Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
2.0.8 fixes this for us. Thanks so much! On Tuesday, September 23, 2014 6:32:55 PM UTC-5, Christian Hammond wrote: Hi Sara, David has a repro case for this now, so we're looking into a fix. There will be a 2.0.8 release tonight. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 3:17:04 PM, Christian Hammond ( chri...@beanbaginc.com javascript:) wrote: Hi Sara, Something that would really help is a complete dump of the request/responses (headers and payloads) for any requests to /api/* in the Network tab of Firefox when these issues occur. I know some information was sent before, but those look to be the Console tab only. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 2:23:34 PM, Christian Hammond ( chri...@beanbaginc.com javascript:) wrote: I wish I knew too... So, for each of these cases, is the only visible error the rsp is null error? This is tricky to diagnose without more direct access to the server. Hoping something will allow me to repro it here. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 1:43:11 PM, Sara Rayburn (sarar...@gmail.com javascript:) wrote: I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn ( sarar...@gmail.com ) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. Good point. I guess it's a problem since before that. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... Tried in most recent Firefox (35), issue remains. 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. I made sure the database encodings were utf8 and even set the encoding for the repository in question to utf8 in the admin repo settings for reviewboard. I added utf8 as the charset in settings_local.py. All of these changes later, I still have the problem. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Nope, no one. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn ( sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. 2) How are you changing the submitter on a review request? We don't have any support for this, without modifying the database. We are in fact modifying the database via the admin tab. 3) The original bug report seemed to have to do with JavaScript errors on uploading diffs, but now it sounds like it's other fields as well? We haven't been able to come up with any working repro case for a diff causing a hang. If that's the true cause of your hangs, we're definitely going to need source files and patch files that consistently reproduce this for our own testing. I will try to provide a broken diff. Can you also answer a few more questions: 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 3) What database server are you using, and which version? mysql 14.14 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com javascript:) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
I wish I knew what this was. We've had three developers run into this bug today alone. It's becoming a real problem for us. More answers to your questions inline below. Sara On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond wrote: Hi Sara, On September 23, 2014 at 11:39:53 AM, Sara Rayburn (sarar...@gmail.com javascript:) wrote: On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian Hammond wrote: Hi Sara, There are several things here that I am very confused about: 1) Can you clarify which part is new since 2.0.7? The subject says 2.0.6. That is weird. I wasn't the original poster. We have only seen the bug since updating to 2.0.7. I know this because we have a request with non-unicode contents that was uploaded before I updated, without problems. Trying to reuse the same patch for an additional review request triggered the same unicode error we saw previously. On September 9th, you posted saying I am having a similar problem after upgrading to 2.0.6. We didn't have a 2.0.7 release until the 15th. Good point. I guess it's a problem since before that. 1) Is this still only happening with Firefox? Yes 2) What version of Firefox? 30 Does 33 work? I haven't had any issues with any recent version... Tried in most recent Firefox (35), issue remains. 4) If MySQL, are the tables set for Unicode? The tables are a mix of latin1 and utf8. Perhaps this is the problem? This is likely to be the cause of at least some of your problems. You'll need to make sure they're all in utf8, otherwise there will be issues even populating the database with non-latin1 text. This can break us in numerous ways. I made sure the database encodings were utf8 and even set the encoding for the repository in question to utf8 in the admin repo settings for reviewboard. I added utf8 as the charset in settings_local.py. All of these changes later, I still have the problem. 5) Are you using any form of proxy server at your company? No. Very vanilla setup on a VM. How about HTTP proxies that the users configure in their browsers? We've seen cases in the past of some proxies messing with the responses from our API. Nope, no one. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 23, 2014 at 10:57:14 AM, Sara Rayburn (sarar...@gmail.com ) wrote: I can also confirm that this is a new bug since 2.0.7. One of the review requests giving us trouble was added before we updated, and when someone tried to change the submitter on the request it seems to have run into the error again. When the same user copied the patch and created a new review request (since they couldn't take ownership of the request) they ran into the unicode bug again. On Tuesday, September 23, 2014 12:51:51 PM UTC-5, Sara Rayburn wrote: Any new information on this bug? We've run into it several times. On Thursday, August 28, 2014 8:09:02 AM UTC-5, koval...@gmail.com wrote: I am using Reviewboard 2.0.6 with Postgres database in utf-8. When I making new pre-commit request on svn-based repository with diff-file containing non-latin symbols, reviewboard hungs. If diff file contains only latin symbols, it works ok. Is it possible to fix this bug? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com . For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http
Re: Git style mercurial diffs with file renames don't work
Done. Note that I was unable to attach the diffs to the bug as Issue attachment quota exceeded but they are very short, and I included the contents. https://code.google.com/p/reviewboard/issues/detail?id=3573thanks=3573ts=1411132852 Thanks. Sara On Friday, September 19, 2014 1:10:12 AM UTC-5, Christian Hammond wrote: Hi Sara, Definitely looks like a bug in how we're representing the revisions. Would you be able to file a bug and provide a full diff (of a trivial file or something) that we can use to reproduce the problem? Thanks, Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On September 16, 2014 at 6:39:26 AM, Sara Rayburn (sarar...@gmail.com javascript:) wrote: Hi, We have a problem where the diff viewer for diffs with rename operations. We use mercurial, and output the diff in git style. Here's a trivial example diff file: diff --git a/include/CCvideo/configUI.H b/include/CCvideo/configUITest.H rename from include/CCvideo/configUI.H rename to include/CCvideo/configUITest.H In the Diff summary section is: include/CCvideo/configUITest.H Was include/CCvideo/configUI.H So I guess the rename works up to a point, but this is the error in the view diff page: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support . With traceback as follows: Traceback (most recent call last): File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/reviews/views.py, line 1088, in create_renderer *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 328, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 369, in _get_requested_diff_file request=self.request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 383, in populate_diff_chunks chunks = generator.get_chunks() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 153, in get_chunks large_data=True) File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 152, in lambda: list(self._get_chunks_uncached()), File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 159, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 169, in get_original_file request=request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 291, in get_file large_data=True)[0] File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 290, in request)], File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 456, in _get_file_uncached data = self.get_scmtool().get_file(path, revision) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 43, in get_file return self.client.cat_file(path, six.text_type(revision)) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 264, in cat_file raise FileNotFoundError(path, rev) FileNotFoundError: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group
Git style mercurial diffs with file renames don't work
Hi, We have a problem where the diff viewer for diffs with rename operations. We use mercurial, and output the diff in git style. Here's a trivial example diff file: diff --git a/include/CCvideo/configUI.H b/include/CCvideo/configUITest.H rename from include/CCvideo/configUI.H rename to include/CCvideo/configUITest.H In the Diff summary section is: include/CCvideo/configUITest.H http://reviewboard.cctechnol.com/r/4112/diff/#0 Was include/CCvideo/configUI.H So I guess the rename works up to a point, but this is the error in the view diff page: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://reviewboard.cctechnol.com/support/. With traceback as follows: Traceback (most recent call last): File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/reviews/views.py, line 1088, in create_renderer *args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 328, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/views.py, line 369, in _get_requested_diff_file request=self.request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 383, in populate_diff_chunks chunks = generator.get_chunks() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 153, in get_chunks large_data=True) File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 152, in lambda lambda: list(self._get_chunks_uncached()), File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/chunk_generator.py, line 159, in _get_chunks_uncached old = get_original_file(self.filediff, self.request, encoding_list) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 169, in get_original_file request=request) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 291, in get_file large_data=True)[0] File /usr/lib/python2.6/site-packages/Djblets-0.8.10-py2.6.egg/djblets/cache/backend.py, line 111, in cache_memoize data = lookup_callable() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 290, in lambda request)], File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/models.py, line 456, in _get_file_uncached data = self.get_scmtool().get_file(path, revision) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 43, in get_file return self.client.cat_file(path, six.text_type(revision)) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.7-py2.6.egg/reviewboard/scmtools/hg.py, line 264, in cat_file raise FileNotFoundError(path, rev) FileNotFoundError: The file 'include/CCvideo/configUI.H' (rUNKNOWN) could not be found in the repository -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi David,
Oddly enough, there is nothing at all in the logs when I try to create the
failed new review request. When I do the same operations in Chrome (where
the diff works just fine), I see
2014-09-11 12:57:32,499 - DEBUG - - DiffParser.parse: Beginning parse of
diff, size = 5408
2014-09-11 12:57:32,503 - DEBUG - - DiffParser.parse: Finished parsing
diff.
2014-09-11 12:57:32,653 - DEBUG - - DiffParser.parse: Beginning parse of
diff, size = 5408
2014-09-11 12:57:32,656 - DEBUG - - DiffParser.parse: Finished parsing
diff.
in the logs. Nothing at all hits the logs using firefox. There are no
errors in the apache logs either.
Sara
On Wednesday, September 10, 2014 4:03:39 PM UTC-5, David Trowbridge wrote:
Sara,
Can you look in the server log and see if there are any tracebacks in
there?
-David
On Wed, Sep 10, 2014 at 5:50 AM, Sara Rayburn sarar...@gmail.com
javascript: wrote:
Christian,
Yes, that was the output from the network tab for the failing new review
request, and the tab was open the whole time. When I create new review
request for that repository with one of the diffs that works, I get these
requests (I may not have caught them all... not familiar with web
debugging):
GET http://reviewboard.cctechnol.com/r/4078/ [HTTP/1.1 200 OK 197ms]
GET http://reviewboard.cctechnol.com/jsi18n/ [HTTP/1.1 200 OK 68ms]
GET http://reviewboard.cctechnol.com/api/review-requests/4078/ [HTTP/1.1
200 OK 109ms]
GET
http://reviewboard.cctechnol.com/static/rb/css/common.min.e6e71be831db.css
[HTTP/1.1 200 OK 12ms]
GET
http://reviewboard.cctechnol.com/static/rb/css/reviews.min.f35ccb97b383.css
We were finally able to narrow down which were the offending characters.
The developer had copied some documentation from a pdf document, and it had
some non-ascii quote marks in it. He corrected the files with the following
perl:
perl -pi -e 's/[[:^ascii:]]//g' filename
Hope that helps.
Sara
On Tuesday, September 9, 2014 4:33:06 PM UTC-5, Christian Hammond wrote:
Hi Sara,
Strange.. Is that output from the Network tab? Was that tab open when
initially making the request?
Christian
--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On September 9, 2014 at 2:30:26 PM, Sara Rayburn (sarar...@gmail.com)
wrote:
Hi Christian,
Well, as it happens, the error only occurs while using Firefox (v.
30). The
user having troubles was relieved to find Chrome as a temporary
workaround.
I was able to unminify the code, but it didn't point me to a specific
line.
Maybe a firefox thing? I looked for a 500 error, but I don't really
even
see a relevant looking request. Here is the log in question, but
there's
not much to it. Clicking on the type error gets the big nasty block
from
before.
GET http://www.gravatar.com/avatar/e3a6e9470514467a04cbc94da028458e
[HTTP/1.1 304 Not Modified 796ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/icons.
2eed2f830119.png
[HTTP/1.1 304 Not Modified 6ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/logo@2x.
4e25cc3cacef.png
[HTTP/1.1 304 Not Modified 6ms]
Use of getPreventDefault() is deprecated. Use defaultPrevented
instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
GET
http://reviewboard.cctechnol.com/static/rb/images/spinner.
73e57937304d.gif
[HTTP/1.1 304 Not Modified 5ms]
The non-standard sendAsBinary method is deprecated and will soon be
removed. Use the standard send(Blob data) method instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
TypeError: rsp is null
On Tuesday, September 9, 2014 4:09:29 PM UTC-5, Christian Hammond
wrote:
Hi Sara,
We minify our files by default, making the context less than useful.
If
you’re using Chrome, you should be able to click the error, see that
big
minified file, and then click the little “{}” at the bottom of the
window.
That will un-minify it, updating the error in the console to point
to the
actual line where things failed. If you could then paste that line
(and the
lines surrounding it), that will help narrow things down.
We are getting ready for Review Board 2.0.7, which will display more
useful errors in the New Review Request page when things go wrong.
Hopefully it will help with this case as well.
It would also be helpful to see the request/response payloads
invoked by
that page, in order to see where things went wrong. I’d expect one
of the
responses will be a HTTP 500.
Christian
--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/
powerpack/
---
Sign up for Review Board hosting at RBCommons: https
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Christian,
Yes, that was the output from the network tab for the failing new review
request, and the tab was open the whole time. When I create new review
request for that repository with one of the diffs that works, I get these
requests (I may not have caught them all... not familiar with web
debugging):
GET http://reviewboard.cctechnol.com/r/4078/ [HTTP/1.1 200 OK 197ms]
GET http://reviewboard.cctechnol.com/jsi18n/ [HTTP/1.1 200 OK 68ms]
GET http://reviewboard.cctechnol.com/api/review-requests/4078/ [HTTP/1.1
200 OK 109ms]
GET
http://reviewboard.cctechnol.com/static/rb/css/common.min.e6e71be831db.css
[HTTP/1.1 200 OK 12ms]
GET
http://reviewboard.cctechnol.com/static/rb/css/reviews.min.f35ccb97b383.css
We were finally able to narrow down which were the offending characters.
The developer had copied some documentation from a pdf document, and it had
some non-ascii quote marks in it. He corrected the files with the following
perl:
perl -pi -e 's/[[:^ascii:]]//g' filename
Hope that helps.
Sara
On Tuesday, September 9, 2014 4:33:06 PM UTC-5, Christian Hammond wrote:
Hi Sara,
Strange.. Is that output from the Network tab? Was that tab open when
initially making the request?
Christian
--
Christian Hammond - chri...@beanbaginc.com javascript:
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On September 9, 2014 at 2:30:26 PM, Sara Rayburn (sarar...@gmail.com
javascript:) wrote:
Hi Christian,
Well, as it happens, the error only occurs while using Firefox (v. 30).
The
user having troubles was relieved to find Chrome as a temporary
workaround.
I was able to unminify the code, but it didn't point me to a specific
line.
Maybe a firefox thing? I looked for a 500 error, but I don't really even
see a relevant looking request. Here is the log in question, but there's
not much to it. Clicking on the type error gets the big nasty block from
before.
GET http://www.gravatar.com/avatar/e3a6e9470514467a04cbc94da028458e
[HTTP/1.1 304 Not Modified 796ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/icons.2eed2f830119.png
[HTTP/1.1 304 Not Modified 6ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/l...@2x.4e25cc3cacef.png
[HTTP/1.1 304 Not Modified 6ms]
Use of getPreventDefault() is deprecated. Use defaultPrevented instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
GET
http://reviewboard.cctechnol.com/static/rb/images/spinner.73e57937304d.gif
[HTTP/1.1 304 Not Modified 5ms]
The non-standard sendAsBinary method is deprecated and will soon be
removed. Use the standard send(Blob data) method instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
TypeError: rsp is null
On Tuesday, September 9, 2014 4:09:29 PM UTC-5, Christian Hammond wrote:
Hi Sara,
We minify our files by default, making the context less than useful.
If
you’re using Chrome, you should be able to click the error, see that
big
minified file, and then click the little “{}” at the bottom of the
window.
That will un-minify it, updating the error in the console to point to
the
actual line where things failed. If you could then paste that line
(and the
lines surrounding it), that will help narrow things down.
We are getting ready for Review Board 2.0.7, which will display more
useful errors in the New Review Request page when things go wrong.
Hopefully it will help with this case as well.
It would also be helpful to see the request/response payloads invoked
by
that page, in order to see where things went wrong. I’d expect one of
the
responses will be a HTTP 500.
Christian
--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google
Groups reviewboard
group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
I am having a similar problem after upgrading to 2.0.6. I do see an error
in my console for url http://reviewboard.cctechnol.com/r/new/. The error
happens after I select a file from browse and try to upload.
TypeError: rsp is null
with the following details:
(function(){RB.PostCommitModel=Backbone.Model.extend({defaults:{repository:null,branch:null}});RB.PreCommitModel=Backbone.Model.extend({defaults:{basedir:null,changeNumber:null,diffFile:null,diffValid:false,error:null,parentDiffFile:null,repository:null,state:0},State:{PROMPT_FOR_DIFF:0,PROMPT_FOR_BASEDIR:1,PROPMT_FOR_CHANGE_NUMBER:2,PROCESSING_DIFF:3,UPLOADING:4,PROMPT_FOR_PARENT_DIFF:5,ERROR:6},initialize:function(){_super(this).initialize.apply(this,arguments);this.on(change:diffFile
change:parentDiffFile change:basedir +change:changeNumber
change:diffValid,this._updateState,this)},startOver:function(){this.set({basedir:null,changeNumber:null,diffFile:null,diffValid:false,error:null,parentDiffFile:null,state:this.State.PROMPT_FOR_DIFF})},_updateState:function(){var
basedir=this.get(basedir),changeNumber=this.get(changeNumber),diff=this.get(diffFile),diffValid=this.get(diffValid),parentDiff=this.get(parentDiffFile),repository=this.get(repository),requiresBasedir=repository.get(requiresBasedir),requiresChangeNumber=repository.get(requiresChangeNumber),state=this.get(state);switch(state){case
this.State.PROMPT_FOR_DIFF:if(diff){if(requiresBasedir!basedir){this.set(state,this.State.PROMPT_FOR_BASEDIR)}else
if(requiresChangeNumber!changeNumber){this.set(state,this.State.PROMPT_FOR_CHANGE_NUMBER)}else{this.set(state,this.State.PROCESSING_DIFF);this._tryValidate()}}break;case
this.State.PROMPT_FOR_PARENT_DIFF:if(diffparentDiff){this.set(state,this.State.PROCESSING_DIFF);this._tryValidate()}break;case
this.State.PROMPT_FOR_BASEDIR:console.assert(diff,cannot be in basedir prompt
state without a
diff);if(basedir){if(requiresChangeNumber!changeNumber){this.set(state,this.State.PROMPT_FOR_CHANGE_NUMBER)}else{this.set(state,this.State.PROCESSING_DIFF);this._tryValidate()}}break;case
this.State.PROMPT_FOR_CHANGE_NUMBER:console.assert(diff,cannot be in
changenum prompt state without a
diff);if(changeNumber){this.set(state,this.State.PROCESSING_DIFF);this._tryValidate()}break;case
this.State.PROCESSING_DIFF:if(diffValid){this.set(state,this.State.UPLOADING);this._createReviewRequest()}break;case
this.State.UPLOADING:break;case
this.State.ERROR:break}},_tryValidate:function(){var
diff=this.get(diffFile),parentDiff=this.get(parentDiffFile),repository=this.get(repository),uploader=new
RB.ValidateDiffModel;this.set(diffValid,false);console.assert(diff);uploader.set({repository:repository.get(id),localSitePrefix:repository.get(localSitePrefix),basedir:this.get(basedir),diff:diff,parentDiff:parentDiff});uploader.save({success:_.bind(this._onValidateSuccess,this),error:_.bind(this._onValidateError,this)})},_onValidateSuccess:function(){this.set(diffValid,true)},_onValidateError:function(model,xhr){var
rsp=$.parseJSON(xhr.responseText),newState=this.State.ERROR,error;switch(rsp.err.code){case
RB.APIErrors.REPO_FILE_NOT_FOUND:if(this.get(repository).get(scmtoolName)===Gitrsp.revision.length!==40){error=gettext(The
uploaded diff uses short revisions, but Review Board requires full
revisions.br /Please generate a new diff using the code--full-index/code
parameter.)}else{error=interpolate(gettext('The file %s (revision %s) was
not found in the
repository.'),[rsp.file,rsp.revision]);if(this.get(parentDiffFile)===null){newState=this.State.PROMPT_FOR_PARENT_DIFF}}break;case
RB.APIErrors.DIFF_PARSE_ERROR:error=rsp.err.msg+br /+Line
+rsp.linenum+:
+rsp.reason;break;default:error=rsp.err.msg;break}if(error){this.set({state:newState,error:error})}},_createReviewRequest:function(){var
repository=this.get(repository),reviewRequest=new
RB.ReviewRequest({commitID:this.get(changeNumber),localSitePrefix:repository.get(localSitePrefix),repository:repository.get(id)});reviewRequest.save({success:function(){var
diff=reviewRequest.createDiff();diff.set({basedir:this.get(basedir),diff:this.get(diffFile),parentDiff:this.get(parentDiffFile)});diff.url=reviewRequest.get(links).diffs.href;diff.save({success:function(){window.location=reviewRequest.get(reviewURL)},error:this._onValidateError},this)},error:this._onValidateError},this)}});RB.NewReviewRequest=Backbone.Model.extend({defaults:{repositories:[]}});RB.CollectionView=Backbone.View.extend({itemViewType:null,initialize:function(options){var
collection=options.collection;this.collection=collection;this.views=[];collection.each(this._add,this);collection.on({add:this._add,remove:this._remove},this)},render:function(){this._rendered=true;this.$el.empty();_.each(this.views,function(view){this.$el.append(view.render().el)},this);return
this},_add:function(item){var
view;console.assert(this.itemViewType,itemViewType must be defined by the
subclass);view=new
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
Hi Christian,
Well, as it happens, the error only occurs while using Firefox (v. 30). The
user having troubles was relieved to find Chrome as a temporary workaround.
I was able to unminify the code, but it didn't point me to a specific line.
Maybe a firefox thing? I looked for a 500 error, but I don't really even
see a relevant looking request. Here is the log in question, but there's
not much to it. Clicking on the type error gets the big nasty block from
before.
GET http://www.gravatar.com/avatar/e3a6e9470514467a04cbc94da028458e
[HTTP/1.1 304 Not Modified 796ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/icons.2eed2f830119.png
[HTTP/1.1 304 Not Modified 6ms]
GET
http://reviewboard.cctechnol.com/static/rb/images/l...@2x.4e25cc3cacef.png
[HTTP/1.1 304 Not Modified 6ms]
Use of getPreventDefault() is deprecated. Use defaultPrevented instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
GET
http://reviewboard.cctechnol.com/static/rb/images/spinner.73e57937304d.gif
[HTTP/1.1 304 Not Modified 5ms]
The non-standard sendAsBinary method is deprecated and will soon be
removed. Use the standard send(Blob data) method instead.
jquery-1.8.2.min.cfa9051cc0b0.js:2
TypeError: rsp is null
On Tuesday, September 9, 2014 4:09:29 PM UTC-5, Christian Hammond wrote:
Hi Sara,
We minify our files by default, making the context less than useful. If
you’re using Chrome, you should be able to click the error, see that big
minified file, and then click the little “{}” at the bottom of the window.
That will un-minify it, updating the error in the console to point to the
actual line where things failed. If you could then paste that line (and the
lines surrounding it), that will help narrow things down.
We are getting ready for Review Board 2.0.7, which will display more
useful errors in the New Review Request page when things go wrong.
Hopefully it will help with this case as well.
It would also be helpful to see the request/response payloads invoked by
that page, in order to see where things went wrong. I’d expect one of the
responses will be a HTTP 500.
Christian
--
Christian Hammond - chri...@beanbaginc.com javascript:
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Error 500 when posting comments
Hi all,
After a reboot of my reviewboard server, I am now getting Error 500
internal server errors any time a user tries to submit a comment on a
review request. I have verified that I can add new review requests, and
perform other edits on those review requests. Here is a sample error:
Traceback (most recent call last):
File
/usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/core/handlers/base.py,
line 112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File
/usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/views/decorators/cache.py,
line 52, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File
/usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/views/decorators/vary.py,
line 19, in inner_func
response = func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/resources.py,
line 494, in __call__
request, method, view, api_format=api_format, *args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/resources.py,
line 565, in call_method_view
return view(request, *args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/resources.py,
line 747, in post
return self.create(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/decorators.py,
line 117, in _call
return view_func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/ReviewBoard-2.0.4-py2.6.egg/reviewboard/webapi/decorators.py,
line 110, in _check
return view_func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/decorators.py,
line 117, in _call
return view_func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/decorators.py,
line 138, in _checklogin
return view_func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/decorators.py,
line 117, in _call
return view_func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/decorators.py,
line 117, in _call
return view_func(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/webapi/decorators.py,
line 287, in _validate
return view_func(*args, **new_kwargs)
File
/usr/lib/python2.6/site-packages/ReviewBoard-2.0.4-py2.6.egg/reviewboard/webapi/resources/base_review.py,
line 169, in create
**self.get_base_reply_to_field(*args, **kwargs))
File
/usr/lib/python2.6/site-packages/Djblets-0.8.7-py2.6.egg/djblets/db/managers.py,
line 53, in get_or_create
return self.get(**kwargs)
File
/usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/db/models/manager.py,
line 151, in get
return self.get_queryset().get(*args, **kwargs)
File
/usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/db/models/query.py,
line 310, in get
self.model._meta.object_name)
DoesNotExist: Review matching query does not exist.
WSGIRequest
path:/api/review-requests/3677/reviews/,
GET:QueryDict: {},
POST:QueryDict: {u'body_top': [u''], u'text_type': [u'plain'],
u'body_bottom': [u''], u'api_format': [u'json'], u'ship_it': [u'false']},
COOKIES:{'collapsediffs': 'True',
'csrftoken': 'v9zdlH2rkdux8ABIrOYXIoEZ3UOY3vB0',
'rbsessionid': '3vha1z6fnrabst0eneet4qjvgjji9b0i'},
META:{'CONTENT_LENGTH': '68',
'CONTENT_TYPE': 'application/x-www-form-urlencoded; charset=UTF-8',
'DOCUMENT_ROOT': '/var/www/reviewboard/htdocs',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT': 'application/json, text/javascript, */*; q=0.01',
'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.5',
'HTTP_CACHE_CONTROL': 'no-cache',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'csrftoken=v9zdlH2rkdux8ABIrOYXIoEZ3UOY3vB0;
rbsessionid=3vha1z6fnrabst0eneet4qjvgjji9b0i; collapsediffs=True',
'HTTP_HOST': 'reviewboard.cctechnol.com',
'HTTP_PRAGMA': 'no-cache',
'HTTP_REFERER': 'http://reviewboard.cctechnol.com/r/3677/diff/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (X11; Linux x86_64; rv:30.0)
Gecko/20100101 Firefox/30.0',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
'PATH_INFO': u'/api/review-requests/3677/reviews/',
'PATH_TRANSLATED':
'/var/www/reviewboard/htdocs/reviewboard.wsgi/api/review-requests/3677/reviews/',
'QUERY_STRING': '',
'REMOTE_ADDR': '10.0.1.85',
'REMOTE_PORT': '57902',
'REQUEST_METHOD': 'POST',
'REQUEST_URI': '/api/review-requests/3677/reviews/',
'SCRIPT_FILENAME': '/var/www/reviewboard/htdocs/reviewboard.wsgi',
'SCRIPT_NAME': u'',
'SERVER_ADDR': '10.0.0.68',
'SERVER_ADMIN': 'root@localhost',
'SERVER_NAME': 'reviewboard.cctechnol.com',
'SERVER_PORT': '80',
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SIGNATURE': 'addressApache/2.2.15 (CentOS) Server at
reviewboard.cctechnol.com
Re: Error 500 when posting comments
Hi Christian, See responses inline. I'm afraid this is a server corruption thing. If that's your opinion, is there some way to repair the db? On Friday, July 25, 2014 2:32:32 PM UTC-5, Christian Hammond wrote: Hi Sara. Some questions for you. When you say a reboot, was it of the full server, or just the web server? Did this include the database server? (What type of database?) Full server reboot, including the db. All requisite services are running, and there is read/write access to the db since we can create/view review requests. When did the upgrade of Review Board to 2.0.4 happen, relative to the reboot? Within a couple of days, however the server VM has been rebooted since the install. (Our VM host keeps dying) I wouldn’t expect these errors unless you had some data corruption somewhere. Was the reboot a clean reboot? This is not out of the question. The server is running in a VM on a dying server. I shutdown the VM to do an emergency back up, and when I relaunched it, all these problems occurred. Are you getting that exact same error traceback for all review requests? Yes, with the exception of the review request number Are you able to see reviews on existing review requests? Yes Can you also make sure that people are actually logged in when posting this? I want to rule out a session-related issue. I'm not sure how to verify this. I have logged out, logged back in, and tried to post. Our site is not public. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Odd behavior and ERROR (EXTERNAL IP) emails
Ok, you can ignore the email question. I sorted that one out. Thanks, Sara On Monday, July 21, 2014 3:51:57 PM UTC-5, Sara Rayburn wrote: Hi, Today one of our users came to me complaining that his review request was stuck as a draft. When he would click Publish a pop-up would appear saying undefined. From the perspective of other users, however, the review request appeared to have been published as expected. He was ultimately able to resolve the issue by clicking Discard, and the review request stayed visible, although the draft and review ordering was mixed up. Shortly after, another of our users received several emails (he was the only one) with the header ERROR (EXTERNAL IP): Internal Server Error: /api/review-requests/3604/draft and a traceback as their contents (See below). Since that review request is the one causing problems, I suspect they are related. I would like to know if this bug was caused by a configuration issue, and also to determine how to ensure that error emails are sent to me, and not just the one user. I poked around on the admin page and in the settings_local.py, but I didn't see anything to make me thing I could control the destination of those emails. Thoughts? Sara Traceback (most recent call last): File /usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/core/handlers/base.py, line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/views/decorators/cache.py, line 52, in _wrapped_view_func response = view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/views/decorators/vary.py, line 19, in inner_func response = func(*args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/resources.py, line 494, in __call__ request, method, view, api_format=api_format, *args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/resources.py, line 565, in call_method_view return view(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/resources.py, line 753, in put return self.update(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.3-py2.6.egg/reviewboard/webapi/decorators.py, line 110, in _check return view_func(*args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/decorators.py, line 138, in _checklogin return view_func(*args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/lib/python2.6/site-packages/Djblets-0.8.6-py2.6.egg/djblets/webapi/decorators.py, line 287, in _validate return view_func(*args, **new_kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.3-py2.6.egg/reviewboard/webapi/resources/review_request_draft.py, line 394, in update review_request.publish(user=request.user) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.3-py2.6.egg/reviewboard/reviews/models/review_request.py, line 716, in publish changes = draft.publish(self, send_notification=False) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.3-py2.6.egg/reviewboard/reviews/models/review_request_draft.py, line 318, in publish review_request.save() File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.3-py2.6.egg/reviewboard/reviews/models/review_request.py, line 581, in save super(ReviewRequest, self).save(**kwargs) File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.3-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py, line 258, in save super(BaseReviewRequestDetails, self).save(**kwargs) File /usr/lib/python2.6/site-packages/Django-1.6.5-py2.6.egg/django/db/models/base.py, line 545, in save force_update=force_update, update_fields=update_fields) span style=color: rgb(46, 52, 54); font-family: Monospace; font- ... -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard
Re: Unable to installing Extensions on RB 2.0.3
I am getting the same errors as MoonWalker. On Tuesday, July 15, 2014 6:29:14 PM UTC-5, MoonWalker wrote: I am using RB 2.0.3 and I tried to install the following extensions but seems like they are not available (easy_install is not able to find them) , am I missing something here? https://www.reviewboard.org/store/products/6/ https://www.reviewboard.org/store/products/2/ -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https
Re: Unable to use New Review Request to create requests with parent diffs
Hi Christian, All of our repos are mercurial repos. An example Path would be /data_local/hg-repository/foo. The mirror path is unused and unconfigured in all cases. We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond christ...@beanbaginc.com wrote: What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote: Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails
Re: Unable to use New Review Request to create requests with parent diffs
That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the setup-repo command fails. I'm not worried about it on our end. On Tue, Jun 17, 2014 at 2:42 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Sara, Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case where the paths more or less match up. If your Path or Mirror Path looked like the ssh:// URL, they would have been found. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 12:28:30 PM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi Christian, All of our repos are mercurial repos. An example Path would be /data_local/hg-repository/foo. The mirror path is unused and unconfigured in all cases. We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond christ...@beanbaginc.com wrote: What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote: Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You
Re: Unable to use New Review Request to create requests with parent diffs
Hi Bruce, Nowhere does that documentation refer to the fact that setup-repo will often fail with less than useful errors. I think that the error should be more useful (error 500 is not super helpful for the person trying to run the setup command) and that the docs should mention that setup-repo is only for the basic case, and explicitly state that you should custom configure in more unusual cases. I mean, we figured it out, so the info is there, I just think it could be clearer. Anyway, it seems to be working for me on all of my projects, and it's working for all of the window's developers. A couple of our programmers are still having problems, but I'm not sure if that's bugs or user error. If they aren't able to resolve their issues I'll post again with details. Sara On Tue, Jun 17, 2014 at 3:42 PM, Bruce Cran bruce.c...@gmail.com wrote: Isn't this covered in http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ? -- Bruce On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn sararayb...@gmail.com wrote: That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the setup-repo command fails. I'm not worried about it on our end. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. Thanks, Sara On Thursday, June 12, 2014 7:44:39 PM UTC-5, David Trowbridge wrote: Sara, Is the reluctance just that installing python stuff on Windows is hard, or are there other concerns? It might be nice to add parent diff support to the New Review Request page, but we'd need to do some redesign to fit it in with the new workflow, which is really designed to handle basic cases very quickly, and defer complex cases to rbtools. -David On Thu, Jun 12, 2014 at 8:40 AM, Sara Rayburn sarar...@gmail.com javascript: wrote: Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create reviews with parent diffs? The windows developers in our group would prefer not to install RB Tools and all of its dependencies. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Unable to use New Review Request to create requests with parent diffs
Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create reviews with parent diffs? The windows developers in our group would prefer not to install RB Tools and all of its dependencies. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.x and hg postreview
Hi Bruce, Most of the developers at my company are still using postreview with RB 2.0. We've always seen the error you reported in the bug, both with and without postreview. It seems to be a reviewboard issue. As a workaround, you might be able to make your parent diff include more changesets. The trick is that all of the changed files in your diff must be referenced in the parent diff as well. Hope that helps. Sara On Monday, June 2, 2014 1:22:09 PM UTC-5, Bruce Cran wrote: I'm investigating upgrading our installation to Review Board 2.x and one issue I've come across is that with the existing code, hg postreview doesn't work correctly. I've submitted a ticket to https://bitbucket.org/ccaughie/hgreviewboard https://www.google.com/url?q=https%3A%2F%2Fbitbucket.org%2Fccaughie%2Fhgreviewboardsa=Dsntz=1usg=AFQjCNE34g4wW_nHHVDDE-wLzYYOHMTp6w, but I was wondering - are people still planning to use the hg postreview extension, or are you all switching to the rbt client? -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Failed upgrade from 1.7.x to 2.0, Error 500
After updating from 1.7.2x to 2.0, my users get occasional error 500 messages. The site seems to be down more often than it is up. I have no errors in my reviewboard logs or my httpd logs. My update process was as follows: easy_install -U ReviewBoard rb-site upgrade /var/www/reviewboard service httpd restart service memcached restart The only oddity I encountered during the process was a message from rb-site suggesting that I run condensediffs, which subsequently failed. Where should I look for hints abount what might be broken here? Sara -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Failed upgrade from 1.7.x to 2.0, Error 500
Hi Christian, Looking further, I was getting some errors about incompatibility between mod_wsgi and python. After updating mod_python and mod_wsgi, this is the error I'm left with: [Fri May 23 17:51:49 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 17:51:49 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) It seems related to this posted problem: https://groups.google.com/forum/#!topic/reviewboard/lbhUHuPDgQA I'm using: Django 1.6.5 Python 2.6.6 MySQL Apache config is as follows: VirtualHost *:80 ServerName reviewboard.cctechnol.com DocumentRoot /var/www/reviewboard/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html WSGIPassAuthorization On WSGIScriptAlias / /var/www/reviewboard/htdocs/reviewboard.wsgi/ Directory /var/www/reviewboard/htdocs AllowOverride All Options -Indexes FollowSymLinks Allow from all /Directory # Alias static media requests to filesystem Location /static SetHandler None /Location Alias /static /var/www/reviewboard/htdocs/static Alias /media /var/www/reviewboard/htdocs/media Alias /errordocs /var/www/reviewboard/htdocs/errordocs Alias /favicon.ico /var/www/reviewboard/htdocs/media/rbcommons/images/favicon.png /VirtualHost On Friday, May 23, 2014 12:41:05 PM UTC-5, Christian Hammond wrote: That's certainly not normal. Can you provide the error logs from reviewboard.log? I also need to know everything you can tell me about your configuration. Versions, software, database type, Apache config, whether you use mod_worker, etc. Christian On Friday, May 23, 2014, Sara Rayburn sarar...@gmail.com javascript: wrote: After updating from 1.7.2x to 2.0, my users get occasional error 500 messages. The site seems to be down more often than it is up. I have no errors in my reviewboard logs or my httpd logs. My update process was as follows: easy_install -U ReviewBoard rb-site upgrade /var/www/reviewboard service httpd restart service memcached restart The only oddity I encountered during the process was a message from rb-site suggesting that I run condensediffs, which subsequently failed. Where should I look for hints abount what might be broken here? Sara -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Failed upgrade from 1.7.x to 2.0, Error 500
I wish I had more information to give you, it doesn't seem like anything specific happens to make it work or fail. Here's my apache error_log since the last httpd restart. It seems like after restarting httpd, it takes a long time (~10 minutes) before we get anything besides the error 500. Once it's up, I've been able to look at a few diffs, but within a few minutes it's producing error 500 messages again. [Fri May 23 13:32:51 2014] [notice] caught SIGTERM, shutting down [Fri May 23 13:33:01 2014] [notice] suEXEC mechanism enabled (wrapper: /usr/sbin/suexec) [Fri May 23 13:33:01 2014] [notice] Digest: generating secret for digest authentication ... [Fri May 23 13:33:01 2014] [notice] Digest: done [Fri May 23 13:33:01 2014] [notice] mod_python: Creating 4 session mutexes based on 256 max processes and 0 max threads. [Fri May 23 13:33:01 2014] [notice] mod_python: using mutex_directory /tmp [Fri May 23 13:33:02 2014] [notice] Apache/2.2.15 (Unix) DAV/2 mod_python/3.3.1 Python/2.6.6 mod_wsgi/3.2 configured -- resuming normal operations [Fri May 23 18:33:34 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:33:34 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:33:44 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:33:44 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:33:47 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:33:47 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:33:51 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:33:51 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:34:10 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:34:10 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:34:29 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:34:29 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:35:09 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:35:09 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) [Fri May 23 18:35:43 2014] [error] /usr/lib/python2.6/site-packages/Djblets-0.8-py2.6.egg/djblets/util/fields.py:11: DeprecationWarning: djblets.util.fields is deprecated. Use djblets.db.fields instead. [Fri May 23 18:35:43 2014] [error] 'djblets.db.fields instead.', DeprecationWarning) Here's the last 30 minutes or so of my reviewboard.log, too. 2014-05-23 18:16:46,636 - DEBUG - None - jdmeador - /r/3170/fragments/diff-comments/23903/ - Patching file library/ccscm-vc-modbus/plcModbus.C took 0.047194 seconds 2014-05-23 18:16:47,057 - DEBUG - None - jdmeador - /r/3170/fragments/diff-comments/23903/ - Begin: Generating diff chunks for self.filediff id 63371 (library/ccscm-vc-modbus/plcModbus.C) 2014-05-23 18:16:47,081 - DEBUG - None - jdmeador - /r/3170/fragments/diff-comments/23903/ - End: Generating diff chunks for self.filediff id 63371 (library/ccscm-vc-modbus/plcModbus.C) 2014-05-23 18:16:47,082 - DEBUG - None - jdmeador - /r/3170/fragments/diff-comments/23903/ - Generating diff chunks for self.filediff id 63371 (library/ccscm-vc-modbus/plcModbus.C) took 0.024082 seconds 2014-05-23 18:31:18,805 - DEBUG - - User is trying to log in via AD 2014-05-23 18:31:18,813 - DEBUG - - Search root dc=cctechnol,dc=com 2014-05-23 18:31:44,420 - DEBUG - - User is trying to log in via AD 2014-05-23 18:31:44,471 - WARNING - - Active Directory: Failed login for user alrichard 2014-05-23 18:31:51,550 - DEBUG - - User is trying to log in via AD 2014-05-23 18:31:51,556 - DEBUG - - Search root dc=cctechnol,dc=com 2014-05-23 18:32:28,702 - DEBUG - None - mpscherer - /r/3186/diff/ - Generating diff viewer page for filediff id 5257 2014-05-23 18:32:29,023 - DEBUG - None - mpscherer - /r/3186/diff/ - Begin: Generating diff file info for diffset id 5257 2014-05-23 18:32:29,182 - DEBUG - None - mpscherer - /r/3186/diff/ -
Re: Failed upgrade from 1.7.x to 2.0, Error 500
There are no other services. This is running on a VM dedicated solely to hosting reviewboard. I disabled mod_python and I am having the same problem. I was using mod_wsgi both before and after, although mod_python was not disabled. serayburn@reviewboard httpd -v Server version: Apache/2.2.15 (Unix) Server built: Apr 3 2014 23:56:16 I installed reviewboard quite a while ago via easy_install. I see that there is a package available for el6 now. Do you think it is worthwhile to try that instead? If I do, how do I maintain my database? When I query the package installer, there are quite a few packages requiring update if I go that route, so maybe there's something I'm missing. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Failed upgrade from 1.7.x to 2.0, Error 500
oops. here's the httpd -V output, I'll try the debug configuration next. serayburn@reviewboard httpd -V Server version: Apache/2.2.15 (Unix) Server built: Apr 3 2014 23:56:16 Server's Module Magic Number: 20051115:25 Server loaded: APR 1.3.9, APR-Util 1.3.9 Compiled using: APR 1.3.9, APR-Util 1.3.9 Architecture: 64-bit Server MPM: Prefork threaded: no forked: yes (variable process count) Server compiled with -D APACHE_MPM_DIR=server/mpm/prefork -D APR_HAS_SENDFILE -D APR_HAS_MMAP -D APR_HAVE_IPV6 (IPv4-mapped addresses enabled) -D APR_USE_SYSVSEM_SERIALIZE -D APR_USE_PTHREAD_SERIALIZE -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT -D APR_HAS_OTHER_CHILD -D AP_HAVE_RELIABLE_PIPED_LOGS -D DYNAMIC_MODULE_LIMIT=128 -D HTTPD_ROOT=/etc/httpd -D SUEXEC_BIN=/usr/sbin/suexec -D DEFAULT_PIDLOG=run/httpd.pid -D DEFAULT_SCOREBOARD=logs/apache_runtime_status -D DEFAULT_LOCKFILE=logs/accept.lock -D DEFAULT_ERRORLOG=logs/error_log -D AP_TYPES_CONFIG_FILE=conf/mime.types -D SERVER_CONFIG_FILE=conf/httpd.conf On Friday, May 23, 2014 2:18:59 PM UTC-5, Christian Hammond wrote: Hi Sara, I'll need the full information from httpd -V. Several pieces in there are useful, though the most crucial to see are the Server MPM and the few lines below that. The database should remain unaffected if you upgrade the package. I wouldn't expect a problem there. However, mixing RPMs and the easy_install'd version could result in conflicting packages installed. Something to try temporarily is to set the following in your $sitedir/conf/settings_local.py: DEBUG = True Then reload Apache and try to reproduce. When it fails, you should hopefully see a full error page with a lot of details. Save the HTML for that and e-mail it to me (privately). If you see a generic 500 without any extra debug information, then the problem is below the Review Board layer, but I suspect there will be something useful in there. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Fri, May 23, 2014 at 12:13 PM, Sara Rayburn sarar...@gmail.comjavascript: wrote: There are no other services. This is running on a VM dedicated solely to hosting reviewboard. I disabled mod_python and I am having the same problem. I was using mod_wsgi both before and after, although mod_python was not disabled. serayburn@reviewboard httpd -v Server version: Apache/2.2.15 (Unix) Server built: Apr 3 2014 23:56:16 I installed reviewboard quite a while ago via easy_install. I see that there is a package available for el6 now. Do you think it is worthwhile to try that instead? If I do, how do I maintain my database? When I query the package installer, there are quite a few packages requiring update if I go that route, so maybe there's something I'm missing. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Failed upgrade from 1.7.x to 2.0, Error 500
I've emailed you the detailed error 500 page generated. On Friday, May 23, 2014 2:21:03 PM UTC-5, Sara Rayburn wrote: oops. here's the httpd -V output, I'll try the debug configuration next. serayburn@reviewboard httpd -V Server version: Apache/2.2.15 (Unix) Server built: Apr 3 2014 23:56:16 Server's Module Magic Number: 20051115:25 Server loaded: APR 1.3.9, APR-Util 1.3.9 Compiled using: APR 1.3.9, APR-Util 1.3.9 Architecture: 64-bit Server MPM: Prefork threaded: no forked: yes (variable process count) Server compiled with -D APACHE_MPM_DIR=server/mpm/prefork -D APR_HAS_SENDFILE -D APR_HAS_MMAP -D APR_HAVE_IPV6 (IPv4-mapped addresses enabled) -D APR_USE_SYSVSEM_SERIALIZE -D APR_USE_PTHREAD_SERIALIZE -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT -D APR_HAS_OTHER_CHILD -D AP_HAVE_RELIABLE_PIPED_LOGS -D DYNAMIC_MODULE_LIMIT=128 -D HTTPD_ROOT=/etc/httpd -D SUEXEC_BIN=/usr/sbin/suexec -D DEFAULT_PIDLOG=run/httpd.pid -D DEFAULT_SCOREBOARD=logs/apache_runtime_status -D DEFAULT_LOCKFILE=logs/accept.lock -D DEFAULT_ERRORLOG=logs/error_log -D AP_TYPES_CONFIG_FILE=conf/mime.types -D SERVER_CONFIG_FILE=conf/httpd.conf On Friday, May 23, 2014 2:18:59 PM UTC-5, Christian Hammond wrote: Hi Sara, I'll need the full information from httpd -V. Several pieces in there are useful, though the most crucial to see are the Server MPM and the few lines below that. The database should remain unaffected if you upgrade the package. I wouldn't expect a problem there. However, mixing RPMs and the easy_install'd version could result in conflicting packages installed. Something to try temporarily is to set the following in your $sitedir/conf/settings_local.py: DEBUG = True Then reload Apache and try to reproduce. When it fails, you should hopefully see a full error page with a lot of details. Save the HTML for that and e-mail it to me (privately). If you see a generic 500 without any extra debug information, then the problem is below the Review Board layer, but I suspect there will be something useful in there. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Fri, May 23, 2014 at 12:13 PM, Sara Rayburn sarar...@gmail.comwrote: There are no other services. This is running on a VM dedicated solely to hosting reviewboard. I disabled mod_python and I am having the same problem. I was using mod_wsgi both before and after, although mod_python was not disabled. serayburn@reviewboard httpd -v Server version: Apache/2.2.15 (Unix) Server built: Apr 3 2014 23:56:16 I installed reviewboard quite a while ago via easy_install. I see that there is a package available for el6 now. Do you think it is worthwhile to try that instead? If I do, how do I maintain my database? When I query the package installer, there are quite a few packages requiring update if I go that route, so maybe there's something I'm missing. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Failed upgrade from 1.7.x to 2.0, Error 500
Hi Christian, Thanks for your help, I think I've fixed it. I still had a beta version of the PowerPack installed. Uninstalling that seems to have corrected our issues. Sara -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
