review from multiple changelists/sources?

['Steve Summit' via Review Board Community]

Reviewboard newbie here; apologies if this is a frequent or ill-advised 
question.

I've got a reviewboard server running, I've successfully installed RBTools, 
I've successfully run rbt setup-repo to hook reviewboard up to my Perforce 
server.  And I've successfully used rbt post to create a review from a 
Perforce changelist.

My question is, how can I create a single review encompassing multiple 
changelists or other sources?

I've tried rbt -u, but that seems to throw away the previous changelist's 
diffs and replace them with a new set.

I've tried rbt post changelist1 changelist2, but that seems to build a 
review from a whole range of changelists, not just changelist1 and 
changelist2.

This may not be possible, but I *really want* to do it, and if it's the 
wrong thing to want, I'm curious to know why, because it probably means 
that my mental model of how to use reviewboard effectively is wrong.

In a possibly-related question, I tried to add a file (a text fine 
containing design notes) to my review using the instructions under the 
"posting paths" section in the rbt post documentation.  I discovered two 
things:

   1. Evidently I can't add an arbitrary file; I can only add a file that's 
   checked in to Perforce.
   2. Evidently I can't add a file to an existing review: if I use rbt post 
   -u //path/to/file, I get a new review; it doesn't add to an old one.

Again, I may be going about this all wrong.  Enlightenment appreciated.

reviewboard 2.5.10 running on the server.  RBTools version 1.0.3.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/fabe0055-d80d-483f-bea8-a8811616b588n%40googlegroups.com.

Re: Page rendering and default route

[Steve]

I've tried the four keys below including values for these keys that are 
incorrect just to try and get a different result but is always the same. 
whether I list-siteconfig or try and set 'site_media_url' to '/media/' or 
any other keys, this error below is persistent. Cant seem to get past it.

Interestingly the response says "if set" does that mean I can remove it 
temporarily.



svnadmin@NEO-SVN-SVR:~$ sudo rb-site manage /var/www/reviewboard 
set-siteconfig -- --key=site_media_url --value=/media/
Traceback (most recent call last):
  File "/usr/local/bin/rb-site", line 11, in 
load_entry_point('ReviewBoard==3.0.15', 'console_scripts', 'rb-site')()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/cmdline/rbsite.py",
 
line 1972, in main
command.run()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/cmdline/rbsite.py",
 
line 1881, in run
initialize()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/__init__.py",
 
line 114, in initialize
load_site_config()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/admin/siteconfig.py",
 
line 294, in load_site_config
apply_django_settings(siteconfig, settings_map)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
 
line 326, in apply_django_settings
setter(settings, setting_key, value)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", 
line 242, in __setattr__
setattr(self._wrapped, name, value)
  File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
line 110, in __setattr__
raise ImproperlyConfigured("If set, %s must end with a slash" % name)
django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
with a slash





On Thursday, 11 July 2019 10:36:32 UTC+1, Christian Hammond wrote:
>
> Hi Steve,
>
> You need to set the following using set-siteconfig:
>
> site_media_url=/media/
> site_static_url=/static/
> site_static_root=/var/www/reviewboard/htdocs/static/
> site_media_root=/var/www/reviewboard/htdocs/media/
>
> I think from the example you gave, you're mixing up the site roots and 
> URLs.
>
> Sorry I haven't gotten back to you until now. Our paid support channel 
> takes a lot of my support time these days.
>
> Christian
>
> On Thu, Jul 11, 2019 at 1:56 AM Steve > 
> wrote:
>
>> Hi Christian,
>>
>> Any thoughts on getting past this error. Can I remove MEDIA_URL and add 
>> it back once I understand the problem.
>>
>>
>>
>> Steve.
>>
>>
>>
>> On Monday, 1 July 2019 10:02:52 UTC+1, Steve wrote:
>>>
>>> Just comes back with the same error message below about " If set, 
>>> MEDIA_URL must end with a slash". Doesn't seem to be able to get past the 
>>> error.
>>>
>>>
>>> Steve.
>>>
>>>
>>>
>>> On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>>>>
>>>> These settings are stored in the database. What’s happening when you 
>>>> run list-siteconfig?
>>>>
>>>> Christian
>>>>
>>>>
>>>> On Sat, Jun 29, 2019 at 01:53 Steve  wrote:
>>>>
>>>>> The test site I created within 3.0..showed the same as you describe so 
>>>>> I tried /static/ and /media/ but still get the same error message. 
>>>>> Trouble 
>>>>> is I now cant run list-siteconfig on the site i'm upgrading so cant check 
>>>>> other settings for conflicts. What settings should I set that relate to 
>>>>> domain, only I cant see anything in the test site that would give me a 
>>>>> clue. Or are we talking about settings in another file.
>>>>>
>>>>>
>>>>> Steve.
>>>>>
>>>>>
>>>>>  
>>>>>
>>>>> On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>>>>>>
>>>>>> Hi Steve,
>>>>>>
>>>>>> The URL parameters are used to build the URLs to media files. They 
>>>>>> must be a path relative to the domain, or the absolute path to a server 
>>>>>> (CDN) serving the files. You’re going to want to only set the “root” 
>>>>>> equivalents.
>>>>>>
>>>>>> Try setting site_static_url to /static/ and site_media_url to /media/.
>>>>>>
>>>>&

Re: Page rendering and default route

[Steve]

Hi Christian,

Any thoughts on getting past this error. Can I remove MEDIA_URL and add it 
back once I understand the problem.



Steve.



On Monday, 1 July 2019 10:02:52 UTC+1, Steve wrote:
>
> Just comes back with the same error message below about " If set, 
> MEDIA_URL must end with a slash". Doesn't seem to be able to get past the 
> error.
>
>
> Steve.
>
>
>
> On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>>
>> These settings are stored in the database. What’s happening when you run 
>> list-siteconfig?
>>
>> Christian
>>
>>
>> On Sat, Jun 29, 2019 at 01:53 Steve  wrote:
>>
>>> The test site I created within 3.0..showed the same as you describe so I 
>>> tried /static/ and /media/ but still get the same error message. Trouble is 
>>> I now cant run list-siteconfig on the site i'm upgrading so cant check 
>>> other settings for conflicts. What settings should I set that relate to 
>>> domain, only I cant see anything in the test site that would give me a 
>>> clue. Or are we talking about settings in another file.
>>>
>>>
>>> Steve.
>>>
>>>
>>>  
>>>
>>> On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>>>>
>>>> Hi Steve,
>>>>
>>>> The URL parameters are used to build the URLs to media files. They must 
>>>> be a path relative to the domain, or the absolute path to a server (CDN) 
>>>> serving the files. You’re going to want to only set the “root” equivalents.
>>>>
>>>> Try setting site_static_url to /static/ and site_media_url to /media/.
>>>>
>>>> Christian
>>>>
>>>>
>>>> On Thu, Jun 27, 2019 at 05:03 Steve  wrote:
>>>>
>>>>> re-set site_media_root and tried again but still the same issue.
>>>>>
>>>>> re-set site_static_url and then tried site_madia_url but keep getting 
>>>>> this back
>>>>>
>>>>>
>>>>>
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>>>>  
>>>>> line 326, in apply_django_settings
>>>>> setter(settings, setting_key, value)
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>>>>> 242, in __setattr__
>>>>> setattr(self._wrapped, name, value)
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", line 
>>>>> 110, 
>>>>> in __setattr__
>>>>> raise ImproperlyConfigured("If set, %s must end with a slash" % 
>>>>> name)
>>>>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must 
>>>>> end with a slash
>>>>>
>>>>>
>>>>> svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
>>>>> /var/www/reviewboard set-siteconfig -- --key=site_media_url 
>>>>> --value=/var/www/reviewboard/htdocs/media/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> can't seem to get a list-siteconfig without the same error.
>>>>>
>>>>>
>>>>> Steve.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>>>>>>
>>>>>> You can use the set-siteconfig management command, like so:
>>>>>>
>>>>>> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
>>>>>> --value=...
>>>>>>
>>>>>> Note the -- before the first flag. This is currently necessary for 
>>>>>> ensuring the arguments are passed to set-siteconfig and not rb-site.
>>>>>>
>>>>>> Christian
>>>>>>
>>>>>>
>>>>>> -- 
>>>>> Supercharge your Review Board with Power Pack: 
>>>>> https://www.reviewboard.org/powerpack/
>>>>> Want us to host Review Board for you? Check out RBCommons: 
>>>>> https://rbcommons.com/
>>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>>> ---

Re: Page rendering and default route

[Steve]

Just comes back with the same error message below about " If set, MEDIA_URL 
must end with a slash". Doesn't seem to be able to get past the error.


Steve.



On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>
> These settings are stored in the database. What’s happening when you run 
> list-siteconfig?
>
> Christian
>
>
> On Sat, Jun 29, 2019 at 01:53 Steve > 
> wrote:
>
>> The test site I created within 3.0..showed the same as you describe so I 
>> tried /static/ and /media/ but still get the same error message. Trouble is 
>> I now cant run list-siteconfig on the site i'm upgrading so cant check 
>> other settings for conflicts. What settings should I set that relate to 
>> domain, only I cant see anything in the test site that would give me a 
>> clue. Or are we talking about settings in another file.
>>
>>
>> Steve.
>>
>>
>>  
>>
>> On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>>>
>>> Hi Steve,
>>>
>>> The URL parameters are used to build the URLs to media files. They must 
>>> be a path relative to the domain, or the absolute path to a server (CDN) 
>>> serving the files. You’re going to want to only set the “root” equivalents.
>>>
>>> Try setting site_static_url to /static/ and site_media_url to /media/.
>>>
>>> Christian
>>>
>>>
>>> On Thu, Jun 27, 2019 at 05:03 Steve  wrote:
>>>
>>>> re-set site_media_root and tried again but still the same issue.
>>>>
>>>> re-set site_static_url and then tried site_madia_url but keep getting 
>>>> this back
>>>>
>>>>
>>>>
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>>>  
>>>> line 326, in apply_django_settings
>>>> setter(settings, setting_key, value)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>>>> 242, in __setattr__
>>>> setattr(self._wrapped, name, value)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", line 
>>>> 110, 
>>>> in __setattr__
>>>> raise ImproperlyConfigured("If set, %s must end with a slash" % 
>>>> name)
>>>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
>>>> with a slash
>>>>
>>>>
>>>> svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
>>>> /var/www/reviewboard set-siteconfig -- --key=site_media_url 
>>>> --value=/var/www/reviewboard/htdocs/media/
>>>>
>>>>
>>>>
>>>>
>>>> can't seem to get a list-siteconfig without the same error.
>>>>
>>>>
>>>> Steve.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>>>>>
>>>>> You can use the set-siteconfig management command, like so:
>>>>>
>>>>> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
>>>>> --value=...
>>>>>
>>>>> Note the -- before the first flag. This is currently necessary for 
>>>>> ensuring the arguments are passed to set-siteconfig and not rb-site.
>>>>>
>>>>> Christian
>>>>>
>>>>>
>>>>> -- 
>>>> Supercharge your Review Board with Power Pack: 
>>>> https://www.reviewboard.org/powerpack/
>>>> Want us to host Review Board for you? Check out RBCommons: 
>>>> https://rbcommons.com/
>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "Review Board Community" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to revie...@googlegroups.com.
>>>> To view this discussion on the web visit 
>>>> https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com
>>>>  
>>>> <https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com?utm_medium=email_source=foote

Re: Page rendering and default route

[Steve]

The test site I created within 3.0..showed the same as you describe so I 
tried /static/ and /media/ but still get the same error message. Trouble is 
I now cant run list-siteconfig on the site i'm upgrading so cant check 
other settings for conflicts. What settings should I set that relate to 
domain, only I cant see anything in the test site that would give me a 
clue. Or are we talking about settings in another file.


Steve.


 

On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>
> Hi Steve,
>
> The URL parameters are used to build the URLs to media files. They must be 
> a path relative to the domain, or the absolute path to a server (CDN) 
> serving the files. You’re going to want to only set the “root” equivalents.
>
> Try setting site_static_url to /static/ and site_media_url to /media/.
>
> Christian
>
>
> On Thu, Jun 27, 2019 at 05:03 Steve > 
> wrote:
>
>> re-set site_media_root and tried again but still the same issue.
>>
>> re-set site_static_url and then tried site_madia_url but keep getting 
>> this back
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>  
>> line 326, in apply_django_settings
>> setter(settings, setting_key, value)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>> 242, in __setattr__
>> setattr(self._wrapped, name, value)
>>   File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
>> line 110, in __setattr__
>> raise ImproperlyConfigured("If set, %s must end with a slash" % name)
>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
>> with a slash
>>
>>
>> svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
>> /var/www/reviewboard set-siteconfig -- --key=site_media_url 
>> --value=/var/www/reviewboard/htdocs/media/
>>
>>
>>
>>
>> can't seem to get a list-siteconfig without the same error.
>>
>>
>> Steve.
>>
>>
>>
>>
>>
>>
>>
>> On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>>>
>>> You can use the set-siteconfig management command, like so:
>>>
>>> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
>>> --value=...
>>>
>>> Note the -- before the first flag. This is currently necessary for 
>>> ensuring the arguments are passed to set-siteconfig and not rb-site.
>>>
>>> Christian
>>>
>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com?utm_medium=email_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/74f2e570-c63a-49d0-a80f-e39966539536%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

re-set site_media_root and tried again but still the same issue.

re-set site_static_url and then tried site_madia_url but keep getting this 
back



  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
 
line 326, in apply_django_settings
setter(settings, setting_key, value)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", 
line 242, in __setattr__
setattr(self._wrapped, name, value)
  File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
line 110, in __setattr__
raise ImproperlyConfigured("If set, %s must end with a slash" % name)
django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
with a slash


svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
/var/www/reviewboard set-siteconfig -- --key=site_media_url 
--value=/var/www/reviewboard/htdocs/media/




can't seem to get a list-siteconfig without the same error.


Steve.







On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>
> You can use the set-siteconfig management command, like so:
>
> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
> --value=...
>
> Note the -- before the first flag. This is currently necessary for 
> ensuring the arguments are passed to set-siteconfig and not rb-site.
>
> Christian
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

Also console log.

(index):28 GET 
http://10.132.40.199/reviewboard/static/rb/css/common.min.4a69e5741dc4.css 
net::ERR_ABORTED 404 (NOT FOUND)
(index):52 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-migrate-1.2.1.min.eb05d8d73b5b.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):256 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-ui-1.8.24.custom.min.f6148fb67d77.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):258 GET 
http://10.132.40.199/reviewboard/static/lib/js/3rdparty.min.1719e20827dd.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):259 GET 
http://10.132.40.199/reviewboard/static/djblets/js/jquery.gravy.min.e24d040808fd.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):260 GET 
http://10.132.40.199/reviewboard/static/djblets/js/utils.min.84b7b8c324db.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):261 GET 
http://10.132.40.199/reviewboard/static/djblets/js/extensions.min.1d8986b3c3cd.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):100 GET 
http://10.132.40.199/reviewboard/static/rb/images/logo.cc81d3ae01b2.png 404 
(NOT FOUND)
(index):51 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-1.11.1.min.8101d596b2b8.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):52 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-migrate-1.2.1.min.eb05d8d73b5b.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):262 GET 
http://10.132.40.199/reviewboard/static/rb/js/base.min.af574b99af97.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):256 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-ui-1.8.24.custom.min.f6148fb67d77.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):258 GET 
http://10.132.40.199/reviewboard/static/lib/js/3rdparty.min.1719e20827dd.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):259 GET 
http://10.132.40.199/reviewboard/static/djblets/js/jquery.gravy.min.e24d040808fd.js
 
404 (NOT FOUND)
(index):260 GET 
http://10.132.40.199/reviewboard/static/djblets/js/utils.min.84b7b8c324db.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):261 GET 
http://10.132.40.199/reviewboard/static/djblets/js/extensions.min.1d8986b3c3cd.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):262 GET 
http://10.132.40.199/reviewboard/static/rb/js/base.min.af574b99af97.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):264 Uncaught ReferenceError: RB is not defined
at (index):264
(anonymous) @ (index):264






On Thursday, 27 June 2019 10:19:58 UTC+1, Steve wrote:
>
> Hi Christian,
>
> Hm, the paths seem to have old references as well as new. site_media_root 
> is definitely a throw back from the original install. Originally 
> reviewboard was running on Gentoo and I created a working clone under 
> Ubuntu with a reviewboard default directory structure. All seemed to work 
> fine until the upgrade from 1.6.. to 3.0.. At that point the directory 
> structure changed so I assume these paths are not part of the upgrade 
> process.
>
> "logging_directory": "/var/log/reviewboard"
> "site_media_root": "/var/www/localhost/htdocs/reviewboard/htdocs/media",
> "site_static_root": "/var/www/reviewboard/htdocs/static",
> "site_static_url": "/reviewboard/static/",
> "site_media_url": "/reviewboard/media/",
>
> Where can I modify these.
>
> 
>
> DEBUG = False
>
>
> Steve.
>
>
>
>
> On Thursday, 27 June 2019 01:04:29 UTC+1, Christian Hammond wrote:
>>
>> Hi,
>>
>> Can you show me one of the URLs it’s trying to load (say, a CSS file)?
>>
>> Also, two things to check:
>>
>> 1) Make sure you have the following in your 
>> $sitedir/conf/settings_local.py
>>
>> DEBUG = False
>>
>> 2) Run this and look at the paths that are set. Make sure they are what 
>> you expect:
>>
>> rb-site manage $sitedir list-siteconfig
>>
>> Christian
>>
>>
>> On Wed, Jun 26, 2019 at 09:06 Steve  wrote:
>>
>>> Yes all present and correct.
>>>
>>>
>>>
>>>
>>> On Wednesday, 26 June 2019 16:39:44 UTC+1, Paul Mansfield wrote:
>>>>
>>>> check you have the following mappings in your apache config for 
>>>> reviewboard
>>>>
>>>> # Alias static media requests to filesystem
>>>> Alias /media "/var/www/reviewboard/htdocs/media"
>>>> Alias /static "/var/www/reviewboard/htdocs/static"
>>>> Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
>>>> Alias /favicon.ico 
>>>> "/var/www/reviewboard/htdocs/static/rb/images/favicon.png"
>>>>
>>>>
>>>>
>>>> -- 
>>> Supercharge your Review Board with Power Pack: 
>>> https://www.reviewboard.org/powerpack/
>

Re: Page rendering and default route

[Steve]

Hi Christian,

Hm, the paths seem to have old references as well as new. site_media_root 
is definitely a throw back from the original install. Originally 
reviewboard was running on Gentoo and I created a working clone under 
Ubuntu with a reviewboard default directory structure. All seemed to work 
fine until the upgrade from 1.6.. to 3.0.. At that point the directory 
structure changed so I assume these paths are not part of the upgrade 
process.

"logging_directory": "/var/log/reviewboard"
"site_media_root": "/var/www/localhost/htdocs/reviewboard/htdocs/media",
"site_static_root": "/var/www/reviewboard/htdocs/static",
"site_static_url": "/reviewboard/static/",
"site_media_url": "/reviewboard/media/",

Where can I modify these.



DEBUG = False


Steve.




On Thursday, 27 June 2019 01:04:29 UTC+1, Christian Hammond wrote:
>
> Hi,
>
> Can you show me one of the URLs it’s trying to load (say, a CSS file)?
>
> Also, two things to check:
>
> 1) Make sure you have the following in your $sitedir/conf/settings_local.py
>
> DEBUG = False
>
> 2) Run this and look at the paths that are set. Make sure they are what 
> you expect:
>
> rb-site manage $sitedir list-siteconfig
>
> Christian
>
>
> On Wed, Jun 26, 2019 at 09:06 Steve > 
> wrote:
>
>> Yes all present and correct.
>>
>>
>>
>>
>> On Wednesday, 26 June 2019 16:39:44 UTC+1, Paul Mansfield wrote:
>>>
>>> check you have the following mappings in your apache config for 
>>> reviewboard
>>>
>>> # Alias static media requests to filesystem
>>> Alias /media "/var/www/reviewboard/htdocs/media"
>>> Alias /static "/var/www/reviewboard/htdocs/static"
>>> Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
>>> Alias /favicon.ico 
>>> "/var/www/reviewboard/htdocs/static/rb/images/favicon.png"
>>>
>>>
>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/3519b207-35bb-46b1-bd41-442c4e5d29a4%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/3519b207-35bb-46b1-bd41-442c4e5d29a4%40googlegroups.com?utm_medium=email_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/41adf1f6-934a-44ac-902d-da9d0bad3d5d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

Yes all present and correct.




On Wednesday, 26 June 2019 16:39:44 UTC+1, Paul Mansfield wrote:
>
> check you have the following mappings in your apache config for reviewboard
>
> # Alias static media requests to filesystem
> Alias /media "/var/www/reviewboard/htdocs/media"
> Alias /static "/var/www/reviewboard/htdocs/static"
> Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
> Alias /favicon.ico 
> "/var/www/reviewboard/htdocs/static/rb/images/favicon.png"
>
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/3519b207-35bb-46b1-bd41-442c4e5d29a4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Page rendering and default route

[Steve]

Hi,

I'm new to Reviewboard but managed to find my way around through an upgrade 
from 1.6.. to 3.0. whilst changing from Mod_Python to WSGI. Also upgraded 
from Ubuntu 12.04  to 18.06 and there seemed to be a few dependency issues 
to sort out on the way.

Anyway Reviewboard seems to working now at least with all the original data 
but I have two problems.


Problem 1.

There is no page rendering or graphics throughout, it's just plain text 
based. Initially I thought it was permissions related or at least in the 
/var/www/RB directory so I created a test site under 3.0.. and just 
compared the two, all seemed to be the same.


[image: snip.png]


Problem 2.

I have trac/svn running on the same machine. If I enable reviewboard.conf 
in apache, reviewboard seems to take over and what was 
http://localhost/trac or locahost/ goes to reviewboard. If I disable 
reviewboard.conf then trac/svn works fine. Been through .conf, .wsgi and 
settings_local.py but cant seem to make it work. I thought that site route 
as /reviewboard/ would have changed it's focus but I guess not.
 

Any help would be appreciated.


Thanks in advance.
Steve.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b8627e3c-4dbb-4732-b17c-1e8d39660263%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Path 6303924 does not match a valid Perforce path.

[Steve McCarthy]

In  ~/.reviewboardrc add:

REPOSITORY_TYPE = "perforce"

Got me past this error.

-Steve



On Tuesday, May 14, 2019 at 2:46:46 PM UTC-7, Harsh Verma wrote:
>
> Hi Darshan,
>
> I am running into the exact same issue and cannot post reviews using rbt. 
> Did you find a resolution to this issue?
>
> Thanks,
> Harsh
>
> On Wednesday, July 11, 2018 at 8:42:43 AM UTC-7, Darshan MAnge wrote:
>>
>> Hi All,
>>
>> I am facing the below issue while running below command
>>
>> input :
>>
>> rbt post -d 6389924
>>
>>
>> output:
>>
>> the issue it pops is : rbtools.clients.errors.SCMError: Path 6303924 
>> does not match a valid Perforce path.
>>
>>
>> My Findings:
>>
>> 1. It is not able to return state of the changelist and thereby making 
>> whole revisions variable NONE
>>
>>
>> File perforce.py
>>
>> def _get_changelist_status(self, changelist):
>>
>> ...
>>
>>
>> if changelist == self.REVISION_DEFAULT_CLN:
>>
>> return 'pending'
>>
>> else:
>>
>> change = self.p4.change(changelist)
>>
>> if len(change) == 1 and 'Status' in change[0]:
>>
>> return change[0]['Status']
>>
>>
>> return None
>>
>>
>> 2. return change[0]['Status'] in this line it is not able to find Status 
>> key inside the change object
>>
>>
>> output of line : change = self.p4.change(changelist) is 
>>
>>
>> {b'code': b'stat', b'Change': b'6303924', b'Date': b'2018/07/09 
>> 17:22:22', b'Client': b'dmange-cmd-vapi', ..., }
>>
>>
>> 3. I guess while decoding it using marshal in below line, it is somehow 
>> not able to convert it to dictionary. 
>>
>>
>> line 283 : data = marshal.load(p.stdout)
>>
>>
>> Please let me know if anyone can help me resolving this issue, i changed 
>> marshal to json and pickle, an another form of decoder, but still i was not 
>> able to solve the issue. 
>>
>>
>> Thanks and Regards,
>>
>> Darshan Mange
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/93f4feed-903f-432c-8a17-c914433c4707%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Djblets Ticket #4686: Initial migration for siteconfig fails because django_site table doesn't exist yet.

[Steve Jorgensen]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4686/
--

New ticket #4686 by stevej
For Beanbag, Inc. > Djblets

Status: New
Tags: Priority:Medium, Project:RBTools


--
Initial migration for siteconfig fails because django_site table doesn't exist 
yet.
==

# What version of Djblets are you using?
1.0.5

# Which module(s) have the problem?
siteconfig

# What steps will reproduce the problem?
1. Perform an initial migration by running `django-admin migrate --run-syncdb`


# What is the expected output? What do you see instead?
Expected migrations to complete successfully.
Got an error: django.db.utils.ProgrammingError: relation “django_site” does not 
exist


# What version of Python and Django?
Python 2.7.14
Django 1.9.12

# Please provide any additional information below.
I can work around the problem by executing migrations in 2 stages as follows:
```
django-admin migrate
django-admin migrate --run-syncdb
```
I had to figure out the workaround though, and it would be nice if that was not 
necessary.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board fails to create a review -- apparently failing to grab valid revision of files from SVN

[Steve]

Version:  *Review Board*  2.5.2 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board fails to create a review -- apparently failing to grab valid revision of files from SVN

[Steve]

On Wednesday, February 15, 2017 at 1:08:14 AM UTC-8, Christian Hammond 
wrote:
>
> Hi Steve,
>
> What version of Review Board are you using?
>
> Can you show me the appropriate line from the diff from `rbt diff`? The 
> entire set of diff headers (filenames + revisions + Index line, no data 
> needed) where it specifies 8525 would help a lot.
>
> Thanks!
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Tue, Feb 14, 2017 at 5:06 PM, Steve Muller <stephen...@gmail.com 
> > wrote:
>
>> When I try to manually post from the review board GUI for one specific 
>> SVN repository, it give me the following message:
>>
>>  
>>
>> The specified diff file could not be parsed.
>> Line undefined: No such revision 8525
>>
>>  
>>
>> In this case, revision 8525 is the original revision the change is based 
>> on and is valid.  From the command line *rbt post* also fails, but* rbt 
>> diff* generates a diff file just fine.  
>>
>>  
>>
>> It looks like failure in both cases is that it can’t grab the SVN 
>> revision of files even though they should be there.  Accessing SVN directly 
>> of these revision seem fine.
>>
>>  
>>
>> Is there a way to debug this either from the SVN side or the Review Board 
>> side??
>>
>>  
>>
>>  
>>
>> Thanks.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

This is a simplified, one file change that I was trying to create a 
review with.  It's actually incremented the SVN revision, but it's still a 
valid revision.

Index: src/vip_bcm97405B1_stage1_bl/CFE/bcm97405A/src/user_input.c

===

--- src/vip_bcm97405B1_stage1_bl/CFE/bcm97405A/src/user_input.c (revision 
8527)

+++ src/vip_bcm97405B1_stage1_bl/CFE/bcm97405A/src/user_input.c (revision 
8528)

@@ -2481,3 +2481,5 @@

}

return halError;

}

+

+/** steve's review board test **/
 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Review Board fails to create a review -- apparently failing to grab valid revision of files from SVN

[Steve Muller]

When I try to manually post from the review board GUI for one specific SVN 
repository, it give me the following message:

 

The specified diff file could not be parsed.
Line undefined: No such revision 8525

 

In this case, revision 8525 is the original revision the change is based on 
and is valid.  From the command line *rbt post* also fails, but* rbt diff* 
generates a diff file just fine.  

 

It looks like failure in both cases is that it can’t grab the SVN revision 
of files even though they should be there.  Accessing SVN directly of these 
revision seem fine.

 

Is there a way to debug this either from the SVN side or the Review Board 
side??

 

 

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Review Board doesn't send emails

[Steve Thompson]

Hi,

I have a Review Board installation hosted on Google Cloud and using 
SendGrid as its SMTP server. When I go to the Admin > E-Mail settings page, 
click the checkbox labelled "Send a test email after saving" and click 
Save, I receive a test email.

However, this is the only email I ever receive from RB. Today I upgraded to 
2.5.6.1 which is working fine but I'm still not receiving emails.

On looking through this forum, for a lot of people who have encountered 
this problem it's turned out to be because of a restrictive mail server 
(which is a good thing). However, not only do I not have a problem with the 
test email but /var/log/reviewboard/reviewboard.log makes no mention of 
email being sent either successfully or unsuccessfully. So before I can 
diagnose why my emails aren't being sent I need to find out why email 
transactions aren't being logged (or if they're being logged somewhere else 
and I missed that bit).

RB was installed (and upgraded) using easy_install. Is there a chance 
there's another Python module that I should've installed manually but 
missed in the instructions? 

My logging is set to Debug - does anyone know why my logs aren't showing 
email transactions? For example

root@reviewboard-2:/var/log/reviewboard# grep -i debug reviewboard.log | wc 
-l
63241

So it's definitely logging debug messages. But

root@reviewboard-2:/var/log/reviewboard# grep -i smtp reviewboard.log | wc 
-l
0
root@reviewboard-2:/var/log/reviewboard# grep -i mail reviewboard.log | wc 
-l
0

Just to clarify - all the "Send e-mails when " checkboxes are checked and 
all the registered users have valid email addresses. 

Any suggestions for things I can poke or tweak gratefully received.

Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools 0.7.4: rbt post --diff-only no longer works

[Steve]

Hi David,

Ticket opened: https://hellosplat.com/s/beanbag/tickets/4368/

--Steve

On Monday, March 14, 2016 at 2:34:51 PM UTC-7, David Trowbridge wrote:
>
> I don't think we've heard about this before. Mind filing a bug?
>
> -David
>
> On Thu, Mar 10, 2016 at 9:15 AM Steve <seide...@gmail.com > 
> wrote:
>
>> I've noticed that the --diff-only option to rbt post is no longer working 
>> the way it used to with Perforce.  It may be trying to be too clever. If I 
>> create a review with this perforce change description:
>>
>> Description:
>>Bogus review request to test --diff-only option
>>
>>
>> Using
>>
>> $ rbt post CL
>>
>> I get a review request where both the title and description read: "Bogus 
>> review request to test --diff-only option".  That's good.  Then I modify 
>> the file and the change list description so the new change list description 
>> reads:
>>
>>
>> Description:
>> Bogus review request to test --diff-only option
>>
>>I'm adding this comment for Rev 2. Using --diff-only, this 
>> text should not appear in ReviewBoard
>>
>>
>> and do
>>
>> $ rbt post --diff-only CL
>>
>> When I look at the new review draft, the title remains the same (good), 
>> but the description field now says:
>>
>>
>>"I'm adding this comment for Rev 2. Using --diff-only, this text 
>> should not appear in ReviewBoard"
>>
>> which is not good.
>>
>> Even worse is this case:
>>
>> I edit the description field in Review Board to add aditional information 
>> directly. It now reads:
>>
>> '''
>> Bogus review request to test --diff-only option
>>
>> Someone reported a problem with 'rbt post --diff-only'  I'm using this 
>> bogus review request to test and see if this is broken. I expect this 
>> comment to remain after an update using --diff-only.
>> '''
>>
>> Now I run
>>
>> $ rbt post --diff-only CL
>>
>> And my description in Review Board has been overwritten with the 
>> description in my perforce change list.
>>
>> I searched for '--diff-only' in the bug tracker and didn't find anything, 
>> so I'm posting here to see if this is a known issue.
>>
>> Thanks
>>
>> --Steve
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -David
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools 0.7.4: rbt post --diff-only no longer works

[Steve]

I've noticed that the --diff-only option to rbt post is no longer working 
the way it used to with Perforce.  It may be trying to be too clever. If I 
create a review with this perforce change description:

Description:
   Bogus review request to test --diff-only option


Using

$ rbt post CL

I get a review request where both the title and description read: "Bogus 
review request to test --diff-only option".  That's good.  Then I modify 
the file and the change list description so the new change list description 
reads:


Description:
Bogus review request to test --diff-only option

   I'm adding this comment for Rev 2. Using --diff-only, this text 
should not appear in ReviewBoard


and do

$ rbt post --diff-only CL

When I look at the new review draft, the title remains the same (good), but 
the description field now says:


   "I'm adding this comment for Rev 2. Using --diff-only, this text should 
not appear in ReviewBoard"

which is not good.

Even worse is this case:

I edit the description field in Review Board to add aditional information 
directly. It now reads:

'''
Bogus review request to test --diff-only option

Someone reported a problem with 'rbt post --diff-only'  I'm using this 
bogus review request to test and see if this is broken. I expect this 
comment to remain after an update using --diff-only.
'''

Now I run

$ rbt post --diff-only CL

And my description in Review Board has been overwritten with the 
description in my perforce change list.

I searched for '--diff-only' in the bug tracker and didn't find anything, 
so I'm posting here to see if this is a known issue.

Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools 0.7.4: rbt patch --px bug

[Steve]

There's a bug in RBTools 0.7.4 when using 'rbt patch' with the --px option. 
The problem is the option string isn't being converted to an integer:

$ rbt --version
RBTools 0.7.4

$ rbt patch --px 4  --repository-type perforce -d 128385



File "C:\Python27\lib\site-packages\rbtools\clients__init__.py", line 197, 
in apply_patch
cmd.append('-p%d' % p_num)
TypeError: %d format: a number is required, not str

The simplest fix is:

< cmd.append('-p%d' % p_num)
> cmd.append('-p%d' % int(p_num))

The problem is also in 0.7.5 alpha.

I opened a ticket here:

https://hellosplat.com/s/beanbag/tickets/4364/

But I wanted to post it here as well for visibility since others may run 
into this.

Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Python API: Delete a user from a review group

[Steve]

Sorry I'm back.  Since I can't remove a user from a group using the API, I 
thought instead  I would make the user account inactive via the API. But I 
can't find a resource for that.  Is the 'active' flag for a user account 
exposed somewhere in the API?

I'm just trying to programmatically prevent departed employees from ending 
up in review requests when they're members of review groups.

--Steve



On Wednesday, September 2, 2015 at 9:29:16 AM UTC-7, Steve wrote:
>
> I'm trying to remove users from review groups using the Python API.  The 
> docs indicate that the review group user resource has a delete method, but 
> I can't figure out how to get it to work.  I can add a user to a group 
> easily this way:
>
> g.get_users().create(username='steve')
>
> Unfortunately, this doesn't work:
>
> g.get_users().delete(username='steve')
>
> Nor does this:
>
> g.get_user()[0].delete() 
>
> or any other incarnation I've tried.  Can somebody point me in the right 
> direction?
>
> Thanks!
>
> --Steve
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Python API: Delete a user from a review group

[Steve]

I'm trying to remove users from review groups using the Python API.  The 
docs indicate that the review group user resource has a delete method, but 
I can't figure out how to get it to work.  I can add a user to a group 
easily this way:

g.get_users().create(username='steve')

Unfortunately, this doesn't work:

g.get_users().delete(username='steve')

Nor does this:

g.get_user()[0].delete() 

or any other incarnation I've tried.  Can somebody point me in the right 
direction?

Thanks!

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Python API: Delete a user from a review group

[Steve]

Thanks Steven for confirming that.  I thought maybe I was going crazy!

--Steve


On Wednesday, September 2, 2015 at 2:24:50 PM UTC-7, Steven MacLeod wrote:
>
> It looks like it's not actually possible to delete a user from a review 
> group using the Python API at the moment. Review Board seems to be 
> returning an incorrect url which points to the user resource itself, rather 
> than the review-group-user resource for the delete link. you can see that 
> by looking at the example here: 
> https://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/review-group-user/#example_application/vnd.reviewboard.org.user+json
>
> "delete": {
>> "href": "http://reviews.example.com/api/users/doc/;,
>> "method": "DELETE"
>> },
>
>
> This is a bug in Review Board and will need to be fixed there to allow 
> this. 
>  
>
> On Wed, Sep 2, 2015 at 12:29 PM, Steve <seide...@gmail.com > 
> wrote:
>
>> I'm trying to remove users from review groups using the Python API.  The 
>> docs indicate that the review group user resource has a delete method, but 
>> I can't figure out how to get it to work.  I can add a user to a group 
>> easily this way:
>>
>> g.get_users().create(username='steve')
>>
>> Unfortunately, this doesn't work:
>>
>> g.get_users().delete(username='steve')
>>
>> Nor does this:
>>
>> g.get_user()[0].delete() 
>>
>> or any other incarnation I've tried.  Can somebody point me in the right 
>> direction?
>>
>> Thanks!
>>
>> --Steve
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Automating ReviewBoard testing with Selenium or some other tool?

[Steve]

Hi everyone,

Is anyone out there doing automated testing of ReviewBoard using Selenium, 
or some other tool?  I'd be interested to know how well it's working and 
how difficult it was to set up.  I'd really like to have an automated test 
suit in place for my move from 1.7.28 to 2.x, but I haven't written a web 
app test suite before and don't want to bite off  more than I can chew.

Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Automating ReviewBoard testing with Selenium or some other tool?

[Steve]

Thanks for the feedback David.  The reason I considered a test suite is 
when I upgraded to 2.0 on a sandbox, I ran into a problem caused, I think, 
by our custom authentication classes in backends.py.  It surfaced when I 
tried to add a reviewer via the web app and I got an internal server error. 
 The log indicated we were missing a query_users() method, which appears to 
be new in the 2.0 auth modules.  It made me what other surprises might be 
in store :)

Based on your experiences, I think I'll  just script some canned, 
interactive session that I can run just to make sure I've exercised the 
basic functionality.  Something like that would have exposed this problem.

--Steve


On Friday, July 10, 2015 at 12:28:04 PM UTC-7, David Trowbridge wrote:

 Steve,

 Once upon a time we used Selenium to test the UI, but it's a complicated 
 and fragile system and we ended up abandoning it. We've replaced it with 
 frontend unit tests which run in a browser using the jasmine framework. If 
 you're doing Review Board development using the devserver, you can run 
 these by navigating to /js-tests/

 If you're just looking to verify an upgrade, I wouldn't worry with all 
 that. Our upgrades are pretty painless (except in the most unusual of 
 circumstances), and if you can open the Review Board site and interact with 
 it afterwards, everything went OK. We do of course recommend making backups 
 of things before you start the upgrade process.

 -David

 On Fri, Jul 10, 2015 at 11:53 AM, Steve seide...@gmail.com javascript: 
 wrote:

 Hi everyone,

 Is anyone out there doing automated testing of ReviewBoard using 
 Selenium, or some other tool?  I'd be interested to know how well it's 
 working and how difficult it was to set up.  I'd really like to have an 
 automated test suit in place for my move from 1.7.28 to 2.x, but I haven't 
 written a web app test suite before and don't want to bite off  more than I 
 can chew.

 Thanks

 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post --diff-filename broken in 0.6.3 and 0.7.x

[Steve]

I was just notified by the issue tracker that a fix has been submitted for 
the diff-filename issue.  I'll test drive it as soon as it becomes 
available.

I hope a fix can be submitted soon for issue 3864 too so we can move to 0.7 
:)

Thanks!

--steve

On Tuesday, July 7, 2015 at 8:57:43 AM UTC-7, Steve wrote:

 Hi Chris,

 Issue 3864 is preventing us from upgrading to 0.7.x.  The issue prevents 
 us from creating reviews for change lists already submitted.


 https://code.google.com/p/reviewboard/issues/detail?id=3864q=seidecolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone


 Also, just to clarify, the problem with 'rbt post --diff-filename' exists 
 in 0.7.3 as well.  See issue 3908:


 https://code.google.com/p/reviewboard/issues/detail?id=3908q=seidecolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone


 Thanks!

 --Steve


 On Sunday, July 5, 2015 at 11:08:38 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 We won't be performing any more 0.6.x releases. What issues are 
 preventing you from using 0.7.x?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Thu, Jul 2, 2015 at 11:54 AM, Steve seide...@gmail.com wrote:

 We recently upgraded from RBTools 0.5.2 to 0.6.3 (Certain bugs in 0.7.x 
 prevent us from upgrading to that version).  One of my users found the 
 --diff-filename option no longer works:

 $ rbt post --diff-filename mydiff 823

 Traceback (most recent call last):
   File /home/sallan/envs/rbtools-0.7.3/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.7.3', 'console_scripts', 'rbt')()
   File 
 /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/main.py,
  line 133, in main
 command.run_from_argv([RB_MAIN, command_name] + args)
   File 
 /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/__init__.py,
  line 612, in run_from_argv
 exit_code = self.main(*args) or 0
   File 
 /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/post.py,
  line 751, in main
 if repository_info.supports_changesets and 'changenum' in diff_info:
 UnboundLocalError: local variable 'diff_info' referenced before assignment



 Same error with 0.6.3.  The same command works properly with RBTools 0.5.2. 
  I opened issue 3908, but I wanted to post here as well for greater 
 visibility.


 Thanks


 --Steve 


  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post --diff-filename broken in 0.6.3 and 0.7.x

[Steve]

Hi Chris,

Issue 3864 is preventing us from upgrading to 0.7.x.  The issue prevents us 
from creating reviews for change lists already submitted.

https://code.google.com/p/reviewboard/issues/detail?id=3864q=seidecolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone


Also, just to clarify, the problem with 'rbt post --diff-filename' exists 
in 0.7.3 as well.  See issue 3908:

https://code.google.com/p/reviewboard/issues/detail?id=3908q=seidecolspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone


Thanks!

--Steve


On Sunday, July 5, 2015 at 11:08:38 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 We won't be performing any more 0.6.x releases. What issues are preventing 
 you from using 0.7.x?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Thu, Jul 2, 2015 at 11:54 AM, Steve seide...@gmail.com javascript: 
 wrote:

 We recently upgraded from RBTools 0.5.2 to 0.6.3 (Certain bugs in 0.7.x 
 prevent us from upgrading to that version).  One of my users found the 
 --diff-filename option no longer works:

 $ rbt post --diff-filename mydiff 823

 Traceback (most recent call last):
   File /home/sallan/envs/rbtools-0.7.3/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.7.3', 'console_scripts', 'rbt')()
   File 
 /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/main.py,
  line 133, in main
 command.run_from_argv([RB_MAIN, command_name] + args)
   File 
 /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/__init__.py,
  line 612, in run_from_argv
 exit_code = self.main(*args) or 0
   File 
 /home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/post.py,
  line 751, in main
 if repository_info.supports_changesets and 'changenum' in diff_info:
 UnboundLocalError: local variable 'diff_info' referenced before assignment



 Same error with 0.6.3.  The same command works properly with RBTools 0.5.2.  
 I opened issue 3908, but I wanted to post here as well for greater 
 visibility.


 Thanks


 --Steve 


  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools: rbt post --diff-filename broken in 0.6.3 and 0.7.x

[Steve]

We recently upgraded from RBTools 0.5.2 to 0.6.3 (Certain bugs in 0.7.x 
prevent us from upgrading to that version).  One of my users found the 
--diff-filename option no longer works:

$ rbt post --diff-filename mydiff 823

Traceback (most recent call last):
  File /home/sallan/envs/rbtools-0.7.3/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.3', 'console_scripts', 'rbt')()
  File 
/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/main.py,
 line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/__init__.py,
 line 612, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/post.py,
 line 751, in main
if repository_info.supports_changesets and 'changenum' in diff_info:
UnboundLocalError: local variable 'diff_info' referenced before assignment



Same error with 0.6.3.  The same command works properly with RBTools 0.5.2.  I 
opened issue 3908, but I wanted to post here as well for greater visibility.


Thanks


--Steve 


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBot: Problem moving from 0.1 to 0.2

[Steve]

Some other information I should have provided:

- I refreshed the installed tools on the extension page
- Here's what's in my .pth files:

root@dory site-packages]# grep -i bot *.pth
easy-install.pth:./Review_Bot_Extension-0.2alpha0-py2.6.egg
easy-install.pth:./ReviewBot-0.3alpha0-py2.6.egg
easy-install.pth:./buildbot-0.8.12-py2.6.egg
[root@dory site-packages]# ls -ld *[Bb]ot*
drwxr-xr-x 4 root root 4096 Jun 15 14:24 buildbot-0.8.12-py2.6.egg
drwxr-xr-x 4 root root 4096 Jan 31  2014 ReviewBot-0.1-py2.6.egg
drwxr-xr-x 4 root root 4096 Jun 15 14:24 ReviewBot-0.3alpha0-py2.6.egg
drwxr-xr-x 4 root root 4096 Sep 25  2013 Review_Bot_Extension-0.1-py2.6.egg
drwxr-xr-x 4 root root 4096 Jun 15 14:23 
Review_Bot_Extension-0.2alpha0-py2.6.egg

On Tuesday, June 16, 2015 at 10:12:58 AM UTC-7, Steve wrote:

 Hi all,

 I'm upgraded a test server from ReviewBoard 1.7.28 to 2.0.15.  That seems 
 to be working fine.  Now I'm trying to upgrade the ReviewBot extension from 
 0.1 to 0.2.  I followed the instructions here:

 https://github.com/reviewboard/ReviewBot

 and everything completed without error.  I then

 - Stopped: reviewbot service, apache and memcached
 - Started: memached, apache, reviewbot


 Then I post a review with a python file that  I know has PEP 8 violations. 
  ReviewBot fails to post a review and the log file complains that

 [2015-06-16 10:08:27,091: DEBUG/MainProcess] Cached response for HTTP GET 
 https://dory/api/extensions/reviewbotext.extension.ReviewBotExtension/ 
 expired and was modified

 Here's the whole output:

 [2015-06-16 09:57:02,650: DEBUG/MainProcess] Making HTTP GET request to 
 https://dory/api/review-requests/75029/diffs/9/files/1698454/patched-file/
 [2015-06-16 09:57:02,819: DEBUG/MainProcess] Added cache entry for HTTP 
 GET request to 
 https://dory/api/review-requests/75029/diffs/9/files/1698454/patched-file/
 [2015-06-16 09:57:02,820: DEBUG/MainProcess] pep8 -r --max-line-length=79 
 --ignore= /tmp/tmpJQJPMa.py
 [2015-06-16 09:57:02,950: INFO/MainProcess] 
 reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7]: 
 Tool execution completed successfully
 [2015-06-16 09:57:02,951: INFO/MainProcess] 
 reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7]: 
 Updating tool execution with completed review
 [2015-06-16 09:57:02,951: DEBUG/MainProcess] Making HTTP GET request to 
 https://dory/api/extensions/reviewbotext.extension.ReviewBotExtension/
 [2015-06-16 09:57:03,090: DEBUG/MainProcess] Cached response for HTTP GET 
 https://dory/api/extensions/reviewbotext.extension.ReviewBotExtension/ 
 expired and was modified
 [2015-06-16 09:57:03,093: ERROR/MainProcess] 
 reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7]: 
 Error updating tool execution:
 [2015-06-16 09:57:03,093: INFO/MainProcess] Task 
 reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7] 
 succeeded in 1.39496517181s: False

 Is there some other step I need to take to upgrade the ReviewBot extension?

 --Steve



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

ReviewBot: Problem moving from 0.1 to 0.2

[Steve]

Hi all,

I'm upgraded a test server from ReviewBoard 1.7.28 to 2.0.15.  That seems 
to be working fine.  Now I'm trying to upgrade the ReviewBot extension from 
0.1 to 0.2.  I followed the instructions here:

https://github.com/reviewboard/ReviewBot

and everything completed without error.  I then

- Stopped: reviewbot service, apache and memcached
- Started: memached, apache, reviewbot


Then I post a review with a python file that  I know has PEP 8 violations. 
 ReviewBot fails to post a review and the log file complains that

[2015-06-16 10:08:27,091: DEBUG/MainProcess] Cached response for HTTP GET 
https://dory/api/extensions/reviewbotext.extension.ReviewBotExtension/ 
expired and was modified

Here's the whole output:

[2015-06-16 09:57:02,650: DEBUG/MainProcess] Making HTTP GET request to 
https://dory/api/review-requests/75029/diffs/9/files/1698454/patched-file/
[2015-06-16 09:57:02,819: DEBUG/MainProcess] Added cache entry for HTTP GET 
request to 
https://dory/api/review-requests/75029/diffs/9/files/1698454/patched-file/
[2015-06-16 09:57:02,820: DEBUG/MainProcess] pep8 -r --max-line-length=79 
--ignore= /tmp/tmpJQJPMa.py
[2015-06-16 09:57:02,950: INFO/MainProcess] 
reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7]: 
Tool execution completed successfully
[2015-06-16 09:57:02,951: INFO/MainProcess] 
reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7]: 
Updating tool execution with completed review
[2015-06-16 09:57:02,951: DEBUG/MainProcess] Making HTTP GET request to 
https://dory/api/extensions/reviewbotext.extension.ReviewBotExtension/
[2015-06-16 09:57:03,090: DEBUG/MainProcess] Cached response for HTTP GET 
https://dory/api/extensions/reviewbotext.extension.ReviewBotExtension/ 
expired and was modified
[2015-06-16 09:57:03,093: ERROR/MainProcess] 
reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7]: 
Error updating tool execution:
[2015-06-16 09:57:03,093: INFO/MainProcess] Task 
reviewbot.tasks.ProcessReviewRequest[faaa0d58-1dd5-426d-bab7-6b0b5f295be7] 
succeeded in 1.39496517181s: False

Is there some other step I need to take to upgrade the ReviewBot extension?

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Problem updating existing reviews after changing perforce port in repository settings

[Steve]

On Monday, June 8, 2015 at 3:00:31 PM UTC-7, David Trowbridge wrote:

 Steve,

 It's pretty hard for us to do support for post-review, since it's 
 completely obsolete (and 0.5.2 is pretty old). That said, can you give us 
 the output of running post-review with --debug in a case where this problem 
 is showing up?

 BTW, why are you planning to upgrade to 0.6.3 instead of 0.7.3?



I'd like to upgrade to 0.7.x but I can't because of Issue 3864.


I'll try to test this repo problem with a newer RBTools just to see if the 
problem is with RBTools or the server.

Thanks

--Steve

 


 -David

 On Mon, Jun 8, 2015 at 9:36 AM Steve seide...@gmail.com javascript: 
 wrote:

 I forgot to mention that I restarted memcached on the servers too, but 
 the problem persists.

 --steve


 On Monday, June 8, 2015 at 9:28:21 AM UTC-7, Steve wrote:

 We changed our DNS entry for our perforce server over the weekend which 
 required me to change our port settings in ReviewBoard.  I edited the repo 
 setting in the RB admin console and changed the name an path like this:

 # Old
 Name: oldname:1666
 Path:   oldname:1666

 # New
 Name: perforce:1666
 Path:   perforce:1666

 The string 'perforce:1666'  is what is returned by 'p4 info' as the 
 'Server address'.  This works fine in the sense that all the old reviews 
 show the new perforce port string and the diffs are being properly 
 displayed.  The problem occurs when we try to update a review that was 
 created prior to the DNS change using post-review.  Instead of updating the 
 old review, it creates a new one.  I've told my users they can get around 
 this for the old reviews by adding the -r option to specify the review 
 board id, but I'd like to understand what I may have done wrong.

 We are currently using RBTools 0.5.2 and post-review, but we're planning 
 to upgrade soon to 0.6.3 and rbt.  Our RB version is 1.7.28.  I'll try to 
 test with the new RBTools, but I have a limited amount of old reviews that 
 I can play with.


 Thanks

 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Problem updating existing reviews after changing perforce port in repository settings

[Steve]

I just tested this with RBTools 0.6.3 and 0.7.3.  I ran rbt post with the 
--debug option.  It reports the change list is already in use, which is 
correct, but rather than updating the old review request it creates a new 
one.  Is it because it thinks it's talking to a different repo?  That would 
surprise me though because the repo ID is the same - just the port and 
description changed.

--Steve


On Tuesday, June 9, 2015 at 7:23:08 AM UTC-7, Steve wrote:



 On Monday, June 8, 2015 at 3:00:31 PM UTC-7, David Trowbridge wrote:

 Steve,

 It's pretty hard for us to do support for post-review, since it's 
 completely obsolete (and 0.5.2 is pretty old). That said, can you give us 
 the output of running post-review with --debug in a case where this problem 
 is showing up?

 BTW, why are you planning to upgrade to 0.6.3 instead of 0.7.3?



 I'd like to upgrade to 0.7.x but I can't because of Issue 3864.


 I'll try to test this repo problem with a newer RBTools just to see if the 
 problem is with RBTools or the server.

 Thanks

 --Steve

  


 -David

 On Mon, Jun 8, 2015 at 9:36 AM Steve seide...@gmail.com wrote:

 I forgot to mention that I restarted memcached on the servers too, but 
 the problem persists.

 --steve


 On Monday, June 8, 2015 at 9:28:21 AM UTC-7, Steve wrote:

 We changed our DNS entry for our perforce server over the weekend which 
 required me to change our port settings in ReviewBoard.  I edited the repo 
 setting in the RB admin console and changed the name an path like this:

 # Old
 Name: oldname:1666
 Path:   oldname:1666

 # New
 Name: perforce:1666
 Path:   perforce:1666

 The string 'perforce:1666'  is what is returned by 'p4 info' as the 
 'Server address'.  This works fine in the sense that all the old reviews 
 show the new perforce port string and the diffs are being properly 
 displayed.  The problem occurs when we try to update a review that was 
 created prior to the DNS change using post-review.  Instead of updating 
 the 
 old review, it creates a new one.  I've told my users they can get around 
 this for the old reviews by adding the -r option to specify the review 
 board id, but I'd like to understand what I may have done wrong.

 We are currently using RBTools 0.5.2 and post-review, but we're 
 planning to upgrade soon to 0.6.3 and rbt.  Our RB version is 1.7.28.  
 I'll 
 try to test with the new RBTools, but I have a limited amount of old 
 reviews that I can play with.


 Thanks

 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Problem updating existing reviews after changing perforce port in repository settings

[Steve]

Sorry about the formatting.  Note the existing review is associated with 
change list 1423088 is RID 9175 which was created before I changed the repo 
port and description.

$ rbt --version
RBTools 0.6.3

$ rbt post -d --server https://reviewboard-testcases 1423088

 Making HTTP GET request to 
https://reviewboard-testcases/api/review-requests/
 Making HTTP POST request to 
https://reviewboard-testcases/api/review-requests/
 Got API Error 204 (HTTP code 409): The change number specified has 
already been used
 Error data: {u'stat': u'fail', u'review_request': {u'status': 
u'discarded', u'blocks': [], u'des
cription': u'Test issue with packet size\n', u'links': {u'diffs': {u'href': 
u'https://reviewboard-te
stcases/api/review-requests/9317/diffs/', u'method': u'GET'}, 
u'repository': {u'href': u'https://rev
iewboard-testcases/api/repositories/1/', u'method': u'GET', u'title': 
u'perforce1666'}, u'changes': {u'href': 
u'https://reviewboard-testcases/api/review-requests/9317/changes/', u'm
ethod': u'GET'}, u'self': {u'href': 
u'https://reviewboard-testcases/api/review-requests/9317/', u'me
thod': u'GET'}, u'update': {u'href': 
u'https://reviewboard-testcases/api/review-requests/9317/', u'm
ethod': u'PUT'}, u'last_update': {u'href': 
u'https://reviewboard-testcases/api/review-requests/9317/
last-update/', u'method': u'GET'}, u'reviews': {u'href': 
u'https://reviewboard-testcases/api/review-
requests/9317/reviews/', u'method': u'GET'}, u'draft': {u'href': 
u'https://reviewboard-testcases/api
/review-requests/9317/draft/', u'method': u'GET'}, u'file_attachments': 
{u'href': u'https://reviewbo
ard-testcases/api/review-requests/9317/file-attachments/', u'method': 
u'GET'}, u'submitter': {u'href
': u'https://reviewboard-testcases/api/users/sallan/', u'method': u'GET', 
u'title': u'sallan'}, u'sc
reenshots': {u'href': 
u'https://reviewboard-testcases/api/review-requests/9317/screenshots/', 
u'meth
od': u'GET'}, u'delete': {u'href': 
u'https://reviewboard-testcases/api/review-requests/9317/', u'met
hod': u'DELETE'}}, u'url': u'/r/9317/', u'depends_on': [], u'public': 
False, u'target_groups': [], u
'bugs_closed': [], u'changenum': 1423088, u'target_people': [], 
u'testing_done': u'', u'branch': u''
, u'last_updated': u'2015-06-09T17:02:45Z', u'time_added': 
u'2015-06-08T16:00:25Z', u'summary': u'Te
st issue with packet size', u'id': 9317}, u'err': {u'msg': u'The change 
number specified has already
 been used', u'code': 204}}
 Making HTTP GET request to 
https://reviewboard-testcases/api/review-requests/9317/
 Making HTTP PUT request to 
https://reviewboard-testcases/api/review-requests/9317/
 Making HTTP GET request to 
https://reviewboard-testcases/api/review-requests/9317/diffs/
 Making HTTP POST request to 
https://reviewboard-testcases/api/review-requests/9317/diffs/
 Making HTTP GET request to 
https://reviewboard-testcases/api/review-requests/9317/draft/
Review request #9317 posted.

https://reviewboard-testcases/r/9317/
https://reviewboard-testcases/r/9317/diff/

On Tuesday, June 9, 2015 at 12:17:45 PM UTC-7, David Trowbridge wrote:

 Can you include the --debug output here?

 -David

 On Tue, Jun 9, 2015 at 10:23 AM Steve seide...@gmail.com javascript: 
 wrote:

 I just tested this with RBTools 0.6.3 and 0.7.3.  I ran rbt post with the 
 --debug option.  It reports the change list is already in use, which is 
 correct, but rather than updating the old review request it creates a new 
 one.  Is it because it thinks it's talking to a different repo?  That would 
 surprise me though because the repo ID is the same - just the port and 
 description changed.

 --Steve


 On Tuesday, June 9, 2015 at 7:23:08 AM UTC-7, Steve wrote:



 On Monday, June 8, 2015 at 3:00:31 PM UTC-7, David Trowbridge wrote:

 Steve,

 It's pretty hard for us to do support for post-review, since it's 
 completely obsolete (and 0.5.2 is pretty old). That said, can you give us 
 the output of running post-review with --debug in a case where this 
 problem 
 is showing up?

 BTW, why are you planning to upgrade to 0.6.3 instead of 0.7.3?



 I'd like to upgrade to 0.7.x but I can't because of Issue 3864.


 I'll try to test this repo problem with a newer RBTools just to see if 
 the problem is with RBTools or the server.

 Thanks

 --Steve

  


 -David

 On Mon, Jun 8, 2015 at 9:36 AM Steve seide...@gmail.com wrote:

 I forgot to mention that I restarted memcached on the servers too, but 
 the problem persists.

 --steve


 On Monday, June 8, 2015 at 9:28:21 AM UTC-7, Steve wrote:

 We changed our DNS entry for our perforce server over the weekend 
 which required me to change our port settings in ReviewBoard.  I edited 
 the 
 repo setting in the RB admin console and changed the name an path like 
 this:

 # Old
 Name: oldname:1666
 Path:   oldname:1666

 # New
 Name: perforce:1666
 Path:   perforce:1666

 The string 'perforce:1666'  is what is returned by 'p4 info' as the 
 'Server address'.  This works fine in the sense that all

Problem updating existing reviews after changing perforce port in repository settings

[Steve]

We changed our DNS entry for our perforce server over the weekend which 
required me to change our port settings in ReviewBoard.  I edited the repo 
setting in the RB admin console and changed the name an path like this:

# Old
Name: oldname:1666
Path:   oldname:1666

# New
Name: perforce:1666
Path:   perforce:1666

The string 'perforce:1666'  is what is returned by 'p4 info' as the 'Server 
address'.  This works fine in the sense that all the old reviews show the 
new perforce port string and the diffs are being properly displayed.  The 
problem occurs when we try to update a review that was created prior to the 
DNS change using post-review.  Instead of updating the old review, it 
creates a new one.  I've told my users they can get around this for the old 
reviews by adding the -r option to specify the review board id, but I'd 
like to understand what I may have done wrong.

We are currently using RBTools 0.5.2 and post-review, but we're planning to 
upgrade soon to 0.6.3 and rbt.  Our RB version is 1.7.28.  I'll try to test 
with the new RBTools, but I have a limited amount of old reviews that I can 
play with.


Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Problem updating existing reviews after changing perforce port in repository settings

[Steve]

I forgot to mention that I restarted memcached on the servers too, but the 
problem persists.

--steve

On Monday, June 8, 2015 at 9:28:21 AM UTC-7, Steve wrote:

 We changed our DNS entry for our perforce server over the weekend which 
 required me to change our port settings in ReviewBoard.  I edited the repo 
 setting in the RB admin console and changed the name an path like this:

 # Old
 Name: oldname:1666
 Path:   oldname:1666

 # New
 Name: perforce:1666
 Path:   perforce:1666

 The string 'perforce:1666'  is what is returned by 'p4 info' as the 
 'Server address'.  This works fine in the sense that all the old reviews 
 show the new perforce port string and the diffs are being properly 
 displayed.  The problem occurs when we try to update a review that was 
 created prior to the DNS change using post-review.  Instead of updating the 
 old review, it creates a new one.  I've told my users they can get around 
 this for the old reviews by adding the -r option to specify the review 
 board id, but I'd like to understand what I may have done wrong.

 We are currently using RBTools 0.5.2 and post-review, but we're planning 
 to upgrade soon to 0.6.3 and rbt.  Our RB version is 1.7.28.  I'll try to 
 test with the new RBTools, but I have a limited amount of old reviews that 
 I can play with.


 Thanks

 --Steve



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: when and how is .rbtools-cookies written?

[Steve]

I figured out my problem.  I need to refresh the api after I post to get a 
valid session.

# Bad way
rbt_api = rbclient.get_root()
post.Post().run_from_argv(args)
# Enter username/password
rr = rbt_api.get_review_request(...)

That didn't work.  This does

# Works
post.Post().run_from_argv(args)
# Enter username/password
rbt_api = rbclient.get_root()
rr = rbt_api.get_review_request(...)  

I don't fully understand the sequence, but it works and seems sensible so I 
thought I'd post it in case someone else runs into something similar.

Thanks

--Steve


On Wednesday, June 3, 2015 at 4:30:55 PM UTC-7, Steve wrote:

 Thanks Barret,

 I'm very confused about the cookie file behavior.  I tried to simplify it 
 as much as possible and found this:

 $ rbt post 814

 will write a new cookie file with a session id,  but calling rbt from a 
 python script in any of these ways:

 subprocess.call(rbt post 814, shel=True)

 subprocess.call(['rbt', 'post', '814'])

 or even

 os.system(rbt post 814)

 writes a cookie file with just the header and no session id.  I'm baffled.

 How are others calling rbt from python scripts and getting authentication 
 to work?

 --Steve


 On Tuesday, June 2, 2015 at 10:38:23 AM UTC-7, Barret Rennie wrote:

 Hey Steve,

 The cookie file is written inside of the ReviewBoardServer class (in 
 rbtools.api.request) when it is instantiated.

 Regards,
 Barret Rennie

 On Jun 2, 2015, at 11:29 AM, Steve seide...@gmail.com wrote:

 I have a wrapper to rbt that calls directly into Post.run_from_argv(). 
  I'm seeing different behavior regarding the saving of credentials in the 
 .rbtools-cookies file and am hoping someone can tell me where to look in 
 the code to understand this.  I've been stepping through the debugger, but 
 getting lost.

 Here's the problem I'm having.  On my main dev box, when prompted for 
 login, I get a proper .rbtools-cookies file.  But on my test machines, the 
 file gets written with only the header - no cookie - so I get prompted 
 every time.  

 Every configuration is using RBTools 0.6.3 and RB 2.0.15.  The only 
 difference that I can see is in python versions. 

 This works:

 RBTools 0.6.3, RB 2.0.15
 Python 2.7.8

 These combos don't work:

 RBTools 0.6.3 RB 2.0.15
 Python 2.7.5, Python 2.6.6

 I don't know if this is significant, but the successful case has this 
 line in the header:

 # http://curl.haxx.se/rfc/cookie_spec.html

 and all the others have this:

 # http://www.netscape.com/newsref/std/cookie_spec.html

 which may indicate a different authentication module is being used.  In 
 every case, rbt itself works correctly, so the problem is coming from my 
 calling directly into run_from_argv.  I don't expect anyone to solve this 
 for me but if I could get some clues as to where to look for the code that 
 saves the cookie file that would be very helpful.

 Thanks!

 --Steve


 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: when and how is .rbtools-cookies written?

[Steve]

Thanks Barret,

I'm very confused about the cookie file behavior.  I tried to simplify it 
as much as possible and found this:

$ rbt post 814

will write a new cookie file with a session id,  but calling rbt from a 
python script in any of these ways:

subprocess.call(rbt post 814, shel=True)

subprocess.call(['rbt', 'post', '814'])

or even

os.system(rbt post 814)

writes a cookie file with just the header and no session id.  I'm baffled.

How are others calling rbt from python scripts and getting authentication 
to work?

--Steve


On Tuesday, June 2, 2015 at 10:38:23 AM UTC-7, Barret Rennie wrote:

 Hey Steve,

 The cookie file is written inside of the ReviewBoardServer class (in 
 rbtools.api.request) when it is instantiated.

 Regards,
 Barret Rennie

 On Jun 2, 2015, at 11:29 AM, Steve seide...@gmail.com javascript: 
 wrote:

 I have a wrapper to rbt that calls directly into Post.run_from_argv(). 
  I'm seeing different behavior regarding the saving of credentials in the 
 .rbtools-cookies file and am hoping someone can tell me where to look in 
 the code to understand this.  I've been stepping through the debugger, but 
 getting lost.

 Here's the problem I'm having.  On my main dev box, when prompted for 
 login, I get a proper .rbtools-cookies file.  But on my test machines, the 
 file gets written with only the header - no cookie - so I get prompted 
 every time.  

 Every configuration is using RBTools 0.6.3 and RB 2.0.15.  The only 
 difference that I can see is in python versions. 

 This works:

 RBTools 0.6.3, RB 2.0.15
 Python 2.7.8

 These combos don't work:

 RBTools 0.6.3 RB 2.0.15
 Python 2.7.5, Python 2.6.6

 I don't know if this is significant, but the successful case has this line 
 in the header:

 # http://curl.haxx.se/rfc/cookie_spec.html

 and all the others have this:

 # http://www.netscape.com/newsref/std/cookie_spec.html

 which may indicate a different authentication module is being used.  In 
 every case, rbt itself works correctly, so the problem is coming from my 
 calling directly into run_from_argv.  I don't expect anyone to solve this 
 for me but if I could get some clues as to where to look for the code that 
 saves the cookie file that would be very helpful.

 Thanks!

 --Steve


 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools: when and how is .rbtools-cookies written?

[Steve]

I have a wrapper to rbt that calls directly into Post.run_from_argv().  I'm 
seeing different behavior regarding the saving of credentials in the 
.rbtools-cookies file and am hoping someone can tell me where to look in 
the code to understand this.  I've been stepping through the debugger, but 
getting lost.

Here's the problem I'm having.  On my main dev box, when prompted for 
login, I get a proper .rbtools-cookies file.  But on my test machines, the 
file gets written with only the header - no cookie - so I get prompted 
every time.  

Every configuration is using RBTools 0.6.3 and RB 2.0.15.  The only 
difference that I can see is in python versions. 

This works:

RBTools 0.6.3, RB 2.0.15
Python 2.7.8

These combos don't work:

RBTools 0.6.3 RB 2.0.15
Python 2.7.5, Python 2.6.6

I don't know if this is significant, but the successful case has this line 
in the header:

# http://curl.haxx.se/rfc/cookie_spec.html

and all the others have this:

# http://www.netscape.com/newsref/std/cookie_spec.html

which may indicate a different authentication module is being used.  In 
every case, rbt itself works correctly, so the problem is coming from my 
calling directly into run_from_argv.  I don't expect anyone to solve this 
for me but if I could get some clues as to where to look for the code that 
saves the cookie file that would be very helpful.

Thanks!

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools 0.7.3 is released!

[Steve]

I just tested 0.7.3 and one of the bugs marked as fixed is showing a 
different error now. I added a comment to the bug with the new error,  but 
I'm not sure if that will automatically reopen it or not.  In some ways 
it's worse now because I had a workaround for the original problem, but not 
for the new one.

The bug is 3864.  Please let me know if I need to do anything more to get 
this issue reopened.

Thanks!

--Steve

On Wednesday, May 27, 2015 at 5:48:26 PM UTC-7, Christian Hammond wrote:

 Hey everyone,

 We've put out a new release of RBTools 0.7.3, which fixes quite a number 
 of bugs, including those annoying Unicode issues many of you have hit. It 
 also has some new useful features you may want, like auto-stamping of 
 commits when posting changes for review.

 Along with this, we've added official support for Python Wheel packages, 
 allowing you to cleanly install with pip. We'll be extending this support 
 to Review Board in the next release.

 We're also now signing all our builds with our official PGP key (
 https://keybase.io/beanbag), so that you can verify anything you download 
 from us is legit.

 See the news post for more information:


 https://www.reviewboard.org/news/2015/05/27/rbtools-0-7-3-out-unicode-fixes-and-more/

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

ETA on RBTools 0.7.3?

[Steve]

Hi all,

I'm planning to roll out some new tools at my company that require bug 
fixes in 0.7.3.  I was wondering if you could provide a rough estimate of 
when 0.7.3 will be released so I can plan my rollout.

Thanks!

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: rbtools: How can I supress the INFO messages?

[Steve]

Thanks.  I saw that but I couldn't figure out how to change the logging 
level.  Having my script do this didn't work:

logging.basicConfig(level=logging.ERROR)

Nor did this:

logger = logging.getLogger()
logger.setLevel(logging.ERROR)

However, this worked:

logging.disable(logging.INFO)

I don't know enough about logging to know it that's the preferred method, 
but it gets the job done :)

--Steve

On Saturday, May 9, 2015 at 8:22:37 PM UTC-7, David Trowbridge wrote:

 I suggest looking at the init_logging method in 
 rbtools/commands/__init__.py

 -David

 On Sat, May 9, 2015 at 2:47 AM Steve seide...@gmail.com javascript: 
 wrote:

 This is a problem of my own creation, but hopefully someone can help me 
 out.  I'm essentially wrapping the functionality provided by the rbt suite 
 of commands with an in-house script.  What I'm doing is processing the 
 input args, performing specific tasks that we need, and then eventually 
 passing the rest on via run_from_argv().

 For example, to create new review,  the code distills down to this:

 from rbtools.commands import post
 p = post.Post()
 p.run_from_argv(args)

 This works fine, except that the logging messages from Post are now being 
 printed to the console:

 $ myrbt post 821
 .INFO:root:Generating diff for pending changeset 821
 Generating diff for pending changeset 821
 Review request #9 posted.

 I am hopelessly lost when it comes to using python logging, but I know 
 that  rbt suppress these message and I can't figure out how.  Can someone 
 nudge me in the right direction?

 Thanks!

 --Steve


  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

rbtools: How can I supress the INFO messages?

[Steve]

This is a problem of my own creation, but hopefully someone can help me 
out.  I'm essentially wrapping the functionality provided by the rbt suite 
of commands with an in-house script.  What I'm doing is processing the 
input args, performing specific tasks that we need, and then eventually 
passing the rest on via run_from_argv().

For example, to create new review,  the code distills down to this:

from rbtools.commands import post
p = post.Post()
p.run_from_argv(args)

This works fine, except that the logging messages from Post are now being 
printed to the console:

$ myrbt post 821
.INFO:root:Generating diff for pending changeset 821
Generating diff for pending changeset 821
Review request #9 posted.

I am hopelessly lost when it comes to using python logging, but I know 
that  rbt suppress these message and I can't figure out how.  Can someone 
nudge me in the right direction?

Thanks!

--Steve


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

[Steve]

Hi Chris, 

Just to close the loop on this topic - the problem with the diffs that I 
mentioned turned out to be a memcache issue.  Turns out that using memcache 
on a test machine where you're continually deleting and recreating a 
perforce depot and rb site, thus reusing change list numbers, can be very 
confusing to memcached :)  I turned off memcache and then got the diffs I 
was expecting.

--Steve

On Wednesday, May 6, 2015 at 10:49:14 AM UTC-7, Steve wrote:

 Issue 3864 created.

 Thanks!

 --Steve


 On Tuesday, May 5, 2015 at 7:14:07 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 Glad it hear it (with the exception of the diff not being correct).

 I'd appreciate a bug report on it. I won't be able to get to this right 
 away, so having all these details will help for later.

 Thanks!

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Tue, May 5, 2015 at 7:10 PM, Steve seide...@gmail.com wrote:

 Hi Chris,

 The good news is, your diagnosis is correct.  Use of '-g no' got past 
 the error.  The bad news is, the diff posted is not correct.  But I found 
 that the diff posted with 0.6.3 is the same incorrect diff (it's incomplete 
 and appears to be a single change instead of a range), so I'm going to have 
 to investigate that some more and get back to you.

 Do I need to file a bug on this issue, or do you have enough already to 
 resolve it?

 Thanks!

 --Steve

 On Tuesday, May 5, 2015 at 6:52:29 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 This looks like a bug with the commit message guessing feature and 
 Perforce revision ranges. Can you try running the same command with '-g 
 no' 
 ?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Tue, May 5, 2015 at 6:04 PM, Steve seide...@gmail.com wrote:

 I've been doing a fair amount of testing of RBTools in preparation for 
 moving to RB 2.0 and I've come across a few important issues that are 
 preventing us from moving to RBTools 0.7.  The 2 most significant ones 
 appear to be regressions as my tests pass in 0.6.3 but fail in 0.7.2.

 The first issue has already been reported by someone else as issue 
 3843.  I've reproduced it and added a comment saying that it doesn't 
 happen 
 in 0.6.3 and I can provide a test file if desired.

 The second issue comes up when I try to post a review using a range of 
 perforce change lists.  This always worked for us with post-review, and 
 it 
 works with RBTools 0.6.3, but fails with 0.7.2.  Here's an example:

 $  rbt --version
 RBTools 0.6.3
 $ rbt post  //depot/Jam/MAIN/src/...@813,@823
 Review request #11 posted.

 http://localhost/r/11/
 http://localhost/r/11/diff/

 I discarded that review and then ran the same exact command against 
 the same repo using RBTools 0.7.2. I had to add the debug option to get 
 any 
 useful output:
 $  rbt --version
 RBTools 0.7.2
 $ rbt post  -d  //depot/Jam/MAIN/src/...@813,@823

 snip

 +Test submitting a review with a shelve and no ship its.
 ---
  Writing //depot/Jam/MAIN/src/RELNOTES#77 to /tmp/tmpQNewPu
  Running: p4 print -o /tmp/tmpQNewPu -q 
 //depot/Jam/MAIN/src/RELNOTES#77
  Writing //depot/Jam/MAIN/src/RELNOTES#78 to /tmp/tmpUJo72G
  Running: p4 print -o /tmp/tmpUJo72G -q 
 //depot/Jam/MAIN/src/RELNOTES#78
  Running: diff -urNp /tmp/tmpQNewPu /tmp/tmpUJo72G
  Command exited with rc 1: [u'diff', u'-urNp', '/tmp/tmpQNewPu', 
 '/tmp/tmpUJo72G']
 --- /tmp/tmpQNewPu  2015-05-05 17:54:57.889010010 -0700
 +++ /tmp/tmpUJo72G  2015-05-05 17:54:57.893009847 -0700
 @@ -548,3 +548,4 @@ Release notes for Jam 2.0.
  
 A poorly set $(JAMSHELL) is likely to result in silent
 failure.
 +Test creating with 2 jobs.
 ---
  Making HTTP GET request to http://localhost/api/validation/diffs/
  Cached response for HTTP GET 
 http://localhost/api/validation/diffs/ expired and was modified
  Making HTTP POST request to http://localhost/api/validation/diffs/
 Traceback (most recent call last):
   File /home/sallan/envs/rbtools-0.7.2/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/main.py,
  
 line 133, in main
 command.run_from_argv([RB_MAIN, command_name] + args)
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/__init__.py,
  
 line 555, in run_from_argv
 exit_code = self.main(*args) or 0
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py,
  
 line 714, in main
 self.check_guess_fields()
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py,
  
 line 553, in check_guess_fields

RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

[Steve]

I've been doing a fair amount of testing of RBTools in preparation for 
moving to RB 2.0 and I've come across a few important issues that are 
preventing us from moving to RBTools 0.7.  The 2 most significant ones 
appear to be regressions as my tests pass in 0.6.3 but fail in 0.7.2.

The first issue has already been reported by someone else as issue 3843. 
 I've reproduced it and added a comment saying that it doesn't happen in 
0.6.3 and I can provide a test file if desired.

The second issue comes up when I try to post a review using a range of 
perforce change lists.  This always worked for us with post-review, and it 
works with RBTools 0.6.3, but fails with 0.7.2.  Here's an example:

$  rbt --version
RBTools 0.6.3
$ rbt post  //depot/Jam/MAIN/src/...@813,@823
Review request #11 posted.

http://localhost/r/11/
http://localhost/r/11/diff/

I discarded that review and then ran the same exact command against the 
same repo using RBTools 0.7.2. I had to add the debug option to get any 
useful output:
$  rbt --version
RBTools 0.7.2
$ rbt post  -d  //depot/Jam/MAIN/src/...@813,@823

snip

+Test submitting a review with a shelve and no ship its.
---
 Writing //depot/Jam/MAIN/src/RELNOTES#77 to /tmp/tmpQNewPu
 Running: p4 print -o /tmp/tmpQNewPu -q //depot/Jam/MAIN/src/RELNOTES#77
 Writing //depot/Jam/MAIN/src/RELNOTES#78 to /tmp/tmpUJo72G
 Running: p4 print -o /tmp/tmpUJo72G -q //depot/Jam/MAIN/src/RELNOTES#78
 Running: diff -urNp /tmp/tmpQNewPu /tmp/tmpUJo72G
 Command exited with rc 1: [u'diff', u'-urNp', '/tmp/tmpQNewPu', 
'/tmp/tmpUJo72G']
--- /tmp/tmpQNewPu  2015-05-05 17:54:57.889010010 -0700
+++ /tmp/tmpUJo72G  2015-05-05 17:54:57.893009847 -0700
@@ -548,3 +548,4 @@ Release notes for Jam 2.0.
 
A poorly set $(JAMSHELL) is likely to result in silent
failure.
+Test creating with 2 jobs.
---
 Making HTTP GET request to http://localhost/api/validation/diffs/
 Cached response for HTTP GET http://localhost/api/validation/diffs/ 
expired and was modified
 Making HTTP POST request to http://localhost/api/validation/diffs/
Traceback (most recent call last):
  File /home/sallan/envs/rbtools-0.7.2/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
  File 
/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/main.py,
 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/__init__.py,
 
line 555, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py,
 
line 714, in main
self.check_guess_fields()
  File 
/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py,
 
line 553, in check_guess_fields
assert self.revisions
AssertionError


When I ran it under a debugger, I found that it was trying to run 

p4 change  //depot/Jam/MAIN/src/...@813,@823

which understandably failed.  So something changed drastically between 0.6 
and 0.7.  Any ideas as to why this use case no longer works in 0.7? 

Please let me know if I can provide any more information.

Thanks!

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

[Steve]

Hi Chris,

The good news is, your diagnosis is correct.  Use of '-g no' got past the 
error.  The bad news is, the diff posted is not correct.  But I found that 
the diff posted with 0.6.3 is the same incorrect diff (it's incomplete and 
appears to be a single change instead of a range), so I'm going to have to 
investigate that some more and get back to you.

Do I need to file a bug on this issue, or do you have enough already to 
resolve it?

Thanks!

--Steve

On Tuesday, May 5, 2015 at 6:52:29 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 This looks like a bug with the commit message guessing feature and 
 Perforce revision ranges. Can you try running the same command with '-g no' 
 ?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Tue, May 5, 2015 at 6:04 PM, Steve seide...@gmail.com javascript: 
 wrote:

 I've been doing a fair amount of testing of RBTools in preparation for 
 moving to RB 2.0 and I've come across a few important issues that are 
 preventing us from moving to RBTools 0.7.  The 2 most significant ones 
 appear to be regressions as my tests pass in 0.6.3 but fail in 0.7.2.

 The first issue has already been reported by someone else as issue 3843.  
 I've reproduced it and added a comment saying that it doesn't happen in 
 0.6.3 and I can provide a test file if desired.

 The second issue comes up when I try to post a review using a range of 
 perforce change lists.  This always worked for us with post-review, and it 
 works with RBTools 0.6.3, but fails with 0.7.2.  Here's an example:

 $  rbt --version
 RBTools 0.6.3
 $ rbt post  //depot/Jam/MAIN/src/...@813,@823
 Review request #11 posted.

 http://localhost/r/11/
 http://localhost/r/11/diff/

 I discarded that review and then ran the same exact command against the 
 same repo using RBTools 0.7.2. I had to add the debug option to get any 
 useful output:
 $  rbt --version
 RBTools 0.7.2
 $ rbt post  -d  //depot/Jam/MAIN/src/...@813,@823

 snip

 +Test submitting a review with a shelve and no ship its.
 ---
  Writing //depot/Jam/MAIN/src/RELNOTES#77 to /tmp/tmpQNewPu
  Running: p4 print -o /tmp/tmpQNewPu -q 
 //depot/Jam/MAIN/src/RELNOTES#77
  Writing //depot/Jam/MAIN/src/RELNOTES#78 to /tmp/tmpUJo72G
  Running: p4 print -o /tmp/tmpUJo72G -q 
 //depot/Jam/MAIN/src/RELNOTES#78
  Running: diff -urNp /tmp/tmpQNewPu /tmp/tmpUJo72G
  Command exited with rc 1: [u'diff', u'-urNp', '/tmp/tmpQNewPu', 
 '/tmp/tmpUJo72G']
 --- /tmp/tmpQNewPu  2015-05-05 17:54:57.889010010 -0700
 +++ /tmp/tmpUJo72G  2015-05-05 17:54:57.893009847 -0700
 @@ -548,3 +548,4 @@ Release notes for Jam 2.0.
  
 A poorly set $(JAMSHELL) is likely to result in silent
 failure.
 +Test creating with 2 jobs.
 ---
  Making HTTP GET request to http://localhost/api/validation/diffs/
  Cached response for HTTP GET http://localhost/api/validation/diffs/ 
 expired and was modified
  Making HTTP POST request to http://localhost/api/validation/diffs/
 Traceback (most recent call last):
   File /home/sallan/envs/rbtools-0.7.2/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/main.py,
  
 line 133, in main
 command.run_from_argv([RB_MAIN, command_name] + args)
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/__init__.py,
  
 line 555, in run_from_argv
 exit_code = self.main(*args) or 0
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py,
  
 line 714, in main
 self.check_guess_fields()
   File 
 /home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py,
  
 line 553, in check_guess_fields
 assert self.revisions
 AssertionError


 When I ran it under a debugger, I found that it was trying to run 

 p4 change  //depot/Jam/MAIN/src/...@813,@823

 which understandably failed.  So something changed drastically between 
 0.6 and 0.7.  Any ideas as to why this use case no longer works in 0.7? 

 Please let me know if I can provide any more information.

 Thanks!

 --Steve

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org

Re: RBtools and submitter issue and other questions

[Steve]

Thanks David.  I think I've been using --username when I should be using 
--submit-as.  How does RB authenticate the --submit-as user?

--Steve

On Wednesday, April 29, 2015 at 5:02:49 PM UTC-7, David Trowbridge wrote:

 --username is for authenticating to the review board server. --submit-as 
 is for impersonating another user (assuming the authenticated user has the 
 right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to post 
 review requests on behalf of others is the use case for --submit-as.

 -David
 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com javascript: 
 wrote:

 Which makes me wonder - what is the difference between the --username and 
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBtools and submitter issue and other questions

[Steve]

We have a shared perforce account for doing merges called merge_master.  
Here's a typical workflow:

$ ssh sallan@mergehost
$ sudo su - merge_master
$ run_merge 

Once conflicts are resolved, we sometimes post for a review, but we want to 
do that as ourselves, not as merge_master

We've been doing that with --username

$ rbt post --username sallan CL

But that leaves a cookie behind in my name, so if the next person comes 
along and runs rbt without --username, they end up creating a review in my 
name, which is awkward. Maybe using --submit-as would be better?

--steve

On Thursday, April 30, 2015 at 11:35:32 AM UTC-7, David Trowbridge wrote:

 Can you clarify your use case? These two things shouldn't be easy to 
 misuse.

 -David
 On Thu, Apr 30, 2015 at 11:31 AM Steve seide...@gmail.com javascript: 
 wrote:

 Thanks David.  I think I've been using --username when I should be using 
 --submit-as.  How does RB authenticate the --submit-as user?

 --Steve


 On Wednesday, April 29, 2015 at 5:02:49 PM UTC-7, David Trowbridge wrote:

 --username is for authenticating to the review board server. --submit-as 
 is for impersonating another user (assuming the authenticated user has the 
 right permissions) after authentication.

 The aforementioned scenario (having a post-commit hook or CI task) to 
 post review requests on behalf of others is the use case for --submit-as.

 -David

 On Wed, Apr 29, 2015 at 3:42 PM Steve seide...@gmail.com wrote:

 Which makes me wonder - what is the difference between the --username and 
 --submit-as options?

 --Steve


 On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted 
 in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing 
 is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBtools and submitter issue and other questions

[Steve]

Which makes me wonder - what is the difference between the --username and 
--submit-as options?

--Steve

On Tuesday, April 28, 2015 at 11:11:13 PM UTC-7, MoonWalker wrote:

 Found it :-). Seems like --submit-as username will do the trick

 On Wednesday, April 29, 2015 at 3:19:39 PM UTC+10, MoonWalker wrote:

 We are using Jenkins in our CI, and we have a job that takes care of 
 doing some testing and if everything goes well a review will be posted in 
 Reviewboard (2.0.15). Everything seems okay, the issue that I am facing is 
 that I had to create a new user in RB called jenkins and the user that 
 trigger the job is not able to modify the review because he was not the 
 direct submitter. Is there any way to make a group capable to modify by 
 default any review that targets the group?.  



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools: Is this a bug in the way 'rbt --username' handles authentication?

[Steve]

I'm testing out 

RB 2.0.15
RBTools 0.7.2

and I've noticed something about how the --username option is handled that 
I think is a bug, but I wanted to run it by you all before filing a bug 
report.  

What I've found is that when I do

rbt post --username me 1234

I always get prompted for a password.  If I already have a valid cookie in 
.rbtools-cookies file, then I can type anything and the review will go 
through.  If however I delete my .rbtools-cookie file, try again then the 
authentication is done correctly.  Does that make sense?  It seems somehow 
wrong to me.

This example may make it clearer.

$ rm ~/.rbtools-cookies
$ rbt post --username sallan 824

Please log in to the Review Board server at localhost.
Password: *bogus_password*
ERROR: Unexpected API Error: The username or password was not correct (HTTP 
401, API Error 104)

$ rbt post --username sallan 824

Please log in to the Review Board server at localhost.
Password: *correct_password*
Generating diff for pending changeset 824
Review request #10 posted.

http://localhost/r/10/
http://localhost/r/10/diff/

$ rbt post --username sallan 824

Please log in to the Review Board server at localhost.
Password: *bogus_password*
Generating diff for pending changeset 824
Review request #10 posted.

http://localhost/r/10/
http://localhost/r/10/diff/

Notice the second time the bogus_password is accepted because I now have a 
cookie. If that's the case, why prompt? Is this a bug? Would you like me to 
file a report?

--Steve


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

[Steve]

Issue 3855 entered.

--Steve


On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote:

 Would you mind filing a bug on our issue tracker?

 Thanks,
 -David

 On Tue, Apr 21, 2015 at 2:35 PM Steve seide...@gmail.com javascript: 
 wrote:

 Oops, sorry for forgetting that.

 Review Board 2.0.15
 RBTools 0.7.2

 --steve


 On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote:

 What version of Review Board and RBTools are you running?

 -David

 On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com wrote:

 Looking further into this, it appears that when I run

 rbt post -r 3 CL

 commit_id for RR 3 gets updated with the new cl number, but changenum 
 does not.  The docs say that changenum is being deprecated in favor of 
 commit_id, but from what I can see, it's the value in changenum that is 
 being displayed in the review web page.

 Is it just me, or are others seeing the same behavior?

 --Steve


 On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an 
 existing review request using the -r option that the change list number 
 is 
 not updated in the review.  I think the review request should update the 
 change list since that's the CL that reflects the current set of diffs, 
 but 
 there may be good reasons to not update it.  So I guess my question is, 
 is 
 this a bug or a feature?

 Since we use perforce, one of the consequences of not updating it is 
 that when the change list is submitted, it won't get automatically 
 updated 
 in the review request with the actual submitted change list number, 
 because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Command Line tool for Review Board administration

[Steve]

For my test suite, I create a perforce repo using the api this way:

from rbtools.api.client import RBClient

client = RBClient(http://localhost;)
client.login(sallan, sallan)
root = client.get_root()
root.get_repositories().create(name='perforce', tool=Perforce, 
path=localhost:1492)

--Steve


On Thursday, April 23, 2015 at 3:43:18 AM UTC-7, GC wrote:

 Thanks for the reply Christian. As far as our requests related to 
 repositories is concerned, it’s only about adding (not updating) Name, 
 Repository type, Path and Mirror path.


 I checked the API link for repository resource. Although I could find 
 fields for Name, Path and Mirror path, i could not find any field for 
 ‘Repository type’ (Bazaaar, Clearcase, CVS etc). Is ‘tool’ field what I’m 
 looking for? More importantly, it looks like the API supports only updation 
 not addition. Please correct me if I’m wrong. 



 https://www.reviewboard.org/docs/manual/2.5/webapi/2.0/resources/repository/



 Regards,

 Gaurav 



 On Thursday, April 23, 2015 at 2:45:15 AM UTC+5:30, Christian Hammond 
 wrote:

 Hi,

 We don't provide a tool for adding those (though that'd be a handy 
 project for someone to work on). We do have an API, though, for 
 adding/manipulating repositories, default reviewers, review requests, and 
 just about anything else.

 It does not support adding users, though. Most people use an LDAP or 
 Active Directory server when they need that kind of ability. That said, I'm 
 not opposed to adding that functionality, but it'd be low on our todo list, 
 so the best way to get that into the product is by writing a patch and 
 contributing it.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Wed, Apr 22, 2015 at 3:04 AM, GC varuag@gmail.com wrote:

 Hi,


 Does Review Board provides a CLI for administrators? We use Git as our 
 version control system and we receive following requests from time-to-time:

 Add repository
 Add user
 Add reviewers (Not very frequent)

 Although these operations don’t consume much time, I would like to 
 automate them, if possible.


 Thanks

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Installation of 1.7.28 on new CentOS 6.6 box fails to find django-evolution-0.6.9

[Steve]

Our current servers are on CentOS 6.6 running RB 1.7.28.  I'm preparing to 
upgrade to 2.0 or 2.5, so I want to test out the migration.  To do that, 
I'm trying to install 1.7.28 on a fresh CentOS6.6 VM.  After installing the 
pre-reqs, I ran

easy_install ReviewBoard==1.7.28

It fails with this message:

Installed /usr/lib/python2.6/site-packages/Djblets-0.7.31-py2.6.egg
Reading http://downloads.reviewboard.org/releases/Djblets/0.7/
Searching for django-evolution=0.6.9,0.7
Reading http://pypi.python.org/simple/django_evolution/
Best match: django-evolution 0.6.9
Downloading 
http://downloads.reviewboard.org/releases/django-evolution/0.6/django_evolution-0.6.9-py2.6.egg#md5=d41d8cd98f00b204e9800998ecf8427e
Processing django_evolution-0.6.9-py2.6.egg
Traceback (most recent call last):
  File /usr/bin/easy_install, line 9, in module
load_entry_point('distribute==0.6.10', 'console_scripts', 
'easy_install')()
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
1715, in main
with_ei_usage(lambda:
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
1696, in with_ei_usage
return f()
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
1719, in lambda
distclass=DistributionWithoutHelpCommands, **kw
  File /usr/lib64/python2.6/distutils/core.py, line 152, in setup
dist.run_commands()
  File /usr/lib64/python2.6/distutils/dist.py, line 975, in run_commands
self.run_command(cmd)
  File /usr/lib64/python2.6/distutils/dist.py, line 995, in run_command
cmd_obj.run()
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
236, in run
self.easy_install(spec, not self.no_deps)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
472, in easy_install
return self.install_item(spec, dist.location, tmpdir, deps)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
504, in install_item
self.process_distribution(spec, dist, deps)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
545, in process_distribution
[requirement], self.local_index, self.easy_install
  File /usr/lib/python2.6/site-packages/pkg_resources.py, line 538, in 
resolve
dist = best[req.key] = env.best_match(req, self, installer)
  File /usr/lib/python2.6/site-packages/pkg_resources.py, line 780, in 
best_match
return self.obtain(req, installer) # try and download/install
  File /usr/lib/python2.6/site-packages/pkg_resources.py, line 792, in 
obtain
return installer(requirement)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
472, in easy_install
return self.install_item(spec, dist.location, tmpdir, deps)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
502, in install_item
dists = self.install_eggs(spec, download, tmpdir)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
645, in install_eggs
return [self.install_egg(dist_filename, tmpdir)]
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
696, in install_egg
dist = self.egg_distribution(egg_path)
  File 
/usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
687, in egg_distribution
metadata = EggMetadata(zipimport.zipimporter(egg_path))
zipimport.ZipImportError: can't read Zip file: 
'/tmp/easy_install-CNWVTO/django_evolution-0.6.9-py2.6.egg'


Does this line indicate it's confused about the version?

load_entry_point('distribute==0.6.10', 'console_scripts', 'easy_install')()

Or is that something different.  I'm not sure how to proceed. I tried 
leaving off the patch number and installing this way:

easy_install ReviewBoard==1.7

But I got different, uglier errors, so I thought I'd try to fix the 1.7.28 
problem first, since that's what I really want for testing. Can anybody 
help me fix this?

--Steve



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Installation of 1.7.28 on new CentOS 6.6 box fails to find django-evolution-0.6.9

[Steve]

Yup, it's all good now.  Thanks!

--Steve


On Thursday, April 23, 2015 at 12:37:07 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 Give it a try now. Looks like a recent migration of the django_evolution 
 packages resulted in that file being truncated. I've fixed this and tested 
 the installation locally.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Thu, Apr 23, 2015 at 12:28 PM, Christian Hammond chi...@chipx86.com 
 javascript: wrote:

 Hi Steve,

 I can confirm this. Let me see what I can see, and I'll get back to you.

 (You'll definitely need the patch number for ReviewBoard.)

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Thu, Apr 23, 2015 at 12:17 PM, Steve seide...@gmail.com javascript:
  wrote:

 Our current servers are on CentOS 6.6 running RB 1.7.28.  I'm preparing 
 to upgrade to 2.0 or 2.5, so I want to test out the migration.  To do that, 
 I'm trying to install 1.7.28 on a fresh CentOS6.6 VM.  After installing the 
 pre-reqs, I ran

 easy_install ReviewBoard==1.7.28

 It fails with this message:

 Installed /usr/lib/python2.6/site-packages/Djblets-0.7.31-py2.6.egg
 Reading http://downloads.reviewboard.org/releases/Djblets/0.7/
 Searching for django-evolution=0.6.9,0.7
 Reading http://pypi.python.org/simple/django_evolution/
 Best match: django-evolution 0.6.9
 Downloading 
 http://downloads.reviewboard.org/releases/django-evolution/0.6/django_evolution-0.6.9-py2.6.egg#md5=d41d8cd98f00b204e9800998ecf8427e
 Processing django_evolution-0.6.9-py2.6.egg
 Traceback (most recent call last):
   File /usr/bin/easy_install, line 9, in module
 load_entry_point('distribute==0.6.10', 'console_scripts', 
 'easy_install')()
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 1715, in main
 with_ei_usage(lambda:
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 1696, in with_ei_usage
 return f()
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 1719, in lambda
 distclass=DistributionWithoutHelpCommands, **kw
   File /usr/lib64/python2.6/distutils/core.py, line 152, in setup
 dist.run_commands()
   File /usr/lib64/python2.6/distutils/dist.py, line 975, in 
 run_commands
 self.run_command(cmd)
   File /usr/lib64/python2.6/distutils/dist.py, line 995, in run_command
 cmd_obj.run()
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 236, in run
 self.easy_install(spec, not self.no_deps)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 472, in easy_install
 return self.install_item(spec, dist.location, tmpdir, deps)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 504, in install_item
 self.process_distribution(spec, dist, deps)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 545, in process_distribution
 [requirement], self.local_index, self.easy_install
   File /usr/lib/python2.6/site-packages/pkg_resources.py, line 538, in 
 resolve
 dist = best[req.key] = env.best_match(req, self, installer)
   File /usr/lib/python2.6/site-packages/pkg_resources.py, line 780, in 
 best_match
 return self.obtain(req, installer) # try and download/install
   File /usr/lib/python2.6/site-packages/pkg_resources.py, line 792, in 
 obtain
 return installer(requirement)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 472, in easy_install
 return self.install_item(spec, dist.location, tmpdir, deps)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 502, in install_item
 dists = self.install_eggs(spec, download, tmpdir)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 645, in install_eggs
 return [self.install_egg(dist_filename, tmpdir)]
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 696, in install_egg
 dist = self.egg_distribution(egg_path)
   File 
 /usr/lib/python2.6/site-packages/setuptools/command/easy_install.py, line 
 687, in egg_distribution
 metadata = EggMetadata(zipimport.zipimporter(egg_path))
 zipimport.ZipImportError: can't read Zip file: 
 '/tmp/easy_install-CNWVTO/django_evolution-0.6.9-py2.6.egg'


 Does this line indicate it's confused about the version?

 load_entry_point('distribute==0.6.10', 'console_scripts', 
 'easy_install')()

 Or is that something different.  I'm not sure how to proceed. I tried 
 leaving off the patch number and installing this way:

 easy_install ReviewBoard==1.7

 But I got different, uglier errors, so I thought I'd try to fix the 
 1.7.28 problem first, since that's what I really want

RB 1.7.28 with Python 2.6.6 is requring non-existant importlib

[Steve]

I've installed RB 1.7.28 on a new CentOS 6.6. VM which has python 2.6.6.  
When I run 

rb-site install /var/www/rb

I get this error:

* Installing the site...
Building site directories ... OK
Building site configuration files ... OK
Creating database ... 
[!] Unable to execute the manager command syncdb: No module named
importlib
 Error: One or more models did not validate:
 scmtools.repository: 'review_groups' has an m2m relation with model 
reviews.Group, which has either not been installed or is abstract.

If the installer is expecting importlib, that may be a problem since I 
believe that's new in Python 2.7.  Or was importlib supposed to be 
installed with RB?

--Steve




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RB 1.7.28 with Python 2.6.6 is requring non-existant importlib

[Steve]

easy_install importlib

fixes the problem, but it looks like a dependency is missing in the rb 
installer.

--Steve

On Thursday, April 23, 2015 at 2:09:43 PM UTC-7, Steve wrote:

 I've installed RB 1.7.28 on a new CentOS 6.6. VM which has python 2.6.6.  
 When I run 

 rb-site install /var/www/rb

 I get this error:

 * Installing the site...
 Building site directories ... OK
 Building site configuration files ... OK
 Creating database ... 
 [!] Unable to execute the manager command syncdb: No module named
 importlib
  Error: One or more models did not validate:
  scmtools.repository: 'review_groups' has an m2m relation with model 
 reviews.Group, which has either not been installed or is abstract.

 If the installer is expecting importlib, that may be a problem since I 
 believe that's new in Python 2.7.  Or was importlib supposed to be 
 installed with RB?

 --Steve






-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RB 1.7.28 with Python 2.6.6 is requring non-existant importlib

[Steve]

Here's what got installed:

[root@localhost site-packages]# ls -d *jan*
Django-1.4.20-py2.6.egg  django_evolution-0.6.9-py2.6.egg  
django_pipeline-1.2.24-py2.6.egg

--steve

On Thursday, April 23, 2015 at 2:33:12 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 We shouldn't need that dependency. I remember seeing this somewhere 
 recently, and think it had to do with the version of Django, maybe? Can you 
 just verify what version you're running?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Thu, Apr 23, 2015 at 2:13 PM, Steve seide...@gmail.com javascript: 
 wrote:

 easy_install importlib

 fixes the problem, but it looks like a dependency is missing in the rb 
 installer.

 --Steve


 On Thursday, April 23, 2015 at 2:09:43 PM UTC-7, Steve wrote:

 I've installed RB 1.7.28 on a new CentOS 6.6. VM which has python 
 2.6.6.  When I run 

 rb-site install /var/www/rb

 I get this error:

 * Installing the site...
 Building site directories ... OK
 Building site configuration files ... OK
 Creating database ... 
 [!] Unable to execute the manager command syncdb: No module named
 importlib
 Error: One or more models did not validate:
 scmtools.repository: 'review_groups' has an m2m relation with model 
 reviews.Group, which has either not been installed or is abstract.

 If the installer is expecting importlib, that may be a problem since I 
 believe that's new in Python 2.7.  Or was importlib supposed to be 
 installed with RB?

 --Steve




  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RB 1.7.28 with Python 2.6.6 is requring non-existant importlib

[Steve]

Yes, it's working now.  And I checked my current 1.7.28 production servers 
and they all have importlib installed, but I don't know how or when it was 
installed.

--Steve


On Thursday, April 23, 2015 at 2:55:52 PM UTC-7, Christian Hammond wrote:

 Weird.

 I just checked the source of Django, Review Board, and Django Evolution. 
 The only references to importlib in any of those are Django's bundled 
 version (django.utils.importlib), so that shouldn't be happening, unless 
 there's some other module involved somewhere in the process that's causing 
 that. It would require some manual tracing to figure it out, though...

 Is it working after you installed importlib?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Thu, Apr 23, 2015 at 2:45 PM, Steve seide...@gmail.com javascript: 
 wrote:

 Here's what got installed:

 [root@localhost site-packages]# ls -d *jan*
 Django-1.4.20-py2.6.egg  django_evolution-0.6.9-py2.6.egg  
 django_pipeline-1.2.24-py2.6.egg

 --steve

 On Thursday, April 23, 2015 at 2:33:12 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 We shouldn't need that dependency. I remember seeing this somewhere 
 recently, and think it had to do with the version of Django, maybe? Can you 
 just verify what version you're running?

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Thu, Apr 23, 2015 at 2:13 PM, Steve seide...@gmail.com wrote:

 easy_install importlib

 fixes the problem, but it looks like a dependency is missing in the rb 
 installer.

 --Steve


 On Thursday, April 23, 2015 at 2:09:43 PM UTC-7, Steve wrote:

 I've installed RB 1.7.28 on a new CentOS 6.6. VM which has python 
 2.6.6.  When I run 

 rb-site install /var/www/rb

 I get this error:

 * Installing the site...
 Building site directories ... OK
 Building site configuration files ... OK
 Creating database ... 
 [!] Unable to execute the manager command syncdb: No module named
 importlib
 Error: One or more models did not validate:
 scmtools.repository: 'review_groups' has an m2m relation with model 
 reviews.Group, which has either not been installed or is abstract.

 If the installer is expecting importlib, that may be a problem since I 
 believe that's new in Python 2.7.  Or was importlib supposed to be 
 installed with RB?

 --Steve




  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.





-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

[Steve]

Actually, maybe I should be testing out 2.5 anyway.  I think I'll give that 
a try first.

--steve

On Wednesday, April 22, 2015 at 2:53:10 PM UTC-7, Steve wrote:

 Will do.  Thanks!


 On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote:

 Would you mind filing a bug on our issue tracker?

 Thanks,
 -David

 On Tue, Apr 21, 2015 at 2:35 PM Steve seide...@gmail.com wrote:

 Oops, sorry for forgetting that.

 Review Board 2.0.15
 RBTools 0.7.2

 --steve


 On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote:

 What version of Review Board and RBTools are you running?

 -David

 On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com wrote:

 Looking further into this, it appears that when I run

 rbt post -r 3 CL

 commit_id for RR 3 gets updated with the new cl number, but changenum 
 does not.  The docs say that changenum is being deprecated in favor of 
 commit_id, but from what I can see, it's the value in changenum that is 
 being displayed in the review web page.

 Is it just me, or are others seeing the same behavior?

 --Steve


 On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an 
 existing review request using the -r option that the change list number 
 is 
 not updated in the review.  I think the review request should update the 
 change list since that's the CL that reflects the current set of diffs, 
 but 
 there may be good reasons to not update it.  So I guess my question is, 
 is 
 this a bug or a feature?

 Since we use perforce, one of the consequences of not updating it is 
 that when the change list is submitted, it won't get automatically 
 updated 
 in the review request with the actual submitted change list number, 
 because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

[Steve]

Will do.  Thanks!


On Tuesday, April 21, 2015 at 3:22:32 PM UTC-7, David Trowbridge wrote:

 Would you mind filing a bug on our issue tracker?

 Thanks,
 -David

 On Tue, Apr 21, 2015 at 2:35 PM Steve seide...@gmail.com javascript: 
 wrote:

 Oops, sorry for forgetting that.

 Review Board 2.0.15
 RBTools 0.7.2

 --steve


 On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote:

 What version of Review Board and RBTools are you running?

 -David

 On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com wrote:

 Looking further into this, it appears that when I run

 rbt post -r 3 CL

 commit_id for RR 3 gets updated with the new cl number, but changenum 
 does not.  The docs say that changenum is being deprecated in favor of 
 commit_id, but from what I can see, it's the value in changenum that is 
 being displayed in the review web page.

 Is it just me, or are others seeing the same behavior?

 --Steve


 On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an 
 existing review request using the -r option that the change list number 
 is 
 not updated in the review.  I think the review request should update the 
 change list since that's the CL that reflects the current set of diffs, 
 but 
 there may be good reasons to not update it.  So I guess my question is, 
 is 
 this a bug or a feature?

 Since we use perforce, one of the consequences of not updating it is 
 that when the change list is submitted, it won't get automatically 
 updated 
 in the review request with the actual submitted change list number, 
 because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

[Steve]

Oops, sorry for forgetting that.

Review Board 2.0.15
RBTools 0.7.2

--steve


On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote:

 What version of Review Board and RBTools are you running?

 -David

 On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com javascript: 
 wrote:

 Looking further into this, it appears that when I run

 rbt post -r 3 CL

 commit_id for RR 3 gets updated with the new cl number, but changenum 
 does not.  The docs say that changenum is being deprecated in favor of 
 commit_id, but from what I can see, it's the value in changenum that is 
 being displayed in the review web page.

 Is it just me, or are others seeing the same behavior?

 --Steve


 On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an 
 existing review request using the -r option that the change list number is 
 not updated in the review.  I think the review request should update the 
 change list since that's the CL that reflects the current set of diffs, but 
 there may be good reasons to not update it.  So I guess my question is, is 
 this a bug or a feature?

 Since we use perforce, one of the consequences of not updating it is 
 that when the change list is submitted, it won't get automatically updated 
 in the review request with the actual submitted change list number, because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request

[Steve]

Looking further into this, it appears that when I run

rbt post -r 3 CL

commit_id for RR 3 gets updated with the new cl number, but changenum does 
not.  The docs say that changenum is being deprecated in favor of 
commit_id, but from what I can see, it's the value in changenum that is 
being displayed in the review web page.

Is it just me, or are others seeing the same behavior?

--Steve


On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote:

 I've noticed that when I post diffs from a new change list to an existing 
 review request using the -r option that the change list number is not 
 updated in the review.  I think the review request should update the change 
 list since that's the CL that reflects the current set of diffs, but there 
 may be good reasons to not update it.  So I guess my question is, is this a 
 bug or a feature?

 Since we use perforce, one of the consequences of not updating it is that 
 when the change list is submitted, it won't get automatically updated in 
 the review request with the actual submitted change list number, because 
 the number in the review is not the one that was submitted.  I hope that 
 wasn't as confusing as it sounds.

 Thanks


 --Steve



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools: rbt post -r ID changenum does not update the change list number in the review request

[Steve]

I've noticed that when I post diffs from a new change list to an existing 
review request using the -r option that the change list number is not 
updated in the review.  I think the review request should update the change 
list since that's the CL that reflects the current set of diffs, but there 
may be good reasons to not update it.  So I guess my question is, is this a 
bug or a feature?

Since we use perforce, one of the consequences of not updating it is that 
when the change list is submitted, it won't get automatically updated in 
the review request with the actual submitted change list number, because 
the number in the review is not the one that was submitted.  I hope that 
wasn't as confusing as it sounds.

Thanks


--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Will changing the name of our perforce server cause us to lose access to old review diffs?

[Steve]

So simple I'm embarrassed I didn't think  to try it. I take it the repo is 
identified internally by a DB key and as long as that is left in place, the 
name and host information can change.  However it's done, it works as 
advertised!

Thanks

--Steve

On Thursday, April 9, 2015 at 2:09:32 PM UTC-7, David Trowbridge wrote:

 Instead of registering the new name as a new repository, just update the 
 existing repository inside the Review Board admin to point to the new 
 hostname. After that, everything should work fine.

 -David

 On Thu, Apr 9, 2015 at 2:04 PM Steve seide...@gmail.com javascript: 
 wrote:

 Our company has decided to clean up our perforce host name conventions a 
 bit and the short version is the server will have a new name.  I've noticed 
 that the reviews display the repo name in the review data like this:

 Repository:  old_hostname:1666
 If I rename old_hostname to new_hostname and register that server as a RB 
 repo, will I still be able to see my diffs?  If  RB walks down the list of 
 repos and tries to reconcile the change list number, it will find it on 
 new_hostname and everything should work.  If instead it pulls the hostname 
 out of the review request and looks there, it won't because that hostname 
 will be gone.  What behavior will I see if I rename the perforce server?

 Thanks

 --Steve
   

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Will changing the name of our perforce server cause us to lose access to old review diffs?

[Steve]

Our company has decided to clean up our perforce host name conventions a 
bit and the short version is the server will have a new name.  I've noticed 
that the reviews display the repo name in the review data like this:

Repository:  old_hostname:1666
If I rename old_hostname to new_hostname and register that server as a RB 
repo, will I still be able to see my diffs?  If  RB walks down the list of 
repos and tries to reconcile the change list number, it will find it on 
new_hostname and everything should work.  If instead it pulls the hostname 
out of the review request and looks there, it won't because that hostname 
will be gone.  What behavior will I see if I rename the perforce server?

Thanks

--Steve
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Can I create a new user in reviewboard using the Python Web API?

[Steve]

Okay, makes sense.  I can work around that.  Is there support for adding a 
perforce repository via the API?  That's the only other piece I need to 
automate my tests.

Thanks

--Steve


On Monday, April 6, 2015 at 6:41:32 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 There's no support in the API for creating users. This must be done 
 through the web UI or through an authentication backend, like LDAP or 
 Active Directory.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Mon, Apr 6, 2015 at 2:35 PM, Steve seide...@gmail.com javascript: 
 wrote:

 I've been chasing my tail for a few hours on this and thought it was time 
 for some help. For testing, I want to spin up a new rb site, which I 
 have a script to do, and then create 2 new users for posting reviews.  I 
 can access existing users this way:

 client = RBClient(http://localhost;)
 root = client.get_root()
 user = root.get_user(username=sallan)
 print user

 But I can't figure out how to create a new user in a script.  Can someone 
 point me in the right direction?

 Thanks


 ---Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Can I create a new user in reviewboard using the Python Web API?

[Steve]

Adding a repo turned out to be easy:

root = client.get_root()
root.get_repositories().create(name='perforce', tool=Perforce, 
path=localhost:1492)

I'm all set.  Thanks!

--Steve


On Tuesday, April 7, 2015 at 7:40:50 AM UTC-7, Steve wrote:

 Okay, makes sense.  I can work around that.  Is there support for adding a 
 perforce repository via the API?  That's the only other piece I need to 
 automate my tests.

 Thanks

 --Steve


 On Monday, April 6, 2015 at 6:41:32 PM UTC-7, Christian Hammond wrote:

 Hi Steve,

 There's no support in the API for creating users. This must be done 
 through the web UI or through an authentication backend, like LDAP or 
 Active Directory.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com

 On Mon, Apr 6, 2015 at 2:35 PM, Steve seide...@gmail.com wrote:

 I've been chasing my tail for a few hours on this and thought it was 
 time for some help. For testing, I want to spin up a new rb site, which 
 I have a script to do, and then create 2 new users for posting reviews.  I 
 can access existing users this way:

 client = RBClient(http://localhost;)
 root = client.get_root()
 user = root.get_user(username=sallan)
 print user

 But I can't figure out how to create a new user in a script.  Can 
 someone point me in the right direction?

 Thanks


 ---Steve

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Can I create a new user in reviewboard using the Python Web API?

[Steve]

I've been chasing my tail for a few hours on this and thought it was time 
for some help. For testing, I want to spin up a new rb site, which I have a 
script to do, and then create 2 new users for posting reviews.  I can 
access existing users this way:

client = RBClient(http://localhost;)
root = client.get_root()
user = root.get_user(username=sallan)
print user

But I can't figure out how to create a new user in a script.  Can someone 
point me in the right direction?

Thanks


---Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

500 error when superuser attempts to access admin console

[Steve]

I've created a fresh RB 2.0.15 instance on 2 test machines (Fedora 20 and 
LUbuntu 14.10).  On both machines, I created an 'admin' user when I created 
the site. As admin, I created a user account for myself, 'sallan', and 
checked the 'Staff status' and 'Superuser status' boxes.  Then I logged out 
as admin and logged in as sallan.  I can see my dashboard fine, but when I 
attempt to go to the admin console, I get a 500 error.  The log file has 
this error message:

2015-03-19 17:42:34,670 - ERROR -  - Exception thrown for user sallan at 
http://tamaki/admin/

'NoneType' object has no attribute 'get'
Traceback (most recent call last):
  File 
/usr/lib/python2.7/site-packages/Django-1.6.10-py2.7.egg/django/core/handlers/base.py,
 
line 112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File 
/usr/lib/python2.7/site-packages/Django-1.6.10-py2.7.egg/django/contrib/admin/views/decorators.py,
 
line 17, in _checkl\
ogin
return view_func(request, *args, **kwargs)
  File 
/usr/lib/python2.7/site-packages/ReviewBoard-2.0.15-py2.7.egg/reviewboard/admin/views.py,
 
line 39, in dashboard
primary_widget_positions = profile_data.get('primary_widget_positions')
AttributeError: 'NoneType' object has no attribute 'get'

Here's what my account looks like in the db:

is_superuser: 1
username: sallan
  first_name: Steve
   last_name: Allan
   email: hidden
   is_staff: 1
   is_active: 1
 date_joined: 2015-03-17 22:27:38

Other info:

$ python -V
Python 2.7.5

$ rb-site --version
rb-site 2.0.15

$ mysql --version
mysql  Ver 14.14 Distrib 5.5.38, for Linux (x86_64) using readline 5.1


Has anyone else encountered this or have suggestions on how to troubleshoot 
the problem? 

Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Perl Syntax Highlighting working for .pm, but not .pl extensions

[Steve]

Upgrading Pygments to 1.6 fixed the problem.

--Steve

On Thursday, August 28, 2014 2:25:51 PM UTC-7, Steve wrote:

 Knowing it should work helps.  The .pl files I'm looking at are smaller 
 than the .pm files that work, so I'm going to rule out file size as the 
 cause.  I'll try to isolate the problem some more.

 Thanks

 --Steve


 On Thursday, August 28, 2014 2:01:21 PM UTC-7, David Trowbridge wrote:

 Steve,

 It should work. We apply syntax highlighting based only on the file 
 extension, but I'm sure that pygments thinks that '.pl' is a perl file. The 
 one thing that you might be hitting is that we disable syntax highlighting 
 for very large files, because it can take a very long time otherwise.

 -David


 On Thu, Aug 28, 2014 at 8:58 AM, Steve seide...@gmail.com wrote:

 When we post code with .pm extensions, we get nice perl syntax 
 highlighting, but we don't get syntax highlighting for files ending in .pl. 
  I've run the pygementize script from the command line and it recognizes 
 .pl files as perl out-of-the-box and highlights them, but this in not 
 working for some reason in RB. Is this a bug, or a configuration problem on 
 our end?  Any tips on how to troubleshoot this?

 Here's our version information:

 $ rb-site --version
 rb-site 1.7.14

 $ pygmentize -V
 Pygments version 1.5, (c) 2006-2011 by Georg Brandl.


 Thanks

 -- Steve

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Is ReviewBot working with ReviewBoard 2.0?

[Steve]

We're currently using ReviewBoard 1.7.14 with the ReviewBot 0.1 (cppunit 
and python extensions) and we're considering moving to ReviewBoard 2.0.  
Anybody have experience, good or bad,  with ReviewBoard 2.0 working with 
ReviewBot?

Thanks

-- 
-- Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Perl Syntax Highlighting working for .pm, but not .pl extensions

[Steve]

When we post code with .pm extensions, we get nice perl syntax 
highlighting, but we don't get syntax highlighting for files ending in .pl. 
 I've run the pygementize script from the command line and it recognizes 
.pl files as perl out-of-the-box and highlights them, but this in not 
working for some reason in RB. Is this a bug, or a configuration problem on 
our end?  Any tips on how to troubleshoot this?

Here's our version information:

$ rb-site --version
rb-site 1.7.14

$ pygmentize -V
Pygments version 1.5, (c) 2006-2011 by Georg Brandl.


Thanks

-- Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Perl Syntax Highlighting working for .pm, but not .pl extensions

[Steve]

Knowing it should work helps.  The .pl files I'm looking at are smaller 
than the .pm files that work, so I'm going to rule out file size as the 
cause.  I'll try to isolate the problem some more.

Thanks

--Steve


On Thursday, August 28, 2014 2:01:21 PM UTC-7, David Trowbridge wrote:

 Steve,

 It should work. We apply syntax highlighting based only on the file 
 extension, but I'm sure that pygments thinks that '.pl' is a perl file. The 
 one thing that you might be hitting is that we disable syntax highlighting 
 for very large files, because it can take a very long time otherwise.

 -David


 On Thu, Aug 28, 2014 at 8:58 AM, Steve seide...@gmail.com javascript: 
 wrote:

 When we post code with .pm extensions, we get nice perl syntax 
 highlighting, but we don't get syntax highlighting for files ending in .pl. 
  I've run the pygementize script from the command line and it recognizes 
 .pl files as perl out-of-the-box and highlights them, but this in not 
 working for some reason in RB. Is this a bug, or a configuration problem on 
 our end?  Any tips on how to troubleshoot this?

 Here's our version information:

 $ rb-site --version
 rb-site 1.7.14

 $ pygmentize -V
 Pygments version 1.5, (c) 2006-2011 by Georg Brandl.


 Thanks

 -- Steve

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Trouble posting diff to RB from git

[Steve Steele]

Walt,

After much head-scratching, I think I have finally discovered the problem:
the repository permissions weren't set up properly on a few
directories/files so that RB couldn't read them. Now your workflow seems to
work for me (and others).

Thank for all of your help!

Steve


On Fri, Mar 14, 2014 at 4:20 PM, Javins, Walt walt.jav...@isilon.comwrote:

  The critical step relevant to your earlier error is:



 3) Pull from the mirror that RB uses



 Review Board can be configured to know how to discuss directly with git
 remotes (read up on the Raw file URL mask parameter).  But if you aren't
 set up with a raw file mast or one of the natively integrated hosting
 services (Github, Gitlab, etc), then it is your responsibility to keep
 Review Board repo (the value in the Path: field) in sync with the repo
 you want to diff against.  Many users use a pull style work flow with a
 '*/5 * * * * git fetch' cron job to do this.  Others choose for a push
 style workflow, and have a post-receive hook that will make sure Review
 Board's copy of info is in sync with the code in the origin repository.



 When I'm working in git my workflow looks like:



 git checkout -b new_branch origin/upstream_branch

 hack hack hack

 git commit

 rbt post -g -tracking-branch origin/upstream_branch --parent HEAD^ (parent
 syntax changes slightly in the most recent rbt release)



 Because origin and the repo Review Board looks at are kept in sync (via
 one of the above methods), I don't have to worry about git cat not being
 able to find any git objects, so long as the diff I'm creating is against a
 known point in origin.



 Walt



 *From:* Steve Steele [mailto:stevewste...@gmail.com]
 *Sent:* Friday, March 14, 2014 1:57 PM
 *To:* reviewboard@googlegroups.com
 *Cc:* Javins, Walt
 *Subject:* Re: Trouble posting diff to RB from git



 Some follow-up:

 I was able to do the following:
 1) Create a release_feature_branch off of release_branch
 2) Push the empty release_feature_branch to the remote host
 3) Pull from the mirror that RB uses
 4) Make my changes in the release_feature_branch
 5) Check in my changes
 6) Run rbt post --tracking-branch=release_branch

 Is this a normal process flow for git development using ReviewBoard?

 Thanks again,

 Steve

 On Friday, March 14, 2014 11:12:10 AM UTC-5, Steve Steele wrote:

 Walt,

 Thanks for your response. I was able to go to the mirror and run
 git cat-file -t 955231e6e237f85a89db874fbc0fecb90fb9fa35

 So it seems as though it is up-to-date. I have my tracking-branch set,
 but tried unsetting it to see what would happen, and I got a very large
 diff. I'm not sure I understand tracking branches (I'm actually fairly sure
 I don't understand them), but here's my branch structure:

 master-develop-release_branch-release_feature_branch

 where master, develop, and release_branch are pushed to the origin and
 release_feature_branch is local. If I use origin/master I get a massive
 diff. If I use origin/release_branch or release_branch, I get a diff that
 fails to get pushed to RB. I know this isn't a git support group, but if
 anything sticks out, I'd appreciate any info you have.

 Thanks again,

 Steve


 On Thursday, March 13, 2014 2:58:23 PM UTC-5, Javins, Walt wrote:

 Hi Steve,



 This is error is typically a sign that:



 1)  Review Board is set up with a local mirror for this git repo, and
 that mirror is out of date (i.e. it doesn't contain all the commits that
 your 'authoratative' git repo has)

 2)  The 'tracking branch' is otherwise invalid/not present outside of
 your local git repo.



 If these hints aren't enough to point you in the right direction, could
 you please provide further information on how you have this git repo
 configured in the Review Board admin UI.  Make sure to anonymize any
 sensitive data.



 Walt



 *From:* revie...@googlegroups.com 
 [mailto:revie...@googlegroups.comrevie...@googlegroups.com]
 *On Behalf Of *Steve Steele
 *Sent:* Thursday, March 13, 2014 6:53 AM
 *To:* revie...@googlegroups.com
 *Subject:* Trouble posting diff to RB from git



 I'm having trouble getting my diffs to be uploaded to ReviewBoard:

 $ rbt post -d
 DEBUG:root:Checking for a Subversion repository...
 DEBUG:root:Running: svn info --non-interactive
 DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
 svn: '.' is not a working copy
 ---
 DEBUG:root:Checking for a Git repository...
 DEBUG:root:Running: git rev-parse --git-dir
 DEBUG:root:Running: git config core.bare
 DEBUG:root:Running: git rev-parse --show-toplevel
 DEBUG:root:Running: git symbolic-ref -q HEAD
 DEBUG:root:Running: git config --get git-p4.port
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get',
 'git-p4.port']
 ---
 DEBUG:root:Running: git config --get branch.TTBLAH.merge
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get',
 'branch.TTBLAH.merge']
 ---
 DEBUG:root:Running: git config --get branch.TTBLAH.remote
 DEBUG:root:Command exited

Re: Trouble posting diff to RB from git

[Steve Steele]

Walt,

Thanks for your response. I was able to go to the mirror and run
git cat-file -t 955231e6e237f85a89db874fbc0fecb90fb9fa35

So it seems as though it is up-to-date. I have my tracking-branch set, but 
tried unsetting it to see what would happen, and I got a very large diff. 
I'm not sure I understand tracking branches (I'm actually fairly sure I 
don't understand them), but here's my branch structure:

master-develop-release_branch-release_feature_branch 

where master, develop, and release_branch are pushed to the origin and 
release_feature_branch is local. If I use origin/master I get a massive 
diff. If I use origin/release_branch or release_branch, I get a diff that 
fails to get pushed to RB. I know this isn't a git support group, but if 
anything sticks out, I'd appreciate any info you have.

Thanks again,

Steve

On Thursday, March 13, 2014 2:58:23 PM UTC-5, Javins, Walt wrote:

  Hi Steve,

  

 This is error is typically a sign that:

  

 1)  Review Board is set up with a local mirror for this git repo, and 
 that mirror is out of date (i.e. it doesn’t contain all the commits that 
 your ‘authoratative’ git repo has)

 2)  The ‘tracking branch’ is otherwise invalid/not present outside of 
 your local git repo.

  

 If these hints aren’t enough to point you in the right direction, could 
 you please provide further information on how you have this git repo 
 configured in the Review Board admin UI.  Make sure to anonymize any 
 sensitive data.

  

 Walt

  

 *From:* revie...@googlegroups.com javascript: [mailto:
 revie...@googlegroups.com javascript:] *On Behalf Of *Steve Steele
 *Sent:* Thursday, March 13, 2014 6:53 AM
 *To:* revie...@googlegroups.com javascript:
 *Subject:* Trouble posting diff to RB from git

  
  
 I'm having trouble getting my diffs to be uploaded to ReviewBoard:

 $ rbt post -d
 DEBUG:root:Checking for a Subversion repository...
 DEBUG:root:Running: svn info --non-interactive
 DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
 svn: '.' is not a working copy
 ---
 DEBUG:root:Checking for a Git repository...
 DEBUG:root:Running: git rev-parse --git-dir
 DEBUG:root:Running: git config core.bare
 DEBUG:root:Running: git rev-parse --show-toplevel
 DEBUG:root:Running: git symbolic-ref -q HEAD
 DEBUG:root:Running: git config --get git-p4.port
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
 'git-p4.port']
 ---
 DEBUG:root:Running: git config --get branch.TTBLAH.merge
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
 'branch.TTBLAH.merge']
 ---
 DEBUG:root:Running: git config --get branch.TTBLAH.remote
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
 'branch.TTBLAH.remote']
 ---
 DEBUG:root:Running: git config --get remote.origin.url
 DEBUG:root:repository info: Path: providerpoint, Base path: , Supports 
 changesets: False
 DEBUG:root:Making HTTP GET request to http://blade-66/reviewboard/api/
 DEBUG:root:Making HTTP GET request to 
 http://blade-66/reviewboard/api/info/
 DEBUG:root:Running: git rev-parse refs/heads/TTBLAH
 DEBUG:root:Running: git merge-base 
 4810fb1f51e15e912eade66829558e0d00d40cfb origin/release-6.0
 DEBUG:root:Running: git rev-parse 5402e6a5d333d8012b0278d5b158f95df45269c1
 DEBUG:root:Running: git rev-parse release-6.0
 DEBUG:root:Running: git status --porcelain --untracked-files=no
 WARNING:root:Your working directory is not clean. Any changes which have 
 not been committed to a branch will not be included in your review request.
 DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff 
 --ignore-submodules --no-renames 
 5402e6a5d333d8012b0278d5b158f95df45269c1..4810fb1f51e15e912eade66829558e0d00d40cfb
  
 -M
 DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff 
 --ignore-submodules --no-renames 
 5402e6a5d333d8012b0278d5b158f95df45269c1..5402e6a5d333d8012b0278d5b158f95df45269c1
  
 -M
 DEBUG:root:Making HTTP GET request to 
 http://blade-66/reviewboard/api/review-requests/
 DEBUG:root:Making HTTP POST request to 
 http://blade-66/reviewboard/api/review-requests/
 DEBUG:root:Making HTTP GET request to 
 http://blade-66/reviewboard/api/review-requests/34/diffs/
 DEBUG:root:Making HTTP POST request to 
 http://blade-66/reviewboard/api/review-requests/34/diffs/
 DEBUG:root:Got API Error 105 (HTTP code 400): One or more fields had errors
 DEBUG:root:Error data: {u'fields': {u'path': [u'error: unable to find 
 955231e6e237f85a89db874fbc0fecb90fb9fa35\nfatal: git cat-file 
 955231e6e237f85a89db874fbc0fecb90fb9fa35: bad file\n']}, u'stat': u'fail', 
 u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
 Traceback (most recent call last):
   File /usr/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.5.7', 'console_scripts', 'rbt')()
   File /usr/local/lib/python2.6/site-packages/rbtools/commands/main.py, 
 line 127, in main
 command.run_from_argv([RB_MAIN] + args)
   File 
 /usr/local/lib/python2.6/site-packages

Re: Trouble posting diff to RB from git

[Steve Steele]

Some follow-up:

I was able to do the following:
1) Create a release_feature_branch off of release_branch
2) Push the empty release_feature_branch to the remote host
3) Pull from the mirror that RB uses
4) Make my changes in the release_feature_branch
5) Check in my changes
6) Run rbt post --tracking-branch=release_branch

Is this a normal process flow for git development using ReviewBoard?

Thanks again,

Steve

On Friday, March 14, 2014 11:12:10 AM UTC-5, Steve Steele wrote:

 Walt,

 Thanks for your response. I was able to go to the mirror and run
 git cat-file -t 955231e6e237f85a89db874fbc0fecb90fb9fa35

 So it seems as though it is up-to-date. I have my tracking-branch set, 
 but tried unsetting it to see what would happen, and I got a very large 
 diff. I'm not sure I understand tracking branches (I'm actually fairly sure 
 I don't understand them), but here's my branch structure:

 master-develop-release_branch-release_feature_branch 

 where master, develop, and release_branch are pushed to the origin and 
 release_feature_branch is local. If I use origin/master I get a massive 
 diff. If I use origin/release_branch or release_branch, I get a diff that 
 fails to get pushed to RB. I know this isn't a git support group, but if 
 anything sticks out, I'd appreciate any info you have.

 Thanks again,

 Steve

 On Thursday, March 13, 2014 2:58:23 PM UTC-5, Javins, Walt wrote:

  Hi Steve,

  

 This is error is typically a sign that:

  

 1)  Review Board is set up with a local mirror for this git repo, 
 and that mirror is out of date (i.e. it doesn’t contain all the commits 
 that your ‘authoratative’ git repo has)

 2)  The ‘tracking branch’ is otherwise invalid/not present outside 
 of your local git repo.

  

 If these hints aren’t enough to point you in the right direction, could 
 you please provide further information on how you have this git repo 
 configured in the Review Board admin UI.  Make sure to anonymize any 
 sensitive data.

  

 Walt

  

 *From:* revie...@googlegroups.com [mailto:revie...@googlegroups.com] *On 
 Behalf Of *Steve Steele
 *Sent:* Thursday, March 13, 2014 6:53 AM
 *To:* revie...@googlegroups.com
 *Subject:* Trouble posting diff to RB from git

  
  
 I'm having trouble getting my diffs to be uploaded to ReviewBoard:

 $ rbt post -d
 DEBUG:root:Checking for a Subversion repository...
 DEBUG:root:Running: svn info --non-interactive
 DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
 svn: '.' is not a working copy
 ---
 DEBUG:root:Checking for a Git repository...
 DEBUG:root:Running: git rev-parse --git-dir
 DEBUG:root:Running: git config core.bare
 DEBUG:root:Running: git rev-parse --show-toplevel
 DEBUG:root:Running: git symbolic-ref -q HEAD
 DEBUG:root:Running: git config --get git-p4.port
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
 'git-p4.port']
 ---
 DEBUG:root:Running: git config --get branch.TTBLAH.merge
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
 'branch.TTBLAH.merge']
 ---
 DEBUG:root:Running: git config --get branch.TTBLAH.remote
 DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
 'branch.TTBLAH.remote']
 ---
 DEBUG:root:Running: git config --get remote.origin.url
 DEBUG:root:repository info: Path: providerpoint, Base path: , Supports 
 changesets: False
 DEBUG:root:Making HTTP GET request to http://blade-66/reviewboard/api/
 DEBUG:root:Making HTTP GET request to 
 http://blade-66/reviewboard/api/info/
 DEBUG:root:Running: git rev-parse refs/heads/TTBLAH
 DEBUG:root:Running: git merge-base 
 4810fb1f51e15e912eade66829558e0d00d40cfb origin/release-6.0
 DEBUG:root:Running: git rev-parse 5402e6a5d333d8012b0278d5b158f95df45269c1
 DEBUG:root:Running: git rev-parse release-6.0
 DEBUG:root:Running: git status --porcelain --untracked-files=no
 WARNING:root:Your working directory is not clean. Any changes which have 
 not been committed to a branch will not be included in your review request.
 DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff 
 --ignore-submodules --no-renames 
 5402e6a5d333d8012b0278d5b158f95df45269c1..4810fb1f51e15e912eade66829558e0d00d40cfb
  
 -M
 DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff 
 --ignore-submodules --no-renames 
 5402e6a5d333d8012b0278d5b158f95df45269c1..5402e6a5d333d8012b0278d5b158f95df45269c1
  
 -M
 DEBUG:root:Making HTTP GET request to 
 http://blade-66/reviewboard/api/review-requests/
 DEBUG:root:Making HTTP POST request to 
 http://blade-66/reviewboard/api/review-requests/
 DEBUG:root:Making HTTP GET request to 
 http://blade-66/reviewboard/api/review-requests/34/diffs/
 DEBUG:root:Making HTTP POST request to 
 http://blade-66/reviewboard/api/review-requests/34/diffs/
 DEBUG:root:Got API Error 105 (HTTP code 400): One or more fields had 
 errors
 DEBUG:root:Error data: {u'fields': {u'path': [u'error: unable to find 
 955231e6e237f85a89db874fbc0fecb90fb9fa35\nfatal: git cat-file

Trouble posting diff to RB from git

[Steve Steele]

I'm having trouble getting my diffs to be uploaded to ReviewBoard:

$ rbt post -d
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
DEBUG:root:Running: git symbolic-ref -q HEAD
DEBUG:root:Running: git config --get git-p4.port
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
'git-p4.port']
---
DEBUG:root:Running: git config --get branch.TTBLAH.merge
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
'branch.TTBLAH.merge']
---
DEBUG:root:Running: git config --get branch.TTBLAH.remote
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 
'branch.TTBLAH.remote']
---
DEBUG:root:Running: git config --get remote.origin.url
DEBUG:root:repository info: Path: providerpoint, Base path: , Supports 
changesets: False
DEBUG:root:Making HTTP GET request to http://blade-66/reviewboard/api/
DEBUG:root:Making HTTP GET request to http://blade-66/reviewboard/api/info/
DEBUG:root:Running: git rev-parse refs/heads/TTBLAH
DEBUG:root:Running: git merge-base 4810fb1f51e15e912eade66829558e0d00d40cfb 
origin/release-6.0
DEBUG:root:Running: git rev-parse 5402e6a5d333d8012b0278d5b158f95df45269c1
DEBUG:root:Running: git rev-parse release-6.0
DEBUG:root:Running: git status --porcelain --untracked-files=no
WARNING:root:Your working directory is not clean. Any changes which have 
not been committed to a branch will not be included in your review request.
DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff 
--ignore-submodules --no-renames 
5402e6a5d333d8012b0278d5b158f95df45269c1..4810fb1f51e15e912eade66829558e0d00d40cfb
 
-M
DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff 
--ignore-submodules --no-renames 
5402e6a5d333d8012b0278d5b158f95df45269c1..5402e6a5d333d8012b0278d5b158f95df45269c1
 
-M
DEBUG:root:Making HTTP GET request to 
http://blade-66/reviewboard/api/review-requests/
DEBUG:root:Making HTTP POST request to 
http://blade-66/reviewboard/api/review-requests/
DEBUG:root:Making HTTP GET request to 
http://blade-66/reviewboard/api/review-requests/34/diffs/
DEBUG:root:Making HTTP POST request to 
http://blade-66/reviewboard/api/review-requests/34/diffs/
DEBUG:root:Got API Error 105 (HTTP code 400): One or more fields had errors
DEBUG:root:Error data: {u'fields': {u'path': [u'error: unable to find 
955231e6e237f85a89db874fbc0fecb90fb9fa35\nfatal: git cat-file 
955231e6e237f85a89db874fbc0fecb90fb9fa35: bad file\n']}, u'stat': u'fail', 
u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
Traceback (most recent call last):
  File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.5.7', 'console_scripts', 'rbt')()
  File /usr/local/lib/python2.6/site-packages/rbtools/commands/main.py, 
line 127, in main
command.run_from_argv([RB_MAIN] + args)
  File 
/usr/local/lib/python2.6/site-packages/rbtools/commands/__init__.py, line 
158, in run_from_argv
exit_code = self.main(*args) or 0
  File /usr/local/lib/python2.6/site-packages/rbtools/commands/post.py, 
line 659, in main
submit_as=self.options.submit_as)
  File /usr/local/lib/python2.6/site-packages/rbtools/commands/post.py, 
line 534, in post_request
raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff


One or more fields had errors (HTTP 400, API Error 105)

path: error: unable to find 955231e6e237f85a89db874fbc0fecb90fb9fa35
fatal: git cat-file 955231e6e237f85a89db874fbc0fecb90fb9fa35: bad file


Your review request still exists, but the diff is not attached.

I have gone to the local repository that ReviewBoard uses and am able to do:
git cat-file -t 955231e6e237f85a89db874fbc0fecb90fb9fa35
blob

I notice that the error message doesn't use any options, but if I don't 
specify an option, I get an error:
$ git cat-file 955231e6e237f85a89db874fbc0fecb90fb9fa35
usage: git cat-file (-t|-s|-e|-p|type) object
   or: git cat-file (--batch|--batch-check)  list_of_objects

type can be one of: blob, tree, commit, tag
-tshow object type
-sshow object size
-eexit with zero when there's no error
-ppretty-print object's content
--batch   show info and content of objects fed from the 
standard input
--batch-check show info about objects fed from the standard 
input

I'm not sure if that's an issue or not. Any ideas?

Thanks!

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are 

Re: Review Bot: How to manually run cppcheck and pep 8?

[Steve]

This question came up again today from one of our users.  Has anyone done a 
manual run of the cppcheck or pep8 bots from reviewboard?



On Thursday, September 26, 2013 2:37:01 PM UTC-7, Steve wrote:

 I have the Review Bot extensions running and they're quick slick.  On the 
 configuration page, there's a check box for 

 Allow run manually


 I have a review with a python file that doesn't have a .py extension and 
 I'd like to manually run the pep 8 bot, but I can't figure out how to do 
 it.  I don't see any button, icon or text to trigger a manual run on the 
 review page.  How do I do that?

 Thanks!

 --Steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

reviewbot logging

[Steve]

How do I enable logging for the reviewbot tools, and where are the logs 
written?  I'm particularly interested in the logging messages in 
tools/process.py.  

--Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: rbt status not working with perforce

[Steve]

Done:

https://code.google.com/p/reviewboard/issues/detail?id=3184

Thanks

--Steve

On Saturday, December 28, 2013 1:37:27 PM UTC-8, David Trowbridge wrote:

 Would you mind filing a bug?

 Thanks!


 On Fri, Dec 27, 2013 at 1:06 PM, Steve seide...@gmail.com 
 javascript:wrote:

 I see it in 0.5.2 on CentOS 6 and in 0.5.2.dev on my Mac. Our ReviewBoard 
 server is 1.7.14.  Here's the debug output:

 DEBUG:root:Checking for a Perforce repository...
 DEBUG:root:Running: p4 info
 DEBUG:root:Running: diff --version
 DEBUG:root:repository info: Path: ['redacted'], Base path: None, Supports 
 changesets: True
 Traceback (most recent call last):
   File /Users/sallan/envs/rbtools-master-2.6/bin/rbt, line 8, in 
 module
 load_entry_point('RBTools==0.5.2.dev', 'console_scripts', 'rbt')()
   File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/main.py, 
 line 113, in main
 command.run_from_argv([RB_MAIN] + args)
   File 
 /Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py, line 
 157, in run_from_argv
 exit_code = self.main(*args) or 0
   File 
 /Users/sallan/PycharmProjects/rbtools/rbtools/commands/status.py, line 
 60, in main
 client_name=self.options.repository_type)
   File 
 /Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py, line 
 188, in initialize_scm_tool
 tool.check_options()
   File 
 /Users/sallan/PycharmProjects/rbtools/rbtools/clients/perforce.py, line 
 298, in check_options
 if self.options.revision_range:
 AttributeError: Values instance has no attribute 'revision_range'


 --Steve


 On Friday, December 27, 2013 12:17:10 PM UTC-8, David Trowbridge wrote:

 I don't think we've seen this particular issue before. What version of 
 rbtools are you using?

 -David


 On Fri, Dec 27, 2013 at 12:13 PM, Steve seide...@gmail.com wrote:

 I didn't see an issue for this in buzilla, but before I post a bug I 
 thought I'd check here.  I'm using perforce, and when I run 'rbt status' I 
 get an error.  If I simply create an empty git repository, it choses that 
 instead of perforce, and then it returns the expected results:


 %  rbt status
 CRITICAL:root:Values instance has no attribute 'revision_range'

 % git init
 Initialized empty Git repository in /home/sallan/cmscripts/.git/

 % rbt status
 WARNING:root:The repository detected in the current directory was not 
 found on
 the Review Board server. Displaying review requests from all 
 repositories.
r/79412 - Try with a smaller set of files.
   snip remaining list


 Is this already a know issue?


 --Steve



  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.

 For more options, visit https://groups.google.com/groups/opt_out.


  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Unable to change server URL from 'localhost' to custom domain

[Steve Vermeulen]

I have reviewboard set up using a custom server.  Everything is working 
nicely and we are receiving notification emails correctly, except that the 
links in the email are to 
http://localhost/reviewboard/r/http://localhost/reviewboard/r/202/ rather 
than the domain that it is hosted on.  I assume that the fix for this is to 
change the 'server url' setting under 'general settings' however whenever I 
do this, it always reverts back to localhost almost immediately afterwards. 
 Is this an issue with reviewboard or am I doing something wrong?
Cheers,
Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

rbt status not working with perforce

[Steve]

I didn't see an issue for this in buzilla, but before I post a bug I 
thought I'd check here.  I'm using perforce, and when I run 'rbt status' I 
get an error.  If I simply create an empty git repository, it choses that 
instead of perforce, and then it returns the expected results:


%  rbt status
CRITICAL:root:Values instance has no attribute 'revision_range'

% git init
Initialized empty Git repository in /home/sallan/cmscripts/.git/

% rbt status
WARNING:root:The repository detected in the current directory was not found 
on
the Review Board server. Displaying review requests from all repositories.
   r/79412 - Try with a smaller set of files.
  snip remaining list


Is this already a know issue?


--Steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: rbt status not working with perforce

[Steve]

I see it in 0.5.2 on CentOS 6 and in 0.5.2.dev on my Mac. Our ReviewBoard 
server is 1.7.14.  Here's the debug output:

DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: ['redacted'], Base path: None, Supports 
changesets: True
Traceback (most recent call last):
  File /Users/sallan/envs/rbtools-master-2.6/bin/rbt, line 8, in module
load_entry_point('RBTools==0.5.2.dev', 'console_scripts', 'rbt')()
  File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/main.py, 
line 113, in main
command.run_from_argv([RB_MAIN] + args)
  File 
/Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py, line 
157, in run_from_argv
exit_code = self.main(*args) or 0
  File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/status.py, 
line 60, in main
client_name=self.options.repository_type)
  File 
/Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py, line 
188, in initialize_scm_tool
tool.check_options()
  File /Users/sallan/PycharmProjects/rbtools/rbtools/clients/perforce.py, 
line 298, in check_options
if self.options.revision_range:
AttributeError: Values instance has no attribute 'revision_range'


--Steve

On Friday, December 27, 2013 12:17:10 PM UTC-8, David Trowbridge wrote:

 I don't think we've seen this particular issue before. What version of 
 rbtools are you using?

 -David


 On Fri, Dec 27, 2013 at 12:13 PM, Steve seide...@gmail.com 
 javascript:wrote:

 I didn't see an issue for this in buzilla, but before I post a bug I 
 thought I'd check here.  I'm using perforce, and when I run 'rbt status' I 
 get an error.  If I simply create an empty git repository, it choses that 
 instead of perforce, and then it returns the expected results:


 %  rbt status
 CRITICAL:root:Values instance has no attribute 'revision_range'

 % git init
 Initialized empty Git repository in /home/sallan/cmscripts/.git/

 % rbt status
 WARNING:root:The repository detected in the current directory was not 
 found on
 the Review Board server. Displaying review requests from all repositories.
r/79412 - Try with a smaller set of files.
   snip remaining list


 Is this already a know issue?


 --Steve



  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Downloading RBTools and Python API docs

[Steve]

That did the trick.   Thanks!

--steve


On Friday, November 15, 2013 2:01:16 PM UTC-8, Christian Hammond wrote:

 Hi Steve,

 They can be built from source by going into the docs/rbtools/ directory 
 and typing 'make html'. We don't have any pre-built packages.

 You'll need python-sphinx and probably some other dependencies as well.

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Fri, Nov 15, 2013 at 10:20 AM, Steve seide...@gmail.com 
 javascript:wrote:

 I'd like to have access to the docs for RBTools and the Python API 
 locally on my machine.  Is there a place I can download the html docs?  I 
 didn't see it available on reviewboard.org, but I may not be looking in 
 the right places.

 --Steve



  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Downloading RBTools and Python API docs

[Steve]

I'd like to have access to the docs for RBTools and the Python API locally 
on my machine.  Is there a place I can download the html docs?  I didn't 
see it available on reviewboard.org, but I may not be looking in the right 
places.

--Steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: ReviewBoard server tips over about twice a week

[Steve]

Just to close the loop on this issue - we doubled the RAM on our server to 
32GB and allocated 8GB to memcached.  So far we've gone 2 weeks without any 
problems so it appears it was memcached that was thrashing.

Thanks for all the input.

---Steve


On Thursday, September 12, 2013 5:27:39 AM UTC-7, Paul Fee wrote:

 MaxRequestsPerChild of 4000 should be fine.  I happen to have mine 
 configured to 3000.  I didn't find the root cause of my server's lock ups, 
 at the time I noted increased memory use by Apache.  A few months of 
 evidence shows the change to be effective.  BTW I'm running RB 1.5 on an 
 old Ubuntu release, so my problems may well have been fixed in more recent 
 versions.  I expect you've got server issues different from mine, but 
 MaxRequestsPerChild shouldn't do any harm.

 On Wednesday, September 11, 2013 4:19:17 PM UTC+1, Steve wrote:

 Thanks Paul, that's helpful. We're using the prefork MPM.  Do you think 
 4000 is too large a number for MaxRequetsPerChild?

 --Steve

 On Wednesday, September 11, 2013 2:15:35 AM UTC-7, Paul Fee wrote:

 Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
 the /server-status URL on your web server.  This should cause Apache httpd 
 to provide a page that summarises the status of all its workers.  That may 
 help you understand why you've got more httpd processes than expected.

 Also, I've found the MaxRequestsPerChild directive to be useful on an 
 installation of mine that would lock up occasionally.  Your config shows 
 the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
 worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
 that MaxRequestsPerChild is taking effect.  The config file contains a set 
 of MPM tuning directives, duplicated for prefork and worker, make sure the 
 required configuration is actually active.

 -- 
 Paul

 On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me 
 on 
 how to limit the number of apache processes and threads?  I've attached 
 the 
 apache httpd.conf file.

 Thanks Christian.

 --steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: post-review only update testing-done field for existing request

[Steve]

I haven't tried this, but does it work if you include the --change-only 
option?

--steve

On Saturday, September 28, 2013 8:04:36 PM UTC-7, Lynn Lin wrote:

 Environment: 
 Git source code repostior
 y Linux ubuntu 
 RBTools:0.5.2
 Reviewboard:1.6.1 
  
  

 I try to *ONLY* update testing-done field for a existing review request 
 on reviewboard through post-review

 here is my command: 

 post-review --testing-done=cppcheck results,unit test results link abc  -r 
 9906  -p 

 output:

 There don't seem to be any diffs!

 Could post-review support only update testing-done field?


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Web API: review-requests?changenum=NNNN stopped working in 1.7.14

[Steve]

I upgraded one of our servers to 1.7.14 and this url no longer works:

${rb_url}/api/review-requests?changenum=


When I attempt to access that now I get

fail Object does not exist 100

That url works on 1.7.12.  Is this an intentional change in the web api, a 
bug, or am I doing something wrong?

Thanks

--Steve




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Web API: review-requests?changenum=NNNN stopped working in 1.7.14

[Steve]

That seems to work.  Curious that it worked previously without the '/'.

Thanks!

--Steve

On Monday, September 30, 2013 4:31:23 PM UTC-7, David Trowbridge wrote:

 The problem is with a trailing slash. Try this URL:

 /api/review-requests/?changenum=N

 -David


 On Mon, Sep 30, 2013 at 7:03 PM, Steve seide...@gmail.com 
 javascript:wrote:

 I upgraded one of our servers to 1.7.14 and this url no longer works:

 ${rb_url}/api/review-requests?changenum=


 When I attempt to access that now I get

 **fail** Object does not exist** 100**
 **
 **
 That url works on 1.7.12.  Is this an intentional change in the web api, 
 a bug, or am I doing something wrong?

 Thanks
 **
 **
 **--Steve**
 **
 **
 **
 **
 **
 **
 **
 **

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

[Steve]

I'm answering my own questions in case others run into similar problems.  I 
figured out that the reviewbot process looks for the reviewbot_cookies.txt 
file in the directory where you ran 'reviewbot worker'.  So the uid running 
the reviewbot process needs to be able to write to that directory.

So reviewbot is now working fine, and is actually pretty cool!

--Steve

On Wednesday, September 25, 2013 2:22:27 PM UTC-7, Steve wrote:

 Okay, I restarted the reviewbot work as root and now the extensions show 
 up.  The reviewbot-cookies.txt file was written into the directory where I 
 cloned the reviewbot source, which was owned by root.  I didn't expect that 
 directory to be a working directory.  That seems odd to me.



 On Wednesday, September 25, 2013 2:08:28 PM UTC-7, Steve wrote:

 This may be the problem.  I'm running the reviewbot worker as apache and 
 seeing this error:

 [2013-09-25 10:57:33,786: WARNING/MainProcess] There was an error while 
 creating a cookie file: [Errno 13] Permission denied: 
 'reviewbot-cookies.txt'
 [2013-09-25 10:57:33,786: ERROR/MainProcess] Could not reach RB server: 
 [Errno 13] Permission denied: 'reviewbot-cookies.txt'

 Where is it trying to write the cookie file? Maybe apache is not the 
 right user to be running the reviewbot worker process?  What is the 
 recommended user?  When I ran it as root there was a message recommending 
 against that.

 --Steve

 On Wednesday, September 25, 2013 11:43:42 AM UTC-7, Steve wrote:

 Sorry, I should have mentioned that I did that.  I even restarted apache 
 and did the refresh again.  I'm still not seeing any extensions.

 --Steve


 On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:

 Right after the section you've pasted, you'll see this:

 After a tool has been installed on a worker, it must be registered with 
 the Review Bot extension, and configured in the admin panel. Registering 
 tools is accomplished in the following manner:

1. Go to the extension list in the admin panel.
2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
3. Click the 'Review bot tools' link.
4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 

 This will trigger tool registration for all of the currently running 
 workers, and refresh the page. You will now see the list of installed 
 tools 
 and may configure them using this admin panel.



 On Wed, Sep 25, 2013 at 2:21 PM, Steve seide...@gmail.com wrote:

 I installed reviewbot on our 1.7.14 server using these instructions:

 https://github.com/reviewboard/ReviewBot

 It looks like pep8 and cppcheck are automatically installed with 
 reviewbot, but I don't see them listed in the extension list. I'm looking 
 for them under

 *Extensions - Database - Review bot tools*

 That page says *'0 review bot tools'*.  Is some additional 
 configuration needed?  The instructions say:

 Workers are able to find installed tools using Entry 
 Pointshttp://packages.python.org/distribute/pkg_resources.html#entry-points.
  
 New tool classes should add a reviewbot.toolsentry point. The entry 
 point for the pep8 tool is part of the review bot installation, here is 
 an 
 example showing its definition:

 'reviewbot.tools': [
 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
 'pep8 = reviewbot.tools.pep8:PEP8Tool',
 ],


 But it's not clear to me where that setting should be.

 --Steve
  
 -- 
 Get the Review Board Power Pack at 
 http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Review Bot: How to manually run cppcheck and pep 8?

[Steve]

I have the Review Bot extensions running and they're quick slick.  On the 
configuration page, there's a check box for 

Allow run manually


I have a review with a python file that doesn't have a .py extension and 
I'd like to manually run the pep 8 bot, but I can't figure out how to do 
it.  I don't see any button, icon or text to trigger a manual run on the 
review page.  How do I do that?

Thanks!

--Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reviewbot: Should I see cppcheck and pep8 in my extension list?

[Steve]

I installed reviewbot on our 1.7.14 server using these instructions:

https://github.com/reviewboard/ReviewBot

It looks like pep8 and cppcheck are automatically installed with reviewbot, 
but I don't see them listed in the extension list. I'm looking for them 
under

*Extensions - Database - Review bot tools*

That page says *'0 review bot tools'*.  Is some additional configuration 
needed?  The instructions say:

Workers are able to find installed tools using Entry 
Pointshttp://packages.python.org/distribute/pkg_resources.html#entry-points. 
New tool classes should add a reviewbot.toolsentry point. The entry point 
for the pep8 tool is part of the review bot installation, here is an 
example showing its definition:

'reviewbot.tools': [
'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
'cpplint = reviewbot.tools.cpplint:CPPLintTool',
'pep8 = reviewbot.tools.pep8:PEP8Tool',
],


But it's not clear to me where that setting should be.

--Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

[Steve]

Sorry, I should have mentioned that I did that.  I even restarted apache 
and did the refresh again.  I'm still not seeing any extensions.

--Steve


On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:

 Right after the section you've pasted, you'll see this:

 After a tool has been installed on a worker, it must be registered with 
 the Review Bot extension, and configured in the admin panel. Registering 
 tools is accomplished in the following manner:

1. Go to the extension list in the admin panel.
2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
3. Click the 'Review bot tools' link.
4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 

 This will trigger tool registration for all of the currently running 
 workers, and refresh the page. You will now see the list of installed tools 
 and may configure them using this admin panel.



 On Wed, Sep 25, 2013 at 2:21 PM, Steve seide...@gmail.com 
 javascript:wrote:

 I installed reviewbot on our 1.7.14 server using these instructions:

 https://github.com/reviewboard/ReviewBot

 It looks like pep8 and cppcheck are automatically installed with 
 reviewbot, but I don't see them listed in the extension list. I'm looking 
 for them under

 *Extensions - Database - Review bot tools*

 That page says *'0 review bot tools'*.  Is some additional configuration 
 needed?  The instructions say:

 Workers are able to find installed tools using Entry 
 Pointshttp://packages.python.org/distribute/pkg_resources.html#entry-points.
  
 New tool classes should add a reviewbot.toolsentry point. The entry 
 point for the pep8 tool is part of the review bot installation, here is an 
 example showing its definition:

 'reviewbot.tools': [
 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
 'pep8 = reviewbot.tools.pep8:PEP8Tool',
 ],


 But it's not clear to me where that setting should be.

 --Steve
  
 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

[Steve]

This may be the problem.  I'm running the reviewbot worker as apache and 
seeing this error:

[2013-09-25 10:57:33,786: WARNING/MainProcess] There was an error while 
creating a cookie file: [Errno 13] Permission denied: 
'reviewbot-cookies.txt'
[2013-09-25 10:57:33,786: ERROR/MainProcess] Could not reach RB server: 
[Errno 13] Permission denied: 'reviewbot-cookies.txt'

Where is it trying to write the cookie file? Maybe apache is not the right 
user to be running the reviewbot worker process?  What is the recommended 
user?  When I ran it as root there was a message recommending against that.

--Steve

On Wednesday, September 25, 2013 11:43:42 AM UTC-7, Steve wrote:

 Sorry, I should have mentioned that I did that.  I even restarted apache 
 and did the refresh again.  I'm still not seeing any extensions.

 --Steve


 On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:

 Right after the section you've pasted, you'll see this:

 After a tool has been installed on a worker, it must be registered with 
 the Review Bot extension, and configured in the admin panel. Registering 
 tools is accomplished in the following manner:

1. Go to the extension list in the admin panel.
2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
3. Click the 'Review bot tools' link.
4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 

 This will trigger tool registration for all of the currently running 
 workers, and refresh the page. You will now see the list of installed tools 
 and may configure them using this admin panel.



 On Wed, Sep 25, 2013 at 2:21 PM, Steve seide...@gmail.com wrote:

 I installed reviewbot on our 1.7.14 server using these instructions:

 https://github.com/reviewboard/ReviewBot

 It looks like pep8 and cppcheck are automatically installed with 
 reviewbot, but I don't see them listed in the extension list. I'm looking 
 for them under

 *Extensions - Database - Review bot tools*

 That page says *'0 review bot tools'*.  Is some additional 
 configuration needed?  The instructions say:

 Workers are able to find installed tools using Entry 
 Pointshttp://packages.python.org/distribute/pkg_resources.html#entry-points.
  
 New tool classes should add a reviewbot.toolsentry point. The entry 
 point for the pep8 tool is part of the review bot installation, here is an 
 example showing its definition:

 'reviewbot.tools': [
 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
 'pep8 = reviewbot.tools.pep8:PEP8Tool',
 ],


 But it's not clear to me where that setting should be.

 --Steve
  
 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?

[Steve]

Okay, I restarted the reviewbot work as root and now the extensions show 
up.  The reviewbot-cookies.txt file was written into the directory where I 
cloned the reviewbot source, which was owned by root.  I didn't expect that 
directory to be a working directory.  That seems odd to me.



On Wednesday, September 25, 2013 2:08:28 PM UTC-7, Steve wrote:

 This may be the problem.  I'm running the reviewbot worker as apache and 
 seeing this error:

 [2013-09-25 10:57:33,786: WARNING/MainProcess] There was an error while 
 creating a cookie file: [Errno 13] Permission denied: 
 'reviewbot-cookies.txt'
 [2013-09-25 10:57:33,786: ERROR/MainProcess] Could not reach RB server: 
 [Errno 13] Permission denied: 'reviewbot-cookies.txt'

 Where is it trying to write the cookie file? Maybe apache is not the right 
 user to be running the reviewbot worker process?  What is the recommended 
 user?  When I ran it as root there was a message recommending against that.

 --Steve

 On Wednesday, September 25, 2013 11:43:42 AM UTC-7, Steve wrote:

 Sorry, I should have mentioned that I did that.  I even restarted apache 
 and did the refresh again.  I'm still not seeing any extensions.

 --Steve


 On Wednesday, September 25, 2013 11:24:22 AM UTC-7, Steven MacLeod wrote:

 Right after the section you've pasted, you'll see this:

 After a tool has been installed on a worker, it must be registered with 
 the Review Bot extension, and configured in the admin panel. Registering 
 tools is accomplished in the following manner:

1. Go to the extension list in the admin panel.
2. Click the 'DATABASE' button for the 'Review-Bot-Extension'.
3. Click the 'Review bot tools' link.
4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. 

 This will trigger tool registration for all of the currently running 
 workers, and refresh the page. You will now see the list of installed tools 
 and may configure them using this admin panel.



 On Wed, Sep 25, 2013 at 2:21 PM, Steve seide...@gmail.com wrote:

 I installed reviewbot on our 1.7.14 server using these instructions:

 https://github.com/reviewboard/ReviewBot

 It looks like pep8 and cppcheck are automatically installed with 
 reviewbot, but I don't see them listed in the extension list. I'm looking 
 for them under

 *Extensions - Database - Review bot tools*

 That page says *'0 review bot tools'*.  Is some additional 
 configuration needed?  The instructions say:

 Workers are able to find installed tools using Entry 
 Pointshttp://packages.python.org/distribute/pkg_resources.html#entry-points.
  
 New tool classes should add a reviewbot.toolsentry point. The entry 
 point for the pep8 tool is part of the review bot installation, here is an 
 example showing its definition:

 'reviewbot.tools': [
 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool',
 'cpplint = reviewbot.tools.cpplint:CPPLintTool',
 'pep8 = reviewbot.tools.pep8:PEP8Tool',
 ],


 But it's not clear to me where that setting should be.

 --Steve
  
 -- 
 Get the Review Board Power Pack at 
 http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: RBTools 5.x API: Can it be used to modify database?

[Steve]

Ah, a light bulb just went on.  I was missing the link between the new 
RBTools API and the web resources.  After reading your message I went back 
and read more carefully the section titled  Links Between Resources. 
 Things are starting to make more sense to me now.

Thanks!

--Steve


On Monday, September 23, 2013 3:31:02 PM UTC-7, David Trowbridge wrote:

 1. Yes. You can remove a user from a group by issuing a DELETE operation 
 on the review group user resource. See 
 http://www.reviewboard.org/docs/manual/1.7/webapi/2.0/resources/review-group-user/for
  more details.

 2. The online docs are generated by introspecting the code, and they are 
 complete.

 -David


 On Mon, Sep 23, 2013 at 11:36 AM, Steve seide...@gmail.com 
 javascript:wrote:

 I've written a script using the RBTools 5.x API which lists RB groups 
 containing users who have left the company.  I have 2 questions:

 1. Can the API be used to actually remove the users from the groups?

 2. What's the best source of complete documentation on all the 
 classes/methods available via the API?  The online docs don't appear to be 
 complete, but I may be missing something.

 Thanks

 Steve

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

RBTools 5.x API: Can it be used to modify database?

[Steve]

I've written a script using the RBTools 5.x API which lists RB groups 
containing users who have left the company.  I have 2 questions:

1. Can the API be used to actually remove the users from the groups?

2. What's the best source of complete documentation on all the 
classes/methods available via the API?  The online docs don't appear to be 
complete, but I may be missing something.

Thanks

Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: User Not Receiving Emails

[Steve]

Did you ever figure this out?  I'm having the same problem here with a 
specific user and only on 1 of our RB servers.  I can't figure out where RB 
is logging its smtp messages.  I don't see anything in my reviewboard.log 
file.

--Steve


On Wednesday, July 31, 2013 10:51:35 AM UTC-7, ReviewBoard User wrote:

 Hey Stephen,

 Thanks for the suggestion :). The reviewboard logs generated don't suggest 
 that there was anything wrong with sending the email for this user which 
 might be because the error is masked elsewhere. There is nothing unusual 
 about the name (it is entirely alphabetic).


 On Wednesday, July 31, 2013 10:12:49 AM UTC-7, Stephen Gallagher wrote:

 On 07/31/2013 12:54 PM, ReviewBoard user wrote: 
  Hello, 
  
  I have a very specific user that can't receive emails via ReviewBoard 
  when creating requests or updates to the request. I checked this 
 against 
  the database, and he is an active user with the correct email. 
  
  I'm attempting to follow the code to send out an email that would 
  replicate the code flow. Are there any tips on how to do this? 
  
  So far, I have done a search on the code from github to get hints on 
 how 
  to do this, but each method requires multiple arguments that I can't 
  confidently supply. 
  
  
 https://github.com/search?l=p=8q=mail++repo%3Areviewboard%2Freviewboardref=advsearchtype=Code
  
  
  Any other advice for debugging why the user is not receiving the email? 
  I have already tried going onto the mail server and using shell 
 commands 
  to manually send the user emails. The user can receive them perfectly 
  fine which makes this a bigger mystery. 
  
  Thanks for any help :D 
  

 Have you checked the mail-server debug logs to see if ReviewBoard has 
 *tried* to send a message? Also, is there anything unusual about the 
 user's name or email address? Is it possible that it contains some 
 unusual characters that might be confusing ReviewBoard or the MTA? 




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: ReviewBoard server tips over about twice a week

[Steve]

Thanks Paul, that's helpful. We're using the prefork MPM.  Do you think 
4000 is too large a number for MaxRequetsPerChild?

--Steve

On Wednesday, September 11, 2013 2:15:35 AM UTC-7, Paul Fee wrote:

 Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
 the /server-status URL on your web server.  This should cause Apache httpd 
 to provide a page that summarises the status of all its workers.  That may 
 help you understand why you've got more httpd processes than expected.

 Also, I've found the MaxRequestsPerChild directive to be useful on an 
 installation of mine that would lock up occasionally.  Your config shows 
 the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
 worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
 that MaxRequestsPerChild is taking effect.  The config file contains a set 
 of MPM tuning directives, duplicated for prefork and worker, make sure the 
 required configuration is actually active.

 -- 
 Paul

 On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me on 
 how to limit the number of apache processes and threads?  I've attached the 
 apache httpd.conf file.

 Thanks Christian.

 --steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

listing all review groups and users within the group using a python script

[Steve]

I can list all RB users this way:

 from django.contrib.auth.models import User
 for user in User.objects.all():
print user

That correctly prints out all of my users. But the same doesn't work for 
Group

 from django.contrib.auth.models import Group
 for group in Group.objects.all():
print group
default reviewer

I have about 30 groups defined in RB, but I only get 'default reviewer'. 
 What I'd like to do is list out all the groups, or more specifically, for 
each group, list all the user in the group.  There's probably a set of 
django functions that will do that, but I'm having trouble finding them. 
 Can someone point me in the right direction?

Thanks

--Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: listing all review groups and users within the group using a python script

[Steve]

Better yet, is there a way to do this with the new RBTools 5.x API?

--Steve


On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote:

 I can list all RB users this way:

  from django.contrib.auth.models import User
  for user in User.objects.all():
 print user

 That correctly prints out all of my users. But the same doesn't work for 
 Group

  from django.contrib.auth.models import Group
  for group in Group.objects.all():
 print group
 default reviewer

 I have about 30 groups defined in RB, but I only get 'default reviewer'. 
  What I'd like to do is list out all the groups, or more specifically, for 
 each group, list all the user in the group.  There's probably a set of 
 django functions that will do that, but I'm having trouble finding them. 
  Can someone point me in the right direction?

 Thanks

 --Steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: listing all review groups and users within the group using a python script

[Steve]

This example is very helpful.  Thanks!

--Steve


On Wednesday, September 11, 2013 11:43:11 AM UTC-7, Steven MacLeod wrote:

 Yes, this can be done using the API. Assuming you have rbtools 5.x 
 installed, the following script should work. Modify for your desired 
 output. It should be noted that this will make a large number of HTTP 
 requests, and is not optimized.

 from rbtools.api.client import RBClient

 client = RBClient(http://your-rb-server-here)
 root = client.get_root()

 groups = root.get_groups()

 while True:
 for group in groups:
 print group.name
 users = group.get_users()

 while True:
 for user in users:
 print \t%s % user.username

 try:
 users = users.get_next()
 except StopIteration:
 break

 try:
 groups = groups.get_next()
 except StopIteration:
 break


 On Wed, Sep 11, 2013 at 12:46 PM, Steve seide...@gmail.com 
 javascript:wrote:

 Better yet, is there a way to do this with the new RBTools 5.x API?

 --Steve


 On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote:

 I can list all RB users this way:

  from django.contrib.auth.models import User
  for user in User.objects.all():
 print user

 That correctly prints out all of my users. But the same doesn't work for 
 Group

  from django.contrib.auth.models import Group
  for group in Group.objects.all():
 print group
 default reviewer

 I have about 30 groups defined in RB, but I only get 'default reviewer'. 
  What I'd like to do is list out all the groups, or more specifically, for 
 each group, list all the user in the group.  There's probably a set of 
 django functions that will do that, but I'm having trouble finding them. 
  Can someone point me in the right direction?

 Thanks

 --Steve

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.