Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47331/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
Nate Cole, Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan 
Periasamy.


Bugs: AMBARI-16649
https://issues.apache.org/jira/browse/AMBARI-16649


Repository: ambari


Description
---

Restart of Hbase and Storm fails on Kerberos env due to missing principals for 
older stacks.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 d3fc173 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 d715a25 

Diff: https://reviews.apache.org/r/47331/diff/


Testing
---

Verified Hbase and Storm enable / disable plugin for Ranger in Kerberos env.

Verified normal Install / Restarts of Hbase and Storm as well (in Kerberos env).


Thanks,

Gautam Borad

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

[Gautam Borad]

> On May 13, 2016, 4 a.m., Mahadev Konar wrote:
> > Please add unit tests in a new jira asap!

Thanks Mahadev. Create https://issues.apache.org/jira/browse/AMBARI-16650 for 
the unit test cases. Thanks.


- Gautam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47074/#review133026
---


On May 9, 2016, 9:56 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47074/
> ---
> 
> (Updated May 9, 2016, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16290
> https://issues.apache.org/jira/browse/AMBARI-16290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement :**
> 1) Hive Restart fails to create repository in Ranger and goes for retries due 
> to missing principal after enabling hive plugin in in kerberized environment.
> 
> 2) Yarn Restart fails to create repository in Ranger in simple environment.
> 
> ** Proposed Solution : **
> 1) Fixing principal required for hive server, adding new parameters required 
> for Ranger service creation.
> 2) Fixing call for repository creation in simple environemnt.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  4f319ea 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  4a071ca 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  864d937 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f42185e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  72eb3ad 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ec43fea 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  92eaaab 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  12ccef6 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  1dd25ce 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  c5f8940 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  ba4c777 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  cf01965 
> 
> Diff: https://reviews.apache.org/r/47074/diff/
> 
> 
> Testing
> ---
> 
> 1) Verified Enable Hive Plugin and Ranger service creation after enabling 
> plugin in kerberos / simple  environment.
> 
> 2) Verified Enable Yarn Plugin and Ranger service creation after enabling 
> plugin in simple  environment.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

[Mahadev Konar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47074/#review133026
---


Ship it!




Please add unit tests in a new jira asap!

- Mahadev Konar


On May 9, 2016, 9:56 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47074/
> ---
> 
> (Updated May 9, 2016, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16290
> https://issues.apache.org/jira/browse/AMBARI-16290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement :**
> 1) Hive Restart fails to create repository in Ranger and goes for retries due 
> to missing principal after enabling hive plugin in in kerberized environment.
> 
> 2) Yarn Restart fails to create repository in Ranger in simple environment.
> 
> ** Proposed Solution : **
> 1) Fixing principal required for hive server, adding new parameters required 
> for Ranger service creation.
> 2) Fixing call for repository creation in simple environemnt.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  4f319ea 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  4a071ca 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  864d937 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f42185e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  72eb3ad 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ec43fea 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  92eaaab 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  12ccef6 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  1dd25ce 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  c5f8940 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  ba4c777 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  cf01965 
> 
> Diff: https://reviews.apache.org/r/47074/diff/
> 
> 
> Testing
> ---
> 
> 1) Verified Enable Hive Plugin and Ranger service creation after enabling 
> plugin in kerberos / simple  environment.
> 
> 2) Verified Enable Yarn Plugin and Ranger service creation after enabling 
> plugin in simple  environment.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47328/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
jun aoki, and Lav Jain.


Bugs: AMBARI-16646
https://issues.apache.org/jira/browse/AMBARI-16646


Repository: ambari


Description
---

Consider all HAWQ host machines. 
If the lowest memory among all systems is >= 32 GB set vm.overcommit_memory as 
2, else use 1


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
a26a398 
  ambari-server/src/main/resources/stacks/service_advisor.py 86682c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py be0f3e4 

Diff: https://reviews.apache.org/r/47328/diff/


Testing
---

Added unit tests.

```
bash-3.2$ cd ambari-server/src/test/python/stacks/2.3/common/
bash-3.2$ python -m discover -v
test_createComponentLayoutRecommendations_hawq_1_Host 
(test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when 
HAWQ has already been installed ... ServiceAdvisor implementation for service 
HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
when HAWQ is selected for installation ... ServiceAdvisor implementation for 
service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, 
when HAWQ is selected for installation ... ServiceAdvisor implementation for 
service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has 
already been installed ... ServiceAdvisor implementation for service PXF was 
loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is 
selected for installation ... ServiceAdvisor implementation for service PXF was 
loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ok

Re: Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47060/#review132998
---



@Mugdha,
In your patch for AMBARI-13349 you had add logic in 
alert_ranger_admin_passwd_check.py in which based on HDP version we are 
triggering different behavior. I had missed it in that review. Can you also 
update that logic in this patch? 

  security_enabled = False

  stack_is_hdp25_or_further = Script.is_stack_greater_or_equal("2.5")
  
  try:
if security_enabled and stack_is_hdp25_or_further:
  result_code = 'UNKNOWN'
  label = 'This alert will get skipped for Ranger Admin on kerberos env'
else:

- Jayush Luniya


On May 9, 2016, 5:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47060/
> ---
> 
> (Updated May 9, 2016, 5:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16285
> https://issues.apache.org/jira/browse/AMBARI-16285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 1) Renaming properties in ranger-tagsync-site.xml introduced in stack -2.5 
> followed by theme change.
> 2) Removed tagsync user password introduced in previous patch
> 3) Add default password in jceks for rangertagsync and rangerusersync
> 4) Derive tag source as ATLAS, if ATLAS is installed
> 5) Added new properties under ranger-ugsync-site.xml related to Policy 
> manager user's credentials in Ranger usersync service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  59190fe 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  1b56044 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  d013371 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ec0eea1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  aabc37d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  08f6235 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml
>  10ef1a8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml
>  d369098 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json
>  19411d4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
>   ambari-web/app/styles/widgets.less f385449 
> 
> Diff: https://reviews.apache.org/r/47060/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger Tagsync on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 45507: Enhance blueprint support for using references

[Amruta Borkar]

> On April 19, 2016, 8:47 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java,
> >  line 87
> > 
> >
> > If the default top-level "default_password" property is not set, I 
> > believe this validation code would still be useful, so I'm inclined to 
> > think that this block should stay, perhaps in some modified form.

I have moved this method in another class ClusterTopologyImpl.java so that 
check will be performed to see any references left in the blueprint after 
default_password substitution is performed.


> On April 19, 2016, 8:47 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> >  line 158
> > 
> >
> > I'm a little concerned about removing this filter.  
> > 
> > Many times in the past, we've run into situations where a component 
> > that has just been integrated with Ambari will have password properties 
> > that are not marked as such in the Stack metadata.  
> > 
> > This can end up causing a given password to show up in clear text in an 
> > exported Blueprint.
> > 
> > It does make sense that this filter would need to be modified for a 
> > change like the one proposed here, but I think it should be updated, rather 
> > than removed, to still catch the cases it was intended for (password 
> > properties that are not annotated as passwords in the stacks).
> 
> Amruta Borkar wrote:
> Please refer AMBARI-15406-v1

Reintegrated Password filter and added logic to treat password properties 
differently.


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45507/#review129615
---


On May 12, 2016, 9:40 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45507/
> ---
> 
> (Updated May 12, 2016, 9:40 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15395 and AMBARI-15406
> https://issues.apache.org/jira/browse/AMBARI-15395
> https://issues.apache.org/jira/browse/AMBARI-15406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enhance blueprints to export placeholder/token for password properties. This 
> is to avoid user from having tochange the password once the cluster is formed 
> if a user wishes to do so.
> Secret References acting as tokens to password properties would be replaced 
> by user with appropriate passwords,
> If any Secret references are found during cluster deployment with blueprint, 
> those will be replaced by default_password provided in blueprint template. 
> Need more comments to make this feature more portable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  9cc7b13 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  432c6f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/RequiredPasswordValidator.java
>  98eaa40 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  14a718d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  0b06eb8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
>  e8a2ff5 
> 
> Diff: https://reviews.apache.org/r/45507/diff/
> 
> 
> Testing
> ---
> 
> Tested the patch by trying out blueprint export and creating a cluster from 
> the exported blueprint. Result was: the password tokens were replaced by 
> default password and cluster was created successfully.
> 
> 
> File Attachments
> 
> 
> AMBARI-15406.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/30/8daa09ee-82e5-4cd8-98d3-b1c00f1269b7__AMBARI-15406.patch
> AMBARI-15406-v1
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/12/7faf76cc-a42d-4017-b203-8db19448b09d__AMBARI-15406.patch
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 45507: Enhance blueprint support for using references

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45507/
---

(Updated May 12, 2016, 9:40 p.m.)


Review request for Ambari, Jayush Luniya, Robert Nettleton, and Yusaku Sako.


Changes
---

Hi Bob, Jayush,

I have addressed the issues marked below in this patch. Please review and 
provide your comments. 

Thank you,
Amruta


Bugs: AMBARI-15395 and AMBARI-15406
https://issues.apache.org/jira/browse/AMBARI-15395
https://issues.apache.org/jira/browse/AMBARI-15406


Repository: ambari


Description
---

Enhance blueprints to export placeholder/token for password properties. This is 
to avoid user from having tochange the password once the cluster is formed if a 
user wishes to do so.
Secret References acting as tokens to password properties would be replaced by 
user with appropriate passwords,
If any Secret references are found during cluster deployment with blueprint, 
those will be replaced by default_password provided in blueprint template. 
Need more comments to make this feature more portable.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 9cc7b13 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 432c6f8 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/RequiredPasswordValidator.java
 98eaa40 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 14a718d 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 0b06eb8 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
 e8a2ff5 

Diff: https://reviews.apache.org/r/45507/diff/


Testing
---

Tested the patch by trying out blueprint export and creating a cluster from the 
exported blueprint. Result was: the password tokens were replaced by default 
password and cluster was created successfully.


File Attachments (updated)


AMBARI-15406.patch
  
https://reviews.apache.org/media/uploaded/files/2016/03/30/8daa09ee-82e5-4cd8-98d3-b1c00f1269b7__AMBARI-15406.patch
AMBARI-15406-v1
  
https://reviews.apache.org/media/uploaded/files/2016/05/12/7faf76cc-a42d-4017-b203-8db19448b09d__AMBARI-15406.patch


Thanks,

Amruta Borkar

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132985
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
 (line 188)


Please move hard-coded texts like this to i18n.config.js


- Richard Zang


On May 12, 2016, 7:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 12, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some effective privilege coming from its group(s). In the fix, the Alert 
> must show the relevant message.
> 4. Alert messages must show more informative messages of what is happening 
> with the user's privileges and why. (addressing 1.2 and 2.3)
> 
> 
> Diffs
> -
> 
>   
> 

Re: Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47322/#review132984
---


Ship it!




Ship It!

- Miklos Gergely


On May 12, 2016, 8:04 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47322/
> ---
> 
> (Updated May 12, 2016, 8:04 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16640
> https://issues.apache.org/jira/browse/AMBARI-16640
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case ambari creates deb package from a directory (not from tar.gz), then 
> permissions not preserved.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 90504e6 
> 
> Diff: https://reviews.apache.org/r/47322/diff/
> 
> 
> Testing
> ---
> 
> FT: created deb package in debian7.6, mapped permissions looking good.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

[Goutam Tadi]

> On May 12, 2016, 4:51 a.m., Matt wrote:
> > Would you like to add tests for this new widget?

Added


- Goutam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/#review132815
---


On May 12, 2016, 9:26 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47252/
> ---
> 
> (Updated May 12, 2016, 9:26 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16461
> https://issues.apache.org/jira/browse/AMBARI-16461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF Agents Live Widget on Dashboard needs custom widget to display only 
> single threshold i.e., Green/Red only
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js eb2edf1 
>   ambari-web/app/messages.js 910bed7 
>   ambari-web/app/mixins.js cf8cef6 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> PRE-CREATION 
>   ambari-web/app/styles/modal_popups.less 5e89dbc 
>   
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs
>  PRE-CREATION 
>   ambari-web/app/views.js 127a996 
>   ambari-web/app/views/main/dashboard/widgets.js 38181c0 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
>   ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
> PRE-CREATION 
>   ambari-web/test/aliases/computed/gtProperties.js f3f1def 
>   
> ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47252/diff/
> 
> 
> Testing
> ---
> 
> Yes, All tests passed. Test was already in place.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/
---

(Updated May 12, 2016, 9:26 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16461
https://issues.apache.org/jira/browse/AMBARI-16461


Repository: ambari


Description
---

PXF Agents Live Widget on Dashboard needs custom widget to display only single 
threshold i.e., Green/Red only


Diffs (updated)
-

  ambari-web/app/assets/test/tests.js eb2edf1 
  ambari-web/app/messages.js 910bed7 
  ambari-web/app/mixins.js cf8cef6 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
PRE-CREATION 
  ambari-web/app/styles/modal_popups.less 5e89dbc 
  
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 
PRE-CREATION 
  ambari-web/app/views.js 127a996 
  ambari-web/app/views/main/dashboard/widgets.js 38181c0 
  ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
  ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
PRE-CREATION 
  ambari-web/test/aliases/computed/gtProperties.js f3f1def 
  
ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47252/diff/


Testing
---

Yes, All tests passed. Test was already in place.


Thanks,

Goutam Tadi

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/
---

(Updated May 12, 2016, 9:19 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Changes
---

Applied feedback


Bugs: AMBARI-16461
https://issues.apache.org/jira/browse/AMBARI-16461


Repository: ambari


Description
---

PXF Agents Live Widget on Dashboard needs custom widget to display only single 
threshold i.e., Green/Red only


Diffs (updated)
-

  ambari-web/app/assets/test/tests.js eb2edf1 
  ambari-web/app/messages.js 910bed7 
  ambari-web/app/mixins.js cf8cef6 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
PRE-CREATION 
  ambari-web/app/styles/modal_popups.less 5e89dbc 
  
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 
PRE-CREATION 
  ambari-web/app/views.js 127a996 
  ambari-web/app/views/main/dashboard/widgets.js 38181c0 
  ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
  ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
PRE-CREATION 
  ambari-web/test/aliases/computed/gtProperties.js f3f1def 
  
ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47252/diff/


Testing
---

Yes, All tests passed. Test was already in place.


Thanks,

Goutam Tadi

Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47322/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16640
https://issues.apache.org/jira/browse/AMBARI-16640


Repository: ambari


Description
---

In case ambari creates deb package from a directory (not from tar.gz), then 
permissions not preserved.


Diffs
-

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 90504e6 

Diff: https://reviews.apache.org/r/47322/diff/


Testing
---

FT: created deb package in debian7.6, mapped permissions looking good.


Thanks,

Oliver Szabo

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/
---

(Updated May 12, 2016, 7:57 p.m.)


Review request for Ambari, Di Li and Richard Zang.


Bugs: AMBARI-15552
https://issues.apache.org/jira/browse/AMBARI-15552


Repository: ambari


Description
---

Reproduction Steps:
1. Go to Admin->Manage Ambari
2. Create a group with a few users belonging to it. 
(I have created "mygroup" with "user1", "user2", "user3") 
(attachments "user1.tiff", "mygroup.tiff" shows samples)
3. Go to Clusters->Roles on the left navigation menu.
4. The default view is the "Block" view for the roles. Assign "mygroup" a role, 
say "Cluster User". 
(attachment "block_view_original.tiff")
5. Click on "List" view, it will show Users by default. It correctly shows the 
role "Cluster User" for each user in "mygroup". 
(attachment "list_view_users.tiff")
6. Now, try adding a new Role, say "Service Operator", to one of the users, say 
"user3". 
(attachments "list_view_add_role_to_user_step1.tiff", 
"list_view_add_role_to_user_step2.tiff")
7. After making this change, the role gets added for that user (in our case 
"user3"), but the roles from other users in its group gets removed. Also, the 
previous role for the user ("user3") is replaced by the new Role.
(attachment "list_view_add_role_to_user_step3.tiff")
8. You can confirm this from the the "Block" view. 
(attachment "block_view_after_step3.tiff")

So, the problem here lies with the List view where it is not able to process 
the changes in the Roles correctly. A change in the Role of a user causes the 
following:

CASE-1: The displayed role (effective privilege) comes from an explicitly 
assigned role to the user.
1.1) The new selected role correctly replaces the existing privilege that was 
explicitly assigned to the user.
1.2) But if the user was assigned multiple roles explicilty (before the fix for 
AMBARI-16102 got pushed in), then all the other roles, which are of lower 
privilege than the role that got replaced, are still displayed in the Block 
view (because those roles are still in the database). So, if the new selected 
role happened to be of a lower privilege than and existing role of the user, 
then even though the user sees a success Alert message, the effective privileg 
he sees is different. For the Ambari user, this behavior is not easily 
understandable.

CASE-2: The displayed role (effective privilege) comes from a group the user 
belongs to.
2.1) If the new selected privilege is higher than the effective privilege 
coming from the user's group(s), then the newly selected role replaces this 
"group" privilege in the database, insetad of creating a new entry.
2.2) As a result of losing the group privilege, all the group members also lose 
their privileges and they show "None" as their effective privilege.
2.3) If the newly selected privilege is lower than effective group privilege, 
the Alert message shows a success of role change but the effective privilge is 
still not the one that the Ambari user selected.


Expected results:
1. Updating a Role of a user must replace any/all of the explicit roles it has 
been assigned through the Block View. (this addresses 1.2)
Note: Even though AMBARI-16102 has attempted to fix the Block view by allowing 
only a user to have just one role assigned to it, there could be cases where 
the earlier version of Block view has already allowed users to have multiple 
roles. So, taking this into consideration, the fix must address removing any or 
all of the roles the user was assigned explicitly.
2. Adding a Role to a user must not affect the Roles of other users in its 
group. (addressing 2.1 and 2.2)
3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
None". This  may not reflect the correct privilege status as the user might 
have some effective privilege coming from its group(s). In the fix, the Alert 
must show the relevant message.
4. Alert messages must show more informative messages of what is happening with 
the user's privileges and why. (addressing 1.2 and 2.3)


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
 11a73f6 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 
ff388cd 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
 edf16be 

Diff: https://reviews.apache.org/r/46808/diff/


Testing
---

The testing done mainly checks the logic used to update the privileges of the 
user/group which is done after a REST call to retrieve the privileges.

The test cases have mocks setup for server calls. The response from the server 
calls are also mocked to work with a particular set of users and groups.

The logic in the .then() clause following 

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Keta Patel]

> On May 10, 2016, 10:28 p.m., Richard Zang wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js,
> >  line 181
> > 
> >
> > loadUser() needs to be called strictly after delete/add operation to 
> > have the up-to-date roles loaded. It's better to put it in the then block. 
> > This can be tested in the case I mentioned earlier: mygroup has "cluster 
> > user" role and aaa bbb ccc are in mygroup. Change aaa to "cluster 
> > administrator", confirm, then change aaa back to None, aaa stays at 
> > "cluster administrator" because loadUser() happens before delete finishes.
> 
> Keta Patel wrote:
> As per your suggestion, I have added "addPrivilege(user)" to the then 
> clause of the deletePrivilege calls. Since I use individual delete calls for 
> the various privilege IDs, I make use of "Prromise.all().then()" to ensure 
> that addPrivilege() gets called only after all the delete calls are complete. 
> The patch "AMBARI-15552-May-11.patch" contains these changes.
> I couldn't figure out using "deletePrivileges()" to delete a set of 
> privileges and so made use of these individual calls. If you think using the 
> individual "deletePrivileges()" call is workable in this case, could you 
> please provide me with the information on the valid attributes for the body.
> 
> Thank you!
> 
> Richard Zang wrote:
> Please try DELETE 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/privileges?PrivilegeInfo/privilege_id.in(12,13)

Hello Richard,
Thank you providing the information on using the deleting multiple Privileges 
API.
I have updated the patch to use this API now. This will save making multiple 
calls to delete the different privileges.
Please find the updated patch named "AMBARI-15552-May-12.patch" with all the 
relevant changes for this Jira.

Keta


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132555
---


On May 11, 2016, 10:08 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 11, 2016, 10:08 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the 

Re: Review Request 47009: Falcon server start fails

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132953
---


Ship it!




Ship It!

- Sumit Mohanty


On May 11, 2016, 8:52 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 11, 2016, 8:52 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47304: Provide default VDF for enabled stacks

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47304/#review132945
---


Ship it!




good feature

- Dmitro Lisnichenko


On May 12, 2016, 3:25 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47304/
> ---
> 
> (Updated May 12, 2016, 3:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16462
> https://issues.apache.org/jira/browse/AMBARI-16462
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For enabled stacks, create VDF for consumption from the 
> /api/v1/version_definitions endpoint.  This is available via the 
> {{show_available}} option, but will create VDF based on stack information 
> ({{repoinfo.xml}}).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  77f2ede 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  94b9648 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 6129ec0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 9fb6106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  3111a4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  fc2bab1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  1117d24 
> 
> Diff: https://reviews.apache.org/r/47304/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> 
> Tests run: 4326, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:54.528s
> [INFO] Finished at: Thu May 12 07:46:59 EDT 2016
> [INFO] Final Memory: 35M/703M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/#review132943
---




ambari-web/app/messages.js (line 2659)


a proper grammar is "between X and Y", I believe, not "between X to Y"



ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js (line 
31)


if the threshold is single, then we don't need 1 at the end of variable 
name.



ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js (line 
111)


we don't have orange here, do we ?


- Alexander Denissov


On May 11, 2016, 7:04 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47252/
> ---
> 
> (Updated May 11, 2016, 7:04 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16461
> https://issues.apache.org/jira/browse/AMBARI-16461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF Agents Live Widget on Dashboard needs custom widget to display only 
> single threshold i.e., Green/Red only
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js c5e1145 
>   ambari-web/app/mixins.js cf8cef6 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> PRE-CREATION 
>   ambari-web/app/styles/modal_popups.less 5e89dbc 
>   
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs
>  PRE-CREATION 
>   ambari-web/app/views.js 127a996 
>   ambari-web/app/views/main/dashboard/widgets.js 38181c0 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
>   ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47252/diff/
> 
> 
> Testing
> ---
> 
> Yes, All tests passed. Test was already in place.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 47134: HAWQ Password handling updated

[bhuvnesh chaudhary]

> On May 12, 2016, 4:43 a.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py, line 31
> > 
> >
> > This is not required. Refer comment on the test_hawqsegment.py file.

Thanks Matt for the suggestion. Used getConfig.


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132812
---


On May 12, 2016, 1:07 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 12, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 

Re: Review Request 47134: HAWQ Password handling updated

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/
---

(Updated May 12, 2016, 4:26 p.m.)


Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Changes
---

Applied feedback


Bugs: AMBARI-16386
https://issues.apache.org/jira/browse/AMBARI-16386


Repository: ambari


Description
---

Updated salt used while creating HAWQ user, and also ensured that the password 
is treated exactly as entered on the HAWQ config ui.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 1bdc85a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 670a58b 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 

Diff: https://reviews.apache.org/r/47134/diff/


Testing
---

yes.
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,997 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-05-09 12:54:42,009 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Not Kerberized ... 2016-05-09 12:54:42,021 - Executing HAWQ Check ...
ok
test_run_hawq_check_case4 

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review132935
---


Ship it!




Ship It!

- Jayush Luniya


On May 12, 2016, 12:41 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 12, 2016, 12:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  aabc37d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 6e506a0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 47271: Use consistent names for Log Search service

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47271/
---

(Updated May 12, 2016, 3:46 p.m.)


Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Changes
---

other small changes + rebase


Bugs: AMBARI-16206
https://issues.apache.org/jira/browse/AMBARI-16206


Repository: ambari


Description
---

use cosistent naming in configurations for LOGSEARCH service ("Log Search" 
instead of Logsearch and LogSearch)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
0ab2b19 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 55e5efe 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
 40d14af 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 c0aa8f4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 f04a5c4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 8444d19 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 46447d8 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
 259fb28 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 9511738 
  ambari-web/app/models/quick_links.js b062895 

Diff: https://reviews.apache.org/r/47271/diff/


Testing
---

web and server pyton tests were successful


Thanks,

Oliver Szabo

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review132928
---




ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java
 


Any reason this is being removed?


- Sumit Mohanty


On May 12, 2016, 11:31 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47296/
> ---
> 
> (Updated May 12, 2016, 11:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16629
> https://issues.apache.org/jira/browse/AMBARI-16629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Authentication : change the API as per suggestion and support for roles in 
> authentication process.
> 2) resultSize property removed from collection class.
> 3) "Preview" issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  0442cf9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  a60402e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  cc61127 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  8535039 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java
>  97226d2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  79a414c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  315d736 
> 
> Diff: https://reviews.apache.org/r/47296/diff/
> 
> 
> Testing
> ---
> 
> Tested in my local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

[Robert Levas]

> On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote:
> > ambari-server/docs/api/v1/permission-get.md, line 75
> > 
> >
> > The official label is going to have an abbreviated word in it?
> 
> Robert Levas wrote:
> Yup.. :|

That's what users are used to since the administrator role has been named that 
way for a while... and we dont want to add too much confusion with this change.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/#review132916
---


On May 11, 2016, 10:06 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47237/
> ---
> 
> (Updated May 11, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.
> 
> 
> Bugs: AMBARI-16449
> https://issues.apache.org/jira/browse/AMBARI-16449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
> "Ambari Admin"
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/permission-get.md d949344 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  2389d0d 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 22413e0 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> ea7ab7a 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  67a94ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
>  f03d240 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
>  bcfae8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
>  4e0ba24 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  6cf520d 
> 
> Diff: https://reviews.apache.org/r/47237/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade and new instance creation.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

[Robert Levas]

> On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote:
> > ambari-server/docs/api/v1/permission-get.md, line 75
> > 
> >
> > The official label is going to have an abbreviated word in it?

Yup.. :|


> On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java,
> >  line 383
> > 
> >
> > Why not just extend the 
> > PermissionEntity.AMBARI_ADMINISTRATOR_PERMISSION_NAME to be an enum which 
> > contains botht he label and the name? Seems like instead of 
> > literal-stringing it all over the place, it would be better to encapsulate 
> > these in an enum.

Ideally this value is taken from the database.  This is to help with future 
proofing for when we allow users to create their own roles (shhh... you didn't 
hear that from me, but I think it makes sense to prepare for this because I 
think it should eventually be a feature).


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/#review132916
---


On May 11, 2016, 10:06 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47237/
> ---
> 
> (Updated May 11, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.
> 
> 
> Bugs: AMBARI-16449
> https://issues.apache.org/jira/browse/AMBARI-16449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
> "Ambari Admin"
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/permission-get.md d949344 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  2389d0d 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 22413e0 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> ea7ab7a 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  67a94ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
>  f03d240 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
>  bcfae8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
>  4e0ba24 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  6cf520d 
> 
> Diff: https://reviews.apache.org/r/47237/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade and new instance creation.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/#review132915
---


Ship it!




Ship It!

- Jonathan Hurley


On May 12, 2016, 8:58 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46944/
> ---
> 
> (Updated May 12, 2016, 8:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav 
> Papirkovskyy, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16230
> https://issues.apache.org/jira/browse/AMBARI-16230
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 different type of errors can occur during adding any new service to Ambari:
> 
> org.apache.ambari.server.AmbariException: Unable to create a default alert 
> group for unknown service  in cluster
> 
> org.apache.ambari.server.ServiceNotFoundException: Service not found, 
> clusterName=c1, serviceName=
> 
> The reason is that: ServiceInstalledEvent can be handled quicker than 
> ServiceImpl.persist() can finish
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  47342f3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 303b043 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 487489b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  108732f 
>   ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
> a3d05a9 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> 19146fd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  d1b27a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  1875ba6 
> 
> Diff: https://reviews.apache.org/r/46944/diff/
> 
> 
> Testing
> ---
> 
> Unit Testing is in progress..
> FT: deploy cluster, add service, restart ambari with deployed cluster.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47315/#review132917
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Травень 12, 2016, 5:28 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47315/
> ---
> 
> (Updated Травень 12, 2016, 5:28 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16635
> https://issues.apache.org/jira/browse/AMBARI-16635
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  ba5774f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
> 
> Diff: https://reviews.apache.org/r/47315/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/#review132916
---


Ship it!





ambari-server/docs/api/v1/permission-get.md (line 75)


The official label is going to have an abbreviated word in it?



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 (line 383)


Why not just extend the 
PermissionEntity.AMBARI_ADMINISTRATOR_PERMISSION_NAME to be an enum which 
contains botht he label and the name? Seems like instead of literal-stringing 
it all over the place, it would be better to encapsulate these in an enum.


- Jonathan Hurley


On May 11, 2016, 10:06 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47237/
> ---
> 
> (Updated May 11, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.
> 
> 
> Bugs: AMBARI-16449
> https://issues.apache.org/jira/browse/AMBARI-16449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
> "Ambari Admin"
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/permission-get.md d949344 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  2389d0d 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 22413e0 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> ea7ab7a 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  67a94ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
>  f03d240 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
>  bcfae8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
>  4e0ba24 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  6cf520d 
> 
> Diff: https://reviews.apache.org/r/47237/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade and new instance creation.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47316: Ambari should delete the ambarismoketest table

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47316/#review132912
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 12, 2016, 2:21 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47316/
> ---
> 
> (Updated Травень 12, 2016, 2:21 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16636
> https://issues.apache.org/jira/browse/AMBARI-16636
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari create a table "ambarismoketest" for hbase deployments, but after the
> smoke test, it just leaves the table there. We should delete the table and
> clean up after the test.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/files/hbase-smoke-cleanup.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py
>  6ecb58e 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_service_check.py 
> 69a6665 
> 
> Diff: https://reviews.apache.org/r/47316/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47315/
---

(Updated Травень 12, 2016, 2:28 після полудня)


Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-16635
https://issues.apache.org/jira/browse/AMBARI-16635


Repository: ambari


Description
---

.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 ba5774f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 3547ad3 

Diff: https://reviews.apache.org/r/47315/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 46661: Put HBase master UI into readonly mode for secure deployment for HDP 2.5

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46661/#review132907
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
143)


I dont think you need to do this.  Can you remove this line an retest. See 
that `recommendHIVEConfigurations` does not call `self.putPropery` yet 
`putHiveInteractiveEnvProperty` is available for use.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
(lines 145 - 148)


what needs to happen when security is disbled and 
`hbase.master.ui.readonly` is `true`?  Does this property need to be removed or 
set to `false`?


- Robert Levas


On May 11, 2016, 7:31 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46661/
> ---
> 
> (Updated May 11, 2016, 7:31 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16164
> https://issues.apache.org/jira/browse/AMBARI-16164
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently in secure deployment, user can request compaction / splitting 
> through hbase master UI.
> This potentially exposes vulnerability to various attacks.
> There is config parameter, hbase.master.ui.readonly, with default value of 
> false.
> In secure deployment, Master UI should be put to readonly mode (setting the 
> above parameter to true).
> Admin can always request compaction / splitting through hbase shell.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 3d689d7dd4f9c5bd98d5d4e0152775fd7ea012a2 
> 
> Diff: https://reviews.apache.org/r/46661/diff/
> 
> 
> Testing
> ---
> 
> Manual testing, sceenshot attached (after kerberizing cluster).
> 
> 
> File Attachments
> 
> 
> hbase-site.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/11/75e8d2ae-99a4-4e8d-8a69-52cd974734fb__hbase-site.png
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 47271: Use consistent names for Log Search service

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47271/#review132909
---


Ship it!




Ship It!

- Miklos Gergely


On May 12, 2016, 12:28 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47271/
> ---
> 
> (Updated May 12, 2016, 12:28 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16206
> https://issues.apache.org/jira/browse/AMBARI-16206
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> use cosistent naming in configurations for LOGSEARCH service ("Log Search" 
> instead of Logsearch and LogSearch)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> 0ab2b19 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  55e5efe 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
>  40d14af 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  c0aa8f4 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  f04a5c4 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  ce53692 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
>  46447d8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
>  259fb28 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 9511738 
>   ambari-web/app/models/quick_links.js b062895 
> 
> Diff: https://reviews.apache.org/r/47271/diff/
> 
> 
> Testing
> ---
> 
> web and server pyton tests were successful
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47315/#review132908
---


Ship it!




Ship It!

- Dmytro Sen


On Май 12, 2016, 2:07 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47315/
> ---
> 
> (Updated Май 12, 2016, 2:07 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16635
> https://issues.apache.org/jira/browse/AMBARI-16635
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  ba5774f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
> 
> Diff: https://reviews.apache.org/r/47315/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47315/
---

Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sumit Mohanty.


Bugs: AMBARI-16635
https://issues.apache.org/jira/browse/AMBARI-16635


Repository: ambari


Description
---

.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 ba5774f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 3547ad3 

Diff: https://reviews.apache.org/r/47315/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47305/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Mahadev Konar, 
and Rohit Choudhary.


Bugs: AMBARI-16146
https://issues.apache.org/jira/browse/AMBARI-16146


Repository: ambari


Description
---

Earlier : The synchronized UserLocalConnection.initialValue() was taking time 
to get hive connection and all other threads were blocking to get inside this 
synchronized block.

In this patch : 
1. Removed synchronized from UserLocalConnection.initialValue() and from 
UserLocalHiveAuthCredentials.initialValue()
2. Introduced locking on specific key and not the complete method. Key would be 
like Connection_INSTANCE-NAME:USER-NAME. So threads for other keys will not get 
into contension with this lock. This avoids blocking of thread that do not want 
to initialize different keys.
3. Used tryLock and fail with exception if lock cannot be obtained immediately. 
This avoids blocking of threads that want to initialize same key as one key 
should be initialized only once.
4. corrected synchronization at several places inside UserLocal class.


Diffs
-

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java
 c80a4c4 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java
 9c72863 
  contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java 
40c8e6e 

Diff: https://reviews.apache.org/r/47305/diff/


Testing
---

Manual testing done by introducing Thread.sleep in 
UserLocalConnection.initialValue() and creating more requests with following 
combinations and logs.
0. first thread for connection + user + view combination obtains the lock and 
goes inside UserLocalConnection.initialValue() and sleeps
1. same user, same hive view requests for connections fails to get lock with 
exception.
2. same user, different hive view -- if first request gets new lock and goes 
inside UserLocalConnection.initialValue().
3. same user, different hive view -- if connection created once then works 
fine. does not block.
4. different user, same view -- gets new lock and goes inside 
UserLocalConnection.initialValue() if first, else works fine.
5. different user, different view -- works as 4.
6. once the first thread come out of initialValue(), rest threads don't try to 
get lock and don't fail either, works fine.


Thanks,

Nitiraj Rathore

Re: Review Request 47304: Provide default VDF for enabled stacks

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47304/#review132900
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (lines 1367 - 1370)


VDFXml.build() might throw an exception like a NPE; should we try/catch 
this to prevent problems on server start.


- Jonathan Hurley


On May 12, 2016, 8:25 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47304/
> ---
> 
> (Updated May 12, 2016, 8:25 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16462
> https://issues.apache.org/jira/browse/AMBARI-16462
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For enabled stacks, create VDF for consumption from the 
> /api/v1/version_definitions endpoint.  This is available via the 
> {{show_available}} option, but will create VDF based on stack information 
> ({{repoinfo.xml}}).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  77f2ede 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  94b9648 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 6129ec0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 9fb6106 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  3111a4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  fc2bab1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  1117d24 
> 
> Diff: https://reviews.apache.org/r/47304/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> 
> Tests run: 4326, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:54.528s
> [INFO] Finished at: Thu May 12 07:46:59 EDT 2016
> [INFO] Final Memory: 35M/703M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47177: Hive view : Upload Table : On unchecking "Is first row header ?" checkbox, the column name should be changed to some default values instead of the first row.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47177/#review132903
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 10, 2016, 10:49 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47177/
> ---
> 
> (Updated May 10, 2016, 10:49 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16424
> https://issues.apache.org/jira/browse/AMBARI-16424
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the header column names used to remain the same as the first row of 
> the file.
> 
> In this patch : UI has been changed to show the default column names 
> "column1" etc.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  d883743 
> 
> Diff: https://reviews.apache.org/r/47177/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

[DIPAYAN BHOWMICK]

> On May 12, 2016, 1:59 p.m., DIPAYAN BHOWMICK wrote:
> > Ship It!

Remove the console.logs


- DIPAYAN


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47175/#review132901
---


On May 12, 2016, 12:51 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47175/
> ---
> 
> (Updated May 12, 2016, 12:51 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16422
> https://issues.apache.org/jira/browse/AMBARI-16422
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earliar : UI should show validation error cue to the user for fields like 
> column names and table name if illegal names are present.
> 
> In this Patch : added new component for UI validation of text fields through 
> regex. It will show red border around invalid values.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  d883743 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
> 
> Diff: https://reviews.apache.org/r/47175/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47175/#review132901
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 12, 2016, 12:51 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47175/
> ---
> 
> (Updated May 12, 2016, 12:51 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16422
> https://issues.apache.org/jira/browse/AMBARI-16422
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earliar : UI should show validation error cue to the user for fields like 
> column names and table name if illegal names are present.
> 
> In this Patch : added new component for UI validation of text fields through 
> regex. It will show red border around invalid values.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  d883743 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
> 
> Diff: https://reviews.apache.org/r/47175/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47178: Hive view : Upload Table throws exception when 'stored as' is set to 'INPUTFORMAT'

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47178/#review132898
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 10, 2016, 11:05 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47178/
> ---
> 
> (Updated May 10, 2016, 11:05 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16425
> https://issues.apache.org/jira/browse/AMBARI-16425
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earliar : There used to be an INPUTFORMAT option in stored as dropdown of 
> upload table feature.
> 
> In this patch : That option has been removed.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  d883743 
> 
> Diff: https://reviews.apache.org/r/47178/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review132892
---



Thanks for contributing this patch.

I believe that some more work needs to be done here before this patch gets 
approved.

In particular, please see my comments on the VList.java changes.  I believe 
this change will break the existing REST API usage in the Ambari Server 
integration layer, and so I'd recommend that at least that portion of the patch 
be reverted.

Thanks.


ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java
 


This change is problematic, since the Ambari Integration API already relies 
on the return results from the LogSearch Server.

At this point in the dev cycle, we can't be changing the API at all from 
LogSearch, or the Ambari Integration will be broken.

Because this is one of the types serialized in responses to the REST API, 
this is a part of the API, and at this point in the dev cycle should be frozen. 
 

I'd request that this part of the patch be reverted. 

Thanks.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 (line 53)


Looks like a type here, can you please fix this enum type to look like:

"PRIVILEGE_INFO"

Thanks



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 (line 56)


Wouldn't it be simpler to just override the toString() methods for this 
enumerated type?


- Robert Nettleton


On May 12, 2016, 11:31 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47296/
> ---
> 
> (Updated May 12, 2016, 11:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16629
> https://issues.apache.org/jira/browse/AMBARI-16629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Authentication : change the API as per suggestion and support for roles in 
> authentication process.
> 2) resultSize property removed from collection class.
> 3) "Preview" issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  0442cf9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  a60402e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  cc61127 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  8535039 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java
>  97226d2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  79a414c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  315d736 
> 
> Diff: https://reviews.apache.org/r/47296/diff/
> 
> 
> Testing
> ---
> 
> Tested in my local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Review Request 47306: Ambari Admin Privilege required for Pig and Hive View. 403 error received when opening Pig View by a non-admin user

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47306/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16634
https://issues.apache.org/jira/browse/AMBARI-16634


Repository: ambari


Description
---

Extended view Cluster interface to return hosts for service component.
Used this method for geting the hosts for hive server, webhcat. Instead of 
using Ambari Api in attached mode.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
529e09a 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 f661844 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ClusterImplTest.java 
daf87ec 
  
ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
 ce8fe7d 
  ambari-views/src/main/java/org/apache/ambari/view/cluster/Cluster.java 
f1b8177 
  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 718c5a5 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
 6072d28 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 1bace94 

Diff: https://reviews.apache.org/r/47306/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/#review132890
---


Ship it!




Ship It!

- Sebastian Toader


On May 12, 2016, 2:58 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46944/
> ---
> 
> (Updated May 12, 2016, 2:58 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav 
> Papirkovskyy, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16230
> https://issues.apache.org/jira/browse/AMBARI-16230
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 different type of errors can occur during adding any new service to Ambari:
> 
> org.apache.ambari.server.AmbariException: Unable to create a default alert 
> group for unknown service  in cluster
> 
> org.apache.ambari.server.ServiceNotFoundException: Service not found, 
> clusterName=c1, serviceName=
> 
> The reason is that: ServiceInstalledEvent can be handled quicker than 
> ServiceImpl.persist() can finish
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  47342f3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 303b043 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 487489b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  108732f 
>   ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
> a3d05a9 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> 19146fd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  d1b27a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  1875ba6 
> 
> Diff: https://reviews.apache.org/r/46944/diff/
> 
> 
> Testing
> ---
> 
> Unit Testing is in progress..
> FT: deploy cluster, add service, restart ambari with deployed cluster.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/
---

(Updated May 12, 2016, 12:58 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav 
Papirkovskyy, Sumit Mohanty, and Sebastian Toader.


Changes
---

- removed the catch part from ServiceImpl#persist(), if the "Service already 
exists" is not needed, then we cannot get an AmbariException.


Bugs: AMBARI-16230
https://issues.apache.org/jira/browse/AMBARI-16230


Repository: ambari


Description
---

2 different type of errors can occur during adding any new service to Ambari:

org.apache.ambari.server.AmbariException: Unable to create a default alert 
group for unknown service  in cluster

org.apache.ambari.server.ServiceNotFoundException: Service not found, 
clusterName=c1, serviceName=

The reason is that: ServiceInstalledEvent can be handled quicker than 
ServiceImpl.persist() can finish


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 47342f3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
303b043 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
487489b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 108732f 
  ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
a3d05a9 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
19146fd 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
 d1b27a9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 1875ba6 

Diff: https://reviews.apache.org/r/46944/diff/


Testing
---

Unit Testing is in progress..
FT: deploy cluster, add service, restart ambari with deployed cluster.


Thanks,

Oliver Szabo

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47175/#review132883
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 10, 2016, 10:25 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47175/
> ---
> 
> (Updated May 10, 2016, 10:25 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16422
> https://issues.apache.org/jira/browse/AMBARI-16422
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earliar : UI should show validation error cue to the user for fields like 
> column names and table name if illegal names are present.
> 
> In this Patch : added new component for UI validation of text fields through 
> regex. It will show red border around invalid values.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/validated-text-field.js
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  d883743 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  b7d9011 
> 
> Diff: https://reviews.apache.org/r/47175/diff/
> 
> 
> Testing
> ---
> 
> Manual testing required.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47297: Extend logging for ActionQueue's retry logic

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47297/#review132878
---


Ship it!




Ship It!

- Oliver Szabo


On May 12, 2016, 9:05 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47297/
> ---
> 
> (Updated May 12, 2016, 9:05 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16330
> https://issues.apache.org/jira/browse/AMBARI-16330
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> At info level, commands should be tracked if they are retried on failure or 
> not, and if not, what is the reason for that.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d0efa2 
> 
> Diff: https://reviews.apache.org/r/47297/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:19.911s
> [INFO] Finished at: Thu May 12 10:58:43 CEST 2016
> [INFO] Final Memory: 17M/850M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47297: Extend logging for ActionQueue's retry logic

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47297/#review132877
---


Ship it!




Ship It!

- Sebastian Toader


On May 12, 2016, 11:05 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47297/
> ---
> 
> (Updated May 12, 2016, 11:05 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16330
> https://issues.apache.org/jira/browse/AMBARI-16330
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> At info level, commands should be tracked if they are retried on failure or 
> not, and if not, what is the reason for that.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d0efa2 
> 
> Diff: https://reviews.apache.org/r/47297/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:19.911s
> [INFO] Finished at: Thu May 12 10:58:43 CEST 2016
> [INFO] Final Memory: 17M/850M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/
---

(Updated May 12, 2016, 11:31 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Refactored the classes to remove excess indentation.


Bugs: AMBARI-16629
https://issues.apache.org/jira/browse/AMBARI-16629


Repository: ambari


Description
---

Patch contains
1) Authentication : change the API as per suggestion and support for roles in 
authentication process.
2) resultSize property removed from collection class.
3) "Preview" issue fixed.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 0442cf9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
 a60402e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
 cc61127 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
 8535039 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java
 97226d2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 79a414c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
 315d736 

Diff: https://reviews.apache.org/r/47296/diff/


Testing
---

Tested in my local Ambari environment.


Thanks,

Dharmesh Makwana

Re: Review Request 47299: Ambari should check if the PID changes after restart, to confirm the process has been restarted

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47299/#review132871
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 12, 2016, 2:11 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47299/
> ---
> 
> (Updated May 12, 2016, 2:11 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16631
> https://issues.apache.org/jira/browse/AMBARI-16631
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> f578fc4 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 5ca6c62 
> 
> Diff: https://reviews.apache.org/r/47299/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47299: Ambari should check if the PID changes after restart, to confirm the process has been restarted

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47299/
---

(Updated May 12, 2016, 11:11 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-16631
https://issues.apache.org/jira/browse/AMBARI-16631


Repository: ambari


Description (updated)
---

.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
f578fc4 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
5ca6c62 

Diff: https://reviews.apache.org/r/47299/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 47300: Included few more steps in "Take a tour" feature and few more enhancements

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47300/
---

Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and 
Sumit Mohanty.


Bugs: AMBARI-16632
https://issues.apache.org/jira/browse/AMBARI-16632


Repository: ambari


Description
---

Patch contains
1) Added few steps more in "Take a tour" option.
2) When url contains "host_name" and "component_name" params than separate tab 
should be open for that component.
3) Comparison tab clean-up, default pageSize changed to 25 and css changes.
4) In histogram graph, time gap is shown above the graph.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js 
6abccf6 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js 
5d55689 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
 ba21b65 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js
 0849820 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/MainLayoutView.js
 09bbacc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/graphs/GraphLayoutView.js
 805b507 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/ComparisonView.js
 8ad0c4b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js
 cb4228c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
 2d19d78 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
 e1bc90a 
  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style.css 
05fd491 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/audit/AuditTabLayoutView_tmpl.html
 2f0a596 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/graphs/GraphLayoutView_tmpl.html
 fb4ee3c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/tabs/HierarchyTabLayoutView_tmpl.html
 4564562 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/troubleshoot/TroubleShootLayoutView_tmpl.html
 b3eeaf5 

Diff: https://reviews.apache.org/r/47300/diff/


Testing
---

Tested in local Ambari environment.


Thanks,

Dharmesh Makwana

Re: Review Request 47299: Ambari should check if the PID changes after restart, to confirm the process has been restarted

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47299/#review132869
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 12, 2016, 12:18 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47299/
> ---
> 
> (Updated May 12, 2016, 12:18 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16631
> https://issues.apache.org/jira/browse/AMBARI-16631
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 31d7b2a 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 5ca6c62 
> 
> Diff: https://reviews.apache.org/r/47299/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47229: [UI Issue]Execution of empty pig script allowed from UI

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47229/
---

(Updated May 12, 2016, 9:32 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16447
https://issues.apache.org/jira/browse/AMBARI-16447


Repository: ambari


Description
---

- Added a condition for checking empty pig script.
- If the script is empty, showing an error.


Diffs (updated)
-

  contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/scriptEdit.js 
60a04ce 
  contrib/views/pig/src/main/resources/ui/pig-web/app/translations.js 5bb8cf7 

Diff: https://reviews.apache.org/r/47229/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 47294: Upgrading ambari server fails when trying to create cluster_type column

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47294/#review132847
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 12, 2016, 7:55 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47294/
> ---
> 
> (Updated May 12, 2016, 7:55 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16627
> https://issues.apache.org/jira/browse/AMBARI-16627
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changing default value to ClusterType.LOCAL_AMBARI.name()
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
> 
> Diff: https://reviews.apache.org/r/47294/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on local vm.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/#review132838
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
(line 489)


This error log is missleading if the exception is thrown after 
```cluster.addService```. It might be better to separate out the event 
publishing logic and call it only of the persist succeeded.



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 


Why 
```
if (services.containsKey(service.getName())) {
throw new AmbariException("Service already exists" + ", 
clusterName="
+ getClusterName() + ", clusterId=" + getClusterId()
+ ", serviceName=" + service.getName());
  }
```
is not needed any more? Is it a valid use case to re-add a service to an 
existing cluster?


- Sebastian Toader


On May 12, 2016, 12:48 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46944/
> ---
> 
> (Updated May 12, 2016, 12:48 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav 
> Papirkovskyy, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16230
> https://issues.apache.org/jira/browse/AMBARI-16230
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 different type of errors can occur during adding any new service to Ambari:
> 
> org.apache.ambari.server.AmbariException: Unable to create a default alert 
> group for unknown service  in cluster
> 
> org.apache.ambari.server.ServiceNotFoundException: Service not found, 
> clusterName=c1, serviceName=
> 
> The reason is that: ServiceInstalledEvent can be handled quicker than 
> ServiceImpl.persist() can finish
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  47342f3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 487489b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  108732f 
>   ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
> a3d05a9 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> 19146fd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  d1b27a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  1875ba6 
> 
> Diff: https://reviews.apache.org/r/46944/diff/
> 
> 
> Testing
> ---
> 
> Unit Testing is in progress..
> FT: deploy cluster, add service, restart ambari with deployed cluster.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 47290: [Hive view] Break in UI for Query Settings in Firefox

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47290/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16626
https://issues.apache.org/jira/browse/AMBARI-16626


Repository: ambari


Description
---

Make some CSS changes to fix the browser compatibilty.


Diffs
-

  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 8f60595 

Diff: https://reviews.apache.org/r/47290/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/#review132836
---




contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
(line 132)


Use Ember.isEmpty or Ember.isBlank for this.


- DIPAYAN BHOWMICK


On May 11, 2016, 9:18 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47224/
> ---
> 
> (Updated May 11, 2016, 9:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16443
> https://issues.apache.org/jira/browse/AMBARI-16443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Introduced a settingException variable
> - settingException variable gets the name and value for the failed setting 
> parameter.
> - we display error the error message for the failed setting while saving the 
> settings.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> b813bbf 
> 
> Diff: https://reviews.apache.org/r/47224/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>