Re: Review Request 65040: AMBARI-22409 : Store the user input at step 3 for custom HDP and HDP-UTILS repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65040/ --- (Updated Jan. 9, 2018, 10:53 a.m.) Review request for Ambari and Nate Cole. Bugs: AMBARI-22409 https://issues.apache.org/jira/browse/AMBARI-22409 Repository: ambari Description (updated) --- Includes UI changes for validating and storing the URLs entered by user at step3 for installer and add host flow. Also allows user to store URLs without validation. Includes changes for displaying all the previously as well as newly selected OS and their respective URLs on the summary page before deploying. Diffs - ambari-web/app/controllers/wizard/step3_controller.js 86f17ef ambari-web/app/routes/add_host_routes.js 0158269 ambari-web/app/routes/installer.js f1f6659 ambari-web/app/templates/wizard/step3.hbs eb2733a ambari-web/app/views/wizard/step3_view.js d788a61 ambari-web/test/controllers/wizard/step3_test.js 4fbcd2d Diff: https://reviews.apache.org/r/65040/diff/1/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Review Request 65040: AMBARI-22409 : Store the user input at step 3 for custom HDP and HDP-UTILS repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65040/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22409 https://issues.apache.org/jira/browse/AMBARI-22409 Repository: ambari Description --- Includes UI changes for validating and storing the URLs entered by user at step3 for installer and add host flow. Also allows user to store URLs without validation. Includes changes for displaying all the previously as well as newly selected oses and their respective URLs on the summary page before deploying. Diffs - ambari-web/app/controllers/wizard/step3_controller.js 86f17ef ambari-web/app/routes/add_host_routes.js 0158269 ambari-web/app/routes/installer.js f1f6659 ambari-web/app/templates/wizard/step3.hbs eb2733a ambari-web/app/views/wizard/step3_view.js d788a61 ambari-web/test/controllers/wizard/step3_test.js 4fbcd2d Diff: https://reviews.apache.org/r/65040/diff/1/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 863-880 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863> > > > > I'm no UI expert, but this entire new block seems to be doing repo > > stuff that already is on the UI. Can you explain the gist here? > > Sonia Garudi wrote: > We need each host's os type which is not available on the UI. This > function makes an API call which gets information of all the bootstrapped > hosts . > > Nate Cole wrote: > I see. We should probably have that returned as part of host > registration and read it from there instead of making another call. Is that > possible in this patch? > > Sonia Garudi wrote: > The os types of the bootstrapped hosts can be obtained in the > registration success callback(isHostsRegisteredSuccessCallback) which would > eliminate the above API call. This would involve editing the > 'wizard.step3.is_hosts_registered' API call in ajax.js to include the > 'Hosts/os_type' field. > Please let me know your suggestions. > > Nate Cole wrote: > That sounds reasonable instead of making another call. Can we make that > an error/failure case after registration that we don't have a JAVA_HOME > matching the type? > > Yussuf Shaikh wrote: > Do you want us to fail the Host Registration if java home is not found > for host os_type? > We were planning to just show a message on the host check warnings popup > that Host does not have proper Java Home set of its Os type and default java > home will be used. This assumption is because during normal(existing) flow > Amabari show warning for incorrect Java Home and does not fail registration. > > Nate Cole wrote: > No need to fail host registration. The popup informational is fine. Eliminated the API call by editing registration API to get the os_family. Also made changes to display java home host check warnings. > On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968> > > > > Should not rely on the name for the id. The API should be giving you > > the id. > > Sonia Garudi wrote: > Made the required change in next diff. > > Nate Cole wrote: > Ok, please resolve review issues as they are fixed in diffs with "Fixed" > > Sonia Garudi wrote: > I made the change to get the stackId based on repositoryVersion instead > of displayName. However, the repositoryVersion is set to '2.6.2.0' > irrespective of the actual version of HDP installed(not sure if its a bug). I > was unable to retrieve the proper installed version of HDP on the UI using > any API call. Please let me know your suggestions. > > Sonia Garudi wrote: > In the latest diff, I have reverted to the previous change(i.e. use of > displayName instead of repositoryVersion to get the version_definition_id). Do you have any suggestions for getting the proper installed version of HDP? Or should we continue using the displayName? If possible could you merge this patch, as we can include these changes in the further patches. - Sonia ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 --- On Jan. 8, 2018, 1:05 p.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > --- > > (Updated Jan. 8, 2018, 1:05 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > --- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > - > > ambari-web/app/controllers/wizard/step3_controller.js 55f4323 > ambari-web/app/messages.js 6da0368 > ambari-web/app/styles/wizard.less 4e680ca > ambari-web/app/templates/wizard/step3.hbs ff436a8 > ambari-web/app/utils/ajax/ajax.js 483be5e > ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/5/ > > > Testing > --- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968> > > > > Should not rely on the name for the id. The API should be giving you > > the id. > > Sonia Garudi wrote: > Made the required change in next diff. > > Nate Cole wrote: > Ok, please resolve review issues as they are fixed in diffs with "Fixed" > > Sonia Garudi wrote: > I made the change to get the stackId based on repositoryVersion instead > of displayName. However, the repositoryVersion is set to '2.6.2.0' > irrespective of the actual version of HDP installed(not sure if its a bug). I > was unable to retrieve the proper installed version of HDP on the UI using > any API call. Please let me know your suggestions. In the latest diff, I have reverted to the previous change(i.e. use of displayName instead of repositoryVersion to get the version_definition_id). - Sonia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 ------- On Jan. 8, 2018, 1:05 p.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > --- > > (Updated Jan. 8, 2018, 1:05 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > --- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > - > > ambari-web/app/controllers/wizard/step3_controller.js 55f4323 > ambari-web/app/messages.js 6da0368 > ambari-web/app/styles/wizard.less 4e680ca > ambari-web/app/templates/wizard/step3.hbs ff436a8 > ambari-web/app/utils/ajax/ajax.js 483be5e > ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/5/ > > > Testing > --- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/ --- (Updated Jan. 8, 2018, 1:05 p.m.) Review request for Ambari and Nate Cole. Changes --- Made changes for using os_family instead of os_type. Also made changes for JAVA_HOME host check warnings. Bugs: AMBARI-22406 https://issues.apache.org/jira/browse/AMBARI-22406 Repository: ambari Description --- Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks. Diffs (updated) - ambari-web/app/controllers/wizard/step3_controller.js 55f4323 ambari-web/app/messages.js 6da0368 ambari-web/app/styles/wizard.less 4e680ca ambari-web/app/templates/wizard/step3.hbs ff436a8 ambari-web/app/utils/ajax/ajax.js 483be5e ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7 ambari-web/app/views/wizard/step3_view.js 3249b24 ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64769/diff/5/ Changes: https://reviews.apache.org/r/64769/diff/4-5/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968> > > > > Should not rely on the name for the id. The API should be giving you > > the id. > > Sonia Garudi wrote: > Made the required change in next diff. > > Nate Cole wrote: > Ok, please resolve review issues as they are fixed in diffs with "Fixed" I made the change to get the stackId based on repositoryVersion instead of displayName. However, the repositoryVersion is set to '2.6.2.0' irrespective of the actual version of HDP installed(not sure if its a bug). I was unable to retrieve the proper installed version of HDP on the UI using any API call. Please let me know your suggestions. - Sonia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 ------- On Jan. 4, 2018, 12:07 p.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > --- > > (Updated Jan. 4, 2018, 12:07 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > --- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > - > > ambari-web/app/controllers/wizard/step3_controller.js 55f4323 > ambari-web/app/styles/wizard.less 4e680ca > ambari-web/app/templates/wizard/step3.hbs ff436a8 > ambari-web/app/utils/ajax/ajax.js 483be5e > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/4/ > > > Testing > --- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/ --- (Updated Jan. 4, 2018, 12:07 p.m.) Review request for Ambari and Nate Cole. Changes --- Removed the API call for getting the os_type for the bootstrapped hosts. Changed the registration check API to include the os_type field, which is later added to the respective hosts in 'bootHosts'. Bugs: AMBARI-22406 https://issues.apache.org/jira/browse/AMBARI-22406 Repository: ambari Description --- Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks. Diffs (updated) - ambari-web/app/controllers/wizard/step3_controller.js 55f4323 ambari-web/app/styles/wizard.less 4e680ca ambari-web/app/templates/wizard/step3.hbs ff436a8 ambari-web/app/utils/ajax/ajax.js 483be5e ambari-web/app/views/wizard/step3_view.js 3249b24 ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64769/diff/4/ Changes: https://reviews.apache.org/r/64769/diff/3-4/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 863-880 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863> > > > > I'm no UI expert, but this entire new block seems to be doing repo > > stuff that already is on the UI. Can you explain the gist here? > > Sonia Garudi wrote: > We need each host's os type which is not available on the UI. This > function makes an API call which gets information of all the bootstrapped > hosts . > > Nate Cole wrote: > I see. We should probably have that returned as part of host > registration and read it from there instead of making another call. Is that > possible in this patch? The os types of the bootstrapped hosts can be obtained in the registration success callback(isHostsRegisteredSuccessCallback) which would eliminate the above API call. This would involve editing the 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 'Hosts/os_type' field. Please let me know your suggestions. - Sonia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 ------- On Dec. 26, 2017, 12:05 p.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > --- > > (Updated Dec. 26, 2017, 12:05 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > --- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > - > > ambari-web/app/controllers/wizard/step3_controller.js 29393e3 > ambari-web/app/styles/wizard.less 7d425d9 > ambari-web/app/templates/wizard/step3.hbs e00012c > ambari-web/app/utils/ajax/ajax.js 3f85dfdc > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/3/ > > > Testing > --- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/ --- (Updated Dec. 26, 2017, 12:05 p.m.) Review request for Ambari and Nate Cole. Changes --- Updated code with suggested changes Bugs: AMBARI-22406 https://issues.apache.org/jira/browse/AMBARI-22406 Repository: ambari Description --- Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks. Diffs (updated) - ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/styles/wizard.less 7d425d9 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/app/utils/ajax/ajax.js 3f85dfdc ambari-web/app/views/wizard/step3_view.js 3249b24 ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64769/diff/3/ Changes: https://reviews.apache.org/r/64769/diff/2-3/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 863-880 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863> > > > > I'm no UI expert, but this entire new block seems to be doing repo > > stuff that already is on the UI. Can you explain the gist here? We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts . > On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968> > > > > Should not rely on the name for the id. The API should be giving you > > the id. Made the required change in next diff. > On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 1192 (patched) > > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line1192> > > > > ftp? I think it's fine to be only http or https. Made the required change in next diff. - Sonia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/#review194434 --- On Dec. 22, 2017, 4:41 a.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64769/ > --- > > (Updated Dec. 22, 2017, 4:41 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22406 > https://issues.apache.org/jira/browse/AMBARI-22406 > > > Repository: ambari > > > Description > --- > > Includes UI changes in ambari-web to check if the repo is selected or > provides prompt to the user to enter the HDP and HDP-utils repo URL's. > Includes necessary validation checks for the repo urls, allows user to select > the public and local repository and also provides functionality to skip > validation checks. > > > Diffs > - > > ambari-web/app/controllers/wizard/step3_controller.js 29393e3 > ambari-web/app/styles/wizard.less 7d425d9 > ambari-web/app/templates/wizard/step3.hbs e00012c > ambari-web/app/utils/ajax/ajax.js 3f85dfdc > ambari-web/app/views/wizard/step3_view.js 3249b24 > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/64769/diff/2/ > > > Testing > --- > > Tests were successful in ambari-web > > > Thanks, > > Sonia Garudi > >
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/ --- (Updated Dec. 22, 2017, 4:41 a.m.) Review request for Ambari and Nate Cole. Changes --- Changed summary Summary (updated) - AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs Bugs: AMBARI-22406 https://issues.apache.org/jira/browse/AMBARI-22406 Repository: ambari Description --- Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks. Diffs - ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/styles/wizard.less 7d425d9 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/app/utils/ajax/ajax.js 3f85dfdc ambari-web/app/views/wizard/step3_view.js 3249b24 ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64769/diff/2/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Re: Review Request 64769: UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/ --- (Updated Dec. 21, 2017, 12:31 p.m.) Review request for Ambari and Nate Cole. Changes --- Updated diff Bugs: AMBARI-22406 https://issues.apache.org/jira/browse/AMBARI-22406 Repository: ambari Description --- Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks. Diffs (updated) - ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/styles/wizard.less 7d425d9 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/app/utils/ajax/ajax.js 3f85dfdc ambari-web/app/views/wizard/step3_view.js 3249b24 ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64769/diff/2/ Changes: https://reviews.apache.org/r/64769/diff/1-2/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Review Request 64769: UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64769/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22406 https://issues.apache.org/jira/browse/AMBARI-22406 Repository: ambari Description --- Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks. Diffs - ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/styles/wizard.less 7d425d9 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/app/utils/ajax/ajax.js 3f85dfdc ambari-web/app/views/wizard/step3_view.js 3249b24 ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64769/diff/1/ Testing --- Tests were successful in ambari-web Thanks, Sonia Garudi
Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types
> On Dec. 4, 2017, 4:20 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> > Lines 130-132 (patched)
> > <https://reviews.apache.org/r/64242/diff/1/?file=1905504#file1905504line130>
> >
> > How many URLs are we talking about here. If more than one, should this
> > bet a Set?
>
> Sonia Garudi wrote:
> ambariRepoUrls is a json string having ambari repo URLs for each os type
> which is sent from the UI.
>
> Nate Cole wrote:
> Can I see an example?
>
> Sonia Garudi wrote:
> Example :
>
> "[{"os_type":"os1","ambari_repo":"http://ambari-repo1","hosts":["host1","host2"],"ambariRepoUIError":"","hasError":false},{"os_type":"os2","ambari_repo":"http://ambari-repo2","hosts":["host3"],"ambariRepoUIError":"","hasError":false}];
> The above json string consists of list of 2 objects; each containing the
> os_type, ambari repository URL and the list of host names for the
> corresponding os_type. The 2 other fields(i.e. ambariRepoUIError and
> hasError) are used for UI validation.
>
> Nate Cole wrote:
> This seems strange in that we end up with two different ways to "get" the
> URL. One is that when the UI does not recognize an OS, we ask for it and
> (presumably) save it in ambari.properties. Seems as though when we should
> always get the value from ambari.properties and fail if it's not there.
> Also, why are we setting all this information If we have a command for
> host1, host2, why would we need to know that os-type-2 goes on host3?
The bootstrap.py file first checks if the os type of a host is not same as
server os type. If its different it checks for the ambari repo property for
that os type in the ambari.properties file.
case 1 : If the property is not found, the bootstrap for that host fails with
code 44. The UI prompts for the ambari repo URL for os_type of hosts which fail
with code 44. These hosts are bootstrapped with the ambariRepoUrls json string
which contains the ambari repo urls. These URLs are then saved in the
ambari.properties file for the respective os type.
case 2 : If the property is found in the properties file, the installation will
continue without showing a prompt for that os_type.
The hosts field in each object is used for removal of prompt when a host is
removed.
Implementation of storing of ambari repo url in properties file in done in
upcoming patches.
- Sonia
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64242/#review192705
---
On Dec. 1, 2017, 7:47 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64242/
> ---
>
> (Updated Dec. 1, 2017, 7:47 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22476
> https://issues.apache.org/jira/browse/AMBARI-22476
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The hosts failing with error code 44 are bootstrapped along with the ambari
> repository URLs. The required java beans are changed to include the ambari
> repository URLs to be passed to bootstrap.py.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java
> c7976ee5bb48209478258625532e3420973b4b8c
>
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> 86888f499f15aa23807067ee1af745525b9d4619
> ambari-server/src/main/python/bootstrap.py
> f1c53ce45316843fd38624536eed656b029a230a
>
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java
> b9da013524fee556c6faa2f0236d2c0c4b032750
> ambari-server/src/test/python/TestBootstrap.py
> bea47f498cbb523fbe24622c63b48918d433c717
> ambari-web/app/controllers/wizard/step3_controller.js
> 5ff2cdc1b4bb9da20565fe387765b4fc6728e096
> ambari-web/test/controllers/wizard/step3_test.js
> be1affe28fdcdb3404ebd3fb3fc6e61315483ed2
>
>
> Diff: https://reviews.apache.org/r/64242/diff/1/
>
>
> Testing
> ---
>
> Tests were successful in ambari-web and ambari-server.
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types
> On Dec. 4, 2017, 4:20 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> > Lines 130-132 (patched)
> > <https://reviews.apache.org/r/64242/diff/1/?file=1905504#file1905504line130>
> >
> > How many URLs are we talking about here. If more than one, should this
> > bet a Set?
>
> Sonia Garudi wrote:
> ambariRepoUrls is a json string having ambari repo URLs for each os type
> which is sent from the UI.
>
> Nate Cole wrote:
> Can I see an example?
Example :
"[{"os_type":"os1","ambari_repo":"http://ambari-repo1","hosts":["host1","host2"],"ambariRepoUIError":"","hasError":false},{"os_type":"os2","ambari_repo":"http://ambari-repo2","hosts":["host3"],"ambariRepoUIError":"","hasError":false}];
The above json string consists of list of 2 objects; each containing the
os_type, ambari repository URL and the list of host names for the corresponding
os_type. The 2 other fields(i.e. ambariRepoUIError and hasError) are used for
UI validation.
- Sonia
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64242/#review192705
---
On Dec. 1, 2017, 7:47 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64242/
> ---
>
> (Updated Dec. 1, 2017, 7:47 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22476
> https://issues.apache.org/jira/browse/AMBARI-22476
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The hosts failing with error code 44 are bootstrapped along with the ambari
> repository URLs. The required java beans are changed to include the ambari
> repository URLs to be passed to bootstrap.py.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java
> c7976ee5bb48209478258625532e3420973b4b8c
>
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> 86888f499f15aa23807067ee1af745525b9d4619
> ambari-server/src/main/python/bootstrap.py
> f1c53ce45316843fd38624536eed656b029a230a
>
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java
> b9da013524fee556c6faa2f0236d2c0c4b032750
> ambari-server/src/test/python/TestBootstrap.py
> bea47f498cbb523fbe24622c63b48918d433c717
> ambari-web/app/controllers/wizard/step3_controller.js
> 5ff2cdc1b4bb9da20565fe387765b4fc6728e096
> ambari-web/test/controllers/wizard/step3_test.js
> be1affe28fdcdb3404ebd3fb3fc6e61315483ed2
>
>
> Diff: https://reviews.apache.org/r/64242/diff/1/
>
>
> Testing
> ---
>
> Tests were successful in ambari-web and ambari-server.
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types
> On Dec. 4, 2017, 4:20 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java > > Lines 130-132 (patched) > > <https://reviews.apache.org/r/64242/diff/1/?file=1905504#file1905504line130> > > > > How many URLs are we talking about here. If more than one, should this > > bet a Set? ambariRepoUrls is a json string having ambari repo URLs for each os type which is sent from the UI. > On Dec. 4, 2017, 4:20 p.m., Nate Cole wrote: > > ambari-server/src/main/python/bootstrap.py > > Lines 906-908 (original), 908-910 (patched) > > <https://reviews.apache.org/r/64242/diff/1/?file=1905505#file1905505line908> > > > > Then what? What is SharedState doing with this information/how is it > > processed? The ambariRepoUrls in the SharedState will be used further to update the ambari repo URL in ambari.repo file on agent. Further changes will be in the next patch. - Sonia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64242/#review192705 ------- On Dec. 1, 2017, 7:47 a.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64242/ > --- > > (Updated Dec. 1, 2017, 7:47 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22476 > https://issues.apache.org/jira/browse/AMBARI-22476 > > > Repository: ambari > > > Description > --- > > The hosts failing with error code 44 are bootstrapped along with the ambari > repository URLs. The required java beans are changed to include the ambari > repository URLs to be passed to bootstrap.py. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java > c7976ee5bb48209478258625532e3420973b4b8c > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java > 86888f499f15aa23807067ee1af745525b9d4619 > ambari-server/src/main/python/bootstrap.py > f1c53ce45316843fd38624536eed656b029a230a > > ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java > b9da013524fee556c6faa2f0236d2c0c4b032750 > ambari-server/src/test/python/TestBootstrap.py > bea47f498cbb523fbe24622c63b48918d433c717 > ambari-web/app/controllers/wizard/step3_controller.js > 5ff2cdc1b4bb9da20565fe387765b4fc6728e096 > ambari-web/test/controllers/wizard/step3_test.js > be1affe28fdcdb3404ebd3fb3fc6e61315483ed2 > > > Diff: https://reviews.apache.org/r/64242/diff/1/ > > > Testing > --- > > Tests were successful in ambari-web and ambari-server. > > > Thanks, > > Sonia Garudi > >
Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64242/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22476 https://issues.apache.org/jira/browse/AMBARI-22476 Repository: ambari Description --- The hosts failing with error code 44 are bootstrapped along with the ambari repository URLs. The required java beans are changed to include the ambari repository URLs to be passed to bootstrap.py. Diffs - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java c7976ee5bb48209478258625532e3420973b4b8c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 86888f499f15aa23807067ee1af745525b9d4619 ambari-server/src/main/python/bootstrap.py f1c53ce45316843fd38624536eed656b029a230a ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java b9da013524fee556c6faa2f0236d2c0c4b032750 ambari-server/src/test/python/TestBootstrap.py bea47f498cbb523fbe24622c63b48918d433c717 ambari-web/app/controllers/wizard/step3_controller.js 5ff2cdc1b4bb9da20565fe387765b4fc6728e096 ambari-web/test/controllers/wizard/step3_test.js be1affe28fdcdb3404ebd3fb3fc6e61315483ed2 Diff: https://reviews.apache.org/r/64242/diff/1/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/ --- (Updated Nov. 20, 2017, 2:25 p.m.) Review request for Ambari and Nate Cole. Changes --- Fix for 1 test case failure in doBootstrapSuccessCallback Bugs: AMBARI-22393 https://issues.apache.org/jira/browse/AMBARI-22393 Repository: ambari Description --- The bootstrap process fails with code 44 incase the ambari repository URL is not set for a particular os type in the ambari.properties file. Checks for the returned status code from bootstrap.py and accordingly displays a prompt on UI for ambari reposiory URL for the failing os types. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java 3d1b31c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java b72ca20 ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/messages.js 390f803 ambari-web/app/styles/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/63945/diff/2/ Changes: https://reviews.apache.org/r/63945/diff/1-2/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/ --- (Updated Nov. 20, 2017, 9:48 a.m.) Review request for Ambari and Nate Cole. Bugs: AMBARI-22393 https://issues.apache.org/jira/browse/AMBARI-22393 Repository: ambari Description --- The bootstrap process fails with code 44 incase the ambari repository URL is not set for a particular os type in the ambari.properties file. Checks for the returned status code from bootstrap.py and accordingly displays a prompt on UI for ambari reposiory URL for the failing os types. Diffs - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java 3d1b31c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java b72ca20 ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/messages.js 390f803 ambari-web/app/styles/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/63945/diff/1/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22393 https://issues.apache.org/jira/browse/AMBARI-22393 Repository: ambari Description --- The bootstrap process fails with code 44 incase the ambari repository URL is not set for a particular os type in the ambari.properties file. Checks for the returned status code from bootstrap.py and accordingly displays a prompt on UI for ambari reposiory URL for the failing os types. Diffs - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java 3d1b31c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java b72ca20 ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/messages.js 390f803 ambari-web/app/styles/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/63945/diff/1/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
