date:20180802

Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11051 )

Change subject: [DOCS] Added the part 1 of IMPALA-5607 to the upgrade guide
..

[DOCS] Added the part 1 of IMPALA-5607 to the upgrade guide

Change-Id: Ib0e53959bef4c629a31868e16b03b6abc11c9f8d
Reviewed-on: http://gerrit.cloudera.org:8080/11051
Tested-by: Impala Public Jenkins 
Reviewed-by: Tim Armstrong 
---
M docs/topics/impala_upgrading.xml
1 file changed, 245 insertions(+), 99 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/11051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0e53959bef4c629a31868e16b03b6abc11c9f8d
Gerrit-Change-Number: 11051
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jinchul Kim 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Bharath Vissapragada (Code Review)

Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/11109 )

Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset
..

Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java
File fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java:

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@40
PS1, Line 40: TreeMultiset
> Yea, I was trying to determine that as well as I was working on this. I was
sgtm.

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java
File
fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java:

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java@77
PS1, Line 77: doRemove(20);
> oops, missed this comment. What would the aim be of the test? Do you think
Yep, since addAll and removeAll are not synchronized, addAll(1,2,3) and
removeAll(1,2,3) in parallel can create various possible final states of this
data structure. But I'm not totally sure how we check for consistency in that
case since the output can be different each time. So it is probably enough to
just test add/remove methods.

--
To view, visit http://gerrit.cloudera.org:8080/11109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef
Gerrit-Change-Number: 11109
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Fri, 03 Aug 2018 02:22:04 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2908/


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 03 Aug 2018 02:15:08 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11103 )

Change subject: IMPALA-7096: restore scanner thread memory heuristics
..


Patch Set 4:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/172/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/11103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9907fa8c4d2b0b85f67f4f160899c1c258ad82b
Gerrit-Change-Number: 11103
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 03 Aug 2018 02:10:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2911/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 9
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:56:59 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 9: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 9
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:56:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 8:

Looks like IMPALA-7328, triggering another build.


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 8
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:56:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/171/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:53:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:53:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-02 Thread Bikramjeet Vig (Code Review)

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11052 )

Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric
..


Patch Set 4:

(12 comments)

looks good, mostly just nits

http://gerrit.cloudera.org:8080/#/c/11052/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11052/4//COMMIT_MSG@9
PS4, Line 9: This patch updates the last heartbeat timestamp of a subscriber
   : everytime the subscriber heartbeats successfully. It also launches
   : a monitoring thread which periodically checks the last heartbeat
   : timestamp for all the subscribers has been updated and logs the
   : slow subscribers.
After this patch, the statestore keeps track of the last successful heartbeat 
timestamp which is exposed as a subscriber metric on the statestore debug page. 
Also adds a monitoring thread that periodically checks the last heartbeat 
timestamp for all the subscribers and logs the IDs of those that have not been 
updated since the last periodic check.


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h
File be/src/statestore/statestore.h:

http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@418
PS4, Line 418: seconds
milliseconds or ms


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@442
PS4, Line 442: /// The timestamp of the last heartbeat in milliseconds. 
This timestamp is updated
 : /// everytime the subscirber heartbeats successfully.
The timestamp of the last successful heartbeat in milliseconds.


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@444
PS4, Line 444: update frequency
heartbeat frequency


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@532
PS4, Line 532: Thread that monitors the subscriber's heartbeats.
Thread that monitors the heartbeats of all subscribers.


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@684
PS4, Line 684: the subscriber's heartbeats every
the heartbeats of all subscribers every


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@686
PS4, Line 686: the
that


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.h@686
PS4, Line 686: subscriber's
 :   /// information to the logs.
subscriber's Id.


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.cc@424
PS4, Line 424:  Status status = Thread::Create("statestore-heartbeat", 
"heartbeat-monitoring-thread",
 :   &Statestore::MonitorSubscriberHeartbeat, this, 
&heartbeat_monitoring_thread_);
 :   if (!status.ok()) LOG(WARNING) << "Unable to start heartbeat 
monitoring thread.";
move this to Init() and return status


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.cc@1003
PS4, Line 1003: %s
$0


http://gerrit.cloudera.org:8080/#/c/11052/4/be/src/statestore/statestore.cc@1004
PS4, Line 1004: ,
nit: add a space after comma


http://gerrit.cloudera.org:8080/#/c/11052/4/www/statestore_subscribers.tmpl
File www/statestore_subscribers.tmpl:

http://gerrit.cloudera.org:8080/#/c/11052/4/www/statestore_subscribers.tmpl@31
PS4, Line 31:   Last heartbeat timestamp
nit: add " (ms)"



--
To view, visit http://gerrit.cloudera.org:8080/11052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I754adccc4569e8219d5d01500cccdfc8782953f7
Gerrit-Change-Number: 11052
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:38:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11103


Change subject: IMPALA-7096: restore scanner thread memory heuristics
..

IMPALA-7096: restore scanner thread memory heuristics

This restores some of the heuristics removed in IMPALA-4835 that can
help scans from hitting OOM conditions. The heuristics are implemented
at the query level rather than in each scan node in isolation.

Introduce a ScannerMemLimiter class that belongs to the QueryState that
tracks the amount of memory estimated to be consumed for all scanner
threads running for the query on the current backend.

Also check soft memory limits to see if scanner threads should be
started or the current scanner thread should stop.

The long-term plan is to switch to the MT scan node implementations.
When that happens this code can be removed. In the meantime this
code is imperfect but will help avoid OOM in many scenarios.

Testing:
Added regression tests for HDFS and Kudu where we previously could
run out of memory with a low mem_limit.

Change-Id: Ib9907fa8c4d2b0b85f67f4f160899c1c258ad82b
---
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/exec/kudu-scan-node-base.h
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-scan-node.h
M be/src/exec/scan-node.cc
M be/src/exec/scan-node.h
M be/src/runtime/CMakeLists.txt
M be/src/runtime/query-state.cc
M be/src/runtime/query-state.h
A be/src/runtime/scanner-mem-limiter.cc
A be/src/runtime/scanner-mem-limiter.h
A 
testdata/workloads/functional-query/queries/QueryTest/hdfs-scanner-thread-mem-scaling.test
A testdata/workloads/functional-query/queries/QueryTest/kudu-scan-mem-usage.test
M tests/query_test/test_mem_usage_scaling.py
15 files changed, 444 insertions(+), 49 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/11103/4
--
To view, visit http://gerrit.cloudera.org:8080/11103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9907fa8c4d2b0b85f67f4f160899c1c258ad82b
Gerrit-Change-Number: 11103
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig

[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0

2018-08-02 Thread Quanlong Huang (Code Review)

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11092 )

Change subject: IMPALA-7364: Add RapidJson 1.1.0
..


Patch Set 3:

Sure. Thank you!


--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:35:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2905/


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 8
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:31:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11079 )

Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/170/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:28:00 +
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11092 )

Change subject: IMPALA-7364: Add RapidJson 1.1.0
..


Patch Set 3:

I'm generating the artifacts now using an internal job. If it succeeds in a few 
hours the ID will be 185-ec90313c05


--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:22:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7362: Add query option to set timezone

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11064 )

Change subject: IMPALA-7362: Add query option to set timezone
..


Patch Set 7: Code-Review+1

(1 comment)

lgtm once Attila is happy

http://gerrit.cloudera.org:8080/#/c/11064/7/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

http://gerrit.cloudera.org:8080/#/c/11064/7/common/thrift/ImpalaService.thrift@332
PS7, Line 332: overrided
nit: overridden



--
To view, visit http://gerrit.cloudera.org:8080/11064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73de86eff096e1c581d3b56a0d9330d686f77272
Gerrit-Change-Number: 11064
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:19:53 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:17:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2910/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:17:55 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 4: Code-Review+2

Updated README.md and carry Joe's +2.


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:17:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Fredy Wijaya has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..

IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER

Switching to a new CDH_BUILD_NUMBER requires downloading new CDH
components as well as forcing Maven to update its local repository.
This patch updates the CDH_COMPONENTS_HOME to include the
CDH_BUILD_NUMBER which will automatically download the new CDH
components after switching to a new CDH_BUILD_NUMBER. When running
a build if it detects that a new CDH_BUILD_NUMBER has changed, the
build will force an update to the local Maven repository. This helps
to prevent build failure even on a fresh Git clone due to stale local
Maven repository.

Testing:
- Manually tested by running buildall.sh with different CDH_BUILD_NUMBER

Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
---
M .gitignore
M README.md
M bin/impala-config.sh
M buildall.sh
4 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/11099/4
--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] [DOCS] Added the part 1 of IMPALA-5607 to the upgrade guide

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11051 )

Change subject: [DOCS] Added the part 1 of IMPALA-5607 to the upgrade guide
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e53959bef4c629a31868e16b03b6abc11c9f8d
Gerrit-Change-Number: 11051
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jinchul Kim 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:16:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7377: Update Sentry for the object ownership feature

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11094 )

Change subject: IMPALA-7377: Update Sentry for the object ownership feature
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2909/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/11094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:06:23 +
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0

2018-08-02 Thread Quanlong Huang (Code Review)

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11092 )

Change subject: IMPALA-7364: Add RapidJson 1.1.0
..


Patch Set 3:

Thank you, Tim! How can I find the latest build id for native-toolchain?


--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:54:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries

2018-08-02 Thread Bikramjeet Vig (Code Review)

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11005 )

Change subject: [WIP] IMPALA-6153: Execute UpdateFilter() only for executing 
queries
..


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.h@301
PS6, Line 301:   /// Synchronizes updates to the filter_routing_table_.
 :   /// Any thread which attempts to update the 
filter_routing_table_ must acquire
 :   /// this lock after acquiring the filter_lock_ in shared mode. 
However, if a thread
 :   /// has exclusive access to filter_lock_, it need not acquire 
the
 :   /// filter_update_lock_.
 :   SpinLock filter_update_lock_;
 :
 :   /// Protects filter_routing_table_.
 :   /// Any thread which attempts to access the 
filter_routing_table must acquire the lock
 :   /// in shared mode. Additionally, any thread which alters the 
filter_routing_table_
 :   /// must acquire the lock in exclusive mode.
maybe write a consolidated comment to better explain the need for two locks. 
This would also help to avoid writing explanations in the .cc file every time 
we acquire these locks:

Protects filter_routing_table_.
Usage Pattern:
1. To update filter_routing_table_: Acquire shared access on filter_lock_ and 
upgrade to exclusive access by subsequently acquiring filter_update_lock_.
2. To read, initialize/destroy filter_routing_table_: Directly acquire 
exclusive access on filter_lock_


http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.h@334
PS6, Line 334:   /// This function must only be invoked by threads which have 
acquired
 :   /// exclusive access to the filter_lock_. If the caller has 
not acquired
 :   /// the filter_lock_. the results produced would be undefined.
nit: "Caller must have exclusive access to filter_lock_"


http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.cc@265
PS6, Line 265:   // Since this function alters the filter_routing_table_ by 
allocating memory for the
 :   // filter objects, acquire the filter_lock_ in exclusive mode 
to ensure that no other
 :   // thread accesses the memory before it is initialized.
fyi: this method is called in exec before any fragments are started. Also, no 
other coord methods are called before exec returns.



--
To view, visit http://gerrit.cloudera.org:8080/11005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669db217f86db5ff2802335e7b1ae8027ea7161c
Gerrit-Change-Number: 11005
Gerrit-PatchSet: 6
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:55:17 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11079 )

Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
..


Patch Set 3:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/169/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:50:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

Tianyi Wang has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/11079 )

Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
..

IMPALA-7258: Support querying HBase tables in LocalCatalog

This is a straightforward port expecting no behavior change. All of
the HBase E2E tests pass with this patch.

Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
20 files changed, 923 insertions(+), 750 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/11079/4
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac

[Impala-ASF-CR] IMPALA-7377: Update Sentry for the object ownership feature

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11094 )

Change subject: IMPALA-7377: Update Sentry for the object ownership feature
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2907/


--
To view, visit http://gerrit.cloudera.org:8080/11094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:21:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11079 )

Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:

http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@220
PS3, Line 220: int startColIdx = (table_ instanceof FeHBaseTable) ? 0 : 
table_.getNumClusteringCols();
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
File fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java:

http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@109
PS3, Line 109:  * Table client objects are thread-unsafe and cheap to 
create. The HBase docs recommend
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@238
PS3, Line 238: // This should never happen - Hive blocks creating a 
mismatched table and both Hive
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@354
PS3, Line 354:  * @return The estimated number of rows in the regions 
between the row keys (first) and
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:19:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

Tianyi Wang has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/11079 )

Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
..

IMPALA-7258: Support querying HBase tables in LocalCatalog

This is a straightforward port expecting no behavior change. All of
the HBase E2E tests pass with this patch.

Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
20 files changed, 922 insertions(+), 750 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/11079/3
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 3: Code-Review+2

This looks good to me. It should be better than what we have.

Can you update README.md? It has a tiny section about CDH_COMPONENTS_HOME.


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:17:00 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7308. Support Avro tables in LocalCatalog

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10970 )

Change subject: IMPALA-7308. Support Avro tables in LocalCatalog
..


Patch Set 7: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69
Gerrit-Change-Number: 10970
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:10:54 +
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0

Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11092 )

Change subject: IMPALA-7364: Add RapidJson 1.1.0
..

IMPALA-7364: Add RapidJson 1.1.0

Also copy over license to built tarball.

Testing:
Built both rapidjson version locally with:

  ./build.sh rapidjson 0.11
  ./build.sh rapidjson 1.1.0

Will run build on a range of operating systems but I don't anticipate
any problems since this "build" is so trivial.

Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Reviewed-on: http://gerrit.cloudera.org:8080/11092
Tested-by: Tim Armstrong 
Reviewed-by: Bikramjeet Vig 
---
M buildall.sh
M source/rapidjson/build.sh
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Verified
  Bikramjeet Vig: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong

[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0

2018-08-02 Thread Bikramjeet Vig (Code Review)

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11092 )

Change subject: IMPALA-7364: Add RapidJson 1.1.0
..


Patch Set 2: Code-Review+2

> Was able to confirm this builds ok on all the distros I have access
 > to.

Good enough for me


--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:43:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Todd Lipcon (Code Review)

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11109 )

Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java
File 
fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java:

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java@77
PS1, Line 77: doRemove(20);
> Can you add a few multithreaded addAll(), RemoveAll() since the underlying
oops, missed this comment. What would the aim be of the test? Do you think they 
should add/remove overlapping sets of elements or separate ones? I thought it 
wasn't worth testing addAll/removeAll since they're just wrappers around the 
add/remove methods that are tested already.



--
To view, visit http://gerrit.cloudera.org:8080/11109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef
Gerrit-Change-Number: 11109
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:29:45 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Todd Lipcon (Code Review)

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11109 )

Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java
File fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java:

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@40
PS1, Line 40: TreeMultiset
> It is not super clear to me (looking at the usage of CatalogObjectVersionQu
Yea, I was trying to determine that as well as I was working on this. I was 
sorely tempted to add assertions that removeVersion() is only called on 
existing versions and addVersion() doesn't add a duplicate, but was a little 
bit nervous to try to make that improvement.

How about sticking with this approach as a first (conservative) patch which 
coudl be backportable to fix scalability problems on prior releases, and then 
I'll do a second one on top to try to make the class more restrictive about 
single-object-per-version?



--
To view, visit http://gerrit.cloudera.org:8080/11109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef
Gerrit-Change-Number: 11109
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:28:51 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7377: Update Sentry for the object ownership feature

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11094 )

Change subject: IMPALA-7377: Update Sentry for the object ownership feature
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/168/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:25:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog

2018-08-02 Thread Vuk Ercegovac (Code Review)

Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11079 )

Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
..


Patch Set 2:

(15 comments)

mostly minor comments, otherwise, looks fine.

http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG@9
PS2, Line 9: porting
nit: port


http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG@10
PS2, Line 10: passes
nit: pass


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@26
PS2, Line 26: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java@23
PS2, Line 23: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java@23
PS2, Line 23: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File 
fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@33
PS2, Line 33: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java@26
PS2, Line 26: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@50
PS2, Line 50: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@35
PS2, Line 35: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@50
PS2, Line 50: Input format class for HBase tables read by Hive.
move this comment before L51, then bring the "implements" up a line.


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@55
PS2, Line 55: import org.apache.tools.ant.taskdefs.Local;
remove (ide expansion?)


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@40
PS2, Line 40: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/Planner.java@38
PS2, Line 38: import org.apache.impala.catalog.HBaseTable;
remove


http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:

http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@62
PS2, Line 62: import org.apache.impala.catalog.

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/167/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:12:44 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/166/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:08:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4690: [DOCS] More content for CONV()

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11075 )

Change subject: IMPALA-4690: [DOCS] More content for CONV()
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml
File docs/topics/impala_math_functions.xml:

http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@279
PS2, Line 279: If a does not represent a valid number in
 :   from_base
> My suggestion is that in the function prototypes, you name the numeric argu
Whether a number or a string, the return values are the same. I changed it to 
"the first argument"



--
To view, visit http://gerrit.cloudera.org:8080/11075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e424fd5a009ff5aa2d35a403e08fcd33c75fec5
Gerrit-Change-Number: 11075
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:07:26 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4690: [DOCS] More content for CONV()

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11075 )

Change subject: IMPALA-4690: [DOCS] More content for CONV()
..


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml
File docs/topics/impala_math_functions.xml:

http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@228
PS2, Line 228: a 2's compliment of -17 in base 2
> This comment was not replied to.
Done


http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@228
PS2, Line 228: a 2's compliment of -17 in base 2
> This is somewhat opaque. What it seems to be doing is interpret -17 as an u
Done


http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@229
PS2, Line 229: 
> SO what happens first: conversion to two's complement or conversion to base
Applied your comment above


http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@249
PS2, Line 249: 
> FYI: Whitespace changes like this can make it hard to read diffs like this:
Will try to minimize whitespace changes.


http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@279
PS2, Line 279: If a does not represent a valid number in
 :   from_base
> My suggestion is that in the function prototypes, you name the numeric argu
Done


http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml
File docs/topics/impala_math_functions.xml:

http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml@240
PS3, Line 240: specified:
> nit: "The string representation", here and below.
Done


http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml@241
PS3, Line 241:   
> nit: comma after "negative"
Done


http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml@242
PS3, Line 242:   
> elide the "and thus" part, here and below - it's confusing.
Removed



--
To view, visit http://gerrit.cloudera.org:8080/11075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e424fd5a009ff5aa2d35a403e08fcd33c75fec5
Gerrit-Change-Number: 11075
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:02:25 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2908/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:56:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Sailesh Mukil (Code Review)

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1: Code-Review+2

Thanks for doing this!


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:54:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7377: Update Sentry for the object ownership feature

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11094 )

Change subject: IMPALA-7377: Update Sentry for the object ownership feature
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2907/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/11094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:51:46 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7377: Update Sentry for the object ownership feature

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11094 )

Change subject: IMPALA-7377: Update Sentry for the object ownership feature
..


Patch Set 4:

Re-running dry-run that failed because of IMPALA-7347.


--
To view, visit http://gerrit.cloudera.org:8080/11094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:50:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7377: Update Sentry for the object ownership feature

Fredy Wijaya has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/11094 )

Change subject: IMPALA-7377: Update Sentry for the object ownership feature
..

IMPALA-7377: Update Sentry for the object ownership feature

Update CDH_BUILD_NUMBER to 506967, especially for the new Sentry update
with the object owership feature (IMPALA-7075). This patch updates the
Sentry package names and Sentry Maven dependencies.

Testing:
- Ran core tests

Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/util/SentryPolicyService.java
M fe/src/main/java/org/apache/impala/util/SentryProxy.java
M fe/src/main/java/org/apache/impala/util/SentryUtil.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
6 files changed, 38 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/11094/4
--
To view, visit http://gerrit.cloudera.org:8080/11094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28671d03cf7785334c333055d8f02c8af5645496
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 3: Code-Review+1

Carry Tim's +1.


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:47:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 7:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/165/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:44:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh@473
PS2, Line 473: if [[ -f ${CDH_FILE} ]]; then
 :   if [[ $(cat ${CDH_FILE}) != ${CDH_BUILD_NUMBER} ]]; then
 : export IMPALA_MAVEN_OPTIONS="${IMPALA_MAVEN_OPTIONS} -U"
 :   fi
 : fi
 : echo "${CDH_BUILD_NUMBER}" > ${CDH_FILE}
 :
 : if [[ "$BUILD_FE_ONLY" -eq 1 ]]; then
 :   build_fe
 :   exit 0
 : fi
> I'm thinking about this a bit. It's a bit of a weird case.
Agreed, it's a bit of a weird case. Not a big fan of this approach either but I 
can't think of a better way of detect CDH_BUILD_IMPALA changes.



--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:37:39 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Fredy Wijaya has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..

IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER

Switching to a new CDH_BUILD_NUMBER requires downloading new CDH
components as well as forcing Maven to update its local repository.
This patch updates the CDH_COMPONENTS_HOME to include the
CDH_BUILD_NUMBER which will automatically download the new CDH
components after switching to a new CDH_BUILD_NUMBER. When running
a build if it detects that a new CDH_BUILD_NUMBER has changed, the
build will force an update to the local Maven repository. This helps
to prevent build failure even on a fresh Git clone due to stale local
Maven repository.

Testing:
- Manually tested by running buildall.sh with different CDH_BUILD_NUMBER

Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
---
M .gitignore
M bin/impala-config.sh
M buildall.sh
3 files changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/11099/3
--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1:

I'm running https://jenkins.impala.io/job/gerrit-verify-dryrun-external/234/ to 
test this doesn't affect the "regular" tests


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:36:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/3 )

Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2906/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:35:24 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/3


Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.
..

IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

This configures the --hostname flag to 'localhost'. This allows
the test to pass in the test-with-docker environment, where
it was failing due to DNS resolution reasons. Interestingly,
I could manipulate /etc/hosts to get this test to pass, but
then thrift-server-test would fail in the same manner, so this
seemed like the easiest approach.

Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
---
M be/src/rpc/rpc-mgr-kerberized-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/3/1
--
To view, visit http://gerrit.cloudera.org:8080/3
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91003cbc86177feb7f99563f61297f7da7fabab4
Gerrit-Change-Number: 3
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 6:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/164/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 6
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:25:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3330: [DOCS] TRANSLATE function updated

Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11074 )

Change subject: IMPALA-3330: [DOCS] TRANSLATE function updated
..

IMPALA-3330: [DOCS] TRANSLATE function updated

- Better description
- Examples

Change-Id: Ica33ecbb7118e3034f95c5705eed19d169dc16cb
Reviewed-on: http://gerrit.cloudera.org:8080/11074
Tested-by: Impala Public Jenkins 
Reviewed-by: Jim Apple 
---
M docs/topics/impala_string_functions.xml
1 file changed, 31 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/11074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica33ecbb7118e3034f95c5705eed19d169dc16cb
Gerrit-Change-Number: 11074
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jim Apple

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/163/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 5
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:16:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2905/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 8
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:15:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 8: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 8
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:15:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 7: Code-Review+2

(2 comments)

Carrying +2

http://gerrit.cloudera.org:8080/#/c/0/4/be/src/util/webserver.cc
File be/src/util/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/0/4/be/src/util/webserver.cc@438
PS4, Line 438:   bool raw_json = (arguments.find("json") != arguments.end());
> Could you update webserver.h's comment for this function with what ?json an
Elaborated it a bit more.


http://gerrit.cloudera.org:8080/#/c/0/4/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/0/4/tests/webserver/test_web_pages.py@97
PS4, Line 97: assert content_type == 
requests.get(url).headers['Content-Type']
> Should this be "==" rather than "in"?
Done



--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:14:32 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)

Hello Philip Zeyliger, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/0

to look at the new patch set (#7).

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..

IMPALA-7387: Set correct MIME type for JSON webpages

Right now Impala sets "text/plain" as the MIME type for all non-HTML
pages. As per RFC-4627[1], JSON's prescribed MIME type is
"application/json".

Testing:
- Inspected HTTP headers manually in the browser.
- Added tests.

[1] http://www.ietf.org/rfc/rfc4627.txt

Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
---
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
3 files changed, 37 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/7
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/0 )

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 6
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:09:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)

Hello Philip Zeyliger, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/0

to look at the new patch set (#6).

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..

IMPALA-7387: Set correct MIME type for JSON webpages

Right now Impala sets "text/plain" as the MIME type for all non-HTML
pages. As per RFC-4627[1], JSON's prescribed MIME type is
"application/json".

Testing:
- Inspected HTTP headers manually in the browser.
- Added tests.

[1] http://www.ietf.org/rfc/rfc4627.txt

Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
---
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
3 files changed, 33 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/6
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 6
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages

2018-08-02 Thread Bharath Vissapragada (Code Review)

Hello Philip Zeyliger, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/0

to look at the new patch set (#5).

Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..

IMPALA-7387: Set correct MIME type for JSON webpages

Right now Impala sets "text/plain" as the MIME type for all non-HTML
pages. As per RFC-4627[1], JSON's prescribed MIME type is
"application/json".

Testing:
- Inspected HTTP headers manually in the browser.
- Added tests.

[1] http://www.ietf.org/rfc/rfc4627.txt

Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
---
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
3 files changed, 33 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/5
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 5
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh@473
PS2, Line 473: # Create .cdh file that contains the CDH_BUILD_NUMBER. If the 
content
 : # of the file is different than the one in the environment 
variable,
 : # append -U into IMPALA_MAVEN_OPTION to force Maven to update 
its local
 : # cache.
 : CDH_FILE="${IMPALA_HOME}/.cdh"
 : if [[ -f ${CDH_FILE} ]]; then
 :   if [[ $(cat ${CDH_FILE}) != ${CDH_BUILD_NUMBER} ]]; then
 : export IMPALA_MAVEN_OPTIONS="${IMPALA_MAVEN_OPTIONS} -U"
 :   fi
 : fi
 : echo "${CDH_BUILD_NUMBER}" > ${CDH_FILE}
> Small thing: Move this above the "BUILD_FE_ONLY" block above.
I'm thinking about this a bit. It's a bit of a weird case.



--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:44:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 2:

(1 comment)

I'm basically good with this change. One small point.

http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh@473
PS2, Line 473: # Create .cdh file that contains the CDH_BUILD_NUMBER. If the 
content
 : # of the file is different than the one in the environment 
variable,
 : # append -U into IMPALA_MAVEN_OPTION to force Maven to update 
its local
 : # cache.
 : CDH_FILE="${IMPALA_HOME}/.cdh"
 : if [[ -f ${CDH_FILE} ]]; then
 :   if [[ $(cat ${CDH_FILE}) != ${CDH_BUILD_NUMBER} ]]; then
 : export IMPALA_MAVEN_OPTIONS="${IMPALA_MAVEN_OPTIONS} -U"
 :   fi
 : fi
 : echo "${CDH_BUILD_NUMBER}" > ${CDH_FILE}
Small thing: Move this above the "BUILD_FE_ONLY" block above.



--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:43:24 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11099 )

Change subject: IMPALA-7381: Prevent build failure after switching to new 
CDH_BUILD_NUMBER
..


Patch Set 2: Code-Review+1

The .cdh thing feels a little hacky but I'm not sure if I have a better 
suggestion. I also agree with not automatically deleting cdh_components - it 
could be very annoying if you switch branches on a slow internet connection and 
then can't build anything until you re-download everything.


--
To view, visit http://gerrit.cloudera.org:8080/11099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:39:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped 
IMPALA_HOME
..


Patch Set 1:

Can you do similar logic for the sentry db?
https://github.com/apache/impala/blob/master/bin/create-test-configuration.sh#L109


--
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:29:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset

2018-08-02 Thread Bharath Vissapragada (Code Review)

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11109 )

Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java
File fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java:

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@40
PS1, Line 40: TreeMultiset
> Internally the TreeMultiset actually uses a pair of  in its
It is not super clear to me (looking at the usage of CatalogObjectVersionQueue) 
whether we need to support duplicate versions. I agree that the default 
implementation of PriorityQueue allows duplicates but I'm not sure if we were 
relying on that behavior.


http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@67
PS1, Line 67: null
Should this be set to INITIAL_CATALOG_VERSION and then getMinimumVersion() just 
return minVersion_...


http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java
File 
fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java:

http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java@77
PS1, Line 77: doRemove(20);
Can you add a few multithreaded addAll(), RemoveAll() since the underlying 
add() remove() can be interleaved.



-- 
To view, visit http://gerrit.cloudera.org:8080/11109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef
Gerrit-Change-Number: 11109
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:11:01 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7385: Fix test-with-docker errors having to do with time zones.

2018-08-02 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11106 )

Change subject: IMPALA-7385: Fix test-with-docker errors having to do with time 
zones.
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/162/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9facfd9741806e7dbb868d8d06d9296bf86e52f
Gerrit-Change-Number: 11106
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:05:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7384: Move /var/lib/hadoop-hdfs into IMPALA HOME

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11105 )

Change subject: IMPALA-7384: Move /var/lib/hadoop-hdfs into IMPALA_HOME
..


Patch Set 1:

HDFS requires every parent of this socket path to be either owned by root or 
non-writable by its group. Absurd! I will put it into $(mktemp) instead.


--
To view, visit http://gerrit.cloudera.org:8080/11105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79501fbc762176674bb1c0dde4196a592aee49b2
Gerrit-Change-Number: 11105
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:04:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7385: Fix test-with-docker errors having to do with time zones.

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11106 )

Change subject: IMPALA-7385: Fix test-with-docker errors having to do with time 
zones.
..


Patch Set 2:

(2 comments)

Thanks for the review, Attila.

http://gerrit.cloudera.org:8080/#/c/11106/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11106/1//COMMIT_MSG@14
PS1, Line 14: /etc/localtim
> Shouldn't it be /etc/localtime ?
Done


http://gerrit.cloudera.org:8080/#/c/11106/1/docker/test-with-docker.py
File docker/test-with-docker.py:

http://gerrit.cloudera.org:8080/#/c/11106/1/docker/test-with-docker.py@504
PS1, Line 504: assert os.path.islink("/etc/localtime")
 : localtime_link_target = os.path.realpath("/etc/localt
> This might be a little more robust:
Did the first two lines.

I added a comment about why you need "in"



--
To view, visit http://gerrit.cloudera.org:8080/11106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9facfd9741806e7dbb868d8d06d9296bf86e52f
Gerrit-Change-Number: 11106
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 02 Aug 2018 20:31:41 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7385: Fix test-with-docker errors having to do with time zones.