[Impala-ASF-CR] IMPALA-7673: Support values from other variables in Impala shell --var
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/11623 )
Change subject: IMPALA-7673: Support values from other variables in Impala
shell --var
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11623/8/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:
http://gerrit.cloudera.org:8080/#/c/11623/8/tests/shell/test_shell_commandline.py@556
PS8, Line 556: query="select \'${var:msg3}
What will happen if impala shell is started without --query + some variables
that reference non-existing variables? I think that the current logic will not
result in an error, while it should.
--
To view, visit http://gerrit.cloudera.org:8080/11623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b9fda329c45f2e5682f3cbc76d29ceca2e226a
Gerrit-Change-Number: 11623
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Fri, 12 Oct 2018 08:36:38 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Attila Jeges has posted comments on this change. (
http://gerrit.cloudera.org:8080/11057 )
Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and
TIMESTAMP_MICROS from Parquet
..
Patch Set 12:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/exprs/timezone_db.h
File be/src/exprs/timezone_db.h:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/exprs/timezone_db.h@79
PS12, Line 79:
Add WARN_UNUSED_RESULT.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/exprs/timezone_db.h@78
PS12, Line 78: /// Public proxy for LoadZoneInfo. Should be only used in BE
tests.
: static Status LoadZoneInfoBeTestOnly(const std::string&
zone_info_dir) {
: return LoadZoneInfo(zone_info_dir);
: }
Maybe instead of this function add a "friend class TimestampTest;" after L87.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc
File be/src/runtime/timestamp-test.cc:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc@909
PS12, Line 909: CET
CET is a deprecated name and its usage is not recommended.
It would be better to use an IANA tz name, eg. Europe/Budapest.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc@928
PS12, Line 928: imestamps that fall to UTC+2->UTC+1 DST change.
More detailed information would be nice:
e.g:
- Up to 2017-10-29 02:59:59.9 AM:
- Offset is UTC+02:00
- After 2017-10-29 02:59:59.9 AM:
- Clocks were moved backward to become 2017-10-29 02:00:00 AM
- Offset is UTC+01:00.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc@950
PS12, Line 950: Timestamp that falls to UTC+1->UTC+2 DST change
More detailed information would be nice:
e.g:
- Up to 2017-03-26 01:59:59.9 AM:
- Offset is UTC+01:00
- After 2017-03-26 01:59:59.9 AM:
- Clocks were moved forward to become 2017-03-26 03:00:00 AM
- Offset is UTC+02:00.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.h
File be/src/runtime/timestamp-value.h:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.h@238
PS12, Line 238: any timestamp that is earlier in UTC
This is a little confusing. Earlier than what?
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.h@239
PS12, Line 239: and any
: /// timestamp later in UTC
Later than what?
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.cc
File be/src/runtime/timestamp-value.cc:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.cc@137
PS12, Line 137: simple
typo: simply
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/data/README
File testdata/data/README:
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/data/README@251
PS12, Line 251: CET
Again, using a real IANA name would be better.
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test
File
testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test:
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test@4
PS12, Line 4: CET
It would be better to use an IANA timezone name here and below. CET is a
deprecated name.
--
To view, visit http://gerrit.cloudera.org:8080/11057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3
Gerrit-Change-Number: 11057
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Fri, 12 Oct 2018 11:30:44 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Hello Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11057 to look at the new patch set (#13). Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet Changes: - parquet.thrift is updated to a newer version which contains the timestamp logical type. - INT64 columns with converted types TIMESTAMP_MILLIS and TIMESTAMP_MICROS can be read as TIMESTAMP. - If the logical type is timestamp, then the type will contain the information whether the UTC->local conversion is necessary. This feature is only supported for the new timestamp types, so INT96 timestamps must still use flag convert_legacy_hive_parquet_utc_timestamps. - Min/max stat filtering is enabled again for columns that need UTC->local conversion. This was disabled in IMPALA-7559 because it could incorrectly drop column chunks. Testing: - Added unit tests for timezone conversion (this needed a new public function in timezone_db.h and adding CET to tzdb_tiny). - Added parquet files (created with parquet-mr) with int64 timestamp columns. Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 --- M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/exec/parquet-column-readers.cc M be/src/exec/parquet-column-readers.h M be/src/exec/parquet-column-stats.cc M be/src/exec/parquet-column-stats.h M be/src/exec/parquet-column-stats.inline.h M be/src/exec/parquet-common.cc M be/src/exec/parquet-common.h M be/src/exec/parquet-metadata-utils.cc M be/src/exprs/timezone_db.h M be/src/runtime/timestamp-test.cc M be/src/runtime/timestamp-value.cc M be/src/runtime/timestamp-value.h M be/src/util/dict-encoding.h M common/thrift/parquet.thrift M fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java M testdata/data/README A testdata/data/int64_timestamps_at_dst_changes.parquet A testdata/data/int64_timestamps_dict.parq A testdata/data/int64_timestamps_plain.parq A testdata/tzdb_tiny/CET A testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test M tests/query_test/test_scanners.py 24 files changed, 866 insertions(+), 116 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11057/13 -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Hello Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11057 to look at the new patch set (#14). Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet Changes: - parquet.thrift is updated to a newer version which contains the timestamp logical type. - INT64 columns with converted types TIMESTAMP_MILLIS and TIMESTAMP_MICROS can be read as TIMESTAMP. - If the logical type is timestamp, then the type will contain the information whether the UTC->local conversion is necessary. This feature is only supported for the new timestamp types, so INT96 timestamps must still use flag convert_legacy_hive_parquet_utc_timestamps. - Min/max stat filtering is enabled again for columns that need UTC->local conversion. This was disabled in IMPALA-7559 because it could incorrectly drop column chunks. Testing: - Added unit tests for timezone conversion (this needed a new public function in timezone_db.h and adding CET to tzdb_tiny). - Added parquet files (created with parquet-mr) with int64 timestamp columns. Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 --- M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/exec/parquet-column-readers.cc M be/src/exec/parquet-column-readers.h M be/src/exec/parquet-column-stats.cc M be/src/exec/parquet-column-stats.h M be/src/exec/parquet-column-stats.inline.h M be/src/exec/parquet-common.cc M be/src/exec/parquet-common.h M be/src/exec/parquet-metadata-utils.cc M be/src/exprs/timezone_db.h M be/src/runtime/timestamp-test.cc M be/src/runtime/timestamp-value.cc M be/src/runtime/timestamp-value.h M be/src/util/dict-encoding.h M common/thrift/parquet.thrift M fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java M testdata/data/README A testdata/data/int64_timestamps_at_dst_changes.parquet A testdata/data/int64_timestamps_dict.parq A testdata/data/int64_timestamps_plain.parq A testdata/tzdb_tiny/CET A testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test M tests/query_test/test_scanners.py 24 files changed, 874 insertions(+), 116 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11057/14 -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1032/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Oct 2018 14:13:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/11057 )
Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and
TIMESTAMP_MICROS from Parquet
..
Patch Set 12:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/exprs/timezone_db.h
File be/src/exprs/timezone_db.h:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/exprs/timezone_db.h@79
PS12, Line 79:
> Add WARN_UNUSED_RESULT.
Done
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/exprs/timezone_db.h@78
PS12, Line 78: /// Public proxy for LoadZoneInfo. Should be only used in BE
tests.
: static Status LoadZoneInfoBeTestOnly(const std::string&
zone_info_dir) {
: return LoadZoneInfo(zone_info_dir);
: }
> Maybe instead of this function add a "friend class TimestampTest;" after L8
I prefer the current solution. I plan to add a similar function that sets the
local time zone and to call it from expr-test.cc. Adding these test classes as
friends of TimezoneDatabase seems "less natural" to me (a higher level class
would be referenced in a low level utility class). Befriending the TimzoneDb
test classes is ok for me, because they are deeply coupled to this class by
design.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc
File be/src/runtime/timestamp-test.cc:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc@909
PS12, Line 909: CET
> CET is a deprecated name and its usage is not recommended.
See README.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc@928
PS12, Line 928: imestamps that fall to UTC+2->UTC+1 DST change.
> More detailed information would be nice:
Done, thanks for the nice comment. :)
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-test.cc@950
PS12, Line 950: Timestamp that falls to UTC+1->UTC+2 DST change
> More detailed information would be nice:
Done
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.h
File be/src/runtime/timestamp-value.h:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.h@238
PS12, Line 238: any timestamp that is earlier in UTC
> This is a little confusing. Earlier than what?
I hope that it is clearer now.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.h@239
PS12, Line 239: and any
: /// timestamp later in UTC
> Later than what?
See line 238.
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.cc
File be/src/runtime/timestamp-value.cc:
http://gerrit.cloudera.org:8080/#/c/11057/12/be/src/runtime/timestamp-value.cc@137
PS12, Line 137: simple
> typo: simply
Done
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/data/README
File testdata/data/README:
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/data/README@251
PS12, Line 251: CET
> Again, using a real IANA name would be better.
My current opinion is that CET is less likely to cause trouble.
Europe/Budapest is canonical, but is interpreted differently by Hive and Impala
for historical dates:
select from_utc_timestamp("1800-07-01", "Europe/Budapest");
result in Impala: 1800-07-01 01:16:20
result in Hive: 1800-07-01 01:00:00
Both return 1800-07-01 01:00:00 for CET (and start using DST from 1977).
I do not know about the reason - maybe it is Hive only, or maybe old rule
changes are removed from the timezone files in some cases. The latter could
mean that using Europe/Budapest in tests without custom timezone can lead to
different results depending on the OS. Europe/Budapest is also more likely to
change in the future (abandoning DST change).
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test
File
testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test:
http://gerrit.cloudera.org:8080/#/c/11057/12/testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test@4
PS12, Line 4: CET
> It would be better to use an IANA timezone name here and below. CET is a de
See README.
--
To view, visit http://gerrit.cloudera.org:8080/11057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3
Gerrit-Change-Number: 11057
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Fri, 12 Oct 2018 14:17:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Hello Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11057 to look at the new patch set (#15). Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet Changes: - parquet.thrift is updated to a newer version which contains the timestamp logical type. - INT64 columns with converted types TIMESTAMP_MILLIS and TIMESTAMP_MICROS can be read as TIMESTAMP. - If the logical type is timestamp, then the type will contain the information whether the UTC->local conversion is necessary. This feature is only supported for the new timestamp types, so INT96 timestamps must still use flag convert_legacy_hive_parquet_utc_timestamps. - Min/max stat filtering is enabled again for columns that need UTC->local conversion. This was disabled in IMPALA-7559 because it could incorrectly drop column chunks. Testing: - Added unit tests for timezone conversion (this needed a new public function in timezone_db.h and adding CET to tzdb_tiny). - Added parquet files (created with parquet-mr) with int64 timestamp columns. Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 --- M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/exec/parquet-column-readers.cc M be/src/exec/parquet-column-readers.h M be/src/exec/parquet-column-stats.cc M be/src/exec/parquet-column-stats.h M be/src/exec/parquet-column-stats.inline.h M be/src/exec/parquet-common.cc M be/src/exec/parquet-common.h M be/src/exec/parquet-metadata-utils.cc M be/src/exprs/timezone_db.h M be/src/runtime/timestamp-test.cc M be/src/runtime/timestamp-value.cc M be/src/runtime/timestamp-value.h M be/src/util/dict-encoding.h M common/thrift/parquet.thrift M fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java M testdata/data/README A testdata/data/int64_timestamps_at_dst_changes.parquet A testdata/data/int64_timestamps_dict.parq A testdata/data/int64_timestamps_plain.parq A testdata/tzdb_tiny/CET A testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test M tests/query_test/test_scanners.py 24 files changed, 873 insertions(+), 115 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11057/15 -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 15 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/11057/14/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/11057/14/testdata/data/README@1 PS14, Line 1: b I have add a character at the beginning by mistake. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 15 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Oct 2018 14:19:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1033/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Oct 2018 14:19:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 15: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3305/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 15 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Oct 2018 14:35:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1034/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 15 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Oct 2018 14:43:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): can you hint this file so that the diff is shown? http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@107 PS1, Line 107: # I nit: I've mostly seen the other, multi-line commenting for this case (e.g., """ ... """) -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 15:25:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/11663/2 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > can you hint this file so that the diff is shown? A file name change from TestShowGrantUser to TestShowGrant since I think it's better for this test to cover both SHOW GRANT ROLE and SHOW GRANT USER. http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@107 PS1, Line 107: """ > nit: I've mostly seen the other, multi-line commenting for this case (e.g., Done -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 15:43:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > A file name change from TestShowGrantUser to TestShowGrant since I think it that's fine, but since its mostly a file rename fwict, with a test added, it would be useful to hint to git that its a rename (not sure when this happens on its own vs. when it needs to be explicitly hinted) -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 15:51:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7673: Support values from other variables in Impala shell --var
Fredy Wijaya has posted comments on this change. (
http://gerrit.cloudera.org:8080/11623 )
Change subject: IMPALA-7673: Support values from other variables in Impala
shell --var
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11623/8/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:
http://gerrit.cloudera.org:8080/#/c/11623/8/tests/shell/test_shell_commandline.py@556
PS8, Line 556: query="select \'${var:msg3}
> What will happen if impala shell is started without --query + some variable
It actually will.
Before the patch:
-- without --query
$ impala-shell.sh --var="foo=1"
[localhost:21000] default> select ${var:bar};
Error: Unknown variable BAR
-- with --query
$ impala-shell.sh --var="foo=1" --query="select \${var:bar}"
Error: Unknown variable BAR
Could not execute command: select ${var:bar}
-- referencing a variable that does not exist
-- this is wrong and the behavior is inconsistent with using SET
$ impala-shell.sh --var="foo=1" --var='bar=${var:baz}' --query='select
"${var:bar}"'
Query: select "${var:baz}"
+--+
| '${var:baz}' |
+--+
| ${var:baz} |
+--+
Fetched 1 row(s) in 0.11s
After the patch:
-- without --query
impala-shell.sh --var="foo=1"
[localhost:21000] default> select ${var:bar};
Error: Unknown variable BAR
-- with --query
$ impala-shell.sh --var="foo=1" --query="select \${var:bar}"
Error: Unknown variable BAR
Could not execute command: select ${var:bar}
-- referencing a variable that does not exist
-- this is correct and the behavior is consistent with SET
$ impala-shell.sh --var="foo=1" --var='bar=${var:baz}' --query='select
"${var:bar}"'
Starting Impala Shell without Kerberos authentication
Error: Unknown variable BAZ
--
To view, visit http://gerrit.cloudera.org:8080/11623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b9fda329c45f2e5682f3cbc76d29ceca2e226a
Gerrit-Change-Number: 11623
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Fri, 12 Oct 2018 16:04:52 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. The patch also renames test_show_grant_user.py to test_show_grant.py for all tests related to SHOW GRANT statements. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/11663/3 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > that's fine, but since its mostly a file rename fwict, with a test added, i Gotcha. I updated the git commit message. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:11:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1035/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:16:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:22:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3306/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:24:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:24:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1036/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:38:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6323 Allow constant "partition by" expressions.
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant "partition by" expressions. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11556/2/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/11556/2/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@85 PS2, Line 85:* Return true if and only if partitionExprs is non-empty and contains non-constant > line has trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 3 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:56:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6323 Allow constant "partition by" expressions.
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant "partition by" expressions. .. Patch Set 3: (1 comment) > Patch Set 3: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/11556/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/11556/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@436 PS3, Line 436: "Expressions in the ORDER BY clause must not be constant: " > I think the JIRA was originally intended to cover removing this case too. I Done -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 3 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:56:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/11630 )
Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11630/4/tests/util/abfs_util.py
File tests/util/abfs_util.py:
http://gerrit.cloudera.org:8080/#/c/11630/4/tests/util/abfs_util.py@36
PS4, Line 36: output = subprocess.output("hadoop fs -%s" % command)
> metadata/test_ddl.py:43: in test_drop_table_with_purge
Also, there are two ways for this to work:
1. You generate a string that is a shell command, and you pass shell=True to
check_output(). Without shell, you'll get a file not found error.
2. You generate a list with the command and arguments (i.e. ["hadoop", "fs",
... args ... ] and use shell=False (the default).
I prefer #2.
Nit: I think it is more intuitive for the callers to include the "-" in the
first arg. i.e. "-ls" rather than "ls" with the "-" appended here.
http://gerrit.cloudera.org:8080/#/c/11630/4/tests/util/abfs_util.py@52
PS4, Line 52: path
The path passed in by our test framework does not have a leading '/'. i.e.
"test-warehouse/alltypes" rather than
"/test-warehouse/alltypes"
HDFS command line needs the leading "/", so all these paths need to be fixed up
before being passed to the HDFS command line.
http://gerrit.cloudera.org:8080/#/c/11630/4/tests/util/abfs_util.py@65
PS4, Line 65: entries = output.split("\n")[1:] # Trim the "Found X items" line
The hadoop shell output has a trailing newline, so the last entry will be an
empty string. We need to handle that here. Maybe [1:-1]
--
To view, visit http://gerrit.cloudera.org:8080/11630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5120b071760e7655e78902dce8483f8f54de445d
Gerrit-Change-Number: 11630
Gerrit-PatchSet: 4
Gerrit-Owner: mackror...@apache.org
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Reviewer: mackror...@apache.org
Gerrit-Comment-Date: Fri, 12 Oct 2018 17:05:22 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.
Hello Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11556 to look at the new patch set (#4). Change subject: IMPALA-6323 Allow constant analytic window expressions. .. IMPALA-6323 Allow constant analytic window expressions. The constraint imposed by IMPALA-1354 was artificial. If there are constant "partition by" expressions, simply drop them, they are no-ops. Constant "order by" expressions can be ignored as well, though in effect they should be accounted for as null expressions in the backend, with the effect that combine all rows in the same window (i.e. no window breaks). Change-Id: Idf129026c45120e9470df601268863634037908c --- M be/src/exec/analytic-eval-node.cc M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test 5 files changed, 54 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/11556/4 -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 4 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/1037/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 4 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 17:40:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11669 Change subject: IMPALA-7545: Add queueing reason to query log .. IMPALA-7545: Add queueing reason to query log After this change, the HS2 GetLog() function returns the queueing reason for a query when it is queued by the AdmissionController. Testing: Added an end-to-end test to test_admission_controller.py to verify the query logs returned. Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/service/impala-hs2-server.cc M tests/custom_cluster/test_admission_controller.py 4 files changed, 78 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/11669/1 -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-5050: Add support to read TIMESTAMP MILLIS and TIMESTAMP MICROS from Parquet
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 ) Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 15 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Oct 2018 18:14:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11670 Change subject: IMPALA-7622: adds profile metrics for incremental stats .. IMPALA-7622: adds profile metrics for incremental stats Reapplies change after fixing where frontend profile is placed in runtime profile. When computing incremental statistics by fetching the stats directly from catalogd, a potentially expensive RPC is made from the impalad coordinator to catalogd. This change adds metrics to the frontend section of the profile to track how long the request takes, the size of the compressed bytes received, and the number of partitions received. The profile for a 'compute incremental ...' command on a table with no statistics looks like this: Frontend: - StatsFetch.CompressedBytes: 0 - StatsFetch.TotalPartitions: 24 - StatsFetch.NumPartitionsWithStats: 0 - StatsFetch.Time: 26ms And the profile looks as follows when the table has stats, so the stats are fetched: Frontend: - StatsFetch.CompressedBytes: 24622 - StatsFetch.TotalPartitions: 23 - StatsFetch.NumPartitionsWithStats: 23 - StatsFetch.Time: 14ms Testing: - manual inspection - e2e test to check the profile Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 --- M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_pull_stats.py 3 files changed, 93 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/11670/1 -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/rpc/rpc-mgr.inline.h File be/src/rpc/rpc-mgr.inline.h: http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/rpc/rpc-mgr.inline.h@35 PS17, Line 35: template hrm, it still feels like we are going through a lot of gymnastics to avoid making a small change to KRPC (adding a service class member in connection id). Do you have a particular resistance to making that change? We can do it on the Impala side first and then port it over to Kudu if that's easier than splitting up the patches. -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 17 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 12 Oct 2018 18:19:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1038/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Fri, 12 Oct 2018 18:33:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1039/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 12 Oct 2018 18:43:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. Patch Set 1: Code-Review+2 This was reverted only to revert IMPALA-7527, right? -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 12 Oct 2018 19:07:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11671 Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" The fix for IMPALA-7644 introduced ASAN issues detailed in IMPALA-7704. Reverting for now. This reverts commit 843683ed6c2ef41c7c25e9fa4af68801dbdd1a78. Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a --- M be/src/common/global-flags.cc M be/src/exec/hdfs-parquet-table-writer.cc M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test R tests/query_test/test_parquet_page_index.py 4 files changed, 76 insertions(+), 105 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/11671/1 -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11671/1/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/11671/1/tests/query_test/test_parquet_page_index.py@173 PS1, Line 173: l flake8: E129 visually indented line with same indent as next logical line http://gerrit.cloudera.org:8080/#/c/11671/1/tests/query_test/test_parquet_page_index.py@272 PS1, Line 272: e flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/11671/1/tests/query_test/test_parquet_page_index.py@354 PS1, Line 354: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 19:17:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use
KRPC
..
Patch Set 17:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/10855/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10855/17//COMMIT_MSG@40
PS17, Line 40: 2. Added some targeted test cases for profile serialization
failure and RPC retries/timeout.
nit: long line
http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/rpc/thrift-util-test.cc
File be/src/rpc/thrift-util-test.cc:
http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/rpc/thrift-util-test.cc@58
PS14, Line 58:
Should we add a test for SerializeToString as well?
http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/runtime/query-state.cc@356
PS17, Line 356: CHECK
should we handle errors like these and log it instead?
http://gerrit.cloudera.org:8080/#/c/10855/16/be/src/service/control-service.h
File be/src/service/control-service.h:
http://gerrit.cloudera.org:8080/#/c/10855/16/be/src/service/control-service.h@52
PS16, Line 52: of
nit: with
http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc
File be/src/testutil/in-process-servers.cc:
http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc@51
PS14, Line 51: FLAGS_krpc_port =
> Some tests were failing without this. I don't recall which one. Apparently,
can you document the reason here? it was not clear to me as to why only this
one is specifically assigned here.
http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:
http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/util/runtime-profile.cc@251
PS14, Line 251: if (UNLIKELY(nodes.size()) == 0) return;
does this only happen when thrift de-serialization fails?
http://gerrit.cloudera.org:8080/#/c/10855/14/common/protobuf/control_service.proto
File common/protobuf/control_service.proto:
http://gerrit.cloudera.org:8080/#/c/10855/14/common/protobuf/control_service.proto@27
PS14, Line 27: message ParquetDmlStatsPB {
nit: maybe retain the comment in thrift file
"// For each column, the on disk byte size"
--
To view, visit http://gerrit.cloudera.org:8080/10855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe
Gerrit-Change-Number: 10855
Gerrit-PatchSet: 17
Gerrit-Owner: Michael Ho
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michal Ostrowski
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Fri, 12 Oct 2018 19:34:14 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1040/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 19:50:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. Patch Set 1: correct. -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 19:54:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3307/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 19:55:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. The patch also renames test_show_grant_user.py to test_show_grant.py for all tests related to SHOW GRANT statements. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Reviewed-on: http://gerrit.cloudera.org:8080/11663 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 20:22:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3308/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 20:35:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11669/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/11669/1/be/src/service/impala-hs2-server.cc@837 PS1, Line 837: DCHECK(queued_reason != nullptr); there is a small window where this can be null, its better to just check for it instead of a dcheck http://gerrit.cloudera.org:8080/#/c/11669/1/be/src/service/impala-hs2-server.cc@838 PS1, Line 838: Queued reason: maybe just use PROFILE_INFO_KEY_LAST_QUEUED_REASON here instead. Also worth printing PROFILE_INFO_KEY_ADMISSION_RESULT : PROFILE_INFO_VAL_QUEUED so that the total output looks like: Admission result: Queued Latest admission queue reason: number of running queries 1 is at or over limit 1 http://gerrit.cloudera.org:8080/#/c/11669/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/11669/1/tests/custom_cluster/test_admission_controller.py@820 PS1, Line 820: @pytest.mark.execute_serially You can setup a query to queue pretty easily instead of doing this: start a cluster with -default_pool_max_requests 1 , start a long running query like sleep(10), then the next query you try to run will be queued For reference, see L759-764 -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Fri, 12 Oct 2018 20:57:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 ) Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver" .. Patch Set 3: Code-Review+2 (1 comment) Update the commit message, otherwise looks good. http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG@15 PS3, Line 15: urllib.urlopen has been deprecated since 2.6 anyways, so the fix is to : switch to using the more current urllib2. Now that you are using the "requests" library, update this commit message. -- To view, visit http://gerrit.cloudera.org:8080/11625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544 Gerrit-Change-Number: 11625 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 12 Oct 2018 21:14:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions()
Tianyi Wang has posted comments on this change. (
http://gerrit.cloudera.org:8080/11641 )
Change subject: IMPALA-7670: Avoid getting the latest tables in
bulkAlterPartitions()
..
Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> ya I don't think it is specific to V2 (updated the jira description).
I've been running concurrent invalidate and drop stats with this diff and
haven't reproduced it.
diff --git a/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
b/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
index e9ef929103..7058a384e2 100644
--- a/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
+++ b/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
@@ -424,6 +424,7 @@ public interface FeFsTable extends FeTable {
break;
}
}
+try { Thread.sleep(100);} catch (Exception e) {}
if (matchFound) return partition;
}
return null;
diff --git a/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
b/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
index 88c1fd5138..892be0a5a7 100644
--- a/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
+++ b/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
@@ -792,6 +792,7 @@ public class HdfsTable extends Table implements FeFsTable {
HdfsPartition partition = createPartition(msPartition.getSd(),
msPartition,
permCache);
addPartition(partition);
+try { Thread.sleep(100);} catch (Exception e) {}
// If the partition is null, its HDFS path does not exist, and it was
not added
// to this table's partition list. Skip the partition.
if (partition == null) continue;
diff --git a/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
b/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
index 36725df84c..e2fcc785a4 100644
--- a/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
+++ b/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
@@ -3275,6 +3275,7 @@ public class CatalogOpExecutor {
MetastoreShim.alterPartitions(msClient.getHiveClient(), dbName,
tableName,
hmsPartitionsSubList);
// Mark the corresponding HdfsPartition objects as dirty
+ try {Thread.sleep(3000);} catch (Exception e) {}
for (org.apache.hadoop.hive.metastore.api.Partition msPartition:
hmsPartitionsSubList) {
try {
--
To view, visit http://gerrit.cloudera.org:8080/11641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec120f9df64d6e7e7d4978b5e190376721a6897
Gerrit-Change-Number: 11641
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Fri, 12 Oct 2018 21:38:28 +
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. IMPALA-7545: Add queueing reason to query log After this change, the HS2 GetLog() function returns the queueing reason for a query when it is queued by the AdmissionController. Testing: Added an end-to-end test to test_admission_controller.py to verify the query logs returned. Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/service/impala-hs2-server.cc M tests/custom_cluster/test_admission_controller.py 4 files changed, 81 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/11669/3 -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11669/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/11669/1/be/src/service/impala-hs2-server.cc@837 PS1, Line 837: const string* queued_reason = req > there is a small window where this can be null, its better to just check fo Done http://gerrit.cloudera.org:8080/#/c/11669/1/be/src/service/impala-hs2-server.cc@838 PS1, Line 838: issionControll > maybe just use PROFILE_INFO_KEY_LAST_QUEUED_REASON here instead. Done http://gerrit.cloudera.org:8080/#/c/11669/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/11669/1/tests/custom_cluster/test_admission_controller.py@820 PS1, Line 820: @pytest.mark.execute_serially > You can setup a query to queue pretty easily instead of doing this: Done -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Fri, 12 Oct 2018 21:48:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@822 PS3, Line 822: , max_queued=1, : pool_max_mem=10 * PROC_MEM_TEST_LIMIT, : queue_wait_timeout_ms=2 * STATESTORE_RPC_FREQUENCY_MS you can get rid of these http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@834 PS3, Line 834: long_running_query nit: just write the query directly here http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@836 PS3, Line 836: HS2TestSuite.check_response(long_query_resp) use self.hs2_client.wait_for_admission_control() to make sure the first query has started running http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@837 PS3, Line 837: # Wait for statestore update to update the query admitted in each node. : sleep(STATESTORE_RPC_FREQUENCY_MS / 1000) you dont need this, the query will anyways run on a single node http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@843 PS3, Line 843: query nit: write the query directly here http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@846 PS3, Line 846: HS2TestSuite.check_response(execute_statement_resp use self.hs2_client.wait_for_operation_state() and wait for PENDING state to make sure the second query has been queued http://gerrit.cloudera.org:8080/#/c/11669/3/tests/custom_cluster/test_admission_controller.py@852 PS3, Line 852: close the running queries at the end -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Fri, 12 Oct 2018 22:15:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1041/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Fri, 12 Oct 2018 22:20:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.
Hello Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11556 to look at the new patch set (#5). Change subject: IMPALA-6323 Allow constant analytic window expressions. .. IMPALA-6323 Allow constant analytic window expressions. The constraint imposed by IMPALA-1354 was artificial. If there are constant "partition by" expressions, simply drop them, they are no-ops. Constant "order by" expressions can be ignored as well, though in effect they should be accounted for as null expressions in the backend, with the effect that combine all rows in the same window (i.e. no window breaks). Change-Id: Idf129026c45120e9470df601268863634037908c --- M be/src/exec/analytic-eval-node.cc M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test 5 files changed, 54 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/11556/5 -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 5 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#13). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. IMPALA-6661 Make NaN values equal for grouping purposes. Similar to the treatment of NULLs, we want to consider NaN values as equal when grouping. - When detecting a NaN in a set of row values, the NaN value must be converted to a canonical value - so that all NaN values have the same bit-pattern for hashing purposes. - When doing equality evaluation, floating point types must have additional logic to consider NaN values as equal. - Existing logic for handling NULLs in this way is appropriate for triggering this behavior for NaN values. - Relabel "force null equality" as "inclusive equality" to expand the scope of the concept to a more generic form that includes NaN. Change-Id: I996c4a2e1934fd887046ed0c55457b7285375086 --- M be/src/codegen/codegen-anyval.cc M be/src/codegen/codegen-anyval.h M be/src/exec/hash-table.cc M be/src/exec/hash-table.h M be/src/exec/hash-table.inline.h M be/src/runtime/raw-value.cc M be/src/runtime/raw-value.h M be/src/runtime/raw-value.inline.h M testdata/workloads/functional-query/queries/QueryTest/exprs.test M testdata/workloads/functional-query/queries/QueryTest/joins.test 10 files changed, 182 insertions(+), 35 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/11535/13 -- To view, visit http://gerrit.cloudera.org:8080/11535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I996c4a2e1934fd887046ed0c55457b7285375086 Gerrit-Change-Number: 11535 Gerrit-PatchSet: 13 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/11535/9/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/11535/9/be/src/exec/hash-table.cc@801 PS9, Line 801: builder.SetIn > The probe-only behavior here doesn't match the behavior of the non-codegen' We should eliminate this test and convert unconditionally. This block is about generating consistent hash values, which we always want. The "inclusive_equality" flag applies only to "eq" comparisons. http://gerrit.cloudera.org:8080/#/c/11535/11/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/11535/11/be/src/exec/hash-table.cc@237 PS11, Line 237: INCLUSIVE_EQUALITY > This change in the logic of hash table may have implication to Join too. Added a more compact test case. http://gerrit.cloudera.org:8080/#/c/11535/11/be/src/exec/hash-table.cc@256 PS11, Line 256: val_is_nan = Raw > nit: val_is_nan Done http://gerrit.cloudera.org:8080/#/c/11535/11/be/src/exec/hash-table.cc@257 PS11, Line 257: local_is_nan = Raw > nit: local_is_nan Done -- To view, visit http://gerrit.cloudera.org:8080/11535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I996c4a2e1934fd887046ed0c55457b7285375086 Gerrit-Change-Number: 11535 Gerrit-PatchSet: 13 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 12 Oct 2018 22:31:26 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#4). Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. IMPALA-7597: wraps retries around CatalogMetaProvider When configured to use the local catalog, concurrent metadata reads and writes can cause the CatalogMetaProvider to throw an InconsistentMetadataFetchException. Queries have been wrapped with a retry loop, but the other frontend methods, such listing table or partition information, can also fail from the same error. These errors were seen under a workload consisting of concurrent adding and showing partitions. This change wraps call-sites (primarily in Frontend.java) that acquire a Catalog, so have a chance of throwing an InconsistentMetadataFetchExecption. Testing: - added a test that checks whether inconsistent metadata exceptions are seen in a concurrent workload. Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b --- M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/MetadataOp.java M tests/custom_cluster/test_local_catalog.py 3 files changed, 247 insertions(+), 100 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/11608/4 -- To view, visit http://gerrit.cloudera.org:8080/11608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b Gerrit-Change-Number: 11608 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11608/4/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/11608/4/tests/custom_cluster/test_local_catalog.py@216 PS4, Line 216: class TestLocalCatalogRetries(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/11608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b Gerrit-Change-Number: 11608 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 22:37:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 4: re-worked the tests a bit to separate out the retries from the other tests and to use less memory (was getting oom killed) -- To view, visit http://gerrit.cloudera.org:8080/11608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b Gerrit-Change-Number: 11608 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 22:38:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11673 Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement .. IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement Change-Id: I203a800855a413069a40c728dfa157939ea15caf --- M docs/topics/impala_alter_table.xml M docs/topics/impala_alter_view.xml 2 files changed, 422 insertions(+), 539 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11673/1 -- To view, visit http://gerrit.cloudera.org:8080/11673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf Gerrit-Change-Number: 11673 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 ) Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/96/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf Gerrit-Change-Number: 11673 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 22:38:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 ) Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/96/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf Gerrit-Change-Number: 11673 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 22:58:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1042/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I996c4a2e1934fd887046ed0c55457b7285375086 Gerrit-Change-Number: 11535 Gerrit-PatchSet: 13 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 12 Oct 2018 23:13:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1043/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 5 Gerrit-Owner: Michal Ostrowski Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 23:13:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11674 Change subject: IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement .. IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement Change-Id: Ifac0b689d55f525145b37846967a7a22f0e9245b --- M docs/impala.ditamap M docs/topics/impala_adls.xml A docs/topics/impala_alter_database.xml M docs/topics/impala_databases.xml 4 files changed, 93 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/11674/1 -- To view, visit http://gerrit.cloudera.org:8080/11674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifac0b689d55f525145b37846967a7a22f0e9245b Gerrit-Change-Number: 11674 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11674 ) Change subject: IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/97/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac0b689d55f525145b37846967a7a22f0e9245b Gerrit-Change-Number: 11674 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 23:19:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1044/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b Gerrit-Change-Number: 11608 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 23:19:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#11). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. IMPALA-7310: Use NDV=1 for a Column with all nulls Modified the planner to handle low-value NDVs by adjusting them upward by one to account for null values. Thus, even an all-null column, which has an NDV of 0 in stats, will have an NDV of 1 in the planner. (The planner already expects NDV to include nulls.) Modified the front end to allow capturing the full plan for use in a unit test. Added unit tests that verify estimated cardinality for a plan as a way to verify that the fix solved the scenario in IMPALA-7310. Testing required a new table, similar to the existing nulltable, but which has multiple rows and has stats calculated. The change was limited to a very narrow range of cases: * Base table column (not an internal column such as COUNT(*)) * Type is not BOOLEAN (turns out metadata does the needed NDV correction for BOOLEAN only.) * Column has stats * Column is nullable * Column does not provide a null count, or null count > 0 * Reported NDV <= 1 Testing showed that, at least for the functional test tables, we do have cases in which stats are computed, but the null count is -1 (undefined), which is why null count had to be considered. If we know the null count, and the null count is zero, then no adjustment is needed, But, if we don't know the null count, or it is positive, then adjustment may be needed. Research for this patch revealed that Impala treats NDVs in two distinct ways: * Stats (which use the NDV function) computes NDV as the number of distinct non-null values. (That is, the NDV of (0, null) is 1.) * The planner itself when working with constants, uses a definition of NDV that includes nulls. That is, the NDV of (0, null) is 2. This fix attempts to bridge the two definitions, Since we know that the NDV in stats excludes nulls (except for the BOOLEAN type), and we know that the column contains nulls, we can bump up the NDV to convert from the stats definition to the planner definition. But, to avoid regressions, we do so in a very narrow range of NDV values: only 0 and 1. Technically, the adjustment should apply to all NDV values. However, it turns out that if we do so, we end up with many failures in PlannerTest in those tests that work with TPC-H tables. The TPC-H tables have multiple columns marked as nullable but which actually have no nulls. Some of these columns also have a low NDV. By limiting the NDV adjustment to the narrow range, the TPC-H tests need not be updated. Since end users could have a similar situation, the narrow range reduces the chance that this fix might impact such workloads. Although the change minimized impact on PlannerTest, some memory numbers needed adjusting for a test in which one column hit the criteria listed above and had its NDV adjusted. Bug: IMPALA-7310: All-null columns give wrong estimates in planner Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 --- M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java M fe/src/main/java/org/apache/impala/analysis/SlotRef.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/ExprNdvTest.java A fe/src/test/java/org/apache/impala/planner/CardinalityTest.java A testdata/NullRows/data.csv M testdata/bin/compute-table-stats.sh M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test 10 files changed, 452 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/11528/11 -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11674 ) Change subject: IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/97/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac0b689d55f525145b37846967a7a22f0e9245b Gerrit-Change-Number: 11674 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 23:22:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/11520 )
Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges
..
Patch Set 6: Code-Review+2
(1 comment)
One small comment. Otherwise, looks good!
http://gerrit.cloudera.org:8080/#/c/11520/6/be/src/runtime/io/scan-range.cc
File be/src/runtime/io/scan-range.cc:
http://gerrit.cloudera.org:8080/#/c/11520/6/be/src/runtime/io/scan-range.cc@466
PS6, Line 466: void ScanRange::Reset(hdfsFS fs, const char* file, int64_t len,
int64_t offset,
: int disk_id, bool expected_local, const BufferOpts&
buffer_opts,
: vector&& sub_ranges, void* meta_data) {
: Reset(fs, file, len, offset, disk_id, expected_local,
buffer_opts, meta_data);
: AddSubRanges(move(sub_ranges));
: }
Nit: Just as a style thing, my preference would be to have the base Reset()
take sub_ranges as an argument and initialize sub_ranges_. The other Reset()
would call in with an empty list.
i.e.
Reset(args) -> Reset(args, sub_ranges)
rather than
Reset(args, sub_ranges) -> Reset(args) then init sub_ranges
In this case, it might make sense for AddSubRanges() to be renamed to
InitSubRanges().
--
To view, visit http://gerrit.cloudera.org:8080/11520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea26ba386713990f7671aab5a372cf449b8d51e4
Gerrit-Change-Number: 11520
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Fri, 12 Oct 2018 23:34:07 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#12). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. IMPALA-7310: Use NDV=1 for a Column with all nulls Modified the planner to handle low-value NDVs by adjusting them upward by one to account for null values. Thus, even an all-null column, which has an NDV of 0 in stats, will have an NDV of 1 in the planner. (The planner already expects NDV to include nulls.) Modified the front end to allow capturing the full plan for use in a unit test. Added unit tests that verify estimated cardinality for a plan as a way to verify that the fix solved the scenario in IMPALA-7310. Testing required a new table, similar to the existing nulltable, but which has multiple rows and has stats calculated. The change was limited to a very narrow range of cases: * Base table column (not an internal column such as COUNT(*)) * Type is not BOOLEAN (turns out metadata does the needed NDV correction for BOOLEAN only.) * Column has stats * Column is nullable * Column does not provide a null count, or null count > 0 * Reported NDV <= 1 Testing showed that, at least for the functional test tables, we do have cases in which stats are computed, but the null count is -1 (undefined), which is why null count had to be considered. If we know the null count, and the null count is zero, then no adjustment is needed, But, if we don't know the null count, or it is positive, then adjustment may be needed. Research for this patch revealed that Impala treats NDVs in two distinct ways: * Stats (which use the NDV function) computes NDV as the number of distinct non-null values. (That is, the NDV of (0, null) is 1.) * The planner itself when working with constants, uses a definition of NDV that includes nulls. That is, the NDV of (0, null) is 2. This fix attempts to bridge the two definitions, Since we know that the NDV in stats excludes nulls (except for the BOOLEAN type), and we know that the column contains nulls, we can bump up the NDV to convert from the stats definition to the planner definition. But, to avoid regressions, we do so in a very narrow range of NDV values: only 0 and 1. Technically, the adjustment should apply to all NDV values. However, it turns out that if we do so, we end up with many failures in PlannerTest in those tests that work with TPC-H tables. The TPC-H tables have multiple columns marked as nullable but which actually have no nulls. Some of these columns also have a low NDV. By limiting the NDV adjustment to the narrow range, the TPC-H tests need not be updated. Since end users could have a similar situation, the narrow range reduces the chance that this fix might impact such workloads. Although the change minimized impact on PlannerTest, some memory numbers needed adjusting for a test in which one column hit the criteria listed above and had its NDV adjusted. Bug: IMPALA-7310: All-null columns give wrong estimates in planner Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 --- M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java M fe/src/main/java/org/apache/impala/analysis/SlotRef.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/ExprNdvTest.java A fe/src/test/java/org/apache/impala/planner/CardinalityTest.java A testdata/NullRows/data.csv M testdata/bin/compute-table-stats.sh M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test 10 files changed, 457 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/11528/12 -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 12 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Patch Set 12: (3 comments) > Uploaded patch set 12. Addressed a few more review comments. Rebased on master. http://gerrit.cloudera.org:8080/#/c/11528/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11528/10//COMMIT_MSG@71 PS10, Line 71: Bug: IMPALA-7310: All-null columns give wrong estimates in planner > We almost always put "IMPALA-7310:" in the first line of the commit message Fixed. http://gerrit.cloudera.org:8080/#/c/11528/10/fe/src/main/java/org/apache/impala/analysis/SlotRef.java File fe/src/main/java/org/apache/impala/analysis/SlotRef.java: http://gerrit.cloudera.org:8080/#/c/11528/10/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@110 PS10, Line 110: // not zero. > Perhaps: "if we don't know the null count (in which case, getNumNulls() ret Done http://gerrit.cloudera.org:8080/#/c/11528/8/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test: http://gerrit.cloudera.org:8080/#/c/11528/8/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test@a986 PS8, Line 986: > test Is this comment itself a test, or is this a request to test something? -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 12 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 23:37:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. IMPALA-7622: adds profile metrics for incremental stats Reapplies change after fixing where frontend profile is placed in runtime profile. When computing incremental statistics by fetching the stats directly from catalogd, a potentially expensive RPC is made from the impalad coordinator to catalogd. This change adds metrics to the frontend section of the profile to track how long the request takes, the size of the compressed bytes received, and the number of partitions received. The profile for a 'compute incremental ...' command on a table with no statistics looks like this: Frontend: - StatsFetch.CompressedBytes: 0 - StatsFetch.TotalPartitions: 24 - StatsFetch.NumPartitionsWithStats: 0 - StatsFetch.Time: 26ms And the profile looks as follows when the table has stats, so the stats are fetched: Frontend: - StatsFetch.CompressedBytes: 24622 - StatsFetch.TotalPartitions: 23 - StatsFetch.NumPartitionsWithStats: 23 - StatsFetch.Time: 14ms Testing: - manual inspection - e2e test to check the profile Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Reviewed-on: http://gerrit.cloudera.org:8080/11670 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_pull_stats.py 3 files changed, 93 insertions(+), 3 deletions(-) Approvals: Tianyi Wang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94559a749500d44aa6aad564134d55c39e1d5273 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 23:44:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1045/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 23:46:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11675 Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER Also, added the privileges required for ALTER VIEW SET OWNER Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 --- M docs/shared/impala_common.xml 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/11675/1 -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11675 ) Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/98/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 23:51:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11675 ) Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/98/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 23:55:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Patch Set 12: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1046/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 12 Gerrit-Owner: Paul Rogers Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sat, 13 Oct 2018 00:05:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. IMPALA-7545: Add queueing reason to query log After this change, the HS2 GetLog() function returns the queueing reason for a query when it is queued by the AdmissionController. Testing: Added an end-to-end test to test_admission_controller.py to verify the query logs returned. Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/service/impala-hs2-server.cc M tests/custom_cluster/test_admission_controller.py 4 files changed, 88 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/11669/4 -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 00:25:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/11669 )
Change subject: IMPALA-7545: Add queueing reason to query log
..
Patch Set 4:
(3 comments)
just a few nits left
http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:
http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py@845
PS4, Line 845: queueing
nit: queuing
http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py@849
PS4, Line 849: assert re.search("Admission result : Queued\nLatest
admission queue reason "
also add assert for "Admission result: Queued"
http://gerrit.cloudera.org:8080/#/c/11669/4/tests/custom_cluster/test_admission_controller.py@849
PS4, Line 849: re.search("Admission result : Queued\nLatest admission queue
reason "
: ": number of running queries 1 is at or over limit
1\n", log)
just use "string_to_search" in str instead of a regex search. no need for extra
overhead
--
To view, visit http://gerrit.cloudera.org:8080/11669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545
Gerrit-Change-Number: 11669
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pooja Nilangekar
Gerrit-Comment-Date: Sat, 13 Oct 2018 00:30:12 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Is this a clean revert ? -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sat, 13 Oct 2018 00:40:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: > Is this a clean revert ? Yes -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sat, 13 Oct 2018 00:43:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1047/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Sat, 13 Oct 2018 00:45:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sat, 13 Oct 2018 01:00:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11677 Change subject: IMPALA-7702: enable fetch incremental stats by default .. IMPALA-7702: enable fetch incremental stats by default Flips the default from always off to always on for --pull_incremental_statistics. With this setting, the default is for coordinators to fetch incremental stats from catalogd directly (only when computing incremental stats) instead of receiving it from the statestore broadcast. Fetching incremental stats is not applicable when using a CatalogMetaProvider. By making fetch the default, it would require that --pull_incremental_statistics is set to false when enabling CatalogMetaProvider. This patch makes this easier by not requiring this. Instead, if --use_local_catalog is set to true, that takes priority over --pull_incremental_statistics. Testing: - manual testing Change-Id: I5601a24f81bb3466cff5308c7093d2765bb1c481 --- M be/src/common/global-flags.cc M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/11677/1 -- To view, visit http://gerrit.cloudera.org:8080/11677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5601a24f81bb3466cff5308c7093d2765bb1c481 Gerrit-Change-Number: 11677 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11677 ) Change subject: IMPALA-7702: enable fetch incremental stats by default .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1048/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5601a24f81bb3466cff5308c7093d2765bb1c481 Gerrit-Change-Number: 11677 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 02:06:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: fix signed overflows in decimal
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11604 ) Change subject: IMPALA-5031: fix signed overflows in decimal .. Patch Set 2: Code-Review+2 Carry Joe's +2 -- To view, visit http://gerrit.cloudera.org:8080/11604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf882428931e4f4264be2fc8cd9d6b1fc89b8ace Gerrit-Change-Number: 11604 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 13 Oct 2018 02:28:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: fix signed overflows in decimal
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11604 ) Change subject: IMPALA-5031: fix signed overflows in decimal .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3309/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf882428931e4f4264be2fc8cd9d6b1fc89b8ace Gerrit-Change-Number: 11604 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 13 Oct 2018 02:29:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7703: Update to Sentry 2.1.0
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11678 Change subject: IMPALA-7703: Update to Sentry 2.1.0 .. IMPALA-7703: Update to Sentry 2.1.0 This patch bumps the CDH_BUILD_NUMBER to 632827 in order to use Sentry 2.1.0. Testing: - Ran all core tests Change-Id: I001d17313663171bc6ff23d62026c258486726a1 --- M bin/impala-config.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/11678/1 -- To view, visit http://gerrit.cloudera.org:8080/11678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I001d17313663171bc6ff23d62026c258486726a1 Gerrit-Change-Number: 11678 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
[Impala-ASF-CR] IMPALA-7703: Update to Sentry 2.1.0
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11678 ) Change subject: IMPALA-7703: Update to Sentry 2.1.0 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3310/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/11678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001d17313663171bc6ff23d62026c258486726a1 Gerrit-Change-Number: 11678 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 02:41:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11675 ) Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11675/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/11675/1/docs/shared/impala_common.xml@299 PS1, Line 299: ALTER TABLE SET OWNER need an entry for ALTER DATABASE SET OWNER. -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 02:55:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11674 ) Change subject: IMPALA-7705: [DOCS] Documented the ALTER DATABASE SET OWNER statement .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac0b689d55f525145b37846967a7a22f0e9245b Gerrit-Change-Number: 11674 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 02:57:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 ) Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml@269 PS1, Line 269: An : owner of a table has the ALL privilege Add "if enabled with Sentry", or something to that effect. http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105 PS1, Line 105: An owner of a view has the ALL privilege if enabled with Sentry. -- To view, visit http://gerrit.cloudera.org:8080/11673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf Gerrit-Change-Number: 11673 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 03:01:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7703: Update to Sentry 2.1.0
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11678 ) Change subject: IMPALA-7703: Update to Sentry 2.1.0 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1049/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001d17313663171bc6ff23d62026c258486726a1 Gerrit-Change-Number: 11678 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sat, 13 Oct 2018 03:19:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag"
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11671 ) Change subject: IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" .. IMPALA-7704: Revert "IMPALA-7644: Hide Parquet page index writing with feature flag" The fix for IMPALA-7644 introduced ASAN issues detailed in IMPALA-7704. Reverting for now. This reverts commit 843683ed6c2ef41c7c25e9fa4af68801dbdd1a78. Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Reviewed-on: http://gerrit.cloudera.org:8080/11671 Tested-by: Impala Public Jenkins Reviewed-by: Michael Ho --- M be/src/common/global-flags.cc M be/src/exec/hdfs-parquet-table-writer.cc M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test R tests/query_test/test_parquet_page_index.py 4 files changed, 76 insertions(+), 105 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Ho: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icf0a64d6ec747275e3ecd6e801e054f81095591a Gerrit-Change-Number: 11671 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11675 ) Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/99/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 03:33:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Hello Fredy Wijaya, Impala Public Jenkins, Adam Holley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11675 to look at the new patch set (#2). Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER Also, added the privileges required for ALTER VIEW SET OWNER Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 --- M docs/shared/impala_common.xml 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/11675/2 -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11675 ) Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11675/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/11675/1/docs/shared/impala_common.xml@299 PS1, Line 299: ALTER TABLE SET OWNER > need an entry for ALTER DATABASE SET OWNER. Done -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 03:33:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11675 ) Change subject: IMPALA-7706: [DOCS] Added the privileges required for ALTER TABLE SET OWNER .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/99/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671dbe3e6fb3118a67c59fb1fcaf1ec53139b587 Gerrit-Change-Number: 11675 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 03:36:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 ) Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml@269 PS1, Line 269: An : owner of a table has the ALL privilege > Add "if enabled with Sentry", or something to that effect. Done http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105 PS1, Line 105: An owner of a view has the ALL privilege > if enabled with Sentry. if the ALL privilege is enabled in Sentry? What should be enabled in Sentry? -- To view, visit http://gerrit.cloudera.org:8080/11673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf Gerrit-Change-Number: 11673 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 13 Oct 2018 03:39:11 + Gerrit-HasComments: Yes
