[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4544/ -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 26 Jun 2019 04:38:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Fredy Wijaya has posted comments on this change. (
http://gerrit.cloudera.org:8080/13346 )
Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper
Sentry API
..
Patch Set 11:
(5 comments)
Thanks for the fixes! This is getting close. I'm ready to give a +2 once all
the comments are resolved.
http://gerrit.cloudera.org:8080/#/c/13346/11/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java
File
fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java:
http://gerrit.cloudera.org:8080/#/c/13346/11/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@535
PS11, Line 535: public boolean isSentryAdmin(User requestingUser) throws
InternalException,
can we add javadoc?
http://gerrit.cloudera.org:8080/#/c/13346/11/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@535
PS11, Line 535: throws InternalException,
nit: I think it's more readable to put throws InternalException,
SentryUserException in the next line.
http://gerrit.cloudera.org:8080/#/c/13346/11/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@537
PS11, Line 537: SentryServiceClient client = new SentryServiceClient();
: try {
: return client.get().isAdmin(requestingUser.getName());
: } finally {
: client.close();
: }
nit: using try-resource is shorter, i.e.
try (SentryServiceClient client = new SentryServiceClient()) {
return client.get().isAdmin(requestingUser.getName());
}
http://gerrit.cloudera.org:8080/#/c/13346/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/13346/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java@304
PS11, Line 304: try {
: boolean isSentryAdmin =
((SentryCatalogdAuthorizationManager)
:
catalogOpExecutor_.getAuthzManager()).isSentryAdmin(user);
: response.setIs_admin(isSentryAdmin);
: } catch (SentryUserException e) {
: // When a user is not defined in Sentry, isAdmin() will
throw
: // SentryUserException, we will consider this requesting
user
: // as a non-Sentry administrator.
: response.setIs_admin(false);
: }
Sorry for the back and forth, but putting this logic in JniCatalog doesn't feel
quite right since JniCatalog is supposed to be a thin JNI wrapper. It makes
more sense to move the try/catch logic in the SentryProxy instead.
http://gerrit.cloudera.org:8080/#/c/13346/11/tests/authorization/test_sentry.py
File tests/authorization/test_sentry.py:
http://gerrit.cloudera.org:8080/#/c/13346/11/tests/authorization/test_sentry.py@51
PS11, Line 51: root
nit: Calling it non_admin makes it easier to understand.
--
To view, visit http://gerrit.cloudera.org:8080/13346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82
Gerrit-Change-Number: 13346
Gerrit-PatchSet: 11
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 26 Jun 2019 03:57:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 12: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4543/ -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 12 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 26 Jun 2019 03:38:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4547/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 03:41:17 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 1: Code-Review+2 Thanks for fixing this! -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 03:40:32 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 03:41:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3750/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 02:05:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3749/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 02:04:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. IMPALA-8698: Disable row count estimate to avoid a flaky test Disabled the row count estimate for an hdfs table for the EE test test_bloom_filters to avoid a flaky test due to a previous patchset (IMPALA-7608). Testing: Have run the revised EE test on a local dev box. Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Reviewed-on: http://gerrit.cloudera.org:8080/13727 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 01:58:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Fang-Yu Rao has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API Impala uses a workaround to detect if a user is a Sentry admin by calling the Sentry API to list privileges associated with the user since previously Sentry did not provide a suitable API to peform this check. This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check. Also modified test_sentry.py to exercise the code paths corresponding to the following 3 different types of users: (i) a Sentry admin, (ii) an existing user which is not a Sentry admin, and (iii) a non-existing user. Testing: 1. Passed the tests in the revised test_sentry.py. Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 --- M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M tests/authorization/test_sentry.py 5 files changed, 62 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13346/11 -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3748/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 01:21:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/13346 )
Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper
Sentry API
..
Patch Set 10:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13346/10/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java
File
fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java:
http://gerrit.cloudera.org:8080/#/c/13346/10/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@534
PS10, Line 534:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/13346/10/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@537
PS10, Line 537: SentryServiceClient client = new SentryServiceClient();
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/13346/10/fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java@538
PS10, Line 538: try {
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/13346/10/fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java
File fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java:
http://gerrit.cloudera.org:8080/#/c/13346/10/fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java@387
PS10, Line 387: return
sentryPolicyService_.isSentryAdmin(requestingUser);
tab used for whitespace
--
To view, visit http://gerrit.cloudera.org:8080/13346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82
Gerrit-Change-Number: 13346
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 26 Jun 2019 01:19:42 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Fang-Yu Rao has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API Impala uses a workaround to detect if a user is a Sentry admin by calling the Sentry API to list privileges associated with the user since previously Sentry did not provide a suitable API to peform this check. This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check. Also modified test_sentry.py to exercise the code paths corresponding to the following 3 different types of users: (i) a Sentry admin, (ii) an existing user which is not a Sentry admin, and (iii) a non-existing user. Testing: 1. Passed the tests in the revised test_sentry.py. Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 --- M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M tests/authorization/test_sentry.py 5 files changed, 62 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13346/10 -- To view, visit http://gerrit.cloudera.org:8080/13346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82 Gerrit-Change-Number: 13346 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4546/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:39:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:39:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4545/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:38:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13717 )
Change subject: IMPALA-8702: Remove the PlannerTestOption of
VALIDATE_CARDINALITY to avoid a flaky test
..
Patch Set 4:
(3 comments)
> Patch Set 1:
>
> (3 comments)
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@222
PS1, Line 222: // Skip cardinality validation because some tables do not
have stats
> This comment should be more concise. The comments shouldn't explain the cha
Thanks for the prompt reply! I will modify the comment as suggested.
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@227
PS1, Line 227: @Test
> No need to pass in an empty set when there's an overload that does not requ
Sure. I will use the method that does not require this argument.
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@263
PS1, Line 263: public void testFkPkJoinDetectionWithHDFSNumRowsEstDisabled() {
Thanks Tim! I have removed the cardinality validation here as well.
--
To view, visit http://gerrit.cloudera.org:8080/13717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187
Gerrit-Change-Number: 13717
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Wed, 26 Jun 2019 00:37:50 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:38:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() and testFkPkJoinDetection() to avoid checking the estimated cardinality which may be slightly different each time due to IMPALA-7608 when an hdfs table without stats is involved in a query. Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/13717/4 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. IMPALA-8589: Re-enable flaky test_query_event_hooks.py This patch fixes the flaky test_query_event_hooks.py. The patch also cuts down the waiting time for impalad timeout to 5 seconds from the default 60 seconds especially for those tests that will fail Impala startup. Testing: - Ran test_query_event_hooks.py in a loop. Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Reviewed-on: http://gerrit.cloudera.org:8080/13713 Reviewed-by: Fredy Wijaya Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java M fe/src/test/java/org/apache/impala/testutil/AlwaysErrorQueryEventHook.java M fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java M fe/src/test/java/org/apache/impala/testutil/PostQueryErrorEventHook.java M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_query_event_hooks.py 6 files changed, 126 insertions(+), 196 deletions(-) Approvals: Fredy Wijaya: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 9 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Wed, 26 Jun 2019 00:13:42 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 ) Change subject: Fix incorrect timestamp units in the logs .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3747/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 26 Jun 2019 00:02:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3746/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 25 Jun 2019 23:35:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3745/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 25 Jun 2019 23:30:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13730 ) Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3744/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 23:28:05 + Gerrit-HasComments: No
[native-toolchain-CR] SSL client support for THttpClient py implementation
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 ) Change subject: SSL client support for THttpClient py implementation .. Patch Set 3: (1 comment) I thought of doing that but I was afraid that it would cause any python 2.x incompatibilities. http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh@166 PS2, Line 166: THRIFT_VERSION=0.9.3-p7 $SOURCE_DIR/source/thrift/build.sh > I don't think we need to build all these thrift versions, do we? We should Moved it under BUILD_HISTORICAL flag. -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 23:22:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test File testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test: http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test@131 PS2, Line 131: SET DISABLE_HDFS_NUM_ROWS_ESTIMATE=1; > instead of disabling this feature, I would recommend changing the query to Hi Bikram, thank you very much for your suggestion! According to your suggestion, I tried to run the following two SQL statements on my local dev box. Notice that the table "functional_seq_gzip.alltypes" is an hdfs table w/o stats. 1. The original statement in bloom_filters.test. $IMPALA_HOME/bin/impala-shell.sh -q \ "SET RUNTIME_FILTER_MODE=GLOBAL; SET RUNTIME_FILTER_WAIT_TIME_MS=3; SET RUNTIME_FILTER_MIN_SIZE=4KB; SET RUNTIME_BLOOM_FILTER_SIZE=4KB; select STRAIGHT_JOIN count(*) from functional_seq_gzip.alltypes a join [SHUFFLE] functional_seq_gzip.alltypes b on a.id = b.id; PROFILE;" -p | less 2. The revised statement according to your suggestion (notice that I changed that 7,300 to 3 to force the returned size of the sub-query to be at most 3 instead of 7,300). $IMPALA_HOME/bin/impala-shell.sh -q \ "SET RUNTIME_FILTER_MODE=GLOBAL; SET RUNTIME_FILTER_WAIT_TIME_MS=3; SET RUNTIME_FILTER_MIN_SIZE=4KB; SET RUNTIME_BLOOM_FILTER_SIZE=4KB; select STRAIGHT_JOIN count(*) from (select * from functional_seq_gzip.alltypes limit 3) a join [SHUFFLE] (select * from functional_seq_gzip.alltypes limit 3) b on a.id = b.id; PROFILE;" -p | less However, on my local dev box, the sizes of "Filter 0" in both cases are 8.00 KB and thus it seems that restricting the sizes of the sub-queries may not be useful in this case. But I might be wrong. Any more suggestions or ideas would be greatly welcomed. :-) -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 23:21:44 + Gerrit-HasComments: Yes
[native-toolchain-CR] SSL client support for THttpClient py implementation
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13725 to look at the new patch set (#3). Change subject: SSL client support for THttpClient py implementation .. SSL client support for THttpClient py implementation Thrift 0.9.3-p7 adds the ability to pass SSL context from the clients for cert verification. This is needed for impala-shell support for HTTP based server endpoints. Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce --- M buildall.sh A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch 2 files changed, 130 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/25/13725/3 -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13731 Change subject: Fix incorrect timestamp units in the logs .. Fix incorrect timestamp units in the logs EventSequence.markEvent() returns ns, so the existing conversion is incorrect. Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 --- M fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/13731/1 -- To view, visit http://gerrit.cloudera.org:8080/13731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1 Gerrit-Change-Number: 13731 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE This change implements INTERVAL expression support for DATE type and adds several DATE related built-in functions. The efficiency of the DateValue::ToYearMonthDay() function used in many of the built-in functions below was also improved. The following functions are supported in Hive: INT YEAR(DATE d) Extracts year of the 'd' date, returns it as an int in 0- range. INT MONTH(DATE d) Extracts month of the 'd' date and returns it as an int in 1-12 range. INT DAY(DATE d), INT DAYOFMONTH(DATE d) Extracts day-of-month of the 'd' date and returns it as an int in 1-31 range. INT QUARTER(DATE d) Extracts quarter of the 'd' date and returns it as an int in 1-4 range. INT DAYOFWEEK(DATE d) Extracts day-of-week of the 'd' date and returns it as an int in 1-7 range. 1 is Sunday and 7 is Saturday. INT DAYOFYEAR(DATE d) Extracts day-of-year of the 'd' date and returns it as an int in 1-366 range. INT WEEKOFYEAR(DATE d) Extracts week-of-year of the 'd' date and returns it as an int in 1-53 range. STRING DAYNAME(DATE d) Returns the day field from a 'd' date, converted to the string corresponding to that day name. The range of return values is "Sunday" to "Saturday". STRING MONTHNAME(DATE d) Returns the month field from a 'd' date, converted to the string corresponding to that month name. The range of return values is "January" to "December". DATE NEXT_DAY(DATE d, STRING weekday) Returns the first date which is later than 'd' and named as 'weekday'. 'weekday' is 3 letters or full name of the day of the week. DATE LAST_DAY(DATE d) Returns the last day of the month which the 'd' date belongs to. INT DATEDIFF(DATE d1, DATE d2) Returns the number of days from 'd1' date to 'd2' date. DATE CURRENT_DATE() Returns the current date (in the local time zone). INT INT_MONTHS_BETWEEN(DATE d1, DATE d2) Returns the number of months between 'd1' and 'd2' dates, as an int representing only the full months that passed. If 'd1' represents an earlier date than 'd2', the result is negative. DOUBLE MONTHS_BETWEEN(DATE d1, DATE d2) Returns the number of months between 'd1' and 'd2' dates. Can include a fractional part representing extra days in addition to the full months between the dates. The fractional component is computed by dividing the difference in days by 31 (regardless of the month). If 'd1' represents an earlier date than 'd2', the result is negative. DATE ADD_YEARS(DATE d, INT/BIGINT num_years), DATE SUB_YEARS(DATE d, INT/BIGINT num_years) Adds/subtracts a specified number of years to a 'd' date value. DATE ADD_MONTHS(DATE d, INT/BIGINT num_months), DATE SUB_MONTHS(DATE d, INT/BIGINT num_months) Adds/subtracts a specified number of months to a date value. If 'd' is the last day of a month, the returned date will fall on the last day of the target month too. DATE ADD_DAYS(DATE d, INT/BIGINT num_days), DATE SUB_DAYS(DATE d, INT/BIGINT num_days) Adds/subtracts a specified number of days to a date value. DATE ADD_WEEKS(DATE d, INT/BIGINT num_weeks), DATE SUB_WEEKS(DATE d, INT/BIGINT num_weeks) Adds/subtracts a specified number of weeks to a date value. The following function doesn't exist in Hive but supported by Amazon Redshift INT DATE_CMP(DATE d1, DATE d2) Compares 'd1' and 'd2' dates. Returns: 1. NULL, if either 'd1' or 'd2' is NULL 2. -1 if d1 < d2 3. 1 if d1 > d2 4. 0 if d1 == d2 (https://docs.aws.amazon.com/redshift/latest/dg/r_DATE_CMP.html) Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Reviewed-on: http://gerrit.cloudera.org:8080/13648 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/benchmarks/date-benchmark.cc M be/src/codegen/impala-ir.cc M be/src/exprs/CMakeLists.txt A be/src/exprs/date-functions-ir.cc A be/src/exprs/date-functions.h M be/src/exprs/expr-test.cc M be/src/exprs/scalar-expr-evaluator.cc M be/src/exprs/timestamp-functions-ir.cc M be/src/exprs/timestamp-functions.cc M be/src/exprs/timestamp-functions.h M be/src/exprs/udf-builtins.cc M be/src/runtime/date-test.cc M be/src/runtime/date-value.cc M be/src/runtime/date-value.h M common/function-registry/impala_functions.py M fe/src/main/java/org/apache/impala/analysis/TimestampArithmeticExpr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 17 files changed, 1,707 insertions(+), 180 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
[native-toolchain-CR] SSL client support for THttpClient py implementation
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 ) Change subject: SSL client support for THttpClient py implementation .. Patch Set 2: (1 comment) I think this looks ok. I compared with the version of this file from thrift master and the key parts look consistent. I kinda wonder if it would have been easier to basically just take the file from new version of thrift instead of selectively picking changes, but I guess this reduces the chance of pulling in new problems. http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh@166 PS2, Line 166: THRIFT_VERSION=0.9.3-p7 $SOURCE_DIR/source/thrift/build.sh I don't think we need to build all these thrift versions, do we? We should be able to remove -p5 and -p6, I wouuld think -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 23:06:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 23:06:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4544/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 25 Jun 2019 22:58:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Vihang Karajgaonkar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories The FileMetadataLoader is used to load the file information in when the table is loaded. By default, it lists all the files in the table/partition directory. Currently, it only skips the filenames which are invalid (hidden files and ones starting with "_" etc). However, it does not skip the directories which are temporary or hidden. In case of Hive when data is inserted into a table, it creates a temporary staging directory which is a hidden directory under the table location. When the insert in hive is completed, such staging directories are removed. But if there is a refresh called during that time, FileMetadataLoader will add the files in the staging directory as well. Not only this could cause temporary invalid results but it causes table to go in a bad state when these temporary directories are removed. The only work-around in such a case to issue a refresh on the table again. This patch adds logic in the filemetadataloader to ignore such temporary staging directories. Unfortunately, hadoop does not provide a API which can recursively list files in a directory and skip certain directories. This patch addes this logic of filtering into existing RecursingIterator in FileSystemUtil. Also, the existing code to recover partitions implements its own recursion logic which includes path validation. This already skips such hidden directories since they do not conform to the partition spec. The patch does a minor modification to this method by directly calling the listStatusIterator instead of going through FileSystemUtil which uses the filtering remote iterator now. Testing: 1. Added a new test in FilemetadataloaderTest and modified existing ones in AcidUtils. Modified existing test_recursive_listing.py 2. Ran concurrent inserts from Hive while issuing refresh in a loop on Impala side. Earlier this would cause the table to go into a bad state. Now, it works fine for the staging directories. It still runs into a FileNotFoundException from the impalad when there are insert overwrite statements in Hive Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java M tests/metadata/test_recursive_listing.py 5 files changed, 148 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13665/8 -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories The FileMetadataLoader is used to load the file information in when the table is loaded. By default, it lists all the files in the table/partition directory. Currently, it only skips the filenames which are invalid (hidden files and ones starting with "_" etc). However, it does not skip the directories which are temporary or hidden. In case of Hive when data is inserted into a table, it creates a temporary staging directory which is a hidden directory under the table location. When the insert in hive is completed, such staging directories are removed. But if there is a refresh called during that time, FileMetadataLoader will add the files in the staging directory as well. Not only this could cause temporary invalid results but it causes table to go in a bad state when these temporary directories are removed. The only work-around in such a case to issue a refresh on the table again. This patch adds logic in the filemetadataloader to ignore such temporary staging directories. Unfortunately, hadoop does not provide a API which can recursively list files in a directory and skip certain directories. This patch addes this logic of filtering into existing RecursingIterator in FileSystemUtil. Also, the existing code to recover partitions implements its own recursion logic which includes path validation. This already skips such hidden directories since they do not conform to the partition spec. The patch does a minor modification to this method by directly calling the listStatusIterator instead of going through FileSystemUtil which uses the filtering remote iterator now. Testing: 1. Added a new test in FilemetadataloaderTest and modified existing ones in AcidUtils. Modified existing test_recursive_listing.py 2. Ran concurrent inserts from Hive while issuing refresh in a loop on Impala side. Earlier this would cause the table to go into a bad state. Now, it works fine for the staging directories. It still runs into a FileNotFoundException from the impalad when there are insert overwrite statements in Hive Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java M tests/metadata/test_recursive_listing.py 5 files changed, 146 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13665/7 -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/13665/7/tests/metadata/test_recursive_listing.py File tests/metadata/test_recursive_listing.py: http://gerrit.cloudera.org:8080/#/c/13665/7/tests/metadata/test_recursive_listing.py@98 PS7, Line 98: , flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13665/7/tests/metadata/test_recursive_listing.py@101 PS7, Line 101: a flake8: E501 line too long (104 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/13665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa Gerrit-Change-Number: 13665 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 25 Jun 2019 22:51:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories
Vihang Karajgaonkar has posted comments on this change. (
http://gerrit.cloudera.org:8080/13665 )
Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp
directories
..
Patch Set 7:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@545
PS6, Line 545:* If 'recursive' is true, all underlying files (except which
are
> this javadoc should be updated to indicate that tmp/hidden files and direct
Done
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@566
PS6, Line 566: // even though it returns Locate
> It looks like this will break the above-mentioned optimization. In the case
hmm.. yeah thats true. Thanks for catching that. I think this method is a bit
confusing or rather the name of the method is confusing. In my opinion its
cleaner if listStatus does just what it says and the caller invokes listStatus
v/s listFiles dependending of if its S3 file system or not. However, I can see
why it is done this way so that we don't inadvertently introduce a inefficient
code path if we don't know about this S3 perf optimization.
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@576
PS6, Line 576:
> The naming and this comment are a bit opposite from each other. The predica
agreed. Changed this to a simple static method called isIgnoredDirectory
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@580
PS6, Line 580:* which tools like Hive create in the table/partition
directories when a query is
> is this ever used as a Predicate? It seems like in this file it's only used
Done
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@592
PS6, Line 592: boolean recursive) throws IOException {
> nit: add an inline comment like this: /*useListStatus=*/false
Changed the input arguments to use a Enum for get the LISTING_TYPE
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@633
PS6, Line 633:
> nit: weird spacing that's inconsistent with most of the java code in impala
Done
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@681
PS6, Line 681: // state)
: while (curFile_ == null) {
: if (curIter_.hasNext()) {
: // Consume the next file or directory from the current
iterator.
: handleFileStat(curIter_.next());
: } else if (!iters_.empty()) {
: // We ran out of entries in the current one, but we
might still have
:
> IMO this javadoc is a bit redundant with the implementation and maybe not n
agreed. removed it
http://gerrit.cloudera.org:8080/#/c/13665/6/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@694
PS6, Line 694:
> this should say "Do not", right?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c4a22908304fe9e377d77d6c18d401c3f3294aa
Gerrit-Change-Number: 13665
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:50:40 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 22:49:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. IMPALA-8697: fix assert in test_query_options for EC test runs IMPALA-7290 added a timezone query option check to this test but the expected order of query options being printed in the query profile was wrong specifically for an option expected in a test run with erasure coding turned on. This patch just puts them in the right order in the expected string. Testing: Tested on EC build. Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Reviewed-on: http://gerrit.cloudera.org:8080/13709 Reviewed-by: Bikramjeet Vig Tested-by: Impala Public Jenkins --- M tests/query_test/test_observability.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Bikramjeet Vig: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 22:49:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13730 Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest The following changes were ok on their own, but together led to broken tests on Hive 3: https://gerrit.cloudera.org/#/c/13428/ https://gerrit.cloudera.org/#/c/13427/ Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d --- M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/13730/1 -- To view, visit http://gerrit.cloudera.org:8080/13730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iad41c1a7b0458a405b95f62d8e0ecd93947f492d Gerrit-Change-Number: 13730 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4536/ -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 22:24:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 12: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 12 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 25 Jun 2019 22:05:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4543/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 12 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 25 Jun 2019 22:05:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. IMPALA-7322: Add storage wait time to profile Add metrics to record storage wait time for operations with metadata load in catalog for hdfs, kudu and hbase tables. Pass storage wait time from catalog to fe through thrift and log total storage load time in query profile. Storage-load-time is the amount of time spent loading metadata from the underlying storage layer (e.g. S3, HDFS, Kudu, HBase), which does not include the amount of time spending loading data from HMS. Testing: Ran queries that can trigger all of, none of or some of the related tables loading. Check query profile for each query. Check catalog metrics for each table. Add unit tests to test_observability.py Ran all core tests. Sample output: Profile:(storage-load-time is the added property): After ran a hbase query (Metadata load finished is divided into several lines because of limitation of commit message): Query Compilation: 4s401ms - Metadata load started: 661.084us (661.084us) - Metadata load finished. loaded-tables=1/1 load-requests=1 catalog-updates=3 storage-load-time=233ms: 3s819ms (3s819ms) - Analysis finished: 3s820ms (763.979us) - Value transfer graph computed: 3s820ms (63.193us) Catalog metrics(this sample is from a hdfs table): storage-metadata-load-duration: Count: 1 Mean rate: 0.0085 1 min. rate: 0.032 5 min. rate: 0.1386 15 min. rate: 0.177 Min (msec): 111 Max (msec): 111 Mean (msec): 111.1802 Median (msec): 111.1802 75th-% (msec): 111.1802 95th-% (msec): 111.1802 99th-% (msec): 111.1802 Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Reviewed-on: http://gerrit.cloudera.org:8080/12940 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M tests/query_test/test_observability.py 7 files changed, 131 insertions(+), 29 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 15 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 14 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Tue, 25 Jun 2019 22:02:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13720 ) Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive() .. IMPALA-8315: ignore rmtree errors in run_stmt_in_hive() Per Joe's suggestion in the JIRA, we shouldn't fail the test if rmtree() hits an error. Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df Reviewed-on: http://gerrit.cloudera.org:8080/13720 Tested-by: Impala Public Jenkins Reviewed-by: Joe McDonnell --- M tests/common/impala_test_suite.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df Gerrit-Change-Number: 13720 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13720 ) Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df Gerrit-Change-Number: 13720 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 25 Jun 2019 21:30:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 21:29:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/358/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 25 Jun 2019 20:57:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test File testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test: http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test@131 PS2, Line 131: SET DISABLE_HDFS_NUM_ROWS_ESTIMATE=1; instead of disabling this feature, I would recommend changing the query to have a deterministic row count like this: select STRAIGHT_JOIN count(*) from (select * from alltypes limit 7300) a join [SHUFFLE] (select * from alltypes limit 7300) b on a.id = b.id; -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 20:47:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13724 to look at the new patch set (#2). Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. IMPALA-8341: [DOCS] Describe the setting for remote data caching Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f --- M docs/impala.ditamap A docs/topics/impala_data_cache.xml 2 files changed, 86 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/13724/2 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/358/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 25 Jun 2019 20:43:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4542/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 20:25:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 20:25:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 20:25:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8665 Include extra info in error message when date cast fails
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13680 ) Change subject: IMPALA-8665 Include extra info in error message when date cast fails .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3743/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04 Gerrit-Change-Number: 13680 Gerrit-PatchSet: 7 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Comment-Date: Tue, 25 Jun 2019 19:58:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3742/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 19:57:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3741/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 19:56:02 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Syntax fix for CREATE FUNCTION
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13726 ) Change subject: [DOCS] Syntax fix for CREATE FUNCTION .. [DOCS] Syntax fix for CREATE FUNCTION - The INTERMEDIATE clause was moved to after RETURNS. Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f Reviewed-on: http://gerrit.cloudera.org:8080/13726 Reviewed-by: Joe McDonnell Tested-by: Impala Public Jenkins --- M docs/topics/impala_create_function.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f Gerrit-Change-Number: 13726 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Peter Ebert (172)
[Impala-ASF-CR] IMPALA-8665 Include extra info in error message when date cast fails
Jiawei Wang has uploaded a new patch set (#7). (
http://gerrit.cloudera.org:8080/13680 )
Change subject: IMPALA-8665 Include extra info in error message when date cast
fails
..
IMPALA-8665 Include extra info in error message when date cast fails
This change extends the error message Impala yields when casting STRING
to DATE (explicitly or implicitly) fails. The new error message includes
the violating string value.
Testing:
changes -> date-partitioning.test & date.test
query_test/test_date_queries.py test passed
Example:
select cast('2000' as date);
ERROR: UDF ERROR: String to Date parse failed. Invalid string val: "2000"
Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
---
M be/src/exprs/cast-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/date.test
3 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/13680/7
--
To view, visit http://gerrit.cloudera.org:8080/13680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
Gerrit-Change-Number: 13680
Gerrit-PatchSet: 7
Gerrit-Owner: Jiawei Wang
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jiawei Wang
[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13727 Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. IMPALA-8698: Disable row count estimate to avoid a flaky test Disabled the row count estimate for an hdfs table for the EE test test_bloom_filters to avoid a flaky test due to a previous patchset (IMPALA-7608). Testing: Have run the revised EE test on a local dev box. Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/13727/2 -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8627: re-enable catalog v2 in containers
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13708 ) Change subject: IMPALA-8627: re-enable catalog v2 in containers .. IMPALA-8627: re-enable catalog v2 in containers Change-Id: I3b4dd7060c3977c4a943b2492008c1dd601402a2 Reviewed-on: http://gerrit.cloudera.org:8080/13708 Tested-by: Impala Public Jenkins Reviewed-by: Vihang Karajgaonkar --- M docker/catalogd/Dockerfile M docker/coord_exec/Dockerfile M docker/coordinator/Dockerfile 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Vihang Karajgaonkar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3b4dd7060c3977c4a943b2492008c1dd601402a2 Gerrit-Change-Number: 13708 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4541/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 18:24:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 8: Code-Review+2 (2 comments) Carry Bharath's +2. http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java File fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java: http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java@24 PS7, Line 24: /** > Add a class comment on how this is supposed to work? Done http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py File tests/custom_cluster/test_query_event_hooks.py: http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py@112 PS7, Line 112: > remove? Done -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 18:24:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. IMPALA-8589: Re-enable flaky test_query_event_hooks.py This patch fixes the flaky test_query_event_hooks.py. The patch also cuts down the waiting time for impalad timeout to 5 seconds from the default 60 seconds especially for those tests that will fail Impala startup. Testing: - Ran test_query_event_hooks.py in a loop. Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 --- M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java M fe/src/test/java/org/apache/impala/testutil/AlwaysErrorQueryEventHook.java M fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java M fe/src/test/java/org/apache/impala/testutil/PostQueryErrorEventHook.java M tests/common/custom_cluster_test_suite.py M tests/custom_cluster/test_query_event_hooks.py 6 files changed, 126 insertions(+), 196 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/13713/8 -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen
[Impala-ASF-CR] IMPALA-8627: re-enable catalog v2 in containers
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13708 ) Change subject: IMPALA-8627: re-enable catalog v2 in containers .. Patch Set 3: Code-Review+2 > (1 comment) makes sense. I am in favor of re-enabling them in that case. -- To view, visit http://gerrit.cloudera.org:8080/13708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4dd7060c3977c4a943b2492008c1dd601402a2 Gerrit-Change-Number: 13708 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 25 Jun 2019 18:20:42 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Syntax fix for CREATE FUNCTION
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13726 ) Change subject: [DOCS] Syntax fix for CREATE FUNCTION .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/357/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/13726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f Gerrit-Change-Number: 13726 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Peter Ebert (172) Gerrit-Comment-Date: Tue, 25 Jun 2019 18:08:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3740/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 18:03:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the settings for remote data caching
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the settings for remote data caching .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13724/1/docs/topics/impala_data_cache.xml File docs/topics/impala_data_cache.xml: http://gerrit.cloudera.org:8080/#/c/13724/1/docs/topics/impala_data_cache.xml@44 PS1, Line 44: --data_cache_dir --data_cache_dir and --data_cache_size are options built specifically only for ./bin/start-impala-cluster.py as that script needs to create extra sub-directories for the caching directory. To specify the caching directory, the user should use the flag: --data_cache=,,: With the above configuration, data will be stored in , and respectively. The user needs to make sure those directories exist in the local filesystem to begin with. In addition, the filesystem which the directory resides in must support hole punching. Modern filesystems such as ext4 and xfs support this feature. The cache may consume up to bytes for each of the directories specified. In other words, with the above configuration, the total cache size can be up to 3 * . Please see https://github.com/apache/impala/blob/master/be/src/runtime/io/disk-io-mgr.cc#L58-L63 for the definition of the flag. -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 25 Jun 2019 17:50:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Syntax fix for CREATE FUNCTION
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13726 ) Change subject: [DOCS] Syntax fix for CREATE FUNCTION .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f Gerrit-Change-Number: 13726 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Peter Ebert (172) Gerrit-Comment-Date: Tue, 25 Jun 2019 17:45:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8665 Include extra info in error message when date cast fails
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13680 ) Change subject: IMPALA-8665 Include extra info in error message when date cast fails .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3739/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04 Gerrit-Change-Number: 13680 Gerrit-PatchSet: 6 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Comment-Date: Tue, 25 Jun 2019 17:32:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4539/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 17:26:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 17:26:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 17:26:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 7: > Uploaded patch set 7. Fixed an int overflow issue. -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 17:23:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE
Attila Jeges has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE This change implements INTERVAL expression support for DATE type and adds several DATE related built-in functions. The efficiency of the DateValue::ToYearMonthDay() function used in many of the built-in functions below was also improved. The following functions are supported in Hive: INT YEAR(DATE d) Extracts year of the 'd' date, returns it as an int in 0- range. INT MONTH(DATE d) Extracts month of the 'd' date and returns it as an int in 1-12 range. INT DAY(DATE d), INT DAYOFMONTH(DATE d) Extracts day-of-month of the 'd' date and returns it as an int in 1-31 range. INT QUARTER(DATE d) Extracts quarter of the 'd' date and returns it as an int in 1-4 range. INT DAYOFWEEK(DATE d) Extracts day-of-week of the 'd' date and returns it as an int in 1-7 range. 1 is Sunday and 7 is Saturday. INT DAYOFYEAR(DATE d) Extracts day-of-year of the 'd' date and returns it as an int in 1-366 range. INT WEEKOFYEAR(DATE d) Extracts week-of-year of the 'd' date and returns it as an int in 1-53 range. STRING DAYNAME(DATE d) Returns the day field from a 'd' date, converted to the string corresponding to that day name. The range of return values is "Sunday" to "Saturday". STRING MONTHNAME(DATE d) Returns the month field from a 'd' date, converted to the string corresponding to that month name. The range of return values is "January" to "December". DATE NEXT_DAY(DATE d, STRING weekday) Returns the first date which is later than 'd' and named as 'weekday'. 'weekday' is 3 letters or full name of the day of the week. DATE LAST_DAY(DATE d) Returns the last day of the month which the 'd' date belongs to. INT DATEDIFF(DATE d1, DATE d2) Returns the number of days from 'd1' date to 'd2' date. DATE CURRENT_DATE() Returns the current date (in the local time zone). INT INT_MONTHS_BETWEEN(DATE d1, DATE d2) Returns the number of months between 'd1' and 'd2' dates, as an int representing only the full months that passed. If 'd1' represents an earlier date than 'd2', the result is negative. DOUBLE MONTHS_BETWEEN(DATE d1, DATE d2) Returns the number of months between 'd1' and 'd2' dates. Can include a fractional part representing extra days in addition to the full months between the dates. The fractional component is computed by dividing the difference in days by 31 (regardless of the month). If 'd1' represents an earlier date than 'd2', the result is negative. DATE ADD_YEARS(DATE d, INT/BIGINT num_years), DATE SUB_YEARS(DATE d, INT/BIGINT num_years) Adds/subtracts a specified number of years to a 'd' date value. DATE ADD_MONTHS(DATE d, INT/BIGINT num_months), DATE SUB_MONTHS(DATE d, INT/BIGINT num_months) Adds/subtracts a specified number of months to a date value. If 'd' is the last day of a month, the returned date will fall on the last day of the target month too. DATE ADD_DAYS(DATE d, INT/BIGINT num_days), DATE SUB_DAYS(DATE d, INT/BIGINT num_days) Adds/subtracts a specified number of days to a date value. DATE ADD_WEEKS(DATE d, INT/BIGINT num_weeks), DATE SUB_WEEKS(DATE d, INT/BIGINT num_weeks) Adds/subtracts a specified number of weeks to a date value. The following function doesn't exist in Hive but supported by Amazon Redshift INT DATE_CMP(DATE d1, DATE d2) Compares 'd1' and 'd2' dates. Returns: 1. NULL, if either 'd1' or 'd2' is NULL 2. -1 if d1 < d2 3. 1 if d1 > d2 4. 0 if d1 == d2 (https://docs.aws.amazon.com/redshift/latest/dg/r_DATE_CMP.html) Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a --- M be/src/benchmarks/date-benchmark.cc M be/src/codegen/impala-ir.cc M be/src/exprs/CMakeLists.txt A be/src/exprs/date-functions-ir.cc A be/src/exprs/date-functions.h M be/src/exprs/expr-test.cc M be/src/exprs/scalar-expr-evaluator.cc M be/src/exprs/timestamp-functions-ir.cc M be/src/exprs/timestamp-functions.cc M be/src/exprs/timestamp-functions.h M be/src/exprs/udf-builtins.cc M be/src/runtime/date-test.cc M be/src/runtime/date-value.cc M be/src/runtime/date-value.h M common/function-registry/impala_functions.py M fe/src/main/java/org/apache/impala/analysis/TimestampArithmeticExpr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 17 files changed, 1,707 insertions(+), 180 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/13648/7 -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id:
[Impala-ASF-CR] [DOCS] Syntax fix for CREATE FUNCTION
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13726 Change subject: [DOCS] Syntax fix for CREATE FUNCTION .. [DOCS] Syntax fix for CREATE FUNCTION - The INTERMEDIATE clause was moved to after RETURNS. Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f --- M docs/topics/impala_create_function.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/13726/1 -- To view, visit http://gerrit.cloudera.org:8080/13726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f Gerrit-Change-Number: 13726 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] [DOCS] Syntax fix for CREATE FUNCTION
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13726 ) Change subject: [DOCS] Syntax fix for CREATE FUNCTION .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/357/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/13726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1c399cdd4d09b1b8d6649866f3d90a35fa0740f Gerrit-Change-Number: 13726 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 17:15:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4538/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 17:12:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 4: Code-Review+2 rebasing to fetch IMPALA-8700 that broke the previous GVO. Carrying forwards +2 -- To view, visit http://gerrit.cloudera.org:8080/13709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a3fffa8c4800cc159bf512692393c6b4392cf9 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 17:11:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8665 Include extra info in error message when date cast fails
Attila Jeges has posted comments on this change. (
http://gerrit.cloudera.org:8080/13680 )
Change subject: IMPALA-8665 Include extra info in error message when date cast
fails
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13680/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13680/5//COMMIT_MSG@18
PS5, Line 18: ('2000' as Date)
> Both of them work. But yeah, I will change this to 'date'.
What I meant was that CAST is missing.
--
To view, visit http://gerrit.cloudera.org:8080/13680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
Gerrit-Change-Number: 13680
Gerrit-PatchSet: 5
Gerrit-Owner: Jiawei Wang
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jiawei Wang
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:58:43 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8665 Include extra info in error message when date cast fails
Jiawei Wang has uploaded a new patch set (#6). (
http://gerrit.cloudera.org:8080/13680 )
Change subject: IMPALA-8665 Include extra info in error message when date cast
fails
..
IMPALA-8665 Include extra info in error message when date cast fails
This change extends the error message Impala yields when casting STRING
to DATE (explicitly or implicitly) fails. The new error message includes
the violating string value.
Testing:
changes -> date-partitioning.test & date.test
query_test/test_date_queries.py test passed
Example:
select ('2000' as date);
ERROR: UDF ERROR: String to Date parse failed. Invalid string val: "2000"
Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
---
M be/src/exprs/cast-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/date.test
3 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/13680/6
--
To view, visit http://gerrit.cloudera.org:8080/13680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04
Gerrit-Change-Number: 13680
Gerrit-PatchSet: 6
Gerrit-Owner: Jiawei Wang
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jiawei Wang
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
..
Patch Set 7: Code-Review+2
(2 comments)
Thanks for fixing this, seems much simpler to follow.
http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
File fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java:
http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java@24
PS7, Line 24: public class DummyQueryEventHook implements QueryEventHook {
Add a class comment on how this is supposed to work?
http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py@112
PS7, Line 112: LOG.info(method.func_dict)
remove?
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: radford nguyen
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:40:08 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 14: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4537/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 14 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Tue, 25 Jun 2019 16:30:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 13 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Tue, 25 Jun 2019 16:30:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 14 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Tue, 25 Jun 2019 16:30:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3738/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 16:30:38 + Gerrit-HasComments: No
[native-toolchain-CR] SSL client support for THttpClient py implementation
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13725 to look at the new patch set (#2). Change subject: SSL client support for THttpClient py implementation .. SSL client support for THttpClient py implementation Thrift 0.9.3-p7 adds the ability to pass SSL context from the clients for cert verification. This is needed for impala-shell support for HTTP based server endpoints. Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce --- M buildall.sh A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch 2 files changed, 128 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/25/13725/2 -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] SSL client support for THttpClient py implementation
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 ) Change subject: SSL client support for THttpClient py implementation .. Patch Set 1: Oops, I think I added the wrong patch file, let me fix that. -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 16:10:31 + Gerrit-HasComments: No
[native-toolchain-CR] SSL client support for THttpClient py implementation
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13725 Change subject: SSL client support for THttpClient py implementation .. SSL client support for THttpClient py implementation Thrift 0.9.3-p7 adds the ability to pass SSL context from the clients for cert verification. This is needed for impala-shell support for HTTP based server endpoints. Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce --- M buildall.sh A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py-implementation.patch 2 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/25/13725/1 -- To view, visit http://gerrit.cloudera.org:8080/13725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce Gerrit-Change-Number: 13725 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 ) Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3737/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 15:59:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4535/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 15:51:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 7: Rebased and re-running the dry-run. -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: radford nguyen Gerrit-Comment-Date: Tue, 25 Jun 2019 15:51:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the settings for remote data caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the settings for remote data caching .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/356/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 25 Jun 2019 15:48:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the settings for remote data caching
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the settings for remote data caching .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/356/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 15:42:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the settings for remote data caching
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13724 Change subject: IMPALA-8341: [DOCS] Describe the settings for remote data caching .. IMPALA-8341: [DOCS] Describe the settings for remote data caching Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f --- M docs/impala.ditamap A docs/topics/impala_data_cache.xml 2 files changed, 85 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/13724/1 -- To view, visit http://gerrit.cloudera.org:8080/13724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7dd958e4de109b46eaf906fe93145799af123b3f Gerrit-Change-Number: 13724 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13723 Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth Switch to a newer version of CDP Hive where HIVE-20833 is reverted. HIVE-20833 was backported without HIVE-20221, which broke the the handling of column PARTITION_PARAMS.PARAM_KEY in HMS, leading to several test failures in Impala. The new HIVE version also includes the fix for HIVE-21796, so test_max_nesting_depth could be also re-enabled with Hive 3. Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 --- M bin/impala-config.sh M tests/common/skip.py M tests/query_test/test_nested_types.py 3 files changed, 6 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/13723/1 -- To view, visit http://gerrit.cloudera.org:8080/13723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 ) Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1 .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3736/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19d8d097a45ae6f103b6cd1b2d81aad38dfd9e23 Gerrit-Change-Number: 13722 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 25 Jun 2019 15:08:10 + Gerrit-HasComments: No
