[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. IMPALA-12744: Support for regr_count() aggregate/analytic function The regr_count() function can be used both as an aggregate and an analytic function and is commonly used in regression analysis. regr_count(y, x) returns an integer that is the number of non-null number pairs. It indicates how many observations are included in the analysis. Testing: The functions are extensively tested and cross-checked with Hive. The tests can be found in aggregation.test. Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Reviewed-on: http://gerrit.cloudera.org:8080/20936 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/aggregate-functions.h M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M testdata/workloads/functional-query/queries/QueryTest/aggregation.test 4 files changed, 305 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sat, 10 Feb 2024 18:14:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10261/ The failure seems to be IMPALA-9441. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sat, 10 Feb 2024 13:43:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sat, 10 Feb 2024 13:44:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10264/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Sat, 10 Feb 2024 13:44:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10261/ -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Fri, 09 Feb 2024 19:35:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: The second failure seems to be a case of https://issues.apache.org/jira/browse/IMPALA-12798, but it's supposed to be fixed now. Started a new build. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Fri, 09 Feb 2024 15:05:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10261/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Fri, 09 Feb 2024 15:04:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10259/ -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Fri, 09 Feb 2024 14:52:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10259/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Fri, 09 Feb 2024 10:15:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10255/ -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Thu, 08 Feb 2024 19:50:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 4: Code-Review+2 Thanks Pranav! -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Thu, 08 Feb 2024 15:16:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Thu, 08 Feb 2024 15:17:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10255/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Thu, 08 Feb 2024 15:17:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Wed, 07 Feb 2024 15:28:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15199/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Wed, 07 Feb 2024 14:02:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 4: > Patch Set 3: > > (1 comment) > > Looks good to me, just one small issue. Thanks for the review, changed! -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Wed, 07 Feb 2024 13:37:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
pranav.lo...@cloudera.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. IMPALA-12744: Support for regr_count() aggregate/analytic function The regr_count() function can be used both as an aggregate and an analytic function and is commonly used in regression analysis. regr_count(y, x) returns an integer that is the number of non-null number pairs. It indicates how many observations are included in the analysis. Testing: The functions are extensively tested and cross-checked with Hive. The tests can be found in aggregation.test. Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/aggregate-functions.h M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M testdata/workloads/functional-query/queries/QueryTest/aggregation.test 4 files changed, 305 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/20936/4 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Tue, 06 Feb 2024 09:14:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 3: (1 comment) Looks good to me, just one small issue. http://gerrit.cloudera.org:8080/#/c/20936/3/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/3/be/src/exprs/aggregate-functions-ir.cc@304 PS3, Line 304: DCHECK_GE(dst->val, 0); I think this line of code should also be inside the if block above. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zihao Ye Gerrit-Comment-Date: Tue, 06 Feb 2024 06:59:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15166/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 05 Feb 2024 09:39:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 3: (4 comments) > Uploaded patch set 3. http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: The regr_cou > We should have "The regr_count() function". Done http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: reg > "and an" Done http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: ot > "as an" Done http://gerrit.cloudera.org:8080/#/c/20936/2/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/2/be/src/exprs/aggregate-functions-ir.cc@307 PS2, Line 307: > We don't use 'ctx' and in the above two functions this variable was unnamed Done -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 05 Feb 2024 09:13:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
pranav.lo...@cloudera.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. IMPALA-12744: Support for regr_count() aggregate/analytic function The regr_count() function can be used both as an aggregate and an analytic function and is commonly used in regression analysis. regr_count(y, x) returns an integer that is the number of non-null number pairs. It indicates how many observations are included in the analysis. Testing: The functions are extensively tested and cross-checked with Hive. The tests can be found in aggregation.test. Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/aggregate-functions.h M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M testdata/workloads/functional-query/queries/QueryTest/aggregation.test 4 files changed, 303 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/20936/3 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: as "as an" http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: and "and an" http://gerrit.cloudera.org:8080/#/c/20936/2//COMMIT_MSG@9 PS2, Line 9: regr_count() We should have "The regr_count() function". http://gerrit.cloudera.org:8080/#/c/20936/2/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20936/2/be/src/exprs/aggregate-functions-ir.cc@307 PS2, Line 307: ctx We don't use 'ctx' and in the above two functions this variable was unnamed. Either having a name or not is ok, but it should be consistent with the above functions. See also L313. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 05 Feb 2024 08:31:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15098/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 30 Jan 2024 07:24:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
pranav.lo...@cloudera.com has posted comments on this change. (
http://gerrit.cloudera.org:8080/20936 )
Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic
function
..
Patch Set 2:
(10 comments)
> Uploaded patch set 2.
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@7
PS1, Line 7: aggregate
> If it can be used as both an aggregate and an analytical function, having "
Done
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9
PS1, Line 9: regr_count
> Nit: "The regr_count() functin..."
Done
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9
PS1, Line 9: as
> Nit: "as an"
Done
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@9
PS1, Line 9: and
> Nit: "and an"
Done
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@10
PS1, Line 10: function
> Nit: function (singular).
Done
http://gerrit.cloudera.org:8080/#/c/20936/1//COMMIT_MSG@10
PS1, Line 10: s c
> Nit: is.
Done
http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions-ir.cc@315
PS1, Line 315: CHECK(!dst->is_null);
: if (!src1.is_null && !src2.is_null) {
: --dst->val;
> Is this different here than in the non-timestamp version, i.e. on L300?
Removed
http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions.h
File be/src/exprs/aggregate-functions.h:
http://gerrit.cloudera.org:8080/#/c/20936/1/be/src/exprs/aggregate-functions.h@74
PS1, Line 74:
> We don't use 'ctx' and in the above two functions this variable was unnamed
Done
http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test
File testdata/workloads/functional-query/queries/QueryTest/aggregation.test:
http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@2713
PS1, Line 2713: 1 in
> This doesn't return null, it returns 1.
Ack
http://gerrit.cloudera.org:8080/#/c/20936/1/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@2802
PS1, Line 2802: rand()
> Is there a specific reason for using rand() and not a simple constant?
No, not really, it was brought up in corr() patch I think and since then it's
kept in the same way to maintain uniformity.
--
To view, visit http://gerrit.cloudera.org:8080/20936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38
Gerrit-Change-Number: 20936
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Daniel Becker
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 30 Jan 2024 07:01:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12744: Support for regr count() aggregate/analytic function
pranav.lo...@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20936 ) Change subject: IMPALA-12744: Support for regr_count() aggregate/analytic function .. IMPALA-12744: Support for regr_count() aggregate/analytic function regr_count() function can be used both as aggregate and analytic function and is commonly used in regression analysis. regr_count(y, x) returns an integer that is the number of non-null number pairs. It indicates how many observations are included in the analysis. Testing: The functions are extensively tested and cross-checked with Hive. The tests can be found in aggregation.test. Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 --- M be/src/exprs/aggregate-functions-ir.cc M be/src/exprs/aggregate-functions.h M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M testdata/workloads/functional-query/queries/QueryTest/aggregation.test 4 files changed, 303 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/20936/2 -- To view, visit http://gerrit.cloudera.org:8080/20936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I773d1e0edc8a9c8ee003f75721f4844685b2eb38 Gerrit-Change-Number: 20936 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins
