[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10944 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) .. IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) In addition to previous fix for IMPALA-7288, this patch would prevent impala from crashing in case a code-path generates a malformed handcrafted function which it then tries to finalize. Ideally this would never happen since the code paths for generating handcrafted IRs would never generate a malformed function. Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Reviewed-on: http://gerrit.cloudera.org:8080/10944 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 14 Jul 2018 00:20:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 13 Jul 2018 20:58:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2815/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 13 Jul 2018 20:58:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10944 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 13 Jul 2018 20:34:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10944 Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) .. IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) In addition to previous fix for IMPALA-7288, this patch would prevent impala from crashing in case a code-path generates a malformed handcrafted function which it then tries to finalize. Ideally this would never happen since the code paths for generating handcrafted IRs would never generate a malformed function. Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b --- M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h 2 files changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10944/1 -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 13 Jul 2018 04:07:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. IMPALA-7288: Fix Codegen Crash in FinalizeModule() Currently codegen crashed during FinalizeModule() where it tries to clean up half-baked handcrafted functions. This happens only for the cases where the code generating the handcrafted IR calls eraseFromParent() on failure which also deletes the memory held by the function pointer and therefore causes a crash during clean up in FinalizeModule(). Testing: Added regression tests that verify that failure code paths in the previously offending methods don't crash Impala. Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Reviewed-on: http://gerrit.cloudera.org:8080/10933 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/hash-table.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-scanner.cc M tests/query_test/test_codegen.py 4 files changed, 17 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2809/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 13 Jul 2018 00:49:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 13 Jul 2018 00:49:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 13 Jul 2018 00:43:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 13 Jul 2018 00:35:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 2: added 2 regression tests for the methods in hash-table.cc -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 13 Jul 2018 00:29:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Hello Michael Ho, Zoram Thanga, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10933 to look at the new patch set (#2). Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. IMPALA-7288: Fix Codegen Crash in FinalizeModule() Currently codegen crashed during FinalizeModule() where it tries to clean up half-baked handcrafted functions. This happens only for the cases where the code generating the handcrafted IR calls eraseFromParent() on failure which also deletes the memory held by the function pointer and therefore causes a crash during clean up in FinalizeModule(). Testing: Added regression tests that verify that failure code paths in the previously offending methods don't crash Impala. Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 --- M be/src/exec/hash-table.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-scanner.cc M tests/query_test/test_codegen.py 4 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/10933/2 -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: Another idea is to inject fault at expression codegen functions to randomly fail codegen. This may not cover cases like scanners but should still provide reasonable coverage for other exec nodes. -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Thu, 12 Jul 2018 23:06:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: > Change LGTM. May be it helps to add some end-to-end test which > exercises the hashT table paths with CHAR type to confirm it's > fixed. Same can be said about the scanner changes. > > In the long run, every codegen changes which include handcrafted IR > should include CHAR type as part of the tests. CHAR type was a part of the manual testing that i did for IMPALA-6177. The thing that I am concerned about is that if we decide to add tests for CHAR for only the changes in this patch, then to get full coverage we would also have to add test cases that exercise all handcrafted IR generation code paths that have failure modes for CHAR -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Thu, 12 Jul 2018 22:58:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: > > I am not sure what kind of tests I can add to this, since this > > looks more like an abuse of API than an actual functionality that > i > > can test. any ideas welcomed > > How about the test case that repro'd this? I mean the one Balasz > posted? I can, but i am wondering if its worth adding a test case that tests a very specific bug. Like if someone where to add similar code to there nodes/code paths, the added test wont be able to catch that. -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Thu, 12 Jul 2018 22:54:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: Change LGTM. May be it helps to add some end-to-end test which exercises the hashT table paths with CHAR type to confirm it's fixed. Same can be said about the scanner changes. In the long run, every codegen changes which include handcrafted IR should include CHAR type as part of the tests. -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Thu, 12 Jul 2018 22:52:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: > I am not sure what kind of tests I can add to this, since this > looks more like an abuse of API than an actual functionality that i > can test. any ideas welcomed How about the test case that repro'd this? I mean the one Balasz posted? -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Thu, 12 Jul 2018 22:50:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: I am not sure what kind of tests I can add to this, since this looks more like an abuse of API than an actual functionality that i can test. any ideas welcomed -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 12 Jul 2018 22:46:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10933 Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. IMPALA-7288: Fix Codegen Crash in FinalizeModule() Currently codegen crashed during FinalizeModule() where it tries to clean up half-baked handcrafted functions. This happens only for the cases where the code generating the handcrafted IR calls eraseFromParent() on failure which also deletes the memory held by the function pointer and therefore causes a crash during clean up in FinalizeModule(). Testing: Tested manually to verify the code path that initially caused the crash was being excercised. Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 --- M be/src/exec/hash-table.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-scanner.cc 3 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/10933/1 -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
