[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16648 )

Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the 
leader only
..


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16648/3/src/kudu/integration-tests/txn_status_table-itest.cc
File src/kudu/integration-tests/txn_status_table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16648/3/src/kudu/integration-tests/txn_status_table-itest.cc@725
PS3, Line 725: FLAGS_leader_failure_max_missed_heartbeat_periods = 1;
 : FLAGS_raft_heartbeat_interval_ms = 30;
> The short heartbeat interval combined with just single missing heartbeat pe
Yes, when I looped I was using --stress_cpu_threads=16.


http://gerrit.cloudera.org:8080/#/c/16648/7/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16648/7/src/kudu/tserver/ts_tablet_manager.cc@1453
PS7, Line 1453:   TxnStatusManager* txn_status_manager =
  :   dynamic_cast(coordinator);
  :   TxnStatusManager::ScopedLeaderSharedLock 
l(txn_status_manager);
> Looking at this again and again prompts me to ask the following question: I
Sounds doable for me, but wondering what is the rationale behind to perform the 
downcast under the hood vs. doing it here?



--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 14 Jan 2021 19:56:43 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16648

to look at the new patch set (#8).

Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the 
leader only
..

KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/txn_manager-test.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
18 files changed, 760 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/8
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16648

to look at the new patch set (#7).

Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the 
leader only
..

KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/txn_manager-test.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
18 files changed, 760 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/7
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16648 )

Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the 
leader only
..


Patch Set 6:

(19 comments)

http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/integration-tests/txn_status_table-itest.cc
File src/kudu/integration-tests/txn_status_table-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/integration-tests/txn_status_table-itest.cc@744
PS6, Line 744: ;
> nit: drop extra semicolon
Done


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/integration-tests/txn_status_table-itest.cc@751
PS6, Line 751: threads.emplace_back([&] {
> What does the multithreading add here? Seems like it complicates things sin
The point is to ensure concurrent txn reads/writes have no failures with 
frequent leader elections. Add the comment to be clear.


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/integration-tests/txn_status_table-itest.cc@758
PS6, Line 758: if (s.ok()) {
> What failures are we expecting?
Add a comment


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/integration-tests/txn_status_table-itest.cc@748
PS6, Line 748:   std::atomic next_thread_id = 0;
 :   vector txn_id_index = { 1, 6, 11, 16, 21};
 :   for (int t = 0; t < 5; t++) {
 : threads.emplace_back([&] {
 :   int thread_id = next_thread_id++;
 :   CHECK_LT(thread_id, txn_id_index.size());
 :   int start_txn_id = txn_id_index[thread_id];
 :   for (int i = start_txn_id; i < start_txn_id + 5; i++) {
 : TxnStatusEntryPB txn_status;
 : Status s = txn_sys_client_->BeginTransaction(i, kUser);
 : if (s.ok()) {
 :   // Make sure a re-election happens before the 
following read.
 :   SleepFor(MonoDelta::FromMilliseconds(3 * 
FLAGS_raft_heartbeat_interval_ms));
 :   s = txn_sys_client_->GetTransactionStatus(i, kUser, 
_status);
 :   CHECK_OK(s);
 :   CHECK(txn_status.has_user());
 :   CHECK_STREQ(kUser, txn_status.user().c_str());
 :   CHECK(txn_status.has_state());
 :   CHECK_EQ(TxnStatePB::OPEN, txn_status.state());
 : }
 :   }
 : });
 :   }
> nit: would be easier to read as:
Done


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:

http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/tablet/tablet_replica.cc@403
PS6, Line 403: <<
> nit: maybe add a message here too indicating what's going on
Done


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/tablet/tablet_replica.cc@472
PS6, Line 472: LOG(WARNING) << Substitute("The tablet is already shutting down 
or shutdown. State: $0",
 :TabletStatePB_Name(state_));
> nit: might be cleaner to let the callers of these otherwise simple function
Done


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/tablet/tablet_replica.cc@979
PS6, Line 979:   if (!txn_coordinator_) {
 : return false;
 :   }
> nit: maybe only call this if txn_coordinator_ is set and change this to a D
I updated the name to reflect the functionality which is 
ShouldRunTxnCoordinatorStalenessTask(). So keep it as it is here.


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/tablet/tablet_replica.cc@997
PS6, Line 997: state_ == STOPPING || state_ == STOPPED) {
> nit: I'm curious, why not reuse the != RUNNING condition from above? A comm
Added a comment.


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/transactions/txn_status_manager.h
File src/kudu/transactions/txn_status_manager.h:

http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/transactions/txn_status_manager.h@109
PS6, Line 109: but some operations
 : // may still be legal.
> I might be missing something but is this fact used anywhere? What operation
Sorry this is not used, removed it.


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/transactions/txn_status_manager.h@106
PS6, Line 106: const Status& replica_status() const { return 
replica_status_; }
 :
 : // Leadership status of the transaction status manager. If 
not OK, the
 : // transaction status manager is not the leader, but some 
operations
 : // may still be legal.
 : const Status& leader_status() const {
 :   return leader_status_;
 : }
> nit: Are these ever used?
Done


http://gerrit.cloudera.org:8080/#/c/16648/6/src/kudu/transactions/txn_status_manager.h@118
PS6, Line 118: if (!replica_status_.ok()) {
 : return replica_status_;
  

[kudu-CR] KUDU-2612 Java client transaction API

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16894 )

Change subject: KUDU-2612 Java client transaction API
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb18e1ac0454a8ef9e3486430dfaa336e381e07
Gerrit-Change-Number: 16894
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 12 Jan 2021 20:15:49 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16648

to look at the new patch set (#6).

Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the 
leader only
..

KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/txn_manager-test.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
18 files changed, 769 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/6
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16648

to look at the new patch set (#5).

Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by 
the leader only
..

(wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
A src/2.patch
A src/3.patch
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/txn_manager-test.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
20 files changed, 2,011 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/5
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2612 Java client transaction API

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16894 )

Change subject: KUDU-2612 Java client transaction API
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@1181
PS2, Line 1181: let = Preconditions.c
> After thinking about this a bit more, I found that for asynchronous program
Yes, I was wondering why we have a blocking call in the class that was meant 
for async ones. Your suggestion make sense to me. Thanks a lot!



--
To view, visit http://gerrit.cloudera.org:8080/16894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb18e1ac0454a8ef9e3486430dfaa336e381e07
Gerrit-Change-Number: 16894
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 07 Jan 2021 00:39:39 +
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-2612 Java client transaction API

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16894 )

Change subject: WIP KUDU-2612 Java client transaction API
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@1181
PS2, Line 1181: This call is blocking
Would you mind explain a bit more about why it is blocking?



--
To view, visit http://gerrit.cloudera.org:8080/16894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb18e1ac0454a8ef9e3486430dfaa336e381e07
Gerrit-Change-Number: 16894
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 05 Jan 2021 20:07:01 +
Gerrit-HasComments: Yes

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16648 )

Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by 
the leader only
..


Patch Set 3:

(17 comments)

http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc
File src/kudu/tablet/tablet_replica.cc:

http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc@154
PS1, Line 154:*meta_->table_type() == 
TableTypePB::TXN_STATUS_TABLE ?
> Do we also need to call cb() here?
Yeah, good point, I don't see reasons not to,  added it.


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc@147
PS1, Line 147:   cmeta_manager_(DCHECK_NOTNULL(std::move(cmeta_manager))),
 :   local_peer_pb_(std::move(local_peer_pb)),
 :   log_anchor_registry_(new LogAnchorRegistry()),
 :   apply_pool_(apply_pool),
 :   
reload_txn_status_tablet_pool_(reload_txn_status_tablet_pool),
 :   shutdown_latch_(shutdown_latch),
 :   txn_coordinator_(meta_->table_type() &&
 :*meta_->table_type() == 
TableTypePB::TXN_STATUS_TABLE ?
 :DCHECK_NOTNULL(txn_
> FWIW I think this would be more plumbing that it's worth.
Agree with Andrew on this. Alexey, let me know if you think otherwise


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc@302
PS1, Line 302: PREFIX(WA
> nit: why does this need to be a lambda?
Just want to be clear this is for leadership change cb, but I guess it is a bit 
redundant. Removed.


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tablet/tablet_replica.cc@302
PS1, Line 302: LOG_WITH_PREFIX(WARNIN
> Just curious: is this going to be called if leadership status hasn't change
Right, this is going to be called for any leadership status change, even though 
the former leader can wins the latest election again. As we discussed offline, 
it is not clear what the performance implication will be, so adding a TODO in 
case we think optimization of not reloading the metadata for this case.


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.h
File src/kudu/transactions/txn_status_manager.h:

http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.h@95
PS1, Line 95: explicit ScopedLeaderSharedLock(TxnStatusManager* txn_status);
> warning: invalid case style for parameter 'txn_status_' [readability-identi
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc
File src/kudu/transactions/txn_status_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@62
PS1, Line 62: 
DEFINE_int32(txn_status_manager_inject_latency_load_from_tablet_ms, 0,
> warning: using decl 'CoordinateTransactionResponsePB' is unused [misc-unuse
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@83
PS1, Line 83:
> nit: construction
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@189
PS1, Line 189:
> nit: remove extra slashes?
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@300
PS1, Line 300:   if (consensus->role() != RaftPeerPB::LEADER) {
> warning: missing username/bug in TODO [google-readability-todo]
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@324
PS1, Line 324:   
RETURN_NOT_OK(status_tablet_.tablet_replica_->op_tracker()->WaitForAllToFinish(timeout));
> warning: the parameter 'func' is copied for each invocation but only used a
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@347
PS1, Line 347: return Status::NotAuthoriz
> nit: you can use __builtin_unreachable()
Done


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/transactions/txn_status_manager.cc@357
PS1, Line 357: table
> nit: This gets used once -- why does it need to be a lambda?
Hmm, since 'check' expects 'std::function', what do you suggest 
instead of using lambda?


http://gerrit.cloudera.org:8080/#/c/16648/2/src/kudu/transactions/txn_status_manager.cc
File src/kudu/transactions/txn_status_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16648/2/src/kudu/transactions/txn_status_manager.cc@202
PS2, Line 202: return;
> What happens if an instance of this lock is being constructed and the table
Right, updated the code to ensure the lock is only hold for tablet replica that 
is fully started as Andrew suggested.


http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16648/1/src/kudu/tserver/ts_tablet_manager.cc@386
PS1, Line 386: disks

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16648

to look at the new patch set (#3).

Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by 
the leader only
..

(wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

wip: txn_status_manager-itest is flaky. Add more comments.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/txn_manager-test.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
16 files changed, 763 insertions(+), 146 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/3
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [rpc] weak ptr for Messenger in RpcRetrier

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16866 )

Change subject: [rpc] weak_ptr for Messenger in RpcRetrier
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG@12
PS1, Line 12: retries
> The dist-test run at http://dist-test.cloudera.org/job?job_id=jenkins-slave
Got it, thanks a lot for the explanation!



--
To view, visit http://gerrit.cloudera.org:8080/16866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I399eef35341c4c9e90d91b1e461302a985d8f283
Gerrit-Change-Number: 16866
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 29 Dec 2020 20:22:14 +
Gerrit-HasComments: Yes

[kudu-CR] [rpc] weak ptr for Messenger in RpcRetrier

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16866 )

Change subject: [rpc] weak_ptr for Messenger in RpcRetrier
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG@12
PS1, Line 12: retries
> In general, yes.  However, while doing so, it might try to access some fiel
Sorry, a bit confused here, is the dist test you linked for this patch? If so, 
it seems it introduced some flakiness?



--
To view, visit http://gerrit.cloudera.org:8080/16866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I399eef35341c4c9e90d91b1e461302a985d8f283
Gerrit-Change-Number: 16866
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 19:50:09 +
Gerrit-HasComments: Yes

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16648

to look at the new patch set (#2).

Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by 
the leader only
..

(wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

wip: fix the flaky tests.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/txn_manager-test.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
16 files changed, 617 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/2
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [doc] add a note about KUDU-3217 into known issues

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16889 )

Change subject: [doc] add a note about KUDU-3217 into known issues
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8fe02e337d62539d30ae4f22377e150b344392
Gerrit-Change-Number: 16889
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Liliana Kadar 
Gerrit-Comment-Date: Sat, 19 Dec 2020 03:39:59 +
Gerrit-HasComments: No

[kudu-CR] rpc: fix non-retriable error when starting up or shutting down

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16876 )

Change subject: rpc: fix non-retriable error when starting up or shutting down
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2379de4cf632d257b93cd701d7c73cb2bbaed
Gerrit-Change-Number: 16876
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 20:10:28 +
Gerrit-HasComments: No

[kudu-CR] Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16852 )

Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK
..


Patch Set 1: Code-Review+1

(1 comment)

I verified the broken tests are fixed with this patch with osx 10.5.7 and 
Xcode12.

http://gerrit.cloudera.org:8080/#/c/16852/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16852/1//COMMIT_MSG@13
PS1, Line 13: using
nit: use



--
To view, visit http://gerrit.cloudera.org:8080/16852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137
Gerrit-Change-Number: 16852
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 11 Dec 2020 04:13:02 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for C++ client

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16779 )

Change subject: KUDU-2612 keep-alive txn heartbeating for C++ client
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG@14
PS3, Line 14: goes
: out of scope.  In contrast, if the transaction handle is created 
by
: KuduTransaction::Deserialize(), the keepalive messages are or 
aren't
> As you can see, the default behavior for KuduTransactionSerializer does exa
Hmm, yeah, I think that should be sufficient.



--
To view, visit http://gerrit.cloudera.org:8080/16779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0283d8e16908f641388f7a30b513a672df27a186
Gerrit-Change-Number: 16779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 08 Dec 2020 21:30:18 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for C++ client

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16779 )

Change subject: KUDU-2612 keep-alive txn heartbeating for C++ client
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG@14
PS3, Line 14: goes
: out of scope.  In contrast, if the transaction handle is created 
by
: KuduTransaction::Deserialize(), the keepalive messages are or 
aren't
> Yes, of course it's possible to have two actors sending keepalive messages
Thanks for the explanation! Makes sense. In this case maybe it is worth to call 
out explicitly somewhere in the doc that 'it's preferable to keep the number as 
low as possible to put less load on the cluster as possible' ?



--
To view, visit http://gerrit.cloudera.org:8080/16779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0283d8e16908f641388f7a30b513a672df27a186
Gerrit-Change-Number: 16779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 08 Dec 2020 19:49:08 +
Gerrit-HasComments: Yes

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16814 )

Change subject: [tserver] KUDU-2612: participant op RPC endpoint
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48895438ce67e453d235934ac560efe8415921b
Gerrit-Change-Number: 16814
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Dec 2020 07:51:27 +
Gerrit-HasComments: No

[kudu-CR] [tserver] KUDU-2612: participant op RPC endpoint

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16814 )

Change subject: [tserver] KUDU-2612: participant op RPC endpoint
..


Patch Set 4: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48895438ce67e453d235934ac560efe8415921b
Gerrit-Change-Number: 16814
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Dec 2020 07:51:15 +
Gerrit-HasComments: No

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16815 )

Change subject: [txn] update not-a-leader retry logic in TxnSystemClient
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59
Gerrit-Change-Number: 16815
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Dec 2020 07:40:19 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2612 keep-alive txn heartbeating for C++ client

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16779 )

Change subject: KUDU-2612 keep-alive txn heartbeating for C++ client
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG@14
PS3, Line 14: goes
: out of scope.  In contrast, if the transaction handle is created 
by
: KuduTransaction::Deserialize(), the keepalive messages are or 
aren't
Can it happen that the original txn handle doesn't go out of scope and another 
node create a txn handle by Deserialize() the original txn handle with keep 
alive enabled? If possible, do you think there is problem that both sending 
keepalive message?


http://gerrit.cloudera.org:8080/#/c/16779/3/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/16779/3/src/kudu/client/client.h@485
PS3, Line 485: ring topology
Just curious, do you know any applications (that integrate with Kudu or not) 
are using this model?


http://gerrit.cloudera.org:8080/#/c/16779/3/src/kudu/client/transaction-internal.h
File src/kudu/client/transaction-internal.h:

http://gerrit.cloudera.org:8080/#/c/16779/3/src/kudu/client/transaction-internal.h@66
PS3, Line 66: The 'status' parameter is to
nit: unfinished?



--
To view, visit http://gerrit.cloudera.org:8080/16779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0283d8e16908f641388f7a30b513a672df27a186
Gerrit-Change-Number: 16779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 08 Dec 2020 07:36:43 +
Gerrit-HasComments: Yes

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16815 )

Change subject: [txn] update not-a-leader retry logic in TxnSystemClient
..


Patch Set 2:

(1 comment)

Overall looks good to me.

http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc
File src/kudu/transactions/coordinator_rpc.cc:

http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc@188
PS2, Line 188:   if (result.status.IsAborted()) {
> Should we also be handling IllegalState? E.g. if we change leaders as we ar
+1



--
To view, visit http://gerrit.cloudera.org:8080/16815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59
Gerrit-Change-Number: 16815
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Dec 2020 01:19:02 +
Gerrit-HasComments: Yes

[kudu-CR] tablet: allow interleaving of row liveness between compaction input rows

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16752 )

Change subject: tablet: allow interleaving of row liveness between compaction 
input rows
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16752/2/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:

http://gerrit.cloudera.org:8080/#/c/16752/2/src/kudu/tablet/compaction.cc@318
PS2, Line 318: //   UNDO(del@5) <- BASE(a) -> REDO(del@10) -> REDO(reins@25)  
// main MRS
 : //   UNDO(del@15) <- BASE(a) -> REDO(del@20)   
// txn MRS
Wondering what will happen if
 UNDO(del@5) <- BASE(a) -> REDO(del@10) -> REDO(reins@25)  ->REDO(del@35) 
// main MRS
 UNDO(del@15) <- BASE(a) -> REDO(del@20) -> REDO(reins@40)   ->REDO(del@45) 
   // txn MRS
it will be transferred to the following?
UNDO(del@15) <- BASE(a) -> REDO(del@20) -> REDO(reins@25)  ->REDO(del@35)-> 
REDO(reins@40)   ->REDO(del@45)// txn MRS
   UNDO(del@5) <- BASE(a) -> REDO(del@10)  // main MRS


http://gerrit.cloudera.org:8080/#/c/16752/2/src/kudu/tablet/compaction.cc@390
PS2, Line 390: For instance this is a valid history with non-disjoint REDO 
histories
Just for my own understanding, wondering when this happen if all the ops are 
not in the same txn?


http://gerrit.cloudera.org:8080/#/c/16752/2/src/kudu/tablet/compaction.cc@453
PS2, Line 453: TransferRedoHistory
It seems for all REDOs in the 'older' that are greater than the REDO head of 
'newer' will be transferred to the end of the 'newer' REDO. What if there is a 
overlapped between the transferred REDOs and the 'newer' REDO? e.g.
 UNDO(del@5) <- BASE(a) -> REDO(del@10) -> REDO(reins@25)  ->REDO(del@35) 
// main MRS
 UNDO(del@15) <- BASE(a) -> REDO(del@20) -> REDO(reins@40)   ->REDO(del@45) 
   // txn MRS
will be transferred to the following?
UNDO(del@15) <- BASE(a) -> REDO(del@20) -> REDO(reins@40)  ->REDO(del@45) 
-> REDO(reins@25)  ->REDO(del@35) // txn MRS

Do you think it is a valid example?Will it matter if the 'newer' REDO is out of 
sequence?



--
To view, visit http://gerrit.cloudera.org:8080/16752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042a7d70d32edf9d2a3a077790821893f162880a
Gerrit-Change-Number: 16752
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 08 Dec 2020 01:00:05 +
Gerrit-HasComments: Yes

[kudu-CR] client: allow tablet ID lookups from the MetaCache

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16794 )

Change subject: client: allow tablet ID lookups from the MetaCache
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.h@427
PS3, Line 427: LookupTabletById
nit: add a comment?


http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc@92
PS3, Line 92: client_tablet_locations_by_id_ttl_ms
Sorry, not directly related to your change, but do you think such flag makes 
sense for cache by key as well?


http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc@662
PS3, Line 662: Status new_status = status;
 :   if (RetryOrReconnectIfNecessary(_status)) {
 : ignore_result(delete_me.release());
 : return;
 :   }
 :   // Check for more application errors.
 :   // Note: RetryOrReconnectIfNecessary only checked for generic 
application
 :   // errors. This check is specific to LookupRpcById.
 :   if (new_status.ok() && resp_.has_error()) {
 : new_status = StatusFromPB(resp_.error().status());
 : if (new_status.IsServiceUnavailable()) {
 :   // One or more of the tablets is not running. Retry after 
some time.
 :   mutable_retrier()->DelayedRetry(this, new_status);
 :   ignore_result(delete_me.release());
 :   return;
 : }
 :   }
This seems dup with LookupRpc::SendRpcCb, do you think it is worth to 
generalize the common code?



--
To view, visit http://gerrit.cloudera.org:8080/16794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2333add5c3ab8403c48e69d29c90f3aec0914b6
Gerrit-Change-Number: 16794
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 02 Dec 2020 23:37:06 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: persist commit MVCC op timestamp in txn metadata

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16569 )

Change subject: KUDU-2612: persist commit MVCC op timestamp in txn metadata
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/txn_participant-test.cc
File src/kudu/tablet/txn_participant-test.cc:

http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/txn_participant-test.cc@614
PS2, Line 614: // One anchor should be gone and another should be registered in 
its place
 :   // that lasts until we flush the finalized metadata.
 :   ASSERT_EQ(2, 
tablet_replica_->log_anchor_registry()->GetAnchorCountForTests());
> There were previously two anchors. We removed one, and added one, so we're
Ack



--
To view, visit http://gerrit.cloudera.org:8080/16569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2400fbb7e96ddba78544a9549965fc095e32ca3
Gerrit-Change-Number: 16569
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 29 Oct 2020 01:18:25 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: persist commit MVCC op timestamp in txn metadata

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16569 )

Change subject: KUDU-2612: persist commit MVCC op timestamp in txn metadata
..

KUDU-2612: persist commit MVCC op timestamp in txn metadata

We previously didn't persist the MVCC op timestamp used for the
BEGIN_COMMIT op. This was problematic, as this timestamp is necessary to
determine relevancy upon iteration.

This adds the timestamp to the TxnMetadata, and ensures that we anchor
the BEGIN_COMMIT op until we flush metadata, as we do with other
persistent participant op state.

Change-Id: Ib2400fbb7e96ddba78544a9549965fc095e32ca3
Reviewed-on: http://gerrit.cloudera.org:8080/16569
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao 
---
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/ops/participant_op.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
9 files changed, 180 insertions(+), 9 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/16569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2400fbb7e96ddba78544a9549965fc095e32ca3
Gerrit-Change-Number: 16569
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2612: persist commit MVCC op timestamp in txn metadata

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16569 )

Change subject: KUDU-2612: persist commit MVCC op timestamp in txn metadata
..


Patch Set 2: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/metadata.proto
File src/kudu/tablet/metadata.proto:

http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/metadata.proto@100
PS2, Line 100: When iterating through mutations at the latest snapshot (as in
 :   // READ_LATEST or during compactions), this MVCC op timestamp 
must be
 :   // applied and there must be a commit timestamp for the 
mutation to be
 :   // considered committed.
Maybe nice to point out this is to avoid dirty reads?


http://gerrit.cloudera.org:8080/#/c/16569/1/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:

http://gerrit.cloudera.org:8080/#/c/16569/1/src/kudu/tablet/tablet_metadata.cc@817
PS1, Line 817: if we are bootstrapping
> This happens when we are bootstrapping and replay a BEGIN_COMMIT op, since
Ack


http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/txn_participant-test.cc
File src/kudu/tablet/txn_participant-test.cc:

http://gerrit.cloudera.org:8080/#/c/16569/2/src/kudu/tablet/txn_participant-test.cc@614
PS2, Line 614: // One anchor should be gone and another should be registered in 
its place
 :   // that lasts until we flush the finalized metadata.
 :   ASSERT_EQ(2, 
tablet_replica_->log_anchor_registry()->GetAnchorCountForTests());
The comment doesn't seem to match the checking? Why not 'ASSERT_EQ(1, ...)'



--
To view, visit http://gerrit.cloudera.org:8080/16569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2400fbb7e96ddba78544a9549965fc095e32ca3
Gerrit-Change-Number: 16569
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 23:07:38 +
Gerrit-HasComments: Yes

[kudu-CR] Remove redundant code in TabletReplica

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16647 )

Change subject: Remove redundant code in TabletReplica
..

Remove redundant code in TabletReplica

Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Reviewed-on: http://gerrit.cloudera.org:8080/16647
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong 
Reviewed-by: Grant Henke 
---
M src/kudu/tablet/tablet_replica.h
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/16647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Gerrit-Change-Number: 16647
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [catalog manager] fix the typo in the comment for 'leader lock '

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16646 )

Change subject: [catalog manager] fix the typo in the comment for 'leader_lock_'
..

[catalog manager] fix the typo in the comment for 'leader_lock_'

Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce
Reviewed-on: http://gerrit.cloudera.org:8080/16646
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong 
Reviewed-by: Grant Henke 
---
M src/kudu/master/catalog_manager.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/16646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce
Gerrit-Change-Number: 16646
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16648


Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by 
the leader only
..

(wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

Currently, even though a non-leader TxnStatusManager will be unable to
write to the underlying table (in the Raft subsystem the write would be
aborted), we may want to restrict calls to be made by the leader
TxnStatusManagers only. The motivation is to provide a more robust system,
which avoids cases when the request was sent to a laggy follower, we may
end up failing the request with an error.

This patch introduces ScopedLeaderSharedLock (similar to the one in Catalog
Manager) to be used to ensure the requests were sent to leaders only and
to block all other operations while reloading the persistent transaction
status metadata upon leadership changes. Note that during failover the
leader replica will wait until in-flight ops in the previous consensus
term to be applied before reloading the metadata.

wip: add more tests.

Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
---
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
13 files changed, 398 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16648/1
--
To view, visit http://gerrit.cloudera.org:8080/16648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] [catalog manager] fix the typo in the comment for 'leader lock '

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16646


Change subject: [catalog manager] fix the typo in the comment for 'leader_lock_'
..

[catalog manager] fix the typo in the comment for 'leader_lock_'

Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce
---
M src/kudu/master/catalog_manager.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/16646/1
--
To view, visit http://gerrit.cloudera.org:8080/16646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09152727d079e1eb3c4afe9eb13181c43c9331ce
Gerrit-Change-Number: 16646
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] Remove redundant code in TabletReplica

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16647


Change subject: Remove redundant code in TabletReplica
..

Remove redundant code in TabletReplica

Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
---
M src/kudu/tablet/tablet_replica.h
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16647/1
--
To view, visit http://gerrit.cloudera.org:8080/16647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Gerrit-Change-Number: 16647
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] KUDU-2612: C++ client sets txn id in WriteRequestPB

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16625 )

Change subject: KUDU-2612: C++ client sets txn_id in WriteRequestPB
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60cb0ea8066e2c6417ebe4b2a24aff3512b44f1
Gerrit-Change-Number: 16625
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 23 Oct 2020 00:24:43 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2612: have MRS iteration account for txn metadata

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16510 )

Change subject: KUDU-2612: have MRS iteration account for txn metadata
..


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@12
PS6, Line 12: TxnMetadata in the MRS
> Right, there will be 1 MRS per transaction. This will make it easier to com
Ack


http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@14
PS6, Line 14: relevancy
> I'm not sure what this is asking, but relevancy is a term used in scanning
Sorry for the confusion, and yes, that is what I was asking, thanks!


http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc.h
File src/kudu/tablet/mvcc.h:

http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc.h@101
PS6, Line 101: If the commit MVCC op finished applying, the commit process is
 :   // complete,
> Here's a summary of the commit process: https://gerrit.cloudera.org/c/16470
Thanks a lot for the pointer.



--
To view, visit http://gerrit.cloudera.org:8080/16510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb02c6025eea1a327cf9d9ee1f14a38d63ae4ad
Gerrit-Change-Number: 16510
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 20 Oct 2020 05:09:16 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: persist commit MVCC op timestamp in txn metadata

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16569 )

Change subject: KUDU-2612: persist commit MVCC op timestamp in txn metadata
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16569/1/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:

http://gerrit.cloudera.org:8080/#/c/16569/1/src/kudu/tablet/tablet_metadata.cc@817
PS1, Line 817: if we are bootstrapping
Wondering In which cases the mvcc op for a txn can be already persisted but the 
txn hasn't begin commit?



--
To view, visit http://gerrit.cloudera.org:8080/16569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2400fbb7e96ddba78544a9549965fc095e32ca3
Gerrit-Change-Number: 16569
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 20:19:22 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: have MRS iteration account for txn metadata

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16510 )

Change subject: KUDU-2612: have MRS iteration account for txn metadata
..


Patch Set 6:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@12
PS6, Line 12: TxnMetadata in the MRS
Wondering is TxnMetadata and MRS  is  a 1 to 1 mapping? It seems so, by reading 
the code, but not sure why? Each MRS is only associate with one txn?


http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@14
PS6, Line 14: relevancy
Is relevancy is in terms of scan?


http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@35
PS6, Line 35: waiting
waits


http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset.h
File src/kudu/tablet/memrowset.h:

http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset.h@367
PS6, Line 367: of
nit: remove?


http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc-test.cc
File src/kudu/tablet/mvcc-test.cc:

http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc-test.cc@830
PS6, Line 830: MvccSnapshot initial_snap(initial_ts)
IIUC, the initial snapshot type is kLatest, sorry I miss where in the test it 
is set to kTimestamp?


http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc.h
File src/kudu/tablet/mvcc.h:

http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc.h@101
PS6, Line 101: If the commit MVCC op finished applying, the commit process is
 :   // complete,
Sorry, but I miss the part how do we make sure the mvcc op is not applied until 
the commit process finished?


http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/txn_metadata.h
File src/kudu/tablet/txn_metadata.h:

http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/txn_metadata.h@84
PS6, Line 84: mutable simple_spinlock lock_;
Can you add a comment on which resource the lock is protecting?


http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/txn_metadata.h@89
PS6, Line 89: commit_mvcc_op_timestamp_
If I understand correctly, this is BEGIN_COMMIT mvcc op? If so, do you think we 
should be clear about it somewhere in the comment? Either in the TxnMetadataPB 
or here?



--
To view, visit http://gerrit.cloudera.org:8080/16510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb02c6025eea1a327cf9d9ee1f14a38d63ae4ad
Gerrit-Change-Number: 16510
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 19 Oct 2020 06:57:19 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Fixes for JDK 12 to 15

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16600 )

Change subject: [java] Fixes for JDK 12 to 15
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie992d089a06e8d4afecda39a234e19a45730381e
Gerrit-Change-Number: 16600
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:45:22 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2612: initial implementation of TxnManager

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16527 )

Change subject: KUDU-2612: initial implementation of TxnManager
..


Patch Set 7: Code-Review+2

(6 comments)

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/master.cc
File src/kudu/master/master.cc:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/master.cc@103
PS5, Line 103: ecurity::TokenSigner;
> I guess for real world scenarios in clusters which use transactions we shou
Ack


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/master.cc@319
PS5, Line 319: //wake up a long-awaiting task and retry 
initialization
 : //right away when TxnManager receives a call.
 : static const MonoDelta kRetryInterval = 
MonoDelta::FromSeconds(1);
 : KLOG_EVERY_N_SECS(WARNING
> TxnManager cannot complete initialization without tablet servers which host
Ack


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.h
File src/kudu/master/txn_manager.h:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.h@102
PS5, Line 102: // Whether or not this instance is lazily initializ
> There is nothing specific about this, it's just a random number so far.  I
Ack


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.cc
File src/kudu/master/txn_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.cc@49
PS5, Line 49: For Kudu clusters which use transactions we should prefer non-laz
> It happens in case of RPC-level errors.
Ack


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.cc@127
PS5, Line 127:  const string& username,
 :  co
> The header has similar comment as well.  I put this comment here as well fo
Ack


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.proto
File src/kudu/master/txn_manager.proto:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.proto@94
PS5, Line 94: ime
> I replaced the whole sentence with 'The transaction state at the time of pr
Ack



--
To view, visit http://gerrit.cloudera.org:8080/16527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie952977a3ae5f625d1283389f0be8afb79df7d8c
Gerrit-Change-Number: 16527
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:13:20 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612: initial implementation of TxnManager

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16527 )

Change subject: KUDU-2612: initial implementation of TxnManager
..


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/master.cc
File src/kudu/master/master.cc:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/master.cc@103
PS5, Line 103: Whether to initialize TxnManager upon arrival of first request.
Wondering how to decide if TxnManager should be initialized upon arrival of 
first request or the other?


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/master.cc@319
PS5, Line 319: KLOG_EVERY_N_SECS(WARNING, 60) << Substitute(
 : "$0: unable to init TxnManager, will retry in $1",
 : s.ToString(), retry_interval.ToString());
 : SleepFor(retry_interval);
Why do we want to retry the initialization, but not as what catalog manager is 
doing which don't retry?


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.h
File src/kudu/master/txn_manager.h:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.h@102
PS5, Line 102: static constexpr int64_t kTxnTableRangeStep = 1024;
Can you add a comment to explain why 1024 is chosen?


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.cc
File src/kudu/master/txn_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.cc@49
PS5, Line 49: If 's' is not OK and 'resp' has no application specific error set
Do you know in which cases this will happen?


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.cc@127
PS5, Line 127: // This method isn't supposed to be called concurrently, so 
there isn't any
 : // protection against concurrent calls.
Should this be moved to the method declaration of the header.


http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.proto
File src/kudu/master/txn_manager.proto:

http://gerrit.cloudera.org:8080/#/c/16527/5/src/kudu/master/txn_manager.proto@94
PS5, Line 94: was
nit: was OK?



--
To view, visit http://gerrit.cloudera.org:8080/16527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie952977a3ae5f625d1283389f0be8afb79df7d8c
Gerrit-Change-Number: 16527
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 13 Oct 2020 18:59:56 +
Gerrit-HasComments: Yes

[kudu-CR] mini ranger: fix typo in error message

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16579 )

Change subject: mini_ranger: fix typo in error message
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78af12220745d8d6b3894b34e1f4bac55f24d7a3
Gerrit-Change-Number: 16579
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 11 Oct 2020 04:48:45 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2612 p5 (b): add highest seen txn id into CoordinatorOpResultPB

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16526 )

Change subject: KUDU-2612 p5 (b): add highest_seen_txn_id into 
CoordinatorOpResultPB
..


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16526/3/src/kudu/transactions/txn_status_manager.cc
File src/kudu/transactions/txn_status_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16526/3/src/kudu/transactions/txn_status_manager.cc@164
PS3, Line 164:   // Always set the 'highest_seen_txn_id' on return.
 :   SCOPED_CLEANUP({
 : if (highest_seen_txn_id) {
 :   std::lock_guard l(lock_);
 :   *highest_seen_txn_id = highest_txn_id_;
 : }
 :   });
> OK sounds reasonable, particularly with concurrent activity. My main concer
Sounds good to me, would you mind adding more to the comment to explain the 
motivation? Thanks!



--
To view, visit http://gerrit.cloudera.org:8080/16526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcb4d90bc10a5695c3f54229688ccdcaf56011d0
Gerrit-Change-Number: 16526
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 07 Oct 2020 23:02:03 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16537 )

Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
..


Patch Set 4: Code-Review+2

LGTM, although the approach of ensure the tablet metadata is loaded may change 
with the TxnStatusManager leadership calls only patch I am working on.


--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2020 19:45:53 +
Gerrit-HasComments: No

[kudu-CR] [catalog manager] Status::AlreadyPresent for range duplicates

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16544 )

Change subject: [catalog_manager] Status::AlreadyPresent for range duplicates
..


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16544/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16544/2//COMMIT_MSG@16
PS2, Line 16: Before this patch, CatalogManager returned 
Status::InvalidArgument()
: for exact duplicates and otherwise overlapped ranges as well.
> Right -- in case of exact range match the client will now get Status::Alrea
Ok, sounds good to me as long as we document it in the release notes.



--
To view, visit http://gerrit.cloudera.org:8080/16544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c1b821f3bd6854c06682ae3c85a058665f1489
Gerrit-Change-Number: 16544
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Comment-Date: Tue, 06 Oct 2020 18:17:37 +
Gerrit-HasComments: Yes

[kudu-CR] [catalog manager] Status::AlreadyPresent for range duplicates

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16544 )

Change subject: [catalog_manager] Status::AlreadyPresent for range duplicates
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16544/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16544/2//COMMIT_MSG@16
PS2, Line 16: Before this patch, CatalogManager returned 
Status::InvalidArgument()
: for exact duplicates and otherwise overlapped ranges as well.
Seems client will expect to see different error status being returned before 
and after the change. Wondering do you foresee will this raise any 
compatibility concerns?



--
To view, visit http://gerrit.cloudera.org:8080/16544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c1b821f3bd6854c06682ae3c85a058665f1489
Gerrit-Change-Number: 16544
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Comment-Date: Mon, 05 Oct 2020 22:52:02 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3192: [hms] Leverage the cluster ID in HMS sync

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16494 )

Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/hms/hms_catalog.h
File src/kudu/hms/hms_catalog.h:

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/hms/hms_catalog.h@66
PS1, Line 66:  // Creates a new table entry in the HMS.
:   //
:   // If 'owner' is omitted the table will be created without an 
owner. This is
:   // useful in circumstances where the owner is not known, for 
example when
:   // creating an HMS table entry for an existing Kudu table.
:   //
:   // Fails the HMS is unreachable, or a table with the same name 
is already present.
nit: update the comment with the cluster_id? The same for other similar methods.


http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc
File src/kudu/master/hms_notification_log_listener.cc:

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc@356
PS1, Line 356: This is safe because we still validate the table ID
 :   // which is universally unique
Does it mean the table ID will never be the same even in across different 
clusters?


http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/tools/tool_action_hms.cc@245
PS1, Line 245: row.resize
nit: samer here.


http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/tools/tool_action_hms.cc@256
PS1, Line 256: adjust row.resize below
nit: adjust 'row.resize' below.



--
To view, visit http://gerrit.cloudera.org:8080/16494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17
Gerrit-Change-Number: 16494
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 24 Sep 2020 22:11:20 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2612 p10: have timestamp assignment account for commit timestamps

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16470 )

Change subject: KUDU-2612 p10: have timestamp assignment account for commit 
timestamps
..


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/consensus/time_manager.h
File src/kudu/consensus/time_manager.h:

http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/consensus/time_manager.h@71
PS2, Line 71: queue
Can you clarify which queue this is referring to?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/consensus/time_manager.h@71
PS2, Line 71: i.e.
: // AdvanceSafeTimeWithMessage() hasn't been called on the 
corresponding
: // message)
Wondering when this can happen?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/consensus/time_manager.h@79
PS2, Line 79: leader lease
Do you plan to address this in future patch?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/consensus/time_manager.h@94
PS2, Line 94: the MVCC op registered for BEGIN_COMMIT is not
: //   finished when the op is applied
Does this mean even when the op is applied it is not visible to the user inside 
the transaction?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/consensus/time_manager.h@97
PS2, Line 97: Until the MVCC op is completed below, further snapshot scans at t 
where
: // t > T_bc will block
Will other concurrent transaction be blocked as well waiting for a timestamp be 
assigned?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/tablet/ops/participant_op.h
File src/kudu/tablet/ops/participant_op.h:

http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/tablet/ops/participant_op.h@73
PS2, Line 73: Anchors the given 'op_id' in the WAL, ensuring that subsequent 
bootstraps
:   // of the tablet's WAL will leave the transaction in the 
appropriate state.
The comment needs to be updated?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/tablet/ops/participant_op.h@89
PS2, Line 89: void SetMvccOp(std::unique_ptr mvcc_op);
:   void ReleaseMvccOpToTxn();
Add a comment for these functions?


http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/tablet/txn_participant.h
File src/kudu/tablet/txn_participant.h:

http://gerrit.cloudera.org:8080/#/c/16470/2/src/kudu/tablet/txn_participant.h@227
PS2, Line 227: commit_op_
Add a short description for this?



--
To view, visit http://gerrit.cloudera.org:8080/16470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0412fd0cf778d96f3fe6b14624d8d06942f40e72
Gerrit-Change-Number: 16470
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Sep 2020 04:16:30 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16388 )

Change subject: KUDU-3187: Enhance the HMS plugin to check if synchronization 
is enabled
..


Patch Set 7: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File 
java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@164
PS1, Line 164: return
> I don't think we need to, this is drop table so it's not introducing proper
Ack


http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@172
PS1, Line 172: if (!isKuduTable(table)) {
 :   // However, make sure it doesn't have a table id from the 
context.
 :   // The table id is only meant for Kudu tables and set by 
the Kudu master.
 :
> This is the case when the drop table request doesn't have target table id i
Ack



--
To view, visit http://gerrit.cloudera.org:8080/16388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37
Gerrit-Change-Number: 16388
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Sep 2020 21:56:25 +
Gerrit-HasComments: Yes

[kudu-CR] WIP - KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16388 )

Change subject: WIP - KUDU-3187: Enhance the HMS plugin to check if 
synchronization is enabled
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File 
java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@128
PS1, Line 128: checkKuduProperties(table);
> Shouldn't we do this after checking whether HMS sync is enabled?
+1


http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@164
PS1, Line 164: return
Should we call checkNoKuduProperties here as well?


http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@172
PS1, Line 172: // If this request doesn't specify a Kudu table ID then allow it 
to proceed.
 : if (targetTableId == null) {
 :   return;
 : }
This case indicates that the table is a Kudu table but it does not has a table 
ID, right? Should this be a validate case? Or we should throw an exception to 
disallow Kudu table to not have an ID?



--
To view, visit http://gerrit.cloudera.org:8080/16388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37
Gerrit-Change-Number: 16388
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Sep 2020 00:26:37 +
Gerrit-HasComments: Yes

[kudu-CR] Upgrade docs/site building tools

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16371 )

Change subject: Upgrade docs/site building tools
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:54:09 +
Gerrit-HasComments: No

[kudu-CR] [docs] add a release step to update the previous release notes

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15969


Change subject: [docs] add a release step to update the previous release notes
..

[docs] add a release step to update the previous release notes

Change-Id: I5eb0f0443a16c92f5fe7810d46539312c7dc5be7
---
M RELEASING.adoc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/15969/1
--
To view, visit http://gerrit.cloudera.org:8080/15969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eb0f0443a16c92f5fe7810d46539312c7dc5be7
Gerrit-Change-Number: 15969
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15968


Change subject: release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1
..

release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1

Change-Id: Id747e39758180a9cf65749ff45c91c0d7b9dfd73
---
M docs/prior_release_notes.adoc
1 file changed, 334 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/15968/1
--
To view, visit http://gerrit.cloudera.org:8080/15968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id747e39758180a9cf65749ff45c91c0d7b9dfd73
Gerrit-Change-Number: 15968
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] [docs] add blog post announcement as part of a release

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15951 )

Change subject: [docs] add blog post announcement as part of a release
..

[docs] add blog post announcement as part of a release

Change-Id: I9bcb826f671ee7878b6e7a66ed9a77256847a153
Reviewed-on: http://gerrit.cloudera.org:8080/15951
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M RELEASING.adoc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bcb826f671ee7878b6e7a66ed9a77256847a153
Gerrit-Change-Number: 15951
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] use org.apache.kudu packages v1.12.0

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15953 )

Change subject: [examples] use org.apache.kudu packages v1.12.0
..

[examples] use org.apache.kudu packages v1.12.0

Change-Id: I988e48b3ffdd1fca016268a3d01dab2815e6eb3d
Reviewed-on: http://gerrit.cloudera.org:8080/15743
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
(cherry picked from commit e2acd00a3727b0c434e095855aaca49d2797b98d)
Reviewed-on: http://gerrit.cloudera.org:8080/15953
Reviewed-by: Grant Henke 
---
M examples/java/collectl/README.adoc
M examples/java/collectl/pom.xml
M examples/java/insert-loadgen/pom.xml
M examples/java/java-example/pom.xml
M examples/quickstart/nifi/README.adoc
M examples/quickstart/spark/README.adoc
M examples/scala/sbt-int-test-example/README.adoc
M examples/scala/sbt-int-test-example/build.sbt
M examples/scala/spark-example/pom.xml
9 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I988e48b3ffdd1fca016268a3d01dab2815e6eb3d
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) [version.txt] update version to 1.12.1-SNAPSHOT

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15952 )

Change subject: [version.txt] update version to 1.12.1-SNAPSHOT
..

[version.txt] update version to 1.12.1-SNAPSHOT

Change-Id: I1f78eb1aeb558684722d1c953a8ad9d16cbc3022
Reviewed-on: http://gerrit.cloudera.org:8080/15952
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
---
M version.txt
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/15952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f78eb1aeb558684722d1c953a8ad9d16cbc3022
Gerrit-Change-Number: 15952
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] fix incorrect branch name in README.adoc

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15949 )

Change subject: [docs] fix incorrect branch name in README.adoc
..

[docs] fix incorrect branch name in README.adoc

Change-Id: Ib2eafae07f00f44f8891531b4515fc0a59641413
Reviewed-on: http://gerrit.cloudera.org:8080/15949
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M README.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2eafae07f00f44f8891531b4515fc0a59641413
Gerrit-Change-Number: 15949
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] upgrade liquid version

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15950 )

Change subject: [docs] upgrade liquid version
..

[docs] upgrade liquid version

Current docs support scripts use liquid 3.0.6. which can cause the
following error:
  jekyll 3.6.3 | Error:  undefined method `to_date' for Liquid::Utils:Module

Upgrade the versio to be 4.0.0 as suggested in [1].

[1]: https://github.com/poole/hyde/issues/215

Change-Id: Ie5220a888b4bac482f11e908d892f5d3cfc58d3f
Reviewed-on: http://gerrit.cloudera.org:8080/15950
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M docs/support/scripts/Gemfile.lock
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5220a888b4bac482f11e908d892f5d3cfc58d3f
Gerrit-Change-Number: 15950
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](gh-pages) [site] add 1.12.0 release post

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15946 )

Change subject: [site] add 1.12.0 release post
..

[site] add 1.12.0 release post

Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
Reviewed-on: http://gerrit.cloudera.org:8080/15946
Reviewed-by: Grant Henke 
Tested-by: Grant Henke 
---
A _posts/2020-05-18-apache-kudu-1-12-0-release.md
1 file changed, 67 insertions(+), 0 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/15946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
Gerrit-Change-Number: 15946
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 

[kudu-CR] [examples] use org.apache.kudu packages v1.12.0

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15953


Change subject: [examples] use org.apache.kudu packages v1.12.0
..

[examples] use org.apache.kudu packages v1.12.0

Change-Id: I988e48b3ffdd1fca016268a3d01dab2815e6eb3d
Reviewed-on: http://gerrit.cloudera.org:8080/15743
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
(cherry picked from commit e2acd00a3727b0c434e095855aaca49d2797b98d)
---
M examples/java/collectl/README.adoc
M examples/java/collectl/pom.xml
M examples/java/insert-loadgen/pom.xml
M examples/java/java-example/pom.xml
M examples/quickstart/nifi/README.adoc
M examples/quickstart/spark/README.adoc
M examples/scala/sbt-int-test-example/README.adoc
M examples/scala/sbt-int-test-example/build.sbt
M examples/scala/spark-example/pom.xml
9 files changed, 14 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/15953/1
--
To view, visit http://gerrit.cloudera.org:8080/15953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I988e48b3ffdd1fca016268a3d01dab2815e6eb3d
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR](gh-pages) [site] add 1.12.0 release post

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15946 )

Change subject: [site] add 1.12.0 release post
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15946/1/_posts/2020-05-11-apache-kudu-1-12-0-release.md
File _posts/2020-05-11-apache-kudu-1-12-0-release.md:

PS1:
> I think we should date this post for today given that is when we are "annou
Done


http://gerrit.cloudera.org:8080/#/c/15946/1/_posts/2020-05-11-apache-kudu-1-12-0-release.md@66
PS1, Line 66:
> nit: add a comma after 'Additionally' ?
Done



--
To view, visit http://gerrit.cloudera.org:8080/15946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
Gerrit-Change-Number: 15946
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Mon, 18 May 2020 23:15:31 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] add 1.12.0 release post

[Hao Hao (Code Review)]

Hello Alexey Serbin, Grant Henke,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15946

to look at the new patch set (#2).

Change subject: [site] add 1.12.0 release post
..

[site] add 1.12.0 release post

Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
---
A _posts/2020-05-18-apache-kudu-1-12-0-release.md
1 file changed, 67 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/15946/2
--
To view, visit http://gerrit.cloudera.org:8080/15946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
Gerrit-Change-Number: 15946
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 

[kudu-CR](branch-1.12.x) [version.txt] update version to 1.12.1-SNAPSHOT

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15952


Change subject: [version.txt] update version to 1.12.1-SNAPSHOT
..

[version.txt] update version to 1.12.1-SNAPSHOT

Change-Id: I1f78eb1aeb558684722d1c953a8ad9d16cbc3022
---
M version.txt
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/15952/1
--
To view, visit http://gerrit.cloudera.org:8080/15952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f78eb1aeb558684722d1c953a8ad9d16cbc3022
Gerrit-Change-Number: 15952
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR](gh-pages) [site] update docs, apidocs and cpp-client-api links for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15948 )

Change subject: [site] update docs, apidocs and cpp-client-api links for Kudu 
1.12.0 release
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac62ce4bd29bb3b37fd6b1b8dcbab08278cc788
Gerrit-Change-Number: 15948
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Mon, 18 May 2020 22:56:09 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update docs, apidocs and cpp-client-api links for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15948 )

Change subject: [site] update docs, apidocs and cpp-client-api links for Kudu 
1.12.0 release
..

[site] update docs, apidocs and cpp-client-api links for Kudu 1.12.0 release

Change-Id: I0ac62ce4bd29bb3b37fd6b1b8dcbab08278cc788
Reviewed-on: http://gerrit.cloudera.org:8080/15948
Reviewed-by: Hao Hao 
Tested-by: Hao Hao 
---
M apidocs
M cpp-client-api
M docs
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/15948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ac62ce4bd29bb3b37fd6b1b8dcbab08278cc788
Gerrit-Change-Number: 15948
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 

[kudu-CR] [docs] add blog post announcement as part of a release

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15951


Change subject: [docs] add blog post announcement as part of a release
..

[docs] add blog post announcement as part of a release

Change-Id: I9bcb826f671ee7878b6e7a66ed9a77256847a153
---
M RELEASING.adoc
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/15951/1
--
To view, visit http://gerrit.cloudera.org:8080/15951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bcb826f671ee7878b6e7a66ed9a77256847a153
Gerrit-Change-Number: 15951
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] [docs] upgrade liquid version

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15950


Change subject: [docs] upgrade liquid version
..

[docs] upgrade liquid version

Current docs support scripts use liquid 3.0.6. which can cause the
following error:
  jekyll 3.6.3 | Error:  undefined method `to_date' for Liquid::Utils:Module

Upgrade the versio to be 4.0.0 as suggested in [1].

[1]: https://github.com/poole/hyde/issues/215

Change-Id: Ie5220a888b4bac482f11e908d892f5d3cfc58d3f
---
M docs/support/scripts/Gemfile.lock
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15950/1
--
To view, visit http://gerrit.cloudera.org:8080/15950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5220a888b4bac482f11e908d892f5d3cfc58d3f
Gerrit-Change-Number: 15950
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] [docs] fix incorrect branch name in README.adoc

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15949


Change subject: [docs] fix incorrect branch name in README.adoc
..

[docs] fix incorrect branch name in README.adoc

Change-Id: Ib2eafae07f00f44f8891531b4515fc0a59641413
---
M README.adoc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/15949/1
--
To view, visit http://gerrit.cloudera.org:8080/15949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2eafae07f00f44f8891531b4515fc0a59641413
Gerrit-Change-Number: 15949
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR](gh-pages) [site] update docs, apidocs and cpp-client-api links for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15948


Change subject: [site] update docs, apidocs and cpp-client-api links for Kudu 
1.12.0 release
..

[site] update docs, apidocs and cpp-client-api links for Kudu 1.12.0 release

Change-Id: I0ac62ce4bd29bb3b37fd6b1b8dcbab08278cc788
---
M apidocs
M cpp-client-api
M docs
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/15948/1
--
To view, visit http://gerrit.cloudera.org:8080/15948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ac62ce4bd29bb3b37fd6b1b8dcbab08278cc788
Gerrit-Change-Number: 15948
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR](gh-pages) [site] add 1.12.0 release post

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15946


Change subject: [site] add 1.12.0 release post
..

[site] add 1.12.0 release post

Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
---
A _posts/2020-05-11-apache-kudu-1-12-0-release.md
1 file changed, 67 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/15946/1
--
To view, visit http://gerrit.cloudera.org:8080/15946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: If84f8412fae3796ddb49fa48317bc9e0479a485e
Gerrit-Change-Number: 15946
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR](gh-pages) [site] add more docs for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15945 )

Change subject: [site] add more docs for Kudu 1.12.0 release
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: If7fa629219c77907d49371d1754103d6286677a2
Gerrit-Change-Number: 15945
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Mon, 18 May 2020 21:25:54 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] add more docs for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15945 )

Change subject: [site] add more docs for Kudu 1.12.0 release
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/15945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: If7fa629219c77907d49371d1754103d6286677a2
Gerrit-Change-Number: 15945
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Mon, 18 May 2020 21:25:56 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] add more docs for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15945 )

Change subject: [site] add more docs for Kudu 1.12.0 release
..

[site] add more docs for Kudu 1.12.0 release

Change-Id: If7fa629219c77907d49371d1754103d6286677a2
Reviewed-on: http://gerrit.cloudera.org:8080/15945
Reviewed-by: Hao Hao 
Tested-by: Hao Hao 
---
M releases/1.12.0/cpp-client-api/annotated.html
M releases/1.12.0/cpp-client-api/callbacks_8h_source.html
M releases/1.12.0/cpp-client-api/classKuduPartialRow-members.html
M releases/1.12.0/cpp-client-api/classKuduPartialRow.html
M releases/1.12.0/cpp-client-api/classes.html
M releases/1.12.0/cpp-client-api/classkudu_1_1MonoDelta-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1MonoDelta.html
M releases/1.12.0/cpp-client-api/classkudu_1_1MonoTime-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1MonoTime.html
M releases/1.12.0/cpp-client-api/classkudu_1_1Slice-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1Slice.html
M releases/1.12.0/cpp-client-api/classkudu_1_1Status-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1Status.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduBloomFilter-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduBloomFilter.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduBloomFilterBuilder-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduBloomFilterBuilder.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduClient-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduClient.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduClientBuilder-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduClientBuilder.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnSchema-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnSchema.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnSpec-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnSpec.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnStorageAttributes-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnStorageAttributes.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnTypeAttributes-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnTypeAttributes.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnarScanBatch-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduColumnarScanBatch.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduDelete-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduDelete.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduError-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduError.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduInsert-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduInsert.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduInsertIgnore-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduInsertIgnore.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduLoggingCallback-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduLoggingCallback.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduLoggingFunctionCallback-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduLoggingFunctionCallback.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduLoggingMemberCallback-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduLoggingMemberCallback.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduPartitioner-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduPartitioner.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduPartitionerBuilder-members.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduPartitionerBuilder.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduPredicate-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduPredicate.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduReplica-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduReplica.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduScanBatch-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduScanBatch.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduScanToken-members.html
M releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduScanToken.html
M 
releases/1.12.0/cpp-client-api/classkudu_1_1client_1_1KuduScanTokenBuilder-members.html
M 

[kudu-CR](branch-1.12.x) docs: add docs to orchestrate a rolling restart

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15943 )

Change subject: docs: add docs to orchestrate a rolling restart
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15943
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 May 2020 19:10:19 +
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) docs: add docs to orchestrate a rolling restart

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15943 )

Change subject: docs: add docs to orchestrate a rolling restart
..

docs: add docs to orchestrate a rolling restart

Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Reviewed-on: http://gerrit.cloudera.org:8080/15930
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Grant Henke 
(cherry picked from commit 161dec90a10aa96fcc1d2ad789743f6bb37e0d48)
Reviewed-on: http://gerrit.cloudera.org:8080/15943
Reviewed-by: Hao Hao 
---
M docs/administration.adoc
1 file changed, 35 insertions(+), 2 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/15943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15943
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) docs: add docs to orchestrate a rolling restart

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15943


Change subject: docs: add docs to orchestrate a rolling restart
..

docs: add docs to orchestrate a rolling restart

Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Reviewed-on: http://gerrit.cloudera.org:8080/15930
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Grant Henke 
(cherry picked from commit 161dec90a10aa96fcc1d2ad789743f6bb37e0d48)
---
M docs/administration.adoc
1 file changed, 35 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/15943/1
--
To view, visit http://gerrit.cloudera.org:8080/15943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I268928ccdf23863880349716b9e5a848a0e443bb
Gerrit-Change-Number: 15943
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 

[kudu-CR](branch-1.12.x) docs: mention how to decommission a tablet server using the rebalancer

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15942 )

Change subject: docs: mention how to decommission a tablet server using the 
rebalancer
..

docs: mention how to decommission a tablet server using the rebalancer

Change-Id: I6f90eb352c4dce6d200cec33dde91c4bdb4aa522
Reviewed-on: http://gerrit.cloudera.org:8080/15929
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Grant Henke 
(cherry picked from commit 3b60ddf1a3f039647db589aa641995cc81dd6857)
Reviewed-on: http://gerrit.cloudera.org:8080/15942
Reviewed-by: Hao Hao 
---
M docs/administration.adoc
1 file changed, 26 insertions(+), 7 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f90eb352c4dce6d200cec33dde91c4bdb4aa522
Gerrit-Change-Number: 15942
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) docs: mention how to decommission a tablet server using the rebalancer

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15942 )

Change subject: docs: mention how to decommission a tablet server using the 
rebalancer
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f90eb352c4dce6d200cec33dde91c4bdb4aa522
Gerrit-Change-Number: 15942
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 May 2020 19:09:48 +
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) docs: update the steps to update directories

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15941 )

Change subject: docs: update the steps to update directories
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15941
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 May 2020 19:09:33 +
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) docs: update the steps to update directories

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15941 )

Change subject: docs: update the steps to update directories
..

docs: update the steps to update directories

The `kudu fs update_dirs` tool is no longer required to update the set
of data directories.

Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Reviewed-on: http://gerrit.cloudera.org:8080/15928
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Grant Henke 
(cherry picked from commit 90450e47e75ace558a04c98e19f2089d21d71c31)
Reviewed-on: http://gerrit.cloudera.org:8080/15941
Reviewed-by: Hao Hao 
---
M docs/administration.adoc
1 file changed, 40 insertions(+), 25 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15941
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) docs: mention how to decommission a tablet server using the rebalancer

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15942


Change subject: docs: mention how to decommission a tablet server using the 
rebalancer
..

docs: mention how to decommission a tablet server using the rebalancer

Change-Id: I6f90eb352c4dce6d200cec33dde91c4bdb4aa522
Reviewed-on: http://gerrit.cloudera.org:8080/15929
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Grant Henke 
(cherry picked from commit 3b60ddf1a3f039647db589aa641995cc81dd6857)
---
M docs/administration.adoc
1 file changed, 26 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/15942/1
--
To view, visit http://gerrit.cloudera.org:8080/15942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f90eb352c4dce6d200cec33dde91c4bdb4aa522
Gerrit-Change-Number: 15942
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 

[kudu-CR](branch-1.12.x) docs: update the steps to update directories

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15941


Change subject: docs: update the steps to update directories
..

docs: update the steps to update directories

The `kudu fs update_dirs` tool is no longer required to update the set
of data directories.

Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Reviewed-on: http://gerrit.cloudera.org:8080/15928
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Grant Henke 
(cherry picked from commit 90450e47e75ace558a04c98e19f2089d21d71c31)
---
M docs/administration.adoc
1 file changed, 40 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/15941/1
--
To view, visit http://gerrit.cloudera.org:8080/15941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11
Gerrit-Change-Number: 15941
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15922 )

Change subject: [site] update site for Kudu 1.12.0 release
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/15922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ef3550eec4d98df889effef4c873aad0046b17b
Gerrit-Change-Number: 15922
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Fri, 15 May 2020 05:26:22 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15922 )

Change subject: [site] update site for Kudu 1.12.0 release
..

[site] update site for Kudu 1.12.0 release

Change-Id: I5ef3550eec4d98df889effef4c873aad0046b17b
Reviewed-on: http://gerrit.cloudera.org:8080/15922
Reviewed-by: Hao Hao 
Tested-by: Hao Hao 
---
A releases/1.12.0/apidocs/allclasses-frame.html
A releases/1.12.0/apidocs/allclasses-noframe.html
A releases/1.12.0/apidocs/constant-values.html
A releases/1.12.0/apidocs/deprecated-list.html
A releases/1.12.0/apidocs/help-doc.html
A releases/1.12.0/apidocs/index-all.html
A releases/1.12.0/apidocs/index.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.CompressionAlgorithm.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.Encoding.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.html
A 
releases/1.12.0/apidocs/org/apache/kudu/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnTypeAttributes.html
A releases/1.12.0/apidocs/org/apache/kudu/Schema.html
A releases/1.12.0/apidocs/org/apache/kudu/Type.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AlterTableOptions.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AlterTableResponse.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduClient.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduSession.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ColumnRangePredicate.html
A releases/1.12.0/apidocs/org/apache/kudu/client/CreateTableOptions.html
A releases/1.12.0/apidocs/org/apache/kudu/client/Delete.html
A releases/1.12.0/apidocs/org/apache/kudu/client/DeleteTableResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ExternalConsistencyMode.html
A releases/1.12.0/apidocs/org/apache/kudu/client/HasFailedRpcException.html
A releases/1.12.0/apidocs/org/apache/kudu/client/Insert.html
A releases/1.12.0/apidocs/org/apache/kudu/client/InsertIgnore.html
A releases/1.12.0/apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduClient.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduException.OriginalException.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduException.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduPartitioner.KuduPartitionerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduPartitioner.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduPredicate.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanToken.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanner.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduScannerIterator.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduSession.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduTable.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduTableStatistics.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ListTablesResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ListTabletServersResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/LocatedTablet.Replica.html
A releases/1.12.0/apidocs/org/apache/kudu/client/LocatedTablet.html
A releases/1.12.0/apidocs/org/apache/kudu/client/Operation.html
A releases/1.12.0/apidocs/org/apache/kudu/client/OperationResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/PartialRow.html
A releases/1.12.0/apidocs/org/apache/kudu/client/PleaseThrottleException.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RangePartitionBound.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ReplicaSelection.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ResourceMetrics.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowError.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowResult.html
A 

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15922 )

Change subject: [site] update site for Kudu 1.12.0 release
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ef3550eec4d98df889effef4c873aad0046b17b
Gerrit-Change-Number: 15922
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Fri, 15 May 2020 05:26:15 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15922


Change subject: [site] update site for Kudu 1.12.0 release
..

[site] update site for Kudu 1.12.0 release

Change-Id: I5ef3550eec4d98df889effef4c873aad0046b17b
---
A releases/1.12.0/apidocs/allclasses-frame.html
A releases/1.12.0/apidocs/allclasses-noframe.html
A releases/1.12.0/apidocs/constant-values.html
A releases/1.12.0/apidocs/deprecated-list.html
A releases/1.12.0/apidocs/help-doc.html
A releases/1.12.0/apidocs/index-all.html
A releases/1.12.0/apidocs/index.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.CompressionAlgorithm.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.Encoding.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnSchema.html
A 
releases/1.12.0/apidocs/org/apache/kudu/ColumnTypeAttributes.ColumnTypeAttributesBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/ColumnTypeAttributes.html
A releases/1.12.0/apidocs/org/apache/kudu/Schema.html
A releases/1.12.0/apidocs/org/apache/kudu/Type.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AlterTableOptions.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AlterTableResponse.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduClient.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduScanner.html
A releases/1.12.0/apidocs/org/apache/kudu/client/AsyncKuduSession.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ColumnRangePredicate.html
A releases/1.12.0/apidocs/org/apache/kudu/client/CreateTableOptions.html
A releases/1.12.0/apidocs/org/apache/kudu/client/Delete.html
A releases/1.12.0/apidocs/org/apache/kudu/client/DeleteTableResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ExternalConsistencyMode.html
A releases/1.12.0/apidocs/org/apache/kudu/client/HasFailedRpcException.html
A releases/1.12.0/apidocs/org/apache/kudu/client/Insert.html
A releases/1.12.0/apidocs/org/apache/kudu/client/InsertIgnore.html
A releases/1.12.0/apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduClient.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduException.OriginalException.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduException.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduPartitioner.KuduPartitionerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduPartitioner.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduPredicate.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanToken.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduScanner.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduScannerIterator.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduSession.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduTable.html
A releases/1.12.0/apidocs/org/apache/kudu/client/KuduTableStatistics.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ListTablesResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ListTabletServersResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/LocatedTablet.Replica.html
A releases/1.12.0/apidocs/org/apache/kudu/client/LocatedTablet.html
A releases/1.12.0/apidocs/org/apache/kudu/client/Operation.html
A releases/1.12.0/apidocs/org/apache/kudu/client/OperationResponse.html
A releases/1.12.0/apidocs/org/apache/kudu/client/PartialRow.html
A releases/1.12.0/apidocs/org/apache/kudu/client/PleaseThrottleException.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RangePartitionBound.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ReplicaSelection.html
A releases/1.12.0/apidocs/org/apache/kudu/client/ResourceMetrics.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowError.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowResult.html
A releases/1.12.0/apidocs/org/apache/kudu/client/RowResultIterator.html
A 
releases/1.12.0/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html
A 

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15917 )

Change subject: [mini_ranger] expect Ranger to bind at wildcard address
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc3b0ac8ffcb74941321588f7110e1dbb61e27
Gerrit-Change-Number: 15917
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: liusheng 
Gerrit-Comment-Date: Fri, 15 May 2020 04:44:44 +
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15919 )

Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..

[C++ client] doxygenized C++ client API in columnar_scan_batch.h

This patch documents the missing parameters for APIs in columnar_scan_batch.h
to satisfy the warnings from doxygen.

Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Reviewed-on: http://gerrit.cloudera.org:8080/15918
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
(cherry picked from commit 7d1f3fbb40984b6917e6e76f252bf6a0924fd70d)
Reviewed-on: http://gerrit.cloudera.org:8080/15919
---
M src/kudu/client/columnar_scan_batch.h
1 file changed, 28 insertions(+), 13 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/15919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15919
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15919


Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..

[C++ client] doxygenized C++ client API in columnar_scan_batch.h

This patch documents the missing parameters for APIs in columnar_scan_batch.h
to satisfy the warnings from doxygen.

Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Reviewed-on: http://gerrit.cloudera.org:8080/15918
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
(cherry picked from commit 7d1f3fbb40984b6917e6e76f252bf6a0924fd70d)
---
M src/kudu/client/columnar_scan_batch.h
1 file changed, 28 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/15919/1
--
To view, visit http://gerrit.cloudera.org:8080/15919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15919
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15918


Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h
..

[C++ client] doxygenized C++ client API in columnar_scan_batch.h

This patch documents the missing parameters for APIs in columnar_scan_batch.h
to satisfy the warnings from doxygen.

Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
---
M src/kudu/client/columnar_scan_batch.h
1 file changed, 28 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/15918/1
--
To view, visit http://gerrit.cloudera.org:8080/15918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb8b927bf55ff181b9923411c35729eed8bafa08
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15917 )

Change subject: [mini_ranger] expect Ranger to bind at wildcard address
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/15917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc3b0ac8ffcb74941321588f7110e1dbb61e27
Gerrit-Change-Number: 15917
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 May 2020 21:13:40 +
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) docs: add Ranger integration

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15910 )

Change subject: docs: add Ranger integration
..

docs: add Ranger integration

Staged version here:
https://github.com/haohaoc/kudu/blob/ranger-docs/docs/security.adoc

Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Reviewed-on: http://gerrit.cloudera.org:8080/15897
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
(cherry picked from commit a961fbc7cac61737d03a0c9cf8898199a101f67e)
Reviewed-on: http://gerrit.cloudera.org:8080/15910
---
M docs/kudu_impala_integration.adoc
M docs/security.adoc
2 files changed, 218 insertions(+), 17 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Gerrit-Change-Number: 15910
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) docs: add Ranger integration

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15910


Change subject: docs: add Ranger integration
..

docs: add Ranger integration

Staged version here:
https://github.com/haohaoc/kudu/blob/ranger-docs/docs/security.adoc

Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Reviewed-on: http://gerrit.cloudera.org:8080/15897
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
(cherry picked from commit a961fbc7cac61737d03a0c9cf8898199a101f67e)
---
M docs/kudu_impala_integration.adoc
M docs/security.adoc
2 files changed, 218 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/15910/1
--
To view, visit http://gerrit.cloudera.org:8080/15910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Gerrit-Change-Number: 15910
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] docs: add Ranger integration

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15897 )

Change subject: docs: add Ranger integration
..

docs: add Ranger integration

Staged version here:
https://github.com/haohaoc/kudu/blob/ranger-docs/docs/security.adoc

Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Reviewed-on: http://gerrit.cloudera.org:8080/15897
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M docs/kudu_impala_integration.adoc
M docs/security.adoc
2 files changed, 218 insertions(+), 17 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Gerrit-Change-Number: 15897
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] docs: add Ranger integration

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15897 )

Change subject: docs: add Ranger integration
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15897/2/docs/security.adoc
File docs/security.adoc:

http://gerrit.cloudera.org:8080/#/c/15897/2/docs/security.adoc@506
PS2, Line 506: [[privilege-caching]]
 : === Kudu Master Caching for Sentry
 :
 : To avoid overwhelming Sentry with requests to fetch user 
privileges, the Kudu
 : master can be configured to cache user privileges. A by-product 
of this caching
 : is that when privileges are changed in Sentry, they may not be 
reflected in
 : Kudu for a configurable amount of time, defined by the following 
Kudu master
 : configurations:
 :
 : `--sentry_privileges_cache_ttl_factor * 
--authz_token_validity_interval_secs`
 :
 : The default value is fifty minutes. If privilege updates need to 
be reflected
 : in Kudu sooner than this, the Kudu CLI tool can be used to 
invalidate the
 : cached privileges to force Kudu to fetch new ones from Sentry:
 :
 : [source,bash]
 : 
 : kudu master authz_cache reset 
> We need these docs to land in master to exist going forward. We can and sho
Ack



--
To view, visit http://gerrit.cloudera.org:8080/15897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad9476f18267c1e14a73f893fd812674c955eee2
Gerrit-Change-Number: 15897
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 May 2020 18:21:24 +
Gerrit-HasComments: Yes

[kudu-CR] tablet: rename transaction-related files to use "op"

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15907 )

Change subject: tablet: rename transaction-related files to use "op"
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30abe8fb12cda5950c0a9c52088b62478e6d169b
Gerrit-Change-Number: 15907
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 May 2020 00:47:06 +
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15905 )

Change subject: KUDU-3113: fix auto-rebalancer move execution
..

KUDU-3113: fix auto-rebalancer move execution

NOTE: this wasn't clean, on account of
8528ac70245efb6d7fec2d18dfa17e45b80421a9.

When executing moves, the auto-rebalancer would try to resolve the
leader's address by passing its UUID instead of its host. This fixes it
to use an appropriate host.

This includes some light cleanup, and updates auto_rebalancer-test to
verify the moves lead to the copying of bytes on tablet servers.

The following flakiness is also addressed:
- NoRebalancingIfReplicasRecovering would sometimes schedule some moves
  before shutting down the tablet server, and we'd time out waiting to
  iterate without scheduling moves. I adjusted the ordering of the
  shutdown so the rebalancer doesn't get a chance to schedule moves.
- Rarely, TestHandlingFailedTservers would see a different error than
  expected when checking for failed sent RPCs. I updated the test to
  expect a couple of messages.

I looped auto_rebalancer-test in DEBUG mode and it pased 1000/1000
times, compared to failing 4/10 times with the change to actually
execute moves.

I also validated this on a real cluster:
- First, I enabled auto-rebalancing on the master.
- I put a tablet server into maintenance mode.
- I then moved all replicas off the tablet server using the rebalancer
  tool's --move_replicas_from_ignored_tservers option.
- I verified that even with the significant skew, since one of the
  tablet servers was in maintenance mode (i.e. unavailable for
  placement), the master didn't automatically move any replicas.
- Once I took the tablet server out of maintenance mode, moves were
  scheduled to repopulate it.
- Steady state was reached with a cluster skew of 1.

Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f
Reviewed-on: http://gerrit.cloudera.org:8080/15850
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-on: http://gerrit.cloudera.org:8080/15905
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 183 insertions(+), 111 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/15905
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f
Gerrit-Change-Number: 15905
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

[Hao Hao (Code Review)]

Hao Hao has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
..

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Reviewed-on: http://gerrit.cloudera.org:8080/15685
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong 
Reviewed-by: Alexey Serbin 
---
M docs/release_notes.adoc
1 file changed, 199 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 14
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

[Hao Hao (Code Review)]

Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar 
Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, 
Bankim Bhavsar, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#13).

Change subject: [docs] add 1.12.0 release notes
..

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 199 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/13
--
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 13
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
..


Patch Set 12:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@182
PS11, Line 182:
  : * The `raft_term` and `time_since_last_leader_heartbeat` 
aggregated table
> Yes, I think that's a bug.  What's the semantics of sum of Raft terms?  It'
Done


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@97
PS12, Line 97:   link:http://getkudu.io/docs/schema_design.html[schema design 
documentation]
> nit: they redirect to the same page, but maybe kudu.apache.org
Done


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@114
PS12, Line 114: tablet replicas
> Raft leaders
Done


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@123
PS12, Line 123: deletes
> delete
Done



--
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Comment-Date: Tue, 12 May 2020 21:42:31 +
Gerrit-HasComments: Yes