[kudu-CR] Fix a unit test in aarch64 system
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually on x86 architecture it is 4k but on aarch64 some linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k block size kernel. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in some aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Reviewed-on: http://gerrit.cloudera.org:8080/20613 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 07 Nov 2023 20:56:53 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/20613/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/11//COMMIT_MSG@9 PS11, Line 9: The block size is not fixed in different architecture systems. : For example, usually on x86 architecture it is 4k but on aarch64 some : linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k : block size kernel. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 : run fails in some aarch64 systems currently because of ignoring the : block size of the architecture All right, let's hope this description isn't going to confuse the readers w.r.t. whether this is about FS block size or recommended IO block size. http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@370 PS10, Line 370: // the encryption is disabled. : FLAGS_log_container_max_size = GetParam() ? 2 * fs_block_size : fs_block_size; : // One block --> one > Yes, you are right. Function GetBlockSize() is decided by 'st_blksize'. And Thank you for updating the comment. IIRC, there are different block sizes that 'stat' reports if you run it on the file and on the filesystem level: * filesystem block size * preferred I/O block size The former is a size of a block in the filesystem. That can be configured when creating a file system. For example for ext4fs that's controlled by the '-b' option when running the 'mkfs.ext4' command. The latter is the "preferred" block size for efficient filesystem I/O. Writing to a file in smaller chunks may cause an inefficient read-modify-rewrite effects. You can ask 'stat' to output information on a particular block size by using the "--format" option with particular format specifiers (those are different depending whether you run it on the file level vs the filesystem level). More information could be found at https://www.man7.org/linux/man-pages/man1/stat.1.html One article that sheds some light on the stat's output is (alternatively, you can take a look at the code yourself): https://askubuntu.com/questions/946521/what-is-the-meaning-of-io-block-and-how-is-it-calculated You could find more information on those in various docs and forums on the Internet, via searching it on google.com and similar engines. http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@376 PS10, Line 376: > Set FLAGS_log_container_max_size fs_block_size or 1024 is both OK when encr Great, thank you for the clarification! -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 07 Nov 2023 20:56:50 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#11). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually on x86 architecture it is 4k but on aarch64 some linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k block size kernel. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in some aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/11 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@370 PS10, Line 370: // For example, usually on x86 architecture it is 4k but on aarch64 some : // linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k : // block size kernel. > I think in this context it's not relevant what's the default block size in Yes, you are right. Function GetBlockSize() is decided by 'st_blksize'. And Kudu uses st_blksize to decide the IO block size. But I have some confusions about the block size. In my aarch64 system, st_blksize is 65536, but when I storage 64 bytes into a file, it shows the file size is 4096 bytes not 65536 bytes on disk. Could you pay some attentions to this issue: https://issues.apache.org/jira/browse/KUDU-3523. Thanks. http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@376 PS10, Line 376: 1024 > Given the comment above, I'd think might be set to fs_block_size instead of Set FLAGS_log_container_max_size fs_block_size or 1024 is both OK when encryption is enabled. Because fs_block_size or 1024 bytes both occupy one block on disk. -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 07 Nov 2023 03:37:25 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@370 PS10, Line 370: // For example, usually on x86 architecture it is 4k but on aarch64 some : // linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k : // block size kernel. I think in this context it's not relevant what's the default block size in particular kernel or architecture, but rather what's the block size for the underlying file system, no? Since the IO block size is now set according to the information read from the FS, I'd think we can remove the TODO comment above about 'Investigate this'. http://gerrit.cloudera.org:8080/#/c/20613/10/src/kudu/fs/log_block_manager-test.cc@376 PS10, Line 376: 1024 Given the comment above, I'd think might be set to fs_block_size instead of hard-coded 1024, no? -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 19:02:25 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@363 PS9, Line 363: // TODO(abukor): If this is 1024, this becomes full when writing the first : // block because of alignments. If it is over filesystem block size, it fails : // with encryption disabled due to having only 5 containers instead of 10. > The modification is related to the comments above, you can update it as wel Done http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@368 PS9, Line 368: ); > nit: sizes Done http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@371 PS9, Line 371: 01. > Why it is 2, not 3 or 4? It would be great to add some comments, thanks! Done http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@371 PS9, Line 371: .90-23.30.v2 > It would be great to mention the encryption header size, I guess it's the r Done -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 09:47:24 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#10). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually on x86 architecture it is 4k but on aarch64 some linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k block size kernel. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in some aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/10 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@363 PS9, Line 363: // TODO(abukor): If this is 1024, this becomes full when writing the first : // block because of alignments. If it is over 4k, it fails with encryption : // disabled due to having only 5 containers instead of 10. Investigate this. The modification is related to the comments above, you can update it as well. http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@368 PS9, Line 368: size nit: sizes http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@371 PS9, Line 371: 2 * Why it is 2, not 3 or 4? It would be great to add some comments, thanks! http://gerrit.cloudera.org:8080/#/c/20613/9/src/kudu/fs/log_block_manager-test.cc@371 PS9, Line 371: GetParam() ? It would be great to mention the encryption header size, I guess it's the reason of setting different FLAGS_log_container_max_size, is it? -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 08:57:57 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 08:33:19 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#9). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually on x86 architecture it is 4k but on aarch64 some linux distribution (eg. 4.19.90-23.30.v2101.ky10.aarch6) can use a 64k block size kernel. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in some aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/9 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#8). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually in x86 architecture it is 4k but in some aarch64 64k, for example, system 4.19.90-23.30.v2101.ky10.aarch6 is 64k. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/8 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#7). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually in x86 architecture it is 4k but in aarch64 64k by default, for example, in system 4.19.90-23.30.v2101.ky10.aarch6 is 64k. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/7 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 6: > Patch Set 3: > > Thank you for the changes. The code change looks good. > Could you please link some source to: > "in aarch64 is 64K in default." > On the internal Cloudera vms: > + Ubuntu 20.04 has 4K > + RHEL 8.8 has 64k > > I started an ubuntu 22.04 t4g.xlarge instance on public aws cloud. It has 4K > block size too. done -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 08:06:18 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20613/5/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/5/src/kudu/fs/log_block_manager-test.cc@369 PS5, Line 369: by defaul > nit: by default Done -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Mon, 06 Nov 2023 02:46:42 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#6). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually in x86 architecture it is 4k but in aarch64 64k defaultly. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/6 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20613/5/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/5/src/kudu/fs/log_block_manager-test.cc@369 PS5, Line 369: defaultly nit: by default -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 01 Nov 2023 16:53:39 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@10 PS4, Line 10: usually in x86 architecture it is 4k but in aarch64 : 64k defaul > usually in x86 architecture it is 4k but in aarch64 it is 64k by default. Done http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@12 PS4, Line 12: run fails i > fails Done http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@13 PS4, Line 13: a f > a Done http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@14 PS4, Line 14: use > use Done http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@368 PS4, Line 368: systems ha > systems have Done http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@369 PS4, Line 369: de > by Done http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@369 PS4, Line 369: ence, here use the blo > Hence use Done -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 01 Nov 2023 02:10:57 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#5). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually in x86 architecture it is 4k but in aarch64 64k defaultly. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 run fails in aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting a fixed value for FLAGS_log_container_max_size, it is better to use the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/5 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] Fix a unit test in aarch64 system
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 4: (7 comments) Just a few nits. http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@10 PS4, Line 10: usually x86 architecture is 4K, but in aarch64 is 64K : in default usually in x86 architecture it is 4k but in aarch64 it is 64k by default. http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@12 PS4, Line 12: runs failed fails http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@13 PS4, Line 13: the a http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@14 PS4, Line 14: using use http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@368 PS4, Line 368: system has systems have http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@369 PS4, Line 369: in by http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@369 PS4, Line 369: Therefore, here should Hence use -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 31 Oct 2023 18:59:52 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 4: Code-Review+1 Overall looks good to me, but please address the points raised by Zoltan. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 31 Oct 2023 18:20:54 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 4: Code-Review+1 Just change the message to something like "On aarch64 some linux distribution (e. g. RHEL) can use a 64k block size kernel." The fix is indeed needed. -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 25 Oct 2023 09:38:00 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 3: Thank you for the changes. The code change looks good. Could you please link some source to: "in aarch64 is 64K in default." On the internal Cloudera vms: + Ubuntu 20.04 has 4K + RHEL 8.8 has 64k I started an ubuntu 22.04 t4g.xlarge instance on public aws cloud. It has 4K block size too. -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 25 Oct 2023 07:47:50 + Gerrit-HasComments: No
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#4). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually x86 architecture is 4K, but in aarch64 is 64K in default. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 runs failed in aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting the fixed value for FLAGS_log_container_max_size, it is better to using the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/4 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG@9 PS2, Line 9: The block size is not fixed in different architecture systems. : For > Isn't it just a parameter of the underlying filesystem (I guess you refer t Yes, block size is a parameter of the underlying filesystem, but different system has different block size in default, for example, x86 is 4K and aarch64 is 64K usually. -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Tue, 24 Oct 2023 07:54:11 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#3). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is not fixed in different architecture systems. For example, usually x86 architecture is 4K, but in aarch64 is 64K in default. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 runs failed in aarch64 systems currently because of ignoring the block size of the architecture. Instead of setting the fixed value for FLAGS_log_container_max_size, it is better to using the variable block size to set it. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/3 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix a unit test in aarch64 system
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 ) Change subject: Fix a unit test in aarch64 system .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG@9 PS2, Line 9: The block size is x86 architecture is 4K, but in aarch64 is : 64K. Isn't it just a parameter of the underlying filesystem (I guess you refer to IO block size, right)? If so, maybe it makes sense using Env::GetBlockSize() call to determine the optimal IO block size, similar to what's done in the TestContainerWithManyHoles scenario? -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Oct 2023 06:26:36 + Gerrit-HasComments: Yes
[kudu-CR] Fix a unit test in aarch64 system
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20613 to look at the new patch set (#2). Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is x86 architecture is 4K, but in aarch64 is 64K. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 runs failed in aarch64. This test should be careful of the block size of the architecture. Instead of setting the fixed value for FLAGS_log_container_max_size, it is better to using the block size of the architecture. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/2 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix a unit test in aarch64 system
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20613 Change subject: Fix a unit test in aarch64 system .. Fix a unit test in aarch64 system The block size is x86 architecture is 4K, but in aarch64 is 64K. Test EncryptionEnabled/LogBlockManagerTest.MetricsTest/1 runs failed in aarch64. This test should be careful of the block size of the architecture. Instead of setting the fixed value for FLAGS_log_container_max_size, it is better to using the block size of the architecture. Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b --- M src/kudu/fs/log_block_manager-test.cc 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/20613/1 -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <1450306...@qq.com>
