Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

> On Aug. 2, 2016, 1:31 a.m., Alex Clemmer wrote:
> > src/slave/cmake/SlaveConfigure.cmake, line 70
> > 
> >
> > Oh. This is especially pertinent given that you seem to remove this 
> > line in #49874.

I cannot recollect that this is intentional. I fixed the issue.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144435
---


On Aug. 3, 2016, 4:40 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated Aug. 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 9a671973b754095e1de917f135a7deb978fb6eb6 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> b339239761a5de321d65b92376dae69c339bee5c 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake, line 51
> > 
> >
> > You're right to split this out, but just for my own education, was 
> > there a specific reason you did it?

The leveldb shared library will be used in this case.


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > src/CMakeLists.txt, line 490
> > 
> >
> > Hmm, is this required? It should be `ON` by default for shared 
> > libraries, no?

the -fPIC is added and so this should not be required anymore. I think we 
should prefer to use this over -fPIC to be not compiler specific?


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > src/slave/cmake/SlaveConfigure.cmake, line 70
> > 
> >
> > Hmm. Can you talk a bit about why we're adding this here? The agent 
> > doesn't depend on leveldb, right? Only the master does?
> > 
> > I'm just trying to think about how we actually want to add this. 
> > Historically there has been some ambition to write this in a way that we 
> > can get rid of libmesos and split it up into libagent and libmaster. If we 
> > maintain the agent dependencies as separated from the master dependencies, 
> > we will get some duplication in the shared dependencies, but it will also 
> > be easier (hopefully) to reason about what depends on what.
> > 
> > What do you think?

Refactoring is a good idea, I think we can come up with mesoscommon, 
mesosmaster and mesosagent as three different libraries. I prefer not to handle 
this right now.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144432
---


On Aug. 2, 2016, 3:35 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated Aug. 2, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 9a671973b754095e1de917f135a7deb978fb6eb6 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> b339239761a5de321d65b92376dae69c339bee5c 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated Aug. 3, 2016, 4:40 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
9a671973b754095e1de917f135a7deb978fb6eb6 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated Aug. 2, 2016, 3:35 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
9a671973b754095e1de917f135a7deb978fb6eb6 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144435
---




src/slave/cmake/SlaveConfigure.cmake (line 70)


Oh. This is especially pertinent given that you seem to remove this line in 
#49874.


- Alex Clemmer


On July 19, 2016, 9:36 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated July 19, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 9a671973b754095e1de917f135a7deb978fb6eb6 
>   src/CMakeLists.txt bde76f7840afe55f20d7551b3f7e5fe522f7f326 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> ced57496970f1d7edf9e7e443b22d14d2ee948f0 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144432
---



Can you please rebase against the `master` branch so I can apply and test this 
review?


3rdparty/cmake/Mesos3rdpartyConfigure.cmake (line 51)


You're right to split this out, but just for my own education, was there a 
specific reason you did it?



src/CMakeLists.txt (line 490)


Hmm, is this required? It should be `ON` by default for shared libraries, 
no?



src/slave/cmake/SlaveConfigure.cmake (line 70)


Hmm. Can you talk a bit about why we're adding this here? The agent doesn't 
depend on leveldb, right? Only the master does?

I'm just trying to think about how we actually want to add this. 
Historically there has been some ambition to write this in a way that we can 
get rid of libmesos and split it up into libagent and libmaster. If we maintain 
the agent dependencies as separated from the master dependencies, we will get 
some duplication in the shared dependencies, but it will also be easier 
(hopefully) to reason about what depends on what.

What do you think?


- Alex Clemmer


On July 19, 2016, 9:36 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated July 19, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 9a671973b754095e1de917f135a7deb978fb6eb6 
>   src/CMakeLists.txt bde76f7840afe55f20d7551b3f7e5fe522f7f326 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> ced57496970f1d7edf9e7e443b22d14d2ee948f0 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 16, 2016, 8:33 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
  src/CMakeLists.txt 493b6dbd28945332fbda2d3172018e109e73235a 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake ced57496970f1d7edf9e7e443b22d14d2ee948f0 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 13, 2016, 12:37 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake ca4575653e00e8f868160976344ac1d57b5f7d27 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 12, 2016, 4:30 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake ca4575653e00e8f868160976344ac1d57b5f7d27 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

> On July 12, 2016, 4:28 a.m., Alex Clemmer wrote:
> > src/CMakeLists.txt, line 477
> > 
> >
> > I'll copy my earlier comment and open up an issue here just to make it 
> > clear that I consider it a ship-blocker:
> > 
> > > Changing the linking structure of this project has a few very 
> > important implications for Windows, and we will need to proceed extremely 
> > cautiously.
> > > Before we get into it, could you please explain explain what the 
> > immediate reason for the patch is? It would be helpful also to have this 
> > justification captured in the commit description, so that it appears in git 
> > log.

I have having issue with libev when using static libraries, I had shared 
libraries work well for both linux and OSX. If we decide to go with static 
libraries I can investigate further on my runtime failures.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review141841
---


On July 11, 2016, 8:39 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated July 11, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
>   src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> ca4575653e00e8f868160976344ac1d57b5f7d27 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review141841
---




src/CMakeLists.txt (line 477)


I'll copy my earlier comment and open up an issue here just to make it 
clear that I consider it a ship-blocker:

> Changing the linking structure of this project has a few very important 
implications for Windows, and we will need to proceed extremely cautiously.
> Before we get into it, could you please explain explain what the 
immediate reason for the patch is? It would be helpful also to have this 
justification captured in the commit description, so that it appears in git log.


- Alex Clemmer


On July 11, 2016, 8:39 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated July 11, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
>   src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> ca4575653e00e8f868160976344ac1d57b5f7d27 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 11, 2016, 8:39 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake ca4575653e00e8f868160976344ac1d57b5f7d27 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review141755
---



Changing the linking structure of this project has a few very important 
implications for Windows, and we will need to proceed extremely cautiously.

Before we get into it, could you please explain explain what the immediate 
reason for the patch is? It would be helpful also to have this justification 
captured in the commit description, so that it appears in `git log`.

- Alex Clemmer


On July 11, 2016, 3:47 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated July 11, 2016, 3:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
>   src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> ca4575653e00e8f868160976344ac1d57b5f7d27 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 11, 2016, 3:47 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
7f7105f5d55fd66f3e826c1c37c0074775bf89ea 
  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake ca4575653e00e8f868160976344ac1d57b5f7d27 

Diff: https://reviews.apache.org/r/49862/diff/


Testing (updated)
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 10, 2016, 2:10 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 10, 2016, 1:49 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated July 10, 2016, 1 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Summary (updated)
-

Changed libmesos from static library to a shared library.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

make


Thanks,

Srinivas Brahmaroutu