Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-20 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/
---

(Updated March 20, 2019, 11:24 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
call to provide a 202 Accepted response with an empty body,
rather than a response containing all reconciliation results.
In this new scheme, reconciliation requests are satisfied with
operation status updates on the scheduler's event stream.
Related tests are also updated.

NOTE that this is a breaking change for schedulers consuming
the experimental operation reconciliation API.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
5443048a620395c6beb0d93a325187df905b1b0b 
  include/mesos/v1/scheduler/scheduler.proto 
3cfe0251847431da09a4eb9c81aecb77c84100dc 
  src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
  src/master/master.hpp 77be494d1ca2d3cd79ab033e41a5ff66c0225f79 
  src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70200/diff/5/

Changes: https://reviews.apache.org/r/70200/diff/4-5/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-20 Thread Greg Mann 


> On March 20, 2019, 8:55 p.m., Joseph Wu wrote:
> > include/mesos/scheduler/scheduler.proto
> > Lines 220-228 (original), 223-231 (patched)
> > 
> >
> > Is there some reason why the un-versioned protobufs do not have the 
> > same deprecation tags?

Whoops, this was an oversight. Thanks Joseph!!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213851
---


On March 15, 2019, 10:35 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 15, 2019, 10:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 5443048a620395c6beb0d93a325187df905b1b0b 
>   include/mesos/v1/scheduler/scheduler.proto 
> 3cfe0251847431da09a4eb9c81aecb77c84100dc 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-20 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213851
---


Fix it, then Ship it!




Minor question, but other LGTM.


include/mesos/scheduler/scheduler.proto
Lines 220-228 (original), 223-231 (patched)


Is there some reason why the un-versioned protobufs do not have the same 
deprecation tags?


- Joseph Wu


On March 15, 2019, 3:35 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 15, 2019, 3:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 5443048a620395c6beb0d93a325187df905b1b0b 
>   include/mesos/v1/scheduler/scheduler.proto 
> 3cfe0251847431da09a4eb9c81aecb77c84100dc 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/
---

(Updated March 15, 2019, 10:35 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
call to provide a 202 Accepted response with an empty body,
rather than a response containing all reconciliation results.
In this new scheme, reconciliation requests are satisfied with
operation status updates on the scheduler's event stream.
Related tests are also updated.

NOTE that this is a breaking change for schedulers consuming
the experimental operation reconciliation API.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
5443048a620395c6beb0d93a325187df905b1b0b 
  include/mesos/v1/scheduler/scheduler.proto 
3cfe0251847431da09a4eb9c81aecb77c84100dc 
  src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
  src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
  src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70200/diff/4/

Changes: https://reviews.apache.org/r/70200/diff/3-4/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-15 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213754
---


Ship it!




Ship It!

- Gastón Kleiman


On March 15, 2019, 3:35 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 15, 2019, 3:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 5443048a620395c6beb0d93a325187df905b1b0b 
>   include/mesos/v1/scheduler/scheduler.proto 
> 3cfe0251847431da09a4eb9c81aecb77c84100dc 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-15 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213751
---



Thanks for the update! This is looking pretty good.

We also have to update the docs, are you going to do that here or do you plan 
to add another patch to the chain?


include/mesos/v1/scheduler/scheduler.proto
Line 218 (original), 221 (patched)


Shouldn't we mark this as deprecated by adding: `[deprecated=true]`?

I don't think it has any effect on the generated code, but it would be 
useful for anyone reading the proto.



include/mesos/v1/scheduler/scheduler.proto
Line 226 (original), 229 (patched)


We should mark this field as deprecated.



include/mesos/v1/scheduler/scheduler.proto
Lines 534-536 (patched)


The `call()` method hasn't changed, so I don't think this statement is 
accurate.

The field will be set to something if an API call returns a response, but 
it just happens to be the case that no call does that at the moment.

I would delete this comment.


- Gastón Kleiman


On March 14, 2019, 10:24 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 14, 2019, 10:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 5443048a620395c6beb0d93a325187df905b1b0b 
>   include/mesos/v1/scheduler/scheduler.proto 
> 3cfe0251847431da09a4eb9c81aecb77c84100dc 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-14 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/
---

(Updated March 14, 2019, 5:24 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
call to provide a 202 Accepted response with an empty body,
rather than a response containing all reconciliation results.
In this new scheme, reconciliation requests are satisfied with
operation status updates on the scheduler's event stream.
Related tests are also updated.

NOTE that this is a breaking change for schedulers consuming
the experimental operation reconciliation API.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
5443048a620395c6beb0d93a325187df905b1b0b 
  include/mesos/v1/scheduler/scheduler.proto 
3cfe0251847431da09a4eb9c81aecb77c84100dc 
  src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
  src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
  src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70200/diff/3/

Changes: https://reviews.apache.org/r/70200/diff/2-3/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213712
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70200']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2959/mesos-review-70200

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2959/mesos-review-70200/logs/mesos-tests.log):

```
I0314 02:38:05.019166  7228 exec shutdown framework 
55cee390-4666-4e16-91c5-2d72ce153f11- because it is terminating
I0314 02:38:05.021153  5740 master.cpp:1295] Agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 at slave(494)@192.10.1.4:55368 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0314 02:38:05.021153  5740 master.cpp:3330] Disconnecting agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 at slave(494)@192.10.1.4:55368 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0314 02:38:05.022153  5740 master.cpp:3349] Deactivating agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 at slave(494)@192.10.1.4:55368 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0314 02:38:05.022153  5348 hierarchical.cpp:390] Removed framework 
55cee390-4666-4e16-91c5-2d72ce153f11-
I0314 02:38:05.022153  5348 hierarchical.cpp:827] Agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0 deactivated
I0314 02:38:05.024169 13204 containerizer.cpp:2576] Destroying container 
0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5 in RUNN[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (691 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (708 ms total)

[--] Global test environment tear-down
[==] 1115 tests from 106 test cases ran. (540795 ms total)
[  PASSED  ] 1114 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

ING state
I0314 02:38:05.024169 13204 containerizer.cpp:3278] Transitioning the state of 
container 0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5 from RUNNING to DESTROYING
I0314 02:38:05.024169 13204 launcher.cpp:161] Asked to destroy container 
0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5
W0314 02:38:05.025177 11352 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=3720 to peer '192.10.1.4:57708': IO failed with error 
code: The specified network name is no longer available.

W0314 02:38:05.026144 11352 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=2140 to peer '192.10.1.4:57709': IO failed with error 
code: The specified network name is no longer available.

I0314 02:38:05.093176  5348 containerizer.cpp:3117] Container 
0756fecb-dda5-4d9b-ab60-f7ba9fccc0d5 has exited
I0314 02:38:05.126160  4404 master.cpp:1135] Master terminating
I0314 02:38:05.127148 11604 hierarchical.cpp:678] Removed agent 
55cee390-4666-4e16-91c5-2d72ce153f11-S0
I0314 02:38:05.405552 11352 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 14, 2019, 1:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 14, 2019, 1:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/
---

(Updated March 14, 2019, 1:41 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
call to provide a 202 Accepted response with an empty body,
rather than a response containing all reconciliation results.
In this new scheme, reconciliation requests are satisfied with
operation status updates on the scheduler's event stream.
Related tests are also updated.

NOTE that this is a breaking change for schedulers consuming
the experimental operation reconciliation API.


Diffs (updated)
-

  src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
  src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
  src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 
  src/tests/storage_local_resource_provider_tests.cpp 
7945384867f26fa15dc734a235ae509d5d6d350f 


Diff: https://reviews.apache.org/r/70200/diff/2/

Changes: https://reviews.apache.org/r/70200/diff/1-2/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-13 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213696
---



Patch looks great!

Reviews applied: [70200]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 13, 2019, 6:09 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 13, 2019, 6:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

2019-03-13 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213691
---




src/master/master.cpp
Line 9557 (original), 9557-9564 (patched)


Should this lambda leverage move semantics? It could take an rvalue and do 
an assignment instead of a copy:

```
update.mutable_update_operation_status()
  ->mutable_status() = status;
```

It would also be possible to create a single `scheduler::Event` message 
instead of one per lambda invocation.



src/tests/operation_reconciliation_tests.cpp
Line 200 (original), 204 (patched)


`s/ASSERT/EXPECT/` here and on the other tests.

The updated test doesn't call `result->response()`, so there is no risk of 
it crashing.



src/tests/storage_local_resource_provider_tests.cpp
Lines 4658-4660 (original), 4662-4664 (patched)


`%s/ASSERT/EXPECT/g`


- Gastón Kleiman


On March 13, 2019, 11:09 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70200/
> ---
> 
> (Updated March 13, 2019, 11:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the v1 scheduler API's RECONCILE_OPERATIONS
> call to provide a 202 Accepted response with an empty body,
> rather than a response containing all reconciliation results.
> In this new scheme, reconciliation requests are satisfied with
> operation status updates on the scheduler's event stream.
> Related tests are also updated.
> 
> NOTE that this is a breaking change for schedulers consuming
> the experimental operation reconciliation API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c 
>   src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 7945384867f26fa15dc734a235ae509d5d6d350f 
> 
> 
> Diff: https://reviews.apache.org/r/70200/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>