[GitHub] spark pull request: [SPARK-3781] code Style format and little impr...
GitHub user shijinkui opened a pull request: https://github.com/apache/spark/pull/2734 [SPARK-3781] code Style format and little improvement 1. use scala recommended usage 2. method body's left bracket 3. parameter list format 4. explicit mutable collection, such as new mutable.HashMap 5. others You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2734.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2734 commit bd103b78adebf933d3e33d4628c2394a845dbaa2 Author: shijinkui shijinkui...@163.com Date: 2014-09-29T05:34:02Z code style format commit 0c9d1754f9c8bf36236f915868eb6f62863fea25 Author: shijinkui shijinkui...@163.com Date: 2014-10-03T14:21:44Z code format commit 237bacc3d1c911e6475da4ad08dcd4d0031883ec Author: shijinkui shijinkui...@163.com Date: 2014-10-08T03:05:01Z resolve conflic commit 78f69b9526ea546251dac5eddf4da9c9eb6e20ad Author: shijinkui shijinkui...@163.com Date: 2014-10-08T03:31:24Z code format commit 725eec51fb7d29d0df99b92df3ef62fcec301d90 Author: çç jinkui@alibaba-inc.com Date: 2014-10-08T14:42:29Z resolve test fail commit e54344b33b4c8cb4c1ff0dfb18a08188de464cfc Author: çç jinkui@alibaba-inc.com Date: 2014-10-09T08:55:18Z code format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format and little impr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2734#issuecomment-58507800 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui closed the pull request at: https://github.com/apache/spark/pull/2704 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
GitHub user shijinkui opened a pull request: https://github.com/apache/spark/pull/2714 [SPARK-3781] code Style format code Style format, modify the third time :( You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2714 commit e00f13a554fb4a95996250e6cd65403fcc20b6e2 Author: shijinkui shijinkui...@163.com Date: 2014-09-29T05:34:02Z code style format commit 271e2a4a60ec2412f32966b65448c8ca25dc377f Author: shijinkui shijinkui...@163.com Date: 2014-10-03T14:21:44Z code format commit 033af6a1bd2011b847633934ba719716d459aca8 Author: shijinkui shijinkui...@163.com Date: 2014-10-03T15:03:24Z code style format commit 5732fae2d1ad94c820cc0a2fbc246aeee3142c00 Author: shijinkui shijinkui...@163.com Date: 2014-10-08T01:30:07Z resolve conflic commit 1f96a878815fd65035e11f5755426e6c9fda3ece Author: shijinkui shijinkui...@163.com Date: 2014-10-08T03:05:01Z resolve conflic commit 4a685cc2ea323f0fc54d6593e0ee568d829ebb02 Author: shijinkui shijinkui...@163.com Date: 2014-10-08T03:31:24Z code format commit 5be64c970c2f5d7fb895910863eb6aa5d1e923bf Author: çç jinkui@alibaba-inc.com Date: 2014-10-08T14:41:58Z Merge branch 'master' of git://git.apache.org/spark commit 42a9d81773d198c9fab7f77e0f2673d16c71 Author: çç jinkui@alibaba-inc.com Date: 2014-10-08T14:42:29Z resolve test fail --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58369606 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21465/consoleFull) for PR 2704 at commit [`42a9d81`](https://github.com/apache/spark/commit/42a9d81773d198c9fab7f77e0f2673d16c71). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58369787 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21465/consoleFull) for PR 2704 at commit [`42a9d81`](https://github.com/apache/spark/commit/42a9d81773d198c9fab7f77e0f2673d16c71). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class FieldAccessFinder(output: mutable.Map[Class[_], mutable.Set[String]]) extends ClassVisitor(ASM4) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58369791 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21465/Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58369964 @AmplabJenkins @andrewor14 review and run test again please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2714#issuecomment-58370041 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on the pull request: https://github.com/apache/spark/pull/2714#issuecomment-58370144 @AmplabJenkins @andrewor14 review and run test again please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2714#issuecomment-58374755 @shijinkui Why do you keep closing this? Right after you requested Jenkins to test it. You can verify the style checks run locally first if you need to. The test failures may not be due to your change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui closed the pull request at: https://github.com/apache/spark/pull/2714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18596253
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter: Iterator[_ : Product2[K, V]]):
Iterator[(K, C)] =
combineValuesByKey(iter, null)
- def combineValuesByKey(iter: Iterator[_ : Product2[K, V]],
- context: TaskContext): Iterator[(K, C)] = {
+ def combineValuesByKey(iter: Iterator[_ : Product2[K, V]], context:
TaskContext): Iterator[(K, C)] = {
--- End diff --
Normally yes, but in Spark we also have a 100 character limit per line, so
if we don't break it down into multiple lines it won't pass the style tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2644#issuecomment-58390539 Hey @shijinkui I think we're fairly confused as to which one is the latest PR. Is there a reason why you keep opening and closing PRs? If you make a change to the code you can always just push it to the same branch and it will show up in the same PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544674
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private val nextBroadcastId = new AtomicLong(0)
def newBroadcast[T: ClassTag](value_ : T, isLocal: Boolean) = {
-broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement())
+broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement)
--- End diff --
I think the `()` should be there because this is not just a getter (it also
increments)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544762
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1019,7 +1020,7 @@ class DAGScheduler(
changeEpoch = true)
}
clearCacheLocs()
- if (stage.outputLocs.exists(_ == Nil)) {
+ if (stage.outputLocs.contains(Nil)) {
--- End diff --
I think this is equivalent but I'm not 100% sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544810
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
@@ -38,5 +42,4 @@ private[spark] trait SchedulerBackend {
* @return The application ID, or None if the backend does not provide
an ID.
*/
def applicationId(): Option[String] = None
-
-}
+}
--- End diff --
need new line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544867
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-import scala.util.Random
-
-import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.SparkContext._
import org.apache.spark.scheduler.SchedulingMode
+import org.apache.spark.{SparkConf, SparkContext}
+
+import scala.util.Random
--- End diff --
Shouldn't scala be above Spark imports? I was under the impression that the
order is java scala 3rd party Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544573
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter: Iterator[_ : Product2[K, V]]):
Iterator[(K, C)] =
combineValuesByKey(iter, null)
- def combineValuesByKey(iter: Iterator[_ : Product2[K, V]],
- context: TaskContext): Iterator[(K, C)] = {
+ def combineValuesByKey(iter: Iterator[_ : Product2[K, V]], context:
TaskContext): Iterator[(K, C)] = {
--- End diff --
This is 100 chars. The correct style here is
```
def combineValuesByKey(
iter: Iterator[...],
context: TaskContext): Iterator[...] = {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544949
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -845,7 +845,7 @@ private[spark] object Utils extends Logging {
stdoutThread.join() // Wait for it to finish reading output
if (exitCode != 0) {
logError(sProcess $command exited with code $exitCode: $output)
- throw new SparkException(sProcess $command exited with code
$exitCode)
--- End diff --
I think we should just keep this. We use string interpolation at many
places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544914
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -265,15 +265,15 @@ private[spark] object Utils extends Logging {
/** Copy all data from an InputStream to an OutputStream */
def copyStream(in: InputStream,
- out: OutputStream,
- closeStreams: Boolean = false): Long =
+out: OutputStream,
+closeStreams: Boolean = false): Long =
--- End diff --
correct style should be
```
def copyStream(
in: InputStream,
out: OutputStream,
closeStreams: Boolean = false): Long = {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2644#issuecomment-58251994 Hey @shijinkui I agree with most of the changes here. It seems that there are a few lines that exceed the 100 character limit however. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18560510
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter: Iterator[_ : Product2[K, V]]):
Iterator[(K, C)] =
combineValuesByKey(iter, null)
- def combineValuesByKey(iter: Iterator[_ : Product2[K, V]],
- context: TaskContext): Iterator[(K, C)] = {
+ def combineValuesByKey(iter: Iterator[_ : Product2[K, V]], context:
TaskContext): Iterator[(K, C)] = {
--- End diff --
i think method parameter should be in one line possibly, there is no
necessary each param one line
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18561868
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private val nextBroadcastId = new AtomicLong(0)
def newBroadcast[T: ClassTag](value_ : T, isLocal: Boolean) = {
-broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement())
+broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement)
--- End diff --
val i: AtomicLong = new AtomicLong(0)
i.incrementAndGet()
Code:
0: new #16 // class
java/util/concurrent/atomic/AtomicLong
3: dup
4: lconst_0
5: invokespecial #19 // Method
java/util/concurrent/atomic/AtomicLong.init:(J)V
8: astore_2
9: aload_2
10: invokevirtual #23 // Method
java/util/concurrent/atomic/AtomicLong.incrementAndGet:()J
13: pop2
14: return
val i: AtomicLong = new AtomicLong(0)
i.incrementAndGet
Code:
0: new #16 // class
java/util/concurrent/atomic/AtomicLong
3: dup
4: lconst_0
5: invokespecial #19 // Method
java/util/concurrent/atomic/AtomicLong.init:(J)V
8: astore_2
9: aload_2
10: invokevirtual #23 // Method
java/util/concurrent/atomic/AtomicLong.incrementAndGet:()J
13: pop2
14: return
they are same byte code.
scala recommend having no () if having no param
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18562022
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
@@ -38,5 +42,4 @@ private[spark] trait SchedulerBackend {
* @return The application ID, or None if the backend does not provide
an ID.
*/
def applicationId(): Option[String] = None
-
-}
+}
--- End diff --
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18562132
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-import scala.util.Random
-
-import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.SparkContext._
import org.apache.spark.scheduler.SchedulingMode
+import org.apache.spark.{SparkConf, SparkContext}
+
+import scala.util.Random
--- End diff --
http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s3.3-import-statements
in ASCII sort order
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18562140
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -265,15 +265,15 @@ private[spark] object Utils extends Logging {
/** Copy all data from an InputStream to an OutputStream */
def copyStream(in: InputStream,
- out: OutputStream,
- closeStreams: Boolean = false): Long =
+out: OutputStream,
+closeStreams: Boolean = false): Long =
--- End diff --
yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui commented on the pull request: https://github.com/apache/spark/pull/2644#issuecomment-58302944 repush at #2704 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
GitHub user shijinkui opened a pull request: https://github.com/apache/spark/pull/2704 [SPARK-3781] code Style format 1. code formater 2. scala normal usage about method and param You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2704.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2704 commit e00f13a554fb4a95996250e6cd65403fcc20b6e2 Author: shijinkui shijinkui...@163.com Date: 2014-09-29T05:34:02Z code style format commit 271e2a4a60ec2412f32966b65448c8ca25dc377f Author: shijinkui shijinkui...@163.com Date: 2014-10-03T14:21:44Z code format commit 033af6a1bd2011b847633934ba719716d459aca8 Author: shijinkui shijinkui...@163.com Date: 2014-10-03T15:03:24Z code style format commit 5732fae2d1ad94c820cc0a2fbc246aeee3142c00 Author: shijinkui shijinkui...@163.com Date: 2014-10-08T01:30:07Z resolve conflic commit 1f96a878815fd65035e11f5755426e6c9fda3ece Author: shijinkui shijinkui...@163.com Date: 2014-10-08T03:05:01Z resolve conflic commit 4a685cc2ea323f0fc54d6593e0ee568d829ebb02 Author: shijinkui shijinkui...@163.com Date: 2014-10-08T03:31:24Z code format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user shijinkui closed the pull request at: https://github.com/apache/spark/pull/2644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58303122 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58308187 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58308604 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21443/consoleFull) for PR 2704 at commit [`4a685cc`](https://github.com/apache/spark/commit/4a685cc2ea323f0fc54d6593e0ee568d829ebb02). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58308676 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21443/Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2704#issuecomment-58308674 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21443/consoleFull) for PR 2704 at commit [`4a685cc`](https://github.com/apache/spark/commit/4a685cc2ea323f0fc54d6593e0ee568d829ebb02). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class FieldAccessFinder(output: mutable.Map[Class[_], mutable.Set[String]]) extends ClassVisitor(ASM4) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18565013
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private val nextBroadcastId = new AtomicLong(0)
def newBroadcast[T: ClassTag](value_ : T, isLocal: Boolean) = {
-broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement())
+broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement)
--- End diff --
No, the style convention is to omit () when the method has no side effects.
`incrementAndGet` clearly has a side-effect, so should have ()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18565055
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-import scala.util.Random
-
-import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.SparkContext._
import org.apache.spark.scheduler.SchedulingMode
+import org.apache.spark.{SparkConf, SparkContext}
+
+import scala.util.Random
--- End diff --
Spark code base convention is to import `scala` first. I have actually
never seen a project that uses lexicographical sort order globally, but overall
groups imports logically and then sorts. In any event, it's better to follow
standard convention and put `scala` first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
GitHub user shijinkui opened a pull request: https://github.com/apache/spark/pull/2644 [SPARK-3781] code Style format You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/spark styleFormat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2644.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2644 commit e00f13a554fb4a95996250e6cd65403fcc20b6e2 Author: shijinkui shijinkui...@163.com Date: 2014-09-29T05:34:02Z code style format commit 271e2a4a60ec2412f32966b65448c8ca25dc377f Author: shijinkui shijinkui...@163.com Date: 2014-10-03T14:21:44Z code format commit 033af6a1bd2011b847633934ba719716d459aca8 Author: shijinkui shijinkui...@163.com Date: 2014-10-03T15:03:24Z code style format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3781] code Style format
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2644#issuecomment-57810182 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
