Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Fri, 16 Dec 2022 17:41:42 GMT, Damon Nguyen wrote: >> Yes, you can replace all "存在安全风险" (that is not after ""被视为") to "被视为存在安全风险". >> >> There are also similar usages in >> `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. > > Hi @wangweij , I believe I fixed the occurrences of "存在安全风险" and replaced > them with "被视为存在安全风险". This translation drop does not update > `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. > So, this may be a separate request. If that file is selected for extraction > in the next drop in January, then it could also be fixed then. > > Could you re-review the current changes for this drop? The updated file looks fine to me. Thanks. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Fri, 16 Dec 2022 15:02:42 GMT, Weijun Wang wrote: >> I didn't do the translation myself so I'm not sure the best approach to >> resolve this. I can manually replace these translations with one or the >> other. However, it's determine which parts of the code translate to >> 被视为存在安全风险" or "存在安全风险". I converted the unicode you highlighted above to >> characters, and I see where each one is located. If I just replace all >> instances of "存在安全风险" and insert "被视为存在安全风险" in unicode in its place, will >> it be OK? > > Yes, you can replace all "存在安全风险" (that is not after ""被视为") to "被视为存在安全风险". > > There are also similar usages in > `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. Hi @wangweij , I believe I fixed the occurrences of "存在安全风险" and replaced them with "被视为存在安全风险". This translation drop does not update `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. So, this may be a separate request. If that file is selected for extraction in the next drop in January, then it could also be fixed then. Could you re-review the current changes for this drop? - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Fri, 16 Dec 2022 03:41:09 GMT, Damon Nguyen wrote:
>> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
>> line 75:
>>
>>> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"},
>>> //-genseckey
>>> 74: {"key.algorithm.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>>> \u7B97\u6CD5\u88AB\u89C6\u4E3A\u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>>> 75: {"key.size.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>>> \u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>>
>> The exact same "is considered a security risk" is sometimes translated into
>> "被视为存在安全风险" and sometimes "存在安全风险". Either is OK for me but please be
>> consistent. This is also shown in 5 other places in the same file.
>
> I didn't do the translation myself so I'm not sure the best approach to
> resolve this. I can manually replace these translations with one or the
> other. However, it's determine which parts of the code translate to
> 被视为存在安全风险" or "存在安全风险". I converted the unicode you highlighted above to
> characters, and I see where each one is located. If I just replace all
> instances of "存在安全风险" and insert "被视为存在安全风险" in unicode in its place, will it
> be OK?
Yes, you can replace all "存在安全风险" (that is not after ""被视为") to "被视为存在安全风险".
There are also similar usages in
`src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert double quote as well
>
> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
> line 75:
>
>> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"},
>> //-genseckey
>> 74: {"key.algorithm.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>> \u7B97\u6CD5\u88AB\u89C6\u4E3A\u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>> 75: {"key.size.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>> \u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>
> The exact same "is considered a security risk" is sometimes translated into
> "被视为存在安全风险" and sometimes "存在安全风险". Either is OK for me but please be
> consistent. This is also shown in 5 other places in the same file.
I didn't do the translation myself so I'm not sure the best approach to resolve
this. I can manually replace these translations with one or the other. However,
it's determine which parts of the code translate to 被视为存在安全风险" or "存在安全风险". I
converted the unicode you highlighted above to characters, and I see where each
one is located. If I just replace all instances of "存在安全风险" and insert
"被视为存在安全风险" in unicode in its place, will it be OK?
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well The changes in the java.xml area look good to me. - Marked as reviewed by joehw (Reviewer). PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
line 75:
> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"},
> //-genseckey
> 74: {"key.algorithm.weak", "%1$s \u4F7F\u7528\u7684 %2$s
> \u7B97\u6CD5\u88AB\u89C6\u4E3A\u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
> 75: {"key.size.weak", "%1$s \u4F7F\u7528\u7684 %2$s
> \u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
The exact same "is considered a security risk" is sometimes translated into
"被视为存在安全风险" and sometimes "存在安全风险". Either is OK for me but please be
consistent. This is also shown in 5 other places in the same file.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl
line 15:
> 13:Id="ShortcutPromptDlgStartMenuShortcutControlLabel">スタート・メニューのショートカットの作成
> 14: [ProductName]セットアップ
> 15: Open with [ProductName]
Why it was removed in all translations, except English?
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties
line 51:
> 49: error.msi-product-version-minor-out-of-range=Nebenversion muss im Bereich
> [0, 255] liegen
> 50: error.version-swap=Versionsinformationen f\u00FCr {0} konnten nicht
> aktualisiert werden
> 51: error.icon-swap=Failed to update icon for {0}
Why this was removed?
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
Marked as reviewed by naoto (Reviewer).
src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/resources/jdeprscan_de.properties
line 26:
> 24: #
> 25:
> 26: main.usage=Verwendung: jdeprscan [Optionen] '{dir|jar|class}'
> ...\n\nOptionen:\n--class-path PATH\n--for-removal\n
> --full-version\n -? -h --help\n -l--list\n--release {0}\n -v
> --verbose\n--version
Good catch!
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert double quote as well - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/09140a05..57c42206 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=03 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=02-03 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
