Re: releasing Subsurface-mobile 3.0 on Android

[Dirk Hohndel via subsurface]

On Tue, 2020-03-31 at 10:13 +0200, Willem Ferguson wrote:
> See the screencast at:
> 
> https://www.dropbox.com/s/olji337v2bw6mqy/20200331_094957.mp4?dl=0

Thanks for doing that. This is always SO MUCH EASIER to understand if I
can see the interaction in front of you. I really appreciate that you
are going through the effort of creating and uploading those videos.

> 
> 1) I open the dive list and hit the undo/redo button from the dive
> list
> 
> The undo/redo button opens. Ok so far.
> 
> I close the undo menu using the BACK button. The submenu closes
> correctly.
> 
> 
> 2) I select another dive in the dive list. This opens the dive 
> info/profile panel.

Small correction. You are not "selecting another dive". You are for the
first time selecting a dive. You start out with no dive selected (which
is why there are no dive specific options in the context menu in step
1) above).

> I select the undo/redo button.
> 
> Then I try to close it using the BACK button.
> 
> This adds three more options to the undo/redo menu but does not
> close 
> the submenu.

The odd thing here is that the drawer stays open. The change that you
see is the switch from the 'dive details' context menu to the 'dive
list' context menu. So some options that are available through the
action button when you are viewing a dive are only available through
the context menu on the dive list (that's 'delete' and 'show on map')

Arguably, the 'mark as invalid' option should be on the 'dive details'
context menu as well. I need to fix that.


> I then close it using the proper X button on the left.
> 
> This shows the dive list as expected.
> 
> 
> 3) I hit the undo/redo button *without selecting a different dive*.

Wait, what? We don't have an 'undo/redo button'. Do you mean the three
dots for the context menu?

> The undo/redo submenu opens.

I think you are calling the 'context menu' the 'undo/redo submenu' and
the 'context menu button' the 'undo/redo button'?

> I hit the BACK button and the submenu closes as expected.
> 
> 
> This may mean that some tweak is needed when the undo/redo menu is 
> opened from the dive info/profile panel.

Yes, I need to add a handler to the 'dive details' page to make sure
that we only go back if the menus aren't open. This should be straight
forward.

> But the puzzling part is why 3 options are added to the undo menu
> when 
> the BACK button is pressed.

I hope I have sufficiently explained why you are seeing this change
(and of course once I fix the issue with the menus closing before going
back, you won't see this confusing effect anymore).


> > Thanks for that. Obviously a bug, I'll look into that later today.
> > 
> You must have looked at this because with this version (1277) the 
> numbers correspond to those calculated in Subsurface Linux Desktop.

Correct. I responded to your email a second time, pointing out that
this was caused by you having one of the few 32bit devices still in use
(right now that's less than 8% of our users).
None of my usual test devices are 32bit, so I missed that...

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Willem Ferguson via subsurface]

On 2020/03/30 22:05, Dirk Hohndel wrote:



  But trying it with the undo/redo submenu now appears
to work ok for me sometimes. The ideosyncracy is that sometimes the
submenu only has 2 items: undo and redo. In that case there appears
to
be no problem and I can quit with BACK. But in other cases 7 items
appear without me doing any editing on the dive contents. < Remove
dive
from trip (at top)  Redo (at bottom). In that case when I hit
the
Android BACK button, the undo/redo submenu is not closed. If I hit
the
BACK button a 2nd time then Subsurface (as it should) quits. In some
cases I can select the redo/undo from the dive list and then there
are
omly two options. In other cases, when I select the undo/redo on the
dive list, it opens the screen with the dive profile and then opens
a
7-option submenu. When I select undo/redo  from the dive list
immediately after startup, I get a 2-item submenu.


See the screencast at:

https://www.dropbox.com/s/olji337v2bw6mqy/20200331_094957.mp4?dl=0

Here is the context. There are three parts:


1) I open the dive list and hit the undo/redo button from the dive list

The undo/redo button opens. Ok so far.

I close the undo menu using the BACK button. The submenu closes correctly.


2) I select another dive in the dive list. This opens the dive 
info/profile panel.


I select the undo/redo button.

Then I try to close it using the BACK button.

This adds three more options to the undo/redo menu but does not close 
the submenu.


I then close it using the proper X button on the left.

This shows the dive list as expected.


3) I hit the undo/redo button *without selecting a different dive*.

The undo/redo submenu opens.

I hit the BACK button and the submenu closes as expected.


This may mean that some tweak is needed when the undo/redo menu is 
opened from the dive info/profile panel.


But the puzzling part is why 3 options are added to the undo menu when 
the BACK button is pressed.




Thanks for that. Obviously a bug, I'll look into that later today.

You must have looked at this because with this version (1277) the 
numbers correspond to those calculated in Subsurface Linux Desktop.


No issue that I can see.


Kind regards,

willem





--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Dirk Hohndel via subsurface]

> On Mar 30, 2020, at 1:05 PM, Dirk Hohndel via subsurface 
>  wrote:
 In the dive summary screen, the Avg SAC (when all dives are used)
 gives
 a zero or a negative value for both columns of results. The other
 SAC
 values displayed appear ok.
>>> I haven't seen that effect (and again tested this on two phones
>>> with to
>>> different test accounts with different data), I will look at the
>>> code
>>> to see if I can understand how that would happen. Do you have a
>>> screen
>>> shot for this effect?
>> See attached screenshot.
> 
> Thanks for that. Obviously a bug, I'll look into that later today.

Duh. I remember that your phone is one of the few remaining
32bit devices out there. And stupidly the statistics code uses
'long' assuming that that gives us 64bit. On 32bit arm long is
a 32bit integer. So my first guess would be that this is simply
an integer overflow issue.

I'll fix that and push another update to Google.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Dirk Hohndel via subsurface]

On Mon, 2020-03-30 at 21:46 +0200, Willem Ferguson wrote:
> On 2020/03/30 18:15, Dirk Hohndel wrote:
> > Yes, please do that. Just "Loading dive list"
> See attached screenshot showing version
> > That's already in 4.9.3.1258. Did this not work for you?
> 
> See attached image.

As I mentioned in one of my emails. With my slowest / oldest phone I
also don't get the updated notification text. With my newer phones and
tablets I do get a better message. I cannot explain why.

> My screen is quite small. I cannot open the undo/redo submenu while
> the 
> main menu is open.

No one can - they are sized to cover about 2/3 of your screen.

>  But trying it with the undo/redo submenu now appears 
> to work ok for me sometimes. The ideosyncracy is that sometimes the 
> submenu only has 2 items: undo and redo. In that case there appears
> to 
> be no problem and I can quit with BACK. But in other cases 7 items 
> appear without me doing any editing on the dive contents. < Remove
> dive 
> from trip (at top)  Redo (at bottom). In that case when I hit
> the 
> Android BACK button, the undo/redo submenu is not closed. If I hit
> the 
> BACK button a 2nd time then Subsurface (as it should) quits. In some 
> cases I can select the redo/undo from the dive list and then there
> are 
> omly two options. In other cases, when I select the undo/redo on the 
> dive list, it opens the screen with the dive profile and then opens
> a 
> 7-option submenu. When I select undo/redo  from the dive list 
> immediately after startup, I get a 2-item submenu.

You are testing with 1258 as 1263 hasn't been pushed out by Google,
yet. I believe (but of course won't know until you try as your phone
truly IS special) that this should be fixed in 1263


> > > In the dive summary screen, the Avg SAC (when all dives are used)
> > > gives
> > > a zero or a negative value for both columns of results. The other
> > > SAC
> > > values displayed appear ok.
> > I haven't seen that effect (and again tested this on two phones
> > with to
> > different test accounts with different data), I will look at the
> > code
> > to see if I can understand how that would happen. Do you have a
> > screen
> > shot for this effect?
> See attached screenshot.

Thanks for that. Obviously a bug, I'll look into that later today.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Dirk Hohndel via subsurface]

On Mon, 2020-03-30 at 14:47 +0200, Willem Ferguson via subsurface
wrote:
> Here are a few comments on V4.9.3.1258.
> 
> On 2020/03/30 00:03, Dirk Hohndel wrote:
> > Upon activating the software,  I get a message "No dives in dive
> > > list"
> > > 
> > > It would make much more sense if the message said something like
> > > "preparing the dive list".
> 
> Yes, please do that. Just "Loading dive list"

That's already in 4.9.3.1258. Did this not work for you?

> > > When opening the Undo/Redo menu and I select the Android Return
> > > button
> > > (NOT the X-button the left of the Undo/Redo menu), I exit
> > > Subsurface-mobile. This is counter-intuitive. Upon hitting the
> > > Android
> > > RETURN button, it should just close the Undo/Redo menu. This
> > > should
> > > probably apply to all submenus
> > > By RETURN you mean the back arrow?
> > > Yeah, that's definitely a bug.
> > Also fixed in the beta.
> Hitting the Android BACK button still exits Subsurface.

Well, that depends. If you are on the dive list with no menus / drawers
open, then yes, the back button exits Subsurface. I consider that a
feature.
But if you have a menu open, it no longer exits, it just closes the
menu. If you then hit back again, yes, it exits.

Is that consistent with the behavior you are seeing?

Oh, interesting. I tried to make sure that this works and here's the
odd thing that I see. If I go back to the dive list from a different
page, open the context menu and hit the back button, the app exits.
It doesn't exit if the main menu is open and I hit the back button. And
it doesn't exit if I first start the app, open the context menu and hit
the back button (the context menu closes as expected).

Very strange and something to investigate further.

> Dive site editing while editing dive information. I hit the pencil
> icon 
> while a dive profile is showing. Editing the dive location is a mess.
> I 
> tried to remove some of the text and ended up with gibberish. I
> suspect 
> it is a case where the screen pointer and the internal text pointer
> do 
> not point at the same place in the text field. See the screen movie
> at
> 
> https://www.dropbox.com/s/ucss7bqtc7mdnp6/20200330_133215.mp4?dl=0

Thanks. The video seems to show a bad interaction between auto
completion of the drop down and the editing on the screen.
I thought I had turned auto completion off for that field.
Admittedly, I have never tried to first select something from the drop
down and then edit that text. Playing with it a little on a couple of
phones I cannot get anything nearly as bad as what you show in the
video, but I do see some odd auto completions happening.

Definitely more investigation needed.

> In the dive summary screen, the Avg SAC (when all dives are used)
> gives 
> a zero or a negative value for both columns of results. The other
> SAC 
> values displayed appear ok.

I haven't seen that effect (and again tested this on two phones with to
different test accounts with different data), I will look at the code
to see if I can understand how that would happen. Do you have a screen
shot for this effect?

> After editing a dive and exiting to the dive list: when I select,
> from 
> the list, a different dive to view, the Android keyboard comes up in 
> front of the dive information. Disabling the keyboard by hitting the 
> Android BACK button only disables the keyboard for a few seconds,
> then 
> the keyboard reappears. Frustrating. Restarting Subsurface removes
> the 
> problem.

I was able to reproduce this behavior. Yikes that is annoying. I'll
work on that one, first :-)

Thank you so much for all of the testing. MUCH appreciated.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Willem Ferguson via subsurface]

Here are a few comments on V4.9.3.1258.

On 2020/03/30 00:03, Dirk Hohndel wrote:

Productive day here so far


On Sun, 2020-03-29 at 11:14 -0700, Dirk Hohndel via subsurface wrote:

Upon activating the software,  I get a message "No dives in dive
list"

It would make much more sense if the message said something like
"preparing the dive list".


Yes, please do that. Just "Loading dive list"


That should work in the beta.


When I tap the filter button, nothing happens.

This works perfectly now. Excellent!

One other issue:
When opening the Undo/Redo menu and I select the Android Return
button
(NOT the X-button the left of the Undo/Redo menu), I exit
Subsurface-mobile. This is counter-intuitive. Upon hitting the
Android
RETURN button, it should just close the Undo/Redo menu. This
should
probably apply to all submenus
By RETURN you mean the back arrow?
Yeah, that's definitely a bug.

Also fixed in the beta.

Hitting the Android BACK button still exits Subsurface.

In the new build I could not repeat the problem with unwanted cloud sync 
of dive logs.



Dive site editing while editing dive information. I hit the pencil icon 
while a dive profile is showing. Editing the dive location is a mess. I 
tried to remove some of the text and ended up with gibberish. I suspect 
it is a case where the screen pointer and the internal text pointer do 
not point at the same place in the text field. See the screen movie at


https://www.dropbox.com/s/ucss7bqtc7mdnp6/20200330_133215.mp4?dl=0

I suspected that the text editing would in general would be problematic, 
but I could not find similar problems when editing the dive notes, only 
while editing the dive location. I tested most of the other input fields 
in the dive edit screen and everything else appeared ok.


In the dive summary screen, the Avg SAC (when all dives are used) gives 
a zero or a negative value for both columns of results. The other SAC 
values displayed appear ok.


After editing a dive and exiting to the dive list: when I select, from 
the list, a different dive to view, the Android keyboard comes up in 
front of the dive information. Disabling the keyboard by hitting the 
Android BACK button only disables the keyboard for a few seconds, then 
the keyboard reappears. Frustrating. Restarting Subsurface removes the 
problem.


Kind regards,

willem











--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Dirk Hohndel via subsurface]

Productive day here so far

Please update to the latest beta (I fat fingered the first one, I mean
the one that identifies as 3.0.2 / 4.9.3.1258). You might like the
results :-)

On Sun, 2020-03-29 at 11:14 -0700, Dirk Hohndel via subsurface wrote:
> 
> > Upon activating the software,  I get a message "No dives in dive
> > list" 
> > this stays on screen about 5 seconds.
> > This is because of a file permission problem because the dive log
> > is
> > not 
> > in the folder where Subsurface-mobile expects it to be.
> 
> Not at all. This is the time it takes to build the full text index on
> your rather old / low performance phone. This isn't a dig about your
> phone, it's simply an explanation for the relatively long wait.
> 
> That said, I think we should change the message that we show there.
> It would make much more sense if the message said something like
> "preparing the dive list".

That should work in the beta.

> > When I tap the filter button, nothing happens.
> 
> You don't see anything happen. If you gently pull down on the dive
> list, I am quite certain that you will see the filter header on top.
> For some reason QML is no longer showing that header by default and I
> need to see if I can figure out why that is the case :-(

That should be fixed. I gave up on relying on QML to magically do the
thing its documentation says it does, and instead created a separate
visual element outside of the ListView for the filter header. This
works on all devices that I tested it on. Reliably.

> > When I double-tap the filter button, the onscreen keyboard opens,
> > but
> > no 
> > filter text box is presented.
> 
> There is actually no specific double-tap action - but weirdly when
> you
> do open-close-open, then on the second open it does show the virtual
> keyboard - but not on the first. Again, no idea why, something to
> investigate.

Also fixed in the beta.

> > One other issue:
> > When opening the Undo/Redo menu and I select the Android Return
> > button 
> > (NOT the X-button the left of the Undo/Redo menu), I exit 
> > Subsurface-mobile. This is counter-intuitive. Upon hitting the
> > Android 
> > RETURN button, it should just close the Undo/Redo menu. This
> > should 
> > probably apply to all submenus
> 
> By RETURN you mean the back arrow?
> Yeah, that's definitely a bug.

Also fixed in the beta.


I would LOVE to see more people test the 3.0.2/4.9.3.1258 (or later)
betas, so I can make another release which addresses these issues.

(of course, Apple hasn't even released 3.0.1, yet...)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Dirk Hohndel via subsurface]

On Sun, 2020-03-29 at 16:05 +0200, Willem Ferguson via subsurface
wrote:
> Below 
> is my experience on a Galaxy J2 (a basic phone) using Android 7.1.1
> and 
> running Subsurface-mobile V4.9.3.1229

Is there a reason why you aren't running the current release?

> Upon activating the software,  I get a message "No dives in dive
> list" 
> this stays on screen about 5 seconds.
> This is because of a file permission problem because the dive log is
> not 
> in the folder where Subsurface-mobile expects it to be.

Not at all. This is the time it takes to build the full text index on
your rather old / low performance phone. This isn't a dig about your
phone, it's simply an explanation for the relatively long wait.

That said, I think we should change the message that we show there.
It would make much more sense if the message said something like
"preparing the dive list".

> I append the log to this mail.
> 
> Then it says "Dives loaded from local dive data file" and the dive
> list 
> is shown as expected.

Good.

> When I tap the filter button, nothing happens.

You don't see anything happen. If you gently pull down on the dive
list, I am quite certain that you will see the filter header on top.
For some reason QML is no longer showing that header by default and I
need to see if I can figure out why that is the case :-(

> When I double-tap the filter button, the onscreen keyboard opens, but
> no 
> filter text box is presented.

There is actually no specific double-tap action - but weirdly when you
do open-close-open, then on the second open it does show the virtual
keyboard - but not on the first. Again, no idea why, something to
investigate.

> With the onscreen keyboard open I blindly continue to type some text
> and 
> hit the RETURN key on the on-screen keyboard.

Again, a slight scroll down would show you the text entry field.

> The correct dives are filtered. When I tap on the filter button now,
> the 
> full dive list is shown again, as expected.

Good.

> One other issue:
> When opening the Undo/Redo menu and I select the Android Return
> button 
> (NOT the X-button the left of the Undo/Redo menu), I exit 
> Subsurface-mobile. This is counter-intuitive. Upon hitting the
> Android 
> RETURN button, it should just close the Undo/Redo menu. This should 
> probably apply to all submenus

By RETURN you mean the back arrow?
Yeah, that's definitely a bug.

> At some stage I unexpectedly got a message "Dive log synced with
> cloud", 
> which was unexpected as I did NOT switch on the autosync feature. I
> have 
> strong feelings about this issue: in the past syncing from mobile
> made 
> unwanted changes to the cloud dive log. This defect is not
> represented 
> in the log file below. I could try and find a repeatable way of
> letting 
> this unwanted sync happen.

I'd be interested in seeing this in a log file. But please with the
current production version (3.0.1 - 4.9.3.1251) as that has some rather
significant changes in the way we access storage.

> One final moan. I attach a screenshot of a dive with a rather long 
> location title. The text overlap with the date/time is obvious. I do
> not 
> know if there is a solution for this.

From past interactions with you on similar issues I know that your
screen has some rather extreme font size to screen size ratio. The
layout tends to work fairly well for more usual font/screen ratios, but
even there I can force similar issues with extremely long location
names. I need to figure out how to better deal with that scenario.
Something else for the todo list.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: releasing Subsurface-mobile 3.0 on Android

[Hartley Horwitz via subsurface]

>
> From: Willem Ferguson 
> To: subsurface@subsurface-divelog.org
> Cc:
> Bcc:
> Date: Sun, 29 Mar 2020 16:05:27 +0200
> Subject: Re: releasing Subsurface-mobile 3.0 on Android
> I assume this discussion is still about Subsurface-mobile on iOs. Below
> is my experience on a Galaxy J2 (a basic phone) using Android 7.1.1 and
> running Subsurface-mobile V4.9.3.1229
>
> Upon activating the software,  I get a message "No dives in dive list"
> …….snip...….
> When I tap the filter button, nothing happens.
> When I double-tap the filter button, the onscreen keyboard opens, but no
> filter text box is presented.
>

Willem - this is the same on iOS.  Can you try tap on the filter button,
then scroll down on the dive list?  On iOS this reveals that the filter
menu was added to the top of the dive list but it just wasn't visible
without scrolling.


> With the onscreen keyboard open I blindly continue to type some text and
> hit the RETURN key on the on-screen keyboard.
>
> The correct dives are filtered. When I tap on the filter button now, the
> full dive list is shown again, as expected.


Hartley
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface