[twdev] Re: TiddlyWiki 5 Dev Hangout #104 will be on Wednesday 17th January at 3pm GMT

[Evan Balster]

I may be a few minutes late to this one; apologies in advance if that's the 
case.

On Monday, 15 January 2018 15:47:21 UTC-6, Jeremy Ruston wrote:
>
> There will be another developer-oriented TiddlyWiki 5 hangout this 
> Wednesday 17th January at 3pm GMT. 
>
> At Evan's request, we'll spend some time discussing the optimisations and 
> architectural improvements that he's been exploring, but hopefully we'll 
> get to some other dev-focussed topics — I'm interested in discussing 
> automating the tiddlywiki.com build process, for instance. 
>
> Also, I'd like to invite others to follow Evan's example and suggest 
> topics and/or formats for future hangouts. 
>
> I'll post the Google Hangout links just here and on Twitter just before we 
> kick things off, 
>
> Best wishes 
>
> Jeremy 
>
>
> -- 
> Jeremy Ruston 
> jer...@jermolene.com  
> https://jermolene.com

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/9c2ab092-cf37-4464-ade1-7dbab596db21%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Possible Bug: prefix-lines doesn't seem to work like documentation states

['Andreas Hahn' via TiddlyWikiDev]

Hi RunningUtes,

as the person who originally documented this feature, I had another look 
at the code and I believe this is a bug, since in the code it seems to 
be supposed to work that way, but on line 37 of 
|$:/core/modules/editor/operations/text/prefix-lines.js|, it seems to 
end up comparing an integer to a string.


/Andreas



Am 17.01.2018 um 06:26 schrieb RunningUtes:
I posted this to the general TW forum 
, 
but no one has responded...



A tm-edit-text-operation is supposed to preform an operation on 
selected text but it doesn't seem to do as the documentation lists.


https://tiddlywiki.com/#WidgetMessage%3A%20tm-edit-text-operation 



If selected text is bolded, the '' is added as a prefix and as a 
suffix. If the same text is already bolded and the operation is run 
again, the '' is removed. See the rules in 
$:/core/ui/EditorToolbar/list-bullet.


This doesn't seem to happen for the prefix-lines operation.

For example, select several lines of text and press the unordered list 
button. A * will be added as a prefix according to the rules in 
$:/core/ui/EditorToolbar/list-bullet. If the same text is selected and 
the unordered list button is pressed again, the * is not removed. In 
fact, nothing happens. The documentation states that the prefix should 
be removed from the selected lines.


Is this a bug in the code of the current TW?

The problem seems to be in 
$:/core/modules/editor/operations/text/prefix-lines.js

--
You received this message because you are subscribed to the Google 
Groups "TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to tiddlywikidev+unsubscr...@googlegroups.com 
.
To post to this group, send email to tiddlywikidev@googlegroups.com 
.

Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/f7f9961a-1f99-4dd5-8307-470a7f61ca93%40googlegroups.com 
.

For more options, visit https://groups.google.com/d/optout.



--
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/20d28dc0-4d43-7fa2-2dc2-1eaf42252efa%40googlemail.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Possible Bug: prefix-lines doesn't seem to work like documentation states

[RunningUtes]

I posted this to the general TW forum 
, but 
no one has responded...


A tm-edit-text-operation is supposed to preform an operation on selected 
text but it doesn't seem to do as the documentation lists.

https://tiddlywiki.com/#WidgetMessage%3A%20tm-edit-text-operation

If selected text is bolded, the '' is added as a prefix and as a suffix. If 
the same text is already bolded and the operation is run again, the '' is 
removed. See the rules in $:/core/ui/EditorToolbar/list-bullet.

This doesn't seem to happen for the prefix-lines operation.

For example, select several lines of text and press the unordered list 
button. A * will be added as a prefix according to the rules in 
$:/core/ui/EditorToolbar/list-bullet. If the same text is selected and the 
unordered list button is pressed again, the * is not removed. In fact, 
nothing happens. The documentation states that the prefix should be removed 
from the selected lines.

Is this a bug in the code of the current TW?

The problem seems to be in 
$:/core/modules/editor/operations/text/prefix-lines.js

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/f7f9961a-1f99-4dd5-8307-470a7f61ca93%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Proposing a plaintext parse & render mode for attributes & more

[Jeremy Ruston]

Hi Evan

> 
> The trouble there is that the plaintext vocabulary wouldn't permit widgets, 
> which would rule out using the list widget. So we would need to be able to 
> select the output mode between HTML and plain text (that's a setting that we 
> already support for transclusion).
> 
>  A "wikified plaintext" vocabulary then.  I imagine that it's necessary to 
> support at least widgets, transclusion, variables and typed blocks for any 
> vocabulary that supports "computation" (and honestly I believe these features 
> should be enabled whenever possible).

Sorry for the confusion, I meant something else. There are two ways that we 
turn the DOM tree generated by the widget tree into text: using either 
innerHTML or textContent. The macrocall widget uses innerHTML when the $output 
parameter is “text/html” and textContent when the $output parameter is 
“text/plain”. The wikify widget extends things with an “output” parameter that 
can be “text” or “html”, or a few special values documented on tw.com.

It may be adequate to always use textContent for widget attributes; one can 
still use an external wikify widget to get the effect of outerHTML.

> The parse rules for <$widgets> and  may need to be separately 
> enabled…

Yes it sounds like that would be useful.

> It would have to [support caching for each vocabulary], yes (just as we 
> currently separately cache the inline vs. block parsing of a tiddler).
> 
> Here's a thought:  Block and inline are essentially vocabularies already.  
> That is, they're sub-divisions of the content type.  Can we just build on 
> that mechanism? 

Indeed, the current implementation of block vs. inline will need substantial 
extension. Indeed, we also need to think through how the block vs. inline logic 
is handled. I’m still hoping we can move most of the logic from the parse stage 
to the rendering stage.

Best wishes

Jeremy

> 
> On Monday, 15 January 2018 15:37:32 UTC-6, Jeremy Ruston wrote:
> Hi Evan
> 
>> Vocabulary as a general concept seems like it fits the bill.  At that point, 
>> "smart" attributes would just be treated as wikitext with the "plaintext" 
>> vocabulary.
> 
> The trouble there is that the plaintext vocabulary wouldn't permit widgets, 
> which would rule out using the list widget. So we would need to be able to 
> select the output mode between HTML and plain text (that's a setting that we 
> already support for transclusion).
> 
>> I have to confess I'd forgotten about typed blocks when I wrote the OP, and 
>> by running at parse-time they solve some of the stickier problems I mention 
>> in the OP.  They provide a simple way to insert "raw" plaintext into 
>> wikified plaintext, and to manipulate the parse settings before widgets are 
>> instantiated...  This puts some questions on my mind:
>> Is it sensible to add vocabulary as another option for typed blocks?
> I have been thinking of the vocabulary as a component of the mime type, not a 
> separate field. The $tw.Tiddler object could explode and cache the 
> components. But I think that some of your thoughts might imply the vocabulary 
> being a separate setting.
>> Would typed blocks would inherit parse settings the markup does not specify? 
>>  (vocabulary & render mode)
> At the moment typed blocks are equivalent to transcluding a tiddler with the 
> specified type and text fields, and parsing pragmas like rules are not 
> inherited. I think we'll need to revisit that.
>> Could widgets detect the parse settings that produced them and employ these 
>> when parsing imported text?
> Widgets aren't necessarily produced directly from a parse tree, and so there 
> might not be any parse settings. Again, we might want to revisit that; if so, 
> variables should be the mechanism for the inheritance.
>> Could the wikiparser cache support caching parse-trees for each vocabulary?
> It would have to, yes (just as we currently separately cache the inline vs. 
> block parsing of a tiddler).
> 
> Best wishes
> 
> Jeremy
> 
>> 
>> On Friday, 12 January 2018 02:02:19 UTC-6, Jeremy Ruston wrote:
>> Hi Evan
>> 
>> I think that this ancient ticket might be roughly equivalent to what you’re 
>> after:
>> 
>> https://github.com/Jermolene/TiddlyWiki5/issues/345 
>> 
>> 
>> The proposal still reflects my thinking in this area.
>> 
>> Best wishes
>> 
>> Jeremy.
>> 
>> 
>>> On 12 Jan 2018, at 04:58, Evan Balster > wrote:
>>> 
>>> Hey, all —
>>> 
>>> Currently TiddlyWiki implements plain-text wikification by applying 
>>> WikiText parsing to generate a DOM, then extracting and concatenating any 
>>> text-widgets in the DOM while discarding everything else.  While this 
>>> functionality is very useful, it has some tricky drawbacks — wikification 
>>> involves (often) unnecessary work processing irrelevant parse rules, and 
>>> anything resembling an  or //wikitext markup will be stripped out, 
>>> when this might be very undesirable (eg, 

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

sure, it's just testing!
 

> If that's you just testing, that's fine.  Otherwise you (the middle man) 
> are stealing a click from me (user) targeting YT itself -- in my view, 
> naughty ;)
>
> On Tuesday, January 16, 2018 at 9:42:01 AM UTC-6, Simon Huber wrote:
>>
>> Ah but... trying to go fullscreen on the yt video fails -- the video 
>>> disappears.
>>>
>>> that's what it should do, as in the stylesheet there's .tw5-burning-tree 
>> .tc-tiddler-frame iframe { display: none; } ... to see if it happens with 
>> yt fullscreen, too
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/8cdae018-0226-4fd9-bf19-945260818891%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[coda coder]

If that's you just testing, that's fine.  Otherwise you (the middle man) 
are stealing a click from me (user) targeting YT itself -- in my view, 
naughty ;)

On Tuesday, January 16, 2018 at 9:42:01 AM UTC-6, Simon Huber wrote:
>
> Ah but... trying to go fullscreen on the yt video fails -- the video 
>> disappears.
>>
>> that's what it should do, as in the stylesheet there's .tw5-burning-tree 
> .tc-tiddler-frame iframe { display: none; } ... to see if it happens with 
> yt fullscreen, too
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/b573a0d4-3485-4664-84e3-14312d59665e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

>
> Ah but... trying to go fullscreen on the yt video fails -- the video 
> disappears.
>
> that's what it should do, as in the stylesheet there's .tw5-burning-tree 
.tc-tiddler-frame iframe { display: none; } ... to see if it happens with 
yt fullscreen, too

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/934a3ffd-94fa-4554-80c8-c89ca8ddfd7e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

that's good news! maybe as Jeremy said, css support is not far away.
thanks for trying it out @coda coder,

@Jeremy I've tried different approaches now and it can be done better than 
the first fast tries but it's a bit a mess and I can't get my head around 
it, too.

not giving up on this, but enough for today

thanks both of you

Am Dienstag, 16. Januar 2018 16:31:42 UTC+1 schrieb coda coder:
>
> Tried FF on Win10 too.  Same.
>
> However (brace yourself) it works on FF 59.0a1, Win7
>
> Can't try Win10 (don't have FF 59).
>
> On Tuesday, January 16, 2018 at 9:26:05 AM UTC-6, coda coder wrote:
>>
>> No, sorry. Same as before.
>>
>> On Tuesday, January 16, 2018 at 8:09:11 AM UTC-6, Simon Huber wrote:
>>>
>>> thanks @coda coder,
>>>
>>> that's bad news, I really want this :D
>>>
>>> I changed something I should have done earlier, if you want to give it 
>>> another try
>>>
>>> I'll investigate further, maybe i get this working, maybe not
>>>
>>> thanks for your help,
>>> Simon
>>>
>>> Am Dienstag, 16. Januar 2018 14:55:23 UTC+1 schrieb coda coder:

 Simon,

 I'm assuming your class addition to the body element should be toggling 
 as I toggle F11?  If so, it's not working here. Your class 
 "tw5-burning-tree" once applied, is never removed.  Your console message 
 always says "not fullscreen" regardless of the actual state.  Also, your 
 class is never applied to the body element of "tc-body 
 tc-single-tiddler-window" windows.

 Win 7, Firefox 57.0.3

 Codacoder


 On Tuesday, January 16, 2018 at 7:26:07 AM UTC-6, Simon Huber wrote:
>
> @Jeremy,
>
> I don't want to bother you too much with this, I've just put something 
> together that works here:
>
> http://tw5fullscreen.tiddlyspot.com
>
> it prevents the F11 key's default event so that we're able to detect 
> the key again when in fullscreen mode, then requests fullscreen and 
> toggles 
> the class. another eventlistener listens for fullscreenchange events and 
> toggles the class
>
> what I need to know for testing and  preparing a pull request if this 
> is reliable is where to put this, would a separate startup module be 
> correct?
>
> thank you,
> Simon
>


-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/cb2969e8-a50b-4445-8f73-c9433f14a9af%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[coda coder]

Ah but... trying to go fullscreen on the yt video fails -- the video 
disappears.

On Tuesday, January 16, 2018 at 9:31:42 AM UTC-6, coda coder wrote:
>
> Tried FF on Win10 too.  Same.
>
> However (brace yourself) it works on FF 59.0a1, Win7
>
> Can't try Win10 (don't have FF 59).
>
> On Tuesday, January 16, 2018 at 9:26:05 AM UTC-6, coda coder wrote:
>>
>> No, sorry. Same as before.
>>
>> On Tuesday, January 16, 2018 at 8:09:11 AM UTC-6, Simon Huber wrote:
>>>
>>> thanks @coda coder,
>>>
>>> that's bad news, I really want this :D
>>>
>>> I changed something I should have done earlier, if you want to give it 
>>> another try
>>>
>>> I'll investigate further, maybe i get this working, maybe not
>>>
>>> thanks for your help,
>>> Simon
>>>
>>> Am Dienstag, 16. Januar 2018 14:55:23 UTC+1 schrieb coda coder:

 Simon,

 I'm assuming your class addition to the body element should be toggling 
 as I toggle F11?  If so, it's not working here. Your class 
 "tw5-burning-tree" once applied, is never removed.  Your console message 
 always says "not fullscreen" regardless of the actual state.  Also, your 
 class is never applied to the body element of "tc-body 
 tc-single-tiddler-window" windows.

 Win 7, Firefox 57.0.3

 Codacoder


 On Tuesday, January 16, 2018 at 7:26:07 AM UTC-6, Simon Huber wrote:
>
> @Jeremy,
>
> I don't want to bother you too much with this, I've just put something 
> together that works here:
>
> http://tw5fullscreen.tiddlyspot.com
>
> it prevents the F11 key's default event so that we're able to detect 
> the key again when in fullscreen mode, then requests fullscreen and 
> toggles 
> the class. another eventlistener listens for fullscreenchange events and 
> toggles the class
>
> what I need to know for testing and  preparing a pull request if this 
> is reliable is where to put this, would a separate startup module be 
> correct?
>
> thank you,
> Simon
>


-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/71c2bad6-fdc2-4f82-92aa-f87763494611%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[coda coder]

Tried FF on Win10 too.  Same.

However (brace yourself) it works on FF 59.0a1, Win7

Can't try Win10 (don't have FF 59).

On Tuesday, January 16, 2018 at 9:26:05 AM UTC-6, coda coder wrote:
>
> No, sorry. Same as before.
>
> On Tuesday, January 16, 2018 at 8:09:11 AM UTC-6, Simon Huber wrote:
>>
>> thanks @coda coder,
>>
>> that's bad news, I really want this :D
>>
>> I changed something I should have done earlier, if you want to give it 
>> another try
>>
>> I'll investigate further, maybe i get this working, maybe not
>>
>> thanks for your help,
>> Simon
>>
>> Am Dienstag, 16. Januar 2018 14:55:23 UTC+1 schrieb coda coder:
>>>
>>> Simon,
>>>
>>> I'm assuming your class addition to the body element should be toggling 
>>> as I toggle F11?  If so, it's not working here. Your class 
>>> "tw5-burning-tree" once applied, is never removed.  Your console message 
>>> always says "not fullscreen" regardless of the actual state.  Also, your 
>>> class is never applied to the body element of "tc-body 
>>> tc-single-tiddler-window" windows.
>>>
>>> Win 7, Firefox 57.0.3
>>>
>>> Codacoder
>>>
>>>
>>> On Tuesday, January 16, 2018 at 7:26:07 AM UTC-6, Simon Huber wrote:

 @Jeremy,

 I don't want to bother you too much with this, I've just put something 
 together that works here:

 http://tw5fullscreen.tiddlyspot.com

 it prevents the F11 key's default event so that we're able to detect 
 the key again when in fullscreen mode, then requests fullscreen and 
 toggles 
 the class. another eventlistener listens for fullscreenchange events and 
 toggles the class

 what I need to know for testing and  preparing a pull request if this 
 is reliable is where to put this, would a separate startup module be 
 correct?

 thank you,
 Simon

>>>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/0e8c4adf-7026-406a-adcf-5fa1aea64809%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[coda coder]

No, sorry. Same as before.

On Tuesday, January 16, 2018 at 8:09:11 AM UTC-6, Simon Huber wrote:
>
> thanks @coda coder,
>
> that's bad news, I really want this :D
>
> I changed something I should have done earlier, if you want to give it 
> another try
>
> I'll investigate further, maybe i get this working, maybe not
>
> thanks for your help,
> Simon
>
> Am Dienstag, 16. Januar 2018 14:55:23 UTC+1 schrieb coda coder:
>>
>> Simon,
>>
>> I'm assuming your class addition to the body element should be toggling 
>> as I toggle F11?  If so, it's not working here. Your class 
>> "tw5-burning-tree" once applied, is never removed.  Your console message 
>> always says "not fullscreen" regardless of the actual state.  Also, your 
>> class is never applied to the body element of "tc-body 
>> tc-single-tiddler-window" windows.
>>
>> Win 7, Firefox 57.0.3
>>
>> Codacoder
>>
>>
>> On Tuesday, January 16, 2018 at 7:26:07 AM UTC-6, Simon Huber wrote:
>>>
>>> @Jeremy,
>>>
>>> I don't want to bother you too much with this, I've just put something 
>>> together that works here:
>>>
>>> http://tw5fullscreen.tiddlyspot.com
>>>
>>> it prevents the F11 key's default event so that we're able to detect the 
>>> key again when in fullscreen mode, then requests fullscreen and toggles the 
>>> class. another eventlistener listens for fullscreenchange events and 
>>> toggles the class
>>>
>>> what I need to know for testing and  preparing a pull request if this is 
>>> reliable is where to put this, would a separate startup module be correct?
>>>
>>> thank you,
>>> Simon
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/4550a5d2-df9e-4dc7-800c-8e95bcb8520b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] [TW5][REQUEST] window fullscreen - applying CLASS on

[Jeremy Ruston]

Hi Simon

> maybe one day :P

To be clear, we just need a cross platform solution that is fully backwards 
compatible. Hopefully, the CSS support will be fixed as that seems the easiest 
approach.

Best wishes

Jeremy

> 
> best wishes, Simon
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to tiddlywikidev@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/6c025cc6-f3a1-40af-a588-f8b445087b51%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/AF5C0521-D543-4ADB-B246-67476A2CDA7F%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

thanks Jeremy,

maybe one day :P

best wishes, Simon

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/6c025cc6-f3a1-40af-a588-f8b445087b51%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] [TW5][REQUEST] window fullscreen - applying CLASS on

[Jeremy Ruston]

Hi Simon

As it’s turned out, I don’t think this current solution is appropriate for the 
core because (a) it breaks some of the usual browser functionality and (b) it 
is somewhat platform specific; for both reasons it isn’t universal enough for 
the core. I think it would be more appropriate for it to be available as a 
plugin so that people can opt to use it if they want to.

Best wishes

Jeremy.



> On 16 Jan 2018, at 14:10, Simon Huber  wrote:
> 
> now i tried it on firefox, too. there it behaves as you report @coda coder
> 
> works for me on chromium
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to tiddlywikidev@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/b74b9463-7d22-4e59-aff7-930b6b6e1c62%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/26A128FC-1C37-45D0-B7EB-929B333A1A55%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

now i tried it on firefox, too. there it behaves as you report @coda coder

works for me on chromium

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/b74b9463-7d22-4e59-aff7-930b6b6e1c62%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

thanks @coda coder,

that's bad news, I really want this :D

I changed something I should have done earlier, if you want to give it 
another try

I'll investigate further, maybe i get this working, maybe not

thanks for your help,
Simon

Am Dienstag, 16. Januar 2018 14:55:23 UTC+1 schrieb coda coder:
>
> Simon,
>
> I'm assuming your class addition to the body element should be toggling as 
> I toggle F11?  If so, it's not working here. Your class "tw5-burning-tree" 
> once applied, is never removed.  Your console message always says "not 
> fullscreen" regardless of the actual state.  Also, your class is never 
> applied to the body element of "tc-body tc-single-tiddler-window" windows.
>
> Win 7, Firefox 57.0.3
>
> Codacoder
>
>
> On Tuesday, January 16, 2018 at 7:26:07 AM UTC-6, Simon Huber wrote:
>>
>> @Jeremy,
>>
>> I don't want to bother you too much with this, I've just put something 
>> together that works here:
>>
>> http://tw5fullscreen.tiddlyspot.com
>>
>> it prevents the F11 key's default event so that we're able to detect the 
>> key again when in fullscreen mode, then requests fullscreen and toggles the 
>> class. another eventlistener listens for fullscreenchange events and 
>> toggles the class
>>
>> what I need to know for testing and  preparing a pull request if this is 
>> reliable is where to put this, would a separate startup module be correct?
>>
>> thank you,
>> Simon
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/ab50b863-63d5-4eb3-9b3b-9703b92e3f78%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[coda coder]

Simon,

I'm assuming your class addition to the body element should be toggling as 
I toggle F11?  If so, it's not working here. Your class "tw5-burning-tree" 
once applied, is never removed.  Your console message always says "not 
fullscreen" regardless of the actual state.  Also, your class is never 
applied to the body element of "tc-body tc-single-tiddler-window" windows.

Win 7, Firefox 57.0.3

Codacoder


On Tuesday, January 16, 2018 at 7:26:07 AM UTC-6, Simon Huber wrote:
>
> @Jeremy,
>
> I don't want to bother you too much with this, I've just put something 
> together that works here:
>
> http://tw5fullscreen.tiddlyspot.com
>
> it prevents the F11 key's default event so that we're able to detect the 
> key again when in fullscreen mode, then requests fullscreen and toggles the 
> class. another eventlistener listens for fullscreenchange events and 
> toggles the class
>
> what I need to know for testing and  preparing a pull request if this is 
> reliable is where to put this, would a separate startup module be correct?
>
> thank you,
> Simon
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/c1c65544-850d-4f8a-a3c8-6d680b71e726%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

@Jeremy,

I don't want to bother you too much with this, I've just put something 
together that works here:

http://tw5fullscreen.tiddlyspot.com

it prevents the F11 key's default event so that we're able to detect the 
key again when in fullscreen mode, then requests fullscreen and toggles the 
class. another eventlistener listens for fullscreenchange events and 
toggles the class

what I need to know for testing and  preparing a pull request if this is 
reliable is where to put this, would a separate startup module be correct?

thank you,
Simon

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/c991f23b-7e73-4dba-9309-d3eac3eb3396%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

>
> and it does what I expect from this, it adds the class to the body if 
> fullscreen.
>
> could this be implemented correctly in the core?
>
>
> A change along those lines wouldn’t cover the situation where the user 
> uses a browser control like the F11 key to enter full screen mode.
>

it's the wrong place there, I guessed so ... :) it was handy to put it 
there. I haven't figured out where the best place could be for detecting 
this

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/d8a3c5e9-8094-42a0-a064-fe2c6a6c8657%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

thank you, Jeremy!

I'm going to give it a try, when I find a solution I'll make the pull 
request

all the best,
Simon

Am Dienstag, 16. Januar 2018 09:32:29 UTC+1 schrieb Jeremy Ruston:
>
> Hi Simon
>
> and it does what I expect from this, it adds the class to the body if 
> fullscreen.
>
> could this be implemented correctly in the core?
>
>
> A change along those lines wouldn’t cover the situation where the user 
> uses a browser control like the F11 key to enter full screen mode.
>
> It appears that this is one of those tricky challenges in web development, 
> and there may not be a good solution:
>
>
> https://stackoverflow.com/questions/21461890/browser-f11-fullscreen-does-not-register-with-webkit-full-screen-or-javascript
>
> If there is a workable solution out there I’d be happy to accept a pull 
> request,
>
> Best wishes
>
> Jeremy.
>
>
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikide...@googlegroups.com .
> To post to this group, send email to tiddly...@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/30ea0b01-7601-4436-ac0d-e047b1a45105%40googlegroups.com
>  
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/02c63b9f-53f0-4868-8507-c82841eeca12%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Jeremy Ruston]

Hi Simon

> and it does what I expect from this, it adds the class to the body if 
> fullscreen.
> 
> could this be implemented correctly in the core?

A change along those lines wouldn’t cover the situation where the user uses a 
browser control like the F11 key to enter full screen mode.

It appears that this is one of those tricky challenges in web development, and 
there may not be a good solution:

https://stackoverflow.com/questions/21461890/browser-f11-fullscreen-does-not-register-with-webkit-full-screen-or-javascript
 


If there is a workable solution out there I’d be happy to accept a pull request,

Best wishes

Jeremy.


> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to tiddlywikidev@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/30ea0b01-7601-4436-ac0d-e047b1a45105%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/D5AEF1DA-9875-49F4-A654-6393CCFE1BB1%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

[Simon Huber]

In the saver-handler.js I just added

if( window.innerHeight == screen.height) {
// browser is fullscreen
$tw.utils.toggleClass(document.body,"tc-fullscreen",true);
}

and it does what I expect from this, it adds the class to the body if 
fullscreen.

could this be implemented correctly in the core?

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/30ea0b01-7601-4436-ac0d-e047b1a45105%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.