Re: [U-Boot] Acccessing IRAM in MX53
> From: Stefano Babic [mailto:sba...@denx.de] > MX53LOCO U-Boot > md 0xF800 > f800: 5f04dbd6 e0a62773 fa92b272 e85f7213..._s'..rr_. > f810: 946065a3 fbe525ce 0cedf27e d2f2e4df.e`..%..~... > f820: e7d76787 e8e97cfe 49927a97 d2b1a033.g...|...z.I3... > f830: e84ac878 ec76c015 4fde5c14 338d88c8x.J...v..\.O...3 > f840: f797b909 fabf35ba 9dee0101 61b6c523.5..#..a > f850: 3a9057e3 dbea4c77 8347b4bd bcbce01a.W.:wLG. >iram is read flawlessy. Yes, it seems that it works. I tried that command in my U-boot and it works ok. I didn't remember those memory dump command. I'll have to investigate how it's read and copy that to my code. About the MMU. I saw some MMU settings used and assumed that MMU was used although I assumed too that it's not used. But anyway. Thanks. I think I can continue from here. -Teemu ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM: bcm2835: add Raspberry Pi model B board
On 06/15/2012 11:42 PM, Graeme Russ wrote: > Hi Stephen, > > On 06/07/2012 03:45 PM, Stephen Warren wrote: >> The Raspberry Pi model B uses the BCM2835 SoC, has 256MB of RAM, contains >> an SMSC 9512 USB LAN/Hub chip, and various IO connectors. For more details, >> see http://www.raspberrypi.org/. >> >> Signed-off-by: Stephen Warren > > Now I really can't wait for my Raspberry Pi to turn up (due on 25 June) > > Looking forward to trying this out - any hints / traps for young players? Mostly U-Boot on RPi works like it would anywhere else. The few things to watch out for are: a) Pick the correct toolchain to build with. For my branch, I assumed everyone was building for armhf/hardfp these days, and so from the tools repo: https://github.com/raspberrypi/tools.git I picked the toolchain in the x86-linux64-cross-arm-linux-hardfp sub-directory, and adjusted the U-Boot Makefiles to suite options required for that toolchain. However, Oleksandr's U-Boot branch appears to rely upon the armel/softfp toolchain in the linux-x86 sub-directory. b) You need to appropriate stuff in config.txt on the SD card - I apparently have: device_tree=kernel.dtb device_tree_address=0x100 kernel_address=0x8000 disable_commandline_tags=1 and I store U-Boot in kernel.img. (although I think the DT-related values are irrelevant when I'm booting U-Boot instead of a kernel) You will of course need a 3.3v serial->something (USB or true RS232) adapter hooked up to GPIO header pins 6/8/10 for the console, since there's no video output support in U-Boot yet (although I suppose we could add USB keyboard support soon...) Oh, and you'll probably want to update the binary firmware images on your SD card to the latest from: https://github.com/raspberrypi/firmware.git The following email from Oleksandr will be interesting too: http://lists.infradead.org/pipermail/linux-rpi-kernel/2012-June/60.html Of course, this is all if you specifically want to use U-Boot. The default boot process already works completely, without involving U-Boot, but of course doesn't support e.g. network booting. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] i.MX refactoring patchset
Dear Otavio Salvador, > This patchset include minor changes for i.MX; mainly: > > 1/3: improves the rare case of unkown booting machine The word's actually "unknown" ;-D > 2/3: generalize the code so it works for i.MX23 and i.MX28 > > The patch 3/3 is what we've been using in Yocto and has been change to > affect only mx28evk. > > Otavio Salvador (3): > imx: Use a clear identification of an unidentified CPU type > mxs: generalize code for print_cpuinfo() > mx28evk: extend default environment It's good, really good :-) > arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++- > arch/arm/cpu/armv7/imx-common/cpu.c |4 +- > include/configs/mx28evk.h | 83 > +++ 3 files changed, 104 insertions(+), 12 > deletions(-) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Environement in NVRAM
Dear Ran Shalit, > Hello, > > Is there a way to save environemnet in NVRAM ? > I did not find any information about that. Check source ... common/env_nvram.c maybe ? > Best Regards, > Ran Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Environement in NVRAM
Hello, Is there a way to save environemnet in NVRAM ? I did not find any information about that. Best Regards, Ran ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
Dear Otavio Salvador, > On Sun, Jun 17, 2012 at 2:56 PM, Stefano Babic wrote: > >> Correct, but isn't the return value mangled somehow (like having major > >> rev. << 16 and minor rev. << 0 )? Or that's only IMX? > > > > Checking in current implementations for get_cpu_rev() (i.MX / OMAP24 / > > OMAP3 / AM33, and even board/apollon/sys_info.c: I do not know why the > > cpu detection is inseide this file), none of them requires strictly 32 > > bit. However, we should be coherent in all code - for this reason I > > dislike if one of the i.MX is implemented differently as for other SOCs. > > So, we change this one to follow the others or fix the others? Fix the others ;-) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
Dear Stefano Babic, > On 17/06/2012 19:50, Otavio Salvador wrote: > > On Sun, Jun 17, 2012 at 1:03 PM, Marek Vasut wrote: > >>> But really, I don't mind it being included or not. I did it because > >>> Marek has comment about it when looking at my initial mx23 patches. > >> > >> And I like it more, it looks less like a typo. > > > > Sorry; I didn't get what you meant ... should it go or not? > > Hi Otavio, > > I make also my point clearer for Marek: my point is that the behavior > for all i.MX must be consistent. If you change here, please change also > for i.MX31 (that returns "unknown in print_cpuinfo) and for other SOCs > that returns "unknown" in print_cpuinfo() - or let the code as now. Ah, I thought it was about the revision. Ok, whatever way is fine by me. > Best regards, > Stefano Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
Dear Otavio Salvador, > On Sun, Jun 17, 2012 at 1:03 PM, Marek Vasut wrote: > >> But really, I don't mind it being included or not. I did it because > >> Marek has comment about it when looking at my initial mx23 patches. > > > > And I like it more, it looks less like a typo. > > Sorry; I didn't get what you meant ... should it go or not? It doesn't look like a typing mistake (i.MX vs. i.MXunknown) => I like it more with "<" ">". Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On 17/06/2012 19:50, Otavio Salvador wrote: > On Sun, Jun 17, 2012 at 1:03 PM, Marek Vasut wrote: >>> But really, I don't mind it being included or not. I did it because >>> Marek has comment about it when looking at my initial mx23 patches. >> >> And I like it more, it looks less like a typo. > > Sorry; I didn't get what you meant ... should it go or not? Hi Otavio, I make also my point clearer for Marek: my point is that the behavior for all i.MX must be consistent. If you change here, please change also for i.MX31 (that returns "unknown in print_cpuinfo) and for other SOCs that returns "unknown" in print_cpuinfo() - or let the code as now. Best regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
Dear Stefano Babic,
> On 17/06/2012 18:02, Marek Vasut wrote:
> >> I like that there will be support for i.MX23, too. But I dislike that
> >> everything takes the name "MX28". As you suggest in your subject, maybe
> >> it is time to rename directories, and use "mxs" (as in kernel) instead
> >> of mx28.
> >
> > We can do that eventually, later ... it depends on the ordering of
> > Otavio's patches, I'm fine either way.
>
> Fine with me - anyway, it is something must be done.
>
> >>> +
> >>> +static u8 get_cpu_rev(void)
> >>> +{
> >>> + struct mx28_digctl_regs *digctl_regs =
> >>> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> >>> +
> >>> + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
> >>> +}
> >>
> >> Everywhere (i.MX, omap, ...) get_cpu_rev returns u32. The function is
> >> currently exported, too.
> >
> > Correct, but isn't the return value mangled somehow (like having major
> > rev. << 16 and minor rev. << 0 )? Or that's only IMX?
>
> Checking in current implementations for get_cpu_rev() (i.MX / OMAP24 /
> OMAP3 / AM33, and even board/apollon/sys_info.c: I do not know why the
> cpu detection is inseide this file), none of them requires strictly 32
> bit. However, we should be coherent in all code - for this reason I
> dislike if one of the i.MX is implemented differently as for other SOCs.
+1
> Best regards,
> Stefano Babic
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 2:56 PM, Stefano Babic wrote: >> Correct, but isn't the return value mangled somehow (like having major rev. >> << >> 16 and minor rev. << 0 )? Or that's only IMX? > > Checking in current implementations for get_cpu_rev() (i.MX / OMAP24 / > OMAP3 / AM33, and even board/apollon/sys_info.c: I do not know why the > cpu detection is inseide this file), none of them requires strictly 32 > bit. However, we should be coherent in all code - for this reason I > dislike if one of the i.MX is implemented differently as for other SOCs. So, we change this one to follow the others or fix the others? -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On 17/06/2012 18:02, Marek Vasut wrote:
>> I like that there will be support for i.MX23, too. But I dislike that
>> everything takes the name "MX28". As you suggest in your subject, maybe
>> it is time to rename directories, and use "mxs" (as in kernel) instead
>> of mx28.
>
> We can do that eventually, later ... it depends on the ordering of Otavio's
> patches, I'm fine either way.
Fine with me - anyway, it is something must be done.
>
>>> +
>>> +static u8 get_cpu_rev(void)
>>> +{
>>> + struct mx28_digctl_regs *digctl_regs =
>>> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
>>> +
>>> + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
>>> +}
>>
>> Everywhere (i.MX, omap, ...) get_cpu_rev returns u32. The function is
>> currently exported, too.
>
> Correct, but isn't the return value mangled somehow (like having major rev.
> <<
> 16 and minor rev. << 0 )? Or that's only IMX?
Checking in current implementations for get_cpu_rev() (i.MX / OMAP24 /
OMAP3 / AM33, and even board/apollon/sys_info.c: I do not know why the
cpu detection is inseide this file), none of them requires strictly 32
bit. However, we should be coherent in all code - for this reason I
dislike if one of the i.MX is implemented differently as for other SOCs.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On Sun, Jun 17, 2012 at 1:03 PM, Marek Vasut wrote: >> But really, I don't mind it being included or not. I did it because >> Marek has comment about it when looking at my initial mx23 patches. > > And I like it more, it looks less like a typo. Sorry; I didn't get what you meant ... should it go or not? -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 12:49 PM, Stefano Babic wrote:
> I like that there will be support for i.MX23, too. But I dislike that
> everything takes the name "MX28". As you suggest in your subject, maybe
> it is time to rename directories, and use "mxs" (as in kernel) instead
> of mx28.
I have it in my wip branch; I'd like to hold it until I have mx23
working so I have freedom to rework the patches.
I can split it on mx28 part and leave mx23 on my branch; this does
looks nicer for me.
>> +static u8 get_cpu_rev(void)
>> +{
>> + struct mx28_digctl_regs *digctl_regs =
>> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
>> +
>> + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
>> +}
>
> Everywhere (i.MX, omap, ...) get_cpu_rev returns u32. The function is
> currently exported, too.
I change it then.
Will fix it.
--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
Dear Otavio Salvador, > On Sun, Jun 17, 2012 at 12:43 PM, Stefano Babic wrote: > >> - return "unknown"; > >> + return ""; > > > > Taste ist taste... but why is better that unknown ? > > For me it gives a visual indication that we didn't meant to support a > i.MXunknown processor ;-) i.MX make it easy to spot > this. > > But really, I don't mind it being included or not. I did it because > Marek has comment about it when looking at my initial mx23 patches. And I like it more, it looks less like a typo. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
Dear Stefano Babic,
> On 17/06/2012 14:58, Otavio Salvador wrote:
> > The information now is gathered from HW_DIGCTL_CHIPID register and
> > includes the revision of the chip on the output.
> >
> > Signed-off-by: Otavio Salvador
> > Cc: Marek Vasut
> > Cc: Stefano Babic
> > Cc: Fabio Estevam
> > ---
>
> Hi Otavio,
>
> > arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++--
> > 1 file changed, 27 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> > b/arch/arm/cpu/arm926ejs/mx28/mx28.c index a82ff25..ac2f2e0 100644
> > --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> > +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> > @@ -190,13 +190,38 @@ int arch_cpu_init(void)
> >
> > #endif
> >
> > #if defined(CONFIG_DISPLAY_CPUINFO)
> >
> > +static const char *get_cpu_type(void)
> > +{
> > + struct mx28_digctl_regs *digctl_regs =
> > + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> > +
> > + switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
> > + case 0x2800:
> > + return "28";
> > + case 0x3728:
> > + return "23";
> > + default:
> > + return "";
> > + }
> > +}
>
> I like that there will be support for i.MX23, too. But I dislike that
> everything takes the name "MX28". As you suggest in your subject, maybe
> it is time to rename directories, and use "mxs" (as in kernel) instead
> of mx28.
We can do that eventually, later ... it depends on the ordering of Otavio's
patches, I'm fine either way.
> > +
> > +static u8 get_cpu_rev(void)
> > +{
> > + struct mx28_digctl_regs *digctl_regs =
> > + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> > +
> > + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
> > +}
>
> Everywhere (i.MX, omap, ...) get_cpu_rev returns u32. The function is
> currently exported, too.
Correct, but isn't the return value mangled somehow (like having major rev. <<
16 and minor rev. << 0 )? Or that's only IMX?
>
> Best regards,
> Stefano Babic
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On 17/06/2012 14:58, Otavio Salvador wrote:
> The information now is gathered from HW_DIGCTL_CHIPID register and
> includes the revision of the chip on the output.
>
> Signed-off-by: Otavio Salvador
> Cc: Marek Vasut
> Cc: Stefano Babic
> Cc: Fabio Estevam
> ---
Hi Otavio,
> arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> index a82ff25..ac2f2e0 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -190,13 +190,38 @@ int arch_cpu_init(void)
> #endif
>
> #if defined(CONFIG_DISPLAY_CPUINFO)
> +static const char *get_cpu_type(void)
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
> + case 0x2800:
> + return "28";
> + case 0x3728:
> + return "23";
> + default:
> + return "";
> + }
> +}
I like that there will be support for i.MX23, too. But I dislike that
everything takes the name "MX28". As you suggest in your subject, maybe
it is time to rename directories, and use "mxs" (as in kernel) instead
of mx28.
> +
> +static u8 get_cpu_rev(void)
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
> +}
Everywhere (i.MX, omap, ...) get_cpu_rev returns u32. The function is
currently exported, too.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On Sun, Jun 17, 2012 at 12:43 PM, Stefano Babic wrote: >> - return "unknown"; >> + return ""; > > Taste ist taste... but why is better that unknown ? For me it gives a visual indication that we didn't meant to support a i.MXunknown processor ;-) i.MX make it easy to spot this. But really, I don't mind it being included or not. I did it because Marek has comment about it when looking at my initial mx23 patches. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On 17/06/2012 14:58, Otavio Salvador wrote:
> In case an unidentified CPU type is detected it now returns
> i.MX, in a const char.
>
> Signed-off-by: Otavio Salvador
> Cc: Marek Vasut
> Cc: Stefano Babic
> Cc: Fabio Estevam
> ---
Hi Otavio,
> arch/arm/cpu/armv7/imx-common/cpu.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/imx-common/cpu.c
> b/arch/arm/cpu/armv7/imx-common/cpu.c
> index b3195dd..77aac7d 100644
> --- a/arch/arm/cpu/armv7/imx-common/cpu.c
> +++ b/arch/arm/cpu/armv7/imx-common/cpu.c
> @@ -66,7 +66,7 @@ char *get_reset_cause(void)
>
> #if defined(CONFIG_DISPLAY_CPUINFO)
>
> -static char *get_imx_type(u32 imxtype)
> +static const char *get_imx_type(u32 imxtype)
> {
> switch (imxtype) {
> case 0x63:
> @@ -80,7 +80,7 @@ static char *get_imx_type(u32 imxtype)
> case 0x53:
> return "53";
> default:
> - return "unknown";
> + return "";
Taste ist taste... but why is better that unknown ?
Stefano
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 12:10 PM, Marek Vasut wrote: >> I fixed it locally; Fabio will check the masking for mx28 revision and >> when I get it I update the patch according. > > It's 0x2800 ... roll out a new version ;-) We are in doubt about the revision, not product code ;-) -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] EXT2 cleanup
Dear Wolfgang Denk, > So, I cleaned up the ext2 filesystem code a bit. I tried to separate the > changes to increase the reviewability. > > Marek Vasut (8): > EXT2: Indent cleanup of dev.c > EXT2: Indent cleanup ext2fs.c > EXT2: Rework ext2fs_blockgroup() function > EXT2: Rework ext2fs_read_file() > EXT2: Rework ext2fs_read_symlink() > EXT2: Rework ext2fs_find_file1() > EXT2: Rework ext2fs_iterate_dir() > EXT2: Rework ext2fs_read_block() > > fs/ext2/dev.c| 74 +++--- > fs/ext2/ext2fs.c | 775 > +++--- 2 files changed, > 416 insertions(+), 433 deletions(-) I see no objections, can we apply these please? Do you prefer pullRQ via staging or will you pick them from PW? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
Dear Otavio Salvador, > On Sun, Jun 17, 2012 at 10:25 AM, Fabio Estevam wrote: > > Reading the Reference Manual I read 0x3780 instead. > > Indeed; I must have typoed it when writting it back. > > I fixed it locally; Fabio will check the masking for mx28 revision and > when I get it I update the patch according. It's 0x2800 ... roll out a new version ;-) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 10:25 AM, Fabio Estevam wrote: > Reading the Reference Manual I read 0x3780 instead. Indeed; I must have typoed it when writting it back. I fixed it locally; Fabio will check the masking for mx28 revision and when I get it I update the patch according. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 10:35 AM, Marek Vasut wrote: > What's the code for mx6q? They dropped this register from it it seems ;-) mx6 code does read the SoC type and revision correctly. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
Dear Fabio Estevam,
> On Sun, Jun 17, 2012 at 9:58 AM, Otavio Salvador
>
> wrote:
> > #if defined(CONFIG_DISPLAY_CPUINFO)
> > +static const char *get_cpu_type(void)
> > +{
> > + struct mx28_digctl_regs *digctl_regs =
> > + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> > +
> > + switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
> > + case 0x2800:
> > + return "28";
>
> > + case 0x3728:
> Reading the Reference Manual I read 0x3780 instead.
Good catch ;-)
What's the code for mx6q? They dropped this register from it it seems ;-)
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
Dear Fabio Estevam, > On Sun, Jun 17, 2012 at 10:09 AM, Otavio Salvador > > wrote: > > On Sun, Jun 17, 2012 at 10:05 AM, Fabio Estevam wrote: > >>>default: > >>> - return "unknown"; > >>> + return ""; > >> > >> I really don't see any improvement here. > > > > It is just to avoid a i.MXunkown return; besides this is how I am > > doing in the mx23 code too. > > This is OK. If you read "i.MXunkown" things are too broken already > because the chip version could not be read. > > Reading "i.MX" will make things no better. This was from my head actually ... and I think this is better. The text is at least not mangled so badly. So let's keep it. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
Dear Otavio Salvador,
> The information now is gathered from HW_DIGCTL_CHIPID register and
> includes the revision of the chip on the output.
>
> Signed-off-by: Otavio Salvador
> Cc: Marek Vasut
> Cc: Stefano Babic
> Cc: Fabio Estevam
> ---
> arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> b/arch/arm/cpu/arm926ejs/mx28/mx28.c index a82ff25..ac2f2e0 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -190,13 +190,38 @@ int arch_cpu_init(void)
> #endif
>
> #if defined(CONFIG_DISPLAY_CPUINFO)
> +static const char *get_cpu_type(void)
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
#define that >> 16 ... maybe offset? I'd define a mask though, see below.
#define PRODUCT_CODE_MASK (0x << 16)
> + case 0x2800:
#define this as something ... #define PRODUCT_CODE_MX28 (0x2800 << 16)
> + return "28";
> + case 0x3728:
> + return "23";
> + default:
> + return "";
So X-Files-ish ;-)
> + }
> +}
> +
> +static u8 get_cpu_rev(void)
uint8_t ... maybe? it's used throughout the code, so let's keep consistent.
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
> +}
> +
> int print_cpuinfo(void)
> {
> struct mx28_spl_data *data = (struct mx28_spl_data *)
> ((CONFIG_SYS_TEXT_BASE - sizeof(struct mx28_spl_data)) & ~0xf);
>
> - printf("Freescale i.MX28 family at %d MHz\n",
> - mxc_get_clock(MXC_ARM_CLK) / 100);
> + printf("CPU: Freescale i.MX%s rev%d at %d MHz\n",
> + get_cpu_type(),
> + get_cpu_rev(),
> + mxc_get_clock(MXC_ARM_CLK) / 100);
> printf("BOOT: %s\n", mx28_boot_modes[data->boot_mode_idx].mode);
> return 0;
> }
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 9:58 AM, Otavio Salvador
wrote:
> #if defined(CONFIG_DISPLAY_CPUINFO)
> +static const char *get_cpu_type(void)
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
> + case 0x2800:
> + return "28";
> + case 0x3728:
Reading the Reference Manual I read 0x3780 instead.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On Sun, Jun 17, 2012 at 10:13 AM, Fabio Estevam wrote: > Reading "i.MX" will make things no better. OK; I'll drop it from the patch queue then. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On Sun, Jun 17, 2012 at 10:09 AM, Otavio Salvador wrote: > On Sun, Jun 17, 2012 at 10:05 AM, Fabio Estevam wrote: >>> default: >>> - return "unknown"; >>> + return ""; >> >> I really don't see any improvement here. > > It is just to avoid a i.MXunkown return; besides this is how I am > doing in the mx23 code too. This is OK. If you read "i.MXunkown" things are too broken already because the chip version could not be read. Reading "i.MX" will make things no better. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
On Sun, Jun 17, 2012 at 9:58 AM, Otavio Salvador
wrote:
> The information now is gathered from HW_DIGCTL_CHIPID register and
> includes the revision of the chip on the output.
>
> Signed-off-by: Otavio Salvador
> Cc: Marek Vasut
> Cc: Stefano Babic
> Cc: Fabio Estevam
> ---
> arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> index a82ff25..ac2f2e0 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -190,13 +190,38 @@ int arch_cpu_init(void)
> #endif
>
> #if defined(CONFIG_DISPLAY_CPUINFO)
> +static const char *get_cpu_type(void)
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
> + case 0x2800:
> + return "28";
> + case 0x3728:
> + return "23";
> + default:
> + return "";
> + }
> +}
> +
> +static u8 get_cpu_rev(void)
> +{
> + struct mx28_digctl_regs *digctl_regs =
> + (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
> +
> + return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
> +}
> +
> int print_cpuinfo(void)
> {
> struct mx28_spl_data *data = (struct mx28_spl_data *)
> ((CONFIG_SYS_TEXT_BASE - sizeof(struct mx28_spl_data)) & ~0xf);
>
> - printf("Freescale i.MX28 family at %d MHz\n",
> - mxc_get_clock(MXC_ARM_CLK) / 100);
> + printf("CPU: Freescale i.MX%s rev%d at %d MHz\n",
In all other i.MX SoCs we display the revision as rev%d.%d, for example:
rev1.0 , rev1.1 , etc.
I think we should print it in the same format here (x.y)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On Sun, Jun 17, 2012 at 10:05 AM, Fabio Estevam wrote: >> default: >> - return "unknown"; >> + return ""; > > I really don't see any improvement here. It is just to avoid a i.MXunkown return; besides this is how I am doing in the mx23 code too. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
On Sun, Jun 17, 2012 at 9:58 AM, Otavio Salvador
wrote:
> -static char *get_imx_type(u32 imxtype)
> +static const char *get_imx_type(u32 imxtype)
This is OK, but ...
> {
> switch (imxtype) {
> case 0x63:
> @@ -80,7 +80,7 @@ static char *get_imx_type(u32 imxtype)
> case 0x53:
> return "53";
> default:
> - return "unknown";
> + return "";
I really don't see any improvement here.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] mx28evk: extend default environment
The environment has been based on mx53loco and m28evk but keeping the
possibility to easy change the default console device as Freescale and
mainline kernels differ on the device name.
Signed-off-by: Otavio Salvador
Cc: Marek Vasut
Cc: Stefano Babic
Cc: Wolfgang Denk
Cc: Fabio Estevam
---
include/configs/mx28evk.h | 83 -
1 file changed, 75 insertions(+), 8 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index e98a746..889d58a 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -234,7 +234,6 @@
#define CONFIG_SETUP_MEMORY_TAGS
#define CONFIG_BOOTDELAY 3
#define CONFIG_BOOTFILE"uImage"
-#define CONFIG_BOOTCOMMAND "run bootcmd_net"
#define CONFIG_LOADADDR0x4200
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
#define CONFIG_OF_LIBFDT
@@ -243,13 +242,81 @@
* Extra Environments
*/
#define CONFIG_EXTRA_ENV_SETTINGS \
- "console_fsl=console=ttyAM0" \
- "console_mainline=console=ttyAMA0" \
- "netargs=setenv bootargs console=${console_mainline}" \
+ "update_nand_full_filename=u-boot.nand\0" \
+ "update_nand_firmware_filename=u-boot.sb\0" \
+ "update_sd_firmware_filename=u-boot.sd\0" \
+ "update_nand_firmware_maxsz=0x10\0" \
+ "update_nand_stride=0x40\0" /* MX28 datasheet ch. 12.12 */ \
+ "update_nand_count=0x4\0" /* MX28 datasheet ch. 12.12 */ \
+ "update_nand_get_fcb_size=" /* Get size of FCB blocks */ \
+ "nand device 0 ; " \
+ "nand info ; " \
+ "setexpr fcb_sz ${update_nand_stride} * ${update_nand_count};" \
+ "setexpr update_nand_fcb ${fcb_sz} * ${nand_writesize}\0" \
+ "update_nand_full=" /* Update FCB, DBBT and FW */ \
+ "if tftp ${update_nand_full_filename} ; then " \
+ "run update_nand_get_fcb_size ; " \
+ "nand scrub -y 0x0 ${filesize} ; " \
+ "nand write.raw ${loadaddr} 0x0 ${update_nand_fcb} ; " \
+ "setexpr update_off ${loadaddr} + ${update_nand_fcb} ; " \
+ "setexpr update_sz ${filesize} - ${update_nand_fcb} ; " \
+ "nand write ${update_off} ${update_nand_fcb} ${update_sz} ; " \
+ "fi\0" \
+ "update_nand_firmware=" /* Update only firmware */ \
+ "if tftp ${update_nand_firmware_filename} ; then " \
+ "run update_nand_get_fcb_size ; " \
+ "setexpr fcb_sz ${update_nand_fcb} * 2 ; " /* FCB + DBBT */ \
+ "setexpr fw_sz ${update_nand_firmware_maxsz} * 2 ; " \
+ "setexpr fw_off ${fcb_sz} + ${update_nand_firmware_maxsz};" \
+ "nand erase ${fcb_sz} ${fw_sz} ; " \
+ "nand write ${loadaddr} ${fcb_sz} ${filesize} ; " \
+ "nand write ${loadaddr} ${fw_off} ${filesize} ; " \
+ "fi\0" \
+ "update_sd_firmware=" /* Update the SD firmware partition */ \
+ "if mmc rescan ; then " \
+ "if tftp ${update_sd_firmware_filename} ; then " \
+ "setexpr fw_sz ${filesize} / 0x200 ; " /* SD block size */ \
+ "setexpr fw_sz ${fw_sz} + 1 ; " \
+ "mmc write ${loadaddr} 0x800 ${fw_sz} ; " \
+ "fi ; " \
+ "fi\0" \
+ "script=boot.scr\0" \
+ "uimage=uImage\0" \
+ "console_fsl=ttyAM0\0" \
+ "console_mainline=ttyAMA0\0" \
+ "console=${console_mainline}\0" \
+ "mmcdev=0\0" \
+ "mmcpart=2\0" \
+ "mmcroot=/dev/mmcblk0p3 rw\0" \
+ "mmcrootfstype=ext3 rootwait\0" \
+ "mmcargs=setenv bootargs console=${console},${baudrate} " \
+ "root=${mmcroot} " \
+ "rootfstype=${mmcrootfstype}\0" \
+ "loadbootscript=" \
+ "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+ "bootscript=echo Running bootscript from mmc ...; " \
+ "source\0" \
+ "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
+ "mmcboot=echo Booting from mmc ...; " \
+ "run mmcargs; " \
+ "bootm\0" \
+ "netargs=setenv bootargs console=${console},${baudrate} " \
"root=/dev/nfs " \
- "ip=dhcp nfsroot=${serverip}:${nfsroot}\0" \
- "bootcmd_net=echo Booting from net ...; " \
- "run netargs; " \
- "dhcp ${uimage}; bootm\0" \
+ "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
+ "netboot=echo Booting from net ...; " \
+ "run netargs; " \
+ "dhcp ${uimage}; bootm\0"
+
+#define CONFIG_BOOTCOMMAND \
+ "if mmc rescan ${mmcdev}; then " \
+ "if run loadbootscript; then " \
+ "run bootscript; " \
+ "else " \
+ "if run loaduimage; then " \
+
[U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()
The information now is gathered from HW_DIGCTL_CHIPID register and
includes the revision of the chip on the output.
Signed-off-by: Otavio Salvador
Cc: Marek Vasut
Cc: Stefano Babic
Cc: Fabio Estevam
---
arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c
b/arch/arm/cpu/arm926ejs/mx28/mx28.c
index a82ff25..ac2f2e0 100644
--- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
+++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
@@ -190,13 +190,38 @@ int arch_cpu_init(void)
#endif
#if defined(CONFIG_DISPLAY_CPUINFO)
+static const char *get_cpu_type(void)
+{
+ struct mx28_digctl_regs *digctl_regs =
+ (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
+
+ switch (readl(&digctl_regs->hw_digctl_chipid) >> 16) {
+ case 0x2800:
+ return "28";
+ case 0x3728:
+ return "23";
+ default:
+ return "";
+ }
+}
+
+static u8 get_cpu_rev(void)
+{
+ struct mx28_digctl_regs *digctl_regs =
+ (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
+
+ return readl(&digctl_regs->hw_digctl_chipid) & 0xF;
+}
+
int print_cpuinfo(void)
{
struct mx28_spl_data *data = (struct mx28_spl_data *)
((CONFIG_SYS_TEXT_BASE - sizeof(struct mx28_spl_data)) & ~0xf);
- printf("Freescale i.MX28 family at %d MHz\n",
- mxc_get_clock(MXC_ARM_CLK) / 100);
+ printf("CPU: Freescale i.MX%s rev%d at %d MHz\n",
+ get_cpu_type(),
+ get_cpu_rev(),
+ mxc_get_clock(MXC_ARM_CLK) / 100);
printf("BOOT: %s\n", mx28_boot_modes[data->boot_mode_idx].mode);
return 0;
}
--
1.7.10
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
In case an unidentified CPU type is detected it now returns
i.MX, in a const char.
Signed-off-by: Otavio Salvador
Cc: Marek Vasut
Cc: Stefano Babic
Cc: Fabio Estevam
---
arch/arm/cpu/armv7/imx-common/cpu.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv7/imx-common/cpu.c
b/arch/arm/cpu/armv7/imx-common/cpu.c
index b3195dd..77aac7d 100644
--- a/arch/arm/cpu/armv7/imx-common/cpu.c
+++ b/arch/arm/cpu/armv7/imx-common/cpu.c
@@ -66,7 +66,7 @@ char *get_reset_cause(void)
#if defined(CONFIG_DISPLAY_CPUINFO)
-static char *get_imx_type(u32 imxtype)
+static const char *get_imx_type(u32 imxtype)
{
switch (imxtype) {
case 0x63:
@@ -80,7 +80,7 @@ static char *get_imx_type(u32 imxtype)
case 0x53:
return "53";
default:
- return "unknown";
+ return "";
}
}
--
1.7.10
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/3] i.MX refactoring patchset
This patchset include minor changes for i.MX; mainly: 1/3: improves the rare case of unkown booting machine 2/3: generalize the code so it works for i.MX23 and i.MX28 The patch 3/3 is what we've been using in Yocto and has been change to affect only mx28evk. Otavio Salvador (3): imx: Use a clear identification of an unidentified CPU type mxs: generalize code for print_cpuinfo() mx28evk: extend default environment arch/arm/cpu/arm926ejs/mx28/mx28.c | 29 +++- arch/arm/cpu/armv7/imx-common/cpu.c |4 +- include/configs/mx28evk.h | 83 +++ 3 files changed, 104 insertions(+), 12 deletions(-) -- 1.7.10 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
