Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (new files)
Dear Reinhard Meyer,
In message 4c091f79.5040...@emk-elektronik.de you wrote:
+static const struct sdram_config sdram_config = {
+.data_bits= SDRAM_DATA_16BIT,
+.row_bits= 13,
+.col_bits= 9,
+.bank_bits= 2,
+.cas= 3,
Indentation by TAB only - please fix globally.
That are verbatim copies from atngw100... Shall I fix there as well ?
Yes, pelas e- a sa separate patch.
--030408090100080902020605
Content-Type: text/x-vcard; charset=utf-8;
name=reinhard_meyer.vcf
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
Can you please drop this when posting to mailing lists? Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Text processing has made it possible to right-justify any idea, even
one which cannot be justified on any other grounds.
-- J. Finnegan, USC.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (modified files)
Dear Reinhard Meyer (-VC),
In message 4c09274b.2080...@emk-elektronik.de you wrote:
Well, what about that situation (two names as maintainers for HAMMERHEAD),
where do I sort in?
Mark Jackson m...@mimc.co.uk
MIMC200AT32AP7000
Alex Raimondi alex.raimo...@miromico.ch
Julien May julien@miromico.ch
First name counts, i. e. this entry should sort as Alex Raimondi.
Please add mail address
I can do that. But is it really senseful to add an email address to each
file?
E-Mail adresses can change. Also Rechtsform (GmbH - GmbH Co. KG).
Shall that all be reflected in a simple copyright string?
It makes a lot of sense to the reader of the code, even i=f it should
change later (when the code is properly maintained, such entries
should get updated, too).
@@ -68,12 +69,56 @@ void read_factory_r (void)
addr += p - buf;
/*printf (%s\n, buf); */
/* search for our specific entry */
-if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19)) {
+if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19))
setenv (ethaddr, (char *)(buf + 19));
-} else if (!strncmp ((char *) buf, [BOARD/SERIAL] , 15)) {
+#if defined(CONFIG_TOP7000)
+/* boards that have 2 LAN interfaces */
+else if (!strncmp ((char *) buf, [RLA/lan2/Ethernet] , 20))
+setenv (eth1addr, (char *)(buf + 20));
+#endif
Curly braces are needed for multiline statements.
Not sure what is multiline here? its like
Your code (ignoring the ifdef):
if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19))
setenv (ethaddr, (char *)(buf + 19));
/* boards that have 2 LAN interfaces */
else if (!strncmp ((char *) buf, [RLA/lan2/Ethernet] , 20))
To me this is multi-line, and badly indented, too.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
365 Days of drinking Lo-Cal beer. = 1 Lite-year
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU Module (3rd try)
Reinhard Meyer (-VC) schrieb: Add support for EMK TOP7000 CPU Module Specifics: 1) create subdir board/emk/top7000 and files in it 2) create include/configs/top7000.h 3) update board/emk/common/vpd.c 4) add call to misc_init_r() to arch/avr32/lib/board.c 5) create arch/avr32/include/asm/unaligned.h to fix zlib.c compilation problem 6) update Makefile, MAINTAINERS, MAKEALL Signed-off-by: Reinhard Meyer i...@emk-elektronik.de Hi, was this my patch overseen now? Its from 6.6.2010... Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Hello,
is this patch going to be accepted, or is someone insisting that only
my port shall return the number of controllers initialized?
Reinhard Meyer schrieb:
Ben Warren schrieb:
Hello Reinhard,
On Sat, Jun 5, 2010 at 3:41 AM, Reinhard Meyer (-VC)
reinhard.me...@emk-elektronik.de wrote:
Add support for EMK TOP7000 CPU module
Specifics:
1) create subdir board/emk/top7000 and files in it
2) create include/configs/top7000.h
3) update board/emk/common/vpd.c
4) add call to misc_init_r() to arch/avr32/lib/board.c
5) create arch/avr32/include/asm/unaligned.h to
fix zlib.c compilation problem
6) update Makefile, MAINTAINERS, MAKEALL
Signed-off-by: Reinhard Meyer i...@emk-elektronik.de
---
MAINTAINERS|6 +-
MAKEALL|3 +-
Makefile |3 +
arch/avr32/include/asm/unaligned.h |1 +
arch/avr32/lib/board.c |5 +
board/emk/common/vpd.c | 56 +-
board/emk/top7000/Makefile | 41 +++
board/emk/top7000/config.mk|3 +
board/emk/top7000/top7000.c| 169
board/emk/top7000/u-boot.lds | 72
include/configs/top7000.h | 216
11 files changed, 570 insertions(+), 5 deletions(-)
create mode 100644 arch/avr32/include/asm/unaligned.h
create mode 100644 board/emk/top7000/Makefile
create mode 100644 board/emk/top7000/config.mk
create mode 100644 board/emk/top7000/top7000.c
create mode 100644 board/emk/top7000/u-boot.lds
create mode 100644 include/configs/top7000.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a13d28..a361be1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -311,7 +311,7 @@ Andrea llandre Marson andrea.mar...@dave-tech.it
PPChameleonEVB PPC405EP
-Reinhard Meyer r.me...@emk-elektronik.de
+Reinhard Meyer reinhard.me...@emk-elektronik.de
TOP860 MPC860T
TOP5200 MPC5200
@@ -919,6 +919,10 @@ Julien May julien@miromico.ch
HAMMERHEAD AT32AP7000
+Reinhard Meyer reinhard.me...@emk-elektronik.de
+
+ TOP7000 AT32AP7000
+
Haavard Skinnemoen haavard.skinnem...@atmel.com
ATSTK1000 AT32AP7xxx
diff --git a/MAKEALL b/MAKEALL
index 2527352..3a80041 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -873,7 +873,8 @@ LIST_avr32=\
atngw100\
favr-32-ezkit \
hammerhead \
- mimc200 \
+ mimc200 \
+ top7000 \
#
diff --git a/Makefile b/Makefile
index c26e491..e57a4ca 100644
--- a/Makefile
+++ b/Makefile
@@ -3549,6 +3549,9 @@ hammerhead_config : unconfig
mimc200_config : unconfig
@$(MKCONFIG) $(@:_config=) avr32 at32ap mimc200 mimc at32ap700x
+top7000_config : unconfig
+ @$(MKCONFIG) $(@:_config=) avr32 at32ap top7000 emk at32ap700x
+
#
# SH3 (SuperH)
#
diff --git a/arch/avr32/include/asm/unaligned.h
b/arch/avr32/include/asm/unaligned.h
new file mode 100644
index 000..6cecbbb
--- /dev/null
+++ b/arch/avr32/include/asm/unaligned.h
@@ -0,0 +1 @@
+#include asm-generic/unaligned.h
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c
index 917ed6c..6be5ab0
--- a/arch/avr32/lib/board.c
+++ b/arch/avr32/lib/board.c
@@ -337,6 +337,11 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
jumptable_init();
console_init_r();
+#if defined(CONFIG_MISC_INIT_R)
+ /* miscellaneous platform dependent initialisations */
+ misc_init_r();
+#endif
+
s = getenv(loadaddr);
if (s)
load_addr = simple_strtoul(s, NULL, 16);
diff --git a/board/emk/common/vpd.c b/board/emk/common/vpd.c
index c2af219..a6c456b
--- a/board/emk/common/vpd.c
+++ b/board/emk/common/vpd.c
@@ -1,6 +1,6 @@
/*
- * (C) Copyright 2003
- * Reinhard Meyer, EMK Elektronik GmbH, r.me...@emk-elektronik.de
+ * (C) Copyright 2003-2010
+ * EMK Elektronik GmbH Co. KG, reinhard.me...@emk-elektronik.de
*
* See file CREDITS for list of people who contributed to this
* project.
@@ -22,7 +22,8 @@
*/
#include common.h
-
+#include command.h
+
/*
* read factory part of EEPROM and set some environment variables
*/
@@ -70,6 +71,10 @@ void read_factory_r (void)
/* search for our specific entry */
if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19)) {
setenv (ethaddr, (char *)(buf + 19));
+#if
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Dear Reinhard Meyer (-VC), In message 4c0b85d8.4070...@emk-elektronik.de you wrote: is this patch going to be accepted, or is someone insisting that only my port shall return the number of controllers initialized? I don't understand what you mean by only my port. Ben's comment that board_eth_init() is supposed to retrurn the number of successfully initialized controllers has been standard policy for a pretty long time, and many boards do so. Eventually the boards you compared against are older ones, and have not been maintained well, so they misbehave in this regard? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Testing can show the presense of bugs, but not their absence. -- Edsger Dijkstra ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Wolfgang Denk schrieb: Dear Reinhard Meyer (-VC), In message 4c0b85d8.4070...@emk-elektronik.de you wrote: is this patch going to be accepted, or is someone insisting that only my port shall return the number of controllers initialized? I don't understand what you mean by only my port. Ben's comment that board_eth_init() is supposed to retrurn the number of successfully initialized controllers has been standard policy for a pretty long time, and many boards do so. Eventually the boards you compared against are older ones, and have not been maintained well, so they misbehave in this regard? Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Wolfgang Denk schrieb: Dear Reinhard Meyer (-VC), In message 4c0b85d8.4070...@emk-elektronik.de you wrote: is this patch going to be accepted, or is someone insisting that only my port shall return the number of controllers initialized? I don't understand what you mean by only my port. Ben's comment that board_eth_init() is supposed to retrurn the number of successfully initialized controllers has been standard policy for a pretty long time, and many boards do so. Eventually the boards you compared against are older ones, and have not been maintained well, so they misbehave in this regard? Best regards, Wolfgang Denk Hello Wolfgang, Is that documented somewhere? I see that the calling function in net.c does NOT care about any positive interger result. Will it care sometime in the future? :) The second problem is that I cannot seem to undo my previous commit in my tree, so any changes I do to my source would come out as a second patch. Would that be accepted? Or do you know what must be done that GIT will issue a new patch with the current and the new changes in one patch? I generate the patches by after editing: git commit -m message git format-patch origin what to do to return to after editing, do new edits and generate a new, single patch? Best Regards, Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Reinhard Meyer (-VC) schrieb: Wolfgang Denk schrieb: Dear Reinhard Meyer (-VC), The second problem is that I cannot seem to undo my previous commit in my tree, so any changes I do to my source would come out as a second patch. Would that be accepted? Or do you know what must be done that GIT will issue a new patch with the current and the new changes in one patch? I generate the patches by after editing: git commit -m message git format-patch origin what to do to return to after editing, do new edits and generate a new, single patch? A git reset --soft HEAD^ followed by git add of all newly changed files does the trick... Best Regards, Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Dear Reinhard Meyer (-VC), In message 4c0b8be7.7090...@emk-elektronik.de you wrote: Is that documented somewhere? I see that the calling function in net.c Probably only in the mailing list archives... does NOT care about any positive interger result. Will it care sometime in the future? :) The second problem is that I cannot seem to undo my previous commit in my tree, so any changes I do to my source would come out as a second patch. Would that be accepted? No. Why cannot you git rebase -i your tree (resp. your development branch) and squash the commits in question? Or do you know what must be done that GIT will issue a new patch with the current and the new changes in one patch? Squash the commits into one? what to do to return to after editing, do new edits and generate a new, single patch? man git-rebase Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de He is truly wise who gains wisdom from another's mishap. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Hello Reinhard, On Sun, Jun 6, 2010 at 4:52 AM, Reinhard Meyer (-VC) reinhard.me...@emk-elektronik.de wrote: Wolfgang Denk schrieb: Dear Reinhard Meyer (-VC), In message 4c0b85d8.4070...@emk-elektronik.de you wrote: is this patch going to be accepted, or is someone insisting that only my port shall return the number of controllers initialized? I don't understand what you mean by only my port. Ben's comment that board_eth_init() is supposed to retrurn the number of successfully initialized controllers has been standard policy for a pretty long time, and many boards do so. Eventually the boards you compared against are older ones, and have not been maintained well, so they misbehave in this regard? Best regards, Wolfgang Denk Hello Wolfgang, Is that documented somewhere? I see that the calling function in net.c does NOT care about any positive interger result. Will it care sometime in the future? :) Yes, it's documented (doc/README.drivers.eth). Maybe it will get used in the future. That's why I politely asked to to make a simple change. It wasn't an arbitrary request, and most boards (maybe not most MACB-using ones) do it properly. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU Module (2nd try)
Reinhard Meyer (-VC) schrieb: if anything can go wrong, it will go wrong... a 0x0d (CR) sneaked into the following line: hammerhead \ - mimc200 \ + mimc200 \ + top7000 \ Please do not try to apply the patch. I will send a new one! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Hello Reinhard,
On Sat, Jun 5, 2010 at 3:41 AM, Reinhard Meyer (-VC)
reinhard.me...@emk-elektronik.de wrote:
Add support for EMK TOP7000 CPU module
Specifics:
1) create subdir board/emk/top7000 and files in it
2) create include/configs/top7000.h
3) update board/emk/common/vpd.c
4) add call to misc_init_r() to arch/avr32/lib/board.c
5) create arch/avr32/include/asm/unaligned.h to
fix zlib.c compilation problem
6) update Makefile, MAINTAINERS, MAKEALL
Signed-off-by: Reinhard Meyer i...@emk-elektronik.de
---
MAINTAINERS|6 +-
MAKEALL|3 +-
Makefile |3 +
arch/avr32/include/asm/unaligned.h |1 +
arch/avr32/lib/board.c |5 +
board/emk/common/vpd.c | 56 +-
board/emk/top7000/Makefile | 41 +++
board/emk/top7000/config.mk|3 +
board/emk/top7000/top7000.c| 169
board/emk/top7000/u-boot.lds | 72
include/configs/top7000.h | 216
11 files changed, 570 insertions(+), 5 deletions(-)
create mode 100644 arch/avr32/include/asm/unaligned.h
create mode 100644 board/emk/top7000/Makefile
create mode 100644 board/emk/top7000/config.mk
create mode 100644 board/emk/top7000/top7000.c
create mode 100644 board/emk/top7000/u-boot.lds
create mode 100644 include/configs/top7000.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a13d28..a361be1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -311,7 +311,7 @@ Andrea llandre Marson andrea.mar...@dave-tech.it
PPChameleonEVB PPC405EP
-Reinhard Meyer r.me...@emk-elektronik.de
+Reinhard Meyer reinhard.me...@emk-elektronik.de
TOP860 MPC860T
TOP5200 MPC5200
@@ -919,6 +919,10 @@ Julien May julien@miromico.ch
HAMMERHEAD AT32AP7000
+Reinhard Meyer reinhard.me...@emk-elektronik.de
+
+ TOP7000 AT32AP7000
+
Haavard Skinnemoen haavard.skinnem...@atmel.com
ATSTK1000 AT32AP7xxx
diff --git a/MAKEALL b/MAKEALL
index 2527352..3a80041 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -873,7 +873,8 @@ LIST_avr32=\
atngw100\
favr-32-ezkit \
hammerhead \
- mimc200 \
+ mimc200 \
+ top7000 \
#
diff --git a/Makefile b/Makefile
index c26e491..e57a4ca 100644
--- a/Makefile
+++ b/Makefile
@@ -3549,6 +3549,9 @@ hammerhead_config : unconfig
mimc200_config : unconfig
@$(MKCONFIG) $(@:_config=) avr32 at32ap mimc200 mimc at32ap700x
+top7000_config : unconfig
+ @$(MKCONFIG) $(@:_config=) avr32 at32ap top7000 emk at32ap700x
+
#
# SH3 (SuperH)
#
diff --git a/arch/avr32/include/asm/unaligned.h
b/arch/avr32/include/asm/unaligned.h
new file mode 100644
index 000..6cecbbb
--- /dev/null
+++ b/arch/avr32/include/asm/unaligned.h
@@ -0,0 +1 @@
+#include asm-generic/unaligned.h
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c
index 917ed6c..6be5ab0
--- a/arch/avr32/lib/board.c
+++ b/arch/avr32/lib/board.c
@@ -337,6 +337,11 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
jumptable_init();
console_init_r();
+#if defined(CONFIG_MISC_INIT_R)
+ /* miscellaneous platform dependent initialisations */
+ misc_init_r();
+#endif
+
s = getenv(loadaddr);
if (s)
load_addr = simple_strtoul(s, NULL, 16);
diff --git a/board/emk/common/vpd.c b/board/emk/common/vpd.c
index c2af219..a6c456b
--- a/board/emk/common/vpd.c
+++ b/board/emk/common/vpd.c
@@ -1,6 +1,6 @@
/*
- * (C) Copyright 2003
- * Reinhard Meyer, EMK Elektronik GmbH, r.me...@emk-elektronik.de
+ * (C) Copyright 2003-2010
+ * EMK Elektronik GmbH Co. KG, reinhard.me...@emk-elektronik.de
*
* See file CREDITS for list of people who contributed to this
* project.
@@ -22,7 +22,8 @@
*/
#include common.h
-
+#include command.h
+
/*
* read factory part of EEPROM and set some environment variables
*/
@@ -70,6 +71,10 @@ void read_factory_r (void)
/* search for our specific entry */
if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19)) {
setenv (ethaddr, (char *)(buf + 19));
+#if defined(CONFIG_TOP7000)
+ } else if (!strncmp ((char *) buf, [RLA/lan2/Ethernet] ,
20)) {
+ setenv (eth1addr, (char *)(buf + 20));
+#endif
} else if
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Ben Warren schrieb:
Hello Reinhard,
On Sat, Jun 5, 2010 at 3:41 AM, Reinhard Meyer (-VC)
reinhard.me...@emk-elektronik.de wrote:
Add support for EMK TOP7000 CPU module
Specifics:
1) create subdir board/emk/top7000 and files in it
2) create include/configs/top7000.h
3) update board/emk/common/vpd.c
4) add call to misc_init_r() to arch/avr32/lib/board.c
5) create arch/avr32/include/asm/unaligned.h to
fix zlib.c compilation problem
6) update Makefile, MAINTAINERS, MAKEALL
Signed-off-by: Reinhard Meyer i...@emk-elektronik.de
---
MAINTAINERS|6 +-
MAKEALL|3 +-
Makefile |3 +
arch/avr32/include/asm/unaligned.h |1 +
arch/avr32/lib/board.c |5 +
board/emk/common/vpd.c | 56 +-
board/emk/top7000/Makefile | 41 +++
board/emk/top7000/config.mk|3 +
board/emk/top7000/top7000.c| 169
board/emk/top7000/u-boot.lds | 72
include/configs/top7000.h | 216
11 files changed, 570 insertions(+), 5 deletions(-)
create mode 100644 arch/avr32/include/asm/unaligned.h
create mode 100644 board/emk/top7000/Makefile
create mode 100644 board/emk/top7000/config.mk
create mode 100644 board/emk/top7000/top7000.c
create mode 100644 board/emk/top7000/u-boot.lds
create mode 100644 include/configs/top7000.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a13d28..a361be1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -311,7 +311,7 @@ Andrea llandre Marson andrea.mar...@dave-tech.it
PPChameleonEVB PPC405EP
-Reinhard Meyer r.me...@emk-elektronik.de
+Reinhard Meyer reinhard.me...@emk-elektronik.de
TOP860 MPC860T
TOP5200 MPC5200
@@ -919,6 +919,10 @@ Julien May julien@miromico.ch
HAMMERHEAD AT32AP7000
+Reinhard Meyer reinhard.me...@emk-elektronik.de
+
+ TOP7000 AT32AP7000
+
Haavard Skinnemoen haavard.skinnem...@atmel.com
ATSTK1000 AT32AP7xxx
diff --git a/MAKEALL b/MAKEALL
index 2527352..3a80041 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -873,7 +873,8 @@ LIST_avr32=\
atngw100\
favr-32-ezkit \
hammerhead \
- mimc200 \
+ mimc200 \
+ top7000 \
#
diff --git a/Makefile b/Makefile
index c26e491..e57a4ca 100644
--- a/Makefile
+++ b/Makefile
@@ -3549,6 +3549,9 @@ hammerhead_config : unconfig
mimc200_config : unconfig
@$(MKCONFIG) $(@:_config=) avr32 at32ap mimc200 mimc at32ap700x
+top7000_config : unconfig
+ @$(MKCONFIG) $(@:_config=) avr32 at32ap top7000 emk at32ap700x
+
#
# SH3 (SuperH)
#
diff --git a/arch/avr32/include/asm/unaligned.h
b/arch/avr32/include/asm/unaligned.h
new file mode 100644
index 000..6cecbbb
--- /dev/null
+++ b/arch/avr32/include/asm/unaligned.h
@@ -0,0 +1 @@
+#include asm-generic/unaligned.h
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c
index 917ed6c..6be5ab0
--- a/arch/avr32/lib/board.c
+++ b/arch/avr32/lib/board.c
@@ -337,6 +337,11 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
jumptable_init();
console_init_r();
+#if defined(CONFIG_MISC_INIT_R)
+ /* miscellaneous platform dependent initialisations */
+ misc_init_r();
+#endif
+
s = getenv(loadaddr);
if (s)
load_addr = simple_strtoul(s, NULL, 16);
diff --git a/board/emk/common/vpd.c b/board/emk/common/vpd.c
index c2af219..a6c456b
--- a/board/emk/common/vpd.c
+++ b/board/emk/common/vpd.c
@@ -1,6 +1,6 @@
/*
- * (C) Copyright 2003
- * Reinhard Meyer, EMK Elektronik GmbH, r.me...@emk-elektronik.de
+ * (C) Copyright 2003-2010
+ * EMK Elektronik GmbH Co. KG, reinhard.me...@emk-elektronik.de
*
* See file CREDITS for list of people who contributed to this
* project.
@@ -22,7 +22,8 @@
*/
#include common.h
-
+#include command.h
+
/*
* read factory part of EEPROM and set some environment variables
*/
@@ -70,6 +71,10 @@ void read_factory_r (void)
/* search for our specific entry */
if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19)) {
setenv (ethaddr, (char *)(buf + 19));
+#if defined(CONFIG_TOP7000)
+ } else if (!strncmp ((char *) buf, [RLA/lan2/Ethernet] ,
20)) {
+ setenv (eth1addr, (char *)(buf + 20));
+#endif
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (new files)
Dear Reinhard Meyer (-VC), In message 4c08ec47.5070...@emk-elektronik.de you wrote: This Patch adds support for the EMK TOP7000 CPU Module Part 1: new files Signed-off-by: Reinhard Meyer reinhard.me...@emk-elektronik.de NAK. Please submit as one patch so we have an atomic, bisectable commit. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If A equals success, then the formula is A = X + Y + Z. X is work. Y is play. Z is keep your mouth shut. - Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (new files)
Dear Reinhard Meyer (-VC),
In message 4c08ec47.5070...@emk-elektronik.de you wrote:
This Patch adds support for the EMK TOP7000 CPU Module
Part 1: new files
Signed-off-by: Reinhard Meyer reinhard.me...@emk-elektronik.de
But please clean up the code berfore resubmitting...
--- /dev/null
+++ b/board/emk/top7000/top7000.c
...
+static const struct sdram_config sdram_config = {
+.data_bits= SDRAM_DATA_16BIT,
+.row_bits= 13,
+.col_bits= 9,
+.bank_bits= 2,
+.cas= 3,
Indentation by TAB only - please fix globally.
+#ifdef CONFIG_CMD_I2C
+// first select SCL and SDA gpio
No C++ comments - please fix globally.
+portmux_select_gpio(PORTMUX_PORT_A,(1SDA_PIN),
No trailing white space - please fix globally
+portmux_select_gpio(PORTMUX_PORT_A,(1SDA_PIN),
PORTMUX_DIR_OUTPUT|PORTMUX_INIT_LOW|PORTMUX_OPEN_DRAIN);
Long lines wrapped by mailer. Please fix your mailer setup (or rather
use git send-email for sending patches.
Note: line too long - please fix globally.
+if (expected_size != actual_size)
+printf(Warning: Only %lu of %lu MiB SDRAM is working\n,
+actual_size 20, expected_size 20);
Curly braces needed for multiline statements - please fix globally.
+int misc_init_r (void)
--^
+{
+/* read 'factory' part of EEPROM */
+extern void read_factory_r (void);
+read_factory_r ();
-^
No spaces after function names - please fix globally.
...
--- /dev/null
+++ b/board/emk/top7000/u-boot.lds
@@ -0,0 +1,72 @@
+/* -*- Fundamental -*-
Incorrect multiline comment style - please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
PoB = Prisoner of Bill -- those held captive, unwillingly or other-
wise, by the contemptible Microsoft monopoly.
-- Tom Christiansen in 6abo45$3l...@csnews.cs.colorado.edu
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (modified files)
Dear Reinhard Meyer (-VC),
In message 4c08ed38.8030...@emk-elektronik.de you wrote:
This Patch adds support for the EMK TOP7000 CPU Module
Part 2: modified files
Signed-off-by: Reinhard Meyer reinhard.me...@emk-elektronik.de
---
MAINTAINERS |6 -
Makefile |3 ++
board/emk/common/vpd.c| 57
Fix your mailer, it is wrapping lines!
@@ -928,6 +928,10 @@ Haavard Skinnemoen haavard.skinnem...@atmel.com
ATSTK1006AT32AP7000
ATNGW100AT32AP7000
+Reinhard Meyer reinhard.me...@emk-elektronik.de
Please keep lists sorted - M S
--- a/board/emk/common/vpd.c
+++ b/board/emk/common/vpd.c
@@ -1,6 +1,6 @@
/*
- * (C) Copyright 2003
- * Reinhard Meyer, EMK Elektronik GmbH, r.me...@emk-elektronik.de
+ * (C) Copyright 2003-2010
+ * Reinhard Meyer, EMK Elektronik
Please add mail address
@@ -68,12 +69,56 @@ void read_factory_r (void)
addr += p - buf;
/*printf (%s\n, buf); */
/* search for our specific entry */
-if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19)) {
+if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19))
setenv (ethaddr, (char *)(buf + 19));
-} else if (!strncmp ((char *) buf, [BOARD/SERIAL] , 15)) {
+#if defined(CONFIG_TOP7000)
+/* boards that have 2 LAN interfaces */
+else if (!strncmp ((char *) buf, [RLA/lan2/Ethernet] , 20))
+setenv (eth1addr, (char *)(buf + 20));
+#endif
Curly braces are needed for multiline statements.
...
+if (eeprom_write (CONFIG_SYS_I2C_FACT_ADDR, CONFIG_SYS_FACT_OFFSET,
buf, i+2)) {
+printf (cannot write factory configuration\n);
All previous comments apply here, too (too long lines, wrapped lines,
no spaces after function name, ...)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Comparing information and knowledge is like asking whether the
fatness of a pig is more or less green than the designated hitter
rule. - David Guaspari
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (new files)
Wolfgang Denk schrieb:
Dear Reinhard Meyer (-VC),
In message 4c08ec47.5070...@emk-elektronik.de you wrote:
...
+static const struct sdram_config sdram_config = {
+.data_bits= SDRAM_DATA_16BIT,
+.row_bits= 13,
+.col_bits= 9,
+.bank_bits= 2,
+.cas= 3,
Indentation by TAB only - please fix globally.
That are verbatim copies from atngw100... Shall I fix there as well ?
attachment: reinhard_meyer.vcf___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module (modified files)
Wolfgang Denk schrieb:
Dear Reinhard Meyer (-VC),
In message 4c08ed38.8030...@emk-elektronik.de you wrote:
This Patch adds support for the EMK TOP7000 CPU Module
Part 2: modified files
Signed-off-by: Reinhard Meyer reinhard.me...@emk-elektronik.de
---
MAINTAINERS |6 -
Makefile |3 ++
board/emk/common/vpd.c| 57
Fix your mailer, it is wrapping lines!
I will investigate on that. Using Thunderbird, should have settings for
that.
@@ -928,6 +928,10 @@ Haavard Skinnemoen haavard.skinnem...@atmel.com
ATSTK1006AT32AP7000
ATNGW100AT32AP7000
+Reinhard Meyer reinhard.me...@emk-elektronik.de
Please keep lists sorted - M S
Well, what about that situation (two names as maintainers for HAMMERHEAD),
where do I sort in?
Mark Jackson m...@mimc.co.uk
MIMC200AT32AP7000
Alex Raimondi alex.raimo...@miromico.ch
Julien May julien@miromico.ch
HAMMERHEADAT32AP7000
Reinhard Meyer reinhard.me...@emk-elektronik.de
TOP7000AT32AP7000
Haavard Skinnemoen haavard.skinnem...@atmel.com
--- a/board/emk/common/vpd.c
+++ b/board/emk/common/vpd.c
@@ -1,6 +1,6 @@
/*
- * (C) Copyright 2003
- * Reinhard Meyer, EMK Elektronik GmbH, r.me...@emk-elektronik.de
+ * (C) Copyright 2003-2010
+ * Reinhard Meyer, EMK Elektronik
Please add mail address
I can do that. But is it really senseful to add an email address to each
file?
E-Mail adresses can change. Also Rechtsform (GmbH - GmbH Co. KG).
Shall that all be reflected in a simple copyright string?
@@ -68,12 +69,56 @@ void read_factory_r (void)
addr += p - buf;
/*printf (%s\n, buf); */
/* search for our specific entry */
-if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19)) {
+if (!strncmp ((char *) buf, [RLA/lan/Ethernet] , 19))
setenv (ethaddr, (char *)(buf + 19));
-} else if (!strncmp ((char *) buf, [BOARD/SERIAL] , 15)) {
+#if defined(CONFIG_TOP7000)
+/* boards that have 2 LAN interfaces */
+else if (!strncmp ((char *) buf, [RLA/lan2/Ethernet] , 20))
+setenv (eth1addr, (char *)(buf + 20));
+#endif
Curly braces are needed for multiline statements.
Not sure what is multiline here? its like
if (cond1)
statement1;
else if (cond2)
statement2;
else if (cond3)
statement3;
...
+if (eeprom_write (CONFIG_SYS_I2C_FACT_ADDR, CONFIG_SYS_FACT_OFFSET,
buf, i+2)) {
+printf (cannot write factory configuration\n);
All previous comments apply here, too (too long lines, wrapped lines,
no spaces after function name, ...)
willco.
Best Regards
Reinhard
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
