Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, I have managed to rebase your patch series and have tested it over the ARM targets. This particular patch was the only one to cause an issue, and an amusing one at that: On Wed, 6 Mar 2013 19:59:24 +0100, Benoît Thébaudeau wrote: > This also fixes support for mx31pdk and tx25, which had been broken by commit > e05e5de7fae5bec79617e113916dac6631251156. Both boards actually build fine with e05e5de7fae (and have built fine since, at least in all of the routine ARM-wide builds I do as the ARM custodian and where I accept zero build failures or warnings). And both boards actually do not build at all with this patch :) and die with the same error: .../spl/u-boot-spl.lds:45: non constant or forward reference address expression for section .bss In both case I have double-checked this using Ubuntu's gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-1ubuntu1) or ELDK 5.3's gcc version 4.7.2 (GCC). Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Albert, On Sunday, March 31, 2013 7:30:24 PM, Albert ARIBAUD wrote: > Hi Benoît, > > I have managed to rebase your patch series and have tested it over the > ARM targets. This particular patch was the only one to cause an issue, > and an amusing one at that: > > On Wed, 6 Mar 2013 19:59:24 +0100, Benoît Thébaudeau > wrote: > > > This also fixes support for mx31pdk and tx25, which had been broken by > > commit > > e05e5de7fae5bec79617e113916dac6631251156. > > Both boards actually build fine with e05e5de7fae (and have built > fine since, at least in all of the routine ARM-wide builds I do as the > ARM custodian and where I accept zero build failures or warnings). Yes, for me too. This was not a build issue, but a runtime one. > And both boards actually do not build at all with this patch :) and die > with the same error: > > .../spl/u-boot-spl.lds:45: non constant or forward reference address > expression for section .bss > > In both case I have double-checked this using Ubuntu's gcc version > 4.7.2 (Ubuntu/Linaro 4.7.2-1ubuntu1) or ELDK 5.3's gcc version 4.7.2 > (GCC). OK. That worked fine for me and Fabio at the time I issued the v9, so it can be the rebase, or something that changed in mainline in the meantime, or the toolchain. According to your tests, it's very unlikely that the toolchain is involved. I've looked at the Git history, and the guilty commit is 3ebd1cb. But thanks to commit 65cdd64, this build issue should be easily solved by replacing: +#define CONFIG_SPL_LDSCRIPT"arch/$(ARCH)/cpu/u-boot.lds" with: +#define CONFIG_SPL_LDSCRIPT"arch/$(ARCH)/cpu/u-boot-spl.lds" in both mx31pdk.h and tx25.h. Can you please retest with this change? This line could even be dropped from tx25.h since there is no arm926ejs SPL linker script obstructing the default assignment, contrary to arm1136 for mx31pdk, but that would be risky if such a linker script is added later. Is it still OK for the release if I send v10 on April 8 as I said (so just with the rebase including the change above if you confirm that everything is OK like that)? Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Mon, 1 Apr 2013 02:30:00 +0200 (CEST), Benoît Thébaudeau wrote: > Hi Albert, > > On Sunday, March 31, 2013 7:30:24 PM, Albert ARIBAUD wrote: > > Hi Benoît, > > > > I have managed to rebase your patch series and have tested it over the > > ARM targets. This particular patch was the only one to cause an issue, > > and an amusing one at that: > > > > On Wed, 6 Mar 2013 19:59:24 +0100, Benoît Thébaudeau > > wrote: > > > > > This also fixes support for mx31pdk and tx25, which had been broken by > > > commit > > > e05e5de7fae5bec79617e113916dac6631251156. > > > > Both boards actually build fine with e05e5de7fae (and have built > > fine since, at least in all of the routine ARM-wide builds I do as the > > ARM custodian and where I accept zero build failures or warnings). > > Yes, for me too. This was not a build issue, but a runtime one. > > > And both boards actually do not build at all with this patch :) and die > > with the same error: > > > > .../spl/u-boot-spl.lds:45: non constant or forward reference address > > expression for section .bss > > > > In both case I have double-checked this using Ubuntu's gcc version > > 4.7.2 (Ubuntu/Linaro 4.7.2-1ubuntu1) or ELDK 5.3's gcc version 4.7.2 > > (GCC). > > OK. That worked fine for me and Fabio at the time I issued the v9, so it can > be > the rebase, or something that changed in mainline in the meantime, or the > toolchain. According to your tests, it's very unlikely that the toolchain is > involved. > > I've looked at the Git history, and the guilty commit is 3ebd1cb. But thanks > to > commit 65cdd64, this build issue should be easily solved by replacing: > +#define CONFIG_SPL_LDSCRIPT"arch/$(ARCH)/cpu/u-boot.lds" > with: > +#define CONFIG_SPL_LDSCRIPT"arch/$(ARCH)/cpu/u-boot-spl.lds" > in both mx31pdk.h and tx25.h. > > Can you please retest with this change? Patch 18/30 amended with this change and testing done; all ARM boards build fine now. > This line could even be dropped from tx25.h since there is no arm926ejs SPL > linker script obstructing the default assignment, contrary to arm1136 for > mx31pdk, but that would be risky if such a linker script is added later. > > Is it still OK for the release if I send v10 on April 8 as I said (so just > with > the rebase including the change above if you confirm that everything is OK > like > that)? You have Scott's acked-by for the NAND parts, and Tom's reviewed-by is proof enough for me that he is ok with the few non-ARM-only patches, so the patch series in itself is fine (assuming v10 is identical to v9 as I rebased it). I would just like some reports that boards (mx31pdk and tx25 especially, but others too, including a few non-ARM to make sure) have no issue running v10. > Best regards, > Benoît Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Albert, On Monday, April 1, 2013 10:26:21 AM, Albert ARIBAUD wrote: > Hi Benoît, > > On Mon, 1 Apr 2013 02:30:00 +0200 (CEST), Benoît Thébaudeau > wrote: > > > Hi Albert, > > > > On Sunday, March 31, 2013 7:30:24 PM, Albert ARIBAUD wrote: > > > Hi Benoît, > > > > > > I have managed to rebase your patch series and have tested it over the > > > ARM targets. This particular patch was the only one to cause an issue, > > > and an amusing one at that: > > > > > > On Wed, 6 Mar 2013 19:59:24 +0100, Benoît Thébaudeau > > > wrote: > > > > > > > This also fixes support for mx31pdk and tx25, which had been broken by > > > > commit > > > > e05e5de7fae5bec79617e113916dac6631251156. > > > > > > Both boards actually build fine with e05e5de7fae (and have built > > > fine since, at least in all of the routine ARM-wide builds I do as the > > > ARM custodian and where I accept zero build failures or warnings). > > > > Yes, for me too. This was not a build issue, but a runtime one. > > > > > And both boards actually do not build at all with this patch :) and die > > > with the same error: > > > > > > .../spl/u-boot-spl.lds:45: non constant or forward reference address > > > expression for section .bss > > > > > > In both case I have double-checked this using Ubuntu's gcc version > > > 4.7.2 (Ubuntu/Linaro 4.7.2-1ubuntu1) or ELDK 5.3's gcc version 4.7.2 > > > (GCC). > > > > OK. That worked fine for me and Fabio at the time I issued the v9, so it > > can be > > the rebase, or something that changed in mainline in the meantime, or the > > toolchain. According to your tests, it's very unlikely that the toolchain > > is > > involved. > > > > I've looked at the Git history, and the guilty commit is 3ebd1cb. But > > thanks to > > commit 65cdd64, this build issue should be easily solved by replacing: > > +#define CONFIG_SPL_LDSCRIPT"arch/$(ARCH)/cpu/u-boot.lds" > > with: > > +#define CONFIG_SPL_LDSCRIPT"arch/$(ARCH)/cpu/u-boot-spl.lds" > > in both mx31pdk.h and tx25.h. > > > > Can you please retest with this change? > > Patch 18/30 amended with this change and testing done; all ARM boards > build fine now. Thanks for testing that. > > This line could even be dropped from tx25.h since there is no arm926ejs SPL > > linker script obstructing the default assignment, contrary to arm1136 for > > mx31pdk, but that would be risky if such a linker script is added later. > > > > Is it still OK for the release if I send v10 on April 8 as I said (so just > > with > > the rebase including the change above if you confirm that everything is OK > > like > > that)? > > You have Scott's acked-by for the NAND parts, and Tom's reviewed-by is > proof enough for me that he is ok with the few non-ARM-only patches, > so the patch series in itself is fine (assuming v10 is identical to > v9 as I rebased it). > > I would just like some reports that boards (mx31pdk and tx25 especially, > but others too, including a few non-ARM to make sure) have no issue > running v10. OK, then it's probably better if I send v10 ASAP. I may not have access to my repo before this date, and I have not kept my v9 bundle in my outbox, so can you just send me back this bundle please? I will try to send a v10 during this week. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Mon, 1 Apr 2013 15:13:05 +0200 (CEST), Benoît Thébaudeau wrote: > OK, then it's probably better if I send v10 ASAP. I may not have access to my > repo before this date, and I have not kept my v9 bundle in my outbox, so can > you > just send me back this bundle please? I will try to send a v10 during this > week. Sent off-list as this bundle is V9 and thus should not be tested by people, only V10 should. > Best regards, > Benoît Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Albert, On Monday, April 1, 2013 5:53:55 PM, Albert ARIBAUD wrote: > Hi Benoît, > > On Mon, 1 Apr 2013 15:13:05 +0200 (CEST), Benoît Thébaudeau > wrote: > > > OK, then it's probably better if I send v10 ASAP. I may not have access to > > my > > repo before this date, and I have not kept my v9 bundle in my outbox, so > > can you > > just send me back this bundle please? I will try to send a v10 during this > > week. > > Sent off-list as this bundle is V9 and thus should not be tested by > people, only V10 should. Here is the v10 bundle for those who want to test: http://dl.free.fr/vdXBGExyq The resulting HEAD is identical to yours, except for board/freescale/mx31ads/u-boot.lds in which you had removed the following unrelated line for 30/30: __bss_end = .; Regarding this line, it is also present in a few other .lds, as well as the following ones: KEEP(*(.__bss_start)); KEEP(*(__bss_end)); However, the end section is named .__bss_end in arch/arm/lib/bss.c, so there is perhaps something wrong here, unless you did that on purpose because of the __bss_end test at the end of the linker script. I had noticed that, but I let you handle it. If something needs to be changed here, please do it after my series if possible in order to avoid a v11 because of newer rebase conflicts. ;) I have also noticed that patman is broken in u-boot-arm/master. I don't know if this has already been fixed somewhere, but it fails with an internal error while running checkpatch, as if an incompatible API change had been made to checkpatch recently, and not propagated to patman. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Benoît Thébaudeau wrote: > Hi Albert, > > Here is the v10 bundle for those who want to test: > http://dl.free.fr/vdXBGExyq Thanks, will build-test it ASAP. People with ARM (expecially tx25 and mx31pdk) and non-ARM boards please run-test it too. > The resulting HEAD is identical to yours, except for > board/freescale/mx31ads/u-boot.lds in which you had removed the following > unrelated line for 30/30: > __bss_end = .; > > Regarding this line, it is also present in a few other .lds, as well as the > following ones: > KEEP(*(.__bss_start)); > KEEP(*(__bss_end)); > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so there > is > perhaps something wrong here, unless you did that on purpose because of the > __bss_end test at the end of the linker script. I had noticed that, but I let > you handle it. If something needs to be changed here, please do it after my > series if possible in order to avoid a v11 because of newer rebase conflicts. > ;) Normally, defining __bss_end symbols in the ARM lds files has become unnecessary as arch/arm/lib/bss.c now defines then (and in so doing avoids generating ugly R_ARM_ABS32 relocation records) so yes, the line removal was intentional, but indeed unrelated to your series. As for the missing period in the .__bss_end input section specification, thanks for bringing this to my attention. I'll give it a look at once as this could lead to tricky bugs popping up... > I have also noticed that patman is broken in u-boot-arm/master. I don't know > if > this has already been fixed somewhere, but it fails with an internal error > while > running checkpatch, as if an incompatible API change had been made to > checkpatch > recently, and not propagated to patman. Cc:ing Simon Glass on patman. Note: u-boot-arm/master is pretty close to u-boot/master at the moment. > Best regards, > Benoît Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Wed, 3 Apr 2013 10:05:57 +0200, Albert ARIBAUD wrote: > > The resulting HEAD is identical to yours, except for > > board/freescale/mx31ads/u-boot.lds in which you had removed the following > > unrelated line for 30/30: > > __bss_end = .; > > > > Regarding this line, it is also present in a few other .lds, as well as the > > following ones: > > KEEP(*(.__bss_start)); > > KEEP(*(__bss_end)); > > > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so > > there is > > perhaps something wrong here, unless you did that on purpose because of the > > __bss_end test at the end of the linker script. I had noticed that, but I > > let > > you handle it. If something needs to be changed here, please do it after my > > series if possible in order to avoid a v11 because of newer rebase > > conflicts. ;) > > Normally, defining __bss_end symbols in the ARM lds files has become > unnecessary as arch/arm/lib/bss.c now defines then (and in so doing > avoids generating ugly R_ARM_ABS32 relocation records) so yes, the line > removal was intentional, but indeed unrelated to your series. > > As for the missing period in the .__bss_end input section specification, > thanks for bringing this to my attention. I'll give it a look at once > as this could lead to tricky bugs popping up... Alright, now that the coffee shot has reached full effect, I think I understand what is going on and indeed that has to be fixed although it most certainly did not cause any issue. In my commit 3ebd1cbc, where the whole bss.c system was put in place, the .__bss_end__ input section specification had the leading period and was thus placed correctly, as was the compiler-generated __bss_end__ symbol from bss.c. Later, when Tom's commit 0ce033d2 manually merged Simon's work turning all __bss_end__ occurrences into __bss_end, two things happened: 1) both the bss.c file and ARM *.lds files then defined __bss_end. 2) the leading period in .__bss_end__ was lost in the conversion. This led to the compiler-generated __bss_end section being mapped away from the whole BSS area -- *before* it, actually, which would have been catastrophic... if the definition for __bss_end from the lds files had not taken precedence over that from bss.c, thus preserving the correct value and semantics for the symbol. In other words, the first issue actually countered the second one, and both stayed hidden as the code continued running as expected. But this has to be fixed, because it causes __bss_end references to generate R_ARM_ABS32 relocation records again, which must be averted (it might be a good idea to add a build-time check to avoid any new R_ARM_ABS32 from creeping up in the future). I'll send out a patch to be taken in 2013.04, in which I'll reintroduce the leading periods in .__bss_end sections, and rename the linker symbols used for overlay mapping (and make them non-exported so that the code won't mistakenly reference them). ... and indeed I won't ask for a V10 rebase for it :) -- either V10 gets in first, or if my patch gets in first, I'll handle rebasing V10 myself. Thanks Benoît for spotting this! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Wed, Apr 3, 2013 at 3:30 AM, Benoît Thébaudeau wrote: > Here is the v10 bundle for those who want to test: > http://dl.free.fr/vdXBGExyq I would like to test it on mx31. I downloaded the mxc-nand-v10.bundle file, but I was not able to open it. Any suggestion? Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Fabio, On Wednesday, April 3, 2013 11:01:51 PM, Fabio Estevam wrote: > Hi Benoît, > > On Wed, Apr 3, 2013 at 3:30 AM, Benoît Thébaudeau > wrote: > > > Here is the v10 bundle for those who want to test: > > http://dl.free.fr/vdXBGExyq > > I would like to test it on mx31. I downloaded the mxc-nand-v10.bundle > file, but I was not able to open it. > > Any suggestion? What did you try? This is a Git bundle. You can use "git bundle verify mxc-nand-v10.bundle" to get the required reference point. Branch from u-boot-arm/master, then "git reset --hard" to this reference, then git pull from this bundle using the HEAD returned by "git bundle list-heads". Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Benoît Thébaudeau wrote: > The resulting HEAD is identical to yours, except for > board/freescale/mx31ads/u-boot.lds in which you had removed the following > unrelated line for 30/30: > __bss_end = .; > > Regarding this line, it is also present in a few other .lds, as well as the > following ones: > KEEP(*(.__bss_start)); > KEEP(*(__bss_end)); > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so there > is > perhaps something wrong here, unless you did that on purpose because of the > __bss_end test at the end of the linker script. I had noticed that, but I let > you handle it. If something needs to be changed here, please do it after my > series if possible in order to avoid a v11 because of newer rebase conflicts. > ;) I have a patch ready and currently undergoing build and run tests. As per http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags, I must ask your permission to add your 'Reported-By:' in my patch. Can I? > Best regards, > Benoît Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Albert, On Thursday, April 4, 2013 11:07:23 AM, Albert ARIBAUD wrote: > Hi Benoît, > > On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Benoît Thébaudeau > wrote: > > > The resulting HEAD is identical to yours, except for > > board/freescale/mx31ads/u-boot.lds in which you had removed the following > > unrelated line for 30/30: > > __bss_end = .; > > > > Regarding this line, it is also present in a few other .lds, as well as the > > following ones: > > KEEP(*(.__bss_start)); > > KEEP(*(__bss_end)); > > > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so > > there is > > perhaps something wrong here, unless you did that on purpose because of the > > __bss_end test at the end of the linker script. I had noticed that, but I > > let > > you handle it. If something needs to be changed here, please do it after my > > series if possible in order to avoid a v11 because of newer rebase > > conflicts. ;) > > I have a patch ready and currently undergoing build and run tests. As > per http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags, > I must ask your permission to add your 'Reported-By:' in my patch. Can I? Sure: Reported-by: Benoît Thébaudeau Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Thu, 4 Apr 2013 16:05:27 +0200 (CEST), Benoît Thébaudeau wrote: > Hi Albert, > > On Thursday, April 4, 2013 11:07:23 AM, Albert ARIBAUD wrote: > > Hi Benoît, > > > > On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Benoît Thébaudeau > > wrote: > > > > > The resulting HEAD is identical to yours, except for > > > board/freescale/mx31ads/u-boot.lds in which you had removed the following > > > unrelated line for 30/30: > > > __bss_end = .; > > > > > > Regarding this line, it is also present in a few other .lds, as well as > > > the > > > following ones: > > > KEEP(*(.__bss_start)); > > > KEEP(*(__bss_end)); > > > > > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so > > > there is > > > perhaps something wrong here, unless you did that on purpose because of > > > the > > > __bss_end test at the end of the linker script. I had noticed that, but I > > > let > > > you handle it. If something needs to be changed here, please do it after > > > my > > > series if possible in order to avoid a v11 because of newer rebase > > > conflicts. ;) > > > > I have a patch ready and currently undergoing build and run tests. As > > per http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags, > > I must ask your permission to add your 'Reported-By:' in my patch. Can I? > > Sure: > Reported-by: Benoît Thébaudeau Actually, I think you've just stated to our patchwork that your patch v9 18/30 fixes a bug reported by you... But never mind, v9 is superseded now anyway, and I'll put your Reported-By manually in my BSS fix patch. > Best regards, > Benoît Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Fabio, On Wednesday, April 3, 2013 11:42:07 PM, Benoît Thébaudeau wrote: > Hi Fabio, > > On Wednesday, April 3, 2013 11:01:51 PM, Fabio Estevam wrote: > > Hi Benoît, > > > > On Wed, Apr 3, 2013 at 3:30 AM, Benoît Thébaudeau > > wrote: > > > > > Here is the v10 bundle for those who want to test: > > > http://dl.free.fr/vdXBGExyq > > > > I would like to test it on mx31. I downloaded the mxc-nand-v10.bundle > > file, but I was not able to open it. > > > > Any suggestion? > > What did you try? This is a Git bundle. You can use > "git bundle verify mxc-nand-v10.bundle" to get the required reference point. > Branch from u-boot-arm/master, then "git reset --hard" to this reference, > then > git pull from this bundle using the HEAD returned by "git bundle list-heads". Did you have a chance to perform this test? Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Mon, Apr 8, 2013 at 3:47 PM, Benoît Thébaudeau wrote: > Did you have a chance to perform this test? I have built v10 bundle and will have access to my mx31pdk tomorrow morning. Will let you know the results. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Mon, Apr 8, 2013 at 3:55 PM, Fabio Estevam wrote: > Hi Benoît, > > On Mon, Apr 8, 2013 at 3:47 PM, Benoît Thébaudeau > wrote: > >> Did you have a chance to perform this test? > > I have built v10 bundle and will have access to my mx31pdk tomorrow morning. > > Will let you know the results. Just tested v10 on mx31pdk. As reported in v9 I start to get reboots and never reach the prompt. Then I disabled watchdog options in mx31pdk.h and I get the following: U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) CPU: Freescale i.MX31 rev 2.0 at 532 MHz. Reset cause: POR Board: MX31PDK DRAM: 128 MiB NAND: 256 MiB In:serial Out: serial Err: serial Net: (Board hangs here). When I tested v9 and removed watchdog support I was able to get into the U-boot prompt. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tue, Apr 9, 2013 at 9:30 AM, Fabio Estevam wrote: > Just tested v10 on mx31pdk. > > As reported in v9 I start to get reboots and never reach the prompt. > > Then I disabled watchdog options in mx31pdk.h and I get the following: > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > Reset cause: POR > Board: MX31PDK > DRAM: 128 MiB > NAND: 256 MiB > In:serial > Out: serial > Err: serial > Net: > > (Board hangs here). > > When I tested v9 and removed watchdog support I was able to get into > the U-boot prompt. I just added "#define DEBUG" in arch/arm/lib/board to start debugging this and for my surprise I can reach the prompt now: U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:35:51) U-Boot code: 87F0 -> 87F2C34C BSS: -> 87F3137C CPU: Freescale i.MX31 rev 2.0 at 532 MHz. Reset cause: POR Board: MX31PDK monitor len: 0003137C ramsize: 0800 TLB table from 87ff to 87ff4000 Top of RAM usable for U-Boot at: 87ff Reserving 196k for U-Boot at: 87fbe000 Reserving 640k for malloc() at: 87f1e000 Reserving 32 Bytes for Board Info at: 87f1dfe0 Reserving 160 Bytes for Global Data at: 87f1df40 New Stack Pointer is: 87f1df30 RAM Configuration: Bank #0: 8000 128 MiB relocation Offset is: 000be000 monitor flash len: 000310F4 Now running in RAM - U-Boot at: 87fbe000 NAND: 256 MiB In:serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 0 MX31PDK U-Boot > I remember to have added "#define DEBUG" in v9 as well, so looks like the behavior between v9 and v10 is consistent. Now we need to understand why the prompt is not reached without ""#define DEBUG". Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Fabio, On Tuesday, April 9, 2013 2:46:21 PM, Fabio Estevam wrote: > On Tue, Apr 9, 2013 at 9:30 AM, Fabio Estevam wrote: > > > Just tested v10 on mx31pdk. > > > > As reported in v9 I start to get reboots and never reach the prompt. > > > > Then I disabled watchdog options in mx31pdk.h and I get the following: > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) > > > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > Reset cause: POR > > Board: MX31PDK > > DRAM: 128 MiB > > NAND: 256 MiB > > In:serial > > Out: serial > > Err: serial > > Net: > > > > (Board hangs here). > > > > When I tested v9 and removed watchdog support I was able to get into > > the U-boot prompt. > > I just added "#define DEBUG" in arch/arm/lib/board to start debugging > this and for my surprise I can reach the prompt now: > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:35:51) > > U-Boot code: 87F0 -> 87F2C34C BSS: -> 87F3137C > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > Reset cause: POR > Board: MX31PDK > monitor len: 0003137C > ramsize: 0800 > TLB table from 87ff to 87ff4000 > Top of RAM usable for U-Boot at: 87ff > Reserving 196k for U-Boot at: 87fbe000 > Reserving 640k for malloc() at: 87f1e000 > Reserving 32 Bytes for Board Info at: 87f1dfe0 > Reserving 160 Bytes for Global Data at: 87f1df40 > New Stack Pointer is: 87f1df30 > RAM Configuration: > Bank #0: 8000 128 MiB > relocation Offset is: 000be000 > monitor flash len: 000310F4 > Now running in RAM - U-Boot at: 87fbe000 > NAND: 256 MiB > In:serial > Out: serial > Err: serial > Net: smc911x-0 > Hit any key to stop autoboot: 0 > MX31PDK U-Boot > > > I remember to have added "#define DEBUG" in v9 as well, so looks like > the behavior between v9 and v10 is consistent. > > Now we need to understand why the prompt is not reached without > ""#define DEBUG". CONFIG_SYS_NAND_U_BOOT_SIZE CONFIG_ENV_OFFSET ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tuesday, April 9, 2013 4:32:21 PM, Benoît Thébaudeau wrote: > Hi Fabio, > > On Tuesday, April 9, 2013 2:46:21 PM, Fabio Estevam wrote: > > On Tue, Apr 9, 2013 at 9:30 AM, Fabio Estevam wrote: > > > > > Just tested v10 on mx31pdk. > > > > > > As reported in v9 I start to get reboots and never reach the prompt. > > > > > > Then I disabled watchdog options in mx31pdk.h and I get the following: > > > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) > > > > > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > > Reset cause: POR > > > Board: MX31PDK > > > DRAM: 128 MiB > > > NAND: 256 MiB > > > In:serial > > > Out: serial > > > Err: serial > > > Net: > > > > > > (Board hangs here). > > > > > > When I tested v9 and removed watchdog support I was able to get into > > > the U-boot prompt. > > > > I just added "#define DEBUG" in arch/arm/lib/board to start debugging > > this and for my surprise I can reach the prompt now: > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:35:51) > > > > U-Boot code: 87F0 -> 87F2C34C BSS: -> 87F3137C > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > Reset cause: POR > > Board: MX31PDK > > monitor len: 0003137C > > ramsize: 0800 > > TLB table from 87ff to 87ff4000 > > Top of RAM usable for U-Boot at: 87ff > > Reserving 196k for U-Boot at: 87fbe000 > > Reserving 640k for malloc() at: 87f1e000 > > Reserving 32 Bytes for Board Info at: 87f1dfe0 > > Reserving 160 Bytes for Global Data at: 87f1df40 > > New Stack Pointer is: 87f1df30 > > RAM Configuration: > > Bank #0: 8000 128 MiB > > relocation Offset is: 000be000 > > monitor flash len: 000310F4 > > Now running in RAM - U-Boot at: 87fbe000 > > NAND: 256 MiB > > In:serial > > Out: serial > > Err: serial > > Net: smc911x-0 > > Hit any key to stop autoboot: 0 > > MX31PDK U-Boot > > > > > I remember to have added "#define DEBUG" in v9 as well, so looks like > > the behavior between v9 and v10 is consistent. > > > > Now we need to understand why the prompt is not reached without > > ""#define DEBUG". > > CONFIG_SYS_NAND_U_BOOT_SIZE > CONFIG_ENV_OFFSET > Please discard this message. Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Fabio, On Tuesday, April 9, 2013 2:46:21 PM, Fabio Estevam wrote: > On Tue, Apr 9, 2013 at 9:30 AM, Fabio Estevam wrote: > > > Just tested v10 on mx31pdk. > > > > As reported in v9 I start to get reboots and never reach the prompt. > > > > Then I disabled watchdog options in mx31pdk.h and I get the following: > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) > > > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > Reset cause: POR > > Board: MX31PDK > > DRAM: 128 MiB > > NAND: 256 MiB > > In:serial > > Out: serial > > Err: serial > > Net: > > > > (Board hangs here). > > > > When I tested v9 and removed watchdog support I was able to get into > > the U-boot prompt. > > I just added "#define DEBUG" in arch/arm/lib/board to start debugging > this and for my surprise I can reach the prompt now: > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:35:51) > > U-Boot code: 87F0 -> 87F2C34C BSS: -> 87F3137C > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > Reset cause: POR > Board: MX31PDK > monitor len: 0003137C > ramsize: 0800 > TLB table from 87ff to 87ff4000 > Top of RAM usable for U-Boot at: 87ff > Reserving 196k for U-Boot at: 87fbe000 > Reserving 640k for malloc() at: 87f1e000 > Reserving 32 Bytes for Board Info at: 87f1dfe0 > Reserving 160 Bytes for Global Data at: 87f1df40 > New Stack Pointer is: 87f1df30 > RAM Configuration: > Bank #0: 8000 128 MiB > relocation Offset is: 000be000 > monitor flash len: 000310F4 > Now running in RAM - U-Boot at: 87fbe000 > NAND: 256 MiB > In:serial > Out: serial > Err: serial > Net: smc911x-0 > Hit any key to stop autoboot: 0 > MX31PDK U-Boot > > > I remember to have added "#define DEBUG" in v9 as well, so looks like > the behavior between v9 and v10 is consistent. > > Now we need to understand why the prompt is not reached without > ""#define DEBUG". Can you try different values for the following configs in mx31pdk.h? - CONFIG_SYS_NAND_U_BOOT_SIZE - CONFIG_SPL_TEXT_BASE - CONFIG_SYS_TEXT_BASE - (CONFIG_ENV_OFFSET) - (CONFIG_ENV_OFFSET_REDUND) I would try: - 0x4 for CONFIG_SYS_NAND_U_BOOT_SIZE - 0x8600 for CONFIG_SPL_TEXT_BASE - 0x8700 for CONFIG_SYS_TEXT_BASE Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tuesday, April 9, 2013 4:38:23 PM, Benoît Thébaudeau wrote: > Hi Fabio, > > On Tuesday, April 9, 2013 2:46:21 PM, Fabio Estevam wrote: > > On Tue, Apr 9, 2013 at 9:30 AM, Fabio Estevam wrote: > > > > > Just tested v10 on mx31pdk. > > > > > > As reported in v9 I start to get reboots and never reach the prompt. > > > > > > Then I disabled watchdog options in mx31pdk.h and I get the following: > > > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) > > > > > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > > Reset cause: POR > > > Board: MX31PDK > > > DRAM: 128 MiB > > > NAND: 256 MiB > > > In:serial > > > Out: serial > > > Err: serial > > > Net: > > > > > > (Board hangs here). > > > > > > When I tested v9 and removed watchdog support I was able to get into > > > the U-boot prompt. > > > > I just added "#define DEBUG" in arch/arm/lib/board to start debugging > > this and for my surprise I can reach the prompt now: > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:35:51) > > > > U-Boot code: 87F0 -> 87F2C34C BSS: -> 87F3137C > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > Reset cause: POR > > Board: MX31PDK > > monitor len: 0003137C > > ramsize: 0800 > > TLB table from 87ff to 87ff4000 > > Top of RAM usable for U-Boot at: 87ff > > Reserving 196k for U-Boot at: 87fbe000 > > Reserving 640k for malloc() at: 87f1e000 > > Reserving 32 Bytes for Board Info at: 87f1dfe0 > > Reserving 160 Bytes for Global Data at: 87f1df40 > > New Stack Pointer is: 87f1df30 > > RAM Configuration: > > Bank #0: 8000 128 MiB > > relocation Offset is: 000be000 > > monitor flash len: 000310F4 > > Now running in RAM - U-Boot at: 87fbe000 > > NAND: 256 MiB > > In:serial > > Out: serial > > Err: serial > > Net: smc911x-0 > > Hit any key to stop autoboot: 0 > > MX31PDK U-Boot > > > > > I remember to have added "#define DEBUG" in v9 as well, so looks like > > the behavior between v9 and v10 is consistent. > > > > Now we need to understand why the prompt is not reached without > > ""#define DEBUG". > > Can you try different values for the following configs in mx31pdk.h? > - CONFIG_SYS_NAND_U_BOOT_SIZE > - CONFIG_SPL_TEXT_BASE > - CONFIG_SYS_TEXT_BASE > - (CONFIG_ENV_OFFSET) > - (CONFIG_ENV_OFFSET_REDUND) > > I would try: > - 0x4 for CONFIG_SYS_NAND_U_BOOT_SIZE > - 0x8600 for CONFIG_SPL_TEXT_BASE > - 0x8700 for CONFIG_SYS_TEXT_BASE I have retrieved your previous test trace: --- U-Boot 2013.01 (Feb 22 2013 - 16:25:48) CPU: Freescale i.MX31 rev 2.0 at 532 MHz. Reset cause: POR Board: MX31PDK DRAM: 128 MiB (hangs here). --- So it does not hang at the same step. Can you try to disable CONFIG_CMD_NET or to comment out eth_initialize() in arch/arm/lib/board.c? Do you know if something has changed in this function recently, or if there is something about it that has not yet been merged in the arm tree? Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tuesday, April 9, 2013 5:04:45 PM, Benoît Thébaudeau wrote: > On Tuesday, April 9, 2013 4:38:23 PM, Benoît Thébaudeau wrote: > > Hi Fabio, > > > > On Tuesday, April 9, 2013 2:46:21 PM, Fabio Estevam wrote: > > > On Tue, Apr 9, 2013 at 9:30 AM, Fabio Estevam wrote: > > > > > > > Just tested v10 on mx31pdk. > > > > > > > > As reported in v9 I start to get reboots and never reach the prompt. > > > > > > > > Then I disabled watchdog options in mx31pdk.h and I get the following: > > > > > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:23:01) > > > > > > > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > > > Reset cause: POR > > > > Board: MX31PDK > > > > DRAM: 128 MiB > > > > NAND: 256 MiB > > > > In:serial > > > > Out: serial > > > > Err: serial > > > > Net: > > > > > > > > (Board hangs here). > > > > > > > > When I tested v9 and removed watchdog support I was able to get into > > > > the U-boot prompt. > > > > > > I just added "#define DEBUG" in arch/arm/lib/board to start debugging > > > this and for my surprise I can reach the prompt now: > > > > > > U-Boot 2013.04-rc1-14135-gab21c72-dirty (Apr 09 2013 - 09:35:51) > > > > > > U-Boot code: 87F0 -> 87F2C34C BSS: -> 87F3137C > > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > > > Reset cause: POR > > > Board: MX31PDK > > > monitor len: 0003137C > > > ramsize: 0800 > > > TLB table from 87ff to 87ff4000 > > > Top of RAM usable for U-Boot at: 87ff > > > Reserving 196k for U-Boot at: 87fbe000 > > > Reserving 640k for malloc() at: 87f1e000 > > > Reserving 32 Bytes for Board Info at: 87f1dfe0 > > > Reserving 160 Bytes for Global Data at: 87f1df40 > > > New Stack Pointer is: 87f1df30 > > > RAM Configuration: > > > Bank #0: 8000 128 MiB > > > relocation Offset is: 000be000 > > > monitor flash len: 000310F4 > > > Now running in RAM - U-Boot at: 87fbe000 > > > NAND: 256 MiB > > > In:serial > > > Out: serial > > > Err: serial > > > Net: smc911x-0 > > > Hit any key to stop autoboot: 0 > > > MX31PDK U-Boot > > > > > > > I remember to have added "#define DEBUG" in v9 as well, so looks like > > > the behavior between v9 and v10 is consistent. > > > > > > Now we need to understand why the prompt is not reached without > > > ""#define DEBUG". > > > > Can you try different values for the following configs in mx31pdk.h? > > - CONFIG_SYS_NAND_U_BOOT_SIZE > > - CONFIG_SPL_TEXT_BASE > > - CONFIG_SYS_TEXT_BASE > > - (CONFIG_ENV_OFFSET) > > - (CONFIG_ENV_OFFSET_REDUND) > > > > I would try: > > - 0x4 for CONFIG_SYS_NAND_U_BOOT_SIZE > > - 0x8600 for CONFIG_SPL_TEXT_BASE > > - 0x8700 for CONFIG_SYS_TEXT_BASE > > I have retrieved your previous test trace: > --- > U-Boot 2013.01 (Feb 22 2013 - 16:25:48) > > CPU: Freescale i.MX31 rev 2.0 at 532 MHz. > Reset cause: POR > Board: MX31PDK > DRAM: 128 MiB > > (hangs here). > --- > > So it does not hang at the same step. > > Can you try to disable CONFIG_CMD_NET or to comment out eth_initialize() in > arch/arm/lib/board.c? Do you know if something has changed in this function > recently, or if there is something about it that has not yet been merged in > the > arm tree? gd->bd might also be broken for some reason. Can you print it with and without DEBUG, right before the call to eth_initialize()? Also, can you try to apply this patch? http://patchwork.ozlabs.org/patch/233964/ Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Benoît, On Tue, Apr 9, 2013 at 11:38 AM, Benoît Thébaudeau wrote: > Can you try different values for the following configs in mx31pdk.h? > - CONFIG_SYS_NAND_U_BOOT_SIZE > - CONFIG_SPL_TEXT_BASE > - CONFIG_SYS_TEXT_BASE > - (CONFIG_ENV_OFFSET) > - (CONFIG_ENV_OFFSET_REDUND) > > I would try: > - 0x4 for CONFIG_SYS_NAND_U_BOOT_SIZE > - 0x8600 for CONFIG_SPL_TEXT_BASE > - 0x8700 for CONFIG_SYS_TEXT_BASE Thanks, that did the trick! With the changes below I am able to get into the U-boot prompt: diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h index 8f12825..d82bf65 100644 --- a/include/configs/mx31pdk.h +++ b/include/configs/mx31pdk.h @@ -51,8 +51,8 @@ #define CONFIG_SPL_MAX_SIZE2048 #define CONFIG_SPL_NAND_SUPPORT -#define CONFIG_SPL_TEXT_BASE 0x87ec -#define CONFIG_SYS_TEXT_BASE 0x87f0 +#define CONFIG_SPL_TEXT_BASE 0x8600 +#define CONFIG_SYS_TEXT_BASE 0x8700 #ifndef CONFIG_SPL_BUILD #define CONFIG_SKIP_LOWLEVEL_INIT @@ -69,8 +69,6 @@ #define CONFIG_MXC_UART #define CONFIG_MXC_UART_BASE UART1_BASE -#define CONFIG_HW_WATCHDOG -#define CONFIG_IMX_WATCHDOG #define CONFIG_MXC_GPIO #define CONFIG_HARD_SPI @@ -199,7 +197,7 @@ /* Start copying real U-boot from the second page */ #define CONFIG_SYS_NAND_U_BOOT_OFFSCONFIG_SPL_PAD_TO -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x4 /* Load U-Boot to this address */ #define CONFIG_SYS_NAND_U_BOOT_DST CONFIG_SYS_TEXT_BASE #define CONFIG_SYS_NAND_U_BOOT_START CONFIG_SYS_NAND_U_BOOT_DST -- 1.7.9. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Fabio, On Tuesday, April 9, 2013 6:40:45 PM, Fabio Estevam wrote: > Hi Benoît, > > On Tue, Apr 9, 2013 at 11:38 AM, Benoît Thébaudeau > wrote: > > > Can you try different values for the following configs in mx31pdk.h? > > - CONFIG_SYS_NAND_U_BOOT_SIZE > > - CONFIG_SPL_TEXT_BASE > > - CONFIG_SYS_TEXT_BASE > > - (CONFIG_ENV_OFFSET) > > - (CONFIG_ENV_OFFSET_REDUND) > > > > I would try: > > - 0x4 for CONFIG_SYS_NAND_U_BOOT_SIZE > > - 0x8600 for CONFIG_SPL_TEXT_BASE > > - 0x8700 for CONFIG_SYS_TEXT_BASE > > Thanks, that did the trick! > > With the changes below I am able to get into the U-boot prompt: > > diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h > index 8f12825..d82bf65 100644 > --- a/include/configs/mx31pdk.h > +++ b/include/configs/mx31pdk.h > @@ -51,8 +51,8 @@ > #define CONFIG_SPL_MAX_SIZE 2048 > #define CONFIG_SPL_NAND_SUPPORT > > -#define CONFIG_SPL_TEXT_BASE 0x87ec > -#define CONFIG_SYS_TEXT_BASE 0x87f0 > +#define CONFIG_SPL_TEXT_BASE 0x8600 > +#define CONFIG_SYS_TEXT_BASE 0x8700 > > #ifndef CONFIG_SPL_BUILD > #define CONFIG_SKIP_LOWLEVEL_INIT > @@ -69,8 +69,6 @@ > > #define CONFIG_MXC_UART > #define CONFIG_MXC_UART_BASE UART1_BASE > -#define CONFIG_HW_WATCHDOG > -#define CONFIG_IMX_WATCHDOG > #define CONFIG_MXC_GPIO > > #define CONFIG_HARD_SPI > @@ -199,7 +197,7 @@ > > /* Start copying real U-boot from the second page */ > #define CONFIG_SYS_NAND_U_BOOT_OFFS CONFIG_SPL_PAD_TO > -#define CONFIG_SYS_NAND_U_BOOT_SIZE 0x32000 > +#define CONFIG_SYS_NAND_U_BOOT_SIZE 0x4 > /* Load U-Boot to this address */ > #define CONFIG_SYS_NAND_U_BOOT_DST CONFIG_SYS_TEXT_BASE > #define CONFIG_SYS_NAND_U_BOOT_START CONFIG_SYS_NAND_U_BOOT_DST Cool, then we need to determine the minimal change set required for v11, so can you retry with fewer of those changes to determine which ones are strictly necessary (apart from the watchdog removal that we already know is required)? What is the size of u-boot-with-spl.bin without DEBUG? Regarding the watchdog removal, it is unrelated to this patch, so do you want me to add a patch for it in this series, or will you handle it separately? And is the correct change to remove it as above, or to change its time-out somewhere? I think that it's probably better if you take care of this separately. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Albert, On Wednesday, April 3, 2013 10:05:57 AM, Albert ARIBAUD wrote: > Hi Benoît, > > On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Benoît Thébaudeau > wrote: > > > Hi Albert, > > > > Here is the v10 bundle for those who want to test: > > http://dl.free.fr/vdXBGExyq > > Thanks, will build-test it ASAP. > > People with ARM (expecially tx25 and mx31pdk) and non-ARM boards please > run-test it too. Following Fabio's tests, I will issue a v11 today with a small change in 18/30 limited to mx31pdk.h. Do you want me to do it on top of your "[PATCH] ARM: Fix __bss_start and __bss_end in linker scripts", or not? Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tuesday, April 9, 2013 6:56:18 PM, Benoît Thébaudeau wrote: > Hi Fabio, > > On Tuesday, April 9, 2013 6:40:45 PM, Fabio Estevam wrote: > > Hi Benoît, > > > > On Tue, Apr 9, 2013 at 11:38 AM, Benoît Thébaudeau > > wrote: > > > > > Can you try different values for the following configs in mx31pdk.h? > > > - CONFIG_SYS_NAND_U_BOOT_SIZE > > > - CONFIG_SPL_TEXT_BASE > > > - CONFIG_SYS_TEXT_BASE > > > - (CONFIG_ENV_OFFSET) > > > - (CONFIG_ENV_OFFSET_REDUND) > > > > > > I would try: > > > - 0x4 for CONFIG_SYS_NAND_U_BOOT_SIZE > > > - 0x8600 for CONFIG_SPL_TEXT_BASE > > > - 0x8700 for CONFIG_SYS_TEXT_BASE > > > > Thanks, that did the trick! > > > > With the changes below I am able to get into the U-boot prompt: > > > > diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h > > index 8f12825..d82bf65 100644 > > --- a/include/configs/mx31pdk.h > > +++ b/include/configs/mx31pdk.h > > @@ -51,8 +51,8 @@ > > #define CONFIG_SPL_MAX_SIZE2048 > > #define CONFIG_SPL_NAND_SUPPORT > > > > -#define CONFIG_SPL_TEXT_BASE 0x87ec > > -#define CONFIG_SYS_TEXT_BASE 0x87f0 > > +#define CONFIG_SPL_TEXT_BASE 0x8600 > > +#define CONFIG_SYS_TEXT_BASE 0x8700 > > > > #ifndef CONFIG_SPL_BUILD > > #define CONFIG_SKIP_LOWLEVEL_INIT > > @@ -69,8 +69,6 @@ > > > > #define CONFIG_MXC_UART > > #define CONFIG_MXC_UART_BASE UART1_BASE > > -#define CONFIG_HW_WATCHDOG > > -#define CONFIG_IMX_WATCHDOG > > #define CONFIG_MXC_GPIO > > > > #define CONFIG_HARD_SPI > > @@ -199,7 +197,7 @@ > > > > /* Start copying real U-boot from the second page */ > > #define CONFIG_SYS_NAND_U_BOOT_OFFSCONFIG_SPL_PAD_TO > > -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 > > +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x4 > > /* Load U-Boot to this address */ > > #define CONFIG_SYS_NAND_U_BOOT_DST CONFIG_SYS_TEXT_BASE > > #define CONFIG_SYS_NAND_U_BOOT_START CONFIG_SYS_NAND_U_BOOT_DST > > Cool, then we need to determine the minimal change set required for v11, so > can > you retry with fewer of those changes to determine which ones are strictly > necessary (apart from the watchdog removal that we already know is required)? Especially, does it work with only: -#define CONFIG_HW_WATCHDOG -#define CONFIG_IMX_WATCHDOG -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x3f800 ? > What is the size of u-boot-with-spl.bin without DEBUG? > > Regarding the watchdog removal, it is unrelated to this patch, so do you want > me > to add a patch for it in this series, or will you handle it separately? And > is > the correct change to remove it as above, or to change its time-out > somewhere? I > think that it's probably better if you take care of this separately. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tue, Apr 9, 2013 at 2:37 PM, Benoît Thébaudeau wrote: > Especially, does it work with only: > -#define CONFIG_HW_WATCHDOG > -#define CONFIG_IMX_WATCHDOG > -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 > +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x3f800 No, it hangs in "Net :". Also tried 0x4 and the same hang happens. Maybe we should use the proposed values you proposed earlier? I can handle the watchdog patch separately. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
Hi Fabio, On Tuesday, April 9, 2013 8:07:31 PM, Fabio Estevam wrote: > On Tue, Apr 9, 2013 at 2:37 PM, Benoît Thébaudeau > wrote: > > > Especially, does it work with only: > > -#define CONFIG_HW_WATCHDOG > > -#define CONFIG_IMX_WATCHDOG > > -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 > > +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x3f800 > > No, it hangs in "Net :". Also tried 0x4 and the same hang happens. OK. > Maybe we should use the proposed values you proposed earlier? These values were very wide, just for testing. It'd be better to adjust them. So can you just try the following, and I'll stop asking for more tests: -#define CONFIG_SPL_TEXT_BASE 0x87ec -#define CONFIG_SYS_TEXT_BASE 0x87f0 +#define CONFIG_SPL_TEXT_BASE 0x87dc +#define CONFIG_SYS_TEXT_BASE 0x87e0 -#define CONFIG_HW_WATCHDOG -#define CONFIG_IMX_WATCHDOG -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x3f800 ? > I can handle the watchdog patch separately. OK. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tue, Apr 9, 2013 at 3:10 PM, Benoît Thébaudeau wrote: > These values were very wide, just for testing. It'd be better to adjust them. > So > can you just try the following, and I'll stop asking for more tests: > -#define CONFIG_SPL_TEXT_BASE 0x87ec > -#define CONFIG_SYS_TEXT_BASE 0x87f0 > +#define CONFIG_SPL_TEXT_BASE 0x87dc > +#define CONFIG_SYS_TEXT_BASE 0x87e0 > -#define CONFIG_HW_WATCHDOG > -#define CONFIG_IMX_WATCHDOG > -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 > +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x3f800 These values work fine, thanks. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL
On Tuesday, April 9, 2013 8:35:09 PM, Fabio Estevam wrote: > On Tue, Apr 9, 2013 at 3:10 PM, Benoît Thébaudeau > wrote: > > > These values were very wide, just for testing. It'd be better to adjust > > them. So > > can you just try the following, and I'll stop asking for more tests: > > -#define CONFIG_SPL_TEXT_BASE 0x87ec > > -#define CONFIG_SYS_TEXT_BASE 0x87f0 > > +#define CONFIG_SPL_TEXT_BASE 0x87dc > > +#define CONFIG_SYS_TEXT_BASE 0x87e0 > > -#define CONFIG_HW_WATCHDOG > > -#define CONFIG_IMX_WATCHDOG > > -#define CONFIG_SYS_NAND_U_BOOT_SIZE0x32000 > > +#define CONFIG_SYS_NAND_U_BOOT_SIZE0x3f800 > > These values work fine, thanks. Thanks for testing and for your patience. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
