Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/11/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: On 12/11/06, Adam Lally <[EMAIL PROTECTED]> wrote: > > On 12/11/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > > When I run InstallPear it throws exception (uima.home not defined) and > > stops. Actually, we don't need uima.home any more in this code, so the > code > > needs to be modified in order to completely get rid of uima.home. Can > I do > > this withing the same JIRA issue (UIMA-101), or should we have another > issue > > ? > > > > Go ahead and attach a patch to UIMA-101. > > I was using the run configuration in uimaj-examples, which defines > uima.home. But if we don't need it, I'm very happy to get rid of it. > > -Adam > Since the PEAR verification code now can use current application CLASSPATH instead of explicitly adding UIMA JARs (based on uima.home), we can get rid of uima.home in the InstallPear code as well. I'll create the patch for the code and the help file. -- Lev I created and attached a patch for the InstallPear code, but left the help file unchanged. We still need UIMA_HOME env. var. in the script files (runPearInstaller.*). -- Lev
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/11/06, Adam Lally <[EMAIL PROTECTED]> wrote: On 12/11/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > When I run InstallPear it throws exception (uima.home not defined) and > stops. Actually, we don't need uima.home any more in this code, so the code > needs to be modified in order to completely get rid of uima.home. Can I do > this withing the same JIRA issue (UIMA-101), or should we have another issue > ? > Go ahead and attach a patch to UIMA-101. I was using the run configuration in uimaj-examples, which defines uima.home. But if we don't need it, I'm very happy to get rid of it. -Adam Since the PEAR verification code now can use current application CLASSPATH instead of explicitly adding UIMA JARs (based on uima.home), we can get rid of uima.home in the InstallPear code as well. I'll create the patch for the code and the help file. -- Lev
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/11/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: When I run InstallPear it throws exception (uima.home not defined) and stops. Actually, we don't need uima.home any more in this code, so the code needs to be modified in order to completely get rid of uima.home. Can I do this withing the same JIRA issue (UIMA-101), or should we have another issue ? Go ahead and attach a patch to UIMA-101. I was using the run configuration in uimaj-examples, which defines uima.home. But if we don't need it, I'm very happy to get rid of it. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/8/06, Adam Lally <[EMAIL PROTECTED]> wrote: On 12/8/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > Actually, I already started modifying the code, so now I need to review > your changes and, may be, add more. > OK. Your last email sounded like you weren't going to work on this. Just a minute ago I checked in the changes to allow the help file to be stored in the jar file, located using the ClassLoader, and viewed in a JEditorPane. This fixes JIRA issue UIMA-101 to my satisfaction. I'm done working on this file, so it's all yours if you find more modifications that need to be made. -Adam When I run InstallPear it throws exception (uima.home not defined) and stops. Actually, we don't need uima.home any more in this code, so the code needs to be modified in order to completely get rid of uima.home. Can I do this withing the same JIRA issue (UIMA-101), or should we have another issue ? -- Lev
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/8/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: Actually, I already started modifying the code, so now I need to review your changes and, may be, add more. OK. Your last email sounded like you weren't going to work on this. Just a minute ago I checked in the changes to allow the help file to be stored in the jar file, located using the ClassLoader, and viewed in a JEditorPane. This fixes JIRA issue UIMA-101 to my satisfaction. I'm done working on this file, so it's all yours if you find more modifications that need to be made. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/8/06, Adam Lally <[EMAIL PROTECTED]> wrote: On 12/8/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > > 1) When PearInstaller launches the JVM for CVD, it will set its > > classpath to the contents of the java.class.path system property of > > the PearInstaller's own JVM. Thus CVD will run with the same > > classpath as PearInstaller. Since CVD is in the same jar as > > PearInstaller and both depend on uima-core.jar, this should work. (I > > don't think we need to support cases where a user has pulled apart our > > jar files.) > > > This will work, of course, but requires significant modifications in the > code :) > It only took me a few minutes to do. I've committed the changes. It seems to work, though maybe you'll tell me I missed something. Actually, I already started modifying the code, so now I need to review your changes and, may be, add more. uima.datapath is used by Gladis to search for sample text files. This is > just a 'convenience' feature for users who want to test their installed > PEARs with sample UIMA documents, and we can easily drop it. I cannot find this feature in the CVD. Maybe it has been removed? Anyway things seem to now be working fine now without passing uima.home or uima.datapath to CVD. > We would prefer to avoid modifying the old PEAR Installer code and rather > wait for the future RCP application, unless it's absolutely necessary for > this SDK release. > I agree we shouldn't be doing any significant enhancements to PEAR Installer, but these don't seem that significant. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/8/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > 1) When PearInstaller launches the JVM for CVD, it will set its > classpath to the contents of the java.class.path system property of > the PearInstaller's own JVM. Thus CVD will run with the same > classpath as PearInstaller. Since CVD is in the same jar as > PearInstaller and both depend on uima-core.jar, this should work. (I > don't think we need to support cases where a user has pulled apart our > jar files.) This will work, of course, but requires significant modifications in the code :) It only took me a few minutes to do. I've committed the changes. It seems to work, though maybe you'll tell me I missed something. uima.datapath is used by Gladis to search for sample text files. This is just a 'convenience' feature for users who want to test their installed PEARs with sample UIMA documents, and we can easily drop it. I cannot find this feature in the CVD. Maybe it has been removed? Anyway things seem to now be working fine now without passing uima.home or uima.datapath to CVD. We would prefer to avoid modifying the old PEAR Installer code and rather wait for the future RCP application, unless it's absolutely necessary for this SDK release. I agree we shouldn't be doing any significant enhancements to PEAR Installer, but these don't seem that significant. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/8/06, Adam Lally <[EMAIL PROTECTED]> wrote: On 12/8/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > Unfortunately, the problem is more complicated that I thought at the > beginning. > Let me try to simplify. I'll propose a solution and you can tell me why it wouldn't work. 1) When PearInstaller launches the JVM for CVD, it will set its classpath to the contents of the java.class.path system property of the PearInstaller's own JVM. Thus CVD will run with the same classpath as PearInstaller. Since CVD is in the same jar as PearInstaller and both depend on uima-core.jar, this should work. (I don't think we need to support cases where a user has pulled apart our jar files.) This will work, of course, but requires significant modifications in the code :) 2) Stop launching an external browser to view the help file. Instead use a JEditorPane. I know that control doesn't have the greatest HTML support, but this is only a help file, so it should suffice. You can now store the piHelp.html file in uima-tools.jar and locate its content using the ClassLoader. uima.home will no longer be needed for this purpose. We can simplify the help file and use a message box to display it. 3) CVD doesn't need the uima.home JVM arg. 4) I don't know what uima.datapathchild is. Do you mean uima.datapath? Shouldn't this be determined by what's in the metadata for the PEAR file that's being tested? Or, just set this to whatever uima.home was set to when PEAR Installer itself was run. uima.datapath is used by Gladis to search for sample text files. This is just a 'convenience' feature for users who want to test their installed PEARs with sample UIMA documents, and we can easily drop it. Summary: PEAR Installer shouldn't need to know what the uima install location is. If we remove the dependencies on that, it will make life easier. -Adam We would prefer to avoid modifying the old PEAR Installer code and rather wait for the future RCP application, unless it's absolutely necessary for this SDK release. -- Lev
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/8/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: Unfortunately, the problem is more complicated that I thought at the beginning. Let me try to simplify. I'll propose a solution and you can tell me why it wouldn't work. 1) When PearInstaller launches the JVM for CVD, it will set its classpath to the contents of the java.class.path system property of the PearInstaller's own JVM. Thus CVD will run with the same classpath as PearInstaller. Since CVD is in the same jar as PearInstaller and both depend on uima-core.jar, this should work. (I don't think we need to support cases where a user has pulled apart our jar files.) 2) Stop launching an external browser to view the help file. Instead use a JEditorPane. I know that control doesn't have the greatest HTML support, but this is only a help file, so it should suffice. You can now store the piHelp.html file in uima-tools.jar and locate its content using the ClassLoader. uima.home will no longer be needed for this purpose. 3) CVD doesn't need the uima.home JVM arg. 4) I don't know what uima.datapathchild is. Do you mean uima.datapath? Shouldn't this be determined by what's in the metadata for the PEAR file that's being tested? Or, just set this to whatever uima.home was set to when PEAR Installer itself was run. Summary: PEAR Installer shouldn't need to know what the uima install location is. If we remove the dependencies on that, it will make life easier. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/6/06, Adam Lally <[EMAIL PROTECTED]> wrote: On 12/6/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: > We just need to modify the InstallPear class main() method code to check if > the CVD class, specified in the gladis.properties file, is on the > classpath. We also may need to clean-up the pi.properties file. > OK, I'll leave this for you to submit a patch, if you know what needs to be done. Unfortunately, the problem is more complicated that I thought at the beginning. The InstallPear application does not load the CVD main class in its own JVM. The CVD application is loaded in the child JVM process, and the classpath for this process is created from the env.CLASSPATH property in the gladis.properties file (it contains some UIMA folders and libs, including uima_tools.jar). So, even if we can find the CVS main class in the main JVM classpath, it does not help in running CVD application in a child JVM. It looks like more changes needed in the InstallPear code to make sure it runs outside of installed UIMA framework (with all the libs and folders in place). Another problem is that InstallPear code requires uima.home JVM system > property. I'm not sure what can we do in the case when this property is not > set. > Is uima.home only used for launching CVD and finding the help file, or are the other uses? It shouldn't be needed for launching CVD if we apply the idea of using the java.class.path property. Maybe there is a better approach to the help file? For example using a Swing widget for viewing the HTML instead of launching a browser? Then the html file could be included in the jar file. -Adam Actually, uima.home JVM option is heavily used in the InstallPear code for configuring and running CVD, as well as getting help file URL. For CVD it needs more than just CLASSPATH (e.g. configuring uima.home and uima.datapathchild JVM options), so removing the InstallPear code dependency on uima.home will not be easy. Actually, there is a plan to sunset the InstallPear and replace it with a new plugin-based solution, but this will not happen in the nearest future.
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/6/06, Lev Kozakov <[EMAIL PROTECTED]> wrote: We just need to modify the InstallPear class main() method code to check if the CVD class, specified in the gladis.properties file, is on the classpath. We also may need to clean-up the pi.properties file. OK, I'll leave this for you to submit a patch, if you know what needs to be done. Another problem is that InstallPear code requires uima.home JVM system property. I'm not sure what can we do in the case when this property is not set. Is uima.home only used for launching CVD and finding the help file, or are the other uses? It shouldn't be needed for launching CVD if we apply the idea of using the java.class.path property. Maybe there is a better approach to the help file? For example using a Swing widget for viewing the HTML instead of launching a browser? Then the html file could be included in the jar file. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/6/06, Adam Lally <[EMAIL PROTECTED]> wrote: > Yes, we lost the help file for the PEAR Installer. So previously this was stored under $UIMA_HOME/docs/pear/piHelp.html. Is that still the plan? I guess it can't be in a jar file since we're actually launching an external browser to view it? I can fix up the last version of the help file I have and make sure it gets to the appropriate place. Yes, the help URL is specified in the pi.properties file and passed to the default browser. Regarding the error message you get: pear_tools.jar is specified in the > pi.properties file. You can modify it to something else, but this will not > help in all cases. We need to modify the InstallPear code to look for the > CVD class rather then for a JAR file. > We could use the java.class.path property when launching the CVD. This should work since uima-tools.jar (there's no more pear-tools.jar) should be on the classpath in order to run the PEAR installer. -Adam We just need to modify the InstallPear class main() method code to check if the CVD class, specified in the gladis.properties file, is on the classpath. We also may need to clean-up the pi.properties file. Another problem is that InstallPear code requires uima.home JVM system property. I'm not sure what can we do in the case when this property is not set. -- Lev
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
Yes, we lost the help file for the PEAR Installer. So previously this was stored under $UIMA_HOME/docs/pear/piHelp.html. Is that still the plan? I guess it can't be in a jar file since we're actually launching an external browser to view it? I can fix up the last version of the help file I have and make sure it gets to the appropriate place. Regarding the error message you get: pear_tools.jar is specified in the pi.properties file. You can modify it to something else, but this will not help in all cases. We need to modify the InstallPear code to look for the CVD class rather then for a JAR file. We could use the java.class.path property when launching the CVD. This should work since uima-tools.jar (there's no more pear-tools.jar) should be on the classpath in order to run the PEAR installer. -Adam
Re: [jira] Created: (UIMA-101) PEAR Installer prints warning messages on startup
On 12/5/06, Adam Lally (JIRA) wrote: PEAR Installer prints warning messages on startup - Key: UIMA-101 URL: http://issues.apache.org/jira/browse/UIMA-101 Project: UIMA Issue Type: Bug Components: Tools Reporter: Adam Lally Fix For: 2.1 When I start the PEAR installer I get the following messages: C:/Program Files/apache-uima/lib/uima_tools.jar not found C:/Program Files/apache-uima/docs/pear/piHelp.html not found The former needs to be uima-tools.jar, but is this even needed at all? It was used to find CVD, but CVD is now in the same jar as pear installer. As for the latter, did we lose the help file? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira Yes, we lost the help file for the PEAR Installer. Regarding the error message you get: pear_tools.jar is specified in the pi.properties file. You can modify it to something else, but this will not help in all cases. We need to modify the InstallPear code to look for the CVD class rather then for a JAR file. -- Lev
