Re: javax.annotation.PostConstruct issue when running with JDK11

[Jean-Baptiste Onofré]

Please let me know if you have any issue.

By the way, I'm preparing blog post + documentation update about how to
use Karaf on Java 10/11 and dealing with modules.

I created a Jira about that:

https://issues.apache.org/jira/browse/KARAF-5938

I also plan to add few examples about that (in karaf/examples).

Regards
JB

On 01/10/2018 19:18, Oleg Cohen wrote:
> Thank you, JB! I will give it a try.
> 
> Best
> Oleg
> 
> Sent from my iPhone
> 
>> On Oct 1, 2018, at 11:57 AM, Jean-Baptiste Onofré  wrote:
>>
>> Hi Oleg,
>>
>> You can add at Karaf level (in the startup) or via dynamic-import on pax
>> web.
>>
>> Regards
>> JB
>>
>>> On 01/10/2018 17:44, Oleg Cohen wrote:
>>> Thank you, JB!
>>>
>>> In my case it is pax-web that can’t find the class, so I guess I need to 
>>> add to ext lib. How can I add it? Should I do it at the JDK level or it is 
>>> a mechanism in Karaf?
>>>
>>> Thank you,
>>> Oleg
>>>
 On Oct 1, 2018, at 11:33 AM, Jean-Baptiste Onofré  
 wrote:

 Hi Oleg,

 Correct, javax.annotation is available up to Java 10 (and even using
 Java 10, the javax.annotation package has been splitted).

 When using Java 11, you have to explicitly install either jsr305 or
 javax.annotation jar files (it could be as private package of your
 bundle, or ext lib).

 Regards
 JB

> On 01/10/2018 17:14, Oleg Cohen wrote:
> Greetings,
>
> I am trying to run my Karaf application under JDK 11. I am getting the 
> following exception:
>
> Caused by: java.lang.ClassNotFoundException: 
> javax.annotation.PostConstruct cannot be found by 
> org.ops4j.pax.web.pax-web-jsp_7.2.3
>
> It appears that the jigsaw module providing this package is not available 
> in JDK 11. The suggestion is to use a dependency.
>
> Wondering if anybody ran into this and what a solution/workaround might 
> be.
>
> Thank you!
> Oleg
>

 --
 Jean-Baptiste Onofré
 jbono...@apache.org
 http://blog.nanthrax.net
 Talend - http://www.talend.com
>>>

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: javax.annotation.PostConstruct issue when running with JDK11

[Oleg Cohen]

Thank you, JB! I will give it a try.

Best
Oleg

Sent from my iPhone

> On Oct 1, 2018, at 11:57 AM, Jean-Baptiste Onofré  wrote:
>
> Hi Oleg,
>
> You can add at Karaf level (in the startup) or via dynamic-import on pax
> web.
>
> Regards
> JB
>
>> On 01/10/2018 17:44, Oleg Cohen wrote:
>> Thank you, JB!
>>
>> In my case it is pax-web that can’t find the class, so I guess I need to add 
>> to ext lib. How can I add it? Should I do it at the JDK level or it is a 
>> mechanism in Karaf?
>>
>> Thank you,
>> Oleg
>>
>>> On Oct 1, 2018, at 11:33 AM, Jean-Baptiste Onofré  wrote:
>>>
>>> Hi Oleg,
>>>
>>> Correct, javax.annotation is available up to Java 10 (and even using
>>> Java 10, the javax.annotation package has been splitted).
>>>
>>> When using Java 11, you have to explicitly install either jsr305 or
>>> javax.annotation jar files (it could be as private package of your
>>> bundle, or ext lib).
>>>
>>> Regards
>>> JB
>>>
 On 01/10/2018 17:14, Oleg Cohen wrote:
 Greetings,

 I am trying to run my Karaf application under JDK 11. I am getting the 
 following exception:

 Caused by: java.lang.ClassNotFoundException: 
 javax.annotation.PostConstruct cannot be found by 
 org.ops4j.pax.web.pax-web-jsp_7.2.3

 It appears that the jigsaw module providing this package is not available 
 in JDK 11. The suggestion is to use a dependency.

 Wondering if anybody ran into this and what a solution/workaround might be.

 Thank you!
 Oleg

>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbono...@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>

Re: Sudden NoFileAssignedException during karaf distro build.

[Erwin Hogeweg]

Thanks Oleg,

Erwin


> On Oct 1, 2018, at 09:58, Oleg Cohen  wrote:
> 
> Hi Erwin,
> 
> I ran into the same last night. I guess 3.0.0-M1 is new and has 
> issues/incompatibilities with the Karaf plugin. 
> 
> The way I fixed it was to define the following in the pluginManagement in the 
> pom.xml or a parent pom.xml to force versions 2.5.2 and 2.8.2 for the install 
> and deploy plugins respectively:
> 
>   
>   
>   
>   
>   
> org.apache.maven.plugins
>   
> maven-install-plugin
>   2.5.2
>   
>   
>   
> org.apache.maven.plugins
>   
> maven-deploy-plugin
>   2.8.2
>   
>   
>   
> org.apache.karaf.tooling
>   
> karaf-maven-plugin
>   
> ${org.apache.karaf.version}
>   true
>   
>   
>   
>   
> 
> Hope this helps.
> 
> Thank you,
> Oleg
> 
> 
>> On Oct 1, 2018, at 9:49 AM, Erwin Hogeweg > > wrote:
>> 
>> Hi -
>> 
>> All of a sudden we are getting a maven build this error when building a 
>> karaf distribution. This started late yesterday and happens on multiple 
>> developer machines but not all. I have nuked my entire .m2 repo and rolled 
>> back to a version well before the issue started but I still get the same 
>> error.
>> 
>> We’re kinda scratching our heads here… Has anyone an idea what is going on?
>> 
>> [ERROR] Failed to execute goal 
>> org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install 
>> (default-install) on project my-distribution: NoFileAssignedException: The 
>> packaging plugin for this project did not assign a main file to the project 
>> but it has attachments. Change packaging to 'pom'. -> [Help 1]
>> 
>> Karaf-4.2.0
>> Java-1.8.0_92
>> Maven-3.5.0
>> 
>> 
>> Thanks,
>> 
>> Erwin
>> 
> 

Re: Sudden NoFileAssignedException during karaf distro build.

[Erwin Hogeweg]

Thanks guys.

Erwin

> On Oct 1, 2018, at 11:38, Jean-Baptiste Onofré  wrote:
> 
> Sorry, I thought you used both 3.x for Karaf and maven-install-plugin.
> 
> The maven-install-plugin 3.0.0.M1 (released couple of days ago) changed
> the way to deal with project packaging. I have to change the way of
> attaching the artifact by the Karaf maven plugin.
> 
> As workaround, you have to use maven-install-plugin 2.5.2 by explicitly
> defining the version in your pom.xml.
> 
> Regards
> JB
> 
> On 01/10/2018 17:32, Erwin Hogeweg wrote:
>> Hi JB,
>> 
>>> ouch, that's a little bit old version of the plugin ;)
>> Not sure which plugin you are talking about. As far as I can see 3.0.0-M1 is 
>> the latest available maven-install-plugin.
>> 
>>> Anyway, you should define the Maven dependencies for this version of the 
>>> plugin.
>>> 
>>> Any change to update to Karaf 4.x at least for Maven plugin?
>> I am on Karaf-4.2.0… for the karaf-maven-plugin.
>> 
>> Erwin
>> 
>> 
>>> 
>>> Regards
>>> JB
>>> 
>>> On 01/10/2018 15:49, Erwin Hogeweg wrote:
 Hi -
 
 All of a sudden we are getting a maven build this error when building a
 karaf distribution. This started late yesterday and happens on multiple
 developer machines but not all. I have nuked my entire .m2 repo and
 rolled back to a version well before the issue started but I still get
 the same error.
 
 We’re kinda scratching our heads here… Has anyone an idea what is going on?
 
 [*ERROR*] Failed to execute goal
 org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install*(default-install)*
 on project my-distribution: *NoFileAssignedException*: The packaging
 plugin for this project did not assign a main file to the project but it
 has attachments. Change packaging to 'pom'. -> *[Help 1]*
 
 Karaf-4.2.0
 Java-1.8.0_92
 Maven-3.5.0
 
 
 Thanks,
 
 Erwin
 
>>> 
>>> -- 
>>> Jean-Baptiste Onofré
>>> jbono...@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>> 
> 
> -- 
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com

Re: javax.annotation.PostConstruct issue when running with JDK11

[Jean-Baptiste Onofré]

Hi Oleg,

You can add at Karaf level (in the startup) or via dynamic-import on pax 
web.


Regards
JB

On 01/10/2018 17:44, Oleg Cohen wrote:

Thank you, JB!

In my case it is pax-web that can’t find the class, so I guess I need to add to 
ext lib. How can I add it? Should I do it at the JDK level or it is a mechanism 
in Karaf?

Thank you,
Oleg


On Oct 1, 2018, at 11:33 AM, Jean-Baptiste Onofré  wrote:

Hi Oleg,

Correct, javax.annotation is available up to Java 10 (and even using
Java 10, the javax.annotation package has been splitted).

When using Java 11, you have to explicitly install either jsr305 or
javax.annotation jar files (it could be as private package of your
bundle, or ext lib).

Regards
JB

On 01/10/2018 17:14, Oleg Cohen wrote:

Greetings,

I am trying to run my Karaf application under JDK 11. I am getting the 
following exception:

Caused by: java.lang.ClassNotFoundException: javax.annotation.PostConstruct 
cannot be found by org.ops4j.pax.web.pax-web-jsp_7.2.3

It appears that the jigsaw module providing this package is not available in 
JDK 11. The suggestion is to use a dependency.

Wondering if anybody ran into this and what a solution/workaround might be.

Thank you!
Oleg



--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: javax.annotation.PostConstruct issue when running with JDK11

[Oleg Cohen]

Thank you, JB!

In my case it is pax-web that can’t find the class, so I guess I need to add to 
ext lib. How can I add it? Should I do it at the JDK level or it is a mechanism 
in Karaf?

Thank you,
Oleg

> On Oct 1, 2018, at 11:33 AM, Jean-Baptiste Onofré  wrote:
> 
> Hi Oleg,
> 
> Correct, javax.annotation is available up to Java 10 (and even using
> Java 10, the javax.annotation package has been splitted).
> 
> When using Java 11, you have to explicitly install either jsr305 or
> javax.annotation jar files (it could be as private package of your
> bundle, or ext lib).
> 
> Regards
> JB
> 
> On 01/10/2018 17:14, Oleg Cohen wrote:
>> Greetings,
>> 
>> I am trying to run my Karaf application under JDK 11. I am getting the 
>> following exception:
>> 
>> Caused by: java.lang.ClassNotFoundException: javax.annotation.PostConstruct 
>> cannot be found by org.ops4j.pax.web.pax-web-jsp_7.2.3
>> 
>> It appears that the jigsaw module providing this package is not available in 
>> JDK 11. The suggestion is to use a dependency.
>> 
>> Wondering if anybody ran into this and what a solution/workaround might be.
>> 
>> Thank you!
>> Oleg 
>> 
> 
> -- 
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com

Re: Sudden NoFileAssignedException during karaf distro build.

[Jean-Baptiste Onofré]

Sorry, I thought you used both 3.x for Karaf and maven-install-plugin.

The maven-install-plugin 3.0.0.M1 (released couple of days ago) changed
the way to deal with project packaging. I have to change the way of
attaching the artifact by the Karaf maven plugin.

As workaround, you have to use maven-install-plugin 2.5.2 by explicitly
defining the version in your pom.xml.

Regards
JB

On 01/10/2018 17:32, Erwin Hogeweg wrote:
> Hi JB,
> 
>> ouch, that's a little bit old version of the plugin ;)
> Not sure which plugin you are talking about. As far as I can see 3.0.0-M1 is 
> the latest available maven-install-plugin.
> 
>> Anyway, you should define the Maven dependencies for this version of the 
>> plugin.
>>
>> Any change to update to Karaf 4.x at least for Maven plugin?
> I am on Karaf-4.2.0… for the karaf-maven-plugin.
> 
> Erwin
> 
> 
>>
>> Regards
>> JB
>>
>> On 01/10/2018 15:49, Erwin Hogeweg wrote:
>>> Hi -
>>>
>>> All of a sudden we are getting a maven build this error when building a
>>> karaf distribution. This started late yesterday and happens on multiple
>>> developer machines but not all. I have nuked my entire .m2 repo and
>>> rolled back to a version well before the issue started but I still get
>>> the same error.
>>>
>>> We’re kinda scratching our heads here… Has anyone an idea what is going on?
>>>
>>> [*ERROR*] Failed to execute goal
>>> org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install*(default-install)*
>>> on project my-distribution: *NoFileAssignedException*: The packaging
>>> plugin for this project did not assign a main file to the project but it
>>> has attachments. Change packaging to 'pom'. -> *[Help 1]*
>>>
>>> Karaf-4.2.0
>>> Java-1.8.0_92
>>> Maven-3.5.0
>>>
>>>
>>> Thanks,
>>>
>>> Erwin
>>>
>>
>> -- 
>> Jean-Baptiste Onofré
>> jbono...@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Sudden NoFileAssignedException during karaf distro build.

[Erwin Hogeweg]

Hi JB,

> ouch, that's a little bit old version of the plugin ;)
Not sure which plugin you are talking about. As far as I can see 3.0.0-M1 is 
the latest available maven-install-plugin.

> Anyway, you should define the Maven dependencies for this version of the 
> plugin.
> 
> Any change to update to Karaf 4.x at least for Maven plugin?
I am on Karaf-4.2.0… for the karaf-maven-plugin.

Erwin


> 
> Regards
> JB
> 
> On 01/10/2018 15:49, Erwin Hogeweg wrote:
>> Hi -
>> 
>> All of a sudden we are getting a maven build this error when building a
>> karaf distribution. This started late yesterday and happens on multiple
>> developer machines but not all. I have nuked my entire .m2 repo and
>> rolled back to a version well before the issue started but I still get
>> the same error.
>> 
>> We’re kinda scratching our heads here… Has anyone an idea what is going on?
>> 
>> [*ERROR*] Failed to execute goal
>> org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install*(default-install)*
>> on project my-distribution: *NoFileAssignedException*: The packaging
>> plugin for this project did not assign a main file to the project but it
>> has attachments. Change packaging to 'pom'. -> *[Help 1]*
>> 
>> Karaf-4.2.0
>> Java-1.8.0_92
>> Maven-3.5.0
>> 
>> 
>> Thanks,
>> 
>> Erwin
>> 
> 
> -- 
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com

Re: javax.annotation.PostConstruct issue when running with JDK11

[Jean-Baptiste Onofré]

Hi Oleg,

Correct, javax.annotation is available up to Java 10 (and even using
Java 10, the javax.annotation package has been splitted).

When using Java 11, you have to explicitly install either jsr305 or
javax.annotation jar files (it could be as private package of your
bundle, or ext lib).

Regards
JB

On 01/10/2018 17:14, Oleg Cohen wrote:
> Greetings,
> 
> I am trying to run my Karaf application under JDK 11. I am getting the 
> following exception:
> 
> Caused by: java.lang.ClassNotFoundException: javax.annotation.PostConstruct 
> cannot be found by org.ops4j.pax.web.pax-web-jsp_7.2.3
> 
> It appears that the jigsaw module providing this package is not available in 
> JDK 11. The suggestion is to use a dependency.
> 
> Wondering if anybody ran into this and what a solution/workaround might be.
> 
> Thank you!
> Oleg 
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

javax.annotation.PostConstruct issue when running with JDK11

[Oleg Cohen]

Greetings,

I am trying to run my Karaf application under JDK 11. I am getting the 
following exception:

Caused by: java.lang.ClassNotFoundException: javax.annotation.PostConstruct 
cannot be found by org.ops4j.pax.web.pax-web-jsp_7.2.3

It appears that the jigsaw module providing this package is not available in 
JDK 11. The suggestion is to use a dependency.

Wondering if anybody ran into this and what a solution/workaround might be.

Thank you!
Oleg 

Re: Sudden NoFileAssignedException during karaf distro build.

[Jean-Baptiste Onofré]

Hi Erwin,

ouch, that's a little bit old version of the plugin ;)

Anyway, you should define the Maven dependencies for this version of the
plugin.

Any change to update to Karaf 4.x at least for Maven plugin ?

Regards
JB

On 01/10/2018 15:49, Erwin Hogeweg wrote:
> Hi -
> 
> All of a sudden we are getting a maven build this error when building a
> karaf distribution. This started late yesterday and happens on multiple
> developer machines but not all. I have nuked my entire .m2 repo and
> rolled back to a version well before the issue started but I still get
> the same error.
> 
> We’re kinda scratching our heads here… Has anyone an idea what is going on?
> 
> [*ERROR*] Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install*(default-install)*
> on project my-distribution: *NoFileAssignedException*: The packaging
> plugin for this project did not assign a main file to the project but it
> has attachments. Change packaging to 'pom'. -> *[Help 1]*
> 
> Karaf-4.2.0
> Java-1.8.0_92
> Maven-3.5.0
> 
> 
> Thanks,
> 
> Erwin
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Sudden NoFileAssignedException during karaf distro build.

[Oleg Cohen]

Hi Erwin,

I ran into the same last night. I guess 3.0.0-M1 is new and has 
issues/incompatibilities with the Karaf plugin. 

The way I fixed it was to define the following in the pluginManagement in the 
pom.xml or a parent pom.xml to force versions 2.5.2 and 2.8.2 for the install 
and deploy plugins respectively:






org.apache.maven.plugins

maven-install-plugin
2.5.2



org.apache.maven.plugins

maven-deploy-plugin
2.8.2



org.apache.karaf.tooling

karaf-maven-plugin

${org.apache.karaf.version}
true





Hope this helps.

Thank you,
Oleg


> On Oct 1, 2018, at 9:49 AM, Erwin Hogeweg  wrote:
> 
> Hi -
> 
> All of a sudden we are getting a maven build this error when building a karaf 
> distribution. This started late yesterday and happens on multiple developer 
> machines but not all. I have nuked my entire .m2 repo and rolled back to a 
> version well before the issue started but I still get the same error.
> 
> We’re kinda scratching our heads here… Has anyone an idea what is going on?
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install 
> (default-install) on project my-distribution: NoFileAssignedException: The 
> packaging plugin for this project did not assign a main file to the project 
> but it has attachments. Change packaging to 'pom'. -> [Help 1]
> 
> Karaf-4.2.0
> Java-1.8.0_92
> Maven-3.5.0
> 
> 
> Thanks,
> 
> Erwin
> 

Sudden NoFileAssignedException during karaf distro build.

[Erwin Hogeweg]

Hi -

All of a sudden we are getting a maven build this error when building a karaf 
distribution. This started late yesterday and happens on multiple developer 
machines but not all. I have nuked my entire .m2 repo and rolled back to a 
version well before the issue started but I still get the same error.

We’re kinda scratching our heads here… Has anyone an idea what is going on?

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install 
(default-install) on project my-distribution: NoFileAssignedException: The 
packaging plugin for this project did not assign a main file to the project but 
it has attachments. Change packaging to 'pom'. -> [Help 1]

Karaf-4.2.0
Java-1.8.0_92
Maven-3.5.0


Thanks,

Erwin

Re: Pax JMS - ConcurrentModificationException

[Miroslav Beranič]

Hi JB,

agree, I guess I am more used to use ConcurrentHashMap than synchronized
keyword. Ok, will close PR.

Kind Regards,
Miroslav


V V pon., 1. okt. 2018 ob 11:08 je oseba Jean-Baptiste Onofré <
j...@nanthrax.net> napisala:

> Just to be clear, this fix is on Pax JDBC, but the same fix should be
> applied to Pax JMS. Synchronized is IMHO better and consistent more than
> using a ConcurrentHashMap.
>
> Regards
> JB
>
> On 01/10/2018 11:05, Jean-Baptiste Onofré wrote:
> > By the way, don't you think this commit:
> >
> >
> https://github.com/ops4j/org.ops4j.pax.jdbc/commit/6bfeccea774195316d4d2382b5235a7c4d1501e0
> >
> > already fix the issue ?
> >
> > I think the synchronized on methods are enough, so I think your PR is
> > useless with this commit.
> >
> > Regards
> > JB
> >
> > On 01/10/2018 08:51, Miroslav Beranič wrote:
> >> Hi all,
> >>
> >> I was getting ( sometimes ) ConcurrentModificationException when using
> >> PAX JMS ( 1.0.2 ). It turned out to be synchronization fail in
> >> ConnectionFactoryConfigManager. I've made a fix by replace HashMap with
> >> ConcurrentHashMap ( and removed synchronized methods ).
> >>
> >> I write here, as I think Karaf is main user base of the PAX JMS library.
> >>
> >> Any comment is welcome. Fix is located at:
> >>
> >> https://github.com/ops4j/org.ops4j.pax.jms/pull/15
> >>
> >> P.S: I've also updated the dependencies ( in my local branch, not part
> >> of the pull request ) - something to have in mind when/if doing local
> >> build ( working with Karaf 4.2.2 ).
> >>
> >> Kind Regards,
> >> Miroslav
> >>
> >>
> >>
> >> --
> >> Miroslav Beranič
> >> MIBESIS
> >> +386(0)40/814-843
> >> miroslav.bera...@mibesis.si 
> >> http://www.mibesis.si
> >
>
> --
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>


-- 
Miroslav Beranič
MIBESIS
+386(0)40/814-843
miroslav.bera...@mibesis.si
http://www.mibesis.si

Re: Pax JMS - ConcurrentModificationException

[Jean-Baptiste Onofré]

Just to be clear, this fix is on Pax JDBC, but the same fix should be
applied to Pax JMS. Synchronized is IMHO better and consistent more than
using a ConcurrentHashMap.

Regards
JB

On 01/10/2018 11:05, Jean-Baptiste Onofré wrote:
> By the way, don't you think this commit:
> 
> https://github.com/ops4j/org.ops4j.pax.jdbc/commit/6bfeccea774195316d4d2382b5235a7c4d1501e0
> 
> already fix the issue ?
> 
> I think the synchronized on methods are enough, so I think your PR is
> useless with this commit.
> 
> Regards
> JB
> 
> On 01/10/2018 08:51, Miroslav Beranič wrote:
>> Hi all,
>>
>> I was getting ( sometimes ) ConcurrentModificationException when using
>> PAX JMS ( 1.0.2 ). It turned out to be synchronization fail in
>> ConnectionFactoryConfigManager. I've made a fix by replace HashMap with
>> ConcurrentHashMap ( and removed synchronized methods ).
>>
>> I write here, as I think Karaf is main user base of the PAX JMS library.
>>
>> Any comment is welcome. Fix is located at:
>>
>> https://github.com/ops4j/org.ops4j.pax.jms/pull/15
>>
>> P.S: I've also updated the dependencies ( in my local branch, not part
>> of the pull request ) - something to have in mind when/if doing local
>> build ( working with Karaf 4.2.2 ).
>>
>> Kind Regards,
>> Miroslav
>>
>>
>>
>> -- 
>> Miroslav Beranič
>> MIBESIS
>> +386(0)40/814-843
>> miroslav.bera...@mibesis.si 
>> http://www.mibesis.si
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Pax JMS - ConcurrentModificationException

[Jean-Baptiste Onofré]

By the way, don't you think this commit:

https://github.com/ops4j/org.ops4j.pax.jdbc/commit/6bfeccea774195316d4d2382b5235a7c4d1501e0

already fix the issue ?

I think the synchronized on methods are enough, so I think your PR is
useless with this commit.

Regards
JB

On 01/10/2018 08:51, Miroslav Beranič wrote:
> Hi all,
> 
> I was getting ( sometimes ) ConcurrentModificationException when using
> PAX JMS ( 1.0.2 ). It turned out to be synchronization fail in
> ConnectionFactoryConfigManager. I've made a fix by replace HashMap with
> ConcurrentHashMap ( and removed synchronized methods ).
> 
> I write here, as I think Karaf is main user base of the PAX JMS library.
> 
> Any comment is welcome. Fix is located at:
> 
> https://github.com/ops4j/org.ops4j.pax.jms/pull/15
> 
> P.S: I've also updated the dependencies ( in my local branch, not part
> of the pull request ) - something to have in mind when/if doing local
> build ( working with Karaf 4.2.2 ).
> 
> Kind Regards,
> Miroslav
> 
> 
> 
> -- 
> Miroslav Beranič
> MIBESIS
> +386(0)40/814-843
> miroslav.bera...@mibesis.si 
> http://www.mibesis.si

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Pax JMS - ConcurrentModificationException

[Jean-Baptiste Onofré]

Hi Miroslav,

let me take a look on the Pax JMS PR (and eventually prepare a release
after the merge).

Thanks !
Regards
JB

On 01/10/2018 08:51, Miroslav Beranič wrote:
> Hi all,
> 
> I was getting ( sometimes ) ConcurrentModificationException when using
> PAX JMS ( 1.0.2 ). It turned out to be synchronization fail in
> ConnectionFactoryConfigManager. I've made a fix by replace HashMap with
> ConcurrentHashMap ( and removed synchronized methods ).
> 
> I write here, as I think Karaf is main user base of the PAX JMS library.
> 
> Any comment is welcome. Fix is located at:
> 
> https://github.com/ops4j/org.ops4j.pax.jms/pull/15
> 
> P.S: I've also updated the dependencies ( in my local branch, not part
> of the pull request ) - something to have in mind when/if doing local
> build ( working with Karaf 4.2.2 ).
> 
> Kind Regards,
> Miroslav
> 
> 
> 
> -- 
> Miroslav Beranič
> MIBESIS
> +386(0)40/814-843
> miroslav.bera...@mibesis.si 
> http://www.mibesis.si

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Pax JMS - ConcurrentModificationException

[Miroslav Beranič]

Hi all,

I was getting ( sometimes ) ConcurrentModificationException when using PAX
JMS ( 1.0.2 ). It turned out to be synchronization fail in
ConnectionFactoryConfigManager. I've made a fix by replace HashMap with
ConcurrentHashMap ( and removed synchronized methods ).

I write here, as I think Karaf is main user base of the PAX JMS library.

Any comment is welcome. Fix is located at:

https://github.com/ops4j/org.ops4j.pax.jms/pull/15

P.S: I've also updated the dependencies ( in my local branch, not part of
the pull request ) - something to have in mind when/if doing local build (
working with Karaf 4.2.2 ).

Kind Regards,
Miroslav



-- 
Miroslav Beranič
MIBESIS
+386(0)40/814-843
miroslav.bera...@mibesis.si
http://www.mibesis.si