Re: Two finger swipe left - right makes editor go wild
On Thu, 2 Nov 2023, 13:01 Neil C Smith, wrote: > > > On Thu, 2 Nov 2023, 12:28 Patrik Karlström, wrote: > >> I was not sure of what to test so I went for >> https://ci-builds.apache.org/job/Netbeans/job/netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/ >> . >> > > Ah, sorry, should have been more explicit. If you go to the test summary > page of any pull request with the dev build label you should see a build to > download under the graph. > > Eg. https://github.com/apache/netbeans/actions/runs/671145789 > Somehow missed a digit https://github.com/apache/netbeans/actions/runs/6711457896 Neil >
Re: Two finger swipe left - right makes editor go wild
On Thu, 2 Nov 2023, 12:28 Patrik Karlström, wrote: > I was not sure of what to test so I went for > https://ci-builds.apache.org/job/Netbeans/job/netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/ > . > Ah, sorry, should have been more explicit. If you go to the test summary page of any pull request with the dev build label you should see a build to download under the graph. Eg. https://github.com/apache/netbeans/actions/runs/671145789 It's only there for 7 days. As it turns out, I can't reproduce this on rc2 either now. > Curious! Still worth dropping those horizontal scroll button values for now to limit possible bad interactions I think. Best wishes, Neil
Re: Two finger swipe left - right makes editor go wild
I was not sure of what to test so I went for https://ci-builds.apache.org/job/Netbeans/job/netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/ . As it turns out, I can't reproduce this on rc2 either now. Since I wrote the first posting on this topic I got, among others, the updates below: I also updated the JDK 21 to 21.0.1 recently, but reverting that now did not change anything. I'm unable to reproduce the original problem. Not sure of what is what now. /Patrik Upgrade xorg-x11-server-Xorg-1.20.14-26.fc38.x86_64 @updates Upgraded xorg-x11-server-Xorg-1.20.14-23.fc38.x86_64 @@System Upgrade xorg-x11-server-Xwayland-22.1.9-3.fc38.x86_64 @updates Upgraded xorg-x11-server-Xwayland-22.1.9-2.fc38.x86_64 @@System Upgrade xorg-x11-server-common-1.20.14-26.fc38.x86_64 @updates Upgraded xorg-x11-server-common-1.20.14-23.fc38.x86_64 @@System Den tors 2 nov. 2023 kl 12:19 skrev Neil C Smith : > On Thu, 2 Nov 2023 at 04:37, Patrik Karlström wrote: > > I just tested the latest daily with a fresh userdir with the default > settings and it looks good to me. > > Daily?! As in daily build, your own build of delivery, or the build > from the pull request? > > I'm curious to clarify because the fix here isn't in master yet. > > Best wishes, > > Neil > > - > To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org > For additional commands, e-mail: users-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >
Re: Two finger swipe left - right makes editor go wild
On Thu, 2 Nov 2023 at 04:37, Patrik Karlström wrote: > I just tested the latest daily with a fresh userdir with the default settings > and it looks good to me. Daily?! As in daily build, your own build of delivery, or the build from the pull request? I'm curious to clarify because the fix here isn't in master yet. Best wishes, Neil - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Two finger swipe left - right makes editor go wild
I just tested the latest daily with a fresh userdir with the default settings and it looks good to me. Thanks! Den tis 31 okt. 2023 kl 15:40 skrev Neil C Smith : > On Mon, 30 Oct 2023 at 14:06, Neil C Smith wrote: > > On Mon, 30 Oct 2023 at 13:51, Laszlo Kishalmi > wrote: > > > can confirm that mouse wheel left/right is button 4/5 on my mouse on > linux (swing event numbers, which are not the button numbers i see via > piper or xev) > > > > > > I can confirm on both X11 and Wayland. Horizontal wheels, two finger > scrolls on touchpad are converted to 4/5 (left/right) buttons. Back/forward > is 6/7 (even on my TrackMan Marble, I dug up from the bottom of an old > wires box). > > > > > > Proposed patch: https://github.com/apache/netbeans/pull/6636 > > > > Thanks for taking a look and confirming those values. I've been tied > > up the last few days but had started looking at a fix. I think we > > should handle in the mouse event handler, though, before it gets to > > the utilities method. > > Had a look at fixing this in the handler - > https://github.com/apache/netbeans/pull/6644 What do you think? > > I do think we should consider if we want to map horizontal scroll in > future, but should probably be in a uniform way across OS? > > I've added ci:dev-build to this PR to aid with testing. Some testing > on Windows and macOS would be appreciated. Unfortunately I'm away > from my machines with those OS this week. > > Patrik, would also be good to get confirmation that that build doesn't > exhibit the problems you've described! > > Thanks, > > Neil >
Re: Two finger swipe left - right makes editor go wild
On Mon, 30 Oct 2023 at 14:06, Neil C Smith wrote: > On Mon, 30 Oct 2023 at 13:51, Laszlo Kishalmi > wrote: > > can confirm that mouse wheel left/right is button 4/5 on my mouse on linux > > (swing event numbers, which are not the button numbers i see via piper or > > xev) > > > > I can confirm on both X11 and Wayland. Horizontal wheels, two finger > > scrolls on touchpad are converted to 4/5 (left/right) buttons. Back/forward > > is 6/7 (even on my TrackMan Marble, I dug up from the bottom of an old > > wires box). > > > > Proposed patch: https://github.com/apache/netbeans/pull/6636 > > Thanks for taking a look and confirming those values. I've been tied > up the last few days but had started looking at a fix. I think we > should handle in the mouse event handler, though, before it gets to > the utilities method. Had a look at fixing this in the handler - https://github.com/apache/netbeans/pull/6644 What do you think? I do think we should consider if we want to map horizontal scroll in future, but should probably be in a uniform way across OS? I've added ci:dev-build to this PR to aid with testing. Some testing on Windows and macOS would be appreciated. Unfortunately I'm away from my machines with those OS this week. Patrik, would also be good to get confirmation that that build doesn't exhibit the problems you've described! Thanks, Neil - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Two finger swipe left - right makes editor go wild
Hi, On Mon, 30 Oct 2023 at 13:51, Laszlo Kishalmi wrote: > can confirm that mouse wheel left/right is button 4/5 on my mouse on linux > (swing event numbers, which are not the button numbers i see via piper or xev) > > I can confirm on both X11 and Wayland. Horizontal wheels, two finger scrolls > on touchpad are converted to 4/5 (left/right) buttons. Back/forward is 6/7 > (even on my TrackMan Marble, I dug up from the bottom of an old wires box). > > Proposed patch: https://github.com/apache/netbeans/pull/6636 Thanks for taking a look and confirming those values. I've been tied up the last few days but had started looking at a fix. I think we should handle in the mouse event handler, though, before it gets to the utilities method. Best wishes, Neil - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Two finger swipe left - right makes editor go wild
On 10/28/23 12:44, Michael Bien wrote: On 28.10.23 14:09, Laszlo Kishalmi wrote: On 10/28/23 04:52, Neil C Smith wrote: On Sat, 28 Oct 2023, 12:29 Neil C Smith, wrote: On Sat, 28 Oct 2023, 11:59 Laszlo Kishalmi, wrote: It would be good if somebody could test the Mouse Button layouts on Windows and Mac, probably can remove the MOUSE_BUTTON4 and MOUSE_BUTTON5 registration... They weren't added by accident! ;-) I have all 3 OS to hand, and tested this on all 3. As far as I could tell, buttons 4 & 5 are required for Mac and Windows. Linux is the odd one out here, unfortunately. Personally, my Wayland laptop trackpad doesn't show this issue. We don't have an option to have disabled mappings. If the reports are more than a one off issue, then the only option is really to remove all the default mouse button mappings for NB20 and let people configure them if they want. But it's not very discoverable, and leaves the original feature request still unfulfilled. PS. Also, if you look at this comment you'll notice that Michael and I had a conversation on the PR about xev values and the JDK numbers being two lower because of scroll wheel events https://github.com/apache/netbeans/pull/6434#issuecomment-1715252021 If we are 100% sure that 4&5 (native 6&7) map to horizontal scroll, we could drop the value down another two in the event handler to bring all OS in line? That what I am thinking about! I think that would be safe to do, or introduce a MOUSE_WHEEL_LEFT and MOUSE_WHEEL_RIGHT for those buttons and map the rest with two down on Linux. can confirm that mouse wheel left/right is button 4/5 on my mouse on linux (swing event numbers, which are not the button numbers i see via piper or xev) I can confirm on both X11 and Wayland. Horizontal wheels, two finger scrolls on touchpad are converted to 4/5 (left/right) buttons. Back/forward is 6/7 (even on my TrackMan Marble, I dug up from the bottom of an old wires box). Proposed patch: https://github.com/apache/netbeans/pull/6636 back/forward is 6/7 (Thumb button would be 8 and a second set of forward/back is 9/10 but most mice with a lot of buttons will probably map those by default to a hardware or system function, e.g mouse resolution switch or volume control etc - thats when the "standardization" ends most likely) have nothing to swipe unfortunately so I can't help there :) -mbien Best wishes, Neil
Re: Two finger swipe left - right makes editor go wild
On 28.10.23 14:09, Laszlo Kishalmi wrote: On 10/28/23 04:52, Neil C Smith wrote: On Sat, 28 Oct 2023, 12:29 Neil C Smith, wrote: On Sat, 28 Oct 2023, 11:59 Laszlo Kishalmi, wrote: It would be good if somebody could test the Mouse Button layouts on Windows and Mac, probably can remove the MOUSE_BUTTON4 and MOUSE_BUTTON5 registration... They weren't added by accident! ;-) I have all 3 OS to hand, and tested this on all 3. As far as I could tell, buttons 4 & 5 are required for Mac and Windows. Linux is the odd one out here, unfortunately. Personally, my Wayland laptop trackpad doesn't show this issue. We don't have an option to have disabled mappings. If the reports are more than a one off issue, then the only option is really to remove all the default mouse button mappings for NB20 and let people configure them if they want. But it's not very discoverable, and leaves the original feature request still unfulfilled. PS. Also, if you look at this comment you'll notice that Michael and I had a conversation on the PR about xev values and the JDK numbers being two lower because of scroll wheel events https://github.com/apache/netbeans/pull/6434#issuecomment-1715252021 If we are 100% sure that 4&5 (native 6&7) map to horizontal scroll, we could drop the value down another two in the event handler to bring all OS in line? That what I am thinking about! I think that would be safe to do, or introduce a MOUSE_WHEEL_LEFT and MOUSE_WHEEL_RIGHT for those buttons and map the rest with two down on Linux. can confirm that mouse wheel left/right is button 4/5 on my mouse on linux (swing event numbers, which are not the button numbers i see via piper or xev) back/forward is 6/7 (Thumb button would be 8 and a second set of forward/back is 9/10 but most mice with a lot of buttons will probably map those by default to a hardware or system function, e.g mouse resolution switch or volume control etc - thats when the "standardization" ends most likely) have nothing to swipe unfortunately so I can't help there :) -mbien Best wishes, Neil
Re: Two finger swipe left - right makes editor go wild
On 10/28/23 04:52, Neil C Smith wrote: On Sat, 28 Oct 2023, 12:29 Neil C Smith, wrote: On Sat, 28 Oct 2023, 11:59 Laszlo Kishalmi, wrote: It would be good if somebody could test the Mouse Button layouts on Windows and Mac, probably can remove the MOUSE_BUTTON4 and MOUSE_BUTTON5 registration... They weren't added by accident! ;-) I have all 3 OS to hand, and tested this on all 3. As far as I could tell, buttons 4 & 5 are required for Mac and Windows. Linux is the odd one out here, unfortunately. Personally, my Wayland laptop trackpad doesn't show this issue. We don't have an option to have disabled mappings. If the reports are more than a one off issue, then the only option is really to remove all the default mouse button mappings for NB20 and let people configure them if they want. But it's not very discoverable, and leaves the original feature request still unfulfilled. PS. Also, if you look at this comment you'll notice that Michael and I had a conversation on the PR about xev values and the JDK numbers being two lower because of scroll wheel events https://github.com/apache/netbeans/pull/6434#issuecomment-1715252021 If we are 100% sure that 4&5 (native 6&7) map to horizontal scroll, we could drop the value down another two in the event handler to bring all OS in line? That what I am thinking about! I think that would be safe to do, or introduce a MOUSE_WHEEL_LEFT and MOUSE_WHEEL_RIGHT for those buttons and map the rest with two down on Linux. Best wishes, Neil
Re: Two finger swipe left - right makes editor go wild
On Sat, 28 Oct 2023, 12:29 Neil C Smith, wrote: > > > On Sat, 28 Oct 2023, 11:59 Laszlo Kishalmi, > wrote: > >> It would be good if somebody could test the Mouse Button layouts on >> Windows and Mac, probably can remove the MOUSE_BUTTON4 and MOUSE_BUTTON5 >> registration... >> > > They weren't added by accident! ;-) > > I have all 3 OS to hand, and tested this on all 3. As far as I could tell, > buttons 4 & 5 are required for Mac and Windows. Linux is the odd one out > here, unfortunately. > > Personally, my Wayland laptop trackpad doesn't show this issue. We don't > have an option to have disabled mappings. If the reports are more than a > one off issue, then the only option is really to remove all the default > mouse button mappings for NB20 and let people configure them if they want. > But it's not very discoverable, and leaves the original feature request > still unfulfilled. > PS. Also, if you look at this comment you'll notice that Michael and I had a conversation on the PR about xev values and the JDK numbers being two lower because of scroll wheel events https://github.com/apache/netbeans/pull/6434#issuecomment-1715252021 If we are 100% sure that 4&5 (native 6&7) map to horizontal scroll, we could drop the value down another two in the event handler to bring all OS in line? Best wishes, Neil
Re: Two finger swipe left - right makes editor go wild
On Sat, 28 Oct 2023, 11:59 Laszlo Kishalmi, wrote: > It would be good if somebody could test the Mouse Button layouts on > Windows and Mac, probably can remove the MOUSE_BUTTON4 and MOUSE_BUTTON5 > registration... > They weren't added by accident! ;-) I have all 3 OS to hand, and tested this on all 3. As far as I could tell, buttons 4 & 5 are required for Mac and Windows. Linux is the odd one out here, unfortunately. Personally, my Wayland laptop trackpad doesn't show this issue. We don't have an option to have disabled mappings. If the reports are more than a one off issue, then the only option is really to remove all the default mouse button mappings for NB20 and let people configure them if they want. But it's not very discoverable, and leaves the original feature request still unfulfilled. Best wishes, Neil
Re: Two finger swipe left - right makes editor go wild
It seems MOUSE_BUTTON4 and MOUSE_BUTTON5 events are sent on horizontal wheel movement on Linux. Remove the registration of those and keeping MOUSE_BUTTON6 and MOUSE_BUTTON7 which is assigned for back and forth buttons does the trick. Tested with Wayland and X11. and with Touchpad, MX Mouse 3S and MX Master 3 It would be good if somebody could test the Mouse Button layouts on Windows and Mac, probably can remove the MOUSE_BUTTON4 and MOUSE_BUTTON5 registration... On 10/28/23 03:03, Laszlo Kishalmi wrote: Well, it seems to be something with the wheel rotation. Horizontal two finger swipe is sent as horizontal scroll by default. Previously that was not working in the IDE. Now I've tested, the touchpad gesture, I can confirm, that it goes back and forth through the editor caret history. So as the MX Master, which has a horizontal scroll wheel. Also on that mouse the back and forth buttons works as should now. On 10/28/23 01:34, Neil C Smith wrote: On Sat, 28 Oct 2023 at 06:34, Patrik Karlström wrote: I'm not sure if this is related to the OS, Fedora in my case or if it's a netbeans thing. Using the touchpad to scroll up and down also invokes a trigger happy two finger swipe left and/or right and the result is that the editor might switch tabs or jump between "editor points" within the current file. Is this behaviour possible to disable on the netbeans side? I'm assuming this is with a NB20 release candidate? This is likely some fallout from https://github.com/apache/netbeans/pull/6434 This registers mouse buttons as alternative shortcuts for the back and forward code history actions. You can search for the back and forward actions in Options / Keymap and remove the mouse button shortcuts. I know it's a little odd to have mouse buttons in the keymap, but we were already using this for mouse wheel actions. Is your touchpad normally that trigger happy in other applications? What about browsers? Is this on Wayland out of interest? Best wishes, Neil - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Two finger swipe left - right makes editor go wild
Thanks, I was able to disable it, perhaps it should be opt-in instead. Yes, it's 20-rc2 on wayland. I'm really happy with the OS gestures in general and two finger left right in firefox takes a bit of "force" in order to go back and forth. Den lör 28 okt. 2023 kl 10:36 skrev Neil C Smith : > On Sat, 28 Oct 2023 at 06:34, Patrik Karlström wrote: > > > > I'm not sure if this is related to the OS, Fedora in my case or if it's > a netbeans thing. > > > > Using the touchpad to scroll up and down also invokes a trigger happy > two finger swipe left and/or right and the result is that the editor might > switch tabs or jump between "editor points" within the current file. > > > > Is this behaviour possible to disable on the netbeans side? > > I'm assuming this is with a NB20 release candidate? > > This is likely some fallout from > https://github.com/apache/netbeans/pull/6434 This registers mouse > buttons as alternative shortcuts for the back and forward code history > actions. > > You can search for the back and forward actions in Options / Keymap > and remove the mouse button shortcuts. I know it's a little odd to > have mouse buttons in the keymap, but we were already using this for > mouse wheel actions. > > Is your touchpad normally that trigger happy in other applications? > What about browsers? > > Is this on Wayland out of interest? > > Best wishes, > > Neil >
Re: Two finger swipe left - right makes editor go wild
Well, it seems to be something with the wheel rotation. Horizontal two finger swipe is sent as horizontal scroll by default. Previously that was not working in the IDE. Now I've tested, the touchpad gesture, I can confirm, that it goes back and forth through the editor caret history. So as the MX Master, which has a horizontal scroll wheel. Also on that mouse the back and forth buttons works as should now. On 10/28/23 01:34, Neil C Smith wrote: On Sat, 28 Oct 2023 at 06:34, Patrik Karlström wrote: I'm not sure if this is related to the OS, Fedora in my case or if it's a netbeans thing. Using the touchpad to scroll up and down also invokes a trigger happy two finger swipe left and/or right and the result is that the editor might switch tabs or jump between "editor points" within the current file. Is this behaviour possible to disable on the netbeans side? I'm assuming this is with a NB20 release candidate? This is likely some fallout from https://github.com/apache/netbeans/pull/6434 This registers mouse buttons as alternative shortcuts for the back and forward code history actions. You can search for the back and forward actions in Options / Keymap and remove the mouse button shortcuts. I know it's a little odd to have mouse buttons in the keymap, but we were already using this for mouse wheel actions. Is your touchpad normally that trigger happy in other applications? What about browsers? Is this on Wayland out of interest? Best wishes, Neil - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Two finger swipe left - right makes editor go wild
On Sat, 28 Oct 2023 at 06:34, Patrik Karlström wrote: > > I'm not sure if this is related to the OS, Fedora in my case or if it's a > netbeans thing. > > Using the touchpad to scroll up and down also invokes a trigger happy two > finger swipe left and/or right and the result is that the editor might switch > tabs or jump between "editor points" within the current file. > > Is this behaviour possible to disable on the netbeans side? I'm assuming this is with a NB20 release candidate? This is likely some fallout from https://github.com/apache/netbeans/pull/6434 This registers mouse buttons as alternative shortcuts for the back and forward code history actions. You can search for the back and forward actions in Options / Keymap and remove the mouse button shortcuts. I know it's a little odd to have mouse buttons in the keymap, but we were already using this for mouse wheel actions. Is your touchpad normally that trigger happy in other applications? What about browsers? Is this on Wayland out of interest? Best wishes, Neil - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Two finger swipe left - right makes editor go wild
I'm not sure if this is related to the OS, Fedora in my case or if it's a netbeans thing. Using the touchpad to scroll up and down also invokes a trigger happy two finger swipe left and/or right and the result is that the editor might switch tabs or jump between "editor points" within the current file. Is this behaviour possible to disable on the netbeans side? /Patrik
