Re: excludeFrom vs visible & includeInLayout
Alex, created PR.
Thanks,
Serkan
17.10.2019 10:55 tarihinde Serkan Taş yazdı:
Hi Alex, as soon as i am available, i am going to work on the subect.
Thanks
Serkan
Android için Outlook <https://aka.ms/ghei36>'u edinin
On Wed, Oct 16, 2019 at 9:33 AM +0300, "Alex Harui" <mailto:aha...@adobe.com>> wrote:
Hi Serkan,
I looked at this sample. The problem appears to be that the
header appears at the bottom. In debugging the code, I noticed
that the StatesWithTransitionsImpl is not in sync with the
SimpleStatesImpl. Yishay added support for position==”first” to
SimpleStatesImpl but apparently forgot to add it to
StatesWithTransitionsImpl.
I’m at the end of my workday, so maybe you or some other volunteer
can make that change and see if it solves your problem.
HTH,
-Alex
*From: *Serkan Taş
*Reply-To: *"users@royale.apache.org"
*Date: *Monday, October 14, 2019 at 12:36 AM
*To: *"users@royale.apache.org"
*Subject: *Re: excludeFrom vs visible & includeInLayout
Hi Alex,
Sometime it is really difficult to create test cases but for the
actual case, I created a sample application.
Basically, there is a button to toggle the header and footer
components show/hide with setting the state. You can see the
strange behavior.
Also there are commented parts that do the same thing with visible
& includeInLayout rather than state change, which is working as
expected.
Here is the js-debug output :
https://drive.google.com/open?id=1oF7OIXuGTfLvqM8mtWGSaKiT8C6lQhb5
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrive.google.com%2Fopen%3Fid%3D1oF7OIXuGTfLvqM8mtWGSaKiT8C6lQhb5=02%7C01%7Caharui%40adobe.com%7C6e66f925a80049c5f4cd08d750792e7a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637066353713277208=ZjRbnDD%2BWtpFY6HTBDaPAPHnCQJ7V6Z6RqFS2YM8vdU%3D=0>
Thanks
Serkan
13.10.2019 09:43 tarihinde Alex Harui yazdı:
We want to understand why excludeFrom is not working. If you
can create a simple test case, that would be great, otherwise
let’s try to debug a public version. Instead of paying for
hosting, if you can create a version that doesn’t require
server-side processing, then you can just upload the
HTML/JS/CSS files to DropBox or some other account.
HTH,
-Alex
*From: *Serkan Taş
<mailto:serkan@likyateknoloji.com>
*Reply-To: *"users@royale.apache.org"
<mailto:users@royale.apache.org>
<mailto:users@royale.apache.org>
*Date: *Saturday, October 12, 2019 at 6:43 AM
*To: *"users@royale.apache.org"
<mailto:users@royale.apache.org>
<mailto:users@royale.apache.org>
*Subject: *excludeFrom vs visible & includeInLayout
Hi Herbs,
As you mentioned before, after updating the latest sources
from github my actual problem is clearly related with the
state concept, especially excludeFrom.
According to your advises I tried using visible &
includeInLayout,
eg. :
It did not work because when using excludeFrom the component
is not created until the state is changed. But with the second
option the component is created, and due to architecture of my
application flow,
throws exceptions related with created components that
shouldn't be.
I have 2 options :
1. Reconstruct my whole application as the excludeFrom will
never work
2. Try to find out why excludeFrom is not working
Which why should I go through ?
Thanks.
Re: excludeFrom vs visible & includeInLayout
Hi Alex, as soon as i am available, i am going to work on the subect. Thanks Serkan Android için Outlook'u edinin On Wed, Oct 16, 2019 at 9:33 AM +0300, "Alex Harui" wrote: Hi Serkan, I looked at this sample. The problem appears to be that the header appears at the bottom. In debugging the code, I noticed that the StatesWithTransitionsImpl is not in sync with the SimpleStatesImpl. Yishay added support for position==”first” to SimpleStatesImpl but apparently forgot to add it to StatesWithTransitionsImpl. I’m at the end of my workday, so maybe you or some other volunteer can make that change and see if it solves your problem. HTH, -Alex From: Serkan Taş Reply-To: "users@royale.apache.org" Date: Monday, October 14, 2019 at 12:36 AM To: "users@royale.apache.org" Subject: Re: excludeFrom vs visible & includeInLayout Hi Alex, Sometime it is really difficult to create test cases but for the actual case, I created a sample application. Basically, there is a button to toggle the header and footer components show/hide with setting the state. You can see the strange behavior. Also there are commented parts that do the same thing with visible & includeInLayout rather than state change, which is working as expected. Here is the js-debug output : https://drive.google.com/open?id=1oF7OIXuGTfLvqM8mtWGSaKiT8C6lQhb5 Thanks Serkan 13.10.2019 09:43 tarihinde Alex Harui yazdı: We want to understand why excludeFrom is not working. If you can create a simple test case, that would be great, otherwise let’s try to debug a public version. Instead of paying for hosting, if you can create a version that doesn’t require server-side processing, then you can just upload the HTML/JS/CSS files to DropBox or some other account. HTH, -Alex From: Serkan Taş Reply-To: "users@royale.apache.org" Date: Saturday, October 12, 2019 at 6:43 AM To: "users@royale.apache.org" Subject: excludeFrom vs visible & includeInLayout Hi Herbs, As you mentioned before, after updating the latest sources from github my actual problem is clearly related with the state concept, especially excludeFrom. According to your advises I tried using visible & includeInLayout, eg. : It did not work because when using excludeFrom the component is not created until the state is changed. But with the second option the component is created, and due to architecture of my application flow, throws exceptions related with created components that shouldn't be. I have 2 options : 1. Reconstruct my whole application as the excludeFrom will never work 2. Try to find out why excludeFrom is not working Which why should I go through ? Thanks.
Re: excludeFrom vs visible & includeInLayout
Hi Serkan, I looked at this sample. The problem appears to be that the header appears at the bottom. In debugging the code, I noticed that the StatesWithTransitionsImpl is not in sync with the SimpleStatesImpl. Yishay added support for position==”first” to SimpleStatesImpl but apparently forgot to add it to StatesWithTransitionsImpl. I’m at the end of my workday, so maybe you or some other volunteer can make that change and see if it solves your problem. HTH, -Alex From: Serkan Taş Reply-To: "users@royale.apache.org" Date: Monday, October 14, 2019 at 12:36 AM To: "users@royale.apache.org" Subject: Re: excludeFrom vs visible & includeInLayout Hi Alex, Sometime it is really difficult to create test cases but for the actual case, I created a sample application. Basically, there is a button to toggle the header and footer components show/hide with setting the state. You can see the strange behavior. Also there are commented parts that do the same thing with visible & includeInLayout rather than state change, which is working as expected. Here is the js-debug output : https://drive.google.com/open?id=1oF7OIXuGTfLvqM8mtWGSaKiT8C6lQhb5<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrive.google.com%2Fopen%3Fid%3D1oF7OIXuGTfLvqM8mtWGSaKiT8C6lQhb5=02%7C01%7Caharui%40adobe.com%7C6e66f925a80049c5f4cd08d750792e7a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637066353713277208=ZjRbnDD%2BWtpFY6HTBDaPAPHnCQJ7V6Z6RqFS2YM8vdU%3D=0> Thanks Serkan 13.10.2019 09:43 tarihinde Alex Harui yazdı: We want to understand why excludeFrom is not working. If you can create a simple test case, that would be great, otherwise let’s try to debug a public version. Instead of paying for hosting, if you can create a version that doesn’t require server-side processing, then you can just upload the HTML/JS/CSS files to DropBox or some other account. HTH, -Alex From: Serkan Taş <mailto:serkan@likyateknoloji.com> Reply-To: "users@royale.apache.org"<mailto:users@royale.apache.org> <mailto:users@royale.apache.org> Date: Saturday, October 12, 2019 at 6:43 AM To: "users@royale.apache.org"<mailto:users@royale.apache.org> <mailto:users@royale.apache.org> Subject: excludeFrom vs visible & includeInLayout Hi Herbs, As you mentioned before, after updating the latest sources from github my actual problem is clearly related with the state concept, especially excludeFrom. According to your advises I tried using visible & includeInLayout, eg. : It did not work because when using excludeFrom the component is not created until the state is changed. But with the second option the component is created, and due to architecture of my application flow, throws exceptions related with created components that shouldn't be. I have 2 options : 1. Reconstruct my whole application as the excludeFrom will never work 2. Try to find out why excludeFrom is not working Which why should I go through ? Thanks.
Re: excludeFrom vs visible & includeInLayout
Hi Alex, Sometime it is really difficult to create test cases but for the actual case, I created a sample application. Basically, there is a button to toggle the header and footer components show/hide with setting the state. You can see the strange behavior. Also there are commented parts that do the same thing with visible & includeInLayout rather than state change, which is working as expected. Here is the js-debug output : https://drive.google.com/open?id=1oF7OIXuGTfLvqM8mtWGSaKiT8C6lQhb5 Thanks Serkan 13.10.2019 09:43 tarihinde Alex Harui yazdı: We want to understand why excludeFrom is not working. If you can create a simple test case, that would be great, otherwise let’s try to debug a public version. Instead of paying for hosting, if you can create a version that doesn’t require server-side processing, then you can just upload the HTML/JS/CSS files to DropBox or some other account. HTH, -Alex *From: *Serkan Taş *Reply-To: *"users@royale.apache.org" *Date: *Saturday, October 12, 2019 at 6:43 AM *To: *"users@royale.apache.org" *Subject: *excludeFrom vs visible & includeInLayout Hi Herbs, As you mentioned before, after updating the latest sources from github my actual problem is clearly related with the state concept, especially excludeFrom. According to your advises I tried using visible & includeInLayout, eg. : includeInLayout="false" > It did not work because when using excludeFrom the component is not created until the state is changed. But with the second option the component is created, and due to architecture of my application flow, throws exceptions related with created components that shouldn't be. I have 2 options : 1. Reconstruct my whole application as the excludeFrom will never work 2. Try to find out why excludeFrom is not working Which why should I go through ? Thanks.
Re: excludeFrom vs visible & includeInLayout
We want to understand why excludeFrom is not working. If you can create a simple test case, that would be great, otherwise let’s try to debug a public version. Instead of paying for hosting, if you can create a version that doesn’t require server-side processing, then you can just upload the HTML/JS/CSS files to DropBox or some other account. HTH, -Alex From: Serkan Taş Reply-To: "users@royale.apache.org" Date: Saturday, October 12, 2019 at 6:43 AM To: "users@royale.apache.org" Subject: excludeFrom vs visible & includeInLayout Hi Herbs, As you mentioned before, after updating the latest sources from github my actual problem is clearly related with the state concept, especially excludeFrom. According to your advises I tried using visible & includeInLayout, eg. : It did not work because when using excludeFrom the component is not created until the state is changed. But with the second option the component is created, and due to architecture of my application flow, throws exceptions related with created components that shouldn't be. I have 2 options : 1. Reconstruct my whole application as the excludeFrom will never work 2. Try to find out why excludeFrom is not working Which why should I go through ? Thanks.
excludeFrom vs visible & includeInLayout
Hi Herbs, As you mentioned before, after updating the latest sources from github my actual problem is clearly related with the state concept, especially excludeFrom. According to your advises I tried using visible & includeInLayout, eg. : includeInLayout="false" > It did not work because when using excludeFrom the component is not created until the state is changed. But with the second option the component is created, and due to architecture of my application flow, throws exceptions related with created components that shouldn't be. I have 2 options : 1. Reconstruct my whole application as the excludeFrom will never work 2. Try to find out why excludeFrom is not working Which why should I go through ? Thanks.
