Change in vdsm[master]: Fix py_modules in setup.py, and duplicate declaration of cpo...
Timothy Asir has posted comments on this change. Change subject: Fix py_modules in setup.py, and duplicate declaration of cpopen.so in spec .. Patch Set 2: Looks good to me, but someone else must approve I have verified this patch and found that, this fixes the following warnings/errors during rpm build (make rpm) --build-temp /home/timothy/current_woking_vdsm/gerrit_vdsm/feb9x2012/vdsm/lib/cpopen --build-lib /home/timothy/current_woking_vdsm/gerrit_vdsm/feb9x2012/vdsm/lib/cpopen) file cpopen.py (for module cpopen) not found file cpopen.py (for module cpopen) not found ... warning: File listed twice: /usr/lib64/python2.7/site-packages/cpopen/cpopen.so -- To view, visit http://gerrit.ovirt.org/14915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I253adf740d31aec59e19136d07e3221ee7b2823d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...
Mark Wu has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba8958549a301c9faac70a32cbafdf320128c85a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reduce the redundant parameters for addVlan()
Mark Wu has posted comments on this change. Change subject: Reduce the redundant parameters for addVlan() .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d94145d833a109929f4d537b83bf0758dc43b91 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
Mark Wu has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 3: Verified Verified for bridged network and bridgeless network -- To view, visit http://gerrit.ovirt.org/14880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1586/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2488/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2488/ (3/3) -- To view, visit http://gerrit.ovirt.org/14880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2419/ (1/3) -- To view, visit http://gerrit.ovirt.org/14880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1586/ (2/3) -- To view, visit http://gerrit.ovirt.org/14880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
Mark Wu has posted comments on this change.
Change subject: Separate adding libvirt network from configuring host network.
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
File vdsm/netconf/ifcfg.py
Line 109: ifup(nic.name, bootproto == 'dhcp' and
Line 110: not utils.tobool(opts.get('blockingdhcp')))
Line 111:
Line 112: def configureLibvirtNetwork(self, network, bridged, iface):
Line 113: self.configWriter.createLibvirtNetwork(network, True, iface)
should use 'bridged' instead of 'True'.
My fault. I apologize for it!
Line 114: self._libvirtAdded.add(network)
Line 115:
Line 116: def configureBonding(self, bond, nics, bridge=None, mtu=None,
Line 117: bondingOptions=None):
--
To view, visit http://gerrit.ovirt.org/14880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: Reduce ConfigWriter addVlan args.
Mark Wu has abandoned this change. Change subject: NetReload: Reduce ConfigWriter addVlan args. .. Patch Set 4: Abandoned Replaced by http://gerrit.ovirt.org/#/c/14881/ -- To view, visit http://gerrit.ovirt.org/11358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5ee6243ec67e6fa0d070d608f59886dc39cc80b1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a new class NetworkParams to represent the pramaters of ...
Mark Wu has abandoned this change. Change subject: Add a new class NetworkParams to represent the pramaters of a network .. Patch Set 1: Abandoned The NetReloaded patches cover this change -- To view, visit http://gerrit.ovirt.org/11359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7df2db451298b5e0c1dfbbf1cf09f69e0e9a9ea5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only assign layer 3 parameters to topmost interface
Mark Wu has abandoned this change. Change subject: Only assign layer 3 parameters to topmost interface .. Patch Set 2: Abandoned This idea is already included in the NetReloaded patches. -- To view, visit http://gerrit.ovirt.org/11355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3d430879cdfcc74ff133ac03ead74305fa3baf06 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
Mark Wu has abandoned this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 1: Abandoned Replaced by another patch: http://gerrit.ovirt.org/#/c/14880/ -- To view, visit http://gerrit.ovirt.org/14305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie974e17538ed92cbf8d3d23d8c23f276cf3b3bc3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: netmodels for delNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2413/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1579/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2487/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: netmodels for delNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for delNetwork .. Patch Set 2: No score Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2487/ (3/3) -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Mark Wu has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Daniel, could you please answer the question I asked before: Which kernel has the support of the flag unpriv_sgio, which the 'unfiltered' function relys on? Thanks! -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: netmodels for addNetwork
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 7: (6 inline comments)
File vdsm/configNetwork.py
Line 47: MAX_BRIDGE_NAME_LEN = 15
Line 48: ILLEGAL_BRIDGE_CHARS = frozenset(':. \t')
Line 49:
Line 50:
Line 51: def objectivizeNetwork(bridge=None, vlan=None, bonding=None,
This method takes a few arguments that describe a network and makes an object
oriented representation out of it. It does not create a network and I am not a
fan of unnecessary long names like "makeObjectOrientedNetworkRepresentation".
Good point about the docstring.
Line 52:bondingOptions=None, nics=None, mtu=None,
ipaddr=None,
Line 53:netmask=None, gateway=None, bootproto=None,
Line 54:_netinfo=None, configurator=None, **opts):
Line 55: if configurator is None:
Line 76: if bridge:
Line 77: topObj = Bridge(bridge, configurator, ports=[topObj] if topObj
else [],
Line 78: mtu=mtu, stp=opts.get('stp'),
Line 79: forwardDelay=opts.get('forward_delay', 0))
Line 80: topObj.ip = IpConfig(inet=IPv4(ipaddr, netmask, gateway),
AFAIK This code can't be reached by calls from vdsClient nor the engine without
a topObj being set. I could raise a BAD_PARAMS error I guess...
Line 81: bootproto=bootproto)
Line 82: return topObj
Line 83:
Line 84:
Line 81: bootproto=bootproto)
Line 82: return topObj
Line 83:
Line 84:
Line 85: def _validateInterNetworkCompatibility(ni, vlan, iface, bridged):
I'd leave this for a follow-up patch.
Line 86: """
Line 87: Verify network compatibility with other networks on iface
(bond/nic).
Line 88:
Line 89: Only following combinations allowed:
Line 175: if bonding not in vlanedIfaces:
Line 176: for nic in nics:
Line 177: if nic not in vlanedIfaces:
Line 178: ifdown(nic)
Line 179: netEnt.configure(network=network, **options)
I'm afraid I don't understand this. Would you please rephrase?
Line 180:
Line 181:
Line 182: def assertBridgeClean(bridge, vlan, bonding, nics):
Line 183: ports = set(netinfo.ports(bridge))
File vdsm/netmodels.py
Line 27: from vdsm import netinfo
Line 28: import neterrors as ne
Line 29:
Line 30:
Line 31: class NetDevice(object):
Done
Line 32: def __init__(self, name, configurator, ipconfig=None, mtu=None):
Line 33: self.name = name
Line 34: self.ip = ipconfig
Line 35: self.mtu = mtu
Line 114: '''This class represents traditional kernel bridges.'''
Line 115: MAX_BRIDGE_NAME_LEN = 15
Line 116: ILLEGAL_BRIDGE_CHARS = frozenset(':. \t')
Line 117:
Line 118: def __init__(self, name, configurator, ipconfig=None, mtu=None,
ports=(),
You are right that we don't do it at the moment and there are no plans to do
it. Thus, this premature extensibility point (it was here for netinfo) will be
dropped.
Line 119: forwardDelay=0, stp=None):
Line 120: self.validateName(name)
Line 121: self.ports = ports
Line 122: self.forwardDelay = forwardDelay
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 11: I would prefer that you didn't submit this
(7 inline comments)
mostly minor comments. I like the spirit.
File vdsm/sudoers.vdsm.in
Line 2: @DMIDECODE_PATH@, \
Line 3: @VDSMDIR@/mk_sysprep_floppy, \
Line 4: @SERVICE_PATH@ ksmtuned *, \
Line 5: @SERVICE_PATH@ ksm *, \
Line 6: @SERVICE_PATH@ vdsmd *, \
why have you moved this? I think that it is still used only by the storage
subsystem.
Line 7: @VDSMDIR@/prepare-vmchannel
Line 8: Cmnd_Alias VDSM_STORAGE = @MOUNT_PATH@, @UMOUNT_PATH@, \
Line 9: @FSCK_PATH@ -p *, \
Line 10: @TUNE2FS_PATH@ -j *, \
File vdsm/supervdsmd.service
Line 1: [Unit]
Line 2: Description=Super Vdsm Service
maybe a less dramatic and more informative description would be better:
"Auxiliary Vdsm service for running helper functions as the super user"
or something like that.
Line 3:
Line 4: [Service]
Line 5: Type=simple
Line 6: ExecStart=/usr/share/vdsm/supervdsmServer.py /var/run/vdsm/svdsm.sock
Line 2: Description=Super Vdsm Service
Line 3:
Line 4: [Service]
Line 5: Type=simple
Line 6: ExecStart=/usr/share/vdsm/supervdsmServer.py /var/run/vdsm/svdsm.sock
use @PYTHON@ to avoid ovirt-node surprises; use @VDSMRUNDIR@ to be nice to
Ubuntu.
File vdsm/supervdsm.py
Line 75: self._log.warn("Connect to svdsm failed %s", ex)
Line 76: raise
Line 77: self._svdsm = self._manager.instance()
Line 78:
Line 79: def _launch(self):
we no longer launch supervdsm here, so this is a misnomer.
Line 80: try:
Line 81: utils.retry(self._connect, Exception, timeout=60, tries=3)
Line 82: except:
Line 83: utils.panic("Couldn't connect to supervdsm service")
Line 115
Line 116
Line 117
Line 118
Line 119
I love the smell of code burning!
File vdsm/supervdsmServer.py
Line 1: #!/usr/bin/python
why was this added? not that you still cannot just execute this script, since
ovirt-node blacklists all *.py. Keep using
python supervdsmServer.pyc
please.
Line 2: #
Line 3: # Copyright 2011 Red Hat, Inc.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
File vdsm/vdsmd.service
Line 1: [Unit]
Line 2: Description=Virtual Desktop Server Manager
Line 3: Requires=multipathd.service libvirtd.service time-sync.target
iscsid.service supervdsmd.service
do you know if this line can be broken?
Line 4: Conflicts=libvirt-guests.service ksmtuned.service
Line 5:
Line 6: [Service]
Line 7: Type=forking
--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Mei Liu
Gerrit-Reviewer: Ohad Basan
Gerrit-Reviewer: Royce Lv
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 9: (1 inline comment)
File vdsm/clientIF.py
Line 364: try:
Line 365: out = alignmentScan.scanImage(volPath)
Line 366: except alignmentScan.VirtAlignError as e:
Line 367: self.log.warning("Error in virt-alignment-scan: %s", e)
Line 368: return errCode['unexpected']
thanks for agreeing to return an error. However, I see no point in having an
"except" clause at all: you would have exactly the same semantics if you simply
have
try:
out = alignmentScan.scanImage(volPath)
for line in out:
aligning[line.partitionName] = line.alignmentScanResult
finally:
bla
Line 369: else:
Line 370: for line in out:
Line 371: aligning[line.partitionName] =
line.alignmentScanResult
Line 372: finally:
--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2418/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1585/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2486/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2418/ (3/3) -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2486/ (2/3) -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1585/ (1/3) -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
Arik Hadas has uploaded a new change for review.
Change subject: RAM snapshots feature
..
RAM snapshots feature
This patch adds the ability to take live snapshot of a VM that includes
its memory state, and to restore memory state that is saved as part of a
snapshot when reverting back to it.
There is a detailed description of the design at the feature page:
http://wiki.ovirt.org/Features/RAM_Snapshots
Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c
Signed-off-by: Arik Hadas
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/libvirtvm.py
3 files changed, 76 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/15072/1
diff --git a/vdsm/API.py b/vdsm/API.py
index ee72116..509addd 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -632,11 +632,15 @@
self.log.info('network %s: using %s', network, ip)
return ip
-def snapshot(self, snapDrives):
+def snapshot(self, snapDrives, snapMemory):
v = self._cif.vmContainer.get(self._UUID)
if not v:
return errCode['noVM']
-return v.snapshot(snapDrives)
+memoryParams = {}
+if snapMemory:
+memoryParams['dst'], memoryParams['dstparams'] = \
+self._getHibernationPaths(snapMemory)
+return v.snapshot(snapDrives, memoryParams)
def merge(self, mergeDrives):
v = self._cif.vmContainer.get(self._UUID)
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 9a4db12..9f9de19 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -280,9 +280,9 @@
vm = API.VM(vmId)
return vm.vmUpdateDevice(params)
-def vmSnapshot(self, vmId, snapDrives):
+def vmSnapshot(self, vmId, snapDrives, snapMemory=''):
vm = API.VM(vmId)
-return vm.snapshot(snapDrives)
+return vm.snapshot(snapDrives, snapMemory)
def vmMerge(self, vmId, mergeDrives):
vm = API.VM(vmId)
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 14bd92e..8d30a9c 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -26,6 +26,8 @@
from xml.dom.minidom import parseString as _domParseStr
import time
import threading
+import pickle
+import re
import vm
from vdsm.define import ERROR, doneCode, errCode
@@ -1554,11 +1556,18 @@
# Reinitialize the merge statuses
self._checkMerge()
elif 'restoreState' in self.conf:
-hooks.before_vm_dehibernate(self.conf.pop('_srcDomXML'), self.conf)
+restoreFromSnapshot = self.conf.pop('restoreFromSnapshot', False)
+srcDomXML = self.conf.pop('_srcDomXML')
+if not restoreFromSnapshot:
+hooks.before_vm_dehibernate(srcDomXML, self.conf)
fname = self.cif.prepareVolumePath(self.conf['restoreState'])
try:
-self._connection.restore(fname)
+if restoreFromSnapshot:
+srcDomXML = self._correctDiskVolumes(srcDomXML)
+self._connection.restoreFlags(fname, srcDomXML)
+else:
+self._connection.restore(fname)
finally:
self.cif.teardownVolumePath(self.conf['restoreState'])
@@ -1585,6 +1594,22 @@
self.setDownStatus(ERROR, 'failed to start libvirt vm')
return
self._domDependentInit()
+
+def _correctDiskVolumes(self, srcDomXML):
+"""
+Update each image in the given XML to point to the right volume.
+Each image should have a newer volume than the one that was the
+newer when the snapshot was taken, since we create new volume
+for each image on 'preview' operation.
+"""
+for vmDrive in self._devices[vm.DISK_DEVICES]:
+if vmDrive.device == 'disk':
+pathToImageDir = os.path.dirname(vmDrive.path)
+pattern = '(' + pathToImageDir + '.*)\''
+mo = re.search(pattern, srcDomXML)
+if mo:
+srcDomXML = srcDomXML.replace(mo.group(1), vmDrive.path)
+return srcDomXML
def hotplugNic(self, params):
if self.isMigrating():
@@ -2078,7 +2103,7 @@
self.saveState()
-def snapshot(self, snapDrives):
+def snapshot(self, snapDrives, memoryParams):
"""Live snapshot command"""
def _diskSnapshot(vmDev, newPath):
@@ -2121,6 +2146,21 @@
except:
self.log.error("Unable to teardown drive: %s", vmDevName,
exc_info=True)
+
+def _memorySnapshot(memoryVolumePath):
+"""Libvirt snapshot XML"""
+
+memory = xml.dom.minidom.Element('memory')
+memory.setAttribute('snapshot', 'external')
+memory.setAttribute('file', memoryVolumePath)
+return memory
+
+def _vmConfForSnapshot():
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm.tool.service to cover alternative service names
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Please split to 2 patches, one that adds the alternative names and one that
adds the initctlNative and sysvNative decorators.
File lib/vdsm/tool/service.py
Line 57: "/usr/sbin/update-rc.d",
Line 58: )
Line 59:
Line 60: _srvNameAlts = {
Line 61: 'iscsid': ['iscsid', 'open-iscsi'],
tuples ?
Line 62: 'libvirtd': ['libvirtd', 'libvirt-bin'],
Line 63: 'multipathd': ['multipathd', 'multipath-tools'],
Line 64: 'network': ['network', 'networking'],
Line 65: }
--
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2417/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1584/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2485/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 9: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2485/ (3/3) -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 9: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2417/ (2/3) -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 9: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1584/ (1/3) -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1583/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2484/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 11: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1583/ (3/3) -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 11: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2416/ (2/3) -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 11: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2484/ (1/3) -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2415/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1582/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2483/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 10: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1582/ (3/3) -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 10: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2483/ (2/3) -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 10: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2415/ (1/3) -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm-tool commands - retrieving host uuid by utils.ge...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Extend vdsm-tool commands - retrieving host uuid by utils.getHostUUID .. Extend vdsm-tool commands - retrieving host uuid by utils.getHostUUID Deploying an host requires to verify if an host has vdsm installed. The command 'vdsm-tool vdsm-id' returns vdsm uuid if vdsm is installed. It doesn't require running vdsm instance. This patch also adds 'legacy' parameter to getHostUUID for backward compatibility, if set to false the mac address won't be added to the uuid. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=964967 Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8 Signed-off-by: Yaniv Bronhaim --- M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/vdsm-id.py M lib/vdsm/utils.py M vdsm.spec.in 4 files changed, 53 insertions(+), 12 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
Dan Kenigsberg has posted comments on this change. Change subject: Supervdsm as external service .. Patch Set 9: (2 inline comments) File vdsm/supervdsmd.init.in Line 1: #! /bin/sh Line 2: # Line 3: # Copyright 2006-2010 Red Hat, Inc. and/or its affiliates. 2013 Line 4: # Line 5: # Licensed to you under the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 7: # (at your option) any later version. See the files README and Line 11: # chkconfig: 2345 99 00 Line 12: # Line 13: ### BEGIN INIT INFO Line 14: # Provides: supervdsmd Line 15: # Required-Start: $syslog $network $vdsmd vdsmd should require supervdsm, not vice versa. Line 16: # Should-Start: $time $vdsmd Line 17: # Required-Stop: $syslog $vdsmd Line 18: # Default-Start: 2 3 4 5 Line 19: # Default-Stop: 0 1 6 -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mei Liu Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Separate adding libvirt network from configuring host networ...
Giuseppe Vallarelli has posted comments on this change. Change subject: Separate adding libvirt network from configuring host network. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Supervdsm as external service
Dan Kenigsberg has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (1 inline comment)
File vdsm/supervdsmd.init.in
Line 39:
Line 40: start(){
Line 41:test_already_running && return 0
Line 42:
Line 43:LC_ALL=C @VDSMDIR@/respawn --minlifetime 10 --daemon
--masterpid $RESPAWNPIDFILE $SUPERVDSM_BIN $AUTH_KEY $SOCKFILE $VDSM_USER
no tabs, and no using of bash's "$" without quotes, please.
Line 44:RETVAL=$?
Line 45:[ "$RETVAL" -eq 0 ] && log_success_msg "$prog start" ||
log_failure_msg "$prog start"
Line 46: }
Line 47:
--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Mei Liu
Gerrit-Reviewer: Ohad Basan
Gerrit-Reviewer: Royce Lv
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain: use the dd statistics for the domain delay
Giuseppe Vallarelli has posted comments on this change.
Change subject: domain: use the dd statistics for the domain delay
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
See comment related to test.
File tests/miscTests.py
Line 891: ("1572864", "s", "1.5", "M", "1.5", "1", "M"),
Line 892: ("1610612736", "s", "1.5", "G", "1000.5", "1.53", "M"),
Line 893: )
Line 894:
Line 895: def checkReadSpeedRegExp(self):
I guess you should prefix with test if you want this method to be considered as
test.
Line 896: for stats in self.STATS_TESTS:
Line 897: m = misc._readspeed_regex.match(self.STATS_TEMPLATE %
stats)
Line 898: self.assertNotEqual(m, None)
Line 899:
File vdsm/storage/misc.py
Line 210: def readfile(name, buffersize=None):
Line 211: """
Line 212: Read the content of the file using /bin/dd command
Line 213: """
Line 214: rc, out, err = _readfile(name, buffersize)
Minor comment, you can use _ to mark unused vars.
Line 215: return out
Line 216:
Line 217:
Line 218: _readspeed_regex = re.compile(
--
To view, visit http://gerrit.ovirt.org/15049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fa54dbbe3475b74bcfe5cbc0c60895818f8b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: netmodels for addNetwork
Giuseppe Vallarelli has posted comments on this change. Change subject: NetReload: netmodels for addNetwork .. Patch Set 7: No score (1 inline comment) File vdsm/configNetwork.py Line 175: if bonding not in vlanedIfaces: Line 176: for nic in nics: Line 177: if nic not in vlanedIfaces: Line 178: ifdown(nic) Line 179: netEnt.configure(network=network, **options) What about a general Network model with 2 methods, addNetDevice and configure which call configure on the list of netDevices created by adding them with addNetDevice ? In this way you can also move the configure methods to the respective entities. Line 180: Line 181: Line 182: def assertBridgeClean(bridge, vlan, bonding, nics): Line 183: ports = set(netinfo.ports(bridge)) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: netmodels for addNetwork
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
See comments specific comments.
File vdsm/configNetwork.py
Line 47: MAX_BRIDGE_NAME_LEN = 15
Line 48: ILLEGAL_BRIDGE_CHARS = frozenset(':. \t')
Line 49:
Line 50:
Line 51: def objectivizeNetwork(bridge=None, vlan=None, bonding=None,
Instead of objectivizeSomething can you change it to buildSomething or
createSomething (same applies to the different models). Adding a docstring
would be cool and responsible, you should explain what the object returned
represents, if I remember correctly is this a configuration that a user wants
to apply? In this case also createNetwork is still a generic name which doesn't
convey the real meaning.
Line 52:bondingOptions=None, nics=None, mtu=None,
ipaddr=None,
Line 53:netmask=None, gateway=None, bootproto=None,
Line 54:_netinfo=None, configurator=None, **opts):
Line 55: if configurator is None:
Line 76: if bridge:
Line 77: topObj = Bridge(bridge, configurator, ports=[topObj] if topObj
else [],
Line 78: mtu=mtu, stp=opts.get('stp'),
Line 79: forwardDelay=opts.get('forward_delay', 0))
Line 80: topObj.ip = IpConfig(inet=IPv4(ipaddr, netmask, gateway),
topObj can still be None, if a user of this function doesn't specifiy bonding,
nics, etc.. Can you add also a test ?
Line 81: bootproto=bootproto)
Line 82: return topObj
Line 83:
Line 84:
File vdsm/netmodels.py
Line 27: from vdsm import netinfo
Line 28: import neterrors as ne
Line 29:
Line 30:
Line 31: class NetDevice(object):
I think you should move in NetDevice the configure method (not implemented) so
you make clear that every subclass of NetDevice should implement a configure
method.
Line 32: def __init__(self, name, configurator, ipconfig=None, mtu=None):
Line 33: self.name = name
Line 34: self.ip = ipconfig
Line 35: self.mtu = mtu
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add after_vdsm_start hook
Allon Mureinik has posted comments on this change. Change subject: vdsm: Add after_vdsm_start hook .. Patch Set 1: I would prefer that you didn't submit this giving -1 just to get off my radar. Vered, perhaps it would be a good idea to abandon this patch until said deliberations are over? -- To view, visit http://gerrit.ovirt.org/13543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id02b2b7d091ffa0be57a3850fa97cdcd35778466 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Allon Mureinik has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) File vdsm/libvirtvm.py Line 1165: driverAttrs['io'] = 'threads' Line 1166: if self.format == 'cow': Line 1167: driverAttrs['type'] = 'qcow2' Line 1168: elif self.format: Line 1169: driverAttrs['type'] = 'raw' you're now allowing a lun device to have a cow format. perhaps you should validate against it? Line 1170: Line 1171: driverAttrs['cache'] = self.cache Line 1172: Line 1173: if (self.propagateErrors == 'on' or -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add "service-reload" command to vdsm-tool service module
Yaniv Bronhaim has posted comments on this change. Change subject: Add "service-reload" command to vdsm-tool service module .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97d818fc1bec005f0a2470525080dfcec43d5aa4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm-tool commands - retrieving host uuid by utils.ge...
Yaniv Bronhaim has posted comments on this change. Change subject: Extend vdsm-tool commands - retrieving host uuid by utils.getHostUUID .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/14866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks
Yaniv Bronhaim has posted comments on this change. Change subject: gluster: Added verbs for read, update, add and remove hooks .. Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) File vdsm/gluster/hooks.py Line 261: if errno.ENOENT != e.errno: Line 262: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename) Line 263: raise ge.GlusterHookRemoveFailedException(err=[errMsg]) Line 264: try: Line 265: os.remove(disabledFile) If you live with letting the user fix fs errors after running Remove command, its fine.. I just hope the users know that. Maybe you should add this info to the errMsg .. Line 266: except OSError: Line 267: if errno.ENOENT != e.errno: Line 268: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename) -- To view, visit http://gerrit.ovirt.org/14145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
