Change in vdsm[master]: [WIP] hooks: Add OVS support to Quantum vNIC hook
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] hooks: Add OVS support to Quantum vNIC hook .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2807/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1995/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2881/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mike Kolesnik Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] hooks: Add OpenStack Network vNIC hook
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] hooks: Add OpenStack Network vNIC hook .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2806/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1994/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2880/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I744b83d9c6027bd817e5d4171a77a005611b9818 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Mike Kolesnik Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] hooks: Add OVS support to Quantum vNIC hook
Mike Kolesnik has posted comments on this change.
Change subject: [WIP] hooks: Add OVS support to Quantum vNIC hook
..
Patch Set 1: (3 inline comments)
File vdsm_hooks/quantumvnic/before_vm_start.py
Line 11:
Line 12: QVNIC_PREFIX = 'quantumvnic_'
Line 13:
Line 14: # The maximum device name length in linux.
Line 15: DEV_MAX_LENGTH = 14
Yes this value conforms to the Quantum code.
Line 16:
Line 17: '''
Line 18: Openstack Quantum Hook
Line 19: ==
Line 41: source.setAttribute('bridge', DUMMY_BRIDGE)
Line 42:
Line 43:
Line 44: def configureOvsVnic(domxml, iface, portId):
Line 45: INTEGRATION_BRIDGE = config.get('quantumvnic_hook',
'integration_bridge')
Replaced in newer version
Line 46: source = iface.getElementsByTagName('source')[0]
Line 47: source.setAttribute('bridge', INTEGRATION_BRIDGE)
Line 48:
Line 49: virtualPort = domxml.createElement('virtualport')
Line 56:
Line 57: def addQuantumVnics(domxml, mac, portId):
Line 58: mac = mac.lower()
Line 59: for iface in domxml.getElementsByTagName('interface'):
Line 60: domMac = iface.getElementsByTagName('mac')[0]
Replaced in newer version
Line 61: domMacAddr = domMac.getAttribute('address').lower()
Line 62:
Line 63: if domMacAddr == mac:
Line 64: if config.get('quantumvnic_hook', 'plugin').lower() ==
"ovs":
--
To view, visit http://gerrit.ovirt.org/15410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Mike Kolesnik
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: constants: unify the BLANK_UUID definition
humble devassy has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9260d74ae1da1382394a375843b2edff112e6f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: humble devassy Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add code coverage support
Dan Kenigsberg has posted comments on this change. Change subject: Add code coverage support .. Patch Set 9: Looks good to me, but someone else must approve (I'd like to verify this with systemd, too.) -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lukas Bednar Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: constants: unify the BLANK_UUID definition
Douglas Schilling Landgraf has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9260d74ae1da1382394a375843b2edff112e6f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...
Giuseppe Vallarelli has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 3: (4 inline comments) Dan, it's not a big deal for me to use minidom but I feel that's not a good choice that's why I didn't use it in the first place. File vdsm_api/vdsmapi-schema.json Line 168: # @onboot:#optional Start the network device automatically during boot Line 169: # Line 170: # @remove:#optional If True, remove existing network only Line 171: # Line 172: # @qosInbound:#optional VmInterfaceDeviceBandwidthParams for incoming traffic. I'm fine with BandwidthParams, so it's decided ;-) Line 173: # Line 174: # @qosOutbound: #optional VmInterfaceDeviceBandwidthParams for outgoing traffic. Line 175: # Line 176: # Since: 4.10.0 File vdsm/netconf/ifcfg.py Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: from xml.sax.saxutils import escape Line 21: from xml.etree.ElementTree import Element as XmlElement, tostring I didn't use minidom because I think that the usage of ElementTree API makes the code more readable, also is a widely accepted API. I know the importance of having a consistent codebase, but I consider the usage of minidom a questionable choice, I would much be in favor of refactoring and using ElementTree instead of baking up our own classes see XMLElement in vm module to cover minidom shortcomings. The best choice would be to use lxml (http://lxml.de/) - which is the most full featured and fast python library for dealing with xml but that require a team discussion, it implements the same API ElementTree. What do you think ? p.s. this is a classic Duty call http://xkcd.com/386/ Line 22: import glob Line 23: import libvirt Line 24: import logging Line 25: import os Line 245: net = conn.networkDefineXML(netXml) Line 246: net.create() Line 247: net.setAutostart(1) Line 248: Line 249: def createNetXml(self, netName, network, bridged, iface, I didn't prefix _ simply because I'm treating it as a public interface method being called from the test module, but I don't mind updating the name if you feel that's important. Line 250: qosInbound=None, qosOutbound=None): Line 251: """ Line 252: Creates Network Xml e.g.: Line 253: Line 598: onboot='yes', **kwargs): Line 599: """ Create ifcfg-* file with proper fields for VLAN """ Line 600: conf = 'VLAN=yes\n' Line 601: if bridge: Line 602: conf += 'BRIDGE=%s\n' % pipes.quote(bridge) ops Line 603: self._createConfFile(conf, vlan, ipaddr, netmask, gateway, Line 604: bootproto, mtu, onboot, **kwargs) Line 605: Line 606: def addBonding(self, bonding, bridge=None, bondingOptions=None, mtu=None, -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP vm payload: cloud-init - multiple files, custom volume l...
Dan Kenigsberg has posted comments on this change.
Change subject: WIP vm payload: cloud-init - multiple files, custom volume label
..
Patch Set 1: I would prefer that you didn't submit this
(8 inline comments)
File tests/mkimageTests.py
Line 123: """
Line 124: checkSudo(["mount", "-o", "loop", "somefile", "target"])
Line 125: checkSudo(["umount", "target"])
Line 126: iso_img = mkimage.mkIsoFs("vmId_iso", self.files, None)
Line 127: # TODO add test for label, same in test_mkFloppyFs above
Any reason not to do it now, by passing a simple string instead of None? Or
even both, with the help of testrunner.permutations().
Line 128: self.assertTrue(os.path.exists(iso_img))
Line 129: m = storage.mount.Mount(iso_img, self.workdir)
Line 130: m.mount(mntOpts='loop')
Line 131: try:
File vdsm/clientIF.py
Line 307: except AttributeError:
Line 308: raise vm.VolumeError("Unsupported 'device': %s in
"
Line 309: "drive: %" %
(drive['device'], drive))
Line 310: else:
Line 311: # the only reason for adding these variables is
that
I'd rather drop this comment than maintain it. It's not completely exact (PEP8
won't mind if it's taken into a helper function).
Line 312: # you can not write this without breaking PEP8
Line 313: file_list =
drive['specParams']['vmPayload']['file']
Line 314: volId =
drive['specParams']['vmPayload'].get('volId', None)
Line 315: volPath = mkFsFunction(vmId, file_list, volId)
Line 309: "drive: %" %
(drive['device'], drive))
Line 310: else:
Line 311: # the only reason for adding these variables is
that
Line 312: # you can not write this without breaking PEP8
Line 313: file_list =
drive['specParams']['vmPayload']['file']
"files" is a better name for a dictionary...
Line 314: volId =
drive['specParams']['vmPayload'].get('volId', None)
Line 315: volPath = mkFsFunction(vmId, file_list, volId)
Line 316:
Line 317: elif "path" in drive:
Line 310: else:
Line 311: # the only reason for adding these variables is
that
Line 312: # you can not write this without breaking PEP8
Line 313: file_list =
drive['specParams']['vmPayload']['file']
Line 314: volId =
drive['specParams']['vmPayload'].get('volId', None)
No need to specify None, as it is the default of dict.get().
Line 315: volPath = mkFsFunction(vmId, file_list, volId)
Line 316:
Line 317: elif "path" in drive:
Line 318: volPath = drive['path']
File vdsm/mkimage.py
Line 50: filename = os.path.join(parentdir, name)
Line 51: dirname = os.path.dirname(filename)
Line 52: if not os.path.exists(dirname):
Line 53: try:
Line 54: os.makedirs(dirname)
The two users of this function are supposed to have the directory created
already. It is not clear why this is needed. If it's a bug fix, please dedicate
a separate patch with its own commit message to it.
Line 55: except OSError as e:
Line 56: if e.errno != os.errno.EEXIST:
Line 57: raise
Line 58: with file(filename, 'w') as f:
Line 80: path = os.path.join(_P_PAYLOAD_IMAGES, "%s.%s.img" % (vmId, md5))
Line 81: return path
Line 82:
Line 83:
Line 84: def mkFloppyFs(vmId, files, volId):
In this level, it's better to follow mkfs.msdos naming, and call it volumeName.
Also, it's nice to make it an optional arg with
volumeName=None
Line 85: floppy = dirname = None
Line 86: try:
Line 87: floppy = _getFileName(vmId, files)
Line 88: if volId:
Line 87: floppy = _getFileName(vmId, files)
Line 88: if volId:
Line 89: command = [EXT_MKFS_MSDOS, '-C', floppy, '1440', '-n',
volId]
Line 90: else:
Line 91: command = [EXT_MKFS_MSDOS, '-C', floppy, '1440']
having
if volumeName is not None:
command.extend([-n, volumeName])
would avoid copy-and-paste.
Line 92: rc, out, err = storage.misc.execCmd(command, raw=True)
Line 93: if rc:
Line 94: raise OSError(errno.EIO, "could not create floppy file: "
Line 95: "code %s, out %s\nerr %s" % (rc, out, err))
Line 116:
Line 117: if volId:
Line 118: command = [EXT_MKISOFS, '-r', '-o', isopath, '-V', volId,
dirname]
L
Change in vdsm[master]: Storage Domain V3 Functional Tests
Federico Simoncelli has posted comments on this change. Change subject: Storage Domain V3 Functional Tests .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) If it's not too hard let's try to keep testing V1 as well. File tests/functional/xmlrpcTests.py Line 274: r['status']['code'], se.StorageDomainDoesNotExist.code) Line 275: Line 276: r = self.s.createStorageDomain( Line 277: storage.sd.name2type(domain['type']), sdid, domain['name'], Line 278: specificArg, storage.sd.name2class(domain['class']), 3) I think this should be a permutation. After all we're still using V1 for ISO/Export domains, we might want to keep testing them too. Line 279: self.assertVdsOK(r) Line 280: undo = lambda sdid=sdid: \ Line 281: self.assertVdsOK(self.s.formatStorageDomain(sdid, True)) Line 282: rollback.prependDefer(undo) -- To view, visit http://gerrit.ovirt.org/14829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9d918b5ef68eaf75c328a1368d1b8d5198f023 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...
Dan Kenigsberg has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 3: I would prefer that you didn't submit this (4 inline comments) Thanks for your fixes and answers. BTW you are in a race condition with http://gerrit.ovirt.org/#/c/15178/ . File vdsm_api/vdsmapi-schema.json Line 168: # @onboot:#optional Start the network device automatically during boot Line 169: # Line 170: # @remove:#optional If True, remove existing network only Line 171: # Line 172: # @qosInbound:#optional VmInterfaceDeviceBandwidthParams for incoming traffic. I understand that it affects the formerly-defined usage of VmInterfaceDeviceBandwidthParams, but no one in the universe has used it yet. Your current usage for it does not fit the name - so I think that a simple BandwidthParams is better. Maybe others have better ideas. Line 173: # Line 174: # @qosOutbound: #optional VmInterfaceDeviceBandwidthParams for outgoing traffic. Line 175: # Line 176: # Since: 4.10.0 File vdsm/netconf/ifcfg.py Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: from xml.sax.saxutils import escape Line 21: from xml.etree.ElementTree import Element as XmlElement, tostring Would you agree to use xml.dom.minidom instead? That's what we do extensively in vm.py, and I hate to link with another library in parallel. (yes, I know that we already have this unfortunate dependency in vdsm-gluster; I have a vague memory of Bala promising to pull it away) I'm not even sure if simple string-mangling is not enough in this case, but that's probably a matter of taste. Line 22: import glob Line 23: import libvirt Line 24: import logging Line 25: import os Line 245: net = conn.networkDefineXML(netXml) Line 246: net.create() Line 247: net.setAutostart(1) Line 248: Line 249: def createNetXml(self, netName, network, bridged, iface, I think that createNetXml should be declared _private as it is just a helper of createLibvirtNetwork. Line 250: qosInbound=None, qosOutbound=None): Line 251: """ Line 252: Creates Network Xml e.g.: Line 253: Line 598: onboot='yes', **kwargs): Line 599: """ Create ifcfg-* file with proper fields for VLAN """ Line 600: conf = 'VLAN=yes\n' Line 601: if bridge: Line 602: conf += 'BRIDGE=%s\n' % pipes.quote(bridge) unrelated deletion. Line 603: self._createConfFile(conf, vlan, ipaddr, netmask, gateway, Line 604: bootproto, mtu, onboot, **kwargs) Line 605: Line 606: def addBonding(self, bonding, bridge=None, bondingOptions=None, mtu=None, -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...
Dan Kenigsberg has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 1: (1 inline comment) File tests/netconfTests.py Line 146: %s Line 147: Line 148: Line 149: """ % (netName, iface)) Line 150: actualDoc = self.cw.createNetXml(netName, None, False, iface) oh, sorry for confusing your new createNetXml with the older createLibvirtNetwork. Line 151: Line 152: self.assertEqualXml(expectedDoc, actualDoc) Line 153: Line 154: def testCreateNetXmlBridgedQos(self): -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Fix param name in vdsmapi-schema: naming issue. Data type for inbound and outbound params should be VmInterfaceDeviceBandwidthParams instead of VmInterfaceBandwidthParams. Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c Signed-off-by: Giuseppe Vallarelli Reviewed-on: http://gerrit.ovirt.org/15787 Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M vdsm_api/vdsmapi-schema.json 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.
Dan Kenigsberg has posted comments on this change. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.
Dan Kenigsberg has posted comments on this change. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Patch Set 1: Looks good to me, approved We should really add a unit test to catch such schema failures. -- To view, visit http://gerrit.ovirt.org/15787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the live diskSizeExtend method
Federico Simoncelli has posted comments on this change. Change subject: vm: add the live diskSizeExtend method .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) File vdsm/vm.py Line 3779: Line 3780: drive = self._findDriveByUUIDs(driveSpecs) Line 3781: Line 3782: try: Line 3783: diskFormat = "qcow2" if drive.format == "cow" else "raw" The entire flow here (lines 3783-3798) is correct only for cow. For raw we should refresh the volume (relevant for lvm) and use getVolumeInfo to feed the new size to blockResize. Also the currentSize check would be impossible (for raw). We need a way to collect the current disk size seen by qemu (surprisingly this is not possible). Line 3784: # Apparently this is what libvirt would do anyway, except that Line 3785: # it would fail on NFS when root_squash is enabled, see BZ#963881 Line 3786: currentSize = qemuImg.info(drive.path, diskFormat)['virtualsize'] Line 3787: -- To view, visit http://gerrit.ovirt.org/15614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2805/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1993/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2879/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 binary wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2804/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2878/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding functional tests for networking
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2803/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1991/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2877/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. Patch Set 2: Fails; I would prefer that you didn't submit this Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2802/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1990/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2876/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding functional tests for networking
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 20: Verified Related to the failure you've experienced ( testFailWithInvalidBondingName) I'm using a dummyIf in that test. -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2800/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1988/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2874/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Declare a broken test as such
oVirt Jenkins CI Server has posted comments on this change. Change subject: Declare a broken test as such .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2801/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2875/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3829d080b0a614ceecd570b193d7deb9ac6059ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Declare a broken test as such
Dan Kenigsberg has uploaded a new change for review.
Change subject: Declare a broken test as such
..
Declare a broken test as such
jsonRpcTests.JsonRpcServerTests.testMethodCallArgList tends to fail when
run on Jenkins, such as in
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2864
Change-Id: I3829d080b0a614ceecd570b193d7deb9ac6059ae
Signed-off-by: Dan Kenigsberg
---
M tests/jsonRpcTests.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/15803/1
diff --git a/tests/jsonRpcTests.py b/tests/jsonRpcTests.py
index 31ade58..80b8fb9 100644
--- a/tests/jsonRpcTests.py
+++ b/tests/jsonRpcTests.py
@@ -142,6 +142,8 @@
@expandPermutations
class JsonRpcServerTests(TestCaseBase):
+@brokentest('we sometime see this fail with '
+'"error: [Errno 9] Bad file descriptor"')
@permutations(REACTOR_TYPE_PERMUTATIONS)
def testMethodCallArgList(self, reactorType):
data = dummyTextGenerator(1024)
--
To view, visit http://gerrit.ovirt.org/15803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3829d080b0a614ceecd570b193d7deb9ac6059ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs for managing services
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2799/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2873/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Add balloon_min to VM.getVmBalloonInfo
Martin Sivák has uploaded a new change for review.
Change subject: [WIP] Add balloon_min to VM.getVmBalloonInfo
..
[WIP] Add balloon_min to VM.getVmBalloonInfo
The balloon_min key will take it's value from memGuaranteedSize
attribute. It's default value will be 0, but can be overriden by
whoever is creating the VM instance or setting the attributes.
This functionality is needed for basic memory QoS.
Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340
Signed-off-by: Martin Sivak
---
M vdsm/vm.py
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/15799/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index e8118a3..e131179 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -863,6 +863,11 @@
smp
+
+
+0
+
+
"""
@@ -883,6 +888,15 @@
self.dom.appendChildWithArgs('memory', text=memSizeKB)
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
self.dom.appendChildWithArgs('vcpu', text=self.conf['smp'])
+
+metadata = XMLElement('metadata')
+self.dom.appendChild(metadata)
+
+ovirt = XMLElement('ovirt')
+metadata.appendChild(ovirt)
+
+memSizeGuaranteedKB = str(int(self.conf.get('memGuaranteedSize', '0'))
* 1024)
+ovirt.appendChildWithArgs('guaranteedmemory', text=memSizeGuaranteedKB)
self._devices = XMLElement('devices')
self.dom.appendChild(self._devices)
@@ -4033,8 +4047,10 @@
if dev['type'] == BALLOON_DEVICES and \
dev['specParams']['model'] != 'none':
max_mem = int(self.conf.get('memSize')) * 1024
+min_mem = int(self.conf.get('memGuaranteedSize', '0')) * 1024
cur_mem = dev.get('target', max_mem)
-return {'balloon_max': max_mem, 'balloon_cur': cur_mem}
+return {'balloon_max': max_mem, 'balloon_cur': cur_mem,
+'balloon_min': min_mem}
return {}
def setBalloonTarget(self, target):
--
To view, visit http://gerrit.ovirt.org/15799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs for managing services
Aravinda VK has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 21: Verified Rebased since all dependent patches got merged. -- To view, visit http://gerrit.ovirt.org/11094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: extend service module to cover alternative service names .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: extend service module to cover alternative service names .. vdsm-tool: extend service module to cover alternative service names Service names are different on various systems, instead of hard-coded service names for each supported system, we can extend vdsm.tool.service to detect the right service name given some hints (possible alternative names). This makes the service management more flexible and helps to port us to new systems easily. This patch iterates over the alternative service names list for each management operation. Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Signed-off-by: Zhou Zheng Sheng Reviewed-on: http://gerrit.ovirt.org/14720 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/service.py 1 file changed, 23 insertions(+), 14 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: add the BLOCK_SIZE constant
Maor Lipchuk has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant .. Patch Set 2: Looks good to me, but someone else must approve I think it could a great start for externalizing the block size to the engine, since right now, the engine always counts that the block size is 512 when validating free space on VM and templates creation, although it is the VDSM implementation. -- To view, visit http://gerrit.ovirt.org/14589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia517ec858fb0d7ee45323b7e2a3584c0858222f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: constants: unify the BLANK_UUID definition
Maor Lipchuk has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9260d74ae1da1382394a375843b2edff112e6f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2798/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2872/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add code coverage support
Lukas Bednar has posted comments on this change. Change subject: Add code coverage support .. Patch Set 9: Verified generated rpms on rhel. installed vdsm cat /etc/sysconfig/vdsm export COVERAGE_PROCESS_START=/etc/vdsm/coveragerc cat /etc/vdsm/coveragerc [run] branch = True data_file = /var/lib/vdsm/coverageresults ls -la /var/lib/vdsm/coverageresults -rw-r--r--. 1 vdsm kvm 153013 Jun 17 12:42 /var/lib/vdsm/coverageresults -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lukas Bednar Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix param name in vdsmapi-schema: naming issue. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2796/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2870/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Qos feature: Adds bandwidth definition at configuration leve...
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 1: (7 inline comments)
File tests/netconfTests.py
Line 76: Compare two xml artifacts for equality.
Line 77: """
Line 78: contents_a = ElementTree.tostring(ElementTree.fromstring(a))
Line 79: contents_b = ElementTree.tostring(ElementTree.fromstring(b))
Line 80: return contents_a == contents_b
I agree thanks for the feedback.
Line 81:
Line 82: def setUp(self):
Line 83: self.cw = ifcfg.ConfigWriter()
Line 84:
Line 79: contents_b = ElementTree.tostring(ElementTree.fromstring(b))
Line 80: return contents_a == contents_b
Line 81:
Line 82: def setUp(self):
Line 83: self.cw = ifcfg.ConfigWriter()
Done
Line 84:
Line 85: @MonkeyPatch(subprocess, 'Popen', lambda x: None)
Line 86: def testAtomicRestore(self):
Line 87: self._createFiles()
Line 138: actualDoc = self.cw.createNetXml(netName, network, True, None)
Line 139:
Line 140: self.assertEqualXml(expectedDoc, actualDoc)
Line 141:
Line 142: def testCreateNetXml(self):
Yes he/she can. There's no need to monkey-patch is just a plain and simple
function which generates the xml string and does nothing more.
Line 143: netName = "awesome_net"
Line 144: iface = "dummy"
Line 145: expectedDoc = ("""
Line 146: %s
Line 146: %s
Line 147:
Line 148:
Line 149: """ % (netName, iface))
Line 150: actualDoc = self.cw.createNetXml(netName, None, False, iface)
There's no need for that see previous answer.
Line 151:
Line 152: self.assertEqualXml(expectedDoc, actualDoc)
Line 153:
Line 154: def testCreateNetXmlBridgedQos(self):
File vdsm_api/vdsmapi-schema.json
Line 71: ##
Line 72: {'type': 'NetworkOptions',
Line 73: 'data': {'*ipaddr': 'str', '*netmask': 'str', '*gateway': 'str',
Line 74: '*bootproto': 'str', '*delay': 'uint', '*onboot': 'str',
Line 75: '*bondingOptions', 'str', '*qosInbound':
'VmInterfaceDeviceBandwidthParams',
OK.
Line 76: '*qosOutbound': 'VmInterfaceDeviceBandwidthParams'}}
Line 77:
Line 78: ##
Line 79: # @Host.addNetwork:
Line 79: # @Host.addNetwork:
Line 80: #
Line 81: # Add a new network to this host.
Line 82: #
Line 83: # @bridge:The name of the bridge device
I may have added them due to some previous change, I'll remove it.
Line 84: #
Line 85: # @vlan: #optional The name of a VLAN to create on the device
Line 86: #
Line 87: # @bond: #optional The name of a bond device to create from
@nics
Line 167: # @onboot:#optional Start the network device automatically
during boot
Line 168: #
Line 169: # @remove:#optional If True, remove existing network only
Line 170: #
Line 171: # @qosInbound:#optional VmInterfaceDeviceBandwidthParams for
incoming traffic.
I just noticed a silly mistake that I did in one of my previous patches see fix
here: http://gerrit.ovirt.org/#/c/15787/1 .
I understand that's not the most beautiful name ever but right now I can't
think of a better name, anyway in change in the name is going to affect also
VmInterfaceDeviceSpecParams definition.
Line 172: #
Line 173: # @qosOutbound: #optional VmInterfaceDeviceBandwidthParams for
outgoing traffic.
Line 174: #
Line 175: # Since: 4.10.0
--
To view, visit http://gerrit.ovirt.org/15724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix param name in vdsmapi-schema: naming issue.
Giuseppe Vallarelli has uploaded a new change for review.
Change subject: Fix param name in vdsmapi-schema: naming issue.
..
Fix param name in vdsmapi-schema: naming issue.
Data type for inbound and outbound params should be
VmInterfaceDeviceBandwidthParams instead of
VmInterfaceBandwidthParams.
Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c
Signed-off-by: Giuseppe Vallarelli
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/15787/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index a87dc56..cf0e420 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2077,8 +2077,8 @@
# Since: 4.10.0
##
{'type': 'VmInterfaceDeviceSpecParams',
- 'data': {'*inbound': 'VmInterfaceBandwidthParams',
- '*outbound': 'VmInterfaceBandwidthParams'}}
+ 'data': {'*inbound': 'VmInterfaceDeviceBandwidthParams',
+ '*outbound': 'VmInterfaceDeviceBandwidthParams'}}
##
# @VmInterfaceDevice:
--
To view, visit http://gerrit.ovirt.org/15787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ee4da51c12d432b0ac258446db99d64f339737c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: functional test: boot VM with network interface device
Giuseppe Vallarelli has posted comments on this change.
Change subject: functional test: boot VM with network interface device
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
-1 Asking a question.
File tests/functional/xmlrpcTests.py
Line 172: @skipNoKVM
Line 173: def testStartSmallVM(self):
Line 174: pciAddress = {'slot': '0x03', 'bus': '0x00', 'domain':
'0x',
Line 175: 'function': '0x0', 'type': 'pci'}
Line 176: interfaceDev = {'nicModel': 'virtio', 'macAddr':
'52:54:00:59:F5:3F',
Zhou does this test rely on actual values, what happens if you change for
example macAddr?
Line 177: 'network': '', 'address': pciAddress,
Line 178: 'device': 'bridge', 'type': 'interface',
Line 179: 'linkActive': True, 'filter':
'no-mac-spoofing'}
Line 180: customization = {'vmId':
'----',
--
To view, visit http://gerrit.ovirt.org/15633
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c350074ce2b9712c468899075e5e2e22ee2550
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
