Change in vdsm[master]: spec: require libvirt 0.10.2-29.el6_5.4
Federico Simoncelli has posted comments on this change. Change subject: spec: require libvirt 0.10.2-29.el6_5.4 .. Patch Set 1: Verified+1 Verified: generated rpms are requiring libvirt 0.10.2-29.el6_5.4 on el6. -- To view, visit http://gerrit.ovirt.org/24392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f57c3f4ee2f5b3d27a1ddbe2faa976120f3da42 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: xmlrpc: Support HTTP 1.1
Yaniv Bronhaim has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 2: Code-Review-1 after seeing discussion after 3.4 rc release. changing the score. we'll try to continue more carefully . absolutely this change was not tested enough for stable release in this time frame . -- To view, visit http://gerrit.ovirt.org/25124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: threadLocal: Cleanup thread local storage
Yaniv Bronhaim has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 2: -Code-Review -- To view, visit http://gerrit.ovirt.org/25123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: utils: Ensure that XMLRPC threads do not delay shutdown
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: -Code-Review -- To view, visit http://gerrit.ovirt.org/25122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: utils: Ensure that XMLRPC threads do not delay shutdown
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: Code-Review+1 it looks to me as purely helpful patch. I agree for this change in ovirt-3.4 -- To view, visit http://gerrit.ovirt.org/25122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: threadLocal: Cleanup thread local storage
Yaniv Bronhaim has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 2: please get ack on this for ovirt-3.4 by federico -- To view, visit http://gerrit.ovirt.org/25123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require libvirt 0.10.2-29.el6_5.4
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: require libvirt 0.10.2-29.el6_5.4 .. spec: require libvirt 0.10.2-29.el6_5.4 A libvirt race condition caused the volume watermark to be reported as large as the physical size triggering an extension at the end of each live migration. This patch adds the requirement for the new libvirt package in order to fix the issue. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038069 Change-Id: I2f57c3f4ee2f5b3d27a1ddbe2faa976120f3da42 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24392 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f57c3f4ee2f5b3d27a1ddbe2faa976120f3da42 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_scale: Allow NetInfo update just the devices
Dan Kenigsberg has submitted this change and it was merged. Change subject: net_scale: Allow NetInfo update just the devices .. net_scale: Allow NetInfo update just the devices When deleting networks there was a lot of NetInfo instantiation due to the need for checking the devices in each delNetwork operation. That need for updated information does not include network changes, so this change adds a method for just updating the device information and reusing the netinfo objects. Bug-Url: https://bugzilla.redhat.com/1053114 Change-Id: Ia32b0333052c05c92475bddcc5e9ce805fb82c94 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/23575 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netinfo.py M vdsm/configNetwork.py 2 files changed, 48 insertions(+), 17 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia32b0333052c05c92475bddcc5e9ce805fb82c94 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove code duplication between nics, bridges, bond...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans .. Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24174/6/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 41: from .ipwrapper import Route Line 42: from .ipwrapper import routeGet Line 43: from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways Line 44: from . import libvirtconnection Line 45: from .ipwrapper import linkShowDev requires rebase on top of http://gerrit.ovirt.org/24989 Line 46: from .netconfpersistence import RunningConfig Line 47: from .netlink import iter_addrs Line 48: Line 49: -- To view, visit http://gerrit.ovirt.org/24174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_scale: Don't instantiate NetInfo needlessly
Dan Kenigsberg has posted comments on this change. Change subject: net_scale: Don't instantiate NetInfo needlessly .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23576/8/vdsm/configNetwork.py File vdsm/configNetwork.py: Line 445: raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'Cannot specify ' Line 446: 'any attribute when removing') Line 447: Line 448: currentBondings = netinfo.bondings() Line 449: currentNicsSet = set(netinfo.nics()) hey, It could be a fozenset()! but enough with that. Line 450: for bonding, bondingAttrs in bondings.iteritems(): Line 451: Bond.validateName(bonding) Line 452: if 'options' in bondingAttrs: Line 453: Bond.validateOptions(bonding, bondingAttrs['options']) -- To view, visit http://gerrit.ovirt.org/23576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I729c522396095a8114fefbc600dab00b46cea2bb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require libvirt 0.10.2-29.el6_5.4
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: require libvirt 0.10.2-29.el6_5.4 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/361/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f57c3f4ee2f5b3d27a1ddbe2faa976120f3da42 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_scale: Don't instantiate NetInfo needlessly
Dan Kenigsberg has submitted this change and it was merged. Change subject: net_scale: Don't instantiate NetInfo needlessly .. net_scale: Don't instantiate NetInfo needlessly network validation used to instantiate full-blown NetInfo objects when it just needed bondings() and nics(). This patch fixes that by calling only for the information that it needs. Bug-Url: https://bugzilla.redhat.com/1053114 Change-Id: I729c522396095a8114fefbc600dab00b46cea2bb Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/23576 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/configNetwork.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I729c522396095a8114fefbc600dab00b46cea2bb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding vdsm.conf.example to rhel build
Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line 666: # dropbox for core dumps
Line 667: install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
Line 668: %endif
Line 669:
Line 670: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
I'd prefer Federoico to remind us why we need to ship the sample within
/etc/vdsm/vdsm.conf
Line 671: %{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
Line 672:
Line 673: # Install the polkit for libvirt
Line 674: %if 0%{?fedora} = 18 || 0%{?rhel} = 7
--
To view, visit http://gerrit.ovirt.org/24945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages
Alon Bar-Lev has posted comments on this change. Change subject: Adding remove\disable verbs to vdsm-tool for admin usages .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 29: from ..constants import P_VDSM_EXEC, DISKIMAGE_GROUP, QEMU_PROCESS_GROUP, \ Line 30: VDSM_GROUP, P_VDSM_LCONF, P_VDSM_QCONF, P_VDSM_LDCONF, P_SYSTEMCTL_CONF Line 31: Line 32: Line 33: def removeSectionFromFile(filename, beginField=None, endField=None): yes I remember that, but after seeing below .. i asked for opinions ab I do not think it is that complex, and it can be improved (testing the exact lines we add instead of signature before/after). I would much like to see that shell script go away. Line 34: ( Line 35: BEFORE, Line 36: WITHIN, Line 37: AFTER, -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding vdsm.conf.example to rhel build
Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line 666: # dropbox for core dumps
Line 667: install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
Line 668: %endif
Line 669:
Line 670: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
I'd prefer Federoico to remind us why we need to ship the sample within /et
on irc, I'm told by Fedeerico and Toni that shipping /etc/vdsm/vdsm.conf is a
best parctice. Fine. But if so, it should be installed in Makefile.am, not
here specifically for rpms.
Line 671: %{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
Line 672:
Line 673: # Install the polkit for libvirt
Line 674: %if 0%{?fedora} = 18 || 0%{?rhel} = 7
--
To view, visit http://gerrit.ovirt.org/24945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding vdsm.conf.example to rhel build
Federico Simoncelli has posted comments on this change.
Change subject: Adding vdsm.conf.example to rhel build
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24945/2/vdsm.spec.in
File vdsm.spec.in:
Line 666: # dropbox for core dumps
Line 667: install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
Line 668: %endif
Line 669:
Line 670: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
on irc, I'm told by Fedeerico and Toni that shipping /etc/vdsm/vdsm.conf is
agreed, this was the workaround to get it shipped only in fedora
Line 671: %{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
Line 672:
Line 673: # Install the polkit for libvirt
Line 674: %if 0%{?fedora} = 18 || 0%{?rhel} = 7
--
To view, visit http://gerrit.ovirt.org/24945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: xmlrpc: Support HTTP 1.1
Yaniv Bronhaim has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 2: -Code-Review -- To view, visit http://gerrit.ovirt.org/25124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: xmlrpc: Support HTTP 1.1
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 2: Code-Review+1 In my opinion, this patch is very beneficial and not really dangerous. We left a quick retreat path (the evil configurable) in case we find out of a serious issue there. -- To view, visit http://gerrit.ovirt.org/25124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: threadLocal: Cleanup thread local storage
Dan Kenigsberg has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: utils: Ensure that XMLRPC threads do not delay shutdown
Dan Kenigsberg has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use same constants for configuring and check configure of sa...
Dan Kenigsberg has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove code duplication between nics, bridges, bond...
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/24174/6/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 41: from .ipwrapper import Route Line 42: from .ipwrapper import routeGet Line 43: from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways Line 44: from . import libvirtconnection Line 45: from .ipwrapper import linkShowDev requires rebase on top of http://gerrit.ovirt.org/24989 Done Line 46: from .netconfpersistence import RunningConfig Line 47: from .netlink import iter_addrs Line 48: Line 49: -- To view, visit http://gerrit.ovirt.org/24174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: API extension to improve the communication with ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] vdsm: API extension to improve the communication with the Engine .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7322/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6538/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7440/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa0a7a86a351a8c2d891f22802a95d1fe1bc1df4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove code duplication between nics, bridges, bond...
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans .. Patch Set 7: Verified+1 Only rebased. Copying verification score -- To view, visit http://gerrit.ovirt.org/24174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report speed of underlying device as that of vlan...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: report speed of underlying device as that of vlan device .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee7f1ea72c77bb628640c1b2b27aac51811c8b0d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report speed of underlying device as that of vlan...
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: report speed of underlying device as that of vlan device .. netinfo: report speed of underlying device as that of vlan device netinfo.py was reporting speed 0 for the vlan devices in the system This patch makes that vlan devices, just like nics and bonds, will have a speed reported, that one of their underlying device. Change-Id: Iee7f1ea72c77bb628640c1b2b27aac51811c8b0d Bug-Url: https://bugzilla.redhat.com/1062617 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24990 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netinfo.py M vdsm/sampling.py 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee7f1ea72c77bb628640c1b2b27aac51811c8b0d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove code duplication between nics, bridges, bond...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7323/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7441/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Fix wrong filtering of dummy devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Fix wrong filtering of dummy devices .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7324/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6540/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7442/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3809eb1bb3230543bd586dcf722e2603da16952a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Do not take bond/nic down when removing one of their ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6541/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7443/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7444/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has uploaded a new change for review.
Change subject: vm: consider 'action' when handling I/O errors
..
vm: consider 'action' when handling I/O errors
When VDSM receives an I/O error event from libvirt,
it does not consider the value of the 'action' callback
field, and thus considers the guest CPU stopped.
This is true in the default configuration, which translates
to the disk write error policy 'stop', but not necessarily
true if the said policy is 'enospace'.
In this case the reported state of the CPU goes out of sync.
Since the error policy may be changed through an hook,
the safest thing to do is actually check the 'action'
value as reported by libvirt in the IOError callback.
This patch adds this check, and additional logging in
the case the guest CPU is reported running after I/O
errors.
Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Bug-Url: https://bugzilla.redhat.com/1064630
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/clientIF.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/25157/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index f8fe499..0169e81 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -550,7 +550,12 @@
v._rtcUpdate(utcoffset)
elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON:
srcPath, devAlias, action, reason = args[:-1]
-v._onAbnormalStop(devAlias, reason)
+if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
+v._onAbnormalStop(devAlias, reason)
+else:
+self.log.warn('I/O error event on %s (%s) reason %s'
+ ' ignored due to action %i',
+ srcPath, devAlias, reason, action)
elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
phase, localAddr, remoteAddr, authScheme, subject = args[:-1]
v.log.debug('graphics event phase '
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7327/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7445/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Misc storage exception class name style
Vered Volansky has posted comments on this change. Change subject: Misc storage exception class name style .. Patch Set 4: For what it's worth, verified storage functional tests -localfs and nfs only, versions 0 and 3 on RHEL 3.4 . -- To view, visit http://gerrit.ovirt.org/8847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f279d13b92bbb8f573a0d772d7504860bbbe3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 552: srcPath, devAlias, action, reason = args[:-1]
Line 553: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554: v._onAbnormalStop(devAlias, reason)
Line 555: else:
Line 556: self.log.warn('I/O error event on %s (%s) reason
%s'
since the only other supported action is report(to the guest), wouldn't it
make more sense to just say so in the log…and only on any other action code log
a warning or error?
Line 557: ' ignored due to action %i',
Line 558: srcPath, devAlias, reason, action)
Line 559: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560: phase, localAddr, remoteAddr, authScheme, subject =
args[:-1]
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 552: srcPath, devAlias, action, reason = args[:-1]
Line 553: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554: v._onAbnormalStop(devAlias, reason)
Line 555: else:
Line 556: self.log.warn('I/O error event on %s (%s) reason
%s'
since the only other supported action is report(to the guest), wouldn't i
or not log anything in case one of these two actions...since there's
self.log.info('abnormal vm stop device… right at the beginning of
_onAbnormalStop ()
Line 557: ' ignored due to action %i',
Line 558: srcPath, devAlias, reason, action)
Line 559: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560: phase, localAddr, remoteAddr, authScheme, subject =
args[:-1]
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 13: Verified+1 Generic Error split will be handled enterily in separate patches. Verified. -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 13: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6544/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/362/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7446/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 13: -Verified -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: Code-Review-1 (1 comment) minor comment. http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) using set(split()) on both sides would be more elegant than forcing everybody to sort their options. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use same constants for configuring and check configure of sa...
Yaniv Bronhaim has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/24011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fixing ssl config validation
Yaniv Bronhaim has posted comments on this change. Change subject: Fixing ssl config validation .. Patch Set 3: verified over rhel and fedora. please ack -- To view, visit http://gerrit.ovirt.org/24500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9ada1b81d275b8cac9391c15ab903ec9552184 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Use same constants for configuring and check configure of sa...
Yaniv Bronhaim has uploaded a new change for review. Change subject: Use same constants for configuring and check configure of sanlock .. Use same constants for configuring and check configure of sanlock Both DISKIMAGE_GROUP and QEMU_PROCESS_GROUP points to 'qemu'. It's confusing to use both one for configure and one for verification. The patch uses the same constants and check also if VDSM_GROUP is also set properly as required by sanlock process. Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/25162/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index b885d81..37fd416 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -24,8 +24,7 @@ from .. import utils from . import service, expose -from ..constants import P_VDSM_EXEC, DISKIMAGE_GROUP -from ..constants import QEMU_PROCESS_GROUP, VDSM_GROUP +from ..constants import P_VDSM_EXEC, QEMU_PROCESS_GROUP, VDSM_GROUP class _ModuleConfigure(object): @@ -108,6 +107,9 @@ class SanlockModuleConfigure(_ModuleConfigure): + +SANLOCK_GROUPS = (QEMU_PROCESS_GROUP, VDSM_GROUP) + def __init__(self): super(SanlockModuleConfigure, self).__init__() @@ -129,7 +131,7 @@ '/usr/sbin/usermod', '-a', '-G', -'%s,%s' % (QEMU_PROCESS_GROUP, VDSM_GROUP), +','.join(self.SANLOCK_GROUPS), 'sanlock' ), raw=True, @@ -159,7 +161,13 @@ break else: raise RuntimeError(Unable to find sanlock service groups) -configured = grp.getgrnam(DISKIMAGE_GROUP)[2] in groups + +is_sanlock_groups_set = True +for g in self.SANLOCK_GROUPS: +if grp.getgrnam(g)[2] not in groups: +is_sanlock_groups_set = False +configured = is_sanlock_groups_set + except IOError as e: if e.errno == os.errno.ENOENT: sys.stdout.write(sanlock service is not running\n) -- To view, visit http://gerrit.ovirt.org/25162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Use same constants for configuring and check configure of sa...
Yaniv Bronhaim has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/25162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: report exit reason for migration failed
Francesco Romani has uploaded a new change for review. Change subject: vm: report exit reason for migration failed .. vm: report exit reason for migration failed this patch add reporting for an explicit exit reason when migration fails, instead of generic error. Change-Id: Iab6cb810138e751f8fde784c5f6e0fdaf0f51fa2 Bug-Url: https://bugzilla.redhat.com/697277 Signed-off-by: Francesco Romani from...@redhat.com --- M vdsm/vm.py 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/25164/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index ed8fd08..9d40c95 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -2335,11 +2335,18 @@ self.recovering = False self.saveState() except Exception as e: +if hasattr(e, 'vm_exit_reason'): +exitReason = e.vm_exit_reason +exitMessage = '' +else: +exitReason = vmexitreason.GENERIC_ERROR +exitMessage = str(e) + if self.recovering: self.log.info(Skipping errors on recovery, exc_info=True) else: self.log.error(The vm start process failed, exc_info=True) -self.setDownStatus(ERROR, vmexitreason.GENERIC_ERROR, str(e)) +self.setDownStatus(ERROR, exitReason, exitMessage) def _incomingMigrationPending(self): return 'migrationDest' in self.conf or 'restoreState' in self.conf @@ -3755,9 +3762,11 @@ state = self._dom.state(0) if state[0] == libvirt.VIR_DOMAIN_PAUSED: if state[1] == libvirt.VIR_DOMAIN_PAUSED_MIGRATION: -raise MigrationError(Migration Error - Timed out +exc = MigrationError(Migration Error - Timed out (did not receive success event)) +exc.vm_exit_reason = vmexitreason.MIGRATION_FAILED +raise exc self.log.debug(NOTE: incomingMigrationFinished event has not been set and wait timed out after %d seconds. Current VM state: %d, reason %d. @@ -3771,6 +3780,7 @@ (e.args[0] if len(e.args) else 'Migration Error')) e.args = (newMsg,) + e.args[1:] +e.vm_exit_reason = vmexitreason.MIGRATION_FAILED raise self._domDependentInit() -- To view, visit http://gerrit.ovirt.org/25164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab6cb810138e751f8fde784c5f6e0fdaf0f51fa2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Do not take bond/nic down when removing one of their ...
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7329/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6545/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/363/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7447/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fixing ssl config validation
Dan Kenigsberg has posted comments on this change. Change subject: Fixing ssl config validation .. Patch Set 3: Code-Review+2 Understanding that moving from ssl=True to False and vice versa was verified, I'm giving my ack. -- To view, visit http://gerrit.ovirt.org/24500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9ada1b81d275b8cac9391c15ab903ec9552184 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: report exit reason for migration failed
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: report exit reason for migration failed .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7330/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6546/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7448/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab6cb810138e751f8fde784c5f6e0fdaf0f51fa2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) using set(split()) on both sides would be more elegant than forcing everybo It assures that the new function returns options sorted, maybe this deserves a comment. Given that we only test bonding options here, I would rather reorder the options manually instead of possible ' '.join(sorted(bondDict['options'].split())) which is ugly. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fixing ssl config validation
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Fixing ssl config validation .. Fixing ssl config validation Currently we verify only the config of livbirtd.conf and qemu.conf when ssl=False in vdsm.conf. If ssl=True we assumed the validation passes. This patch add a check also to ssl=True. Except that, the validation function is not general and checks only ssl configuration. This patch splits to specific test_conflict functions and allow adding more test_conflict functions in the future. Change-Id: I3d9ada1b81d275b8cac9391c15ab903ec9552184 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24425 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24500 --- M lib/vdsm/tool/libvirt_configure.sh.in 1 file changed, 31 insertions(+), 14 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d9ada1b81d275b8cac9391c15ab903ec9552184 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
testSetupNetworksAddDelDhcp verifies the new property.
Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/25170/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index d7eccc6..510ac85 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -500,9 +500,11 @@
Raises a KeyError if the iface does not exist.'''
data = {}
try:
+bootproto4 = 'dhcp' if iface in dhcp4 else 'none'
if bridged:
data.update({'ports': ports(iface), 'stp': bridge_stp_state(iface),
'cfg': getIfaceCfg(iface)})
+data['cfg']['BOOTPROTO'] = bootproto4
else:
# ovirt-engine-3.1 expects to see the interface attribute iff the
# network is bridgeless. Please remove the attribute and this
@@ -512,7 +514,7 @@
ipv4addr, ipv4netmask, ipv6addrs = getIpInfo(iface, ipaddrs)
data.update({'iface': iface, 'bridged': bridged,
'addr': ipv4addr, 'netmask': ipv4netmask,
- 'bootproto4': iface in dhcp4,
+ 'bootproto4': bootproto4,
'gateway': getgateway(gateways, iface),
'ipv6addrs': ipv6addrs,
'ipv6gateway': ipv6routes.get(iface, '::'),
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 695a29f..ec4fb1c 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1661,12 +1661,15 @@
veth.setLinkUp(left)
with dnsmasqDhcp(left):
network = {NETWORK_NAME: {'nic': right, 'bridged': False,
- 'bootprot': 'dhcp'}}
+ 'bootproto': 'dhcp'}}
status, msg = self.vdsm_net.setupNetworks(network, {}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkExists(NETWORK_NAME)
+net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
+self.assertEqual(net['bootproto4'], 'dhcp')
+
network = {NETWORK_NAME: {'remove': True}}
status, msg = self.vdsm_net.setupNetworks(network, {}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7331/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7449/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 552: srcPath, devAlias, action, reason = args[:-1]
Line 553: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554: v._onAbnormalStop(devAlias, reason)
Line 555: else:
Line 556: self.log.warn('I/O error event on %s (%s) reason
%s'
or not log anything in case one of these two actions...since there's self.
Right, I'll improve logging.
Will also push the check on the 'action' field inside _onAbnormalStop.
Line 557: ' ignored due to action %i',
Line 558: srcPath, devAlias, reason, action)
Line 559: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560: phase, localAddr, remoteAddr, authScheme, subject =
args[:-1]
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Do not take bond/nic down when removing one of their ...
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/25003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: pre-validate disks for snapshot
Daniel Erez has posted comments on this change. Change subject: vm: pre-validate disks for snapshot .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: snapshot transient disk check should be per disk
Daniel Erez has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Federico Simoncelli has uploaded a new change for review. Change subject: spec: add missing requirement for sanlock on el7 .. spec: add missing requirement for sanlock on el7 In the el7 section we were missing the sanlock and sanlock-python requirements. At this time we could have unified the three requirements outside of the conditional parts but I don't want to hit this issue again in the future in case we'll have to split it. Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/25173/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 0383532..64adbcc 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -168,6 +168,7 @@ Requires: qemu-kvm Requires: qemu-img Requires: selinux-policy-targeted +Requires: sanlock = 2.8, sanlock-python %else Requires: python # Update the qemu-kvm requires when block_stream will be included -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Federico Simoncelli has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 2: Verified+1 Verified: el7 now requires sanlock and sanlock-python -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6548/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/364/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7450/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7452/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6549/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/365/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7451/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: xmlrpc: Support HTTP 1.1
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 2: Verified on RHEL 6.5 host and ovirt-engine 3.4.0-0.9.beta3.fc19: - starting and stopping vms - create and delete snapshot - create and delete template - create vm from template - remove vm -- To view, visit http://gerrit.ovirt.org/25124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: xmlrpc: Support HTTP 1.1
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/25124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix migration progress calculation
Francesco Romani has posted comments on this change. Change subject: vm: fix migration progress calculation .. Patch Set 2: Verified+1 verification: verified using vdsClient and with both failed (timeout) and sucesfull migrations. -- To view, visit http://gerrit.ovirt.org/25038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10bc039e9620b0cafe4adc21a6f3bda075046d78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1: Code-Review-1
(2 comments)
The functional test was fixed and extended to become actually usable but it
breaks /etc/resolv.conf.
http://gerrit.ovirt.org/#/c/25170/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 503: bootproto4 = 'dhcp' if iface in dhcp4 else 'none'
Line 504: if bridged:
Line 505: data.update({'ports': ports(iface), 'stp':
bridge_stp_state(iface),
Line 506: 'cfg': getIfaceCfg(iface)})
Line 507: data['cfg']['BOOTPROTO'] = bootproto4
Backwards compatibility was omitted in the original patch.
Line 508: else:
Line 509: # ovirt-engine-3.1 expects to see the interface
attribute iff the
Line 510: # network is bridgeless. Please remove the attribute and
this
Line 511: # comment when the version is no longer supported.
http://gerrit.ovirt.org/#/c/25170/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1660: veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1661: veth.setLinkUp(left)
Line 1662: with dnsmasqDhcp(left):
Line 1663: network = {NETWORK_NAME: {'nic': right, 'bridged':
False,
Line 1664: 'bootproto': 'dhcp'}}
I decided to use this test becase it was not testing out much even with
'bootproto' fixed.
Unfortunately, it causes /etc/resolv.conf to be rewritten:
; generated by /sbin/dhclient-script
nameserver 240.0.0.1
Line 1665:
Line 1666: status, msg = self.vdsm_net.setupNetworks(network,
{}, NOCHK)
Line 1667: self.assertEqual(status, SUCCESS, msg)
Line 1668: self.assertNetworkExists(NETWORK_NAME)
--
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: more combinations mtu combinations
Antoni Segura Puimedon has posted comments on this change. Change subject: net tests: more combinations mtu combinations .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: more combinations mtu combinations
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: more combinations mtu combinations .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6551/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7453/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove code duplication between nics, bridges, bond...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6552/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7454/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) It assures that the new function returns options sorted, maybe this deserve As you said, ' '.join(sorted(bondDict['options'].split())) is ugly. That's why I suggested self.assertEqual(set(cfg['BONDING_OPTS'].split()), set(bondDict['options']).split()) This way, you do not force future test writers to remember that they have to sort their option. Options may be unsorted in real life, so this should be possible also in the test framework. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Dan Kenigsberg has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 2: Code-Review+2 We should probably split the requirement section to smaller per-package ones (e.g. the iscsi-initiator one). -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File vdsm/vm.py:
Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
Line 4583: self.log.info('I/O error %s device %s reported to guest
OS',
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: self.log.info('I/O error %s device %s action %i ignored',
just a nit, this should probably be an error since the current libvirt list of
events have only pause and report.
As you prefer.
Line 4587: err, blockDevAlias, action)
Line 4588:
Line 4589: def _acpiShutdown(self):
Line 4590:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/25170/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1660: veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1661: veth.setLinkUp(left)
Line 1662: with dnsmasqDhcp(left):
Line 1663: network = {NETWORK_NAME: {'nic': right, 'bridged':
False,
Line 1664: 'bootproto': 'dhcp'}}
I decided to use this test becase it was not testing out much even with 'bo
oh dear. this explains a lot - in particular, why slaves lost their
connectivity.
Passing
--port=0
to dnsmasq should avoid that.
Line 1665:
Line 1666: status, msg = self.vdsm_net.setupNetworks(network,
{}, NOCHK)
Line 1667: self.assertEqual(status, SUCCESS, msg)
Line 1668: self.assertNetworkExists(NETWORK_NAME)
Line 1667: self.assertEqual(status, SUCCESS, msg)
Line 1668: self.assertNetworkExists(NETWORK_NAME)
Line 1669:
Line 1670: net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
Line 1671: self.assertEqual(net['bootproto4'], 'dhcp')
please add an asserion for the legacy ['cfg'][BOOTPROTO] report.
Line 1672:
Line 1673: network = {NETWORK_NAME: {'remove': True}}
Line 1674: status, msg = self.vdsm_net.setupNetworks(network,
{}, NOCHK)
Line 1675: self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 14: Verified+1 ok, *now* actually verified (previously I had some remnants of what then evolved in http://gerrit.ovirt.org/#/c/25164/. My bad, failed with some git commit juggling) - verified various setDownStatus scenarios, on each one message was constructed correctly from the exitReason and the exitReason is reported. -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages
mooli tayer has posted comments on this change. Change subject: Adding remove\disable verbs to vdsm-tool for admin usages .. Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 86: P_SYSTEMCTL_CONF = SYSCONF_PATH + '/sysctl.d/vdsm' Line 87: P_VDSM_LCONF = SYSCONF_PATH + '/libvirt/libvirtd.conf' Line 88: P_VDSM_LDCONF = SYSCONF_PATH + '/sysconfig/libvirtd' Line 89: P_VDSM_QCONF = SYSCONF_PATH + '/libvirt/qemu.conf' Line 90: no need for that I guess this is related to your comment on configurator.py in line 151? my response to you there is that i'm not sure what you want done in this patch instead? Line 91: # Line 92: # External programs (sorted, please keep in order). Line 93: # Line 94: EXT_BLKID = '@BLKID_PATH@' http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 29: from ..constants import P_VDSM_EXEC, DISKIMAGE_GROUP, QEMU_PROCESS_GROUP, \ Line 30: VDSM_GROUP, P_VDSM_LCONF, P_VDSM_QCONF, P_VDSM_LDCONF, P_SYSTEMCTL_CONF Line 31: Line 32: Line 33: def removeSectionFromFile(filename, beginField=None, endField=None): I do not think it is that complex, and it can be improved (testing the exac testing the exact lines we add instead of signature before/after I guess that a patch removing exact lines should also change the code that inserts them? not sure if it should be done now or or in a different patch. Also, I do not like the duplicated: '## beginning of configuration section by vdsm' in this patch. Just a thought: is there a way we can do a one line import inside libvirt configuration file/s to a new file containing our conf and then just remove that? Line 34: ( Line 35: BEFORE, Line 36: WITHIN, Line 37: AFTER, Line 147: conf_prefix = '## beginning of configuration section by vdsm' + \ Line 148: vdsm_ver Line 149: conf_suffix = '## end of configuration section by vdsm' + vdsm_ver Line 150: Line 151: conf_paths = [ libvirt_configure.sh already keeps those files names in it, remove_conf ver I am not sure what you are suggesting to do in this patch instead? Line 152: P_VDSM_LCONF, Line 153: P_VDSM_QCONF, Line 154: P_VDSM_LDCONF, Line 155: ] Line 357: m = [ Line 358: c.getName() for c in __configurers Line 359: if c.getName() in args.modules and not c.removeConf() Line 360: ] Line 361: if m: c.removeConf() Well I guess this whole section should change since c.removeConf() can never return false? Some other way should be used to detect errors. Line 362: sys.stdout.write( Line 363: Could not remove configuration for modules %s\n % ','.join(m), Line 364: ) Line 365: ret = False -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File vdsm/vm.py:
Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
Line 4583: self.log.info('I/O error %s device %s reported to guest
OS',
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: self.log.info('I/O error %s device %s action %i ignored',
just a nit, this should probably be an error since the current libvirt list
I think you are right. Will change.
Line 4587: err, blockDevAlias, action)
Line 4588:
Line 4589: def _acpiShutdown(self):
Line 4590:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6553/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7455/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Dan Kenigsberg has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 3: That's fine, too. Thogh I'd drop the obvious comment. -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Dan Kenigsberg has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
Francesco Romani has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 7:
(2 comments)
I think we can improve the code even more by get rid of some function
arguments, if -as code suggests- they are used only for testing.
http://gerrit.ovirt.org/#/c/23703/7/vdsm/caps.py
File vdsm/caps.py:
Line 164: return topology
Line 165:
Line 166:
Line 167: @utils.memoized
Line 168: def _getNumaTopology(capabilities=None):
I think you can get rid of this argument by using more monkeypatch, by
replacing _getCapsXMLStr() in the tests.
Line 169: if capabilities is None:
Line 170: capabilities = _getCapsXMLStr()
Line 171: caps = minidom.parseString(capabilities)
Line 172: host = caps.getElementsByTagName('host')[0]
Line 185: return cellsInfo
Line 186:
Line 187:
Line 188: @utils.memoized
Line 189: def _getMemoryStatsByNumaCell(cell, flags=0):
and get rid of the flags argument here (seems unused both here and in the
tests).
Probably this one-line method can be dropped as well. I'm ok with keeping it if
this helps testing, though.
Line 190: return libvirtconnection.get().getMemoryStats(int(cell), flags)
Line 191:
Line 192:
Line 193: @utils.memoized
--
To view, visit http://gerrit.ovirt.org/23703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6554/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/366/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7456/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6555/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7457/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: add missing requirement for sanlock on el7 .. spec: add missing requirement for sanlock on el7 In the el7 section we were missing the sanlock and sanlock-python requirements. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064042 Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25173 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
Dan Kenigsberg has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 4: Verified+1 Code-Review+2 Not verified, but I'm tired of this one. -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Stop the fileConfig from disabling existing logs
oVirt Jenkins CI Server has posted comments on this change. Change subject: logging: Stop the fileConfig from disabling existing logs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7340/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6556/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7458/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Stop the fileConfig from disabling existing logs
Dan Kenigsberg has posted comments on this change. Change subject: logging: Stop the fileConfig from disabling existing logs .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: add missing requirement for sanlock on el7
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: add missing requirement for sanlock on el7 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/368/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf9a6ae3386e4312861d7659da696f94498d7de4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix migration progress calculation
Dan Kenigsberg has posted comments on this change. Change subject: vm: fix migration progress calculation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10bc039e9620b0cafe4adc21a6f3bda075046d78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Stop the fileConfig from disabling existing logs
Yaniv Bronhaim has posted comments on this change. Change subject: logging: Stop the fileConfig from disabling existing logs .. Patch Set 1: Code-Review-1 oh sorry. we have more locations were we load logging.config , modify all of them -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Stop the fileConfig from disabling existing logs
Yaniv Bronhaim has posted comments on this change. Change subject: logging: Stop the fileConfig from disabling existing logs .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) As you said, Okay, it's not much of an advantage that we know our bondopts are sorted. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7341/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7459/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Reload daemon file after each install
oVirt Jenkins CI Server has posted comments on this change. Change subject: Reload daemon file after each install .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/17/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Stop the fileConfig from disabling existing logs
oVirt Jenkins CI Server has posted comments on this change. Change subject: logging: Stop the fileConfig from disabling existing logs .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7342/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7460/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/25170/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1660: veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1661: veth.setLinkUp(left)
Line 1662: with dnsmasqDhcp(left):
Line 1663: network = {NETWORK_NAME: {'nic': right, 'bridged':
False,
Line 1664: 'bootproto': 'dhcp'}}
oh dear. this explains a lot - in particular, why slaves lost their connect
It is already there, in dhcp.py :-/
Line 1665:
Line 1666: status, msg = self.vdsm_net.setupNetworks(network,
{}, NOCHK)
Line 1667: self.assertEqual(status, SUCCESS, msg)
Line 1668: self.assertNetworkExists(NETWORK_NAME)
Line 1667: self.assertEqual(status, SUCCESS, msg)
Line 1668: self.assertNetworkExists(NETWORK_NAME)
Line 1669:
Line 1670: net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
Line 1671: self.assertEqual(net['bootproto4'], 'dhcp')
please add an asserion for the legacy ['cfg'][BOOTPROTO] report.
Along with 'bridged': True, added (I had it here prepared).
Line 1672:
Line 1673: network = {NETWORK_NAME: {'remove': True}}
Line 1674: status, msg = self.vdsm_net.setupNetworks(network,
{}, NOCHK)
Line 1675: self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6559/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7461/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos: Support to SOS 3
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: sos: Support to SOS 3
..
sos: Support to SOS 3
This patch will add support to sos 3 API and keep compatible
with old API.
Change-Id: I52fbd9431506c5862cc762b4d3f0701ab5cf6a0b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060383
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M configure.ac
M vdsm.spec.in
M vdsm/sos/vdsm.py.in
3 files changed, 73 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/25188/1
diff --git a/configure.ac b/configure.ac
index 55879e7..fd61e03 100644
--- a/configure.ac
+++ b/configure.ac
@@ -55,6 +55,26 @@
)
AM_CONDITIONAL([HOOKS], [test ${enable_hooks} = yes])
+AC_MSG_CHECKING(sos version)
+AC_ARG_VAR([SOS_VERSION], [SOS utility version])
+SOS_VERSION=`$PYTHON -c import sos; print(sos.__version__) |cut -c1
2/dev/null`
+AC_MSG_RESULT($SOS_VERSION)
+
+# SOS - support API 2 and 3 calls
+if test x${SOS_VERSION} = x2; then
+ AC_SUBST([SOS_ADD_COPY_SPEC], [addCopySpec])
+ AC_SUBST([SOS_ADD_COPY_SPEC_LIMIT], [addCopySpecLimit])
+ AC_SUBST([SOS_CLASS], [vdsm(sos.plugintools.PluginBase)])
+ AC_SUBST([SOS_CMD_OUTPUT], [collectExtOutput])
+ AC_SUBST([SOS_GET_OPTION], [getOption])
+else
+ AC_SUBST([SOS_ADD_COPY_SPEC], [add_copy_spec])
+ AC_SUBST([SOS_ADD_COPY_SPEC_LIMIT], [add_copy_spec_limit])
+ AC_SUBST([SOS_CLASS], [Vdsm(Plugin, RedHatPlugin)])
+ AC_SUBST([SOS_CMD_OUTPUT], [add_cmd_output])
+ AC_SUBST([SOS_GET_OPTION], [get_option])
+fi
+
AC_ARG_ENABLE(
[libvirt-sanlock],
[AS_HELP_STRING(
@@ -185,6 +205,7 @@
AX_PYTHON_MODULE([pthreading], [fatal])
AX_PYTHON_MODULE([pyinotify], [fatal])
AX_PYTHON_MODULE([selinux], [fatal])
+AX_PYTHON_MODULE([sos], [fatal])
# External programs (sorted, please keep in order)
AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0383532..3be91c7 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -97,6 +97,8 @@
BuildRequires: python-pep8
%endif
+BuildRequires: sos
+
%if 0%{?with_systemd}
BuildRequires: systemd-units
%endif
@@ -241,7 +243,13 @@
Requires: psmisc = 22.6-15
Requires: bridge-utils
-Requires: sos
+
+%if 0%{fedora} = 20 || 0%{?rhel} = 7
+Requires: sos = 3.1
+%else
+Requires: sos 3
+%endif
+
Requires: tree
Requires: dosfstools
Requires: genisoimage
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 6bc111a..50f0ac2 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -18,7 +18,11 @@
# Refer to the README and COPYING files for full details of the license
#
-import sos.plugintools
+try:
+from sos.plugins import Plugin, RedHatPlugin
+except:
+import sos.plugintools
+
import subprocess
import os
@@ -39,7 +43,7 @@
config = _importVdsmPylibModule('config').config
-class vdsm(sos.plugintools.PluginBase):
+class @SOS_CLASS@:
VDSM server related information
@@ -54,64 +58,64 @@
irrespective of their size.
if logsize is not None:
-self.addCopySpecLimit(path, logsize)
+self.@SOS_ADD_COPY_SPEC_LIMIT@(path, logsize)
else:
-self.addCopySpec(path)
+self.@SOS_ADD_COPY_SPEC@(path)
def setup(self):
os.environ[LVM_SYSTEM_DIR] = @VDSMRUNDIR@/lvm
-self.collectExtOutput(/etc/init.d/vdsmd status)
-self.addCopySpec(/tmp/vds_installer*)
-self.addCopySpec(/tmp/vds_bootstrap*)
-self.addCopySpec(/etc/vdsm/*)
-self.addCopySpec(/etc/vdsm-reg/*)
-logsize = self.getOption('logsize')
+self.@SOS_CMD_OUTPUT@(/etc/init.d/vdsmd status)
+self.@SOS_ADD_COPY_SPEC@(/tmp/vds_installer*)
+self.@SOS_ADD_COPY_SPEC@(/tmp/vds_bootstrap*)
+self.@SOS_ADD_COPY_SPEC@(/etc/vdsm/*)
+self.@SOS_ADD_COPY_SPEC@(/etc/vdsm-reg/*)
+logsize = self.@SOS_GET_OPTION@('logsize')
self.__addCopySpecLogLimit(/var/log/vdsm/*, logsize)
self.__addCopySpecLogLimit(/var/log/vdsm-reg/*, logsize)
self._addVdsmRunDir()
-self.addCopySpec(@TRUSTSTORE@)
-self.addCopySpec(@HOOKSDIR@)
-self.addCopySpec(/var/log/ovirt.log)
-self.addCopySpec(/var/log/sanlock.log)
+self.@SOS_ADD_COPY_SPEC@(@TRUSTSTORE@)
+self.@SOS_ADD_COPY_SPEC@(@HOOKSDIR@)
+self.@SOS_ADD_COPY_SPEC@(/var/log/ovirt.log)
+self.@SOS_ADD_COPY_SPEC@(/var/log/sanlock.log)
p = subprocess.Popen(['/usr/bin/pgrep', 'qemu-kvm'],
stdout=subprocess.PIPE)
out, err = p.communicate()
for line in out.splitlines():
pid = line.strip()
-self.addCopySpec(/proc/%s/cmdline % pid)
-self.addCopySpec(/proc/%s/status % pid)
-self.addCopySpec(/proc/%s/mountstats % pid)
-self.collectExtOutput(/bin/ls -l /var/log/core)
-
Change in vdsm[master]: sos: Support to SOS 3
Douglas Schilling Landgraf has posted comments on this change. Change subject: sos: Support to SOS 3 .. Patch Set 1: Verified+1 Tested on RHEL6.4 and Fedora20 using command sosreport -o vdsm -- To view, visit http://gerrit.ovirt.org/25188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fbd9431506c5862cc762b4d3f0701ab5cf6a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos: Support to SOS 3
oVirt Jenkins CI Server has posted comments on this change. Change subject: sos: Support to SOS 3 .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6560/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/369/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7462/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fbd9431506c5862cc762b4d3f0701ab5cf6a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos: Support to SOS 3
Douglas Schilling Landgraf has posted comments on this change. Change subject: sos: Support to SOS 3 .. Patch Set 1: Going to fix the jenkins alarm. new patch soon -- To view, visit http://gerrit.ovirt.org/25188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fbd9431506c5862cc762b4d3f0701ab5cf6a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: pre-validate disks for snapshot
Federico Simoncelli has posted comments on this change. Change subject: vm: pre-validate disks for snapshot .. Patch Set 1: Verified+1 Same as master. -- To view, visit http://gerrit.ovirt.org/25006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
