Change in vdsm[master]: pep8: virt cleanups for pep8-1.5
Francesco Romani has uploaded a new change for review.
Change subject: pep8: virt cleanups for pep8-1.5
..
pep8: virt cleanups for pep8-1.5
virt is now pep8-1.5 clean
Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/sampling.py
M vdsm/virt/vm.py
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/26347/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 6ff0641..991c969 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -476,7 +476,7 @@
for ifid, ifrate in zip(self._ifids, self._ifrates):
# it skips hot-plugged devices if we haven't enough information
# to count stats from it
-if not ifid in hs0.interfaces:
+if ifid not in hs0.interfaces:
continue
ifrate = ifrate or 1000
Mbps2Bps = (10 ** 6) / 8
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 3c2fcbe..f389715 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1107,7 +1107,7 @@
# This hack is for backward compatibility as the libvirt
# does not allow 'qemu64' guest on intel hardware
-if model == 'qemu64' and not '+svm' in features:
+if model == 'qemu64' and '+svm' not in features:
features += ['-svm']
for feature in features[1:]:
@@ -1241,7 +1241,7 @@
if self.conf.get('keyboardLayout'):
graphicsAttrs['keymap'] = self.conf['keyboardLayout']
-if not 'spiceDisableTicketing' in self.conf:
+if 'spiceDisableTicketing' not in self.conf:
graphicsAttrs['passwd'] = '*'
graphicsAttrs['passwdValidTo'] = '1970-01-01T00:00:01'
@@ -4869,8 +4869,8 @@
for dev in self.conf['devices']:
if ((dev['type'] == CONTROLLER_DEVICES) and
(dev['device'] == device) and
-(not 'index' in dev or dev['index'] == index) and
-(not 'model' in dev or dev['model'] == model)):
+('index' not in dev or dev['index'] == index) and
+('model' not in dev or dev['model'] == model)):
dev['address'] = address
dev['alias'] = alias
knownDev = True
--
To view, visit http://gerrit.ovirt.org/26347
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: virt cleanups for pep8-1.5
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: virt cleanups for pep8-1.5 .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7005/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7907/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7796/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: virt cleanups for pep8-1.5
Dan Kenigsberg has posted comments on this change. Change subject: pep8: virt cleanups for pep8-1.5 .. Patch Set 1: Verified+1 Code-Review+2 verified with gitpydiff for having not syntactical change. -- To view, visit http://gerrit.ovirt.org/26347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: virt cleanups for pep8-1.5
Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8: virt cleanups for pep8-1.5 .. pep8: virt cleanups for pep8-1.5 virt is now pep8-1.5 clean Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26347 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/sampling.py M vdsm/virt/vm.py 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ffcb5c7601cad74741fce07301ddb458cd6679f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool
Hello Ayal Baron, Federico Simoncelli, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/26349 to review the following change. Change subject: hsm: refresh pool connection on connectStoragePool .. hsm: refresh pool connection on connectStoragePool When a storage domain is not accessible when connecting to the pool, the domain links are not created. Later, during the recovery flow, when engine ask vdsm to reconnect to the pool, the domain links are not created since the host is already connected to the pool. This patch ensures that domain structure is created in this case, by triggering a refresh when the host is already connected to the pool. Note about poorly documented changes in teh original patch: - Removing support for auto-reconnection, when msdUUID and masterVersion are None. In this case they were read from the pool file by invoking getPoolParams(). While this change is not correct, the auto-reconnect code is broken for years, (and was removed later in master), so this support is not needed. - Validation of host id is replaced by comparing hostID to pool.id in _updateStoragePool(). - pool.getMasterDomain calls was removed becuase it is called in the refresh flow later. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026697 Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22467 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 18 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/26349/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 1d36cee..349ee6f 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1007,6 +1007,14 @@ return self._connectStoragePool(spUUID, hostID, scsiKey, msdUUID, masterVersion, options) +@staticmethod +def _updateStoragePool(pool, hostId, msdUUID, masterVersion): +if hostId != pool.id: +raise se.StoragePoolConnected( +hostId=%s, newHostId=%s % (pool.id, hostId)) + +pool.refresh(msdUUID, masterVersion) + def _connectStoragePool(self, spUUID, hostID, scsiKey, msdUUID, masterVersion, options=None): misc.validateUUID(spUUID, 'spUUID') @@ -1022,17 +1030,14 @@ pass # pool not connected yet else: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared): -pool = self.getPool(spUUID) -if not msdUUID or not masterVersion: -hostID, scsiKey, msdUUID, masterVersion = \ -pool.getPoolParams() -misc.validateN(hostID, 'hostID') -# getMasterDomain is called because produce is required here -# since the master domain can be changed by the SPM if it is -# the refreshPool flow. -pool.getMasterDomain(msdUUID=msdUUID, - masterVersion=masterVersion) -return +# FIXME: this breaks in case of a race as it assumes that the +# pool is still available. At the moment we maintain this +# behavior as it's inherited from the previous implementation +# but the problem must be addressed (possibly improving the +# entire locking pattern used in this method). +self._updateStoragePool(self.getPool(spUUID), hostID, msdUUID, +masterVersion) +return True with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive): try: @@ -1040,14 +1045,8 @@ except se.StoragePoolUnknown: pass # pool not connected yet else: -if not msdUUID or not masterVersion: -hostID, scsiKey, msdUUID, masterVersion = \ -pool.getPoolParams() -misc.validateN(hostID, 'hostID') -# Idem. See above. -pool.getMasterDomain(msdUUID=msdUUID, - masterVersion=masterVersion) -return +self._updateStoragePool(pool, hostID, msdUUID, masterVersion) +return True pool = sp.StoragePool(spUUID, self.taskMng) if not hostID or not scsiKey or not msdUUID or not masterVersion: -- To view, visit http://gerrit.ovirt.org/26349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool
Nir Soffer has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 1: Verified+1 Verified on RHEL 6.5 with ISCI storage with engine 3.4 - Create data center, cluster, storage domain - Create vm, start it, install, stop - Put host to maintenance/activate - When host is connected to pool, issue connectStoragePool from vdsClient, simulating recovery flow, verify that refresh flow was performed -- To view, visit http://gerrit.ovirt.org/26349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool
Nir Soffer has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 1: Note: gerrit is drunk again: $ git checkout ovirt-3.4 $ git log --grep=I46d7c36b48f5d58edbc89947ccd2bcd60408a729 commit 639cb14a1eff082e979e56c69e20eb7e361451b2 Author: Federico Simoncelli fsimo...@redhat.com Date: Tue Dec 17 05:17:12 2013 -0500 hsm: refresh pool connection on connectStoragePool This patch ensures that connectStoragePool would trigger a refresh when the host is already connected to the same pool. Using connectStoragePool instead of refreshStoragePool is at the base of the storage pool metadata removal but it also solves an existing problem in the non-operational recovery flow where the engine sends a connectStoragePool request. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026697 Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22467 Reviewed-by: Ayal Baron aba...@redhat.com -- To view, visit http://gerrit.ovirt.org/26349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: move threads in a separate module
Francesco Romani has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 11: Verified+1 Patch set 11: * rebased after pep8 1.5.x fixes * verified to be pep8 1.5.x clean rebase + changes are only in comments, re-ticking Verified -- To view, visit http://gerrit.ovirt.org/25970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: always run migration monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: always run migration monitor .. Patch Set 12: Verified+1 Patch set 12: * rebased * improved the commit message re-ticking verified. -- To view, visit http://gerrit.ovirt.org/25975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4953ddda5a5c6c0ecd7ea0f95377309e18f771a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename migration threads
Francesco Romani has posted comments on this change. Change subject: virt: migration: rename migration threads .. Patch Set 4: Patch set 4: - rebased -- To view, visit http://gerrit.ovirt.org/26260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47597b8a0e89d093e0ff725518a80d3ec6de2cfe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 13: Patch set 13: * rebased -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 14: Patch set 14: * rebased * improved the commit message -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7006/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7908/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7797/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 4: Patch set 4: rebased -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7007/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7909/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7798/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 15: Patch set 15: rebased -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7008/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7910/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7799/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename migration threads
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename migration threads .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7010/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7911/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7800/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47597b8a0e89d093e0ff725518a80d3ec6de2cfe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7009/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7912/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7801/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: move threads in a separate module
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7011/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/447/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7913/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7802/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: always run migration monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: always run migration monitor .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7012/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7914/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7803/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4953ddda5a5c6c0ecd7ea0f95377309e18f771a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: make pep8-1.5 happy with E265
Eyal Edri has posted comments on this change. Change subject: pep8: make pep8-1.5 happy with E265 .. Patch Set 3: still fails on other issues: http://pastebin.com/uMaXEfaT -- To view, visit http://gerrit.ovirt.org/26248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c49e1c0f36590b8052462b9e066c110eacd67b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
Martin Sivák has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 8: I like it. Fix Francesco's comments and it should be ready. -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool
Allon Mureinik has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 1: Code-Review+1 This bug was probably solved before the 3.4 split, so there is no such GERRIT item for 3.4. Please ignore the malfactioning hook. -- To view, visit http://gerrit.ovirt.org/26349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
Michal Skrivanek has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/23703/8/vdsm/caps.py
File vdsm/caps.py:
Line 165:
Line 166:
Line 167: @utils.memoized
Line 168: def _getNumaTopology():
Line 169: capabilities = _getCapsXMLStr()
I'd suggest to use the same code as at line 146. And then as a separate patch
it should be refactored so we don't have to do this in every function:)
Line 170: caps = minidom.parseString(capabilities)
Line 171: host = caps.getElementsByTagName('host')[0]
Line 172: cells = host.getElementsByTagName('cells')[0]
Line 173: cellsInfo = {}
--
To view, visit http://gerrit.ovirt.org/23703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: [wip] modeling graphics as a device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: [wip] modeling graphics as a device .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7013/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7915/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7804/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/23555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59b933f4cd1e3ab562ad2ec1c237007c83f214c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not allow empty network names (bridged nor bridgeless)
Dan Kenigsberg has posted comments on this change. Change subject: Do not allow empty network names (bridged nor bridgeless) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d1e5d9fb284eb67936daf197e3025314a29f58b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not allow empty network names (bridged nor bridgeless)
Dan Kenigsberg has submitted this change and it was merged. Change subject: Do not allow empty network names (bridged nor bridgeless) .. Do not allow empty network names (bridged nor bridgeless) It was possible to create empty network names that ended up in libvirt networks called 'vdsm-'. This patch solved it returning the appropriate error and not allowing empty bridge names in the internal representation either. Change-Id: I1d1e5d9fb284eb67936daf197e3025314a29f58b Bug-Url: https://bugzilla.redhat.com/1078899 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26263 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/netmodelsTests.py M vdsm/network/api.py M vdsm/network/models.py 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d1e5d9fb284eb67936daf197e3025314a29f58b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vnic QoS: Fix specParams to XML definition conversion
Antoni Segura Puimedon has posted comments on this change. Change subject: vnic QoS: Fix specParams to XML definition conversion .. Patch Set 1: Verified+1 Passed the functional tests at http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1201/ -- To view, visit http://gerrit.ovirt.org/26254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25041b8f853c870388ecd9c9f9176bd384242234 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
Vinzenz Feenstra has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/25927/10/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm_hooks/fakevmstats/after_get_all_vm_stats.py:
Line 80: stats['cpuSys'] = '%.2f' % (cpuTotal - cpuUser)
Line 81: stats['memUsage'] = str(random.randint(0, 100))
Line 82:
Line 83: # Disks
Line 84: for disk in stats['disks'].iterkeys():
for disk in stats['disks'].itervalues():
disk['readRate'] = ...
Line 85: # Simulate some supersonic disks:
Line 86: stats['disks'][disk]['readRate'] = str(random.randint(0,
2**32))
Line 87: stats['disks'][disk]['writeRate'] = str(random.randint(0,
2**32))
Line 88: stats['disks'][disk]['readLatency'] = str(random.randint(0,
10**9))
Line 93: for net in stats['network'].iterkeys():
for net in stats['network'].itervalues():
net['rxRate'] = ...
Line 99: stats['network'][net]['txErrors'] = str(random.randint(0,
2*32))
Line 100:
Line 101: # Fake guest-agent reports:
Line 102: stats['session'] = 'Unknown'
Line 103: if not 'memoryStats' in stats.keys():
if 'memoryStats' not in stats:
Line 104: stats['memoryStats'] = {}
Line 105: stats['memoryStats']['mem_total'] = str((2**random.randint(0,
5)) * GB)
Line 106: memUsed = int(random.random() *
int(stats['memoryStats']['mem_total']))
Line 107: memUnused = int(random.random() * memUsed)
--
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: move threads in a separate module
Federico Simoncelli has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: [wip] modeling graphics as a device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: [wip] modeling graphics as a device .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7014/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7916/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7805/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/23555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59b933f4cd1e3ab562ad2ec1c237007c83f214c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: remove unused add/remove tags
Federico Simoncelli has posted comments on this change. Change subject: lvm: remove unused add/remove tags .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Liron Ar has uploaded a new change for review. Change subject: core: fixing attribute error on fenceSpmStorage .. core: fixing attribute error on fenceSpmStorage In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool metadata operations were moved to the pool backend, while the call to invalidateMetadata in fenceSpmStorage was left as it was, leading to an attribute error. This patch fixes it by checking the backend type before executing it, though it's not the nicest way for doing so, it's the pattern already being used in other places in hsm.py,therefore in the meanwhile it can be fixed the same way. Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1082365 Signed-off-by: Liron Aravot lara...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/26357/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 0ebe129..d9697ef 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3529,7 +3529,8 @@ se.SpmFenceError(spUUID=%s, lastOwner=%s, lastLver=%s % (spUUID, lastOwner, lastLver))) pool = self.getPool(spUUID) -pool.invalidateMetadata() +if isinstance(pool.getBackend(), StoragePoolDiskBackend): +pool.getBackend().invalidateMetadata() vars.task.getExclusiveLock(STORAGE, spUUID) pool.forceFreeSpm() return dict(spm_st=self._getSpmStatusInfo(pool)) -- To view, visit http://gerrit.ovirt.org/26357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Liron Ar has abandoned this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Abandoned -- To view, visit http://gerrit.ovirt.org/26357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7015/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7917/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7806/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7016/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7918/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7807/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7017/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7919/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7808/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Liron Ar has uploaded a new change for review. Change subject: core: fixing attribute error on fenceSpmStorage .. core: fixing attribute error on fenceSpmStorage In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool metadata operations were moved to the pool backend, while the call to invalidateMetadata in fenceSpmStorage was left as it was, leading to an attribute error. This patch fixes it by executing the operation on the pool backend object rather than on the pool, as the metadata operation are implemented only in StoragePoolDiskBackend - there's also a check for the backend type before executing it. Though it's not the nicest way for doing so, it's the pattern already used in hsm.py,therefore in the meanwhile it can be fixed the same way. Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1082365 Signed-off-by: Liron Aravot lara...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/26358/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 0ebe129..d9697ef 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3529,7 +3529,8 @@ se.SpmFenceError(spUUID=%s, lastOwner=%s, lastLver=%s % (spUUID, lastOwner, lastLver))) pool = self.getPool(spUUID) -pool.invalidateMetadata() +if isinstance(pool.getBackend(), StoragePoolDiskBackend): +pool.getBackend().invalidateMetadata() vars.task.getExclusiveLock(STORAGE, spUUID) pool.forceFreeSpm() return dict(spm_st=self._getSpmStatusInfo(pool)) -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid redundant volume produces.
Federico Simoncelli has posted comments on this change. Change subject: Avoid redundant volume produces. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/17991/1/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 640: # If it has a repo we don't have multiple domains. Assume single pool Line 641: return os.path.join(self.storage_repository, self.getPools()[0]) Line 642: Line 643: def getVolumePath(self, imgUUID, volUUID): Line 644: return os.path.join(self.mountpoint, self.sdUUID, 'images', imgUUID, Use DOMAIN_IMAGES instead of 'images'. Also this getVolumePath looks different from the previous vol.getVolumePath since it reaches the volume through the mountpoint instead that through the storage pool directory. Line 645: volUUID) Line 646: Line 647: def getIsoDomainImagesDir(self): Line 648: -- To view, visit http://gerrit.ovirt.org/17991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad53a7e8a66d7f9bdd62048f2bf1f722a490c5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7018/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7920/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7809/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
Federico Simoncelli has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/25927/10/vdsm/hooking.py File vdsm/hooking.py: Line 56: def write_domxml(domxml): Line 57: file(os.environ['_hook_domxml'], 'w').write(domxml.toxml(encoding='utf-8')) Line 58: Line 59: Line 60: def read_json(): I have mixed feelings about adding these two methods in this change. They may deserve their own patch, after all we're already supporting _JSON_HOOK. Line 61: return json.loads(file(os.environ['_hook_json']).read()) Line 62: Line 63: Line 64: def write_json(data): -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Liron Ar has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3529: se.SpmFenceError(spUUID=%s, lastOwner=%s, lastLver=%s % Line 3530: (spUUID, lastOwner, lastLver))) Line 3531: pool = self.getPool(spUUID) Line 3532: if isinstance(pool.getBackend(), StoragePoolDiskBackend): Line 3533: pool.getBackend().invalidateMetadata() already wrote about that in the commit message - but just so reviewers will notice - nicer way might be to add it to the Storage pool backend interface and implement it for all the interface implementations and add invalidateMetadata() method in sp.py that'll refer there so we could leave the code here as is - i don't mind to implement either of the soltions, just let me know what you prefer. Line 3534: vars.task.getExclusiveLock(STORAGE, spUUID) Line 3535: pool.forceFreeSpm() Line 3536: return dict(spm_st=self._getSpmStatusInfo(pool)) Line 3537: -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Nir Soffer has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Code-Review+1 Ugly, but good enough for temporary bug fix. -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Federico Simoncelli has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3531: pool = self.getPool(spUUID) Line 3532: if isinstance(pool.getBackend(), StoragePoolDiskBackend): Line 3533: pool.getBackend().invalidateMetadata() Line 3534: vars.task.getExclusiveLock(STORAGE, spUUID) Line 3535: pool.forceFreeSpm() Also forceFreeSpm is also relevant only for StoragePoolDiskBackend. Line 3536: return dict(spm_st=self._getSpmStatusInfo(pool)) Line 3537: Line 3538: @public Line 3539: def upgradeStoragePool(self, spUUID, targetDomVersion): -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
Vinzenz Feenstra has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 10: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25927/10/vdsm/hooking.py File vdsm/hooking.py: Line 56: def write_domxml(domxml): Line 57: file(os.environ['_hook_domxml'], 'w').write(domxml.toxml(encoding='utf-8')) Line 58: Line 59: Line 60: def read_json(): I have mixed feelings about adding these two methods in this change. They m True, this should be a separate patch Line 61: return json.loads(file(os.environ['_hook_json']).read()) Line 62: Line 63: Line 64: def write_json(data): -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7019/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7921/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7810/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 10: Ok, will split -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: [wip] modeling graphics as a device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: [wip] modeling graphics as a device .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7021/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7923/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7812/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/23555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59b933f4cd1e3ab562ad2ec1c237007c83f214c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7022/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7924/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7813/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: remove unused add/remove tags
Dan Kenigsberg has submitted this change and it was merged. Change subject: lvm: remove unused add/remove tags .. lvm: remove unused add/remove tags Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337 Signed-off-by: Yeela Kaplan ykap...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25013 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/lvm.py M vdsm/storage/storage_exception.py 2 files changed, 0 insertions(+), 35 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Yeela Kaplan: Verified Federico Simoncelli: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Dan Kenigsberg has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if destDom.supportsSparseness: I agree about moving the logic, but I don't think it should block /this/ pa Let me try to understand the alternative of implementing this within _create(): it means having SD.createVolume() create a volume as PREALLOCATED, but not really preallocating it with zeros? Currently we have already have it as a temporary state on the image level (until content is copied during _finalizeDestinationImage(), but do we want to extend this lie to the volume level? Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not allow empty network names (bridged nor bridgeless)
Antoni Segura Puimedon has posted comments on this change. Change subject: Do not allow empty network names (bridged nor bridgeless) .. Patch Set 1: Verified+1 Passed the functional tests (jenkins) and tried to create the no name networks: tonif2001 ~ # vdsClient -s 0 addNetwork bridge='' nics=eth2 bridged=true Empty network names are not valid tonif2001 ~ # vdsClient -s 0 addNetwork bridge='' nics=eth2 bridged=false Empty network names are not valid -- To view, visit http://gerrit.ovirt.org/26367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d1e5d9fb284eb67936daf197e3025314a29f58b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 21: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7023/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7925/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7814/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1203/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 534: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH)) Line 535: Line 536: Line 537: @memoized Line 538: def _getDefaultBondingOptions(): Actually, the nature of the bonding options is that only the 802.3ad (4) mo Additionally, the 'extra' 802.3ad options have to be examinated if they are 'options' at all. I will read up on them in the kernel documentation. Line 539: teeCmd = _TEE_BINARY.cmd Line 540: MAX_MODE = 6 Line 541: Line 542: bondName = _randomIfaceName() -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Nir Soffer has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 11: (1 comment) Nice, but the tests are modifying stuff in unsafe way now. http://gerrit.ovirt.org/#/c/25877/11/tests/samplingTests.py File tests/samplingTests.py: Line 53: with open(path, 'w') as f: Line 54: f.write(content) Line 55: # monkeypatch has no idea where our new file is but it will clean Line 56: # up the value for us Line 57: sampling.PROC_STAT_PATH = path You are effecting other tests with this change. This must be done using monkeypatching. @MonkeyPatch(samling, 'PROC_STAT_PATH', 'path/to/good/data') def testGood(self): self.assertEquals(sampling.getBootTime(), 42) And 'path/to/goo/data' contains: something btime 42 another Line 58: return sampling.getBootTime() Line 59: Line 60: def testBootTimeOk(self): Line 61: self.assertEquals(self.getFakeBootTime(self.fixture_good), -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Nir Soffer has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: Code-Review+1 Even worse, but good enough if this fix is urgent. -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7024/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1204/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Dima Kuznetsov has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/25877/11/tests/samplingTests.py File tests/samplingTests.py: Line 53: with open(path, 'w') as f: Line 54: f.write(content) Line 55: # monkeypatch has no idea where our new file is but it will clean Line 56: # up the value for us Line 57: sampling.PROC_STAT_PATH = path You are effecting other tests with this change. This must be done using mon The above @MonkeyClass takes care of this. Line 58: return sampling.getBootTime() Line 59: Line 60: def testBootTimeOk(self): Line 61: self.assertEquals(self.getFakeBootTime(self.fixture_good), -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
mooli tayer has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/25927/10/vdsm/API.py
File vdsm/API.py:
Line 1204: for s in vms['vmList']:
Line 1205: response = VM(s['vmId']).getStats()
Line 1206: if response:
Line 1207: statsList.append(response['statsList'][0])
Line 1208: statsList = hooks.after_get_all_vm_stats(statsList)
before hook?
Line 1209: return {'status': doneCode, 'statsList': statsList}
Line 1210:
Line 1211: def getStats(self):
Line 1212:
http://gerrit.ovirt.org/#/c/25927/10/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm_hooks/fakevmstats/after_get_all_vm_stats.py:
Line 73: 'used': str(used)}
Line 74:
Line 75:
Line 76: def randomizeRuntimeStats(stats):
Line 77: cpuTotal = random.random() * 100.0
Not sure if even distribution is important here,
but if it is you should use random.uniform(0,100)
instead of all the random.random() * x
Line 78: cpuUser = random.random() * cpuTotal
Line 79: stats['cpuUser'] = '%.2f' % (cpuUser)
Line 80: stats['cpuSys'] = '%.2f' % (cpuTotal - cpuUser)
Line 81: stats['memUsage'] = str(random.randint(0, 100))
Line 116: diskUsage = []
Line 117: diskUsage.append(createDiskUsage('/', 'ext4', 20 * GB))
Line 118: diskUsage.append(createDiskUsage('/boot', 'ext4', 1 * GB))
Line 119: diskUsage.append(createDiskUsage('/home', 'ext4', 50 * GB))
Line 120: for i in xrange(random.randint(0, MAX_DYNAMIC_MOUNTS)):
why max? DYNAMIC_MOUNTS?
Line 121: diskUsage.append(createDiskUsage('/mount/dynamic-%d' % i,
'ext4'))
Line 122: stats['diskUsage'] = diskUsage
Line 123:
Line 124: stats['appsList'] = APP_LIST
--
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Add an option to replace locking type 4
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/23645/7/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 256: else:
Line 257: conf = self._getCachedExtraCfg()
Line 258:
Line 259: if rw:
Line 260: conf = conf.replace(locking_type=4, locking_type=1)
It seems that you rebased on top of Towards a more (block) secure HSM which
is already providing RE_LOCKING_TYPE and setROMD/setRWMD. We probably want to
have just one way to substituting/set the locking_type.
I was wondering, instead of using string replacements wouldn't it be possible
to use something similar to the device filters? E.g.:
LVMCONF_TEMPLATE =
...
devices {
%(filters)s
}
...
global {
...
locking_type=%(lockingType)s
...
}
def _buildConfig(devList, lockingType):
flt = _buildFilter(chain(devList, USER_DEV_LIST))
conf = _current_lvmconf % {'filters': flt, 'lockingType': lockingType}
return conf.replace(\n, )
Line 261: newcmd += [--config, conf]
Line 262:
Line 263: if len(cmd) 1:
Line 264: newcmd += cmd[1:]
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] json-rpc: AMQP test reactor
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] json-rpc: AMQP test reactor .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7025/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7927/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7816/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert clientIF: rescan devices on failed hotplugDisk
Nir Soffer has posted comments on this change. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Patch Set 1: Verified+1 Verified on RHEL 6.5 - Create data center/cluster/storage domain - Create vms/start/stop/remove - Extend vg (testing getDevicesVisibility) - Hot plug/unplug disks - Switch SPM -- To view, visit http://gerrit.ovirt.org/25240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib978fada8ee82e3c6da9de9b79a66edafba4eb70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: Do not hide errors when checking device visibility
Nir Soffer has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 1: Verified+1 Verified on RHEL 6.5 - Create data center/cluster/storage domain - Create vms/start/stop/remove - Extend vg (testing getDevicesVisibility) - Hot plug/unplug disks - Switch SPM -- To view, visit http://gerrit.ovirt.org/25242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: clientIF: Rescan devices if device not found after vmHotplug...
Nir Soffer has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 1: Verified+1 Verified on RHEL 6.5 - Create data center/cluster/storage domain - Create vms/start/stop/remove - Extend vg (testing getDevicesVisibility) - Hot plug/unplug disks - Switch SPM -- To view, visit http://gerrit.ovirt.org/25243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: Check all devices visibility after multipath rescan
Nir Soffer has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 1: Verified+1 Verified on RHEL 6.5 - Create data center/cluster/storage domain - Create vms/start/stop/remove - Extend vg (testing getDevicesVisibility) - Hot plug/unplug disks - Switch SPM -- To view, visit http://gerrit.ovirt.org/25241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46ede1124f4c5f849b040b598b49ee784c540ecc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: unified pers: fix restoration when moving from ifcfg pers
Hello Douglas Schilling Landgraf, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26373
to review the following change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
unified pers: fix restoration when moving from ifcfg pers
Up until now we were only flushing the persistence of the
configurator currently set up. This had the problem that when
switching between configurators and persistence models, old
persistence remainders could be left over.
Bug-Url https://bugzilla.redhat.com/1064530
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856
Reviewed-on: http://gerrit.ovirt.org/25063
Tested-by: Douglas Schilling Landgraf dougsl...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M init/vdsmd_init_common.sh.in
M vdsm/vdsm-restore-net-config
2 files changed, 26 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/26373/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 47b147c..505072e 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -250,8 +250,8 @@
tune_system \
test_space \
test_lo \
-restore_nets \
unified_network_persistence_upgrade \
+restore_nets \
upgrade_300_nets \
;;
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index 9e90be8..4829658 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -1,6 +1,6 @@
#! /usr/bin/python
#
-# Copyright 2011-2012 Red Hat, Inc.
+# Copyright 2011-2014 Red Hat, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -18,14 +18,19 @@
#
# Refer to the README and COPYING files for full details of the license
#
-
import logging
import logging.config
-from netconf import ifcfg
from vdsm.config import config
+
+# Ifcfg persistence restoration
+from netconf import ifcfg
+
+# Unified persistence restoration
from vdsm.netconfpersistence import RunningConfig, PersistentConfig
-from configNetwork import setupNetworks, ConfiguratorClass
+from configNetwork import setupNetworks
+import pkgutil
+import netconf
def ifcfg_restoration():
@@ -38,7 +43,6 @@
Builds a setupNetworks command from the persistent configuration to set it
as running configuration.
-configurator = ConfiguratorClass()
runningConfig = RunningConfig()
removeNetworks = {}
removeBonds = {}
@@ -51,7 +55,11 @@
setupNetworks(removeNetworks, removeBonds, connectivityCheck=False,
_inRollback=True)
-configurator.flush()
+# Flush vdsm configurations left-overs from any configurator on the system
+# so that changes of configurator and persistence system are smooth.
+for configurator_cls in _get_all_configurators():
+configurator_cls().flush()
+
persistentConfig = PersistentConfig()
nets = persistentConfig.networks
bonds = persistentConfig.bonds
@@ -60,6 +68,17 @@
setupNetworks(nets, bonds, connectivityCheck=False, _inRollback=True)
+def _get_all_configurators():
+Returns the class objects of all the configurators in the netconf pkg
+prefix = netconf.__name__ + '.'
+for importer, moduleName, isPackage in pkgutil.iter_modules(
+netconf.__path__, prefix):
+__import__(moduleName, fromlist=_)
+
+for cls in netconf.Configurator.__subclasses__():
+yield cls
+
+
def restore():
if config.get('vars', 'net_persistence') == 'unified':
unified_restoration()
--
To view, visit http://gerrit.ovirt.org/26373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1205/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add boot menu support
Francesco Romani has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 3: Verified+1 Patch set 3: * rebased (needed changes, so no trivial rebase, +1/+2 lost :( ) * added explicit boolean cast to prevent a corner case, being the 'bootMenuEnable' parameter being present but falsy * verified manually using vdsClient and inspecting the XML on the logs looking for the presence of the `bootmenu` attribute * unit tests still works -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a845097294603bbb11e7941995cb1729f388109 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add boot menu support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7026/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7928/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7817/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a845097294603bbb11e7941995cb1729f388109 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add boot menu support
Francesco Romani has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 4: Verified+1 Patch set 4: * added a couple of tests to catch the corner cased mentioned in the comment of the previous patchset. No code changes, re-ticking verified. -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a845097294603bbb11e7941995cb1729f388109 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1206/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add boot menu support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7027/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7929/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7818/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a845097294603bbb11e7941995cb1729f388109 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
Ondřej Svoboda has uploaded a new change for review.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
network: Reset bonding options we did not modify to defaults (WIP)
This is an attempt to have bonds configured with exactly
the options that were requested.
The handling of mode 4 options (if they are options at all?)
is yet to be investigated. I suspect the also belong to the set
of run-time values we should not even report as bonding options.
Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M vdsm/network/models.py
1 file changed, 37 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/26374/1
diff --git a/vdsm/network/models.py b/vdsm/network/models.py
index ced0a30..a44c24c 100644
--- a/vdsm/network/models.py
+++ b/vdsm/network/models.py
@@ -190,6 +190,41 @@
def __repr__(self):
return 'Bond(%s: %r)' % (self.name, self.slaves)
+def _confOptions(self):
+return [option.split('=', 1) for option in self.options.split(' ')]
+
+def replaceCurrentOptsWithDefaults(self):
+'''
+Any active non-default value not touched by options being currently
+set is added so it is explicitly reset to its default.
+
+This is intended to make sure no other options than those we modified
+have non-default values.
+'''
+activeOpts = netinfo._getBondingOptions(self.name)
+
+defaults, defaultMode = netinfo._getDefaultBondingOptions()
+mode = (activeOpts['mode'][-1] if 'mode' in activeOpts
+else defaultMode[-1])
+defaults = defaults[mode]
+
+confOpts = dict(self._confOptions())
+
+for key in activeOpts:
+if key not in confOpts:
+logging.error('Clearing pre-existing non-default %s option'
+ ' (%s=%s)', self.name, key, activeOpts[key])
+
+if key in defaults:
+activeOpts[key] = defaults[key][-1]
+else:
+logging.error('No default value found! '
+ 'The mode is %s.', mode)
+activeOpts[key] = ''
+
+activeOpts.update(confOpts)
+return netinfo._bondOptsForIfcfg(activeOpts)
+
def configure(self, **opts):
# When the bond is up and we are not changing the configuration that
# is already applied in any way, we can skip the configuring.
@@ -203,10 +238,11 @@
frozenset(netinfo.slaves(self.name))):
return
+self.options = self.resetUnwantedOptions()
self.configurator.configureBond(self, **opts)
def areOptionsApplied(self):
-confOpts = [option.split('=', 1) for option in self.options.split(' ')]
+confOpts = self._confOpts()
activeOpts = netinfo.bondOpts(self.name,
(name for name, value in confOpts))
return all(value in activeOpts[name] for name, value in confOpts)
--
To view, visit http://gerrit.ovirt.org/26374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 23: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7028/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7930/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1207/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7029/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7931/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1208/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7030/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7932/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1209/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 2: The second run of functional tests failure is 'connectivity check' and it is an unrelated issue. -- To view, visit http://gerrit.ovirt.org/26373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Add an option to replace locking type 4
Yeela Kaplan has posted comments on this change. Change subject: lvm: Add an option to replace locking type 4 .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/23645/7/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 256: else: Line 257: conf = self._getCachedExtraCfg() Line 258: Line 259: if rw: Line 260: conf = conf.replace(locking_type=4, locking_type=1) It seems that you rebased on top of Towards a more (block) secure HSM whi Actually it is rebased on purpose on top of Edu's patch. Both are required. This is an extension in order to use locking type 1 for clustersafe commands. as for the proposed change it was considered as the solution at first, but we also obtain cached configuration from '_getCachedExtraCfg', so the best solution to avoid any misconfigurations has been moved here. Line 261: newcmd += [--config, conf] Line 262: Line 263: if len(cmd) 1: Line 264: newcmd += cmd[1:] -- To view, visit http://gerrit.ovirt.org/23645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7031/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7933/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1210/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7032/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7934/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7823/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1211/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7033/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7935/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1212/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
Ondřej Svoboda has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 6:
(2 comments)
Comments on the dictionary of defaults.
http://gerrit.ovirt.org/#/c/26374/6//COMMIT_MSG
Commit Message:
Line 6:
Line 7: network: Reset bonding options we did not modify to defaults (WIP)
Line 8:
Line 9: This is an attempt to have bonds configured with exactly
Line 10: the options that were requested.
Including blank '' options signifying defaults.
Line 11:
Line 12: The handling of mode 4 options (if they are options at all?)
Line 13: is yet to be investigated. I suspect they also belong to the set
Line 14: of run-time values we should not even report as bonding options.
http://gerrit.ovirt.org/#/c/26374/6/vdsm/network/models.py
File vdsm/network/models.py:
Line 192:
Line 193: def confOptions(self):
Line 194: return [option.split('=', 1) for option in
self.options.split(' ')]
Line 195:
Line 196: def replaceCurrentOptsWithDefaults(self):
Here we can see how clumsy the work with defaults options remembered per mode
can get.
As explained in the comments to the previous patch –
http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py – I strongly suggest
using a merged dictionary of defaults. For all modes, the options are exactly
the same. Only the mode 4 manifests has a few extra 'options' that I still have
yet to learn about.
Line 197: '''
Line 198: Any active non-default value not touched by options being
currently
Line 199: set is added so it is explicitly reset to its default.
Line 200:
--
To view, visit http://gerrit.ovirt.org/26374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7034/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7936/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1213/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
Ondřej Svoboda has posted comments on this change.
Change subject: network: Reset bonding options we did not modify to defaults
(WIP)
..
Patch Set 6:
(1 comment)
Another comment.
http://gerrit.ovirt.org/#/c/26374/6/vdsm/network/models.py
File vdsm/network/models.py:
Line 276: if name in _netinfo.bondings:
Line 277: if _netinfo.ifaceUsers(name):
Line 278: mtu = max(mtu, netinfo.getMtu(name))
Line 279:
Line 280: if options is None:
This makes it possible to pass empty, as opposed to no options:
In api.py the call to objectivize yields None for options=attrs.get('options').
I believe this is very important and we should look outside of functional tests
to make sure users can expect options to be reset to defaults.
And one more thing: in __init__() the options are set to 'mode=802.3ad
miimon=150'. I think we should actually do the same in this very case:
if options is None:
options = _netinfo.bondings[name]['cfg'].get('BONDING_OPTS')
elif not options:
options = 'mode=802.3ad miimon=150' # make this a constant
I really do not know. But, clearly, testSetupNetworksMultiMTUsOverBond fails
when run in the alphabetic order, and then again if run separately afterwards.
The problem is that some options are persisted for bond0 to ifcfg file – and
read again if this very line of code is not patched.
Line 281: options = _netinfo.bondings[name]['cfg'].get(
Line 282: 'BONDING_OPTS')
Line 283: elif name in _netinfo.bondings: # Implicit bonding.
Line 284: if _netinfo.ifaceUsers(name):
--
To view, visit http://gerrit.ovirt.org/26374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7035/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7937/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7826/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1214/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7036/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7938/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1215/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7037/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7939/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1216/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7038/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7940/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1217/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset bonding options we did not modify to defaults...
Ondřej Svoboda has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) .. Patch Set 8: This is completely misguided. VDSM must not persist “polluted” bonding options in the first place. It must check that exactly the intended options have been applied, nothing else. -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage
Federico Simoncelli has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: Code-Review+1 (1 comment) Looks ok. I am not confident enough for a +2 today yet. http://gerrit.ovirt.org/#/c/26358/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3532: if isinstance(pool.getBackend(), StoragePoolDiskBackend): Line 3533: pool.getBackend().invalidateMetadata() Line 3534: vars.task.getExclusiveLock(STORAGE, spUUID) Line 3535: pool.getBackend().forceFreeSpm() Line 3536: return dict(spm_st=self._getSpmStatusInfo(pool)) Can you double check what engine is going to do with this data? Anyway it's not relevant for the vote on this patch. Line 3537: Line 3538: @public Line 3539: def upgradeStoragePool(self, spUUID, targetDomVersion): Line 3540: targetDomVersion = int(targetDomVersion) -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7039/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1218/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Nir Soffer has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/25877/11/tests/samplingTests.py File tests/samplingTests.py: Line 53: with open(path, 'w') as f: Line 54: f.write(content) Line 55: # monkeypatch has no idea where our new file is but it will clean Line 56: # up the value for us Line 57: sampling.PROC_STAT_PATH = path The above @MonkeyClass takes care of this. Missed it, but would it be cleaner to monkey patch what you need? here you monkey patch the class with something that does not make any sense, just to get the side effect of restoring the old value, and then you modify the value in a way that looks unsafe in multiple places. Line 58: return sampling.getBootTime() Line 59: Line 60: def testBootTimeOk(self): Line 61: self.assertEquals(self.getFakeBootTime(self.fixture_good), -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
