Change in vdsm[master]: mutipath: Remove unneeded and dangerous -r parameter
Allon Mureinik has posted comments on this change. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/27242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I880ab5343df3e0030638901e188320b20570747d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Rescan also FC devices
Allon Mureinik has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/27122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7699504f9771232ee0b880f9c83a51fd5b90f40e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make new timekeeping revertable
Michal Skrivanek has posted comments on this change. Change subject: vm: make new timekeeping revertable .. Patch Set 4: how about joining this with hv_enlightenment's timer…maybe? -- To view, visit http://gerrit.ovirt.org/24443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I471be44454dcae6e73c46a473eb1eee19a5275ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add the cmd get-ca-issuer
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: add the cmd get-ca-issuer .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27651/2//COMMIT_MSG Commit Message: Line 8: Line 9: If oVirt Node is registered via oVirt Engine currently Line 10: we don't show to users which engine the node is registered. Line 11: This patch extracts the issuer field from cacert.pem to use Line 12: the CN (commonname) data in ovirt-node-plugin-vdsm. The certificates has nothing to do with the Vdsm/Engine API. They are part I agree. but since registration tool for ovirt-node was on the list of things that we plan to add, I thought that this option could be good start. this verb should be exposed only if host runs as node, therefore, to not mess with node verbs and regular hosts verbs, separate tool for registration and manage node sounds good approach to me in that case Line 13: Line 14: Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1039267 -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Dima Kuznetsov has uploaded a new change for review. Change subject: pep8: Fix indentation in supervdsmServer .. pep8: Fix indentation in supervdsmServer Fix pep8 issue in supervdsmServer and added its path to PEP8_WHITELIST to make sure don't oversee other pep8 issues in the file. Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com --- M Makefile.am M vdsm/supervdsmServer 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/27899/1 diff --git a/Makefile.am b/Makefile.am index d2ac39a..f72576c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -63,6 +63,7 @@ PEP8_WHITELIST = \ vdsm-tool/vdsm-tool \ + vdsm/supervdsmServer \ $(NULL) diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer index ffcedb8..498517b 100755 --- a/vdsm/supervdsmServer +++ b/vdsm/supervdsmServer @@ -265,8 +265,8 @@ @logDecorator def appropriateDevice(self, guid, thiefId): ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId) -rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % (guid, - DISKIMAGE_USER, DISKIMAGE_GROUP) +rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % \ +(guid, DISKIMAGE_USER, DISKIMAGE_GROUP) with open(ruleFile, w) as rf: self.log.debug(Creating rule %s: %r, ruleFile, rule) rf.write(rule) -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9037/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9178/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8249/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add more tests for graphics devices
Francesco Romani has uploaded a new change for review.
Change subject: tests: add more tests for graphics devices
..
tests: add more tests for graphics devices
this patch adds a few more sanity tests for
the graphic devices.
Change-Id: I6724ee2c5ce393272b40aa7b08bc5f864123fdc5
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/vmTests.py
1 file changed, 47 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/27901/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 53d43fe..38a3078 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1149,31 +1149,38 @@
'smp': '8', 'maxVCpus': '160',
'memSize': '1024', 'memGuaranteedSize': '512'}
-self.confDisplay = (
+self.confDisplayVnc = (
{'display': 'vnc', 'displayNetwork': 'vmDisplay'},
{'display': 'vnc', 'displayPort': '-1', 'displayNetwork':
- 'vmDisplay', 'keyboardLayout': 'en-us'},
+ 'vmDisplay', 'keyboardLayout': 'en-us'})
+self.confDisplaySpice = (
{'display': 'qxl', 'displayNetwork': 'vmDisplay'},
{'display': 'qxl', 'displayPort': '-1',
'displaySecurePort': '-1'})
-self.confDeviceGraphics = (
+self.confDeviceGraphicsVnc = (
({'type': 'graphics', 'device': 'vnc'},),
({'type': 'graphics', 'device': 'vnc', 'port': '-1',
'specParams': {
'displayNetwork': 'vmDisplay',
-'keyMap': 'en-us'}},),
+'keyMap': 'en-us'}},))
+self.confDeviceGraphicsSpice = (
({'type': 'graphics', 'device': 'spice'},),
({'type': 'graphics', 'device': 'spice', 'port': '-1',
'tlsPort': '-1', 'specParams': {
'spiceSecureChannels':
'smain,sinputs,scursor,splayback,srecord,sdisplay'}},))
+
+self.confDisplay = self.confDisplayVnc + self.confDisplaySpice
+
+self.confDeviceGraphics = (self.confDeviceGraphicsVnc +
+ self.confDeviceGraphicsSpice)
def testGraphicsDeviceLegacy(self):
for conf in self.confDisplay:
@@ -1221,3 +1228,39 @@
{'type': 'graphics', 'device': devType}]
with FakeVM(self.conf, devices) as fake:
self.assertRaises(ValueError, fake.buildConfDevices)
+
+def testGraphicsDeviceSanityLegacy(self):
+for conf in self.confDisplay:
+conf.update(self.conf)
+self.assertTrue(vm.GraphicsDevice.isSupportedDisplayType(conf))
+
+def testGraphicsDeviceSanity(self):
+for dev in self.confDeviceGraphics:
+conf = {'devices': list(dev)}
+conf.update(self.conf)
+self.assertTrue(vm.GraphicsDevice.isSupportedDisplayType(conf))
+
+def testGraphicDeviceUnsupported(self):
+conf = {'display': 'rdp'}
+conf.update(self.conf)
+self.assertFalse(vm.GraphicsDevice.isSupportedDisplayType(conf))
+
+def testHasSpiceLegacy(self):
+for conf in self.confDisplaySpice:
+conf.update(self.conf)
+with FakeVM(conf) as fake:
+self.assertTrue(fake.hasSpice)
+
+for conf in self.confDisplayVnc:
+conf.update(self.conf)
+with FakeVM(conf) as fake:
+self.assertFalse(fake.hasSpice)
+
+def testHasSpice(self):
+for dev in self.confDeviceGraphicsSpice:
+with FakeVM(self.conf, dev) as fake:
+self.assertTrue(fake.hasSpice)
+
+for dev in self.confDeviceGraphicsVnc:
+with FakeVM(self.conf, dev) as fake:
+self.assertFalse(fake.hasSpice)
--
To view, visit http://gerrit.ovirt.org/27901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6724ee2c5ce393272b40aa7b08bc5f864123fdc5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 3: removed error swalling in reviveTicket, added a note in the docstring. reorganize the patch to be more self-contained (getUnderlyingGraphicsInfo was leaning towards the next patch in the series) moved away the unrelated tests into http://gerrit.ovirt.org/#/c/27901/ -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: reorganize the graphic devices lookup
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: reorganize the graphic devices lookup .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9038/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9179/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8250/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231087647e515a1f310de45b659e512444bd0a1d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add more tests for graphics devices
Francesco Romani has posted comments on this change. Change subject: tests: add more tests for graphics devices .. Patch Set 1: Verified+1 verified by running the tests. -- To view, visit http://gerrit.ovirt.org/27901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6724ee2c5ce393272b40aa7b08bc5f864123fdc5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 32: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9039/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9180/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8251/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support headless VM
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27846/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4321: graphics = _domParseStr(
Line 4322: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \
Line 4323: childNodes[0].getElementsByTagName('graphics')[0]
Line 4324: except IndexError:
Line 4325: self.log.error('no graphics devices configured')
error swallowing is still here
Done
Line 4326: return
Line 4327: validto =
max(time.strptime(graphics.getAttribute('passwdValidTo'),
Line 4328: '%Y-%m-%dT%H:%M:%S'),
Line 4329: time.gmtime(time.time() + newlife))
--
To view, visit http://gerrit.ovirt.org/27846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 32: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9040/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9181/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8252/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/620/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: handle ticket for multiple devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: handle ticket for multiple devices .. Patch Set 33: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9041/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9182/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8253/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9042/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9183/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8254/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9043/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9184/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8255/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add more tests for graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add more tests for graphics devices .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9044/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9185/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8256/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6724ee2c5ce393272b40aa7b08bc5f864123fdc5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: get rid of _getStatsInternal
Vinzenz Feenstra has posted comments on this change. Change subject: virt: stats: get rid of _getStatsInternal .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I469759b86115d80bad62c3449fe9084d5f2e550b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values.
oVirt Jenkins CI Server has posted comments on this change. Change subject: dmidecode: Handle missing values. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9045/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9186/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8257/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add custom mount options to NFS SD
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add custom mount options to NFS SD .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9046/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9187/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8258/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd35107d14608a2e6f15feb6118b9cb33a22d05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 1: Verified+1 verified with make check-local -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 24: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add custom mount options to NFS SD
Xavi Francisco has posted comments on this change. Change subject: storage: Add custom mount options to NFS SD .. Patch Set 2: Verified+1 Changelog from p1 to p2: * Change parameter names to reduce the patch size * Simplify string concatenation -- To view, visit http://gerrit.ovirt.org/27584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd35107d14608a2e6f15feb6118b9cb33a22d05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
Yaniv Bronhaim has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Code-Review+1 in ovirt-engine those values just remain empty -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
oVirt Jenkins CI Server has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9047/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9188/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8259/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Antoni Segura Puimedon has posted comments on this change.
Change subject: pep8: Fix indentation in supervdsmServer
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27899/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 265: @logDecorator
Line 266: def appropriateDevice(self, guid, thiefId):
Line 267: ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
Line 268: rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % \
Line 269: (guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
For Python files '(' is preferred to escaping '\'. Thus, this could just be:
rule = 'SUMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % (
guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
Line 270: with open(ruleFile, w) as rf:
Line 271: self.log.debug(Creating rule %s: %r, ruleFile, rule)
Line 272: rf.write(rule)
Line 273:
--
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Read default bonding options
..
Patch Set 5: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/27680/5//COMMIT_MSG
Commit Message:
Line 12: Some sysfs entries are ignored as they are not actually
Line 13: options, e.g. 'active_slave', 'ad_partner_mac'.
Line 14:
Line 15: Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Line 16: Bug-Url: https://bugzilla.redhat.com/987813
this patch solves nothing, hence it is only
Related-To:
http://gerrit.ovirt.org/#/c/27680/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 183: el for el in optFile.read().rstrip().split(' ') if el]
Line 184: return opts
Line 185:
Line 186:
Line 187: def realBondOpts(bond, keys=None):
please keep this function module-private
Line 188:
Line 189: Returns a dictionary in the same format as bondOpts(). Values
that are not
Line 190: actually options are excluded, e.g. 'ad_num_ports' or 'slaves'.
Line 191:
Line 188:
Line 189: Returns a dictionary in the same format as bondOpts(). Values
that are not
Line 190: actually options are excluded, e.g. 'ad_num_ports' or 'slaves'.
Line 191:
Line 192: EXCLUDED = frozenset(('slaves', 'active_slave', 'mii_status',
'queue_id',
Please define this out of the function.
Line 193: 'ad_aggregator', 'ad_num_ports',
'ad_actor_key',
Line 194: 'ad_partner_key', 'ad_partner_mac'))
Line 195:
Line 196: return dict(((opt, val) for (opt, val) in bondOpts(bond,
keys).iteritems()
--
To view, visit http://gerrit.ovirt.org/27680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Dima Kuznetsov has posted comments on this change.
Change subject: pep8: Fix indentation in supervdsmServer
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27899/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 265: @logDecorator
Line 266: def appropriateDevice(self, guid, thiefId):
Line 267: ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
Line 268: rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % \
Line 269: (guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
For Python files '(' is preferred to escaping '\'. Thus, this could just be
Done
Line 270: with open(ruleFile, w) as rf:
Line 271: self.log.debug(Creating rule %s: %r, ruleFile, rule)
Line 272: rf.write(rule)
Line 273:
--
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
Francesco Romani has uploaded a new change for review. Change subject: vm: fix 'port' reporting with SSL enabled .. vm: fix 'port' reporting with SSL enabled If spice is configured with ssl enabled, the 'port' attribute may be missing. This patch fixes that. Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Bug-Url: https://bugzilla.redhat.com/1099425 Signed-off-by: Francesco Romani from...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/27924/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index ca4029a..c12f188 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -5060,7 +5060,8 @@ def _updateLegacyConf(self, dev): self.conf['display'] = 'qxl' if dev['device'] == 'spice' else 'vnc' -self.conf['displayPort'] = dev['port'] +if 'port' in dev: +self.conf['displayPort'] = dev['port'] if 'tlsPort' in dev: self.conf['displaySecurePort'] = dev['tlsPort'] -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Antoni Segura Puimedon has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
Sandro Bonazzola has posted comments on this change. Change subject: vm: fix 'port' reporting with SSL enabled .. Patch Set 1: Verified+1 Applied by hand on vdsm-4.14.1-339.gitedb07b8.fc19.x86_64. Now the VM starts and I can connect with spice plugin. -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9048/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9189/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8260/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix 'port' reporting with SSL enabled .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9049/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9190/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8261/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
Antoni Segura Puimedon has posted comments on this change. Change subject: vm: fix 'port' reporting with SSL enabled .. Patch Set 1: Code-Review+1 I missed that in the review :( -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add custom mount options to NFS SD
Nir Soffer has posted comments on this change. Change subject: storage: Add custom mount options to NFS SD .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27584/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 304: options = self.DEFAULT_OPTIONS[:] Line 305: self._timeout = timeout Line 306: self._version = version Line 307: self._retrans = retrans Line 308: self._options = extraOptions I'm not sure about .options returning extraOptions, which is not a collection of options but a string. Line 309: options.append(timeo=%d % timeout) Line 310: options.append(retrans=%d % retrans) Line 311: Line 312: if version: -- To view, visit http://gerrit.ovirt.org/27584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd35107d14608a2e6f15feb6118b9cb33a22d05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add custom mount options to NFS SD
Xavi Francisco has posted comments on this change. Change subject: storage: Add custom mount options to NFS SD .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27584/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 304: options = self.DEFAULT_OPTIONS[:] Line 305: self._timeout = timeout Line 306: self._version = version Line 307: self._retrans = retrans Line 308: self._options = extraOptions I'm not sure about .options returning extraOptions, which is not a collecti It's implemented the same way as MountConnection. What I was not entirely sure is that I just put the extra options or the whole option set (including timeo and retrans). I just decided to go with the extra options to reduce redundancy and avoid leading into confusion. Line 309: options.append(timeo=%d % timeout) Line 310: options.append(retrans=%d % retrans) Line 311: Line 312: if version: -- To view, visit http://gerrit.ovirt.org/27584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd35107d14608a2e6f15feb6118b9cb33a22d05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: http protocol detection
Nir Soffer has posted comments on this change. Change subject: http protocol detection .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27839/1/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 196: # init http handler Line 197: pass Line 198: Line 199: def detect(self, data): Line 200: return (data.startswith(POST) and data.startswith(PUT) and ? Sorry for not being clear - your condition will never match anything with and. You need something like this: (data.startswith(POST) or data.startswith(PUT) ...) and not /RPC2 in data. But this will break if /RPC2 is not the path, but included in one of the headers of the body of the message. So the above check is wrong in more then one way. If you like to implement this in Python - for xmlrpc (assuming ordering) try: method, path, version = data.split( , 2) except ValueError: return False else: return method == POST and path in (/, /RPC2) for http: try: method, rest = data.split( , 1) return method in (POST, ...) except ValueError: return False The regex way is much simpler and probably faster. Line 201: data.startswith(GET) and data.startswith(HEAD) and Line 202: data.startswith(DELETE) and data.startswith(TRANCE) and Line 203: data.startswith(OPTIONS) and not /RPC2 in data) Line 204: -- To view, visit http://gerrit.ovirt.org/27839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f899cbab4d95ebd184bf32f3ccec1f4fa0e49bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix 'port' reporting with SSL enabled .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9051/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9192/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8263/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: when boostraping lvm refresh/activate also LVs with special ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: when boostraping lvm refresh/activate also LVs with special tags .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9050/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9191/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8262/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Martin Sivák has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 19: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
Martin Sivák has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 21: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
Dan Kenigsberg has posted comments on this change. Change subject: vm: fix 'port' reporting with SSL enabled .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: fix 'port' reporting with SSL enabled .. vm: fix 'port' reporting with SSL enabled If spice is configured with ssl enabled, the 'port' attribute may be missing. This patch fixes that. The port allocation behaviour in libvirtt may be surprising. If we supply graphics autoport=yes keymap=en-us passwd=* passwdValidTo=1970-01-01T00:00:01 port=-1 tlsPort=-1 type=spice channel mode=secure name=main/ channel mode=secure name=inputs/ channel mode=secure name=cursor/ channel mode=secure name=playback/ channel mode=secure name=record/ channel mode=secure name=display/ channel mode=secure name=usbredir/ channel mode=secure name=smartcard/ listen type='address' address='127.0.0.1'/ /graphics note port=1 and tlsPort=-1 in input we will get in output graphics type='spice' tlsPort='5900' autoport='yes' listen='127.0.0.1' keymap='en-us' passwdValidTo='1970-01-01T00:00:01' listen type='address' address='127.0.0.1'/ channel name='main' mode='secure'/ channel name='display' mode='secure'/ channel name='inputs' mode='secure'/ channel name='cursor' mode='secure'/ channel name='playback' mode='secure'/ channel name='record' mode='secure'/ channel name='smartcard' mode='secure'/ channel name='usbredir' mode='secure'/ /graphics note no 'port' in output However, if we do not specify the channels in input graphics type='spice' port='-1' autoport='yes' listen='127.0.0.1' /graphics We will get 'port' in output in addition to 'tlsPort', which was expected. graphics type='spice' port='5900' tlsPort='5901' autoport='yes' listen='127.0.0.1' listen type='address' address='127.0.0.1'/ /graphics Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Bug-Url: https://bugzilla.redhat.com/1099425 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27924 Tested-by: Sandro Bonazzola sbona...@redhat.com Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix 'port' reporting with SSL enabled
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix 'port' reporting with SSL enabled .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1314/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cfab79f8f353957a43dd7f4bf908a51a5dca57 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: when boostraping lvm refresh/activate also LVs with special ...
Nir Soffer has posted comments on this change. Change subject: when boostraping lvm refresh/activate also LVs with special tags .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27880/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 660: Line 661: if activate: Line 662: log.info(Activating lvs: vg=%s lvs=%s, vg.name, activate) Line 663: try: Line 664: activateLVs(vg.name, activate) Please use the lower level _setLVAvailability with the y parameter. At this point we already know that the lvs are not active, and there is no need to check that again as done inside the public activateLVs() function. Line 665: except se.CannotActivateLogicalVolumes: Line 666: log.error(Error activating lvs: vg=%s lvs=%s, vg.name, Line 667: activate) Line 668: Line 663: try: Line 664: activateLVs(vg.name, activate) Line 665: except se.CannotActivateLogicalVolumes: Line 666: log.error(Error activating lvs: vg=%s lvs=%s, vg.name, Line 667: activate) At this point our lvm metadata cache may be out of sync with the actual lvs, and must be invalidated - like we do when deactivating lvs. _lvminfo._invalidatelvs(vg.name, deactivate) There is duplication here, that can be fix with some refactoring in later patch. Line 668: Line 669: if deactivate: Line 670: log.info(Deactivating lvs: vg=%s lvs=%s, vg.name, deactivate) Line 671: try: Line 668: Line 669: if deactivate: Line 670: log.info(Deactivating lvs: vg=%s lvs=%s, vg.name, deactivate) Line 671: try: Line 672: deactivateLVs(vg.name, deactivate) This change is not related to your change, and incorrect (see above why we use _setLVAvailability). Line 673: except se.CannotDeactivateLogicalVolumes: Line 674: log.error(Error deactivating lvs: vg=%s lvs=%s, vg.name, Line 675: deactivate) Line 676: # Some lvs are inactive now -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: when boostraping lvm refresh/activate also LVs with special ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: when boostraping lvm refresh/activate also LVs with special tags .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9052/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9193/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8264/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: when boostraping lvm refresh/activate also LVs with special ...
Nir Soffer has posted comments on this change. Change subject: when boostraping lvm refresh/activate also LVs with special tags .. Patch Set 3: Looks ok regarding activation/refresh during bootstrap. I think that more work is needed to activate lvs when host is activated - bootstrap is called only when vdsm starts. Can you test this with hosted engine installation and share the results here? I would test: - Installation - while system is running shut down vdsm, and verify that it does not touch the special lvs - Start vdsm and make sure it does refresh/activate the special lvs - Put host to maintenance - vdsm will disconnect from the storage server and the special lvs will disapper. Now activate the host again - the special lvs will be available, and should be activate. -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 2: Verified+1 verified with make check-local -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: when boostraping lvm refresh/activate also LVs with special ...
Jiří Moskovčák has posted comments on this change. Change subject: when boostraping lvm refresh/activate also LVs with special tags .. Patch Set 3: Sure thing, I'm just installing it on my hosts -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8: Fix indentation in supervdsmServer .. pep8: Fix indentation in supervdsmServer Fix pep8 issue in supervdsmServer and added its path to PEP8_WHITELIST to make sure don't oversee other pep8 issues in the file. Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27899 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M Makefile.am M vdsm/supervdsmServer 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dima Kuznetsov: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
Dan Kenigsberg has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Read default bonding options .. Patch Set 6: Changes applied. -- To view, visit http://gerrit.ovirt.org/27680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: Fix indentation in supervdsmServer
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1315/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes
Yeela Kaplan has posted comments on this change.
Change subject: Convert file metadata to use ioprocess for read/writes
..
Patch Set 6:
(3 comments)
http://gerrit.ovirt.org/#/c/27267/6/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:
Line 99: return self._iop.rename(oldpath, newpath)
Line 100: except OSError as e:
Line 101: if e.errno != errno.ENOTEMPTY:
Line 102: raise
Line 103:
Add warning in the log about how dangerous it is to rename folders.
Done
Line 104: _IOProcessFileUtils(self._iop).cleanupdir(newpath, False)
Line 105: self.mkdir(newpath)
Line 106: for fname in self.listdir(oldpath):
Line 107: src = os.path.join(oldpath, fname)
Line 115:
Line 116:
Line 117: def directReadLines(ioprocess, path):
Line 118: fileStr = ioprocess.readfile(path, direct=True)
Line 119: lines = fileStr.split('\n')
fileStr.splitlines(True)
Done
Line 120: return [l + '\n' for l in lines]
Line 121:
Line 122:
Line 123: def writeLines(ioprocess, path, lines):
Line 119: lines = fileStr.split('\n')
Line 120: return [l + '\n' for l in lines]
Line 121:
Line 122:
Line 123: def writeLines(ioprocess, path, lines):
data = ''.join(lines)
Done
Line 124: data = ''
Line 125: for l in lines:
Line 126: data += l
Line 127: return ioprocess.writefile(path, data)
--
To view, visit http://gerrit.ovirt.org/27267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86beb53885dc935ad473498208e486895eab8315
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Read default bonding options
..
Patch Set 5:
(3 comments)
http://gerrit.ovirt.org/#/c/27680/5//COMMIT_MSG
Commit Message:
Line 12: Some sysfs entries are ignored as they are not actually
Line 13: options, e.g. 'active_slave', 'ad_partner_mac'.
Line 14:
Line 15: Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Line 16: Bug-Url: https://bugzilla.redhat.com/987813
this patch solves nothing, hence it is only
Done
http://gerrit.ovirt.org/#/c/27680/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 183: el for el in optFile.read().rstrip().split(' ') if el]
Line 184: return opts
Line 185:
Line 186:
Line 187: def realBondOpts(bond, keys=None):
please keep this function module-private
Done
Line 188:
Line 189: Returns a dictionary in the same format as bondOpts(). Values
that are not
Line 190: actually options are excluded, e.g. 'ad_num_ports' or 'slaves'.
Line 191:
Line 188:
Line 189: Returns a dictionary in the same format as bondOpts(). Values
that are not
Line 190: actually options are excluded, e.g. 'ad_num_ports' or 'slaves'.
Line 191:
Line 192: EXCLUDED = frozenset(('slaves', 'active_slave', 'mii_status',
'queue_id',
Please define this out of the function.
Done
Line 193: 'ad_aggregator', 'ad_num_ports',
'ad_actor_key',
Line 194: 'ad_partner_key', 'ad_partner_mac'))
Line 195:
Line 196: return dict(((opt, val) for (opt, val) in bondOpts(bond,
keys).iteritems()
--
To view, visit http://gerrit.ovirt.org/27680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9056/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9197/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8268/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove unused remote file handler method (directWriteLines)
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove unused remote file handler method (directWriteLines) .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9057/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9198/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8269/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16be5717b492b1093a26e5a5c85cfe5a9d1b07e9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: glob.glob ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: glob.glob ioprocess implementation .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9058/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9199/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8270/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Additional oop functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Additional oop functionality .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9059/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9200/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8271/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoStats implementation using ioprocess instead of RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: repoStats implementation using ioprocess instead of RFH .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9060/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9201/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8272/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I225b8914801628c625716f58cdca19884081b4b6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert file metadata to use ioprocess for read/writes .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9061/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9202/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8273/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86beb53885dc935ad473498208e486895eab8315 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 46: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9053/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9194/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8265/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9062/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9203/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8274/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement rest of os and os.path functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Implement rest of os and os.path functionality .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9063/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9204/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8275/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add createdir, cleanupdir, simplewalk functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add createdir, cleanupdir, simplewalk functionality .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9064/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9205/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8276/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica6cb0fee5802c664548011c38e358529b155333 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change file permissions using ioprocess
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change file permissions using ioprocess .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9065/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9206/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8277/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71ebd4172e53fe0a9c530d29584603b9d2eef5c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add more tests for graphics devices
Francesco Romani has posted comments on this change. Change subject: tests: add more tests for graphics devices .. Patch Set 2: Verified+1 rebased. No dependencies with other patches, so the earlier the better. -- To view, visit http://gerrit.ovirt.org/27901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6724ee2c5ce393272b40aa7b08bc5f864123fdc5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 4: rebased and put at the end of the queue, because there is no immediate need nor request for this feature. -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Read default bonding options .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1368/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9054/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9195/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8266/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: reorganize the graphic devices lookup
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: reorganize the graphic devices lookup .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9066/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9207/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8278/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231087647e515a1f310de45b659e512444bd0a1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 33: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9068/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9209/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/621/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 33: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9067/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8279/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9070/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8282/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: fix device hooks post migration
Francesco Romani has uploaded a new change for review.
Change subject: vm: graphdev: fix device hooks post migration
..
vm: graphdev: fix device hooks post migration
the _deviceXML attribute was not regenerated on
destination VM after migrations.
Change-Id: I6643f81cc5cff1a282da607e7e5759a97b081c7a
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/27933/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index e977ff3..20936a7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5122,6 +5122,12 @@
if alias in aliasToDevice:
aliasToDevice[alias]._deviceXML = deviceXML.toxml()
+elif deviceXML.tagName == GRAPHICS_DEVICES:
+# graphics device do not have aliases, must match by type
+graphType = deviceXML.getAttribute('type')
+for devObj in self._devices[GRAPHICS_DEVICES]:
+if devObj.device == graphType:
+devObj._deviceXML = deviceXML.toxml()
def waitForMigrationDestinationPrepare(self):
Wait until paths are prepared for migration destination
--
To view, visit http://gerrit.ovirt.org/27933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6643f81cc5cff1a282da607e7e5759a97b081c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: handle ticket for multiple devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: handle ticket for multiple devices .. Patch Set 34: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9069/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8281/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: update the _devices field
Francesco Romani has uploaded a new change for review.
Change subject: vm: graphdev: update the _devices field
..
vm: graphdev: update the _devices field
this patch let the Graphic Devices instances in _devices
be updated from the fresh data from libvirt.
Change-Id: Ie6a2133742a5515dc1077cd935ad7d1e37410e44
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/27932/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 2c4ad7e..e977ff3 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4945,13 +4945,20 @@
updated = False
for gxml in graphicsXml:
graphicsType = gxml.getAttribute('type')
+port = gxml.getAttribute('port')
+tlsPort = gxml.getAttribute('tlsPort')
+
+for d in self._devices[GRAPHICS_DEVICES]:
+if d.device == graphicsType:
+d.port = port
+d.tlsPort = tlsPort
+break
for dev in self.conf['devices']:
-if dev.get('device') == graphicsType:
-port = gxml.getAttribute('port')
+if (dev.get('type') == GRAPHICS_DEVICES and
+ dev.get('device') == graphicsType):
if port:
dev['port'] = port
-tlsPort = gxml.getAttribute('tlsPort')
if tlsPort:
dev['tlsPort'] = tlsPort
if not updated:
--
To view, visit http://gerrit.ovirt.org/27932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6a2133742a5515dc1077cd935ad7d1e37410e44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 25: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8283/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add more tests for graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add more tests for graphics devices .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9072/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8284/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6724ee2c5ce393272b40aa7b08bc5f864123fdc5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset a bond's options to defaults before using it
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset a bond's options to defaults before using it .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9055/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9196/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8267/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9073/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9214/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8285/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: update the _devices field
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: graphdev: update the _devices field .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8286/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a2133742a5515dc1077cd935ad7d1e37410e44 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: fix device hooks post migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: graphdev: fix device hooks post migration .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9216/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8287/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6643f81cc5cff1a282da607e7e5759a97b081c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 19: Code-Review-1 the pep8 failure is real, please fix it. ./vdsm/virt/vm.py:4513:21: E128 continuation line under-indented for visual indent -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 47: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1370/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8288/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 47 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9220/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8291/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests
Saggi Mizrahi has posted comments on this change. Change subject: utils: Add execCmd sync mode failing stress tests .. Patch Set 2: Good job pointing the obvious. AsyncProc was never meant to be used for scale. It does a lot of things that slow it down. It was for processes that run a long time put out short messages and are accessed by a many threads. Those plans never came together but we ended up using it for all communication because of problems in python. As I said in the other patch. I don't care if the python code is good now because history tells us that it may break on any future update. This is why I said that we want to have an efficient implementation sync and simple async cases which is 99% percent of the time. We have plans to just not depend on subprocess at all and have our own efficient implementation for more operations in cpopen as we are realizing that minimizing our scope to just supporting *nix make the subprocess code much for flexible and stable. But as things stand it is currently a low priority task. If you feel it should be a higher priority task you can raise it on the mailing list. Alternatively you can implement said communicate() and send it to copen for review. My distrust for Python's standard library is due to years of working on VDSM and one test at a single point in time doesn't change my decision. It's a critical, often used code path and I feel we should be in complete control of it. -- To view, visit http://gerrit.ovirt.org/27784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9080/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9221/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8292/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Read default bonding options .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1371/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8289/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Saggi Mizrahi has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/26300/15/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 72: self.log.warn(Unrecognized protocol from %s, Line 73: socket_address) Line 74: continue Line 75: Line 76: for handler in self.handlers.values(): I think we do care about order. For example, on of the options may be the p Could be decided later. Put it as a #TBD Line 77: if handler.detect(data): Line 78: handler.handleSocket(client_socket, Line 79: socket_address) Line 80: break -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset a bond's options to defaults before using it
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset a bond's options to defaults before using it .. Patch Set 17: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1372/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9219/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8290/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Adam Litke has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 20: Code-Review-1 (1 comment) -1 only due to lack of schema documentation. http://gerrit.ovirt.org/#/c/27258/20/vdsm/API.py File vdsm/API.py: Line 709: def setCpuTuneQuota(self, quota): Line 710: v = self._cif.vmContainer.get(self._UUID) Line 711: if not v: Line 712: return errCode['noVM'] Line 713: return v.setCpuTuneQuota(quota) I don't see any updates to the schema in vdsm_api/vdsmapi-schema.json for these new APIs. Please make sure to document the commands as well as parameter and return value types. Line 714: Line 715: def setCpuTunePeriod(self, period): Line 716: v = self._cif.vmContainer.get(self._UUID) Line 717: if not v: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Read default bonding options .. Patch Set 8: Verified+1 (1 comment) The patch passes all unit tests, including a new one. The patchset as a whole passes functional tests which now always check that after changing of bonding options, no other (pre-existing) options are set. http://gerrit.ovirt.org/#/c/27680/8/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 623: Return non-empty options differing from defaults, excluding not actual or Line 624: not applicable options, e.g. 'ad_num_ports' or 'slaves'. Line 625: Line 626: opts = _realBondOpts(bond) Line 627: mode = opts['mode'][-1] if 'mode' in opts else None This function is called even before a bond exists hence the condition is necessary. 'if opts' should be enough though as 'mode' is presumed to always exist. Line 628: defaults = _getDefaultBondingOptions(mode) Line 629: Line 630: return dict(((opt, val) for (opt, val) in opts.iteritems() Line 631: if val and val != defaults.get(opt))) -- To view, visit http://gerrit.ovirt.org/27680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
Liron Ar has posted comments on this change.
Change subject: core: imageSharing - export logic to functions
..
Patch Set 3:
(7 comments)
http://gerrit.ovirt.org/#/c/26759/3/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:
Line 74:methodArgs.get(headers, {}))
Line 75:
Line 76:
Line 77: def streamDownloadImage(dstImgPath, methodArgs):
Line 78: bytes_left = streamGetSize(methodArgs)
This is not bytes_left anymore, it is totalSize.
Done
Line 79: stream = methodArgs['fileObj']
Line 80:
Line 81: cmd = [constants.EXT_DD, of=%s % dstImgPath, bs=%s %
constants.MEGAB]
Line 82: p = utils.execCmd(cmd, sudo=False, sync=False,
Line 89: p.kill()
Line 90: raise
Line 91:
Line 92:
Line 93: def _waitForProcess(p, command, failureException):
You cannot design an API for logging. We should take out the command argu
i'll stick at the moment with the StorageException here and will replace the
command with DD, in a further patch let's change it to generic errors with
matching engine patch.
Line 94: if not p.wait(WAIT_TIMEOUT):
Line 95: log.error(timeout waiting for %s , str(command))
Line 96: raise failureException()
Line 97:
Line 91:
Line 92:
Line 93: def _waitForProcess(p, command, failureException):
Line 94: if not p.wait(WAIT_TIMEOUT):
Line 95: log.error(timeout waiting for %s , str(command))
No need for string conversion
Done
Line 96: raise failureException()
Line 97:
Line 98: if p.returncode != 0:
Line 99: log.error(%s error - code %s, stderr %s,
Line 96: raise failureException()
Line 97:
Line 98: if p.returncode != 0:
Line 99: log.error(%s error - code %s, stderr %s,
Line 100: str(command), p.returncode, p.stderr.read(1000))
No need for string conversion
Done
Line 101: raise failureException()
Line 102:
Line 103:
Line 104: def _copyData(inFile, outFile, bytesLeft):
Line 100: str(command), p.returncode, p.stderr.read(1000))
Line 101: raise failureException()
Line 102:
Line 103:
Line 104: def _copyData(inFile, outFile, bytesLeft):
This is the other way around:
Done
Line 105: totalSize = bytesLeft
Line 106: while bytesLeft 0:
Line 107: to_read = min(BUFFER_SIZE, bytesLeft)
Line 108:
Line 103:
Line 104: def _copyData(inFile, outFile, bytesLeft):
Line 105: totalSize = bytesLeft
Line 106: while bytesLeft 0:
Line 107: to_read = min(BUFFER_SIZE, bytesLeft)
let's stick to one naming convetion: bytesToRead
Done
Line 108:
Line 109: try:
Line 110: data = inFile.read(to_read)
Line 111: except Exception as e:
Line 117: (totalSize - bytesLeft, totalSize)
Line 118: log.error(error)
Line 119: raise se.MiscFileReadException(error)
Line 120:
Line 121: try:
This try/except is new, it should probably be a separate patch.
if it's fine by you - let's keep it as part of this refactor if we already
moved the logic to a new function, if you don't want it here i'll move it to a
separate patch.
Line 122: outFile.write(data)
Line 123: # outFile may not be a real file object but a wrapper.
Line 124: # To ensure that we don't use more memory as the input
buffer size
Line 125: # we flush on every write.
--
To view, visit http://gerrit.ovirt.org/26759
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 48: -Code-Review -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1373/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9081/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9222/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8293/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/27258/20/vdsm/API.py File vdsm/API.py: Line 709: def setCpuTuneQuota(self, quota): Line 710: v = self._cif.vmContainer.get(self._UUID) Line 711: if not v: Line 712: return errCode['noVM'] Line 713: return v.setCpuTuneQuota(quota) I don't see any updates to the schema in vdsm_api/vdsmapi-schema.json for t Can you add a short explanation/link to what is the schema file and how it is used? 10x Line 714: Line 715: def setCpuTunePeriod(self, period): Line 716: v = self._cif.vmContainer.get(self._UUID) Line 717: if not v: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Read default bonding options
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Read default bonding options .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1374/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9223/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8294/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8109feeef02b71c1d74dc6303839c6f45175915 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
Nir Soffer has posted comments on this change. Change subject: core: imageSharing - export logic to functions .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26759/3/vdsm/storage/imageSharing.py File vdsm/storage/imageSharing.py: Line 117: (totalSize - bytesLeft, totalSize) Line 118: log.error(error) Line 119: raise se.MiscFileReadException(error) Line 120: Line 121: try: if it's fine by you - let's keep it as part of this refactor if we already I'm also would like to remove this new try expect. I think we should change this code to blow when it fails with the original exception, and handle it at a higher level if needed. This means dropping also the MiscReadException above. The only reason to raise something here is when we get partial data. From the engine point of view, it could not care less if the operation failed because the socket was disconnected, or because dd was disconnected. The user has nothing to do with this detail, and it belong in vdsm logs. In vdsm log, we would like the best detail we can get for such error, which is provided by the original exception. Since this is not an error that expected to happen a lot, not handling this situation is the best way to handle it. Line 122: outFile.write(data) Line 123: # outFile may not be a real file object but a wrapper. Line 124: # To ensure that we don't use more memory as the input buffer size Line 125: # we flush on every write. -- To view, visit http://gerrit.ovirt.org/26759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset a bond's options to defaults before using it
Ondřej Svoboda has posted comments on this change.
Change subject: network: Reset a bond's options to defaults before using it
..
Patch Set 18:
(1 comment)
http://gerrit.ovirt.org/#/c/26374/18/vdsm/network/models.py
File vdsm/network/models.py:
Line 214: options.insert(0, ('mode', defaults['mode'][-1]))
Line 215: del currentOpts['mode']
Line 216:
Line 217: for current, value in currentOpts.iteritems():
Line 218: if current not in optionsDict and current in defaults:
The second check should not be necessary.
Line 219: options.insert(0, (current, defaults[current][-1]))
Line 220: logging.debug('Clearing pre-existing %s option %s=%s',
Line 221: self.name, current, value)
Line 222:
--
To view, visit http://gerrit.ovirt.org/26374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 48:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/48/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1403:
Line 1404: self.assertBondExists(BONDING_NAME, nics[:2],
Line 1405:
bondings[BONDING_NAME].get('options'))
Line 1406:
self.assertEquals(self.vdsm_net.getBondMode(BONDING_NAME),
Line 1407: REQMODE_BROADCAST) # TODO:
redundant?
getBondMode (in tests/functional/utils.py) is made redundant by the new check
in assertBondExists.
Line 1408:
Line 1409: bondings = {BONDING_NAME: dict(remove=True)}
Line 1410: status, msg = self.vdsm_net.setupNetworks({},
bondings, {})
Line 1411:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Reset a bond's options to defaults before using it
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Reset a bond's options to defaults before using it .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1375/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9224/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8295/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
