Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
Francesco Romani has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5391e7966dd46d7b33962fb3adf2830381472247 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
Francesco Romani has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter .. Patch Set 4: Code-Review+1 (1 comment) please check debian/control for possible rebase glitch. http://gerrit.ovirt.org/#/c/31991/4/debian/control File debian/control: Line 18: python (>=2.7.3), Line 19: python-dev, Line 20: python-cpopen (>= 1.3), Line 21: python-dmidecode, Line 22: python-ethtool (>=0.8), unrelated? Line 23: python-libvirt (>= 1.2.3), Line 24: python-m2crypto, Line 25: python-netaddr, Line 26: python-nose, -- To view, visit http://gerrit.ovirt.org/31991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108e2480f5fcd6f80a209b9746c50aadcfc5c591 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: debug: Integrate manhole debugging service
Francesco Romani has posted comments on this change. Change subject: debug: Integrate manhole debugging service .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a6cdf97ddce446bea527e771eb641f969b1a532 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move general devices to vmdevices
Francesco Romani has posted comments on this change. Change subject: virt: move general devices to vmdevices .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a904346d7ef3b4f3a89e68030e44e21377b7645 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor all_devices using etree
Francesco Romani has posted comments on this change. Change subject: vdsm: refactor all_devices using etree .. Patch Set 3: Code-Review-1 (1 comment) not the right direction http://gerrit.ovirt.org/#/c/32453/3/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 496: def _domElement(etreeElement): Line 497: """ Line 498: Hack required in order to refactor functions in this module while Line 499: keeping other modules working as intended. Returns xml.dom.Element Line 500: instead of etree.Element We need a different approach here, to avoid the details of the XML library we used internally leak outside (e.g. to vm.py). This begs for deeper refactoring, let's discuss this separately. Line 501: """ Line 502: return xml.dom.minidom.parseString(etreeElement.tostring()) Line 503: Line 504: -- To view, visit http://gerrit.ovirt.org/32453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id83e7282319041bd5e6fdc0ef48eb2e1cd543841 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor has_channel using etree
Francesco Romani has posted comments on this change. Change subject: vdsm: refactor has_channel using etree .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: expose hostdev via vdsClient
Francesco Romani has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e4dd1a1ee9af0d1873a081c115289ad2e52204f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
Alon Bar-Lev has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 752:
Line 753: %post
Line 754: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
Line 755: if /usr/sbin/selinuxenabled; then
Line 756: %{_bindir}/vdsm-tool sebool-config
> In that case with and without this patch the user would fail at runtime whe
so if it is part of configure why do we need it here?
Line 757: fi
Line 758: # set the vdsm "secret" password for libvirt
Line 759: %{_bindir}/vdsm-tool set-saslpasswd
Line 760:
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
mooli tayer has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 752:
Line 753: %post
Line 754: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
Line 755: if /usr/sbin/selinuxenabled; then
Line 756: %{_bindir}/vdsm-tool sebool-config
> hmm... I also unsure about this one... what if user has it disabled now and
In that case with and without this patch the user would fail at runtime when
selinux policy is violated.
In my view the very best solution would be to make sebool a configurator, since:
1. it has a life cycle of config/unconfig and that exactly a configurator.
2. in the case you describe we can implement validate - we check if selinux
enabled and sebooleans 'off' - we fail with a 'run vdsm-tool configure --force'
error.
Line 757: fi
Line 758: # set the vdsm "secret" password for libvirt
Line 759: %{_bindir}/vdsm-tool set-saslpasswd
Line 760:
Line 820: /etc/sysctl.conf
Line 821:
Line 822: if /usr/sbin/selinuxenabled; then
Line 823: %{_bindir}/vdsm-tool sebool-unconfig
Line 824: fi
> I think you want to clean it up anyway... and ignore whatever error, as it
Right. I agree.
Line 825:
Line 826: %{_bindir}/vdsm-tool remove-saslpasswd
Line 827:
Line 828: if /sbin/initctl status libvirtd >/dev/null 2>/dev/null ; then
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Moving python_sitearch to python_sitelib
Dan Kenigsberg has posted comments on this change. Change subject: Moving python_sitearch to python_sitelib .. Patch Set 1: Code-Review-1 Let's wait with that for 3.5.1 - I don't want a Fedora ARM build to delay 3.5.0. -- To view, visit http://gerrit.ovirt.org/33738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
(3 comments)
I think we are going in the wrong direction. This patch should be simple move
of multipath code as is to vdsm-tool.
Any change in this code will be very hard to review later, because of the code
moves.
We can always improve the details later.
Regarding the backup change - it is the worst idea in this patch - mix code
move an behavior change, and the behavior change is questionable.
http://gerrit.ovirt.org/#/c/30909/13/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:
Line 101: during configuration.
Line 102: '''
Line 103: return []
Line 104:
Line 105: def _parseConf(self):
It would be nicer if the private function is at the end of the class, after the
public module configure functions.
Line 106: first = second = ''
Line 107: with open(self._MPATH_CONF) as f:
Line 108: mpathconf = [x.strip("\n") for x in f.readlines()]
Line 109: try:
Line 124: first, second = self._parseConf()
Line 125: if not os.path.exists(self._CONF_BACKUP) and \
Line 126: self._MPATH_CONF_TAG not in first:
Line 127: cmd = [constants.EXT_CP, self._MPATH_CONF,
self._CONF_BACKUP]
Line 128: rc, out, err = utils.execCmd(cmd)
If we cannot write multipath configuration file running as root, something is
very wrong in this host, and we should fail hard.
Line 129: utils.persistFile(self._CONF_BACKUP)
Line 130:
Line 131: with tempfile.NamedTemporaryFile() as f:
Line 132: f.write(self._MPATH_CONF_TEMPLATE %
Line 138:
Line 139: if rc != 0:
Line 140: raise RuntimeError("Failed to perform Multipath
config.")
Line 141: if utils.isOvirtNode():
Line 142: utils.persistFile(self._MPATH_CONF)
You don't need the ovirt node check, utils.presistFile does nothing now if we
are not on ovirt node.
Line 143:
Line 144: # Flush all unused multipath device maps
Line 145: utils.execCmd([constants.EXT_MULTIPATH, "-F"])
Line 146:
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Moving python_sitearch to python_sitelib
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33738
to review the following change.
Change subject: Moving python_sitearch to python_sitelib
..
Moving python_sitearch to python_sitelib
VDSM uses pure python code, therefore there is no need to use
specific sitearch at all while installation vdsm-python files
Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141669
Signed-off-by: Yaniv Bronhaim
Reviewed-on: http://gerrit.ovirt.org/33711
Reviewed-by: Dan Kenigsberg
---
M configure.ac
M vdsm.spec.in
2 files changed, 41 insertions(+), 41 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/33738/1
diff --git a/configure.ac b/configure.ac
index 3aae03e..9938ba1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,7 +148,7 @@
AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
AC_SUBST([vdsmrepo], ['/rhev/data-center'])
-AC_SUBST([vdsmpylibdir], ['${pyexecdir}/vdsm'])
+AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4f822e4..3e42f37 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1188,49 +1188,49 @@
%defattr(-, root, root, -)
%{_mandir}/man1/vdsm-tool.1*
%{_bindir}/vdsm-tool
-%dir %{python_sitearch}/%{vdsm_name}
-%dir %{python_sitearch}/%{vdsm_name}/tool
-%{python_sitearch}/%{vdsm_name}/__init__.py*
-%{python_sitearch}/%{vdsm_name}/compat.py*
-%{python_sitearch}/%{vdsm_name}/config.py*
-%{python_sitearch}/%{vdsm_name}/constants.py*
-%{python_sitearch}/%{vdsm_name}/define.py*
-%{python_sitearch}/%{vdsm_name}/exception.py*
-%{python_sitearch}/%{vdsm_name}/ipwrapper.py*
-%{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
-%{python_sitearch}/%{vdsm_name}/netinfo.py*
-%{python_sitearch}/%{vdsm_name}/netlink.py*
-%{python_sitearch}/%{vdsm_name}/profile.py*
-%{python_sitearch}/%{vdsm_name}/qemuimg.py*
-%{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
-%{python_sitearch}/%{vdsm_name}/netconfpersistence.py*
-%{python_sitearch}/%{vdsm_name}/sslutils.py*
-%{python_sitearch}/%{vdsm_name}/utils.py*
-%{python_sitearch}/%{vdsm_name}/vdscli.py*
-%{python_sitearch}/%{vdsm_name}/tool/__init__.py*
+%dir %{python_sitelib}/%{vdsm_name}
+%dir %{python_sitelib}/%{vdsm_name}/tool
+%{python_sitelib}/%{vdsm_name}/__init__.py*
+%{python_sitelib}/%{vdsm_name}/compat.py*
+%{python_sitelib}/%{vdsm_name}/config.py*
+%{python_sitelib}/%{vdsm_name}/constants.py*
+%{python_sitelib}/%{vdsm_name}/define.py*
+%{python_sitelib}/%{vdsm_name}/exception.py*
+%{python_sitelib}/%{vdsm_name}/ipwrapper.py*
+%{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
+%{python_sitelib}/%{vdsm_name}/netinfo.py*
+%{python_sitelib}/%{vdsm_name}/netlink.py*
+%{python_sitelib}/%{vdsm_name}/profile.py*
+%{python_sitelib}/%{vdsm_name}/qemuimg.py*
+%{python_sitelib}/%{vdsm_name}/SecureXMLRPCServer.py*
+%{python_sitelib}/%{vdsm_name}/netconfpersistence.py*
+%{python_sitelib}/%{vdsm_name}/sslutils.py*
+%{python_sitelib}/%{vdsm_name}/utils.py*
+%{python_sitelib}/%{vdsm_name}/vdscli.py*
+%{python_sitelib}/%{vdsm_name}/tool/__init__.py*
%if 0%{?with_systemd}
-%exclude %{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
+%exclude %{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py*
%else
-%{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
+%{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py*
%endif
-%{python_sitearch}/%{vdsm_name}/tool/dummybr.py*
-%{python_sitearch}/%{vdsm_name}/tool/nwfilter.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurator.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/__init__*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/configfile.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/certificates.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/libvirt.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/sanlock.py*
-%{python_sitearch}/%{vdsm_name}/tool/passwd.py*
-%{python_sitearch}/%{vdsm_name}/tool/restore_nets.py*
-%{python_sitearch}/%{vdsm_name}/tool/seboolsetup.py*
-%{python_sitearch}/%{vdsm_name}/tool/service.py*
-%{python_sitearch}/%{vdsm_name}/tool/transient.py*
-%{python_sitearch}/%{vdsm_name}/tool/unified_persistence.py*
-%{python_sitearch}/%{vdsm_name}/tool/upgrade.py*
-%{python_sitearch}/%{vdsm_name}/tool/upgrade_300_networks.py*
-%{python_sitearch}/%{vdsm_name}/tool/validate_ovirt_certs.py*
-%{python_sitearch}/%{vdsm_name}/tool/vdsm-id.py*
+%{python_sitelib}/%{vdsm_name}/tool/dummybr.py*
+%{python_sitelib}/%{vdsm_name}/tool/nwfilter.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurator.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/__init__*
+%{python_sitelib}/%{vdsm_name}/tool/conf
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/1/vdsm.spec.in
File vdsm.spec.in:
Line 823: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \
Line 824: /etc/sysctl.conf
Line 825:
Line 826: if /usr/sbin/selinuxenabled; then
Line 827: %{_bindir}/vdsm-tool sebool-unconfig
> Note sure about these indentations.
its fine
Line 828: fi
Line 829:
Line 830: %{_bindir}/vdsm-tool remove-saslpasswd
Line 831:
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: avoid swallowing errors in seboolsetup calls. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/439/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11795/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12584/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
Alon Bar-Lev has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 752:
Line 753: %post
Line 754: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
Line 755: if /usr/sbin/selinuxenabled; then
Line 756: %{_bindir}/vdsm-tool sebool-config
hmm... I also unsure about this one... what if user has it disabled now and
enable it after vdsm is installed? what error do you get?
Line 757: fi
Line 758: # set the vdsm "secret" password for libvirt
Line 759: %{_bindir}/vdsm-tool set-saslpasswd
Line 760:
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kaxmlrpc: fix ancient comment text
oVirt Jenkins CI Server has posted comments on this change. Change subject: kaxmlrpc: fix ancient comment text .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/254/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5887/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4047/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/57/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/53/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/59/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/33/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
Alon Bar-Lev has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 820: /etc/sysctl.conf
Line 821:
Line 822: if /usr/sbin/selinuxenabled; then
Line 823: %{_bindir}/vdsm-tool sebool-unconfig
Line 824: fi
I think you want to clean it up anyway... and ignore whatever error, as it was.
Line 825:
Line 826: %{_bindir}/vdsm-tool remove-saslpasswd
Line 827:
Line 828: if /sbin/initctl status libvirtd >/dev/null 2>/dev/null ; then
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: avoid swallowing errors in seboolsetup calls. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/438/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11794/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12583/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
mooli tayer has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 1:
(1 comment)
@Fedrico does this patch make sense?
Was the "|| :" also done to tackle disabled linux at
http://gerrit.ovirt.org/#/c/9840/3.
If so why was the version bumping there not enough?
http://gerrit.ovirt.org/#/c/33737/1/vdsm.spec.in
File vdsm.spec.in:
Line 823: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \
Line 824: /etc/sysctl.conf
Line 825:
Line 826: if /usr/sbin/selinuxenabled; then
Line 827: %{_bindir}/vdsm-tool sebool-unconfig
Note sure about these indentations.
if %{_bindir}/vdsm-tool sebool-unconfig is indented once for
the then clause, should it not be indented again for the if clause?
However usually '%'starting lines are not indented.
Line 828: fi
Line 829:
Line 830: %{_bindir}/vdsm-tool remove-saslpasswd
Line 831:
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/253/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5886/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4046/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/56/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/52/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/58/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/32/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
mooli tayer has posted comments on this change. Change subject: tool: avoid swallowing errors in seboolsetup calls. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33737/1//COMMIT_MSG Commit Message: Line 4: Commit: Mooli Tayer Line 5: CommitDate: 2014-10-02 18:38:09 +0300 Line 6: Line 7: tool: avoid swallowing errors in seboolsetup calls. Line 8: This obviously needs to be trimmed down. What is the allowed length for commit messages? Line 9: Previously we avoided failing when vdsm-tool sebool-unconfig or vdsm-tool sebool-unconfig failed. Line 10: This was done to cope with rhbz 883355 where disabled selinux might cause inconsistent installations. Line 11: Line 12: This patch suggests to fail installation (standalone and host deploy) when seboolsetup failes. -- To view, visit http://gerrit.ovirt.org/33737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: make _calcDiskRate a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: make _calcDiskRate a function .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11793/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1714/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12582/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f89f52309afc900a166b761e4041a371d217968 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11792/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1713/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12581/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: consolidate disk statistics
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11791/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1712/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12580/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.
mooli tayer has uploaded a new change for review.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
tool: avoid swallowing errors in seboolsetup calls.
Previously we avoided failing when vdsm-tool sebool-unconfig or vdsm-tool
sebool-unconfig failed.
This was done to cope with rhbz 883355 where disabled selinux might cause
inconsistent installations.
This patch suggests to fail installation (standalone and host deploy) when
seboolsetup failes.
This is done to cope with cases like bug 1139873 where there is a different
unknown failure and still host
deploy succeeds.
To avoid disabled selinux related problems /usr/sbin/selinuxenabled is used.
Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139873
Signed-off-by: Mooli Tayer
---
M vdsm.spec.in
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/33737/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cd1c0e4..dba122b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -112,6 +112,10 @@
%endif
%if 0%{?with_systemd}
+Requires(post): systemd
+Requires(preun): systemd
+Requires(postun): systemd
+BuildRequires: systemd
BuildRequires: systemd-units
%endif
@@ -752,7 +756,9 @@
%post
%{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
-%{_bindir}/vdsm-tool sebool-config || :
+if /usr/sbin/selinuxenabled; then
+%{_bindir}/vdsm-tool sebool-config
+fi
# set the vdsm "secret" password for libvirt
%{_bindir}/vdsm-tool set-saslpasswd
@@ -817,7 +823,9 @@
/bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \
/etc/sysctl.conf
-%{_bindir}/vdsm-tool sebool-unconfig || :
+if /usr/sbin/selinuxenabled; then
+%{_bindir}/vdsm-tool sebool-unconfig
+fi
%{_bindir}/vdsm-tool remove-saslpasswd
@@ -863,8 +871,7 @@
if ! %{_bindir}/vdsm-tool is-configured --module libvirt >/dev/null 2>&1;
then
if ! %{_bindir}/vdsm-tool configure --module libvirt --force \
->/dev/null 2>&1; then
-# fallback to vdsmd reconfigure api - This change may be removed
+s# fallback to vdsmd reconfigure api - This change may be removed
# when vdsm won't support any downgrade\upgrade to versions that
# don't include vdsm-tool configure api (vdsm <= 3.3)
for f in '/usr/lib/systemd/systemd-vdsmd' '/etc/init.d/vdsmd'; do
--
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: make _calcDiskRate a function
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: make _calcDiskRate a function
..
virt: stats: make _calcDiskRate a function
used to be a method, but never uses 'self',
so make it a function.
No changes in behaviour, except the drop of the
unused 'self'.
Change-Id: I7f89f52309afc900a166b761e4041a371d217968
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/33736/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 97f8cbe..a05dd1a 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -542,24 +542,13 @@
if (sInfo and vmDrive.name in sInfo and
eInfo and vmDrive.name in eInfo):
# will be None if sampled during recovery
-dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo,
- sampleInterval))
+dStats.update(_calcDiskRate(vmDrive, sInfo, eInfo,
+sampleInterval))
except (AttributeError, TypeError, ZeroDivisionError):
self._log.exception("Disk %s stats not available",
vmDrive.name)
stats[vmDrive.name] = dStats
-
-def _calcDiskRate(self, vmDrive, sInfo, eInfo, sampleInterval):
-return {
-'readRate': (
-(eInfo[vmDrive.name][1] -
- sInfo[vmDrive.name][1])
-/ sampleInterval),
-'writeRate': (
-(eInfo[vmDrive.name][3] -
- sInfo[vmDrive.name][3])
-/ sampleInterval)}
def _getDiskLatency(self, stats):
sInfo, eInfo, sampleInterval = self.sampleDiskLatency.getStats()
@@ -626,6 +615,18 @@
return True
+def _calcDiskRate(vmDrive, sInfo, eInfo, sampleInterval):
+return {
+'readRate': (
+(eInfo[vmDrive.name][1] -
+ sInfo[vmDrive.name][1])
+/ sampleInterval),
+'writeRate': (
+(eInfo[vmDrive.name][3] -
+ sInfo[vmDrive.name][3])
+/ sampleInterval)}
+
+
def _calcDiskLatency(vmDrive, sInfo, eInfo):
dname = vmDrive.name
--
To view, visit http://gerrit.ovirt.org/33736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f89f52309afc900a166b761e4041a371d217968
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving python_sitearch to python_sitelib
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving python_sitearch to python_sitelib .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/252/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5885/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4045/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/55/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/51/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/57/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/31/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kaxmlrpc: fix ancient comment text
Dan Kenigsberg has submitted this change and it was merged. Change subject: kaxmlrpc: fix ancient comment text .. kaxmlrpc: fix ancient comment text Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/33621 Reviewed-by: Piotr Kliczewski --- M vdsm/kaxmlrpclib.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kaxmlrpc: fix ancient comment text
Dan Kenigsberg has posted comments on this change. Change subject: kaxmlrpc: fix ancient comment text .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Dan Kenigsberg has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Dan Kenigsberg has submitted this change and it was merged.
Change subject: volume: Fix exception re-rasing
..
volume: Fix exception re-rasing
When re-raising and excepition, the correct way is:
raise
And not:
raise e
The later form create a new useless traceback, strating at the point were the
exception was re-raised:
Traceback (most recent call last):
File "raise.py", line 14, in
raise e
Exception: testing
Instead of the original traceback, showing the original call stack:
Traceback (most recent call last):
File "raise.py", line 11, in
a()
File "raise.py", line 2, in a
b()
File "raise.py", line 5, in b
c()
File "raise.py", line 8, in c
raise Exception("testing")
Exception: testing
Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605
Signed-off-by: Nir Soffer
Reviewed-on: http://gerrit.ovirt.org/33556
Reviewed-by: Yeela Kaplan
Reviewed-by: Dan Kenigsberg
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Yeela Kaplan: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving python_sitearch to python_sitelib
Dan Kenigsberg has submitted this change and it was merged. Change subject: Moving python_sitearch to python_sitelib .. Moving python_sitearch to python_sitelib VDSM uses pure python code, therefore there is no need to use specific sitearch at all while installation vdsm-python files Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141669 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/33711 Reviewed-by: Dan Kenigsberg --- M configure.ac M vdsm.spec.in 2 files changed, 47 insertions(+), 47 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Remove rsyslog requirement and leave the check of syslog fd ...
Yaniv Bronhaim has abandoned this change. Change subject: Remove rsyslog requirement and leave the check of syslog fd availability .. Abandoned regarding https://bugzilla.redhat.com/show_bug.cgi?id=1143923#c7 -- To view, visit http://gerrit.ovirt.org/33089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I997c6b92b5567b4593fdaf3c7dd33739f59ffb85 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
Martin Peřina has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 3: Verified+1 Verified in 10 fencing flow tests, reconnection after host was fenced works fine with JSONRPC and XMLRPC -- To view, visit http://gerrit.ovirt.org/33657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
Saggi Mizrahi has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving python_sitearch to python_sitelib
Yaniv Bronhaim has posted comments on this change. Change subject: Moving python_sitearch to python_sitelib .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ssl: ssl_accept blocks after reboot
Yaniv Bronhaim has submitted this change and it was merged. Change subject: ssl: ssl_accept blocks after reboot .. ssl: ssl_accept blocks after reboot When rebooting host most of the times ssl_accept blocks when there is new connection established just after socket is opened. Setting timeout on socket seems to help but when testing I noticed sometimes there is still connection blocked on ssl_accept. Bug-Url: https://bugzilla.redhat.com/1148772 Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Signed-off-by: pkliczewski Signed-off-by: Saggi Mizrahi Reviewed-on: http://gerrit.ovirt.org/33644 Reviewed-by: Oved Ourfali Reviewed-by: Yaniv Bronhaim --- M lib/vdsm/SecureXMLRPCServer.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ssl: ssl_accept blocks after reboot
Yaniv Bronhaim has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11790/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12579/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11789/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12735/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12578/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
Amador Pahim has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/31529/16/vdsm/vdsm-sysctl.conf File vdsm/vdsm-sysctl.conf: Line 7: # and iSCSI targets (BZ#1112861). The kernel parameters bellow are needed to Line 8: # accomodate this case: Line 9: # For the ARP flux problem, where the machine may respond to ARP requests Line 10: # from all Ethernet interfaces, we are setting "arp_ignore=1" and Line 11: # "arp_announce=2" > Sysctl.conf takes effect on boot, when there are no "existent devices". Done Line 12: net.ipv4.conf.default.arp_ignore = 1 -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
Dan Kenigsberg has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/31529/16/vdsm/vdsm-sysctl.conf File vdsm/vdsm-sysctl.conf: Line 7: # and iSCSI targets (BZ#1112861). The kernel parameters bellow are needed to Line 8: # accomodate this case: Line 9: # For the ARP flux problem, where the machine may respond to ARP requests Line 10: # from all Ethernet interfaces, we are setting "arp_ignore=1" and Line 11: # "arp_announce=2" > Dan, some patch sets ago we changed this from *all* to *default*. Reading n Sysctl.conf takes effect on boot, when there are no "existent devices". " default " allows to tweak params to any value (even lower than what is set here) Also, it was Tsirkin that suggested using default. So unless there's a functional bug, let's keep default. Line 12: net.ipv4.conf.default.arp_ignore = 1 -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving python_sitearch to python_sitelib
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving python_sitearch to python_sitelib .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/420/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/437/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11788/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert 'Create default multipath.conf during install'
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert 'Create default multipath.conf during install' .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/419/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/436/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11785/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12731/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12574/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/30978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2da0442bbcc5e33123c47d0a9f1e825fe47d1cf Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/418/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/435/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11784/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12573/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving python_sitearch to python_sitelib
Dan Kenigsberg has posted comments on this change. Change subject: Moving python_sitearch to python_sitelib .. Patch Set 1: Code-Review+2 looks good, but please verify by installing vdsm and running it on el6 AND el7. -- To view, visit http://gerrit.ovirt.org/33711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 1: Verified-1
unit test seems to fail when run on a clean setup
please fix on master branch by mocking the missing file
==
FAIL: testGetBondingOptions (netinfoTests.TestNetinfo)
--
Traceback (most recent call last):
File "/builddir/build/BUILD/vdsm-4.16.0/tests/testValidation.py", line 105,
in wrapper
return f(*args, **kwargs)
File "/builddir/build/BUILD/vdsm-4.16.0/tests/testValidation.py", line 134,
in wrapper
return f(*args, **kwargs)
File "/builddir/build/BUILD/vdsm-4.16.0/tests/netinfoTests.py", line 319, in
testGetBondingOptions
opt.write(INTERVAL)
File "/usr/lib64/python2.7/contextlib.py", line 35, in __exit__
self.gen.throw(type, value, traceback)
File "/builddir/build/BUILD/vdsm-4.16.0/tests/testlib.py", line 323, in
not_raises
raise test_case.failureException("Exception raised: %s" % e)
AssertionError: Exception raised: [Errno 2] No such file or directory:
'/var/lib/vdsm/bonding-defaults.json'
--
To view, visit http://gerrit.ovirt.org/33528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving python_sitearch to python_sitelib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Moving python_sitearch to python_sitelib
..
Moving python_sitearch to python_sitelib
VDSM uses pure python code, therefore there is no need to use
specific sitearch at all while installation vdsm-python files
Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141669
Signed-off-by: Yaniv Bronhaim
---
M configure.ac
M vdsm.spec.in
2 files changed, 47 insertions(+), 47 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/33711/1
diff --git a/configure.ac b/configure.ac
index e4b0c88..238e519 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,7 +148,7 @@
AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
AC_SUBST([vdsmrepo], ['/rhev/data-center'])
-AC_SUBST([vdsmpylibdir], ['${pyexecdir}/vdsm'])
+AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 58ed07c..0dcd82b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1220,55 +1220,55 @@
%defattr(-, root, root, -)
%{_mandir}/man1/vdsm-tool.1*
%{_bindir}/vdsm-tool
-%dir %{python_sitearch}/%{vdsm_name}
-%dir %{python_sitearch}/%{vdsm_name}/netlink
-%dir %{python_sitearch}/%{vdsm_name}/tool
-%{python_sitearch}/%{vdsm_name}/__init__.py*
-%{python_sitearch}/%{vdsm_name}/compat.py*
-%{python_sitearch}/%{vdsm_name}/config.py*
-%{python_sitearch}/%{vdsm_name}/constants.py*
-%{python_sitearch}/%{vdsm_name}/define.py*
-%{python_sitearch}/%{vdsm_name}/exception.py*
-%{python_sitearch}/%{vdsm_name}/ipwrapper.py*
-%{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
-%{python_sitearch}/%{vdsm_name}/netinfo.py*
-%{python_sitearch}/%{vdsm_name}/netlink/__init__.py*
-%{python_sitearch}/%{vdsm_name}/netlink/addr.py*
-%{python_sitearch}/%{vdsm_name}/netlink/link.py*
-%{python_sitearch}/%{vdsm_name}/netlink/route.py*
-%{python_sitearch}/%{vdsm_name}/profile.py*
-%{python_sitearch}/%{vdsm_name}/qemuimg.py*
-%{python_sitearch}/%{vdsm_name}/netconfpersistence.py*
-%{python_sitearch}/%{vdsm_name}/sslutils.py*
-%{python_sitearch}/%{vdsm_name}/utils.py*
-%{python_sitearch}/%{vdsm_name}/vdscli.py*
-%{python_sitearch}/%{vdsm_name}/virtsparsify.py*
-%{python_sitearch}/%{vdsm_name}/xmlrpc.py*
-%{python_sitearch}/%{vdsm_name}/tool/__init__.py*
+%dir %{python_sitelib}/%{vdsm_name}
+%dir %{python_sitelib}/%{vdsm_name}/netlink
+%dir %{python_sitelib}/%{vdsm_name}/tool
+%{python_sitelib}/%{vdsm_name}/__init__.py*
+%{python_sitelib}/%{vdsm_name}/compat.py*
+%{python_sitelib}/%{vdsm_name}/config.py*
+%{python_sitelib}/%{vdsm_name}/constants.py*
+%{python_sitelib}/%{vdsm_name}/define.py*
+%{python_sitelib}/%{vdsm_name}/exception.py*
+%{python_sitelib}/%{vdsm_name}/ipwrapper.py*
+%{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
+%{python_sitelib}/%{vdsm_name}/netinfo.py*
+%{python_sitelib}/%{vdsm_name}/netlink/__init__.py*
+%{python_sitelib}/%{vdsm_name}/netlink/addr.py*
+%{python_sitelib}/%{vdsm_name}/netlink/link.py*
+%{python_sitelib}/%{vdsm_name}/netlink/route.py*
+%{python_sitelib}/%{vdsm_name}/profile.py*
+%{python_sitelib}/%{vdsm_name}/qemuimg.py*
+%{python_sitelib}/%{vdsm_name}/netconfpersistence.py*
+%{python_sitelib}/%{vdsm_name}/sslutils.py*
+%{python_sitelib}/%{vdsm_name}/utils.py*
+%{python_sitelib}/%{vdsm_name}/vdscli.py*
+%{python_sitelib}/%{vdsm_name}/virtsparsify.py*
+%{python_sitelib}/%{vdsm_name}/xmlrpc.py*
+%{python_sitelib}/%{vdsm_name}/tool/__init__.py*
%if 0%{?with_systemd}
-%exclude %{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
+%exclude %{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py*
%else
-%{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
+%{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py*
%endif
-%{python_sitearch}/%{vdsm_name}/tool/dummybr.py*
-%{python_sitearch}/%{vdsm_name}/tool/dump_bonding_defaults.py*
-%{python_sitearch}/%{vdsm_name}/tool/nwfilter.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurator.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/__init__*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/configfile.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/certificates.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/libvirt.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/sanlock.py*
-%{python_sitearch}/%{vdsm_name}/tool/passwd.py*
-%{python_sitearch}/%{vdsm_name}/tool/restore_nets.py*
-%{python_sitearch}/%{vdsm_name}/tool/seboolsetup.py*
-%{python_sitearch}/%{vdsm_name}/tool/service.py*
-%{python_sitearch}/%{vdsm_name}/tool/transient.py*
-%{python_sitearch}/%{vdsm_name}/tool/unified_persistence.py*
-%{python_sitearch}/%{vdsm_name}/tool/upgrade.py*
-%{python_sitearch}/%{vdsm_name}/tool/upgr
Change in vdsm[master]: utils: Use ovirt node for persist files
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12575/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Yeela Kaplan has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Move functionality from storage.misc
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Move functionality from storage.misc .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11787/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12576/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c547e3ac2ecf19359c32f7e717ad7b098bfbca4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: expose hostdev via vdsClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11783/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12572/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e4dd1a1ee9af0d1873a081c115289ad2e52204f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: expose hostdev via vdsClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11782/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12728/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e4dd1a1ee9af0d1873a081c115289ad2e52204f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ssl: ssl_accept blocks after reboot
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 3: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 570: try:
Line 571: if (sInfo and vmDrive.name in sInfo and
Line 572:eInfo and vmDrive.name in eInfo):
Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo,
eInfo)
Line 574: except (KeyError, TypeError):
> The if block is required, we don't want to log exceptions when vmDrive.name
These were meant if the "if" could be dropped, wasn't aware of the logging
issue so ignore
Line 575: self._log.exception("Disk %s latency not available",
Line 576: vmDrive.name)
Line 577:
Line 578: stats[vmDrive.name].update(dStats)
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12570/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 12: Code-Review+1
(1 comment)
my comment there although its as previous implementation in multipath.py. i
prefer to see the rc checked
http://gerrit.ovirt.org/#/c/30909/12/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:
Line 141: if utils.isOvirtNode():
Line 142: utils.persistFile(self._MPATH_CONF)
Line 143:
Line 144: # Flush all unused multipath device maps
Line 145: utils.execCmd([constants.EXT_MULTIPATH, "-F"])
don't you want to check the return value ?
Line 146:
Line 147: rc = service.service_reload("multipathd")
Line 148: if rc != 0:
Line 149: status = service.service_status("multipathd", False)
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 1: please get douglas ack on it -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Remove noisy log message from CPU metadata collector
Martin Sivák has restored this change. Change subject: Remove noisy log message from CPU metadata collector .. Restored This is still needed. -- To view, visit http://gerrit.ovirt.org/30079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ic186c68bf378e9e6016a568fc2a5e59b009bac8d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
Martin Polednik has posted comments on this change. Change subject: vdsm: introduce hostdev module .. Patch Set 13: Verified+1 removed deprecated logic in tests -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 596: sData['flush_operations'])
Line 597: else (eData['flush_total_times'] -
Line 598: sData['flush_total_times']) /
Line 599: (eData['flush_operations'] -
Line 600: sData['flush_operations']))
> The repeating code here is the code to calculate the latency, which is the
neat, will do.
Line 601: return {'readLatency': str(readLatency),
Line 602: 'writeLatency': str(writeLatency),
Line 603: 'flushLatency': str(flushLatency)}
Line 604:
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Log the correct error when creating a volume fails
Nir Soffer has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33301/1//COMMIT_MSG Commit Message: Line 11: confused and wasted many developers hours. Now we log the exception Line 12: value instead. Line 13: Line 14: Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Line 15: Relates-To: https://bugzilla.redhat.com/1142710 > Lets use https://bugzilla.redhat.com/1143830 to track this. Done -- To view, visit http://gerrit.ovirt.org/33301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12569/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
Dima Kuznetsov has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 570: try:
Line 571: if (sInfo and vmDrive.name in sInfo and
Line 572:eInfo and vmDrive.name in eInfo):
Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo,
eInfo)
Line 574: except (KeyError, TypeError):
> Have you thought of adding AttributeError, NameError and removing if block
The if block is required, we don't want to log exceptions when vmDrive.name is
not in sInfo or eInfo.
Why do we need to handle AttributeError or NameError?
Line 575: self._log.exception("Disk %s latency not available",
Line 576: vmDrive.name)
Line 577:
Line 578: stats[vmDrive.name].update(dStats)
Line 596: sData['flush_operations'])
Line 597: else (eData['flush_total_times'] -
Line 598: sData['flush_total_times']) /
Line 599: (eData['flush_operations'] -
Line 600: sData['flush_operations']))
> I'd consider iterating over some composed data structure in order to reduce
The repeating code here is the code to calculate the latency, which is the same
for all types. So lets have a function that repeat this code once:
Something like:
def compute_latency(ltype, edata, sdata):
ops = ltype + '_operations'
operations = edata[ops] - sdata[ops]
if not operations
return 0
times = ltype + '_total_times'
elasped_time = edata[times] - sdata[times]
return elapsed_time / operations
I'm using edata and sdata because I don't know what they mean, please use more
descriptive names.
The client code looks like:
readLatency = compute_latency("rd", edata, sdata)
Line 601: return {'readLatency': str(readLatency),
Line 602: 'writeLatency': str(writeLatency),
Line 603: 'flushLatency': str(flushLatency)}
Line 604:
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Log the correct error when creating a volume fails
Allon Mureinik has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33301/1//COMMIT_MSG Commit Message: Line 11: confused and wasted many developers hours. Now we log the exception Line 12: value instead. Line 13: Line 14: Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Line 15: Relates-To: https://bugzilla.redhat.com/1142710 Lets use https://bugzilla.redhat.com/1143830 to track this. -- To view, visit http://gerrit.ovirt.org/33301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 7: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12568/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
Yeela Kaplan has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/31501/6/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 89: def _getIOProcessPool(clientName): Line 90: with _procPoolLock: Line 91: cleanIdleIOProcesses(clientName) Line 92: Line 93: try: > 93-109 can be written as: Done Line 94: proc = _refProcPool[clientName]() Line 95: if proc is None: Line 96: del _refProcPool[clientName] Line 97: raise KeyError -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: introduce hostdev module .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/417/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/434/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12567/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
Saggi Mizrahi has posted comments on this change.
Change subject: protocol_acceptor: Make SSL handshake asynchronous
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/33657/1/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 181: if e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK):
Line 182: raise
Line 183:
Line 184: def _accept_connection(self):
Line 185: client_socket, address = self._socket.accept()
> We still can get sslerror from accept.
No we can't. self._socket a regular tcp socket.
Line 186: if self._sslctx:
Line 187: client_socket = self._sslctx.wrapSocket(client_socket)
Line 188: client_socket.address = address
Line 189: try:
Line 186: if self._sslctx:
Line 187: client_socket = self._sslctx.wrapSocket(client_socket)
Line 188: client_socket.address = address
Line 189: try:
Line 190: client_socket.setup_ssl()
> Code related to m2c we should keep in sslutils. protocoldetector's responsi
Th whole point was to make this loop aware of the handshake process so it's
become async.
These methods are public so that implementations that need lower level access
to them can use them.
Line 191: client_socket.set_accept_state()
Line 192: except SSL.SSLError as e:
Line 193: self.log.warning("Error setting up ssl: %s", e)
Line 194: client_socket.close()
--
To view, visit http://gerrit.ovirt.org/33657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/416/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/433/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12713/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1710/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12558/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer version of selinux-policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Require newer version of selinux-policy .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/415/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/432/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12711/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12556/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie783bcccb1ab39397714fc728336fd65ee4b95a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/414/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11766/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12710/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1709/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12555/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/413/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/430/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11753/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12697/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12542/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: consolidate disk statistics
Martin Polednik has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/412/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11751/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12695/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12540/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4: Code-Review-1
(2 comments)
-1 for visibility, not critical to me
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 570: try:
Line 571: if (sInfo and vmDrive.name in sInfo and
Line 572:eInfo and vmDrive.name in eInfo):
Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo,
eInfo)
Line 574: except (KeyError, TypeError):
Have you thought of adding AttributeError, NameError and removing if block
above?
Line 575: self._log.exception("Disk %s latency not available",
Line 576: vmDrive.name)
Line 577:
Line 578: stats[vmDrive.name].update(dStats)
Line 596: sData['flush_operations'])
Line 597: else (eData['flush_total_times'] -
Line 598: sData['flush_total_times']) /
Line 599: (eData['flush_operations'] -
Line 600: sData['flush_operations']))
I'd consider iterating over some composed data structure in order to reduce the
amount of copy-pastiness in this code
latency = {}
for type in ('rd', 'wr', 'flush'):
(0 if not eData[type + '_operations']
latency[type]
Line 601: return {'readLatency': str(readLatency),
Line 602: 'writeLatency': str(writeLatency),
Line 603: 'flushLatency': str(flushLatency)}
Line 604:
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/411/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/428/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11752/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12696/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12541/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/410/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/427/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11746/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12690/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12535/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/409/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/426/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11745/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12689/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12534/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/408/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/425/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12531/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Nir Soffer has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 25: (1 comment) http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4489: return pid Line 4490: Line 4491: def _updateDomainDescriptor(self): Line 4492: domainXML = self._dom.XMLDesc(0) Line 4493: self._lastXMLDesc = DomainDescriptor(domainXML) > 'domain' is nicer and shorter, and as you said saves developer time. Will c 336721 is not related to this change, please don't squash it. Line 4494: Line 4495: def _ejectFloppy(self): Line 4496: if 'volatileFloppy' in self.conf: Line 4497: utils.rmFile(self.conf['floppy']) -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
