Change in vdsm[ovirt-3.5]: net: Force blocking DHCP when restoring networks
automat...@ovirt.org has posted comments on this change. Change subject: net: Force blocking DHCP when restoring networks .. Patch Set 5: * Update tracker::#1218637::OK * Check Bug-Url::OK * Check Public Bug::#1218637::OK, public bug * Check Product::#1218637::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1218637::OK, correct target release 3.5.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b84a82794ac97eba6d34ec9d54430e387b659 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Francesco Romani has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Code-Review+1 code and code path should be the same as master -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 3: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Refactor GlusterFSConnection class
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 1: * Update tracker::#117::OK * Check Bug-Url::OK * Check Public Bug::#117::OK, public bug * Check Product::#117::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Refactor GlusterFSConnection class
Ala Hino has uploaded a new change for review. Change subject: gluster: Refactor GlusterFSConnection class .. gluster: Refactor GlusterFSConnection class Refactor GlusterFSConnection class to delegate calls to MountConnection instead of inheriting it. Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Bug-Url: https://bugzilla.redhat.com/117 Signed-off-by: Ala Hino ah...@redhat.com --- M vdsm/storage/storageServer.py 1 file changed, 67 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/40575/1 diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py index 50fcf5c..e198846 100644 --- a/vdsm/storage/storageServer.py +++ b/vdsm/storage/storageServer.py @@ -191,14 +191,19 @@ def getLocalPathBase(cls): return cls.localPathBase -def __init__(self, spec, vfsType=None, options=): +def __init__(self, spec, vfsType=None, options=, localPath=None): self._vfsType = vfsType self._remotePath = spec self._options = options +self._localPath = localPath self._mount = mount.Mount(spec, self._getLocalPath()) def _getLocalPath(self): -return os.path.join(self.getLocalPathBase(), +localPath = self.getLocalPathBase() +if self._localPath: +localPath = self._localPath + +return os.path.join(localPath, self._remotePath.replace(_, __).replace(/, _)) @@ -254,10 +259,67 @@ return hash(type(self)) ^ hash(self._mount) -class GlusterFSConnection(MountConnection): +class GlusterFSConnection(object): -def getLocalPathBase(cls): -return os.path.join(MountConnection.getLocalPathBase(), glusterSD) +def __init__(self, spec, vfsType=glusterfs, options=): +self._vfsType = vfsType +self._remotePath = spec +self._options = options + +def connect(self): +localPath = os.path.join(MountConnection. + getLocalPathBase(), + glusterSD + ) +mountCon = MountConnection(self._remotePath, + glusterfs, + self._options, + localPath + ) +return mountCon.connect() + +def isConnected(self): +localPath = os.path.join(MountConnection. + getLocalPathBase(), + glusterSD + ) +mountCon = MountConnection(self._remotePath, + glusterfs, + self._options, + localPath + ) +return mountCon.isConnected() + +def disconnect(self): +localPath = os.path.join(MountConnection. + getLocalPathBase(), + glusterSD + ) +mountCon = MountConnection(self._remotePath, + glusterfs, + self._options, + localPath + ) +return mountCon.disconnect() + +def __eq__(self, other): +if not isinstance(other, GlusterFSConnection): +return False + +try: +return (other._vfsType == self._vfsType and +other._remotePath == self._remotePath and +other._options == self._options +) +except Exception: +return False + +def __hash__(self): +hsh = hash(type(self)) +hsh ^= hash(self._vfsType) +hsh ^= hash(self._remotePath) +hsh ^= hash(self._options) +return hsh class NFSConnection(object): -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: factor out method from unified restoration logic.
Ondřej Svoboda has posted comments on this change. Change subject: network: factor out method from unified restoration logic. .. Patch Set 1: Code-Review+1 Nice :-) -- To view, visit https://gerrit.ovirt.org/40536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecc95718ac1755799884c7b124a83238e8a5f27d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
Darshan N has uploaded a new change for review.
Change subject: gluster: Modified volumeReplaceBrickCommit verb.
..
gluster: Modified volumeReplaceBrickCommit verb.
This patch modifies volumeReplaceBrickCommit verb, this
verb was taking force as optional parameter. But in
glusterfs-3.7 this force option is made manditory in the
command. To accomodate that, removed force as optional
parameter from verb and replace brick is always executed
with force as option. The name of modified verb is
volumeReplaceBrickCommitForce.
Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14
Signed-off-by: Darshan N dnara...@redhat.com
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
6 files changed, 45 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/40587/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index c7ab5f6..72fdc02 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -163,17 +163,15 @@
status = self.s.glusterHostRemoveByUuid(hostUuid, force)
return status['status']['code'], status['status']['message']
-def do_glusterVolumeReplaceBrickCommit(self, args):
+def do_glusterVolumeReplaceBrickCommitForce(self, args):
params = self._eqSplit(args)
volumeName = params.get('volumeName', '')
existingBrick = params.get('existingBrick', '')
newBrick = params.get('newBrick', '')
-force = (params.get('force', 'no').upper() == 'YES')
-status = self.s.glusterVolumeReplaceBrickCommit(volumeName,
-existingBrick,
-newBrick,
-force)
+status = self.s.glusterVolumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
return status['status']['code'], status['status']['message']
def do_glusterVolumeRemoveBrickStart(self, args):
@@ -825,10 +823,10 @@
'gluster cluster',
'remove server from gluster cluster'
)),
- 'glusterVolumeReplaceBrickCommit': (
- serv.do_glusterVolumeReplaceBrickCommit,
+ 'glusterVolumeReplaceBrickCommitForce': (
+ serv.do_glusterVolumeReplaceBrickCommitForce,
('volumeName=volume_name existingBrick=existing_brick '
- 'newBrick=new_brick [force={yes|no}]\n\t'
+ 'newBrick=new_brick \n\t'
'volume_name is existing volume name\n\t'
'existing_brick is existing brick\n\t'
'new_brick is new brick',
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 2835876..33ed194 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -215,12 +215,11 @@
return self.svdsmProxy.glusterVolumeRebalanceStatus(volumeName)
@exportAsVerb
-def volumeReplaceBrickCommit(self, volumeName, existingBrick, newBrick,
- force=False, options=None):
-self.svdsmProxy.glusterVolumeReplaceBrickCommit(volumeName,
-existingBrick,
-newBrick,
-force)
+def volumeReplaceBrickCommitForce(self, volumeName, existingBrick,
+ newBrick, options=None):
+self.svdsmProxy.glusterVolumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
@exportAsVerb
def volumeRemoveBrickStart(self, volumeName, brickList,
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 578fc92..0a1d16f 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -164,6 +164,11 @@
return self._gluster.volumeRemoveBrickForce(volumeName, brickList,
replicaCount)
+def replaceBrickCommitForce(self, volumeName, existingBrick, newBrick):
+return self._gluster.volumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
+
def profileInfo(self, volumeName, nfs=False):
return self._gluster.volumeProfileInfo(volumeName, nfs)
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index db9b3fc..8bcb5cb 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -726,18 +726,16 @@
Change in vdsm[master]: gluster: Refactor GlusterFSConnection class
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
Omer Frenkel has posted comments on this change.
Change subject: Add support for specifying vm maximum memory
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/40547/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3582: # @serial:#optional Serial number for the VM.
Line 3583: #
Line 3584: # @numOfIoThreads:#optional The num of iothreads qemu
allocates
Line 3585: #
Line 3586: # @maxMemSize:The maximum amount of memory that can be
assigned
isn't this optional? If this is mandatory, new VDSMs will not work with old
Done
Line 3587: # to the VM in MB
Line 3588: #
Line 3589: # Since: 4.10.0
Line 3590: ##
Line 3601: '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint',
Line 3602: 'status': 'VmStatus', 'timeOffset': 'uint',
Line 3603: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 3604: 'vmType': 'VmType', '*exitCode': 'int', '*exitMessage':
'str',
Line 3605: '*serial': 'str', '*numOfIoThreads': 'uint', 'maxMemSize':
'uint'}}
if this is indeed optional, don't forget to update here as well.
Done
Line 3606:
Line 3607: ##
Line 3608: # @VmParameters:
Line 3609: #
https://gerrit.ovirt.org/#/c/40547/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 169: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 170: if 'maxMemSize' in self.conf:
Line 171: maxMemSizeKB = str(int(self.conf['maxMemSize']) * 1024)
Line 172: self.dom.appendChildWithArgs('maxMemory',
text=maxMemSizeKB,
Line 173: slots=self._getMaxVCpus())
is the usage of _getMaxVCpus() intentional?
you are right this is wrong, i will change it to be sent from the engine as well
Line 174: vcpu = self.dom.appendChildWithArgs('vcpu',
text=self._getMaxVCpus())
Line 175: vcpu.setAttrs(**{'current': self._getSmp()})
Line 176:
Line 177: self._devices = Element('devices')
--
To view, visit https://gerrit.ovirt.org/40547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 2: * Update tracker::#1216900::OK * Check Bug-Url::OK * Check Public Bug::#1216900::OK, public bug * Check Product::#1216900::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1216900::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eldan Shachar eshac...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Refactor GlusterFSConnection class
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs
..
Patch Set 18: Code-Review-1
(1 comment)
very partial review...
https://gerrit.ovirt.org/#/c/40312/18/vdsm_hooks/ovs/ovs_before_device_create.py
File vdsm_hooks/ovs/ovs_before_device_create.py:
Line 52: ovs_device(domxml)
Line 53:
Line 54: for iface in domxml.getElementsByTagName('interface'):
Line 55: source = iface.getElementsByTagName('source')[0]
Line 56: source_bridge = source.getAttribute('bridge')
Engine would never pass BRIDGE_NAME here, but the specific network it wants to
have this vnic connected to.
You should replace the source_bridge with BRIDGE_NAME, and add the vlan tag if
needed.
Line 57: if source_bridge == BRIDGE_NAME:
Line 58: virtualport = iface.createElement('virtualport')
Line 59: assert virtualport == 'openvswitch'
Line 60:
--
To view, visit https://gerrit.ovirt.org/40312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 387: def VM_getMigrationStatus_Ret(ret):
Line 388:
Line 389: Return status of the Migration, progress and downtime if available
Line 390:
Line 391: return ret
why do we need this? looks like a simple passthrough, IIRC can be avoided
Without that we didn't got the response in the Engine,
That was Piotr suggestion (offline) I will add him for review.
Line 392:
Line 393:
Line 394: def Volume_getsize_Ret(ret):
Line 395:
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
why is this needed?
There is not always progress and we had NPE when calling migrateStat verb.
I think that it was not tested...
It may be related to the schema fix
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
Line 1866: return self._migrationSourceThread.status
Line 1867: finally:
Line 1868: self._guestCpuLock.release()
Line 1869:
Line 1870: def migrateStatus(self):
Can't we just always use the new downtime_net?
Libvirt holds the downtime statistics after and clear it so its important to
fetch it only when needed.
The new key downtime_net is not cleared so I will remove that flag
Line 1871: return self._migrationSourceThread.getStat(useDowntime=True)
Line 1872:
Line 1873: def migrateCancel(self):
Line 1874: self._acquireCpuLockWithTimeout()
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Remove 3.0.0 network upgrade
Ido Barkan has uploaded a new change for review.
Change subject: net: Remove 3.0.0 network upgrade
..
net: Remove 3.0.0 network upgrade
since ovirt-3.0, VDSM uses libvirt networks (with names prefixed
vdsm-*) to store its own networks. Such networks were not defined in
older versions of VDSM, and only Linux bridges were used. ovirt-3.5
was the last version that supported the network upgrade to the new
naming scheme.
Change-Id: I917af80b37976eacaa8a5054ecaa689107512aa5
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M debian/vdsm-python.install
M init/systemd/vdsm-network.service.in
M init/sysvinit/vdsmd.init.in
M lib/vdsm/tool/Makefile.am
D lib/vdsm/tool/upgrade_300_networks.py
M vdsm-tool/vdsm-tool.1.in
M vdsm.spec.in
7 files changed, 0 insertions(+), 106 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/40568/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 25ca0bb..fc42fab 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -40,7 +40,6 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/transient.py
./usr/lib/python2.7/dist-packages/vdsm/tool/unified_persistence.py
./usr/lib/python2.7/dist-packages/vdsm/tool/upgrade.py
-./usr/lib/python2.7/dist-packages/vdsm/tool/upgrade_300_networks.py
./usr/lib/python2.7/dist-packages/vdsm/tool/validate_ovirt_certs.py
./usr/lib/python2.7/dist-packages/vdsm/tool/vdsm-id.py
./usr/lib/python2.7/dist-packages/vdsm/udevadm.py
diff --git a/init/systemd/vdsm-network.service.in
b/init/systemd/vdsm-network.service.in
index 9680f06..722a2b4 100644
--- a/init/systemd/vdsm-network.service.in
+++ b/init/systemd/vdsm-network.service.in
@@ -8,7 +8,6 @@
Type=oneshot
EnvironmentFile=-/etc/sysconfig/vdsm
ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append
--logfile=@VDSMLOGDIR@/upgrade.log upgrade-unified-persistence
-ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append
--logfile=@VDSMLOGDIR@/upgrade.log upgrade-3.0.0-networks
ExecStart=@BINDIR@/vdsm-tool restore-nets
KillMode=process
RemainAfterExit=yes
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 6edd89f..046568a 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -151,11 +151,6 @@
$VDSM_TOOL ${UPGRADE_LOGGING_PARAMS} upgrade-unified-persistence
}
-upgrade_300_nets(){
-echo 'Upgrading to v3.x networking if needed'
-$VDSM_TOOL ${UPGRADE_LOGGING_PARAMS} upgrade-3.0.0-networks
-}
-
start() {
test_already_running return 0
@@ -172,8 +167,6 @@
unified_network_persistence_upgrade || return 1
restore_nets || return 1
-upgrade_300_nets || return 1
-
echo $Starting up vdsm daemon:
DAEMON_COREFILE_LIMIT=unlimited NICELEVEL=${NICE_LOWEST} daemon \
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index d704bbc..065192f 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -45,7 +45,6 @@
transient.py \
unified_persistence.py \
upgrade.py \
- upgrade_300_networks.py \
vdsm-id.py \
$(NULL)
diff --git a/lib/vdsm/tool/upgrade_300_networks.py
b/lib/vdsm/tool/upgrade_300_networks.py
deleted file mode 100644
index 819aa90..000
--- a/lib/vdsm/tool/upgrade_300_networks.py
+++ /dev/null
@@ -1,88 +0,0 @@
-#
-# Copyright 2011-2014 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# Refer to the README and COPYING files for full details of the license
-#
-
-import logging
-import sys
-
-from vdsm import netinfo
-from vdsm.constants import LEGACY_MANAGEMENT_NETWORKS
-from vdsm.tool import expose
-from vdsm.tool.upgrade import apply_upgrade
-
-sys.path.append(/usr/share/vdsm)
-from network.configurators import ifcfg
-
-UPGRADE_NAME = 'upgrade-3.0.0-networks'
-
-
-def isNeeded(networks, bridges):
-def managementNetwork():
-return any(net in networks for net in LEGACY_MANAGEMENT_NETWORKS)
-
-def managementBridge():
-return any(net in bridges for net in LEGACY_MANAGEMENT_NETWORKS)
-
-return not managementNetwork() and managementBridge()
-
-
-def run(networks, bridges):
-configWriter = ifcfg.ConfigWriter()
-
-# Create a network for every bridge that doesn't have one
-for bridge in bridges:
-
Change in vdsm[master]: gluster: New verb to mount update fstab for meta-volume
Darshan N has posted comments on this change. Change subject: gluster: New verb to mount update fstab for meta-volume .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Remove 3.0.0 network upgrade
automat...@ovirt.org has posted comments on this change. Change subject: net: Remove 3.0.0 network upgrade .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I917af80b37976eacaa8a5054ecaa689107512aa5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el65 support for libnl binding
Ido Barkan has uploaded a new change for review.
Change subject: net: remove el65 support for libnl binding
..
net: remove el65 support for libnl binding
Since 3.6 does not support el6 this commits reverts 2 other commits:
02ab984 vdsm: Fix memory leak in netlink/link.py
66aa7d8 libnl: workaround for _rtnl_link_get_kernel on el6
The workaround is no longer needed hence also the fix for the memory
leak it created.
Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M lib/vdsm/netlink/link.py
1 file changed, 21 insertions(+), 52 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/40571/1
diff --git a/lib/vdsm/netlink/link.py b/lib/vdsm/netlink/link.py
index 605da6e..1797902 100644
--- a/lib/vdsm/netlink/link.py
+++ b/lib/vdsm/netlink/link.py
@@ -16,7 +16,6 @@
#
# Refer to the README and COPYING files for full details of the license
#
-from contextlib import contextmanager
from ctypes import (CFUNCTYPE, byref, c_char, c_char_p, c_int, c_void_p,
c_size_t, sizeof)
from functools import partial
@@ -25,19 +24,18 @@
from . import _cache_manager, _nl_cache_get_first, _nl_cache_get_next
from . import _char_proto, _int_char_proto, _int_proto, _void_proto
-from . import LIBNL_ROUTE, _nl_geterror, _pool, _none_proto
+from . import LIBNL_ROUTE, _nl_geterror, _pool
from . import _addr_to_str, CHARBUFFSIZE
def get_link(name):
Returns the information dictionary of the name specified link.
with _pool.socket() as sock:
-with _get_link(name=name, sock=sock) as link:
-if not link:
-raise IOError(errno.ENODEV, '%s is not present in the system' %
- name)
-link_info = _link_info(link)
-return link_info
+link = _get_link(name=name, sock=sock)
+if not link:
+raise IOError(errno.ENODEV, '%s is not present in the system' %
+ name)
+return _link_info(link)
def iter_links():
@@ -97,12 +95,11 @@
name = (c_char * CHARBUFFSIZE)()
if cache is None:
-with _get_link(index=link_index) as link:
-if link is None:
-raise IOError(errno.ENODEV, 'Dev with index %s is not present '
-'in the system' % link_index)
-name = _rtnl_link_get_name(link)
-return name
+link = _get_link(index=link_index)
+if link is None:
+raise IOError(errno.ENODEV, 'Dev with index %s is not present in '
+'the system' % link_index)
+return _rtnl_link_get_name(link)
else:
return _rtnl_link_i2name(cache, link_index, name, sizeof(name))
@@ -146,52 +143,25 @@
return -1
-# workaround for el6
-def _rtnl_link_get_kernel_workaround(sock, name):
-with _nl_link_cache(sock) as cache:
-return _rtnl_link_get_by_name(cache, name)
-
-
-@contextmanager
def _get_link(name=None, index=0, sock=None):
If defined both name and index, index is primary
# libnl/incluede/netlink/errno.h
-NLE_INVAL = 7
NLE_NODEV = 31
-NLE_OPNOTSUPP = 10
-NLE_SUCCESS = 0
if name is None and index == 0:
raise ValueError('Must specify either a name or an index')
link = c_void_p()
-
-# related to workaroud for el6
-ref_count = False
-
-try:
-if sock is None:
-with _pool.socket() as sock:
-err = _rtnl_link_get_kernel(sock, index, name, byref(link))
-if -err in (NLE_INVAL, NLE_OPNOTSUPP) and index == 0:
-link = _rtnl_link_get_kernel_workaround(sock, name)
-ref_count = True
-err = NLE_SUCCESS
-else:
+if sock is None:
+with _pool.socket() as sock:
err = _rtnl_link_get_kernel(sock, index, name, byref(link))
-if -err in (NLE_INVAL, NLE_OPNOTSUPP) and index == 0:
-link = _rtnl_link_get_kernel_workaround(sock, name)
-ref_count = True
-err = NLE_SUCCESS
-if err:
-if -err == NLE_NODEV:
-link = None
-else:
-raise IOError(-err, _nl_geterror())
-yield link
-finally:
-if ref_count:
-_rtnl_link_put(link)
-
+else:
+err = _rtnl_link_get_kernel(sock, index, name, byref(link))
+if err:
+if -err == NLE_NODEV:
+link = None
+else:
+raise IOError(-err, _nl_geterror())
+return link
_nl_link_cache = partial(_cache_manager, _rtnl_link_alloc_cache)
@@ -210,4 +180,3 @@
'rtnl_link_i2name', LIBNL_ROUTE))
_rtnl_link_operstate2str = _int_char_proto(('rtnl_link_operstate2str',
LIBNL_ROUTE))
-_rtnl_link_put =
Change in vdsm[master]: gluster: New verb to mount update fstab for meta-volume
automat...@ovirt.org has posted comments on this change. Change subject: gluster: New verb to mount update fstab for meta-volume .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Remove 3.0.0 network upgrade
Ido Barkan has posted comments on this change. Change subject: net: Remove 3.0.0 network upgrade .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I917af80b37976eacaa8a5054ecaa689107512aa5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el65 support for libnl binding
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el65 support for libnl binding .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el65 support for libnl binding
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el65 support for libnl binding .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
(3 comments)
a few questions inside
https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 387: def VM_getMigrationStatus_Ret(ret):
Line 388:
Line 389: Return status of the Migration, progress and downtime if available
Line 390:
Line 391: return ret
why do we need this? looks like a simple passthrough, IIRC can be avoided
Line 392:
Line 393:
Line 394: def Volume_getsize_Ret(ret):
Line 395:
https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1717: 'network': {},
Line 1718: 'disks': {}}
Line 1719: if 'pauseCode' in self.conf:
Line 1720: stats['pauseCode'] = self.conf['pauseCode']
Line 1721: if self.isMigrating() and
self.migrateStatus().has_key('progress'):
why is this needed?
Line 1722: stats['migrationProgress'] =
self.migrateStatus()['progress']
Line 1723:
Line 1724: decStats = {}
Line 1725: try:
Line 1866: return self._migrationSourceThread.status
Line 1867: finally:
Line 1868: self._guestCpuLock.release()
Line 1869:
Line 1870: def migrateStatus(self):
Can't we just always use the new downtime_net?
Line 1871: return self._migrationSourceThread.getStat(useDowntime=True)
Line 1872:
Line 1873: def migrateCancel(self):
Line 1874: self._acquireCpuLockWithTimeout()
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode
Ido Barkan has uploaded a new change for review.
Change subject: Teach utils.rmFile to handle ovirtNode
..
Teach utils.rmFile to handle ovirtNode
We need to handle files in other places in vdsm so moving it down
the file hierarchy.
Change-Id: I080c4f34f8962ac5589f0a2c54f26e808d65ec33
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M lib/vdsm/utils.py
M vdsm/network/configurators/ifcfg.py
2 files changed, 24 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/40573/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 4856cf9..520542b 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -135,6 +135,26 @@
If the file doesn't exist it's assumed that it was already removed.
+if isOvirtNode():
+try:
+_rmFileInNode(fileToRemove)
+except OSError as e:
+if e.errno == errno.ENOENT:
+logging.warning(File: %s already removed, fileToRemove)
+else:
+logging.error(Removing file: %s failed, fileToRemove,
+ exc_info=True)
+raise
+else:
+_rmFile(fileToRemove)
+
+
+def _rmFileInNode(fileToRemove):
+unpersists and shreds the file
+node_fs.Config().delete(fileToRemove)
+
+
+def _rmFile(fileToRemove):
try:
os.unlink(fileToRemove)
except OSError as e:
@@ -1088,6 +1108,9 @@
bool(glob.glob('/etc/ovirt-node-*-release')))
+if isOvirtNode():
+from ovirt.node.utils import fs as node_fs
+
# Copied from
# http://docs.python.org/2.6/library/itertools.html?highlight=grouper#recipes
def grouper(iterable, n, fillvalue=None):
diff --git a/vdsm/network/configurators/ifcfg.py
b/vdsm/network/configurators/ifcfg.py
index 6d35c0a..cdb22c8 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -280,11 +280,7 @@
@staticmethod
def _removeFile(filename):
-Remove file (directly or using oVirt node's library)
-if utils.isOvirtNode():
-node_fs.Config().delete(filename) # unpersists and shreds the file
-else:
-utils.rmFile(filename)
+utils.rmFile(filename)
logging.debug(Removed file %s, filename)
def createLibvirtNetwork(self, network, bridged=True, iface=None,
--
To view, visit https://gerrit.ovirt.org/40573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I080c4f34f8962ac5589f0a2c54f26e808d65ec33
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode
automat...@ovirt.org has posted comments on this change. Change subject: Teach utils.rmFile to handle ovirtNode .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I080c4f34f8962ac5589f0a2c54f26e808d65ec33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el65 support for libnl binding
Ido Barkan has posted comments on this change. Change subject: net: remove el65 support for libnl binding .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: wait for udev after configuring SRIOV
automat...@ovirt.org has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: wait for udev after configuring SRIOV
Nir Soffer has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: factor out _find_bonds_with_available_nics
Ondřej Svoboda has posted comments on this change. Change subject: net: factor out _find_bonds_with_available_nics .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09dc7278607b3f908a82ec1c523052c79e6269c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: clearer log for unavailable bonds
Ondřej Svoboda has posted comments on this change. Change subject: net: clearer log for unavailable bonds .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Fabian Deutsch has uploaded a new change for review. Change subject: network: Recognize macvlans as fake devices .. network: Recognize macvlans as fake devices macvlans are yet another type of virtual NICs. This patch allows vdsm to accept macvlan devices as fake NICs. Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Signed-off-by: Fabian Deutsch fabi...@fedoraproject.org --- M lib/vdsm/ipwrapper.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/40608/1 diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py index 2b7d455..8efc393 100644 --- a/lib/vdsm/ipwrapper.py +++ b/lib/vdsm/ipwrapper.py @@ -212,12 +212,15 @@ def isVLAN(self): return self.type == LinkType.VLAN +def isMACVLAN(self): +return self.type == LinkType.MACVLAN + def isFakeNIC(self): Returns True iff vdsm config marks the DUMMY or VETH dev to be reported as NIC. -if self.isDUMMY() or self.isVETH(): +if self.isDUMMY() or self.isVETH() or self.isMACVLAN(): return anyFnmatch(self.name, self._fakeNics) return False -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch fabi...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Fabian Deutsch has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Anatoly Litovsky tlito...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
Ondřej Svoboda has posted comments on this change. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9da7203d319879ab754822bd5cb9f922d6080f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: factor out _find_nets_with_available_devices.
Ondřej Svoboda has posted comments on this change. Change subject: net: factor out _find_nets_with_available_devices. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e1ea8759d2c671fa27edc9b01ccc496e31dc928 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: do not try to clean running configuration
Ondřej Svoboda has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 1: Code-Review-1 (2 comments) Much clearer! Just fix the typos for me :-) https://gerrit.ovirt.org/#/c/40537/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 73: n Since you're ending with a full stop you may also want to begin with uppercase. Line 73: nn n -- To view, visit https://gerrit.ovirt.org/40537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c0062e3d0c3625311876ef740b15577bf8a16e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...
Ido Barkan has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: Code-Review+1 yes. you are right. -- To view, visit https://gerrit.ovirt.org/40478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...
automat...@ovirt.org has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: wait for udev after configuring SRIOV
automat...@ovirt.org has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: always print IPV6INIT=yes/no .. Patch Set 1: Code-Review-1 Please add a functional test, that verifies that bridges does not obtain an ipv6 address needlessly. -- To view, visit https://gerrit.ovirt.org/40610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
Yaniv Bronhaim has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39990/3/tests/sslTests.py File tests/sslTests.py: Line 369: -key, self.keyfile, Line 370: ]) Line 371: self.assertEquals(rc, 0) Line 372: Line 373: @brokentest The python-native implementation of ssl is unaware of ssl sessions, and it Done Line 374: def testSessionIsCached(self): Line 375: Line 376: Verify that SSL the session identifier is preserved when Line 377: connecting two times without stopping the server. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: exec mount in different cgroup
automat...@ovirt.org has posted comments on this change. Change subject: storage: exec mount in different cgroup .. Patch Set 2: * Update tracker::#1201355::OK -- To view, visit https://gerrit.ovirt.org/40179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd6d6076af46ec3e2bf2400afb72ad8ec3fc3dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el6 support for libnl binding
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
automat...@ovirt.org has posted comments on this change. Change subject: Memory Hotplug for vm .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Hooks for Memory Hotplug
automat...@ovirt.org has posted comments on this change. Change subject: Hooks for Memory Hotplug .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
automat...@ovirt.org has posted comments on this change. Change subject: Add support for specifying vm maximum memory .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: exec mount in different cgroup
Sandro Bonazzola has abandoned this change. Change subject: storage: exec mount in different cgroup .. Abandoned Abandoned in favor of the patch using systemd. -- To view, visit https://gerrit.ovirt.org/40179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8dd6d6076af46ec3e2bf2400afb72ad8ec3fc3dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: avoid python3-inconsistent syntax
Nir Soffer has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
automat...@ovirt.org has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
Sandro Bonazzola has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 4: Verified+1 Updated test with suggested message. Patch was rebased. I am copying verification flag. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode
Ido Barkan has abandoned this change. Change subject: Teach utils.rmFile to handle ovirtNode .. Abandoned this is not needed atm -- To view, visit https://gerrit.ovirt.org/40573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I080c4f34f8962ac5589f0a2c54f26e808d65ec33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Teach utils.rmFile to handle ovirtNode
automat...@ovirt.org has posted comments on this change. Change subject: Teach utils.rmFile to handle ovirtNode .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I080c4f34f8962ac5589f0a2c54f26e808d65ec33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: do not try to clean running configuration
Ido Barkan has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40537/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 73: nn n Done Line 73: n Since you're ending with a full stop you may also want to begin with upperc Done -- To view, visit https://gerrit.ovirt.org/40537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c0062e3d0c3625311876ef740b15577bf8a16e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no
automat...@ovirt.org has posted comments on this change. Change subject: ifcfg: always print IPV6INIT=yes/no .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no
Ondřej Svoboda has uploaded a new change for review. Change subject: ifcfg: always print IPV6INIT=yes/no .. ifcfg: always print IPV6INIT=yes/no EL6's /etc/sysconfig/network-scripts/ifup-ipv6 had a condition: [ $IPV6INIT = yes ] || exit 0 which changed to an inverted one in EL7: [[ $IPV6INIT = [nN0]* ]] exit 0 This makes IPV6INIT mandatory in ifcfg files. Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18 Signed-off-by: Ondřej Svoboda osvob...@redhat.com --- M vdsm/network/configurators/ifcfg.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/40610/1 diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py index 6d35c0a..26efd6f 100644 --- a/vdsm/network/configurators/ifcfg.py +++ b/vdsm/network/configurators/ifcfg.py @@ -583,8 +583,9 @@ if ipv4.defaultRoute is not None: cfg += 'DEFROUTE=%s\n' % _to_ifcfg_bool(ipv4.defaultRoute) cfg += 'NM_CONTROLLED=no\n' -if ipv6.address or ipv6.ipv6autoconf or ipv6.dhcpv6: -cfg += 'IPV6INIT=yes\n' +enable_ipv6 = ipv6.address or ipv6.ipv6autoconf or ipv6.dhcpv6 +cfg += 'IPV6INIT=%s\n' % _to_ifcfg_bool(enable_ipv6) +if enable_ipv6: if ipv6.address is not None: cfg += 'IPV6ADDR=%s\n' % pipes.quote(ipv6.address) if ipv6.gateway is not None: -- To view, visit https://gerrit.ovirt.org/40610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: simplify _find_nets_with_available_devices algorithm.
Ondřej Svoboda has posted comments on this change. Change subject: net: simplify _find_nets_with_available_devices algorithm. .. Patch Set 1: Code-Review+1 (1 comment) One comment (not introduced in this patch) seems wrong to me. https://gerrit.ovirt.org/#/c/40541/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 157: nics Aren't they bridge-only 'networks'? -- To view, visit https://gerrit.ovirt.org/40541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c4972c16753e391bf2691a6739b088a4cbd05e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: Ido, I don't think this patch depends on the later one. It does one job: to split ifup into two functions, both of which have their users (ones that used 'async' before and the others that did not). You may notice that I removed unused 'returns' from both _ifups. I don't want to merge this patch with the later one because it does away with 'async', that's a different task. And while at it I took the opportunity to give the two descendant functions of ifup new names that indicate they are private to ifcfg, as you suggested. -- To view, visit https://gerrit.ovirt.org/40478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Refactor GlusterFSConnection class
Nir Soffer has posted comments on this change. Change subject: gluster: Refactor GlusterFSConnection class .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/40575/3/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 166 Line 167 Line 168 Line 169 Line 170 Previously, we use to create the local path by: os.path.join(self.getLocalpathBase(), remote_path) And we customized the behavior by overriding self.getLocalpathBase(), accessing MountConnection.getLocalPathBase() We also have code to customize MountConnection.localPathBase during runtime, I don't see any need to support this. We used the term localPath instead of the more common term mountpoint. This is clumsy and more complicated than needed. We can use this instead: class MountConnection(object): ROOT = /tmp DIR = Subclass can customized by overriding DIR. Line 199 Line 200 Line 201 Line 202 Line 203 Use: path = self._remotePath.replace(_, __).replace(/, _) return os.path.join(self.ROOT, self.DIR, path) Line 200: Line 201: def _getLocalPath(self): Line 202: localPath = self.getLocalPathBase() Line 203: if self._localPath: Line 204: localPath = self._localPath Not needed Line 205: Line 206: return os.path.join(localPath, Line 207: self._remotePath.replace(_, Line 208: __).replace(/, _)) Line 258: def __hash__(self): Line 259: return hash(type(self)) ^ hash(self._mount) Line 260: Line 261: Line 262: class GlusterFSConnection(object): Generally I prefer composition over sub-classing, but in this case we don't have any behavior in the subclass, so creating an object using MountConnection is wasted effort. The only differences between MountConnection and GlusterfsConnection are - glusterSD used in the mountpoint - glusterfs used for vfsType So a better change would be: GlusterFSConnection(MountConnection): VFSTYPE = glusterfs DIR = gluserSD And change MountConnection to use this class constants - see the comments in MountConnection. The other change planed is to modify options before connecting. We can override the options property in the subclass, and return a modified self._options. Line 263: Line 264: def __init__(self, spec, vfsType=glusterfs, options=): Line 265: self._vfsType = vfsType Line 266: self._remotePath = spec -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 4: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#840114::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi d...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dudi Maroshi d...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: do not try to clean running configuration
automat...@ovirt.org has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c0062e3d0c3625311876ef740b15577bf8a16e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: factor out method from unified restoration logic.
automat...@ovirt.org has posted comments on this change. Change subject: network: factor out method from unified restoration logic. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecc95718ac1755799884c7b124a83238e8a5f27d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: factor out _find_bonds_with_available_nics
automat...@ovirt.org has posted comments on this change. Change subject: net: factor out _find_bonds_with_available_nics .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09dc7278607b3f908a82ec1c523052c79e6269c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: clearer log for unavailable bonds
automat...@ovirt.org has posted comments on this change. Change subject: net: clearer log for unavailable bonds .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: simplify _find_nets_with_available_devices algorithm.
automat...@ovirt.org has posted comments on this change. Change subject: net: simplify _find_nets_with_available_devices algorithm. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c4972c16753e391bf2691a6739b088a4cbd05e7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
automat...@ovirt.org has posted comments on this change. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9da7203d319879ab754822bd5cb9f922d6080f6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: factor out _find_nets_with_available_devices.
automat...@ovirt.org has posted comments on this change. Change subject: net: factor out _find_nets_with_available_devices. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e1ea8759d2c671fa27edc9b01ccc496e31dc928 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: always print IPV6INIT=yes/no .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: always print IPV6INIT=yes/no .. Patch Set 1: Verified+1 Even with IPV6INIT=no (which _was correctly added_ to an ifcfg file for a bridge) the bridge got a link-local IPv6 address. This is due to initscripts not actually _disabling_ IPv6 on the bridge (via a sysctl option 'disable_ipv6') before creating it (at least grepping initscript sources for 'disable_ipv6' returns nothing). I think initscripts developers encountered some bugs when doing so. The LL address is unproblematic and it's good to have it in case we want to enable DHCPv6 on the same bridge later. -- To view, visit https://gerrit.ovirt.org/40610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: fix forgotten python2-ish syntax
Yaniv Bronhaim has posted comments on this change. Change subject: python3: fix forgotten python2-ish syntax .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Fix bug when mode is not specified
Federico Simoncelli has posted comments on this change. Change subject: fileUtils: Fix bug when mode is not specified .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/36781/4/vdsm/storage/fileUtils.py File vdsm/storage/fileUtils.py: Line 145: os.makedirs(*params) Line 146: except OSError as e: Line 147: if e.errno != errno.EEXIST: Line 148: raise Line 149: statinfo = os.stat(dirPath) Do you mean to move it after the expect block? Correct. Line 150: if not stat.S_ISDIR(statinfo.st_mode): Line 151: raise OSError(errno.ENOTDIR, Not a directory %s % dirPath) Line 152: log.warning(Dir %s already exists, dirPath) Line 153: if mode is not None: -- To view, visit https://gerrit.ovirt.org/36781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I669791fb09ddd18f9b2e6320cf98839ed07aa831 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Job related actions
Nir Soffer has posted comments on this change.
Change subject: v2v: Job related actions
..
Patch Set 14:
(3 comments)
https://gerrit.ovirt.org/#/c/39361/14/client/vdsClient.py
File client/vdsClient.py:
Line 1926: return 0, 'Job started'
Line 1927:
Line 1928: def getConvertedVm(self, args):
Line 1929: if len(args) != 1:
Line 1930: raise ValueError('Wrong number of arguments')
Lets use validateArgTypes - it will complain about wrong argument count for us
instead of duplicating this logic 3 times.
Line 1931: status = self.s.getConvertedVm(args[0])
Line 1932: if status['status']['code'] == 0:
Line 1933: print(status['ovf'])
Line 1934: return status['status']['code'], status['status']['message']
https://gerrit.ovirt.org/#/c/39361/14/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3839: # @Host.getConvertedVm:
Line 3840: #
Line 3841: # Return OVF string that created via convertVmFromExternalSystem call
Line 3842: #
Line 3843: # @jobId: UUID to identify the job that created in
convertVmFromExternalSystem
In # @Host.convertExternalVm, you use jobid (lowercase). Lets be consistent
and use the same term everywhere in the same way.
convertVmFromExternalSystem - we renamed this to convertExternalVm - please
update the description.
Line 3844: #
Line 3845: # Since: 4.17.0
Line 3846: ##
Line 3847: {'command': {'class': 'Host', 'name': 'getConvertedVm'},
https://gerrit.ovirt.org/#/c/39361/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 191
Line 192
Line 193
Line 194
Line 195
Lets move all the job management helpers functions together - I think the best
place would be under the public management functions.
--
To view, visit https://gerrit.ovirt.org/39361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Nir Soffer has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 6: Federico, I believe that the next patch https://gerrit.ovirt.org/40477 is addressing your concern about non-existent hosts and more. Can you review this topic again? -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: do not try to clean running configuration
Ondřej Svoboda has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c0062e3d0c3625311876ef740b15577bf8a16e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Fix bug when mode is not specified
Nir Soffer has posted comments on this change. Change subject: fileUtils: Fix bug when mode is not specified .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/36781/4/vdsm/storage/fileUtils.py File vdsm/storage/fileUtils.py: Line 145: os.makedirs(*params) Line 146: except OSError as e: Line 147: if e.errno != errno.EEXIST: Line 148: raise Line 149: statinfo = os.stat(dirPath) Not for this patch: I don't think that all this belongs to the except block Do you mean to move it after the expect block? try: make dirs... except cannot create: raise validate existing directory Line 150: if not stat.S_ISDIR(statinfo.st_mode): Line 151: raise OSError(errno.ENOTDIR, Not a directory %s % dirPath) Line 152: log.warning(Dir %s already exists, dirPath) Line 153: if mode is not None: -- To view, visit https://gerrit.ovirt.org/36781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I669791fb09ddd18f9b2e6320cf98839ed07aa831 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages
automat...@ovirt.org has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 6: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1129587::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Fix bug when mode is not specified
automat...@ovirt.org has posted comments on this change. Change subject: fileUtils: Fix bug when mode is not specified .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I669791fb09ddd18f9b2e6320cf98839ed07aa831 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
automat...@ovirt.org has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus
Nir Soffer has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Allon Mureinik has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert hba: Run fc-scan in supervdsm
Nir Soffer has posted comments on this change. Change subject: Revert hba: Run fc-scan in supervdsm .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/37261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica493bd2e269ae3fcee2e2ec91df5aa5e323a23f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert hba: Run fc-scan in supervdsm
Nir Soffer has posted comments on this change. Change subject: Revert hba: Run fc-scan in supervdsm .. Patch Set 3: Tested again positive and negative flows, fc-scan is reaped correctly when running in vdsm. -- To view, visit https://gerrit.ovirt.org/37261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica493bd2e269ae3fcee2e2ec91df5aa5e323a23f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Convert valid to read-only property
automat...@ovirt.org has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus
automat...@ovirt.org has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Convert valid to read-only property
Nir Soffer has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus
Nir Soffer has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/38041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Fix bug when mode is not specified
Federico Simoncelli has posted comments on this change. Change subject: fileUtils: Fix bug when mode is not specified .. Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/36781/4/vdsm/storage/fileUtils.py File vdsm/storage/fileUtils.py: Line 149: stat Not for this patch: I don't think that all this belongs to the except block. -- To view, visit https://gerrit.ovirt.org/36781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I669791fb09ddd18f9b2e6320cf98839ed07aa831 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clusterlock: Add reference counting
automat...@ovirt.org has posted comments on this change. Change subject: clusterlock: Add reference counting .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846116ae16e88a51bdce20f97ddf22859dea3086 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: HACK: run GC in domain monitor
automat...@ovirt.org has posted comments on this change. Change subject: HACK: run GC in domain monitor .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c560e6fbccdf50b135cc9c90b23824ae04b0376 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
