Change in vdsm[master]: jsonrpc: rename setMessageHandler method for pep8 compliance
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method for pep8 compliance .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/41065/3/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: If we go in the pep8 direction, lets rename this module to stompreactor.py, We already have stomp module so stompreactor should be good enough. Line 1: # Copyright (C) 2014 Saggi Mizrahi, Red Hat Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License version 2 as https://gerrit.ovirt.org/#/c/41065/3/vdsm/rpc/BindingJsonRpc.py File vdsm/rpc/BindingJsonRpc.py: Same fro this module name - jsonrpcbinding.py or better jsonrpc.py Let's go with jsonrpcbinging. Line 1: # VDSM JsonRPC Server Line 2: # Copyright (C) 2012 Adam Litke, IBM Corporation Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/41065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: allow to set system thread names
Francesco Romani has posted comments on this change. Change subject: lib: allow to set system thread names .. Patch Set 4: messed up the rebase. Will resubmit. -- To view, visit https://gerrit.ovirt.org/41052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added logging for libgfapi related operations.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added logging for libgfapi related operations. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/35280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbb7199d740b54def5e9180875757d7c13c2634 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: allow to set system thread names
Francesco Romani has posted comments on this change.
Change subject: lib: allow to set system thread names
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/41052/3/lib/vdsm/threadname.py
File lib/vdsm/threadname.py:
Line 40: 'pthread_setname_np unavailable. '
Line 41: 'System thread names will not be set.')
Line 42:
Line 43:
Line 44: def systemname(name):
Even better name - setname()
OK, since this is non-portable, I'm fine to use 'pthread.py'.
I'm a bit worried about the possible naming clash between pthread.py and
pthreading.py.
I don't think we should bind together python name and system name. The
drawbacks IMO overweight the benefits because system name is 15 bytes long at
maximum, while python name can be anty python string.
If we bind the two together we must conform to the stricter one, hence only 15
bytes
Line 45:
Line 46: Allows to set a system-wide thread name.
Line 47: This decorator should be used on `func' callables which implement
Line 48: a threading.Thread target.
Line 66: 16 character maximum, including the '\0' terminator.
Line 67: http://man7.org/linux/man-pages/man3/pthread_setname_np.3.html
Line 68:
Line 69: if len(name) 15:
Line 70: raise ValueError(System thread name too long)
I think we can inline this into the decorator, and we don't need so much de
Will change.
https://gerrit.ovirt.org/#/c/41052/3/vdsm.spec.in
File vdsm.spec.in:
Line 1333: %{python_sitelib}/%{vdsm_name}/response.py*
Line 1334: %{python_sitelib}/%{vdsm_name}/netconfpersistence.py*
Line 1335: %{python_sitelib}/%{vdsm_name}/schedule.py*
Line 1336: %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1337: %{python_sitelib}/%{vdsm_name}/threadname.py*
The best name for this module is pthread.py, and the function/decorator pth
I just don't know what are the future plans for pthreading. Will we drop that
once we move on python3?
Moreover, I'd like to have this change as easy as backport to 3.5 as possible,
because is 3.5 the one which benefits the most of this patch. Move this change
to pthreading will make things easier or harder on this regard?
Line 1338: %{python_sitelib}/%{vdsm_name}/sysctl.py*
Line 1339: %{python_sitelib}/%{vdsm_name}/udevadm.py*
Line 1340: %{python_sitelib}/%{vdsm_name}/utils.py*
Line 1341: %{python_sitelib}/%{vdsm_name}/vdscli.py*
--
To view, visit https://gerrit.ovirt.org/41052
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: assign system-wide name to threads
automat...@ovirt.org has posted comments on this change. Change subject: virt: assign system-wide name to threads .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6f2afec140c9ae54601151cd51d87cba3ee232 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
automat...@ovirt.org has posted comments on this change. Change subject: lib: set system name for threads .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8ffe2c598221d93ca154e4ee4f345568c5b35f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: allow to set system thread names
automat...@ovirt.org has posted comments on this change. Change subject: lib: allow to set system thread names .. Patch Set 4: * Update tracker::#1141422::OK * Check Bug-Url::OK * Check Public Bug::#1141422::OK, public bug * Check Product::#1141422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: creation of outbox class
Piotr Kliczewski has posted comments on this change. Change subject: stomp: creation of outbox class .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/41067/2/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 278: except IndexError: Line 279: return None Line 280: Line 281: Line 282: class Outbox(object): This class does not add any behavior. The only addition is the peek method Initially we used deque and I was asked to wrap/adopt it and share this implementation. Line 283: Line 284: def __init__(self): Line 285: self._outbox = deque() Line 286: Line 292: Line 293: def pop(self): Line 294: return self._outbox.popleft() Line 295: Line 296: def add_right(self, element): append_right? I am not really sure whether we want to follow deque so closely. I would go with add_first and add_last. Line 297: self._outbox.append(element) Line 298: Line 299: def add_left(self, element): Line 300: self._outbox.appendleft(element) Line 295: Line 296: def add_right(self, element): Line 297: self._outbox.append(element) Line 298: Line 299: def add_left(self, element): append_left? Answer above. Line 300: self._outbox.appendleft(element) Line 301: Line 302: Line 303: class AsyncDispatcher(object): -- To view, visit https://gerrit.ovirt.org/41067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2020b05393daeafaed73f628cf441305a2d52354 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: allow to set system thread names
Francesco Romani has posted comments on this change. Change subject: lib: allow to set system thread names .. Patch Set 4: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/41052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
automat...@ovirt.org has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 7: * Update tracker::#970711::OK * Check Bug-Url::OK * Check Public Bug::#970711::OK, public bug * Check Product::#970711::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
automat...@ovirt.org has posted comments on this change. Change subject: Migration: Prevent KeyError in migrateStatus .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]migration: Strat using migrate3 instead of migrate2
automat...@ovirt.org has posted comments on this change. Change subject: [WIP]migration: Strat using migrate3 instead of migrate2 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]migration: Start using migrate3 instead of migrate2
automat...@ovirt.org has posted comments on this change. Change subject: [WIP]migration: Start using migrate3 instead of migrate2 .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: assign system-wide name to threads
automat...@ovirt.org has posted comments on this change. Change subject: virt: assign system-wide name to threads .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6f2afec140c9ae54601151cd51d87cba3ee232 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added logging for libgfapi related operations.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added logging for libgfapi related operations. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/35280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbb7199d740b54def5e9180875757d7c13c2634 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
automat...@ovirt.org has posted comments on this change. Change subject: lib: set system name for threads .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8ffe2c598221d93ca154e4ee4f345568c5b35f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: assign system-wide name to threads
automat...@ovirt.org has posted comments on this change. Change subject: virt: assign system-wide name to threads .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6f2afec140c9ae54601151cd51d87cba3ee232 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: pthread: allow to set system thread names
automat...@ovirt.org has posted comments on this change. Change subject: lib: pthread: allow to set system thread names .. Patch Set 6: * Update tracker::#1141422::OK * Check Bug-Url::OK * Check Public Bug::#1141422::OK, public bug * Check Product::#1141422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: pthread: allow to set system thread names
Francesco Romani has posted comments on this change. Change subject: lib: pthread: allow to set system thread names .. Patch Set 6: version 6 adds the initial round of tests -- To view, visit https://gerrit.ovirt.org/41052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
Francesco Romani has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41057/4/lib/vdsm/executor.py
File lib/vdsm/executor.py:
Line 163: def join(self):
Line 164: self._log.debug('Waiting for worker %s', self.name)
Line 165: self._thread.join()
Line 166:
Line 167: @pthread.setname(self._executor.name)
of course we don't know about self here.
Either I use a short name - but then, how to distinguish among executors? or I
add a new helper function in pthread module, to be invoked down here in _run.
But this is a little ugly and duplicates the decorator.
Line 168: @utils.traceback(on=_log.name)
Line 169: def _run(self):
Line 170: self._log.debug('Worker started')
Line 171: try:
--
To view, visit https://gerrit.ovirt.org/41057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e8ffe2c598221d93ca154e4ee4f345568c5b35f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
Shahar Havivi has posted comments on this change. Change subject: Migration: Prevent KeyError in migrateStatus .. Patch Set 5: Tested with migration downtime patch, at the end of the migration migrateStats was called, added log check for the _progress field - looks good. -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
Shahar Havivi has posted comments on this change. Change subject: Migration: Prevent KeyError in migrateStatus .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]migration: Strat using migrate3 instead of migrate2
Yeela Kaplan has uploaded a new change for review.
Change subject: [WIP]migration: Strat using migrate3 instead of migrate2
..
[WIP]migration: Strat using migrate3 instead of migrate2
We would like to enable using the new libvirt
migration parameters, this is the first step necessary.
As new parameters can only be used with migrate3.
Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed
Signed-off-by: Yeela Kaplan ykap...@redhat.com
---
M vdsm/virt/migration.py
1 file changed, 15 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/41101/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 2c7fb31..c167e8e 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -332,29 +332,33 @@
maxBandwidth = config.getint('vars', 'migration_max_bandwidth')
# FIXME: there still a race here with libvirt,
-# if we call stop() and libvirt migrateToURI2 didn't start
+# if we call stop() and libvirt migrateToURI3 didn't start
# we may return migration stop but it will start at libvirt
# side
self._preparingMigrationEvt = False
if not self._migrationCanceledEvt:
-self._vm._dom.migrateToURI2(
-duri, muri, None,
-libvirt.VIR_MIGRATE_LIVE |
-libvirt.VIR_MIGRATE_PEER2PEER |
+params = {'migrate_uri': muri,
+ 'destination_xml': None,
+ 'destination_name': None,
+ 'bandwidth': maxBandwidth}
+
+flags = libvirt.VIR_MIGRATE_LIVE |\
+libvirt.VIR_MIGRATE_PEER2PEER |\
(libvirt.VIR_MIGRATE_TUNNELLED if
-self._tunneled else 0) |
+self._tunneled else 0) |\
(libvirt.VIR_MIGRATE_ABORT_ON_ERROR if
-self._abortOnError else 0) |
+self._abortOnError else 0) |\
(libvirt.VIR_MIGRATE_COMPRESSED if
-self._compressed else 0) |
+self._compressed else 0) |\
(libvirt.VIR_MIGRATE_AUTO_CONVERGE if
-self._autoConverge else 0),
-None, maxBandwidth)
+self._autoConverge else 0)
+
+self._vm._dom.migrateToURI3(duri, params, flags)
else:
self._raiseAbortError()
def stop(self):
-# if its locks we are before the migrateToURI2()
+# if its locks we are before the migrateToURI3()
# call so no need to abortJob()
try:
self._migrationCanceledEvt = True
--
To view, visit https://gerrit.ovirt.org/41101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Piotr Kliczewski has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 383:
Line 384: return {'params': ret['params'], 'migrationPort':
ret['migrationPort']}
Line 385:
Line 386:
Line 387: def VM_getMigrationStatus_Ret(ret):
I thought that we agreed not to have method which only returns result.
Line 388:
Line 389: Return status of the Migration, progress and downtime if available
Line 390:
Line 391: return ret
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
Francesco Romani has posted comments on this change. Change subject: Migration: Prevent KeyError in migrateStatus .. Patch Set 5: Code-Review+1 looks OK -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replacing minidom with ElementTree in caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Replacing minidom with ElementTree in caps.py .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1ca58807515922347e2255c77b4f950decd619 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 7: migration.py part OK, waiting for the Bridge part as per Piotr's comment. -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Add register verb
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Add register verb
..
Patch Set 6: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/40966/6/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:
Line 136:
Line 137: try:
Line 138: res = requests.get(__GET_VERSION, verify=False)
Line 139: except requests.RequestException:
Line 140: self.logger.error(requests.RequestException,
exc_info=True)
you should still use
try:
self.logger.exception('some text')
raise
but frankly, I do not understand why you need this exception handling at all.
Exceptions should be handled at the top-most possible place. In this case - it
is the main() function.
Line 141: raise requests.RequestException
Line 142:
Line 143: if res.status_code != 200:
Line 144: self.reg_protocol = legacy
Line 230: except requests.RequestException:
Line 231: self.logger.error(Cannot connect to engine. {f} matches
Line 232: the FQDN of
Engine?.format(f=self.engine_fqdn),
Line 233: exc_info=True)
Line 234: raise requests.RequestException
again, I don't think that you should have ANY exception handling here. but if
you do want exc_info, use logger.exception('text).
Line 235:
Line 236: return res.content
Line 237:
Line 238: def _silent_restorecon(self, path):
Line 488:ssh_user=args.ssh_user,
Line 489:ssh_port=args.ssh_port,
Line 490:fingerprint=args.fingerprint,
Line 491:check_fqdn=args.check_fqdn)
Line 492:
here I'd add a try
Line 493: reg.host_uuid()
Line 494: reg.download_ca()
Line 495: reg.download_ssh()
Line 496: reg.execute_registration()
Line 492:
Line 493: reg.host_uuid()
Line 494: reg.download_ca()
Line 495: reg.download_ssh()
Line 496: reg.execute_registration()
and here, an
except:
reg.logger.exception('Error')
return 1
this would make sure all exceptions are logged, and save specific handling.
Line 497:
Line 498: if __name__ == '__main__':
Line 499: main()
Line 500:
Line 495: reg.download_ssh()
Line 496: reg.execute_registration()
Line 497:
Line 498: if __name__ == '__main__':
Line 499: main()
place
sys.exit(main())
to make sure that the return value of main() is propagated to the calling
script.
Line 500:
Line 501:
Line 502: Registration schema:
Line 503:
--
To view, visit https://gerrit.ovirt.org/40966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: pthread: allow to set system thread names
automat...@ovirt.org has posted comments on this change. Change subject: lib: pthread: allow to set system thread names .. Patch Set 5: * Update tracker::#1141422::OK * Check Bug-Url::OK * Check Public Bug::#1141422::OK, public bug * Check Product::#1141422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
automat...@ovirt.org has posted comments on this change. Change subject: lib: set system name for threads .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8ffe2c598221d93ca154e4ee4f345568c5b35f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Job related actions
Francesco Romani has posted comments on this change. Change subject: v2v: Job related actions .. Patch Set 17: Code-Review+1 (1 comment) no reason to further delay this patch. https://gerrit.ovirt.org/#/c/39361/17/client/vdsClient.py File client/vdsClient.py: Line 1925: validateArgTypes(args, [str], requiredArgsNumber=1) Line 1926: response = self.s.getConvertedVm(args[0]) Line 1927: if response['status']['code'] == 0: Line 1928: print(response['ovf']) Line 1929: return response['status']['code'], response['status']['message'] I joined the party later, this will break things if/when we switch to the response name (identifier rebound). No big deal however, we will tackle this in a future patch. Line 1930: Line 1931: def abortV2VJob(self, args): Line 1932: validateArgTypes(args, [str], requiredArgsNumber=1) Line 1933: response = self.s.abortV2VJob(args[0]) -- To view, visit https://gerrit.ovirt.org/39361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Add register verb
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: Add register verb .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40966/6/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 417: Line 418: # Needed by vdsm-tool. Otherwise it complains about register Line 419: # option doesn't exist Line 420: parser.add_argument( Line 421: 'register', Hi Yaniv, without this line, I see the line below, is that expected to add no. vdsm-tool goes over all @exposed functions and add them as arguments to vdsm-tool command. you need to parse the args only after vdsm-tool, register Line 422: ) Line 423: Line 424: parser.add_argument( Line 425: '--node-fqdn', -- To view, visit https://gerrit.ovirt.org/40966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replacing minidom with ElementTree in caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Replacing minidom with ElementTree in caps.py .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1ca58807515922347e2255c77b4f950decd619 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
Dan Kenigsberg has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 9: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41077/9/tests/capsTests.py File tests/capsTests.py: Line 231: 'SandyBridge': 'Intel', 'kvm64': None} Line 232: self.assertEqual(expected, result) Line 233: Line 234: def testGetAllCpuModels_noArch(self): Line 235: fileName = 'cpu_map.xml' please use os.path.join( os.path.dirname(os.path.realpath(__file__)), 'cpu_map.xml' ) or something like that Line 236: result = caps._getAllCpuModels(capfile=fileName, Line 237:arch='zzz') Line 238: self.assertEqual(dict(), result) Line 239: -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: rename setMessageHandler method
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: rename setMessageHandler method
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: rename setMessageHandler method .. jsonrpc: rename setMessageHandler method Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: https://gerrit.ovirt.org/41065 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Francesco Romani from...@redhat.com Continuous-Integration: Jenkins CI --- M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stompReactor.py M vdsm/rpc/BindingJsonRpc.py 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Dan Kenigsberg has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40608/1/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 219: Line 220: Returns True iff vdsm config marks the DUMMY or VETH dev to be reported Line 221: as NIC. Line 222: Line 223: if self.isDUMMY() or self.isVETH() or self.isMACVLAN(): please note that macvlans are used by libvirt to connect VMs to VFs (used by our vmfex hooks). I think that by default they would not match the _fakeNics glob, so they would not be reported as such. Line 224: return anyFnmatch(self.name, self._fakeNics) Line 225: return False Line 226: Line 227: def isNICLike(self): -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Anatoly Litovsky tlito...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: cleanup v2v directory leftovers
Dan Kenigsberg has posted comments on this change. Change subject: v2v: cleanup v2v directory leftovers .. Patch Set 13: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/39789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add format for disk conversion
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: add format for disk conversion
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40343/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 418: def _create_command(self):
Line 419: cmd = [_VIRT_V2V.cmd,
Line 420:'-ic', self._uri,
Line 421:'-o', 'vdsm',
Line 422:'-of', self._vminfo.get('format', 'raw')]
should be added as optional? on @ExternalVmInfo:
Line 423: cmd.extend(self._generate_disk_parameters())
Line 424: cmd.extend(['--password-file',
Line 425: self._passwd_file,
Line 426: '--vdsm-vm-uuid',
--
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
Dan Kenigsberg has posted comments on this change. Change subject: Migration: Prevent KeyError in migrateStatus .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
automat...@ovirt.org has posted comments on this change. Change subject: Migration: Prevent KeyError in migrateStatus .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration: Prevent KeyError in migrateStatus
Dan Kenigsberg has submitted this change and it was merged. Change subject: Migration: Prevent KeyError in migrateStatus .. Migration: Prevent KeyError in migrateStatus MigrateStats only return progress when monitor thread is alive, When calling MigrateStats after the thread is dead we get KeyError. (when calling getMigrationStatus verb) Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Signed-off-by: Shahar Havivi shah...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40657 Tested-by: Shahar Havivi shav...@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/migration.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via http
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via http .. Patch Set 4: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#917026::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b190b5d3d43cab7bdbfa81bdf0904b2988b2bc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add format for disk conversion
Shahar Havivi has posted comments on this change.
Change subject: v2v: add format for disk conversion
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40343/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 418: def _create_command(self):
Line 419: cmd = [_VIRT_V2V.cmd,
Line 420:'-ic', self._uri,
Line 421:'-o', 'vdsm',
Line 422:'-of', self._vminfo.get('format', 'raw')]
should be added as optional? on @ExternalVmInfo:
Done
Line 423: cmd.extend(self._generate_disk_parameters())
Line 424: cmd.extend(['--password-file',
Line 425: self._passwd_file,
Line 426: '--vdsm-vm-uuid',
--
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: don't log password in update graphic device
Dan Kenigsberg has posted comments on this change.
Change subject: virt: don't log password in update graphic device
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41073/1/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 1159: elif f.__name__ == 'convertExternalVm':
Line 1160: if len(args) 3:
Line 1161: displayArgs = args[:2] + ('',) + args[3:]
Line 1162: elif f.__name__ == 'vmUpdateDevice':
Line 1163: if len(args) == 2 and args[1].get(
=2
Line 1164:'deviceType', '') == 'graphics':
Line 1165: devParams = args[1].copy()
Line 1166: devParams['password'] = ''
Line 1167: displayArgs = args[0] + [devParams]
--
To view, visit https://gerrit.ovirt.org/41073
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3d318a16eb4d1b10a12f650ba957057e090532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add way to easily mock host devices
Dan Kenigsberg has posted comments on this change. Change subject: tests: add way to easily mock host devices .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40860/5/tests/vmfakelib.py File tests/vmfakelib.py: Line 49: def listAllNetworks(self, *args): Line 50: return [] Line 51: Line 52: @staticmethod Line 53: def nodeDeviceLookupByName(name): @staticmethod? libvirt's is nodeDeviceLookupByName(self, name) Line 54: Line 55: This is a method that allows us to access hostdev XML in a test. Line 56: Normally, libvirt holds the device XML but in case of unit testing, Line 57: we cannot access the libvirt. -- To view, visit https://gerrit.ovirt.org/40860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id154b390811a7c9d81da09f60d9414423925136a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add way to easily mock host devices
automat...@ovirt.org has posted comments on this change. Change subject: tests: add way to easily mock host devices .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id154b390811a7c9d81da09f60d9414423925136a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
automat...@ovirt.org has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stompReactor: fix naming of default destination
automat...@ovirt.org has posted comments on this change. Change subject: stompReactor: fix naming of default destination .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb12dc725930076c44ea9720605f6283df0ec46 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
automat...@ovirt.org has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: ignore not needed transport
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: ignore not needed transport .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icecf5c06e216151bd95f56f6fef9ed9ccba9074d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
automat...@ovirt.org has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reactor: using single instance
automat...@ovirt.org has posted comments on this change. Change subject: reactor: using single instance .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Trigger VM status check on guest agent status changes
automat...@ovirt.org has posted comments on this change. Change subject: virt: Trigger VM status check on guest agent status changes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaceca8e42720df50d5eb1e20670b6ed733db8b50 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 383:
Line 384: return {'params': ret['params'], 'migrationPort':
ret['migrationPort']}
Line 385:
Line 386:
Line 387: def VM_getMigrationStatus_Ret(ret):
I thought that we agreed not to have method which only returns result.
its not working other solutions suck as
'VM_getMigrationStatus': {}
and
'VM_getMigrationStatus': {'ret': 'MigrationStats'}
note:
MigrationStats is a union in json schema
Line 388:
Line 389: Return status of the Migration, progress and downtime if available
Line 390:
Line 391: return ret
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]migration: Start using migrate3 instead of migrate2
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP]migration: Start using migrate3 instead of migrate2
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/41101/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 335: # if we call stop() and libvirt migrateToURI3 didn't start
Line 336: # we may return migration stop but it will start at libvirt
Line 337: # side
Line 338: self._preparingMigrationEvt = False
Line 339: if not self._migrationCanceledEvt:
Please add a
# TODO: use libvirt constants when bz#1222795 is fixed
Line 340: params = {'migrate_uri': muri,
Line 341: 'destination_xml': None,
Line 342: 'destination_name': None,
Line 343: 'bandwidth': maxBandwidth}
Line 341: 'destination_xml': None,
Line 342: 'destination_name': None,
Line 343: 'bandwidth': maxBandwidth}
Line 344:
Line 345: flags = libvirt.VIR_MIGRATE_LIVE |\
please open a parenthesis - it is much nicer than backslashes.
Line 346: libvirt.VIR_MIGRATE_PEER2PEER |\
Line 347: (libvirt.VIR_MIGRATE_TUNNELLED if
Line 348: self._tunneled else 0) |\
Line 349: (libvirt.VIR_MIGRATE_ABORT_ON_ERROR if
--
To view, visit https://gerrit.ovirt.org/41101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: rename setMessageHandler method for pep8 compliance
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method for pep8 compliance .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/41065/3/vdsm/rpc/BindingJsonRpc.py File vdsm/rpc/BindingJsonRpc.py: Let's go with jsonrpcbinging. there's the cognate BindingXMLRPC which should match. please do not include these changes on this patch, though. Line 1: # VDSM JsonRPC Server Line 2: # Copyright (C) 2012 Adam Litke, IBM Corporation Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/41065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 383:
Line 384: return {'params': ret['params'], 'migrationPort':
ret['migrationPort']}
Line 385:
Line 386:
Line 387: def VM_getMigrationStatus_Ret(ret):
its not working other solutions suck as
Also since its a union the key for the 'ret' value is vary:
MigratedStats or MigratingStats it depend on the context - the empty method is
the one that works for both ways
Line 388:
Line 389: Return status of the Migration, progress and downtime if available
Line 390:
Line 391: return ret
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Job related actions
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Job related actions .. Patch Set 17: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/39361/17/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3834: Line 3835: ## Line 3836: # @Host.deleteV2VJob: Line 3837: # Line 3838: # Delete V2V job when job is done or stop due to errors stop- stopped Line 3839: # Line 3840: # @jobid: UUID to identify the job that created in convertExternalVm Line 3841: # Line 3842: # Since: 4.17.0 -- To view, visit https://gerrit.ovirt.org/39361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: cleanup v2v directory leftovers
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: cleanup v2v directory leftovers
..
Patch Set 12:
(4 comments)
https://gerrit.ovirt.org/#/c/39789/12/vdsm/v2v.py
File vdsm/v2v.py:
Line 214:
Line 215:
Line 216: def clean_leftovers():
Line 217: logging.debug('Cleaning v2v leftovers')
Line 218: for ovf in glob.iglob('%s/*.ovf' % _V2V_DIR):
os.path.join() is nicer
Line 219: try:
Line 220: logging.info('Removing ovf file %r', ovf)
Line 221: os.remove(ovf)
Line 222: except Exception as e:
Line 216: def clean_leftovers():
Line 217: logging.debug('Cleaning v2v leftovers')
Line 218: for ovf in glob.iglob('%s/*.ovf' % _V2V_DIR):
Line 219: try:
Line 220: logging.info('Removing ovf file %r', ovf)
logging.info() should not sit in the try-block
Line 221: os.remove(ovf)
Line 222: except Exception as e:
Line 223: logging.error('Cannot remove file: %s, err: %s', ovf, e)
Line 224:
Line 219: try:
Line 220: logging.info('Removing ovf file %r', ovf)
Line 221: os.remove(ovf)
Line 222: except Exception as e:
Line 223: logging.error('Cannot remove file: %s, err: %s', ovf, e)
if we want to remove the ovf, we should not ignore this failure. if we don't
care about the failure, we should not attempt to remove.
Line 224:
Line 225: for tmp in glob.glob('%s/*.tmp' % _V2V_DIR):
Line 226: try:
Line 227: logging.warn('Removing password file %r', tmp)
Line 221: os.remove(ovf)
Line 222: except Exception as e:
Line 223: logging.error('Cannot remove file: %s, err: %s', ovf, e)
Line 224:
Line 225: for tmp in glob.glob('%s/*.tmp' % _V2V_DIR):
glob.glob - glob.iglob
Line 226: try:
Line 227: logging.warn('Removing password file %r', tmp)
Line 228: os.remove(tmp)
Line 229: except Exception as e:
--
To view, visit https://gerrit.ovirt.org/39789
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add allocation type for disk conversion
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Add allocation type for disk conversion
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40533/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 418: def _create_command(self):
Line 419: cmd = [_VIRT_V2V.cmd,
Line 420:'-ic', self._uri,
Line 421:'-o', 'vdsm',
Line 422:'-of', self._vminfo.get('format', 'raw'),
raw should better be taken from @VolumeFormat.@RAW
Line 423:'-oa', self._vminfo.get('allocation', 'sparse')]
Line 424: cmd.extend(self._generate_disk_parameters())
Line 425: cmd.extend(['--password-file',
Line 426: self._passwd_file,
Line 419: cmd = [_VIRT_V2V.cmd,
Line 420:'-ic', self._uri,
Line 421:'-o', 'vdsm',
Line 422:'-of', self._vminfo.get('format', 'raw'),
Line 423:'-oa', self._vminfo.get('allocation', 'sparse')]
@VolumeAllocation.@SPARSE
Line 424: cmd.extend(self._generate_disk_parameters())
Line 425: cmd.extend(['--password-file',
Line 426: self._passwd_file,
Line 427: '--vdsm-vm-uuid',
--
To view, visit https://gerrit.ovirt.org/40533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: cleanup v2v directory leftovers
Shahar Havivi has abandoned this change. Change subject: v2v: cleanup v2v directory leftovers .. Abandoned -- To view, visit https://gerrit.ovirt.org/39789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: cleanup v2v directory leftovers
automat...@ovirt.org has posted comments on this change. Change subject: v2v: cleanup v2v directory leftovers .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/39789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make sure to inherit from an object
automat...@ovirt.org has posted comments on this change. Change subject: stomp: make sure to inherit from an object .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b651226443bb0b5e1cecfdb222d52a74f24a74 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: rename setMessageHandler method
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: allow single stomp reactor
automat...@ovirt.org has posted comments on this change. Change subject: stomp: allow single stomp reactor .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdd7afef991d51c293d5624d936f8e689ccb8de4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
automat...@ovirt.org has posted comments on this change. Change subject: events: vm status notifications .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make sure to iherit from an object
automat...@ovirt.org has posted comments on this change. Change subject: stomp: make sure to iherit from an object .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b651226443bb0b5e1cecfdb222d52a74f24a74 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: creation of outbox class
automat...@ovirt.org has posted comments on this change. Change subject: stomp: creation of outbox class .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2020b05393daeafaed73f628cf441305a2d52354 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: introduction of header constants
automat...@ovirt.org has posted comments on this change. Change subject: stomp: introduction of header constants .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb4f5ebaa962861ae5836a6594ad3a0f8c166c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: preparation of subscribtion class for subscription ma...
automat...@ovirt.org has posted comments on this change. Change subject: stomp: preparation of subscribtion class for subscription management .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40cb609432c3d5a7d297e25647a152abdc8e86c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Trigger VM status check on guest agent status changes
Vinzenz Feenstra has uploaded a new change for review.
Change subject: virt: Trigger VM status check on guest agent status changes
..
virt: Trigger VM status check on guest agent status changes
Change-Id: Iaceca8e42720df50d5eb1e20670b6ed733db8b50
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M vdsm/virt/guestagent.py
M vdsm/virt/vm.py
2 files changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/41108/1
diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py
index 812e543..4d4a469 100644
--- a/vdsm/virt/guestagent.py
+++ b/vdsm/virt/guestagent.py
@@ -108,14 +108,15 @@
class GuestAgent(object):
MAX_MESSAGE_SIZE = 2 ** 20 # 1 MiB for now
-def __init__(self, socketName, channelListener, log, user='Unknown',
- ips=''):
+def __init__(self, socketName, channelListener, log, onStatusChange,
+ user='Unknown', ips=''):
self.effectiveApiVersion = _IMPLICIT_API_VERSION_ZERO
+self._onStatusChange = onStatusChange
self.log = log
self._socketName = socketName
self._sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
self._stopped = True
-self.guestStatus = None
+self._guestStatus = None
self.guestDiskMapping = {}
self.guestInfo = {
'username': user,
@@ -133,6 +134,17 @@
self._messageState = MessageState.NORMAL
@property
+def guestStatus(self):
+return self._guestStatus
+
+@guestStatus.setter
+def guestStatus(self, value):
+oldValue = self._guestStatus
+self._guestStatus = value
+if oldValue != value and self._onStatusChange:
+self._onStatusChange()
+
+@property
def guestDiskMapping(self):
return self._guestDiskMapping
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 984f1d0..f073fe0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -331,7 +331,8 @@
self._guestSocketFile = self._makeChannelPath(_VMCHANNEL_DEVICE_NAME)
self._qemuguestSocketFile = self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
self.guestAgent = guestagent.GuestAgent(
-self._guestSocketFile, self.cif.channelListener, self.log)
+self._guestSocketFile, self.cif.channelListener, self.log,
+self._agent_status_changed)
self._domain = DomainDescriptor.from_id(self.id)
self._released = False
self._releaseLock = threading.Lock()
@@ -352,6 +353,13 @@
self._numaInfo = {}
self._vmJobs = None
+def _agent_status_changed(self):
+with self._statusLock:
+last = self._get_lastStatus()
+now = self._getVmStatus()
+if last != now:
+self._set_lastStatus(now)
+
def _get_lastStatus(self):
# note that we don't use _statusLock here. One of the reasons is the
# non-obvious recursive locking in the following flow:
--
To view, visit https://gerrit.ovirt.org/41108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaceca8e42720df50d5eb1e20670b6ed733db8b50
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: remove not needed param
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: remove not needed param .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a9e44d272bb4d12c0816c7d168397ffa2758d2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: subscription cleanup when connection lost
automat...@ovirt.org has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make sure to iherit from an object
automat...@ovirt.org has posted comments on this change. Change subject: stomp: make sure to iherit from an object .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b651226443bb0b5e1cecfdb222d52a74f24a74 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make sure to iherit from an object
Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: make sure to iherit from an object .. stomp: make sure to iherit from an object Change-Id: I60b651226443bb0b5e1cecfdb222d52a74f24a74 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: https://gerrit.ovirt.org/41066 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Continuous-Integration: Jenkins CI --- M lib/yajsonrpc/stomp.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60b651226443bb0b5e1cecfdb222d52a74f24a74 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends.py: setSpmStatus - expect tuple as arguemnt
Liron Aravot has uploaded a new change for review. Change subject: spbackends.py: setSpmStatus - expect tuple as arguemnt .. spbackends.py: setSpmStatus - expect tuple as arguemnt As part of change I049adecda40deb6f715e3aea2e3ada4030b518a3 setSpmStatus the tuple argument was removed, but the passed argument is still a tuple - which causes to the lambda fuction to fail on getting one argument instead of two. Change-Id: Ib0181e1af8715323e23f4980945beedb1d4475ad Signed-off-by: Liron Aravot lara...@redhat.com --- M vdsm/storage/spbackends.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/4/1 diff --git a/vdsm/storage/spbackends.py b/vdsm/storage/spbackends.py index 48ee301..f003205 100644 --- a/vdsm/storage/spbackends.py +++ b/vdsm/storage/spbackends.py @@ -229,7 +229,7 @@ def setSpmStatus(self, lVer=None, spmId=None): self.invalidateMetadata() -metaParams = dict(filter(lambda k, v: v is not None, +metaParams = dict(filter(lambda k: k[1] is not None, ((PMDK_LVER, lVer), (PMDK_SPM_ID, spmId self._metadata.update(metaParams) -- To view, visit https://gerrit.ovirt.org/4 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0181e1af8715323e23f4980945beedb1d4475ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends.py: setSpmStatus - expect tuple as arguemnt
automat...@ovirt.org has posted comments on this change. Change subject: spbackends.py: setSpmStatus - expect tuple as arguemnt .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/4 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0181e1af8715323e23f4980945beedb1d4475ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert python3: eliminate tuple_params
automat...@ovirt.org has posted comments on this change. Change subject: Revert python3: eliminate tuple_params .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I878793a3a9ccb897cfd8581e28ab40ad652b9fd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert python3: eliminate tuple_params
Liron Aravot has uploaded a new change for review.
Change subject: Revert python3: eliminate tuple_params
..
Revert python3: eliminate tuple_params
This reverts commit 3fac182abaa9d403f600119086cf296ed1b434eb.
The given change eliminated tuple params, but the recieving methods
weren't changed to expect to recieve a tuple.
Change-Id: I878793a3a9ccb897cfd8581e28ab40ad652b9fd7
Signed-off-by: Liron Aravot lara...@redhat.com
---
M tests/functional/networkTests.py
M vdsm/storage/spbackends.py
M vdsm/virt/vm.py
3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/41112/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 4159d08..27c9d65 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1758,11 +1758,11 @@
{BONDING_NAME: {'remove': True}},
NOCHK)
-@permutations([(True, (4,)), (True, (6,)), (True, (4, 6)),
- (False, (4,)), (False, (6,)), (False, (4, 6))])
+@permutations([[(True, (4,))], [(True, (6,))], [(True, (4, 6))],
+ [(False, (4,))], [(False, (6,))], [(False, (4, 6))]])
@cleanupNet
@RequireVethMod
-def testSetupNetworksAddDelDhcp(self, bridged, families):
+def testSetupNetworksAddDelDhcp(self, (bridged, families)):
with vethIf() as (left, right):
veth.setIP(left, IP_ADDRESS, IP_CIDR)
veth.setIP(left, IPv6_ADDRESS, IPv6_CIDR, 6)
@@ -1879,10 +1879,10 @@
finally:
dhcp.delete_dhclient_leases(NETWORK_NAME, dhcpv4=True)
-@permutations([(4, 'default'), (4, 'local'), (6, None)])
+@permutations([[(4, 'default')], [(4, 'local')], [(6, None)]])
@cleanupNet
@RequireVethMod
-def testDhclientLeases(self, family, dateFormat):
+def testDhclientLeases(self, (family, dateFormat)):
dhcpv4_ifaces = set()
dhcpv6_ifaces = set()
with vethIf() as (server, client):
diff --git a/vdsm/storage/spbackends.py b/vdsm/storage/spbackends.py
index 48ee301..86714a3 100644
--- a/vdsm/storage/spbackends.py
+++ b/vdsm/storage/spbackends.py
@@ -229,7 +229,7 @@
def setSpmStatus(self, lVer=None, spmId=None):
self.invalidateMetadata()
-metaParams = dict(filter(lambda k, v: v is not None,
+metaParams = dict(filter(lambda (k, v): v is not None,
((PMDK_LVER, lVer), (PMDK_SPM_ID, spmId
self._metadata.update(metaParams)
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ede1038..d89ea63 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -115,7 +115,7 @@
def _filterSnappableDiskDevices(diskDeviceXmlElements):
-return filter(lambda x: not(x.getAttribute('device')) or
+return filter(lambda(x): not(x.getAttribute('device')) or
x.getAttribute('device') in ['disk', 'lun'],
diskDeviceXmlElements)
--
To view, visit https://gerrit.ovirt.org/41112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I878793a3a9ccb897cfd8581e28ab40ad652b9fd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot lara...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends.py: setSpmStatus - expect tuple as argument
automat...@ovirt.org has posted comments on this change. Change subject: spbackends.py: setSpmStatus - expect tuple as argument .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/4 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0181e1af8715323e23f4980945beedb1d4475ad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends.py: setSpmStatus - expect tuple as param
automat...@ovirt.org has posted comments on this change. Change subject: spbackends.py: setSpmStatus - expect tuple as param .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/4 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0181e1af8715323e23f4980945beedb1d4475ad Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: creation of outbox class
Dan Kenigsberg has posted comments on this change. Change subject: stomp: creation of outbox class .. Patch Set 3: Code-Review-1 (2 comments) -1 for visibility https://gerrit.ovirt.org/#/c/41067/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-15 17:06:21 +0200 Line 4: Commit: Vinzenz Feenstra vfeen...@redhat.com Line 5: CommitDate: 2015-05-19 12:49:33 +0200 Line 6: Line 7: stomp: creation of outbox class Vinzenz mistakenly reverted your commit message fixes Line 8: Line 9: Line 10: Change-Id: I2020b05393daeafaed73f628cf441305a2d52354 https://gerrit.ovirt.org/#/c/41067/3/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 283: Line 284: def __init__(self): Line 285: self._outbox = deque() Line 286: Line 287: def is_not_empty(self): you said you are not use __nonzero__ ? Line 288: return (len(self._outbox) 0) Line 289: Line 290: def peek(self): Line 291: return self._outbox[0] -- To view, visit https://gerrit.ovirt.org/41067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2020b05393daeafaed73f628cf441305a2d52354 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: veth: introduce a context manager to create and destroy a ve...
Ondřej Svoboda has posted comments on this change. Change subject: veth: introduce a context manager to create and destroy a veth pair .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38945/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-13 19:58:20 +0100 Line 4: Commit: Ondřej Svoboda osvob...@redhat.com Line 5: CommitDate: 2015-05-14 19:14:12 +0200 Line 6: Line 7: veth: introduce a context manager to create and destroy a veth pair you are just moving it to another place, not introducing it, right? Even though vethIf is being removed, most of veth.pair's code originates from veth.create. From veth module's POV I am introducing it and making use of it in netinfotests. The wording was not very important to me :-) Line 8: Line 9: Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b -- To view, visit https://gerrit.ovirt.org/38945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37733/8/tests/functional/dummy.py File tests/functional/dummy.py: Line 52:(dummy_name, e)) Line 53: Line 54: Line 55: @contextmanager Line 56: def device(prefix='dummy_', max_length=11): never used? Do you mean max_length? I must have lost it in (local) rebases. Line 57: dummy_name = create(prefix=prefix) Line 58: try: Line 59: yield dummy_name Line 60: finally: -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added volumeReplaceBrickCommitForce verb.
Timothy Asir has posted comments on this change. Change subject: gluster: Added volumeReplaceBrickCommitForce verb. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert python3: eliminate tuple_params
Dan Kenigsberg has posted comments on this change. Change subject: Revert python3: eliminate tuple_params .. Patch Set 1: Code-Review-1 I very much prefer your suggestion https://gerrit.ovirt.org/#/c/4/4 which solves the filter() regression and does not touch harmless peices of the reverted patch. -- To view, visit https://gerrit.ovirt.org/41112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I878793a3a9ccb897cfd8581e28ab40ad652b9fd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via http
Simone Tiraboschi has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via http .. Patch Set 4: It's failing just because http driver is not whitelisted, at least not on centos 7.1 vdsm.log: disk device=cdrom type=networkdriver name=qemu type=raw/source name=/download/current/x86_64/RCDx64_11_02.iso protocol=httphost name=rescuecd.pld-linux.org port=80//sourcereadonly/backingStore/target bus=ide dev=hda tray=closed/boot order=1//disk/devices vdsm.log:libvirtError: internal error: process exited while connecting to monitor: 2015-05-19T10:42:51.718220Z qemu-kvm: -drive file=http://rescuecd.pld-linux.org:80/download/current/x86_64/RCDx64_11_02.iso,if=none,id=drive-ide0-0-0,readonly=on,format=raw: could not open disk image http://rescuecd.pld-linux.org:80/download/current/x86_64/RCDx64_11_02.iso: Driver 'http' is not whitelisted vdsm.log:Thread-3415::INFO::2015-05-19 12:42:52,000::vm::1218::vm.Vm::(setDownStatus) vmId=`d8f49271-e587-443f-ad57-f85ff554c1a6`::Changed state to Down: internal error: process exited while connecting to monitor: 2015-05-19T10:42:51.718220Z qemu-kvm: -drive file=http://rescuecd.pld-linux.org:80/download/current/x86_64/RCDx64_11_02.iso,if=none,id=drive-ide0-0-0,readonly=on,format=raw: could not open disk image http://rescuecd.pld-linux.org:80/download/current/x86_64/RCDx64_11_02.iso: Driver 'http' is not whitelisted -- To view, visit https://gerrit.ovirt.org/41076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b190b5d3d43cab7bdbfa81bdf0904b2988b2bc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends.py: setSpmStatus - expect tuple as param
Dan Kenigsberg has posted comments on this change. Change subject: spbackends.py: setSpmStatus - expect tuple as param .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/4 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0181e1af8715323e23f4980945beedb1d4475ad Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding unittests for caps.py
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add format for disk conversion
automat...@ovirt.org has posted comments on this change. Change subject: v2v: add format for disk conversion .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: introduction of header constants
automat...@ovirt.org has posted comments on this change. Change subject: stomp: introduction of header constants .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb4f5ebaa962861ae5836a6594ad3a0f8c166c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
