Change in vdsm[master]: extra_ipv4_addrs_hook: Add a hook for configuring secondary ...
Ido Barkan has posted comments on this change. Change subject: extra_ipv4_addrs_hook: Add a hook for configuring secondary addrs .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/29738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id465870df6274552a68f6c9c0b907a843f08bf58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: extra_ipv4_addrs_hook: Add a hook for configuring secondary ...
automat...@ovirt.org has posted comments on this change. Change subject: extra_ipv4_addrs_hook: Add a hook for configuring secondary addrs .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/29738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id465870df6274552a68f6c9c0b907a843f08bf58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43852/2/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py: Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: from . import constants Line 21: Please add a note here that this is a partial version of cmdutils from mast Done Line 22: Line 23: def systemd_run(cmd, scope=False, unit=None, slice=None): Line 24: command = [constants.EXT_SYSTEMD_RUN] Line 25: if scope: -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
automat...@ovirt.org has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 6: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
Yaniv Bronhaim has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 1: I asked edri to confirm as well -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
automat...@ovirt.org has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
Yaniv Bronhaim has abandoned this change. Change subject: new vdsm config to output libvirtd log to file .. Abandoned for now I abandon this work - I don't see the benefit here for the long run. its only one liner change in livbirtd.conf file that can be added manually -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6
Michal Skrivanek has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 .. Patch Set 1: ? -- To view, visit https://gerrit.ovirt.org/43307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c55f66aa526a6b9498f557c964ee1f72885 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
Ido Barkan has posted comments on this change.
Change subject: net: run dhclient in its own process group.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43853/4/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:
Line 21:
Line 22:
Line 23: def systemd_run(cmd, scope=False, unit=None, slice=None):
Line 24: # warning: this is supported only on OS versions that use systemd
(el7 and
Line 25: # later).
The word warning is unneeded.
Done
Line 26: command = [constants.EXT_SYSTEMD_RUN]
Line 27: if scope:
Line 28: command.append('--scope')
Line 29: if unit:
--
To view, visit https://gerrit.ovirt.org/43853
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
automat...@ovirt.org has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 5: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
Ido Barkan has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove supportedProtocols parameter which is not in use
Yaniv Bronhaim has posted comments on this change. Change subject: Remove supportedProtocols parameter which is not in use .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9227d27f9e96d7efbac1cc42c757ca9a4e73269 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
Yaniv Bronhaim has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Send event after shutdown or reboot initiation
Piotr Kliczewski has posted comments on this change. Change subject: virt: Send event after shutdown or reboot initiation .. Patch Set 1: I thought that the intention was to trigger event from as few places in the code as possible. Have we changed our mind? -- To view, visit https://gerrit.ovirt.org/43862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I756b4e5d1aa3f32ba58f9e0a05178f1f71af7a59 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Send event after shutdown or reboot initiation
Michal Skrivanek has posted comments on this change. Change subject: virt: Send event after shutdown or reboot initiation .. Patch Set 1: @piotr: yeah, it's spreading like plague:) That's why I would think the existing guest agent handling is good enough. We will miss events in cases when guest agent is not there, but in that case we miss a lot of things, and e.g. just for a fact that ballooning doesn't work without it I would say our first choice should be supporting agent -- To view, visit https://gerrit.ovirt.org/43862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I756b4e5d1aa3f32ba58f9e0a05178f1f71af7a59 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove supportedProtocols parameter which is not in use
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove supportedProtocols parameter which is not in use .. Remove supportedProtocols parameter which is not in use Requires to update MarshallingTestCase.java in engine side which validates getVdsCaps output. Change-Id: Ib9227d27f9e96d7efbac1cc42c757ca9a4e73269 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234790 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43571 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/dsaversion.py.in M vdsm/rpc/vdsmapi-schema.json 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9227d27f9e96d7efbac1cc42c757ca9a4e73269 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove supportedProtocols parameter which is not in use
automat...@ovirt.org has posted comments on this change. Change subject: Remove supportedProtocols parameter which is not in use .. Patch Set 2: * Update tracker::#1234790::OK * Set MODIFIED::bug 1234790#1234790IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/43571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9227d27f9e96d7efbac1cc42c757ca9a4e73269 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
automat...@ovirt.org has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 16: * Update tracker::#1147148::OK * Check Bug-Url::OK * Check Public Bug::#1147148::OK, public bug * Check Product::#1147148::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Eldad Marciano emarc...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
Dan Kenigsberg has submitted this change and it was merged. Change subject: Cleaning libvirt requirements which are not required anymore .. Cleaning libvirt requirements which are not required anymore Those requirements were needed by ci. commit 87cf34 introduced this complexity since libvirt-daemon = 1.2.8-16.el7_1.2 was not yet available in Centos repositories. Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43851 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Eyal Edri ee...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
Dan Kenigsberg has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
automat...@ovirt.org has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
Dan Kenigsberg has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
automat...@ovirt.org has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix permutations of decorated tests
automat...@ovirt.org has posted comments on this change. Change subject: testlib: Fix permutations of decorated tests .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I805885cb584f7ff015443682dd3bf52d0a44c74b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix permutations of decorated tests
Dan Kenigsberg has posted comments on this change. Change subject: testlib: Fix permutations of decorated tests .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I805885cb584f7ff015443682dd3bf52d0a44c74b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix permutations of decorated tests
Dan Kenigsberg has submitted this change and it was merged. Change subject: testlib: Fix permutations of decorated tests .. testlib: Fix permutations of decorated tests Our expandPermutations infrastructure assume that generated tests use the original test method, and break when using test decorators such as @slowtestest or @stresstest. The generated tests are registered incorrectly, overriding tests with the same first permutation argument. Assuming we have the following test: @slowtest @permutations([[1, 2], [1, 4]]) def test_permutations(self, a, b): ... Instead of generating these tests: test_permutations(a=1, b=2) test_permutations(a=1, b=4) We generate only one test, dropping the first permutation: test_permutations(kwargs=1) This happens because decorated method signature is converted from: test_permutations(self, a, b) To the generic form: test_permutations(*args, **kwargs) When expanding permutations, we drop the first argument (args), assuming it is self, and zipping the argument list with the rest of the argument names (kwargs), dropping the second argument, and generating the wrong argument string kwargs=1. The issue seems unfixable, since we need the original wrapped function to get the original variables names, and we can have any number of wrappers around it. This patch fixes the issue in the same way nose and pytest handle this issue, by generating positional argument string: 1, 2. This is not nice as a=1, b=2, but it works with decorated tests correctly. So in the example above, we are generated these tests correctly: test_permutations(1, 2) test_permutations(1, 4) Change-Id: I805885cb584f7ff015443682dd3bf52d0a44c74b Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43433 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/testlib.py 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I805885cb584f7ff015443682dd3bf52d0a44c74b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
Nir Soffer has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 57: kill_dhclient(self.iface) Line 58: cmd = [self.DHCLIENT.cmd, '-1', '-pf', self.pidFile, '-lf', Line 59:self.leaseFile, self.iface] Line 60: if not EL6: Line 61: cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup) Here you don't check for None self._cgroup. Lets be consistent with ifup. Either always use cgroup (because we don't have a need for not using it, or allow None in both cases. Again, I assume this is master behavior? Line 62: Line 63: rc, out, err = execCmd(cmd) Line 64: return rc, out, err Line 65: -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Darshan Narayana Murthy dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: The tests fail again because of bridges with same names. Maybe we should backport the fix from master? -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
Nir Soffer has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 791: Bring up an interface Line 792: def _ifup(netIf): Line 793: cmd = [constants.EXT_IFUP, netIf] Line 794: Line 795: if not EL6 and cgroup is not None: cgroup is a new argument, and I don't see code in this patch calling ifup with cgroup=None, so this check seems unneeded. I guess this is the same on master? Line 796: cmd = cmdutils.systemd_run(cmd, scope=True, slice=cgroup) Line 797: Line 798: rc, out, err = utils.execCmd(cmd, raw=False) Line 799: -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6 for ppc64le
Martin Polednik has uploaded a new change for review. Change subject: vdsm: drop cluster version 3.6 for ppc64le .. vdsm: drop cluster version 3.6 for ppc64le Due to moving from powerKVM to ppc64le, we should not support older cluster levels in newest VDSM for POWER8 platform. I5c55f66aa526a6b9498f557c964ee1f72885 Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Signed-off-by: Martin Polednik mpoled...@redhat.com --- M vdsm/dsaversion.py.in 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/43892/1 diff --git a/vdsm/dsaversion.py.in b/vdsm/dsaversion.py.in index 374580d..41f6266 100644 --- a/vdsm/dsaversion.py.in +++ b/vdsm/dsaversion.py.in @@ -18,6 +18,8 @@ # Refer to the README and COPYING files for full details of the license # +import platform + This module provides DSA software versioning information for python based components @@ -36,3 +38,6 @@ 'supportedENGINEs': ['3.4', '3.5', '3.6'], 'clusterLevels': ['3.4', '3.5', '3.6'], } + +if platform.machine() == 'ppc64le': +version_info['clusterLevels'] = ['3.6'] -- To view, visit https://gerrit.ovirt.org/43892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6 for ppc64le
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 for ppc64le .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c55f66aa526a6b9498f557c964ee1f72885 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6
Martin Polednik has abandoned this change. Change subject: vdsm: drop cluster version 3.6 .. Abandoned replaced by https://gerrit.ovirt.org/#/c/43892/ -- To view, visit https://gerrit.ovirt.org/43307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5c55f66aa526a6b9498f557c964ee1f72885 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6 for ppc64le
Martin Polednik has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 for ppc64le .. Patch Set 1: Verified+1 x86_64: vdsClient -s 0 getVdsCapabilities | grep -i cluster clusterLevels = ['3.4', '3.5', '3.6'] ppc64le: vdsClient -s 0 getVdsCapabilities | grep -i cluster clusterLevels = ['3.6'] -- To view, visit https://gerrit.ovirt.org/43892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 16: Code-Review-1 Patch not ready form merging. We need to understand implication of this change so giving -1 for visibility. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Eldad Marciano emarc...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 16: Verified+1 Rebased, verified with the latest engine. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Eldad Marciano emarc...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: configurators: persist custom bond option
Petr Horáček has uploaded a new change for review.
Change subject: net: configurators: persist custom bond option
..
net: configurators: persist custom bond option
Until now, custom bond property was exposed only to
before_network_setup hook and then dropped (so it was not
passed to configurators and persisted). But this is not how
custom *network* property behaves. We want these two custom
properties to be symmetric - they have to be persisted
(if unified persistence is used) and must not be shown
in netinfo.
This patch moves removal of custom property down to
configurators. Thanks to it, custom property is persisted,
but not set and bond option.
Custom property is not dropped only in configurators, but in
models.py:Bond:areOptionsApplied as well - we don't want
configurator to reconfigure bond when there is a custom
property defined while its value is not used by configurator.
Change-Id: Ic4f1564e19904cc1d53bc6d1cf732ca35375332e
Signed-off-by: Petr Horáček phora...@redhat.com
---
M tests/functional/networkTests.py
M vdsm/network/configurators/__init__.py
M vdsm/network/configurators/ifcfg.py
M vdsm/network/configurators/iproute2.py
M vdsm/network/configurators/pyroute_two.py
M vdsm/network/models.py
6 files changed, 38 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/43891/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index e5bfe25..4d9f480 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2648,8 +2648,12 @@
NOCHK, test_kernel_config=False)
self.assertEqual(status, SUCCESS, msg)
self.assertBondExists(BONDING_NAME, nics)
-opts = self.vdsm_net.config.bonds.get(BONDING_NAME).get('options')
-self.assertEquals(opts, 'mode=balance-rr')
+# custom property have to be persisted (if unified persistence is
+# used) and must not be shown in netinfo.
+self._assert_exact_bond_opts(BONDING_NAME, ('mode=balance-rr',))
+if vdsm.config.config.get('vars', 'net_persistence') == 'unified':
+bond = self.vdsm_net.config.bonds.get(BONDING_NAME)
+self.assertEquals(bond.get('options'), 'mode=balance-rr')
status, msg = self.setupNetworks(
{}, {BONDING_NAME: {'remove': True}}, NOCHK)
diff --git a/vdsm/network/configurators/__init__.py
b/vdsm/network/configurators/__init__.py
index e51d3ed..bc41119 100644
--- a/vdsm/network/configurators/__init__.py
+++ b/vdsm/network/configurators/__init__.py
@@ -178,3 +178,16 @@
if iface.blockingdhcp and rc:
raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient%s failed',
family)
+
+
+def remove_custom_bond_option(options):
+ Removes 'custom' option from bond options string.
+
+ remove_custom_bond_option('custom=foo=bar mode=1')
+'mode=1'
+
+d_opts = dict(opt.split('=', 1) for opt in options.split())
+if d_opts.pop('custom', None) is not None:
+options = ' '.join(['%s=%s' % (key, value)
+for key, value in d_opts.items()])
+return options
diff --git a/vdsm/network/configurators/ifcfg.py
b/vdsm/network/configurators/ifcfg.py
index f2dbd5e..c5e2c0d 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -44,7 +44,8 @@
if utils.isOvirtNode():
from ovirt.node.utils import fs as node_fs
-from . import Configurator, dhclient, getEthtoolOpts, libvirt
+from . import (Configurator, dhclient, getEthtoolOpts, libvirt,
+ remove_custom_bond_option)
from ..errors import ConfigNetworkError, ERR_FAILED_IFUP
from ..models import Nic, Bridge, IPv4, IPv6
from ..sourceroute import StaticSourceRoute, DynamicSourceRoute
@@ -567,7 +568,9 @@
def addBonding(self, bond, **opts):
Create ifcfg-* file with proper fields for bond
-conf = 'BONDING_OPTS=%s\n' % pipes.quote(bond.options or '')
+options = (remove_custom_bond_option(bond.options)
+ if bond.options else '')
+conf = 'BONDING_OPTS=%s\n' % pipes.quote(options)
opts['hotplug'] = 'no' # So that udev doesn't trigger an ifup
if bond.bridge:
conf += 'BRIDGE=%s\n' % pipes.quote(bond.bridge.name)
diff --git a/vdsm/network/configurators/iproute2.py
b/vdsm/network/configurators/iproute2.py
index 0b5b73e..0850212 100644
--- a/vdsm/network/configurators/iproute2.py
+++ b/vdsm/network/configurators/iproute2.py
@@ -29,7 +29,8 @@
from vdsm.utils import CommandPath
from vdsm.utils import execCmd
-from . import Configurator, runDhclient, getEthtoolOpts, libvirt
+from . import (Configurator, runDhclient, getEthtoolOpts, libvirt,
+ remove_custom_bond_option)
from .dhclient import DhcpClient
from ..errors import ConfigNetworkError,
Change in vdsm[master]: net: configurators: persist custom bond option
automat...@ovirt.org has posted comments on this change. Change subject: net: configurators: persist custom bond option .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f1564e19904cc1d53bc6d1cf732ca35375332e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: do not send empty disks/networks
Dan Kenigsberg has posted comments on this change. Change subject: vm: stats: do not send empty disks/networks .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30aac0079fec71b496d4db9536b65d8f16360d7a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: do not send empty disks/networks
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: do not send empty disks/networks .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30aac0079fec71b496d4db9536b65d8f16360d7a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: do not send empty disks/networks
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: stats: do not send empty disks/networks .. vm: stats: do not send empty disks/networks VDSM used to inconditionally add keys for disks and networks in the stats value to be returned on Vm.getStats() API. If stats from libvirt are available, those keys will be overwritten with real data; otherwise, empty values are reported. If we use the same code path to piggyback data on vm_status events, this will confuse Engine and will make it believe there are no disks nor networks. Moreovero, in general, we should avoid to report empty values if the emptiness carries no meaning (noteworthy counterexample: vmJobs for live merge). So this patch makes sure that we report either full data for disks and networks, or nothing at all, avoiding empty values. Change-Id: I30aac0079fec71b496d4db9536b65d8f16360d7a Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43464 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30aac0079fec71b496d4db9536b65d8f16360d7a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
automat...@ovirt.org has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 7: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: configurators: persist custom bond option
automat...@ovirt.org has posted comments on this change. Change subject: net: configurators: persist custom bond option .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f1564e19904cc1d53bc6d1cf732ca35375332e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
Nir Soffer has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 57: kill_dhclient(self.iface) Line 58: cmd = [self.DHCLIENT.cmd, '-1', '-pf', self.pidFile, '-lf', Line 59:self.leaseFile, self.iface] Line 60: if not EL6: Line 61: cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup) this code should check if self._cgroup is not None. same as in ifcfg.py Is it the same as master now? If master does not check for None, I would add this in a separate patch in both master/3.5. Line 62: Line 63: rc, out, err = execCmd(cmd) Line 64: return rc, out, err Line 65: -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient
Petr Horáček has uploaded a new change for review.
Change subject: network: add 'default_route' parameter to DhcpClient
..
network: add 'default_route' parameter to DhcpClient
Non-ifcfg configurators handle 'default_route' option only with
static IPs, but this should be allowed with dynamic as well.
This patch enhances DhcpClient so it is able to disable standard
default gateway overwriting.
Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae
Signed-off-by: Petr Horáček phora...@redhat.com
---
M vdsm/network/configurators/dhclient.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/43900/1
diff --git a/vdsm/network/configurators/dhclient.py
b/vdsm/network/configurators/dhclient.py
index d71b5ff..222d902 100644
--- a/vdsm/network/configurators/dhclient.py
+++ b/vdsm/network/configurators/dhclient.py
@@ -42,9 +42,11 @@
LEASE_FILE = os.path.join(LEASE_DIR, 'dhclient{0}--{1}.lease')
DHCLIENT = CommandPath('dhclient', '/sbin/dhclient')
-def __init__(self, iface, family=4, cgroup=DHCLIENT_CGROUP):
+def __init__(self, iface, family=4, default_route=True,
+ cgroup=DHCLIENT_CGROUP):
self.iface = iface
self.family = family
+self.default_route = default_route
self.pidFile = self.PID_FILE % (family, self.iface)
if not os.path.exists(self.LEASE_DIR):
os.mkdir(self.LEASE_DIR)
@@ -58,6 +60,9 @@
kill_dhclient(self.iface, self.family)
cmd = [self.DHCLIENT.cmd, '-%s' % self.family, '-1', '-pf',
self.pidFile, '-lf', self.leaseFile, self.iface]
+if not self.default_route:
+# Instruct Fedora/EL's dhclient-script not to set gateway on iface
+cmd += ['-e', 'DEFROUTE=no']
cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup)
rc, out, err = execCmd(cmd)
return rc, out, err
--
To view, visit https://gerrit.ovirt.org/43900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček phora...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient
automat...@ovirt.org has posted comments on this change. Change subject: network: add 'default_route' parameter to DhcpClient .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Dan Kenigsberg has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43852/3/vdsm/sudoers.vdsm.in File vdsm/sudoers.vdsm.in: Line 32: @MULTIPATH_PATH@, \ Line 33: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \ Line 34: @SERVICE_PATH@ vdsmd *, \ Line 35: @REBOOT_PATH@ -f, \ Line 36: @SYSTEMD_RUN_PATH@ this is a security breach that should be fixed on master, as it allows vdsm to run ANY binary (provided it is prefixed with systemd-run). In this backport, we need it ONLY within setupNetwork, which is run already in supervdsm, so I don't think we need it at all in this file. Line 37: Line 38: vdsm ALL=(ALL) NOPASSWD: VDSM_LIFECYCLE, VDSM_STORAGE Line 39: Defaults:vdsm !requiretty -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient
automat...@ovirt.org has posted comments on this change. Change subject: network: add 'default_route' parameter to DhcpClient .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Send event after shutdown or reboot initiation
Piotr Kliczewski has posted comments on this change. Change subject: virt: Send event after shutdown or reboot initiation .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I756b4e5d1aa3f32ba58f9e0a05178f1f71af7a59 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cleaning libvirt requirements which are not required anymore
Eyal Edri has posted comments on this change. Change subject: Cleaning libvirt requirements which are not required anymore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf656d3f026b32d2a5a30efe9ee2a57ac8f38b46 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Try to be nicer to other processes
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id163844a5976384ca9e9a75d58a581645f08a89f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: configurators: persist custom bond option
Petr Horáček has posted comments on this change. Change subject: net: configurators: persist custom bond option .. Patch Set 2: Verified+1 Passed functional test with both unified and ifcfg persistence without a regression (test_setupNetworks_bond_with_custom_option was fixed with ifcfg). -- To view, visit https://gerrit.ovirt.org/43891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f1564e19904cc1d53bc6d1cf732ca35375332e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6 for ppc64le
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 for ppc64le .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43892/1//COMMIT_MSG Commit Message: Line 8: Line 9: Due to moving from powerKVM to ppc64le, we should not support older Line 10: cluster levels in newest VDSM for POWER8 platform. Line 11: Line 12: I5c55f66aa526a6b9498f557c964ee1f72885 mentioning the abandoned changeid helps no one. at least not me. Line 13: Line 14: Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 -- To view, visit https://gerrit.ovirt.org/43892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6 for ppc64le
Martin Polednik has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 for ppc64le .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43892/1//COMMIT_MSG Commit Message: Line 8: Line 9: Due to moving from powerKVM to ppc64le, we should not support older Line 10: cluster levels in newest VDSM for POWER8 platform. Line 11: Line 12: I5c55f66aa526a6b9498f557c964ee1f72885 mentioning the abandoned changeid helps no one. at least not me. so thats the reason why it failed to update the PS :/ Line 13: Line 14: Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 -- To view, visit https://gerrit.ovirt.org/43892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: drop cluster version 3.6 for ppc64le
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: drop cluster version 3.6 for ppc64le .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda0fc1b3716fa9be361a0f60e3639395bb9a174 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
Ido Barkan has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 57: kill_dhclient(self.iface) Line 58: cmd = [self.DHCLIENT.cmd, '-1', '-pf', self.pidFile, '-lf', Line 59:self.leaseFile, self.iface] Line 60: if not EL6: Line 61: cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup) Here you don't check for None self._cgroup. Lets be consistent with ifup. E this code should check if self._cgroup is not None. same as in ifcfg.py Line 62: Line 63: rc, out, err = execCmd(cmd) Line 64: return rc, out, err Line 65: https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 791: Bring up an interface Line 792: def _ifup(netIf): Line 793: cmd = [constants.EXT_IFUP, netIf] Line 794: Line 795: if not EL6 and cgroup is not None: cgroup is a new argument, and I don't see code in this patch calling ifup w this is indeed the same as master. if future backports will pass None, it is supported. Line 796: cmd = cmdutils.systemd_run(cmd, scope=True, slice=cgroup) Line 797: Line 798: rc, out, err = utils.execCmd(cmd, raw=False) Line 799: -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
Ido Barkan has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/33375/5/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 33: import struct Line 34: import xml.etree.cElementTree as etree Line 35: Line 36: from . import constants Line 37: from netaddr import IPNetwork please place in former import block Done Line 38: from .ipwrapper import drv_name Line 39: from .ipwrapper import DUMMY_BRIDGE Line 40: from .ipwrapper import getLink, getLinks, Link Line 41: from .ipwrapper import IPRoute2Error https://gerrit.ovirt.org/#/c/33375/5/tests/netinfoTests.py File tests/netinfoTests.py: Line 353: 192.168.1.9 How about using the test range? I recall that there's another patch brewing Done Line 375: 192.168.1.1 begs to be included as a named CONSTANT Done -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
Ido Barkan has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improve which ipv4 addr is reported.
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. .. Patch Set 5: Code-Review-1 (3 comments) nits https://gerrit.ovirt.org/#/c/33375/5/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 33: import struct Line 34: import xml.etree.cElementTree as etree Line 35: Line 36: from . import constants Line 37: from netaddr import IPNetwork please place in former import block Line 38: from .ipwrapper import drv_name Line 39: from .ipwrapper import DUMMY_BRIDGE Line 40: from .ipwrapper import getLink, getLinks, Link Line 41: from .ipwrapper import IPRoute2Error https://gerrit.ovirt.org/#/c/33375/5/tests/netinfoTests.py File tests/netinfoTests.py: Line 353: 192.168.1.9 How about using the test range? I recall that there's another patch brewing about this. Line 375: 192.168.1.1 begs to be included as a named CONSTANT -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-tool: remove register verb
..
vdsm-tool: remove register verb
git://gerrit.ovirt.org/ovirt-register provides the
generic registration which should deprecate the vdsm-tool
register as the registration must be triggered without
VDSM.
Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M debian/vdsm-python.install
M lib/vdsm/tool/Makefile.am
D lib/vdsm/tool/register.py
M vdsm.spec.in
4 files changed, 0 insertions(+), 553 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/43921/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index d9402c3..b74d0e9 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -37,7 +37,6 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/configurator.py
./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py
./usr/lib/python2.7/dist-packages/vdsm/tool/passwd.py
-./usr/lib/python2.7/dist-packages/vdsm/tool/register.py
./usr/lib/python2.7/dist-packages/vdsm/tool/restore_nets.py
./usr/lib/python2.7/dist-packages/vdsm/tool/service.py
./usr/lib/python2.7/dist-packages/vdsm/tool/transient.py
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index c8979ca..e4afc98 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -37,7 +37,6 @@
nwfilter.py \
configfile.py \
configurator.py \
- register.py \
restore_nets.py \
service.py \
transient.py \
diff --git a/lib/vdsm/tool/register.py b/lib/vdsm/tool/register.py
deleted file mode 100644
index 31121c0..000
--- a/lib/vdsm/tool/register.py
+++ /dev/null
@@ -1,550 +0,0 @@
-# Copyright (C) 2012-2015 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; version 2 of the License.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
-# MA 02110-1301, USA. A copy of the GNU General Public License is
-# also available at http://www.gnu.org/copyleft/gpl.html.
-from __future__ import absolute_import
-import argparse
-import getpass
-import hashlib
-import logging
-import os
-import pwd
-import socket
-import ssl
-import sys
-import tempfile
-
-import requests
-import selinux
-
-from . import expose
-from .. import utils
-
-from vdsm.utils import getHostUUID, tobool
-
-
-class Register(object):
-
-def __init__(self, engine_fqdn, engine_https_port=None,
- fingerprint=None, ssh_port=None,
- ssh_user=None, check_fqdn=True,
- vdsm_port=None, node_fqdn=None,
- node_name=None):
-
-Attributes:
-
-engine_fqdn - Engine FQDN
-engine_https_port - Engine http port
-fingeprint- Fingerprint to be validated
-ssh_user - SSH user that will establish the connection
-from Engine
-ssh_port - Port of ssh daemon is running
-check_fqdn- Validate Engine FQDN against CA (True or False)
-Default is TRUE
-vdsm_port - VDSM listen port
-node_fqdn - Specify node FQDN
-node_name - Specify node name
-
-self.logger = self._set_logger()
-self.logger.debug(===)
-self.logger.debug(Registering the node)
-self.logger.debug(===)
-self.logger.debug(Received the following attributes:)
-
-self.engine_fqdn = engine_fqdn
-self.logger.debug(Engine FQDN: {fqdn}.format(fqdn=self.engine_fqdn))
-
-self.engine_url = https://{e}.format(e=engine_fqdn)
-if engine_https_port is None:
-self.engine_port = 443
-else:
-self.engine_port = engine_https_port
-self.engine_url = https://{e}:{p}.format(e=self.engine_fqdn,
- p=self.engine_port)
-
-self.logger.debug(Engine URL: {url}.format(url=self.engine_url))
-self.logger.debug(Engine https port: {hp}.format(
- hp=self.engine_port))
-
-if check_fqdn is None:
-self.check_fqdn = True
-else:
-self.check_fqdn = tobool(check_fqdn)
-self.logger.debug(Check FQDN:
Change in vdsm[master]: vdsm-tool: remove register verb
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 1: Verified+1 I could build vdsm and generate rpm without register.py -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient
Dan Kenigsberg has posted comments on this change. Change subject: network: add 'default_route' parameter to DhcpClient .. Patch Set 2: Code-Review-1 sounds great! However, do initscripts use -e DEFROUTE=no ? could you mention how ifcfg works fine? Also, I think that you should expose the new arg on runDhclient, and pass defaultRoute into it. -- To view, visit https://gerrit.ovirt.org/43900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient
Petr Horáček has posted comments on this change.
Change subject: network: add 'default_route' parameter to DhcpClient
..
Patch Set 2: Verified+1
testSetupNetworksAddDelDhcp passed with Iproute2 configurator without loosing
internet connectivity. We don't have to verify this with ifcfg while it's
used only in Pyroute and Iproute.
Default gw is not overwritten with DhcpClient('iface', default_route=False):
import sys
import time
sys.path.append('/root/vdsm/lib')
sys.path.append('/root/vdsm/vdsm')
from network.configurators.dhclient import DhcpClient
# prepare veth pair and run dnsmasq
!ip link add name veth_l type veth peer name veth_r
!ip -4 addr add dev veth_l 240.0.0.1/24
!ip link set dev veth_l up
!dnsmasq --dhcp-authoritative -p 0 --dhcp-range=240.0.0.10,240.0.0.100,2m \
| --dhcp-option=3,240.0.0.254 --dhcp-option=6 -i veth_l -I lo --bind-dynamic \
| --dhcp-range=fdb3:84e5:4ff4:55e3::a,fdb3:84e5:4ff4:55e3::64,2m
# setup bridge
!brctl addbr br0
!brctl addif br0 veth_r
!ip link set veth_r up
!ip link set br0 up
# start dhclient with DEFROUTE=no
c = DhcpClient('br0', default_route=False)
c.start(False)
time.sleep(10)
!route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse Iface
0.0.0.0 192.168.122.1 0.0.0.0 UG0 00 eth0
169.254.0.0 0.0.0.0 255.255.0.0 U 1002 00 eth0
192.168.122.0 0.0.0.0 255.255.255.0 U 0 00 eth0
240.0.0.0 0.0.0.0 255.255.255.0 U 0 00 veth_l
240.0.0.0 0.0.0.0 255.255.255.0 U 0 00 br0
c.shutdown()
# start dhclient with DEFROUTE=yes
c = DhcpClient('br0', default_route=True)
c.start(False)
time.sleep(10)
!route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse Iface
0.0.0.0 240.0.0.254 0.0.0.0 UG0 00 br0
169.254.0.0 0.0.0.0 255.255.0.0 U 1002 00 eth0
192.168.122.0 0.0.0.0 255.255.255.0 U 0 00 eth0
240.0.0.0 0.0.0.0 255.255.255.0 U 0 00 veth_l
240.0.0.0 0.0.0.0 255.255.255.0 U 0 00 br0
c.shutdown()
--
To view, visit https://gerrit.ovirt.org/43900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 4: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Open vSwitch configurator
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Open vSwitch configurator .. Patch Set 50: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Barak Azulay bazu...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: change downloaded ca pem filename
automat...@ovirt.org has posted comments on this change. Change subject: change downloaded ca pem filename .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/42837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74669f9eb3a166af36fc4568881902688d28f8b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: change downloaded ca pem filename
Douglas Schilling Landgraf has abandoned this change. Change subject: change downloaded ca pem filename .. Abandoned -- To view, visit https://gerrit.ovirt.org/42837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I74669f9eb3a166af36fc4568881902688d28f8b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient
Petr Horáček has posted comments on this change. Change subject: network: add 'default_route' parameter to DhcpClient .. Patch Set 2: Proper formated output: http://fpaste.org/246917/57379814/ -- To view, visit https://gerrit.ovirt.org/43900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43852/3/vdsm/sudoers.vdsm.in File vdsm/sudoers.vdsm.in: Line 32: @MULTIPATH_PATH@, \ Line 33: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \ Line 34: @SERVICE_PATH@ vdsmd *, \ Line 35: @REBOOT_PATH@ -f, \ Line 36: @SYSTEMD_RUN_PATH@ this is a security breach that should be fixed on master, as it allows vdsm Done Line 37: Line 38: vdsm ALL=(ALL) NOPASSWD: VDSM_LIFECYCLE, VDSM_STORAGE Line 39: Defaults:vdsm !requiretty -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.
automat...@ovirt.org has posted comments on this change. Change subject: net: run dhclient in its own process group. .. Patch Set 8: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
