Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Nir Soffer has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 57: filter_ = lambda x: not x.startswith('_')
Line 58:
Line 59: return set(
Line 60: getmname(module)
Line 61: for module in iglob("%s*.py*" % path)
This will match also foo.pybar :-)
We do not expect to have other files except *.py and *.pyc, but this code is
wrong, and will fail in the future when used in other context.
This is simpler, more clear and correct:
is_module = re.compile(r"^[^_].*\.pyc?$").search
return set(os.path.splitext(name)[0] for name in os.listdir(path) if
is_module(name))
Line 62: if filter_(getmname(module))
Line 63: )
Line 64:
Line 65:
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
automat...@ovirt.org has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 2: * Update tracker::#1259247::OK * Check Bug-Url::OK * Check Public Bug::#1259247::OK, public bug * Check Product::#1259247::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 57: filter_ = lambda x: not x.startswith('_')
Line 58:
Line 59: return [
Line 60: getmname(module)
Line 61: for module in iglob("%s*.py*" % path)
> Good point, this should remove duplicate names before returning the result.
no order. and I like the set cast though we don't have any problem with having
the same name twice, but I guess its just redundant or a waste
Line 62: if filter_(getmname(module))
Line 63: ]
Line 64:
Line 65:
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 2: * Update tracker::#1259310::OK * Set MODIFIED::bug 1259310#1259310IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
Yaniv Bronhaim has submitted this change and it was merged. Change subject: supervdsm: don't let _runAs return early due to EINTR .. supervdsm: don't let _runAs return early due to EINTR When _runAs executes a command, it polls a pipe to determine status of that command. The poll has a timeout, also allowing the child to be killed if execution takes too long. If a stray signal is received by the parent process, it may cause the poll to return early, prematurely ending child command execution ending in unintentional failure. This is particularly prevalant when subsequent _runAs executions are performed. Termination of the first will result in a SIGCHLD which interrupts polling for the second, as exposed by commit 777c36d6. Because poll will return early without an exception if the low-level call is interrupted, NoIntrCall() cannot be used and thus a new helper function is provided that retries based on the time elapsed since the call started. PEP-475 will handle this in Python 3.5, but in the meantime this workaround is needed. Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1259310 Signed-off-by: Greg Padgett Reviewed-On: https://gerrit.ovirt.org/45752 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Tested-by: Greg Padgett Reviewed-on: https://gerrit.ovirt.org/45885 Reviewed-by: Yaniv Bronhaim --- M vdsm/supervdsmServer 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Greg Padgett: Verified Yaniv Bronhaim: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: make removeNic cope with a missing ifcfg file
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: make removeNic cope with a missing ifcfg file
..
Patch Set 1: Code-Review-1
(1 comment)
Exception handling is maybe too granular for no benefit (but errno should still
be logged).
https://gerrit.ovirt.org/#/c/45893/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:
Line 660: logging.warning("%s didn't exist, HWADDR is unknown", cf)
: else:
: logging.exception("%s couldn't be read, HWADDR is
unknown", cf)
Okay, this is wasteful.
--
To view, visit https://gerrit.ovirt.org/45893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: make removeNic cope with a missing ifcfg file
automat...@ovirt.org has posted comments on this change. Change subject: ifcfg: make removeNic cope with a missing ifcfg file .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: make removeNic cope with a missing ifcfg file
Ondřej Svoboda has uploaded a new change for review.
Change subject: ifcfg: make removeNic cope with a missing ifcfg file
..
ifcfg: make removeNic cope with a missing ifcfg file
The file is only read to be able to write back the HWADDR property.
This information may already be available in ConfigWriter._backups,
but let's just patch around the obvious problem first.
Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Signed-off-by: Ondřej Svoboda
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/45893/1
diff --git a/vdsm/network/configurators/ifcfg.py
b/vdsm/network/configurators/ifcfg.py
index 161a3b2..6315b15 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -647,11 +647,24 @@
def removeNic(self, nic):
cf = netinfo.NET_CONF_PREF + nic
self._backup(cf)
-with open(cf) as nicFile:
-hwlines = [line for line in nicFile if line.startswith('HWADDR=')]
+
+try:
+with open(cf) as nicFile:
+# TODO: how about getting the MAC from netinfo.gethwaddr or
+# self._backups instead?
+hwlines = [line for line in nicFile if line.startswith(
+'HWADDR=')]
+except IOError as e:
+if e.errno == os.errno.ENOENT:
+# TODO: does logging not work during network restoration?
+logging.warning("%s didn't exist, HWADDR is unknown", cf)
+else:
+logging.exception("%s couldn't be read, HWADDR is unknown", cf)
+hwlines = []
+
l = [self.CONFFILE_HEADER + '\n', 'DEVICE=%s\n' % nic, 'ONBOOT=yes\n',
'MTU=%s\n' % netinfo.DEFAULT_MTU] + hwlines
-l += 'NM_CONTROLLED=no\n'
+l += 'NM_CONTROLLED=no\n' # TODO: why care?
with open(cf, 'w') as nicFile:
nicFile.writelines(l)
--
To view, visit https://gerrit.ovirt.org/45893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: revert "storage: validate vdsm rwx permissions for file stor...
Greg Padgett has posted comments on this change. Change subject: revert "storage: validate vdsm rwx permissions for file storage" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: revert "storage: validate vdsm rwx permissions for file stor...
automat...@ovirt.org has posted comments on this change. Change subject: revert "storage: validate vdsm rwx permissions for file storage" .. Patch Set 1: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1250752::OK, public bug * Check Product::#1250752::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: revert "storage: validate vdsm rwx permissions for file stor...
Greg Padgett has uploaded a new change for review. Change subject: revert "storage: validate vdsm rwx permissions for file storage" .. revert "storage: validate vdsm rwx permissions for file storage" This reverts commit 777c36d64f9fe0aee69fe6ed9049262accff54d3 The above patch triggers a race condition in supervdsm's _runAs() method which can prevent file-based storage domains from being added, thus this patch needs to be reverted. Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Bug-Url: https://bugzilla.redhat.com/1259310 Related-To: https://bugzilla.redhat.com/1250752 Signed-off-by: Greg Padgett Reviewed-on: https://gerrit.ovirt.org/45891 Continuous-Integration: Jenkins CI --- M vdsm/storage/fileSD.py 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/45892/1 diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index ec46d18..2feb6b5 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -67,10 +67,6 @@ try: getProcPool().fileUtils.validateAccess(dirPath) supervdsm.getProxy().validateAccess( -constants.VDSM_USER, -(constants.VDSM_GROUP,), dirPath, -(os.R_OK | os.W_OK | os.X_OK)) -supervdsm.getProxy().validateAccess( constants.QEMU_PROCESS_USER, (constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath, (os.R_OK | os.X_OK)) -- To view, visit https://gerrit.ovirt.org/45892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: revert "storage: validate vdsm rwx permissions for file stor...
Greg Padgett has posted comments on this change. Change subject: revert "storage: validate vdsm rwx permissions for file storage" .. Patch Set 1: Verified+1 An alternative to https://gerrit.ovirt.org/#/c/45752/ -- To view, visit https://gerrit.ovirt.org/45891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: revert "storage: validate vdsm rwx permissions for file stor...
Greg Padgett has uploaded a new change for review. Change subject: revert "storage: validate vdsm rwx permissions for file storage" .. revert "storage: validate vdsm rwx permissions for file storage" This reverts commit 777c36d64f9fe0aee69fe6ed9049262accff54d3 The above patch triggers a race condition in supervdsm's _runAs() method which can prevent file-based storage domains from being added, thus this patch needs to be reverted. Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Bug-Url: https://bugzilla.redhat.com/1259310 Related-To: https://bugzilla.redhat.com/1250752 Signed-off-by: Greg Padgett --- M vdsm/storage/fileSD.py 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/45891/1 diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index 5c9aa6d..b74b4b4 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -67,10 +67,6 @@ try: getProcPool().fileUtils.validateAccess(dirPath) supervdsm.getProxy().validateAccess( -constants.VDSM_USER, -(constants.VDSM_GROUP,), dirPath, -(os.R_OK | os.W_OK | os.X_OK)) -supervdsm.getProxy().validateAccess( constants.QEMU_PROCESS_USER, (constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath, (os.R_OK | os.X_OK)) -- To view, visit https://gerrit.ovirt.org/45891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: revert "storage: validate vdsm rwx permissions for file stor...
automat...@ovirt.org has posted comments on this change. Change subject: revert "storage: validate vdsm rwx permissions for file storage" .. Patch Set 1: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1250752::OK, public bug * Check Product::#1250752::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: more meaningful name of address param
Nir Soffer has posted comments on this change. Change subject: jsonrpc: more meaningful name of address param .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45839/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 244: "]") Line 245: Line 246: Line 247: class _JsonRpcServeRequestContext(object): Line 248: def __init__(self, client, server_address): This is always the server address - right? (In a previous patch you explained that we reuse this code in both client and server) Line 249: self._requests = [] Line 250: self._client = client Line 251: self._server_address = server_address Line 252: self._counter = 0 -- To view, visit https://gerrit.ovirt.org/45839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1aaba81cadd84e6264e7f59e552879f26d74cbc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
Nir Soffer has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
Greg Padgett has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 1: Verified+1 Backported to 3.6 from sandbox and added metadata by hand, since this is an urgent patch. Merge to master and acks are pending. -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 1: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1259310::OK, public bug * Check Product::#1259310::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: don't let _runAs return early due to EINTR
Hello Greg Padgett, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/45885 to review the following change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. supervdsm: don't let _runAs return early due to EINTR When _runAs executes a command, it polls a pipe to determine status of that command. The poll has a timeout, also allowing the child to be killed if execution takes too long. If a stray signal is received by the parent process, it may cause the poll to return early, prematurely ending child command execution ending in unintentional failure. This is particularly prevalant when subsequent _runAs executions are performed. Termination of the first will result in a SIGCHLD which interrupts polling for the second, as exposed by commit 777c36d6. Because poll will return early without an exception if the low-level call is interrupted, NoIntrCall() cannot be used and thus a new helper function is provided that retries based on the time elapsed since the call started. PEP-475 will handle this in Python 3.5, but in the meantime this workaround is needed. Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1259310 Signed-off-by: Greg Padgett Reviewed-On: https://gerrit.ovirt.org/45752 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Tested-by: Greg Padgett --- M vdsm/supervdsmServer 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/45885/1 diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer index 978fc18..c5766a3 100755 --- a/vdsm/supervdsmServer +++ b/vdsm/supervdsmServer @@ -118,6 +118,26 @@ return wrapper +def safe_poll(mp_connection, timeout): +""" +This is a workaround until we get the PEP-475 fix for EINTR. It +ensures that a multiprocessing.connection.poll() will not return +before the timeout due to an interruption. + +Returns True if there is any data to read from the pipe or if the +pipe was closed. Returns False if the timeout expired. +""" +deadline = utils.monotonic_time() + timeout +remaining = timeout + +while not mp_connection.poll(remaining): +remaining = deadline - utils.monotonic_time() +if remaining <= 0: +return False + +return True + + class _SuperVdsm(object): UDEV_WITH_RELOAD_VERSION = 181 @@ -246,7 +266,7 @@ needReaping = True try: -if not pipe.poll(RUN_AS_TIMEOUT): +if not safe_poll(pipe, RUN_AS_TIMEOUT): try: os.kill(proc.pid, signal.SIGKILL) -- To view, visit https://gerrit.ovirt.org/45885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Greg Padgett ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
Nir Soffer has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 5: Code-Review+2 Pitor should approve this, but he is not around, and this is pretty urgent. -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
Greg Padgett has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 5: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1259310::OK, public bug * Check Product::#1259310::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
Nir Soffer has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/45752/4/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 122: def safe_poll(mp_connection, timeout): Line 123: """ Line 124: This is a workaround until we get the PEP-475 fix for EINTR. It Line 125: ensures that a multiprocessing.connection.poll() will not return Line 126: before the timeout due to an interruption. Lets document the new behavior: Returns True if there is any data to read from the pipe. Returns False if the timeout expired. Line 127: """ Line 128: deadline = utils.monotonic_time() + timeout Line 129: remaining = timeout Line 130: -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 4: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1259310::OK, public bug * Check Product::#1259310::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
Greg Padgett has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 3: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1259310::OK, public bug * Check Product::#1259310::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: startSpm - clusterlock inquire leads to failure
Nir Soffer has posted comments on this change. Change subject: sp: startSpm - clusterlock inquire leads to failure .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082dc83ea410768db3819e7259089c20c2614b07 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: moving InquireNotSupportedError to storage_exception.py
Nir Soffer has posted comments on this change. Change subject: core: moving InquireNotSupportedError to storage_exception.py .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8201794dc96ee24dc9c0da5b7c3d71ab0b75e9f3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 7: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: startSpm - clusterlock inquire leads to failure
automat...@ovirt.org has posted comments on this change. Change subject: sp: startSpm - clusterlock inquire leads to failure .. Patch Set 2: * Update tracker::#1242092::OK * Check Bug-Url::OK * Check Public Bug::#1242092::OK, public bug * Check Product::#1242092::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082dc83ea410768db3819e7259089c20c2614b07 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: moving InquireNotSupportedError to storage_exception.py
automat...@ovirt.org has posted comments on this change. Change subject: core: moving InquireNotSupportedError to storage_exception.py .. Patch Set 2: * Update tracker::#1242092::OK * Check Bug-Url::OK * Check Public Bug::#1242092::OK, public bug * Check Product::#1242092::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8201794dc96ee24dc9c0da5b7c3d71ab0b75e9f3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: lock pool when running upgradeStoragePool
automat...@ovirt.org has posted comments on this change. Change subject: hsm: lock pool when running upgradeStoragePool .. Patch Set 3: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d5b65a75b1b50d5f5991334cf6221c067a31f5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
Greg Padgett has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
Greg Padgett has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 1: (6 comments) Thanks Nir, comments inline https://gerrit.ovirt.org/#/c/45752/1//COMMIT_MSG Commit Message: Line 13: ending child command execution ending in unintentional failure. Line 14: Line 15: This is particularly prevalant when subsequent _runAs executions are Line 16: performed. Termination of the first will result in a SIGCHLD which Line 17: interrupts polling for the second, as exposed by commit 777c36d6. > So this is a regression triggered by the new check in 777c36d6? Yes, you could say that. It revealed a race that seems to happen every time in hosted engine setup but (in my case at least) less frequently when setting up a file domain on a regular host. Line 18: Line 19: Because poll will return early without an exception if the low-level Line 20: call is interrupted, NoIntrCall() cannot be used and thus a new helper Line 21: function is provided that retries based on the time elapsed since the Line 23: Line 24: PEP-475 will handle this in Python 3.5, but in the meantime this Line 25: workaround is needed. Line 26: Line 27: Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa > We want to backport this to 3.6 - right? Done Line 28: Bug-Url: https://bugzilla.redhat.com/1259310 https://gerrit.ovirt.org/#/c/45752/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 353: This is a workaround until we get the PEP-475 fix for EINTR. It Line 354: ensures that a multiprocessing.connection.poll() will not return Line 355: before the timeout due to an interruption. Line 356: """ Line 357: end = monotonic_time() + timeout > Lets call it deadline for consistently with other code using this pattern. Done Line 358: remaining = timeout Line 359: Line 360: while not mpConnection.poll(remaining): Line 361: remaining = end - monotonic_time() Line 359: Line 360: while not mpConnection.poll(remaining): Line 361: remaining = end - monotonic_time() Line 362: if remaining > 0: Line 363: continue > Why not: Done Line 364: return False Line 365: Line 366: return True Line 367: https://gerrit.ovirt.org/#/c/45752/1/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 244: proc.start() Line 245: Line 246: needReaping = True Line 247: try: Line 248: if not utils.NoIntrMPConnPoll(pipe, RUN_AS_TIMEOUT): > Another nicer option - subclass Pipe, and fix its poll function: I like this, but multiprocessing.Pipe returns a multiprocessing.connection object that holds the poll method. We could wrap Pipe and return a new connection object with a wrapped poll method, but it seems overly complicated compared to simply calling a method with our fix. Thoughts? Line 249: try: Line 250: Line 251: os.kill(proc.pid, signal.SIGKILL) Line 252: except OSError as e: Line 244: proc.start() Line 245: Line 246: needReaping = True Line 247: try: Line 248: if not utils.NoIntrMPConnPoll(pipe, RUN_AS_TIMEOUT): > This name is little ugly and it is also not really generic helper for utils Done Line 249: try: Line 250: Line 251: os.kill(proc.pid, signal.SIGKILL) Line 252: except OSError as e: -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: startSpm - ignore InquireNotSupportedError()
Liron Aravot has posted comments on this change.
Change subject: sp: startSpm - ignore InquireNotSupportedError()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45764/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 252: try:
Line 253: oldlver, oldid = self._backend.getSpmStatus()
Line 254: except se.InquireNotSupportedError:
Line 255: self.log.info("cluster lock inquire isn't supported. "
Line 256: "proceeding with startSpm()")
> This is an expected condition during upgrade, but vdsm does not have any co
I'm also leaning toward having that as an info, Allon - any objection?
Line 257: else:
Line 258: if int(oldlver) != int(prevLVER) or int(oldid) !=
int(prevID):
Line 259: self.log.info("expected previd:%s lver:%s got
request for "
Line 260: "previd:%s lver:%s" %
--
To view, visit https://gerrit.ovirt.org/45764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I082dc83ea410768db3819e7259089c20c2614b07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: startSpm - ignore InquireNotSupportedError()
Liron Aravot has posted comments on this change.
Change subject: sp: startSpm - ignore InquireNotSupportedError()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45764/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 247: raise se.CurrentVersionTooAdvancedError(
Line 248: self.masterDomain.sdUUID, curVer=masterDomVersion,
Line 249: expVer=expectedDomVersion)
Line 250:
Line 251: oldlver = LVER_INVALID
> Init in the expect
Done
Line 252: try:
Line 253: oldlver, oldid = self._backend.getSpmStatus()
Line 254: except se.InquireNotSupportedError:
Line 255: self.log.info("cluster lock inquire isn't supported. "
--
To view, visit https://gerrit.ovirt.org/45764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I082dc83ea410768db3819e7259089c20c2614b07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: moving InquireNotSupportedError to storage_exception.py
Liron Aravot has posted comments on this change.
Change subject: core: moving InquireNotSupportedError to storage_exception.py
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/45763/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 599: # This happens when we cannot read the MD LV
Line 600: self.log.error("Can't read LV based metadata",
exc_info=True)
Line 601: raise se.StorageDomainMasterError("Can't read LV based
metadata")
Line 602: except se.InquireNotSupportedError:
Line 603: self.log.error("Inquire spm status isn't supported by the
used cluster lock", exc_info=True)
> - line too long
Done
Line 604: raise
Line 605: except se.StorageException as e:
Line 606: self.log.error("MD read error: %s", str(e), exc_info=True)
Line 607: raise se.StorageDomainMasterError("MD read error")
https://gerrit.ovirt.org/#/c/45763/1/vdsm/storage/storage_exception.py
File vdsm/storage/storage_exception.py:
Line 1618: message = "Could not initialize cluster lock"
Line 1619:
Line 1620: class InquireNotSupportedError(StorageException):
Line 1621: code = 702
Line 1622: message = "Cluster lock inquire isnt supported"
> Cluster lock does not support inquire?
we inquire the cluster lock, not inquiring using the cluster lock..so i'd
prefer the current message.
Line 1623:
Line 1624: #
Line 1625: # Meta data related Exceptions
Line 1626: #
--
To view, visit https://gerrit.ovirt.org/45763
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8201794dc96ee24dc9c0da5b7c3d71ab0b75e9f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: don't let _runAs return early due to EINTR
automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR .. Patch Set 2: * Update tracker::#1259310::OK * Check Bug-Url::OK * Check Public Bug::#1259310::OK, public bug * Check Product::#1259310::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spmprotect: Switch from fencing by pid to fencing using syst...
Nir Soffer has posted comments on this change. Change subject: spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/43211/8//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-05 14:36:43 +0300 Line 4: Commit: Nir Soffer Line 5: CommitDate: 2015-09-08 19:50:44 +0300 Line 6: Line 7: spmprotect: Switch from fencing by pid to fencing using systemctl - When this was broken - What is the possible result Line 8: Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1222564 Line 10: Change-Id: Ifdea618514232a1f751afae54337de787f297b9e -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spmprotect: Switch from fencing by pid to fencing using syst...
automat...@ovirt.org has posted comments on this change. Change subject: spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 8: * Update tracker::#1222564::OK * Check Bug-Url::OK * Check Public Bug::#1222564::OK, public bug * Check Product::#1222564::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
Nir Soffer has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 10: -Code-Review Needs manual rebase, better rewrite it. -- To view, visit https://gerrit.ovirt.org/19255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Nir Soffer has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 57: filter_ = lambda x: not x.startswith('_')
Line 58:
Line 59: return [
Line 60: getmname(module)
Line 61: for module in iglob("%s*.py*" % path)
> Is it an issue if both py and pyc are loaded?
Good point, this should remove duplicate names before returning the result. It
can return a set() to simplify things, since module names do not have order -
right?
Line 62: if filter_(getmname(module))
Line 63: ]
Line 64:
Line 65:
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Reformat device info dict
Nir Soffer has posted comments on this change.
Change subject: hsm: Reformat device info dict
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45845/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2024: pvsize = ""
Line 2025: vguuid = ""
Line 2026:
Line 2027: devInfo = {
Line 2028: "serial": dev.get("serial", ""),
> If it is sorted, "serial" should not be first.
Thanks, will fix ( " < ' )
Line 2029: 'GUID': dev.get("guid", ""),
Line 2030: 'capacity': dev.get("capacity", "0"),
Line 2031: 'devtype': dev.get("devtype", ""),
Line 2032: 'fwrev': dev.get("fwrev", ""),
--
To view, visit https://gerrit.ovirt.org/45845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Nir Soffer has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 6: Code-Review+1 Looks good, need more time to think about this change before approving it. -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: lock pool when running upgradeStoragePool
Nir Soffer has posted comments on this change. Change subject: hsm: lock pool when running upgradeStoragePool .. Patch Set 2: Code-Review+1 Looks good, need more time to think about this change before approving it. -- To view, visit https://gerrit.ovirt.org/45866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d5b65a75b1b50d5f5991334cf6221c067a31f5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
Liron Aravot has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45774/5/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 422:
Line 423: sd.validateDomainVersion(targetDomVersion)
Line 424: try:
Line 425: self.log.info("Trying to lock domains that are
currently pending for an update")
Line 426: for sdUUID in self._domainsToUpgrade:
> need to sort the domains here and in shutdownupgrade.
actually unneed, both flows take lock on the pool beforehand.
Line 427: try:
Line 428: res = rmanager.acquireResource(STORAGE,
"upgrade_" + sdUUID,
Line 429:
rm.LockType.exclusive)
Line 430: except (rm.RequestTimedOutError,
se.ResourceAcqusitionFailed):
--
To view, visit https://gerrit.ovirt.org/45774
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
automat...@ovirt.org has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 6: * Update tracker::#1260428::OK * Check Bug-Url::OK * Check Public Bug::#1260428::OK, public bug * Check Product::#1260428::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
Liron Aravot has restored this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Restored -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 6: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: lock pool when running upgradeStoragePool
automat...@ovirt.org has posted comments on this change. Change subject: hsm: lock pool when running upgradeStoragePool .. Patch Set 2: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d5b65a75b1b50d5f5991334cf6221c067a31f5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
Liron Aravot has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45774/5/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 422:
Line 423: sd.validateDomainVersion(targetDomVersion)
Line 424: try:
Line 425: self.log.info("Trying to lock domains that are
currently pending for an update")
Line 426: for sdUUID in self._domainsToUpgrade:
need to sort the domains here and in shutdownupgrade.
Line 427: try:
Line 428: res = rmanager.acquireResource(STORAGE,
"upgrade_" + sdUUID,
Line 429:
rm.LockType.exclusive)
Line 430: except (rm.RequestTimedOutError,
se.ResourceAcqusitionFailed):
--
To view, visit https://gerrit.ovirt.org/45774
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
automat...@ovirt.org has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 5: * Update tracker::#1260428::OK -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
Liron Aravot has abandoned this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Abandoned -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 5: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
automat...@ovirt.org has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 5: * Update tracker::#1260428::OK * Check Bug-Url::OK * Check Public Bug::#1260428::OK, public bug * Check Product::#1260428::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tmp
automat...@ovirt.org has posted comments on this change. Change subject: tmp .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d5b65a75b1b50d5f5991334cf6221c067a31f5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tmp
Liron Aravot has uploaded a new change for review.
Change subject: tmp
..
tmp
Change-Id: I1d5b65a75b1b50d5f5991334cf6221c067a31f5b
Signed-off-by: Liron Aravot
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/45866/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 5583f76..7050fcf 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3512,7 +3512,11 @@
def upgradeStoragePool(self, spUUID, targetDomVersion):
targetDomVersion = int(targetDomVersion)
pool = self.getPool(spUUID)
-pool._upgradePool(targetDomVersion)
+# This lock has to be mutual with the pool metadata operations (like
+# activateSD/deactivateSD) as it uses the pool metadata.
+with rmanager.acquireResource(STORAGE, spUUID,
+ rm.LockType.exclusive):
+pool._upgradePool(targetDomVersion)
return {"upgradeStatus": "started"}
def _getDomsStats(self, domainMonitor, doms):
--
To view, visit https://gerrit.ovirt.org/45866
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d5b65a75b1b50d5f5991334cf6221c067a31f5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 4: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
automat...@ovirt.org has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 4: * Update tracker::#1260428::OK * Check Bug-Url::OK * Check Public Bug::#1260428::OK, public bug * Check Product::#1260428::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
automat...@ovirt.org has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 3: * Update tracker::#1260428::OK * Check Bug-Url::OK * Check Public Bug::#1260428::OK, public bug * Check Product::#1260428::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 3: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Nir Soffer has posted comments on this change.
Change subject: sp: deactivateSd - remove domain from pending for upgrade list
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45773/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 3514: pool = self.getPool(spUUID)
Line 3515: # This lock has to be mutual with the pool metadata
operations (like
Line 3516: # activateSD/deactivateSD) as it uses the pool metadata.
Line 3517: with rmanager.acquireResource(STORAGE, spUUID,
Line 3518: rm.LockType.exclusive):
Check that acquireResource will is a try lock with a timeout.
Line 3519: pool._upgradePool(targetDomVersion)
Line 3520: return {"upgradeStatus": "started"}
Line 3521:
Line 3522: def _getDomsStats(self, domainMonitor, doms):
--
To view, visit https://gerrit.ovirt.org/45773
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve safety between startup and shutdown
automat...@ovirt.org has posted comments on this change. Change subject: vm: improve safety between startup and shutdown .. Patch Set 2: * Update tracker::#912390::OK * Check Bug-Url::OK * Check Public Bug::#912390::OK, public bug * Check Product::#912390::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scsi: Scan only the required domain type
Freddy Rolland has posted comments on this change. Change subject: scsi: Scan only the required domain type .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Reformat device info dict
Freddy Rolland has posted comments on this change.
Change subject: hsm: Reformat device info dict
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45845/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2028: "serial": dev.get("serial", "")
If it is sorted, "serial" should not be first.
--
To view, visit https://gerrit.ovirt.org/45845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
Nir Soffer has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending
update
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/45774/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 427: rm.LockType.exclusive):
Line 428: acquiredDomainResources = []
Line 429:
Line 430: sd.validateDomainVersion(targetDomVersion)
Line 431: try:
> plese elaborate, i didn't understand what you meant to.
try finaly is fragile and error prone, do not use it when you can use with.
Line 432: self.log.info("Trying to lock domains that are
currently pending for an update")
Line 433: for sdUUID in self._domainsToUpgrade:
Line 434: try:
Line 435: res = rmanager.acquireResource(STORAGE,
"upgrade_" + sdUUID,
Line 432: self.log.info("Trying to lock domains that are
currently pending for an update")
Line 433: for sdUUID in self._domainsToUpgrade:
Line 434: try:
Line 435: res = rmanager.acquireResource(STORAGE,
"upgrade_" + sdUUID,
Line 436:
rm.LockType.exclusive)
> Instead of failing immediately when len(self._domainsToUpgrade) > 0 we have
_shutDownUpgrade is a list, which is thread safe in Python.
If we fixed the issue of cleaning up pending upgrades when deactivating a
domain, a user can put domain to maintenance if the domain is not accessible
(the reason the upgrade is left pending).
If we want to support this, maybe only in master, we need a simple change that
does not try to lock so many things in the same time.
For example, keeping upgrade state in the pool, so we can easily fail here if a
domain is upgrade is running, and a domain upgrade will be canceled if pull
upgrade was started. Having to take 10's of locks to manage state is not
maintainable.
Or maybe using current code - did you look in _shutdownUpgrade?
Not sure that we should get into this tricky stuff, the current code failing on
non-empty _domainsToUpgrade is much safer.
Line 437: except (rm.RequestTimedOutError,
se.ResourceAcqusitionFailed):
Line 438: self.log.info("Cannot acquire domain upgrade
resource '%s'", str(sdUUID))
Line 439: raise se.PoolUpgradeInProgress(self.spUUID,
self.sdUUID)
Line 440: else:
Line 453: except ValueError:
Line 454: pass
Line 455: finally:
Line 456: for res in acquiredDomainResources:
Line 457: res.release()
> same as the rest of the code - we are under the assumption that it shouldn'
Having bad code elsewhere is not a good reason to add more.
Line 458:
Line 459: self.log.debug("Registering with state change event")
Line 460: self.domainMonitor.onDomainStateChange.register(
Line 461: self._upgradeCallback)
--
To view, visit https://gerrit.ovirt.org/45774
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Report vg name in getDeviceList
Freddy Rolland has posted comments on this change. Change subject: hsm: Report vg name in getDeviceList .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116714cb5143ea92f5cb54c3f80f895c07ada536 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Liron Aravot has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45773/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1094 Line 1095 Line 1096 Line 1097 Line 1098 > Ok, since in deactivateStoargeDomain flow we are holding both the pool and we need to have a mutual lock between the upgrade and the metadata operations, that was handled by the lock on my change here. but its actually better to add the lock to the upgrade rather then to this verb (as it'll fix it for other scenarios as well..but has a wider scope). -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 2: * Update tracker::#1260429::OK * Check Bug-Url::OK * Check Public Bug::#1260429::OK, public bug * Check Product::#1260429::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
automat...@ovirt.org has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 2: * Update tracker::#1260428::OK * Check Bug-Url::OK * Check Public Bug::#1260428::OK, public bug * Check Product::#1260428::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Liron Aravot has restored this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Restored -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: caps: more precise emulated machines selection
Francesco Romani has posted comments on this change. Change subject: caps: more precise emulated machines selection .. Patch Set 1: Verified+1 jenkins failure unrelated: 00:05:38.760 == 00:05:38.760 ERROR: Tests mkimage.mkIsoFs creating an image and checking its content 00:05:38.760 -- 00:05:38.760 Traceback (most recent call last): 00:05:38.760 File "/home/jenkins/workspace/vdsm_3.6_check-patch-fc22-x86_64/vdsm/tests/testlib.py", line 65, in wrapper 00:05:38.760 return f(self, *args) 00:05:38.760 File "/home/jenkins/workspace/vdsm_3.6_check-patch-fc22-x86_64/vdsm/tests/mkimageTests.py", line 189, in test_mkIsoFs 00:05:38.760 m.mount(mntOpts='loop') 00:05:38.760 File "/home/jenkins/workspace/vdsm_3.6_check-patch-fc22-x86_64/vdsm/vdsm/storage/mount.py", line 225, in mount 00:05:38.760 return self._runcmd(cmd, timeout) 00:05:38.760 File "/home/jenkins/workspace/vdsm_3.6_check-patch-fc22-x86_64/vdsm/vdsm/storage/mount.py", line 241, in _runcmd 00:05:38.760 raise MountError(rc, ";".join((out, err))) 00:05:38.760 MountError: (32, ';mount: /tmp/tmpTLBKwu/vmId_iso.413f2aff7d7b797cfd6c864f9d204027.img: failed to setup loop device: No such file or directory\n') 00:05:38.760 >> begin captured logging << 00:05:38.760 root: DEBUG: /usr/bin/mkisofs -R -J -o /tmp/tmpTLBKwu/vmId_iso.413f2aff7d7b797cfd6c864f9d204027.img /tmp/tmpBnd0Az (cwd None) 00:05:38.760 root: DEBUG: SUCCESS: = 'Total translation table size: 0\nTotal rockridge attributes bytes: 1796\nTotal directory bytes: 8192\nPath table size(bytes): 64\nMax brk space used 21000\n199 extents written (0 MB)\n'; = 0 00:05:38.760 Storage.Misc.excCmd: DEBUG: /usr/bin/mount -o loop /tmp/tmpTLBKwu/vmId_iso.413f2aff7d7b797cfd6c864f9d204027.img /tmp/tmpuUEZWC (cwd None) This change is coverd by tests; additionally, verified booting a VM on RHEL7.1 box. -- To view, visit https://gerrit.ovirt.org/45850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
automat...@ovirt.org has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 1: * Update tracker::#1260429::OK -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Liron Aravot has abandoned this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Abandoned -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: fix vdsmd service start
Petr Horáček has posted comments on this change. Change subject: net: fix vdsmd service start .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/45787/2//COMMIT_MSG Commit Message: Line 13: VDSM networks uses DHCP and `service network start` tries to run Line 14: it second time. Line 15: Line 16: With `service network restart` we first put dhclients down and then up. Line 17: > please add Done Line 18: Change-Id: I71342362f56b87bcb566c3343c90a69f95327ea6 Line 19: Bug-Url: https://bugzilla.redhat.com/1258551 -- To view, visit https://gerrit.ovirt.org/45787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71342362f56b87bcb566c3343c90a69f95327ea6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: fix vdsmd service start
automat...@ovirt.org has posted comments on this change. Change subject: net: fix vdsmd service start .. Patch Set 3: * Update tracker::#1258551::OK * Check Bug-Url::OK * Check Public Bug::#1258551::OK, public bug * Check Product::#1258551::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1258551::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/45787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71342362f56b87bcb566c3343c90a69f95327ea6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: caps: more precise emulated machines selection
automat...@ovirt.org has posted comments on this change. Change subject: caps: more precise emulated machines selection .. Patch Set 1: * Update tracker::#1239258::OK * Check Bug-Url::OK * Check Public Bug::#1239258::OK, public bug * Check Product::#1239258::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: caps: more precise emulated machines selection
Hello Dan Kenigsberg, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/45850
to review the following change.
Change subject: caps: more precise emulated machines selection
..
caps: more precise emulated machines selection
Current VDSM code fetches emulated machines from the section which matches
first the required architecture.
This works in the simplest (and the only recommended) case, but doesn't
if, for any reason, there is more than one valid emulatore for a given
architecture.
The only known case is if the user managed to install qemu-kvm alongside
plain qemu.
This patch implements more robust capabilities fetching to deal with
this corner case.
Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3
Bug-Url: https://bugzilla.redhat.com/1239258
Signed-off-by: Francesco Romani
Reviewed-on: https://gerrit.ovirt.org/45257
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik
Reviewed-by: Dan Kenigsberg
---
M tests/Makefile.am
M tests/capsTests.py
A tests/caps_libvirt_multiqemu.out
M vdsm.spec.in
M vdsm/caps.py
5 files changed, 606 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/45850/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 174982c..e247551 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -154,6 +154,7 @@
caps_libvirt_intel_E5606.out \
caps_libvirt_intel_i73770.out \
caps_libvirt_intel_i73770_nosnap.out \
+ caps_libvirt_multiqemu.out \
cpu_map.xml \
caps_numactl_4_nodes.out \
glusterGeoRepStatus.xml \
diff --git a/tests/capsTests.py b/tests/capsTests.py
index 1bdccce..a70de5f 100644
--- a/tests/capsTests.py
+++ b/tests/capsTests.py
@@ -317,6 +317,24 @@
'pc-i440fx-rhel7.0.0']
self.assertEqual(expected, result)
+def test_getEmulatedMachinesWithTwoQEMUInstalled(self):
+capsData = self._readCaps("caps_libvirt_multiqemu.out")
+result = caps._getEmulatedMachines('x86_64', capsData)
+expected = ['pc-i440fx-rhel7.1.0',
+'rhel6.3.0',
+'pc-q35-rhel7.0.0',
+'rhel6.1.0',
+'rhel6.6.0',
+'rhel6.2.0',
+'pc',
+'pc-q35-rhel7.1.0',
+'q35',
+'rhel6.4.0',
+'rhel6.0.0',
+'rhel6.5.0',
+'pc-i440fx-rhel7.0.0']
+self.assertEqual(expected, result)
+
def test_getNumaTopology(self):
capsData = self._readCaps("caps_libvirt_intel_i73770_nosnap.out")
result = caps.getNumaTopology(capsData)
diff --git a/tests/caps_libvirt_multiqemu.out b/tests/caps_libvirt_multiqemu.out
new file mode 100644
index 000..38e962f
--- /dev/null
+++ b/tests/caps_libvirt_multiqemu.out
@@ -0,0 +1,547 @@
+
+
+
+8760ad12-e4e8-43ca-8a11-93c59fbf148d
+
+ x86_64
+ SandyBridge
+ Intel
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+tcp
+rdma
+
+
+
+
+
+ 33444704
+ 8361176
+ 0
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ 33554432
+ 8388608
+ 0
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ selinux
+ 0
+ system_u:system_r:svirt_t:s0
+ system_u:system_r:svirt_tcg_t:s0
+
+
+ dac
+ 0
+ +107:+107
+ +107:+107
+
+
+
+
+hvm
+
+ 64
+ /usr/bin/qemu-system-alpha
+ clipper
+
+
+
+
+
+
+
+
+
+
+hvm
+
+ 32
+ /usr/bin/qemu-system-arm
+ borzoi
+ virt
+ midway
+ tosa
+ cheetah
+ realview-pb-a8
+ collie
+ n800
+ highbank
+ kzm
+ integratorcp
+ sx1-v1
+ smdkc210
+ akita
+ canon-a1100
+ spitz
+ verdex
+ xilinx-zynq-a9
+ realview-eb-mpcore
+ nuri
+ vexpress-a15
+ n810
+ terrier
+ mainstone
+ musicpal
+ realview-pbx-a9
+ lm3s6965evb
+ vexpress-a9
+ cubieboard
+ realview-eb
+
Change in vdsm[master]: net: fix test_getVdsStats
automat...@ovirt.org has posted comments on this change. Change subject: net: fix test_getVdsStats .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib41b6c942a5f7158e7520e9f6dfda338a71b19e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Nir Soffer has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/45773/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1094 Line 1095 Line 1096 Line 1097 Line 1098 > 1, the lock for the sdUUID is already taken at hsm.py -deactivateSd(), plea Ok, since in deactivateStoargeDomain flow we are holding both the pool and domain lock, we don't have to take any lock to cancel the upgrade, just remove it from the domainsToUpgrade so if a domains becomes up while we are deactivating it, it will block until deactivation was completed. So what is missing here is removal of the domain from _domainsToUpgrade list and handling the case when _domainsToUpgrade becomes empty - 2 lines change in this method, no other change is needed at this point. Please minimize changes - this patch does two much. Line Line 1112 Line 1113 Line 1114 Line 1115 Here we can safely remove the domain from _domainsToUpgrade and handle empty _domainsToUpgrade. Line 1097: self.masterMigrate(sdUUID, newMsdUUID, masterVersion) Line 1098: self._deactivateSD(domList, sdUUID) Line 1099: else: Line 1100: with rmanager.acquireResource(STORAGE, "upgrade_" + self.spUUID, Line 1101: rm.LockType.exclusive): > i'll correct myself - it seems debateable whether we want to have it or not My take is don't touch anything you don't need to touch - this code is fragile. Line 1102: masterDir = os.path.join(dom.domaindir, sd.MASTER_FS_DIR) Line 1103: try: Line 1104: m = mount.getMountFromTarget(masterDir) Line 1105: except OSError as e: Line 1115: "%s", masterDir, dom) Line 1116: self._deactivateSD(domList, sdUUID) Line 1117: self._domainsToUpgrade.remove(sdUUID) Line 1118: Line 1119: def _deactivateSD(self, domList, sdUUID): > Its needed, see previous comment. firstly the metadata updates should be ma Not needed since nobody can touch the pool in this flow. Please minimize changes - it is easier to review minimal change and then decide if another change is needed. Line 1120: domList[sdUUID] = sd.DOM_ATTACHED_STATUS Line 1121: self._backend.setDomainsMap(domList) Line 1122: self.updateMonitoringThreads() Line 1123: -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 57: filter_ = lambda x: not x.startswith('_')
Line 58:
Line 59: return [
Line 60: getmname(module)
Line 61: for module in iglob("%s*.py*" % path)
Is it an issue if both py and pyc are loaded?
In case of having a regular host.
Line 62: if filter_(getmname(module))
Line 63: ]
Line 64:
Line 65:
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
automat...@ovirt.org has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 1: * Update tracker::#1259247::OK * Check Bug-Url::OK * Check Public Bug::#1259247::OK, public bug * Check Product::#1259247::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Yaniv Bronhaim has uploaded a new change for review.
Change subject: configurator doesn't load pyc files under configurators folder
..
configurator doesn't load pyc files under configurators folder
configurator loads dynamically modules from configurators folder. It
searches for py files only. In ovirt-node installation we install only pyc
files and this caused us to miss all configurators modules in ovirt-node
installation.
Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1259247
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/45846/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 5ed905d..c9984aa 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -58,7 +58,7 @@
return [
getmname(module)
-for module in iglob("%s*.py" % path)
+for module in iglob("%s*.py*" % path)
if filter_(getmname(module))
]
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: let nose produce an xunit xml format.
automat...@ovirt.org has posted comments on this change. Change subject: tests: let nose produce an xunit xml format. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aa8702c58d35529898462b754fb828fdbf9b0f8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: more precise emulated machines selection
automat...@ovirt.org has posted comments on this change. Change subject: caps: more precise emulated machines selection .. Patch Set 10: * Update tracker::#1239258::OK * Check TR::#1239258::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/45257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: more precise emulated machines selection
Dan Kenigsberg has posted comments on this change. Change subject: caps: more precise emulated machines selection .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: more precise emulated machines selection
Dan Kenigsberg has submitted this change and it was merged. Change subject: caps: more precise emulated machines selection .. caps: more precise emulated machines selection Current VDSM code fetches emulated machines from the section which matches first the required architecture. This works in the simplest (and the only recommended) case, but doesn't if, for any reason, there is more than one valid emulatore for a given architecture. The only known case is if the user managed to install qemu-kvm alongside plain qemu. This patch implements more robust capabilities fetching to deal with this corner case. Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Bug-Url: https://bugzilla.redhat.com/1239258 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/45257 Continuous-Integration: Jenkins CI Reviewed-by: Martin Polednik Reviewed-by: Dan Kenigsberg --- M tests/Makefile.am M tests/capsTests.py A tests/caps_libvirt_multiqemu.out M vdsm.spec.in M vdsm/caps.py 5 files changed, 606 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Reformat device info dict
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Reformat device info dict .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0907e3c5cf27959e0989903162cf16c9add0406d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Reformat device info dict
Nir Soffer has uploaded a new change for review.
Change subject: hsm: Reformat device info dict
..
hsm: Reformat device info dict
Reformat device info dict in getDeviceList using one item per line and
sorted. This make it easier to search and modify the code and creates
nicer diffs.
Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce
Signed-off-by: Nir Soffer
---
M vdsm/storage/hsm.py
1 file changed, 16 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/45845/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 1b8c064..d3405aa 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2024,18 +2024,22 @@
pvsize = ""
vguuid = ""
-devInfo = {'GUID': dev.get("guid", ""), 'pvUUID': pvuuid,
- 'pvsize': str(pvsize),
- 'vgUUID': vguuid, 'vendorID': dev.get("vendor", ""),
- 'productID': dev.get("product", ""),
- 'fwrev': dev.get("fwrev", ""),
- "serial": dev.get("serial", ""),
- 'capacity': dev.get("capacity", "0"),
- 'devtype': dev.get("devtype", ""),
- 'pathstatus': dev.get("paths", []),
- 'pathlist': dev.get("connections", []),
- 'logicalblocksize': dev.get("logicalblocksize", ""),
- 'physicalblocksize': dev.get("physicalblocksize", "")}
+devInfo = {
+"serial": dev.get("serial", ""),
+'GUID': dev.get("guid", ""),
+'capacity': dev.get("capacity", "0"),
+'devtype': dev.get("devtype", ""),
+'fwrev': dev.get("fwrev", ""),
+'logicalblocksize': dev.get("logicalblocksize", ""),
+'pathlist': dev.get("connections", []),
+'pathstatus': dev.get("paths", []),
+'physicalblocksize': dev.get("physicalblocksize", ""),
+'productID': dev.get("product", ""),
+'pvUUID': pvuuid,
+'pvsize': str(pvsize),
+'vendorID': dev.get("vendor", ""),
+'vgUUID': vguuid,
+}
if not checkStatus:
devInfo["status"] = "unknown"
devices.append(devInfo)
--
To view, visit https://gerrit.ovirt.org/45845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Reformat device info dict
Nir Soffer has abandoned this change. Change subject: hsm: Reformat device info dict .. Abandoned Wrong signoff -- To view, visit https://gerrit.ovirt.org/45822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0907e3c5cf27959e0989903162cf16c9add0406d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Reformat device info dict
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Reformat device info dict .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scheduler: use single instance
automat...@ovirt.org has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scheduler: use single instance
Dan Kenigsberg has submitted this change and it was merged. Change subject: scheduler: use single instance .. scheduler: use single instance We used to have one instance of a scheduler used for periodic operations. With this patch we prepare code for using single scheduler in more places like jsonrpc server. Change-Id: If83eded458f8304d802fcd75839e7a916146918b Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/43825 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M vdsm/vdsm M vdsm/virt/periodic.py 2 files changed, 19 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Liron Aravot has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45773/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1097: self.masterMigrate(sdUUID, newMsdUUID, masterVersion) Line 1098: self._deactivateSD(domList, sdUUID) Line 1099: else: Line 1100: with rmanager.acquireResource(STORAGE, "upgrade_" + self.spUUID, Line 1101: rm.LockType.exclusive): > this lock is actually unneeded as the update and this method are taking the i'll correct myself - it seems debateable whether we want to have it or not. the "_upgrade" lock today is used to prevent from concurrent updates (for example if domain is changing status during an update) and not from concurrent access to some members like _domainsToUpgrade. Nir, what's your take on it? Line 1102: masterDir = os.path.join(dom.domaindir, sd.MASTER_FS_DIR) Line 1103: try: Line 1104: m = mount.getMountFromTarget(masterDir) Line 1105: except OSError as e: -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list
Liron Aravot has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45773/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1097: self.masterMigrate(sdUUID, newMsdUUID, masterVersion) Line 1098: self._deactivateSD(domList, sdUUID) Line 1099: else: Line 1100: with rmanager.acquireResource(STORAGE, "upgrade_" + self.spUUID, Line 1101: rm.LockType.exclusive): > if the upgrade thread is trying to upgrade at the exact time, you should fa this lock is actually unneeded as the update and this method are taking the "general" domain lock, removing. Line 1102: masterDir = os.path.join(dom.domaindir, sd.MASTER_FS_DIR) Line 1103: try: Line 1104: m = mount.getMountFromTarget(masterDir) Line 1105: except OSError as e: -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: more meaningful name of address param
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: more meaningful name of address param .. Patch Set 1: Verified+1 Verified by updating existing vdsm and seeing that there are no issues with communication. -- To view, visit https://gerrit.ovirt.org/45839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1aaba81cadd84e6264e7f59e552879f26d74cbc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: more meaningful name of address param
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: more meaningful name of address param .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1aaba81cadd84e6264e7f59e552879f26d74cbc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: more meaningful name of address param
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: more meaningful name of address param
..
jsonrpc: more meaningful name of address param
During previous changes we agreed to fix address param naming to give
more information what kind of address is contained there.
Change-Id: Id1aaba81cadd84e6264e7f59e552879f26d74cbc
Signed-off-by: pkliczewski
---
M lib/yajsonrpc/__init__.py
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/45839/1
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index 03c49ed..f45952d 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -245,10 +245,10 @@
class _JsonRpcServeRequestContext(object):
-def __init__(self, client, addr):
+def __init__(self, client, server_address):
self._requests = []
self._client = client
-self._addr = addr
+self._server_address = server_address
self._counter = 0
self._requests = {}
self._responses = []
@@ -266,8 +266,8 @@
return self._counter
@property
-def address(self):
-return self._addr
+def server_address(self):
+return self._server_address
def sendReply(self):
if len(self._requests) > 0:
@@ -514,7 +514,7 @@
try:
params = req.params
-self._bridge.register_server_address(ctx.address)
+self._bridge.register_server_address(ctx.server_address)
if isinstance(req.params, list):
res = method(*params)
else:
@@ -540,11 +540,11 @@
if obj is None:
break
-client, addr, msg = obj
-self._parseMessage(client, addr, msg)
+client, server_address, msg = obj
+self._parseMessage(client, server_address, msg)
-def _parseMessage(self, client, addr, msg):
-ctx = _JsonRpcServeRequestContext(client, addr)
+def _parseMessage(self, client, server_address, msg):
+ctx = _JsonRpcServeRequestContext(client, server_address)
try:
rawRequests = json.loads(msg)
--
To view, visit https://gerrit.ovirt.org/45839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1aaba81cadd84e6264e7f59e552879f26d74cbc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report DHCP on devices only when configured (like f...
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: report DHCP on devices only when configured (like for networks) .. netinfo: report DHCP on devices only when configured (like for networks) As reporting of DHCP relies on reading of dhclient lease files, it is not reliable when a network is reconfigured to static addressing: unused leases indicate dhclient presence hours after it has been stopped (expiration time is usually in hours or days). The false indication has already been fixed for networks, now even their respective devices adhere to configuration to stop false positives. A year and half ago it was suggested first to rely on cmdlines on running dhclients (where network device is the last parameter for all network configurators). This fix is just a hacky, though little bandaid for the 3.6 release. A proper fix will be considered for the 4.0 branch. testSetupNetworksAddDelDhcp now checks that DHCP stops being reported on a network device, in addition to its network. Change-Id: I2b17b0c66e3a0fc8c5ada62d166d9a2b92513033 Bug-Url: https://bugzilla.redhat.com/1184497 Signed-off-by: Ondřej Svoboda Reviewed-on: https://gerrit.ovirt.org/45504 Continuous-Integration: Jenkins CI Tested-by: Eliraz Levi Reviewed-by: Dan Kenigsberg --- M lib/vdsm/netinfo.py M tests/functional/networkTests.py 2 files changed, 59 insertions(+), 33 deletions(-) Approvals: Eliraz Levi: Verified Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b17b0c66e3a0fc8c5ada62d166d9a2b92513033 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eliraz Levi Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
