Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7
Hello Fred Rolland, Allon Mureinik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49205
to review the following change.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu version for el7
Prior to QEMU 2.3.0-13, it cannot yield while dumping a dirty map, which
may cause live merge to hang when merging large snapshots. QEMU 2.3.0-13
adds yield points, which prevents the aforementioned hanging.
We don't require the package on CentOS, since it is not available yet.
Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Bug-Url: https://bugzilla.redhat.com/1271173
Signed-off-by: Fred Rolland
Reviewed-on: https://gerrit.ovirt.org/49009
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik
Reviewed-by: Nir Soffer
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/49205/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index b7cb5b8..5a6a877 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -224,9 +224,15 @@
%endif
%if 0%{?rhel}
+%if 0%{?centos}
+# TODO: Remove when qemu-kvm-rhev 2.3.0-13 is available
Requires: qemu-kvm-rhev >= 10:2.1.2-23.el7_1.2
Requires: qemu-img-rhev >= 10:2.1.2-23.el7_1.2
%else
+Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
+Requires: qemu-img-rhev >= 10:2.3.0-13.el7
+%endif # centos
+%else
Requires: qemu-kvm >= 2:2.1.3-11
Requires: qemu-img >= 2:2.1.3-11
%endif # rhel
--
To view, visit https://gerrit.ovirt.org/49205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Fred Rolland
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7
gerrit-hooks has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: * #1271173::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1271173::OK, public bug * Check Product::#1271173::OK, Correct classification oVirt * Check TM::#1271173::OK, correct target milestone ovirt-3.6.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/49205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7
Freddy Rolland has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Verified+1 [root@venus-vdsa ~]# rpm -qa | grep qemu qemu-img-rhev-2.3.0-31.el7.x86_64 qemu-kvm-rhev-2.3.0-31.el7.x86_64 qemu-kvm-tools-rhev-2.3.0-31.el7_2.1.x86_64 ipxe-roms-qemu-20130517-7.gitc4bce43.el7.noarch qemu-kvm-common-rhev-2.3.0-31.el7.x86_64 libvirt-daemon-driver-qemu-1.2.17-13.el7.x86_64 [root@venus-vdsa ~]# cat /etc/redhat-release Red Hat Enterprise Linux Server release 7.2 (Maipo) [root@venus-vdsa ~]# -- To view, visit https://gerrit.ovirt.org/49205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Cleanup conditionals in the build system
Piotr Kliczewski has posted comments on this change. Change subject: build: Cleanup conditionals in the build system .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in File vdsm.spec.in: Line 10: %global snlk_user @SNLKUSER@ Line 11: %global cdrom_group @CDROMGROUP@ Line 12: Line 13: # Build types Line 14: %global koji_build @KOJI_BUILD@ > no.. this variable just says if to install vhostmd or not and nothing else. So if it "says if to install vhostmd" why the name do not reflect its intentions? Line 15: Line 16: # Features Line 17: %global with_gluster_mgmt @GLUSTER_MGMT@ Line 18: %global with_hooks @HOOKS@ -- To view, visit https://gerrit.ovirt.org/48446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Barak Korren Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: improve message id handling during response send
Piotr Kliczewski has posted comments on this change. Change subject: stomp: improve message id handling during response send .. Patch Set 1: Verified+1 Verified by running vdsm and checking that there are no issues. -- To view, visit https://gerrit.ovirt.org/49185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: startup: Change system default encoding to utf8
Piotr Kliczewski has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell helper: typo
gerrit-hooks has posted comments on this change. Change subject: shell helper: typo .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43384a95c8334c3d9ac9258224e3091932d882b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell helper: typo
Ido Barkan has uploaded a new change for review.
Change subject: shell helper: typo
..
shell helper: typo
Change-Id: I43384a95c8334c3d9ac9258224e3091932d882b8
Signed-off-by: Ido Barkan
---
M contrib/shell_helper
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/49206/1
diff --git a/contrib/shell_helper b/contrib/shell_helper
index 6b6314a..8e1dd97 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -102,7 +102,7 @@
}
vdsm_build_reinstall_restart() {
-vdsm_build && vdsm_reinstall && restart_vdsm
+vdsm_build && vdsm_reinstall && vdsm_restart
}
del_dummies() {
--
To view, visit https://gerrit.ovirt.org/49206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43384a95c8334c3d9ac9258224e3091932d882b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: startup: Change system default encoding to utf8
Milan Zamazal has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move utilities to find drive in a new module
gerrit-hooks has posted comments on this change. Change subject: virt: move utilities to find drive in a new module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd88666effe1ef20eea75745cc2a47e9ac227e6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move utilities to find drive in a new module
Francesco Romani has uploaded a new change for review.
Change subject: virt: move utilities to find drive in a new module
..
virt: move utilities to find drive in a new module
Many flows need to find the Drive object given some
id - maybe name, maybe UUIDs.
This is implemented using private methods in the
Vm class, but this code doesn't actually need
to be a methods, and can trivially made like a function,
which redouces the coupling, the complexity, the size
of Vm class and give the functions themselves better
spotlight.
This patch only moves code with trivial changes
(e.g. self._devices -> devices parameter)
Change-Id: Ibd88666effe1ef20eea75745cc2a47e9ac227e6d
Signed-off-by: Francesco Romani
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/virt/Makefile.am
A vdsm/virt/finddrive.py
M vdsm/virt/vm.py
5 files changed, 105 insertions(+), 64 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/49209/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 007913b..60fe22e 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -137,6 +137,7 @@
./usr/share/vdsm/vdsmapi-schema.json
./usr/share/vdsm/virt/__init__.py
./usr/share/vdsm/virt/domain_descriptor.py
+./usr/share/vdsm/virt/finddrive.py
./usr/share/vdsm/virt/guestagent.py
./usr/share/vdsm/virt/hoststats.py
./usr/share/vdsm/virt/migration.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6466988..353172e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -845,6 +845,7 @@
%{_datadir}/%{vdsm_name}/vdsm-store-net-config
%{_datadir}/%{vdsm_name}/virt/__init__.py*
%{_datadir}/%{vdsm_name}/virt/domain_descriptor.py*
+%{_datadir}/%{vdsm_name}/virt/finddrive.py*
%{_datadir}/%{vdsm_name}/virt/guestagent.py*
%{_datadir}/%{vdsm_name}/virt/hoststats.py*
%{_datadir}/%{vdsm_name}/virt/migration.py*
diff --git a/vdsm/virt/Makefile.am b/vdsm/virt/Makefile.am
index 409a178..8732be3 100644
--- a/vdsm/virt/Makefile.am
+++ b/vdsm/virt/Makefile.am
@@ -26,6 +26,7 @@
dist_vdsm_virt_PYTHON = \
__init__.py \
domain_descriptor.py \
+ finddrive.py \
guestagent.py \
hoststats.py \
migration.py \
diff --git a/vdsm/virt/finddrive.py b/vdsm/virt/finddrive.py
new file mode 100644
index 000..b671183
--- /dev/null
+++ b/vdsm/virt/finddrive.py
@@ -0,0 +1,78 @@
+#
+# Copyright 2008-2015 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+"""
+utilities to find VM drives
+"""
+
+from .vmdevices.storage import DISK_TYPE
+from .vmdevices import hwclass
+
+
+def by_name(devices, name):
+for device in devices:
+if device.name == name:
+return device
+raise LookupError("No such drive: '%s'" % name)
+
+
+def by_UUIDs(devices, drive):
+"""Find a drive given its definition"""
+
+if "domainID" in drive:
+tgetDrv = (drive["domainID"], drive["imageID"],
+ drive["volumeID"])
+
+for device in devices:
+if not hasattr(device, "domainID"):
+continue
+if (device.domainID, device.imageID,
+device.volumeID) == tgetDrv:
+return device
+
+elif "GUID" in drive:
+for device in devices:
+if not hasattr(device, "GUID"):
+continue
+if device.GUID == drive["GUID"]:
+return device
+
+elif "UUID" in drive:
+for device in devices:
+if not hasattr(device, "UUID"):
+continue
+if device.UUID == drive["UUID"]:
+return device
+
+elif drive.get('diskType') == DISK_TYPE.NETWORK:
+for device in devices:
+if device.diskType != DISK_TYPE.NETWORK:
+continue
+if device.path == drive["path"]:
+return device
+
+raise LookupError("No such drive: '%s'" % drive)
+
+
+def config_by_name(config, name):
+for device in config:
+if device['type'] == hwclass.DISK and device.get("name") == name:
+return device
+raise LookupError("No such disk %r" % name)
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f07f55e..987e0c0 100644
--- a/vdsm/virt/vm.py
+++
Change in vdsm[master]: virt: introduce "Async" helper
Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Martin, I think we can go with Async if we can simplify it. E.g. how about something like the following in do(): self._started = threading.Event() ... start the thread .. self._started.wait() # for set() in _set_started We could eliminate some Async attributes + maybe error(). My primary concern is what error() is actually for. -- To view, visit https://gerrit.ovirt.org/49114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd277197c7c3819008ae71a8cf2c0679b901397e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: split netinfo module
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: add script name to log
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: add script name to log .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e40406fb2dfce6099a2c288b5d3c37ceec839d1 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support
Oved Ourfali has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Who can merge this? -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Make BIOS messages available on vmconsole
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py
File tests/vmTests.py:
Line 289: xml = find_xml_element(domxml.dom.toxml(), './sysinfo')
Line 290: self.assertXMLEqual(xml, sysinfoXML)
Line 291:
Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
> I would like to only lowercase names in new code, even if it is less consis
No problem for me. Francesco?
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as
fakevm:
Line 297: dom_xml = fakevm._buildDomainXML()
https://gerrit.ovirt.org/#/c/48404/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1569: """
Line 1570: for console in self._devices[hwclass.CONSOLE]:
Line 1571: if console.isSerial:
Line 1572: return console
Line 1573: return None
> Maybe raise NotFound error instead returning None?
It may be a valid concern but at least in the current code it would require us
to handle the exception without any benefit. Not having serial console is
perfectly OK, not an exceptional situation, after all.
Line 1574:
Line 1575: def _customDevices(self):
Line 1576: """
Line 1577: Get all devices that have custom properties
--
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: split netinfo module
Ido Barkan has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Missing autogenerated files added
gerrit-hooks has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. hooks: ovs: pass ip configuration as a namedtuple Signed-off-by: Petr Horáček Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Reviewed-on: https://gerrit.ovirt.org/48830 Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg --- M vdsm_hooks/ovs/ovs_before_network_setup_ip.py 1 file changed, 37 insertions(+), 21 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks
gerrit-hooks has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks
Dan Kenigsberg has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. net: ovs: remove initial nic ip, dont touch unchanged networks According to ifcfg configurator behavior, now we remove inital IP configuration of nics attached to VDSM network. Also there is an improvement in IP changes handling: If IP configuration was not changed, don't recreate it. Signed-off-by: Petr Horáček Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8 Reviewed-on: https://gerrit.ovirt.org/46692 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M vdsm_hooks/ovs/README M vdsm_hooks/ovs/ovs_before_network_setup_ip.py 2 files changed, 41 insertions(+), 11 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after migration .. Patch Set 1: * #1156194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1156194::OK, public bug * Check Product::#1156194::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
Milan Zamazal has uploaded a new change for review.
Change subject: virt: vm: Update time on VM after migration
..
virt: vm: Update time on VM after migration
When a VM is resumed from suspension and/or migrated, its clock
continues from the time of suspension, i.e. it's delayed. We already
addressed the problem by introducing VM._syncTime() method. But for
safety reasons we call the method only in the restoreState path, see
https://gerrit.ovirt.org/48860.
This patch calls _syncTime in migrationDest path as well. It serves the
originally intended purpose of restoring the clock also after migration,
just separates it from the original solution in case something bad could
happen with migration due to it.
Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7
Bug-Url: https://bugzilla.redhat.com/1156194
Signed-off-by: Milan Zamazal
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/49212/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 9aa08bb..7f33c8d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2801,10 +2801,6 @@
fromSnapshot = self.conf.pop('restoreFromSnapshot', False)
hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf,
{'FROM_SNAPSHOT': fromSnapshot})
-# TODO: _syncTime() should probably be called for both the
-# restore_state and migration_dest paths, but let's handle just the
-# safer case first.
-self._syncTime()
elif 'migrationDest' in self.conf:
if self._needToWaitForMigrationToComplete():
usedTimeout = self._waitForUnderlyingMigration()
@@ -2819,6 +2815,8 @@
hooks.after_device_migrate_destination(
dev._deviceXML, self.conf, dev.custom)
+self._syncTime()
+
if 'guestIPs' in self.conf:
del self.conf['guestIPs']
if 'guestFQDN' in self.conf:
--
To view, visit https://gerrit.ovirt.org/49212
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
gerrit-hooks has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Balogh Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
Petr Balogh has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 406:
Line 407: ('coverage_enable', 'false',
Line 408: 'Enable code coverage (requires python-coverage package).
'
Line 409: 'false by default. Use environment file
/etc/sysconfig/vdsm to '
Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE
variables.'),
> So you will install these files on all qe hosts, and then enable coverage v
Yes, I will need put two files on each host.. one is /etc/sysconfig/vdsm which
will contain two lines
export COVERAGE_PROCESS_START=/etc/vdsm/coveragerc.conf
export COVERAGE_FILE=/var/log/vdsm/coverage_data
and second file /etc/vdsm/coveragerc.conf will contain something like this:
http://pastebin.test.redhat.com/331020
So ok, I can send another patch which with these two files?
contrib/coveragerc.conf.sample and
contrib/sysconfig_coverage.sample
After our test will be finished I need copy coverage_data files from all hosts
and combine them with coverage combine command to get report from all hosts
together..
But what would be good is run coverage in phase of deploying hosts as Piotr
suggests by some config option in engine's db. But it is part of java code. Can
someone from devel do this part? Thanks
Line 411:
Line 412: ]),
Line 413:
Line 414: # Section: [gluster]
https://gerrit.ovirt.org/#/c/49168/2/vdsm/vdsm
File vdsm/vdsm:
Line 124: logging.addLevelName(5, 'TRACE')
Line 125: logging.TRACE = 5 # impolite but helpful
Line 126:
Line 127: # Used to enable code coverage. To enable it use coverage_enable
option in
Line 128: # devel section.
> The comment is not needed, the line getting the configuration from the conf
Done
Line 129: if config.getboolean('devel', 'coverage_enable'):
Line 130: import coverage
Line 131: coverage.process_startup()
Line 132:
--
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Balogh
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Remove reporting of bond custom options from RunningConfig
Dan Kenigsberg has posted comments on this change. Change subject: net: Remove reporting of bond custom options from RunningConfig .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5863d67b2b2b9ce15cee9c447983d3ba2e0f23ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove duplicate servers
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: Ala, any reason this is not verified? -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell helper: typo
Dan Kenigsberg has posted comments on this change. Change subject: shell helper: typo .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43384a95c8334c3d9ac9258224e3091932d882b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell-helper: stop using service command
gerrit-hooks has posted comments on this change. Change subject: shell-helper: stop using service command .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie11bba182fd89f86c46bdbb896dd4d73005399e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell-helper: stop using service command
Ido Barkan has uploaded a new change for review.
Change subject: shell-helper: stop using service command
..
shell-helper: stop using service command
In master we can safely use systemctl since we do not support systemv
anymore. Also, the 'status' and 'stop' verbs support multiple
arguments so this allows the use of less shell command.
Change-Id: Ie11bba182fd89f86c46bdbb896dd4d73005399e4
Signed-off-by: Ido Barkan
---
M contrib/shell_helper
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/49215/1
diff --git a/contrib/shell_helper b/contrib/shell_helper
index 8e1dd97..f9d95c7 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -18,14 +18,11 @@
}
vdsm_restart() {
-sudo service vdsmd stop && sudo service supervdsmd stop
-sudo service vdsmd start
+sudo systemctl stop vdsmd supervdsmd
+sudo systemctl start vdsmd
sleep 3
-service vdsm-network-cleanup status | egrep -i "activ|failed"
-service vdsm-network status | egrep -i "activ|failed"
-service vdsmd status | egrep -i "activ|failed"
-service supervdsmd status | egrep -i "activ|failed"
-}
+systemctl status vdsm-network vdsmd supervdsmd | egrep -i
"activ|failed|vdsm-network|vdsmd"
+}
vdsm_caps_nonsecure() {
if [ -t 1 ]; then
--
To view, visit https://gerrit.ovirt.org/49215
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie11bba182fd89f86c46bdbb896dd4d73005399e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove duplicate servers
Ala Hino has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: break netinfo-netconfpersistence dependency
Dan Kenigsberg has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48824/5/lib/vdsm/kernelconfig.py File lib/vdsm/kernelconfig.py: Line 2: 2013 2013-2015 -- To view, visit https://gerrit.ovirt.org/48824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie64081f13b249ff7a7595ae56d00d1b218428d9c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fixup to add
Ido Barkan has uploaded a new change for review.
Change subject: fixup to add
..
fixup to add
Change-Id: Id9ccad25fe6dcabcbb26401de1ee8a207f6e53bc
Signed-off-by: Ido Barkan
---
M tests/functional/networkTests.py
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/49216/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 915b0f9..1c3e954 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1649,6 +1649,24 @@
self.assertEquals(status, SUCCESS, msg)
self.assertNetworkDoesntExist(NETWORK_NAME)
+@cleanupNet
+@permutations([[True], [False]])
+def testVolatileConfig(self, bridged):
+"""
+Checks that the network doesn't persist over restart
+"""
+with dummyIf(1) as nics:
+nic, = nics
+status, msg = self.setupNetworks(
+{NETWORK_NAME: {'nic': nic, 'bridged': bridged}})
+self.assertEquals(status, SUCCESS, msg)
+
+self.assertNetworkExists(NETWORK_NAME, bridged=bridged)
+
+self.vdsm_net.restoreNetConfig()
+
+self.assertNetworkDoesntExist(NETWORK_NAME)
+
@permutations([[True], [False]])
@cleanupNet
def testStaticSourceRouting(self, bridged=True):
--
To view, visit https://gerrit.ovirt.org/49216
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9ccad25fe6dcabcbb26401de1ee8a207f6e53bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fixup to add
gerrit-hooks has posted comments on this change. Change subject: fixup to add .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9ccad25fe6dcabcbb26401de1ee8a207f6e53bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/49205/1/vdsm.spec.in File vdsm.spec.in: Line 229: Requires: qemu-kvm-rhev >= 10:2.1.2-23.el7_1.2 Line 230: Requires: qemu-img-rhev >= 10:2.1.2-23.el7_1.2 Line 231: %else Line 232: Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7 Line 233: Requires: qemu-img-rhev >= 10:2.3.0-13.el7 Fred, according to your comment: Freddy Rolland 10:11 AM Patch Set 1: Verified+1 [root@venus-vdsa ~]# rpm -qa | grep qemu qemu-img-rhev-2.3.0-31.el7.x86_64 qemu-kvm-rhev-2.3.0-31.el7.x86_64 qemu-kvm-tools-rhev-2.3.0-31.el7_2.1.x86_64 The version should be 2.3.0-31, but you require 10:2.3... This was also in the old code - can you explain this difference? Did you verify that vdsm can be installed on rhel 7.2 machine with these requirements? This is the only way to verify the spec, checking the package exists is not good enough, you may have a syntax error in the spec. Line 234: %endif # centos Line 235: %else Line 236: Requires: qemu-kvm >= 2:2.1.3-11 Line 237: Requires: qemu-img >= 2:2.1.3-11 -- To view, visit https://gerrit.ovirt.org/49205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fixup to add
Ido Barkan has abandoned this change. Change subject: fixup to add .. Abandoned mistake -- To view, visit https://gerrit.ovirt.org/49216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id9ccad25fe6dcabcbb26401de1ee8a207f6e53bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fixup to add
gerrit-hooks has posted comments on this change. Change subject: fixup to add .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/49216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9ccad25fe6dcabcbb26401de1ee8a207f6e53bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Cleanup conditionals in the build system
Nir Soffer has posted comments on this change. Change subject: build: Cleanup conditionals in the build system .. Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in File vdsm.spec.in: Line 46 Line 47 Line 48 Line 49 Line 50 > :) Can you explain when this should be used? if it is never can be true, lets remove this and the koji_build that is used only for this check. Line 10: %global snlk_user @SNLKUSER@ Line 11: %global cdrom_group @CDROMGROUP@ Line 12: Line 13: # Build types Line 14: %global koji_build @KOJI_BUILD@ > So if it "says if to install vhostmd" why the name do not reflect its inten Lets improve the name in another patch, we are trying to cleanup the logic here. Line 15: Line 16: # Features Line 17: %global with_gluster_mgmt @GLUSTER_MGMT@ Line 18: %global with_hooks @HOOKS@ -- To view, visit https://gerrit.ovirt.org/48446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Barak Korren Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: split netinfo module
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove duplicate servers
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove duplicate servers
Nir Soffer has submitted this change and it was merged. Change subject: gluster: Remove duplicate servers .. gluster: Remove duplicate servers Gluster volinfo could return duplicate servers. For example, if the volume is a distributed replica volume (2 X 3) with 6 bricks, the bricks could be spread over 4 volumes. This patch removes duplicate servers if appear in volinfo. Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/49023 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Sahina Bose --- M lib/vdsm/utils.py M tests/storageServerTests.py M tests/utilsTests.py M vdsm/storage/storageServer.py 4 files changed, 44 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove addNetwork old API
gerrit-hooks has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e4eb62d7b2dda03082498a451e2e4a699ab7403 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Make BIOS messages available on vmconsole
Nir Soffer has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/48404/8/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1569: """ Line 1570: for console in self._devices[hwclass.CONSOLE]: Line 1571: if console.isSerial: Line 1572: return console Line 1573: return None > It may be a valid concern but at least in the current code it would require OK Line 1574: Line 1575: def _customDevices(self): Line 1576: """ Line 1577: Get all devices that have custom properties -- To view, visit https://gerrit.ovirt.org/48404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove delNetwork old API
gerrit-hooks has posted comments on this change. Change subject: net: remove delNetwork old API .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove editNetwork old API
gerrit-hooks has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5c46fc31401cd7b38856d66253d2c5074a51e8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Missing autogenerated files added
Nir Soffer has submitted this change and it was merged. Change subject: gitignore: Missing autogenerated files added .. gitignore: Missing autogenerated files added Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/48328 Reviewed-by: Piotr Kliczewski Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/48328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Missing autogenerated files added
Nir Soffer has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Missing autogenerated files added
gerrit-hooks has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: break netinfo-netconfpersistence dependency
Ido Barkan has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48824/5/lib/vdsm/kernelconfig.py File lib/vdsm/kernelconfig.py: Line 2: 2013 > 2013-2015 Done -- To view, visit https://gerrit.ovirt.org/48824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie64081f13b249ff7a7595ae56d00d1b218428d9c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: wip
Ido Barkan has abandoned this change. Change subject: wip .. Abandoned -- To view, visit https://gerrit.ovirt.org/49171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icee997a585251b5132c1b871d29cc19151b2dd20 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: wip
gerrit-hooks has posted comments on this change. Change subject: wip .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/49171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icee997a585251b5132c1b871d29cc19151b2dd20 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: break netinfo-netconfpersistence dependency
gerrit-hooks has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie64081f13b249ff7a7595ae56d00d1b218428d9c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: removing the bonding modes constant duplication.
gerrit-hooks has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6682c7294f5afb8d50a30c6bd0431d85bbd159d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Flatten KernelConfig logic
gerrit-hooks has posted comments on this change. Change subject: net: Flatten KernelConfig logic .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e0df1b4355cafb9f4d3a6da070b9384b858aba0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: split netinfo module
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Remove reporting of bond custom options from RunningConfig
Ido Barkan has posted comments on this change. Change subject: net: Remove reporting of bond custom options from RunningConfig .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/49081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5863d67b2b2b9ce15cee9c447983d3ba2e0f23ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove addNetwork old API
Ido Barkan has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/48909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e4eb62d7b2dda03082498a451e2e4a699ab7403 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove editNetwork old API
Ido Barkan has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5c46fc31401cd7b38856d66253d2c5074a51e8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding coverage check for unit tests
Ido Barkan has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/49217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
Hello Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49217
to review the following change.
Change subject: gluster: Remove duplicate servers
..
gluster: Remove duplicate servers
Gluster volinfo could return duplicate servers. For example, if
the volume is a distributed replica volume (2 X 3) with 6 bricks,
the bricks could be spread over 4 volumes.
This patch removes duplicate servers if appear in volinfo.
Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Signed-off-by: Ala Hino
Reviewed-on: https://gerrit.ovirt.org/49023
Reviewed-by: Nir Soffer
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose
---
M lib/vdsm/utils.py
M tests/storageServerTests.py
M tests/utilsTests.py
M vdsm/storage/storageServer.py
4 files changed, 56 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/49217/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 70032a3..e227c5a 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -27,7 +27,7 @@
Contains a reverse dictionary pointing from error string to its error code.
"""
-from collections import namedtuple, deque
+from collections import namedtuple, deque, OrderedDict
from contextlib import contextmanager
from fnmatch import fnmatch
from StringIO import StringIO
@@ -1277,3 +1277,23 @@
log.debug("%s: %.2f seconds", message, elapsed)
else:
yield
+
+
+def kill_and_rm_pid(pid, pid_file):
+try:
+os.kill(pid, signal.SIGTERM)
+except OSError as e:
+if e.errno == os.errno.ESRCH: # Already exited
+pass
+else:
+raise
+if pid_file is not None:
+rmFile(pid_file)
+
+
+def unique(iterable):
+"""
+Return unique items from iterable of hashable objects, keeping the
+original order.
+"""
+return OrderedDict.fromkeys(iterable).keys()
diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index f39fe82..7cf101a 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -168,6 +168,27 @@
self.assertEquals(gluster.options, expected_backup_servers)
@MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
+def test_duplicate_servers_in_volinfo(self):
+"""
+This test simulates a use case where gluster server provided in the
+path doesn't appear in the volume info.
+"""
+def glusterVolumeInfo(volname=None, volfileServer=None):
+return {'music': {'brickCount': '3',
+ 'bricks': ['192.168.122.5:/tmp/music',
+ '192.168.122.2:/tmp/music',
+ '192.168.122.2:/tmp/music',
+ '192.168.122.5:/tmp/music',
+ '192.168.122.3:/tmp/music']}}
+
+storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo
+
+gluster = GlusterFSConnection(spec="gluster-server:/music")
+expected_backup_servers = \
+"backup-volfile-servers=192.168.122.5:192.168.122.2:192.168.122.3"
+self.assertEquals(gluster.options, expected_backup_servers)
+
+@MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
def test_gluster_and_user_provided_mount_options(self):
def glusterVolumeInfo(volname=None, volfileServer=None):
return {'music': {'brickCount': '3',
diff --git a/tests/utilsTests.py b/tests/utilsTests.py
index cb593f6..39fcbd1 100644
--- a/tests/utilsTests.py
+++ b/tests/utilsTests.py
@@ -156,6 +156,7 @@
self.assertIn(NAME, e.strerror)
+@expandPermutations
class GeneralUtilsTests(TestCaseBase):
def testPanic(self):
self.assertRaises(AssertionError, utils.panic, "panic test")
@@ -204,6 +205,16 @@
('a', 'b', 'c', 'd', 'e')]
self.assertEquals(list(utils.grouper(iterable, 5)), grouped)
+@permutations([
+([], []),
+((), []),
+((i for i in [1, 2, 3, 1, 3]), [1, 2, 3]),
+(('a', 'a', 'b', 'c', 'a', 'd'), ['a', 'b', 'c', 'd']),
+(['a', 'a', 'b', 'c', 'a', 'd'], ['a', 'b', 'c', 'd'])
+])
+def test_unique(self, iterable, unique_items):
+self.assertEquals(utils.unique(iterable,), unique_items)
+
class AsyncProcessOperationTests(TestCaseBase):
def _echo(self, text):
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 4385889..9f09aa4 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -33,6 +33,7 @@
from vdsm.compat import pickle
from vdsm.config import config
from vdsm import udevadm
+from vdsm import utils
import supervdsm
import mount
@@ -336,7 +337,8 @@
raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
def _get_backup_servers_option(self):
-servers = [bric
Change in vdsm[master]: code coverage: change approach how to enable it
Nir Soffer has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 406:
Line 407: ('coverage_enable', 'false',
Line 408: 'Enable code coverage (requires python-coverage package).
'
Line 409: 'false by default. Use environment file
/etc/sysconfig/vdsm to '
Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE
variables.'),
> Yes, I will need put two files on each host.. one is /etc/sysconfig/vdsm wh
These files seems to be useful to anyone that want to do code coverage for
vdsm, so I like to have them in vdsm.
This will also help developers to understand how the code work and decrease the
chance that we break this in the future.
How about adding a package - vdsm-coverage that will install all the file in
the correct place and enable coverage in the configuration?
Then it will be trivial for ovirt-host-deploy to install this package if
instructed by the engine.
Piotr, Dan, what do you think?
Line 411:
Line 412: ]),
Line 413:
Line 414: # Section: [gluster]
--
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Balogh
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
Nir Soffer has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 406:
Line 407: ('coverage_enable', 'false',
Line 408: 'Enable code coverage (requires python-coverage package).
'
Line 409: 'false by default. Use environment file
/etc/sysconfig/vdsm to '
Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE
variables.'),
> These files seems to be useful to anyone that want to do code coverage for
And of course, vdsm-coverage will require python-coverage, so you don't have to
keep this package on all your hosts.
Line 411:
Line 412: ]),
Line 413:
Line 414: # Section: [gluster]
--
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Balogh
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 2: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/49217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/49217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove addNetwork old API
Edward Haas has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e4eb62d7b2dda03082498a451e2e4a699ab7403 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding coverage check for unit tests
Edward Haas has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/49130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding coverage check for unit tests
gerrit-hooks has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/49130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding coverage check for unit tests
Dan Kenigsberg has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding coverage check for unit tests
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Adding coverage check for unit tests .. tests: Adding coverage check for unit tests It is helpfull to examine the test coverage when modifying source code, assuring all scenarios have been checked. The coverage is currently performed with the unit tests run. Results are shown at the end of the run. Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/49130 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M automation/check-patch.packages M automation/check-patch.sh 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/49130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 3: Code-Review-1
(2 comments)
Ala, please check jenkins failure.
If it looks like ci issue, please report to infra mailing list.
If it looks like a broken test, please report to devel mailing list.
https://gerrit.ovirt.org/#/c/49217/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1287: pass
Line 1288: else:
Line 1289: raise
Line 1290: if pid_file is not None:
Line 1291: rmFile(pid_file)
Ala, this is not part of your patch, please kill and remove it.
Line 1292:
Line 1293:
Line 1294: def unique(iterable):
Line 1295: """
https://gerrit.ovirt.org/#/c/49217/3/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 170: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 171: def test_duplicate_servers_in_volinfo(self):
Line 172: """
Line 173: This test simulates a use case where gluster server provided
in the
Line 174: path doesn't appear in the volume info.
Please send another patch fixing this wrong docstring.
Line 175: """
Line 176: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 177: return {'music': {'brickCount': '3',
Line 178: 'bricks': ['192.168.122.5:/tmp/music',
--
To view, visit https://gerrit.ovirt.org/49217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW
Francesco Romani has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 1: raising score -- To view, visit https://gerrit.ovirt.org/49144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW
gerrit-hooks has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 2: * #1282239::Update tracker: OK * Set MODIFIED::bug 1282239#1282239IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/49144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW
Francesco Romani has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW
Francesco Romani has submitted this change and it was merged. Change subject: image: copy - set VM metadata images format to RAW .. image: copy - set VM metadata images format to RAW Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw volumes is done using 'qemu-img convert' instead of invoking 'dd'. Consequently, exporting VM metadata images (produce during live snapshot) fails on qemu-img convert - since the images 'impersonate' to qcow2 (the format in .meta file is cow, whereas the real format is raw). Hence, we try to identify the VM metadata image on '_interImagesCopy' and set its format to RAW so qemuimg.convert won't fail (QImgError: "Image is not in qcow2 format"). This approach is a workaround since it's done merely to conceal the aforementioned miscorrelation, however, it seems to be simpler than fixing the root cause (see https://gerrit.ovirt.org/#/c/48768/). Note: this fix is merely for passing the correct argument to qemu-img on convert (raw format). I.e. the .meta file of the target files will still contain the wrong format (cow). Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Bug-Url: https://bugzilla.redhat.com/1282239 Signed-off-by: Daniel Erez Reviewed-on: https://gerrit.ovirt.org/49002 Reviewed-by: Adam Litke Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/49144 Continuous-Integration: Francesco Romani --- M vdsm/storage/image.py 1 file changed, 26 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Daniel Erez: Verified Francesco Romani: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/49217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
Nir Soffer has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: Code-Review+2 Thanks Petr! Did you test that it works? If you did, please describe how did you test, and mark as verified. Waiting for Piotr approval. -- To view, visit https://gerrit.ovirt.org/49168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Balogh Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Balogh Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
Ala Hino has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/49217/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1287: pass
Line 1288: else:
Line 1289: raise
Line 1290: if pid_file is not None:
Line 1291: rmFile(pid_file)
> Ala, this is not part of your patch, please kill and remove it.
Done
Line 1292:
Line 1293:
Line 1294: def unique(iterable):
Line 1295: """
https://gerrit.ovirt.org/#/c/49217/3/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 170: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 171: def test_duplicate_servers_in_volinfo(self):
Line 172: """
Line 173: This test simulates a use case where gluster server provided
in the
Line 174: path doesn't appear in the volume info.
> Please send another patch fixing this wrong docstring.
Good catch; will fix it
Line 175: """
Line 176: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 177: return {'music': {'brickCount': '3',
Line 178: 'bricks': ['192.168.122.5:/tmp/music',
--
To view, visit https://gerrit.ovirt.org/49217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
Piotr Kliczewski has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 406:
Line 407: ('coverage_enable', 'false',
Line 408: 'Enable code coverage (requires python-coverage package).
'
Line 409: 'false by default. Use environment file
/etc/sysconfig/vdsm to '
Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE
variables.'),
> And of course, vdsm-coverage will require python-coverage, so you don't hav
I agree with Nir. It would be great if I could see how well my code is covered
by tests and improve it in my dev env.
Line 411:
Line 412: ]),
Line 413:
Line 414: # Section: [gluster]
--
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Balogh
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
Piotr Kliczewski has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: Code-Review+2 This patch is good start but let's make it usable for developers. -- To view, visit https://gerrit.ovirt.org/49168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Balogh Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Balogh Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: code coverage: change approach how to enable it
Nir Soffer has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 406:
Line 407: ('coverage_enable', 'false',
Line 408: 'Enable code coverage (requires python-coverage package).
'
Line 409: 'false by default. Use environment file
/etc/sysconfig/vdsm to '
Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE
variables.'),
> I agree with Nir. It would be great if I could see how well my code is cove
The coverage package is needed only for testing coverage of tests working with
running vdsm process, for example, qe automation tests or vdsm functional
tests.
For the regular tests testing vdsm module, you can use built-in coverage
support in nosetest (try nosetests -h and look for --cover).
Line 411:
Line 412: ]),
Line 413:
Line 414: # Section: [gluster]
--
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Balogh
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
Ala Hino has uploaded a new change for review.
Change subject: gluster: Fix unit test docstring
..
gluster: Fix unit test docstring
Fix unit test docstring to reflect what the test checks.
Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7
Signed-off-by: Ala Hino
---
M tests/storageServerTests.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/49222/1
diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 7cf101a..70f71ca 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -170,8 +170,7 @@
@MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
def test_duplicate_servers_in_volinfo(self):
"""
-This test simulates a use case where gluster server provided in the
-path doesn't appear in the volume info.
+This test verifies that servers list contains no duplicates.
"""
def glusterVolumeInfo(volname=None, volfileServer=None):
return {'music': {'brickCount': '3',
--
To view, visit https://gerrit.ovirt.org/49222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
gerrit-hooks has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
Ala Hino has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
Ala Hino has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 1: > Patch Set 1: Verified+1 No logic changed here, only docstring -- To view, visit https://gerrit.ovirt.org/49222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
Nir Soffer has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 1: Code-Review+2 Continuous-Integration+1 Verified+1 Thanks Ala! -- To view, visit https://gerrit.ovirt.org/49222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
Nir Soffer has submitted this change and it was merged. Change subject: gluster: Fix unit test docstring .. gluster: Fix unit test docstring Fix unit test docstring to reflect what the test checks. Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/49222 Reviewed-by: Nir Soffer Continuous-Integration: Nir Soffer Tested-by: Nir Soffer --- M tests/storageServerTests.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved; Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/49222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix unit test docstring
gerrit-hooks has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/49222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/49217/3//COMMIT_MSG
Commit Message:
Line 10: the volume is a distributed replica volume (2 X 3) with 6 bricks,
Line 11: the bricks could be spread over 4 volumes.
Line 12: This patch removes duplicate servers if appear in volinfo.
Line 13:
Line 14: Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
We need a bug url for merging into 3.6 - check if the original bug url is good
enough.
Line 15: Signed-off-by: Ala Hino
Line 16: Reviewed-on: https://gerrit.ovirt.org/49023
Line 17: Reviewed-by: Nir Soffer
Line 18: Continuous-Integration: Jenkins CI
https://gerrit.ovirt.org/#/c/49217/3/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 170: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 171: def test_duplicate_servers_in_volinfo(self):
Line 172: """
Line 173: This test simulates a use case where gluster server provided
in the
Line 174: path doesn't appear in the volume info.
> Good catch; will fix it
Please backport also the fixed docstrings, put the same bug-url on it.
Line 175: """
Line 176: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 177: return {'music': {'brickCount': '3',
Line 178: 'bricks': ['192.168.122.5:/tmp/music',
--
To view, visit https://gerrit.ovirt.org/49217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 4: Code-Review-1 Missing burl url and the next patch fixing the docstring. -- To view, visit https://gerrit.ovirt.org/49217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring
gerrit-hooks has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/49223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring
Ala Hino has uploaded a new change for review.
Change subject: gluster: Fix unit test docstring
..
gluster: Fix unit test docstring
Fix unit test docstring to reflect what the test checks.
Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7
Signed-off-by: Ala Hino
Reviewed-on: https://gerrit.ovirt.org/49222
Reviewed-by: Nir Soffer
Continuous-Integration: Nir Soffer
Tested-by: Nir Soffer
---
M tests/storageServerTests.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/49223/1
diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 7cf101a..70f71ca 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -170,8 +170,7 @@
@MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
def test_duplicate_servers_in_volinfo(self):
"""
-This test simulates a use case where gluster server provided in the
-path doesn't appear in the volume info.
+This test verifies that servers list contains no duplicates.
"""
def glusterVolumeInfo(volname=None, volfileServer=None):
return {'music': {'brickCount': '3',
--
To view, visit https://gerrit.ovirt.org/49223
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()
gerrit-hooks has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ab50fc789dde969b2fb9ab969241ed4ad12545c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()
Milan Zamazal has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 12: Verified+1 With migration working again in master, I rebased and tried to cancel VM migration at several different times after migration initiation and it worked. -- To view, visit https://gerrit.ovirt.org/40520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ab50fc789dde969b2fb9ab969241ed4ad12545c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring
Nir Soffer has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 1: Code-Review-1 Needs the same bug url as the patch it fixes. -- To view, visit https://gerrit.ovirt.org/49223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If90bfae822534f68861b7699a5e82e8fd2a562b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 7: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/48880/7/tests/vmTests.py
File tests/vmTests.py:
Line 1294: # never reach sleep when device is removed in first check, and
method
Line 1295: # should exit immediately
Line 1296: @MonkeyPatch(vm, "config", make_config([
Line 1297: ("vars", "hotunplug_timeout", "0"),
Line 1298: ("vars", "hotunplug_check_interval", "1")
This value does not effect the test, so we don't have to monkeypatch it in this
test.
Line 1299: ]))
Line 1300: @MonkeyPatch(utils, "isBlockDevice", lambda x: x ==
"/block_path")
Line 1301: @permutations([[drive_file, FILE_DRIVE_XML],
Line 1302:[drive_network, NETWORK_DRIVE_XML],
https://gerrit.ovirt.org/#/c/48880/7/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:
Line 190: """
Line 191: Returns xpath to the device in libvirt dom xml
Line 192: The path is relative to the root element
Line 193: """
Line 194: return "./devices/interface/mac[@address='%s']" % self.macAddr
Not needed, belongs to the next patch.
https://gerrit.ovirt.org/#/c/48880/7/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 432: source_key = {DISK_TYPE.FILE: 'file',
Line 433: DISK_TYPE.BLOCK: 'dev',
Line 434: DISK_TYPE.NETWORK: 'name'}
Line 435: return "./devices/disk/source[@%s='%s']" \
Line 436:% (source_key[self.diskType], self.path)
Not needed, belongs to the next patch.
Line 437:
Line 438:
Line 439: def _getSourceXML(drive):
Line 440: source = vmxml.Element('source')
--
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
