Change in vdsm[master]: host stats: Collect stats from online cpu cores only

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: host stats: Collect stats from online cpu cores only
..


Patch Set 14: Code-Review+1

Look good to me, but we need more reviews from the virt team and approval from 
Francesco.

-- 
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Omer Frenkel 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: p3test: add few modules that currently pass on Python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: p3test: add few modules that currently pass on Python 3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If52335524c3208c7209d3c0f9fd7bad85f250381
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: add SDM.create_volume API stub

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: add SDM.create_volume API stub
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb2c902ff41e71266689b42323624f8e7a38ed8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: All outstanding VolumeMetadata changes squashed
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagefakelib: Add FakeResourceManager
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: constants: Define temporary volume indicators

[automation]

gerrit-hooks has posted comments on this change.

Change subject: constants: Define temporary volume indicators
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage constants: Move LEASE_FILEEXT

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage constants: Move LEASE_FILEEXT
..

storage constants: Move LEASE_FILEEXT

Change-Id: I80c741d34c6441de2474bf7c5ce4d5ea5a725995
Signed-off-by: Adam Litke 
---
M vdsm/storage/constants.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileVolume.py
3 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/50841/1

diff --git a/vdsm/storage/constants.py b/vdsm/storage/constants.py
index c9070f2..c146453 100644
--- a/vdsm/storage/constants.py
+++ b/vdsm/storage/constants.py
@@ -22,6 +22,7 @@
 SECTOR_SIZE = 512
 
 FILE_VOLUME_PERMISSIONS = 0o660
+LEASE_FILEEXT = ".lease"
 
 # Temporary volume indicators
 TEMP_VOL_FILEEXT = ".tmp"# Appended to FileVolume metadata filenames
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index ec24d35..965af12 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -39,6 +39,8 @@
 from vdsm import supervdsm
 import mount
 
+from storage.constants import LEASE_FILEEXT
+
 REMOTE_PATH = "REMOTE_PATH"
 
 FILE_SD_MD_FIELDS = sd.SD_MD_FIELDS.copy()
@@ -463,7 +465,7 @@
 if self.hasVolumeLeases():
 vol = self.produceVolume(imgUUID, volUUID)
 volumePath = vol.getVolumePath()
-leasePath = volumePath + fileVolume.LEASE_FILEEXT
+leasePath = volumePath + LEASE_FILEEXT
 return leasePath, fileVolume.LEASE_FILEOFFSET
 return None, None
 
@@ -669,7 +671,7 @@
 basePath = os.path.join(repoPath, self.sdUUID, sd.DOMAIN_IMAGES)
 volFiles = [volUUID, volUUID + fileVolume.META_FILEEXT]
 if self.hasVolumeLeases():
-volFiles.append(volUUID + fileVolume.LEASE_FILEEXT)
+volFiles.append(volUUID + LEASE_FILEEXT)
 for rImg in relinkImgs:
 # This function assumes that all relevant images and template
 # namespaces are locked.
diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 79ecc60..9eb0173 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -37,9 +37,9 @@
 from threadLocal import vars
 
 from storage.constants import FILE_VOLUME_PERMISSIONS
+from storage.constants import LEASE_FILEEXT
 
 META_FILEEXT = ".meta"
-LEASE_FILEEXT = ".lease"
 LEASE_FILEOFFSET = 0
 
 BLOCK_SIZE = volume.BLOCK_SIZE


-- 
To view, visit https://gerrit.ovirt.org/50841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80c741d34c6441de2474bf7c5ce4d5ea5a725995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add get_volume_artifacts_class to the domain manifest
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: Add _getDeletedImagePath until patch merged
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd67cacc58da27ffda7286582e263195dac96894
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: host stats: Collect stats from online cpu cores only
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/46269/13/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 156: self.coresSample[match.group(1)] = coreSample
Line 157: 
Line 158: def getCoreSample(self, coreId):
Line 159: strCoreId = str(coreId)
Line 160: return self.coresSample.get(strCoreId)
> The method already returned None. Only in case of a racecondition it would 
I agree that a bug fix should be minimal, but we want to fix this code to raise 
when there is no sample, simplifying the upper layer error handling.

Would you send additional patch doing this?
Line 161: 
Line 162: 
Line 163: class NumaNodeMemorySample(object):
Line 164: """


-- 
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Omer Frenkel 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: tcTests should run as root

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: tcTests should run as root
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50794/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: net tests: tcTests should run as root
Line 8: 
Line 9: Mark that tcTests.TestConfigureOutbound tests should
Line 10: run as root (otherwise, skip).
currently, these tests are already skipped, with a

 test_single_vlan(2) SKIP: Failed 
to create a dummy interface dummy_8mtON: ['RTNETLINK answers: Operation not 
permitted']

message. Why is this patch such a grand improvement?
Line 11: 
Line 12: Change-Id: I3a6d85dcb5ac6b0d842b2547e7ea8a91bc6a742c


-- 
To view, visit https://gerrit.ovirt.org/50794
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a6d85dcb5ac6b0d842b2547e7ea8a91bc6a742c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: tcTests should run as root

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: net tests: tcTests should run as root
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50794/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: net tests: tcTests should run as root
Line 8: 
Line 9: Mark that tcTests.TestConfigureOutbound tests should
Line 10: run as root (otherwise, skip).
> currently, these tests are already skipped, with a
This is not a grand improvement :-)

Currently the tests are skipped because they fail, this patch will skip them 
because they cannot succeed. Future patch can remove the skip on failures, 
making the test fail when it fails.

Even if this patch changed nothing, declaring that a test requires root is a 
good change.
Line 11: 
Line 12: Change-Id: I3a6d85dcb5ac6b0d842b2547e7ea8a91bc6a742c


-- 
To view, visit https://gerrit.ovirt.org/50794
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a6d85dcb5ac6b0d842b2547e7ea8a91bc6a742c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1//COMMIT_MSG
Commit Message:

Line 14: 
Line 15: Also, if one of the files couldn't be removed, we didn't try to remove
Line 16: the others.
Line 17: Now we handle each removal separately, so that a failure in the removal
Line 18: of one file doesn't affect the removal of the others.
Please describe also fixing handling of missing files, logging a warning 
instead of useless a traceback.
Line 19: 
Line 20: Bug-Url: https://bugzilla.redhat.com/1292092
Line 21: Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage constants: Move LEASE_FILEEXT

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage constants: Move LEASE_FILEEXT
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c741d34c6441de2474bf7c5ce4d5ea5a725995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: show vlan in caps ports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: show vlan in caps ports
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test network's iface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: tests: test network's iface
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: caps vlan vlanid property has to be int

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: caps vlan vlanid property has to be int
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50729
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I737ae75e066ee27d5ecba0aa86118b94fd1ea62d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: p3test: add few modules that currently pass on Python 3

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: p3test: add few modules that currently pass on Python 3
..


p3test: add few modules that currently pass on Python 3

Change-Id: If52335524c3208c7209d3c0f9fd7bad85f250381
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/50647
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
---
M tests/Makefile.am
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/50647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If52335524c3208c7209d3c0f9fd7bad85f250381
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test network's iface

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: tests: test network's iface
..


Patch Set 11: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48366/11/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 258:  is not False
I find 

 network_config.get('bridged', True)

less confusing.


-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: moving nics between bonds

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: supervdsm: moving nics between bonds
..


Patch Set 1:

(7 comments)

https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 687: ,
: _netinfo=_netinfo
> this line break is unrelated, right?
Done


Line 690: modified_bondings=bondings
> You probably meant to pass 'edition'.
We need the complete list of bondings, or at least all the bonds in which the 
new nics have been before the request (and from which they have been 
deleted/not deleted).


Line 708: modified_bondings
> Not in use.
Done


Line 711: for slave_name in _netinfo.bondings[name]['slaves']:
: if slave_name not in attrs.get('nics')
> removed_slaves = _netinfo.bondings[name]['slaves'] - attrs.get('nics')
Done


Line 714:  configurator.remove_slaves(removed_slaves, _netinfo)
> Why this is saved here?
We need to delete a slave from one bond, before adding it to another. The 
mechanism is the same as for instance configurator.configureBond.


https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/models.py
File lib/vdsm/network/models.py:

Line 262: if not existing_bond_name or new_bond_name == existing_bond_name:
> I would split this or expression into 2 tests (as done for next 2 tests) fo
Done


Line 268: bond['remove'] == 'true':
> can 'remove' be other then 'true'?
Done


-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: constants: Define temporary volume indicators

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: constants: Define temporary volume indicators
..


Patch Set 8: Code-Review-1

(1 comment)

Check the comments

https://gerrit.ovirt.org/#/c/49544/8/vdsm/storage/constants.py
File vdsm/storage/constants.py:

Line 22: SECTOR_SIZE = 512
Line 23: 
Line 24: # Temporary volume indicators
Line 25: TEMP_VOL_FILEEXT = ".tmp"# Appended to FileVolume metadata 
filenames
Line 26: TEMP_VOL_TAG = "OVIRT_VOL_TEMP"  # Tag applied to temporary 
BlockVolume LVs
How about TEMP_VOL_LVTAG?

Symmetric with FILEEXT and give even more information.

About the value, we should be more consistent, so:

TEMP_VOL_FILEEXT = ".temp"
TEMP_VOL_LVTAG = "OVIRT_VOL_TEMP"

We may like be more formal:

TEMP_VOL_FILEEXT = ".temporary"
TEMP_VOL_LVTAG = "OVIRT_VOL_TEMPORARY"

Or maybe:

TEMP_VOL_FILEEXT = ".volatile"
TEMP_VOL_LVTAG = "OVIRT_VOLATILE"

I like the last one :-)

See http://www.thesaurus.com/browse/temporary


-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: Port password module to python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: python3: Port password module to python 3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50848
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6317e00ac4d5c1201bc5169adac476e14a5aed68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: Port password module to python 3

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: python3: Port password module to python 3
..

python3: Port password module to python 3

Python 3 removed the iteritems() method from dict object. Use
six.iteritems() instead.

Change-Id: I6317e00ac4d5c1201bc5169adac476e14a5aed68
Signed-off-by: Nir Soffer 
---
M lib/vdsm/password.py
M tests/Makefile.am
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/50848/1

diff --git a/lib/vdsm/password.py b/lib/vdsm/password.py
index 336bb44..16ef9db 100644
--- a/lib/vdsm/password.py
+++ b/lib/vdsm/password.py
@@ -18,6 +18,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 from __future__ import absolute_import
+import six
 
 
 class ProtectedPassword(object):
@@ -68,7 +69,7 @@
 
 def _walk(obj):
 if isinstance(obj, dict):
-for key, value in obj.iteritems():
+for key, value in six.iteritems(obj):
 if key == "password":
 yield obj, key, value
 elif isinstance(value, (dict, list)):
diff --git a/tests/Makefile.am b/tests/Makefile.am
index ad1871d..f40455a 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -31,6 +31,7 @@
cmdutilsTests.py \
cpuProfileTests.py \
domainDescriptorTests.py \
+   passwordsTests.py \
permutationTests.py \
responseTests.py \
$(NULL)


-- 
To view, visit https://gerrit.ovirt.org/50848
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6317e00ac4d5c1201bc5169adac476e14a5aed68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: Port password module to python 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: python3: Port password module to python 3
..


Patch Set 1: Verified+1

Verified by the tests.

-- 
To view, visit https://gerrit.ovirt.org/50848
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6317e00ac4d5c1201bc5169adac476e14a5aed68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 8: Code-Review-1

(13 comments)

Partial review

https://gerrit.ovirt.org/#/c/50221/8/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3688: their meaning.
Line 3689: """
Line 3690: return {'domains': self.domainMonitor.getHostStatus(domains)}
Line 3691: 
Line 3692: def sdm_schedule(self, name, job):
No need for name parameter, use the job.id or add job.name.
Line 3693: """
Line 3694: SDM jobs currently run using the old TaskManager thread pool 
but none
Line 3695: of the other old Task features (ie. rollbacks, persistence) 
are
Line 3696: supported.  SDM tasks are managed using the Host Jobs API in 
jobs.py.


Line 3695: of the other old Task features (ie. rollbacks, persistence) 
are
Line 3696: supported.  SDM tasks are managed using the Host Jobs API in 
jobs.py.
Line 3697: """
Line 3698: def start_job(*args, **kwargs):
Line 3699: pass
Leftover?
Line 3700: 
Line 3701: jobs.add(job)
Line 3702: self.taskMng.scheduleJob("sdm", None, vars.task, name, 
job.run)
Line 3703: 


Line 3701: jobs.add(job)
Line 3702: self.taskMng.scheduleJob("sdm", None, vars.task, name, 
job.run)
Line 3703: 
Line 3704: @public
Line 3705: def sdm_create_volume(self, job_id, vol_info_params):
We don't need _params - we get a vol_info dict, and wrap it in 
CreateVolumeInfo, replacing vol_info so we cannot touch it.

vol_info = Wapper(vol_info)

This is good pattern when you do this in the start of the function.

In the future, the bridge will wrap the vol_info dict for us, based on the 
schema type.
Line 3706: vol_info = 
sdm.api.create_volume.CreateVolumeInfo(vol_info_params)
Line 3707: dom_manifest = sdCache.produce(vol_info.sd_id).manifest
Line 3708: host_id = self.domainMonitor.getHostId(vol_info.sd_id)
Line 3709: job = sdm.api.create_volume.Job(job_id, host_id, 
dom_manifest,


https://gerrit.ovirt.org/#/c/50221/8/vdsm/storage/sdm/api/create_volume.py
File vdsm/storage/sdm/api/create_volume.py:

Line 31: rmanager = rm.ResourceManager.getInstance()
Line 32: 
Line 33: 
Line 34: class Job(sdm_job.SdmJob):
Line 35: def __init__(self, job_id, host_id, dom_manifest, vol_info):
Lets use "sd" instead of "dom".
Line 36: super(Job, self).__init__(job_id, 'create_volume', host_id)
Line 37: self.dom_manifest = dom_manifest
Line 38: self.vol_info = vol_info
Line 39: 


Line 37: self.dom_manifest = dom_manifest
Line 38: self.vol_info = vol_info
Line 39: 
Line 40: def _run(self):
Line 41: vol_format = volume.name2type(self.vol_info.vol_format)
vol_info.vol_format can be the format enum - the api must use only strings, the 
code can use enums. If we use this system, we don't have to do this kind of 
translation by hand.
Line 42: self.dom_manifest.validateCreateVolumeParams(
Line 43: vol_format, self.vol_info.parent_vol_id)
Line 44: 
Line 45: with self.dom_manifest.domain_lock(self.host_id):


Line 54: try:
Line 55: artifacts.create(
Line 56: self.vol_info.virtual_size, vol_format,
Line 57: self.vol_info.disk_type, 
self.vol_info.description,
Line 58: self.vol_info.parent_vol_id)
Too many parameter, can we pass vol_info as is?
Line 59: artifacts.commit()
Line 60: except (volume_artifacts.CannotCreateVolumeArtifacts,
Line 61: volume_artifacts.VolumeArtifactsNotFound):
Line 62: self.log.exception("Error creating volume 
artifacts")


Line 59: artifacts.commit()
Line 60: except (volume_artifacts.CannotCreateVolumeArtifacts,
Line 61: volume_artifacts.VolumeArtifactsNotFound):
Line 62: self.log.exception("Error creating volume 
artifacts")
Line 63: raise se.VolumeCreationError()
This error translation is bad, and hiding the original error. The concept of 
raising specific error in vdsm for each verb is usless, and we should stop it 
now.

We should have set of common errors, and raise any of them from any verb, based 
the error (e.g OutOfSpace error is good for create volume or snapshot or most 
operations).

Engine has all the context to show translated error about creating a volume, it 
does not need CreateVolumeError from vdsm. If can use more specific errors from 
vdsm like OutOfSpace or PermisionDenied, or NoSuchFile to show useful error 
message.

For example:

Cannot create volume "Foo"

There is no available space on storage domain "Bar".

The first part of the error is based on what engine knows. 

Change in vdsm[master]: gluster: fix size conversion issues in brick create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 7:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Handle missing glusterfs-cli package

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 1: Verified+1

Verified on master

-- 
To view, visit https://gerrit.ovirt.org/50787
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[sshnaidm]

Sagi Shnaidman has uploaded a new change for review.

Change subject: Always propagate bonding mode to engine
..

Always propagate bonding mode to engine

Without this patch the bond mode is not propagated
if it's not equal to 0 (default) although
engine expect it to be always propagated

Change-Id: I1c5a2cfb6f2d5742aad3bc57a851e02764c2fdfa
Bug-Url: https://bugzilla.redhat.com/1276445
Signed-off-by: Sagi Shnaidman 
---
M lib/vdsm/netconfpersistence.py
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
3 files changed, 32 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/50792/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index b5c3f14..a0af856 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -369,6 +369,8 @@
 # TODO: globalize default bond options from Bond in models.py
 normalized_opts = self._parse_bond_options(
 bond_attr.get('options'))
+if "mode" not in normalized_opts:
+normalized_opts["mode"] = '0'
 bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
 normalized_opts)
 # before d18e2f10 bondingOptions were also part of networks, so in case
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index fd5b209..ad35072 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -427,14 +427,15 @@
 def _getBondingOptions(bond):
 """
 Return non-empty options differing from defaults, excluding not actual or
-not applicable options, e.g. 'ad_num_ports' or 'slaves'.
+not applicable options, e.g. 'ad_num_ports' or 'slaves'  and always return
+bonding mode even if it's default, e.g. 'mode=0'
 """
 opts = bondOpts(bond)
 mode = opts['mode'][-1] if 'mode' in opts else None
 defaults = getDefaultBondingOptions(mode)
 
 return dict(((opt, val[-1]) for (opt, val) in opts.iteritems()
- if val and val != defaults.get(opt)))
+ if val and (val != defaults.get(opt) or opt == "mode")))
 
 
 def _bondOptsForIfcfg(opts):
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 7bff125..5ab22d1 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -270,8 +270,8 @@
 # TODO: we should try and call this logic always during
 # TODO: assertBondExists and be stricter. Will probably need to fix a
 # TODO: few tests
-self.assertEqual(set(self._get_active_bond_opts(bond)),
- set(opts))
+self.assertEqual(set(self._get_active_bond_opts(bond))-set(["mode=0"]),
+ set(opts)-set(["mode=0"]))
 
 def _get_active_bond_opts(self, bondName):
 netinfo = self.vdsm_net.netinfo
@@ -2745,3 +2745,28 @@
 {}, {BONDING_NAME: {'remove': True}}, NOCHK)
 self.assertEqual(status, SUCCESS, msg)
 self.assertBondDoesntExist(BONDING_NAME, nics)
+
+@permutations([[{}], [{'options': 'mode=1'}], [{'options': 'mode=0'}]])
+@cleanupNet
+@ValidateRunningAsRoot
+def test_bondmode_in_capabilities(self, mode_arg):
+with dummyIf(2) as nics:
+if mode_arg:
+origin_mode = mode_arg.get("options").split("=")[1]
+else:
+origin_mode = '0'
+bonding = {'nics': nics}
+bonding.update(mode_arg)
+status, msg = self.setupNetworks(
+{},
+{BONDING_NAME: bonding},
+NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondExists(BONDING_NAME, nics)
+status, msg, info = self.vdsm_net.getVdsCapabilities()
+mode = info['bondings'][BONDING_NAME]['opts'].get('mode')
+self.assertEqual(mode, origin_mode)
+status, msg = self.setupNetworks(
+{}, {BONDING_NAME: {'remove': True}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondDoesntExist(BONDING_NAME, nics)


-- 
To view, visit https://gerrit.ovirt.org/50792
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c5a2cfb6f2d5742aad3bc57a851e02764c2fdfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 1: Verified-1

* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Product::#1276445::OK, Correct classification oVirt
* Check TM::#1276445::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/50792
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5a2cfb6f2d5742aad3bc57a851e02764c2fdfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[sshnaidm]

Sagi Shnaidman has abandoned this change.

Change subject: Always propagate bonding mode to engine
..


Abandoned

wrong change-id

-- 
To view, visit https://gerrit.ovirt.org/50792
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1c5a2cfb6f2d5742aad3bc57a851e02764c2fdfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[sshnaidm]

Sagi Shnaidman has uploaded a new change for review.

Change subject: Always propagate bonding mode to engine
..

Always propagate bonding mode to engine

Without this patch the bond mode is not propagated
if it's not equal to 0 (default) although
engine expect it to be always propagated

Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Bug-Url: https://bugzilla.redhat.com/1276445
Signed-off-by: Sagi Shnaidman 
---
M lib/vdsm/netconfpersistence.py
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
3 files changed, 32 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/50793/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index b5c3f14..a0af856 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -369,6 +369,8 @@
 # TODO: globalize default bond options from Bond in models.py
 normalized_opts = self._parse_bond_options(
 bond_attr.get('options'))
+if "mode" not in normalized_opts:
+normalized_opts["mode"] = '0'
 bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
 normalized_opts)
 # before d18e2f10 bondingOptions were also part of networks, so in case
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index fd5b209..ad35072 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -427,14 +427,15 @@
 def _getBondingOptions(bond):
 """
 Return non-empty options differing from defaults, excluding not actual or
-not applicable options, e.g. 'ad_num_ports' or 'slaves'.
+not applicable options, e.g. 'ad_num_ports' or 'slaves'  and always return
+bonding mode even if it's default, e.g. 'mode=0'
 """
 opts = bondOpts(bond)
 mode = opts['mode'][-1] if 'mode' in opts else None
 defaults = getDefaultBondingOptions(mode)
 
 return dict(((opt, val[-1]) for (opt, val) in opts.iteritems()
- if val and val != defaults.get(opt)))
+ if val and (val != defaults.get(opt) or opt == "mode")))
 
 
 def _bondOptsForIfcfg(opts):
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 7bff125..5ab22d1 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -270,8 +270,8 @@
 # TODO: we should try and call this logic always during
 # TODO: assertBondExists and be stricter. Will probably need to fix a
 # TODO: few tests
-self.assertEqual(set(self._get_active_bond_opts(bond)),
- set(opts))
+self.assertEqual(set(self._get_active_bond_opts(bond))-set(["mode=0"]),
+ set(opts)-set(["mode=0"]))
 
 def _get_active_bond_opts(self, bondName):
 netinfo = self.vdsm_net.netinfo
@@ -2745,3 +2745,28 @@
 {}, {BONDING_NAME: {'remove': True}}, NOCHK)
 self.assertEqual(status, SUCCESS, msg)
 self.assertBondDoesntExist(BONDING_NAME, nics)
+
+@permutations([[{}], [{'options': 'mode=1'}], [{'options': 'mode=0'}]])
+@cleanupNet
+@ValidateRunningAsRoot
+def test_bondmode_in_capabilities(self, mode_arg):
+with dummyIf(2) as nics:
+if mode_arg:
+origin_mode = mode_arg.get("options").split("=")[1]
+else:
+origin_mode = '0'
+bonding = {'nics': nics}
+bonding.update(mode_arg)
+status, msg = self.setupNetworks(
+{},
+{BONDING_NAME: bonding},
+NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondExists(BONDING_NAME, nics)
+status, msg, info = self.vdsm_net.getVdsCapabilities()
+mode = info['bondings'][BONDING_NAME]['opts'].get('mode')
+self.assertEqual(mode, origin_mode)
+status, msg = self.setupNetworks(
+{}, {BONDING_NAME: {'remove': True}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondDoesntExist(BONDING_NAME, nics)


-- 
To view, visit https://gerrit.ovirt.org/50793
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: ensure LV size is multiple of VG's PE value

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 3: Code-Review+2 Continuous-Integration+1

CI failure is not relevant.

-- 
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[edwardh]

Edward Haas has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50793
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: ensure LV size is multiple of VG's PE value

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


gluster: ensure LV size is multiple of VG's PE value

 Alignment value for JBOD is changed to 256 KiB from 0
in https://gerrit.ovirt.org/#/c/47959 and alignment value is
used as PE value in VG creation. It resulted in following
error for some JBOD disks.

"DeviceError: ('Adding new lv is too large to fit in free space',
 u'vg-brick2-pool-brick2'"

Size of LV should be multiple of PE value. But this calculation
was done only for RAID volume not for JBOD and that was the casue for
above error.

With this patch, lv size will be adjusted to the multiples of PE
always regardless of whether its RAID or JBOD.

Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Bug-Url: https://bugzilla.redhat.com/1270792
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50802
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve
  Ramesh N: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: ensure LV size is multiple of VG's PE value

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 4:

* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: ensure LV size is multiple of VG's PE value

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 215: volPath = os.path.join(toDelDir, volUUID)
Line 216: self._deleteFile("volume", volPath)
Line 217: self._deleteFile("metadata", volPath + '.meta')
Line 218: if self.hasVolumeLeases():
Line 219: self._deleteFile("lease", volPath + '.lease')
> Before this patch, the flow will stop after the first failure. Here it will
Yes
Line 220: self.log.debug("Removing directory: %s", toDelDir)
Line 221: try:
Line 222: self.oop.os.rmdir(toDelDir)
Line 223: except OSError as e:


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: fix size conversion issues in brick create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50808
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 216: self._deleteFile("volume", volPath)
: self._deleteFile("metadata", volPath + '.meta')
: if self.hasVolumeLeases():
: self._deleteFile("lease", volPath + '.lease')
> Before this patch, the flow will stop after the first failure. Here it will
Forget it, I missed the explanation in the commit message.


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster add mount options for gluster brick.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: ensure LV size is multiple of VG's PE value

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: fix alignment issue for brick creation on JBOD

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: fix size conversion issues in brick create

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50808
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster add mount options for gluster brick.

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: fix alignment issue for brick creation on JBOD

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1:

I think you should first merge this into ovirt-3.6 before backporting to 
ovirt-3.5.

-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: startup: Change system default encoding to utf8

[automation]

gerrit-hooks has posted comments on this change.

Change subject: startup: Change system default encoding to utf8
..


Patch Set 6:

* #1281940::Update tracker: OK
* Set MODIFIED::bug 1281940#1281940OK

-- 
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1:

(4 comments)

Nice

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 223: except OSError as e:
Line 224: self.log.error("removed image dir: %s can't be removed", 
toDelDir)
Line 225: raise se.ImageDeleteError("%s %s" % (imgUUID, str(e)))
Line 226: 
Line 227: def _deleteFile(self, fileType, filePath):
- Rename _deleteFile to _deleteVolumeFile. This is not a generic utility for 
deleting files.
- There is not need for fileType, the type of the file is clear from the file 
path.
- rename filePath to path.
Line 228: try:
Line 229: self.oop.os.remove(filePath)
Line 230: self.log.debug("%s file: %s was removed.", fileType, 
filePath)
Line 231: except OSError as ose:


Line 226: 
Line 227: def _deleteFile(self, fileType, filePath):
Line 228: try:
Line 229: self.oop.os.remove(filePath)
Line 230: self.log.debug("%s file: %s was removed.", fileType, 
filePath)
Put the log *before* the operation - if the operation get stuck, we want to see 
this log, so we know what the machine is doing now.

Keep the previous log format, it was good:

self.log.debug("Removing file: %s", path)
Line 231: except OSError as ose:
Line 232: if ose.errno != errno.ENOENT:
Line 233: self.log.error("%s file: %s can't be removed.",
Line 234:fileType, filePath, exc_info=True)


Line 227: def _deleteFile(self, fileType, filePath):
Line 228: try:
Line 229: self.oop.os.remove(filePath)
Line 230: self.log.debug("%s file: %s was removed.", fileType, 
filePath)
Line 231: except OSError as ose:
Don't use such names, in this context there is only *one* exception, and the 
best name for it is "e".

Even if we had multiple exceptions there is no need to use different exception 
names (unlike java).
Line 232: if ose.errno != errno.ENOENT:
Line 233: self.log.error("%s file: %s can't be removed.",
Line 234:fileType, filePath, exc_info=True)
Line 235: 


Line 230: self.log.debug("%s file: %s was removed.", fileType, 
filePath)
Line 231: except OSError as ose:
Line 232: if ose.errno != errno.ENOENT:
Line 233: self.log.error("%s file: %s can't be removed.",
Line 234:fileType, filePath, exc_info=True)
Do not use exc_info, it is non-standard and we want to kill it.

If you want to log an exception (with traceback), use log.exception()

In this context, missing file is very unlikely since we looked for all the 
files, so logging a warning about missing volume file is a good idea.
Line 235: 
Line 236: def getAllVolumes(self):
Line 237: """
Line 238: Return dict {volUUID: ((imgUUIDs,), parentUUID)} of the 
domain.


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: show vlan in caps ports

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: hooks: ovs: show vlan in caps ports
..


Patch Set 4: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 3

-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 1:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::#1290997::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50787
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Handle missing glusterfs-cli package

[ahino]

Hello Nir Soffer, Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50787

to review the following change.

Change subject: gluster: Handle missing glusterfs-cli package
..

gluster: Handle missing glusterfs-cli package

In 3.6 we introduced a soft dependency to glusterfs-cli. This was
required in order to get gluster volume info needed for to purposes:
1. get gluster backup servers in order to automatically mount gluster
   back servers
2. get replica related to verify that it is supported
However, during upgrade, if glusterfs-cli is missing, mount failed. In
this case, we'd like to add a warning message clearly indicating about
the missing glustefs-cli package, and ask the admin to install it in
order to enable automatica mount of gluster backup servers.

Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Signed-off-by: Ala Hino 
Bug-Url: https://bugzilla.redhat.com/1290997
Reviewed-on: https://gerrit.ovirt.org/50363
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Sahina Bose 
---
M tests/storageServerTests.py
M vdsm/gluster/cli.py
M vdsm/storage/storageServer.py
3 files changed, 33 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/50787/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 13cb27e..3ad5230 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -19,6 +19,7 @@
 #
 
 from monkeypatch import MonkeyPatch
+import gluster.cli
 from testlib import permutations, expandPermutations
 from testlib import VdsmTestCase
 from storage.storageServer import GlusterFSConnection
@@ -131,6 +132,7 @@
 self.assertEquals(mount_con._mount.fs_file,
   "/tmp/glusterSD/server:_volume")
 
+@MonkeyPatch(gluster.cli, 'exists', lambda: True)
 @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
 def test_gluster_replica3_mount_options(self):
 def glusterVolumeInfo(volname=None, volfileServer=None):
@@ -147,6 +149,7 @@
 self.assertEquals(gluster.options,
   "backup-volfile-servers=192.168.122.2:192.168.122.3")
 
+@MonkeyPatch(gluster.cli, 'exists', lambda: True)
 @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
 def test_server_not_in_volinfo(self):
 """
@@ -166,6 +169,7 @@
 "backup-volfile-servers=192.168.122.5:192.168.122.2:192.168.122.3"
 self.assertEquals(gluster.options, expected_backup_servers)
 
+@MonkeyPatch(gluster.cli, 'exists', lambda: True)
 @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
 def test_duplicate_servers_in_volinfo(self):
 """
@@ -186,6 +190,7 @@
 "backup-volfile-servers=192.168.122.5:192.168.122.2:192.168.122.3"
 self.assertEquals(gluster.options, expected_backup_servers)
 
+@MonkeyPatch(gluster.cli, 'exists', lambda: True)
 @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
 def test_gluster_and_user_provided_mount_options(self):
 def glusterVolumeInfo(volname=None, volfileServer=None):
@@ -237,3 +242,8 @@
 
 gluster = GlusterFSConnection(spec="192.168.122.1:/music")
 gluster.validate()
+
+@MonkeyPatch(gluster.cli, 'exists', lambda: False)
+def test_glusterfs_cli_missing(self):
+gluster = GlusterFSConnection(spec="192.168.122.1:/music")
+self.assertEquals(gluster.options, "")
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 8d399f0..995576c 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -20,6 +20,7 @@
 
 import calendar
 import logging
+import os
 import socket
 import time
 import xml.etree.cElementTree as etree
@@ -1579,3 +1580,12 @@
 return True
 except ge.GlusterCmdFailedException as e:
 raise ge.GlusterGeoRepSessionDeleteFailedException(rc=e.rc, err=e.err)
+
+
+def exists():
+try:
+return os.path.exists(_glusterCommandPath.cmd)
+except OSError as e:
+if e.errno != os.errno.ENOENT:
+raise
+return False
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 35cf81e..25f0d46 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -42,6 +42,7 @@
 import iscsi
 from sync import asyncmethod, AsyncCallStub
 from mount import MountError
+import gluster.cli
 import storage_exception as se
 
 
@@ -314,13 +315,14 @@
 self._volinfo = None
 self._volfileserver, volname = self._remotePath.split(":", 1)
 self._volname = volname.strip('/')
+self._have_gluster_cli = gluster.cli.exists()
 
 @property
 def options(self):
+backup_servers_option = ""
 if "backup-volfile-servers" in self._options:
 self.log.warn("Using user specified backup-volfile-servers option")
-  

Change in vdsm[master]: net: Update mtu under the bridge only when needed

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Update mtu under the bridge only when needed
..

net: Update mtu under the bridge only when needed

Updating the mtu of an existing bridge and its ports,
only when the mtu is different from the current value.

Change-Id: I0f26d1d6ddbb5ed1e7ecb4f6d7df1c185bccecc0
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/api.py
1 file changed, 16 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/50790/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index f5d5cb1..93c55d2 100755
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -35,10 +35,9 @@
 from vdsm import kernelconfig
 from vdsm import netconfpersistence
 from vdsm.netinfo import (addresses, libvirtNets2vdsm, bridges,
-  get as netinfo_get, CachingNetInfo,
+  get as netinfo_get, CachingNetInfo, mtus,
   networks as netinfo_networks, nics as netinfo_nics,
   NET_PATH)
-from vdsm.netinfo.mtus import DEFAULT_MTU
 from vdsm import udevadm
 from vdsm import utils
 from vdsm import ipwrapper
@@ -319,18 +318,15 @@
 _netinfo=_netinfo, configurator=configurator, opts=options)
 
 if bridged and network in _netinfo.bridges:
-net_ent_to_configure = net_ent.port
+# The bridge already exists, update the configured entity to one level
+# down and update the mtu of the bridge.
+# The mtu is updated in the bridge configuration and in all the tap
+# devices attached to it (for the VMs).
+# (expecting the bridge running mtu to be updated by the kernel when
+# the device attached under it has its mtu updated)
 logging.info("Bridge %s already exists.", network)
-
-# TODO: Update the mtu only if it is different from current.
-
-# The bridge already exists and we attach a new underlying device
-# to it. We need to make sure that the bridge MTU configuration is
-# updated.
-configurator.configApplier.setIfaceMtu(network, mtu)
-# We must also update the vms` tap devices (the bridge ports in
-# this case) so that their MTU is synced with the bridge
-_update_bridge_ports_mtu(net_ent.name, mtu)
+net_ent_to_configure = net_ent.port
+_update_mtu_for_an_existing_bridge(network, configurator, mtu)
 else:
 net_ent_to_configure = net_ent
 
@@ -340,6 +336,12 @@
 configurator.configureLibvirtNetwork(network, net_ent)
 if hostQos is not None:
 configurator.configureQoS(hostQos, net_ent)
+
+
+def _update_mtu_for_an_existing_bridge(dev_name, configurator, mtu):
+if mtu != mtus.getMtu(dev_name):
+configurator.configApplier.setIfaceMtu(dev_name, mtu)
+_update_bridge_ports_mtu(dev_name, mtu)
 
 
 def assertBridgeClean(bridge, vlan, bonding, nics):
@@ -977,7 +979,7 @@
 continue
 
 if 'mtu' not in attrs:
-attrs['mtu'] = DEFAULT_MTU
+attrs['mtu'] = mtus.DEFAULT_MTU
 
 
 def setSafeNetworkConfig():


-- 
To view, visit https://gerrit.ovirt.org/50790
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f26d1d6ddbb5ed1e7ecb4f6d7df1c185bccecc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Update mtu under the bridge only when needed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Update mtu under the bridge only when needed
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50790
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f26d1d6ddbb5ed1e7ecb4f6d7df1c185bccecc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 1:

* #1276445::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/50792
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5a2cfb6f2d5742aad3bc57a851e02764c2fdfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 1:

* #1276445::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1276445::OK, public bug
* Check Product::#1276445::OK, Correct classification oVirt
* Check TM::#1276445::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50793
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Always propagate bonding mode to engine

[sshnaidm]

Sagi Shnaidman has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50793
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test network's iface

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: tests: test network's iface
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: ensure LV size is multiple of VG's PE value

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 22:

(4 comments)

https://gerrit.ovirt.org/#/c/42908/22//COMMIT_MSG
Commit Message:

Line 29: ---
Line 30: 
Line 31: writers: 1 readers: 2
Line 32: writes  avg=3381.00 med=3381 min=3381 max=3381
Line 33: reads   avg=3367.00 med=3376 min=3358 max=3376
> what those numbers mean?
average/median/mininum/maximum number of times a lock was taken by readers or 
by writers during a test. This is the output of the RWLockStressTests results, 
running with different number of readers and writers.

Higher numbers means the lock is more efficient.
Line 34: 
Line 35: writers: 2 readers: 8
Line 36: writes  avg=945.00 med=945 min=945 max=945
Line 37: reads   avg=937.38 med=938 min=933 max=940


https://gerrit.ovirt.org/#/c/42908/22/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:

Line 85: 
Line 86: def acquire_write(self):
Line 87: me = threading.current_thread()
Line 88: if me is self._writer:
Line 89: self._holders[me] += 1
> this for the recursive lock I guess
Yes
Line 90: return
Line 91: if me in self._holders:
Line 92: raise RuntimeError("Lock promotion is forbidden")
Line 93: with self._lock:


Line 107: if self._writer or self._waiters:
Line 108: self._wait(False)
Line 109: self._holders[me] = 1
Line 110: if self._waiters:
Line 111: self._grant_next_waiter()
> can't it cause a race? set the event while same holder can acquire the lock
Can you describe the flow that may be racy?

At this point, the current thread is holding self._lock. No other thread can 
access this object, except another reader that already hold this lock.

The waiter list may have other threads waiting to take a read or write lock.

grant_next_waiter will wake up the next reader thread, and it will return from 
self._wait(), take a read lock and wake up the next waiter.
Line 112: 
Line 113: def release(self):
Line 114: me = threading.current_thread()
Line 115: if me not in self._holders:


Line 108: self._wait(False)
Line 109: self._holders[me] = 1
Line 110: if self._waiters:
Line 111: self._grant_next_waiter()
Line 112: 
> and after this scope you release _lock as its under context. the lock shoul
No, the lock is protecting the rwlock internals. Both readers and writers take 
this lock for very short time, marking the rwlock as "locked" for reading or 
writing.

The actual waiting on the lock (e.g. acquire_read() when a writer is holding 
the rwlock) is implemented using a list of Waiter objects.
Line 113: def release(self):
Line 114: me = threading.current_thread()
Line 115: if me not in self._holders:
Line 116: raise RuntimeError("Thread %s attempted to release a lock 
it "


-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster add mount options for gluster brick.

[rnachimu]

Hello Nir Soffer, Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50807

to review the following change.

Change subject: gluster add mount options for gluster brick.
..

gluster add mount options for gluster brick.

 Mount options "inode64,noatime" should be used to
mount the gluster brick to improve the performance.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50770
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/50807/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index f19d959..8f50452 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -273,7 +273,8 @@
 raise ge.GlusterHostStorageDeviceMkfsFailedException(
 thinlv.path, alignment, raidParams.get('stripeSize', 0), fsType)
 
-format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path)
+format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path,
+  mountopts=DEFAULT_MOUNT_OPTIONS)
 format._defaultFormatOptions = ["-f", "-i", "size=512", "-n", "size=8192"]
 if raidParams.get('type') == '6':
 format._defaultFormatOptions += ["-d", "sw=%s,su=%sk" % (
@@ -296,5 +297,6 @@
 rc, out, err = utils.execCmd([_vgscanCommandPath.cmd])
 if rc:
 raise ge.GlusterHostStorageDeviceVGScanFailedException(rc, out, err)
-fstab.FsTab().add(thinlv.path, mountPoint, DEFAULT_FS_TYPE)
+fstab.FsTab().add(thinlv.path, mountPoint,
+  DEFAULT_FS_TYPE, mntOpts=[DEFAULT_MOUNT_OPTIONS])
 return _getDeviceDict(thinlv)


-- 
To view, visit https://gerrit.ovirt.org/50807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: ensure LV size is multiple of VG's PE value

[rnachimu]

Hello Nir Soffer, Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50809

to review the following change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..

gluster: ensure LV size is multiple of VG's PE value

 Alignment value for JBOD is changed to 256 KiB from 0
in https://gerrit.ovirt.org/#/c/47959 and alignment value is
used as PE value in VG creation. It resulted in following
error for some JBOD disks.

"DeviceError: ('Adding new lv is too large to fit in free space',
 u'vg-brick2-pool-brick2'"

Size of LV should be multiple of PE value. But this calculation
was done only for RAID volume not for JBOD and that was the casue for
above error.

With this patch, lv size will be adjusted to the multiples of PE
always regardless of whether its RAID or JBOD.

Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Bug-Url: https://bugzilla.redhat.com/1270792
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50802
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/50809/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 6ec47e2..da8f1f6 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -262,16 +262,14 @@
 # a multiple of RAID stripe width if it is > minimum vg size
 # otherwise allocate a minimum of 0.5% of the data device size
 # and create data LV (poolDataSize) that has a size which is
-# a multiple of stripe width
-# For JBOD, this adjustment is not necessary
+# a multiple of stripe width.
 vgSizeKib = int(_getDeviceSize(vg, 'KiB'))
 if _getDeviceSize(vg) < MIN_VG_SIZE:
 metaDataSizeKib = vgSizeKib * MIN_METADATA_PERCENT
 poolDataSize = vgSizeKib - metaDataSizeKib
 
-if raidType:
-metaDataSizeKib = (metaDataSizeKib - (metaDataSizeKib % alignment))
-poolDataSize = (poolDataSize - (poolDataSize % alignment))
+metaDataSizeKib = (metaDataSizeKib - (metaDataSizeKib % alignment))
+poolDataSize = (poolDataSize - (poolDataSize % alignment))
 
 # Creating a thin pool from the data LV and the metadata LV
 # lvconvert --chunksize alignment --thinpool VOLGROUP/thin_pool


-- 
To view, visit https://gerrit.ovirt.org/50809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: fix alignment issue for brick creation on JBOD

[rnachimu]

Hello Nir Soffer, Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50806

to review the following change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..

gluster: fix alignment issue for brick creation on JBOD

  Chunk size and alignment value should be 256KB for
 JBOD use case. So assigining these values incase of
JBOD.

 Note: blivet doesn't support alignment values in PV,VG,
Thinpool creation. So we were using blivet API only when i
we don't have any alignment and LVM commands directly when
we have alignment values. Now, with this patch we will
use lvm commands always as we have alignment values in all
the cases and Blivet API usage can be removed completely
in PV, Thin pool, VG creation.

Bug-Url: https://bugzilla.redhat.com/1270792
Signed-off-by: Ramesh Nachimuthu 
Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Signed-off-by: Timothy Asir Jeyasingh 
Reviewed-on: https://gerrit.ovirt.org/47959
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 72 insertions(+), 98 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/50806/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 93219c2..f19d959 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -26,8 +26,6 @@
 import blivet.formats
 import blivet.formats.fs
 import blivet.size
-from blivet.devices import LVMVolumeGroupDevice
-from blivet.devices import LVMThinPoolDevice
 from blivet.devices import LVMLogicalVolumeDevice
 from blivet.devices import LVMThinLogicalVolumeDevice
 from blivet import udev
@@ -137,114 +135,89 @@
 return [blivetEnv.devicetree.getDeviceByName(devName.split("/")[-1])
 for devName in devNameList]
 
-def _createPV(deviceList, alignment=0):
-def _createAlignedPV(deviceList, alignment):
-for dev in deviceList:
-# bz#1178705: Blivet always creates pv with 1MB dataalignment
-# Workaround: Till blivet fixes the issue, we use lvm pvcreate
-rc, out, err = utils.execCmd([_pvCreateCommandPath.cmd,
-  '--dataalignment',
-  '%sk' % alignment,
-  dev.path])
-if rc:
-raise ge.GlusterHostStorageDevicePVCreateFailedException(
-dev.path, alignment, rc, out, err)
-_reset_blivet(blivetEnv)
-return _getDeviceList([dev.name for dev in deviceList])
-
-if alignment:
-blivetEnv.doIt()
-return _createAlignedPV(deviceList, alignment)
-
+def _createPV(deviceList, alignment):
 for dev in deviceList:
-lvmpv = blivet.formats.getFormat("lvmpv", device=dev.path)
-blivetEnv.formatDevice(dev, lvmpv)
-
-blivet.partitioning.doPartitioning(blivetEnv)
-return deviceList
-
-def _createVG(vgName, deviceList, stripeSize=0):
-if stripeSize:
-# bz#1198568: Blivet always creates vg with 1MB stripe size
-# Workaround: Till blivet fixes the issue, use vgcreate command
-devices = ','.join([device.path for device in deviceList])
-rc, out, err = utils.execCmd([_vgCreateCommandPath.cmd,
-  '-s', '%sk' % stripeSize,
-  vgName, devices])
+# bz#1178705: Blivet always creates pv with 1MB dataalignment
+# Workaround: Till blivet fixes the issue, we use lvm pvcreate
+rc, out, err = utils.execCmd([_pvCreateCommandPath.cmd,
+  '--dataalignment',
+  '%sk' % alignment,
+  dev.path])
 if rc:
-raise ge.GlusterHostStorageDeviceVGCreateFailedException(
-vgName, devices, stripeSize, rc, out, err)
-blivetEnv.reset()
-vg = blivetEnv.devicetree.getDeviceByName(vgName)
-else:
-vg = LVMVolumeGroupDevice(vgName, parents=deviceList)
-blivetEnv.createDevice(vg)
-return vg
+raise ge.GlusterHostStorageDevicePVCreateFailedException(
+dev.path, alignment, rc, out, err)
+_reset_blivet(blivetEnv)
+return _getDeviceList([dev.name for dev in deviceList])
 
-def _createThinPool(poolName, vg, alignment=0,
-poolMetaDataSize=0, poolDataSize=0):
-if not alignment:
-# bz#1180228: blivet doesn't handle percentage-based sizes properly
-# 

Change in vdsm[ovirt-3.5-gluster]: gluster: fix size conversion issues in brick create

[rnachimu]

Hello Nir Soffer, Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50808

to review the following change.

Change subject: gluster: fix size conversion issues in brick create
..

gluster: fix size conversion issues in brick create

 There is change in blivet API device.size.convertTo(spec).
spec was a string parameter in older versions of blivet but its changed
to constants in newer versions. This patch address this issue
in a generic way so that it can run on all releases.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50705
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 24 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/50808/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 8f50452..6ec47e2 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -63,6 +63,20 @@
 DEFAULT_MOUNT_OPTIONS = "inode64,noatime"
 
 
+# This method helps to convert the size to given Unittype.
+# This is required since there an incompatible change in blivet API
+# size.convertTo. Older versions required string param but newer versions
+# requires the equivalent constants in blivet.size
+def _getDeviceSize(device, unitType='MiB'):
+if hasattr(blivet.size, 'MiB'):
+# New Blivet requires size constants from blivet.size
+unit = getattr(blivet.size, unitType)
+return device.size.convertTo(unit)
+else:
+# Older blivet needs spec string
+return device.size.convertTo(spec=unitType)
+
+
 def _getDeviceDict(device, createBrick=False):
 info = {'name': device.name,
 'devPath': device.path,
@@ -74,7 +88,7 @@
 'uuid': '',
 'createBrick': createBrick}
 if isinstance(device.size, blivet.size.Size):
-info['size'] = '%s' % device.size.convertTo(spec="MiB")
+info['size'] = '%s' % _getDeviceSize(device)
 else:
 info['size'] = '%s' % device.size
 if not info['bus'] and device.parents:
@@ -207,7 +221,7 @@
 poolDataSize = 0
 count = 0
 raidType = raidParams.get('type')
-metaDataSize = DEFAULT_METADATA_SIZE_KB
+metaDataSizeKib = DEFAULT_METADATA_SIZE_KB
 if raidType == '6':
 count = raidParams['pdCount'] - 2
 alignment = raidParams['stripeSize'] * count
@@ -244,25 +258,26 @@
 # http://docbuilder.usersys.redhat.com/22522
 # /#chap-Configuring_Red_Hat_Storage_for_Enhancing_Performance
 
-# create ~16GB metadata LV (metaDataSize) that has a size which is
+# create ~16GB metadata LV (metaDataSizeKib) that has a size which is
 # a multiple of RAID stripe width if it is > minimum vg size
 # otherwise allocate a minimum of 0.5% of the data device size
 # and create data LV (poolDataSize) that has a size which is
 # a multiple of stripe width
 # For JBOD, this adjustment is not necessary
-vgSizeKib = int(vg.size.convertTo(spec="KiB"))
-if vg.size.convertTo(spec='MiB') < MIN_VG_SIZE:
-metaDataSize = vgSizeKib * MIN_METADATA_PERCENT
-poolDataSize = vgSizeKib - metaDataSize
+vgSizeKib = int(_getDeviceSize(vg, 'KiB'))
+if _getDeviceSize(vg) < MIN_VG_SIZE:
+metaDataSizeKib = vgSizeKib * MIN_METADATA_PERCENT
+poolDataSize = vgSizeKib - metaDataSizeKib
 
 if raidType:
-metaDataSize = (metaDataSize - (metaDataSize % alignment))
+metaDataSizeKib = (metaDataSizeKib - (metaDataSizeKib % alignment))
 poolDataSize = (poolDataSize - (poolDataSize % alignment))
 
 # Creating a thin pool from the data LV and the metadata LV
 # lvconvert --chunksize alignment --thinpool VOLGROUP/thin_pool
 # --poolmetadata VOLGROUP/metadata_device_name
-pool = _createThinPool(poolName, vg, chunkSize, metaDataSize, poolDataSize)
+pool = _createThinPool(poolName, vg, chunkSize, metaDataSizeKib,
+   poolDataSize)
 thinlv = LVMThinLogicalVolumeDevice(brickName, parents=[pool],
 size=vg.size, grow=True)
 blivetEnv.createDevice(thinlv)


-- 
To view, visit https://gerrit.ovirt.org/50808
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[rnachimu]

Hello Nir Soffer, Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50805

to review the following change.

Change subject: gluster: create bricks without MBR partitions
..

gluster: create bricks without MBR partitions

 During gluster brick creation, PVs should be
created directly on the disks instead of MBR
partitions to align the pvs correctly as per given
RAID parameter. This patch will remove the
_makePartition function and will not create
parition as part of gluster brick creation.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50769
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 1 insertion(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/50805/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 1e4402c..93219c2 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -137,24 +137,6 @@
 return [blivetEnv.devicetree.getDeviceByName(devName.split("/")[-1])
 for devName in devNameList]
 
-def _makePartition(deviceList):
-pvDeviceList = []
-doPartitioning = False
-for dev in deviceList:
-if dev.type not in ['disk', 'dm-multipath']:
-pvDeviceList.append(dev)
-else:
-blivetEnv.initializeDisk(dev)
-part = blivetEnv.newPartition(fmt_type="lvmpv", grow=True,
-  parents=[dev])
-blivetEnv.createDevice(part)
-pvDeviceList.append(part)
-doPartitioning = True
-
-if doPartitioning:
-blivet.partitioning.doPartitioning(blivetEnv)
-return pvDeviceList
-
 def _createPV(deviceList, alignment=0):
 def _createAlignedPV(deviceList, alignment):
 for dev in deviceList:
@@ -283,8 +265,7 @@
 if inUseList:
 raise ge.GlusterHostStorageDeviceInUseException(inUseList)
 
-pvDeviceList = _makePartition(deviceList)
-pvDeviceList = _createPV(pvDeviceList, alignment)
+pvDeviceList = _createPV(deviceList, alignment)
 vg = _createVG(vgName, pvDeviceList, raidParams.get('stripeSize', 0))
 
 # The following calculation is based on the redhat storage performance doc


-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1:

This is a special branch for gluster :-).  But Yes. I have to back port the 
patches to ovirt 3.6 as well.

-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: show vlan in caps ports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: show vlan in caps ports
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 22:

(4 comments)

https://gerrit.ovirt.org/#/c/42908/22//COMMIT_MSG
Commit Message:

Line 29: ---
Line 30: 
Line 31: writers: 1 readers: 2
Line 32: writes  avg=3381.00 med=3381 min=3381 max=3381
Line 33: reads   avg=3367.00 med=3376 min=3358 max=3376
what those numbers mean?
Line 34: 
Line 35: writers: 2 readers: 8
Line 36: writes  avg=945.00 med=945 min=945 max=945
Line 37: reads   avg=937.38 med=938 min=933 max=940


https://gerrit.ovirt.org/#/c/42908/22/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:

Line 85: 
Line 86: def acquire_write(self):
Line 87: me = threading.current_thread()
Line 88: if me is self._writer:
Line 89: self._holders[me] += 1
this for the recursive lock I guess
Line 90: return
Line 91: if me in self._holders:
Line 92: raise RuntimeError("Lock promotion is forbidden")
Line 93: with self._lock:


Line 107: if self._writer or self._waiters:
Line 108: self._wait(False)
Line 109: self._holders[me] = 1
Line 110: if self._waiters:
Line 111: self._grant_next_waiter()
can't it cause a race? set the event while same holder can acquire the lock 
again
Line 112: 
Line 113: def release(self):
Line 114: me = threading.current_thread()
Line 115: if me not in self._holders:


Line 108: self._wait(False)
Line 109: self._holders[me] = 1
Line 110: if self._waiters:
Line 111: self._grant_next_waiter()
Line 112: 
and after this scope you release _lock as its under context. the lock should 
hold. no?
Line 113: def release(self):
Line 114: me = threading.current_thread()
Line 115: if me not in self._holders:
Line 116: raise RuntimeError("Thread %s attempted to release a lock 
it "


-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 216: self._deleteFile("volume", volPath)
: self._deleteFile("metadata", volPath + '.meta')
: if self.hasVolumeLeases():
: self._deleteFile("lease", volPath + '.lease')
Before this patch, the flow will stop after the first failure. Here it will try 
to delete the next file even if the one before failed.
Is it what we want to do ?


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: ensure LV size is multiple of VG's PE value

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 3:

I have verified this patch in Fedora, RHEL 6 and RHEL 7 platforms.

Also i tried creating brick with RAID 10, RAID 6, RAID 0 and Plain Disk 
configurations.

Note: I have tested all this with VMs only. These calculation changes will not 
vary in physical hardware.

-- 
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: fix deleteImage flow

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 215: volPath = os.path.join(toDelDir, volUUID)
Line 216: self._deleteFile("volume", volPath)
Line 217: self._deleteFile("metadata", volPath + '.meta')
Line 218: if self.hasVolumeLeases():
Line 219: self._deleteFile("lease", volPath + '.lease')
> Forget it, I missed the explanation in the commit message.
It's ok, Nir explained the reason for this in the BZ:

"We have one error handler for the 3 unlink calls, so if removing vol-uuid 
fails, we will not try to remove vol-uuid.meta and vol-uuid.lease, and
deleting the image directory will fail because rmdir works only for
empty directories."
Line 220: self.log.debug("Removing directory: %s", toDelDir)
Line 221: try:
Line 222: self.oop.os.rmdir(toDelDir)
Line 223: except OSError as e:


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: startup: Change system default encoding to utf8

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: startup: Change system default encoding to utf8
..


startup: Change system default encoding to utf8

In Python 2, the system default encoding is 'ascii'. This causes mixing
of unicode and non-ascii strings (e.g. utf8 encoded) to fail with
UnicodeDecodeError or UnicodeEncodeError. The trigger for this failures
is starting using the built-in json library, that returns all values as
unicode strings, even if the value is ascii.

For example:

>>> u'ascii' + '\xd7\x90'
Traceback (most recent call last):
  File "", line 1, in 
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd7 in position 0:
ordinal not in range(128)

Python tries to decode the second value implicitly, and fails since this
is a utf8 encoded string.

To avoid such issues, the entire application must be changed to use only
strings or only unicode internally, and never mix these types.  In the
distant future, when we run on Python 3, this will be true. For now, the
only way to prevent these issues systematically is to change the system
default encoding to 'utf8'.

Changing the default encoding is done with sys.setdefaultencoding(), but
this function exists only during startup, and can be called only from
sitecustomize module.

We keep now sitecustomize.py module, and change PYTHONPATH so it will be
loaded on startup.

This change is not needed in Python 3 since the default encoding is
already utf8, and Python does not do any implicit decoding or encoding
when mixing 'str' and 'bytes' types.

Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Bug-Url: https://bugzilla.redhat.com/1281940
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/48661
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Francesco Romani 
Reviewed-by: Piotr Kliczewski 
---
M debian/vdsm.install
M init/daemonAdapter
M tests/Makefile.am
A tests/unicode_test.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/sitecustomize.py
7 files changed, 84 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified; Passed CI tests
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: startup: Change system default encoding to utf8

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: startup: Change system default encoding to utf8
..


Patch Set 5:

I cannot say that I like it, as it is hiding deeply-entrenched bugs of Vdsm 
failing to decode its input into unicode strings.

But I suppose that solving all these bugs would take a long while.

-- 
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: p3test: add few modules that currently pass on Python 3

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: p3test: add few modules that currently pass on Python 3
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If52335524c3208c7209d3c0f9fd7bad85f250381
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: list all attached nics in caps ports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: list all attached nics in caps ports
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: caps vlan vlanid property has to be int

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: caps vlan vlanid property has to be int
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50729
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I737ae75e066ee27d5ecba0aa86118b94fd1ea62d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: ensure LV size is multiple of VG's PE value

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50854
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix size conversion issues in brick create

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix alignment issue for brick creation on JBOD

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50851
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster add mount options for gluster brick.

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster add mount options for gluster brick.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 2:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix xfs filesystem is created with wrong inode size

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix xfs filesystem is created with wrong inode size
..


Patch Set 2:

* #1293537::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1293537::OK, public bug
* Check Product::#1293537::OK, Correct classification oVirt
* Check TM::#1293537::ERROR, wrong target milestone for stable branch, --- 
should match ^.*3.6.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: create bricks without MBR partitions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 2:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: ensure LV size is multiple of VG's PE value

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: ensure LV size is multiple of VG's PE value
..


Patch Set 2:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50854
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix size conversion issues in brick create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 2:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix alignment issue for brick creation on JBOD

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 2:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50851
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5-gluster]: gluster: create bricks without MBR partitions

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm.py: Fixed typo speficy->specify

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: vm.py: Fixed typo speficy->specify
..

vm.py: Fixed typo speficy->specify

Change-Id: Icba0f7ccc2aabb83c03076ff5290518d063f9d25
Signed-off-by: Allon Mureinik 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/50855/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ae91531..4285f9b 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3067,7 +3067,7 @@
 # all snapshots as if they are type='file'.  In order to ensure
 # proper handling of block snapshots in modern libvirt versions,
 # we specify type='block' and dev=path for block volumes but we
-# always speficy the file=path for backwards compatibility.
+# always specify the file=path for backwards compatibility.
 args = {'type': sourceType, 'file': newPath}
 if sourceType == 'block':
 args['dev'] = newPath


-- 
To view, visit https://gerrit.ovirt.org/50855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icba0f7ccc2aabb83c03076ff5290518d063f9d25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm.py: Fixed typo speficy->specify

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm.py: Fixed typo speficy->specify
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icba0f7ccc2aabb83c03076ff5290518d063f9d25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm.py: Fixed typo speficy->specify

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: vm.py: Fixed typo speficy->specify
..


Patch Set 1: Verified+1

Verification: This is a fix to a comment, runtime is not affected. The read the 
comment and observe the typo is gone :-)

-- 
To view, visit https://gerrit.ovirt.org/50855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icba0f7ccc2aabb83c03076ff5290518d063f9d25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix xfs filesystem is created with wrong inode size

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix xfs filesystem is created with wrong inode size
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix alignment issue for brick creation on JBOD

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50851
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: fix size conversion issues in brick create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches