Change in vdsm[master]: net: mtu should be reported as a string through caps
Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) could you state how this was verified? https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 629: _getCompatibleCpuModels()) Line 630: Line 631: caps.update(_getVersionInfo()) Line 632: Line 633: # TODO: Version requests by engine to ease handling of compatability. please see current plans in https://gerrit.ovirt.org/#/c/50032/ Line 634: netinfo_data = netinfo.get_with_engine36_compatibility() Line 635: caps.update(netinfo_data) Line 636: Line 637: try: Line 634: netinfo_data I don't see benefit of defining this temporary variable. (note that in another place in this patchset you *drop* such a temporary variable). -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time
gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpcvdscli: improve functional network tests duration time .. jsonrpcvdscli: improve functional network tests duration time The tests were creating new jsonrpcvdscli#_Server every time before test invocation. In __init__ method we perform schema parsing which is time consuming operation. We improved duration time of the test by creating the objects only once instead of before every test method. Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/48356 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Petr Horáček Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py M tests/functional/utils.py 2 files changed, 26 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid
gerrit-hooks has posted comments on this change. Change subject: net: netconf owner change should ignore gid .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/51149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: netconf owner change should ignore gid .. net: netconf owner change should ignore gid When changing ownership of the directories/files the group id does not need to change. It affects tests which run as non-root (they fail when attempting to change the gid to root (0). Change-Id: I059a443d39122490f085d4538c9adf353e17563e Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/51148 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg (cherry picked from commit e98cc411ac055f1e76e039237db2941883bcc52c) Reviewed-on: https://gerrit.ovirt.org/51149 --- M lib/vdsm/netconfpersistence.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: netconf owner change should ignore gid
Dan Kenigsberg has posted comments on this change. Change subject: net: netconf owner change should ignore gid .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059a443d39122490f085d4538c9adf353e17563e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634: netinfo_data > I don't see benefit of defining this temporary variable. I did it to express what data is being updated. It also fits (in my mind) to the ability to choose the correct netinfo data based on the client version in the future. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 97: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): Too ugly, we don't want such apis. Lets move this into get(compatibility=306) At the end of get(): if compatibility <= 306: networking = _strinfify_muts(networking) Line 102: # REQUIRED_FOR engine < 3.7 Line 103: return _stringify_mtus(get()) Line 104: Line 105: https://gerrit.ovirt.org/#/c/51164/3/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 406: return status, msg Line 407: Line 408: def _assert_kernel_config_matches_running_config(self): Line 409: bare_kernel_config = kernelconfig.KernelConfig( Line 410: vdsm.netinfo.CachingNetInfo()) Why is this needed? Line 411: bare_running_config = self.vdsm_net.config Line 412: normalized_running_config = kernelconfig.normalize(bare_running_config) Line 413: # Unify strings to unicode instances so differences are easier to Line 414: # understand. This won't be needed once we move to Python 3. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: Verified by running all networking functional tests. They cover these points: - setupNetwork using string and integer mtu values. - Validating (per setupNetwork) that the running and kernel mtu/s are equal (and integers). - The mtu in the caps report is always a string, no matter the input. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 97: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): > Too ugly, we don't want such apis. I don't like the compatibility logic to enter into the main method logic, that should be handled one layer up. This will also be a good opportunity to replace the name "get" which does not describe what the method really does. Anyway, if dan agrees as well to the api change, I will do it and add a layer: get(compatibility=None) calling get() and adding the if. Line 102: # REQUIRED_FOR engine < 3.7 Line 103: return _stringify_mtus(get()) Line 104: Line 105: https://gerrit.ovirt.org/#/c/51164/3/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 406: return status, msg Line 407: Line 408: def _assert_kernel_config_matches_running_config(self): Line 409: bare_kernel_config = kernelconfig.KernelConfig( Line 410: vdsm.netinfo.CachingNetInfo()) > Why is this needed? This is the 'real' netinfo data, the previous was the caps data (although the naming does not hint it). The kernel config needs to be compared to the netinfo data. Line 411: bare_running_config = self.vdsm_net.config Line 412: normalized_running_config = kernelconfig.normalize(bare_running_config) Line 413: # Unify strings to unicode instances so differences are easier to Line 414: # understand. This won't be needed once we move to Python 3. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: PoC: enforcement of contract for rpc
Nir Soffer has posted comments on this change.
Change subject: PoC: enforcement of contract for rpc
..
Patch Set 2: Code-Review-1
(14 comments)
https://gerrit.ovirt.org/#/c/50032/2//COMMIT_MSG
Commit Message:
Line 7: PoC: enforcement of contract for rpc
Line 8:
Line 9: This patch demonstrates how we could obtain client version by using
Line 10: client-version stomp header for CONNECT frame. This would enable vdsm
Line 11: to modify content of response for specific version of the client.
I don't like this direction. We should not modify responses based on client
version, as this will make debugging much harder.
Line 12:
Line 13: The idea is that Bridge is responsible for enforcing contract by fixing
Line 14: requests parameters based on yaml schema by making sure that api
changes
Line 15: like additions, removals or modifications do not break backward
Line 18:
Line 19: Here we explore ideas how we could replace our current schema format
Line 20: with yaml. I picked fenceNode verb which is very complex. It uses
Line 21: custom types and there are changes in the api over time. Proposed
schema
Line 22: format do not lose any information from the previous schema.
This is a good change, remove all the custom parsing code, and use standard
format with mature tools for working with it.
Please separate converting the schema from custom json+comments format to yamal
from the "contract enforcement" feature.
Line 23:
Line 24: Please note that this patch contains all the code that is required to
Line 25: enable vdsm being our of client version and how to pass it around to
Line 26: make it useful during compatibility enforcement operations.
https://gerrit.ovirt.org/#/c/50032/2/lib/api/parser.py
File lib/api/parser.py:
Line 19: import yaml
Line 20: import os
Line 21:
Line 22:
Line 23: class SchemaParser(object):
This class does not parse anything, yamal parse the schema. This looks more
like a SchemaCache, which has one method (load), and one property (schema).
This is not a very useful class.
Also the name of the module is not correct since we don't parse anything.
Instead, we should have a schema.py module, which should provide way to load
schema from the schema file, and way to get the cached schema.
We don't want to force client to import classes from this module and created
instances, when they just want to get the cached schema, and we don't want to
provide ways to have multiple cached schema (e.g. created multiple instances of
such class).
Line 24:
Line 25: def __init__(self):
Line 26: with open(self.find_schema()) as f:
Line 27: self._schema = yaml.load(f)
Line 25: def __init__(self):
Line 26: with open(self.find_schema()) as f:
Line 27: self._schema = yaml.load(f)
Line 28:
Line 29: def find_schema(self, schema_name='vdsmapi', raiseOnError=True):
- Remove raiseOnError, we should always raise on errors.
- change the name to vdsm-api-scheme.yaml or vdsm-api.yaml. We don't have to be
compatible with bad names in current code.
- This function has nothing to do with parsing the schema, so it should not be
a method of the parser, make it a regular function in the module.
Line 30: """
Line 31: Find the API schema file whether we are running from within
the source
Line 32: dir or from an installed location
Line 33: """
Line 38: installedpath = constants.P_VDSM_RPC
Line 39: for directory in localpath, installedpath:
Line 40: path = os.path.join(directory, schema_name +
'-schema.yaml')
Line 41: if os.access(path, os.R_OK):
Line 42: return path
The os.access check is not needed, if we cannot access the schema something is
very wrong with this machine and we should die.
Line 43:
Line 44: if not raiseOnError:
Line 45: return None
Line 46:
Line 43:
Line 44: if not raiseOnError:
Line 45: return None
Line 46:
Line 47: raise Exception("Unable to find API schema file in %s or %s",
Define proper exception for this, SchemaNotFound?
Line 48: localpath, installedpath)
Line 49:
Line 50: @property
Line 51: def schema(self):
https://gerrit.ovirt.org/#/c/50032/2/lib/api/vdsmapi-schema.yaml
File lib/api/vdsmapi-schema.yaml:
Line 18: #
Line 19:
Line 20: types:
Line 21: # Specifies the type of fencing operation to perform
Line 22: FenceNodeAction: &FenceNodeAction
> This is how yaml enables references of nodes.
Is this needed so you can reference later FenceNodeAction?
Line 23: type: enum
Line 24: values: ['status', 'on', 'off', 'reboot']
Line 25:
Line 26: # A mapping of hostId indexed by domain UUID
Line 73: Host.fenceNode:
Line 74: params:
Line 75: # The IP address of the remote fence agent
Line 76: - name: addr
Line 77: type: string
Is this a
Change in vdsm[master]: net: mtu should be reported as a string through caps
Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 97: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): > I don't like the compatibility logic to enter into the main method logic, t This returns info from the netinfo module, so netinfo.get() is not that bad name. I think info() would be a better name, and also match other names (e.g. bonding.info()) But this patch is not about improving names but about restoring backward compatibility. Lets handle the name in another patch? Line 102: # REQUIRED_FOR engine < 3.7 Line 103: return _stringify_mtus(get()) Line 104: Line 105: -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 97: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): > This returns info from the netinfo module, so netinfo.get() is not that bad I agree that adding the compatibility into get() guts is unwanted, so lets do ti like this: def get(compatibility=None): if compatibility is None: return _get() else: return _stringify_mtus(_get()) Line 102: # REQUIRED_FOR engine < 3.7 Line 103: return _stringify_mtus(get()) Line 104: Line 105: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): Line 102: # REQUIRED_FOR engine < 3.7 We don't what next version will be (3.7, 4.0), so better mention version we know: engine <= 3.6 Line 103: return _stringify_mtus(get()) Line 104: Line 105: Line 106: def _stringify_mtus(netinfo_data): -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 97: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): > I agree that adding the compatibility into get() guts is unwanted, so lets Done Line 102: # REQUIRED_FOR engine < 3.7 Line 103: return _stringify_mtus(get()) Line 104: Line 105: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): Line 102: # REQUIRED_FOR engine < 3.7 > We don't what next version will be (3.7, 4.0), so better mention version we I have no opinion on this, Dan? I see no real difference. Line 103: return _stringify_mtus(get()) Line 104: Line 105: Line 106: def _stringify_mtus(netinfo_data): -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test default Job.progress implementation
Nir Soffer has uploaded a new change for review.
Change subject: tests: Test default Job.progress implementation
..
tests: Test default Job.progress implementation
Test jobs.Job.progress, and add ProgressingJob class for testing job
that report a progress.
Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Signed-off-by: Nir Soffer
---
M tests/jobsTests.py
1 file changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/51213/1
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 2420d55..7f86ba4 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -29,12 +29,7 @@
def __init__(self):
jobs.Job.__init__(self, str(uuid.uuid4()))
-self._progress = None
self._aborted = False
-
-@property
-def progress(self):
-return self._progress
def _abort(self):
self._aborted = True
@@ -46,6 +41,17 @@
class BarJob(TestingJob):
_JOB_TYPE = 'bar'
+
+
+class ProgressingJob(TestingJob):
+
+def __init__(self):
+TestingJob.__init__(self)
+self._progress = None
+
+@property
+def progress(self):
+return self._progress
@expandPermutations
@@ -174,10 +180,9 @@
jobs.delete('foo'))
def test_job_get_progress(self):
-job = TestingJob()
+job = ProgressingJob()
# Job queued or initializing, no progress yet
-self._progress = None
self.assertNotIn('progress', job.info())
# Job running
--
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test default Job.progress implementation
gerrit-hooks has posted comments on this change. Change subject: tests: Test default Job.progress implementation .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Take lock once when deleting a job
Nir Soffer has uploaded a new change for review.
Change subject: jobs: Take lock once when deleting a job
..
jobs: Take lock once when deleting a job
Previous we use get() for checking if a job exists before deleting it,
and then check again in _delete. Move all the logic to _delete, so we
take the lock once and during this flow.
With this change, test coverage for this module is 100%.
Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e
Signed-off-by: Nir Soffer
---
M lib/vdsm/jobs.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/51215/1
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 008c100..c28ac58 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -132,8 +132,6 @@
def delete(job_id):
try:
-job = get(job_id)
-job.validate_not_active()
_delete(job_id)
except ClientError as e:
logging.info('Cannot delete job, error: %s', e)
@@ -181,6 +179,9 @@
def _delete(job_id):
with _lock:
-if job_id not in _jobs:
+try:
+job = _jobs[job_id]
+except KeyError:
raise NoSuchJob("No such job %r" % job_id)
+job.validate_not_active()
del _jobs[job_id]
--
To view, visit https://gerrit.ovirt.org/51215
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Take lock once when deleting a job
gerrit-hooks has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove unused method
Nir Soffer has uploaded a new change for review.
Change subject: jobs: Remove unused method
..
jobs: Remove unused method
Nobody is calling Job.validate_done(), and I don't want to add test for
code that we don't need.
Change-Id: I9107b7eabeb70569be967df2ef1d78f996219370
Signed-off-by: Nir Soffer
---
M lib/vdsm/jobs.py
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/51214/1
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 549028a..008c100 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -112,10 +112,6 @@
logging.info('Job %r aborting...', self._id)
self._abort()
-def validate_done(self):
-if self.status != STATUS.DONE:
-raise JobNotDone("Job %r is %s" % (self.id, self.status))
-
def validate_not_active(self):
if self.status not in (STATUS.DONE, STATUS.ABORTED, STATUS.FAILED):
raise JobNotDone("Job %r is %s" % (self.id, self.status))
--
To view, visit https://gerrit.ovirt.org/51214
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9107b7eabeb70569be967df2ef1d78f996219370
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove unused method
gerrit-hooks has posted comments on this change. Change subject: jobs: Remove unused method .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9107b7eabeb70569be967df2ef1d78f996219370 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test default Job.progress implementation
Nir Soffer has posted comments on this change. Change subject: tests: Test default Job.progress implementation .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c129a53d95cd856c4a4dadaefa72bc17888ba66 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove unused method
Nir Soffer has posted comments on this change. Change subject: jobs: Remove unused method .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9107b7eabeb70569be967df2ef1d78f996219370 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Take lock once when deleting a job
Nir Soffer has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Replace validation method with a property
gerrit-hooks has posted comments on this change. Change subject: jobs: Replace validation method with a property .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23facf952529f3e811c9e179af25cfe39b2db0fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Replace validation method with a property
Nir Soffer has uploaded a new change for review.
Change subject: jobs: Replace validation method with a property
..
jobs: Replace validation method with a property
Replace Job.validate_not_active() with an Job.active property. Change
the single call site to check the property and raise.
Change-Id: I23facf952529f3e811c9e179af25cfe39b2db0fe
Signed-off-by: Nir Soffer
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
2 files changed, 18 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/51216/1
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index c28ac58..cdf1fa8 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -107,14 +107,14 @@
return ret
+@property
+def active(self):
+return self.status in (STATUS.PENDING, STATUS.RUNNING)
+
def abort(self):
self._status = STATUS.ABORTED
logging.info('Job %r aborting...', self._id)
self._abort()
-
-def validate_not_active(self):
-if self.status not in (STATUS.DONE, STATUS.ABORTED, STATUS.FAILED):
-raise JobNotDone("Job %r is %s" % (self.id, self.status))
def _abort(self):
"""
@@ -183,5 +183,6 @@
job = _jobs[job_id]
except KeyError:
raise NoSuchJob("No such job %r" % job_id)
-job.validate_not_active()
+if job.active:
+raise JobNotDone("Job %r is %s" % (job_id, job.status))
del _jobs[job_id]
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 7f86ba4..65f5c80 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -154,6 +154,18 @@
jobs.abort(job.id))
@permutations([
+[jobs.STATUS.PENDING, True],
+[jobs.STATUS.RUNNING, True],
+[jobs.STATUS.ABORTED, False],
+[jobs.STATUS.DONE, False],
+[jobs.STATUS.FAILED, False]
+])
+def test_job_active(self, status, active):
+job = TestingJob()
+job._status = status
+self.assertEqual(active, job.active)
+
+@permutations([
[jobs.STATUS.ABORTED],
[jobs.STATUS.DONE],
[jobs.STATUS.FAILED]
--
To view, visit https://gerrit.ovirt.org/51216
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23facf952529f3e811c9e179af25cfe39b2db0fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging
Nir Soffer has uploaded a new change for review.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
jobs: Add Job.__repr__ for easier debugging
Every object should have __repr__ to make it easy to have more detailed
logs, or for debugging interactively using the manhole debugging shell.
Example output:
Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f
Signed-off-by: Nir Soffer
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/51217/1
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index cdf1fa8..84e9691 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -122,6 +122,13 @@
"""
raise AbortNotSupported()
+def __repr__(self):
+s = "<{self.__class__.__name__} id={self.id} status={self.status} "
+if self.progress is not None:
+s += "progress={self.progress}% "
+s += "at 0x{id}>"
+return s.format(self=self, id=id(self))
+
# This helper should only be called by test code. Everything else should be
# using the public APIs.
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 65f5c80..c541303 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -211,3 +211,19 @@
job._error = error
self.assertEqual(job.error, error)
self.assertEqual(error.info(), job.info()['error'])
+
+def test_job_repr(self):
+job = TestingJob()
+rep = repr(job)
+self.assertIn("TestingJob", rep)
+self.assertIn("id=%s" % job.id, rep)
+self.assertIn("status=pending", rep)
+self.assertNotIn("progress=", rep)
+
+def test_job_repr_with_progress(self):
+job = ProgressingJob()
+job._status = jobs.STATUS.RUNNING
+job._progress = 32
+rep = repr(job)
+self.assertIn("status=running", rep)
+self.assertIn("progress=32%", rep)
--
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging
gerrit-hooks has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Take lock once when deleting a job
Nir Soffer has posted comments on this change. Change subject: jobs: Take lock once when deleting a job .. Patch Set 1: Continuous-Integration+1 CI failure not relevant (mount loop device failures) -- To view, visit https://gerrit.ovirt.org/51215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Replace validation method with a property
Nir Soffer has posted comments on this change. Change subject: jobs: Replace validation method with a property .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23facf952529f3e811c9e179af25cfe39b2db0fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging
Nir Soffer has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add Job.__repr__ for easier debugging
gerrit-hooks has posted comments on this change. Change subject: jobs: Add Job.__repr__ for easier debugging .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8317fde241d064ae230093610f9aaac750fcf08f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): Line 102: # REQUIRED_FOR engine < 3.7 > I have no opinion on this, Dan? Neither do I see a difference. Line 103: return _stringify_mtus(get()) Line 104: Line 105: Line 106: def _stringify_mtus(netinfo_data): https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634: netinfo_data > I did it to express what data is being updated. sorry, I don't understand the explanation. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: mtu should be reported as a string through caps
Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634: netinfo_data > sorry, I don't understand the explanation. Something like caps.update(netinfo.get()) gives no clue on what data is being 'updated' into caps. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Convert valid to read-only property
Jenkins CI RO has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 2: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Jenkins CI RO has abandoned this change. Change subject: vmdevices: move storage methods to storage module .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Jenkins CI RO has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus
Jenkins CI RO has abandoned this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/38041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus
gerrit-hooks has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/38041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Convert valid to read-only property
Jenkins CI RO has abandoned this change. Change subject: monitor: Convert valid to read-only property .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus
Jenkins CI RO has posted comments on this change. Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus .. Patch Set 3: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/38041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Convert valid to read-only property
gerrit-hooks has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
gerrit-hooks has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
