Change in vdsm[ovirt-3.6]: virt: Don't expose GuestAgent.guestInfo directly
gerrit-hooks has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 2: * #1295428::Update tracker: OK * Set MODIFIED::bug 1295428#1295428OK -- To view, visit https://gerrit.ovirt.org/52335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: Don't expose GuestAgent.guestInfo directly
Francesco Romani has submitted this change and it was merged. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. virt: Don't expose GuestAgent.guestInfo directly GuestAgent.getGuestInfo() returns its guestInfo dict attribute directly, so the callers may modify it. guestInfo is a public attribute so it shouldn't be a problem in theory as it's possible to modify that attribute anyway without calling getGuestInfo(). But guestInfo isn't used anywhere outside GuestAgent and should be probably changed to a private attribute. The problem of modifiable internal structure is exposed in Vm._getGuestStats where modifications to guestInfo cause incorrect memUsage values reported in case of repeated invocations (see the referenced bug). The safest approach to the problem is to return a deep copy of guestInfo from getGuestInfo(). However, making a deep copy can have performance issues, e.g. when copying a list of thousands installed Windows packages. For that reason we return just a shallow copy, which should suffice for typical uses. Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9 Bug-Url: https://bugzilla.redhat.com/1295428 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/51508 Reviewed-by: Francesco Romani Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/52335 Reviewed-by: Vinzenz Feenstra --- M tests/guestagentTests.py M vdsm/virt/guestagent.py 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/52335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add weakmethod helper
Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: Verified+1 v11 polishes the tests a bit more, thanks to Nir's suggestions. There are no changes to production code since v5, which added a docstring, hence copying V+1 score. I'm happy with the tests now, I think this patch is ready. -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add weakmethod helper
gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add weakmethod helper
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/51865/10/tests/utilsTests.py
File tests/utilsTests.py:
Line 1034: self.assertEquals(obj.public(), ("public", (), {}))
Line 1035: del obj
Line 1036:
Line 1037: gc.collect()
Line 1038: assert len(gc.garbage) == 1
> These asserts are fine when using py.test, but with nose we get bad output
Done
Line 1039: assert ObjectWithDel == type(gc.garbage[0])
Line 1040: gc.garbage[0].public = None # break the cycle
Line 1041: del gc.garbage[0] # we need to do explicitely to avoid
leaks
Line 1042:
Line 1037: gc.collect()
Line 1038: assert len(gc.garbage) == 1
Line 1039: assert ObjectWithDel == type(gc.garbage[0])
Line 1040: gc.garbage[0].public = None # break the cycle
Line 1041: del gc.garbage[0] # we need to do explicitely to avoid
leaks
> We can get rid of garbage from the test in the context manager:
Done
Line 1042:
Line 1043: # not needed by the test, but we don't want to pollute
Line 1044: # the global environment.
Line 1045: self.assertNoGarbage()
Line 1041: del gc.garbage[0] # we need to do explicitely to avoid
leaks
Line 1042:
Line 1043: # not needed by the test, but we don't want to pollute
Line 1044: # the global environment.
Line 1045: self.assertNoGarbage()
> This is not needed now if you handle garbage from the test in the context m
Done
Line 1046:
Line 1047: def test_without_reference_cycle(self):
Line 1048:
Line 1049: with _debug_gc():
Line 1065: def assertNoGarbage(self):
Line 1066: gc.collect()
Line 1067: # only to help troubleshooting should the assert fail
Line 1068: print(gc.garbage)
Line 1069: assert not gc.garbage
> If you use assertEqual(gc.garbage, []) we don't need the print
Done
Line 1070:
Line 1071:
Line 1072: class NoIntrPollTests(TestCaseBase):
Line 1073: RETRIES = 3
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: use weakmethod to break reference cycles
gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 14: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::#1269424::OK, public bug * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: Don't expose GuestAgent.guestInfo directly
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr
Dan Kenigsberg has posted comments on this change. Change subject: net: vdsClient fails to connect to an IPv6 addr .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcb3863a720f414d3048299fd54ef74839bdb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4
Dan Kenigsberg has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/52366/1/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 34: this is a very awkward exception that we are raising here; but why removing it is related to this patch? -- To view, visit https://gerrit.ovirt.org/52366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Use VLAN ID as integer across VDSM
Dan Kenigsberg has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/51802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3a0133560a6946c3438161fb1696f002f2cdb21 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 3: * #1271575::Update tracker: OK * Set MODIFIED::bug 1271575#1271575OK -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
Yaniv Bronhaim has submitted this change and it was merged. Change subject: supervdsm: failed validateAccess leaves pipes open .. supervdsm: failed validateAccess leaves pipes open Whenever we run validateAccess and it fails with "Permission denied" we leak file descriptors. We need to make sure to close child and parent pipes. Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Signed-off-by: pkliczewski Bug-Url: https://bugzilla.redhat.com/1271575 Reviewed-on: https://gerrit.ovirt.org/52365 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Continuous-Integration: Yaniv Bronhaim --- M vdsm/supervdsmServer 1 file changed, 27 insertions(+), 24 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 2: -Verified * #1271575::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1271575::OK, public bug * Check Product::#1271575::OK, Correct classification oVirt * Check TM::#1271575::OK, correct target milestone ovirt-3.6.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3 test improving
Yaniv Bronhaim has posted comments on this change. Change subject: py3 test improving .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c50e064059fa8ce0b4b38e6a12f6b9235581b49 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Nosikovsky Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: use the `terminating' decorator
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: use the `terminating' decorator
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52349/2/vdsm_hooks/checkimages/before_vm_start.py
File vdsm_hooks/checkimages/before_vm_start.py:
Line 81: p = hooking.execCmd(cmd, raw=True, sync=False)
Line 82:
Line 83: with terminating(p):
Line 84: if p.wait(timeout) is None:
Line 85: p.kill()
you can avoid calling kill. after exit terminating will kill p
Line 86: sys.stderr.write(
Line 87: 'checkimages: %s image check operation timed out.' %
path)
Line 88: sys.stderr.write('Increate timeout or check image
availability.')
Line 89: sys.exit(2)
--
To view, visit https://gerrit.ovirt.org/52349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica692d8b330b71e1fed6fb9df1546ce3a37ade7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/51407/12/lib/vdsm/commands.py File lib/vdsm/commands.py: Line 282: self._returncode = self._proc.poll() Line 283: return self._returncode Line 284: Line 285: def poll(self): Line 286: return self._returncode > We must return self.returncode so returncode() will run and query self._pro oh, missed that I reached _! good catch! Line 287: Line 288: def kill(self): Line 289: try: Line 290: self._proc.kill() -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: terminating tests - verify process death
Yaniv Bronhaim has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/52362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: terminating tests - verify process death
gerrit-hooks has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: health: Introduce Vdsm health monitoring
Nir Soffer has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 6: Piotr, what do you mean about common tool to collect them? My intention is similar to the cpu profiler - when you have an issue in the field/qe/scale, you can flip an option and get useful information for debugging. For developers, having the health info in the log give useful context. This is the simplest solution and easy to backport. We may improve this later for master if needed. -- To view, visit https://gerrit.ovirt.org/51708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2abbd753118cb212a298055138087ca2e48ede91 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: health: Introduce Vdsm health monitoring
Nir Soffer has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/51708/6/lib/vdsm/health.py
File lib/vdsm/health.py:
Line 50: log = logging.getLogger("health")
Line 51:
Line 52: def __init__(self, interval):
Line 53: self._interval = interval
Line 54: self._thread = concurrent.thread(self._run)
> it might be a bit more straight forward, but maybe we should use "periodic"
This should be separate from periodic
- it should monitor periodic, e.g. number of scheduled timeouts, executors
status, discarded executors
- periodic can be blocked by libvirt calls
- we may like to reuse same module in supervdsm
- periodic is too complex
- it should be able to detect scheduling delays in vdsm, e.g. the delays that
cause hearbeats get dropped. In periodic these delays may be hidden by blocking
libvirt calls
- seperating debugging and real code, separate thread is the best separation we
can have inside vdsm
Line 55: self._done = threading.Event()
Line 56:
Line 57: def start(self):
Line 58: self.log.info("Starting health monitor (interval=%d)",
self._interval)
Line 93: self.log.warning("Found %d uncollectable objects: %s",
Line 94: len(uncollectable), uncollectable)
Line 95:
Line 96:
Line 97: def saferepr(obj):
> could you give a hint why this wrapper is needed?
See the comment in line 90, I'll move it here.
Line 98: try:
Line 99: return repr(obj)
Line 100: except Exception as e:
Line 101: simple_repr = "<%s at 0x%x>" % (type(obj), id(obj))
--
To view, visit https://gerrit.ovirt.org/51708
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2abbd753118cb212a298055138087ca2e48ede91
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: use weakmethod to break reference cycles
Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 13: Code-Review+2 Requires the previous patch. -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add weakmethod helper
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/51865/10/tests/utilsTests.py
File tests/utilsTests.py:
Line 1034: self.assertEquals(obj.public(), ("public", (), {}))
Line 1035: del obj
Line 1036:
Line 1037: gc.collect()
Line 1038: assert len(gc.garbage) == 1
These asserts are fine when using py.test, but with nose we get bad output when
if it fails. We should use unitest asserts until we move to py.test.
Line 1039: assert ObjectWithDel == type(gc.garbage[0])
Line 1040: gc.garbage[0].public = None # break the cycle
Line 1041: del gc.garbage[0] # we need to do explicitely to avoid
leaks
Line 1042:
Line 1037: gc.collect()
Line 1038: assert len(gc.garbage) == 1
Line 1039: assert ObjectWithDel == type(gc.garbage[0])
Line 1040: gc.garbage[0].public = None # break the cycle
Line 1041: del gc.garbage[0] # we need to do explicitely to avoid
leaks
We can get rid of garbage from the test in the context manager:
finally:
del gc.garbage[:]
gc.garbage.extend(saved_garbage)
...
This is safer, we don't have to cleanup in the test.
Line 1042:
Line 1043: # not needed by the test, but we don't want to pollute
Line 1044: # the global environment.
Line 1045: self.assertNoGarbage()
Line 1041: del gc.garbage[0] # we need to do explicitely to avoid
leaks
Line 1042:
Line 1043: # not needed by the test, but we don't want to pollute
Line 1044: # the global environment.
Line 1045: self.assertNoGarbage()
This is not needed now if you handle garbage from the test in the context
manager.
Line 1046:
Line 1047: def test_without_reference_cycle(self):
Line 1048:
Line 1049: with _debug_gc():
Line 1065: def assertNoGarbage(self):
Line 1066: gc.collect()
Line 1067: # only to help troubleshooting should the assert fail
Line 1068: print(gc.garbage)
Line 1069: assert not gc.garbage
If you use assertEqual(gc.garbage, []) we don't need the print
Line 1070:
Line 1071:
Line 1072: class NoIntrPollTests(TestCaseBase):
Line 1073: RETRIES = 3
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add weakmethod helper
Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/51865/9/tests/utilsTests.py File tests/utilsTests.py: Line 1037: gc.collect() Line 1038: assert len(gc.garbage) == 1 Line 1039: assert ObjectWithDel == type(gc.garbage[0]) Line 1040: gc.garbage[0].public = None # break the cycle Line 1041: del gc.garbage[0] # we need to do explicitely to avoid leaks > It seems we need a stronger push, such as using del explicitely. Otherwise: Move assertNoGarbage out of the with _debug_gc() context, and you will not find any garbage. Line 1042: Line 1043: # not needed by the test, but we don't want to pollute Line 1044: # the global environment. Line 1045: self.assertNoGarbage() -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
Edward Haas has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51762/3/tests/commands_tests.py File tests/commands_tests.py: > We keep tests in their own directory, so we don't have this issue. But even I understand your point, I just do not share your pains & gains on this naming. For example, I mostly use the IDE 'search callers' on a method, filtering out all who start with test* is easier for me. So it is a matter of taste, there is no -fit to all- option here. Line 1: # Line 2: # Copyright 2012-2016 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/51407/12/lib/vdsm/commands.py File lib/vdsm/commands.py: Line 282: self._returncode = self._proc.poll() Line 283: return self._returncode Line 284: Line 285: def poll(self): Line 286: return self._returncode We must return self.returncode so returncode() will run and query self._proc.poll(). This code will just return None without checking the child process status. Line 287: Line 288: def kill(self): Line 289: try: Line 290: self._proc.kill() -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: terminating tests - verify process death
Nir Soffer has posted comments on this change.
Change subject: terminating tests - verify process death
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52362/1/tests/utilsTests.py
File tests/utilsTests.py:
Line 78:
Line 79: class TerminatingTests(TestCaseBase):
Line 80: def testTerminating(self):
Line 81: proc = commands.execCmd([EXT_SLEEP, "5"], sync=False)
Line 82: pids = utils.pgrep(EXT_SLEEP)
Lets check /proc/pid instead of using pgrep.
Line 83: # verify process is up and running
Line 84: self.assertTrue(proc.pid in pids)
Line 85: with utils.terminating(proc):
Line 86: # do whatever with proc
Line 86: # do whatever with proc
Line 87: pass
Line 88: # here process should not exist
Line 89: pids = utils.pgrep(EXT_SLEEP)
Line 90: self.assertFalse(proc.pid in pids)
We can do:
self.assertFalse(os.path.exists("/proc/pid"))
Line 91:
Line 92:
Line 93: class RetryTests(TestCaseBase):
Line 94: def testStopCallback(self):
--
To view, visit https://gerrit.ovirt.org/52362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 23: (4 comments) https://gerrit.ovirt.org/#/c/42908/23//COMMIT_MSG Commit Message: Line 23: supporting timed acquire. Line 24: Line 25: This implementation has less overhead, as seen in the fairness tests Line 26: with many writers and readers (tested on Lenovo T430s). Line 27: > You could mention that larger numbers mean more throughput. Will add that. Line 28: storage.misc.RWLock Line 29: --- Line 30: Line 31: writers: 1 readers: 2 Line 60: reads avg=323.72 med=324 min=323 max=325 Line 61: Line 62: writers: 4 readers: 128 Line 63: writes avg=82.00 med=82 min=82 max=82 Line 64: reads avg=83.23 med=83 min=82 max=89 > I think the read throughput could be dramatically increased without degradi I agree, but this would complicate the code, and we don't have such performance issue. Our operations are very slow (running subprocess, or sending request to another process and waiting for response), so the cost of waiting for the lock (couple of milliseconds) is insignificant. My goal is not to make this more efficient, but have simpler code that is easier to understand and maintain. Line 65: Line 66: To run this test, use: Line 67: Line 68: ./run_tests_local.sh --enable-stress-tests rwlock_test.py:RWLockStressTests https://gerrit.ovirt.org/#/c/42908/23/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line 1: # Line 2: # Copyright 2015 Red Hat, Inc. > 2016 Will update Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 61: with lock.shared: Line 62: do stuff that require a shared lock.. Line 63: Line 64: When a thread is holding a read lock, other threads requesting a read lock Line 65: can acquire the lock. Other threads requesting a write lock will be blocked > When a reader is granted the lock, do we want to search the waiters for oth Yes, we can wake all the readers up to the first writer together. They will wake up and take the lock in random order. So this will effect fairness, and will not improve throughput. To improve throughput we want to take the lock, wakeup all all the readers up to the first writer, and release the lock. Do you see a simple way to do this? Line 66: until all the readers release their lock. Line 67: Line 68: If a reader try to acquire a read lock while other threads are waiting Line 69: (e.g. a writer), the reader is blocked until the waiting writer will get -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr
Edward Haas has posted comments on this change. Change subject: net: vdsClient fails to connect to an IPv6 addr .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/52367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcb3863a720f414d3048299fd54ef74839bdb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4
Edward Haas has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/52366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Introduction to imagetickets.py
Nir Soffer has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/50014/10/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 8421: # @timeout: Timeout in seconds for the ticket to expire Line 8422: # Line 8423: # @ops: operations list to be applied on the image Line 8424: # Line 8425: # @size: block size of each transferred chunk > Current daemon code assume that offset is always 0, and validate size with We agreed on keeping size, but the value must be the size of the image. Attempt to read or write must be withing the range 0 - (size - 1) For example, writing 1000 bytes will write byte 0 to byte 999. Line 8426: # Line 8427: # @path: an image path Line 8428: # Line 8429: # Since: 4.18.0 -- To view, visit https://gerrit.ovirt.org/50014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
Nir Soffer has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/35181/7/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 557: ) Line 558: ) Line 559: Line 560: Line 561: def SimpleClient(host, port=54321, ssl=True): > Nice! Lets separate this change, looks nice addition regardless of the client. Line 562: """ Line 563: Returns JsonRpcClient able to receive jsonrpc messages and notifications. Line 564: It is required to provide a host where we want to connect, port and whether Line 565: we want to use ssl (True by default). Other settings use defaults and if -- To view, visit https://gerrit.ovirt.org/35181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
Nir Soffer has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 7: Code-Review-1
(7 comments)
Comparing with the version 5, the jsonrpc changes looks nice and simple, but
everything else is worse (error handling, usability)
https://gerrit.ovirt.org/#/c/35181/7/contrib/jsonrpc
File contrib/jsonrpc:
Line 25: methods and parameters. The user should consult the schema to
construct request
Line 26: that make sense. Future version should parse the schema and provide
online
Line 27: help.
Line 28:
Line 29: Invoking simple methods:
The :: suffix is intentional, this is rst format for a code block, please keep
it.
Line 30:
Line 31: # jsonrpc Host.getVMList
Line 32: ['b3f6fa00-b315-4ad4-8108-f73da817b5c5']
Line 33:
Line 32: ['b3f6fa00-b315-4ad4-8108-f73da817b5c5']
Line 33:
Line 34: Invoking methods with simple parameters::
Line 35:
Line 36: # jsonrpc VM.getStats -p vmID=b3f6fa00-b315-4ad4-8108-f73da817b5c5
Why do we need the -p option? the previous format looks better.
If this is needed by argparse, then don't use argparse :-). We need simple way
to send simple parameter lists, and the previous key1=value1 key2=value2 is
easier to use then the new api.
Line 37: ...
Line 38:
Line 39: For invokinng methods with many or complex parameters, you can read the
Line 40: parameters from a file:
Line 38:
Line 39: For invokinng methods with many or complex parameters, you can read the
Line 40: parameters from a file:
Line 41:
Line 42: # jsonrpc VM.create -f vm-create
We like to send json files, not some non-standard key=value format.
Line 43: ...
Line 44:
Line 45: It is also possible to read parameters from standard input, creating
complex
Line 46: parameters interactively:
Line 46: parameters interactively:
Line 47:
Line 48: # jsonrpc StorageDomain.activate -f -
Line 49: storagedomainID=75ab40e3-06b1-4a54-a825-2df7a40b93b2,
Line 50: storagepoolID=b3f6fa00-b315-4ad4-8108-f73da817b5c5
The previous format was better. Using simple arguments we cannot express json
tree needed for some verbs. Please keep the original api.
Line 51: (Press Ctrl + D to finish)
Line 52:
Line 53: """
Line 54:
Line 100: pretty_print(resp.result)
Line 101: finally:
Line 102: client.close()
Line 103: except Exception as e:
Line 104: fail("Connection failed: %s" % e)
The jsonrpc changes are good, but the original error handling was much better,
you treat everying as connection failed, very incorrect. Please keep the
original error handling.
Line 105:
Line 106:
Line 107: def option_parser():
Line 108: parser = argparse.ArgumentParser()
Line 109: parser.add_argument('-a', '--host', dest="host",
default="localhost",
Line 110: help='host address (default localhost)')
Line 111: parser.add_argument('method', help='remote method name')
Line 112: group = parser.add_mutually_exclusive_group()
Line 113: group.add_argument('-p', '--params', help='params [param=value
...]')
We don't wan to use -p, using the params as key=value pairs on the command line
is nicer.
Line 114: group.add_argument('-f', '--file', dest='file',
Line 115:help="read method parameters from json file.
Set to"
Line 116: " '-' to read from standard input")
Line 117: return parser
Line 153: representation = pprint.pformat(resp[element]).replace(
Line 154: '\n', '\n\t' + ' ' * len(element + ' = ') + '\t')
Line 155: print('\t' + '\t%s = %s' % (element, representation))
Line 156: else:
Line 157: pprint.pprint(resp)
The previous way to pretify things was better - json format is much better then
pprint, we don't see the ugly u'key': u'value' everywhere.
Also returning valid json means I can feed the tool output to another tool that
parse the json and do something useful with the data.
Please keep the concept of accepting and returning json format.
Line 158:
Line 159:
Line 160: def fail(msg):
Line 161: sys.stderr.write("%s: %s\n" % (os.path.basename(sys.argv[0]),
msg))
--
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
__
Change in vdsm[master]: storage: Introduction to imagetickets.py
Greg Padgett has posted comments on this change.
Change subject: storage: Introduction to imagetickets.py
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/50014/10/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 8423: # @ops: operations list to be applied on the image
Line 8424: #
Line 8425: # @size: block size of each transferred chunk
Line 8426: #
Line 8427: # @path: an image path
> There is no point in adding public api that we know is not going to work fo
Using a URL in all cases (incl. "file://") is a nice, extensible way to specify
the image, plus gets us out of maintaining an extra "type" option. +1 for that,
and if it's always a url, it's more intuitive to name it that.
(Previously I'd have vouched for uri, but it seems the modern definition of url
covers our use case here so I think it's good.)
Line 8428: #
Line 8429: # Since: 4.18.0
Line 8430: ##
Line 8431: {'type': 'ImageTicket',
--
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Greg Padgett
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
Nir Soffer has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/35181/7/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 557: ) Line 558: ) Line 559: Line 560: Line 561: def SimpleClient(host, port=54321, ssl=True): Nice! Line 562: """ Line 563: Returns JsonRpcClient able to receive jsonrpc messages and notifications. Line 564: It is required to provide a host where we want to connect, port and whether Line 565: we want to use ssl (True by default). Other settings use defaults and if -- To view, visit https://gerrit.ovirt.org/35181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Simple jsonrpc client
Nir Soffer has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/35181/7/contrib/jsonrpc
File contrib/jsonrpc:
Line 151: keys.sort()
Line 152: for element in keys:
Line 153: representation = pprint.pformat(resp[element]).replace(
Line 154: '\n', '\n\t' + ' ' * len(element + ' = ') + '\t')
Line 155: print('\t' + '\t%s = %s' % (element, representation))
Why do we need this? pprint.pprint knows how to format dicts nicely
Line 156: else:
Line 157: pprint.pprint(resp)
Line 158:
Line 159:
--
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
Nir Soffer has submitted this change and it was merged. Change subject: split to commands_test.py - only execCmd tests .. split to commands_test.py - only execCmd tests Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/51762 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Tested-by: Nir Soffer --- M tests/Makefile.am A tests/commands_test.py M tests/utilsTests.py 3 files changed, 185 insertions(+), 155 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
gerrit-hooks has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
Nir Soffer has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 6: Tests pass also locally. -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
Nir Soffer has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 6: Code-Review+2 Verified+1 Jenkins is happy, must be verified. -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
Nir Soffer has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51762/3/tests/commands_tests.py File tests/commands_tests.py: > I like the test_* format, just because it's easier to differentiate between We keep tests in their own directory, so we don't have this issue. But even when you mix code and tests, using *_test.py format makes the code and the tests sort in the same place, making it easier to work with. For example, you can open both the foo.py and foo_test.py by using "vim foo*.py", very useful, instead of writing "vim foo.py test_foo.py". When all tests tests are in the same directory, it make working from the command line much faster, since you don't have to type test_ prefix for any file. Also inspecting the tests visually is easier since you don't have to skip the test_ prefix in all files. And finally, we already use the *Tests.py convention. The change I'm suggesting is making this easier to use by using lowercase, and using the default py.test configuration so we don't have to waste our time on changing it, and making it easier for people to get into the project, using standard naming conventions. Line 1: # Line 2: # Copyright 2012-2016 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: use cpuarch module
Nir Soffer has posted comments on this change. Change subject: nettestlib: use cpuarch module .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacb382c2abcbc4e1e7a3d9423b1814b64409ed8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Fix ResourceRef leak
Nir Soffer has posted comments on this change. Change subject: resourceManager: Fix ResourceRef leak .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51917/3/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 297: continue Line 298: Line 299: weakmethod = partial(ResourceRef.__methodProxy, Line 300: weakref.proxy(self), attr) Line 301: setattr(self, attr, weakmethod) > looks good. For my understanding, you can't use our new utils.weakmethod() Right, that was my first attempt, doing one line patch with the new shiny weakmethod, but it does not work with partial, which is not a method. Line 302: Line 303: def __methodProxy(self, attr, *args, **kwargs): Line 304: with self._syncRoot.shared: Line 305: if not self.isValid: -- To view, visit https://gerrit.ovirt.org/51917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890616ba53ee70688ee00ea337ebc566d63f861d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
Jenkins CI has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 6: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 5 -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virtsparsify: remove useless deathSignal
Yaniv Bronhaim has posted comments on this change. Change subject: virtsparsify: remove useless deathSignal .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14f46e1e12708382280021b41d4913b6c2d6b7ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: exception: Gather exceptions in vdsm.exception
gerrit-hooks has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I076a7a381003053e7655ef5bece17c00ce9a92ca Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: exception: Make VdsmException reusable
gerrit-hooks has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_test.py - only execCmd tests
gerrit-hooks has posted comments on this change. Change subject: split to commands_test.py - only execCmd tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_tests.py - only execCmd tests
gerrit-hooks has posted comments on this change. Change subject: split to commands_tests.py - only execCmd tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: exception: Inherit from VdsmException
gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ffdd531fc9878a6762e2c0f670134b3aedf9a0 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: exception: Inherit from VdsmException
Dan Kenigsberg has submitted this change and it was merged. Change subject: exception: Inherit from VdsmException .. exception: Inherit from VdsmException All exceptions used by vdsm API inherit now from VdsmException, removing duplicate code for generating response. The info() method added recently to GeneralException was moved up to VdsmException. Use new info to simplify GlusterException base class. Change-Id: I25ffdd531fc9878a6762e2c0f670134b3aedf9a0 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/48869 Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- M lib/vdsm/exception.py M tests/exception_test.py M tests/gluster_exception_test.py M vdsm/gluster/exception.py 4 files changed, 26 insertions(+), 19 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ffdd531fc9878a6762e2c0f670134b3aedf9a0 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add gluster exception tests
gerrit-hooks has posted comments on this change. Change subject: gluster: Add gluster exception tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/51565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45c62ea48dfae744ef580deec0cfbb77b6fec6a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: exception: Make VdsmException reusable
Dan Kenigsberg has submitted this change and it was merged. Change subject: exception: Make VdsmException reusable .. exception: Make VdsmException reusable VdsmException was initializing code and message to default values if called without arguments. This make is useless as as base class for more specific exceptions, defining real code and message. GlusterException, the only exception inheriting from VdsmException, avoided this issue by overriding __init__. Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/48875 Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- M lib/vdsm/exception.py M tests/Makefile.am A tests/exception_test.py 3 files changed, 61 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: exception: Gather exceptions in vdsm.exception
Dan Kenigsberg has submitted this change and it was merged. Change subject: exception: Gather exceptions in vdsm.exception .. exception: Gather exceptions in vdsm.exception Move GeneralException and ActionStopped from vdsm.utils to vdsm.exception. The long term goal is to have one exception module similar to storage_exception, simplifying error handling and improving the information returned to clients on errors. Change-Id: I076a7a381003053e7655ef5bece17c00ce9a92ca Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/48868 Reviewed-by: Yaniv Bronhaim Reviewed-by: Piotr Kliczewski Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M lib/vdsm/commands.py M lib/vdsm/exception.py M lib/vdsm/qemuimg.py M lib/vdsm/utils.py M tests/jobsTests.py M tests/main.py M tests/miscTests.py M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/image.py M vdsm/storage/storage_exception.py 12 files changed, 51 insertions(+), 47 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I076a7a381003053e7655ef5bece17c00ce9a92ca Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add gluster exception tests
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Add gluster exception tests .. gluster: Add gluster exception tests GlusterException inherits from VdsmException, which we are going to change in the next patch. Add the missing tests to make sure we don't break it. Change-Id: Id45c62ea48dfae744ef580deec0cfbb77b6fec6a Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/51565 Reviewed-by: Sahina Bose Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- M tests/Makefile.am A tests/gluster_exception_test.py 2 files changed, 75 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id45c62ea48dfae744ef580deec0cfbb77b6fec6a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters
Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 2: again bogus failures: 00:08:07.950 == 00:08:07.950 ERROR: testGetBondingOptions (netinfoTests.TestNetinfo) 00:08:07.950 -- 00:08:07.950 Traceback (most recent call last): 00:08:07.950 File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/monkeypatch.py", line 133, in wrapper 00:08:07.950 return f(*args, **kw) 00:08:07.950 File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/testValidation.py", line 100, in wrapper 00:08:07.950 return f(*args, **kwargs) 00:08:07.950 File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/netinfoTests.py", line 374, in testGetBondingOptions 00:08:07.950 with open(BONDING_MASTERS, 'w') as bonds: 00:08:07.950 IOError: [Errno 13] Permission denied: '/sys/class/net/bonding_masters' 00:08:07.950 00:08:07.950 -- -- To view, visit https://gerrit.ovirt.org/52342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I063d74c1fe1725c514f7aeb60463d0558e240baa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore
Francesco Romani has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 2: Verified+1 verified on branch hibernating/restoring few times a VM while $ watch -n 1 vdsClient -s 0 list with no issues -- To view, visit https://gerrit.ovirt.org/52343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46be9c779589b8c27395ced7904efb7de8cacc7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4
gerrit-hooks has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr
gerrit-hooks has posted comments on this change. Change subject: net: vdsClient fails to connect to an IPv6 addr .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I069dcb3863a720f414d3048299fd54ef74839bdb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr
Edward Haas has uploaded a new change for review.
Change subject: net: vdsClient fails to connect to an IPv6 addr
..
net: vdsClient fails to connect to an IPv6 addr
When vdsClient is used on a non-ipv6 host, and no destination address
is provided, it will fail to connect to the server.
(it uses the vdsm.conf management_ip parameter which is by default '::')
The vdsClient now prompts when it detects/suspects this is the problem.
(instead of a traceback)
Change-Id: I069dcb3863a720f414d3048299fd54ef74839bdb
Signed-off-by: Edward Haas
---
M client/vdsClient.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/52367/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 9f17344..94c9723 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -18,6 +18,7 @@
#
from __future__ import print_function
+import errno
import sys
import ast
import getopt
@@ -3005,6 +3006,12 @@
except socket.error as e:
if e[0] == 111:
print("Connection to %s refused" % hostPort)
+elif e.errno == errno.EAFNOSUPPORT:
+print("Connection to host %s is not supported, "
+ "probably trying to connect to an IPv6 address "
+ "while IPv6 is disabled.\n"
+ "Either specify a proper address or "
+ "update vdsm.conf management_ip parameter" % hostPort)
else:
traceback.print_exc()
sys.exit(-1)
--
To view, visit https://gerrit.ovirt.org/52367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I069dcb3863a720f414d3048299fd54ef74839bdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4
Edward Haas has uploaded a new change for review.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
net: When IPv6 is not enabled, fallback to IPv4
There are setups where IPv6 is disabled, causing a conflict with the
default configuration (which is set to listen on address '::').
In such a case, VDSM fails to listen on '::'.
In order to support IPv4 only setups without requiring a change in the
configuration, VDSM will fallback to listen on an IPv4 only address.
Note that '::' is used to listen on both IPv4 & IPv6 stacks, a fallback to
IPv4 seems reasonable.
Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9
Signed-off-by: Edward Haas
---
M vdsm/clientIF.py
M vdsm/protocoldetector.py
2 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/52366/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 8faf5bc..0d1e235 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -18,6 +18,7 @@
# Refer to the README and COPYING files for full details of the license
#
+import errno
import os
import os.path
import socket
@@ -116,7 +117,16 @@
host = config.get('addresses', 'management_ip')
port = config.getint('addresses', 'management_port')
-self._createAcceptor(host, port)
+# When IPv6 is not enabled, fallback to listen on IPv4 address
+try:
+self._createAcceptor(host, port)
+except socket.error as e:
+if e.errno == errno.EAFNOSUPPORT and host in ('::', '::1'):
+fallback_host = '0.0.0.0'
+self._createAcceptor(fallback_host, port)
+else:
+raise
+
self._prepareXMLRPCBinding()
self._prepareJSONRPCBinding()
self._connectToBroker()
diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py
index a4aabae..882d671 100644
--- a/vdsm/protocoldetector.py
+++ b/vdsm/protocoldetector.py
@@ -30,10 +30,6 @@
def _create_socket(host, port):
addrinfo = socket.getaddrinfo(host, port,
socket.AF_UNSPEC, socket.SOCK_STREAM)
-if not addrinfo:
-raise socket.error("Could not translate address '%s:%s'"
- % (host, str(port)))
-
family, socktype, proto, _, sockaddr = addrinfo[0]
server_socket = socket.socket(family, socktype, proto)
filecontrol.set_close_on_exec(server_socket.fileno())
--
To view, visit https://gerrit.ovirt.org/52366
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
Piotr Kliczewski has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: Verified+1 Verified on prod env using master branch. -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hooks: ovs: fix bonded network change problem
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: fix bonded network change problem
..
Patch Set 2: Verified+1
Manually tested: when we add a bonded network and then edit it, it is ok.
>>> from vdsm import vdscli
>>> c = vdscli.connect()
>>> c.setupNetworks({'test-network1': {'custom': {'ovs': True}, 'bonding':
'bond11'}}, {'bond11': {'options': 'custom=ovs=True', 'nics': ['dummy_1',
'dummy_2']}}, {'connectivityCheck': False})
{'status': {'message': 'Done', 'code': 0}}
>>> c.setupNetworks({'test-network1': {'custom': {'ovs': True}, 'bonding':
'bond11'}}, {'bond11': {'options': 'custom=ovs=True', 'nics': ['dummy_1',
'dummy_2']}}, {'connectivityCheck': False})
{'status': {'message': 'Done', 'code': 0}}
--
To view, visit https://gerrit.ovirt.org/52346
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
Piotr Kliczewski has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/52365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: supervdsm: failed validateAccess leaves pipes open
Piotr Kliczewski has uploaded a new change for review.
Change subject: supervdsm: failed validateAccess leaves pipes open
..
supervdsm: failed validateAccess leaves pipes open
Whenever we run validateAccess and it fails with "Permission denied" we
leak file descriptors. We need to make sure to close child and parent
pipes.
Change-Id: I6356837686c274389e92e828143cce3a5eeff564
Signed-off-by: pkliczewski
Bug-url: https://bugzilla.redhat.com/1271575
---
M vdsm/supervdsmServer
1 file changed, 27 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/52365/1
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 247b599c..bc7836d 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -31,6 +31,8 @@
import signal
import logging
import logging.config
+
+from contextlib import closing
from vdsm.infra import sigutils
from vdsm.infra import zombiereaper
@@ -264,37 +266,38 @@
pipe.recv()
pipe, hisPipe = Pipe()
-proc = Process(target=child, args=(hisPipe,))
-proc.start()
+with closing(pipe), closing(hisPipe):
+proc = Process(target=child, args=(hisPipe,))
+proc.start()
-needReaping = True
-try:
-if not safe_poll(pipe, RUN_AS_TIMEOUT):
-try:
+needReaping = True
+try:
+if not safe_poll(pipe, RUN_AS_TIMEOUT):
+try:
-os.kill(proc.pid, signal.SIGKILL)
-except OSError as e:
-# Don't add to zombiereaper of PID no longer exists
-if e.errno == errno.ESRCH:
-needReaping = False
-else:
-raise
+os.kill(proc.pid, signal.SIGKILL)
+except OSError as e:
+# Don't add to zombiereaper of PID no longer exists
+if e.errno == errno.ESRCH:
+needReaping = False
+else:
+raise
-raise Timeout()
+raise Timeout()
-res, err = pipe.recv()
-pipe.send("Bye")
-proc.terminate()
+res, err = pipe.recv()
+pipe.send("Bye")
+proc.terminate()
-if err is not None:
-raise err
+if err is not None:
+raise err
-return res
+return res
-finally:
-# Add to zombiereaper if process has not been waited upon
-if proc.exitcode is None and needReaping:
-zombiereaper.autoReapPID(proc.pid)
+finally:
+# Add to zombiereaper if process has not been waited upon
+if proc.exitcode is None and needReaping:
+zombiereaper.autoReapPID(proc.pid)
@logDecorator
def validateAccess(self, user, groups, *args, **kwargs):
--
To view, visit https://gerrit.ovirt.org/52365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: py3 test improving
gerrit-hooks has posted comments on this change. Change subject: py3 test improving .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c50e064059fa8ce0b4b38e6a12f6b9235581b49 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Nosikovsky Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Replace misc.RWLock
Adam Litke has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 19: Simple enough code-wise. We'll want to make sure this gets a thorough test cycle in case we have any bugs in our new impl. -- To view, visit https://gerrit.ovirt.org/43423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 1: I think that https://gerrit.ovirt.org/51698 has caused what you are seeing. But I do not understand you fix. -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
Adam Litke has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 23: This patch is safe since it doesn't actually change behavior of current code. It's just adding a new implementation. -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
Adam Litke has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 23: (4 comments) https://gerrit.ovirt.org/#/c/42908/23//COMMIT_MSG Commit Message: Line 23: supporting timed acquire. Line 24: Line 25: This implementation has less overhead, as seen in the fairness tests Line 26: with many writers and readers (tested on Lenovo T430s). Line 27: You could mention that larger numbers mean more throughput. Line 28: storage.misc.RWLock Line 29: --- Line 30: Line 31: writers: 1 readers: 2 Line 60: reads avg=323.72 med=324 min=323 max=325 Line 61: Line 62: writers: 4 readers: 128 Line 63: writes avg=82.00 med=82 min=82 max=82 Line 64: reads avg=83.23 med=83 min=82 max=89 I think the read throughput could be dramatically increased without degrading the write throughput much if you searched the waiters for multiple readers to grant at the same time. Line 65: Line 66: To run this test, use: Line 67: Line 68: ./run_tests_local.sh --enable-stress-tests rwlock_test.py:RWLockStressTests https://gerrit.ovirt.org/#/c/42908/23/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line 1: # Line 2: # Copyright 2015 Red Hat, Inc. 2016 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 61: with lock.shared: Line 62: do stuff that require a shared lock.. Line 63: Line 64: When a thread is holding a read lock, other threads requesting a read lock Line 65: can acquire the lock. Other threads requesting a write lock will be blocked When a reader is granted the lock, do we want to search the waiters for other readers in order to grant them similtaneous access? I guess this could cause a fairness issue though. Line 66: until all the readers release their lock. Line 67: Line 68: If a reader try to acquire a read lock while other threads are waiting Line 69: (e.g. a writer), the reader is blocked until the waiting writer will get -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: fix bonded network change problem .. hooks: ovs: fix bonded network change problem When we try to change a bonded network, setupNetworks explodes because we are trying to remove running_nic which is None. Now we first check if configuration is changed and then do optional removal and setup of a nic. Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/52344 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open
Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsm: failed validateAccess leaves pipes open .. supervdsm: failed validateAccess leaves pipes open Whenever we run validateAccess and it fails with "Permission denied" we leak file descriptors. We need to make sure to close child and parent pipes. Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Signed-off-by: pkliczewski Bug-url: https://bugzilla.redhat.com/1271575 Reviewed-on: https://gerrit.ovirt.org/51850 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M vdsm/supervdsmServer 1 file changed, 26 insertions(+), 24 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open
gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/51850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open
Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/51850/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 29: import resource Line 30: import signal Line 31: import logging Line 32: import logging.config Line 33: from contextlib import closing > I think gathering the "from" imports together would be nicer. Since they ar long ago we decided that imports like this should be placed based on the order of contextlib.closing but yest, this sorting of this stanza is a random mess. Line 34: Line 35: from vdsm import commands Line 36: from vdsm import concurrent Line 37: from vdsm import cpuarch -- To view, visit https://gerrit.ovirt.org/51850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 12: Verified+1 uts in following patch -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: terminating tests - verify process death
Yaniv Bronhaim has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 1: Verified+1 I do it separately because I assume you will want deeper tests which probably require to expose zombie reaper pid lists and mock the kill func .. anyway, I don't want to block the original patch which verified locally . but Im up to uts for that For now, I did only basic one which only checks successful death when exiting the terminating context. -- To view, visit https://gerrit.ovirt.org/52362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split to commands_tests.py - only execCmd tests
gerrit-hooks has posted comments on this change. Change subject: split to commands_tests.py - only execCmd tests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4fafb105607f2a768ae80f74cdea131b2d3dc7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing context manager to terminate async processes on ...
gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: terminating tests - verify process death
Yaniv Bronhaim has uploaded a new change for review. Change subject: terminating tests - verify process death .. terminating tests - verify process death Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Signed-off-by: Yaniv Bronhaim --- M tests/utilsTests.py 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/52362/1 diff --git a/tests/utilsTests.py b/tests/utilsTests.py index 01a0796..059ce48 100644 --- a/tests/utilsTests.py +++ b/tests/utilsTests.py @@ -76,6 +76,20 @@ self.patch.revert() +class TerminatingTests(TestCaseBase): +def testTerminating(self): +proc = commands.execCmd([EXT_SLEEP, "5"], sync=False) +pids = utils.pgrep(EXT_SLEEP) +# verify process is up and running +self.assertTrue(proc.pid in pids) +with utils.terminating(proc): +# do whatever with proc +pass +# here process should not exist +pids = utils.pgrep(EXT_SLEEP) +self.assertFalse(proc.pid in pids) + + class RetryTests(TestCaseBase): def testStopCallback(self): counter = [0] -- To view, visit https://gerrit.ovirt.org/52362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: terminating tests - verify process death
gerrit-hooks has posted comments on this change. Change subject: terminating tests - verify process death .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: Verified+1 Manually verified (added bonded network and then edited it). With following tests-fixing patches it passes functional tests OK. -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Petr Horáček has uploaded a new change for review. Change subject: hooks: ovs: two networks cannot share one tag .. hooks: ovs: two networks cannot share one tag Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Signed-off-by: Petr Horáček --- M tests/functional/networkTestsOVS.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/52361/1 diff --git a/tests/functional/networkTestsOVS.py b/tests/functional/networkTestsOVS.py index 70b9d96..d58cb4e 100644 --- a/tests/functional/networkTestsOVS.py +++ b/tests/functional/networkTestsOVS.py @@ -90,6 +90,8 @@ 'testSetupNetworksMultiMTUsOverBond(False)', # bridgeless 'testSetupNetworksMultiMTUsOverNic(False)', # bridgeless 'testSetupNetworksNetCompatibilityMultipleNetsSameNic(False)', # brless +# two networks cannot share one tag +'testSetupNetworksNetCompatibilityMultipleNetsSameNic(True)', 'testSetupNetworksNiclessBridgeless', # bridgeless 'testSetupNetworksOverDhcpIface', # bridgeless 'testSetupNetworksRemoveBondWithKilledEnslavedNics', # bridgeless -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: delete recovery file only after destroy()
Milan Zamazal has posted comments on this change. Change subject: vm: delete recovery file only after destroy() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9513a72041e9514fd3aed8b2292f2ebdea4a03ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: fix tests (waitForState and vdsProxy)
..
hooks: ovs: fix tests (waitForState and vdsProxy)
We have to fake not only waitForKnownState, but also waitForState,
because of tests expects bond to turn UP, but that never happens.
We have to change proxy handling to match new behavior using
getProxy() function.
Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9
Signed-off-by: Petr Horáček
---
M tests/functional/networkTestsOVS.py
1 file changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/52360/1
diff --git a/tests/functional/networkTestsOVS.py
b/tests/functional/networkTestsOVS.py
index 17ffb3c..70b9d96 100644
--- a/tests/functional/networkTestsOVS.py
+++ b/tests/functional/networkTestsOVS.py
@@ -32,7 +32,7 @@
_get_source_route, dnsmasqDhcp, NETWORK_NAME,
IP_ADDRESS, IP_MASK, IP_CIDR, IP_GATEWAY,
IPv6_ADDRESS, IPv6_CIDR, VLAN_ID, NOCHK, SUCCESS)
-from utils import VdsProxy
+from utils import _VdsProxy
import dhcp
# WARNING: because of this module changes networkTests module, we cannot run
@@ -141,12 +141,13 @@
# When we set OVS bond device up, it does not turn UP, but only UNKNOWN
-def _fakeWaitForKnownOperstate(*args, **kwargs):
+def _fakeWaitForOperstate(*args, **kwargs):
pass
-networkTests._waitForKnownOperstate = _fakeWaitForKnownOperstate
+networkTests._waitForOperstate = _fakeWaitForOperstate
+networkTests._waitForKnownOperstate = _fakeWaitForOperstate
-class OVSVdsProxy(VdsProxy):
+class OVSVdsProxy(_VdsProxy):
def setupNetworks(self, networks, bonds, options):
if options.pop('ovs', True):
@@ -177,6 +178,21 @@
return super(OVSVdsProxy, self).setupNetworks(networks, bonds, options)
+_instance = OVSVdsProxy()
+
+
+def getProxy():
+"""
+We used to connect when a proxy was created but now
+we want to connect only when the proxy is needed.
+It is used in functional test context so we do not
+care about concurrent calls of this function.
+"""
+if not _instance._is_connected():
+_instance._connect()
+return _instance
+
+
@expandPermutations
class OVSNetworkTest(NetworkTest):
__test__ = True
@@ -196,7 +212,7 @@
return wrapper
def setUp(self):
-self.vdsm_net = OVSVdsProxy()
+self.vdsm_net = getProxy()
def setupNetworks(self, *args, **kwargs):
# Do not run test_kernel_config
--
To view, visit https://gerrit.ovirt.org/52360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: untested: notify Engine when host connectivity changes
Piotr Kliczewski has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes .. Patch Set 2: Subscription id looks good. -- To view, visit https://gerrit.ovirt.org/51135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters
Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 2: Verified+1 verified together: 52341 52342 tested the same way as master and branch 3.6: run migration back and forth while wuerying status meantime: $ watch -n1 vdsClient -s 0 list with no issues found, worked as expected -- To view, visit https://gerrit.ovirt.org/52342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I063d74c1fe1725c514f7aeb60463d0558e240baa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore
Francesco Romani has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 2: Verified+1 verified together: 52341 52342 tested the same way as master and branch 3.6: run migration back and forth while wuerying status meantime: $ watch -n1 vdsClient -s 0 list with no issues found, worked as expected -- To view, visit https://gerrit.ovirt.org/52341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fb7bd6a66898804eefd9bd286c77fd8b9225bc4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: untested: notify Engine when host connectivity changes
gerrit-hooks has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: delete recovery file only after destroy()
Francesco Romani has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51799/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3892: del self.cif.vmContainer[self.conf['vmId']]
Line 3893: except KeyError:
Line 3894: self.log.exception("Failed to delete VM %s",
self.conf['vmId'])
Line 3895: else:
Line 3896: self._cleanupRecoveryFile()
> Can it happen that VM disappears from vmContainer elsewhere, so we don't ca
No, deleteVm is the only place on which we do this removal.
Line 3897: self.log.debug("Total desktops after destroy of %s is
%d",
Line 3898:self.conf['vmId'],
len(self.cif.vmContainer))
Line 3899:
Line 3900: def destroy(self):
--
To view, visit https://gerrit.ovirt.org/51799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9513a72041e9514fd3aed8b2292f2ebdea4a03ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore
Francesco Romani has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 2: failed tests not related: 00:05:36.803 == 00:05:36.803 ERROR: test_mkIsoFs(label=None) (mkimageTests.MkimageTestCase) 00:05:36.803 -- 00:05:36.803 Traceback (most recent call last): 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/tests/testrunner.py", line 120, in wrapper 00:05:36.803 return f(self, *args) 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/tests/mkimageTests.py", line 191, in test_mkIsoFs 00:05:36.803 m.mount(mntOpts='loop') 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/vdsm/storage/mount.py", line 223, in mount 00:05:36.803 return self._runcmd(cmd, timeout) 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/vdsm/storage/mount.py", line 239, in _runcmd 00:05:36.803 raise MountError(rc, ";".join((out, err))) 00:05:36.803 MountError: (32, ';mount: /tmp/vdsm-mkimage-testsoKQdBj/images/vmId_iso.9a28a44bef56c9f24990eaa9bdc7c9e2.img: failed to setup loop device: No such file or directory\n') 00:05:36.803 >> begin captured logging << 00:05:36.803 root: DEBUG: /usr/bin/mkisofs -R -J -o /tmp/vdsm-mkimage-testsoKQdBj/images/vmId_iso.9a28a44bef56c9f24990eaa9bdc7c9e2.img /tmp/tmpvLbNhT (cwd None) 00:05:36.803 root: DEBUG: SUCCESS: = 'Total translation table size: 0\nTotal rockridge attributes bytes: 1796\nTotal directory bytes: 8192\nPath table size(bytes): 64\nMax brk space used 21000\n199 extents written (0 MB)\n'; = 0 00:05:36.803 Storage.Misc.excCmd: DEBUG: /usr/bin/mount -o loop /tmp/vdsm-mkimage-testsoKQdBj/images/vmId_iso.9a28a44bef56c9f24990eaa9bdc7c9e2.img /tmp/vdsm-mkimage-testsoKQdBj/work (cwd None) 00:05:36.803 - >> end captured logging << - 00:05:36.803 00:05:36.803 == 00:05:36.803 ERROR: testGetBondingOptions (netinfoTests.TestNetinfo) 00:05:36.803 -- 00:05:36.803 Traceback (most recent call last): 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/tests/monkeypatch.py", line 133, in wrapper 00:05:36.803 return f(*args, **kw) 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/tests/testValidation.py", line 100, in wrapper 00:05:36.803 return f(*args, **kwargs) 00:05:36.803 File "/var/lib/jenkins/workspace/vdsm_3.5_check-patch-fc22-x86_64/vdsm/tests/netinfoTests.py", line 374, in testGetBondingOptions 00:05:36.803 with open(BONDING_MASTERS, 'w') as bonds: 00:05:36.803 IOError: [Errno 13] Permission denied: '/sys/class/net/bonding_masters' 00:05:36.803 00:05:36.803 -- 00:05:36.803 Ran 648 tests in 104.936s -- To view, visit https://gerrit.ovirt.org/52341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fb7bd6a66898804eefd9bd286c77fd8b9225bc4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore
Vinzenz Feenstra has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46be9c779589b8c27395ced7904efb7de8cacc7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
