Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
gerrit-hooks has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Yaniv Bronhaim has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
Yaniv Bronhaim has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: configure --disable-python3
gerrit-hooks has posted comments on this change. Change subject: python3: configure --disable-python3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916e24abfd2a843428ee1977f825f27681e5c616 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: configure --disable-python3
Dan Kenigsberg has uploaded a new change for review.
Change subject: python3: configure --disable-python3
..
python3: configure --disable-python3
If you would not like to run python3 checks during build, you can now do
this with passing --disable-python3 to configure.
Change-Id: I916e24abfd2a843428ee1977f825f27681e5c616
Signed-off-by: Dan Kenigsberg
---
M Makefile.am
M configure.ac
M contrib/rhev_build.sh
M tests/Makefile.am
M vdsm.spec.in
5 files changed, 41 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/55519/1
diff --git a/Makefile.am b/Makefile.am
index 8b7422a..b66329d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -118,9 +118,13 @@
.PHONY: python3
python3: all
- PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \
- $(WHITELIST) \
- `find . -name '*.py'`;
+ if [ "$(ENABLE_PYTHON3)" != yes ]; then \
+ echo "skipping python3 compilation check"; \
+ else \
+ PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \
+ $(WHITELIST) \
+ `find . -name '*.py'`; \
+ fi
# Note: dependencies ordered by time needed to run them
check-recursive: gitignore abs_imports python3 pyflakes pep8
diff --git a/configure.ac b/configure.ac
index 3307507..4dbeef7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -105,6 +105,20 @@
)
AC_SUBST([ENABLE_LIBVIRT_SELINUX], ["${enable_libvirt_selinux}"])
+AC_ARG_ENABLE(
+[python3],
+[AS_HELP_STRING(
+[--disable-python3],
+[disable build-time testing with python3]
+)],
+,
+[enable_python3="yes"]
+)
+AC_SUBST([ENABLE_PYTHON3], ["${enable_python3}"])
+AS_IF([test "${enable_python3}" = "yes"],
+ AC_SUBST([WITH_PYTHON3], ['1']),
+ AC_SUBST([WITH_PYTHON3], ['0']))
+
AC_ARG_WITH(
[qemu-user],
[AS_HELP_STRING(
@@ -245,14 +259,16 @@
AC_MSG_WARN([python-pep8 not found])
fi
-AC_PATH_PROG([PYTHON3], [python3])
-if test "x$PYTHON3" = "x"; then
- AC_MSG_ERROR([python3 not found])
-fi
+if test "$enable_python3" == "yes"; then
+AC_PATH_PROG([PYTHON3], [python3])
+if test "x$PYTHON3" = "x"; then
+ AC_MSG_ERROR([python3 not found])
+fi
-AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
-if test "x$PYTHON3_NOSE" = "x"; then
- AC_MSG_ERROR([python3-nose not found])
+AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
+if test "x$PYTHON3_NOSE" = "x"; then
+ AC_MSG_ERROR([python3-nose not found])
+fi
fi
# Checking for python-devel
diff --git a/contrib/rhev_build.sh b/contrib/rhev_build.sh
index a41af7c..2cf717f 100755
--- a/contrib/rhev_build.sh
+++ b/contrib/rhev_build.sh
@@ -9,6 +9,7 @@
--with-qemu-kvm='qemu-kvm-rhev' \
--with-qemu-img='qemu-img-rhev' \
--enable-hooks \
+--disable-python3 \
--disable-gluster-mgmt
make dist
diff --git a/tests/Makefile.am b/tests/Makefile.am
index ad387a5..69159bc 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -269,5 +269,7 @@
@echo '*** into your environment. Do not submit untested code!***'
$(top_srcdir)/tests/run_tests_local.sh $(args) crossImportsTests.py
$(top_srcdir)/tests/run_tests_local.sh $(args) $(run_modules)
- PYTHON_EXE="$(PYTHON3)" $(top_srcdir)/tests/run_tests_local.sh \
- $(test_modules_py3);
+ if [ "$(ENABLE_PYTHON3)" == yes ]; then \
+ PYTHON_EXE="$(PYTHON3)" $(top_srcdir)/tests/run_tests_local.sh \
+ $(test_modules_py3); \
+ fi
diff --git a/vdsm.spec.in b/vdsm.spec.in
index fecbf5d..cd0a09e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -14,6 +14,7 @@
%global with_gluster_mgmt @GLUSTER_MGMT@
%global with_hooks @HOOKS@
%global with_vhostmd @VHOSTMD@
+%global with_python3 @WITH_PYTHON3@
# Glusterfs package version
%global gluster_version 3.7.1
@@ -81,12 +82,14 @@
BuildRequires: rpm-python
BuildRequires: python-blivet
+%if 0%{?with_python3}
%if 0%{?rhel}
BuildRequires: python34-nose
BuildRequires: python34-six
%else
BuildRequires: python3-nose
BuildRequires: python3-six
+%endif
%endif
# Autotools BuildRequires
@@ -646,6 +649,9 @@
%if 0%{?with_hooks}
--enable-hooks \
%endif
+%if ! 0%{?with_python3}
+--disable-python3 \
+%fi
%if ! 0%{?with_gluster_mgmt}
--disable-gluster-mgmt \
%endif
--
To view, visit https://gerrit.ovirt.org/55519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I916e24abfd2a843428ee1977f825f27681e5c616
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: vm: skip domDependentInit for containers
gerrit-hooks has posted comments on this change. Change subject: WIP: vm: skip domDependentInit for containers .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: initial support
gerrit-hooks has posted comments on this change. Change subject: containers: initial support .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e4b0552613ee160760a5a9bb4b27e0ae1f5d2f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: supervdsm: configure container networks
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: events: don't abort creation if event fails
gerrit-hooks has posted comments on this change. Change subject: vm: events: don't abort creation if event fails .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a06df003fce796519df26550910352120da17a8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: detect and report container support
gerrit-hooks has posted comments on this change. Change subject: containers: detect and report container support .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: always add emulator to XML
gerrit-hooks has posted comments on this change. Change subject: containers: always add emulator to XML .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie40c6a3e2cdbb72053db71056092d3b7684b994d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: HACK: virt: override vm type from custom property
gerrit-hooks has posted comments on this change. Change subject: HACK: virt: override vm type from custom property .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63b89f8791a9b0eb08100c62dcfa28d29b2321a6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: add imagerepo feed containers
gerrit-hooks has posted comments on this change. Change subject: hook: add imagerepo feed containers .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: configure --disable-python3
gerrit-hooks has posted comments on this change. Change subject: python3: configure --disable-python3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916e24abfd2a843428ee1977f825f27681e5c616 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: configure --disable-python3
Dan Kenigsberg has abandoned this change. Change subject: python3: configure --disable-python3 .. Abandoned Bronheim already done that on https://gerrit.ovirt.org/#/c/55517/ -- To view, visit https://gerrit.ovirt.org/55519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I916e24abfd2a843428ee1977f825f27681e5c616 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Dan Kenigsberg has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/55517/3/Makefile.am File Makefile.am: Line 117: $(WHITELIST) Line 118: Line 119: .PHONY: python3 Line 120: python3: all Line 121: if [ -x "$(PYTHON3)" ]; then \ test PYTHON3_SUPPORT here as well. Line 122: PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \ Line 123: $(WHITELIST) \ Line 124: `find . -name '*.py'`; \ Line 125: else \ https://gerrit.ovirt.org/#/c/55517/3/tests/Makefile.am File tests/Makefile.am: Line 255: @echo '*** Running tests. To skip this step place NOSE_EXCLUDE=.* ***' Line 256: @echo '*** into your environment. Do not submit untested code! ***' Line 257: $(top_srcdir)/tests/run_tests_local.sh $(args) crossImportsTests.py Line 258: $(top_srcdir)/tests/run_tests_local.sh $(args) $(run_modules) Line 259: if [ -x "$(PYTHON3)" ]; then \ please test [ PYTHON3_SUPPORT -eq 1 ]. event if pytohn3 is installed, we should skip the test in case we were asked to avoid it in ./configure Line 260: PYTHON_EXE="$(PYTHON3)" $(top_srcdir)/tests/run_tests_local.sh \ Line 261: $(test_modules_py3); \ -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
Dan Kenigsberg has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 3: I think that this can be safely squashed into the previous patch. -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
Dan Kenigsberg has posted comments on this change. Change subject: commands: import StringIO when AsyncProc is started .. Patch Set 5: Verified+1 passes unit tests -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotplug
Piotr Kliczewski has posted comments on this change. Change subject: hostdev: add support for hotplug .. Patch Set 16: Code-Review-1 Repeating my score from patch set #12 -- To view, visit https://gerrit.ovirt.org/42661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
gerrit-hooks has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
Yaniv Bronhaim has abandoned this change. Change subject: contrib: Build script for rhev without python3 support .. Abandoned squashed to https://gerrit.ovirt.org/#/c/55517 -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Piotr Kliczewski has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
Piotr Kliczewski has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: suppress for python2
Piotr Kliczewski has posted comments on this change. Change subject: suppress for python2 .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
Piotr Kliczewski has posted comments on this change. Change subject: commands: import StringIO when AsyncProc is started .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
Dan Kenigsberg has submitted this change and it was merged. Change subject: commands: import StringIO when AsyncProc is started .. commands: import StringIO when AsyncProc is started This patch makes it possible to import vdsm.commands on Python 3. However, it does not make the module py3-compatible - any usage of AsyncProc under Python 3 would fail in runtime. The motivation of this patch is to allow adding more modules to the test_modules_py3 list, while causing no runtime harm to Python 3. Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/55380 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski --- M lib/vdsm/commands.py M tests/Makefile.am 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
gerrit-hooks has posted comments on this change. Change subject: commands: import StringIO when AsyncProc is started .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: suppress for python2
Dan Kenigsberg has submitted this change and it was merged. Change subject: suppress for python2 .. suppress for python2 Since suppress() function is available only since Python 3.4, add our own implementation to vdsm/common/contextlib.py and use it if original not available. Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/55065 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Reviewed-by: Piotr Kliczewski --- A lib/vdsm/common/contextlib.py M lib/vdsm/compat.py A tests/common/contextlib_test.py M vdsm_hooks/ovs/ovs_before_network_setup.py M vdsm_hooks/ovs/ovs_before_network_setup_ip.py M vdsm_hooks/ovs/ovs_before_network_setup_libvirt.py M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py M vdsm_hooks/ovs/ovs_utils.py 8 files changed, 90 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Verified -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: suppress for python2
gerrit-hooks has posted comments on this change. Change subject: suppress for python2 .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotplug
Martin Polednik has posted comments on this change. Change subject: hostdev: add support for hotplug .. Patch Set 16: Would be nice to also consider my response. It does not make sense to make this single hotplug different and hack around utils.validateMinimalKeySet by creating tmp dict from it. -- To view, visit https://gerrit.ovirt.org/42661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Dan Kenigsberg has submitted this change and it was merged. Change subject: testlib: Fix temporaryPath on Python 3. .. testlib: Fix temporaryPath on Python 3. Writing data to files must use bytes objects, not unicode/strings. Replace os.fdopen() with io.open(path, "wb") creating a buffered file object for writing binary data. Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/55489 Reviewed-by: Francesco Romani Reviewed-by: Yaniv Bronhaim Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski --- M tests/testlib.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
gerrit-hooks has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Vinzenz Feenstra has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring network caps
Dan Kenigsberg has submitted this change and it was merged. Change subject: caps: allow root-requiring network caps .. caps: allow root-requiring network caps Since some OVS parameters are available only to root, we have to introduce a mechanism to complement already gathered network info with root-only data. This will be done by introduced network/api.py:caps_networks(). Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/55073 Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI --- M lib/vdsm/network/api.py M vdsm/caps.py M vdsm/supervdsm_api/network.py 3 files changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring network caps
gerrit-hooks has posted comments on this change. Change subject: caps: allow root-requiring network caps .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
gerrit-hooks has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Francesco Romani has uploaded a new change for review. Change subject: automation: require python3 packages on fedora23 .. automation: require python3 packages on fedora23 Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a unbreaks: error: python3-nose not found Signed-off-by: Francesco Romani --- A automation/build-artifacts.packages.fc23 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/55522/1 diff --git a/automation/build-artifacts.packages.fc23 b/automation/build-artifacts.packages.fc23 new file mode 100644 index 000..57d2e05 --- /dev/null +++ b/automation/build-artifacts.packages.fc23 @@ -0,0 +1,22 @@ +autoconf +automake +git +libguestfs-tools-c +m2crypto +make +mom +policycoreutils-python +pyflakes +python-blivet +python-devel +python-inotify +python-ioprocess +python-netaddr +python-nose +python-pep8 +python-pthreading +python-six +python3-nose +python3-six +rpm-build +yum-utils -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Sandro Bonazzola has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
gerrit-hooks has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Edward Haas has posted comments on this change.
Change subject: network: add hosttail_join to address.py
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/55473/1/lib/vdsm/common/network/address.py
File lib/vdsm/common/network/address.py:
PS1, Line 56: "
We usually use single quotes
https://gerrit.ovirt.org/#/c/55473/1/tests/common/network_test.py
File tests/common/network_test.py:
Line 67: def test_hosttail_ipv6_no_brackets_returns_garbage(self):
Line 68: self.assertNotEqual(('2001::1', '4321'),
Line 69: ipaddress.hosttail_split('2001::1:4321'))
Line 70:
Line 71: @permutations([
Please use the convention above for tests and avoid the permutations, it is not
readable and its unclear what is tested and why.
As an example, What does ("ser:ver", "/path", "[ser:ver]:/path") tests? (it is
not a legal name for a host)
Line 72: # (host, tail, expected_return_value)
Line 73: ("server", "/", "server:/"),
Line 74: ("server", "/path", "server:/path"),
Line 75: ("ser:ver", "/path", "[ser:ver]:/path"),
--
To view, visit https://gerrit.ovirt.org/55473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Yaniv Bronhaim has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Yaniv Bronhaim has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 2: we have build-artifacts.packages .. we should separate it to build-artifacts.packages.el7 and build-artifacts.packages.fc23 now, no? -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: marking test as broken
Martin Mucha has uploaded a new change for review.
Change subject: marking test as broken
..
marking test as broken
Change-Id: I0b253deed5e18d7c65c240f4c360dd9b7b60d0c4
Signed-off-by: Martin Mucha
---
M tests/utilsTests.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/55523/1
diff --git a/tests/utilsTests.py b/tests/utilsTests.py
index c8b4d17..b49b75d 100644
--- a/tests/utilsTests.py
+++ b/tests/utilsTests.py
@@ -238,6 +238,7 @@
class PgrepTests(TestCaseBase):
+@brokentest("when running './autogen.sh --system && make rpm' from fedora
23 in virtual machine, this tests fails")
def test(self):
sleepProcs = []
for i in range(3):
--
To view, visit https://gerrit.ovirt.org/55523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b253deed5e18d7c65c240f4c360dd9b7b60d0c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: marking test as broken
gerrit-hooks has posted comments on this change. Change subject: marking test as broken .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b253deed5e18d7c65c240f4c360dd9b7b60d0c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Mucha Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Jenkins CI has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
Vinzenz Feenstra has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/55135/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1685: for con in self._devices[hwclass.CONSOLE]: Line 1686: con.cleanup() Line 1687: Line 1688: def _teardownDevices(self): Line 1689: for dev_objects in self._devices.values(): > This is not safe on Python 3 - check if six has a helper that does nothing This is not really a problem because the keys aren't changing on runtime, however the bigger issue would be the iteration below Line 1690: for dev_object in dev_objects: Line 1691: dev_object.teardown() Line 1692: Line 1693: def _cleanupRecoveryFile(self): -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Francesco Romani has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 2: Yaniv: ok, on it. -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Yaniv Bronhaim has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 2: Code-Review-1 oh I already sent such patch :) https://gerrit.ovirt.org/#/c/55396/ forgot about it. just need to change it to softlinks -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Dan Kenigsberg has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55517/6/configure.ac File configure.ac: Line 259: if test "x$PEP8" = "x"; then Line 260: AC_MSG_WARN([python-pep8 not found]) Line 261: fi Line 262: Line 263: AC_PATH_PROG([PYTHON3], [python3]) these two tests must be skipped if python3 is not to be supported Line 264: if test "x$PYTHON3" = "x"; then Line 265: AC_MSG_ERROR([python3 not found]) Line 266: fi Line 267: -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
gerrit-hooks has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
gerrit-hooks has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 4: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
gerrit-hooks has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Idan Shaby has posted comments on this change.
Change subject: storagetests: add test for mount.isMounted
..
Patch Set 3:
(6 comments)
https://gerrit.ovirt.org/#/c/55180/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-03-31 11:35:30 +0300
Line 6:
Line 7: storagetests: add test for mount.isMounted
Line 8:
Line 9: Given a local path, this test verifies that the expected fs_file is
> Given a local path
Done
Line 10: found in /proc/mounts by calling mount.isMounted.
Line 11:
Line 12: Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee
Line 13: Related-To: https://bugzilla.redhat.com/1305529
Line 7: storagetests: add test for mount.isMounted
Line 8:
Line 9: Given a local path, this test verifies that the expected fs_file is
Line 10: found in /proc/mounts by calling mount.isMounted.
Line 11:
> This is not very clear. This patch add the missing tests ensuring that moun
Done
Line 12: Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee
Line 13: Related-To: https://bugzilla.redhat.com/1305529
https://gerrit.ovirt.org/#/c/55180/2/tests/mountTests.py
File tests/mountTests.py:
Line 31: from nose.plugins.skip import SkipTest
Line 32:
Line 33: from testlib import VdsmTestCase as TestCaseBase
Line 34: from testlib import namedTemporaryDir, temporaryPath
Line 35: from testlib import expandPermutations, permutations
> Don't use \. Instead, add separate import for namedTemporaryDir and tempora
Done
Line 36: from storage.misc import execCmd
Line 37: import storage.mount as mount
Line 38: from testValidation import checkSudo
Line 39: import monkeypatch
Line 277: 0)
Line 278: self.assertFalse('/dev/loop10001' in mount._getLoopFsSpecs())
Line 279:
Line 280:
Line 281: @contextmanager
> This should be in the function docstring:
Done
Line 282: def fake_mounts(mount_lines):
Line 283: """
Line 284: This method gets a list of mount lines,
Line 285: fakes the /proc/mounts and /etc/mtab files
Line 289: Usage example:
Line 290: with fake_mounts([mount_line_1, mount_line_2]):
Line 291:
Line 292: """
Line 293: data = b"".join(line + b"\n" for line in mount_lines)
> mount_list -> mount_lines
Done
Line 294: with temporaryPath(data=data) as fake_mounts:
Line 295: with monkeypatch.MonkeyPatchScope([
Line 296: (mount, '_PROC_MOUNTS_PATH', fake_mounts),
Line 297: (mount, '_ETC_MTAB_PATH', fake_mounts),
Line 301:
Line 302: class TestRemoteSdIsMounted(TestCaseBase):
Line 303:
Line 304: def test_is_mounted(self):
Line 305: with fake_mounts(["server:/path "
> Use b"...", in Python 3 you cannot write a string to a file without specify
I get here a sintax error:
*** File "./tests/mountTests.py", line 305
with fake_mounts([b"server:/path "
^
SyntaxError: cannot mix bytes and nonbytes literals
The test passes without this change, why should we change it?
Maybe it is run by Python 2?
Line 306: "/rhev/data-center/mnt/server:_path "
Line 307: "nfs4 defaults 0 0"]):
Line 308: self.assertTrue(mount.isMounted(
Line 309: "/rhev/data-center/mnt/server:_path"))
--
To view, visit https://gerrit.ovirt.org/55180
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
Francesco Romani has abandoned this change. Change subject: automation: require python3 packages on fedora23 .. Abandoned fixing in 55396 -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Idan Shaby has posted comments on this change.
Change subject: network: add hosttail_join to address.py
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/55473/1/lib/vdsm/common/network/address.py
File lib/vdsm/common/network/address.py:
PS1, Line 56: '
> We usually use single quotes
Done
https://gerrit.ovirt.org/#/c/55473/1/tests/common/network_test.py
File tests/common/network_test.py:
Line 67: def test_hosttail_ipv6_no_brackets_returns_garbage(self):
Line 68: self.assertNotEqual(('2001::1', '4321'),
Line 69: ipaddress.hosttail_split('2001::1:4321'))
Line 70:
Line 71: @permutations([
> Please use the convention above for tests and avoid the permutations, it is
IMHO, permutations are readable, clear and were meant exactly for these kind of
tests.
I don't think that duplicating the code six times (as the number of
permutations) and make it ~ three times bigger will make it more readable, it
will just make it longer.
The third test proves that even if it's not an IPv6 legal address, the method
still does what it claims, and thus proves that we don't wrap only IPv6
addresses with "[]", but any string that contains a colon. If you think that
this permutation is irrelevant, I don't mind to remove it.
There are plenty of places where we use permutations in vdsm.
Please consider to ack this patch and not delaying the patches that depend on
it. You can always send a patch that transforms this code to your style, if you
like. I will not be against it.
Line 72: # (host, tail, expected)
Line 73: ("server", "/", "server:/"),
Line 74: ("server", "/path", "server:/path"),
Line 75: ("ser:ver", "/path", "[ser:ver]:/path"),
Line 68: self.assertNotEqual(('2001::1', '4321'),
Line 69: ipaddress.hosttail_split('2001::1:4321'))
Line 70:
Line 71: @permutations([
Line 72: # (host, tail, expected)
> expected_return_value is little too long, if you use "expected", the test
Done
Line 73: ("server", "/", "server:/"),
Line 74: ("server", "/path", "server:/path"),
Line 75: ("ser:ver", "/path", "[ser:ver]:/path"),
Line 76: ("12.34.56.78", "/path", "12.34.56.78:/path"),
--
To view, visit https://gerrit.ovirt.org/55473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: require python3 packages on fedora23
gerrit-hooks has posted comments on this change. Change subject: automation: require python3 packages on fedora23 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
Idan Shaby has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 3: Nir, this series of patches are aimed to fix a bug. Please don't delay them with a request to fix other things "on the way". We can upload a patch to fix it later. -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
gerrit-hooks has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sr-iov: use device setup instead of detach
gerrit-hooks has posted comments on this change. Change subject: sr-iov: use device setup instead of detach .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use device setup instead of detach
gerrit-hooks has posted comments on this change. Change subject: hostdev: use device setup instead of detach .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibff865dc1a40434bf48e640baf25b67b39767001 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
Idan Shaby has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/55182/3/vdsm/storage/fileUtils.py File vdsm/storage/fileUtils.py: Line 32: import ctypes Line 33: from contextlib import contextmanager Line 34: from vdsm.common.network import address as ipaddress Line 35: import subprocess Line 36: import shutil > We cannot depend on mount here, mount should depend on this module since th Done Line 37: import logging Line 38: import errno Line 39: import sys Line 40: import warnings https://gerrit.ovirt.org/#/c/55182/3/vdsm/storage/mount.py File vdsm/storage/mount.py: Line 182: return Mount(rec.fs_spec, rec.fs_file) Line 183: Line 184: raise OSError(errno.ENOENT, 'Mount target %s not found' % target) Line 185: Line 186: > We can delete the commented code now. Bahh...my bad :/ Thanks Line 187: def getMountFromDevice(device): Line 188: device = normpath(device) Line 189: for rec in _iterMountRecords(): Line 190: if rec.fs_spec == device: -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Idan Shaby has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handle closed stream when virt-v2v fails
Nir Soffer has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 3: Please add *Bug-Url* -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
Idan Shaby has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Idan Shaby has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Adding the netswitch module
gerrit-hooks has posted comments on this change. Change subject: net: Adding the netswitch module .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Adding the netswitch module
Dan Kenigsberg has posted comments on this change. Change subject: net: Adding the netswitch module .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Adding the netswitch module
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Adding the netswitch module .. net: Adding the netswitch module netswitch is placed between the network api and the switches (legacy and future ovs), acting as an interface to the underlying switches and taking shared responsibilities. Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/55131 Tested-by: Petr Horáček Reviewed-by: Petr Horáček Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M debian/vdsm.install M lib/vdsm/network/Makefile.am M lib/vdsm/network/api.py A lib/vdsm/network/connectivity.py A lib/vdsm/network/netswitch.py A tests/network/connectivity_test.py M vdsm.spec.in 7 files changed, 189 insertions(+), 57 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/55131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
Martin Polednik has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py File vdsm/virt/vm.py: PS4, Line 1689: for dev_objects in self._devices.values(): This is safe in both 2 and 3 as it iterates over device types (those are static for us) PS4, Line 1690: for dev_object in dev_objects[:] This is also safe in both 2 and 3 as slice is still a copy -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: marking test as broken
Dan Kenigsberg has posted comments on this change.
Change subject: marking test as broken
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55523/1/tests/utilsTests.py
File tests/utilsTests.py:
Line 237: sproc.wait()
Line 238:
Line 239:
Line 240: class PgrepTests(TestCaseBase):
Line 241: @brokentest("when running './autogen.sh --system && make rpm'
from fedora 23 in virtual machine, this tests fails")
./tests/utilsTests.py:241:80: E501 line too long (120 > 79 characters)
"this test fails when run in a Fedora 23 virtual machine"
would be enough.
but the commit message should include the traceback of this failure - I was not
aware of this one, and it smells like something that must be solved.
Line 242: def test(self):
Line 243: sleepProcs = []
Line 244: for i in range(3):
Line 245: sleepProcs.append(commands.execCmd([EXT_SLEEP, "3"],
sync=False,
--
To view, visit https://gerrit.ovirt.org/55523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b253deed5e18d7c65c240f4c360dd9b7b60d0c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handle closed stream when virt-v2v fails
gerrit-hooks has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 4: * #1298134::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298134::OK, public bug * Check Product::#1298134::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
Petr Horáček has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/55497/1/tests/network/hook_ovs_test.py File tests/network/hook_ovs_test.py: PS1, Line 46: class TestOvsHookMigration(VdsmTestCase): You can use 'from testlib import XMLTestCase', it handles XML assertion. -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
gerrit-hooks has posted comments on this change. Change subject: API: net: introduce 'switch' attribute for nets and bonds .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: destroy: try harder destroying a Vm
Dan Kenigsberg has posted comments on this change. Change subject: vm: destroy: try harder destroying a Vm .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: destroy: retry to gracefully destroy
gerrit-hooks has posted comments on this change. Change subject: vm: destroy: retry to gracefully destroy .. Patch Set 12: * #1309884::Update tracker: OK * Set MODIFIED::bug 1309884#1309884IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/55224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I513b16c5091cb22313dc18e2587ed6db386e982a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: destroy: retry to gracefully destroy
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: destroy: retry to gracefully destroy .. vm: destroy: retry to gracefully destroy Add support to retry gracefully to destroy a VM before to go forcefully. Clients (Engine) could use a new optional parameter to tell Vdsm how many times it should retry gracefully. This is meant to reduce the risk of data corruption in the case the first graceful destroy fails (e.g. EBUSY, or system-level timeout). The default number of graceful attempt is one for backward compatibility. Change-Id: I513b16c5091cb22313dc18e2587ed6db386e982a Bug-Url: https://bugzilla.redhat.com/1309884 Backport-To: 3.6 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/55224 Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- M lib/api/vdsmapi-schema.json M tests/vmTests.py M tests/vmfakelib.py M vdsm/API.py M vdsm/virt/vm.py 5 files changed, 93 insertions(+), 13 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/55224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I513b16c5091cb22313dc18e2587ed6db386e982a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: destroy: try harder destroying a Vm
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: destroy: try harder destroying a Vm .. vm: destroy: try harder destroying a Vm The current Vm code to destroy a Vm starts nice, using graceful destroy, and hits harder if the nice way fails. However, the failure of the first graceful attempt is only detected when libvirt returns a specific error code. Indeed, the return code of libvirt changed between RHEL6 and RHEL7. This looks fragile and looks like unnecessary detail. Digging into history, I was not able to find the reason why we look for a specific error code. This patch just drops the specific error code check. Now Vdsm always uses the harsh way if the nice way fails. Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b Bug-Url: https://bugzilla.redhat.com/1309884 Backport-To: 3.6 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/53747 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/53747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: destroy: try harder destroying a Vm
gerrit-hooks has posted comments on this change. Change subject: vm: destroy: try harder destroying a Vm .. Patch Set 14: * #1309884::Update tracker: OK * Set MODIFIED::bug 1309884#1309884IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/53747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Move saveState() out of constructor
gerrit-hooks has posted comments on this change. Change subject: vm: Move saveState() out of constructor .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: canonicalize 'switch' in nets and bonds
gerrit-hooks has posted comments on this change. Change subject: net: canonicalize 'switch' in nets and bonds .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bonding: regenerated bonding-name2numeric.json on EL7
gerrit-hooks has posted comments on this change. Change subject: bonding: regenerated bonding-name2numeric.json on EL7 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c9812896692066555c333d1ecaa2013343c523 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
Dan Kenigsberg has posted comments on this change. Change subject: API: net: introduce 'switch' attribute for nets and bonds .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: extract destroyVm helper
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55535
to review the following change.
Change subject: virt: extract destroyVm helper
..
virt: extract destroyVm helper
It is generally not safe to force the destruction
(really: shutdown) of a VM. There are few known cases
on which we believe it is safe despite a previous
failure of destroyVmGraceful().
This patch adds an utility method to encapsulate
force-shutdown-afeter-known-safe-error logic,
previously found in destroyVmGraceful().
No changes in external behaviour.
Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Bug-Url: https://bugzilla.redhat.com/1309884
Backport-To: 3.6
Signed-off-by: Francesco Romani
Reviewed-on: https://gerrit.ovirt.org/53932
Reviewed-by: Dan Kenigsberg
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/55535/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 62da365..30d2f07 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3818,7 +3818,7 @@
self._incomingMigrationFinished.set()
self.guestAgent.stop()
if self._dom.connected:
-result = self._destroyVmGraceful()
+result = self._destroyVm()
if response.is_error(result):
return result
@@ -3842,7 +3842,14 @@
return response.success()
+def _destroyVm(self):
+res, safe_to_force = self._destroyVmGraceful()
+if safe_to_force:
+res = self._destroyVmForceful()
+return res
+
def _destroyVmGraceful(self):
+safe_to_force = False
try:
self._dom.destroyFlags(libvirt.VIR_DOMAIN_DESTROY_GRACEFUL)
except libvirt.libvirtError as e:
@@ -3856,9 +3863,9 @@
"Failed to destroy VM '%s' gracefully (error=%i)",
self.id, e.get_error_code())
if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED:
-return self._destroyVmForceful()
-return response.error('destroyErr')
-return response.success()
+safe_to_force = True
+return response.error('destroyErr'), safe_to_force
+return response.success(), safe_to_force
def _destroyVmForceful(self):
try:
--
To view, visit https://gerrit.ovirt.org/55535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55534
to review the following change.
Change subject: virt: clean and modernize the destroy() path
..
virt: clean and modernize the destroy() path
cleanup the destroy path with no changes in behaviour.
Change-Id: I46296fe7ac6c13e064014298148f518ea6b1e1d8
Bug-Url: https://bugzilla.redhat.com/1309884
Backport-To: 3.6
Signed-off-by: Francesco Romani
Reviewed-on: https://gerrit.ovirt.org/53931
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal
Reviewed-by: Dan Kenigsberg
---
M vdsm/virt/vm.py
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/55534/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index e942773..62da365 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3852,21 +3852,23 @@
self.log.info("VM '%s' already down and destroyed",
self.conf['vmId'])
else:
-self.log.warning("Failed to destroy VM '%s' gracefully",
- self.conf['vmId'], exc_info=True)
+self.log.warning(
+"Failed to destroy VM '%s' gracefully (error=%i)",
+self.id, e.get_error_code())
if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED:
return self._destroyVmForceful()
return response.error('destroyErr')
-return {'status': doneCode}
+return response.success()
def _destroyVmForceful(self):
try:
self._dom.destroy()
-except libvirt.libvirtError:
-self.log.warning("Failed to destroy VM '%s'",
- self.conf['vmId'], exc_info=True)
+except libvirt.libvirtError as e:
+self.log.warning(
+"Failed to destroy VM '%s' forcefully (error=%i)",
+self.id, e.get_error_code())
return response.error('destroyErr')
-return {'status': doneCode}
+return response.success()
def deleteVm(self):
"""
--
To view, visit https://gerrit.ovirt.org/55534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46296fe7ac6c13e064014298148f518ea6b1e1d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Milan Zamazal
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: destroy: try harder destroying a Vm
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55536
to review the following change.
Change subject: vm: destroy: try harder destroying a Vm
..
vm: destroy: try harder destroying a Vm
The current Vm code to destroy a Vm starts
nice, using graceful destroy, and hits harder
if the nice way fails.
However, the failure of the first graceful attempt
is only detected when libvirt returns a specific error code.
Indeed, the return code of libvirt changed between RHEL6 and RHEL7.
This looks fragile and looks like unnecessary detail.
Digging into history, I was not able to find the reason why we look
for a specific error code.
This patch just drops the specific error code check.
Now Vdsm always uses the harsh way if the nice way fails.
Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b
Bug-Url: https://bugzilla.redhat.com/1309884
Backport-To: 3.6
Signed-off-by: Francesco Romani
Reviewed-on: https://gerrit.ovirt.org/53747
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/55536/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 30d2f07..81c166d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3862,7 +3862,8 @@
self.log.warning(
"Failed to destroy VM '%s' gracefully (error=%i)",
self.id, e.get_error_code())
-if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED:
+if e.get_error_code() in (libvirt.VIR_ERR_OPERATION_FAILED,
+ libvirt.VIR_ERR_SYSTEM_ERROR,):
safe_to_force = True
return response.error('destroyErr'), safe_to_force
return response.success(), safe_to_force
--
To view, visit https://gerrit.ovirt.org/55536
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: extract destroyVm helper
gerrit-hooks has posted comments on this change. Change subject: virt: extract destroyVm helper .. Patch Set 1: * #1309884::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1309884::OK, public bug * Check Product::#1309884::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1309884::OK, correct target milestone ovirt-3.6.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/55535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: use response module in the destroy path
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55533
to review the following change.
Change subject: vm: use response module in the destroy path
..
vm: use response module in the destroy path
use the facilities of the response module to
make the code nicer, and easier to change in the future.
Change-Id: I92402f2101c4c256e18b251e2e12e65b8ae849a1
Backport-To: 3.6
Signed-off-by: Francesco Romani
Reviewed-on: https://gerrit.ovirt.org/51383
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/55533/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 890d328..e942773 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3801,7 +3801,7 @@
with self._releaseLock:
if self._released:
-return {'status': doneCode}
+return response.success()
# unsetting mirror network will clear both mirroring
# (on the same network).
@@ -3819,7 +3819,7 @@
self.guestAgent.stop()
if self._dom.connected:
result = self._destroyVmGraceful()
-if result['status']['code']:
+if response.is_error(result):
return result
# Wait for any Live Merge cleanup threads. This will only block in
@@ -3840,7 +3840,7 @@
self._released = True
-return {'status': doneCode}
+return response.success()
def _destroyVmGraceful(self):
try:
@@ -3885,12 +3885,12 @@
self.log.debug('destroy Called')
result = self.doDestroy()
-if result['status']['code']:
+if response.is_error(result):
return result
# Clean VM from the system
self.deleteVm()
-return {'status': doneCode}
+return response.success()
def doDestroy(self):
for dev in self._customDevices():
--
To view, visit https://gerrit.ovirt.org/55533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92402f2101c4c256e18b251e2e12e65b8ae849a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path
gerrit-hooks has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 1: * #1309884::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1309884::OK, public bug * Check Product::#1309884::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1309884::OK, correct target milestone ovirt-3.6.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/55534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46296fe7ac6c13e064014298148f518ea6b1e1d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: use response module in the destroy path
gerrit-hooks has posted comments on this change. Change subject: vm: use response module in the destroy path .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/55533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92402f2101c4c256e18b251e2e12e65b8ae849a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: destroy: retry to gracefully destroy
Hello Piotr Kliczewski,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/55537
to review the following change.
Change subject: vm: destroy: retry to gracefully destroy
..
vm: destroy: retry to gracefully destroy
Add support to retry gracefully to destroy a VM
before to go forcefully.
Clients (Engine) could use a new optional parameter
to tell Vdsm how many times it should retry
gracefully. This is meant to reduce the risk
of data corruption in the case the first graceful
destroy fails (e.g. EBUSY, or system-level timeout).
The default number of graceful attempt is one for
backward compatibility.
Change-Id: I513b16c5091cb22313dc18e2587ed6db386e982a
Bug-Url: https://bugzilla.redhat.com/1309884
Backport-To: 3.6
Signed-off-by: Francesco Romani
Reviewed-on: https://gerrit.ovirt.org/55224
Reviewed-by: Piotr Kliczewski
Continuous-Integration: Jenkins CI
---
M tests/vmTests.py
M tests/vmfakelib.py
M vdsm/API.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
5 files changed, 93 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/55537/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index a0d7d0b..9791a58 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -994,6 +994,67 @@
self.assertXMLEqual(out_dom_xml,
_load_xml('vm_restore_spice_after.xml'))
+@MonkeyPatch(os, 'unlink', lambda _: None)
+def test_release_vm_succeeds(self):
+with fake.VM(self.conf) as testvm:
+testvm.guestAgent = fake.GuestAgent()
+
+dom = fake.Domain()
+
+status = {
+'graceful': 0,
+'forceful': 0,
+}
+
+def graceful(*args):
+status['graceful'] += 1
+return response.success()
+
+def forceful(*args):
+status['forceful'] += 1
+return response.success()
+
+dom.destroyFlags = graceful
+dom.destroy = forceful
+testvm._dom = dom
+
+testvm.releaseVm()
+self.assertEqual(status, {
+'graceful': 1,
+'forceful': 0,
+})
+
+@MonkeyPatch(os, 'unlink', lambda _: None)
+@permutations([[1], [2], [3], [9]])
+def test_releasevm_fails(self, attempts):
+with fake.VM(self.conf) as testvm:
+testvm.guestAgent = fake.GuestAgent()
+
+dom = fake.Domain()
+
+status = {
+'graceful': 0,
+'forceful': 0,
+}
+
+def graceful(*args):
+status['graceful'] += 1
+raise fake.Error(libvirt.VIR_ERR_SYSTEM_ERROR)
+
+def forceful(*args):
+status['forceful'] += 1
+return response.success()
+
+dom.destroyFlags = graceful
+dom.destroy = forceful
+testvm._dom = dom
+
+testvm.releaseVm(gracefulAttempts=attempts)
+self.assertEqual(status, {
+'graceful': attempts,
+'forceful': 1,
+})
+
@expandPermutations
class TestVmOperations(TestCaseBase):
diff --git a/tests/vmfakelib.py b/tests/vmfakelib.py
index dec951c..069a455 100644
--- a/tests/vmfakelib.py
+++ b/tests/vmfakelib.py
@@ -147,10 +147,15 @@
return uuid, usage_type, usage_id, description
+class IRS(object):
+def inappropriateDevices(self, ident):
+pass
+
+
class ClientIF(clientIF.clientIF):
def __init__(self):
# the bare minimum initialization for our test needs.
-self.irs = None # just to make sure nothing ever happens
+self.irs = IRS() # just to make sure nothing ever happens
self.log = logging.getLogger('fake.ClientIF')
self.channelListener = None
self.vmContainerLock = threading.Lock()
@@ -283,6 +288,9 @@
'memoryStats': {},
'guestCPUCount': -1}
+def stop(self):
+pass
+
class VirNodeDeviceStub(object):
diff --git a/vdsm/API.py b/vdsm/API.py
index d5f6ced..4342277 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -334,7 +334,7 @@
else:
return errCode['nonresp']
-def destroy(self):
+def destroy(self, gracefulAttempts=1):
"""
Destroy the specified VM.
"""
@@ -344,7 +344,7 @@
v = self._cif.vmContainer.get(self._UUID)
if not v:
return errCode['noVM']
-res = v.destroy()
+res = v.destroy(gracefulAttempts)
status = utils.picklecopy(res)
if status['status']['code'] == 0:
status['status']['message'] = "Machine destroyed"
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 8ca7627..4721917 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6784,
Change in vdsm[ovirt-3.6]: vm: destroy: try harder destroying a Vm
gerrit-hooks has posted comments on this change. Change subject: vm: destroy: try harder destroying a Vm .. Patch Set 1: * #1309884::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1309884::OK, public bug * Check Product::#1309884::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1309884::OK, correct target milestone ovirt-3.6.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/55536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: destroy: retry to gracefully destroy
gerrit-hooks has posted comments on this change. Change subject: vm: destroy: retry to gracefully destroy .. Patch Set 1: * #1309884::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1309884::OK, public bug * Check Product::#1309884::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1309884::OK, correct target milestone ovirt-3.6.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/55537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I513b16c5091cb22313dc18e2587ed6db386e982a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora
Francesco Romani has posted comments on this change. Change subject: spec: don't depend on ovirt-vmconsole on fedora .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/54999/8//COMMIT_MSG Commit Message: Line 12: Line 13: ./configure \ Line 14: --with-ovirt-vmconsole-user=vdsm Line 15: --with-ovirt-vmconsole-group=kvm Line 16: > not sure I understand. but without having vmconsole installed I expect not yes, and this is the reason why it broke on fedora :) no ovirt-vmconsole -> no user -> VMs fails to start workaround: ./configure as described above. Line 17: In particular the ovirt-vmconsole-group could be something Line 18: else, but MUST be a group already present in the system. Line 19: Without those two options, any VM will fail to run. Line 20: -- To view, visit https://gerrit.ovirt.org/54999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora
gerrit-hooks has posted comments on this change. Change subject: spec: don't depend on ovirt-vmconsole on fedora .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: destroy: retry to gracefully destroy
Piotr Kliczewski has posted comments on this change. Change subject: vm: destroy: retry to gracefully destroy .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I513b16c5091cb22313dc18e2587ed6db386e982a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
