Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
gerrit-hooks has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
Dan Kenigsberg has uploaded a new change for review.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
net tests: take2: wait for a concurrent iptables call to finish
commit 9f7685f added --wait to iptable executions during tests, but not
to all of them.
This patch amends that.
Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f
Signed-off-by: Dan Kenigsberg
---
M tests/network/firewall.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/56871/1
diff --git a/tests/network/firewall.py b/tests/network/firewall.py
index ff4d97e..e2f7999 100644
--- a/tests/network/firewall.py
+++ b/tests/network/firewall.py
@@ -84,10 +84,10 @@
If cleaning up fails the affected test must fail too (with FirewallError).
"""
if _serviceRunning('iptables'):
-_execCmdChecker([_IPTABLES_BINARY.cmd, '-D', 'INPUT', '-i',
+_execCmdChecker([_IPTABLES_BINARY.cmd, '--wait', '-D', 'INPUT', '-i',
iface, '-p', 'udp', '--sport', '68', '--dport',
'67', '-j', 'ACCEPT']) # DHCPv4
-_execCmdChecker([_IPTABLES_BINARY.cmd, '-D', 'INPUT', '-i',
+_execCmdChecker([_IPTABLES_BINARY.cmd, '--wait', '-D', 'INPUT', '-i',
iface, '-p', 'udp', '--sport', '546', '--dport',
'547', '-j', 'ACCEPT']) # DHCPv6
elif _serviceRunning('firewalld'):
--
To view, visit https://gerrit.ovirt.org/56871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
Edward Haas has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Convert valid to read-only property
Liron Aravot has posted comments on this change. Change subject: monitor: Convert valid to read-only property .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
Edward Haas has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 1: Verified+1 Passes functional tests on Centos7 -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: small test improvement
Shahar Havivi has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Detect VM with snapshots
Shahar Havivi has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 4: we need to make sure that Libvirt API this is working on rhel 5.x which importing Libvirt Xen to vdsm -- To view, visit https://gerrit.ovirt.org/56574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...
Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/53214/11/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 48: # Configurators Interface: Line 49: # Line 50: # Default implementation follows; Line 51: # Line 52: > We do not need this change Done Line 53: def _getrequires(module): Line 54: """Return a set of module names required by this module. Line 55: Line 56: Those modules will be included even if not provided in --module. -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...
gerrit-hooks has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 12:
(3 comments)
except some minor notes its +1
https://gerrit.ovirt.org/#/c/53214/12/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:
Line 46:logUtils.py \
Line 47:m2cutils.py \
Line 48:machinetype.py \
Line 49:momIF.py \
Line 50:module_loader.py \
I think m is after d
Line 51:netconfpersistence.py \
Line 52:numa.py \
Line 53:osinfo.py \
Line 54:panic.py \
https://gerrit.ovirt.org/#/c/53214/12/tests/module_loader_test.py
File tests/module_loader_test.py:
Line 39: def test_import_modules(self, files, expected_modules):
Line 40: with namedTemporaryDir() as path:
Line 41: for f in files:
Line 42: utils.touchFile(os.path.join(path, f))
Line 43: utils.touchFile(os.path.join(path, '__init__.py'))
you can touch __init__.py only once
Line 44: result = module_loader.load_modules(path)
Line 45:
Line 46: result = frozenset(result.keys())
Line 47: expected = frozenset(expected_modules)
https://gerrit.ovirt.org/#/c/53214/12/vdsm.spec.in
File vdsm.spec.in:
Line 1120: %{python_sitelib}/%{vdsm_name}/kernelconfig.py*
Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py*
Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py*
should be here
Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py*
Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py*
Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py*
Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py*
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
gerrit-hooks has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 17: * #1195208::Update tracker: OK * Set MODIFIED::bug 1195208#1195208IGNORE, not all related patches are closed, check 52336 -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: add Transaction() to netconfpersistence .. net: add Transaction() to netconfpersistence This patch introduces Transaction() class/context manager to netconfpersistence.py. It will be used as a rollback trigger for OVS switch and could also replace unified rollback mechanism in legacy switch. Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/56149 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/netconfpersistence.py M tests/network/conf_persistence_test.py 2 files changed, 91 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
Dan Kenigsberg has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 16: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
gerrit-hooks has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 13: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py
gerrit-hooks has posted comments on this change. Change subject: storage: add tests for Mount.isMounted in mount.py .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
gerrit-hooks has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: streamline getting domain mountpoint
gerrit-hooks has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py
Idan Shaby has posted comments on this change. Change subject: storage: add tests for Mount.isMounted in mount.py .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56704/2/tests/mountTests.py
File tests/mountTests.py:
Line 193: mountpoint = "/mnt/mountpoint"
Line 194: with fake_mounts([b"%s %s nfs defaults 0 0" %
Line 195: (link_to_file, mountpoint)]):
Line 196: mnt = mount.Mount(link_to_file, mountpoint)
Line 197: self.assertTrue(mnt.isMounted())
> This keeps the file open until we finish the test, while we don't care abou
Nice, thanks.
Line 198:
Line 199:
Line 200: class IterMountsPerfTests(TestCaseBase):
Line 201: line_fmt = ('%(fs_spec)s\t%(fs_file)s\t%(fs_vfstype)s'
--
To view, visit https://gerrit.ovirt.org/56704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...
gerrit-hooks has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: macspoof hook: README: help adding the custom property
Edward Haas has posted comments on this change.
Change subject: macspoof hook: README: help adding the custom property
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56015/2/vdsm_hooks/macspoof/README
File vdsm_hooks/macspoof/README:
PS2, Line 12: Custom property for a specific vNIC in a VM:
: sudo engine-config -g CustomDeviceProperties
: shows the current value of CustomDeviceProperties. It's content
may look like
:
{type=interface;prop={property_name1=regexp1;property_name2=regexp2}}
: add "ifacemacspoof=^(true|false)$" to the semicolon-separated
list of
: properties and set
: sudo engine-config -s
"CustomDeviceProperties={type=interface;prop={somthing_you_had_before=regexp;ifacemacspoof=^(true|false)$}}"
How about this?
Custom property for a specific vNIC in a VM:
Check current value of CustomDeviceProperties:
sudo engine-config -g CustomDeviceProperties
It's content may look like:
{type=interface;prop={property_name1=regexp1;property_name2=regexp2}}
Update CustomDeviceProperties and append "ifacemacspoof=^(true|false)$" to
the existing value:
sudo engine-config -s
"CustomDeviceProperties={type=interface;prop={property_name1=regexp1;property_name2=regexp2;ifacemacspoof=^(true|false)$}}"
--
To view, visit https://gerrit.ovirt.org/56015
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7edb61612d5af913ec34d6077a0fa49fcc6ce63
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test both ssl and m2c
Nir Soffer has restored this change. Change subject: tests: Test both ssl and m2c .. Restored -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Refine error handling in getDevicesVisibility
Nir Soffer has restored this change. Change subject: hsm: Refine error handling in getDevicesVisibility .. Restored -- To view, visit https://gerrit.ovirt.org/39305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I2382986e886210e921d005dfcb0d4c479b87174d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Pep8ize function name
Nir Soffer has restored this change. Change subject: hsm: Pep8ize function name .. Restored -- To view, visit https://gerrit.ovirt.org/39306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I54715971378319a8501a49cb89b24f27e50a07f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Fail loudly if called with unexpected input
Nir Soffer has restored this change. Change subject: lvm: Fail loudly if called with unexpected input .. Restored -- To view, visit https://gerrit.ovirt.org/37329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: If9e6754d4aa2efaf894a9309cfaa4595d710063b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing generationID from clientIF
gerrit-hooks has posted comments on this change. Change subject: Removing generationID from clientIF .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecdf9e15dbc7aaf8a93d0b221b014ba2d5870d3f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing generationID from clientIF
Nir Soffer has submitted this change and it was merged. Change subject: Removing generationID from clientIF .. Removing generationID from clientIF Originally generationID was added as an element to getVdsStats to monitor vdsmd restarts in commit 537012b5c, Engine never actually used it. Change-Id: Iecdf9e15dbc7aaf8a93d0b221b014ba2d5870d3f Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/56475 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg Reviewed-by: Piotr Kliczewski --- M lib/api/vdsmapi-schema.json M vdsm/API.py M vdsm/clientIF.py 3 files changed, 1 insertion(+), 6 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecdf9e15dbc7aaf8a93d0b221b014ba2d5870d3f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move the host stats dict creation to host module
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Move the host stats dict creation to host module
..
Move the host stats dict creation to host module
This work is part of reporting the metric of host stats. This patch help
to centerelize the code around host capabilities.
Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/host.py
M vdsm/API.py
2 files changed, 174 insertions(+), 157 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/56874/1
diff --git a/lib/vdsm/host.py b/lib/vdsm/host.py
index 1cf633a..5318ce6 100644
--- a/lib/vdsm/host.py
+++ b/lib/vdsm/host.py
@@ -20,15 +20,23 @@
from __future__ import absolute_import
+import errno
import os
import logging
-from vdsm.utils import memoized
+import time
+from vdsm import cpuarch
+from vdsm import hooks
+from vdsm import utils
+from vdsm.config import config
+from vdsm.define import Kbytes, Mbytes
+from vdsm.virt import hoststats
+from vdsm.virt import vmstatus
+from vdsm.virt import sampling
from .commands import execCmd
from . import constants
-from . import cpuarch
-@memoized
+@utils.memoized
def uuid():
host_UUID = None
@@ -65,3 +73,161 @@
logging.error("Error retrieving host UUID", exc_info=True)
return host_UUID
+
+
+def _readSwapTotalFree():
+meminfo = utils.readMemInfo()
+return meminfo['SwapTotal'] / 1024, meminfo['SwapFree'] / 1024
+
+
+# take a rough estimate on how much free mem is available for new vm
+# memTotal = memFree + memCached + mem_used_by_non_qemu + resident .
+# simply returning (memFree + memCached) is not good enough, as the
+# resident set size of qemu processes may grow - up to memCommitted.
+# Thus, we deduct the growth potential of qemu processes, which is
+# (memCommitted - resident)
+
+def _memCommitted(cif):
+"""
+Return the amount of memory (Mb) committed for VMs
+"""
+committed = 0
+for v in cif.vmContainer.values():
+committed += v.memCommitted
+return committed
+
+
+def _memAvailable(cif):
+"""
+Return an approximation of available memory for new VMs.
+"""
+memCommitted = _memCommitted(cif)
+resident = 0
+for v in cif.vmContainer.values():
+if v.conf['pid'] == '0':
+continue
+try:
+with open('/proc/' + v.conf['pid'] + '/statm') as statmfile:
+resident += int(statmfile.read().split()[1])
+except:
+pass
+resident *= cpuarch.PAGE_SIZE_BYTES
+meminfo = utils.readMemInfo()
+freeOrCached = (meminfo['MemFree'] +
+meminfo['Cached'] + meminfo['Buffers']) * Kbytes
+return freeOrCached + resident - memCommitted - \
+config.getint('vars', 'host_mem_reserve') * Mbytes
+
+
+def _memFree():
+"""
+Return the actual free mem on host.
+"""
+meminfo = utils.readMemInfo()
+return (meminfo['MemFree'] +
+meminfo['Cached'] + meminfo['Buffers']) * Kbytes
+
+
+def _countVms(cif):
+count = active = incoming = outgoing = 0
+for vmId, v in cif.vmContainer.items():
+try:
+count += 1
+status = v.lastStatus
+if status == vmstatus.UP:
+active += 1
+elif status == vmstatus.MIGRATION_DESTINATION:
+incoming += 1
+elif status == vmstatus.MIGRATION_SOURCE:
+outgoing += 1
+except:
+logging.error(vmId + ': Lost connection to VM')
+return count, active, incoming + outgoing, incoming, outgoing
+
+
+def _getHaInfo(haClient):
+"""
+Return Hosted Engine HA information for this host.
+"""
+i = {
+'configured': False,
+'active': False,
+'score': 0,
+'globalMaintenance': False,
+'localMaintenance': False,
+}
+if haClient:
+try:
+instance = haClient.HAClient()
+host_id = instance.get_local_host_id()
+
+# If a host id is available, consider HA configured
+if host_id:
+i['configured'] = True
+else:
+return i
+
+stats = instance.get_all_stats()
+if 0 in stats:
+i['globalMaintenance'] = stats[0].get(
+haClient.HAClient.GlobalMdFlags.MAINTENANCE, False)
+if host_id in stats:
+i['active'] = stats[host_id]['live-data']
+i['score'] = stats[host_id]['score']
+i['localMaintenance'] = stats[host_id]['maintenance']
+except IOError as ex:
+if ex.errno == errno.ENOENT:
+logging.error(
+("failed to retrieve Hosted Engine HA score '{0}'"
+ "Is the Hosted Engine setup finished?")
+.format(str(ex))
+)
+else:
+l
Change in vdsm[master]: Move the host stats dict creation to host module
gerrit-hooks has posted comments on this change. Change subject: Move the host stats dict creation to host module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt
Shahar Havivi has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/55797/5/configure.ac
File configure.ac:
Line 376: AC_OUTPUT([
Line 377: Makefile
Line 378: client/Makefile
Line 379: contrib/Makefile
Line 380: helpers/Makefile
> missing tab
Done
Line 381: init/Makefile
Line 382: init/systemd/Makefile
Line 383: lib/Makefile
Line 384: lib/vdsm/Makefile
https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line 73: sys.stdout.flush()
Line 74:
Line 75:
Line 76: def volume_progress(op, done):
Line 77: while op.done < op.size:
> op.size may be None, causing the progress thread to crash (see vdms log for
Done
Line 78: progress = op.done * 100 // op.size
Line 79: write_progress(progress)
Line 80: if done.wait(1):
Line 81: break
Line 108: with progress(op):
Line 109: op.run()
Line 110: finally:
Line 111: try:
Line 112: # TODO: remove that after libvirt answer???
> Actually we need the try block so we don't hide the real error raise before
we need the first try but not the one around the finish
Line 113: stream.finish()
Line 114: except Exception as ex:
Line 115: write_error(str(ex))
Line 116:
PS5, Line 129: options = parse_arguments()
:
: con = libvirtconnection.open_connection(options.uri,
: options.username,
: get_password())
:
: diskno = 1
: disksitems = len(options.source)
: bufsize = int(options.bufsize)
: write_output('preparing for copy')
: for item in itertools.izip(options.source, options.dest):
: vol = con.storageVolLookupByPath(item[0])
: download_volume(vol, item[1], diskno, disksitems, bufsize,
options.verbose)
: diskno = diskno + 1
: write_output('Finishing off')
> please wrap this in a main() function, like I commented few versions ago.
Done
Line 140: vol = con.storageVolLookupByPath(item[0])
Line 141: download_volume(vol, item[1], diskno, disksitems, bufsize,
options.verbose)
Line 142: diskno = diskno + 1
Line 143: write_output('Finishing off')
Line 144
> call the new main() function using this idiom
Done
--
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt
gerrit-hooks has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt
gerrit-hooks has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py
Nir Soffer has posted comments on this change. Change subject: storage: add tests for Mount.isMounted in mount.py .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py
gerrit-hooks has posted comments on this change. Change subject: storage: add tests for Mount.isMounted in mount.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py
Nir Soffer has submitted this change and it was merged. Change subject: storage: add tests for Mount.isMounted in mount.py .. storage: add tests for Mount.isMounted in mount.py Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c Signed-off-by: Idan Shaby Reviewed-on: https://gerrit.ovirt.org/56704 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M tests/mountTests.py 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/56704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Avoid stale lvs
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Avoid stale lvs
..
blockSD: Avoid stale lvs
When connecting to iSCSI storage, all lvs are automatically activate -
this seems to be new behavior introduced in during EL7 development that
we missed. This creates huge amount of stale devices that are not used
by anyone, but slow down significantly lvm commands.
Even worse, active lv may not reflect the real mapping on storage when
we start to use it, leading to unneeded pausing of vms, or even to data
corruption.
Additionally, when storage domain is deactivated, we do not deactivate
lvs, leaving around stale devices.
This patch introduces new life cycle methods to storage domain:
- setup called when storage domain monitor produce the storage
domain object, before starting to monitor the domain.
- teardown called when storage domain monitor has finished.
The BlockStorageDomain implementation deactivate unused lvs in both
setup and teardown to avoid stale devices.
Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e
Bug-Url: https://bugzilla.redhat.com/1331978
Signed-off-by: Nir Soffer
---
M vdsm/storage/blockSD.py
M vdsm/storage/lvm.py
M vdsm/storage/monitor.py
M vdsm/storage/sd.py
4 files changed, 78 insertions(+), 28 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/56876/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 3c7c290..1a513bf 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -821,6 +821,24 @@
self._registerResourceNamespaces()
self._lastUncachedSelftest = 0
+# Life cycle
+
+def setup(self):
+"""
+Ensure that unused normal lvs are deactivated, avoiding stale devices.
+"""
+log.debug("Deactivating domain %s normal lvs", self.sdUUID)
+lvm.deactivateUnusedLVs(self.sdUUID, refreshlvs=SPECIAL_LVS)
+
+def teardown(self):
+"""
+Ensure that all lvs are deactivated, avoiding stale devices.
+"""
+log.debug("Deactivating domain %s lvs", self.sdUUID)
+lvm.deactivateUnusedLVs(self.sdUUID)
+
+# Other
+
@property
def logBlkSize(self):
return self._manifest.logBlkSize
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 7a2ca2f..ae6d288 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -651,36 +651,38 @@
refreshlvs = set(refreshlvs)
for vg in _lvminfo.getAllVgs():
-deactivate = []
-refresh = []
+deactivateUnusedLVs(vg.name, refreshlvs=refreshlvs)
-for lv in _lvminfo.getLv(vg.name):
-if lv.active:
-if lv.name in refreshlvs:
-refresh.append(lv.name)
-elif lv.opened:
-log.debug("Skipping open lv: vg=%s lv=%s", vg.name,
- lv.name)
-else:
-deactivate.append(lv.name)
-if deactivate:
-log.info("Deactivating lvs: vg=%s lvs=%s", vg.name, deactivate)
-try:
-_setLVAvailability(vg.name, deactivate, "n")
-except se.CannotDeactivateLogicalVolume:
-log.error("Error deactivating lvs: vg=%s lvs=%s", vg.name,
- deactivate)
-# Some lvs are inactive now
-_lvminfo._invalidatelvs(vg.name, deactivate)
+def deactivateUnusedLVs(vgname, refreshlvs=()):
+deactivate = []
+refresh = []
-if refresh:
-log.info("Refreshing lvs: vg=%s lvs=%s", vg.name, refresh)
-try:
-refreshLVs(vg.name, refresh)
-except se.LogicalVolumeRefreshError:
-log.error("Error refreshing lvs: vg=%s lvs=%s", vg.name,
- refresh)
+for lv in _lvminfo.getLv(vgname):
+if lv.active:
+if lv.name in refreshlvs:
+refresh.append(lv.name)
+elif lv.opened:
+log.debug("Skipping open lv: vg=%s lv=%s", vgname, lv.name)
+else:
+deactivate.append(lv.name)
+
+if deactivate:
+log.info("Deactivating lvs: vg=%s lvs=%s", vgname, deactivate)
+try:
+_setLVAvailability(vgname, deactivate, "n")
+except se.CannotDeactivateLogicalVolume:
+log.error("Error deactivating lvs: vg=%s lvs=%s", vgname,
+ deactivate)
+# Some lvs are inactive now
+_lvminfo._invalidatelvs(vgname, deactivate)
+
+if refresh:
+log.info("Refreshing lvs: vg=%s lvs=%s", vgname, refresh)
+try:
+refreshLVs(vgname, refresh)
+except se.LogicalVolumeRefreshError:
+log.error("Error refreshing lvs: vg=%s lvs=%s", vgname, refresh)
def invalidateCache():
diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index b4a0846.
Change in vdsm[master]: blockSD: Avoid stale lvs
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check Product::#1331978::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: Verified-1 * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check Product::#1331978::OK, Correct classification oVirt * Check TM::#1331978::ERROR, wrong target milestone for stable branch, --- should match ^.*3.6.* * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/56877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Avoid stale lvs
..
blockSD: Avoid stale lvs
When connecting to iSCSI storage, all lvs are automatically activate -
this seems to be new behavior introduced in during EL7 development that
we missed. This creates huge amount of stale devices that are not used
by anyone, but slow down significantly lvm commands.
Even worse, active lv may not reflect the real mapping on storage when
we start to use it, leading to unneeded pausing of vms, or even to data
corruption.
Additionally, when storage domain is deactivated, we do not deactivate
lvs, leaving around stale devices.
This patch introduces new life cycle methods to storage domain:
- setup called when storage domain monitor produce the storage
domain object, before starting to monitor the domain.
- teardown called when storage domain monitor has finished.
The BlockStorageDomain implementation deactivate unused lvs in both
setup and teardown to avoid stale devices.
Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e
Bug-Url: https://bugzilla.redhat.com/1331978
Signed-off-by: Nir Soffer
---
M vdsm/storage/blockSD.py
M vdsm/storage/lvm.py
M vdsm/storage/monitor.py
M vdsm/storage/sd.py
4 files changed, 78 insertions(+), 28 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/56877/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 8d953e0..362d0ff 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -468,6 +468,24 @@
self._registerResourceNamespaces()
self._lastUncachedSelftest = 0
+# Life cycle
+
+def setup(self):
+"""
+Ensure that unused normal lvs are deactivated, avoiding stale devices.
+"""
+log.debug("Deactivating domain %s normal lvs", self.sdUUID)
+lvm.deactivateUnusedLVs(self.sdUUID, refreshlvs=SPECIAL_LVS)
+
+def teardown(self):
+"""
+Ensure that all lvs are deactivated, avoiding stale devices.
+"""
+log.debug("Deactivating domain %s lvs", self.sdUUID)
+lvm.deactivateUnusedLVs(self.sdUUID)
+
+# Other
+
@property
def logBlkSize(self):
return self._manifest.logBlkSize
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index aab4bc6..8591923 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -649,36 +649,38 @@
refreshlvs = set(refreshlvs)
for vg in _lvminfo.getAllVgs():
-deactivate = []
-refresh = []
+deactivateUnusedLVs(vg.name, refreshlvs=refreshlvs)
-for lv in _lvminfo.getLv(vg.name):
-if lv.active:
-if lv.name in refreshlvs:
-refresh.append(lv.name)
-elif lv.opened:
-log.debug("Skipping open lv: vg=%s lv=%s", vg.name,
- lv.name)
-else:
-deactivate.append(lv.name)
-if deactivate:
-log.info("Deactivating lvs: vg=%s lvs=%s", vg.name, deactivate)
-try:
-_setLVAvailability(vg.name, deactivate, "n")
-except se.CannotDeactivateLogicalVolume:
-log.error("Error deactivating lvs: vg=%s lvs=%s", vg.name,
- deactivate)
-# Some lvs are inactive now
-_lvminfo._invalidatelvs(vg.name, deactivate)
+def deactivateUnusedLVs(vgname, refreshlvs=()):
+deactivate = []
+refresh = []
-if refresh:
-log.info("Refreshing lvs: vg=%s lvs=%s", vg.name, refresh)
-try:
-refreshLVs(vg.name, refresh)
-except se.LogicalVolumeRefreshError:
-log.error("Error refreshing lvs: vg=%s lvs=%s", vg.name,
- refresh)
+for lv in _lvminfo.getLv(vgname):
+if lv.active:
+if lv.name in refreshlvs:
+refresh.append(lv.name)
+elif lv.opened:
+log.debug("Skipping open lv: vg=%s lv=%s", vgname, lv.name)
+else:
+deactivate.append(lv.name)
+
+if deactivate:
+log.info("Deactivating lvs: vg=%s lvs=%s", vgname, deactivate)
+try:
+_setLVAvailability(vgname, deactivate, "n")
+except se.CannotDeactivateLogicalVolume:
+log.error("Error deactivating lvs: vg=%s lvs=%s", vgname,
+ deactivate)
+# Some lvs are inactive now
+_lvminfo._invalidatelvs(vgname, deactivate)
+
+if refresh:
+log.info("Refreshing lvs: vg=%s lvs=%s", vgname, refresh)
+try:
+refreshLVs(vgname, refresh)
+except se.LogicalVolumeRefreshError:
+log.error("Error refreshing lvs: vg=%s lvs=%s", vgname, refresh)
def invalidateCache():
diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index 25067d2.
Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: This is not merge on master yet, but I want to get this tested by the community. -- To view, visit https://gerrit.ovirt.org/56877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed relative imports to absolute imports
gerrit-hooks has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf42bbe589b1e18b789ad8e3137d320e3a3966a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: Verified+1 Tested: - start vdsm - stop vdsm - deactivate storage domain - activate storage domain - put host to maintenance - activate host -- To view, visit https://gerrit.ovirt.org/56877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Avoid stale lvs
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: Verified+1 Tested: - start vdsm - stop vdsm - deactivate storage domain - activate storage domain - put host to maintenance - activate host -- To view, visit https://gerrit.ovirt.org/56876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check Product::#1331978::OK, Correct classification oVirt * Check TM::#1331978::ERROR, wrong target milestone for stable branch, --- should match ^.*3.6.* * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/56877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Avoid stale lvs
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check Product::#1331978::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
gerrit-hooks has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move the host stats dict creation to host module
gerrit-hooks has posted comments on this change. Change subject: Move the host stats dict creation to host module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed relative imports to absolute imports
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG Commit Message: PS2, Line 10: can't handle relative imports. could you doublecheck this? my gut feeling is that using the second arg of https://docs.python.org/3.1/library/importlib.html#importlib.import_module should help. -- To view, visit https://gerrit.ovirt.org/56607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf42bbe589b1e18b789ad8e3137d320e3a3966a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed relative imports to absolute imports
Irit Goihman has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG Commit Message: PS2, Line 10: can't handle relative imports. > could you doublecheck this? my gut feeling is that using the second arg of I'm still checking it. It can handle relative imports, not in the way it's implemented in the code right now. -- To view, visit https://gerrit.ovirt.org/56607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf42bbe589b1e18b789ad8e3137d320e3a3966a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move the host stats dict creation to host module
Nir Soffer has posted comments on this change.
Change subject: Move the host stats dict creation to host module
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56874/2/lib/vdsm/host.py
File lib/vdsm/host.py:
Line 22:
Line 23: import errno
Line 24: import os
Line 25: import logging
Line 26: import time
Please separate the standard library imports from vdsm imports and current
package imports:
Line 27: from vdsm import cpuarch
Line 28: from vdsm import hooks
Line 29: from vdsm import utils
Line 30: from vdsm.config import config
Line 30: from vdsm.config import config
Line 31: from vdsm.define import Kbytes, Mbytes
Line 32: from vdsm.virt import hoststats
Line 33: from vdsm.virt import vmstatus
Line 34: from vdsm.virt import sampling
These imports mean we are doing something wrong - why do we need to depend on
the virt package for host stats?
Line 35: from .commands import execCmd
Line 36: from . import constants
Line 37:
Line 38:
Line 190: logging.exception("failed to retrieve Hosted Engine HA
info")
Line 191: return i
Line 192:
Line 193:
Line 194: def getStats(irs, cif, haClient):
Lets put the public apis on the top of the module, and the helpers on the
bottom.
Line 195: """
Line 196: Retreive host internal statistics
Line 197: """
Line 198: hooks.before_get_stats()
--
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: macspoof hook: README: help adding the custom property
gerrit-hooks has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7edb61612d5af913ec34d6077a0fa49fcc6ce63 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt
Nir Soffer has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt File helpers/kvm2ovirt: Line 108: with progress(op): Line 109: op.run() Line 110: finally: Line 111: try: Line 112: # TODO: remove that after libvirt answer??? > we need the first try but not the one around the finish If you don't cache exceptions in stream.finish, and both stream.finish and op.run raise, the error from stream.finish will hide the original error, making debuging much harder. Line 113: stream.finish() Line 114: except Exception as ex: Line 115: write_error(str(ex)) Line 116: -- To view, visit https://gerrit.ovirt.org/55797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...
Yaniv Bronhaim has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move hoststats code to host module
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Move hoststats code to host module
..
Move hoststats code to host module
The code shouldn't be under virt folder and we already have host module
which should gather host related sampling code.
Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/host.py
M lib/vdsm/virt/Makefile.am
M lib/vdsm/virt/periodic.py
M tests/hoststatsTests.py
M vdsm.spec.in
5 files changed, 283 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/56879/1
diff --git a/lib/vdsm/host.py b/lib/vdsm/host.py
index 7fc0b22..5efff1a 100644
--- a/lib/vdsm/host.py
+++ b/lib/vdsm/host.py
@@ -21,19 +21,38 @@
import errno
-import os
import logging
+import os
+import six
import time
from vdsm import cpuarch
from vdsm import hooks
+from vdsm import numa
from vdsm import utils
+from vdsm import v2v
from vdsm.config import config
from vdsm.define import Kbytes, Mbytes
-from vdsm.virt import hoststats
from vdsm.virt import vmstatus
from vdsm.virt import sampling
from .commands import execCmd
from . import constants
+
+JIFFIES_BOUND = 2 ** 32
+NETSTATS_BOUND = 2 ** 32
+
+_clock = utils.monotonic_time
+_start_time = 0
+
+
+def _elapsed_time():
+return _clock() - _start_time
+
+
+def initTimes(clock=utils.monotonic_time):
+global _clock
+global _start_time
+_clock = clock
+_start_time = _clock()
@utils.memoized
@@ -191,6 +210,247 @@
return i
+def _empty_stats():
+return {
+'cpuUser': 0.0,
+'cpuSys': 0.0,
+'cpuIdle': 100.0,
+'rxRate': 0.0, # REQUIRED_FOR: engine < 3.6
+'txRate': 0.0, # REQUIRED_FOR: engine < 3.6
+'cpuSysVdsmd': 0.0,
+'cpuUserVdsmd': 0.0,
+'elapsedTime': _elapsed_time(),
+}
+
+
+def produce(first_sample, last_sample):
+stats = _empty_stats()
+
+if first_sample is None:
+return stats
+
+stats.update(_get_interfaces_stats(first_sample, last_sample))
+
+interval = last_sample.timestamp - first_sample.timestamp
+
+jiffies = (
+last_sample.pidcpu.user - first_sample.pidcpu.user
+) % JIFFIES_BOUND
+stats['cpuUserVdsmd'] = jiffies / interval
+jiffies = (
+last_sample.pidcpu.sys - first_sample.pidcpu.sys
+) % JIFFIES_BOUND
+stats['cpuSysVdsmd'] = jiffies / interval
+
+jiffies = (
+last_sample.totcpu.user - first_sample.totcpu.user
+) % JIFFIES_BOUND
+stats['cpuUser'] = jiffies / interval / last_sample.ncpus
+jiffies = (
+last_sample.totcpu.sys - first_sample.totcpu.sys
+) % JIFFIES_BOUND
+stats['cpuSys'] = jiffies / interval / last_sample.ncpus
+stats['cpuIdle'] = max(0.0,
+ 100.0 - stats['cpuUser'] - stats['cpuSys'])
+stats['memUsed'] = last_sample.memUsed
+stats['anonHugePages'] = last_sample.anonHugePages
+stats['cpuLoad'] = last_sample.cpuLoad
+
+stats['diskStats'] = last_sample.diskStats
+stats['thpState'] = last_sample.thpState
+
+if _boot_time():
+stats['bootTime'] = _boot_time()
+
+stats['numaNodeMemFree'] = last_sample.numaNodeMem.nodesMemSample
+stats['cpuStatistics'] = _get_cpu_core_stats(
+first_sample, last_sample)
+
+stats['v2vJobs'] = v2v.get_jobs_status()
+return stats
+
+
+def _get_cpu_core_stats(first_sample, last_sample):
+interval = last_sample.timestamp - first_sample.timestamp
+
+def compute_cpu_usage(cpu_core, mode):
+first_core_sample = first_sample.cpuCores.getCoreSample(cpu_core)
+last_core_sample = last_sample.cpuCores.getCoreSample(cpu_core)
+if not first_core_sample or not last_core_sample:
+raise MissingSample()
+jiffies = (
+last_core_sample[mode] - first_core_sample[mode]
+) % JIFFIES_BOUND
+return ("%.2f" % (jiffies / interval))
+
+cpu_core_stats = {}
+for node_index, numa_node in six.iteritems(numa.topology()):
+cpu_cores = numa_node['cpus']
+for cpu_core in cpu_cores:
+try:
+user_cpu_usage = compute_cpu_usage(cpu_core, 'user')
+system_cpu_usage = compute_cpu_usage(cpu_core, 'sys')
+except MissingSample:
+# Only collect data when all required samples already present
+continue
+core_stat = {
+'nodeIndex': int(node_index),
+'cpuUser': user_cpu_usage,
+'cpuSys': system_cpu_usage,
+}
+core_stat['cpuIdle'] = (
+"%.2f" % max(0.0,
+ 100.0 -
+ float(core_stat['cpuUser']) -
+ float(core_stat['cpuSys'])))
+cpu_core_stats[str(cpu_core)] = core_stat
+return cpu_core_stats
+
+
+class MissingSample(Exception)
Change in vdsm[master]: Move hoststats code to host module
gerrit-hooks has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed relative imports to absolute imports
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf42bbe589b1e18b789ad8e3137d320e3a3966a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. net tests: take2: wait for a concurrent iptables call to finish commit 9f7685f added --wait to iptable executions during tests, but not to all of them. This patch amends that. Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/56871 Reviewed-by: Edward Haas Tested-by: Edward Haas Continuous-Integration: Jenkins CI --- M tests/network/firewall.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
Dan Kenigsberg has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish
gerrit-hooks has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ca11913ca909dbf8a2d692c235a9b71bcbea2f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Fail loudly if called with unexpected input
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Fail loudly if called with unexpected input .. Patch Set 4: Code-Review+1 But I'd prefer that this kind of validation take place much higher up, at the entrance to Vdsm. -- To view, visit https://gerrit.ovirt.org/37329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9e6754d4aa2efaf894a9309cfaa4595d710063b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 6:
(16 comments)
https://gerrit.ovirt.org/#/c/55797/6/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line 51: parser.add_argument('--source', dest='source', nargs='+',
required=True,
Line 52: help='Source remote volumes path')
Line 53: parser.add_argument('--dest', dest='dest', nargs='+',
required=True,
Line 54: help='Destination local volumes path')
Line 55: parser.add_argument('--bufsize', dest='bufsize', default=1048576,
add type=int
Line 56: help='Size of packets in bytes, default
1048676')
Line 57: parser.add_argument('--verbose', action='store_true',
Line 58: help='verbose output')
Line 59: return parser.parse_args(sys.argv)
Line 72: sys.stdout.write('(%d/100%%)\r' % progress)
Line 73: sys.stdout.flush()
Line 74:
Line 75:
Line 76: def volume_progress(op, done):
Add estimated_size argument
Line 77: while op.done < op.size:
Line 78: progress = op.done * 100 // op.size
Line 79: write_progress(progress)
Line 80: if done.wait(1):
Line 73: sys.stdout.flush()
Line 74:
Line 75:
Line 76: def volume_progress(op, done):
Line 77: while op.done < op.size:
op.size is None, we cannot use it, pass the estimated size as argument.
Line 78: progress = op.done * 100 // op.size
Line 79: write_progress(progress)
Line 80: if done.wait(1):
Line 81: break
Line 74:
Line 75:
Line 76: def volume_progress(op, done):
Line 77: while op.done < op.size:
Line 78: progress = op.done * 100 // op.size
progress = min(99, op.done * 100 // estimated_size)
Line 79: write_progress(progress)
Line 80: if done.wait(1):
Line 81: break
Line 82: write_progress(100)
Line 82: write_progress(100)
Line 83:
Line 84:
Line 85: @contextmanager
Line 86: def progress(op):
Add estimated_size argument, pass it to volume_progress thread
Line 87: done = threading.Event()
Line 88: th = concurrent.thread(volume_progress, args=(op, done))
Line 89: th.start()
Line 90: try:
Line 93: done.set()
Line 94: th.join()
Line 95:
Line 96:
Line 97: def download_volume(con, vol, dest, diskno, disks, bufsize, verbose):
remove diskno, disks, verbose.
Line 98: write_output('Copying disk %d/%d to %s' % (diskno, disks, dest))
Line 99: if verbose:
Line 100: write_output('>>> disk %d, capacity: %d allocation %d' %
Line 101: (diskno, vol.info()[1], vol.info()[2]))
Line 97: def download_volume(con, vol, dest, diskno, disks, bufsize, verbose):
Line 98: write_output('Copying disk %d/%d to %s' % (diskno, disks, dest))
Line 99: if verbose:
Line 100: write_output('>>> disk %d, capacity: %d allocation %d' %
Line 101: (diskno, vol.info()[1], vol.info()[2]))
Move both to main loop
Line 102:
Line 103: stream = con.newStream()
Line 104: try:
Line 105: vol.download(stream, 0, 0, 0)
Line 107: op = directio.Receive(dest, sr, buffersize=bufsize)
Line 108: with progress(op):
Line 109: op.run()
Line 110: finally:
Line 111: stream.finish()
If op.run raises, and stream.finish raises, the error from stream finish will
hide the original error making debugging much harder.
I think we can simplify this by removing the all the try blocks here - if
op.run fails, we don't care about finish since we are dieing anyway.
Line 112:
Line 113:
Line 114: def get_password(options):
Line 115: ret = ''
Line 111: stream.finish()
Line 112:
Line 113:
Line 114: def get_password(options):
Line 115: ret = ''
A better way would be:
if not options.password_file:
return '''
write output...
with open(...) as f:
return f.read()
Line 116: if options.password_file:
Line 117: if options.verbose:
Line 118: write_output('>>> Reading password from file %s' %
Line 119: options.password_file)
Line 116: if options.password_file:
Line 117: if options.verbose:
Line 118: write_output('>>> Reading password from file %s' %
Line 119: options.password_file)
Line 120: with open(options.password_file, 'r') as fd:
fd is a bad name file object, this is the common name for a file descriptor.
The common name for this temporary is "f"
Line 121: ret = fd.read()
Line 122: return ret
Line 123:
Line 124: def main():
Line 121: ret = fd.read()
Line 122: return ret
Line 123:
Line 124: def main():
Line 125: options = parse_arguments()
Decide on the name - options or arguments?
Line 126:
Line 127: con = libvirtconnection.open_connection(opti
Change in vdsm[master]: Move hoststats code to host module
Nir Soffer has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 1: You move here lot of code, but I don't see the deleted code in the original module -- To view, visit https://gerrit.ovirt.org/56879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: streamline getting domain mountpoint
Nir Soffer has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 3: Can you verify? I want to take this first. -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks
Nir Soffer has posted comments on this change. Change subject: net tests: Clean netinfo_test from uneeded mocks .. Patch Set 4: Dan, ping -- To view, visit https://gerrit.ovirt.org/55898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: small test improvement
Nir Soffer has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 1: OK, we will improve this later. -- To view, visit https://gerrit.ovirt.org/56694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: small test improvement
gerrit-hooks has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: small test improvement
Nir Soffer has submitted this change and it was merged. Change subject: v2v: small test improvement .. v2v: small test improvement Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f Signed-off-by: Tomáš Golembiovský Reviewed-on: https://gerrit.ovirt.org/56694 Reviewed-by: Francesco Romani Reviewed-by: Milan Zamazal Continuous-Integration: Jenkins CI Reviewed-by: Shahar Havivi --- M tests/v2vTests.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Tomas Golembiovsky: Verified Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...
Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py File lib/vdsm/module_loader.py: PS13, Line 34: if not hasattr(modules[module_name], 'name'): : setattr(modules[module_name], 'name', module_name) Can we please control this with a flag? https://gerrit.ovirt.org/#/c/53214/13/tests/module_loader_test.py File tests/module_loader_test.py: PS13, Line 40: with namedTemporaryDir() as path: : for f in files: : utils.touchFile(os.path.join(path, f)) : utils.touchFile(os.path.join(path, '__init__.py')) What about moving this to a separated contextmanager? So we can use it like this: with _setup_test_modules as path: result = module_loader.load_modules(path) https://gerrit.ovirt.org/#/c/53214/13/vdsm.spec.in File vdsm.spec.in: Line 1191 Line 1192 Line 1193 Line 1194 Line 1195 Please do not fix this here, it will cause uneeded conflicts with other changes currently in progress. -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks
Dan Kenigsberg has posted comments on this change. Change subject: net tests: Clean netinfo_test from uneeded mocks .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks
gerrit-hooks has posted comments on this change. Change subject: net tests: Clean netinfo_test from uneeded mocks .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: Clean netinfo_test from uneeded mocks .. net tests: Clean netinfo_test from uneeded mocks Removing mockey patches that are no longer needed. They have been probably left in the tests unintentionally after the production code has been modified. This presents a general maintanance issue with mocks that do not varify their usage. Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/55898 Reviewed-by: Nir Soffer Reviewed-by: Yaniv Bronhaim Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/network/netinfo_test.py 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/55898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: macspoof hook: README: help adding the custom property
Edward Haas has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7edb61612d5af913ec34d6077a0fa49fcc6ce63 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding reportStats
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding reportStats
..
Adding reportStats
Adding function that uses statsd to report internal host info. This will
be called after each sampling for now.
Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/host.py
M lib/vdsm/virt/sampling.py
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/56880/1
diff --git a/lib/vdsm/host.py b/lib/vdsm/host.py
index 0752663..6578872 100644
--- a/lib/vdsm/host.py
+++ b/lib/vdsm/host.py
@@ -24,6 +24,7 @@
import logging
import os
import six
+import statsd
import time
from vdsm import cpuarch
from vdsm import hooks
@@ -42,6 +43,7 @@
_clock = utils.monotonic_time
_start_time = 0
+_current_stats = {}
def _elapsed_time():
@@ -408,6 +410,8 @@
"""
Retreive host internal statistics
"""
+global _current_stats
+
hooks.before_get_stats()
stats = {}
@@ -443,4 +447,23 @@
stats['haScore'] = stats['haStats']['score']
stats = hooks.after_get_stats(stats)
+_current_stats = stats
return stats
+
+
+def reportStats():
+"""
+Send gauge values to statsd
+The format
+"""
+report = statsd.Gauge(".host." + uuid())
+report.send('memAvailable', _current_stats['memAvailable'])
+report.send('memCommitted', _current_stats['memCommitted'])
+report.send('memFree', _current_stats['memFree'])
+report.send('swapTotal', _current_stats['swapTotal'])
+report.send('swapFree', _current_stats['swapFree'])
+report.send('vmActive', _current_stats['vmActive'])
+report.send('vmCount', _current_stats['vmCount'])
+report.send('vmMigrating', _current_stats['vmMigrating'])
+report.send('incomingVmMigrations', _current_stats['incomingVmMigrations'])
+report.send('outgoingVmMigrations', _current_stats['outgoingVmMigrations'])
diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 5801099..74b0ef3 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -32,6 +32,7 @@
import time
from vdsm.constants import P_VDSM_RUN, P_VDSM_CLIENT_LOG
+from vdsm import host
from vdsm import ipwrapper
from vdsm import numa
from vdsm.netinfo import nics, bonding, vlans
@@ -547,6 +548,7 @@
sample = HostSample(self._pid)
self._samples.append(sample)
second_last = self._samples.last(nth=2)
+host.reportStats()
if second_last is None:
self._CONNLOG.debug('%s', sample.to_connlog())
else:
--
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding reportStats
gerrit-hooks has posted comments on this change. Change subject: Adding reportStats .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move hoststats code to host module
gerrit-hooks has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
Hello Nir Soffer, Adam Litke, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/56881 to review the following change. Change subject: Don't prepare image with illegal volumes .. Don't prepare image with illegal volumes The irs verb 'prepareImage' is used only by clientIF when preparing the host to start a VM. Currently, this operation succeeds even if one or more of the volumes in the image is illegal. Since we should never permit a VM to start with an illegal disk, check for this and report an error if any illegal volumes are found. The pivot stage of a live merge operation depends on this behavior to ensure that a VM is not accidentally started using a stale leaf volume. Bug-Url: https://bugzilla.redhat.com/1331572 Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/39302 Reviewed-by: Greg Padgett Reviewed-by: Allon Mureinik Reviewed-by: Francesco Romani Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI --- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/56881/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 3a04424..1880da8 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3221,6 +3221,11 @@ if leafUUID not in imgVolumes: raise se.VolumeDoesNotExist(leafUUID) +for volUUID in imgVolumes: +legality = dom.produceVolume(imgUUID, volUUID).getLegality() +if legality == volume.ILLEGAL_VOL: +raise se.prepareIllegalVolumeError(volUUID) + imgPath = dom.activateVolumes(imgUUID, imgVolumes) if spUUID and spUUID != sd.BLANK_UUID: runImgPath = dom.linkBCImage(imgPath, imgUUID) -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
Ala Hino has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
gerrit-hooks has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: * #1331572::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331572::OK, public bug * Check Product::#1331572::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1331572::OK, correct target milestone ovirt-3.6.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Move netconfpersistence under vdsm.network
Dan Kenigsberg has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 2: Code-Review-1 (8 comments) boring ordering nits https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/netinfo/cache.py File lib/vdsm/netinfo/cache.py: Line 25: import errno Line 26: import six Line 27: Line 28: from ..ipwrapper import getLinks Line 29: from vdsm.network.netconfpersistence import RunningConfig seems odd here. please place on top of the in-package imports. Line 30: from ..netlink import link as nl_link Line 31: Line 32: from vdsm import netinfo Line 33: from .addresses import getIpAddrs, getIpInfo, is_ipv6_local_auto https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 31: from vdsm.config import config Line 32: from vdsm import commands Line 33: from vdsm import constants Line 34: from vdsm import hooks Line 35: from . import netconfpersistence now belongs to the next stanza Line 36: from vdsm import udevadm Line 37: from vdsm import ipwrapper Line 38: Line 39: from . canonicalize import canonicalize_networks, canonicalize_bondings https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/configurators/__init__.py File lib/vdsm/network/configurators/__init__.py: Line 21: import logging Line 22: from six.moves import configparser Line 23: Line 24: from vdsm.config import config Line 25: from vdsm.network.netconfpersistence import RunningConfig alphabetic order places this under vdsm.netlink Line 26: from vdsm import ipwrapper Line 27: from vdsm.netinfo import mtus Line 28: from vdsm.netlink import monitor Line 29: https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 45: NET_PATH) Line 46: from vdsm.netinfo.cache import ifaceUsed Line 47: from vdsm import sysctl Line 48: from vdsm import utils Line 49: from vdsm.network.netconfpersistence import RunningConfig, PersistentConfig alphabetize Line 50: from vdsm.netlink import monitor Line 51: Line 52: if utils.isOvirtNode(): Line 53: from ovirt.node.utils import fs as node_fs https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/configurators/iproute2.py File lib/vdsm/network/configurators/iproute2.py: Line 20: from __future__ import absolute_import Line 21: import logging Line 22: Line 23: from vdsm.netinfo import bonding, vlans, bridges, mtus, misc Line 24: from vdsm.netinfo.cache import ifaceUsed alphabetization required in a separate patch Line 25: from vdsm import ipwrapper Line 26: from vdsm.constants import EXT_BRCTL Line 27: from vdsm.ipwrapper import routeAdd, routeDel, ruleAdd, ruleDel, IPRoute2Error Line 28: from vdsm.network.netconfpersistence import RunningConfig https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/network/legacy_switch.py File lib/vdsm/network/legacy_switch.py: Line 27: Line 28: from vdsm.config import config Line 29: from vdsm import ipwrapper Line 30: from vdsm import kernelconfig Line 31: from . import netconfpersistence next stanza Line 32: from vdsm.netinfo import NET_PATH Line 33: from vdsm.netinfo import addresses Line 34: from vdsm.netinfo import bridges Line 35: from vdsm.netinfo import mtus https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/tool/unified_persistence.py File lib/vdsm/tool/unified_persistence.py: Line 21: import logging Line 22: Line 23: from .. import utils Line 24: from ..config import config Line 25: from vdsm.network.netconfpersistence import RunningConfig place above Line 26: from ..netinfo.cache import CachingNetInfo Line 27: from ..netinfo import misc, routes Line 28: from . import expose Line 29: from .upgrade import apply_upgrade https://gerrit.ovirt.org/#/c/56677/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 33: from vdsm import kernelconfig Line 34: from vdsm.ipwrapper import (routeExists, ruleExists, addrFlush, LinkType, Line 35: getLinks, routeShowTable, linkDel, linkSet, Line 36: addrAdd) Line 37: from vdsm.network.netconfpersistence import RunningConfig place lower Line 38: from vdsm.netinfo.bonding import BONDING_SLAVES, BONDING_MASTERS Line 39: from vdsm.netinfo.bridges import bridges Line 40: from vdsm.netinfo.misc import NET_CONF_PREF Line 41: from vdsm.netinfo.mtus import DEFAULT_MTU -- To view, visit https://gerrit.ovirt.org/56677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5325153a6462014d4b5e8300633d25757258d3c0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
Nir Soffer has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add virtual port to libvirt network def
Edward Haas has posted comments on this change. Change subject: net: add virtual port to libvirt network def .. Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/56828/3/lib/vdsm/network/configurators/libvirt.py File lib/vdsm/network/configurators/libvirt.py: PS3, Line 52: [] I don't think it belongs to this patch. https://gerrit.ovirt.org/#/c/56828/3/tests/network/conf_test.py File tests/network/conf_test.py: PS3, Line 160: testCreateNetXmlVirtualport Please do not use Camel Case for new methods/funcs PS3, Line 161: virtualport = "openvswitch" I think you can loose this variable, it will be readable without it. -- To view, visit https://gerrit.ovirt.org/56828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d081cb51d9f01eccbe28ced62e8bed07ac12396 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes
gerrit-hooks has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 8: * #1182088::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182088::OK, public bug * Check Product::#1182088::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes
Irit Goihman has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use libvirt flags to select capability
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: use libvirt flags to select capability .. hostdev: use libvirt flags to select capability hostdevListByCaps (or list_by_caps in hostdev module) filtered devices manually by inspecting their capability. This can be done on libvirt level to avoid parsing unwanted devices. Change-Id: Ia40fff8ba0bace1272666825d6c4fce18ac9a1f0 Bug-Url: https://bugzilla.redhat.com/1270581 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/56037 Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M lib/vdsm/hostdev.py M tests/hostdevTests.py M tests/vmfakelib.py 3 files changed, 30 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/56037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia40fff8ba0bace1272666825d6c4fce18ac9a1f0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use libvirt flags to select capability
gerrit-hooks has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 9: * #1270581::Update tracker: OK * Set MODIFIED::bug 1270581#1270581IGNORE, not all related patches are closed, check 55022 -- To view, visit https://gerrit.ovirt.org/56037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia40fff8ba0bace1272666825d6c4fce18ac9a1f0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: streamline getting domain mountpoint
gerrit-hooks has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 14: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
gerrit-hooks has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: streamline getting domain mountpoint
Idan Shaby has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: streamline getting domain mountpoint
gerrit-hooks has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: streamline getting domain mountpoint
Nir Soffer has submitted this change and it was merged. Change subject: storage: streamline getting domain mountpoint .. storage: streamline getting domain mountpoint When checking if a domain's mountpoint is mounted, the code used to add "/.." to the domain's path, counting on mount.isMounted() to normalize the path. This patch replaces this approach by simply using os.path.dirname. Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Signed-off-by: Idan Shaby Reviewed-on: https://gerrit.ovirt.org/56706 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI --- M vdsm/storage/glusterSD.py M vdsm/storage/nfsSD.py 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1d8b8fb7851dd4f6b18e7804518227760a3e277 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
Tal Nisan has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Code-Review-1 Wait with the merge, we need a different Bug-Url -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: get network switch type from libvirt
Edward Haas has posted comments on this change. Change subject: net: get network switch type from libvirt .. Patch Set 1: Code-Review-1 I am not clear why libvirt DB is considered 'actual' or real time info. To me, it is not better then our simple running config. In general, we would like to be independent of libvirt network DB, so in this spirit we better not add to it. If we would like to be more accurate (we are :)), we should check against ovs.netinfo, if the network appears there. ovs.netinfo should use running config and validate against ovsdb for the existence of the network. -- To view, visit https://gerrit.ovirt.org/56838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie733d39efa0fd40a81d3111d55fa19dde9a3c1b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: do not protect requests on client side
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 92 Line 93 Line 94 Line 95 Line 96 Why do we use Request for both client and server? it does not make sense. We should have a separate class for client request, and server request, each with the behavior that makes sense. client: - create from arguments - encode for the wire server: - create from wire format - decode from wire format - protect passwords Thoughts? -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
Idan Shaby has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 10: -Verified There've been too many rebases since the last time I verified. Marking as not verified until the next patch is reviewed, and then I'll verify them together. -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: do not protect requests on client side
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 99 Line 100 Line 101 Line 102 Line 103 Relevant only to server side Line 108 Line 109 Line 110 Line 111 Line 112 Relevant only to server side Line 125 Line 126 Line 127 Line 128 Line 129 Relevant only to client side Line 133 Line 134 Line 135 Line 136 Line 137 Relevant only to client side Line 137 Line 138 Line 139 Line 140 Line 141 Relevant only to server side -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
Ala Hino has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Verified-1 -1 for visibility: The code is perfect but bug Id is incorrect -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configure: add support for nosetests/python 3.5
Edward Haas has posted comments on this change. Change subject: configure: add support for nosetests/python 3.5 .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56083/3/configure.ac File configure.ac: Line 289: fi Line 290: Line 291: AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4]) Line 292: if test "x$PYTHON3_NOSE" = "x"; then Line 293: AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5]) > yes, and to do so I'll need to refresh my autoconf knowledge I think you actually need https://gerrit.ovirt.org/#/c/56533 to work, that should solve these problems. Unfortunately, there is a problem with that patch, but fixing it will make this patch unneeded. Line 294: fi Line 295: if test "x$PYTHON3_NOSE" = "x"; then Line 296: AC_MSG_ERROR([python3-nose not found]) Line 297: fi -- To view, visit https://gerrit.ovirt.org/56083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes
Tal Nisan has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: -Code-Review Please use this bug in the Bug-Url: https://bugzilla.redhat.com/1332038 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
