Change in vdsm[master]: v2v: Treat Xen specially after all.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: Treat Xen specially after all.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57431/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 993: try:
Line 994: ret = vm.hasCurrentSnapshot()
Line 995: except libvirt.libvirtError as e:
Line 996: if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT or \
Line 997: conn.getType() != 'Xen':
Well, if we expect that this on any driver but xen, and we never expect it on 
xen, better to skip the call on xen and fail loudly otherwise.

The generic check makes sense only if you don't care about the driver, and want 
to handle unsupported methods in a generic way.
Line 998: logging.exception('Error checking for existing 
snapshots.')
Line 999: # else: The snapshot related API is not implemented in all 
libvirt
Line 1000: #   drivers. It is missing e.g. in Xen. But we know that 
already,
Line 1001: #   so no need to log the exception.


-- 
To view, visit https://gerrit.ovirt.org/57431
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29befae33113f80a2011670c1edbff331becc72d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Do not give Xen a special treatment.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: Do not give Xen a special treatment.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57430/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 995: except libvirt.libvirtError as e:
Line 996: if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
Line 997: logging.exception('Error checking for existing 
snapshots.')
Line 998: # else: The snapshot related API is not implemented in all 
libvirt
Line 999: #   drivers. It is missing e.g. in Xen.
Look good if we don't care about the driver, and can work with any driver by 
ignoring the unimplemented method.
Line 1000: else:
Line 1001: params['has_snapshots'] = ret > 0
Line 1002: 
Line 1003: 


-- 
To view, visit https://gerrit.ovirt.org/57430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I597118940d42ee953d9cdc83bb44afd13b5e882a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 2:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Port vdsm.storage.check to python 3
..


Patch Set 6:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Convert valid to read-only property
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: monitor: Convert valid to read-only property
..


monitor: Convert valid to read-only property

Status.valid was a duplicate of Status.error. This could lead to
inconsistent state if one of the attributes is not synced with the
other. Now valid is a property based on Status.error.

Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/39088
Reviewed-by: Liron Aravot 
Continuous-Integration: Jenkins CI
---
M tests/storageMonitorTests.py
M vdsm/storage/monitor.py
2 files changed, 21 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 20:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Port vdsm.storage.check to python 3
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 37:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Add process helpers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Add process helpers
..


Patch Set 8:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a8e452ce2acd3aebdc76212a534e6d4a5638d9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: monitoring: Use new monitoring infrastructure
..

monitoring: Use new monitoring infrastructure

DomainMonitor is keeping now a checker object, providing path checking
services. The checker starts with the domain monitor is created, and
stopped when shutting down vdsm.

Monitor threads use the checker to start checking the monitoring path
during setupLoop, and stop checking when the thread is stopping.

Since path checker events are received on a different thread, creating
new status and updating it is done under a lock to races when evaluating
status changes.

Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Signed-off-by: Nir Soffer 
---
M vdsm/storage/monitor.py
1 file changed, 54 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/57432/1

diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index d86853c..169375d 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -26,6 +26,7 @@
 from vdsm import concurrent
 from vdsm import utils
 from vdsm.config import config
+from vdsm.storage import check
 
 from . import clusterlock
 from . import misc
@@ -129,8 +130,12 @@
 def __init__(self, interval):
 self._monitors = {}
 self._interval = interval
+# NOTE: This must be used in asynchronous mode to prevent blocking of
+# the checker event loop thread.
 self.onDomainStateChange = misc.Event(
-"Storage.DomainMonitor.onDomainStateChange")
+"Storage.DomainMonitor.onDomainStateChange", sync=False)
+self._checker = check.CheckService()
+self._checker.start()
 
 @property
 def domains(self):
@@ -165,7 +170,7 @@
 
 log.info("Start monitoring %s", sdUUID)
 monitor = MonitorThread(weakref.proxy(self), sdUUID, hostId,
-self._interval)
+self._interval, self._checker)
 monitor.poolDomain = poolDomain
 monitor.start()
 # The domain should be added only after it succesfully started
@@ -205,6 +210,7 @@
 """
 log.info("Shutting down domain monitors")
 self._stopMonitors(self._monitors.values(), shutdown=True)
+self._checker.stop()
 
 def _stopMonitors(self, monitors, shutdown=False):
 # The domain monitor issues events that might become raceful if
@@ -234,7 +240,7 @@
 
 class MonitorThread(object):
 
-def __init__(self, domainMonitor, sdUUID, hostId, interval):
+def __init__(self, domainMonitor, sdUUID, hostId, interval, checker):
 self.thread = concurrent.thread(self._run, logger=log.name)
 self.domainMonitor = domainMonitor
 self.stopEvent = threading.Event()
@@ -242,6 +248,8 @@
 self.sdUUID = sdUUID
 self.hostId = hostId
 self.interval = interval
+self.checker = checker
+self.lock = threading.Lock()
 self.monitoringPath = None
 # For backward compatibility, we must present a fake status before
 # collecting the first sample. The fake status is marked as
@@ -287,6 +295,7 @@
 finally:
 log.debug("Domain monitor for %s stopped (shutdown=%s)",
   self.sdUUID, self.wasShutdown)
+self._stopCheckingPath()
 if self._shouldReleaseHostId():
 self._releaseHostId()
 
@@ -322,6 +331,12 @@
 if self.domain is None:
 self._produceDomain()
 
+# This may fail even if the domain was produced. We will try again in
+# the next cycle.
+if self.monitoringPath is None:
+self.monitoringPath = self.domain.getMonitoringPath()
+self.checker.start_checking(self.monitoringPath, self._pathChecked)
+
 # The isIsoDomain assignment is deferred because the isoPrefix
 # discovery might fail (if the domain suddenly disappears) and we
 # could risk to never try to set it again.
@@ -331,9 +346,7 @@
 @utils.cancelpoint
 def _produceDomain(self):
 log.debug("Producing domain %s", self.sdUUID)
-domain = sdCache.produce(self.sdUUID)
-self.monitoringPath = domain.getMonitoringPath()
-self.domain = domain
+self.domain = sdCache.produce(self.sdUUID)
 
 @utils.cancelpoint
 def _setIsoDomainInfo(self):
@@ -362,28 +375,10 @@
 if self._shouldRefreshDomain():
 self._refreshDomain()
 
-if self._checkPathStatus():
-self._checkDomainStatus()
+self._checkDomainStatus()
 
 if self._shouldAcquireHostId():
 self._acquireHostId()
-
-@utils.cancelpoint
-def _checkPathStatus(self):
-# This may block for long time if the storage server is not accessible.
-# On overloaded machines we have seen this take up to 15 

Change in vdsm[master]: v2v: Treat Xen specially after all.

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Treat Xen specially after all.
..


Patch Set 1:

The cause of CI -1 seems unrelated to the change. Yum failed to install stuff 
from EPEL.

-- 
To view, visit https://gerrit.ovirt.org/57431
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29befae33113f80a2011670c1edbff331becc72d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Do not give Xen a special treatment.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Do not give Xen a special treatment.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I597118940d42ee953d9cdc83bb44afd13b5e882a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Treat Xen specially after all.

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: v2v: Treat Xen specially after all.
..

v2v: Treat Xen specially after all.

The condition in the exception handler may be too general and may hide
some unforeseen error cases in other drivers that we would like to know
about.

Change-Id: I29befae33113f80a2011670c1edbff331becc72d
Signed-off-by: Tomáš Golembiovský 
---
M lib/vdsm/v2v.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/57431/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index 946f61b..25d0a1b 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -993,10 +993,12 @@
 try:
 ret = vm.hasCurrentSnapshot()
 except libvirt.libvirtError as e:
-if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
+if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT or \
+conn.getType() != 'Xen':
 logging.exception('Error checking for existing snapshots.')
 # else: The snapshot related API is not implemented in all libvirt
-#   drivers. It is missing e.g. in Xen.
+#   drivers. It is missing e.g. in Xen. But we know that already,
+#   so no need to log the exception.
 else:
 params['has_snapshots'] = ret > 0
 


-- 
To view, visit https://gerrit.ovirt.org/57431
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29befae33113f80a2011670c1edbff331becc72d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Treat Xen specially after all.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Treat Xen specially after all.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57431
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29befae33113f80a2011670c1edbff331becc72d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Do not give Xen a special treatment.

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: v2v: Do not give Xen a special treatment.
..

v2v: Do not give Xen a special treatment.

Allways perform the check for snapshots and do not give Xen a special
treatment. Instead watch for VIR_ERR_NOT_SUPPORTED, which is more
generic.

Based on the discussion here:
https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py@903

Change-Id: I597118940d42ee953d9cdc83bb44afd13b5e882a
Signed-off-by: Tomáš Golembiovský 
---
M lib/vdsm/v2v.py
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/57430/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index a4a4f17..946f61b 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -990,14 +990,13 @@
 
 
 def _add_snapshot_info(conn, vm, params):
-# Snapshot related API is not yet implemented in the libvirt's Xen driver
-if conn.getType() == 'Xen':
-return
-
 try:
 ret = vm.hasCurrentSnapshot()
-except libvirt.libvirtError:
-logging.exception('Error checking for existing snapshots.')
+except libvirt.libvirtError as e:
+if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
+logging.exception('Error checking for existing snapshots.')
+# else: The snapshot related API is not implemented in all libvirt
+#   drivers. It is missing e.g. in Xen.
 else:
 params['has_snapshots'] = ret > 0
 


-- 
To view, visit https://gerrit.ovirt.org/57430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I597118940d42ee953d9cdc83bb44afd13b5e882a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 5: Verified+1

(1 comment)

Passed network tests OK.

https://gerrit.ovirt.org/#/c/57102/2/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

Line 40: TEST_NETMASK = '255.255.255.0'
Line 41: TEST_ADDRESS_WITH_PREFIX = '192.168.1.10/24'
Line 42: TEST_VLAN = 10
Line 43: TEST_VLANED_BOND = '%s.%s' % (TEST_BOND, TEST_VLAN)
Line 44: TEST_VLANED_NETWORK = 'test-network' + str(TEST_VLAN)
> If the original test has not yet been merged, better move the change there.
Done
Line 45: 
Line 46: 
Line 47: @contextmanager
Line 48: def _setup_ovs_network(ovsdb, nic1, nic2):


-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Separate path status and domain status

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Separate path status and domain status
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97e18ebec36b421d0b4ec20e768fe661d6facf98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Separate path status and domain status

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Separate path status and domain status
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97e18ebec36b421d0b4ec20e768fe661d6facf98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Simplify Status class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Simplify Status class
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57428
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ce56d9a17547f8dfa49ee6f009589227c8761f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Separate path status and domain status

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: monitor: Separate path status and domain status
..

monitor: Separate path status and domain status

Introduce two classes:

PathStatus  the status of checking domain monitoring path.
Collecting this status can block only if the storage is
not accessible.

DomainStatusthe status collected from the storage domain object.
Collecting this status may block for long time because
unrelated threads are holding global locks in vdsm.

The Status class wrap both objects and provides an unified view of the
monitor status, required for satisfying the code reporting storage
domain status, and for emitting status changes events.

We update the status twice for each monitoring cycle; once after
collecting path status, and once after collecting domain status. When
path checking is moved to new path checking infrastructure, this will
allow updating path status regardless of domain status check state.

For status changes, we mostly keep the old behavior:
- If path status check or domain status check fail and last status was
  valid, we emit a INVALID event.
- When both path status check and domain status check succeed and last
  status was invalid, we emit VALID event.

Note that now we perform path status check before domain self test; we
cannot keep the old order since path status must be separated from
operations accessing the storage domain object.

Change-Id: I97e18ebec36b421d0b4ec20e768fe661d6facf98
Signed-off-by: Nir Soffer 
---
M tests/storage_monitor_test.py
M vdsm/storage/monitor.py
2 files changed, 237 insertions(+), 78 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/57429/1

diff --git a/tests/storage_monitor_test.py b/tests/storage_monitor_test.py
index c711b48..17fa165 100644
--- a/tests/storage_monitor_test.py
+++ b/tests/storage_monitor_test.py
@@ -18,18 +18,106 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import time
+
 from storage import monitor
+
 from testlib import VdsmTestCase
+from testlib import permutations, expandPermutations
+from monkeypatch import MonkeyPatch
 
 
+@expandPermutations
 class TestStatus(VdsmTestCase):
 
-def test_valid(self):
-s = monitor.Status()
-self.assertIsNone(s.error)
-self.assertTrue(s.valid)
+def test_initial_status(self):
+# For backward compatibility, we must publish an initial status before
+# we collect the first samples. The initial status is marked as
+# actual=False to allow engine to treat it specially.
+path_status = monitor.PathStatus(actual=False)
+domain_status = monitor.DomainStatus(actual=False)
+status = monitor.Status(path_status, domain_status)
+self.assertFalse(status.actual)
+self.assertIsNone(status.error)
+self.assertTrue(status.valid)
 
-def test_invalid(self):
-s = monitor.Status()
-s.error = Exception()
-self.assertFalse(s.valid)
+def test_partial_status(self):
+# We collected path stauts but domain status is not available yet.
+path_status = monitor.PathStatus()
+domain_status = monitor.DomainStatus(actual=False)
+status = monitor.Status(path_status, domain_status)
+self.assertFalse(status.actual)
+self.assertIsNone(status.error)
+self.assertTrue(status.valid)
+
+def test_full_status(self):
+# Both path status and domain status are available.
+path_status = monitor.PathStatus()
+domain_status = monitor.DomainStatus()
+status = monitor.Status(path_status, domain_status)
+self.assertTrue(status.actual)
+self.assertIsNone(status.error)
+self.assertTrue(status.valid)
+
+def test_path_error(self):
+path_status = monitor.PathStatus(error=Exception("path"))
+domain_status = monitor.DomainStatus()
+status = monitor.Status(path_status, domain_status)
+self.assertTrue(status.actual)
+self.assertEqual(status.error, path_status.error)
+self.assertFalse(status.valid)
+
+def test_path_error_non_actual_domain_status(self):
+path_status = monitor.PathStatus(error=Exception("path"))
+domain_status = monitor.DomainStatus(actual=False)
+status = monitor.Status(path_status, domain_status)
+self.assertTrue(status.actual)
+self.assertEqual(status.error, path_status.error)
+self.assertFalse(status.valid)
+
+def test_domain_error(self):
+path_status = monitor.PathStatus()
+domain_status = monitor.DomainStatus(error=Exception("domain"))
+status = monitor.Status(path_status, domain_status)
+self.assertTrue(status.actual)
+self.assertEqual(status.error, domain_status.error)
+

Change in vdsm[master]: monitor: Separate path status and domain status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Separate path status and domain status
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97e18ebec36b421d0b4ec20e768fe661d6facf98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Separate setup from monitor loop

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Separate setup from monitor loop
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa621325ddf121365c647829cc213940eae6cfa3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Simplify Status class

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: monitor: Simplify Status class
..

monitor: Simplify Status class

Remove the unneeded __slots__ since we do not manage many status
objects.

Remove FrozenStatus as it is not needed. The new status implementation
will make the status read only in another way.

Change-Id: I0ce56d9a17547f8dfa49ee6f009589227c8761f9
Signed-off-by: Nir Soffer 
---
M tests/storage_monitor_test.py
M vdsm/storage/monitor.py
2 files changed, 3 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/57428/1

diff --git a/tests/storage_monitor_test.py b/tests/storage_monitor_test.py
index 56c4a1b..c711b48 100644
--- a/tests/storage_monitor_test.py
+++ b/tests/storage_monitor_test.py
@@ -22,31 +22,7 @@
 from testlib import VdsmTestCase
 
 
-class FrozenStatusTests(VdsmTestCase):
-
-def setUp(self):
-self.status = monitor.Status()
-self.frozen = monitor.FrozenStatus(self.status)
-
-def test_copy_attributes(self):
-for name in self.status.__slots__:
-value = getattr(self.status, name)
-expected = getattr(self.frozen, name)
-self.assertEquals(value, expected)
-
-def test_setting_attribute_raises(self):
-for name in self.status.__slots__:
-self.assertRaises(AssertionError, setattr, self.frozen, name, 1)
-
-def test_deleting_attribute_raises(self):
-for name in self.status.__slots__:
-self.assertRaises(AssertionError, delattr, self.frozen, name)
-
-def test_valid(self):
-self.assertEqual(self.frozen.valid, self.status.valid)
-
-
-class StatusValidTests(VdsmTestCase):
+class TestStatus(VdsmTestCase):
 
 def test_valid(self):
 s = monitor.Status()
diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index 9483993..6c90faf 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -35,12 +35,6 @@
 
 
 class Status(object):
-__slots__ = (
-"error", "checkTime", "readDelay", "masterMounted",
-"masterValid", "diskUtilization", "vgMdUtilization",
-"vgMdHasEnoughFreeSpace", "vgMdFreeBelowThreashold", "hasHostId",
-"isoPrefix", "version", "actual",
-)
 
 def __init__(self, actual=True):
 self.actual = actual
@@ -67,19 +61,6 @@
 @property
 def valid(self):
 return self.error is None
-
-
-class FrozenStatus(Status):
-
-def __init__(self, other):
-for name in other.__slots__:
-value = getattr(other, name)
-super(FrozenStatus, self).__setattr__(name, value)
-
-def __setattr__(self, *args):
-raise AssertionError('%s is readonly' % self)
-
-__delattr__ = __setattr__
 
 
 class DomainMonitor(object):
@@ -204,7 +185,7 @@
 # For backward compatibility, we must present a fake status before
 # collecting the first sample. The fake status is marked as
 # actual=False so engine can handle it correctly.
-self.status = FrozenStatus(Status(actual=False))
+self.status = Status(actual=False)
 self.isIsoDomain = None
 self.isoPrefix = None
 self.lastRefresh = time.time()
@@ -340,7 +321,7 @@
 def _updateStatus(self, status):
 if self._statusDidChange(status):
 self._notifyStatusChanges(status)
-self.status = FrozenStatus(status)
+self.status = status
 
 def _statusDidChange(self, status):
 return (not self.status.actual or


-- 
To view, visit https://gerrit.ovirt.org/57428
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ce56d9a17547f8dfa49ee6f009589227c8761f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 12:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 11:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: storage: Do not reference image dir in backing volume path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Do not reference image dir in backing volume path
..


Patch Set 1: Code-Review+1

Looks good, but get it tested before we merge to 3.6.

-- 
To view, visit https://gerrit.ovirt.org/57419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: access network caps via network API

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: access network caps via network API
..


Patch Set 2: Verified+1

Passed network tests.

-- 
To view, visit https://gerrit.ovirt.org/57402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfce0d2fe741e89a3ca54b58c9738ce33495ec92
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 10:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: Marked optional fields in ExternalVmInfo.

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: schema: Marked optional fields in ExternalVmInfo.
..


Patch Set 1: Verified+1

There is nothing to verify, is there?

-- 
To view, visit https://gerrit.ovirt.org/57417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2e7f81ba39be2616f732de1deff477a1ca6c65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migrations: enhance legacy downtime alg

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migrations: enhance legacy downtime alg
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d18a77c91a1344110afef1577e310faab3ffe5b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: storage: Do not reference image dir in backing volume path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Do not reference image dir in backing volume path
..


Patch Set 1:

* #1333627::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1333627::OK, public bug
* Check Product::#1333627::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1333627::OK, correct target milestone ovirt-3.6.7
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/57419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: canonicalize network before broken network removal

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: canonicalize network before broken network removal
..


Patch Set 2: Verified+1

Passed network tests OK.

-- 
To view, visit https://gerrit.ovirt.org/57349
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37cc478db6957308f43613f835779a9179f06bff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Lazy loading of external VMs info

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Lazy loading of external VMs info
..


Patch Set 1: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/57418/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 7095: type: string
Line 7096: 
Line 7097: -   defaultvalue: False
Line 7098: description: Request only names, not complete info about 
hosts
Line 7099: name: names_only
This is a misnomer actually, because we are returning also VM state and not 
just the name. Should I rename it somehow, or is this OK? Any suggestions?
Line 7100: added: '4.0'
Line 7101: type: boolean
Line 7102: 
Line 7103: -   defaultvalue: null


-- 
To view, visit https://gerrit.ovirt.org/57418
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dc6fc4573b2c0b1c03ed87025452e14af2fc566
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: open nontls port only if requested

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: open nontls port only if requested
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56839
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If87d70ce70f60b09213343533e9168f942e6ea64
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: dynamic setting of {in, out}bound limits

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: dynamic setting of {in,out}bound limits
..


Patch Set 35:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: yml: fix virt glitches

[automation]

gerrit-hooks has posted comments on this change.

Change subject: schema: yml: fix virt glitches
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57314
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e04e19ea3ba3d78c9d21634869cf0779e72a830
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: storage: Do not reference image dir in backing volume path

[alitke]

Hello Nir Soffer,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/57419

to review the following change.

Change subject: storage: Do not reference image dir in backing volume path
..

storage: Do not reference image dir in backing volume path

Until now, the backing volume path (to be written into qcow2 metadata)
was computed as ..//.  The ../ component
causes the backing_chain field of volumes to grow every time a live
merge is performed until it eventually overflows.  The blockSD function
createImageLinks is now ensuring that all volumes of an image (including
templates) are in a directory together so we can use just the volume ID
to reference the backing volume.  File domains hard link templates into
the directories of images that are dependent so this works for file
domains as well.

Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1333627
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/57284
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/volume.py
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/57419/1

diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index ef41d15..085fbf5 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -155,7 +155,13 @@
 
 
 def getBackingVolumePath(imgUUID, volUUID):
-return os.path.join('..', imgUUID, volUUID)
+# We used to return a relative path ..// but this caused
+# unnecessary growth in the backing chain paths with repeated live merge
+# operations (see https://bugzilla.redhat.com/show_bug.cgi?id=1333627).
+# Since all volumes of an image are in the same directory (including cloned
+# templates which have a hard link on file domains and a symlink on block
+# domains) we do not need to use the image dir reference anymore.
+return volUUID
 
 
 class VmVolumeInfo(object):


-- 
To view, visit https://gerrit.ovirt.org/57419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Lazy loading of external VMs info

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: v2v: Lazy loading of external VMs info
..

v2v: Lazy loading of external VMs info

API changes allowing implementation of lazy loading of information about
external VMs. Fetching of all the information is rather expensive
operation especially from VMware hosts. Now we can fetch the names first
and then load all the other information only for specified subset of
VMs.

Change-Id: I3dc6fc4573b2c0b1c03ed87025452e14af2fc566
Bug-Url: https://bugzilla.redhat.com/1294629
Signed-off-by: Tomáš Golembiovský 
---
M client/vdsClient.py
M lib/api/vdsm-api.yml
M lib/api/vdsmapi-schema.json
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/utils.py
M lib/vdsm/v2v.py
M tests/v2vTests.py
M vdsm/API.py
8 files changed, 107 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/57418/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index c7b359d..514cd92 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1900,10 +1900,19 @@
 return 0, ''
 
 def getExternalVMs(self, args):
-if len(args) != 3:
+if len(args) < 3:
 raise ValueError('Wrong number of arguments')
-uri, username, password = args
-status = self.s.getExternalVMs(uri, username, password)
+
+uri, username, password = args[0:3]
+if len(args) > 3:
+names_only = utils.tobool(args[3])
+vm_names = args[4:]
+else:
+names_only = False
+vm_names = []
+
+status = self.s.getExternalVMs(uri, username, password, names_only,
+   vm_names)
 if status['status']['code'] == 0:
 vmList = status['vmList']
 for vm in vmList:
@@ -2865,7 +2874,7 @@
 )),
 'externalVMList': (
 serv.getExternalVMs, (
-'  ',
+'   [ [ ...] ]'
 'get VMs from external hypervisor'
 )),
 'getHostJobs': (
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 40a0cfe..6c7c17b 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -7093,6 +7093,20 @@
 -   description: libvirt connection password
 name: password
 type: string
+
+-   defaultvalue: False
+description: Request only names, not complete info about hosts
+name: names_only
+added: '4.0'
+type: boolean
+
+-   defaultvalue: null
+description: Limit query only to hosts with specified names
+name: vm_names
+added: '4.0'
+type:
+- string
+
 return:
 description: A list of VMs (List of ExternalVmInfo)
 type:
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index b2dd77a..391666b 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -4049,13 +4049,20 @@
 #
 # @password:  libvirt connection password
 #
+# @names_only: #optional Request only names, not complete info about hosts
+# (new in version 4.18.0)
+#
+# @vm_names:  #optional Limit query only to hosts with specified names.
+# (new in version 4.18.0)
+#
 # Returns:
 # A list of VMs (List of ExternalVmInfo)
 #
 # Since: 4.17.0
 ##
 {'command': {'class': 'Host', 'name': 'getExternalVMs'},
-  'data': {'uri': 'str', 'username': 'str', 'password': 'str'},
+  'data': {'uri': 'str', 'username': 'str', 'password': 'str',
+   '*names_only': 'bool', '*vm_names': '[str]'},
   'returns': ['ExternalVmInfo']}
 
 
diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py
index 8b8dcc7..e38b5bf 100644
--- a/lib/vdsm/rpc/bindingxmlrpc.py
+++ b/lib/vdsm/rpc/bindingxmlrpc.py
@@ -363,10 +363,12 @@
 job_type = None if job_type == '' else job_type
 return api.getJobs(job_type=job_type, job_ids=job_ids)
 
-def getExternalVMs(self, uri, username, password):
+def getExternalVMs(self, uri, username, password, names_only=False,
+   vm_names=None):
 password = ProtectedPassword(password)
 api = API.Global()
-return api.getExternalVMs(uri, username, password)
+return api.getExternalVMs(uri, username, password, names_only,
+  vm_names)
 
 def getExternalVmFromOva(self, ova_path):
 api = API.Global()
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index e6b8dd5..0bee912 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -414,7 +414,7 @@
 return False
 if type(s) == bool:
 return s
-if s.lower() == 'true':
+if str(s).lower() == 'true':
 return True
 return bool(int(s))
 except:
diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index 4bedf18..3adeda2 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -142,7 

Change in vdsm[master]: v2v: Lazy loading of external VMs info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Lazy loading of external VMs info
..


Patch Set 1:

* #1294629::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294629::OK, public bug
* Check Product::#1294629::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57418
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dc6fc4573b2c0b1c03ed87025452e14af2fc566
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: Marked optional fields in ExternalVmInfo.

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: schema: Marked optional fields in ExternalVmInfo.
..

schema: Marked optional fields in ExternalVmInfo.

Some fields may remain empty in certain cases, but they were not marked
as optional in the scheme. Small changes to capitalization included.

We prefer to fix the schema instead of adding defaults to the code.
Returning (nearly) empty structure will come in handy for next API
change that will provida us with the ability to do a lazy loading of
information.

Change-Id: I8e2e7f81ba39be2616f732de1deff477a1ca6c65
Signed-off-by: Tomáš Golembiovský 
---
M lib/api/vdsm-api.yml
M lib/api/vdsmapi-schema.json
2 files changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/57417/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 81d86b3..40a0cfe 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -924,11 +924,13 @@
 name: allocation
 type: *VolumeAllocation
 
--   description: size of actual memory in MB
+-   defaultvalue: null
+description: Size of actual memory in MB
 name: memSize
 type: uint
 
--   description: number of cpu
+-   defaultvalue: null
+description: Number of CPUs
 name: smp
 type: uint
 
@@ -937,7 +939,8 @@
 name: virtio_iso_path
 type: string
 
--   description: The VM uuid
+-   defaultvalue: null
+description: The VM UUID
 name: vmId
 type: *UUID
 
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index c2da818..b2dd77a 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -4006,11 +4006,11 @@
 #
 # @status:  The current VM status
 #
-# @vmId:The VM uuid
+# @vmId:#optional The VM UUID
 #
-# @smp: number of cpu
+# @smp: #optional Number of CPUs
 #
-# @memSize: size of actual memory in MB
+# @memSize: #optional Size of actual memory in MB
 #
 # @disks:   #optional list of disk devices
 #
@@ -4032,8 +4032,8 @@
 # Since: 4.17.0
 ##
 {'type': 'ExternalVmInfo',
- 'data': {'vmName': 'str', 'status': 'VmStatus', 'vmId': 'UUID', 'smp': 'uint',
-  'memSize': 'uint', '*disks': ['ExternalDiskInfo'],
+ 'data': {'vmName': 'str', 'status': 'VmStatus', '*vmId': 'UUID',
+  '*smp': 'uint', '*memSize': 'uint', '*disks': ['ExternalDiskInfo'],
   '*networks': ['ExternalNetworkInfo'], '*format': 'VolumeFormat',
   '*allocation': 'VolumeAllocation', '*virtio_iso_path': 'str',
   '*graphics': 'str', '*video': 'str'}}


-- 
To view, visit https://gerrit.ovirt.org/57417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e2e7f81ba39be2616f732de1deff477a1ca6c65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: Marked optional fields in ExternalVmInfo.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: schema: Marked optional fields in ExternalVmInfo.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2e7f81ba39be2616f732de1deff477a1ca6c65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 9:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 8:

please rebase on top of gerrit to make jenkins happy.

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: access network caps via network API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: access network caps via network API
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfce0d2fe741e89a3ca54b58c9738ce33495ec92
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: canonicalize network before broken network removal

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: canonicalize network before broken network removal
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57349
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37cc478db6957308f43613f835779a9179f06bff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: canonicalize network before broken network removal

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: canonicalize network before broken network removal
..


Patch Set 1: -Verified

-- 
To view, visit https://gerrit.ovirt.org/57349
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37cc478db6957308f43613f835779a9179f06bff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: devices: fix behaviour with balloon model=none
..


Patch Set 1:

We've got a bug for this now: https://bugzilla.redhat.com/1335840

-- 
To view, visit https://gerrit.ovirt.org/54440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab96f47118148a67135286a3a9b1998840efce18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: access network caps via network API

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: access network caps via network API
..

net: access network caps via network API

With OVS, caps will be mixed from OVS netinfo, legacy netinfo and
nics netinfo (legacy and nics are now included in netinfo.cache.get).

Let's access netinfo from network API as we should move netinfo package
here as well. In API we will have centralized control of netinfo
mixing, faking,...

Change-Id: Icfce0d2fe741e89a3ca54b58c9738ce33495ec92
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/api.py
M vdsm/caps.py
2 files changed, 4 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/57402/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index a2388ba..f3dca84 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -29,6 +29,7 @@
 import six
 
 from vdsm.config import config
+from vdsm.netinfo import cache as netinfo_cache
 from vdsm import commands
 from vdsm import constants
 from vdsm import hooks
@@ -45,7 +46,8 @@
 
 def caps_networks():
 """Complement existing non-root caps"""
-return {}
+# TODO: Version requests by engine to ease handling of compatibility.
+return netinfo_cache.get(compatibility=30600)
 
 
 def _wait_for_udev_events():
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 66eb245..0a0e45a 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -27,7 +27,6 @@
 import libvirt
 
 from vdsm.config import config
-from vdsm.netinfo import cache as netinfo_cache
 from vdsm import cpuarch
 from vdsm import cpuinfo
 from vdsm import dsaversion
@@ -161,12 +160,7 @@
 
 caps.update(_getVersionInfo())
 
-# TODO: Version requests by engine to ease handling of compatibility.
-netinfo_data = netinfo_cache.get(compatibility=30600)
-caps.update(netinfo_data)
-
-super_caps_networks = supervdsm.getProxy().caps_networks()
-caps.update(super_caps_networks)
+caps.update(supervdsm.getProxy().caps_networks())
 
 try:
 caps['hooks'] = hooks.installed()


-- 
To view, visit https://gerrit.ovirt.org/57402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfce0d2fe741e89a3ca54b58c9738ce33495ec92
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: access network caps via network API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: access network caps via network API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfce0d2fe741e89a3ca54b58c9738ce33495ec92
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add LegacyCdromPath as DriveSpec

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: storage: add LegacyCdromPath as DriveSpec
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee7df14b0b49ea844f17711b6621e025d9df4bf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 6: Verified+1

(3 comments)

Passed ovs_info_test.py

https://gerrit.ovirt.org/#/c/57068/5/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

PS5, Line 289: 
> Lets drop it and make it clear below that we change netinfo.
Done


PS5, Line 291: def _ovs_networks(networks):
 : return ((net, attrs) for net, attrs in six.iter
> Please avoid it and make sure the caller supplies it.
Done


PS5, Line 299: 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
> How about this?
Done


-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adapting to latest lago 0.17

[dcaro]

David Caro has posted comments on this change.

Change subject: Adapting to latest lago 0.17
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57376
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78360edc6ab2fd0c3faea8f308609b23f711ad0b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: check-merged:Using yaml for the lago initfile

[automation]

gerrit-hooks has posted comments on this change.

Change subject: check-merged:Using yaml for the lago initfile
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32af33e5cabda00e2e43e6512079c3b93fa59e9f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

[dcaro]

David Caro has abandoned this change.

Change subject: bridgeTests:Remove extra param to migrationCreate
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/57388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifa02aba240760f1b69aa34b3cba5a1fb2c4120ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adapting to latest lago 0.17

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adapting to latest lago 0.17
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57376
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78360edc6ab2fd0c3faea8f308609b23f711ad0b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridgeTests:Remove extra param to migrationCreate
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/57388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02aba240760f1b69aa34b3cba5a1fb2c4120ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: log the convergence schedule only if provided

[tjelinek]

Tomas Jelinek has posted comments on this change.

Change subject: migration: log the convergence schedule only if provided
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id34f02deea261cd7e09197771950316efc09ebd5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migrations: enhance legacy downtime alg

[tjelinek]

Tomas Jelinek has posted comments on this change.

Change subject: migrations: enhance legacy downtime alg
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d18a77c91a1344110afef1577e310faab3ffe5b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

[jniederm]

Jakub Niedermertl has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: bridgeTests:Remove extra param to migrationCreate
..


Patch Set 2:

Yes, master is ok now, so you should abandon this change.

-- 
To view, visit https://gerrit.ovirt.org/57388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02aba240760f1b69aa34b3cba5a1fb2c4120ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Do not reference image dir in backing volume path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Do not reference image dir in backing volume path
..


Patch Set 2:

Please backport to 3.6

-- 
To view, visit https://gerrit.ovirt.org/57284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Do not reference image dir in backing volume path

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Do not reference image dir in backing volume path
..


storage: Do not reference image dir in backing volume path

Until now, the backing volume path (to be written into qcow2 metadata)
was computed as ..//.  The ../ component
causes the backing_chain field of volumes to grow every time a live
merge is performed until it eventually overflows.  The blockSD function
createImageLinks is now ensuring that all volumes of an image (including
templates) are in a directory together so we can use just the volume ID
to reference the backing volume.  File domains hard link templates into
the directories of images that are dependent so this works for file
domains as well.

Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1333627
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/57284
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/volume.py
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/57284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Do not reference image dir in backing volume path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Do not reference image dir in backing volume path
..


Patch Set 2:

* #1333627::Update tracker: OK
* Set MODIFIED::bug 1333627#1333627IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/57284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62afa6db6f458d5c2c64ccc3427831cb76af1dcc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add LegacyCdromPath as DriveSpec

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add LegacyCdromPath as DriveSpec
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee7df14b0b49ea844f17711b6621e025d9df4bf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: teardown non-scsi devices

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: hostdev: teardown non-scsi devices
..


Patch Set 6: Code-Review+1

Without understanding all the possible implications, it looks basically fine to 
me. (And I wouldn't make it more complicated unless there is a reason to do so.)

-- 
To view, visit https://gerrit.ovirt.org/57375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8b8780203fcd29afa37dabc4594e2767245359
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Detach read delay from storage domain

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Detach read delay from storage domain
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56826
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a687f70c220a86e538bf1cee500aa8b6028eff1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Separate setup from monitor loop

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Separate setup from monitor loop
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa621325ddf121365c647829cc213940eae6cfa3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Use module logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Use module logger
..


Patch Set 8: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35954fe676388247164c8c62fa0744ffcc14006f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Convert valid to read-only property
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Rename storage.monitor test module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Rename storage.monitor test module
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0cf3ac326d8e50950771870c76d7b309514ffb6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Convert valid to read-only property
..


Patch Set 10: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Use module logger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Use module logger
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35954fe676388247164c8c62fa0744ffcc14006f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Rename storage.monitor test module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Rename storage.monitor test module
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0cf3ac326d8e50950771870c76d7b309514ffb6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Convert valid to read-only property
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Separate setup from monitor loop

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Separate setup from monitor loop
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa621325ddf121365c647829cc213940eae6cfa3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add LegacyCdromPath as DriveSpec

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add LegacyCdromPath as DriveSpec
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieee7df14b0b49ea844f17711b6621e025d9df4bf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmdevices: make disk's makeName public

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmdevices: make disk's makeName public
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e11c52f86a4ed7155118607723e9e7712a08e7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add block device naming tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add block device naming tests
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I492a1849109b6f852ccd015d487c6cb7441febdb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cdrom: API change: require interface & index

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cdrom: API change: require interface & index
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 56
Line 57
Line 58
Line 59
Line 60
> Something used throughout whole hostdev - it's a libvirt way of naming a de
Please add a docstring with these examples  in another patch.


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches