Change in vdsm[master]: hooks: Add fcoe hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 33:

* #1239122::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1239122::OK, public bug
* Check Product::#1239122::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: move fuser module to vdsm storage lib

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: storage: move fuser module to vdsm storage lib
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I752fed7ebe4af8a3837f817634ff4732637c8ac5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Move libvirt module under network

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Move libvirt module under network
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/57310/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: net: Move libvirt module under network
Line 8: 
Line 9: Move libvirt module from network.configurators to network.
Line 10: 
> please add a motivation (it's not really a network configurator, and it is 
Done
Line 11: Change-Id: I858c57e026573d000388ea42c2319b6bd400497c


-- 
To view, visit https://gerrit.ovirt.org/57310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I858c57e026573d000388ea42c2319b6bd400497c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: ad_actor_system may not be reset to its default value

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: ad_actor_system may not be reset to its default value
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/57490/1/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 880: for k, v in default_opts.iteritems():
Line 881: if k != 'mode' and k in current_opts and v != current_opts[k]:
Line 882: diff[k] = default_opts[k]
Line 883: for k, v in diff.iteritems():
Line 884: if k in (
did we not have a means to exclude read-only options?

if we don't, you'd better add such a named frozenset.
Line 885: # bonding.txt: The value can not be either NULL or 
Multicast.
Line 886: 'ad_actor_system',):
Line 887: continue
Line 888: with open(netinfo_bonding.BONDING_OPT % (bond_name, k), 'w') 
as f:


-- 
To view, visit https://gerrit.ovirt.org/57490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Expose existing ip address info through the api

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Expose existing ip address info through the api
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/57309/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 105: 
Line 106: ipwrapper.linkSet(net_name, ['up'])
Line 107: 
Line 108: 
Line 109: def ip_addrs_info(device):
> unlike the other public functions here, this one is not expected to be expo
Done
Line 110: return ipaddress.addrs_info(device)
Line 111: 
Line 112: 
Line 113: def _build_setup_hook_dict(req_networks, req_bondings, req_options):


-- 
To view, visit https://gerrit.ovirt.org/57309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I714d2f7012ddc495d580b65857ae80db5dee7a79
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ceph: Require ceph-common when it is available

[derez]

Daniel Erez has posted comments on this change.

Change subject: ceph: Require ceph-common when it is available
..


Patch Set 13: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: ad_actor_system may not be reset to its default value

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: ad_actor_system may not be reset to its default value
..


Patch Set 1: Verified+1

testSetupNetworksActiveSlave now passes on Fedora 23.

-- 
To view, visit https://gerrit.ovirt.org/57490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: ad_actor_system may not be reset to its default value

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: ad_actor_system may not be reset to its default value
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: ad_actor_system may not be reset to its default value

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: ifcfg: ad_actor_system may not be reset to its default value
..

ifcfg: ad_actor_system may not be reset to its default value

_restore_default_bond_options tries to reset this option to
00:00:00:00:00:00, which (on Fedora 23) causes "IOError: [Errno 22]
Invalid argument", during testSetupNetworksActiveSlave.

Linux documentation (bonding.txt) says that "The value can not
be either NULL or Multicast". Stop resetting the value for now.

From more digging:

bond_option_ad_actor_system_set in bond_options.c doesn't look like it
is possible to reset the value (only valid MAC address is accepted).
The address (if set) persists bond mode changes.

The documentation also says that "If the value is not given then
system defaults to using the masters' mac address as actors' system
address." so the only sane way to reset the option (if we wanted)
would be to the bond's MAC address.

Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/57490/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 384ee25..9532577 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -881,6 +881,10 @@
 if k != 'mode' and k in current_opts and v != current_opts[k]:
 diff[k] = default_opts[k]
 for k, v in diff.iteritems():
+if k in (
+# bonding.txt: The value can not be either NULL or Multicast.
+'ad_actor_system',):
+continue
 with open(netinfo_bonding.BONDING_OPT % (bond_name, k), 'w') as f:
 f.write(' '.join(v))
 


-- 
To view, visit https://gerrit.ovirt.org/57490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: make _bonds_edit more readable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: legacy_switch: make _bonds_edit more readable
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f8f3de793087b836885d8afac9256f36f1d9b3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: remove duplicated handling of extraneous slaves

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: remove duplicated handling of extraneous slaves
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I438f93d3002a2371920c23dba2de510559759ce0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: split _detach_extraneous_slaves off _bonds_edit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: legacy_switch: split _detach_extraneous_slaves off _bonds_edit
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5008d0c801312ab93d14cdaef7674cdf8739f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: quote bonding options and stop repeating "bon...

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: legacy_switch: quote bonding options and stop repeating "bond 
Bond()"
..


Patch Set 1: Verified+1

Strings only.

-- 
To view, visit https://gerrit.ovirt.org/57486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie34b67a74f9411b956376eb0ef0c1debc5d8ff72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: point to vars.hidden_nics when refusing to bond them

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: network: point to vars.hidden_nics when refusing to bond them
..


Patch Set 2: Verified+1

Strings only.

-- 
To view, visit https://gerrit.ovirt.org/57485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83130813bb6e168c5148cf58d01ef97de39394bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: clarify logging messages, use explicit t...

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: netconfpersistence: clarify logging messages, use explicit terms
..


Patch Set 1: Verified+1

Strings only.

-- 
To view, visit https://gerrit.ovirt.org/57484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78a15d6218273619f96364ef6fcb77b910998ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: remove duplicated handling of extraneous slaves

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: remove duplicated handling of extraneous slaves
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I438f93d3002a2371920c23dba2de510559759ce0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: remove duplicated handling of extraneous slaves

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: remove duplicated handling of extraneous slaves
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I438f93d3002a2371920c23dba2de510559759ce0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: explain why we have to reset bonding options to default

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: explain why we have to reset bonding options to default
..


Patch Set 1: Verified+1

Documentation-only commit.

-- 
To view, visit https://gerrit.ovirt.org/57482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72bea05213c8561367351749fd6b3831ebe77b9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: remove duplicated handling of extraneous slaves

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: ifcfg: remove duplicated handling of extraneous slaves
..

ifcfg: remove duplicated handling of extraneous slaves

legacy_switch._detach_extraneous_slaves already does the same job.

Change-Id: I438f93d3002a2371920c23dba2de510559759ce0
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/57489/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 433b2fa..0f66710 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -153,11 +153,6 @@
 self.configApplier.addBonding(bond)
 bondIfcfgWritten = True
 
-# Detach excessive slaves (TODO: hasn't _bonds_edit done this already?)
-for nic in currentNics - nicsToSet:
-ifdown(nic)  # So that no users will be detected for it.
-Nic(nic, self, _netinfo=_netinfo).remove()
-
 for slave in bond.slaves:
 if slave.name in nicsToAdd:
 ifdown(slave.name)  # nics must be down to join a bond


-- 
To view, visit https://gerrit.ovirt.org/57489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I438f93d3002a2371920c23dba2de510559759ce0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: remove duplicated handling of extraneous slaves

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: remove duplicated handling of extraneous slaves
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I438f93d3002a2371920c23dba2de510559759ce0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: point to vars.hidden_nics when refusing to bond them

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: point to vars.hidden_nics when refusing to bond them
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83130813bb6e168c5148cf58d01ef97de39394bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: split _detach_extraneous_slaves off _bonds_edit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: legacy_switch: split _detach_extraneous_slaves off _bonds_edit
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5008d0c801312ab93d14cdaef7674cdf8739f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: split _detach_extraneous_slaves off _bonds_edit

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: legacy_switch: split _detach_extraneous_slaves off _bonds_edit
..

legacy_switch: split _detach_extraneous_slaves off _bonds_edit

Change-Id: I0a5008d0c801312ab93d14cdaef7674cdf8739f8
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/legacy_switch.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/57488/1

diff --git a/lib/vdsm/network/legacy_switch.py 
b/lib/vdsm/network/legacy_switch.py
index e722659..ea5080d 100644
--- a/lib/vdsm/network/legacy_switch.py
+++ b/lib/vdsm/network/legacy_switch.py
@@ -522,6 +522,8 @@
 remove, edit, add = _bonds_classification(bonds, _netinfo)
 _bonds_remove(remove, configurator, _netinfo, in_rollback)
 _netinfo.updateDevices()
+_detach_extraneous_slaves()
+_netinfo.updateDevices()
 _bonds_edit(edit, configurator, _netinfo)
 _bonds_add(add, configurator, _netinfo)
 
@@ -576,7 +578,7 @@
 return True
 
 
-def _bonds_edit(bonds, configurator, _netinfo):
+def _detach_extraneous_slaves(bonds, configurator, _netinfo):
 for name, attrs in six.iteritems(bonds):
 excessive_slaves = (set(_netinfo.bondings[name]['slaves']) -
 set(attrs.get('nics')))
@@ -585,8 +587,8 @@
   excessive_slaves, name)
 _remove_slaves(excessive_slaves, configurator, _netinfo)
 
-_netinfo.updateDevices()
 
+def _bonds_edit(bonds, configurator, _netinfo):
 for name, attrs in six.iteritems(bonds):
 bond = Bond.objectivize(
 name, configurator, attrs.get('options'), attrs.get('nics'),


-- 
To view, visit https://gerrit.ovirt.org/57488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a5008d0c801312ab93d14cdaef7674cdf8739f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: make _bonds_edit more readable; and mark a po...

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: legacy_switch: make _bonds_edit more readable; and mark a 
possible duplicity in ifcfg
..

legacy_switch: make _bonds_edit more readable; and mark a possible duplicity in 
ifcfg

Change-Id: Ic6f8f3de793087b836885d8afac9256f36f1d9b3
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/legacy_switch.py
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/57487/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 384ee25..433b2fa 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -153,6 +153,7 @@
 self.configApplier.addBonding(bond)
 bondIfcfgWritten = True
 
+# Detach excessive slaves (TODO: hasn't _bonds_edit done this already?)
 for nic in currentNics - nicsToSet:
 ifdown(nic)  # So that no users will be detected for it.
 Nic(nic, self, _netinfo=_netinfo).remove()
diff --git a/lib/vdsm/network/legacy_switch.py 
b/lib/vdsm/network/legacy_switch.py
index 21c45d4..e722659 100644
--- a/lib/vdsm/network/legacy_switch.py
+++ b/lib/vdsm/network/legacy_switch.py
@@ -521,6 +521,7 @@
 _netinfo.updateDevices()
 remove, edit, add = _bonds_classification(bonds, _netinfo)
 _bonds_remove(remove, configurator, _netinfo, in_rollback)
+_netinfo.updateDevices()
 _bonds_edit(edit, configurator, _netinfo)
 _bonds_add(add, configurator, _netinfo)
 
@@ -576,16 +577,14 @@
 
 
 def _bonds_edit(bonds, configurator, _netinfo):
-_netinfo.updateDevices()
-
 for name, attrs in six.iteritems(bonds):
-slaves_to_remove = (set(_netinfo.bondings[name]['slaves']) -
+excessive_slaves = (set(_netinfo.bondings[name]['slaves']) -
 set(attrs.get('nics')))
-logging.debug('Editing bond %r, removing slaves %s', name,
-  slaves_to_remove)
-_remove_slaves(slaves_to_remove, configurator, _netinfo)
+if excessive_slaves:
+logging.debug('Detaching extra slaves %s from %r',
+  excessive_slaves, name)
+_remove_slaves(excessive_slaves, configurator, _netinfo)
 
-# we need bonds to be slaveless in _netinfo
 _netinfo.updateDevices()
 
 for name, attrs in six.iteritems(bonds):


-- 
To view, visit https://gerrit.ovirt.org/57487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6f8f3de793087b836885d8afac9256f36f1d9b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: make _bonds_edit more readable; and mark a po...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: legacy_switch: make _bonds_edit more readable; and mark a 
possible duplicity in ifcfg
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f8f3de793087b836885d8afac9256f36f1d9b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: quote bonding options and stop repeating "bon...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: legacy_switch: quote bonding options and stop repeating "bond 
Bond()"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie34b67a74f9411b956376eb0ef0c1debc5d8ff72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: legacy_switch: quote bonding options and stop repeating "bon...

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: legacy_switch: quote bonding options and stop repeating "bond 
Bond()"
..

legacy_switch: quote bonding options and stop repeating "bond Bond()"

Change-Id: Ie34b67a74f9411b956376eb0ef0c1debc5d8ff72
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/legacy_switch.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/57486/1

diff --git a/lib/vdsm/network/legacy_switch.py 
b/lib/vdsm/network/legacy_switch.py
index 21c45d4..c84c478 100644
--- a/lib/vdsm/network/legacy_switch.py
+++ b/lib/vdsm/network/legacy_switch.py
@@ -592,7 +592,7 @@
 bond = Bond.objectivize(
 name, configurator, attrs.get('options'), attrs.get('nics'),
 mtu=None, _netinfo=_netinfo)
-logging.debug('Editing bond %r with options %s', bond, bond.options)
+logging.debug('Editing %r with options %r', bond, bond.options)
 configurator.editBonding(bond, _netinfo)
 
 
@@ -607,7 +607,7 @@
 bond = Bond.objectivize(
 name, configurator, attrs.get('options'), attrs.get('nics'),
 mtu=None, _netinfo=_netinfo)
-logging.debug('Creating bond %r with options %s', bond, bond.options)
+logging.debug('Creating %r with options %r', bond, bond.options)
 configurator.configureBond(bond)
 
 


-- 
To view, visit https://gerrit.ovirt.org/57486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie34b67a74f9411b956376eb0ef0c1debc5d8ff72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: point to vars.hidden_nics when refusing to bond them

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: point to vars.hidden_nics when refusing to bond them
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83130813bb6e168c5148cf58d01ef97de39394bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: point to vars.hidden_nics when refusing to bond them

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: network: point to vars.hidden_nics when refusing to bond them
..

network: point to vars.hidden_nics when refusing to bond them

Saying that dummy0 is "unknown" can mean either that it in fact
doesn't exist, or worse, that it is hidden from netinfo, and this
may confuse someone not aware of this configuration option.

Change-Id: I83130813bb6e168c5148cf58d01ef97de39394bd
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/models.py
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/57485/1

diff --git a/lib/vdsm/network/legacy_switch.py 
b/lib/vdsm/network/legacy_switch.py
index 21c45d4..1ee61aa 100644
--- a/lib/vdsm/network/legacy_switch.py
+++ b/lib/vdsm/network/legacy_switch.py
@@ -632,8 +632,9 @@
 raise ConfigNetworkError(ne.ERR_BAD_PARAMS,
  'Must specify nics for bonding')
 if not set(nics).issubset(currentNicsSet):
-raise ConfigNetworkError(ne.ERR_BAD_NIC,
- 'Unknown nics in: %r' % list(nics))
+raise ConfigNetworkError(
+ne.ERR_BAD_NIC, 'Unknown nics in: %r (see vars.hidden_nics in '
+'vdsm.conf)' % list(nics))
 
 
 def _validate_network_remove(networkAttrs):
diff --git a/lib/vdsm/network/models.py b/lib/vdsm/network/models.py
index f91f010..51205af 100644
--- a/lib/vdsm/network/models.py
+++ b/lib/vdsm/network/models.py
@@ -80,7 +80,8 @@
 if _netinfo is None:
 _netinfo = CachingNetInfo()
 if name not in _netinfo.nics:
-raise ConfigNetworkError(ne.ERR_BAD_NIC, 'unknown nic: %s' % name)
+raise ConfigNetworkError(ne.ERR_BAD_NIC, 'unknown nic: %s (see '
+'vars.hidden_nics in vdsm.conf)' % name)
 
 if _netinfo.ifaceUsers(name):
 mtu = max(mtu, mtus.getMtu(name))


-- 
To view, visit https://gerrit.ovirt.org/57485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83130813bb6e168c5148cf58d01ef97de39394bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: clarify logging messages, use explicit t...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netconfpersistence: clarify logging messages, use explicit terms
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78a15d6218273619f96364ef6fcb77b910998ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netconfpersistence: clarify logging messages, use explicit t...

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: netconfpersistence: clarify logging messages, use explicit terms
..

netconfpersistence: clarify logging messages, use explicit terms

In supervdsm.log, an unattentive reader may easily and often become
confused about the original "Adding/Removing bond/network" messages.

Change-Id: I78a15d6218273619f96364ef6fcb77b910998ebb
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/57484/1

diff --git a/lib/vdsm/network/netconfpersistence.py 
b/lib/vdsm/network/netconfpersistence.py
index fbf7676..39edb63 100644
--- a/lib/vdsm/network/netconfpersistence.py
+++ b/lib/vdsm/network/netconfpersistence.py
@@ -53,25 +53,26 @@
   ('configurator', '_netinfo', 'force',
'bondingOptions', 'implicitBonding'))
 self.networks[network] = cleanAttrs
-logging.info('Adding network %s(%s)', network, cleanAttrs)
+logging.info('Persisting network %s(%s)', network, cleanAttrs)
 
 def removeNetwork(self, network):
 try:
 del self.networks[network]
-logging.info('Removing network %s', network)
+logging.info('Removing network %s from persistence', network)
 except KeyError:
-logging.debug('Network %s not found for removal', network)
+logging.debug('Network %s not found for removal from persistence',
+  network)
 
 def setBonding(self, bonding, attributes):
 self.bonds[bonding] = attributes
-logging.info('Adding %s(%s)', bonding, attributes)
+logging.info('Persisting %s(%s)', bonding, attributes)
 
 def removeBonding(self, bonding):
 try:
 del self.bonds[bonding]
-logging.info('Removing %s', bonding)
+logging.info('Removing %s from persistence', bonding)
 except KeyError:
-logging.debug('%s not found for removal', bonding)
+logging.debug('%s not found for removal from persistence', bonding)
 
 def diffFrom(self, other):
 """Returns a diff Config that shows the what should be changed for


-- 
To view, visit https://gerrit.ovirt.org/57484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78a15d6218273619f96364ef6fcb77b910998ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Remove circular dependency

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: sdm: Remove circular dependency
..

sdm: Remove circular dependency

StorageDomain.get_volume_artifacts() was creating a circular dependency;
BlockSD and fileSD depend on volume_artifacts, volume_articats depend on
blockVolume, and blockVolume depend on blockSD. The results of this
circular dependency is not being to storageServerTests without importing
first blockSD, although this module is never used.

This patch removes the circular dependency by removing
StorageDomain.get_volume_class. Since volume_artifacts must depened on
old classes (mainly for using class methods), we cannot have old class
depend on it.

New factory method volume_artifacts.create() is used to create the
correct class for the current storage domain.

Change-Id: Ib5f005ed6111b8dd5f90d867aa6693aafe052c6a
Signed-off-by: Nir Soffer 
---
M tests/storage_sdm_create_volume_test.py
M tests/storage_volume_artifacts_test.py
M tests/storagetestlib.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sdm/api/create_volume.py
M vdsm/storage/sdm/volume_artifacts.py
7 files changed, 69 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/57483/1

diff --git a/tests/storage_sdm_create_volume_test.py 
b/tests/storage_sdm_create_volume_test.py
index c888158..11cad05 100644
--- a/tests/storage_sdm_create_volume_test.py
+++ b/tests/storage_sdm_create_volume_test.py
@@ -34,6 +34,7 @@
 from storage import fileVolume, sd
 from storage import resourceManager as rm
 from storage.resourceFactories import IMAGE_NAMESPACE
+from storage.sdm import volume_artifacts
 
 import storage.sdm.api.create_volume
 
@@ -62,10 +63,7 @@
 self.releaseDomainLock()
 
 def getVolumeClass(self):
-return fileVolume.FileVolumeMetadata
-
-def get_volume_artifacts(self, img_id, vol_id):
-return FakeVolumeArtifacts(self, img_id, vol_id)
+return fileVolume.FileVolumeManifest
 
 
 class FakeVolumeArtifacts(object):
@@ -103,8 +101,10 @@
 @contextmanager
 def _fake_env(self):
 self.rm = FakeResourceManager()
-with MonkeyPatchScope([(storage.sdm.api.create_volume, 'rmanager',
-self.rm)]):
+with MonkeyPatchScope([
+(storage.sdm.api.create_volume, 'rmanager', self.rm),
+(volume_artifacts, 'create', FakeVolumeArtifacts),
+]):
 yield
 
 def test_create_volume(self):
diff --git a/tests/storage_volume_artifacts_test.py 
b/tests/storage_volume_artifacts_test.py
index e0fe872..2487464 100644
--- a/tests/storage_volume_artifacts_test.py
+++ b/tests/storage_volume_artifacts_test.py
@@ -57,8 +57,7 @@
 
 def test_state_missing(self):
 with self.fake_env() as env:
-artifacts = env.sd_manifest.get_volume_artifacts(
-self.img_id, self.vol_id)
+artifacts = env.get_volume_artifacts(self.img_id, self.vol_id)
 self.assertFalse(artifacts.is_garbage())
 self.assertFalse(artifacts.is_image())
 self.assertRaises(AssertionError,
@@ -66,8 +65,7 @@
 
 def test_state_garbage_volatile_image_dir(self):
 with self.fake_env() as env:
-artifacts = env.sd_manifest.get_volume_artifacts(
-self.img_id, self.vol_id)
+artifacts = env.get_volume_artifacts(self.img_id, self.vol_id)
 artifacts.create(*BASE_RAW_PARAMS)
 self.assertTrue(artifacts.is_garbage())
 self.assertFalse(artifacts.is_image())
@@ -75,16 +73,14 @@
 
 def test_state_garbage_create_raises(self):
 with self.fake_env() as env:
-artifacts = env.sd_manifest.get_volume_artifacts(
-self.img_id, self.vol_id)
+artifacts = env.get_volume_artifacts(self.img_id, self.vol_id)
 artifacts.create(*BASE_RAW_PARAMS)
 self.assertRaises(se.DomainHasGarbage, artifacts.create,
   *BASE_RAW_PARAMS)
 
 def test_state_image(self):
 with self.fake_env() as env:
-artifacts = env.sd_manifest.get_volume_artifacts(
-self.img_id, self.vol_id)
+artifacts = env.get_volume_artifacts(self.img_id, self.vol_id)
 artifacts.create(*BASE_RAW_PARAMS)
 artifacts.commit()
 self.assertFalse(artifacts.is_garbage())
@@ -92,35 +88,29 @@
 
 def test_create_additional_vol_missing_parent_id(self):
 with self.fake_env() as env:
-first = env.sd_manifest.get_volume_artifacts(
-self.img_id, self.vol_id)
+first = env.get_volume_artifacts(self.img_id, self.vol_id)
 first.create(*BASE_RAW_PARAMS)
 first.commit()
-second = env.sd_manifest.get_volume_artifacts(
-self.img_id, str(uuid.uuid4()))

Change in vdsm[master]: sdm: Remove circular dependency

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Remove circular dependency
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f005ed6111b8dd5f90d867aa6693aafe052c6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: explain why we have to reset bonding options to default

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: explain why we have to reset bonding options to default
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72bea05213c8561367351749fd6b3831ebe77b9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 6:

Does it make more sense with https://gerrit.ovirt.org/#/c/57441/5 ?

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Separate broken test from good tests

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Separate broken test from good tests
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5963fcd0fb25fba6305045de80346fb0cfa3666b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Temporary hack around circular import

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Temporary hack around circular import
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bdf6b66c28cc25ef2baab426a7e1e1562258a7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Separate broken test from good tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Separate broken test from good tests
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5963fcd0fb25fba6305045de80346fb0cfa3666b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Temporary hack around circular import

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: storage: Temporary hack around circular import
..

storage: Temporary hack around circular import

Since the introducation of BlockVolumeArtifacts, it is not possible to
run the storageServerTests because of circular import dependency.

This is an ugly hack to make it possible to run these tests; the real
fix is to remove the circular dependency.

Change-Id: I4bdf6b66c28cc25ef2baab426a7e1e1562258a7a
Signed-off-by: Nir Soffer 
---
M tests/storageServerTests.py
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/57480/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index b2ce92d..9f2a753 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -24,6 +24,14 @@
 from testlib import permutations, expandPermutations
 from testlib import VdsmTestCase
 from testValidation import brokentest
+
+# Fix circular dependency
+from storage import blockSD, fileSD
+
+# Make pyflakes happy
+blockSD
+fileSD
+
 from storage.storageServer import GlusterFSConnection
 from storage.storageServer import IscsiConnection
 from storage.storageServer import MountConnection


-- 
To view, visit https://gerrit.ovirt.org/57480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bdf6b66c28cc25ef2baab426a7e1e1562258a7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Separate broken test from good tests

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: tests: Separate broken test from good tests
..

tests: Separate broken test from good tests

In commit 29fa0abb687d (storagetests: add a test for
normalize_local_path) we added a new failing test for path ending with
slash. To keep the build successful, the test was marked as @brokentest.
However, since this test uses permuations, all the tests were marked
broken, instead of only the new test.

Separate the failing tests from the other, so the good tests will fail
the build when they fail.

Change-Id: I5963fcd0fb25fba6305045de80346fb0cfa3666b
Signed-off-by: Nir Soffer 
---
M tests/storageServerTests.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/57481/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 9f2a753..7e0decd 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -75,7 +75,6 @@
 self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
 self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
 
-@brokentest
 @permutations([
 # spec, localpath
 ("server:/a/", "/tmp/server:_a"),
@@ -83,12 +82,16 @@
 ("server:/a/b", "/tmp/server:_a_b"),
 ("server:/a//b", "/tmp/server:_a_b"),
 ("server:/a/b_c", "/tmp/server:_a_b__c"),
-("server:/", "/tmp/server:_"),
 ])
 def test_normalize_local_path(self, spec, localpath):
 con = MountConnection(spec, mountClass=FakeMount)
 self.assertEqual(con._mount.fs_file, localpath)
 
+@brokentest("os.path.normpath used for mount spec")
+def test_normalize_slash(self, spec, localpath):
+con = MountConnection("server:/", mountClass=FakeMount)
+self.assertEqual(con._mount.fs_file, "/tmp/server:_")
+
 
 @expandPermutations
 class TestMountConnectionEquality(VdsmTestCase):


-- 
To view, visit https://gerrit.ovirt.org/57481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5963fcd0fb25fba6305045de80346fb0cfa3666b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Simplify Status class

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Simplify Status class
..


Patch Set 3: Continuous-Integration+1

CI failure not related.

-- 
To view, visit https://gerrit.ovirt.org/57428
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ce56d9a17547f8dfa49ee6f009589227c8761f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Port to Python 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: directio: Port to Python 3
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6f317df3efc70adb95063227c5e07513d34135
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Keep line terminators in readlines()

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: directio: Keep line terminators in readlines()
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d533b3811cfc7f642f6f0a081c61fe468946f3
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Require full blocks

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: directio: Require full blocks
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c13e322926c424b83ae09d9d427e71598f99f3b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Introduce vdsm.storage.directio module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Introduce vdsm.storage.directio module
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8557095df26d5a253088be07d0fdeb668ba59e58
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Modernize test names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Modernize test names
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib669c92dd0f81229e3f1f3afaa93a1861907890b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Keep line terminators in readlines()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Keep line terminators in readlines()
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d533b3811cfc7f642f6f0a081c61fe468946f3
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Replace magic number with constant

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Replace magic number with constant
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf89be2b776650ba189db9cca7bd1e2cfdd7b2a9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Add test for reading entire file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Add test for reading entire file
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54700
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55bf86d9d4c3f41e9ac338361d3bbada565f5898
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Add failing test for DirectFile.readlines()
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54694
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b487a6537efcf38e61a9170835124cab8821531
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Port to Python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Port to Python 3
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6f317df3efc70adb95063227c5e07513d34135
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Require full blocks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Require full blocks
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c13e322926c424b83ae09d9d427e71598f99f3b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Simplify DirectFile tests

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Simplify DirectFile tests
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic86b0fe22d5d5f1c9252b658ad76a13626de8246
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.outOfProcess

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.outOfProcess
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723200491287229da72edf5179e1646df9f40195
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Fix copyright years in storage.imagetickets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Fix copyright years in storage.imagetickets
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0abb7d2f8d2aa3f952cd37c3813afc696a4cef58
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.threadPool

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.threadPool
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.iscsiadm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.iscsiadm
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.imagetickets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.imagetickets
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91bc1c76ba3c6bd6ad79c7b4b751df7024c6f29b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.sdc

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.sdc
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage:  Move threadLocal module to vdsm storage lib
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Require full blocks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Require full blocks
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c13e322926c424b83ae09d9d427e71598f99f3b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Introduce vdsm.storage.directio module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Introduce vdsm.storage.directio module
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8557095df26d5a253088be07d0fdeb668ba59e58
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Add failing test for DirectFile.readlines()
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54694
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b487a6537efcf38e61a9170835124cab8821531
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Modernize test names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Modernize test names
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib669c92dd0f81229e3f1f3afaa93a1861907890b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Keep line terminators in readlines()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Keep line terminators in readlines()
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d533b3811cfc7f642f6f0a081c61fe468946f3
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Port to Python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Port to Python 3
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6f317df3efc70adb95063227c5e07513d34135
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Remove useless DirectFile.writelines()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Remove useless DirectFile.writelines()
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3e03c4d96f1862df2c5fec834cc3787145a3fa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Add test for reading entire file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Add test for reading entire file
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54700
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55bf86d9d4c3f41e9ac338361d3bbada565f5898
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Replace magic number with constant

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Replace magic number with constant
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf89be2b776650ba189db9cca7bd1e2cfdd7b2a9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: changed Makefile so that both python2 and pyhton3 wil...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: changed Makefile so that both python2 and pyhton3 will 
be default. That way, all tests (including new ones) will have to support 
python3 eventually.
..


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/57106/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-05-05 17:21:48 +0300
Line 4: Commit: Irit Goihman 
Line 5: CommitDate: 2016-05-15 18:38:39 +0300
Line 6: 
Line 7: tests: changed Makefile so that both python2 and pyhton3 will
try not to pass 80 characters in title
Line 8: be default.
Line 9: That way, all tests (including new ones) will have to support python3 
eventually.
Line 10: 
Line 11: Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043


Line 5: CommitDate: 2016-05-15 18:38:39 +0300
Line 6: 
Line 7: tests: changed Makefile so that both python2 and pyhton3 will
Line 8: be default.
Line 9: That way, all tests (including new ones) will have to support python3 
eventually.
and new line after 80characters in the commit itself
Line 10: 
Line 11: Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043


https://gerrit.ovirt.org/#/c/57106/4/tests/Makefile.am
File tests/Makefile.am:

Line 76
Line 77
Line 78
Line 79
Line 80
how is this related?


-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ceph: Require ceph-common when it is available

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: ceph: Require ceph-common when it is available
..


Patch Set 13: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
..


Patch Set 16: Code-Review+1 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
..


Patch Set 16:

ci -1 is not related.

-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ceph: Require ceph-common when it is available

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ceph: Require ceph-common when it is available
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ceph: Require ceph-common when it is available

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: ceph: Require ceph-common when it is available
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/42471/11/vdsm.spec.in
File vdsm.spec.in:

Line 140: %endif
Line 141: 
Line 142: %ifnarch ppc ppc64 ppc64le
Line 143: Requires: ceph-common
Line 144: %endif
> why here? I'd like to have under BuildRequires another separate section for
Addresses in latest version, please check.
Line 145: 
Line 146: %if 0%{?rhel}
Line 147: %if 0%{?centos}
Line 148: Requires: libguestfs-tools-c >= 1:1.28.1-1.55.el7.centos.2


-- 
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 30:

(2 comments)

https://gerrit.ovirt.org/#/c/53919/30/lib/api/schemaapi.py
File lib/api/schemaapi.py:

Line 36:'uint': lambda value: isinstance(value, int) and 
value >= 0}
Line 37: TYPE_KEYS = list(PRIMITIVE_TYPES.keys())
Line 38: 
Line 39: 
Line 40: default_values = {'{}': {},
default_values should be also ALL CAPS I guess..
Line 41:   '()': ()}
Line 42: 
Line 43: 
Line 44: class SchemaNotFound(Exception):


https://gerrit.ovirt.org/#/c/53919/30/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 17: from functools import partial
Line 18: try:
Line 19: from Queue import Queue
Line 20: except ImportError:  # py3
Line 21: from queue import Queue
can you move it to vdsm.compat ?
Line 22: from weakref import ref
Line 23: from threading import Lock, Event
Line 24: 
Line 25: from vdsm.compat import json


-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ceph: Require ceph-common when it is available

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ceph: Require ceph-common when it is available
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageServer: Remove dead code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storageServer: Remove dead code
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e827eb7c9e18d4bf521f2b415879c6142c433a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/54528/25/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 130: chopping off the ctor_args from the beginning of argObj.
Line 131: """
Line 132: print(argObj)
Line 133: allArgs = self._schema.get_arg_names(className, methodName)
Line 134: print(allArgs)
also here..
Line 135: 
Line 136: class_name = self._convert_class_name(className)
Line 137: if _glusterEnabled and class_name.startswith('Gluster'):
Line 138: ctorArgs = getattr(gapi, class_name).ctorArgs


-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Remove unused readspeed function

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: misc: Remove unused readspeed function
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57471
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaadbccb070e1a5e6537b1d58b2db85561e5b296
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sd: Introduce StorageDomainChecker

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sd: Introduce StorageDomainChecker
..


Patch Set 2:

Replaced by monitoring topic.

-- 
To view, visit https://gerrit.ovirt.org/54375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib801c54515baaa6b04098f97c8df70c711535200
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: coverage: Add vdsm-coverage sub package
..


Patch Set 5:

ping

-- 
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Refresh domains only if needed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Refresh domains only if needed
..


Patch Set 2:

* #1081962::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/53395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I974c26fb1af3594684e00a3f9e5d64d5bfaedecd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Refresh domains only if needed

[nsoffer]

Nir Soffer has abandoned this change.

Change subject: monitor: Refresh domains only if needed
..


Abandoned

We must keep refresh now, lot of stuff will break if we stop refreshing.

-- 
To view, visit https://gerrit.ovirt.org/53395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I974c26fb1af3594684e00a3f9e5d64d5bfaedecd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lvm: Simplify locking, increasing concurrency

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Simplify locking, increasing concurrency
..


Patch Set 3:

ping

-- 
To view, visit https://gerrit.ovirt.org/53540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86153c34c3ddc4055bb0679ce46aa48757d9cae1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.iscsiadm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.iscsiadm
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.outOfProcess

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.outOfProcess
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723200491287229da72edf5179e1646df9f40195
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.threadPool

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.threadPool
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move threadLocal module to vdsm storage lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage:  Move threadLocal module to vdsm storage lib
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1205799f8eca037b8b1963db62e1961684d3ce2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Fix copyright years in storage.imagetickets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Fix copyright years in storage.imagetickets
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0abb7d2f8d2aa3f952cd37c3813afc696a4cef58
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.imagetickets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.imagetickets
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91bc1c76ba3c6bd6ad79c7b4b751df7024c6f29b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Organize imports in storage.sdc

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Organize imports in storage.sdc
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Simplify DirectFile tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Simplify DirectFile tests
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic86b0fe22d5d5f1c9252b658ad76a13626de8246
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileUtils: Remove open_ex

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileUtils: Remove open_ex
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a26cdd857b845b7bbd58d302e231bb7d6c33e5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: directio: Add failing test for DirectFile.readlines()
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54694
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b487a6537efcf38e61a9170835124cab8821531
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Modernize test names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Modernize test names
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib669c92dd0f81229e3f1f3afaa93a1861907890b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileUtils: Remove the redundant "d" mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileUtils: Remove the redundant "d" mode
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54680
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23be87699af290bb20381219fe32d06bb79ba9b5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Replace magic number with constant

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Replace magic number with constant
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf89be2b776650ba189db9cca7bd1e2cfdd7b2a9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches