Change in vdsm[master]: API: modernize VM methods
Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py File vdsm/API.py: Line 37: from vdsm import supervdsm Line 38: from vdsm import throttledlog Line 39: from vdsm import jobs Line 40: from vdsm import v2v Line 41: from vdsm.common import api as wrapapi > Can we use the original name? I had a name clash. Not sure if it applies nowadays. Will try, and if still relevant I'll add a comment to explain. Line 42: from vdsm.host import api as hostapi Line 43: from vdsm.logUtils import AllVmStatsValue, Suppressed Line 44: from vdsm.storage import clusterlock Line 45: from vdsm.storage import misc Line 127: @contextmanager Line 128: def _vm_instance(self): Line 129: v = self._cif.vmContainer.get(self._UUID) Line 130: if not v: Line 131: raise exception.NoSuchVM() > Nice cleanup! Good idea, will implement. Line 132: yield v Line 133: Line 134: @wrapapi.method Line 135: def changeCD(self, driveSpec): -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
Yaniv Kaul has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 309: Line 310: Line 311: def _qcow2_compat(**kwargs): Line 312: sd_version = kwargs.get('version') Line 313: if sd_version == '4': >= 4 perhaps? Line 314: return _QCOW2_1_1 Line 315: value = config.get('irs', 'qcow2_compat') Line 316: if value not in _QCOW2_COMPAT_SUPPORTED: Line 317: raise exception.InvalidConfiguration( -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
gerrit-hooks has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
gerrit-hooks has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
Jenkins CI has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
gerrit-hooks has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
gerrit-hooks has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
Maor Lipchuk has uploaded a new change for review. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. .. [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. Add kwargs of storage domain metadata to indicate the appropriate qcow level to use for create and convert operations. Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Signed-off-by: Maor Lipchuk --- M lib/vdsm/qemuimg.py 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/64169/1 diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py index 53a02c7..213890b 100644 --- a/lib/vdsm/qemuimg.py +++ b/lib/vdsm/qemuimg.py @@ -46,6 +46,7 @@ VMDK = "vmdk" _QCOW2_COMPAT_SUPPORTED = ("0.10", "1.1") +_QCOW2_1_1 = "1.1" def supports_compat(compat): @@ -101,14 +102,14 @@ return info -def create(image, size=None, format=None, backing=None, backingFormat=None): +def create(image, size=None, format=None, backing=None, backingFormat=None, kwargs=None): cmd = [_qemuimg.cmd, "create"] cwdPath = None if format: cmd.extend(("-f", format)) if format == FORMAT.QCOW2: -cmd.extend(('-o', 'compat=' + _qcow2_compat())) +cmd.extend(('-o', 'compat=' + _qcow2_compat(kwargs))) if backing: if not os.path.isabs(backing): @@ -153,7 +154,7 @@ def convert(srcImage, dstImage, srcFormat=None, dstFormat=None, -backing=None, backingFormat=None): +backing=None, backingFormat=None, kwargs=None): cmd = [_qemuimg.cmd, "convert", "-p", "-t", "none", "-T", "none"] options = [] cwdPath = None @@ -166,7 +167,7 @@ if dstFormat: cmd.extend(("-O", dstFormat)) if dstFormat == FORMAT.QCOW2: -options.append('compat=' + _qcow2_compat()) +options.append('compat=' + _qcow2_compat(kwargs)) if backing: if not os.path.isabs(backing): @@ -306,7 +307,10 @@ raise QImgError(rc, out, err) -def _qcow2_compat(): +def _qcow2_compat(kwargs): +sd_version = kwargs.get('version') +if sd_version == '4': +return _QCOW2_1_1 value = config.get('irs', 'qcow2_compat') if value not in _QCOW2_COMPAT_SUPPORTED: raise exception.InvalidConfiguration( -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: config: Rename irs:scsi_settle_timeout option
Nir Soffer has posted comments on this change. Change subject: config: Rename irs:scsi_settle_timeout option .. Patch Set 1: ping -- To view, visit https://gerrit.ovirt.org/64064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I645bada21a95bd911ef47ce0358f467d064520a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: move define.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move define.py under common .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: add and use new devel logger
Nir Soffer has posted comments on this change. Change subject: logging: add and use new devel logger .. Patch Set 8: -Continuous-Integration Jenkins happy now -- To view, visit https://gerrit.ovirt.org/62209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: add and use new devel logger
Jenkins CI has posted comments on this change. Change subject: logging: add and use new devel logger .. Patch Set 8: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 7 -- To view, visit https://gerrit.ovirt.org/62209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: drop the warnings module configuration
Nir Soffer has posted comments on this change. Change subject: vdsm: drop the warnings module configuration .. Patch Set 7: Francesco, can you update the commit message? See comments in https://gerrit.ovirt.org/#/c/62212/4//COMMIT_MSG@10 -- To view, visit https://gerrit.ovirt.org/62212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: add and use new devel logger
Nir Soffer has posted comments on this change. Change subject: logging: add and use new devel logger .. Patch Set 8: Code-Review+2 Continuous-Integration+1 ci failure seems irellevent. -- To view, visit https://gerrit.ovirt.org/62209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
Edward Haas has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 8: Code-Review-1 (3 comments) Small things... I like the tests, very nice! https://gerrit.ovirt.org/#/c/63723/8/tests/network/func_bond_basic_test.py File tests/network/func_bond_basic_test.py: PS8, Line 112: # BZ 1372798 Why is this needed? This info exists in the source control history. PS8, Line 115: self.update_netinfo() Can you add a comment on why it is needed? In a week I will forget why it was done. PS8, Line 124: self._test_detach_used_bond_from_bridge() Calling this without a 'with'? What happens when it reaches the 'yield'? Can't you just call it with 'pass'? -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Remove python-argparse requirement
Nir Soffer has posted comments on this change. Change subject: Remove python-argparse requirement .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: log: Nicer logging format
Nir Soffer has posted comments on this change. Change subject: log: Nicer logging format .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup
Edward Haas has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG Commit Message: PS3, Line 18: fixies > fixes Done https://gerrit.ovirt.org/#/c/64118/3/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS3, Line 204: net_add_setup = ovs_switch.create_network_addition_setup(ovs_info) : net_add_setup.add(nets2add) : acq.acquire(net_add_setup.acquired_ifaces) > do we need to keep setup class here? it would be easier to read if it was a Initially I tried it in the same class (Setup), then decided to go with a separate class, dedicated for add (and another for remove). Main reasoning was the multiple inner small methods, with multiple shared data. I prefer a class that can save the data for the methods to use it, over passing a large number of arguments between the methods. The later is just too messy for me. -- To view, visit https://gerrit.ovirt.org/64118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup
gerrit-hooks has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Use Linux bonds with OVS networks
Edward Haas has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/63119/30/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS30, Line 82: but not successfully deployed (not saved in running config). > this should not be the problem now. the problem is when there is bond creat During the setup steps, the in-memory running config is updated, however, if an error/failure occurs in the middle, the config is not saved persistently, it is just used to revert back any partial changes. Therefore, the special handling here is still needed and has nothing to do with the atomicity of bond setup. -- To view, visit https://gerrit.ovirt.org/63119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
Nir Soffer has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py File lib/vdsm/virtsparsify.py: Line 64: :param vol_path: path to the volume Line 65: """ Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', vol_path] Line 67: Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'}) > I've asked Richard. He is against setting this flag and asks instead, if it Generally we should not use this flag, but in alignment scan case, after investing hours in debugging we did not have a choice. If this work without the flag we should not use this flag, if it does not work, we don't have a choice. To debug this, you should turn on libvirt debugging and open a bug with the results. Line 69: Line 70: if rc != 0: https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py File vdsm/storage/sdm/api/sparsify_volume.py: Line 22: Line 23: from vdsm import virtsparsify Line 24: from vdsm.storage import guarded Line 25: Line 26: from .copy_data import CopyDataDivEndpoint > I've asked Adam in e-mail about this: The idea is to both move the code and rename the schema. Lets see what Adam thinks about it. Line 27: Line 28: from . import base Line 29: Line 30: -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py File lib/vdsm/virtsparsify.py: Line 64: :param vol_path: path to the volume Line 65: """ Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', vol_path] Line 67: Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'}) > Also, do we have a virt-sparsify bug for this? We need a comment like this: I've asked Richard. He is against setting this flag and asks instead, if it is not working, to turn libvirt debugging on and collect the logs. So, what do you recommend - remove the setting as Richard asks or keep it because it works better? On my system, I didn't succeed to run virt-sparsify without this flag. Line 69: Line 70: if rc != 0: https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py File vdsm/storage/sdm/api/sparsify_volume.py: Line 27: Line 28: from . import base Line 29: Line 30: Line 31: class Job(base.Job): > Please keep empty line after the class declaration. Done Line 32: def __init__(self, job_id, host_id, vol_info): Line 33: super(Job, self).__init__(job_id, 'sparsify_volume', host_id) Line 34: self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True) Line 35: Line 30: Line 31: class Job(base.Job): Line 32: def __init__(self, job_id, host_id, vol_info): Line 33: super(Job, self).__init__(job_id, 'sparsify_volume', host_id) Line 34: self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True) > True is not clear, better use writable=True - see copy_data.Job.__init__. Done Line 35: Line 36: def _run(self): Line 37: with guarded.context(self._vol_info.locks): Line 38: with self._vol_info.prepare(): -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (7 comments) Thank you all for the comments and suggestions, I hope things get clarified and we can make a progress. If we can agree on using default value argument in *find* then the major concept issues are probably resolved. Let's also not forget we can either discard the API or continue using it after the final switch to etree. I prefer making a clean API, because in case we decide to keep it or we stop before the final switch to etree for some serious reason, we can use the API without worries. But even then the API needn't be engraved into a stone at this moment, I think making progress beyond this patch is more important. https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 78: result = [element] + result Line 79: return result Line 80: Line 81: Line 82: def dom_find_tag(element, tag, index=0): > I'm not convinced by the argument about common patterns in client code. I also don't like having both find_xxx and require_xxx, although for slightly different reasons: 1. It's unnecessary to double the number of helpers when we can simply use an argument; 2. it's easy to miss that find_xxx may return None. I like the suggestion about having a default argument. It solves all the problems (and obsoletes the need for `required' argument). Line 83: """ Line 84: Find a DOM element specified by given arguments. Line 85: Line 86: :param element: DOM object to be searched for given `tag` Line 98: except IndexError: Line 99: return None Line 100: Line 101: Line 102: def dom_find_attr(element, tag, attribute=True, index=0): > Why have an api accepting element when we want to find the attribute of a s Because dom_find_attr(element, 'foo', 'bar') is easier to use than dom_attr(dom_find_tag(element, 'foo'), 'bar') or tag_element = dom_find_tag(element, 'foo') dom_attr(tag_element, 'bar') or even tag_element = dom_find_tag(element, 'foo', default=None) if tag_element is not None: dom_attr(tag_element, 'bar') (consider something like if dom_find_attr(element, 'foo', 'bar', default=None) == 'baz': ... ) Line 103: """ Line 104: Find attribute values of a DOM element specified by given arguments. Line 105: Line 106: :param element: DOM object to be searched for given `tag` Line 125: if subelement is None: Line 126: if isinstance(attribute, basestring): Line 127: return '' Line 128: else: Line 129: return {} > Why we should care about argument type? Why should be return different retu It's too complicated, I should use separate methods here instead of switching on the argument type. Line 130: return dom_attr(subelement, attribute) Line 131: Line 132: Line 133: def dom_tag(element): Line 139: :returns: tag of the element Line 140: :rtype: basestring Line 141: Line 142: """ Line 143: return element.tagName > Why do we need this? what is the etree way that this should hide? We need it for the minidom->etree transition period (at least), because it's different in minidom and etree. Line 144: Line 145: Line 146: def dom_attr(element, attribute): Line 147: """ Line 151: :type element: DOM object Line 152: :param attribute: attribute name to look for, or a sequence of attribute Line 153: names to look for, or True to return all attribute values of the given Line 154: element Line 155: :type attribute: basestring, or sequence of basestrings, or True > Please accept only one type for attribute, this does not make any sense. Ac I agree, it should be split into two helpers: 1. for retrieving just a simple attribute; 2. for retrieving multiple attributes, perhaps in the way you suggest in another comment. Line 156: :returns: the corresponding attribute values or empty string (if Line 157: `attribute` is basestring and no corresponding attribute is found) Line 158: :rtype: basestring if `attribute` is string; dictionary of Line 159: attribute names as keys and their corresponding values otherwise Line 180: :rtype: basestring or NoneType Line 181: Line 182: """ Line 183: if element is None: Line 184: return None > This is very bad idea, result of having functions returning None. The calle OK, I think it's used in only two places now so it doesn't matter much and we can add the extra condition to that places. Line 185: child_node = element.firstChild Line 186: if child_node is None: Line 187: return None Line 188: return child_node.nodeValue Line 184: return None Line 185: child_node = element.firstChild Line 186: if child_node is None: Line 187: return None Line 188: return child_node.nodeValue > Why
Change in vdsm[master]: lib: api: allow to return prebuilt responses
Francesco Romani has posted comments on this change. Change subject: lib: api: allow to return prebuilt responses .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/61474/12/lib/vdsm/common/api.py File lib/vdsm/common/api.py: Line 63: return ret Line 64: else: Line 65: _log.debug("FINISH %s response=%s", func.__name__, ret) Line 66: if ret is None: Line 67: return response.success() > Here: No real good reason, fixing Line 68: else: -- To view, visit https://gerrit.ovirt.org/61474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: response: helper to detect valid responses
Francesco Romani has posted comments on this change. Change subject: lib: response: helper to detect valid responses .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py File lib/vdsm/common/response.py: Line 85: else: Line 86: return code != doneCode["code"] Line 87: Line 88: Line 89: def is_valid(res): > Lets add the docstring? Done, eventually. Line 90: # catching AttributeError is even uglier Line 91: if not isinstance(res, dict): Line 92: return False Line 93: try: -- To view, visit https://gerrit.ovirt.org/63760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: api.py: preserve signature in decorator
Francesco Romani has posted comments on this change. Change subject: lib: api.py: preserve signature in decorator .. Patch Set 13: Verified+1 schemaValidation passes with this patch. -- To view, visit https://gerrit.ovirt.org/63759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Remove python-argparse requirement
Yaniv Bronhaim has posted comments on this change. Change subject: Remove python-argparse requirement .. Patch Set 1: cstratak reached me in irc as python maintainer and asked to remove this requirement from our spec now when its part of stdlib. it used to be Provides by python2.7 so we it was redundant anyway. but now he wants to remove this Provides as he plans to rename it to python2-argparse and this will break our build -- To view, visit https://gerrit.ovirt.org/64162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Remove python-argparse requirement
Yaniv Bronhaim has uploaded a new change for review. Change subject: Remove python-argparse requirement .. Remove python-argparse requirement This package has been obsoleted in Fedora because it got in to stdlib. Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Signed-off-by: Yaniv Bronhaim --- M vdsm.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/64162/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index c09b9a9..abe5f7e 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -138,7 +138,6 @@ Requires: PyYAML Requires: python-netaddr Requires: python-inotify -Requires: python-argparse Requires: python-cpopen >= 1.4 Requires: python-ioprocess >= 0.16.1-1 Requires: python-pthreading >= 0.1.3-3 -- To view, visit https://gerrit.ovirt.org/64162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Remove python-argparse requirement
gerrit-hooks has posted comments on this change. Change subject: Remove python-argparse requirement .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: draft: Hook nic_libvirt_migration_destination, proposal 2
gerrit-hooks has posted comments on this change. Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/63686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60e4cc7f801033cc830aa1a0aad32afecafe4fea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: draft: Hook nic_libvirt_migration_destination, proposal 2
Marcin Mirecki has abandoned this change. Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2 .. Abandoned -- To view, visit https://gerrit.ovirt.org/63686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I60e4cc7f801033cc830aa1a0aad32afecafe4fea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...
gerrit-hooks has posted comments on this change. Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/63684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...
Marcin Mirecki has abandoned this change. Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1 .. Abandoned -- To view, visit https://gerrit.ovirt.org/63684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
Petr Horáček has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 8: Verified+1 Passed network/*_test.py and functional/networkTests.py OK. Without introduced ifcfg.py change, new test fails. -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Inform Engine about switching to post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Inform Engine about switching to post-copy .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281ec36a6bd65b816afbdeef79205e6241d4a27c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Prevent monitoring of VMs in post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Prevent monitoring of VMs in post-copy .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I010d3311ce497081720a871e2a3c715f53dcb299 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Add info about post-copy to UP event after migration
gerrit-hooks has posted comments on this change. Change subject: virt: Add info about post-copy to UP event after migration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ff575e3bf43c9ccfe8c5fbf5c5be17da452fcb1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Report paused VM status in post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Report paused VM status in post-copy .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4738a7519f8d1af2ee30bfe766f3407853263cf2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between migration completion kinds
gerrit-hooks has posted comments on this change. Change subject: virt: Distinguish between migration completion kinds .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff88aa0aaa88b34167bb671a56f2cc09c122ab6f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Fetch only minimum VM stats during post-copy migration
gerrit-hooks has posted comments on this change. Change subject: virt: Fetch only minimum VM stats during post-copy migration .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac3da08b0816e7a9a247969147c17b15518c7624 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Report downtime after a post-copy migration
gerrit-hooks has posted comments on this change. Change subject: virt: Report downtime after a post-copy migration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f34e1ff577db325cc976431b3570f91833ff815 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...
gerrit-hooks has posted comments on this change. Change subject: virt: Distinguish between switching to and entering post-copy migration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Stop guest agent before switching to post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Stop guest agent before switching to post-copy .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd855ee36847b293009ac35d8d03b01521aaace8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Use a variable for self._vm in MonitorThread action ha...
gerrit-hooks has posted comments on this change. Change subject: virt: Use a variable for self._vm in MonitorThread action handling .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Destroy VM after failed post-copy migration
gerrit-hooks has posted comments on this change. Change subject: virt: Destroy VM after failed post-copy migration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1918e9afce189c8b3f617766e55afa13f1e153f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Refuse to cancel post-copy migrations
gerrit-hooks has posted comments on this change. Change subject: virt: Refuse to cancel post-copy migrations .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
gerrit-hooks has posted comments on this change. Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id93bec2881040566261cc6ffaeb8df97eef477a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...
gerrit-hooks has posted comments on this change. Change subject: virt: Start all VM related stuff after switching to post-copy migration .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
Francesco Romani has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib
Petr Horáček has posted comments on this change. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup
Petr Horáček has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/64118/3//COMMIT_MSG Commit Message: PS3, Line 18: fixies fixes https://gerrit.ovirt.org/#/c/64118/3/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS3, Line 204: net_add_setup = ovs_switch.create_network_addition_setup(ovs_info) : net_add_setup.add(nets2add) : acq.acquire(net_add_setup.acquired_ifaces) do we need to keep setup class here? it would be easier to read if it was a plain function: acquired_ifaces = ovs_switch.add_networks(networks, ovs_info) -- To view, visit https://gerrit.ovirt.org/64118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 8: * #1372798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1372798::OK, public bug * Check Product::#1372798::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Simone Tiraboschi has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Code-Review+1 +1 for me, I agree to take the python way for it. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Martin Sivák has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > and if you don't you'll never see it. so for what? you can just write it to The whole point is to allow interested developers or users (or automation) to see it without bothering users, who can do nothing to solve it anyway. Nir already pointed out that it is the same approach Python itself uses. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 7: * #1372798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1372798::OK, public bug * Check Product::#1372798::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Use Linux bonds with OVS networks
Petr Horáček has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 31: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63119/30/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS30, Line 82: but not successfully deployed (not saved in running config). this should not be the problem now. the problem is when there is bond created with OVS but not attached to any network=bridge. maybe it is not even needed now when all bonds operations are atomic (right?) -- To view, visit https://gerrit.ovirt.org/63119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: move exception.py under common
Nir Soffer has posted comments on this change. Change subject: lib: move exception.py under common .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase
Freddy Rolland has posted comments on this change. Change subject: vm: Remove unneeded fallback to blockRebase .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py File vdsm/storage/sdm/api/sparsify_volume.py: Line 22: Line 23: from vdsm import virtsparsify Line 24: from vdsm.storage import guarded Line 25: Line 26: from .copy_data import CopyDataDivEndpoint > Importing from another verb is ugly. Since CopyDataDivEndpoint is reusable, I've asked Adam in e-mail about this: Me: It will not look good to import copy_data.py from sparsify_volume.py. So, we need to move CopyDataDIVEndpoint to some common place. What place should it be? Adam: For your first patch could you just try and do: from copy_data import CopyDataDIVEndpoint I want to keep the same names as in the schema for clarity. Later on, we can move the implementation of CopyDataDIVEndpoint out to a common module if necessary but I don't want to delay your verb for this. We are simultaneously making improvements to CopyDataDIVEndpoint (locking, etc) and it will be easier to continue development in its current location for now. Line 27: Line 28: from . import base Line 29: Line 30: -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup
gerrit-hooks has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib
gerrit-hooks has posted comments on this change. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Use Linux bonds with OVS networks
gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 31: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib
Edward Haas has posted comments on this change. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG Commit Message: PS1, Line 14: bonbs > bonds Done https://gerrit.ovirt.org/#/c/64131/1/tests/network/nettestlib.py File tests/network/nettestlib.py: PS1, Line 487: " > ' please Done -- To view, visit https://gerrit.ovirt.org/64131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib
Petr Horáček has posted comments on this change. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/64131/1//COMMIT_MSG Commit Message: PS1, Line 14: bonbs bonds https://gerrit.ovirt.org/#/c/64131/1/tests/network/nettestlib.py File tests/network/nettestlib.py: PS1, Line 487: " ' please -- To view, visit https://gerrit.ovirt.org/64131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Petr Horáček has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
Petr Horáček has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 6: Verified+1 The added test fails without ifcfg changes, passes with them. -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 6: * #1372798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1372798::OK, public bug * Check Product::#1372798::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib
gerrit-hooks has posted comments on this change. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup
gerrit-hooks has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Use Linux bonds with OVS networks
gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 30: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Relocate sysfs_bond_permission to nettestlib
Edward Haas has uploaded a new change for review. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. net: Relocate sysfs_bond_permission to nettestlib CI does not always allow access to sysfs and will fail the tests when such access is attempted. Linux bonds driver is using sysfs to configure bonds. This patch locates the sysfs bond access permission check under nettestlib in order to allow several test modules to use it when bonbs are involved. Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Signed-off-by: Edward Haas --- M tests/network/link_bond_test.py M tests/network/nettestlib.py 2 files changed, 20 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/64131/1 diff --git a/tests/network/link_bond_test.py b/tests/network/link_bond_test.py index a610f63..021fda8 100644 --- a/tests/network/link_bond_test.py +++ b/tests/network/link_bond_test.py @@ -21,21 +21,18 @@ from contextlib import contextmanager from nose.plugins.attrib import attr -from nose.plugins.skip import SkipTest from testlib import VdsmTestCase as TestCaseBase -from .nettestlib import dummy_devices +from .nettestlib import dummy_devices, check_sysfs_bond_permission from vdsm.network.link import iface from vdsm.network.link.bond import Bond -from vdsm.network.link.bond import BondSysFS from vdsm.utils import random_iface_name def setup_module(): -if not _has_sysfs_bond_permission(): -raise SkipTest("This test requires sysfs bond write access") +check_sysfs_bond_permission() @attr(type='integration') @@ -112,13 +109,3 @@ yield bond finally: bond.destroy() - - -def _has_sysfs_bond_permission(): -bond = BondSysFS(random_iface_name('check_', max_length=11)) -try: -bond.create() -bond.destroy() -except IOError: -return False -return True diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py index df66d53..42673af 100644 --- a/tests/network/nettestlib.py +++ b/tests/network/nettestlib.py @@ -38,10 +38,10 @@ from vdsm.network.ipwrapper import ( addrAdd, linkSet, linkAdd, linkDel, IPRoute2Error, netns_add, netns_delete, netns_exec) -from vdsm.network.link import iface as linkiface +from vdsm.network.link import iface as linkiface, bond as linkbond from vdsm.network.netlink import monitor from vdsm.commands import execCmd -from vdsm.utils import CommandPath, random_iface_name +from vdsm.utils import CommandPath, memoized, random_iface_name from . import dhcp from . import firewall @@ -480,3 +480,19 @@ yield finally: shutil.copy2(RESOLV_CONF_BACKUP, RESOLV_CONF) + + +def check_sysfs_bond_permission(): +if not _has_sysfs_bond_permission(): +raise SkipTest("This test requires sysfs bond write access") + + +@memoized +def _has_sysfs_bond_permission(): +bond = linkbond.BondSysFS(random_iface_name('check_', max_length=11)) +try: +bond.create() +bond.destroy() +except IOError: +return False +return True -- To view, visit https://gerrit.ovirt.org/64131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f5016d8453d021d663fe293e17edf87b24c215d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Rely on system for logrotation
Nir Soffer has posted comments on this change. Change subject: vdsm: Rely on system for logrotation .. Patch Set 3: Please send another patch documenting why we are not using logrotate in the standard way, with url to the relevant bugs. -- To view, visit https://gerrit.ovirt.org/63682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
gerrit-hooks has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: mount: Wait for systemd temporary mount unit
Dan Kenigsberg has submitted this change and it was merged. Change subject: mount: Wait for systemd temporary mount unit .. mount: Wait for systemd temporary mount unit Systemd is monitoring mountpoints created during runtime by creating a temporary mount units. For example: # systemctl status /tmp/mount-1.DUNxySxI2R/wrk ● tmp-mount\x2d1.DUNxySxI2R-wrk.mount - /tmp/mount-1.DUNxySxI2R/wrk Loaded: loaded (/proc/self/mountinfo) Active: active (mounted) since Sun 2016-04-24 22:37:55 IDT; 14ms ago Where: /tmp/mount-1.DUNxySxI2R/wrk What: /dev/loop2 Mounting and unmounting quickly as we do in the tests, or when creating a floppy image may confuse systemd, and lead to various errors: - mountpoint is not mounted when trying to access files or unmount - mountpoint is busy when trying to unmount These are probably systemd or mount bugs. Until these issues are resolve, we need to find a workaround to avoid failures in the tests or when creating a floppy images. This patch add udevadm.settle() call after successful mount and umount operations. Change-Id: I9b0318eb534f781f127882983527e1a221820478 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/56544 Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/storage/mount.py M tests/mkimageTests.py M tests/mountTests.py 3 files changed, 18 insertions(+), 16 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Tomas Golembiovsky has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Yaniv, you are trying to force your warnings on other developers. We are trying to help developers using our software, not punish them or their users. We can add python warnings, we can add warnings in documentation, add release notes etc. We cannot spam people stderr or logs with unrelated warnings. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
gerrit-hooks has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Jenkins CI has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Nir Soffer has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64123/1//COMMIT_MSG Commit Message: Line 6: Line 7: alignmentScan: Use proper environment Line 8: Line 9: In commit f9d12864a404 (v2v: Running virt-v2v with some sane Line 10: environment) we leaned that we should not use bare environment dict. > Typo? Yes, thanks for reading this Line 11: This patch fixes the environment when running virt-alignment-scan. Line 12: Line 13: Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Tomas Golembiovsky has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 1: (1 comment) Just a typo in commit message. Other than that LGTM. https://gerrit.ovirt.org/#/c/64123/1//COMMIT_MSG Commit Message: PS1, Line 10: leaned Typo? -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: **WIP** tool: reconfigure containers networks
gerrit-hooks has posted comments on this change. Change subject: **WIP** tool: reconfigure containers networks .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
gerrit-hooks has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Tal Nisan has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
Francesco Romani has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 18: code coverage is pretty good: 00:08:20.964 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/__init__ 41 0 100% 00:08:21.142 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/command 120 794% 46, 185-186, 197, 205, 208, 211 00:08:21.143 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/config/__init__ 18 0 100% 00:08:21.143 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/config/environ 17 0 100% 00:08:21.143 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/config/network 17 0 100% 00:08:21.144 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/connection 47 296% 83, 86 00:08:21.144 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/domain 100 0 100% 00:08:21.144 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/doms 20 0 100% 00:08:21.144 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/errors 8 0 100% 00:08:21.145 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/events 50 0 100% 00:08:21.145 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/fs 16 288% 38-39 00:08:21.145 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/metrics/__init__ 2 0 100% 00:08:21.146 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/metrics/cgroups 88 298% 51, 172 00:08:21.146 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/monitoring 13 0 100% 00:08:21.146 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runner 70 0 100% 00:08:21.147 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtime 64 0 100% 00:08:21.147 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/__init__ 141 696% 119, 187, 216, 219, 223, 229 00:08:21.147 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/docker 36 0 100% 00:08:21.148 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/fake 35 0 100% 00:08:21.148 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/runtimes/rkt 133 298% 156, 168 00:08:21.148 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/xmlconstants 9 0 100% 00:08:21.148 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/lib/vdsm/virt/containers/xmlfile 33 0 100% -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
Francesco Romani has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 18: Verified+1 this patch adds only tests, so as long as juenkins is happy, so we are. -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Rely on system for logrotation
Tomas Golembiovsky has posted comments on this change. Change subject: vdsm: Rely on system for logrotation .. Patch Set 3: Code-Review-1 Thanks Dan. Somehow I have missed this change when browsing through related history. If we really can generate more than 15 MB of logs per day and we want to run logrotate hourly (as opposed to daily by the system) then it makes sense to stick with what we do now. In this case we can abandon this change. -- To view, visit https://gerrit.ovirt.org/63682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: lib: move the response.py under common
Francesco Romani has posted comments on this change. Change subject: lib: move the response.py under common .. Patch Set 3: Junkins failure is unrelated: DEBUG package_manager.py:96: ['/usr/bin/yum-deprecated', '--installroot', '/var/lib/mock/epel-7-x86_64-dcebbf316d769782f44acc0ef5f2397b-31868/root/', '--releasever', '7', 'install', '@buildsys-build'] DEBUG util.py:567: child environment: None DEBUG util.py:499: Executing command: ['/usr/bin/yum-deprecated', '--installroot', '/var/lib/mock/epel-7-x86_64-dcebbf316d769782f44acc0ef5f2397b-31868/root/', '--releasever', '7', 'install', '@buildsys-build', '--setopt=tsflags=nocontexts'] with env {'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'LD_PRELOAD': '/tmp/tmpg21g8hqp/$LIB/nosync.so', 'LANG': 'en_US.UTF-8', 'HOME': '/builddir', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'TERM': 'vt100', 'LC_MESSAGES': 'C'} and shell False DEBUG util.py:421: Yum command has been deprecated, use dnf instead. DEBUG util.py:421: See 'man dnf' and 'man yum2dnf' for more information. DEBUG util.py:421: http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/49b8ba752141a73495c14e1fbf11e910209fddf08caacef99d3bb5cbc979d339-updateinfo.xml.bz2: [Errno 14] HTTP Error 404 - Not Found DEBUG util.py:421: Trying other mirror. DEBUG util.py:421: http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz: [Errno 14] HTTP Error 404 - Not Found DEBUG util.py:421: Trying other mirror. DEBUG util.py:421: http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz: [Errno 14] HTTP Error 404 - Not Found DEBUG util.py:421: Trying other mirror. DEBUG util.py:421: http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz: [Errno 14] HTTP Error 404 - Not Found DEBUG util.py:421: Trying other mirror. DEBUG util.py:421: One of the configured repositories failed ("Custom epel"), DEBUG util.py:421: and yum doesn't have enough cached data to continue. At this point the only DEBUG util.py:421: safe thing yum can do is fail. There are a few ways to work "fix" this: DEBUG util.py:421: 1. Contact the upstream for the repository and get them to fix the problem. DEBUG util.py:421: 2. Reconfigure the baseurl/etc. for the repository, to point to a working DEBUG util.py:421: upstream. This is most often useful if you are using a newer DEBUG util.py:421: distribution release than is supported by the repository (and the DEBUG util.py:421: packages for the previous distribution release still work). DEBUG util.py:421: 3. Disable the repository, so yum won't use it by default. Yum will then DEBUG util.py:421: just ignore the repository until you permanently enable it again or use DEBUG util.py:421: --enablerepo for temporary usage: DEBUG util.py:421: yum-config-manager --disable epel DEBUG util.py:421: 4. Configure the failing repository to be skipped, if it is unavailable. DEBUG util.py:421: Note that yum will try to contact the repo. when it runs most commands, DEBUG util.py:421: so will have to try and fail each time (and thus. yum will be be much DEBUG util.py:421: slower). If it is a very temporary problem though, this is often a nice DEBUG util.py:421: compromise: DEBUG util.py:421: yum-config-manager --save --setopt=epel.skip_if_unavailable=true DEBUG util.py:421: failure: repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz from epel: [Errno 256] No more mirrors to try. DEBUG util.py:421: http://download.fedoraproject.org/pub/epel/7/x86_64/repodata/58c0449c85c258e5d9389d7ab796ea196c56cf13a5f12d7bbb020b8c3d8bc598-primary.sqlite.xz: [Errno 14] HTTP Error 404 - Not Found DEBUG util.py:546: Child return code was: 1 -- To view, visit https://gerrit.ovirt.org/63954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: utils: add is_kvm helper
Francesco Romani has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 33: Verified+1 trivial patch, covered by tests. -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
Nir Soffer has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py File lib/vdsm/virtsparsify.py: Line 64: :param vol_path: path to the volume Line 65: """ Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', vol_path] Line 67: Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'}) > Good point, we need the same fix here. Also, do we have a virt-sparsify bug for this? We need a comment like this: https://github.com/oVirt/vdsm/blob/master/vdsm/alignmentScan.py#L43 Line 69: Line 70: if rc != 0: -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
Nir Soffer has uploaded a new change for review. Change subject: alignmentScan: Use proper environment .. alignmentScan: Use proper environment In commit f9d12864a404 (v2v: Running virt-v2v with some sane environment) we leaned that we should not use bare environment dict. This patch fixes the environment when running virt-alignment-scan. Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Signed-off-by: Nir Soffer --- M vdsm/alignmentScan.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/64123/1 diff --git a/vdsm/alignmentScan.py b/vdsm/alignmentScan.py index 0957c05..3c72a9b 100644 --- a/vdsm/alignmentScan.py +++ b/vdsm/alignmentScan.py @@ -19,6 +19,7 @@ # +import os from collections import namedtuple from vdsm.utils import CommandPath from vdsm.storage.misc import execCmd @@ -40,10 +41,12 @@ def runScanArgs(*args): cmd = [_virtAlignmentScan.cmd] cmd.extend(args) -# TODO: remove the environment variable when the issue in +# TODO: remove the environment when the issue in # virt-alignment-scan/libvirt is resolved # http://bugzilla.redhat.com/1151838 -return execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'}) +env = os.environ.copy() +env['LIBGUESTFS_BACKEND'] = 'direct' +return execCmd(cmd, env=env) def scanImage(image_path): -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: alignmentScan: Use proper environment
gerrit-hooks has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: enhance systemd_run
Francesco Romani has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 29: Verified+1 verified running patched Vdsm, and using the tests. -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: supervdsm: expose systemd utilities
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 29: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: core: containers: add the container support module
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 31: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: enhance systemd_run
gerrit-hooks has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 29: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: supervdsm: configure container networks
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 42: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 42 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org