Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/65696/6/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 35: from vdsm import supervdsm
Line 36: from vdsm.config import config
Line 37: from vdsm.network.netinfo.routes import getRouteDeviceTo
Line 38: from vdsm.network.errors import ConfigNetworkError
Line 39: from vdsm.network.ip.address import IPv6
we try hard to avoid interdependence between storage and network subtrees. You 
should either move the imported function to lib/vdsm/common, or -- since what 
you need is so simple -- redefine what you need right here.
Line 40: from vdsm.password import ProtectedPassword
Line 41: from vdsm.storage import devicemapper
Line 42: from vdsm.storage import misc
Line 43: 


Line 56: 
Line 57: log = logging.getLogger('storage.ISCSI')
Line 58: 
Line 59: 
Line 60: def getTargetString(portal, tpgt=None, iqn=None):
We need to improve the code coverage of tests. Please introduce a unit test for 
new functions.
Line 61: hostname = portal.hostname
Line 62: try:
Line 63: IPv6.validateAddress(hostname)
Line 64: hostname = "[%s]" % hostname


-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..


Patch Set 6:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: RPC support for IPv6 iSCSI targets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: RPC support for IPv6 iSCSI targets
..


Patch Set 2:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia31b045237dc2defc00181ef8a08cdaf808aa635
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 6:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[dholler]

Dominik Holler has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

[dholler]

Dominik Holler has posted comments on this change.

Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: RPC support for IPv6 iSCSI targets

[dholler]

Dominik Holler has posted comments on this change.

Change subject: storage: RPC support for IPv6 iSCSI targets
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia31b045237dc2defc00181ef8a08cdaf808aa635
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[dholler]

Dominik Holler has uploaded a new change for review.

Change subject: storage: prepare iscsi for IPv6 targets
..

storage: prepare iscsi for IPv6 targets

The used iscsiadm tool expects IPv6 addresses in square brackets if a
port is appended.

For this reason this patch encapsulates hostnames given as IPv6
addresses in square brackets.

Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Bug-Url: https://bugzilla.redhat.com/1308306
Signed-off-by: Dominik Holler 
---
M vdsm/storage/iscsi.py
1 file changed, 29 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/65696/5

diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py
index 4df844c..72320ff 100644
--- a/vdsm/storage/iscsi.py
+++ b/vdsm/storage/iscsi.py
@@ -35,6 +35,8 @@
 from vdsm import supervdsm
 from vdsm.config import config
 from vdsm.network.netinfo.routes import getRouteDeviceTo
+from vdsm.network.errors import ConfigNetworkError
+from vdsm.network.ip.address import IPv6
 from vdsm.password import ProtectedPassword
 from vdsm.storage import devicemapper
 from vdsm.storage import misc
@@ -53,6 +55,28 @@
 _iscsiadmTransactionLock = RLock()
 
 log = logging.getLogger('storage.ISCSI')
+
+def getTargetString(portal, tpgt=None, iqn=None):
+hostname = portal.hostname
+try:
+IPv6.validateAddress(hostname)
+hostname = "[%s]" % hostname
+except ConfigNetworkError:
+pass
+
+portalStr = "%s:%d" % (hostname, portal.port)
+
+if tpgt is None:
+tpgtStr = ""
+else:
+tpgtStr = ",%d" % tpgt
+
+if iqn is None:
+iqnStr= ""
+else:
+iqnStr = " %s" % iqn
+
+return "%s%s%s" % (portalStr, tpgtStr, iqnStr)
 
 
 def getDevIscsiSessionId(dev):
@@ -189,8 +213,7 @@
 # bounded iface. Explicitly specifying tpgt on iSCSI login imposes creation
 # of the node record in the new style format which enables to access a
 # portal through multiple ifaces for multipathing.
-portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port,
-  target.tpgt)
+portalStr = getTargetString(target.portal, target.tpgt)
 with _iscsiadmTransactionLock:
 iscsiadm.node_new(iface.name, portalStr, target.iqn)
 try:
@@ -216,8 +239,7 @@
 # Basically this command deleting a node record (see addIscsiNode).
 # Once we create a record in the new style format by specifying a tpgt,
 # we delete it in the same way.
-portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port,
-  target.tpgt)
+portalStr = getTargetString(target.portal, target.tpgt)
 with _iscsiadmTransactionLock:
 try:
 iscsiadm.node_disconnect(iface.name, portalStr, target.iqn)
@@ -230,7 +252,7 @@
 
 def addIscsiPortal(iface, portal, credentials=None):
 discoverType = "sendtargets"
-portalStr = "%s:%d" % (portal.hostname, portal.port)
+portalStr = getTargetString(portal)
 
 with _iscsiadmTransactionLock:
 iscsiadm.discoverydb_new(discoverType, iface.name, portalStr)
@@ -251,7 +273,7 @@
 
 def deleteIscsiPortal(iface, portal):
 discoverType = "sendtargets"
-portalStr = "%s:%d" % (portal.hostname, portal.port)
+portalStr = getTargetString(portal)
 iscsiadm.discoverydb_delete(discoverType, iface.name, portalStr)
 
 
@@ -259,7 +281,7 @@
 # Because proper discovery actually has to clear the DB having multiple
 # discoveries at once will cause unpredictable results
 discoverType = "sendtargets"
-portalStr = "%s:%d" % (portal.hostname, portal.port)
+portalStr = getTargetString(portal)
 
 with _iscsiadmTransactionLock:
 addIscsiPortal(iface, portal, credentials)


-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: RPC support for IPv6 iSCSI targets

[dholler]

Dominik Holler has uploaded a new change for review.

Change subject: storage: RPC support for IPv6 iSCSI targets
..

storage: RPC support for IPv6 iSCSI targets

HSM.discoverSendTargets uses iscsi.getTargetString, which already
supports IPv6 iSCSI targets, to encapsulate the iSCSI targets in a
string.

Change-Id: Ia31b045237dc2defc00181ef8a08cdaf808aa635
Bug-Url: https://bugzilla.redhat.com/1308306
Signed-off-by: Dominik Holler 
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/65736/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index e1d6d1e..50f7013 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2937,8 +2937,7 @@
 fullTargets = []
 partialTargets = []
 for target in targets:
-fullTargets.append("%s:%d,%d %s" %
-   (target.portal.hostname, target.portal.port,
+fullTargets.append(iscsi.getTargetString( target.portal,
 target.tpgt, target.iqn))
 partialTargets.append(target.iqn)
 


-- 
To view, visit https://gerrit.ovirt.org/65736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia31b045237dc2defc00181ef8a08cdaf808aa635
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

[dholler]

Dominik Holler has uploaded a new change for review.

Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..

storage: iscsiadm parses IPv6 iSCSI addresses

Enables parsing of IPv6 iSCSI addresses during discovery.

Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02
Bug-Url: https://bugzilla.redhat.com/1308306
Signed-off-by: Dominik Holler 
---
M vdsm/storage/iscsiadm.py
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65707/5

diff --git a/vdsm/storage/iscsiadm.py b/vdsm/storage/iscsiadm.py
index 52a0083..2cfe6c5 100644
--- a/vdsm/storage/iscsiadm.py
+++ b/vdsm/storage/iscsiadm.py
@@ -31,6 +31,7 @@
 ISCSI_ERR_SESS_EXISTS = 15
 ISCSI_ERR_LOGIN_AUTH_FAILED = 24
 ISCSI_ERR_OBJECT_NOT_FOUND = 21
+ISCSI_HOST_IPV6_REGEX = re.compile(r"\[(.*)\]:([0-9]+)")
 
 Iface = namedtuple('Iface', 'ifacename transport_name hwaddress ipaddress \
 net_ifacename initiatorname')
@@ -239,11 +240,16 @@
 if rc == 0:
 res = []
 for line in out:
-if line.startswith("["):  # skip IPv6 targets
-continue
 rest, iqn = line.split()
 rest, tpgt = rest.split(",")
-ip, port = rest.split(":")
+if rest.startswith("["):
+# IPv6
+match = ISCSI_HOST_IPV6_REGEX.match(rest)
+ip = match.group(1)
+port = match.group(2)
+else:
+# IPv4
+ip, port = rest.split(":")
 res.append((ip, int(port), int(tpgt), iqn))
 
 return res


-- 
To view, visit https://gerrit.ovirt.org/65707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: bootstrap the livemerge tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: bootstrap the livemerge tests
..


Patch Set 10:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e3efd06a3d807d46e582ef1ba6548ab1c7e30f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: clientIF: rename recovery thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clientIF: rename recovery thread
..


Patch Set 2:

* Update Tracker::#1141422::OK, status: NEW
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1141422::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I489012786f3ebd76ef7adc4607645d095cbbc1a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: migration: coalesce join() into stop()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: coalesce join() into stop()
..


Patch Set 7:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62587
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6def55d50a61ac983b45e826c05e09887fe5ee0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: vm: migration: introduce virt subloggers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vm: migration: introduce virt subloggers
..


Patch Set 15:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2f9689fb5c0d0a80261aabed11eedbab358a491
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: shorten name of libvirt event thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: shorten name of libvirt event thread
..


Patch Set 2:

* Update Tracker::#1141422::OK, status: NEW
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1141422::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65501
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3dedfc52ad33f3d5f21a8154c248bb130b62ca7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: migration: use system thread names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: use system thread names
..


Patch Set 2:

* Update Tracker::#1141422::OK, status: NEW
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65503
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie03f19f75cb9430cd3a267817df269df776fa6a3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[automation]

gerrit-hooks has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 20:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: drop the bogus _getStats helper method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: API: drop the bogus _getStats helper method
..


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a5497013bffb676565508babd62b6f976d68233
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: a Down domain is not ready for commands

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: a Down domain is not ready for commands
..


Abandoned

so let's stick with 65131 for the time being

-- 
To view, visit https://gerrit.ovirt.org/65130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4620de494d410ee362e8f939e6ff59ef0f6185a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: refactor the monitorResponse handling

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: refactor the monitorResponse handling
..


Abandoned

overkill, we may want to use the new constants - but not now

-- 
To view, visit https://gerrit.ovirt.org/65539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic48d88dfd8cb1ad086be4b0e182fab02462f52c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check commands timeout only on steady state

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check commands timeout only on steady state
..


Patch Set 5:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/65505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafd83afa8ae7d0c6a172f8ceb872c2110eba1c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 25: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Calculate qcow volume size on import.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: image: Calculate qcow volume size on import.
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia87df2b0d5378f93c5cb2cc68a37458fe3b4467b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Calculate qcow volume size on import.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: image: Calculate qcow volume size on import.
..


Patch Set 2: -Verified

-- 
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia87df2b0d5378f93c5cb2cc68a37458fe3b4467b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: move valid states list in vmstatus.py

[fromani]

Francesco Romani has abandoned this change.

Change subject: virt: move valid states list in vmstatus.py
..


Abandoned

not now

-- 
To view, visit https://gerrit.ovirt.org/65538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I69b09501ac3984bdb59db31a48fd582d06975e3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: move valid states list in vmstatus.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: move valid states list in vmstatus.py
..


Patch Set 1:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/65538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69b09501ac3984bdb59db31a48fd582d06975e3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: a Down domain is not ready for commands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: a Down domain is not ready for commands
..


Patch Set 3:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/65130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4620de494d410ee362e8f939e6ff59ef0f6185a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: refactor the monitorResponse handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: refactor the monitorResponse handling
..


Patch Set 1:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/65539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48d88dfd8cb1ad086be4b0e182fab02462f52c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check commands timeout only on steady state

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: check commands timeout only on steady state
..


Abandoned

https://gerrit.ovirt.org/65727 is a better fix.

-- 
To view, visit https://gerrit.ovirt.org/65505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iafd83afa8ae7d0c6a172f8ceb872c2110eba1c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hsm:Use sd compat instead of qemu conf compat.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: hsm:Use sd compat instead of qemu conf compat.
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b19a99e5d9a73c011bf6d8079e3855298561b9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hsm:Use sd compat instead of qemu conf compat.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm:Use sd compat instead of qemu conf compat.
..


Patch Set 11:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b19a99e5d9a73c011bf6d8079e3855298561b9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 3:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 3:

Propagate review hook: Continuous Integration value inherited from patch 2

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 25:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 25:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: switch type switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: switch type switch
..


Patch Set 11:

* Update Tracker::IGNORE, not relevant for branch: master
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1362399::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storagetestlib: Add sdVersion param to the test API.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetestlib: Add sdVersion param to the test API.
..


Patch Set 4:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9759fa6d8b2bd7c359fd188d1e18ffbba5004941
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 3: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 3: Verified+1

verified injecting sleep() in the domDependentInit method, and checked that 
monitorResponse was reported '0' - thus OK- while the thread was sleeping.

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 6:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 7: Verified+1

verified with 65590

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 9:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 8:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 8:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 7: Verified+1

verified with 65590

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 24:

(3 comments)

https://gerrit.ovirt.org/#/c/64373/24/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 76: 
Line 77: @contextmanager
Line 78: def get_vols(self, storage_type, src_fmt, dst_fmt, chain_length=1,
Line 79:  size=DEFAULT_SIZE, sd_version=3, 
src_qcow2_compat='0.10'):
Line 80: with fake_env(storage_type, sd_version) as env:
> sd_version is a kwarg, please always call it sd_version=value
Done
Line 81: rm = FakeResourceManager()
Line 82: with MonkeyPatchScope([
Line 83: (guarded, 'context', fake_guarded_context()),
Line 84: (storage.sdm.api.copy_data, 'sdCache', env.sdcache),


Line 197: ('block', 'cow', 'cow', '1.1', 4),
Line 198: ('block', 'cow', 'cow', '0.10', 3),
Line 199: ))
Line 200: def test_volume_qcow2v3(self, env_type, src_fmt, dst_fmt, 
src_qcow2_compat,
Line 201: dst_sd_version):
> In this test we are actually testing coping in the same domain, so the sour
Done
Line 202: src_fmt = sc.name2type(src_fmt)
Line 203: dst_fmt = sc.name2type(dst_fmt)
Line 204: job_id = make_uuid()
Line 205: 


Line 220: job = storage.sdm.api.copy_data.Job(job_id, 0, source, 
dest)
Line 221: 
Line 222: job.run()
Line 223: wait_for_job(job)
Line 224: self.assertEqual(jobs.STATUS.DONE, job.status)
> Please add:
Added verify_qemu_chain(dst_chain)
Line 225: 
Line 226: def test_bad_vm_configuration_volume(self):
Line 227: """
Line 228: When copying a volume containing VM configuration information 
the


-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 2:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 5: Verified+1

works, but it is not enough to fix the bugs.

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 1:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 7:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 8:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 7:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: check stats timeout only for monitorable VMs
..

vm: check stats timeout only for monitorable VMs

We should adjust responsiveness for stats too old
only if a VM is monitorable, not inconditionally.
Otherwise we can have misreports on slow startup
or slow shutdowns.

Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1382578
Bug-Url: https://bugzilla.redhat.com/1382583
Signed-off-by: Francesco Romani 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 19 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/65727/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 603f4af..99a870c 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1343,6 +1343,7 @@
   'vmType': 'kvm', 'memSize': 1024}
 
 
+@expandPermutations
 class TestVmStats(TestCaseBase):
 
 DEV_BALLOON = [{'type': 'balloon', 'specParams': {'model': 'virtio'}}]
@@ -1414,8 +1415,14 @@
 
 @MonkeyPatch(vm, 'config',
  make_config([('vars', 'vm_command_timeout', '10')]))
-def testMonitorTimeoutResponsive(self):
+@permutations([
+# monitorable
+[True],
+[False],
+])
+def testMonitorTimeoutResponsive(self, monitorable):
 with fake.VM(_VM_PARAMS) as testvm:
+testvm._monitorable = monitorable  # accessing private field
 self.assertFalse(testvm.isMigrating())
 stats = {'monitorResponse': '0'}
 testvm._setUnresponsiveIfTimeout(stats, 1)  # any value < timeout
@@ -1423,13 +1430,20 @@
 
 @MonkeyPatch(vm, 'config',
  make_config([('vars', 'vm_command_timeout', '1')]))
-def testMonitorTimeoutUnresponsive(self):
+@permutations([
+# monitorable
+[True],
+[False],
+])
+def testMonitorTimeoutUnresponsive(self, monitorable):
 with fake.VM(_VM_PARAMS) as testvm:
+testvm._monitorable = monitorable  # accessing private field
 self.assertEqual(testvm._monitorResponse, 0)
 self.assertFalse(testvm.isMigrating())
 stats = {'monitorResponse': '0'}
 testvm._setUnresponsiveIfTimeout(stats, 10)  # any value > timeout
-self.assertEqual(stats['monitorResponse'], '-1')
+self.assertEqual(stats['monitorResponse'],
+ '0' if not monitorable else '-1')
 
 @MonkeyPatch(vm, 'config',
  make_config([('vars', 'vm_command_timeout', '10')]))
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6dedd20..ba19d7f 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4686,6 +4686,8 @@
 def _setUnresponsiveIfTimeout(self, stats, stats_age):
 if self.isMigrating():
 return
+if not self._monitorable:
+return
 # we don't care about decimals here
 if stats_age < config.getint('vars', 'vm_command_timeout'):
 return


-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 5:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report nested virtualization capabilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps: report nested virtualization capabilities
..


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: osinfo: memoize runtime_kernel_flags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: osinfo: memoize runtime_kernel_flags
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report nested virtualization capabilities

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: caps: report nested virtualization capabilities
..

caps: report nested virtualization capabilities

Nested virtualization capability can be easily queried without sysfs
and is necessary and sufficient to determine nested VT availability.
Moving this code to lib/osinfo also allows us to simplify nestedvt
hook - done as a part of this patch.

Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Signed-off-by: Martin Polednik 
---
M lib/api/vdsm-api.yml
M lib/vdsm/osinfo.py
M vdsm/caps.py
M vdsm_hooks/nestedvt/before_vm_start.py
4 files changed, 34 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/65717/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index e44e06a..88635e1 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -6496,6 +6496,13 @@
 name: realtimeKernel
 type: string
 added: '4.1'
+
+-   defaultvalue: no-default
+description: Indication whether the system is capable of nested
+virtualization (considers platform & module options).
+name: nestedVirtualization
+type: string
+added: '4.1'
 type: object
 
 VmShortStatus: 
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index bf2cd5f..d35eaca 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -27,6 +27,7 @@
 
 from collections import namedtuple
 
+from vdsm import cpuarch
 from vdsm import utils
 
 # For debian systems we can use python-apt if available
@@ -51,6 +52,8 @@
 
 
 KernelFlags = namedtuple('KernelFlags', 'version, realtime')
+NestedVirtualization = namedtuple('NestedVirtualization',
+  'enabled, kvm_module')
 
 
 class OSName:
@@ -260,3 +263,20 @@
 realtime = 'RT' in ret[3]
 
 return KernelFlags(dict(version=ver, release=rel), realtime)
+
+
+@utils.memoized
+def nested_virtualization():
+if cpuarch.is_ppc(cpuarch.real()):
+return NestedVirtualization(False, None)
+
+for kvm_module in ("kvm_intel", "kvm_amd"):
+kvm_module_path = "/sys/module/%s/parameters/nested" % kvm_module
+try:
+with open(kvm_module_path) as f:
+if f.readline().strip() in ("Y", "1"):
+return NestedVirtualization(True, kvm_module)
+except IOError:
+logging.debug('Could not determine status of nested '
+  'virtualization', exc_info=True)
+return NestedVirtualization(False, None)
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 57ea7e9..b12e6df 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -170,6 +170,8 @@
 caps['packages2'] = osinfo.package_versions()
 caps['realtimeKernel'] = str(
 osinfo.runtime_kernel_flags().realtime).lower()
+caps['nestedVirtualization'] = str(
+osinfo.nested_virtualization().enabled).lower()
 caps['emulatedMachines'] = machinetype.emulated_machines(
 cpuarch.effective())
 caps['ISCSIInitiatorName'] = _getIscsiIniName()
diff --git a/vdsm_hooks/nestedvt/before_vm_start.py 
b/vdsm_hooks/nestedvt/before_vm_start.py
index 5ea71f4..f245e3f 100755
--- a/vdsm_hooks/nestedvt/before_vm_start.py
+++ b/vdsm_hooks/nestedvt/before_vm_start.py
@@ -21,26 +21,19 @@
 
 import hooking
 
+from vdsm import osinfo
+
 cpu_nested_features = {
 "kvm_intel": "vmx",
 "kvm_amd": "svm",
 }
 
-for kvm_mod in ("kvm_intel", "kvm_amd"):
-kvm_mod_path = "/sys/module/%s/parameters/nested" % kvm_mod
-try:
-with open(kvm_mod_path) as f:
-if f.readline().strip() in ("Y", "1"):
-break
-except IOError:
-pass
-else:
-kvm_mod = None
+nestedvt = osinfo.nested_virtualization()
 
-if kvm_mod:
+if nestedvt.status:
 domxml = hooking.read_domxml()
 feature_vmx = domxml.createElement("feature")
-feature_vmx.setAttribute("name", cpu_nested_features[kvm_mod])
+feature_vmx.setAttribute("name", cpu_nested_features[nestedvt.kvm_module])
 feature_vmx.setAttribute("policy", "require")
 domxml.getElementsByTagName("cpu")[0].appendChild(feature_vmx)
 hooking.write_domxml(domxml)


-- 
To view, visit https://gerrit.ovirt.org/65717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report nested virtualization capabilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps: report nested virtualization capabilities
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: caps: report realtime kernel status
..

caps: report realtime kernel status

Determining whether system is suitable for RT operation is complex
task consisting of multiple variables. One of the necessary but
insufficient indications is RT_PREEMPT patch within running kernel,
as shown by "RT" string within kernel's release string.

We now report realtimeKernel in caps, using os.uname() to gather
information about runtime kernel; allowing engine to act based on
this information.

Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Signed-off-by: Martin Polednik 
---
M lib/api/vdsm-api.yml
M lib/vdsm/osinfo.py
M vdsm/caps.py
3 files changed, 19 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/65715/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index f311b17..e44e06a 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -6489,6 +6489,13 @@
 name: kernelArgs
 type: string
 added: '4.0'
+
+-   defaultvalue: no-default
+description: Indication whether the running kernel is compiled
+with RT_PREEMPT enabled
+name: realtimeKernel
+type: string
+added: '4.1'
 type: object
 
 VmShortStatus: 
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index 23bb2c2..f5342a4 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -25,6 +25,8 @@
 import logging
 import os
 
+from collections import namedtuple
+
 from vdsm import utils
 
 # For debian systems we can use python-apt if available
@@ -46,6 +48,9 @@
 glusterEnabled = True
 except ImportError:
 glusterEnabled = False
+
+
+KernelFlags = namedtuple('KernelFlags', 'version, realtime')
 
 
 class OSName:
@@ -178,7 +183,7 @@
 
 
 def package_versions():
-pkgs = {'kernel': _runtime_kernel_version()}
+pkgs = {'kernel': runtime_kernel_flags().version}
 
 if _release_name() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA,
OSName.RHEL, OSName.POWERKVM):
@@ -243,7 +248,7 @@
 return pkgs
 
 
-def _runtime_kernel_version():
+def runtime_kernel_flags():
 ret = os.uname()
 try:
 ver, rel = ret[2].split('-', 1)
@@ -251,4 +256,6 @@
 logging.error('kernel release not found', exc_info=True)
 ver, rel = '0', '0'
 
-return dict(version=ver, release=rel)
+realtime = 'RT' in ret[3]
+
+return KernelFlags(dict(version=ver, release=rel), realtime)
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 703b500..57ea7e9 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -168,7 +168,8 @@
 caps['operatingSystem'] = osinfo.version()
 caps['uuid'] = host.uuid()
 caps['packages2'] = osinfo.package_versions()
-caps['kernelArgs'] = osinfo.kernel_args()
+caps['realtimeKernel'] = str(
+osinfo.runtime_kernel_flags().realtime).lower()
 caps['emulatedMachines'] = machinetype.emulated_machines(
 cpuarch.effective())
 caps['ISCSIInitiatorName'] = _getIscsiIniName()


-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: osinfo: memoize runtime_kernel_flags

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: osinfo: memoize runtime_kernel_flags
..

osinfo: memoize runtime_kernel_flags

Unless magic is involved, we don't expect the underlying kernel to
change. Memoize to save uname calls.

Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31
Signed-off-by: Martin Polednik 
---
M lib/vdsm/osinfo.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/65716/1

diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index f5342a4..bf2cd5f 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -248,6 +248,7 @@
 return pkgs
 
 
+@utils.memoized
 def runtime_kernel_flags():
 ret = os.uname()
 try:


-- 
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 7:

The test failure is interesting but unrelated

00:15:56.269 
==
00:15:56.269 ERROR: test_schedule_after() (scheduleTests.SchedulerTests)
00:15:56.269 
--
00:15:56.269 Traceback (most recent call last):
00:15:56.269   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/testlib.py",
 line 86, in wrapper
00:15:56.269 return f(self, *args)
00:15:56.269   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/scheduleTests.py",
 line 59, in test_schedule_after
00:15:56.269 self.assertTrue(deadline <= task1.call_time)
00:15:56.270 TypeError: unorderable types: float() <= NoneType()
00:15:56.270  >> begin captured logging << 

00:15:56.270 2016-10-20 09:23:51,221 DEBUG   (MainThread) [Scheduler] Starting 
scheduler Scheduler (schedule:98)
00:15:56.270 2016-10-20 09:23:51,227 DEBUG   (Scheduler) [Scheduler] started 
(schedule:140)
00:15:56.270 2016-10-20 09:23:51,625 DEBUG   (MainThread) [Scheduler] Stopping 
scheduler Scheduler (schedule:110)
00:15:56.270 2016-10-20 09:23:51,955 DEBUG   (Scheduler) [Scheduler] stopped 
(schedule:14

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 10: Verified+1

(3 comments)

https://gerrit.ovirt.org/#/c/64502/8/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 43: cli.call(method, args, timeout)
Line 44: 
Line 45: Examples:
Line 46: 
Line 47: cli.call('Host.getVMList')
> This is not very clear, lets show an example request with complex parameter
Done
Line 48: 
Line 49: result:
Line 50: [u'd7207614-38e3-43c4-b8f2-6086867d0a84',
Line 51: u'2c73bed5-cd2a-4d01-9095-97c0d71c831b']


https://gerrit.ovirt.org/#/c/64502/9/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 95: "display": "qxl", "maxvcpus": "16", "maxmemslots": 16},
Line 96: "vmid": "d7207614-38e3-43c4-b8f2-6086867d0a84"}))
Line 97: 
Line 98: ClientError will be raised in case of a protocol error:
Line 99: 
> args is optional now (good), but you are using mutable default argument, me
Done
Line 100: vdsm.client.ClientError: Error sending request: [Errno 111]
Line 101: Connection refused
Line 102: 
Line 103: TimeoutError will be raised when preconfigured amount of time has 
passed with


Line 105: 
Line 106: vdsm.client.TimeoutError: timeout waiting for a response
Line 107: 
Line 108: ServerError will be raised if the command encountered execution error:
Line 109: 
> I think we need to introduce a Timeout error, otherwise the user cannot tel
Done
Line 110: vdsm.client.ServerError: Vdsm request failed
Line 111: (code=4, message=Virtual machine already exists)
Line 112: 
Line 113: 


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 10:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hsm:Use sd compat instead of qemu conf compat.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: hsm:Use sd compat instead of qemu conf compat.
..


Patch Set 10:

(4 comments)

https://gerrit.ovirt.org/#/c/64951/10/tests/storage_hsm_test.py
File tests/storage_hsm_test.py:

Line 98
Line 99
Line 100
Line 101
Line 102
> But you check that the code raises?!
Indeed, changed the method name.


Line 88: ('0.10', '0.10', 4),
Line 89: ('1.1', '0.10', 4),
Line 90: ('0.10', '0.10', 3),
Line 91: ))
Line 92: def test_disabled_compat_raises(self, hsm_compat, qemu_config, 
sd_version):
> This test check the invalid compat raises...
Changed to test_valid_qcow2_compat
Line 93: with self.fake_volume(sc.COW_FORMAT, sd_version) as vol:
Line 94: create_conf = make_config([('irs', 'qcow2_compat', 
qemu_config)])
Line 95: info = {"format": qemuimg.FORMAT.QCOW2, "compat": 
hsm_compat}
Line 96: with MonkeyPatchScope([(qemuimg, 'config', create_conf),


Line 98: qemuimg.create(vol.volumePath, size=self.SIZE,
Line 99:format=qemuimg.FORMAT.QCOW2)
Line 100: h = FakeHSM()
Line 101: self.assertNotRaises(h.verify_untrusted_volume, 'sp',
Line 102:  vol.sdUUID, vol.imgUUID, 
vol.volUUID)
> But you check that the code does not raise?!
Changed the method name to indicate the test purpose:
test_valid_qcow2_compat
Line 103: 
Line 104: @permutations((
Line 105: ('1.1', '0.10', 3),
Line 106: ))


Line 103: 
Line 104: @permutations((
Line 105: ('1.1', '0.10', 3),
Line 106: ))
Line 107: def test_valid_compat(self, hsm_compat, qemu_config, sd_version):
> This test should test valid compats...
Changed it to test_disabled_compat_raises
Line 108: with self.fake_volume(sc.COW_FORMAT, sd_version) as vol:
Line 109: create_conf = make_config([('irs', 'qcow2_compat', 
qemu_config)])
Line 110: info = {"format": qemuimg.FORMAT.QCOW2, "compat": 
hsm_compat}
Line 111: with MonkeyPatchScope([(qemuimg, 'config', create_conf),


-- 
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b19a99e5d9a73c011bf6d8079e3855298561b9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 3:

Nothing changed in the reporting or setup itself, only in the validation.
It is not practical to test all possible scenarios in functional tests, that's 
why we have unit tests.

-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Refine TerminationTests names

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: Refine TerminationTests names
..


Patch Set 6:

(4 comments)

https://gerrit.ovirt.org/#/c/65326/6//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-10-13 14:32:59 +0300
Line 6: 
Line 7: tests: Refine TerminationTests names
Line 8: 
Line 9: - Al the test are testing termination, there is no need to repeat
s/Al/All
Line 10:   the class name in the test names.
Line 11: - Use the tests names to describe the situation tested; terminating a
Line 12:   running process, or kill failure.
Line 13: - Rename fake_kill to fail, describing what this function is doing.


Line 7: tests: Refine TerminationTests names
Line 8: 
Line 9: - Al the test are testing termination, there is no need to repeat
Line 10:   the class name in the test names.
Line 11: - Use the tests names to describe the situation tested; terminating a
s/names/name
Line 12:   running process, or kill failure.
Line 13: - Rename fake_kill to fail, describing what this function is doing.
Line 14: 
Line 15: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d


Line 9: - Al the test are testing termination, there is no need to repeat
Line 10:   the class name in the test names.
Line 11: - Use the tests names to describe the situation tested; terminating a
Line 12:   running process, or kill failure.
Line 13: - Rename fake_kill to fail, describing what this function is doing.
Rameing ... describes "better" what this function does
Line 14: 
Line 15: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d


https://gerrit.ovirt.org/#/c/65326/6/tests/utilsTests.py
File tests/utilsTests.py:

Line 101
Line 102
Line 103
Line 104
Line 105
you asked for this name iirc


-- 
To view, visit https://gerrit.ovirt.org/65326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 15:

http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/297/
job ended successfully

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: Raise detectable error if termination fail

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: Raise detectable error if termination fail
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/65325/6/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 752: proc.kill()
Line 753: proc.wait()
Line 754: except Exception as e:
Line 755: raise TerminatingFailure(proc.pid, e)
Line 756: 
why not to raise the original exception ?
Line 757: 
Line 758: def get_selinux_enforce_mode():
Line 759: """
Line 760: Returns the SELinux mode as reported by kernel.


-- 
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfa5434ce011b9185550884233b5b233026d13c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: Wait for terminated process

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: Wait for terminated process
..


Patch Set 5:

we don't use terminating context anywhere yet anyway, only in execmd itself 
when calling communicate which should be stuck if the process still runs. if 
this context manager waits for the process I wouldn't call it "terminating", it 
just signals the process and wait for it to exit

-- 
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 3: Code-Review-1

We should add a test to func_dns_test.py, to check if both ifcfg and our caps 
reporting are OK with this usage.

-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 3:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py
File tests/network/ip_test.py:

PS1, Line 87: fe80::1%eth1
> rfc6874 does not limit to local link, but seems to be the most relevant usa
Done


-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[dholler]

Dominik Holler has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py
File tests/network/ip_test.py:

PS1, Line 87: 2001::1%eth1
> Do you have a reference to the usage of this %tail? I could not seen any sp
rfc6874 does not limit to local link, but seems to be the most relevant usage.


-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py
File tests/network/ip_test.py:

PS1, Line 87: 2001::1%eth1
> The zone id is usually used for local link addresses. For this reason would
Do you have a reference to the usage of this %tail? I could not seen any 
specification that limits it to the local scope, on the other hand,I could not 
find any official text about that '%' in general.


-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 15:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: support nameserver address with %iface tail

[dholler]

Dominik Holler has posted comments on this change.

Change subject: net: support nameserver address with %iface tail
..


Patch Set 1: Code-Review+1

(2 comments)

Currently I only know that the zone id is used for local link addresses, for 
this  reason I suggest to use a local link address as the sample address.

https://gerrit.ovirt.org/#/c/65693/1/lib/vdsm/network/ip/validator.py
File lib/vdsm/network/ip/validator.py:

PS1, Line 61: 2001::1%eth0
The zone id is usually used for local link addresses. For this reason would be 
a local link address here more clean.


https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py
File tests/network/ip_test.py:

PS1, Line 87: 2001::1%eth1
The zone id is usually used for local link addresses. For this reason would be 
a local link address here more clean.


-- 
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: Wait for terminated process

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: utils: Wait for terminated process
..


Patch Set 5: Code-Review+1

what you say here is very clear; but since https://gerrit.ovirt.org/#/c/51407/ 
was very explicit about this intended semantics, I'd like to hear from 
Piotr+Bronheim if they are aware of anything that depends on it, and would be 
broken now.

-- 
To view, visit https://gerrit.ovirt.org/65324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use Popen.poll() for running state

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use Popen.poll() for running state
..


Patch Set 6:

* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use Popen.poll() for running state

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Use Popen.poll() for running state
..


tests: Use Popen.poll() for running state

Checking if /proc/pid exists works, but using poll() is simpler and more
clear.

Since proc_path is used only in one test, move it the test using it.

Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65323
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Piotr Kliczewski 
---
M tests/utilsTests.py
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org