Change in vdsm[master]: storage: add more info to NFS SD getInfo
Roy Golan has posted comments on this change. Change subject: storage: add more info to NFS SD getInfo .. Patch Set 1: (1 comment) - can this reveal secure info of some sort? - Thinking on the client side, the engine should consume that and possibly store that as the mount option on that domain and obviously not all the info is relevant. Maor, Liron how do you see this? https://gerrit.ovirt.org/#/c/63636/1/vdsm/storage/nfsSD.py File vdsm/storage/nfsSD.py: Line 131: try: Line 132: mntrcd = mount.getMountFromTarget(self.mountpoint).getRecord() Line 133: info['vfsType'] = mntrcd.fs_vfstype Line 134: info['mountOptions'] = mntrcd.fs_mntops Line 135: except mount.MountError: log the err? Line 136: return info Line 137: Line 138: return info Line 139: -- To view, visit https://gerrit.ovirt.org/63636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: api: unexpected response when a verb returns nothing
Roy Golan has posted comments on this change. Change subject: api: unexpected response when a verb returns nothing .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59469/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: PS1, Line 543: Why btw not make those API verbs to return True if None isn't a valid answer. Is this for compatibility? -- To view, visit https://gerrit.ovirt.org/59469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5630052bea05fb8ea4fa3f2ff1dfedf6e1b2841d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storageServer: Normalize local path before escaping
Roy Golan has posted comments on this change. Change subject: storageServer: Normalize local path before escaping .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hsm: Prevent stop monitoring of a pool domain
Roy Golan has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99555b230dfdab41384af0461e4b30c590b669b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: sp: Allow attaching of monitored domain
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Collect stats from online cpu cores only
Roy Golan has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 13: Code-Review+1 Later we would need to adapt engine scheduling to consider online cpus - And possible notify with audit log that there are some offline cpus. -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown
Roy Golan has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching of monitored domain
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 3: Verified+1 Seems to work correctly. Even saw the log messages [root@bear noarch]# grep "Monitor for" /var/log/vdsm/vdsm.log Thread-70::DEBUG::2015-12-01 15:07:38,517::monitor::118::Storage.Monitor::(startMonitoring) Monitor for a81f9aed-47b3-4 52c-a52e-c9b55feb296a is already running -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitor: Do not release host id during shutdown
Roy Golan has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/49386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib14fa48abf9c98fdce268c4675d71aab05c92b10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching of monitored domain
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48217/2/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:
Line 101: if monitor is not None:
Line 102: self.log.debug("Monitor for %s is running", sdUUID)
Line 103: if poolDomain:
Line 104: self.log.info("Attaching monitor for %s to the pool",
sdUUID)
Line 105: monitor.poolDomain = True
I would add a comment here that from now on external monitoring is joint into
the pool.
Line 106: return
Line 107:
Line 108: self.log.info("Start monitoring %s", sdUUID)
Line 109: monitor = MonitorThread(weakref.proxy(self), sdUUID, hostId,
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: Nir I didn't understand our comment. -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: Nir pending your comments. -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: getting the logs. will post them on the bz -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: Sanlock sees qemu pid is using a path on one of its a resource(the sd) and when it needs to remove the lockspace it kills the pid? correct me if I wrong. If yes that's the expected behaviour of the cleanup and the code makes sense. -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: First, we need a fix asap and the refcount patch doesn't look like its going to be merged soon enough. I'm not sure how qemu is an application resource of the SPM lockspace but that's a fact. The flow is: hosted engine setup creates a pool with SD1 using vdsm setup creates disks for the VMs on SD1 using vdsm setup create SD2 and reconstruct the master on it to detach SD1 from pool VM1 (engine) is running with disks on SD1 SD1 is detached Engine imports SD1 Engine attach SD1 Engine adds VM1 from the configuration detected -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: Verified+1 (1 comment) Working as expected. The domain is imported and attached while the VM is running and I'm able to auto import the hosted engine VM https://gerrit.ovirt.org/#/c/48217/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 888: return Line 889: Line 890: # When attaching hosted engine storage domain, sanlock is already Line 891: # maintaning a lockspace on this domain, and releasing the host id Line 892: # would cause sanlock to kill the hosted engine vm. Arguably this is true whenever attaching a domain with running VMs on it (e.g in case of DR) and not exclusively hosted engine? Line 893: # See https://bugzilla.redhat.com/1269768 Line 894: shouldAcquireHostId = not dom.hasHostId(self.id) Line 895: Line 896: if shouldAcquireHostId: -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Report vg name in getDeviceList
Roy Golan has posted comments on this change. Change subject: hsm: Report vg name in getDeviceList .. Patch Set 3: Code-Review+1 I currently crossmatch using sd id and try to match the lun. The vg_name will greatly simplify the process as I will be able to immdiatly spot the disk with hosted_engine configuration -- To view, visit https://gerrit.ovirt.org/45823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116714cb5143ea92f5cb54c3f80f895c07ada536 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: Handle numa nodes with zero memory assigned
Roy Golan has posted comments on this change. Change subject: sampling: Handle numa nodes with zero memory assigned .. Patch Set 2: this patch is missing vdsm maintainers. Don't forget to add them -- To view, visit https://gerrit.ovirt.org/44121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6be69e715e9b4a0cc8ded744b0bcc192a466c6c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: Handle numa nodes with zero memory assigned
Roy Golan has posted comments on this change. Change subject: sampling: Handle numa nodes with zero memory assigned .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6be69e715e9b4a0cc8ded744b0bcc192a466c6c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Balloon should not work when guest agent is not present
Roy Golan has posted comments on this change. Change subject: Balloon should not work when guest agent is not present .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Roy Golan has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40129/6/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 319: """
Line 320: rule = os.path.join(_UDEV_RULE_FILE_DIR,
_UDEV_RULE_FILE_PREFIX +
Line 321: "iommu_group_" + iommu_group +
_UDEV_RULE_FILE_EXT)
Line 322: self.log.debug("Removing rule %s", rule)
Line 323: os.remove(rule)
> Change resulting from rebase. Not my commit.
but it looks like you added it(same as above). I guess its not related to your
patch?
Line 324:
Line 325: @logDecorator
Line 326: def ksmTune(self, tuningParams):
Line 327: '''
--
To view, visit https://gerrit.ovirt.org/40129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dudi Maroshi
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Max Kovgan
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Fix the CPU quota MOM policy computations
Roy Golan has posted comments on this change. Change subject: Fix the CPU quota MOM policy computations .. Patch Set 1: this is merged upstream. can you guys review? -- To view, visit https://gerrit.ovirt.org/40311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f014d1b4058ef447a962cbda3336115e8610dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Roy Golan has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 3: @Max is the -1 still relevant? -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix the CPU quota MOM policy computations
Roy Golan has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/39411/8/tests/momPolicyTests.py
File tests/momPolicyTests.py:
Line 143: p.set_policy("04-cputune",
cpu_policy_string))
Line 144:
Line 145: p.evaluate(host, [vm])
Line 146:
Line 147: self.assertEqual(vm.controls["vcpu_quota"], 1100)
> But it is. Multiply it by the number of logical CPUs and you get 10% of the
the cpu count is 1. I don't see where did you set 10 logical cpus
--
To view, visit https://gerrit.ovirt.org/39411
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1f014d1b4058ef447a962cbda3336115e8610dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix the CPU quota MOM policy computations
Roy Golan has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/39411/8/tests/momPolicyTests.py
File tests/momPolicyTests.py:
Line 7: from mom.Entity import Entity
Line 8: from mom.Monitor import Monitor
Line 9: from unittest import TestCase
Line 10:
Line 11: # This is a very hacky way of implementing the test scenario
not that hacky I'd say
Line 12: # we should update MOM to offer test capability and use it here.
Line 13: # Unfortunately bug #1207610 has very high priority and won't
Line 14: # wait for MOM to appear in Fedora repositories
Line 15: # TODO replace with proper test API once it appears
Line 49: "vcpu_quota": None,
Line 50: "vcpu_period": None
Line 51: })
Line 52:
Line 53: config_policy_string =
self._getPolicyContent("00-defines.policy")
line 53-60 are repeating for every test. care to refactor them out?
Line 54: cpu_policy_string = self._getPolicyContent("04-cputune.policy")
Line 55:
Line 56: self.assertEqual(True,
Line 57: p.set_policy("00-defines",
config_policy_string))
Line 143: p.set_policy("04-cputune",
cpu_policy_string))
Line 144:
Line 145: p.evaluate(host, [vm])
Line 146:
Line 147: self.assertEqual(vm.controls["vcpu_quota"], 1100)
doesn't look like 10%
--
To view, visit https://gerrit.ovirt.org/39411
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1f014d1b4058ef447a962cbda3336115e8610dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: mom.d: make CpuTuneEnabled True by default
Roy Golan has posted comments on this change. Change subject: mom.d: make CpuTuneEnabled True by default .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: mom.d: make CpuTuneEnabled True by default
Roy Golan has abandoned this change. Change subject: mom.d: make CpuTuneEnabled True by default .. Abandoned -- To view, visit http://gerrit.ovirt.org/36026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: mom.d: make CpuTuneEnabled True by default
Roy Golan has uploaded a new change for review. Change subject: mom.d: make CpuTuneEnabled True by default .. mom.d: make CpuTuneEnabled True by default we should ship vdsm with that policy enabled otherwise cpu tuning isn't taking place at all as the policy isn't evaluated. future: control this policy parameter at runtime as well Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Bug-Url: https://bugzilla.redhat.com/1143992 Signed-off-by: Roy Golan Reviewed-on: http://gerrit.ovirt.org/35330 Reviewed-by: Martin Sivák Reviewed-by: Dan Kenigsberg (cherry picked from commit db830339d13a12f5081a9f661e87470dd95c928e) --- M vdsm/mom.d/00-defines.policy 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/36027/1 diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy index 1d98990..faa6d90 100644 --- a/vdsm/mom.d/00-defines.policy +++ b/vdsm/mom.d/00-defines.policy @@ -6,5 +6,5 @@ # Define variables for configurable options here (defvar ksmEnabled 1) (defvar balloonEnabled 0) -(defvar cpuTuneEnabled 0) +(defvar cpuTuneEnabled 1) -- To view, visit http://gerrit.ovirt.org/36027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5.0]: mom.d: make CpuTuneEnabled True by default
Roy Golan has uploaded a new change for review. Change subject: mom.d: make CpuTuneEnabled True by default .. mom.d: make CpuTuneEnabled True by default we should ship vdsm with that policy enabled otherwise cpu tuning isn't taking place at all as the policy isn't evaluated. future: control this policy parameter at runtime as well Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Bug-Url: https://bugzilla.redhat.com/1143992 Signed-off-by: Roy Golan Reviewed-on: http://gerrit.ovirt.org/35330 Reviewed-by: Martin Sivák Reviewed-by: Dan Kenigsberg (cherry picked from commit db830339d13a12f5081a9f661e87470dd95c928e) --- M vdsm/mom.d/00-defines.policy 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/36026/1 diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy index 1d98990..faa6d90 100644 --- a/vdsm/mom.d/00-defines.policy +++ b/vdsm/mom.d/00-defines.policy @@ -6,5 +6,5 @@ # Define variables for configurable options here (defvar ksmEnabled 1) (defvar balloonEnabled 0) -(defvar cpuTuneEnabled 0) +(defvar cpuTuneEnabled 1) -- To view, visit http://gerrit.ovirt.org/36026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5.0 Gerrit-Owner: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mom.d: make CpuTuneEnabled True by default
Roy Golan has posted comments on this change. Change subject: mom.d: make CpuTuneEnabled True by default .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/35330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mom.d: make CpuTuneEnabled True by default
Roy Golan has uploaded a new change for review. Change subject: mom.d: make CpuTuneEnabled True by default .. mom.d: make CpuTuneEnabled True by default we should ship vdsm with that policy enabled otherwise cpu tuning isn't taking place at all as the policy isn't evaluated. future: control this policy parameter at runtime as well Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Bug-Url: https://bugzilla.redhat.com/1143992 Signed-off-by: Roy Golan --- M vdsm/mom.d/00-defines.policy 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/35330/1 diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy index 1d98990..faa6d90 100644 --- a/vdsm/mom.d/00-defines.policy +++ b/vdsm/mom.d/00-defines.policy @@ -6,5 +6,5 @@ # Define variables for configurable options here (defvar ksmEnabled 1) (defvar balloonEnabled 0) -(defvar cpuTuneEnabled 0) +(defvar cpuTuneEnabled 1) -- To view, visit http://gerrit.ovirt.org/35330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a602b8d50583b9cd16ef202f285c6a9897fa209 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: fix broken updateVmPolicy for jsonrpc
Roy Golan has abandoned this change. Change subject: API: fix broken updateVmPolicy for jsonrpc .. Abandoned merged already upstream -- To view, visit http://gerrit.ovirt.org/35236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I66a507034689a80ec40e73a35b86bc541349581a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: fix broken updateVmPolicy for jsonrpc
Roy Golan has posted comments on this change.
Change subject: API: fix broken updateVmPolicy for jsonrpc
..
Patch Set 1:
(1 comment)
@Gilad @Martin - pleaes review the updated signature of updateVmPolicy
http://gerrit.ovirt.org/#/c/35236/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 7884: # @vmId: The UUID of the virtual machine to migrate
Line 7885: #
Line 7886: # @vcpuLimit #optional the cpu limit in percentage
Line 7887: #
Line 7888: # Since: 4.16.0
I guess this should be 4.15 although new and let git blame fill in the gap
Line 7889: ##
Line 7890: {'type': 'vmPolicy',
Line 7891: 'data': {'vmId': 'UUID', '*vcpuLimit': 'int'}}
Line 7892:
--
To view, visit http://gerrit.ovirt.org/35236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66a507034689a80ec40e73a35b86bc541349581a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: fix broken updateVmPolicy for jsonrpc
Roy Golan has posted comments on this change. Change subject: API: fix broken updateVmPolicy for jsonrpc .. Patch Set 1: will fix the unit test -- To view, visit http://gerrit.ovirt.org/35236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66a507034689a80ec40e73a35b86bc541349581a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: fix broken updateVmPolicy for jsonrpc
Roy Golan has uploaded a new change for review.
Change subject: API: fix broken updateVmPolicy for jsonrpc
..
API: fix broken updateVmPolicy for jsonrpc
the schema had a wrong mapping of the above verb.
the argument for that verb is a dictionary with the various policy
parameters. One which is currently used it vcpuLimit.
the outcome of this verb being unsable is that the cpu profile feature
was useless as the metadata was never set at the vm xml
Change-Id: I66a507034689a80ec40e73a35b86bc541349581a
Bug-Url: https://bugzilla.redhat.com/1162774
Signed-off-by: Roy Golan
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/35236/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index b6a835e..dd7e0be 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -7877,13 +7877,27 @@
'*ioTune': ['VmDiskDeviceTuneLimits']}}
##
+# @vmPolicy:
+#
+# Parameters for @VM.updateVmPolicy
+#
+# @vmId: The UUID of the virtual machine to migrate
+#
+# @vcpuLimit #optional the cpu limit in percentage
+#
+# Since: 4.16.0
+##
+{'type': 'vmPolicy',
+ 'data': {'vmId': 'UUID', '*vcpuLimit': 'int'}}
+
+##
# @VM.updateVmPolicy:
#
# Set VM SLA parameters
#
# @vmID: The UUID of the VM
#
-# @params:The UpdateVmPolicyParams structure that defines
+# @params:The vmPolicy structure that defines
# the changes that are to be applied to the current
# QoS policy.
#
@@ -7893,5 +7907,4 @@
# Since: 4.15.0
##
{'command': {'class': 'VM', 'name': 'updateVmPolicy'},
- 'data': {'vmID': 'UUID', 'params': 'UpdateVmPolicyParams'},
- 'returns': 'TaskStatus'}
+ 'data': {'vmID': 'UUID', 'params': 'vmPolicy'}}
--
To view, visit http://gerrit.ovirt.org/35236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66a507034689a80ec40e73a35b86bc541349581a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Roy Golan has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: engine checks if the string has changed. agnostic to how it is generated of course -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setNumberOfCpus marshalling issue
Roy Golan has posted comments on this change. Change subject: setNumberOfCpus marshalling issue .. Patch Set 1: Code-Review+1 correct - I forgot vdsClient uses XMLRPC binding. -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setNumberOfCpus marshalling issue
Roy Golan has posted comments on this change. Change subject: setNumberOfCpus marshalling issue .. Patch Set 1: Code-Review-1 you need to fix client/vdsClient.py as well -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setNumberOfCpus marshalling issue
Roy Golan has posted comments on this change. Change subject: setNumberOfCpus marshalling issue .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: refine calculation of cpu topology
Roy Golan has abandoned this change. Change subject: refine calculation of cpu topology .. Abandoned moving the calculation of maxVCpus to backend -- To view, visit http://gerrit.ovirt.org/31032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refine calculation of cpu topology
Roy Golan has abandoned this change. Change subject: refine calculation of cpu topology .. Abandoned moving the calculation of maxVCpus to backend -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: refine calculation of cpu topology
Roy Golan has uploaded a new change for review.
Change subject: refine calculation of cpu topology
..
refine calculation of cpu topology
engine sends along with createInfo the following:
smp // VM.numOfCpus
smpCoresPerSocket // VM.cpuPerSocket validated against
ConfigValue.MaxNumOfSockets currently = 16
maxVCpus// ConfigValue.MaxNumberOfVmCpus
smpThreadsPerCore // optional - we don't send so defaults to 1
we need to send also
* MaxNumOfSockets
the xml should be calculated like this
M
smp = smp
C = smpCoresPerSocket
T = cpuThreads
S = maxNumberOfSockets
M = min(maxVCpus, (C * S * T))
Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Bug-Url: https://bugzilla.redhat.com/1121295
Signed-off-by: Roy Golan
---
M tests/vmTests.py
M tests/vmTestsData.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
4 files changed, 39 insertions(+), 26 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/31032/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 7ee2eb8..53a41c9 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -165,7 +165,7 @@
9ffe28b6-6134-4b1e-8804-1185f49c436f
1048576
1048576
- 160
+ 16
524288
@@ -400,7 +400,7 @@
-
+
diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py
index 3cee160..baac543 100644
--- a/tests/vmTestsData.py
+++ b/tests/vmTestsData.py
@@ -20,13 +20,14 @@
CONF_TO_DOMXML_X86_64 = [({
'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
-'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512',
+'memSize': '1024', 'memGuaranteedSize': '512',
'displayPort': '-1', 'vmName': 'testVm',
'display': 'vnc', 'emulatedMachine': 'pc',
'boot': '', 'timeOffset': 0,
'acpiEnable': 'true', 'cpuType': 'qemu64',
'smpCoresPerSocket': 1, 'smpThreadsPerCore': 1,
-'smp': '1', 'cpuPinning': {}, 'numaTune': {}, 'maxVCpus': '160',
+'smp': '8', 'maxNumberOfSockets': '16',
+'cpuPinning': {}, 'numaTune': {}, 'maxVCpus': '160',
'vmchannel': 'true', 'qgaEnable': 'true',
'tabletEnable': False,
'displayNetwork': 'mydisp', 'custom': {},
@@ -38,7 +39,7 @@
%(vmId)s
1048576
1048576
-160
+16
524288
@@ -80,7 +81,7 @@
qemu64
-
+
@@ -88,13 +89,14 @@
CONF_TO_DOMXML_PPC64 = [({
'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
-'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512',
+'memSize': '1024', 'memGuaranteedSize': '512',
'displayPort': '-1', 'vmName': 'testVm',
'display': 'vnc', 'emulatedMachine': 'pc',
'boot': '', 'timeOffset': 0,
'acpiEnable': 'true', 'cpuType': 'qemu64',
'smpCoresPerSocket': 1, 'smpThreadsPerCore': 1,
-'smp': '1', 'cpuPinning': {}, 'numaTune': {}, 'maxVCpus': '160',
+'smp': '8', 'maxNumberOfSockets': '16',
+'cpuPinning': {}, 'numaTune': {}, 'maxVCpus': '160',
'vmchannel': 'true', 'qgaEnable': 'true',
'tabletEnable': False,
'displayNetwork': 'mydisp', 'custom': {},
@@ -107,7 +109,7 @@
%(vmId)s
1048576
1048576
-160
+16
524288
@@ -134,7 +136,7 @@
-
+
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index c301912..d0d58a3 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3329,6 +3329,8 @@
#
# @smpThreadsPerCore: #optional Indicates the number of CPU threads per
core
#
+# @maxNumberOfSockets:#optional Indicates the max number of sockets
+#
# @timeOffset:The time difference from host to the VM in seconds
#
# @transparentHugePages: Indicates if the Transparent Huge Pages feature is
@@ -3346,7 +3348,7 @@
#
# @guestNumaNodes:#optional Indicates the guest numa topology.
#
-# Since: 4.10.0
+# Since: 4.16.2
##
{'type': 'VmParameters',
'data': {'acpiEnable': 'bool', '*bootMenuEnable': 'bool',
@@ -3354,8 +3356,9 @@
'display': 'VmDisplayType', '*hypervEnable': 'bool',
'kvmEnable': 'bool', 'memSize': 'uint',
'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
- '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint',
- 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
+ '*smpThreadsPe
Change in vdsm[master]: refine calculation of cpu topology
Roy Golan has posted comments on this change. Change subject: refine calculation of cpu topology .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refine calculation of cpu topology
Roy Golan has posted comments on this change. Change subject: refine calculation of cpu topology .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/30896/9/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3415: '*cpuShares': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], Line 3416: 'display': 'VmDisplayType', '*hypervEnable': 'bool', Line 3417: 'kvmEnable': 'bool', 'memSize': 'uint', Line 3418: 'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 3419: '*maxNumberOfSockets': 'int', > but add it after smpThreadsPerCore to keep the description order. I'm confused. where to add it? Line 3420: '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint', Line 3421: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', Line 3422: 'vmType': 'VmType', '*launchPaused': 'bool', Line 3423: 'numaTune': 'NumaTune', 'guestNumaNodes': ['GuestNumaNode']}} -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refine calculation of cpu topology
Roy Golan has posted comments on this change.
Change subject: refine calculation of cpu topology
..
Patch Set 8:
(1 comment)
a
http://gerrit.ovirt.org/#/c/30896/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 422: def toxml(self):
Line 423: return self.doc.toprettyxml(encoding='utf-8')
Line 424:
Line 425: def _getSmp(self):
Line 426: return self.conf.get('smp', '1')
> since you're introducing _topology, I'd say please move smp there and add m
I'll add smp. maxNumberOfSockets is equivilent to sockets
Line 427:
Line 428: def _calcTopology(self):
Line 429: cores = int(self.conf.get('smpCoresPerSocket', '1'))
Line 430: threads = int(self.conf.get('smpThreadsPerCore', '1'))
--
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refine calculation of cpu topology
Roy Golan has posted comments on this change.
Change subject: refine calculation of cpu topology
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/30896/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 95:
Line 96: """
Line 97: self.conf = conf
Line 98: self.log = log
Line 99: self._setTopology()
> better to have all the initialization directly in __init__, so I'd rather d
Done
Line 100: self.arch = arch
Line 101:
Line 102: self.doc = xml.dom.minidom.Document()
Line 103:
Line 127: ('
> too long line, that's the reason for automation's negative score.
Done
Line 428: cores = int(self.conf.get('smpCoresPerSocket', '1'))
Line 429: threads = int(self.conf.get('smpThreadsPerCore', '1'))
Line 430: sockets = int(self.conf.get('maxNumberOfSockets', '16'))
Line 431: maxVCpus = int(self.conf.get('maxVCpus', self._getSmp()))
Line 432: maxVCpus = maxVCpus if cores * sockets > maxVCpus else cores
* sockets
> don't we have something like a max(a, b) function?
min(a,b) is the one I guess because we don't want to allocate sockets above the
configurable max.
Line 433:
Line 434: self._topology = {
Line 435: 'cores': cores,
Line 436: 'threads': threads,
Line 435: 'cores': cores,
Line 436: 'threads': threads,
Line 437: 'sockets': sockets,
Line 438: 'maxVCpus': maxVCpus
Line 439: }
> (see comment at line 99)
Done
I got no problem with that. can you explain why? is that a matter of convention
to so self_a = self._calcA()?
Line 440:
Line 441: if sys.version_info[:2] == (2, 6):
Line 442: # A little unrelated hack to make
xml.dom.minidom.Document.toprettyxml()
Line 443: # not wrap Text node with whitespace.
--
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refine calculation of cpu topology
Roy Golan has uploaded a new change for review.
Change subject: refine calculation of cpu topology
..
refine calculation of cpu topology
engine sends along with createInfo the following:
smp // VM.numOfCpus
smpCoresPerSocket // VM.cpuPerSocket validated against
ConfigValue.MaxNumOfSockets currently = 16
maxVCpus// ConfigValue.MaxNumberOfVmCpus
smpThreadsPerCore // optional - we don't send so defaults to 1
we need to send also
* MaxNumOfSockets
the xml should be calculated like this
M
smp = smp
C = smpCoresPerSocket
T = cpuThreads
S = MaxNumOfSockets / T
M = (C * S) < maxVCpus
Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Bug-Url: https://bugzilla.redhat.com/1070890
Signed-off-by: Roy Golan
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vmxml.py
2 files changed, 20 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/30896/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index bd411a0..d21ad87 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3389,6 +3389,8 @@
#
# @smpThreadsPerCore: #optional Indicates the number of CPU threads per
core
#
+# @maxNumberOfSockets:#optional Indicates the max number of sockets
+#
# @timeOffset:The time difference from host to the VM in seconds
#
# @transparentHugePages: Indicates if the Transparent Huge Pages feature is
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index b8d87df..66e0c6b 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -96,7 +96,7 @@
"""
self.conf = conf
self.log = log
-
+self._setTopology()
self.arch = arch
self.doc = xml.dom.minidom.Document()
@@ -124,7 +124,7 @@
memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
self.dom.appendChildWithArgs('memory', text=memSizeKB)
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
-vcpu = self.dom.appendChildWithArgs('vcpu', text=self._getMaxVCpus())
+vcpu = self.dom.appendChildWithArgs('vcpu',
text=self._topology['maxVCpus'])
vcpu.setAttrs(**{'current': self._getSmp()})
memSizeGuaranteedKB = str(1024 * int(
@@ -318,12 +318,10 @@
if ('smpCoresPerSocket' in self.conf or
'smpThreadsPerCore' in self.conf):
-maxVCpus = int(self._getMaxVCpus())
-cores = int(self.conf.get('smpCoresPerSocket', '1'))
-threads = int(self.conf.get('smpThreadsPerCore', '1'))
cpu.appendChildWithArgs('topology',
-sockets=str(maxVCpus / cores / threads),
-cores=str(cores), threads=str(threads))
+cores=str(self._topology.['cores']),
+sockets=str(self._topology['sockets']),
+threads=str(self._topology['threads'])
# CPU-pinning support
# see http://www.ovirt.org/wiki/Features/Design/cpu-pinning
@@ -426,9 +424,20 @@
def _getSmp(self):
return self.conf.get('smp', '1')
-def _getMaxVCpus(self):
-return self.conf.get('maxVCpus', self._getSmp())
+def _setTopology(self):
+cores = int(self.conf.get('smpCoresPerSocket', '1'))
+threads = int(self.conf.get('smpThreadsPerCore', '1'))
+sockets = int(self.conf.get('maxNumberOfSockets', '16'))
+maxVCpus = int(self.conf.get('maxVCpus', self._getSmp()))
+maxVCpus =
+maxVCpus if (cores * sockets) > maxVCpus else (cores * sockets)
+self._topology = {
+'cores': cores,
+'threads': threads,
+'sockets': sockets,
+'maxVCpus': maxVCpus
+}
if sys.version_info[:2] == (2, 6):
# A little unrelated hack to make xml.dom.minidom.Document.toprettyxml()
--
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix xml maximum vcpus for odd number of vCores
Roy Golan has posted comments on this change. Change subject: Fix xml maximum vcpus for odd number of vCores .. Patch Set 2: the fix should still be VDSM's and a small engine addition: engine sends along with createInfo the following: smp // VM.numOfCpus smpCoresPerSocket // VM.cpuPerSocket validated against ConfigValue.MaxNumOfSockets currently = 16 maxVCpus// ConfigValue.MaxNumberOfVmCpus smpThreadsPerCore // optional - we don't send so defaults to 1 - bug? we need to send also * MaxNumOfSockets the xml should be calculated like this M smp = smp C = smpCoresPerSocket T = cpuThreads S = MaxNumOfSockets / T M = (C * S) < maxVCpus so 1. ENGINE - I'll add MaxNumOfSockets to engine create info 2. VDSM - adjust the xml creation to the formula above -- To view, visit http://gerrit.ovirt.org/30594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb45254b9005163cca15bd0b9c0ba48755f9da1d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix xml maximum vcpus for odd number of vCores
Roy Golan has posted comments on this change. Change subject: Fix xml maximum vcpus for odd number of vCores .. Patch Set 1: Code-Review+1 thanks amador -- To view, visit http://gerrit.ovirt.org/30594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb45254b9005163cca15bd0b9c0ba48755f9da1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add optimizations for hyperv
Roy Golan has posted comments on this change.
Change subject: vm: add optimizations for hyperv
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/27619/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 671: features.appendChild(hyperv)
Line 672:
Line 673: hyperv.appendChildWithArgs('relaxed', state='on')
Line 674: # turns off an internal Windows watchdog, and by doing so
avoids
Line 675: # some high load BSODs.
:) funny that BSODs is still around
Line 676: hyperv.appendChildWithArgs('vapic', state='on')
Line 677: hyperv.appendChildWithArgs(
Line 678: 'spinlocks', state='on', retries='8191')
Line 679: # performance optimization flags, that can improve the
performance
--
To view, visit http://gerrit.ovirt.org/27619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: agent: Add new command setNumberOfCPUs(count)
Roy Golan has posted comments on this change. Change subject: agent: Add new command setNumberOfCPUs(count) .. Patch Set 4: hot plug as well as unplug, no? -- To view, visit http://gerrit.ovirt.org/26531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I330f789eee9e5b7a457bc6defa744c0a6cd6c399 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Roy Golan has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Line 362: if not v:
Line 363: return errCode['noVM']
Line 364: stats = v.getStats().copy()
Line 365: if not stats:
Line 366: return errCode['down']
> Agreed. Then, if we want to save the concept (which I think is still sound)
why simply the regular errCode isn't enough? no stats, that's ok. engine will
try you later.
special error code is suggesting a potential specific care while this isn't the
case.
Line 367: stats['vmId'] = self._UUID
Line 368: return {'status': doneCode, 'statsList': [stats]}
Line 369:
Line 370: def hibernate(self, hibernationVolHandle):
--
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guest: Add support for guest cpu topology
Roy Golan has posted comments on this change.
Change subject: guest: Add support for guest cpu topology
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/23258/8/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 301: # Converting to string because XML-RPC doesn't
support 64-bit
Line 302: # integers.
Line 303: disk['total'] = str(disk['total'])
Line 304: disk['used'] = str(disk['used'])
Line 305: disks.append(disk)
general thing - couldn't we replace this tired long methods with some
dispatcher based on the message?
class agent():
def cpu-topology(self):
//do
agent.__getattribute__(message)()
Line 306: self.guestInfo['disksUsage'] = disks
Line 307: elif message == 'cpu-topology':
Line 308: API_VALUES = ('threads', 'sockets', 'cores', 'online',
'offline',
Line 309: 'possible', 'present')
--
To view, visit http://gerrit.ovirt.org/23258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: * addressed comments * added an update to the vm container to reflect changes when migrating etc -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
(4 comments)
http://gerrit.ovirt.org/#/c/21789/26//COMMIT_MSG
Commit Message:
Line 39:
Line 40: Tested:
Line 41: * setup: Host RHEL 6.5 and Guest 6.5 qemu-guest-agent installed
Line 42: * able to hot add CPUs. Guest online them immediatly
Line 43: * unplug fails with "Operation not supported: qemu didn't unplug the
vCPUs properly"
> Keep lines shorter, please.
Done
Line 44:
Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 46:vcpu set as the above mentioned.
Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
Line 42: * able to hot add CPUs. Guest online them immediatly
Line 43: * unplug fails with "Operation not supported: qemu didn't unplug the
vCPUs properly"
Line 44:
Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 46:vcpu set as the above mentioned.
> is this line here in purpose ?
Done
Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
http://gerrit.ovirt.org/#/c/21789/26/vdsm/API.py
File vdsm/API.py:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
> you can print:
Done
Line 464: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 465:'message': 'Missing one of required '
Line 466: 'parameters: vmId,
numberOfCpus'}}
Line 467: try:
Line 469: except KeyError:
Line 470: self.log.warning("vm %s doesn't exist", self._UUID)
Line 471: return errCode['noVM']
Line 472:
Line 473: return curVm.setNumberOfCpus(int(numberOfCpus))
> if numberOfCpus is not valid integer you'll get here ValueError that you do
I think its very reasonable to let it blow in the face of a careless client.
Line 474:
Line 475: def migrate(self, params):
Line 476: """
Line 477: Migrate a VM to a remote host.
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 26: Verified-1 I think I missed updating the vmcontainer. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 25: Verified+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [RFE] set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 18:
(4 comments)
File vdsm/vm.py
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self.conf.get('smp', 1)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self.conf.get('maxVCpus', smp))
Line 902: # hotplug cpu requires a maximum number which is higher than
the static
Done
Line 903: # assignment. 160 is the max number of cpu's for a guest
Line 904: # see http://www.ovirt.org/Hot_plug_cpu
Line 905: vcpu.setAttrs(**{'current': smp, 'placement': 'static'})
Line 906:
Line 901: 'vcpu', text=self.conf.get('maxVCpus', smp))
Line 902: # hotplug cpu requires a maximum number which is higher than
the static
Line 903: # assignment. 160 is the max number of cpu's for a guest
Line 904: # see http://www.ovirt.org/Hot_plug_cpu
Line 905: vcpu.setAttrs(**{'current': smp, 'placement': 'static'})
Done
Line 906:
Line 907: memSizeGuaranteedKB = str(1024 * int(
Line 908: self.conf.get('memGuaranteedSize', '0')
Line 909: ))
Line 1056: cpu.appendChildWithArgs('feature', **featureAttrs)
Line 1057:
Line 1058: if ('smpCoresPerSocket' in self.conf or
Line 1059: 'smpThreadsPerCore' in self.conf):
Line 1060: maxVCpus = int(self.conf.get('maxVCpus', '160'))
Done
Line 1061: cores = int(self.conf.get('smpCoresPerSocket', '1'))
Line 1062: threads = int(self.conf.get('smpThreadsPerCore', '1'))
Line 1063: cpu.appendChildWithArgs('topology',
Line 1064: sockets=str(maxVCpus / cores /
threads),
Line 3386: except libvirt.libvirtError as e:
Line 3387: self.log.error("setNumberOfCpus failed", exc_info=True)
Line 3388: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3389: return errCode['noVM']
Line 3390: return {'status': {'code': errCode['setNumberOfCpusErr
/']
Done
Line 3391: ['status']['code'], 'message': e.message}}
Line 3392:
Line 3393: self.saveState()
Line 3394: hooks.after_set_num_of_cpus()
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [RFE] set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15:
(12 comments)
Commit Message
Line 4: Commit: Roy Golan
Line 5: CommitDate: 2014-01-02 13:51:18 +0200
Line 6:
Line 7: set the # of vcpus for a VM (hot plug/unplug)
Line 8:
Done
Line 9: RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
Line 10:
Line 11: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
File debian/vdsm.dirs
Line 51: usr/libexec/vdsm/hooks/before_vm_migrate_source
Line 52: usr/libexec/vdsm/hooks/before_vm_pause
Line 53: usr/libexec/vdsm/hooks/before_vm_set_ticket
Line 54: usr/libexec/vdsm/hooks/before_vm_start
Line 55: usr/libexec/vdsm/hooks/before_set_num_of_cpus
Done
Line 56: usr/libexec/vdsm/hooks/after_set_num_of_cpus
Line 57: var/lib/libvirt/qemu/channels
Line 58: var/lib/vdsm
Line 59: var/lib/vdsm/netconfback
File lib/vdsm/define.py
Line 131: 'message': 'Wrong resize disk parameter'}},
Line 132: 'transientErr': {'status': {
Line 133: 'code': 59,
Line 134: 'message': 'Action not permitted on a VM with transient
disks'}},
Line 135: 'setNumberOfCpus': {'status': {
Done
Line 136: 'code': 60,
Line 137: 'message': 'Failed to set the number of cpus'}},
Line 138: 'recovery': {'status': {
Line 139: 'code': 99,
File tests/vmTests.py
Line 55: converted = element.toprettyxml()
Line 56: else:
Line 57: elem = ET.fromstring(element.toprettyxml())
Line 58: converted = re.sub(' />', '/>',
Line 59:ET.tostring(elem.find("./%s" % path)))
Done
Line 60: self.assertEqual(
Line 61: re.sub('\n\s*', ' ', converted).strip(' '),
Line 62: re.sub('\n\s*', ' ', expectedXML).strip(' '))
Line 63:
File tests/vmTestsData.py
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: CONF_TO_DOMXML = ({
mainly because client code is weird.
for a,b in CONF_TO_DOMXML:
why for if thats a plain tuple?
you probably mean future conf variations and expected xmls in the list?
Line 22: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 23: 'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512',
Line 24: 'displayPort': '-1', 'vmName': 'testVm',
Line 25: 'display': 'vnc', 'emulatedMachine': 'pc',
File vdsm/API.py
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
vdsClient?
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
Line 464: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 465:'message': 'Missing one of required '
File vdsm/hooks.py
Line 297:
Line 298:
Line 299: def before_set_num_of_cpus(vmconf={}, params={}):
Line 300: return _runHooksDir(None, 'before_set_num_of_cpus', vmconf=vmconf,
Line 301: params=params, raiseError=False)
Done
Line 302:
Line 303:
Line 304: def after_set_num_of_cpus(vmconf={}, params={}):
Line 305: return _runHooksDir(None, 'after_set_num_of_cpus', vmconf=vmconf,
File vdsm/vm.py
Line 77: RNG_DEVICES = 'rng'
Line 78: WATCHDOG_DEVICES = 'watchdog'
Line 79: CONSOLE_DEVICES = 'console'
Line 80: SMARTCARD_DEVICES = 'smartcard'
Line 81: CPU_DEVICES = 'cpu'
Done
Line 82:
Line 83:
Line 84: def isVdsmImage(drive):
Line 85: return all(k in drive.keys() for k in ('volumeID', 'domainID',
'imageID',
Line 897: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 898: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 899: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self.conf.get('maxVCpus', '160'))
not that I'm aware of. its pure libvirt. I didn't see change in the guest /sys/
can you add a libvirt reviewer for this?
Line 902: # hotplug cpu requires a maximum number which is higher than
the static
Line 903: # assignment. 160 is the max number of cpu's for a guest
Line 904: # see http://www.ovirt.org/Hot_plug_cpu
Line 905: vcpu.setAttrs(**{'
Change in vdsm[master]: [RFE] set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 17: addressed most of the comments -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 14: hook supported isn't verified -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 13: * reverted the use of EqualsMultiLine which doesn't exist in the 2.6 * following Edu's comments on buildCmdLine test case -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 12: no change just a rebase. on my side all the tests run OK when I "make rpm". -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11:
(2 comments)
File tests/vmTests.py
Line 45: 'function': '0x0', 'type': 'pci'}
Line 46:
Line 47: def __init__(self, *args, **kwargs):
Line 48: TestCaseBase.__init__(self, *args, **kwargs)
Line 49: self.maxDiff = None
this is for the assertMultiLineEqual to show the full diff of xml incase there
is a mismatch
Line 50: self.conf = {'vmName': 'testVm',
Line 51: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 52: 'smp': '8', 'memSize': '1024',
'memGuaranteedSize': '512'}
Line 53:
File vdsm/API.py
Line 455: return errCode['noVM']
Line 456:
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
I use it only for input parameter validation here for this section is shared
with vdsClient.py and BinfingXMLRPC and potentially every other client.
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 10: * test wasn't fixed yet -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified+1 Verified * the vm is up and running with 2 cpus * can call setVcpus Not verified * the libvirt call still says the domain couldn't hot add cpus probably an OS issue -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: the libvirt xml is changed now to allow adding more cpus this means we have a topology element and a vcpu element to reflect the current placement of cpus 160 this means we currently use 2 VCPU and we can grow by hot adding up to 160 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 3: * addressed comments * rename the new vdsClient verb to plural: setNumberOfCpu -> setNumberOfCpus -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(5 comments)
File client/vdsClient.py
Line 245: params = {'vmId': args[0], 'drive': drive}
Line 246: return self.ExecAndExit(self.s.hotunplugDisk(params))
Line 247:
Line 248: def setNumberOfCpus(self, args):
Line 249: return self.ExecAndExit(self.s.setNumberOfCpus(args[0],
args[1]))
Done
Line 250:
Line 251: def do_changeCD(self, args):
Line 252: vmId = args[0]
Line 253: file = self._parseDriveSpec(args[1])
File vdsm/API.py
Line 456: def setNumberOfCpus(self, params):
Line 457: try:
Line 458: utils.validateMinimalKeySet(params, ('vmId',
'numberOfCpus'))
Line 459: except ValueError:
Line 460: self.log.error('Missing one of required parameters: vmId,
drive')
will the backtrace include the missing params? otherwise I don't see the real
value
Line 461: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 462:'message': 'Missing one of required '
Line 463: 'parameters: vmId,
numberOfCpus'}}
Line 464: try:
File vdsm/vm.py
Line 3309: if self.isMigrating():
Line 3310: return errCode['migInProgress']
Line 3311:
Line 3312: self.log.debug("Setting number of cpus to : %s" %
Line 3313:params.get['numberOfCpus'])
Done
Line 3314:
Line 3315: try:
Line 3316: self._dom.setVcpu(params.get('numberOfCpus'))
Line 3317: except libvirt.libvirtError as e:
File vdsm_api/Bridge.py
Line 339: 'Volume_getInfo': {'ret': 'info'},
Line 340: 'Volume_getPath': {'ret': 'path'},
Line 341: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 342: 'Host_getAllTasks': {'ret': 'tasks'},
Line 343: 'VM_setNumberOfCpus': {'ret': 'vmList'},
Done
Line 344: }
Line 345:
Line 346:
Line 347: def fieldClone(oldName, newName, obj):
File vdsm_api/vdsmapi-schema.json
Line 6694: #
Line 6695: # Since: 4.10.0
Line 6696: ##
Line 6697: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6698: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int' },
Done
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has uploaded a new change for review.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
RFE https://bugzilla.redhat.com/show_bug.cgi?id=833102
Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=833102
Signed-off-by: Roy Golan
---
M client/vdsClient.py
M lib/vdsm/define.py
M tests/vmTests.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/vm.py
M vdsm_api/Bridge.py
M vdsm_api/vdsmapi-schema.json
8 files changed, 82 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/21789/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 67ce3b7..097e21f 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -245,6 +245,9 @@
params = {'vmId': args[0], 'drive': drive}
return self.ExecAndExit(self.s.hotunplugDisk(params))
+def setNumberOfCpus(self, args):
+return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
+
def do_changeCD(self, args):
vmId = args[0]
file = self._parseDriveSpec(args[1])
@@ -2511,6 +2514,11 @@
' ',
'Extends the virtual size of a disk'
)),
+'setNumberOfCpu': (
+serv.setNumberOfCpus, (
+' ',
+'set the number of cpus for a running VM'
+)),
}
if _glusterEnabled:
commands.update(ge.getGlusterCmdDict(serv))
@@ -2550,7 +2558,7 @@
try:
serv.do_connect(hostPort)
try:
-commandArgs = args[2:]
+commandArgs = args[2:]
except:
commandArgs = []
code, message = commands[command][0](commandArgs)
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index eb78633..389a5ba 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -132,6 +132,9 @@
'transientErr': {'status': {
'code': 59,
'message': 'Action not permitted on a VM with transient disks'}},
+'setNumberOfCpus': {'status': {
+'code': 60,
+'message': 'Failed to set the number of cpus'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 1f69f0a..8d5fbd3 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -67,7 +67,7 @@
9ffe28b6-6134-4b1e-8804-1185f49c436f
1048576
1048576
- 8
+ 160
524288
diff --git a/vdsm/API.py b/vdsm/API.py
index 48eecc6..40d641c 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -453,6 +453,22 @@
return curVm.hotunplugDisk(params)
+def setNumberOfCpus(self, params):
+try:
+utils.validateMinimalKeySet(params, ('vmId', 'numberOfCpus'))
+except ValueError:
+self.log.error('Missing one of required parameters: vmId, drive')
+return {'status': {'code': errCode['MissParam']['status']['code'],
+ 'message': 'Missing one of required '
+ 'parameters: vmId, numberOfCpus'}}
+try:
+curVm = self._cif.vmContainer[self._UUID]
+except KeyError:
+self.log.warning("vm %s doesn't exist", self._UUID)
+return errCode['noVM']
+
+return curVm.setNumberOfCpus(params)
+
def migrate(self, params):
"""
Migrate a VM to a remote host.
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 1602c5c..fc5d926 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -283,6 +283,10 @@
vm = API.VM(vmId)
return vm.vmUpdateDevice(params)
+def setNumberOfCpus(self, vmId, numberOfCpus):
+vm = API.VM(vmId)
+return vm.setNumberOfCpus(vmId, numberOfCpus)
+
def vmSnapshot(self, vmId, snapDrives, snapMemVolHandle=''):
"""
Take snapshot of VM
@@ -867,7 +871,8 @@
(self.vmHotunplugDisk, 'hotunplugDisk'),
(self.vmHotplugNic, 'hotplugNic'),
(self.vmHotunplugNic, 'hotunplugNic'),
-(self.vmUpdateDevice, 'vmUpdateDevice'))
+(self.vmUpdateDevice, 'vmUpdateDevice'),
+(self.vmSetNumberOfCpus, 'setNumberOfCpus'))
def getIrsMethods(self):
return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 10eb54b..a2aa92a 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -77,6 +77,7 @@
WATCHDOG_DEVICES = 'watchdog'
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES = 'smartcard'
+CPU_DEVICES = 'cpu'
def isVdsmImage(drive):
@@ -852,7 +853,7 @@
9ffe28b6-6134-4b1e-8804-1185f49c436f
262144
262144
-smp
+
Change in vdsm[master]: vdsm: report migration status in migrateStatuses()
Roy Golan has posted comments on this change.
Change subject: vdsm: report migration status in migrateStatuses()
..
Patch Set 7:
(1 comment)
File vdsm_api/vdsmapi-schema.json
Line 2839: # Since: 4.10.0
Line 2840: ##
Line 2841: {'command': {'class': 'Host', 'name': 'getMigrationStatuses'},
Line 2842: 'data': {'*vmList': ['UUID']},
Line 2843: 'returns': ['MigrationStatus']}
this should return a dictionary of UUID: MigrationStatus otherwise how could
the caller corelate stats with a VM?
Line 2844:
Line 2845: ##
Line 2846: # @Host.ping:
Line 2847: #
--
To view, visit http://gerrit.ovirt.org/15125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc32fa00eaa1b90c3ba9d0afffdeb1cdd8150f9a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change. Change subject: Catch libvirt timeout and return an error on setVmTicket .. Patch Set 12: Verified -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Vinzenz Feenstra ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Ignore after_vm_cont hook if _dom was not yet created
Roy Golan has posted comments on this change. Change subject: vdsm: Ignore after_vm_cont hook if _dom was not yet created .. Patch Set 1: +1 on raising event when _dom is ready -- To view, visit http://gerrit.ovirt.org/12558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e36f988c965b51855861f04bcebee5ad51d3b09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change. Change subject: Catch libvirt timeout and return an error on setVmTicket .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api-schema: adding expection to err objects
Roy Golan has abandoned this change. Change subject: api-schema: adding expection to err objects .. Patch Set 1: Abandoned adding exception object to vdsm error objects is the right thing to do but requires more work than this schema change (Adam correct me if I'm wrong here) -- To view, visit http://gerrit.ovirt.org/12455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iff07aa2da3b54111ef04c5e9abc42d579404a9f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change.
Change subject: Catch libvirt timeout and return an error on setVmTicket
..
Patch Set 6: (1 inline comment)
File vdsm/libvirtvm.py
Line 2415: self._dom.updateDeviceFlags(graphics.toxml(), 0)
Line 2416: except TimeoutError as tmo:
Line 2417: err = errCode['ticketErr']
Line 2418: err['exception'] = tmo
Line 2419: return err
just realize this will set the exception object for that error and I should
really get a new error copy in hand
err = dict(errCode['ticketErr'])
err['exception'] = tmo
Line 2420: hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2421: return {'status': doneCode}
Line 2422:
Line 2423: def _reviveTicket(self, newlife):
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Shu Ming
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change. Change subject: Catch libvirt timeout and return an error on setVmTicket .. Patch Set 6: jenkins's jsonRpcTest is failing with Bad File descriptor so I don't think its related -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api-schema: adding expection to err objects
Roy Golan has uploaded a new change for review.
Change subject: api-schema: adding expection to err objects
..
api-schema: adding expection to err objects
Adding optional exception string to the err object for more information
on the underlying root cause.
Change-Id: Iff07aa2da3b54111ef04c5e9abc42d579404a9f6
Signed-off-by: Roy Golan
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/12455/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index e2512ea..1fd80ee 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2889,9 +2889,11 @@
#
# @message: The error message
#
+# @exception: Optional exception message
+# #
# Since: 4.10.0
##
-{'type': 'ConnectionError', 'data': {'code': 'int', 'message': 'str'}}
+{'type': 'ConnectionError', 'data': {'code': 'int', 'message': 'str',
'exception': 'str'}}
##
# @ConnectionRef:
--
To view, visit http://gerrit.ovirt.org/12455
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff07aa2da3b54111ef04c5e9abc42d579404a9f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 3: (2 inline comments)
File vdsm/libvirtvm.py
Line 2456: graphics.setAttribute('passwdValidTo', validto)
Line 2457: if graphics.getAttribute('type') == 'spice':
Line 2458: graphics.setAttribute('connected', connAct)
Line 2459: hooks.before_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2460: self._dom.updateDeviceFlags(graphics.toxml(), 0)
totally right I was a bit blind on this one
Line 2461: hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2462: except TimeoutError as tmo:
Line 2463: err = errCode['internalVdsmTimeout']
Line 2464: err['exception'] = tmo
Line 2460: self._dom.updateDeviceFlags(graphics.toxml(), 0)
Line 2461: hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2462: except TimeoutError as tmo:
Line 2463: err = errCode['internalVdsmTimeout']
Line 2464: err['exception'] = tmo
add a dependency patch and put Adam, right?
Line 2465: return err
Line 2466: return {'status': doneCode}
Line 2467:
Line 2468: def _reviveTicket(self, newlife):
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Shu Ming
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change. Change subject: catch libvirt timeout and return an error on setVmTicket .. Patch Set 1: (2 inline comments) File vdsm/API.py Line 43: from vdsm.config import config Line 44: import ksm Line 45: Line 46: import supervdsm Line 47: from libvirtvm import TimeoutError Done Line 48: Line 49: # default message for system shutdown, will be displayed in guest Line 50: USER_SHUTDOWN_MESSAGE = 'System going down' Line 51: Line 575: except KeyError: Line 576: return errCode['noVM'] Line 577: except TimeoutError as tmo: Line 578: err = errCode['internalVdsmTimeout'] Line 579: err['exception'] = tmo Done I want to report the exception as it has relevant info for the engine which can't be described in the message - the timeout exception can be thrown with different causes. Line 580: return err Line 581: Line 582: def shutdown(self, delay=None, message=None): Line 583: """ -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change. Change subject: catch libvirt timeout and return an error on setVmTicket .. Patch Set 1: (1 inline comment) File vdsm/API.py Line 575: except KeyError: Line 576: return errCode['noVM'] Line 577: except TimeoutError as tmo: Line 578: err = errCode['internalVdsmTimeout'] Line 579: err['exception'] = tmo I meant this to be the string representation of the exception and not the object itself. will resend. Line 580: return err Line 581: Line 582: def shutdown(self, delay=None, message=None): Line 583: """ -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: catch libvirt timeout and return an error on setVmTicket
Roy Golan has posted comments on this change. Change subject: catch libvirt timeout and return an error on setVmTicket .. Patch Set 1: (1 inline comment) File vdsm/API.py Line 575: except KeyError: Line 576: return errCode['noVM'] Line 577: except TimeoutError as tmo: Line 578: err = errCode['internalVdsmTimeout'] Line 579: err['exception'] = tmo indeed, ovirt engine. its for better error handling/reporting. you can refer to the bz in the comment. Line 580: return err Line 581: Line 582: def shutdown(self, delay=None, message=None): Line 583: """ -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: catch libvirt timeout and return an error on setVmTicket
Roy Golan has uploaded a new change for review.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
catch libvirt timeout and return an error on setVmTicket
return an errCode instead of an exception libvirt timeout in setVmTicket
verb so upper layers could handle more easily.
Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=878064
Signed-off-by: Roy Golan
---
M vdsm/API.py
M vdsm/define.py
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/10285/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 60e37a5..239b5ad 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -44,6 +44,7 @@
import ksm
import supervdsm
+from libvirtvm import TimeoutError
# default message for system shutdown, will be displayed in guest
USER_SHUTDOWN_MESSAGE = 'System going down'
@@ -570,9 +571,13 @@
"""
try:
v = self._cif.vmContainer[self._UUID]
+return v.setTicket(password, ttl, existingConnAction, params)
except KeyError:
return errCode['noVM']
-return v.setTicket(password, ttl, existingConnAction, params)
+except TimeoutError as tmo:
+err = errCode['internalVdsmTimeout']
+err['exception'] = tmo
+return err
def shutdown(self, delay=None, message=None):
"""
diff --git a/vdsm/define.py b/vdsm/define.py
index 0313116..684e0a3 100644
--- a/vdsm/define.py
+++ b/vdsm/define.py
@@ -131,6 +131,10 @@
{'code': 99,
'message':
'Recovering from crash or Initializing'}},
+ 'internalVdsmTimeout': {'status':
+ {'code': 101,
+'message': 'Internal VDSM timeout'}
+ }
}
doneCode = {'code': 0, 'message': 'Done'}
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.1]: BZ#847744 fenceNode API is missing the options argument
Roy Golan has posted comments on this change. Change subject: BZ#847744 fenceNode API is missing the options argument .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.1]: BZ#847744 fenceNode API is missing the options argument
Roy Golan has posted comments on this change. Change subject: BZ#847744 fenceNode API is missing the options argument .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fenceNode API is missing the options argument
Roy Golan has posted comments on this change. Change subject: fenceNode API is missing the options argument .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fenceNode API is missing the options argument
Roy Golan has uploaded a new change for review. Change subject: fenceNode API is missing the options argument .. fenceNode API is missing the options argument Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Signed-off-by: Roy Golan --- M vdsm/BindingXMLRPC.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/7058/1 -- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#787728 configNet: restore backup on connectivity failure
Roy Golan has posted comments on this change. Change subject: BZ#787728 configNet: restore backup on connectivity failure .. Patch Set 2: (1 inline comment) File vdsm/configNetwork.py Line 1025: for bridge in networksAdded: pls change bride to network, we're going bridgeless soon! -- To view, visit http://gerrit.ovirt.org/1686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#787728 configNet: restore backup on connectivity failure
Roy Golan has posted comments on this change. Change subject: BZ#787728 configNet: restore backup on connectivity failure .. Patch Set 1: (1 inline comment) File vdsm/configNetwork.py Line 879: configWriter.restoreAtomicBackup() so the restore will be called twice? why? is it re-entrant? -- To view, visit http://gerrit.ovirt.org/1686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: boostrap completion: fix no reboot function and report.
Roy Golan has posted comments on this change. Change subject: boostrap completion: fix no reboot function and report. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: boostrap completion: fix no reboot function and report.
Roy Golan has posted comments on this change. Change subject: boostrap completion: fix no reboot function and report. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added mtu support for network interface
Roy Golan has posted comments on this change. Change subject: added mtu support for network interface .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added mtu support for network interface
Roy Golan has posted comments on this change. Change subject: added mtu support for network interface .. Patch Set 4: The backend needs the mtu reported in VdsCaps. If not reported by the ifcfg file please report the default -- To view, visit http://gerrit.ovirt.org/754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: change registration servlet name
Roy Golan has posted comments on this change. Change subject: vdsm-reg: change registration servlet name .. Patch Set 1: I'm just sending a patch to change that to /register so the link would be http://ovirt:8080/register -- To view, visit http://gerrit.ovirt.org/310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vds_boostrap: rename rhevm to engine
Roy Golan has uploaded a new change for review. Change subject: vds_boostrap: rename rhevm to engine .. vds_boostrap: rename rhevm to engine Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d --- M vds_bootstrap/vds_bootstrap.py M vdsm_reg/config.py M vdsm_reg/deployUtil.py.in M vdsm_reg/vdsm-reg-setup M vdsm_reg/vdsm-reg.conf.in 5 files changed, 28 insertions(+), 28 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/311/1 -- To view, visit http://gerrit.ovirt.org/311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: change registration servlet name
Roy Golan has uploaded a new change for review. Change subject: vdsm-reg: change registration servlet name .. vdsm-reg: change registration servlet name Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29 --- M vdsm_reg/vdsm-reg.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/310/1 -- To view, visit http://gerrit.ovirt.org/310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
