Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service > +1 for names, the numbers themselves are not portable across architectures. Right, lets use the names. Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service > See https://github.com/systemd/systemd/blob/aab723074c368f65aaf2748d0c530ba +1 for names, the numbers themselves are not portable across architectures. Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service > Also systemctl supports signal names, just like kill: See https://github.com/systemd/systemd/blob/aab723074c368f65aaf2748d0c530ba9a1e6ad3e/src/basic/signal-util.c#L237-L256 The (evil) line: DEFINE_PRIVATE_STRING_TABLE_LOOKUP(__signal, int); Define a fuction for looking up the values in __signal_table[] by the string value, so any of the signals names are available . Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service > Why run killl just to get the signal number? This code run on linux, the si Also systemctl supports signal names, just like kill: systemctl kill -s KILL vdsmd systemctl kill -s USR1 vdsmd Tested on rhel 7.1. Does this fail any other platforms? Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service Why run killl just to get the signal number? This code run on linux, the signal numbers are not going to change soon. Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 77: echodo $SYSTEMCTL restart vdsmd.service Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service > Nir, I think you just afraid of regressions and try to avoid verification f Yaniv, systemctl stop vdsmd can take up to 20 seconds - this is not a replacement for kill -9. Please read my previous comments. Line 82: Line 83: rm -fr $RENEWDIR Line 84: trap EXIT Line 85: exit 3 -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Yaniv Bronhaim has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 77: echodo $SYSTEMCTL restart vdsmd.service Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service > I think this will be good replacement for the kill commands above. Nir, I think you just afraid of regressions and try to avoid verification for that change - Any solution we choose will require verification and testing for the fencing flow. send SIGTERM, sleep 2 seconds, send SIGKILL is the exact way systemd does "systemctl restart" so there is NO different and waiting 7seconds should be enough. I don't see why your rejection is correct here - please explain from what you are worried from more specifically. Line 82: Line 83: rm -fr $RENEWDIR Line 84: trap EXIT Line 85: exit 3 -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
automat...@ovirt.org has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: * Update tracker::#1222564::OK * Check Bug-Url::OK * Check Public Bug::#1222564::OK, public bug * Check Product::#1222564::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > I think that if the semantic is just to restart vdsm, there is a more intui The semantics is to kill vdsm immediately - this is the purpose of fencing. Vdsm should start again after that because we systemd watch and restart vdsm after failures. Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > What is wrong with "systemctl kill" that you suggested bellow? I think that if the semantic is just to restart vdsm, there is a more intuitive way to do it, thats all. Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > Well, it looks like sysvinit (used to) run {super,}vdsmd with respawn, so b What is wrong with "systemctl kill" that you suggested bellow? Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > We are not getting rid of this code soon, we must support this for few year Well, it looks like sysvinit (used to) run {super,}vdsmd with respawn, so basically this gets rid of the running vdsm instance and brings up a fresh one. I'll send a version with your suggestions but I propose we think of a prettier way to interact with systemd services. Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > I wrote it as you suggested first (rev1) but I think it is kind of a wrong We are not getting rid of this code soon, we must support this for few years. The original code did not try to restart the service, and we are fixing a regression caused by incorrect porting to systemd. So the first thing we must do (quickly) is to restore the original behavior. If you think we should start vdsm after killing it, please suggest that in another patch. However, you cannot use "systemctl restart" instead of "systemctl kill" at this point in the script. Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > This is not equivalent to the original code. sysemctl restart can take 20 s I wrote it as you suggested first (rev1) but I think it is kind of a wrong approach. If we're to get rid of this code soon I won't oppose, but this code attempts to restart a service managed by systemd, and it should use facilities provided by systemd. Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service This is not equivalent to the original code. sysemctl restart can take 20 seconds. Please keep the original code behavior: - send SIGTERM - sleep 2 seconds - send SIGKILL We don't want to debug the new behavior and it may not be good enough regarding the timeouts (e.g. sleep 20 && $REBOOTCMM). Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service Line 77: echodo $SYSTEMCTL restart vdsmd.service Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service I think this will be good replacement for the kill commands above. Line 82: Line 83: rm -fr $RENEWDIR Line 84: trap EXIT Line 85: exit 3 -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
automat...@ovirt.org has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: * Update tracker::#1222564::OK * Check Bug-Url::OK * Check Public Bug::#1222564::OK, public bug * Check Product::#1222564::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
automat...@ovirt.org has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches