Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: support hot-plugged vnics .. hooks: ovs: support hot-plugged vnics To support hot-plugged vnics, we have to place our before_device_create hook to before_nic_hotplug hookpoing. Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Signed-off-by: Petr Horáček Bug-Url: https://bugzilla.redhat.com/1234867 Reviewed-on: https://gerrit.ovirt.org/52347 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in M vdsm_hooks/ovs/Makefile.am 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 5: * #1234867::Update tracker: OK * Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are closed, check 52348 -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 4: Verified+1 With this build, it is possible to add a new nic to running VM, VM is then able to ping its host. -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 4: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 3: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 2: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Edward Haas has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 148: return ['--', 'set', 'Bridge', BRIDGE_NAME, Line 149: 'stp_enable=%s' % str(stp).lower()] Line 150: Line 151: Line 152: def _set_aa_mapping(network, attrs, running_config): > We use this template: Many functions are a bless, so say SOLID principles. It should be very easy and fast to read, if possible. Anyway, it is up to you.. In general, I prefer good names with focused functions over comments. Line 153: """Handle OVS Auto-Attach mapping""" Line 154: command = [] Line 155: init_sid = rget(running_config.networks, (network, 'custom', 'ovs_aa_sid')) Line 156: init_vlan = rget(running_config.networks, (network, 'vlan')) -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 148: return ['--', 'set', 'Bridge', BRIDGE_NAME, Line 149: 'stp_enable=%s' % str(stp).lower()] Line 150: Line 151: Line 152: def _set_aa_mapping(network, attrs, running_config): > It's a bit complex to read what the func does, it will be nice to use somet We use this template: if differs: if init: remove if running: add In other places in OVS code. I'd be happier if we learn to read it, rather than transforming it into many functions. Line 153: """Handle OVS Auto-Attach mapping""" Line 154: command = [] Line 155: init_sid = rget(running_config.networks, (network, 'custom', 'ovs_aa_sid')) Line 156: init_vlan = rget(running_config.networks, (network, 'vlan')) -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: enable auto-attach mapping .. hooks: ovs: enable auto-attach mapping Add Auto-Attach mapping support to OVS hook. I-SID could be defined in engine with custom network property 'ovs_aa_sid'. This is supported only for tagged networks. Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/51859 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg --- M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Edward Haas has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Petr Horáček has abandoned this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Abandoned -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/52360/4//COMMIT_MSG Commit Message: Line 12: We have to change proxy handling to match new behavior using : getProxy() function. I don't understand why. is it related to the waitForState change? if not, can you split the apart, and better explain which patch introduced the need for getProxy? -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: two networks cannot share one tag .. hooks: ovs: two networks cannot share one tag testSetupNetworksNetCompatibilityMultipleNetsSameNic assigns the same tag to two networks. This is not possible with OVS, two fake bridges under the same OVS bridge cannot share a tag. Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/52361 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTestsOVS.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: Verified+1 OVS tests passed without a regression. Manual testing of ovs_aa_map option was OK -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: don't log every stats change .. Patch Set 3: * #1234867::Update tracker: OK * Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are closed, check 52346 -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: don't log every stats change .. hooks: ovs: don't log every stats change VDSM log is spammed with 'ovs_after_get_stats' and every hour the VDSM log is rotating. Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Bug-Url: https://bugzilla.redhat.com/1234867 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/52920 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm_hooks/ovs/ovs_after_get_stats.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: don't log every stats change .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: don't log every stats change .. Patch Set 2: Verified+1 vdsClient -s 0 getVdsStats now logs only hook execution. -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: don't log every stats change .. Patch Set 1: * #1234867::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
Petr Horáček has abandoned this change. Change subject: hooks: ovs: don't log every stats change .. Abandoned -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: don't log every stats change .. Patch Set 2: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
Petr Horáček has restored this change. Change subject: hooks: ovs: don't log every stats change .. Restored -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Jenkins CI has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 3: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 2 -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: don't log every stats change .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: don't log every stats change
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: don't log every stats change
..
hooks: ovs: don't log every stats change
VDSM log is spammed with 'ovs_after_get_stats' and every hour the VDSM
log is rotating.
This patch is ovirt-3.6-only because of native implementation will
be released soon on master.
Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96
Bug-Url: https://bugzilla.redhat.com/1234867
Signed-off-by: Petr Horáček
Label: ovirt-3.6-only
---
M vdsm_hooks/ovs/ovs_after_get_stats.py
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/52920/1
diff --git a/vdsm_hooks/ovs/ovs_after_get_stats.py
b/vdsm_hooks/ovs/ovs_after_get_stats.py
index 9e8e1bf..fc27b5f 100755
--- a/vdsm_hooks/ovs/ovs_after_get_stats.py
+++ b/vdsm_hooks/ovs/ovs_after_get_stats.py
@@ -17,7 +17,6 @@
#
# Refer to the README and COPYING files for full details of the license
#
-from functools import partial
import traceback
import six
@@ -27,9 +26,6 @@
import hooking
from ovs_utils import is_ovs_network
-import ovs_utils
-
-log = partial(ovs_utils.log, tag='ovs_after_get_stats: ')
def ovs_networks_stats(stats):
@@ -60,7 +56,6 @@
ovs_networks_stats[vlan_name] = stats[network]
ovs_networks_stats[vlan_name]['name'] = vlan_name
-log('Updating network stats with OVS networks: %s' % ovs_networks_stats)
return ovs_networks_stats
--
To view, visit https://gerrit.ovirt.org/52920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b3386118d0d43bec2e6eaa1799eb3c93a2e4c96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 3: Verified+1 The test is not used now. -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Petr Horáček has restored this change. Change subject: hooks: ovs: two networks cannot share one tag .. Restored -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Petr Horáček has abandoned this change. Change subject: hooks: ovs: two networks cannot share one tag .. Abandoned -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 1: Verified+1 It's possible to run OVS tests again. -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 1: I think that https://gerrit.ovirt.org/51698 has caused what you are seeing. But I do not understand you fix. -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: fix bonded network change problem .. hooks: ovs: fix bonded network change problem When we try to change a bonded network, setupNetworks explodes because we are trying to remove running_nic which is None. Now we first check if configuration is changed and then do optional removal and setup of a nic. Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/52344 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: Verified+1 Manually verified (added bonded network and then edited it). With following tests-fixing patches it passes functional tests OK. -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: two networks cannot share one tag .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: two networks cannot share one tag
Petr Horáček has uploaded a new change for review. Change subject: hooks: ovs: two networks cannot share one tag .. hooks: ovs: two networks cannot share one tag Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Signed-off-by: Petr Horáček --- M tests/functional/networkTestsOVS.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/52361/1 diff --git a/tests/functional/networkTestsOVS.py b/tests/functional/networkTestsOVS.py index 70b9d96..d58cb4e 100644 --- a/tests/functional/networkTestsOVS.py +++ b/tests/functional/networkTestsOVS.py @@ -90,6 +90,8 @@ 'testSetupNetworksMultiMTUsOverBond(False)', # bridgeless 'testSetupNetworksMultiMTUsOverNic(False)', # bridgeless 'testSetupNetworksNetCompatibilityMultipleNetsSameNic(False)', # brless +# two networks cannot share one tag +'testSetupNetworksNetCompatibilityMultipleNetsSameNic(True)', 'testSetupNetworksNiclessBridgeless', # bridgeless 'testSetupNetworksOverDhcpIface', # bridgeless 'testSetupNetworksRemoveBondWithKilledEnslavedNics', # bridgeless -- To view, visit https://gerrit.ovirt.org/52361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib60987c6cab9ebd77c60de2e6dd95aca41007f49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: fix tests (waitForState and vdsProxy)
..
hooks: ovs: fix tests (waitForState and vdsProxy)
We have to fake not only waitForKnownState, but also waitForState,
because of tests expects bond to turn UP, but that never happens.
We have to change proxy handling to match new behavior using
getProxy() function.
Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9
Signed-off-by: Petr Horáček
---
M tests/functional/networkTestsOVS.py
1 file changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/52360/1
diff --git a/tests/functional/networkTestsOVS.py
b/tests/functional/networkTestsOVS.py
index 17ffb3c..70b9d96 100644
--- a/tests/functional/networkTestsOVS.py
+++ b/tests/functional/networkTestsOVS.py
@@ -32,7 +32,7 @@
_get_source_route, dnsmasqDhcp, NETWORK_NAME,
IP_ADDRESS, IP_MASK, IP_CIDR, IP_GATEWAY,
IPv6_ADDRESS, IPv6_CIDR, VLAN_ID, NOCHK, SUCCESS)
-from utils import VdsProxy
+from utils import _VdsProxy
import dhcp
# WARNING: because of this module changes networkTests module, we cannot run
@@ -141,12 +141,13 @@
# When we set OVS bond device up, it does not turn UP, but only UNKNOWN
-def _fakeWaitForKnownOperstate(*args, **kwargs):
+def _fakeWaitForOperstate(*args, **kwargs):
pass
-networkTests._waitForKnownOperstate = _fakeWaitForKnownOperstate
+networkTests._waitForOperstate = _fakeWaitForOperstate
+networkTests._waitForKnownOperstate = _fakeWaitForOperstate
-class OVSVdsProxy(VdsProxy):
+class OVSVdsProxy(_VdsProxy):
def setupNetworks(self, networks, bonds, options):
if options.pop('ovs', True):
@@ -177,6 +178,21 @@
return super(OVSVdsProxy, self).setupNetworks(networks, bonds, options)
+_instance = OVSVdsProxy()
+
+
+def getProxy():
+"""
+We used to connect when a proxy was created but now
+we want to connect only when the proxy is needed.
+It is used in functional test context so we do not
+care about concurrent calls of this function.
+"""
+if not _instance._is_connected():
+_instance._connect()
+return _instance
+
+
@expandPermutations
class OVSNetworkTest(NetworkTest):
__test__ = True
@@ -196,7 +212,7 @@
return wrapper
def setUp(self):
-self.vdsm_net = OVSVdsProxy()
+self.vdsm_net = getProxy()
def setupNetworks(self, *args, **kwargs):
# Do not run test_kernel_config
--
To view, visit https://gerrit.ovirt.org/52360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50dc6cdf4312d194feeb2c8b7613a6adb61ccff9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: support hot-plugged vnics .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: support hot-plugged vnics
Petr Horáček has uploaded a new change for review. Change subject: hooks: ovs: support hot-plugged vnics .. hooks: ovs: support hot-plugged vnics To support hot-plugged vnics, we have to place our before_device_create hook to before_nic_hotplug hookpoing. Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Signed-off-by: Petr Horáček --- M vdsm_hooks/ovs/Makefile.am 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/52347/1 diff --git a/vdsm_hooks/ovs/Makefile.am b/vdsm_hooks/ovs/Makefile.am index a539039..152be56 100644 --- a/vdsm_hooks/ovs/Makefile.am +++ b/vdsm_hooks/ovs/Makefile.am @@ -53,6 +53,9 @@ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_device_create $(INSTALL_SCRIPT) $(srcdir)/ovs_before_device_create.py \ $(DESTDIR)$(vdsmhooksdir)/before_device_create/50_ovs + $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug + $(INSTALL_SCRIPT) $(srcdir)/ovs_before_device_create.py \ + $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/50_ovs $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_network_setup $(INSTALL_SCRIPT) $(srcdir)/ovs_before_network_setup.py \ $(DESTDIR)$(vdsmhooksdir)/before_network_setup/50_ovs @@ -75,6 +78,7 @@ $(RM) $(DESTDIR)$(vdsmhooksdir)/after_get_caps/50_ovs $(RM) $(DESTDIR)$(vdsmhooksdir)/after_get_stats/50_ovs $(RM) $(DESTDIR)$(vdsmhooksdir)/before_device_create/50_ovs + $(RM) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/50_ovs $(RM) $(DESTDIR)$(vdsmhooksdir)/before_network_setup/50_ovs $(RM) $(DESTDIR)$(vdsmhooksdir)/before_network_setup/ovs_setup_ovs.py $(RM) $(DESTDIR)$(vdsmhooksdir)/before_network_setup/ovs_setup_ip.py @@ -93,6 +97,9 @@ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_device_create $(INSTALL_SCRIPT) $(srcdir)/$(utilsfile) \ $(DESTDIR)$(vdsmhooksdir)/before_device_create/$(utilsfile) + $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug + $(INSTALL_SCRIPT) $(srcdir)/$(utilsfile) \ + $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/$(utilsfile) $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_network_setup $(INSTALL_SCRIPT) $(srcdir)/$(utilsfile) \ $(DESTDIR)$(vdsmhooksdir)/before_network_setup/$(utilsfile) @@ -107,6 +114,7 @@ $(RM) $(DESTDIR)$(vdsmhooksdir)/after_get_caps/$(utilsfile) $(RM) $(DESTDIR)$(vdsmhooksdir)/after_get_stats/$(utilsfile) $(RM) $(DESTDIR)$(vdsmhooksdir)/before_device_create/$(utilsfile) + $(RM) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/$(utilsfile) $(RM) $(DESTDIR)$(vdsmhooksdir)/before_network_setup/$(utilsfile) $(RM) $(DESTDIR)$(vdsmhooksdir)/after_network_setup/$(utilsfile) $(RM) $(DESTDIR)$(vdsmhooksdir)/after_network_setup_fail/$(utilsfile) -- To view, visit https://gerrit.ovirt.org/52347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8fa6a06fd93af3bd6a9f9d2ec3e302b088cdf98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: fix bonded network change problem
..
hooks: ovs: fix bonded network change problem
When we try to change bonded network, it explodes every time because
of we are trying to remove running_nic which is None.
Now we first check if configuration is changed and then do optional
removal and setup of a nic.
Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b
Signed-off-by: Petr Horáček
---
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/52344/1
diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
index 5b291b2..e4a7fd9 100644
--- a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
@@ -101,11 +101,11 @@
elif running_vlan != vlan:
commands.extend(['--', 'set', 'port', net, 'tag=%d' % vlan])
running_nic = running_config.networks[net].get('nic')
-if running_nic is None:
-commands.extend(_add_nic_port(net, nic, nets_by_nic))
-elif running_nic != nic:
-commands.extend(_del_nic_port(net, running_nic, nets_by_nic))
-commands.extend(_add_nic_port(net, nic, nets_by_nic))
+if running_nic != nic:
+if running_nic is not None:
+commands.extend(_del_nic_port(net, running_nic, nets_by_nic))
+elif nic is not None:
+commands.extend(_add_nic_port(net, nic, nets_by_nic))
running_config.setNetwork(net, attrs)
return commands
--
To view, visit https://gerrit.ovirt.org/52344
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix bonded network change problem
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd3a064b4d4a428c61353b1533f8ed4be732c1b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py:
Line 151:
Line 152: def _set_aa_mapping(network, attrs, running_config):
Line 153: """Handle OVS Auto-Attach mapping"""
Line 154: command = []
Line 155: init_sid = rget(running_config.networks, (network, 'custom',
'ovs_aa_sid'))
> In the future, it will be safer to read ovs actual settings.
I agree, now we are heavily dependent on running config.
Line 156: init_vlan = rget(running_config.networks, (network, 'vlan'))
Line 157: sid = rget(attrs, ('custom', 'ovs_aa_sid'))
Line 158: vlan = attrs.get('vlan')
Line 159: if init_sid != sid or init_vlan != vlan:
Line 151:
Line 152: def _set_aa_mapping(network, attrs, running_config):
Line 153: """Handle OVS Auto-Attach mapping"""
Line 154: command = []
Line 155: init_sid = rget(running_config.networks, (network, 'custom',
'ovs_aa_sid'))
> can we have a catchier name (say, "sid")?
they don't have to type anything, they add it to engine and then just select
from dropdown box. i'd rather keep it explicit, so it won't be confused with
some native networking property
Line 156: init_vlan = rget(running_config.networks, (network, 'vlan'))
Line 157: sid = rget(attrs, ('custom', 'ovs_aa_sid'))
Line 158: vlan = attrs.get('vlan')
Line 159: if init_sid != sid or init_vlan != vlan:
Line 161: command.extend(['--', 'del-aa-mapping', network, init_sid,
Line 162: init_vlan])
Line 163: if sid is not None:
Line 164: interfaces = (
Line 165: running_config.bonds.get(attrs['bonding'])['nics']
> Based on ovs-vsctl man:
I think that that comment applies only to Port and Interface commands.
add-aa-mapping command should be called on the whole bridge.
lldp:enable change is made in Interface table and therefore it has to be called
on nics (bondings are not listed there).
Line 166: if 'bonding' in attrs else [attrs['nic']])
Line 167: for interface in interfaces:
Line 168: command.extend(['--', 'set', 'Interface', interface,
Line 169: 'lldp:enable=true'])
Line 165: running_config.bonds.get(attrs['bonding'])['nics']
Line 166: if 'bonding' in attrs else [attrs['nic']])
Line 167: for interface in interfaces:
Line 168: command.extend(['--', 'set', 'Interface', interface,
Line 169: 'lldp:enable=true'])
> Can you please add a reference to where this settings are documented? I cou
Done
Line 170: command.extend(['--', 'add-aa-mapping', network, sid,
vlan])
Line 171:
Line 172: return command
Line 173:
--
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Edward Haas has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 148: return ['--', 'set', 'Bridge', BRIDGE_NAME, Line 149: 'stp_enable=%s' % str(stp).lower()] Line 150: Line 151: Line 152: def _set_aa_mapping(network, attrs, running_config): It's a bit complex to read what the func does, it will be nice to use something like this: if not _aa_mapping_configured() __aa_mapping_delete() _aa_mapping_update(sid, vlan) def _aa_mapping_configured(sid, vlan): if sid is None: return ... Line 153: """Handle OVS Auto-Attach mapping""" Line 154: command = [] Line 155: init_sid = rget(running_config.networks, (network, 'custom', 'ovs_aa_sid')) Line 156: init_vlan = rget(running_config.networks, (network, 'vlan')) Line 155: running_config In the future, it will be safer to read ovs actual settings. Like we do with kernelconfig. Line 165: running_config.bonds.get(attrs['bonding'])['nics'] Based on ovs-vsctl man: "These commands treat a bonded port as a single entity." So do we need to touch the port representing the bond or not the slave ports? Line 168: command.extend(['--', 'set', 'Interface', interface, : 'lldp:enable=true']) Can you please add a reference to where this settings are documented? I could not locate it in the man, saw it only in vswitch.xml. -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 155: ovs_aa_ can we have a catchier name (say, "sid")? I suspect that our users would prefer typing less. -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: Code-Review+1 -Verified -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 166: if 'bonding' in attrs else [attrs['nic']]) Line 167: for interface in interfaces: Line 168: command.extend(['--', 'set', 'Interface', interface, Line 169: 'lldp:enable=true']) Line 170: command.extend(['--', 'add-aa-mapping', network, sid, vlan]) > I am asking if the purpose of the method is just to replace a mapping, or a Aha! It should handle mapping according to given query. If no mapping is defined, we should remove it (if it exists); if there is different configuration, remove it and add new; if there was no mapping before, add it. So it should handle everything. Line 171: Line 172: return command Line 173: Line 174: -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 166: if 'bonding' in attrs else [attrs['nic']]) Line 167: for interface in interfaces: Line 168: command.extend(['--', 'set', 'Interface', interface, Line 169: 'lldp:enable=true']) Line 170: command.extend(['--', 'add-aa-mapping', network, sid, vlan]) > I don't understand, could you give me an example of broken behavior? I am asking if the purpose of the method is just to replace a mapping, or also to delete and add mappings? Line 171: Line 172: return command Line 173: Line 174: -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 166: if 'bonding' in attrs else [attrs['nic']]) Line 167: for interface in interfaces: Line 168: command.extend(['--', 'set', 'Interface', interface, Line 169: 'lldp:enable=true']) Line 170: command.extend(['--', 'add-aa-mapping', network, sid, vlan]) > If either init_sid or sid is None, then we will just delete a mapping or ju I don't understand, could you give me an example of broken behavior? Line 171: Line 172: return command Line 173: Line 174: -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Marcin Mirecki has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 160: if init_sid is not None: : command.extend(['--', 'del-aa-mapping', network, init_sid, : init_vlan]) : if sid is not None: : interfaces = ( : running_config.bonds.get(attrs['bonding'])['nics'] : if 'bonding' in attrs else [attrs['nic']]) : for interface in interfaces: : command.extend(['--', 'set', 'Interface', interface, : 'lldp:enable=true']) : command.extend(['--', 'add-aa-mapping', network, sid, vlan]) If either init_sid or sid is None, then we will just delete a mapping or just add a mapping. Would this be the correct behaviour? -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: enable auto-attach mapping
..
hooks: ovs: enable auto-attach mapping
Add Auto-Attach mapping support to OVS hook. I-SID could be defined
in engine with custom network property 'ovs_aa_sid'. This is supported
only for tagged networks.
Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0
Signed-off-by: Petr Horáček
---
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/51859/1
diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
index 5b291b2..880c028 100644
--- a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
@@ -81,6 +81,7 @@
commands.extend(['--', 'add-br', net, BRIDGE_NAME, str(vlan)])
if nic is not None:
commands.extend(_add_nic_port(net, nic, nets_by_nic))
+commands.extend(_set_aa_mapping(net, attrs, running_config.networks))
running_config.setNetwork(net, attrs)
return commands
@@ -106,6 +107,7 @@
elif running_nic != nic:
commands.extend(_del_nic_port(net, running_nic, nets_by_nic))
commands.extend(_add_nic_port(net, nic, nets_by_nic))
+commands.extend(_set_aa_mapping(net, attrs, running_config.networks))
running_config.setNetwork(net, attrs)
return commands
@@ -147,6 +149,29 @@
'stp_enable=%s' % str(stp).lower()]
+def _set_aa_mapping(network, attrs, running_config):
+"""Handle OVS Auto-Attach mapping"""
+command = []
+init_sid = rget(running_config.networks, (network, 'custom', 'ovs_aa_sid'))
+init_vlan = rget(running_config.networks, (network, 'vlan'))
+sid = rget(attrs, ('custom', 'ovs_aa_sid'))
+vlan = attrs.get('vlan')
+if init_sid != sid or init_vlan != vlan:
+if init_sid is not None:
+command.extend(['--', 'del-aa-mapping', network, init_sid,
+init_vlan])
+if sid is not None:
+interfaces = (
+running_config.bonds.get(attrs['bonding'])['nics']
+if 'bonding' in attrs else [attrs['nic']])
+for interface in interfaces:
+command.extend(['--', 'set', 'Interface', interface,
+'lldp:enable=true'])
+command.extend(['--', 'add-aa-mapping', network, sid, vlan])
+
+return command
+
+
def _get_untagged_net(running_config):
for network, attrs in iter_ovs_nets(running_config.networks):
if 'vlan' not in attrs:
@@ -183,6 +208,8 @@
if untagged_net not in (None, net):
raise Exception('Untagged network already defined with name %s' %
untagged_net)
+if rget(attrs, ('custom', 'ovs_aa_sid')) is not None:
+raise Exception('Cannot define aa-mapping on untagged network')
if stp and vlan is not None:
raise Exception('STP could be set only on untagged networks')
--
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: keep README on wiki
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: keep README on wiki .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/51294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: keep README on wiki
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: keep README on wiki .. hooks: ovs: keep README on wiki Keeping OVS README on wiki would give the hook more visibility and it will be easier to edit it. Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/51294 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M vdsm_hooks/ovs/README 1 file changed, 1 insertion(+), 112 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: keep README on wiki
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: keep README on wiki .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/51294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: keep README on wiki
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: keep README on wiki .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: keep README on wiki
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: keep README on wiki .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: keep README on wiki
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: keep README on wiki
..
hooks: ovs: keep README on wiki
Keeping OVS README on wiki would give the hook more visibility and
easier editation.
Change-Id: I44ff1e5dbdd819dc3676bdd753aa834949a61244
Signed-off-by: Petr Horáček
---
M vdsm_hooks/ovs/README
1 file changed, 1 insertion(+), 112 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/51294/1
diff --git a/vdsm_hooks/ovs/README b/vdsm_hooks/ovs/README
index 9899330..b583dcf 100644
--- a/vdsm_hooks/ovs/README
+++ b/vdsm_hooks/ovs/README
@@ -1,115 +1,4 @@
Open vSwitch VDSM hook
==
-This hook enables us to create selected networks and bonds as Open vSwitch
-devices.
-
-
-Warning
-
-This hook is not yet ready to be used in real environment. It passes some VDSM
-networks tests, but it is not able to run with oVirt Engine as a native Linux
-networking replacement. See TODO below.
-
-
-Installation
-
-
-In case of missing openvswitch package in repositories, you might install the
-package manualy.
-
-Install vdsm-hook-ovs package on a host:
-yum install vdsm-hook-ovs
-
-Configure engine for hook's custom network properties:
-PROPERTIES='ovs=.*'
-engine-config -s "UserDefinedNetworkCustomProperties=$PROPERTIES" --cver='3.5'
-systemctl restart ovirt-engine
-
-Don't forget to include the names of other custom network properties you may
-want to use, such as 'ethtool_opts'.
-
-
-Usage
--
-
-Setup network:
-In the oVirt UI open the 'Setup Host Networks' dialog. Proceed to editing
-a desired logical network's properties. Among them you will find 'ovs', set
-it to 'true' or '1' to mark is as OVS Network.
-
-Setup bonding:
-In the oVirt UI open the 'Setup Host Networks' dialog. Merge two networks.
-In opened 'Create New Bond' dialog select 'Bonding Mode' 'Custom' and set
-it to 'ovs=True'.
-
-
-Limitations
-
-- Only one untagged network
-- STP only on untagged network
-- All networks are bridged
-- Tested only with ifcfg configurator. OVS rollback probably won't be working
- with iproute2 or pyroute2 configurators
-
-
-TODO
-
-
-- Faster rollback:
- + Now in case of a rollback, we remove all OVS networks and bonds and then
-recreate them. This could be improved with changing just what have to
-be changed as we do in iproute2 rollback.
-- Implement QoS:
- + Linux HFSC QoS is supported by OVS and could be set up via ovs-vsctl
-as described here: [1]
-- Implement 'multicast_router' and 'multicast_snooping':
- + This feature is not supported by openvswitch until 2.4.0
- + We need to be able to set and get those values. It should be possible
-via 'mcast_snooping_enable' records, described here [1]
-- Implement implicitBonding
-- Defined multiple OVS Bridge instances:
- + Now custom network property 'ovs' is passing only True, we could change it
-to pass an integer and then create OVS network under 'ovsbr$INT'
-OVS Bridge instance.
-- Fix networkTestsOVS.py dependencies: # TO BE CHECKED
- + It is possible that this test fail would cause problems when
-vdsm-hook-ovs package is installed without vdsm-tests.
-- Better OVS command logging:
- + Now we log created OVS command as one long string. It would be nice to
-split commands with new lines and add 'comment' about what was done with
-certain sub-command.
-- Allow non-OVS=>OVS and OVS=>non-OVS changes:
- + Now we do not handle the situation when OVS network is changed into
-non-OVS and vice versa.
- + non-OVS=>OVS editation should be easy, we could handle it within
-a before_network_setup hook.
- + OVS=>non-OVS editation is harder, while we have to first remove non-OVS
-network and then create OVS network after_network_setup.
-- Better handling of traceback and logging:
- + We need more logging.
- + Traceback sometimes provides hooking mess, but not an initial error.
-- Network persistence:
- + An easy way would be to remove all OVS networks on startup (as we do in
-rollback) and then let persistence restoration to recreate it all.
-- Bond does not turn UP: # TO BE CHECKED
- + When we create OVS Bond and attach real NICs to it, it does not turn UP,
-even after `ip link set ovsbond up`
- + Check if it OK or a BUG.
-- Call `sysctl enable openvswitch` on hook installation
-- Report bridge options (like netinfo._bridge_options):
- + We need to report at least some of bridge options. It is not possible to
-read them the same way as with native Linux bridges.
-- Implement ports:
- + We should report NICs and VM nets attached to bridge/network in caps.
-- Move needed VDSM non-libraries to vdsm/lib:
- + Now we use hacky sys.path.append('/usr/share/vdsm') to access some VDSM
-modules. They should be moved to vdsm/lib.
-- When we configure dhclient over a network and then setup fails, dhclient
- is not rolled back.
-
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: show vlan in caps ports .. hooks: ovs: show vlan in caps ports Until now, when we set up a tagged network we reported only directly attached nics and bonds. To be compatible with VDSM we have to report attached vlan (in its iface.id format) too. Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/50730 Reviewed-by: Ido Barkan Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py M vdsm_hooks/ovs/ovs_after_get_caps.py 2 files changed, 22 insertions(+), 7 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/50730/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 233: hostQos=None, assert_in_running_conf=True): Line 234: netinfo = self.vdsm_net.netinfo Line 235: running_config = self.vdsm_net.config Line 236: network_config = running_config.networks[networkName] Line 237: network_netinfo = netinfo.networks[networkName] unrelated but could we keep it? Line 238: self.assertIn(networkName, netinfo.networks) Line 239: if bridged is not None: Line 240: self.assertEqual(bridged, network_netinfo['bridged']) Line 241: if bridged: -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: set OVS devices UP .. hooks: ovs: set OVS devices UP Set all attached and created devices explicitly UP. We need to do a minor change in tests: when we set OVS bond up, it turns into UNKNOWN state, not UP state. Because of that we have to return fake True from networkTests._waitForKnownOperstate. Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/48388 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTestsOVS.py M vdsm_hooks/ovs/ovs_before_network_setup.py M vdsm_hooks/ovs/ovs_utils.py 3 files changed, 43 insertions(+), 2 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
Ido Barkan has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 10: Verified+1 passed ovs tests without a regression -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: set OVS devices UP
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 9: Verified+1 passwd ovs tests without a regression -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 10: Verified+1 Passed functional network and OVS tests without a regression. -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Ido Barkan has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: show vlan in caps ports
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/50730/5/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:
Line 71: 'dhcpv6': dhcpv6,
Line 72: 'cfg': {'BOOTPROTO': 'dhcp' if dhcpv4 else 'none'}}
Line 73:
Line 74:
Line 75: def _get_ports(network, attrs):
> this is a little complicated. can you add a doc string?
Done
Line 76: top_device = network if 'vlan' in attrs else BRIDGE_NAME
Line 77: physical_interface = attrs.get('bonding') or attrs.get('nic')
Line 78: assigned_port = ('%s.%s' % (physical_interface, attrs.get('vlan'))
Line 79: if 'vlan' in attrs else physical_interface or
None)
Line 76: top_device = network if 'vlan' in attrs else BRIDGE_NAME
Line 77: physical_interface = attrs.get('bonding') or attrs.get('nic')
Line 78: assigned_port = ('%s.%s' % (physical_interface, attrs.get('vlan'))
Line 79: if 'vlan' in attrs else physical_interface or
None)
Line 80: ports = (list(set(_list_ports(top_device).append(assigned_port)))
> can _list_ports return duplicates? if not, this is a little more confusing
Done
Line 81: if assigned_port else _list_ports(top_device))
Line 82: return ports
Line 83:
Line 84:
--
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: show vlan in caps ports
Ido Barkan has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/50730/5/vdsm_hooks/ovs/ovs_after_get_caps.py File vdsm_hooks/ovs/ovs_after_get_caps.py: Line 75: _get_ports this is a little complicated. can you add a doc string? what should _list_ports return in the cases of top_device? Line 80: _list_ports can _list_ports return duplicates? if not, this is a little more confusing then: if x not in l: l.append(x) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
