Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 12: Code-Review-1 we need to write only to runningConfig and drop the checkConnectivity behavior. setSafeConfig should handle the persisting. -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40088/7/vdsm/network/api.py File vdsm/network/api.py: Line 550: with open(os.path.join(dir_path, device_name), 'w') as f: Line 551: f.write(str(numvfs)) Line 552: Line 553: Line 554: def changeNumvfs(device_name, num_vfs): that's intended, since this is new code, and a parameter name. I will actua 'numvfs' is the name used everywhere in kernel and documentation, I don't see a reason to break the systemwide consistency. The method, according to pep8 and this consistency, should be called 'change_numvfs' and the formal parameter 'numvfs'. Line 555: Change number of virtual functions of a device in a 'safe' way. If the Line 556: connectivity to engine is lost as a consequence, the value is restored. Line 557: Since calling this verb is currently blocked by engine if this device is Line 558: already in use, the logic does not attempt to do anything further, such as -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 9: Code-Review-1 Please do not create stack naming inconsistence with num_vfs. -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 9: (Small correction: numvfs is used for documentation and generic pci driver, the drivers themself use num_vfs. I still vote for numvfs due to consistence and pci/iov.c compatibility) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 9: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1635/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/40088/7/vdsm/network/api.py File vdsm/network/api.py: Line 529: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION, Line 530: 'connectivity check failed') Line 531: Line 532: Line 533: def _update_num_vfs(device_name, num_vfs): reintroduced the num_vfs to numvfs consistency see below comment Line 534: with open(_SYSFS_SRIOV_NUMVFS.format(device_name), 'w', 0) as f: Line 535: # Zero needs to be written first in order to remove previous VFs. Line 536: # Trying to just write the number (if n 0 VF's existed before) Line 537: # results in 'write error: Device or resource busy' Line 550: with open(os.path.join(dir_path, device_name), 'w') as f: Line 551: f.write(str(numvfs)) Line 552: Line 553: Line 554: def changeNumvfs(device_name, num_vfs): num_vfs - numvfs again that's intended, since this is new code, and a parameter name. I will actually want to rename changeNumvfs to change_num_vfs later. Line 555: Change number of virtual functions of a device in a 'safe' way. If the Line 556: connectivity to engine is lost as a consequence, the value is restored. Line 557: Since calling this verb is currently blocked by engine if this device is Line 558: already in use, the logic does not attempt to do anything further, such as https://gerrit.ovirt.org/#/c/40088/7/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 55: missing_devices = [] # devices that no longer exist Line 56: Line 57: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH): Line 58: os.makedirs(_VIRTUAL_FUNCTIONS_PATH) Line 59: return Trailing whitespace Done Line 60: Line 61: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH): Line 62: if file_name not in existing_sriov_devices: Line 63: missing_devices.append(file_name) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 9: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18404/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40088/7/vdsm/network/api.py File vdsm/network/api.py: Line 550: with open(os.path.join(dir_path, device_name), 'w') as f: Line 551: f.write(str(numvfs)) Line 552: Line 553: Line 554: def changeNumvfs(device_name, num_vfs): 'numvfs' is the name used everywhere in kernel and documentation, I don't s okay. Line 555: Change number of virtual functions of a device in a 'safe' way. If the Line 556: connectivity to engine is lost as a consequence, the value is restored. Line 557: Since calling this verb is currently blocked by engine if this device is Line 558: already in use, the logic does not attempt to do anything further, such as -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 12: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18433/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 12: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1664/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 12: Code-Review+1 Looks fine from code standpoint, cannot judge network side though. -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 10: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1659/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 10: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18428/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 11: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1661/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 11: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18430/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2897/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1549/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change.
Change subject: network: restore sriov devices number of vfs
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40088/6/vdsm/network/api.py
File vdsm/network/api.py:
Line 562:
Line 563: logger = logging.getLogger(changeNumvfs)
Line 564: original_value = _get_num_vfs(device_name)
Line 565: logger.info(changing number of vfs on device %s to %s.,
Line 566: device_name, num_vfs)
Not sure I understand. Do you mean using _SYSFS_SRIOV_NUMVFS.format(device_
Meant 'changing number of vfs on device {} to {}'.format(device_name, num_vfs)
Line 567: _update_num_vfs(device_name, num_vfs)
Line 568: if not clientSeen(CONNECTIVITY_TIMEOUT_DEFAULT):
Line 569: _update_num_vfs(device_name, original_value)
Line 570: logger.error(changing number of vfs on device %s failed
during
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: Code-Review-1 (3 comments) Still minor num_vfs and numvfs inconsistency mistakes, I see no issues (apart from the location which I won't fight) with the code itself (-1 for inconsistency/whitespace) https://gerrit.ovirt.org/#/c/40088/7/vdsm/network/api.py File vdsm/network/api.py: Line 529: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION, Line 530: 'connectivity check failed') Line 531: Line 532: Line 533: def _update_num_vfs(device_name, num_vfs): reintroduced the num_vfs to numvfs consistency Line 534: with open(_SYSFS_SRIOV_NUMVFS.format(device_name), 'w', 0) as f: Line 535: # Zero needs to be written first in order to remove previous VFs. Line 536: # Trying to just write the number (if n 0 VF's existed before) Line 537: # results in 'write error: Device or resource busy' Line 550: with open(os.path.join(dir_path, device_name), 'w') as f: Line 551: f.write(str(numvfs)) Line 552: Line 553: Line 554: def changeNumvfs(device_name, num_vfs): num_vfs - numvfs again Line 555: Change number of virtual functions of a device in a 'safe' way. If the Line 556: connectivity to engine is lost as a consequence, the value is restored. Line 557: Since calling this verb is currently blocked by engine if this device is Line 558: already in use, the logic does not attempt to do anything further, such as https://gerrit.ovirt.org/#/c/40088/7/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 55: missing_devices = [] # devices that no longer exist Line 56: Line 57: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH): Line 58: os.makedirs(_VIRTUAL_FUNCTIONS_PATH) Line 59: return Trailing whitespace Line 60: Line 61: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH): Line 62: if file_name not in existing_sriov_devices: Line 63: missing_devices.append(file_name) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 8: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2898/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 8: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18359/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 8: Build Started (3/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1589/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18359/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2898/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1589/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2892/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1512/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 6: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2894/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2894/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1516/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 6: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18286/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 6: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1516/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 5: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1512/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2897/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18319/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 7: Build Started (3/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1549/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change.
Change subject: network: restore sriov devices number of vfs
..
Patch Set 6:
(7 comments)
Martin, about your concern. SRIOV is currently a network feature, both in
engine and in VDSM.
Since this is not a lot of code and since restoration is also currently a
network related issue, lets sacrifice generality for simplicity. It will not be
hard to move things around in the future, when we need to support non-network
SRIOV devices.
https://gerrit.ovirt.org/#/c/40088/6/vdsm/network/api.py
File vdsm/network/api.py:
Line 557: Since calling this verb is currently blocked by engine if this
device is
Line 558: already in use, the logic does not attempt to do anything
further, such as
Line 559: restoring possibly lost networks.
Line 560: The persistence is stored in a place which is writable also in
ovirt-node.
Line 561: Garbage is will be collected during restoration.
type: just will
Done
Line 562:
Line 563: logger = logging.getLogger(changeNumvfs)
Line 564: original_value = _get_num_vfs(device_name)
Line 565: logger.info(changing number of vfs on device %s to %s.,
Line 562:
Line 563: logger = logging.getLogger(changeNumvfs)
Line 564: original_value = _get_num_vfs(device_name)
Line 565: logger.info(changing number of vfs on device %s to %s.,
Line 566: device_name, num_vfs)
Is there a reason not to use format here when it is used in later in _get_n
Not sure I understand. Do you mean using
_SYSFS_SRIOV_NUMVFS.format(device_name) in the log message?
Line 567: _update_num_vfs(device_name, num_vfs)
Line 568: if not clientSeen(CONNECTIVITY_TIMEOUT_DEFAULT):
Line 569: _update_num_vfs(device_name, original_value)
Line 570: logger.error(changing number of vfs on device %s failed
during
https://gerrit.ovirt.org/#/c/40088/6/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 50: if 'totalvfs' in device['params']]
Line 51:
Line 52:
Line 53: def _get_persisted_numvfs(existing_sriov_devices):
Line 54: num_vfs_by_device = {}
minor: I'd rather see numvfs as elsewhere
Done
Line 55: missing_devices = [] # devices that no longer exist
Line 56:
Line 57: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 58: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
Line 54: num_vfs_by_device = {}
Line 55: missing_devices = [] # devices that no longer exist
Line 56:
Line 57: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 58: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
Return here would save branch that is guaranteed to not find anything
well, the for will iterate nothing but +1 for readability (and saving a syscall
:-) ).
Line 59:
Line 60: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 61: if file_name not in existing_sriov_devices:
Line 62: missing_devices.append(file_name)
Line 76:
Line 77:
Line 78: def _restore_sriov_num_vfs():
Line 79: sriov_devices = _get_sriov_devices()
Line 80: persisted_num_vfs, missing_devices =
_get_persisted_numvfs(sriov_devices)
Same minor issue with numvfs and numvfs (very visible inconsistence here)
Done
Line 81:
Line 82: for device in sriov_devices:
Line 83: desired_num_vfs = persisted_num_vfs.get(device)
Line 84: if desired_num_vfs is not None:
Line 79: sriov_devices = _get_sriov_devices()
Line 80: persisted_num_vfs, missing_devices =
_get_persisted_numvfs(sriov_devices)
Line 81:
Line 82: for device in sriov_devices:
Line 83: desired_num_vfs = persisted_num_vfs.get(device)
As above
Done
Line 84: if desired_num_vfs is not None:
Line 85: logging.info('Changing number of virtual functions for
device %s '
Line 86: 'to %s', device, desired_num_vfs)
Line 87: else:
Line 84: if desired_num_vfs is not None:
Line 85: logging.info('Changing number of virtual functions for
device %s '
Line 86: 'to %s', device, desired_num_vfs)
Line 87: else:
Line 88: logging.info('an SRIOV network device which is not
persisted found'
typo: an - a, additional question: is the else branch logging required?
I believe so. Boot time part of VDSM is infamous of low predictability,
especially when restoration takes place, and I would like us (and
administrators) to be able to analyze what happened easily.
Line 89: 'at: %s.', device)
Line 90: continue
Line 91:
Line 92: changeNumvfs(device, desired_num_vfs)
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Change in vdsm[master]: network: restore sriov devices number of vfs
Martin Polednik has posted comments on this change.
Change subject: network: restore sriov devices number of vfs
..
Patch Set 6: Code-Review-1
(7 comments)
Multiple minor issue, I would also like to express one major issue:
this is heavily moving the code to network while this is perfectly generic
feature. I would really like to see it moved back to hostdev module where it
belongs.
https://gerrit.ovirt.org/#/c/40088/6/vdsm/network/api.py
File vdsm/network/api.py:
Line 557: Since calling this verb is currently blocked by engine if this
device is
Line 558: already in use, the logic does not attempt to do anything
further, such as
Line 559: restoring possibly lost networks.
Line 560: The persistence is stored in a place which is writable also in
ovirt-node.
Line 561: Garbage is will be collected during restoration.
type: just will
Line 562:
Line 563: logger = logging.getLogger(changeNumvfs)
Line 564: original_value = _get_num_vfs(device_name)
Line 565: logger.info(changing number of vfs on device %s to %s.,
Line 562:
Line 563: logger = logging.getLogger(changeNumvfs)
Line 564: original_value = _get_num_vfs(device_name)
Line 565: logger.info(changing number of vfs on device %s to %s.,
Line 566: device_name, num_vfs)
Is there a reason not to use format here when it is used in later in
_get_num_vfs? (same for other logging) Also, - '
Line 567: _update_num_vfs(device_name, num_vfs)
Line 568: if not clientSeen(CONNECTIVITY_TIMEOUT_DEFAULT):
Line 569: _update_num_vfs(device_name, original_value)
Line 570: logger.error(changing number of vfs on device %s failed
during
https://gerrit.ovirt.org/#/c/40088/6/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 50: if 'totalvfs' in device['params']]
Line 51:
Line 52:
Line 53: def _get_persisted_numvfs(existing_sriov_devices):
Line 54: num_vfs_by_device = {}
minor: I'd rather see numvfs as elsewhere
Line 55: missing_devices = [] # devices that no longer exist
Line 56:
Line 57: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 58: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
Line 54: num_vfs_by_device = {}
Line 55: missing_devices = [] # devices that no longer exist
Line 56:
Line 57: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 58: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
Return here would save branch that is guaranteed to not find anything
Line 59:
Line 60: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 61: if file_name not in existing_sriov_devices:
Line 62: missing_devices.append(file_name)
Line 76:
Line 77:
Line 78: def _restore_sriov_num_vfs():
Line 79: sriov_devices = _get_sriov_devices()
Line 80: persisted_num_vfs, missing_devices =
_get_persisted_numvfs(sriov_devices)
Same minor issue with numvfs and numvfs (very visible inconsistence here)
Line 81:
Line 82: for device in sriov_devices:
Line 83: desired_num_vfs = persisted_num_vfs.get(device)
Line 84: if desired_num_vfs is not None:
Line 79: sriov_devices = _get_sriov_devices()
Line 80: persisted_num_vfs, missing_devices =
_get_persisted_numvfs(sriov_devices)
Line 81:
Line 82: for device in sriov_devices:
Line 83: desired_num_vfs = persisted_num_vfs.get(device)
As above
Line 84: if desired_num_vfs is not None:
Line 85: logging.info('Changing number of virtual functions for
device %s '
Line 86: 'to %s', device, desired_num_vfs)
Line 87: else:
Line 84: if desired_num_vfs is not None:
Line 85: logging.info('Changing number of virtual functions for
device %s '
Line 86: 'to %s', device, desired_num_vfs)
Line 87: else:
Line 88: logging.info('an SRIOV network device which is not
persisted found'
typo: an - a, additional question: is the else branch logging required?
Line 89: 'at: %s.', device)
Line 90: continue
Line 91:
Line 92: changeNumvfs(device, desired_num_vfs)
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18248/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2890/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2890/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1478/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2891/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1492/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 5: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18282/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 5: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2892/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 4: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2891/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 4: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18262/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 4: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1492/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 3: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1478/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2887/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1448/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40088/1/vdsm/network/api.py File vdsm/network/api.py: Line 558: os.makedirs(dir_path) Line 559: except OSError as ose: Line 560: if errno.EEXIST != ose.errno: Line 561: raise Line 562: with open(dir_path, device_name, 'w') as f: os.path.join Done Line 563: f.write(str(numvfs)) Line 564: Line 565: Line 566: def changeNumvfs(device_name, num_vfs): https://gerrit.ovirt.org/#/c/40088/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 67: return num_vfs_by_device, missing_devices Line 68: Line 69: Line 70: def _remove_missing_devices_persistence(missing_devices): Line 71: for file_name in missing_devices: please log missing devices - if we suddenly no longer see a device, let the Done Line 72: os.remove(os.path.join(_VIRTUAL_FUNCTIONS_PATH, file_name)) Line 73: Line 74: Line 75: def _restore_sriov_num_vfs(): -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2887/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18218/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1448/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Dan Kenigsberg has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/40088/1/vdsm/network/api.py File vdsm/network/api.py: Line 558: os.makedirs(dir_path) Line 559: except OSError as ose: Line 560: if errno.EEXIST != ose.errno: Line 561: raise Line 562: with open(dir_path, device_name, 'w') as f: os.path.join Line 563: f.write(str(numvfs)) Line 564: Line 565: Line 566: def changeNumvfs(device_name, num_vfs): https://gerrit.ovirt.org/#/c/40088/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 67: return num_vfs_by_device, missing_devices Line 68: Line 69: Line 70: def _remove_missing_devices_persistence(missing_devices): Line 71: for file_name in missing_devices: please log missing devices - if we suddenly no longer see a device, let the admin know about it. Line 72: os.remove(os.path.join(_VIRTUAL_FUNCTIONS_PATH, file_name)) Line 73: Line 74: Line 75: def _restore_sriov_num_vfs(): -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has uploaded a new change for review.
Change subject: network: restore sriov devices number of vfs
..
network: restore sriov devices number of vfs
vdsm-restore-net-config will attempt to restore the number of vfs
from the last successful change. If no sriov devices are found the
function only tries to collect garbage. This is done before network
restoration so that networks can be configured based on the
restored vfs.
The patch also introduces a 'safe' changing of number of vfs of an
sriov card which also checks if the connectivity to the engine was
lost as a consequence.
Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M vdsm/network/api.py
M vdsm/vdsm-restore-net-config
2 files changed, 85 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/40088/1
diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index bc2dbd2..07f2640 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -40,6 +40,7 @@
import hooks # TODO: Turn into parent package import when vdsm is a package
CONNECTIVITY_TIMEOUT_DEFAULT = 4
+_SYSFS_SRIOV_NUMVFS = '/sys/bus/pci/devices/{}/sriov_numvfs'
def _getConfiguratorClass():
@@ -541,17 +542,51 @@
'connectivity check failed')
-def changeNumvfs(device_name, numvfs):
-with open('/sys/bus/pci/devices/{}/sriov_numvfs'.format(
-device_name), 'w', 0) as f:
+def _update_num_vfs(device_name, num_vfs):
+with open(_SYSFS_SRIOV_NUMVFS.format(device_name), 'w', 0) as f:
# Zero needs to be written first in order to remove previous VFs.
# Trying to just write the number (if n 0 VF's existed before)
# results in 'write error: Device or resource busy'
# https://www.kernel.org/doc/Documentation/PCI/pci-iov-howto.txt
f.write('0')
+f.write(str(num_vfs))
+
+
+def _persist_num_vfs(device_name, numvfs):
+dir_path = os.path.join(constants.P_VDSM_LIB, 'virtual_functions')
+try:
+os.makedirs(dir_path)
+except OSError as ose:
+if errno.EEXIST != ose.errno:
+raise
+with open(dir_path, device_name, 'w') as f:
f.write(str(numvfs))
+def changeNumvfs(device_name, num_vfs):
+Change number of virtual functions of a device in a 'safe' way. If the
+connectivity to engine is lost as a consequence, the value is restored.
+Since calling this verb is currently blocked by engine if this device is
+already in use, the logic does not attempt to do anything further, such as
+restoring possibly lost networks.
+The persistence is stored in a place which is writable also in ovirt-node.
+Garbage is will be collected during restoration.
+
+original_value = _get_num_vfs(device_name)
+_update_num_vfs(device_name, num_vfs)
+if not clientSeen():
+_update_num_vfs(device_name, original_value)
+raise ConfigNetworkError(
+ne.ERR_LOST_CONNECTION, 'connectivity check failed')
+
+_persist_num_vfs(device_name, num_vfs)
+
+
+def _get_num_vfs(device_name):
+with open(_SYSFS_SRIOV_NUMVFS.format(device_name), 'r', 0) as f:
+return int(f.read())
+
+
def _validateNetworkSetup(networks, bondings):
for network, networkAttrs in networks.iteritems():
if networkAttrs.get('remove', False):
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index 21d6592..afe4abd 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -27,21 +27,64 @@
from vdsm.config import config
from vdsm import netinfo
-from vdsm.constants import P_VDSM_RUN
+from vdsm.constants import P_VDSM_RUN, P_VDSM_LIB
+import hostdev
# Ifcfg persistence restoration
from network.configurators import ifcfg
# Unified persistence restoration
-from network.api import setupNetworks
+from network.api import setupNetworks, changeNumvfs
from network import configurators
from vdsm.netconfpersistence import RunningConfig, PersistentConfig
import pkgutil
_NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored')
+_VIRTUAL_FUNCTIONS_PATH = os.path.join(P_VDSM_LIB, 'virtual_functions')
+
+
+def _get_sriov_devices():
+devices = hostdev.list_by_caps()
+sriov_pci_addrs = [addr for addr, device in devices.iteritems()
+ if 'totalvfs' in device['params']]
+net_devs = [device for device in devices.itervalues()
+if device['params']['capability'] == 'net']
+return [device['params']['interface'] for device in net_devs
+if device['params']['parent'] in sriov_pci_addrs]
+
+
+def _get_persisted_numvfs(existing_sriov_devices):
+num_vfs_by_device = {}
+missing_devices = []
+for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
+if file_name not in existing_sriov_devices:
+
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17946/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2878/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: Build Started (3/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18118/ -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18118/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17946/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2878/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
