Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


storage: Split newMetadata into makeMetadata and createMetadata

To prepare for garbage-collectible volume metadata needed by the SDM
flows, we need to break out the functionality of creating new volume
metadata.  Introduce makeMetadata() which builds a metadata dict from a
given set of args.

Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/44045
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/volume.py
1 file changed, 17 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 16: Code-Review+2

Lets take it as is, I don't want to delay this more. We will make this nicer in 
the next iteration.

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/15/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 533: cls.createMetadata(metaId, meta_dict)
Line 534: return meta_dict
Line 535: 
Line 536: @classmethod
Line 537: def new_metadata_dict(cls, sdUUID, imgUUID, puuid, size, format, 
type,
> This is little better. What if we move this code into a new VolumeMeta?
We need a better name than VolumeMeta.  What's the difference between 
VolumeMetadata and VolumeMeta?
Line 538:   voltype, disktype, desc="", 
legality=ILLEGAL_VOL):
Line 539: """
Line 540: Produce a metadata dictionary from a set of arguments.
Line 541: """


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/15/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 533: cls.createMetadata(metaId, meta_dict)
Line 534: return meta_dict
Line 535: 
Line 536: @classmethod
Line 537: def new_metadata_dict(cls, sdUUID, imgUUID, puuid, size, format, 
type,
> We need a better name than VolumeMeta.  What's the difference between Volum
I agree, VolumeMetadata would be great, but you took that name :-)
Line 538:   voltype, disktype, desc="", 
legality=ILLEGAL_VOL):
Line 539: """
Line 540: Produce a metadata dictionary from a set of arguments.
Line 541: """


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 15: Verified+1

Verified with 'make check' and by doing LSM+Live Merge.

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 15: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44045/15/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 533: cls.createMetadata(metaId, meta_dict)
Line 534: return meta_dict
Line 535: 
Line 536: @classmethod
Line 537: def new_metadata_dict(cls, sdUUID, imgUUID, puuid, size, format, 
type,
This is little better. What if we move this code into a new VolumeMeta?

class VolumeMeta(object):

def __init__(self, sdUUID, ...):
self.format = foramt
 ...

def info(self):
return {FORMAT: self.format, ...}

Now we can use this class from both new and old code, and we make legacy class 
smaller and easier to work with. Later we can move funcionality into the 
metadata class, like formatMetadata.
Line 538:   voltype, disktype, desc="", 
legality=ILLEGAL_VOL):
Line 539: """
Line 540: Produce a metadata dictionary from a set of arguments.
Line 541: """


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 14:

(2 comments)

https://gerrit.ovirt.org/#/c/44045/14/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 522
Line 523
Line 524
Line 525
Line 526
> This separation makes sense, although I did not see the other place using t
It will be used by the volume artifacts when creating a new volume.


Line 533: return meta
Line 534: 
Line 535: @classmethod
Line 536: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type,
Line 537:  voltype, disktype, desc="", 
legality=ILLEGAL_VOL):
> The name is confusing. This return a metadata dict that can be used to crea
new_metadata_dict
Line 538: """
Line 539: Produce a metadata dictionary from a set of arguments.
Line 540: """
Line 541: return {


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 14: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/44045/14/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 522
Line 523
Line 524
Line 525
Line 526
This separation makes sense, although I did not see the other place using the 
new method yet, but the names are very confusing.


Line 533: return meta
Line 534: 
Line 535: @classmethod
Line 536: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type,
Line 537:  voltype, disktype, desc="", 
legality=ILLEGAL_VOL):
The name is confusing. This return a metadata dict that can be used to create 
newMetadata, or for some other purpose.

How about newMetadict?
Line 538: """
Line 539: Produce a metadata dictionary from a set of arguments.
Line 540: """
Line 541: return {


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[derez]

Daniel Erez has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 530: return meta
Line 531: 
Line 532: @classmethod
Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type, 
voltype,
Line 534:  disktype, desc="", legality=ILLEGAL_VOL):
> Hmm, not really sure what you mean here.  none of the lines are too long.
Just meant to align the variables with newMetadata method for easier 
identification of the difference.
I.e.
line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL):
line 534: voltype, disktype, desc="", legality=ILLEGAL_VOL):
Line 535: return {
Line 536: FORMAT: str(format),
Line 537: TYPE: str(type),
Line 538: VOLTYPE: str(voltype),


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7:

(3 comments)

https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 540
Line 541
Line 542
Line 543
Line 544
> Remove this return
Done


Line 521: def createMetadata(cls, metaId, meta):
Line 522: cls._putMetadata(metaId, meta)
Line 523: 
Line 524: @classmethod
Line 525: def newMetadata(cls, metaId, sdUUID, imgUUID, puuid, size, 
format, type,
> It might be confusing to understand the difference between newMetadata and 
Done
Line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL):
Line 527: meta = cls.makeMetadata(sdUUID, imgUUID, puuid, size, format, 
type,
Line 528: voltype, disktype, desc, legality)
Line 529: cls.createMetadata(metaId, meta)


Line 530: return meta
Line 531: 
Line 532: @classmethod
Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type, 
voltype,
Line 534:  disktype, desc="", legality=ILLEGAL_VOL):
> readability - consider moving 'voltype' to the prefix of this line...
Hmm, not really sure what you mean here.  none of the lines are too long.
Line 535: return {
Line 536: FORMAT: str(format),
Line 537: TYPE: str(type),
Line 538: VOLTYPE: str(voltype),


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 540
Line 541
Line 542
Line 543
Line 544
Remove this return


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[derez]

Daniel Erez has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 521: def createMetadata(cls, metaId, meta):
Line 522: cls._putMetadata(metaId, meta)
Line 523: 
Line 524: @classmethod
Line 525: def newMetadata(cls, metaId, sdUUID, imgUUID, puuid, size, 
format, type,
It might be confusing to understand the difference between newMetadata and 
makeMetadata methods.. Can you please add some documentation the clarify and 
explain when one should use which?
Line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL):
Line 527: meta = cls.makeMetadata(sdUUID, imgUUID, puuid, size, format, 
type,
Line 528: voltype, disktype, desc, legality)
Line 529: cls.createMetadata(metaId, meta)


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[derez]

Daniel Erez has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 530: return meta
Line 531: 
Line 532: @classmethod
Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type, 
voltype,
Line 534:  disktype, desc="", legality=ILLEGAL_VOL):
readability - consider moving 'voltype' to the prefix of this line...
Line 535: return {
Line 536: FORMAT: str(format),
Line 537: TYPE: str(type),
Line 538: VOLTYPE: str(voltype),


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches