Re: [patch] Fixed segfault from using regexes with clientserver
On Friday, August 21, 2015 at 5:31:12 PM UTC-5, James Kolb wrote: On Friday, August 21, 2015 at 1:39:10 PM UTC-4, Bram Moolenaar wrote: James Kolb wrote: The current regex code may call mch_breakcheck which can process X events. One of these events could be a remote_expr that makes its own call into the regex engine. This usually crashes because the regex engine isn't reentrant. This is probably also a problem for anything else that runs long enough to make breakchecks and isn't reentrant. This crash can usually be reproduced in linux by running vim with a --servername argument and typing the command: :call system(sleep 1 vim --servername .v:servername. --remote-expr 'substitute(string(range(5000)), \a\, \b\, \g\)' ) | call substitute(string(range(5000)), '\(,.*\)\@!,', '', 'g') The attached patch fixes the problem by preventing RealWaitForChar from processing X events if it is called from mch_breakcheck. Thanks for the patch. However, I think the proper solution would be to make the regexp code reentrant. That means getting rid of the global variables. It's been messy like that for a long time. I think your patch fixes one specific situation, but it can happen in other situations as well. I agree that the regexp code should be reentrant, but I think regexes are just one mine in a larger breakchecks-can-run-arbitrary-code minefield. Most of the places that call breakchecks don't seem to assume that they can call arbitrary vim commands. Commonly run functions like buflist_list() or searchit(), for example, can read-after-free if somebody deletes a buffer using remote-expr. Anything that calls the regex engine will have the same problem that the regex engine can call arbitrary commands, even if the regex engine were reentrant. For example: I have not found the full root cause yet, but I think I've narrowed down this crash to being caused by a --remote-expr call, which issues a echomsg command, occurring while Vim is waiting for input for tag selection: https://groups.google.com/d/topic/vim_dev/ZSfhmAKL97c/discussion One of the row variables is set to -1 when trying to display something about the selected tag, I forget exactly which variable or display call. I got involved in a different open-source project and haven't gotten back to working on the issue; I was going to save off the required message variables before processing a remote event, and restore them after, but making it re-entrant, or queuing the output from the remote call somehow, might be better. I had noticed that linked crash on Windows; it looks like your patch only touches os_unix and os_vms files. Does something similar need doing for Windows files? -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Vim is moving from Google Code to Github
On Monday, August 24, 2015 at 10:18:15 AM UTC-5, Ben Fritz wrote: On Tuesday, August 18, 2015 at 3:52:23 PM UTC-5, Quan Chau wrote: I'm really happy with this change. But are you guys moving to git to replace mercurial? I'm really sad with this change. Yes. I'm too glib. Christian is also maintaining a BitBucket mirror with Mercurial. So instructions will come out for those who want to keep using Mercurial as well. -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Vim is moving from Google Code to Github
On Tuesday, August 18, 2015 at 3:52:23 PM UTC-5, Quan Chau wrote: I'm really happy with this change. But are you guys moving to git to replace mercurial? I'm really sad with this change. Yes. -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Gnuplot Syntax Patch
Josh Wainwright wrote: Hi Christian, Well, would you volunteer to maintain this syntax file? I haven't exactly volunteered, but am more than happy to do so. Is it back to this list that I send the updated file? No, send your patches directly to Bram Moolenaar. Tell him the situation of non-contact with gnuplot's old mintainer, too. (bram AT moolenaar DOT net) Regards, Chip Campbell -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Vim has moved from Google Code to Github
Hello Vim users, The announced move is done! The cleaned up git repository is available on GitHub. You can start using it, see http://www.vim.org/git.php If you previously had synced from the Mercurial repository on Google Code, you can either just drop it and start using GitHub, or switch to the Mercurial mirror. More info here: http://www.vim.org/movetogithub.php Sorry, the section about moving to github and taking over your local changes isn't filled in yet. Hopefully you can figure it out yourself, or wait until someone provides the missing instructions. Discuss this on the vim-dev maillist. The Vim project on Google Code has been put in the project moved state. Most things should redirect to the equivalent page on GitHub. Works for issues, at least. Happy Vimming! -- BRIDGEKEEPER: What is your favorite colour? GAWAIN: Blue ... No yelloww! Monty Python and the Holy Grail PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Vim has moved from Google Code to Github
Bram Moolenaar wrote: Hello Vim users, The announced move is done! The cleaned up git repository is available on GitHub. You can start using it, see http://www.vim.org/git.php If you previously had synced from the Mercurial repository on Google Code, you can either just drop it and start using GitHub, or switch to the Mercurial mirror. More info here: http://www.vim.org/movetogithub.php Sorry, the section about moving to github and taking over your local changes isn't filled in yet. Hopefully you can figure it out yourself, or wait until someone provides the missing instructions. Discuss this on the vim-dev maillist. The Vim project on Google Code has been put in the project moved state. Most things should redirect to the equivalent page on GitHub. Works for issues, at least. Happy Vimming! Thanks Bram and thanks to those who helped migrating to Github. I've just created a pull request on Github: https://github.com/vim/vim/pull/396 Hopefully that's the right way of proposing changes now that we use github. Regards Dominique -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Vim has moved from Google Code to Github
Dominique wrote: Bram Moolenaar wrote: [...] the Mercurial mirror. More info here: http://www.vim.org/movetogithub.php Sorry, the section about moving to github and taking over your local changes isn't filled in yet. Hopefully you can figure it out yourself, or wait until someone provides the missing instructions. Discuss this on the vim-dev maillist. The Vim project on Google Code has been put in the project moved state. Most things should redirect to the equivalent page on GitHub. Works for issues, at least. Happy Vimming! Thanks Bram and thanks to those who helped migrating to Github. I've just created a pull request on Github: https://github.com/vim/vim/pull/396 Hopefully that's the right way of proposing changes now that we use github. That should be OK. Keep in mind that pull requests are a snapshot, the actual change may be different depending on when I look at it. I'll probably just use the diff (https://github.com/vim/vim/pull/396.diff) until I figure out a way to reverse my way of working. -- Q: What kind of stuff do you do? A: I collect hobbies. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Mail from Vim Github Repository
On Mo, 24 Aug 2015, Marvin Renich wrote: (I have set up an forwarding of all notifications from the vim repository to the vim-dev ml). I have started getting mail from Vim Github Repository; apparently they are pull-requests forwarded to vim-dev. I have two problems with this mail. First, the person who sent the PR isn't identified. (This was also a problem with the Vim problem tracker.) Second, the List-ID headers are different, depending, I think, on the repository where the PR originated. Here is a sample: List-ID: dyng/ctrlsf.vim ctrlsf.vim.dyng.github.com I apologize, I did cause this by not being careful enough. That happened, when commenting on an issue, while still being logged in as the vim-ml user. That shouldn't happen anymore. Ideally, I shouldn't need to log in as that user anymore. I think the fact that vim occurs at all in the list-id is purely coincidental based on the fact that the repo name contains vim. That comes from the notification mails from github. The list-id should be constant and based on the list to which I am subscribed, not the list where the message originated. One of the major purposes of the list-id and related headers, such as list-unsubscribe, is so that the recipient can identify why he/she is receiving the email and do something about it if the emails are unwanted (either because someone else subscribed him or he is no longer interested). Another purpose, which is more important to me at the moment, is that the list-id allows sorting incoming mail (at delivery time for some of us). I am not going to start rewriting mails, that are sent from github. It's just a simple forwarding, since the original github notification mail is rejected by the google groups page. (I tried to add the reply address into the reply-to, so that replies also end up at the issue tracker, but apparently, google groups clears this header completely before adding the googlegroups address.)[1] Also, vim-dev has a lot of discussion that is not directly related to PRs. I think it would be nice for the PRs to go to a separate list, such as vim-repo or vim-source. Many people who are currently subscribed to vim-dev will want to subscribe to the new list, but not all. Having the PRs separated from general development discussion would be a benefit. This could be discussed. I actually think, it is nice that issues can be discussed on this list and also we should see how much additional traffic will be created by the issue tracker. However you could filter the Header List-ID: vim/vim vim.vim.github.com to a different folder. [1] Currently there is a X-Github-Reply-To Header, which contains the reply address for github. So if replying to that address the message should show up at github. Best, Christian -- Was die neuen Unwissenden holen müssen: Tankinnenbeleuchtung -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Mail from Vim Github Repository
I have started getting mail from Vim Github Repository; apparently they are pull-requests forwarded to vim-dev. I have two problems with this mail. First, the person who sent the PR isn't identified. (This was also a problem with the Vim problem tracker.) Second, the List-ID headers are different, depending, I think, on the repository where the PR originated. Here is a sample: List-ID: dyng/ctrlsf.vim ctrlsf.vim.dyng.github.com I think the fact that vim occurs at all in the list-id is purely coincidental based on the fact that the repo name contains vim. The list-id should be constant and based on the list to which I am subscribed, not the list where the message originated. One of the major purposes of the list-id and related headers, such as list-unsubscribe, is so that the recipient can identify why he/she is receiving the email and do something about it if the emails are unwanted (either because someone else subscribed him or he is no longer interested). Another purpose, which is more important to me at the moment, is that the list-id allows sorting incoming mail (at delivery time for some of us). Also, vim-dev has a lot of discussion that is not directly related to PRs. I think it would be nice for the PRs to go to a separate list, such as vim-repo or vim-source. Many people who are currently subscribed to vim-dev will want to subscribe to the new list, but not all. Having the PRs separated from general development discussion would be a benefit. ...Marvin -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Gnuplot Syntax Patch
No, send your patches directly to Bram Moolenaar. Tell him the situation of non-contact with gnuplot's old mintainer, too. (bram AT moolenaar DOT net) Thank you for the clarification. I'm about to do that now. For the future, I've spent a while maintaining a few of my own syntax files and have learnt from the experiences of other maintainers, but there are some things that are done very differently. Are there any resources or collection of advice for those writing and/or maintaining syntax files? I use things like `b:current_syntax` and `did_*` variables, and there is some info and bits of advice in the help files, but there are some things that aren't mentioned. Thanks for your kind advice and continued work for the community. Regards, Josh. -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Mail from Vim Github Repository
* Christian Brabandt cbli...@256bit.org [150824 16:28]: On Mo, 24 Aug 2015, Marvin Renich wrote: (I have set up an forwarding of all notifications from the vim repository to the vim-dev ml). I have started getting mail from Vim Github Repository; apparently they are pull-requests forwarded to vim-dev. I have two problems with this mail. First, the person who sent the PR isn't identified. (This was also a problem with the Vim problem tracker.) Any chance this can be fixed? Is this how github works for all projects that it hosts? If so, I won't bother considering github for any of my projects unless they fix this (and I would have voiced my opinion before Vim switched if I had known). Second, the List-ID headers are different, depending, I think, on the repository where the PR originated. Here is a sample: List-ID: dyng/ctrlsf.vim ctrlsf.vim.dyng.github.com I apologize, I did cause this by not being careful enough. That happened, when commenting on an issue, while still being logged in as the vim-ml user. That shouldn't happen anymore. Ideally, I shouldn't need to log in as that user anymore. No problem. I saw three different List-ID's and jumped to the conclusion that the list-id depended on the user who sent the PR. Does that mean that in the future, all of these notifications will have list-id vim.vim.github.com? I am not going to start rewriting mails, that are sent from github. It's just a simple forwarding, Understandable. Also, vim-dev has a lot of discussion that is not directly related to PRs. I think it would be nice for the PRs to go to a separate list, such as vim-repo or vim-source. This could be discussed. I actually think, it is nice that issues can be discussed on this list and also we should see how much additional traffic will be created by the issue tracker. However you could filter the Header List-ID: vim/vim vim.vim.github.com to a different folder. If there are not too many PRs, that will be fine. If the number of PRs gets large, a separate read-only mailing list (only the PR notifications are posted, discussion referencing the PRs still happens on vim-dev) should be considered. [1] Currently there is a X-Github-Reply-To Header, which contains the reply address for github. So if replying to that address the message should show up at github. Actually, I found X-Github-Recipient-Address after sending my email. That is what I am now using. Thanks...Marvin -- -- You received this message from the vim_dev maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups vim_dev group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Mail from Vim Github Repository
El Monday 24 August 2015, Christian Brabandt escribió: I am not going to start rewriting mails, that are sent from github. It's just a simple forwarding, since the original github notification mail is rejected by the google groups page. Note that the sender name is lost as well. It's difficult to read who said what, so one would want to click on the link and read it on the web anyway. -- Alex (a.k.a. suy) | GPG ID 0x0B8B0BC2 http://barnacity.net/ | http://disperso.net
